Update http4s-client, http4s-dsl, ... to 0.21.14

Updates

org.http4s:http4s-client
org.http4s:http4s-dsl
org.http4s:http4s-okhttp-client

from 0.21.7 to 0.21.14.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-patch

Codecov Report

Merging #174 (1fdba73) into master (e31fc88) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #174   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          24      24
  Lines         234     234
  Branches        9       9
======================================
  Misses        234     234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31fc88...1fdba73. Read the comment docs.

Superseded by #180.

Superseded by #180.


WebSocketDecoderConfig.java being final limits the ability to change limits based on authorization

WebSocketDecoderConfig is currently final, which means that some aspects (eg maxFramePayloadLength) cannot be changed as a result of - for example - an Authorization header sent with the initial handshake, or with some sort of initial "login" websocket message.
I can't see any reason why this field in particular has to be final; it's not like the value for one received frame has to be identical to a frame received for a different message. If other fields really must be final over the length of a session that can be enforced, but by some other mechanism other than making this class final
I've submitted a PR to change this, in the hope it's not controversial.

For example you can see WebSocketServerProtocolHandler.handlerAdded(ChannelHandlerContext ctx).WebSocketDecoderConfig some properties of will be passed to other handler，If it is not final, it may show unexpected performance after modification. sure not limited to this methodNot limited to this method.I am understand it this way，hope to help you


pachctl port-forward says UI not enabled when it is

When running pachctl port-forward after deploying and adding the dashboard with --dashboard only, i get:
$ pachctl port-forward
Pachd port forwarded
Dash websocket port forwarded
Dash UI port forwarded, navigate to localhost:30080
CTRL-C to exit
UI not enabled, deploy with --dashboard

Pretty sure that last line should be silenced

I think this is working correctly now


Memory leak in Otsu binarization

I think there is a memory leak in the Otsu binarization: the call to the leptonica lib returns two PIX objects. One is returned to the caller and can be disposed of. The other just lingers and creates lost memory.
I fixed this in the interface function in Pix.cs: I create a temporary Pix object from the returned IntPtr's I am not interested in and then dispose of those. There is probably a better way but this works.
I found this out the hard way :)

Thanks I've identified and fixed the issue and will endeavour to release a
new release asp. Unfortunately I don't have internet at home so might take
a day or two.
On 24 Jan 2015 06:07, "landersohn"<EMAIL_ADDRESS>wrote:

I think there is a memory leak in the Otsu binarization: the call to the
leptonica lib returns two PIX objects. One is returned to the caller and
can be disposed of. The other just lingers and creates lost memory.
I fixed this in the interface function in Pix.cs: I create a temporary Pix
object from the returned IntPtr's I am not interested in and then dispose
of those. There is probably a better way but this works.
I found this out the hard way :)
—
Reply to this email directly or view it on GitHub
https://github.com/charlesw/tesseract/issues/149.

Resolved in version 2.2.

Charles,
thanks for your prompt response, great.
I have a question, though:
I have some mysterious crash:
I am running 4 threads doing OCR on 4 cameras in real time. After a
few thousand cycles suddenly something goes wrong and my camera
image bitmaps get corrupted. It appears as if the tesseract engine
alone is fine (I have separate engines for each thread) but the
binarization seems to be the culprit.
In each thread I create a local BitmapToPIXConverter and
PixToBitmapConverter, convert my bitmap to Pix, call grayscale
conversion and sauvola binarization, do my OCR and then call
pixToBitmapConverter to get it back into a bitmap.
Using always the same input bitmaps it fails at various points and
times.
Any idea about muyltithreading?

On 01/25/2015 10:56 PM, Charles Weld
  wrote:

  Closed #149.
  —
    Reply to this email directly or view
      it on GitHub.


The Sampler datapipe produces indices instead of the actual data.

🐛 Describe the bug
from torchdata.datapipes.iter import Sampler, IterableWrapper
from torch.utils.data import RandomSampler

print(tuple(Sampler(
    IterableWrapper(range(1000, 1100)),
    RandomSampler,
    sampler_kwargs={"num_samples": 3})))

produces three numbers from the 0..99 range, e.g. (11, 27, 15), but I expect it to produce three numbers from the 1000..1099 range.
Versions
torchdata 0.4.1

This is the expected behavior of Sampler.
And, for IterDataPipe, since there is no random-accessing pattern. To get sample data, you should do:
dp = IterableWrapper().shuffle().head(3)
print(tuple(dp))


Mouse motion lag from 2.7.0 onwards including Debian Bookworm's 2.10.0, no issue in 2.6.1.

Describe the bug
Odd behavior in which upgrading to Debian Bookworm (FreeRDP 2.10.0) from Bullseye (FreeRDP 2.3.0) gave rise to a connection with much more mouse movement lag to a second's delay or worse.
To Reproduce
Steps to reproduce the behavior:
Build and/or install 2.10.0 on Debian Bookworm system.
Connect, noticing mouse delay.
Build and install backwards until arriving at 2.6.1 on Debian Bookworm system.
Noticing far less (near-instaneous feedback) mouse delay similar to Debian Bullseye (2.3.0) behavior.
Expected behavior
The quick responsiveness from 2.6.1 and 2.3.0 should be similar in 2.10.0, the default Debian Bookworm package.
Application details

FreeRDP version 2.10.0, 2.6.1

Command line used:
2.10.0 (bad): xfreerdp +toggle-fullscreen +clipboard /bpp:16 /multimon /u:xxxx /v:xxxx /g:xxxx /sound /microphone:sys:alsa /log-level:trace 2>&1 | tee log.txt
2.6.1 (good): /usr/local/bin/xfreerdp +toggle-fullscreen +clipboard /multimon /u:xxxx /v:xxxx /g:xxxx /sound /microphone:sys:alsa /log-level:trace 2>&1 | tee goodlog.txt

If available the log output from a run with /log-level:trace 2>&1 | tee log.txt
2.10.0 (bad): https://www.dropbox.com/s/rur4x4gugrea1uj/log.txt?dl=0
2.6.1 (good): https://www.dropbox.com/s/65mcu7fsdfmsngj/goodlog.txt?dl=0

If you built it yourself add some notes which tag/commit/branch you have used, also your cmake parameters and
compiler can help

2.6.1: cmake -GNinja -DCHANNEL_URBDRC=ON -DWITH_DSP_FFMPEG=ON -DWITH_CUPS=ON -DWITH_PULSE=ON  -DWITH_FAAC=ON -DWITH_FAAD2=ON -DWITH_GSM=ON
Tag 2.6.1, Tag 2.7.0 for 'good' and 'bad' behavior, respectively.
Environment (please complete the following information):
Debian 12

we did not change anything related to that, only thing that could cause this (and which differs in the log) is that the newer versions try websocket transport for the gateway connection.
We´ve received reports that some server versions (or only configurations?) have suboptimal performance with that, so you might try adding /gt:http,no-websockets or /gt:auto,no-websockets and check if that fixes your issue.

Thank you, /gt:auto,no-websockets did do the trick. I appreciate you taking the time to recommend this!


Cannot upload large files when passed the @http option to stream files

I was looking for a way to work with file streams and s3, both read and write. Writing worked perfectly when using the writeStream method without any options. However, readStream did not work out of the box. When I searched for a solution I found this thread: https://github.com/thephpleague/flysystem-aws-s3-v3/issues/124
I implemented the fix suggested in this comment: https://github.com/thephpleague/flysystem-aws-s3-v3/issues/124#issuecomment-330589497
After this readStream worked perfectly, so far so good. However, after passing this option I cannot get my writeStream to work anymore. It gives me the following error:
Found 1 error while validating the input provided for the UploadPart operation:
[UploadId] is missing and is a required parameter

If I remove the option than uploading streams work perfectly again but obviously the reading isn't working anymore.
Any suggestion how to get to a situation where I can both read and write streams?
Long shot: @twistor , I know this is a long time ago but do you remember how you came up with this suggestion of including the option? I have looked through the flysystem docs, all the source and most of the aws s3 docs but I didn't find any mention of this magic.

@tstrijdhorst this sounds like a bug in the SDK. This should just work.


add to bower

please add to bower repo

I'm not familiar with what is bower repo, could you please provide more info?

Callback CREATE() function does not exist in your code.
In your documentation you have twice the EXPAND function. One have to change it COLLAPSE.

For callback create please look to the example on page:
http://gagiks.github.io/jquery-tbltree/examples/events.html
Regarding the second comment I didn't find issue in provided doc.
Thanks,
Gagik.


UI issues on product pages

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #937
Test URLs:
Fixes done:

Please reduce the size of these images
https://franklin.moleculardevices.com/products/3d-biology/3d-bioprinting-bab400-bioprinter-automation-solution.com

Remove the line separator above "Assure data integrity.."
https://franklin.moleculardevices.com/products/microplate-readers/absorbance-readers/spectramax-abs-plate-readers
https://franklin.moleculardevices.com/products/microplate-readers/acquisition-and-analysis-software/softmax-pro-software
https://franklin.moleculardevices.com/products/gxp-compliance-solutions/softmax-pro-gxp-software-installation-validation-services

Add a little space here

Before: https://main--moleculardevices--hlxsites.hlx.page/products/microplate-readers/multi-mode-readers/filtermax-f3-f5-readers
After: https://937-products--moleculardevices--hlxsites.hlx.page/products/microplate-readers/multi-mode-readers/filtermax-f3-f5-readers

Centre align "Cellular Image Gallery" text. Add space above the disclaimer text and remove the letter "S" and remove the extra asterisks.

Before: https://main--moleculardevices--hlxsites.hlx.page/products/cellular-imaging-systems/high-content-imaging/imagexpress-confocal-ht-ai

After: https://937-products--moleculardevices--hlxsites.hlx.page/products/cellular-imaging-systems/high-content-imaging/imagexpress-confocal-ht-ai

Before: https://main--moleculardevices--hlxsites.hlx.page/products/cellular-imaging-systems/high-content-imaging/imagexpress-micro-confocal
-After: https://937-products--moleculardevices--hlxsites.hlx.page/products/cellular-imaging-systems/high-content-imaging/imagexpress-micro-confocal

Fix the font size for this section-
Center align "Turnkey solutions for ..." with font h2:36 px.
"MetaXpress Application Modules" h2: 24px blue color
"Expedite image analysis and data...." h4:18px

Before: https://main--moleculardevices--hlxsites.hlx.page/products/cellular-imaging-systems/acquisition-and-analysis-software/metaxpress
After: https://937-products--moleculardevices--hlxsites.hlx.page/products/cellular-imaging-systems/acquisition-and-analysis-software/metaxpress

View Interactive Demo CTA is not working, and remove the cross button below. Add line separators here
https://franklin.moleculardevices.com/products/cellular-imaging-systems/acquisition-and-analysis-software/cellreporterxpress

Add line separator
https://franklin.moleculardevices.com/products/clone-screening/single-cell-isolation/dispencell-single-cell-dispenser

@MeghnaTewari Please clarify: Remove Request pricing CTA from the banner
The Request Pricing is on the original page on the banner too.
https://franklin.moleculardevices.com/products/flipr-penta-high-throughput-cellular-screening-system

Empty resources
https://franklin.moleculardevices.com/service-support/lab-automation-solutions/lab-automation-for-high-content-screening#resources

Remove line separator
https://franklin.moleculardevices.com/products/gxp-compliance-solutions/softmax-pro-gxp-software
https://franklin.moleculardevices.com/products/gxp-compliance-solutions/softmax-pro-gxp-software-installation-validation-services

Additional reported styling issues for Category pages (blue title, title center align, font html snippet, buttons in same row)

Before: https://main--moleculardevices--hlxsites.hlx.page/products/gxp-compliance-solutions
After: https://937-products--moleculardevices--hlxsites.hlx.page/products/gxp-compliance-solutions

Styling issues got successfully validated by Meghna


Migrate the EntityState code generation to ProtoData and move it to core-java

<This is a placeholder for a big umbrella-issue. It is created, so that we could reference it in PRs earlier.>

@armiol, I think we can keep newly introduced codegen under McJava for 2.0.
We may move this code under core-java once we have the architecture for participation of libraries in custom code generation.


Crash with other mods

Hey, I just installed your mod to my modpack, but it occasionally. I don't know why it sometimes works ^^"
This is the crash report:
https://pastebin.com/grW7FmVN

I don't know what happened.
But I think it's not my mod's bug.


Update sass.md

Highlight a the sass->css chaining syntax

@SephReed hi, v3 doesn't have a concept of chaining anymore. Please take a look at examples

Which samples?  I was looking at the docs.

I will have to close this one, if you have time please do help with v4 docs !


Epic: Upgradeable Aztec Smart Contracts

~First thing's first: decide on how we want to enable contract upgrades. Decide based on dev ease of use and a reduction in critical bugs.~
Build SetCode
Reading material:
@nventuro @spalladino is there anything you'd add, with an extra 6 months of knowledge since you wrote these docs, and in advance of discussing this topic next week?
Overview: https://forum.aztec.network/t/how-to-do-contract-upgrades-feb-2024-edition/4583
https://forum.aztec.network/t/deep-dive-into-delegatecall-proxy-upgrades/4581
https://forum.aztec.network/t/contract-upgrades-via-shared-mutable-state-slowjoe/4582
https://hackmd.io/wVLDGk5gRJaTQfFQ3YmEDA?both
old? https://forum.aztec.network/t/implementing-contract-upgrades/2570
This task list will be clearer once we decide on an approach.
### Tasks
- [ ] Decide on the approach.
- [ ] Kernel circuit changes.
- [ ] AVM changes.
- [ ] Example proxy contracts and e2e tests.

cc @dbanks12 @fcarreiro the planned approach should have only a small amount of work from AVM. Not needed for testnet launch so not including it on the milestone


Broken ExtensionType interoperability with Keras in 2.16

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
binary
TensorFlow version
v2.16.1-0-g5bc9d26649c 2.16.1
Custom code
No
OS platform and distribution
MacOS 14.4.1 (Arm)
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
The ExtensionType guide suggests that it is possible to create tf.keras.layers.Input for ExtensionTypes using the type_spec argument. This argument, however, seems to be missing in Keras 3 / TF 2.16. It is not clear how the integration with Keras should work in 2.16 (if it is even possible due to the absence of the critical argument).
Standalone code to reproduce the issue
# Taken from the guide for reference (https://www.tensorflow.org/guide/extension_type#keras):

class Network(tf.experimental.BatchableExtensionType):
  shape: tf.TensorShape  # batch shape. A single network has shape=[].
  work: tf.Tensor        # work[*shape, n] = work left to do at node n
  bandwidth: tf.Tensor   # bandwidth[*shape, n1, n2] = bandwidth from n1->n2

  def __init__(self, work, bandwidth):
    self.work = tf.convert_to_tensor(work)
    self.bandwidth = tf.convert_to_tensor(bandwidth)
    work_batch_shape = self.work.shape[:-1]
    bandwidth_batch_shape = self.bandwidth.shape[:-2]
    self.shape = work_batch_shape.merge_with(bandwidth_batch_shape)

  def __repr__(self):
    return network_repr(self)

input_spec = Network.Spec(shape=None,
                          work=tf.TensorSpec(None, tf.float32),
                          bandwidth=tf.TensorSpec(None, tf.float32))
model = tf.keras.Sequential([
    tf.keras.layers.Input(type_spec=input_spec),
    # BalanceNetworkLayer(),
    ])

Relevant log output
TypeError: Input() got an unexpected keyword argument 'type_spec'

Hi @karelhorak-gen ,

Sorry for the delay, I tried to run your code on colab using TF v2.15, 2.16.1, nightly and in 2.15 it is working fine, remaining versions getting the same issue. please find the gist here for reference.
And Please post this issue on keras-team/keras repo.
To know more see;
https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999.
Thank you!


K-Means Clustering

K-Means Clustering

Implemented K-means Clustering algorithm with all the details  mentioned

[x] DevIncept Participant

[x] Contributor

Closes: #74
Describe the changes you've made

Created and implemented a model which shows the working of the K-Means Clustering algorithm
Demo Images are added to the images folder which is used in the README.md file for explanation.
Added dataset in the Dataset folder and also added the required files.
Also, README is added with a proper and detailed explanation.

Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Once you run the model you get to know the accuracy of the model and this model can be tested with the help of a defined classifier().
Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented on my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added test cases that prove my fix is effective or that my feature works.

Only change it needs, .ipynb should be in "Model" folder. And rest all perfect. @hrugved06

Changes done :-)


[disasters] map and config improvements

More readable maps - updated colors, dot sizes, fixed droughts
Rename page
Add dates to map titles
Sort categories
Default to 1 year filter

thanks for the review!


Inherit data not only from layout.js load functions

Describe the problem
Currently parent data only comes from the layouts above, not from the pages above, which I find rather confusing. If I have a route that returns data in its +page.js load function, then it's accessible in +page.svelte - but not in a subroute of that route. For that I have to move the data loading to a brand new +layout.js file (which also means having to create a +layout.svelte file with just a <slot />).
See also https://github.com/sveltejs/kit/issues/6316.
Describe the proposed solution
Have parent data not only use the layout load tree, but also the page load tree.
Alternatives considered
Keep it as it is, with a bunch of extra files as a result, plus the confusion of why data is available in +page.svelte, but not in a subroute's +page.svelte when using parent data.
Importance
would make my life easier
Additional Information
No response

Pages are leaves, they inherit from layouts. It would be super weird if leaves inherited from other leaves. The fact that you currently have to add a +layout.svelte if you have a +layout.js is a bug, it'll be fixed soon.
Closing as works-as-intended

I think the way it works now is a bit strange. Like, let's say in a certain route you don't need a custom layout so you load some data in +page.js, together with the parent data from the parent load function. So far so good. Then you add a subroute and you want to access that same parent (page) data. But that's not possible - now you need to move the data loading to a new layout.js file, because of what's happening in a child route. It's not very logical to me. The fact that both layout and page load functions can return data, the page.svelte can use both of them, but child pages can't, is weird.
But ok, not impossible to work with it either so it is what it is.

These are distinct pages which could do very different things. Just because one is further below the file tree doesn't mean they are related. The layout is what is shown for both, so it makes sense to inherit from that and not the page.

That makes sense. Thanks!


Multicast between nodes

I've setup a simple two node cluster just to test some containers and the platform. I tried to deploy a two node hazelcast cluster, one container on each node, but as hazelcast uses multicast to discover other nodes, this traffic does not pass between nodes. If i have two container on the same node multicast works and hazelcast find the other node, if i start a new container on the second host it does not join the cluster. If I use the TCPIP joiner, specifying the other containers addresses, the cluster works.
How is routed, if it is, the multicast between nodes?

The Rancher overlay network is a set of point-to-point Layer 3 IPSec tunnels between hosts.  There is no Layer 2 capability and thus no broadcast/multicast (unless the containers happen to be on the same host, as you said).
Layer 2 networks/large broadcast domains do not scale very well across many clients and disparate physical networks.  Typically you would end up having to segment a large-ish deployment into more than one, and then you have to start worrying about if the right containers are in the same segment.  So it's really better to avoid this altogether, the whole internet is one Layer 3 network and it scales ok so far :-)
In the next release or so there will be a new rancher-metadata service that containers will be able to query to get information about themselves, the service and stack they are a part of, etc.  so you will be able to use this in a startup script to get the list of IP addresses of the other hazelcast containers in the service in an automated way.

As mentioned, we've released the metadata service, which is available in v0.35.0 and is documented here: http://docs.rancher.com/rancher/metadata-service/
Please let us know if you have other questions.


Adding support for /universe/ids/ endpoint

Hi, I'd like to add support for the /universe/ids POST endpoint.
I am working on a Rust application and need to support a way to convert character names into character IDs, and this endpoint seemed the correct way.
Is this currently being worked on, or is it something I can tackle and open a PR for?
Thank you!

Hi!
You're welcome to take a crack at it, or I can add it - your choice.

I will give it a go, thanks!

@Celeo After looking at it a bit more today, I realize I might be slightly over my head. I did not realize the /universe/ids endpoint returns it based on category (agents, alliances, characters, constellations, corporations factions, inventory_types, regions, stations, and systems), so I'm not sure the best way to parse the response.
I would guess you would need to see what type of category it returned, and then depending on that put it in the that particular result?

This is the endpoint that you POST names to, in order to resolve them to IDs, right? It looks like we just send it a list of strings and it gives back a object with optional keys that are objects with "id" and "name" pairs.
curl -X POST "https://esi.evetech.net/latest/universe/ids/?datasource=tranquility&language=en" -H  "accept: application/json" -H  "Accept-Language: en" -H  "Content-Type: application/json" -H  "Cache-Control: no-cache" -d "[  \"Celeo Servasse\",  \"Veldspar\"]"

{
  "characters": [
    {
      "id": 91316135,
      "name": "Celeo Servasse"
    },
    {
      "id": 95223939,
      "name": "Veldspar"
    }
  ],
  "inventory_types": [
    {
      "id": 1230,
      "name": "Veldspar"
    }
  ]
}

Correct! Do we need to do any parsing of the response, or is that totally on the implementer of the crate when they call it?

Nope, I'd leave interpreting the results to the caller, since they'll have a good idea of what they're expecting.

Awesome, understood.
Another question: the api_post! macro seems to call self.esi.query("GET", ... and I do not understand why that is a GET versus a POST?
Also, for /universe/ids there is only one required argument, not two. Not sure how to approach that with the api_post! macro.
Thank again for all your help.

Another question: the api_post! macro seems to call self.esi.query("GET", ... and I do not understand why that is a GET versus a POST?

Oh wow, that is super weird. I'll have to check out the functions that are using that to see if they work.

Yup, that GET should definitely be POST.

Okay, glad I'm not completely crazy! Though, it still leaves me a bit confused on how to use the macro with a single argument for the /universe/ids endpoint. Any advice there would be awesome

In the macros, you can omit the URL replacement section, like in this function:

api_post!(
    /// Get character affiliations.
    get_affiliation,
    "post_characters_affiliation",
    RequestType::Public,
    Vec<CharacterAffiliation>,
    ,
    character_ids: &[u64],
);

This would make a function that POSTed to that operation_id's endpoint, with no URL substitutions, and passing in an array of u64s.

It might help to just write a function that calls esi.query yourself first - that'll let you test that the call is actually working before needing to worry about macros (which are nice when they're done, but definitely difficult to deal with).

If you want to keep on it, please feel free. If you don't want to fuss with it, just let me know and I'll do it. Up to you!

Hi, sorry for being absent!
I am working through a few things to improve on my poor current solution, which is:
#[derive(Debug, Deserialize)]
#[allow(missing_docs)]
pub struct Ids {
    pub characters: Option<Vec<Character>>,
}

#[derive(Debug, Deserialize)]
#[allow(missing_docs)]
pub struct Character {
    pub id: u64,
    pub name: String,
}

api_post!(
        /// Get IDs from a list of names
        get_ids,
        "post_universe_ids",
        RequestType::Public,
        Ids,
        ,
        names: &Vec<String>,
    );

I know there is issues (ids shouldn't have a member characters but a more general one to wrap all categories), but I'm still picking up on serde_json and learning. Getting there though!

Looking good!

Just wondering Why you don't get the categories from sde ?

#25 opened a PR for this issue

You've solved this in #25 - thanks!


ROU-4531: Release 2.18.0 ODC

This PR is to merge the release 2.18.0

@rugoncalves can we merge this?


It's a bug not a feature! reproject if needed (not the opposite)

https://github.com/developmentseed/tipg/blob/0c0f5129fc4405e7548db5e074926bdedd995983/tipg/dbmodel.py#L385-L386
cc @bitner

this was fixed in #24


[Sticky] Rails skipping when rail higher then screen.

Hi,
The rail's seem to be skipping up when it is goes out the screen and you start scrolling. See the codepen repo here : http://codepen.io/fpoirier1/pen/mJLLMP
Am I missing something here ?

I'm not seeing the issue.  It appears to be sticking correctly. Can you clarify what you mean?

Yes, I understand for continuing to scroll when content is heigher than the screen. What I mean is if you scroll slowly, you see the rail skipping.
Like the example below, shouldn't the Stuck Content still be visible? It seems to be jumping from Item 0 to Item 6...

Sorry my screen was too tall. I'm seeing the issue now.
http://codepen.io/anon/pen/NqMZGQ

Thanks ! At first glance, when the position:fixed is not  apply the top property is subzero based on the context but when it becomes position:fixed the topproperty must be set relatively to the Window.

Scroll position is adjusted with requestAnimationFrame which means the delta has to be calculated from last scroll position. This is probably an issue with edge conditions.

JSFiddle of next
http://jsfiddle.net/38nngpww/


#83: reconnect when output goes away

Fixes #83
@LilleAila can you test to see if this fixes your suspend issue?
Was not a trivial fix, haha

That seems to have worked perfectly from my testing
https://github.com/user-attachments/assets/75499773-8aed-4a83-aed3-854e4dcfb561


[indirect-value]: add new port

[X] Changes comply with the maintainer guide
[X] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[X] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
[X] The versioning scheme in vcpkg.json matches what upstream says.
[X] The license declaration in vcpkg.json matches what upstream says.
[X] The installed as the "copyright" file matches what upstream says.
[X] The source code of the component installed comes from an authoritative source.
[X] The generated "usage text" is accurate. See adding-usage for context.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is in the new port's versions file.
[X] Only one version is added to each modified port's versions file.

The usage test passed (header files found):
The package indirect-value provides CMake targets:

    find_package(indirect_value CONFIG REQUIRED)
    target_link_libraries(main PRIVATE indirect_value::indirect_value)


Extending Gate Class

It says in the manual that “New, user-defined gates can be easily added to the code by extending the Gate class in the corresponding .cpp and .hpp files.”. Is this really enough? It seems that I also need to make changes in https://github.com/LLNL/quandary/blob/master/src/optimproblem.cpp (see, for example, lines 75-82).
I want to add a new gate which depend on a new parameter other than the ones provided in Gate class, let’s call the parameter gate_param_. Other than updating gate.hpp and gate.cpp, what else should I change?
When Quandary parses the .cfg file, will it look for gate_param and expect a list of gate parameters without further changes? If not, what should I do to define gate_param as a configuration option in .cfg file?

I think I’ve figured it out. I’ve updated the following files to define parametrized gates. I will commit the changes soon.
Files to be updated:
optimproblem.hpp
gate.hpp

optimproblem.cpp
main.cpp
gate.cpp

Great! Please create a pull request then. Thanks!


[FEA] Have a repartition fallback for hash aggregates instead of sort

Is your feature request related to a problem? Please describe.
We know that hash partitioning is faster than sorting.  In GpuHashAggregate if the intermediate values get to be too large we end up sorting the intermediate results and then doing a final pass to output the answer.
In many cases it might be good to have a heuristic in place that sees if the output got smaller so we can decide if we do https://github.com/NVIDIA/spark-rapids/issues/7404 instead.  But in the cases when we see the output is getting a lot smaller than the input or if it is not a partial aggregate, we probably should look at doing hash partitioning of the intermediate results instead of sorting the result.

is this a duplicate with https://github.com/NVIDIA/spark-rapids/issues/8391 ?

Yup I filed the same thing twice. Feel free to dupe this to the other or vise versa.

Closing this as it duplicates #8391


remove receipt verifier

gunicorn is needed for this but has been removed

r+

fwiw, it would be really nice to run the receipt verifier in docker. I had to do it a couple times for fxpay development.


Client & Job Timelines

Description
Fixes #112

No new dependencies added
Added timelines to the client and job home pages (the screenshots are in this order too)
Added the timeline endpoints to the client collection (sample curl request and response below)
Modified any pre-existing timeline-related code to dynamically adapt for more different categories
Fixed a tiny bug in GET endpoint for the client collection pertaining to await

PATCH Client Timeline Sample Curl
curl --location --request PATCH 'http://localhost:3001/api/client/64177ef559295797ab75b5cb/timeline'
--header 'Content-Type: application/json'
--data '{
"text": "wee!",
"category": "UPDATES",
"title": "Test updates",
"timestamp": "2023-3-29"
}'
PATCH Client Timeline Sample Response
Successfully updated the timeline field of client with id 64177ef559295797ab75b5cb
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have run npm run lint:fix
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (if required)
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works (Delete if frontend)

I like how the code is very neat and extendable,  👍


Fix MultipartResolver javadoc implementation refs

Before this fix MultipartResolver javadoc mentioned that there is only
one concrete implementation included in Spring. This was true as of
Spring 2.5 but Spring 3.1 added another one, Servlet 3.0 Part API based
implementation.
This fix changes MultipartResolver javadoc so that the other one,
StandardServletMultipartResolver implementation, gets also listed.
Changed javadoc mentions also as of which version does Spring bundle
two MultipartResolver implementations.
Issue: SPR-5984
I have signed and agree to the terms of SpringSource Individual Contributor License Agreement.

Stevo can you re-send the request based on the master branch? That's the main branch in use now with selective backports only going back to 3.1.x. Thanks!

@rstoyanchev Created new one, master branch based pull request #48


Create book file, add Book class.

Changes:

Create a book file into the classes folder.

Add Book class to the book file.

The book class inherits from the Item superclass

Add method can_be_archived? that gets the value from the parent can_be_archived? and override it.

Status Approved 🚀  🟢
Hi, @jchernandez87 nice job implementing the requirements for this milestone.
Your project is complete, feel free to merge it!


Cygwin Build Error -- gcc: error: unrecognized command line option ‘-rdynamic’

Platform: Windows 7 x64
Cygwin version: 1.7.35 x64
config.log: https://cryptobin.org/w6l691z0

password: allinurl-goaccess-config.log

make log: https://cryptobin.org/x851d2j0

password: allinurl-goaccess-make.log

Let me know if you have any questions. Thanks!

Thank you for reporting it, I'm looking into this, I'll follow up as soon as I figure out what's the issue.

Interesting, when I tried it myself, the build succeeded:
gcc (GCC) 4.9.2,
uname -m = i686
uname -r = 1.7.35(0.287/5/3)
uname -s = CYGWIN_NT-6.1
uname -v = 2015-03-04 12:07

However, my build does not compile with -rdynamic. If you run $ ldd --version what output do you get? Thanks.

$ ldd --version ldd (cygwin) 1.7.35 Print shared library dependencies Copyright (C) 2009 - 2015 Chris Faylor This is free software; see the source for copying conditions.  There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
It looks like you're compiling with the 32-bit version of GCC whereas I'm using the 64-bit version. Let me know if you have any questions.

This has been fixed. Feel free to build from dev.
Let me know how it goes. I'll push this in the upcoming version. Thanks!

The fix works. It compiles now. Thanks!


Fix final type problems

Fixes final type issues, all CI checks should be green.

adds a bunch of .?
moves PR modal to seperate class
tests and refactors title checking

follows structure from https://github.com/oleeskild/obsidian-digital-garden/pull/397 so should rebase nicely.
after this is in enforcing type-passing becomes easy!

Tremendous work the last couple of days! Thank you!
Had to merge this in manually due to merge conflixts, so closing this PR.

@oleeskild thanks! don't know what's gotten into me, have been doing quality things at work this week so you'd think that this is the last thing I'd want to do, but there's something soothing about refactoring


ResGen Cache Serialization Fix

Update ResGen Serailization Compat for RTM and U1
07e17f6 When reverting the CodeFormatter private field name changes (#314), the Dependencies class was missed. This causes an incompatability going from  Update 1 back to RTM and causes a null ref. This change fixes the compat issue (rename the field) and updates the serialization version to ensure U1 -> U2 works as expected.
Rename field for internal build.
c863538 Looks like the field was renamed for STANDALONEBUILD but not otherwise.Correcting this.

LGTM, except you misspelled "serialization" in the commit message.


Add unlearning API

Each ReChorus instance should know how to unlearn a (u, i) pair. Input (u, i) pair to be unlearned and perform unlearning.

unlearning API added in pull request #15


problem with verilator

Hi. I tried to re run your project but Verilator simulator dose not work properly. which version did you use?
Is there any way to provide me with working version?
best regards

Hi @H0sseinR0stami, the Verilator version we used to test was Verilator 4.038 2020-07-11 rev v4.038. It should be available on Verilator's official website/package repository. Try this URL for instance: https://repology.org/project/verilator/versions.
Thanks,
Aebel

Dear colleagues, I probably have similar issue. I've successfully installed VeRLPy through pip, but when I try to make the axi_fabric_rl example, I receive the following:
ODULE=test_axi_fabric TESTCASE= TOPLEVEL=mkaxi4_fabric_test TOPLEVEL_LANG=verilog \
         sim_build/Vtop
     -.--ns INFO     cocotb.gpi                         ..mbed/gpi_embed.cpp:76   in set_program_name_in_venv        Did not detect Python virtual environment. Using system-wide Python interpreter
     -.--ns INFO     cocotb.gpi                         ../gpi/GpiCommon.cpp:99   in gpi_print_registered_impl       VPI registered
     0.00ns INFO     Running on Verilator version 4.226 2022-08-31
     0.00ns INFO     Running tests with cocotb v1.6.2 from /home/ssedai/.local/lib/python3.8/site-packages/cocotb
     0.00ns INFO     Seeding Python random module with<PHONE_NUMBER>
     0.00ns CRITICAL Failed to import module test_axi_fabric: No module named 'cocotb.drivers'
     0.00ns INFO     MODULE variable was "test_axi_fabric"
     0.00ns INFO     Traceback:
     0.00ns INFO     Traceback (most recent call last):
                       File "/home/ssedai/.local/lib/python3.8/site-packages/cocotb/regression.py", line 172, in _discover_tests
                         module = _my_import(module_name)
                       File "/home/ssedai/.local/lib/python3.8/site-packages/cocotb/regression.py", line 66, in _my_import
                         mod = __import__(name)
                       File "/home/ssedai/.local/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 168, in exec_module
                         exec(co, module.__dict__)
                       File "/home/ssedai/ai/VeRLPy/examples/axi4_fabric_rl/test_axi_fabric.py", line 6, in <module>
                         from test_axi_fabric_helper import *
                       File "/home/ssedai/.local/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 168, in exec_module
                         exec(co, module.__dict__)
                       File "/home/ssedai/ai/VeRLPy/examples/axi4_fabric_rl/test_axi_fabric_helper.py", line 3, in <module>
                         from cocotb.drivers import BusDriver
                     ModuleNotFoundError: No module named 'cocotb.drivers'

/usr/lib/python3/dist-packages/apport/report.py:13: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
  import fnmatch, glob, traceback, errno, sys, atexit, locale, imp, stat
Traceback (most recent call last):
  File "/home/ssedai/.local/lib/python3.8/site-packages/cocotb/__init__.py", line 242, in _initialise_testbench
    _initialise_testbench_(argv_)
  File "/home/ssedai/.local/lib/python3.8/site-packages/cocotb/__init__.py", line 344, in _initialise_testbench_
    regression_manager = RegressionManager.from_discovery(top)
  File "/home/ssedai/.local/lib/python3.8/site-packages/cocotb/regression.py", line 147, in from_discovery
    return cls(dut, tests)
  File "/home/ssedai/.local/lib/python3.8/site-packages/cocotb/regression.py", line 126, in __init__
    for test in tests:
  File "/home/ssedai/.local/lib/python3.8/site-packages/cocotb/regression.py", line 172, in _discover_tests
    module = _my_import(module_name)
  File "/home/ssedai/.local/lib/python3.8/site-packages/cocotb/regression.py", line 66, in _my_import
    mod = __import__(name)
  File "/home/ssedai/.local/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 168, in exec_module
    exec(co, module.__dict__)
  File "/home/ssedai/ai/VeRLPy/examples/axi4_fabric_rl/test_axi_fabric.py", line 6, in <module>
    from test_axi_fabric_helper import *
  File "/home/ssedai/.local/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 168, in exec_module
    exec(co, module.__dict__)
  File "/home/ssedai/ai/VeRLPy/examples/axi4_fabric_rl/test_axi_fabric_helper.py", line 3, in <module>
    from cocotb.drivers import BusDriver
ModuleNotFoundError: No module named 'cocotb.drivers'
     0.00ns ERROR    Failing test at simulator request before test run completion: Simulator shutdown prematurely
- /home/ssedai/.local/lib/python3.8/site-packages/cocotb/share/lib/verilator/verilator.cpp:118: Verilog $finish
ERROR: results.xml was not written by the simulation!

I've tried to use Verilator  4.038, but cocotb requires Verilator 4.106 or later. Verilator 4.106 gives me the error I've described above.

Sorry, I missed top error message. The cause is that some modules in cocotb are migrated from cocotb package to cocotb_bus package. Being fixed, AXI example runs properly:)

Thanks @ssmolov for pointing it out and raising the pull request for the fix! :)
Links to the breaking changes for future reference: https://github.com/cocotb/cocotb/pull/2289 , https://docs.cocotb.org/en/stable/release_notes.html#id14
Closing this issue since it seems resolved unless there are any other concerns.


Test release

PR for debugging build.yml which will be closed in favor of an eventual PR against main.

Closing for #32.


⚠ TV Manager has degraded performance

In c32f34d, TV Manager ($SITES_URL_TV_MANAGER) experienced degraded performance:

HTTP code: 523
Response time: 1140 ms

Resolved: TV Manager performance has improved in 58aeae2 after 20 minutes.


docs: Set service version to 3.2.0 in API documents

Closes #4841

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[X] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[X] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[ ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.63%. Comparing base (6c68246) to head (0736188).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4842   +/-   ##
=======================================
  Coverage   40.63%   40.63%
=======================================
  Files         109      109
  Lines       10427    10427
=======================================
  Hits         4237     4237
  Misses       5828     5828
  Partials      362      362

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: support setting the KV cache quant type

WIP
Testing adding configuration to allow setting the KV cache type re: #5091

Allow setting the KV cache type in the env and params.
Allow setting flashattention in params (as well as the existing env).

Hmm, seems to crash out when doing this through Ollama, perhaps there's something I've missed?
>>> /set parameter cache_type_k q4_0
Set parameter 'cache_type_k' to 'q4_0'
>>> /set parameter cache_type_v q4_0
Set parameter 'cache_type_v' to 'q4_0'
>>> tell me a joke
Error: llama runner process has terminated: signal: aborted (core dumped)
...

llm_load_tensors: offloaded 29/29 layers to GPU
llm_load_tensors:        CPU buffer size =   182.57 MiB
llm_load_tensors:      CUDA0 buffer size =   549.39 MiB
llm_load_tensors:      CUDA1 buffer size =   658.72 MiB
llama_new_context_with_model: n_ctx      = 32768
llama_new_context_with_model: n_batch    = 4096
llama_new_context_with_model: n_ubatch   = 512
llama_new_context_with_model: flash_attn = 1
llama_new_context_with_model: freq_base  = 1000000.0
llama_new_context_with_model: freq_scale = 1
llama_kv_cache_init:      CUDA0 KV buffer size =   135.00 MiB
llama_kv_cache_init:      CUDA1 KV buffer size =   117.00 MiB
llama_new_context_with_model: KV self size  =  252.00 MiB, K (q4_0):  126.00 MiB, V (q4_0):  126.00 MiB
llama_new_context_with_model:  CUDA_Host  output buffer size =     0.59 MiB
llama_new_context_with_model: pipeline parallelism enabled (n_copies=4)
llama_new_context_with_model:      CUDA0 compute buffer size =   344.01 MiB
llama_new_context_with_model:      CUDA1 compute buffer size =   439.77 MiB
llama_new_context_with_model:  CUDA_Host compute buffer size =   259.02 MiB
llama_new_context_with_model: graph nodes  = 875
llama_new_context_with_model: graph splits = 3
GGML_ASSERT: /go/src/github.com/ollama/ollama/llm/llama.cpp/ggml-cuda/fattn-common.cuh:97: K->type == GGML_TYPE_F16
time=2024-06-17T13:15:35.247Z level=INFO source=server.go:590 msg="waiting for server to become available" status="llm server not responding"
time=2024-06-17T13:15:36.063Z level=INFO source=server.go:590 msg="waiting for server to become available" status="llm server error"
time=2024-06-17T13:15:36.313Z level=ERROR source=sched.go:388 msg="error loading llama server" error="llama runner process has terminated: signal: aborted (core dumped) "
[GIN] 2024/06/17 - 13:15:36 | 500 |  9.220745669s |       <IP_ADDRESS> | POST     "/api/chat"
time=2024-06-17T13:15:41.443Z level=WARN source=sched.go:575 msg="gpu VRAM usage didn't recover within timeout" seconds=5.12908724 model=/home/llm/.ollama/models/blobs/sha256-58148c0e3025b575e546f9b58d1bd0e451c5ae9533c1ff15a94145061cd02538

@sammcj thanks for the PR. It did indeed crash for me as well, I'm not sure if all runtimes support the quantized kv cache (cuda, metal, etc)

Yeah I gave it a red hot go but didn't get anywhere :( oh well, maybe in the future.


Don't expose custom user stuff or middlewares

Paired with https://github.com/bugsnag/bugsnag-laravel/pull/135.


Directives of the config/voyager.php file not working

Laravel Version: 5.5.40
Voyager Version: 1.1.0
PHP Version: 7.0.29
Database Driver & Version:

Description:
Hi I'm trying to modify the directives in the config/voyager.php but I find that the changes I make do not reflect on the admin page. For instance, I removed the 'migrations and data_rows' as shown in the image below this should've resulted in these tables appearing on the admin panel, however that's not the case

Steps To Reproduce:

My first question would be "why".. shouldn't be any reason to show those tables in Voyager.
In either case, back to your question.  Are your views or config cached? Try running the various clear artisan commands.  Also, make sure you're editing the right file (not the one under vendor)

Many thanks for that, it has worked. Like you said I was modifying the voyager.php in the vendor folder. In any case I'm a novice and was just trying to familiarize

No problem. Just remember you should never have to modify anything under vendor

Thanks again


"Loading" and "No data" messages

In the graphical display and the tabular display, it would be good to have a "Loading" message while the data is being loaded so the user knows that something is happening.
When the loading is finished, if there is no data to show in the displayed area, the tabular display should also show a "No data in this region" or some sort of other message.
May need to add a loading status flag to the client data store.

Possible implementation for loading message:

Add "loadingRegions" as a Region[] to volatile section of packages/jbrowse-plugin-apollo/src/session/ClientDataStore.ts
In loadFeatures in that same file, add currently loading region to "loadingRegions" at the beginning of the action and remove it at the end
In packages/jbrowse-plugin-apollo/src/LinearApolloDisplay/components/LinearApolloDisplay.tsx, check the currently loading regions (via session.apolloDataStore.loadingRegions) and the displayed regions (via model.displayedRegions), and if any of them overlap, add a "Loading..." message to the component

The loading message can be in the corner of the track and overlap the regular track area, since it may still be loading new data when there is already data on the screen

I'll have to think more about the "No data" message


Fixed the bug in PerfCompare

Issue: https://github.com/AdoptOpenJDK/openjdk-test-tools/issues/227

bug fixed

Signed-off-by: sophiaxu0424<EMAIL_ADDRESS>

Is there any more comments/ need updates here? @llxia

May I ask for a review for this PR  @llxia, thanks!


cy.json (); height and width do not change

Dear Team,
when I resize node with cytoscape-node-editing grapples the height and width data are not up-to-date. After using grapples, I try to read the current data, for example with below code:
document.getElementById('save').addEventListener('click', function() {   json = cy.json();   console.log('Nodes:', cy.nodes().jsons());   console.log('Edges:', cy.edges().jsons( ));
but I can always see the data before resizing.

Could you please check it ?

I think, those width and height properties in your data are added by your application, because nodes in Cytoscape.js don't have width or height in their data by default and this extension also doesn't add those properties. This extension only changes css(style) width and height values on resize. If you want to update width and height properties in your data as well, you can use events provided by this extension. For example, you can use resizeend event to update the width value in node's data based on the new width value in node's css.

@hasanbalci Thank you for your response.
I appreciate your support.


(Bug) Unable to drag items to other inventories

With the new 5.11.0, there is a bug with dragging items to different inventories, be it the party stash, or other player sheets. The item shows up on the new sheet only while you have it open, but bulk is not opened, and the item is not usable, and goes back to the original sheet upon closing and opening the sheets again.

Duplicate of #12231


Add scrollToHash setting

Usually, scrollNav will try to scroll to window.location.hash. But with hash-based navigation, which is used by Backbone.js and other Javascript frameworks, it will lead to errors, because it will try to scroll to, for example, #about/contribute, which is absolutely wrong element selector.
This pull request keeps original behavior, but allows to disable scrolling to an element which ID is equal to window.location.hash

Finally taking a look at this. Looks great @Borzik but I don't work on Backbone or Angular projects too often so I have nothing to test this with. @OmarKhanfer, can you test this on your single page app you referenced in #54? I'd appreciate a feedback before merging it in. Thanks.

The only thing that update does is allows to turn off scrolling to #id found in window.location.hash. So to test it you don't even need to have Backbone application. But I can provide a simple Backbone page to you if you want to test it.

Ah, sorry, I looked at it so quickly I didn't realize it's just a toggle for the auto-scrolling to location hash. Let me merge this locally and get a release together. Thanks again.


Comparing == null does not work as type guard when explicitNullChecks is disabled

TypeScript Version:  2.6.1
Code
(with "strictNullChecks" disabled)
function foo(value: number | null | undefined): string | null | undefined {
    if (value == null) {
        return value;
    }

    return value.toString();
}

Expected behavior:
Compile without errors.
Actual behavior:
"Type 'number' is not assignable to 'string'" at the "return value" line

Enabling "strictNullChecks" causes the code to compile without error, but I unfortunately cannot enable strictNullChecks in my project due to a 3rd party typescript library that was not designed with structNullChecks.

To clarify, I would expect that double equal (==) comparison to null would act as a type guard that confirms to the compiler that the value must be either null or undefined. I would expect this regardless of whether "strictNullChecks" is enabled.

When --strictNullChecks is not enabled, every type implicitly includes null and undefined. Therefore, from a type level perspective, the function
declare function foo(value: number | null | undefined): string | null | undefined;

is equivalent to
declare function foo(value: number): string;

The only difference is that the former is more self-documenting.

@mhegazy Could you explain how this is "working as intended"?
Inside the "if (value == null)", value is guaranteed to not be a number. It is guaranteed to be only null or undefined. null and undefined are both valid return types/values regardless of whether I explicitly list "| null | undefined" as return types, or if they are implied due to implicitNullChecks being disabled. S ohow is it "intended" that the compiler complains that "Type 'number' is not assignable to 'string'", when the value most certainly is not a number?

When --strictNullChecks is not enabled, every type implicitly includes null and undefined.

see https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#null--and-undefined-aware-types for more details.

I understand that every type implicitly includes null and undefined. How is that related to the compiler error I am experiencing?
I am returning "value" from within an if block that checks if "value == null". "value" is therefore guaranteed to be null or undefined - NOT a number. Why is the compiler complaining that number cannot be assigned to string?
The value I am returning is either null or undefined. The return type of the function allows both null and undefined. What is the problem?

Maybe this will clarify my confusion. With "strictNullChecks" disabled, this code compiles:
function foo(value: number): string {
    if (value === null) {
        return null;
    }

    return value.toString();
}

But this code causes a compiler error:
function foo(value: number): string {
    if (value === null) {
        return value;
    }

    return value.toString();
}

Why is this "intended"? Shouldn't I expect that type guards should work?

To say that every type implicitly includes null and undefined, means that null and undefined are valid values of type number just like 1 and 2.
So when --strictNullChecks is not enabled the following code will typecheck
const x: null = null;

const y: number = null;

foo(x);

foo(y);

declare function foo(x: number): void;

It typechecks because null is a number.

This sounds like you are providing insight into some technical implementation details that cause the behavior to be what I am experiencing, but it does not explain why this is the "intended" behavior.
To further the confusion, this causes a compiler error with strictNullChecks disabled:
function foo(value: number): string {
    if (value === null) { // not acting as a type guard
        // compiler still thinks "value" is of type "number" rather than type "null"
        return value;
    }

    return value.toString();
}

but this is perfectly valid:
function isNull(value: any): value is null {
    return value === null;
}

function foo(value: number): string {
    if (isNull(value)) { // custom type guard works as expected
        // Compiler knows that "value" is of type "null"; not a "number"
        return value;
    }

    return value.toString();
}

function bar(value: number): string {
    if (isNull(value)) {
        // Even with custom type guard forcing the compiler to understand "value"
        // is REALLY "null", it's still valid to pass as a number param to foo().
        // So why can't (value === null) work the same as isNull(value)
        return foo(value);
    }

    return value.toString();
}

This seems very inconsistent.

@aluanhaddad @mhegazy  Please review my previous comment. I believe this most clearly demonstrates what I perceive as incorrect/inconsistent behavior. Is there an "intentional" reason that the behavior of "=== null" cannot be updated to produce the same outcome as my custom "isNull" typeguard in my previous example?
The behavior around my "isNull" custom type guard is exactly what I expected when using "=== null".

This sounds like you are providing insight into some technical implementation details that cause the behavior to be what I am experiencing, but it does not explain why this is the "intended" behavior.

Actually, it's quite the opposite. What I was explaining was the conceptual reason for the behavior not the implementation.
Imagine null represents the empty set. For any set A, it is meaningless to check if the empty set is a subset of A as it is true by the definition of a set.

That completely makes sense to me... however, it also seems completely irrelevant to the issue I am highlighting. Let's break this down simply into what I am seeing:

In strictNullChecks=false mode, null is implicitly a valid value for all data types.
Inside of the if (value === null) block, it is quite clear that the value is, in fact, null.
Given 1. and 2. above, it does not make sense that the compiler will not allow me to return the value as a string (which implicitly allows null as a value).

If I return a literal null, there's no compiler error, because null is a valid value for string. So why can't I return my number "value" variable from within an if block that explicitly confirms that the value is null?
If I write my own custom type guard that explicitly tells compiler that the value is null, then I get the behavior I expect. Why does the built-in equality operator with a literal null value NOT tell the compiler that the value is null? It is a very direct and explicit test of whether the value is null.
I also noticed that the compiler does not complain at all if I try to access properties from within my if (value === null). How could this possibly be "working as intended"?
function foo(value: number): string {
    if (value === null) { // not acting as a type guard
        // compiler lets me access properties of a null value.
        return value.toString(16);
    }

    return value.toString();
}

@UselessPickles based on your description, what you're missing is how pre-strictNullChecks checking works.
With SNC off, there is no distinction about whether a value is null or not. There's no distinctions, anywhere, about what null means, whether something has been determined to be null or not, or when something may or may not be null. It's just completely untracked; type guards checking for null do nothing.

@RyanCavanaugh Thanks! The historical behavior helps make sense of this. However, none of the documentation I have found about "strictNullChecks" explains this. It is only described in terms of forcing you to explicitly specifying null/undefined types where null/undefined should be allowed.
I would now agree that "strictNullChecks=false" is "working as intended" in the "pre-strictNullChecks" era, but not "working as one would expect" in the "post-strictNullChecks" era.
A couple potential options:

Improve documentation of "strictNullChecks" to more clearly explain this behavior (with historical context) when it is disabled. This is the simplest bare-minimum improvement that can be made if none of the following options are reasonable.
Improve behavior of "strictNullChecks=false" to track type guards for null/undefined so that it works as one without historical knowledge would expect. On the surface, this seems like a mostly non-breaking change. The only breaking change I know of so far is my previous example, where the compiler would error on an obvious attempt to access properties of a value that is obviously null due to an explicit type guard.
If retaining backward compatibility is important, maybe add a 3rd option so that users can choose between "old pre-strictNullChecks" behavior, reasonable/expected behavior for "strictNullCHecks=false", and, of course, current "strictNullChecks=true" behavior.

On the surface, this seems like a mostly non-breaking change. The only breaking change I know of so far is my previous example, where the compiler would error on an obvious attempt to access properties of a value that is obviously null due to an explicit type guard.

The problem here is detailed in #9998 - we would break a decent amount of working non-SNC code that relies on distant side effects to invalidate a null guard


Keyboard-only outlines

After discussion with @samitron7

@pbakaus / @barklund I added a utility that polyfills :focus-visible, please review again if possible

@dvoytenko since @barklund is out could you please take a look at this?


show summary does not correctly apply all filters

Bug description
In the changes introduced in #28057 (code), all parameters are discarded when passing extras. However, the custom SQL filters are set within the extras, leading to an issue where the show summary feature does not correctly apply these filters, as illustrated in the attached image.
How to reproduce the bug

Set the filter using custom SQL.
Select the show summary option.
Observe that the summary of the query results does not apply the filter.

Screenshots/recordings

Superset version
master / latest-dev
Python version
3.10
Node version
18 or greater
Browser
Chrome
Additional context
No response
Checklist

[ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
[X] I have searched the GitHub issue tracker and didn't find a similar bug report.
[X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

My version is already 4.1.0rc2.

@dosu
@mapledan  is correct.
The bug is at
https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts#L204 for time comparison where the extras args is cleared when it has timeoffsets. The keeps any custom sql filters from being included in the generated query.
It is the similar for Show summary where the extraQueries doesn't include the extras args assuming it is only for time grains.
https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts#L242

Thanks for reporting this @mapledan! I assigned it to me so I can work on a fix for it

Just for reference, take a look at this discussion: https://github.com/apache/superset/discussions/29297

Hi @Antonio-RiveroMartnez. My main objective in sharing that discussion is to highlight that the Summary will not necessarily match what's displayed in the table because of limits/pagination constraints. That being said, we still need to fix the issue reported here.

does that means only the tooltip was to change and the computation must remain as is -- except for the extras that will be fixed as part of this issue --?

Exactly.


Plugin does not work with PowerToys 0.79

It does show me the error "Fail to load plugin: Spotify"
I looked in the log and found the follwing entry:
[2024-03-05 10:37:28.8841] [ERROR] [C:\a\_work\1\s\src\modules\launcher\Wox.Plugin\PluginPair.cs::191]
-------------------------- Begin exception --------------------------
Message: Can't find class implement IPlugin for <Spotify> in C:\Users\smart\AppData\Local\Microsoft\PowerToys\PowerToys Run\Plugins\PowerToys-Run-Spotify\PowerToys-Run-Spotify.dll

Exception full name  : System.InvalidOperationException
Exception message    : Sequence contains no matching element
Exception stack trace:
   at System.Linq.ThrowHelper.ThrowNoMatchException()
   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
   at Wox.Plugin.PluginPair.CreatePluginInstance()
Exception source     : System.Linq
Exception target site: Void ThrowNoMatchException()
Exception HResult    : -2146233079
-------------------------- End exception --------------------------```

Fixed in https://github.com/waaverecords/PowerToys-Run-Spotify/releases/tag/v0.79.0.

Great!
It's working now also for me.
Have a nice day!


[HOWTO] Make project search popup window permanent?

What I want to achieve
When pressing SPC / p, how do I make that window permanent (e.g. move it to the right side), so I can check through matches without having to re-type my search pattern and memorize last selected match?
System information

emacs   version    26.3
        features   XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2
        build      Aug 29, 2019
        buildopts  (--prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now)
doom    version    2.0.9
        build      HEAD -> develop d866ee37 2019-09-10 15:01:00 -0400
system  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /usr/bin/zsh
        uname      Linux 5.2.13-arch1-1-ARCH #1 SMP PREEMPT Fri Sep 6 17:52:33 UTC 2019 x86_64
        path       (~/code/js/contact-keeper/client/node_modules/.bin/ /usr/local/bin /usr/bin /bin /usr/local/sbin /usr/lib/jvm/default/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl ~/.npm-packages/bin ~/.config/composer/vendor/bin /usr/lib/emacs/26.3/x86_64-pc-linux-gnu)
config  envfile    nil
        elc-files  0
        modules    (:completion company ivy :ui doom hl-todo indent-guides modeline nav-flash ophints (popup +all +defaults) treemacs vc-gutter vi-tilde-fringe window-select workspaces :editor evil file-templates fold multiple-cursors rotate-text snippets :emacs dired electric vc :term eshell :tools eval flycheck (lookup +docsets) magit :lang cc data emacs-lisp javascript lua markdown (org +dragndrop +ipython +pandoc +present) php sh web :config default)
        packages   (n/a)
        elpa-packages (n/a)

In M-x it says +popup/raise is bound to C-~ but in the active rg search window it says C-~ is undefined.

I've manually mapped C-~ to +popup/raise
(map!
 (:map ivy-mode-map
   "C-~" #'+popup/raise))

But it says Cannot raise a non-popup window, yet I don't know how to move the search window to the right or switch to other window without closing the search. None of SPC, M-SPC, C-w work and I couldn't find anything useful in C-x or C-c.

@sooqua
C-c C-o
You can also run SPC ' to resume last search if you close the window.

@zuchmanski Bookmarked. Thanks!


Bugfix: Animation direction tooltips showing for enabled direction

Context
Found while prepping for bug bash.
Summary
Tooltips were showing up for enabled direction.
Relevant Technical Choices
A prop was getting the wrong name - needed isDisabled not disabled. Also turning cursor to default when direction is disabled.
To-do

User-facing changes
Tooltips on animation direction should now only show up for disabled directions.
Testing Instructions
See that only disabled directions in animation panel show tooltips.
QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[ ] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[ ] I have added documentation where necessary
[ ] I have added a matching Type: XYZ label to the PR

Fixes #

@csossi this is from bugbash today and needs to be done for release, if you could prioritize it that would be super helpful!

Em, max, samuel and miina all reviewed and tested this bugfix which feels like a pretty thorough qa, since we want it for release I'm going to go ahead and merge.


min ||Ax-b||_2 with linear constraints

Hi All,
I am wondering if spark-tfocs solves a linear regression problem with linear constraints.  i.e.
min ||Ax-b||_2^2
s.t. Ux<=b
where U is a matrix?
I know that it would solve without those constraints, but not sure if it handles the constraints.

Hi mutmurat, unfortunately TFOCS for Spark does not support quadratic programming out of the box. However if your constraints happen to be very simple ranges you may be able to implement them using projection operators. (For example see the ProjBox operator.)

staple, thank you for the answer.

Hi  can you please help me set up contraints lasso in py spark?


Update building-from-source.md

Update the page to be consistent with the concepts template.

Updated the page to be consistent.

/assign zhangxiaoyu-zidif
Please review the changes i made at: https://deploy-preview-12577--kubernetes-io-master-staging.netlify.com/docs/setup/release/building-from-source/ and let me know if any changes need to be made.

@VineethReddy02 Hey there! 👋 thanks for the contribution. On first glance, it's a little hard for me to tell what you are achieving here. Is it just to change the look/feel? It seems like some language is also changed here

Hi Zach!
In This PR Building from Source is repetitive, would like to update it to Building a release.  Considering better understanding and eliminating redundancy in docs! :)

Yep! Makes more sense. Thanks!
/lgtm
/approve


Update GettingStarted.md

Small contribution for those who using zsh instead bash on their macOS:
In case if user using zsh filename should be different

Wrong edit


内存泄露警告

场景：tomcat8运行的状态下修改log4j.properties文件触发了tomcat重新载入编译
控制台输出：
四月 26, 2017 9:43:17 上午 org.apache.catalina.core.StandardContext reload
信息: Reloading Context with name [/pms] has started
四月 26, 2017 9:43:17 上午 org.apache.catalina.core.ApplicationContext log
信息: Closing Spring root WebApplicationContext
2017-04-26 09:43:17:957 [AbstractApplicationContext.java:816] [ContainerBackgroundProcessor[StandardEngine[Catalina]]:41844]-[INFO] Closing org.springframework.web.context.support.XmlWebApplicationContext@35a7795: display name [Root WebApplicationContext]; startup date [Wed Apr 26 09:42:36 CST 2017]; root of context hierarchy
2017-04-26 09:43:17:957 [DefaultSingletonBeanRegistry.java:396] [ContainerBackgroundProcessor[StandardEngine[Catalina]]:41844]-[INFO] Destroying singletons in org.springframework.beans.factory.support.DefaultListableBeanFactory@1ce68e56: defining beans [dataSource,sessionFactory,txManager,txAdvice,druid-stat-interceptor,druid-stat-pointcut,org.springframework.aop.config.internalAutoProxyCreator,mypointcut,org.springframework.aop.support.DefaultBeanFactoryPointcutAdvisor#0,org.springframework.aop.support.DefaultBeanFactoryPointcutAdvisor#1,loginInterceptor,baseDao,menuDao,operatorDao,rolelistDao,basicinfoDao,basickindDao,payrecordDao,insuredDao,productDao,distribDao,companyDao,messageApiDao,menuService,operatorService,rolelistService,basicinfoService,basickindService,payrecordService,payService,companyService,productService,insuredService,distribService,ncExample,messageApiService,loginAction,menuAction,operatorAction,rolelistAction,basickindAction,basicinfoAction,payrecordAction,payAction,productAction,companyAction,insuredAction,distribAction,cxf,org.apache.cxf.bus.spring.BusWiringBeanFactoryPostProcessor,org.apache.cxf.bus.spring.Jsr250BeanPostProcessor,org.apache.cxf.bus.spring.BusExtensionPostProcessor,apiPayService,restServiceContainer,authenticationFilter,jsonProvider,jsonTypes,jsonKeys]; root of factory hierarchy
2017-04-26 09:43:17:959 [AbstractSessionFactoryBean.java:246] [ContainerBackgroundProcessor[StandardEngine[Catalina]]:41846]-[INFO] Closing Hibernate SessionFactory
2017-04-26 09:43:17:959 [SessionFactoryImpl.java:769] [ContainerBackgroundProcessor[StandardEngine[Catalina]]:41846]-[INFO] closing
四月 26, 2017 9:43:17 上午 org.apache.catalina.loader.WebappClassLoaderBase clearReferencesJdbc
警告: The web application [pms] registered the JDBC driver [com.alibaba.druid.proxy.DruidDriver] but failed to unregister it when the web application was stopped. To prevent a memory leak, the JDBC Driver has been forcibly unregistered.
四月 26, 2017 9:43:17 上午 org.apache.catalina.loader.WebappClassLoaderBase clearReferencesJdbc
警告: The web application [pms] registered the JDBC driver [com.mysql.jdbc.Driver] but failed to unregister it when the web application was stopped. To prevent a memory leak, the JDBC Driver has been forcibly unregistered.
四月 26, 2017 9:43:17 上午 org.apache.catalina.loader.WebappClassLoaderBase clearReferencesThreads
警告: The web application [pms] appears to have started a thread named [MySQL Statement Cancellation Timer] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread:
java.lang.Object.wait(Native Method)
java.lang.Object.wait(Object.java:502)
java.util.TimerThread.mainLoop(Timer.java:526)
java.util.TimerThread.run(Timer.java:505)
四月 26, 2017 9:43:17 上午 org.apache.catalina.loader.WebappClassLoaderBase clearReferencesThreads
警告: The web application [pms] appears to have started a thread named [Druid-ConnectionPool-Create-2106177382] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread:
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
com.alibaba.druid.pool.DruidDataSource$CreateConnectionThread.run(DruidDataSource.java:1824)
四月 26, 2017 9:43:17 上午 org.apache.catalina.loader.WebappClassLoaderBase clearReferencesThreads
警告: The web application [pms] appears to have started a thread named [Druid-ConnectionPool-Destroy-2106177382] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread:
java.lang.Thread.sleep(Native Method)
com.alibaba.druid.pool.DruidDataSource$DestroyConnectionThread.run(DruidDataSource.java:1898)
四月 26, 2017 9:43:22 上午 org.apache.jasper.servlet.TldScanner scanJars
信息: At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time.
四月 26, 2017 9:43:22 上午 org.apache.catalina.core.ApplicationContext log
信息: Initializing Spring root WebApplicationContext

druid-1.0.9版本


Gracefully remove node from cluster on AWS node termination

Feature Request
Describe in as much detail as possible what feature you would like to see added and how it should work.
Motivation
Describe why we should work on this feature request.
Who's it for?
OSS User, Enterprise

How different is this from https://github.com/gravitational/gravity/issues/942 ?
Right now the SQS handles the removal and passes to gravity remove, eventually, it gets a bit janky atm due to how join/remove can't happen in parallel atm.
Curious of the scope here

@helgi The use-case targeted here is when someone terminates the instance directly via AWS control panel so it doesn't go through ASG lifecycle hooks. Not sure yet if there's a way to tell this scenario from a regular node shutdown and launch shrink in this case, needs some research.


fix(query): add Check method to query service interfaces

Fixes influxdata/idpe#2756.
Closes #
Briefly describe your proposed changes:

[x] Rebased/mergeable
[x] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[ ] Sign CLA (if not already signed)

Need to determine the right way to determine health; will research and complete this work.


Removing csv files does not remove them from the 'Home" screen

Description
I copied a csv file in the input files folder 2 times and then deleted them. The 'Home' screen still displayed the task for those two deleted csvs. When you click on the csv it does not open as that csv file is no longer in the input files folder. If the csvs are deleted from the input files folder they should not be displayed in the 'Home' screen.
Steps to reproduce
See above
Additional context
No response
Hedera network
other
Version
0.2.0-alpha.2
Operating system
No response

It looks like after some time the batch transaction tasks did remove, but it did not seem to do right away since the app is now scanning the input files folder more frequently.


Agent Fails to List Secrets

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Enable BGP control plane, enable debug level logging, and observe agent logs.
Cilium Version
Tip of the main branch.
Kernel Version
6.5.0-26-generic
Kubernetes Version
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.3", GitCommit:"434bfd82814af038ad94d62ebe59b133fcb50506", GitTreeState:"clean", BuildDate:"2022-10-12T10:57:26Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"linux/arm64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.1", GitCommit:"4c9411232e10168d7b050c49a1b59f6df9d7ea4b", GitTreeState:"clean", BuildDate:"2023-05-12T19:05:23Z", GoVersion:"go1.20.3", Compiler:"gc", Platform:"linux/arm64"}
WARNING: version difference between client (1.25) and server (1.27) exceeds the supported minor version skew of +/-1

Regression
No response
Sysdump
No response
Relevant log output
...
level=warning msg="github.com/cilium/cilium/pkg/k8s/resource/resource.go:808: failed to list *v1.Secret: secrets is forbidden: User \"system:serviceaccount:kube-system:cilium\" cannot list resource \"secrets\" in API group \"\" in the namespace \"kube-system\"" subsys=klog
...

Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[x] I agree to follow this project's Code of Conduct

This issue is specific to #31684 which needed to update install/kubernetes/cilium/templates/cilium-agent/role|rolebinding.yaml to create the cilium-bgp-control-plane-secrets role/rolebinding when either BGP v1 or v2 control planes are enabled. I will update #31684 accordingly.


refactor: VisuallyHidden to polymorphic types

Closes #
📝 Description

Refactor VisuallyHidden off createComponent to polymorphic types

Screenshots

Merge checklist

[ ] Added/updated tests
[x] Added changeset

lets open these against the next branch and we will do one big major release


notepad++ 7.3.3 64bit

are you going to release a dll plugin that works with notepad++ 7.3.3 64bit?
thank you

You can build it if you have Visual Studio, just change Build > Platform Target to x64. Attached is a debug build of v1.7 x64 built with Visual Studio 2010. NppToolBucket x64 v1.7.zip

Thanks for raising this, I realise I've been a bit slack in providing updates. I'll get a build for x64 done asap

No problem. I compiled it as kindly suggested. Thank  you for your plugin. I really appreciate it!

So it turns out I don't have a copy of VS2010 anymore and I can't build the current solution in VS2015 without upgrading the plugin template. I'll work on upgrading the plugin to the latest template here (https://github.com/kbilsted/NotepadPlusPlusPluginPack.Net/releases), in the meantime @trueliarx are you able to send me the x64 binary and I'll upload it to the plugin page?

See PR #16, fix for using with VS2015 and minimal set of changes from https://github.com/kbilsted/NotepadPlusPlusPluginPack.Net to work under x64 for n++.
Under https://ci.appveyor.com/project/chcg/npptoolbucket/build/1.7.3/job/g9vii4gomby4swen/artifacts you will also find builded artifacts with VS2015.

Thanks to @chcg I've built a 64-bit version, available here: http://phdesign.com.au/npptoolbucket/


Bump dev-dependencies

This updates the following dev-dependencies:

babel-eslint {8.0.0 🡺 8.0.2}
eslint {4.7.0 🡺 4.12.0}
eslint-config-davidtheclark-node {0.2.1 🡺 0.2.2}
eslint-config-prettier {2.5.0 🡺 2.9.0}
eslint-plugin-flowtype {2.35.1 🡺 2.39.1}
eslint-plugin-node {3.0.5 🡺 5.2.1}
flow-bin {0.54.1 🡺 0.59.0}
flow-remove-types {1.2.1 🡺 1.2.3}
jest {21.1.0 🡺 21.2.1}
lint-staged {4.2.1 🡺 5.0.0}
prettier {1.7.0 🡺 1.8.2}

eslint-plugin-node hasn't been updated due to a peer dependency.
However, flow is reporting some errors. @davidtheclark Could you please help me fix these?

@sudo-suhas How about just leaving out the Flow update and coming back to it later? Or I can try to look at it next week.

Okay. I'll leave flow out of this. Please take a look when you get some time.


Make sure divs and buttons only get outlined on tab and not onclick

Expected Behavior

divs and buttons should only get outline on tab over

Actual Behavior

divs and buttons get outlined on click

Steps to Reproduce the Problem

Navigate to any of the places listed in Observed In section and click on the mentioned element

Specifications

Version: 1.0.1
Platform: fabric

Observed in
All drawers: Routes, Functions, Threads (JVM/GO)
Service Instances view (table rows and links within)
Clear Cache modal in settings view
TableToolbar gm-select dropdowns

changed in:
JVM: routes, threads
GO: routes, functions
explorer inspector
Clear cache modal should be dealt in another issue: #1121
Drop downs should stay as they are. The onChange handler doesn't differentiate between clicks and keyboard actions which means that we can remove outline at the cost of lost focus for keyboard users which makes the drop down less accessible overall.


ERROR: screenshots/fornix module failed for subject ...

Description
When running
python qatools.py --subjects_dir /indirect/tmp_brainage/data/derivatives/freesurfer --output_dir /indirect/tmp_brainage/data/derivatives/freesurfer_qc --screenshots --fornix --outlier --screenshots-html --fornix-html --subjects sub-ADNI002S0413_ses-M000
I'm getting two errors:
ERROR: screenshots module failed for subject ... ``ERROR: fornix module failed for subject ...
I get the summary measures in the end, but no screenshots, etc. are appearing.
Also, I had problems during the installation process. I used the following steps:
conda create -n qatools python==3.8
conda activate qatools

pip3 install --user git+https://github.com/Deep-MI/BrainPrint-python.git
pip3 install --user git+https://github.com/Deep-MI/LaPy.git
pip3 install --user -r requirements.txt

When running, it is missing skimage, so I had to install it by hand.

When digging into it:
It fails in:
https://github.com/Deep-MI/qatools-python/blob/b17c95485e0dd3ce27d3ed6996b5367e1d2038ab/qatoolspython/createScreenshots.py#L109
With:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/users/rubendorfel/.conda/envs/qatools/lib/python3.8/site-packages/pandas/util/_decorators.py", line 311, in wrapper
    return func(*args, **kwargs)
  File "/users/rubendorfel/.conda/envs/qatools/lib/python3.8/site-packages/pandas/io/parsers/readers.py", line 586, in read_csv
    return _read(filepath_or_buffer, kwds)
  File "/users/rubendorfel/.conda/envs/qatools/lib/python3.8/site-packages/pandas/io/parsers/readers.py", line 488, in _read
    return parser.read(nrows)
  File "/users/rubendorfel/.conda/envs/qatools/lib/python3.8/site-packages/pandas/io/parsers/readers.py", line 1047, in read
    index, columns, col_dict = self._engine.read(nrows)
  File "/users/rubendorfel/.conda/envs/qatools/lib/python3.8/site-packages/pandas/io/parsers/c_parser_wrapper.py", line 223, in read
    chunks = self._reader.read_low_memory(nrows)
  File "pandas/_libs/parsers.pyx", line 801, in pandas._libs.parsers.TextReader.read_low_memory
  File "pandas/_libs/parsers.pyx", line 857, in pandas._libs.parsers.TextReader._read_rows
  File "pandas/_libs/parsers.pyx", line 843, in pandas._libs.parsers.TextReader._tokenize_rows
  File "pandas/_libs/parsers.pyx", line 1925, in pandas._libs.parsers.raise_parser_error
pandas.errors.ParserError: Error tokenizing data. C error: Expected 6 fields in line 82, saw 7

Regarding to this it can be solved using:
on_bad_lines='skip' instead of error_bad_lines=False in pd.read_csv(...)

Hello, thanks for reporting this issue and also for looking into it. We are currently working on a major revision of the toolbox that addresses e.g. dependency issues, and issues with the screenshots module. Maybe one option for you is to try the 'freesurfer-module-dev' branch, which has some more recent updates than the default branch.

If you need any help in development/testing, let me know @kdiers. Think it is quite a helpful tool for qc-ing big datasets

We have now released version 2.0, and the reported issues should be solved, therefore closing this issue now. Feel free to go ahead with some testing if you like, and to reopen this issue if anything persists. Thanks!

great work @kdiers and right in time. Ill give it a shoot next week.


Fixed Heap-buffer-overflow in parse_unix via clusterfuzz

Fixes

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=661
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=655
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=650

Do you know if something needs to be done to mark the clusterfuzz entry as fixed?

Yes, I noticed that seconds after sending that commit. Refresh :)
On 23 February 2017 at 09:20, Mark D. Roth<EMAIL_ADDRESS>wrote:

@markdroth requested changes on this pull request.
In src/core/ext/client_channel/parse_address.c
https://github.com/grpc/grpc/pull/9833#discussion_r102766724:

@@ -49,12 +49,11 @@

int parse_unix(grpc_uri *uri, grpc_resolved_address *resolved_addr) {
struct sockaddr_un *un = (struct sockaddr_un *)resolved_addr->addr;

const size_t maxlen = sizeof(un->sun_path);
if (strnlen(uri->path, maxlen) == maxlen) return 0;

Won't this fail if the size is exactly maxlen?
In src/core/ext/client_channel/parse_address.c
https://github.com/grpc/grpc/pull/9833#discussion_r102767210:

un->sun_family = AF_UNIX;

strncpy(un->sun_path, uri->path, sizeof(un->sun_path) - 1 /* null term'd */);
un->sun_path[sizeof(un->sun_path) - 1] = '\0';
resolved_addr->len = strlen(un->sun_path) + sizeof(un->sun_family) + 1;

strcpy(un->sun_path, uri->path);
resolved_addr->len = strlen(un->sun_path) + maxlen + 1;

Looks like you put maxlen here instead of sizeof(un->sun_family), where
you probably actually meant to replace sizeof(un->sun_path).
Shouldn't this actually just be set to sizeof(struct sockaddr_un)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/pull/9833#pullrequestreview-23533832, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAHVmaY5-bcFtL2PSPPYrZgVL2z5Fsr7ks5rfb_6gaJpZM4MJSIN
.

Issues: #9147 #9762 #9797 #9399


Have Error when build

When I build my application, i got the error like these:
ERROR in : Unexpected value 'ZoomModule in D:/bang-ng-template/node_modules/angular-zoom/zoom.module.d.ts' imported by the module 'ShareModule in D:/bang-ng-template/src/app/share/share.module.ts'. Please add a @NgModule annotation.
Pls fix this bug

Hi,
Thanks for trying out the package. I assume you are using the latest version. Can you please let me know the angular version you are using?

Angular CLI: 1.7.0
Node: 8.9.4
OS: win32 x64
Angular: 5.2.5

I was testing the package with a angular + webpack starter kit (https://github.com/nishantmc/angular-webpack-starter) with the following deps
"dependencies": {
  "@angular/common": "5.2.5",
  "@angular/compiler": "5.2.5",
  "@angular/core": "5.2.5",
  "angular-zoom": "0.0.5",

  "@angular/platform-browser": "5.2.5",
  "@angular/platform-browser-dynamic": "5.2.5",
  "core-js": "^2.4.1",
  "rxjs": "5.0.1",
  "zone.js": "^0.8.4"
},

I could test the demo page without any issues. I was using webpack to build the project. How are you building the project? Can you also send me all the deps so that i can try locally?

Same issue here.

i have the same issue :(

Works fine on development, but throws up this error when taking a build:
ERROR in : Unexpected value 'ZoomModule in F:/AppName/node_modules/angular-zoom/zoom.module.d.ts' imported by the module 'AppModule in F:/AppName/src/app/app.module.ts'. Please add a @NgModule annotation.

Necro, but same error here and this package has the functionality I need, to sad to see it's not maintained.


(WIP) Implement more granular build process

This implements the concept outlined in #50 and is a followup to #52.
Build logic has been moved from the monolithic Nix expression into a multi-staged process in which layer creation is handled by the server.
For now the primary advantages of this are subtle:

after creating a layer grouping we can avoid duplicate layer builds by checking for previously built layers with the same contents
less time is spent in Nix (which is the primary concurrency bottleneck for Nixery)
the build process becomes easier to parallelise

In the future this might enable additional optimisations (such as additional caching steps, for example by requesting runtime closures of each package separately and applying caching at that level).

Note: This PR is currently WIP. There are many tasks left to do:

[x] Move group-layers into the server component
[x] Refactor build-image.nix to remove functionality that is moving into the server
[ ] Deserialise the new build output correctly (including runtime graph)
[ ] Hash & cache layers by content
[ ] Implement layer creation (tarring & hashing (side note: is it possible to feed both hashes simultaneously from one disk read?))
[ ] Implement assembly of config layer
[ ] Implement assembly of manifest

To answer my own question:

side note: is it possible to feed both hashes simultaneously from one disk read?

Yes!
package main

import (
	"crypto/md5"
	"crypto/sha256"
	"fmt"
	"io"
	"os"
)

func main() {
	file := os.Args[1]
	fmt.Printf("Hashing '%s'\n", file)

	f, err := os.Open(file)
	if err != nil {
		fmt.Fprintf(os.Stderr, "failed to open file: %s\n", err)
		os.Exit(1)
	}

	md5hash := md5.New()
	sha256hash := sha256.New()
	multi := io.MultiWriter(md5hash, sha256hash)

	_, err = io.Copy(multi, f)
	if err != nil {
		fmt.Fprintf(os.Stderr, "failed to copy to multi hash: %s\n", err)
		os.Exit(1)
	}

	fmt.Printf("md5\t%x\n", md5hash.Sum([]byte{}))
	fmt.Printf("sha256\t%x\n", sha256hash.Sum([]byte{}))
}

Interestingly this ends up faster than a plain sha256sum-call on average, despite doing both hashes.

Minor change of plans: I will keep the construction of layer tarballs in Nix, but invoked as a separate derivation. The tarballs will then be read, hashed & uploaded by Nixery in one disk read.

This pull request is now missing two major things: Using the new caching strategy, and cleaning up builder.go.

Almost there. Local manifest caching is currently gone, because the manifests are no longer written to local files and the local manifest cache used file paths.

Alright, it's done.
The layer construction, as mentioned, is still in Nix (but in a separate invocation). A subsequent version could optimise this further to create the tarball in the server and avoid the last round of extra reads/writes on disk.


Implement document expressions

JAVA-4782

@jyemin When I rebase one of the branches, all of the ensuing branches need to be rebased (with conflicts resolved along the way). Sometimes I'm caught in the middle of this process (this happened to @stIncMale a couple of times), and the diff is unreadable. This has been resolved in array, date, and conv, and soon in this branch.


Bootstrap implementation

Rework the Pages to use bootstrap so that UI becomes responsive across all displays

i would like to help with this and have been learning bootstrap, but i am new to coding in general. i need help in getting it up and running. does all bootstrap have to go into the index,html? i dont know how to separate pages then. if you want, i am available on discord at reitenth#0171. thanks!

Hi @reitenth , I'd greatly appreciate any help. You don't need to be so concerned about it but, I'm also new to certain elements of react and bootstrap so this is also a learning experience for me. No, everything doesn't need to be in the main page. Each page will have its own elements and they are what you style using the standard bootstrap classes. I'm available to chat on discord in an hour as I'm currently in the middle of a blackout.
To help get started, I suggest pulling the bootstrap branch as iv already done partial implementation.
One pulled, just run npm install to get the packages and npm run start-all to start the program

Hi @reitenth , your discord seems to be set to block requests

fixed discord. looking through the bootstrap branch right now. also, it does not appear to be a tag on the docker hub? unless its the unstable.


Dropdown nav

Created a dropdown menu.

@diiq is going to see if we can make this menu accessible today. If not, we should merge this.

Looks great. Thanks @oneblackcrayon and @diiq!


Can't go to Page 2

Description
I have a folder with many files. It shows my a button for page 2, but I can't go there. If i click on '2', it redirects to the start page of documents.
URL for folder Documents: https://dms.mydomain
URL for folder with the documents: https://dms.mydomain/#100
Link for page 2: https://dms.mydomain/?page=2
So for me it looks like the Link to page 2 is broken, not sure where the problem is: Papermerge, or traeffik.
Also I can't see the documents (which I think there are on page 2), when i change the sort order.
Expected
Switch to page 2 in the folder.
Actual
Landing on the Documents page.
Info:

OS: Windows 10
Browser Edge
Database PostgreSQL
Papermerge Version 2.0.0.rc38

ah, that's a bad bug. I will fix it. @w4tzmann, thanks for reporting!

wow, you are faster then light! Thank you for you work and you passion.

Fixed. Fix available in latest release, which is 2.0.0rc45.


pull request for e2e test at 01/29/2017 07:56:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: port forwarding card

add: port forwarding grid (push)
current: port forwarding card ui thin