Support for Instruct / prompt format templates

Personally, I mix a pure "notebook" mode with prompt templates, which helps with finetuned models such as Mixtral - even for pure instruction (not complete) mode, I find an interface like Mikupad to be much better than a typical chat UI, as it allows me to edit and steer the replies of the AI very easily.
A chat-instruction finetune still works on continuous text. The AI doesn't see a conversation, just text with a special format - in other words, LLMs are actually always in complete mode! What changes is the illusion of it being a chat. So by having prompts (a prefix before the user prompt and a suffix after it that marks the start of the AI's turn) we can avoid typing all the instruct tags if we want to use them (some like ChatLM are quite hard to remember and type).
The interface is based on the sessions, with the addition of the "Insert" button (Control + Insert) that will insert the currently selected template into the text:

Creating a template needs a name, and a suffix or a prefix (one can be missing, since I suppose there are templates like that). It allows line breaks, since in fact many templates need them:

Then, when the user inserts the template, it will be inserted around the current selection:

If no selection is there, it will insert the template at the cursor position and then position the cursor inside the template so the user can start writing right away
If there is a selection, it will prepend the prefix before the selection and append the suffix after the selection, basically turning something into an instruction.

I have supported exporting and importing JSON files, and the templates themselves are stored in the local storage, and are not part of the sessions. I have included by default the ones I use the most: alpaca, mixtral and ChatLM, but the idea is the user can create any. There is no support for system prompt templates as some, like ChatLM, have, since it's not clear where the user would include them, and personally I'd put them in the memory.
Other areas of future improvement are:

Having an option to auto insert as a stopping string the start of the user's turn (prefix) - oftentimes the AI may start writing your own turn
An option to clean up instructions, so it would delete from the text area everything that is inside prompts, plus the prompt itself - at least this is something I miss from NovelAI, where my text becomes full of left-over prompts

Nice feature, this is also something I wished for mikupad! I have some comments to do on your implementation.

I think this doesn't look very good, there's no need to have the instruct templates take up so much space. I think something like a SelectBox with buttons on the side would be better for this, for example:

And then the instruct template creation could be done in a modal.

are u able to add a metharme format


Stop auto-refresh of Search Results after Add to Quick Access

Storage Explorer Version: 1.4.1
Platform/OS Version: Windows
Architecture: ia32
Regression From: Not sure
Steps to Reproduce:

Recent upgrade of Azure Storage Explorer client cause all of my Quick Access items to be invalid so I have to re-define them
Using the "Search for resources" feature, I type part of a Resource name and wait some minutes for the search to be completed
In the results, I select one Resource, right-click and select "Add to Quick Access"
The item is added to Quick Access but the Explorer is refreshed which is annoying and I then have to collapse up the nodes to find the next matching Resource in the previous search results

Expected Experience:
Prefer to add to Quick Access but the Search Results to not auto-refresh
Actual Experience:
The search results is refreshed and I lose my context

No repro anymore.


set  Secrets The forked repo

@ThusharaX only you can fix this action issue because you are the owner of this repo, please fix it immediately


Updating client secret for Exchange Online with authentication type Oauth (Cross Tenant)

This documentation explains how to setup a new server profile with oauth authentication that can be used in cross tenant scenario's. However when the secret does expire, the screen doesn't contain the tenant, clientid and client secret fields anymore. See screenshot. Please amend the documentation to state how to update the client secret in the scenario where it does expire.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fc66531e-53ea-bcdf-1bb3-3ae2e2617a8e
Version Independent ID: 0659f974-8190-0cb9-e12e-2640fb30b114
Content: Exchange Online cross-tenant authentication - Power Platform
Content Source: power-platform/admin/connect-exchange-online-server-profile-oauth.md
Service: power-platform
Sub-service: admin
GitHub Login: @gattimassimo
Microsoft Alias: magatti

Thanks for your comment, @pieterh. This issue has been assigned to the doc author for review.


Fix Extras docstrings

Codecov Report

Merging #48 (8c46802) into master (e8bf681) will decrease coverage by 0.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   85.95%   85.12%   -0.83%
==========================================
  Files           5        5
  Lines         242      242
==========================================
- Hits          208      206       -2
- Misses         34       36       +2

Flag
Coverage Δ

unittests
85.12% <ø> (-0.83%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/core.jl
91.30% <0.00%> (-4.35%)
:arrow_down:

src/something.jl
94.59% <0.00%> (-2.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8bf681...8c46802. Read the comment docs.


Copy transaction and link at success modal at drop page mint

gives this
https://statemint.subscan.io/extrinsic/[object Object]

👋

even after fixing that we dont have a valid txHash #8857
should we hide the top if we dont have it?


When using a bar chart and the hide option - the graph doesn't draw data correctly.

http://jsfiddle.net/Lbej86Lf/
When hiding 2 of 3 series - the graph still tries to draw the other series with the one you specify.  Works fine for line graphs.
Introduced in ver 0.4.15.

I'm on 0.4.18 and just came across this issue as well. Here's another fiddle that shows the issue:
http://jsfiddle.net/z5uxz09a/
In the fiddle, you can see that "data2" is showing(over "data1") in the chart, but correctly hidden on the legend. If you click "data2" in the legend to show, then click again to hide, it shows properly.

Hello,
Thank you for the great work.
I just came across the problem. In the official sample, just add hidden: true in data block, and you will see how messed up it is 😄
Any chance of having this corrected soon ? thanks.


[Bug] When clicking on the "Check updates" button, the icon disappears

Description of the bug:
When clicking on the "Check updates" button, the icon disappears.

How to reproduce the bug:

Go to "Settings"
Click on the "Check updates" button
The problem is here

Expected behaviour:
The icon is missing after clicking on the button.

Screenshots:

Computer:

OS: Windows
OS Version: 10.0.19042.804
Software's Version: <IP_ADDRESS>3

Monday, March 8th: The bug is fixed.


specup: init

Description of changes
A command line tool for cases where you want to generate markup from yaml. This is common for web development but using a command line tool saves building and maintaining a framework in your favorite programming language.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I checked closures by running the following commands. I'm just preempting a request from a similar PR.
$ nix path-info -Sh .#specup
/nix/store/npwb53371yb2ya0zvjx9igkbv0nnxx6x-specup-<IP_ADDRESS>-bin	  63.2M

$ nix path-info -r .#specup
evaluating derivation 'git+file:///home/dan/repos/nixpkgs#specup'/nix/store/bncqz1jnd3mkssg2rbx3qgqy55bi0m7g-xgcc-13.2.0-libgcc
/nix/store/mgkvalznvc8ik2r9p93445vjbd80ax00-libunistring-1.1
/nix/store/x3wc0s3165pfcakkbbc22j7k5hndc73k-libidn2-2.3.4
/nix/store/7jiqcrg061xi5clniy7z5pvkc4jiaqav-glibc-2.38-27
/nix/store/1l3a02nqq5b5v7rhchj89hi7plmbza5r-openssl-3.0.12
/nix/store/4znq11s8j9d29kj2l4qivl5pyhbbzy8q-zlib-1.3
/nix/store/4hdjb7r9k0dpcyk11k568c6y9kdgf6zc-libssh2-1.11.0
/nix/store/4z9wwg9lgdy30drvizy891zisj2makq4-nghttp2-1.57.0-lib
/nix/store/9nsd8bhgzb7ar3366lvlycj9lr0wldpx-brotli-1.1.0-lib
/nix/store/kbsb6s8djydiawgswnm8j5bwn1yxaqb7-gcc-13.2.0-libgcc
/nix/store/np3cndfk53miqg2cilv7vfdxckga665h-gcc-13.2.0-lib
/nix/store/b5r5rikbdpr6qs4wfm6dxz9dbrmyvps6-gmp-with-cxx-6.3.0
/nix/store/c5gp1vii3qmma428db3gyyb91p710whs-zstd-1.5.5
/nix/store/cjbyb45nxiqidj95c4k1mh65azn1x896-bash-5.2-p21
/nix/store/d3jhphmgval3c9hhvmz04qj3qavy8hns-keyutils-1.6.3-lib
/nix/store/dx65xxpnmcb4a3pjkqp74zibxd7wb16x-xz-5.4.5
/nix/store/jqcm3z315k4dx4qqdcvvs3b80fganpbr-libkrb5-1.21.2
/nix/store/l5rgcblia1bvrhp8p7s9xbyhf25alnpy-curl-8.5.0
/nix/store/npfpil5nswlaqy7y56dwp0csj91pjiyd-libffi-3.4.4
/nix/store/rmnl7cvvr3gfx4g821xbcaqy3x0g6v6r-bzip2-1.0.8
/nix/store/qnlgnpvh94xw2j3pm5f02iw102lx6llc-elfutils-0.190
/nix/store/npwb53371yb2ya0zvjx9igkbv0nnxx6x-specup-<IP_ADDRESS>-bin

LGTM, thank you!

Can we add this to release-haskell.nix as well?

Can we add this to release-haskell.nix as well?

Sure thing. I raised this as https://github.com/NixOS/nixpkgs/pull/287824.


Missing Config file

Currently a WIP, it should be done soon. Just getting the last things finished like bugs and guide etc


Bind type and string from scope

It would be nice to be able to bind the type and the string from scope

Feel free to submit a pull request for the change. Just make sure you are still able to put multiple barcodes on the same page.

currently are the type and the string attributes fixed ?, is not supporting model data binding?
    <barcode type="code128b" string="model.barcode" options="barcodeOptions"></barcode><br>

@romelgomez i've downloaded the lastest master and it works, the bower package is not updated yet apparently

I pushed a new tag. It should be updated in bower

Thanks @eatskolnikov @justechn, the string is attribute working now, but if i change the type attribute the string is not revalued until the string changes. I guess if add this lines will work:
After: https://github.com/justechn/angular-barcode/blob/master/src/Barcode.js#L133
    function watchStringAttr(scope, element, attrs) {
        attrs.$observe('type', function (value) {
            link(scope, element, attrs);
        });
    }

But what if string is invalid, the demo (http://lindell.me/JsBarcode/) suggests that the function JsBarcode() take 3 parameters:
$("#barcode").JsBarcode(
    $("#userInput").val(),{
        "format":$("#barcodeType").val(),
        "backgroundColor":"#fff",
        "fontSize":parseInt($("#bar-fontSize").val()),
        "height":parseInt($("#bar-height").val()),
        "width":$("#bar-width").val(),
        "displayValue":displayValue
    },
    function(valid){
        if(valid){
            $("#invalid").stop().fadeTo(300,0);
        }
        else{
            $("#invalid").stop().fadeTo(300,1);
        }
    });

How do I get that warning?

@romelgomez do the change you want and make a pull request?

So I don't think we need to check both type and string because if the type changes, then the string will also change. Since we are already checking string it should be good enough.
What do you think? Is there a time when the type will change without also changing the string?


Single properties for setting all credentials for file transfer

fileTransfer.username=yourAdLogin
fileTransfer.password=yourAdPassword
fileTransfer.domain=yourAdDomain

as shorthand for
fileTransfer.smb.username=yourAdLogin
fileTransfer.smb.password=yourAdPassword
fileTransfer.smb.password=yourAdDomain

fileTransfer.sftp.username=yourAdLogin
fileTransfer.sftp.password=yourAdPassword

fileTransfer.http.username=yourAdLogin
fileTransfer.http.password=yourAdPassword

still old way / detailed credentials should have precedence over this new shorthand properties

very useful especially when combined with https://github.com/neva-dev/gradle-fork-plugin/issues/27

to be released in 9.1.0


Issues with outline (first variable in a group missing)

Given the sample:
       01 error-messages.
          05 bad-ending           pic x(50) value
             "Should have exactly 3 digits !".
          05 bad-param            pic x(50) value
             "Bad param!".
      *
       78 test-date value 123.

the outline misses the first entry bad-ending in error-messages (and shows test-date "below" it, level 78-items should be on the same level as 01+77).

Please reopen; 0761f6a fixes only the side issue of level 78 constants, but not the main part this issue is about: "first variable in a group missing".


Add the ability to divide a CIDR range

The CIDR range division feature allow users to easily divide a given CIDR range into a specified number of smaller subnets.
Why: this enhancement is crucial for users dealing with IP address management, allowing them to efficiently and accurately divide CIDR ranges as needed. Improving this feature will enhance the overall usability of cidr.
Example:
Introduce a divide subcommand, where you specify both a CIDR range as well as an integer to divide it respectively.
$ cidr divide <IP_ADDRESS>/16 9
<IP_ADDRESS>/20
<IP_ADDRESS>/20
<IP_ADDRESS>/20
<IP_ADDRESS>/20
<IP_ADDRESS>/20
<IP_ADDRESS>/20
<IP_ADDRESS>/20
<IP_ADDRESS>/20
<IP_ADDRESS>/20

h/t @steynovich for proposing this enhancement to cidr in a 1-on-1.

What are your thoughts on this feature request @DanielRieske, @mmourick and @mvanholsteijn?

Sounds like a very nice feature to add to cidr. I'd also like to take a crack at implementing this.

Created a PR for you.


Add lts/18/21/FR1.yaml to get new freckle-app with prelude

$ diff lts/18/21/FR1.yaml lts/18/21.yaml
10c10
<   - freckle-app-<IP_ADDRESS>@sha256:f46ab8cadaf8b7890e81891a314db302eb3cd614778e4b13abf9e4a4c24a4f0b,6612
---
>   - freckle-app-<IP_ADDRESS>@sha256:93bf2fcac81e63f3dc9a75dc0c557d729f1ff7902dce9ab6da4b1852a80eac13,6445

Can you hold this for @cbeav 's Freckle.App.Database change too?

@pbrisbin of course, no problem at all!

Stackage LTS has moved to 18.23.

I may have neglected to check if @cbeav knew we've been waiting :grimacing:
Chris, do you want to get your stuff in this next snapshot or let it go?

@mjgpy3 Wanna take over https://github.com/freckle/stackage-snapshots/pull/29 and proceed there?


False possitive in android-json-0.0.20131108.vaadin1.jar

Hi
Im having a false possitive in android-json-0.0.20131108.vaadin1.jar, pointing several vulnerabilities
This is part of springboot 1.5.3, and is returning vulnerabilities that are not related at all to this component
It has been also discussed in stackoverflow -- https://stackoverflow.com/questions/43978228/cve-2010-1807-vulnerablity-from-android-json-in-spring-boot-1-5-3
The cve reported are:
CVE-2010-1807
CVE-2013-7372
CVE-2014-1939
CVE-2014-6060
CVE-2016-5696
Thanks

Thanks for reporting the FP!


Xtend Test Coverage

I'm trying to determine the code coverage for my tests, but all of the results are relative to the generated Java code.
A preliminary search shows that it is supposed to be possible to show the coverage right in the Xtend source files, but all of these solutions appear to require intimate knowledge of the project setup that I don't possess.
@eyck could you take a look at this?
Possibly relevant:

https://dietrich-it.de/xtext/2016/01/12/code-coverage-for-xtend/
https://github.com/codecov/example-xtend
https://www.eclipse.org/forums/index.php/t/1091909/

Unfortunately this turns out to be not as straight forward as hoped. So we should post-pone to 2.1.


Add automated testing

The goal of this change is to have Travis-CI automatically run flake8 tests on every pull request. This will help contributors know if their submissions are going to break the build. To turn on this free service, you would need to do steps 1 and 2 of https://docs.travis-ci.com/user/getting-started/

Bump.

Bump/


[2021 UX Reevaluation] – Design Discovery / Exploration

This is a placeholder issue so that we can cross-reference components of #662. The content will be updated to include a summary of the work for each component as it is completed.

After our initial research of the current state of Explorer, we defined a few guiding principles for the first phase of explorations.

Know our users
Curate and expose vital data
Promote Personalization
Subtract for Simplicity
Invisible Design (System feedback)
Data = Narrative (Tie data together in a sentence that connects it and provides significance)

Current Landing

Proposed Landing

Search Feedback (New Users)

Search Behaviors

Current Transaction Landing

Proposed Transaction Landing

Current Validator Landing

Proposed Validator Landing
More to follow the following upcoming research efforts.

A couple of questions:

After our initial research of the current state of Explorer...

Is this research summarized anywhere or is this what is shown in the images above?
Re: Guiding Principles: How did you arrive at the guiding principles outlined above? Are these assumptions/ideas for how the explorer could evolve, and if so, what are they informed by?

Promote Personalization: Has there been an expressed need for users to be able to personalize their experience?
Subtract for Simplicity: To what extent? Would be great to know how users are consuming the data we display currently in order to determine if they feel there is a need to simplify.
Invisible Design (System feedback): This is a bit vague, can you articulate a few more details about what is meant by this?

Is this research summarized anywhere or is this what is shown in the images above?
At the global level these are all assumptions we will validate through our user research efforts in the coming weeks.

Re: Guiding Principles: How did you arrive at the guiding principles outlined above? Are these assumptions/ideas for how the explorer could evolve, and if so, what are they informed by?

These Principles are mostly informed by the initial competitive analysis of PoS explorers. The research efforts will aim to validate or challenge these ideas.

Promote Personalization: Has there been an expressed need for users to be able to personalize their experience?
In my initial discussions with a few people internally/close to the project, the use case of "Returning Users" was something that needed exploration. There was a common interest in the idea mostly for Developers and Delegators.

Subtract for Simplicity: To what extent? Would be great to know how users are consuming the data we display currently in order to determine if they feel there is a need to simplify.
The Subtraction principle is pointed at things like the transaction categories. For instance the smart contract execution label: Called method: 'add_block_header' in contract: 0.client.ropsten.testnet - We refine this to: "Block Header"

This might be dependent on if there is a manageable set of possible labels. In addition to this we'll find out whether the Developer finds this subtraction useful or not.

Invisible Design (System feedback): This is a bit vague, can you articulate a few more details about what is meant by this?
This invisible intelligence is directed at the proposed search categorization and corresponding data per result in the auto-suggestion pattern. This also needs validation across all user segments. The purpose of this is to quickly get users to a transaction or account without the need of a results page.

Our research efforts have helped us to refine or eliminate the principles we started with.
Our new principles:
Know our validators
Provide Delegators Tools
Encourage Decentralization
Better Data Hierarchy
Curate and expose vital data
Promote Personalization
Data = Narrative
We've explored a couple concepts that point back to our new focus.
Here are some highlights:
Stake Simulator

Validator Notifications

Validator Profiles

Better Ranking


[release] v0.0.24

[x] I have followed (at least) the PR section of the contributing guide.

I'll fix the breaking CI separately. It's unrelated to the actual tests.

If the fail is about

Browserslist: caniuse-lite is outdated. Please run:

A possible path https://github.com/mui/material-ui/pull/43564, it makes sense for the old branchs, as, wut are they failing builds because of old data? It's absurd, I want idempotence between inside a major. I can't ship breaking changes because their data changes.


hook_android_dlopen_ext and android_dlopen_ext calls are inter-looped and resulting a call-stack overflow

Hi,
Getting this issue of call looping between these two functions.
backtrace:
hook_impl: hook_android_dlopen_ext: filename: libhook_impl.so
/base.apk!libhook_impl.so (offset 0x3d9000) (hook_android_dlopen_ext+168)
/base.apk!libmain_hook.so (offset 0x3e0000) (android_dlopen_ext+36)
/base.apk!libhook_impl.so (offset 0x3d9000) (hook_android_dlopen_ext+168)
/base.apk!libmain_hook.so (offset 0x3e0000) (android_dlopen_ext+36)
/base.apk!libhook_impl.so (offset 0x3d9000) (hook_android_dlopen_ext+168)
/base.apk!libmain_hook.so (offset 0x3e0000) (android_dlopen_ext+36)
/base.apk!libhook_impl.so (offset 0x3d9000) (hook_android_dlopen_ext+168)

Uh can I see the client code? This shouldn't happen


Ma add missing building fields to models cart discount anddiscount code

shouldn't it be added to default and rest builds too?

added and in the discount code they already exist https://github.com/commercetools/test-data/blob/main/models/discount-code/src/discount-code-draft/transformers.ts#L14


Reconstruction of the 3D scenes with the corresponding information

Hi,
Thanks for the availability of the dataset and the ground truth data. I went through the available elements that you share here in this repository however it is not clear to me whether it is possible to have the 3D reconstruction of the demo scenes rather only the renderings.
Could you please elaborate a bit on this and whether this is possible or not.
Thanks.

Related: Will 3D environments be available as scenes for example for editing in UE/blender?


ERROR: GDScript::_create_instance: Condition ' r_error.error != Variant::CallError::CALL_OK ' is true. returned: 0    At: modules\gdscript\gdscript.cpp:128

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Godot 3 Beta 1 (Without Mono)
Was also seeing it in the last Alpha
Windows 10
Issue description:

The following error appears in the console, however the game works as I expect.
ERROR: GDScript::_create_instance: Condition ' r_error.error != Variant::CallError::CALL_OK ' is true. returned: 0

At: modules\gdscript\gdscript.cpp:128
I'm instantiating a scene that is just one node which is the BBText control.
I might be doing something dumb, but just wanted to log and issue right away to see if it jumps out to anybody as something obvious.
I'm new to Godot and Programming.
If you guys think this is a genuine bug that needs investigating, please let me know and I will do some more work on it to try and work out what is going wrong.

(Since Noshyaar keeps closing this, I am going to continue to post it until one thread remains visible for discussion, no need to censor)

Lead developer sent this message after a user was giving his honest feedback via this reddit thread.
They also said (I kid you not) -- giving feedback is "bullying",  a "professional whiner", and "ranting". Reduz's passive aggressive tone and insulting behavior is rampant there.  I already terminated my patreon account because of this, and not saying you should either (FLOSS projects) are great, however, for the lead developer to act like this towards people giving feedback.. is not okay!
Let me re-iterate, not saying that you should stop giving feedback, but I just want this message to be seen across github and reach as far as possible. Because this kind of communication and how the lead developer treats a regular Godot developer is not right at all. I've never seen this behavior from a FLOSS project lead developer.  It's a shame, because the guy giving feedback is just a random person anyway, and the way the project managers and lead developers took it so personally like it was an attack (when it wasn't), means the lead developers/contributors are possibly not viewing your issues with the right mindset.
Also, after reading the last paragraph from this post by akien

From here on, we will avoid responding to xxx's threads on the various Godot communities, and focus instead on the huge amount of constructive feedback and bug reports that we get from other users. This will likely overlap with some of the issues mentioned above, which will thus be fixed eventually, but we won't accept being bullied into working on them now when we have different priorities. Users are free to disagree with our priorities, but in the end the contributors are the ones making the call.

He's saying they will now favor/prioritize issues based on the user reporting it, and not the issue itself. (Extreme prejudice), which will not be good for the project because the issue should be irrelevant to the user reporting it. Just because if a user who has a snotty attitude that is reporting a huge client crash error, doesn't mean that client crash error should not be taken lightly.
He's also stating that anyone giving hard feedback is now "bullying" them. Which is not true whatsoever.
Just wanting to post this to get the word out there, hopefully some things change. @reduz @akien-mga  This is just unbelievable :(

Sorry to bother you after so much time... Is this issue still present? If so, can you submit a simple example project so we might look into it? :)

I just run into this issue. This was in the context of creating a plugin with a custom dock. The EditorPlugin instantiates a scene which has a Controlat its root. Adding a script with tool keyword generates the reported error. I can give it a shot to slim my project down to bare elements, if that is helpful. I'm not that far in.

So, no, I cannot reproduce this problem with a project stripped to minimum. I will come back if I run into it again.

This happened to me.
When:

Node as scene root with script attached
script contains _ready() and _init(), where _init

extends Node
var value = 1.0

func _ready():
	print("here") # not getting printed and the error appears

func _init(value):
	self.value = value

E 0:00:01:0465   Condition ' r_error.error != Variant::CallError::CALL_OK ' is true. returned: __null
     modules/gdscript/gdscript.cpp:129 @ _create_instance()
(bad) workaround:

create custom init function.

Can confirm. This is somewhat paraphrasing what @cobrapitz said, but in order to simply reproduce this error, just:

Create a new project
Add a (base) Node as root
Attach a script to it containing:

extends Node

func _init(foo):
	pass

Run.

Note that some people could argue that using a non-standard _init signature in a node isn't supposed to be done (at least it may not be). I personally like using the scene tab to hold a hierarchy of "script nodes" representing custom objects, as it makes them easier to view/access at any given time. They don't act as nodes in that case, _ready / _process aren't called, etc, which is actually convenient.
I could obviously just store them as pure scripts and not have to extend Node (and forget about the scene tree hierarchy thing), but before that at least someone can confirm if that's desired behavior or not.

I just got this issue without a script attached to the root. In my case the script is on a RigidBody but the  root is a Node. If I change the root to any other node type is still not working. In fact I cannot use any scripts in this project due to this bug.

Just faced this issue myself.
I had to have a parameter-less _init method in my class. I assume this this is the case because Godot instantiates an object then loads the saved export variables into the instantiated object.
Changed my code from
func _init(_begin: float, _end: float):

To:
func _init(_begin: float = 0.0, _end: float = 0.0):

One thing that helped me was the answer given by "Zylann" in this post
Quoted here in case the link ever dies:

If your script instance is going to be saved/loaded inside a scene, it must have a parameterless constructor, or a constructor with all arguments optional. The reason is, the "state" of the script instance comes from the scene file (variables with export or the STORAGE hint), it's not really building a new one.
Otherwise it's fine to have arguments in _init, for cases where you are calling it with new in your scripts.

Sorry but this is still an issue in Godot 3.2.2 and took me forever to figure out why my custom type wasn't doing anything.  The _init function gets called but called a method of the class does absolutely nothing.

To fix this do not use custom _init() functions

That is not a fix.  I understand if this cannot be supported but the ability to pass arguments to a "constructor" is an important feature that is currently broken.  At a minimum, an error message that makes sense should be displayed rather than just halting execution of the script.

The solution is to have default values for every param in _init()
bad:
func _init(x:int, y:int, z:int, size:float):
good:
func _init(x:int = 0, y:int = 0, z:int = 0, size:float = 0.0):

I fixed the error by removing the nodes with paramtrized _inits from the editor scenetree and I instance them by scripting only.

Duplicate of https://github.com/godotengine/godot/issues/15866.


Replace Sqlite3 with Libsql

Libsql is a fork of SQlite3 and has more features like ALTER TABLE extension for modifying column types and constraints
I recommend replacing Sqlite3 with Liqsql https://github.com/tursodatabase/libsql

The point of SQLocal is to run the database in the browser. libSQL does not have a build that runs in the browser.

would it be possible to support https://github.com/tursodatabase/libsql-client-ts/tree/main/packages/libsql-client-wasm/examples/browser ?


The getter 'accentColor' isn't defined for the class 'ThemeData'.

Hello!
When i try to run examle:
Error (Xcode): ../lib/src/pixel_perfect.dart:142:62: Error: The getter 'accentColor' isn't defined for the class 'ThemeData'.
Could not build the application for the simulator.
Error launching application on iPhone 14.
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.0, on macOS 13.3.1 22E772610a darwin-arm64, locale en-RU)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.78.1)
[✓] Connected device (3 available)
[✓] Network resources
• No issues found!

thanks man.

fixed in https://github.com/kherel/pixel_perfect/commit/e9f2758a4252dd7b5fee52aa9a90198a2ad302bd


I would like to delete my account on homebrewery/naturalcrit

Hello!
I'm aware this is definitely not the place for it, but there does not appear to be any kind of contact form or mechanism on the actual website, I have similarly not found any kind of contact e-mail address for the maintainers of this project, and do not possess a reddit account - so here I am.
I would like my account on homebrewery/naturalcrit to be deleted. What details do I need to provide?

Give me a username and detail on any of your brews (titles, etc) so I can make sure it's the right account.
Do you want all the documents deleted as well?

The username is 'UnfetteredPanopticon'. There is zero content attached to the account.

Your account is now deleted. 👍

Is there a different way that I can contact you to delete my account?

Is there a different way that I can contact you to delete my account?

Send a message to me /u/calculuschild on Reddit.

I do not have a reddit

@pact-wheeler
You can visit us on our Gitter page and sign in using your GitHub account. Click on my name and you can send me a private message.
https://gitter.im/naturalcrit/Lobby


Optimize power consumption

Investigate opportunities to reduce power consumption.  The system uses about 1300 mW when recording at 96 kSPS, over half of which is for the Raspberry Pi.  It may be possible to turn off features of the Pi to save some power.

Turn off WiFi after Tag becomes submerged.


Add Adaptive Cruise Controller (ACC) model

WIP model:
@taylorize function ACC!(du, u, p, t)
    local f, a_lead, a_ego = 0.0001, -2., -1.
    # u[1] = x_lead
    # u[2] = v_lead
    # u[3] = γ_lead
    # u[4] = x_ego
    # u[5] = v_ego
    # u[6] = γ_ego

    du[1] = u[2]
    du[2] = u[3]
    du[3] = -2 * u[3] + 2 * a_lead - 2 * f * u[2] * u[2]
    du[4] = u[5]
    du[5] = u[6]
    du[6] = -2 * u[6] + 2 * a_ego - 2 * f * u[5] * u[5]
    return du
end

# define the initial-value problem
X₀ = Hyperrectangle(low=[90., 32, 0, 10, 30, 0], high=[110, 32.2, 0, 11, 30.2, 0])

prob = @ivp(x' = ACC!(x), dim: 6, x(0) ∈ X₀)

# solve it
@time sol = solve(prob, T=0.1);

good! the rhs of u[3] does not satisfy the rule of only using binary operations (see this paragraph), s i would suggest to re-write this as
    two_f = 2 * f
    u2sq = u[2] * u[2]
    u5sq = u[5] * u[5]

    du[1] = u[2]
    du[2] = u[3]
    du[3] = -2 * u[3] + (2 * a_lead - two_f * u2sq)
    du[4] = u[5]
    du[5] = u[6]
    du[6] = -2 * u[6] + (2 * a_ego - two_f * u5sq)

Fixed by #6.


map key contains underLine,do not support underLine to hump

Are you in the right place?

For issues or feature requests related to the code in this repository file a Github issue.
For general technical questions, post a question on Google Groups.

Whats your runtime?

Dozer version: _____
OS version: _____
JDK version: _____

Whats the problem?
Steps to reproduce:

Observed Results:
What happened?  This could be a description, log output, etc.
Expected Results:
What did you expect to happen?
Link to GitHub repo with Unit test
The easiest way for us to fix issues, is if you provide a GitHub repo, using the latest release and a simple unit test.

Please provide a description of the issue and a minimal example, preferably in the form of a new Github repository containing a unit test.

as no description, closing.


ShellItem not released on error in Windows implementation

Hi,
The following ShellItem is not released if an error is returned while using it (the function jumps to the end):
https://github.com/mlabbe/nativefiledialog/blob/5cfe5002eb0fac1e49777a17dec70134147931e2/src/nfd_win.cpp#L403
Similarly, the file dialog itself is never released.
Compare it to the official example.

I agree, this needs doing!  If you offer a PR, I would be happy to merge it.
https://github.com/mlabbe/nativefiledialog/blob/master/docs/submitting_pull_requests.md

Could maybe switch to use the RAII objects - the ComPtr would auto call release in any circumstance

I implemented a fix for all of the cases on the devel branch.


Use more real-life example in Readme,

More meaning full example in readme.
Typo in $basicCollector->collect

@mimol91 I have made few fixes, please check if they are OK.


Error detected: ...attempt to call field 'is_closing'

Hey! I'm using the basic template setup from https://github.com/LunarVim/Neovim-from-scratch which uses cmp-nvim-lsp and sumneko_lua LSP-server. I have not modified anything else from the template other than pinned some newer versions for nvim-treesitter and some other plugins. I am getting this error with every single inserted character in lua files:

Running command ":lua =vim.lsp.get_active_clients({ filter = { name = "sumneko_lua " }})[1].is_stopped()" returns false so I guess the LSP-server should be working fine. Using newest pre-release NeoVim v0.8.0-1183-ge6c214033 on Windows and newest cmp-nvim-lsp.
Any ideas what this could be caused by?

Hey!
I encountered a similar error and found a related issue on the neovim repo.
In my case the error disappeared after updating null-ls.

Hey! I encountered a similar error and found a related issue on the neovim repo. In my case the error disappeared after updating null-ls.

Updating null-ls solved the issue! Thanks!


Transfer with Transact Design Discussion

Hi guys, we would like to propose a new feature for xtokens and want to start a discussion to see if it is reasonable and can be worked on.
Given that users can privatize any asset on our chain, we want to enable them to move cross-chain assets to our chain and privatize them in one call. Our idea is to allow users to send, along with token transfers, a Transact instruction that includes the encoded privatization extrinsic. Moving some assets and using them in an extrinsic with one call seems like something that can be useful for other use-cases as well.
The design that we've come up with so far is the following:

Add new transfer_with_transact extrinsic that will use existing token transfer logic and sends a message to move some assets:
a. for the encoded call in the Transact instruction (our case to be privatized)
b. to pay for execution fees
All the assets will be deposited to an account created by converting the MultiLocation of the sender user account on the sender chain (from the viewpoint of the receiver chain) with Account32Hash or whatever converter is implemented on the receiver chain.
Then an additional xcm message will be sent: (DescendOrigin + WithdrawAsset + BuyExecution + Transact)
a. first descend the origin to the account from step 2
b. withdraw the fee assets from 1.b. to holding
c. buy execution with the assets in holding
d. Transact the encoded manta-pay extrinsic to privatize the assets from 1.a.
e. Change can be deposited back to the same account or a different account

Here's a very rough shot implementation of the idea for reference https://github.com/Manta-Network/open-runtime-module-library/pull/4/files
Also some impl details:

For starters we can limit the new extrinsic where:
a. asset is a CurrencyId and fee is the same CurrencyId.
b. asset and fee are withdrawn separately from sender.
The receiver account which will also dispatch the Transact call, should be the origin of the extrinsic on the sender chain:
a. self_location.append_with(sender_account_origin).reanchor(destination_chain, ancestry)
b. the above destination won't be valid according to the dest != self_location check
c. to work around 2.b. we need to construct a "fake" destination to pass the check
d. then use the maybe_recipient_override argument to override with the "real" destination from 2.a.
Ideally we want to deposit change to any account on the destination chain
a. it would be easier to do a refund to the destination from 2.a.
b. we can start off without depositing any change

@xlc @zqhxuyuan @shaunxw @stechu

If DescendOrigin is first xcm instruction, I think current Barriers not support it.  We've some same needs before: https://github.com/open-web3-stack/open-runtime-module-library/pull/651

If DescendOrigin is first xcm instruction, I think current Barriers not support it. We've some same needs before: #651

Right, the DescendOrigin will need a different Barrier, which would be left for the receiver chain to implement.
651 looks exactly that, but should also allow a customizable set of sibling parachain locations. In our use case the messages can come direct from another parachain.

Hi @KiChjang, Thanks for the feedback, this is really helpful.
Thanks for the XCM V3 and Bounded Vec suggestions. We should definitely leverage them. Here let's address the two major points first.

Motivation
Security

Motivation

In general though, I don't feel like a transfer with a Transact instruction is something that should be abstracted and generalized into a template. I understand that it's supposed to be general purpose -- I get the general part but not the purpose part, because it would seem to me that it's no different from a xcmPallet.send, other than the fact that it uses a more privileged XCM origin, which should really be handled with more care. It also seems to me from a fee perspective that it's more beneficial to a user if they do a transfer and interact directly with the chain to submit the dispatchable, rather than through the transfer and transact dispatchable, because it would skip the fees payable to the sending chain.

Our motivating application is to streamline the privatization of parachain assets. For example, using transfer_and_transact, a user could 1-click privatize her assets in Acala to private assets. However, the logic is quite general. For example, if a user want to 1-click sending KMA to Acala/Moonbeam/Astar and exchange for some DOT, the same logic could apply.
You can argue that we can always compose these transactions at the front-end/dApp level. However, composing at runtime level has the great advantage of latency and reducing complexity for dApp development. Since these operations are streamlined. dApp developers doesn't need to handle the complexity of composing and waiting for the first extrinsic  finish and then sending the second one. Here, we would like to at least to provide a choice to compose at runtime level.
Security

I'm a bit hesitant to add an API that allows any signed account to simply provide an encoded call and then have it be executed on a foreign chain. It just sounds to me that there's a high chance that it could be exploited in ways that we don't quite yet understand, the one that I could think of is via a bad runtime upgrade that accidentally added a new dispatchable to modify important state info without having proper access controls. Further, since work is underway to provide an upper limit to all Vecs accepted in call parameters and storage items, it's becoming a bad idea to accept an unbounded Vec as an argument to any dispatchable function.

This is a very good point, in @ghzlatarev 's original post, he didn't elaborate on the security aspect of the design. The key security guarantees of the design are as follows (BTW, these points are precisely why we want to implement in ORML and get the code potentially audited):

transfer_and_transact assume that the destination chain will create a derivative account using Account32Hash upon received the transfer, and the transferred token will be hold in this derivative account. Essentially this is a hash of sender's multi-location.

In the XCM message that transfer_and_transact send, the code ensures that OriginKind in the Transact instruction is SoverignAccount,  and then assume a reasonable implemented ConvertOrigin should covert it to the "correct" multilocation, i.e, the default one that polkadot uses (https://github.com/paritytech/polkadot/blob/master/xcm/xcm-builder/src/origin_conversion.rs#L30).

Transact { origin_type, require_weight_at_most, mut call } => {
    // We assume that the Relay-chain is allowed to use transact on this parachain.
    let origin = self.origin.clone().ok_or(XcmError::BadOrigin)?;
    // TODO: #2841 #TRANSACTFILTER allow the trait to issue filters for the relay-chain
    let message_call = call.take_decoded().map_err(|_| XcmError::FailedToDecode)?;
    let dispatch_origin = Config::OriginConverter::convert_origin(origin, origin_type)
                                        .map_err(|_| XcmError::BadOrigin)?;`

and in the AssetTransactor implementation, the Convert(Multilocation, Account) implementation did the "correct" thing to convert the Multilocation to the derivative account.
I think these are kind of strong assumptions that we need to enforce to make sure the current transfer_and_transact design is secure.  We would like to have your idea on what is the proper way to enforce and handle these assumptions or what is a good alternative design here.

What I would argue instead is whether you can think of a way to introduce a new XCM instruction that sidesteps this issue. Remember, any XCM instruction is capable of having different semantics determined by the receiving chain, so if this is something that you feel like it can be generalized, then perhaps it's a really good idea to add such an operation at the XCM instruction level, rather than trying to operate around the current security constraints and instruction set. I don't have a good name for the operation that you are trying to introduce, but I will say that there is already an ExchangeAsset instruction.

Hi, hadnt seen this thread before but I would like to share my thoughts on this matter:

In general, regardless whether its tied to a Transfer or not, I think having a Transact extrinsic (that would be composed of DescendOrigin + WithdrawAsset + BuyExecution + Transact) opens a whole new set of possibilities.  We have an extrinsic in Moonbeam that does something similar (only in our test networks for now) https://github.com/PureStake/moonbeam/blob/1f1b300af5c3ae3695e7666712aed5c5af4dcb3e/pallets/xcm-transactor/src/lib.rs#L532.

With respect to the security side of things, I still cannot imagine a scenario in which this exploits an extirnsic that is not exploitable itself by regular means. The only part where I see a bit of friction is the LengthToFee mechanisms we have for non-xcm usage, which would be skipped in the case of XCM. DescendOrigin is supposed to take charge of making the sovereign account secure. Indeed, correct me if I am wrong but rococo already allows to do this https://github.com/paritytech/polkadot/blob/56e9b675407d33b34bfde4c28032386306b901fb/runtime/rococo/src/xcm_config.rs#L155 via pallet-xcm.

In the moonbeam-lido case, we dont do 2 xcm messages. First, the token you are going to use to pay for the xcm fees is burned in Moonbeam. Second, a xcm message is sent to the relay chain in the form WithdrawAsset | BUyExecution | Transact. But we wrap the transaction to be done in an as_derivative call. Essentially, Lido is using a derivative address from the Moonbeam sovereign address in the relay chain.

We are working towards making frontier also compatible with XCM-transact calls (see https://github.com/paritytech/frontier/pull/733). We consider this a key-usecase for the interoperability narrative of the polkadot ecosystem.

Also, I now recall that ClearOrigin is not in fact required to construct an XCM that passes AllowTopLevelPaidExecutionsFrom -- a missing ClearOrigin is also permitted.

Just to quickly add, for the user to 1-click transfer assets, I view this as a UX problem rather than an XCM issue. I don't see why XCM interactions should correlate 1-to-1 with user actions.

Indeed this is a UX issue, and our thinking is that it will probably have to be dealt with on different front-ends, so that's why it could be beneficial to have the solution in xtokens directly.

Also, I now recall that ClearOrigin is not in fact required to construct an XCM that passes AllowTopLevelPaidExecutionsFrom -- a missing ClearOrigin is also permitted.

The issue with ClearOrigin is not the barrier. The default xcm-executor code attaches ClearOrigin when it handles instructions used by xtokens extrinsics like DepositReserveAsset or InitiateReserveWithdraw   - https://github.com/paritytech/polkadot/blob/master/xcm/xcm-executor/src/lib.rs#L398-L421 So I cannot descend and create a unique origin for the Transact dispatchable. So that's why the second xcm message is needed. But if I understood your previous comment correctly, the XCM v3 PR will resolve this issue.

In the moonbeam-lido case, we dont do 2 xcm messages. First, the token you are going to use to pay for the xcm fees is burned in Moonbeam. Second, a xcm message is sent to the relay chain in the form WithdrawAsset | BUyExecution | Transact. But we wrap the transaction to be done in an as_derivative call. Essentially, Lido is using a derivative address from the Moonbeam sovereign address in the relay chain.

This is an example where one wouldn't need the second XCM call, the amount is burned on Moonbeam's side and withdrawn from Moonbeam's sovereign account on the relay chain and used by a derivative of the sovereign account. However this assumes that there already was a reserve transfer from relay to Moonbeam. If I'm doing a self_reserve transfer (as it's called in xtokens) this won't work, as I won't be able to withdraw anything from the sovereign account of the sender chain on the receiver chain, since there are no assumed prior transfers.

In general, regardless whether its tied to a Transfer or not, I think having a Transact extrinsic (that would be composed of DescendOrigin + WithdrawAsset + BuyExecution + Transact) opens a whole new set of possibilities.  We have an extrinsic in Moonbeam that does something similar (only in our test networks for now) https://github.com/PureStake/moonbeam/blob/1f1b300af5c3ae3695e7666712aed5c5af4dcb3e/pallets/xcm-transactor/src/lib.rs#L532.

I think the Transact must be tied to a transfer in order to not assume any prefunded accounts, sovereign or not. This way it can work for all 3 xtokens transfer cases self_reserve, to_reserver and to_non_reserve

#I think the Transact must be tied to a transfer in order to not assume any prefunded accounts, from which funds for tx fees can be withdrawn, sovereign or not. This way it can work for all 3 xtokens transfer cases self_reserve, to_reserver and to_non_reserve
While in general I agree with this (and we might move to this in the future), we had some concerns around this, specifically being:

A user willing to transact paying fees in a token not yet accepted by the origin chain. In this case there would be nothing to burn on the origin chain side.

For simplicity, lets assume there is no transfer, but rather only fees for paying the XCM messages are burnt on the origin chain and withdrawn from the sovereign on the destination side. In order to work with DescendOrigin, your message would look something like: WithdrawAsset + ClearOrigin + BuyExecution + Transact. Meaning that WithdrawAsset should happen with the parachain origin, while Transact should happen with the descended origin. Although there should (in theory) not be any issue with this, we preferred decoupling actions that required different origins.

Doing a transfer alongisde transact involves most likely additional instructions (at least DepositAsset) which some users might not be willing to pay every time they do a transact. Some users might be willing to just transfer funds once to their controlled account, and then issuing a transact assuming fees will be paid from the previously transferred funds.

Dont know if these are sufficient concerns, but maybe we can make both cases co-exist (e.g., a extrinsic with transfer_and_transact, and another one with just transact).

The issue with ClearOrigin is not the barrier. The default xcm-executor code attaches ClearOrigin when it handles instructions used by xtokens extrinsics like DepositReserveAsset or InitiateReserveWithdraw - https://github.com/paritytech/polkadot/blob/master/xcm/xcm-executor/src/lib.rs#L398-L421 So I cannot descend and create a unique origin for the Transact dispatchable. So that's why the second xcm message is needed. But if I understood your previous comment correctly, the XCM v3 PR will resolve this issue.

As it turns out, XCMv3 doesn't resolve this issue, as we can't be certain that the reserve is accurately representing the origin when it tries to modify the origin register with DescendOrigin, so sending an extra XCM directly to the destination is likely to be the only way that works.

Ok guys thanks for the attention, so here is a much cleaner draft PR against my own fork. If it has potential I can reopen against orml master: https://github.com/Manta-Network/open-runtime-module-library/pull/6
Here's what it includes:

The pallet code - transact-only and transfer_with_transact extrinsics, as well as helpers
Mock runtime barrier implementation for Transact instructions ---> AllowTransactFrom<ParentOrFriends>
Mock runtime configurations for LocationToAccountId ---> Account32Hash
transfer_with_transact unit tests for self-reserve, to-reserve and to-non-reserve scenarios
Weights for the new extrinsics
Initial documentation

As described, for the transfer_with_transact extrinsic there are 2 messages being sent to accomplish the functionality.
First a token transfer to a user sovereign account. The user sovereign account is crated from the sender multilocation as seen by the receiver chain. Concretely in the mock runtime and tests a blak256 hash is used.
Second a message is sent that first descends into the user sovereign account origin and dispatches a local extrinsic, which is decoded from the encoded call data in a Transact instruction. To pay for execution some of the transferred tokens from the first message are withdrawn, and any refund is deposited back to the user sovereign account.
The barrier implementation checks that the origin is from a configurable set of multilocations and then basically expects the exact 6 instructions in order: DescendOrigin + WithdrawAsset + BuyExecution + Transact + RefundSurplus + DepositAsset. Also replaces the dest_weight with the locally weighed value of the XCM message.
For the transact-only extrinsic only the second message is sent.
Potentially the barrier can be improved by:

checking the encoded call data length - need to submit a small PR in Polkadot for this. Seems simple enough just need to add a function that returns the length of the private vector field in DoubleEncoded .
decoding the call and match against some configurable set of allowed calls, but not sure how to do this without adding some trait bounds to the underlying ShouldExecute trait interface. This is also in Polkadot but will probably require more code change, not so easy to merge.

Besides that and probably some more more test scenarios, it seems like most of the components are in place.There are certain places in the code marked with some todos, which should be examined in more detail.
Please let me know what you think.
@KiChjang @xlc @girazoki


Allows other users besides ubuntu

http://tracker.ceph.com/issues/10086

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1637/
Test PASSed.

You're right, I shouldn't said simpler. It's the most straightforward way I found to implement the new functionality, which is to allow other usernames instead of always assuming "ubuntu".

The new tests won't pass if they run against master. For example, given foo@bar the canonicalize_hostname function returns<EMAIL_ADDRESS>

OK, fair enough; I see that failure in the original code after reviewing the original in situ.  Will this also work for<EMAIL_ADDRESS>-> ?

Depends on whether lab_domain is empty. If empty, it will do<EMAIL_ADDRESS>-><EMAIL_ADDRESS>If not (say lab_domain='ceph.com'), then this will do<EMAIL_ADDRESS>-><EMAIL_ADDRESS>Is this OK?

I see that.  OK.  I think it wouldn't hurt to add that test case, but I'm OK with it.

It's already there. test_decanonicalize_hostname_nolab() covers that case

Sigh.  I apologize for being so thick about this.
I think that<EMAIL_ADDRESS>with lab_domain set to front.sepia.ceph.com, should return<EMAIL_ADDRESS>and I think the current code will instead return
<EMAIL_ADDRESS> Does that sound right, and can we make the code handle the case of "the lab domain is already supplied and correct, so don't modify it"?

No worries. Sure, I will add that.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1644/
Test PASSed.

I had to revert this:
https://github.com/ceph/teuthology/commit/57e73e729fc7a345537f09a99887199574075db9

I was looking at the the log and couldn't figure out what was the problem in decanonicalize_hostname that caused this. If you have time, can you describe the use case? Are there any others that are not covered by the unit tests?


When suggesting IRIs, it would be nice not to suggest a conflicting IRI

Currently, when an IRI is suggested, there is no check whether or not this IRI already exists.

Use case from demo:

create attribute profile of dcterms:title on Resource
create attribute profile of dcterms:title on Distribution

In both cases, dct-title is suggested, but in the second case, it creates an IRI conflict.

@jakubklimek What should be suggested when a collision is detected? I would rather show a warning message and let user decide. The message can also be utilized for non-generated input.

Those are 2 things:

detecting a conflicting IRI regardless of whether it was autosuggested or manually entered. Coloring it red and displaying a warning would be nice.
Autosuggesting IRI which causes a conflict - is there a case this would be a good thing? I do not think so. Therefore, there should be some default strategy for avoiding the conflict (such as appending -1, -2, etc.) and when a conflict is detected, this strategy should be applied. Ideally, this would lead to not suggesting a conflicting IRI.


Returning 0 for null values

In some scenarios I would not like to be using If and Else, so I've added more validation to evidence the exception.

You can catch the UnexpectedValueException exception.


[FLINK-12409][python] Adds from_elements in TableEnvironment

What is the purpose of the change
This pull request adds the API from_elements in TableEnvironment. It's a convenient API to create a table from a collection of elements.
It works as follows:

Serializes the python data to a local file via PickleSerializer
Reads the local file and deserializes the python object and creates a DataStream from the deserialized elements in Java
Creates a Table from the created DataStream

Brief change log

Adds from_elements API in TableEnvironment
Adds PythonUtil to create a DataStream/DataSet from a file containing the serialized python objects
Adds PythonTableUtil to create a Table from a DataStream
Adds PythonTypeUtil to convert the deserialized objects according to the schema

Verifying this change
This change added tests and can be verified as follows:

Added unit test test_calc.test_from_elements

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

The CI  throws TypeError for a python test case. I have been restarted it. And make sure all the test cases work well before the review.
@flinkbot approve-until

I agree with @sunjincheng121, we must not put Python-relates code into unrelated packages.

Thanks for the reply @aljoscha!
As we(@aljoscha @dianfu and me) discussed offline, we got a consistent solution, we will put Python related Java code into
flink-python module, and we will add classifier named java-binding for the JAR. So, I appreciate if you can update the PR according to our decision. @dianfu  :)
Best, Jincheng

Sounds good. I will rebase the PR.

@sunjincheng121 Have addressed your comments and also moved all the Python related Java files to module flink-python.

@flinkbot attention @zentol

@sunjincheng121 Thanks a lot for your review. Have updated the PR accordingly.

Thanks for the quick updated! @dianfu
LGTM.
From my side, +1 to merged.

Thanks for the rebase, Merging...


[WIP] Add insert, flush, and query methods to collection

Here are the proposing changes

Client::flush_collections
Collection::create_insert_frame (temporal solution) I think it would be better to store schema inside collection itself
CollectionFieldsData and FieldData
Collection::insert
Collection::query

Hi @andreytkachenko,
Thanks for your contribution, some questions for your proposals:

the example requires the collection existed, create it if not existed would be better
create_insert_frame is nice, the users won't create wrong data schema with it, could you add a method add_batch(), which is column-oriented? It's useful for performance-sensitive cases (the parameter may be: the item of iterator is (field name,batch of data)).

Hi @andreytkachenko,
I decide to merge this PR, because the coming PRs of others are based on this, thanks for your contribution!


Added a little more negative margin

Previously the link icon was almost touching the header which made it look untidy. This adds a bit more margin so it looks neater.

👍 Thanks!

Published in version 0.7.1


[Rollkit/CosmosSDK] Attempted upgrade to v0.47.6

Summary
Human Summary
New version of Rollkit's CosmosSDK was released, and we need to keep up-to-date.
AI Summary

Summary generated by Reviewpad on 01 Dec 23 00:10 UTC
This pull request includes the following changes:

In the Tiltfile, a new package net-tools has been added to the apt-get install command.
In the Dockerfile.dev file, a step to copy the centralized sequencer address into the genesis.json file has been added. The EXPOSE statements have also been modified to document ports that will soon be changed.
In the Makefile, the localnet_regenesis target has been modified to regenerate the localnet genesis file. A comment has been added to indicate this change. Additionally, code has been added to copy the centralized sequencer address into the genesis.json file, using the temporary file temp.json.

Please let me know if you need further clarification or assistance with this code review.

Type of change
Select one or more:

[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

[ ] Run all unit tests: make go_develop_and_test
[ ] Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

[ ] I have tested my changes using the available tooling
[ ] I have performed a self-review of my own code
[ ] I have commented my code, updated documentation and left TODOs throughout the codebase

Unfortunately currently unable to upgrade, due to an error:
panic: genesisValidators[0] != req.Validators[0]
More context:

https://buildwithgrove.slack.com/archives/C05Q97X25QX/p1701223114197249
https://github.com/rollkit/docs/pull/269/files
https://github.com/rollkit/docs/pull/280

@okdas I'm noticing that in localnet/poktrolld/config/genesis.json, we have "validators": [] which may be the source of the issue.

Discussed prior to the holiday that we'll pause this work (not a priority) and go straight to v0.50.


Initial DA service sketch

Notice that traits and/or bounds may be changed. This is an initial approach and things would have to change probably a bit when piping everything together. I'll be implementing the backend and adapters after this.

Codecov Report
Patch has no changes to coverable lines.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Files Changed
Coverage

...omos-services/data-availability/src/backend/mod.rs
0.00%

nomos-services/data-availability/src/lib.rs
0.00%

:loudspeaker: Thoughts on this report? Let us know!.


Fix broken link to action

I don't know why our action isn't visible but can we fix it?

I'll contact github support


Putting an empty variable in a component's contract should fail

In Pharo 11, putting an instance variable into one of the parts that make a component's contract (i.e. consumed/producedComponentEvents, used/providedComponentServices) for a given Type automatically creates a get...Notifier method (as expected) in its implementations, but in this case leads to the creation of a getnilNotifier method. This getnilNotifier searches for notifiers at: nil, which isn't a trait that uses the MolComponentEvents trait.
Instead of this current behavior, the compilator should return an error when putting an empty instance variable into one or multiple parts of a component's contract.

Thanks @Eliott-Guevel !

@Eliott-Guevel could you give to me an example ?

Putting an empty game instance variable for the GameConsole type

leads to the creation of a getnilSubscriber method in SNES (a GameConsole implementation) (after using the define all components option)

Ohhh ok :)
We work on it :)

Problem when declaring a variable into a Trait class side (for making the test).

Bug fixed but this mistake bring some unstability problem of the image.


Please I am waiting

Please I am waiting
This problem worried me
Please help me as soon as possible

Let's follow up on this in https://github.com/tiktok/gtm-template-pixel/issues/2


Laravel + Vitess Compatibility

Vitess is a database clustering system for horizontal scaling of MySQL (born at youtube)
In order for us to connect our framework to vitess we can disable sending this construct
set this option first.
'options' => array(
                PDO::ATTR_EMULATE_PREPARES => true
             ),
vitess => true,

then code change on src/Illuminate/Database/Connectors/MySqlConnector.php
    {
        if (isset($config['modes'])) {
            $this->setCustomModes($connection, $config);
        } elseif (isset($config['strict'])) {
            if ($config['strict']) {
                $connection->prepare($this->strictMode($connection))->execute();
            } else {
                if(!$config['vitess'])
                $connection->prepare("set session sql_mode='NO_ENGINE_SUBSTITUTION'")->execute();
            }
        }
  }

Heya, thanks for submitting this. This seems like a feature request or an improvement. It's best to post these at the laravel/ideas repository to get support for your idea. After that you may send a PR to the framework. Please only use this issue tracker to report bugs and issues with the framework.

Actually though it's really a feature request, my question is if you set the modes => null it shouldn't
execute  $connection->prepare("set session sql_mode='NO_ENGINE_SUBSTITUTION'")->execute();

@hellracer Sorry but I still consider this to be a feature request so please open up an issue at the ideas repo.


[!] OS is not supported!

[!] OS is not supported!
I am getting the above error after a successful build
Someone please help...

MINGW64 is not supported currently. Use Kali Linux instead

MINGW64 is not supported currently. Use Kali Linux instead

But how is it supposed to run on Windows i just need it to start installing

MINGW64 is not supported currently. Use Kali Linux instead

I wanted it to run on Windows 10


Should -Inf be interpreted as a NULL value

See:
https://github.com/enram/vpts/blob/c726842e60515d33fdf0f97343858a40f603b20c/table-schemas/vol2bird.json#L192
Note: if we don't do this, it will lead to type validation errors.

I hijack this issue to push the question a bit further: in vol2bird's output, we find several different "not a number" values for columns such as ff, dbz, ...
For example:

-inf (negative infinity?)
nodata (actual data value -1000, but metadata says -1000 == nodata)
undetect (actual data value -999.0, but metadata says -999.0 == undetect)

In the case of the vpts "standard", do we want to keep all the nuances and have 3 different values ? Or is it "good enough" to normalize them to a single one?
Any opinion? @peterdesmet, @CeciliaNilsson709 , @adokter ?

For implementation, we have two options:

Nuances are lost in data: transform nuances to empty values when vptstools writes to CSV
Nuances are lost when reading: keep the nuances in the data, but document them as to be interpreted as empty values by any reader. This can be done in missingValues.

I'm in favour of 2. @adokter what nuances should we allow?

Since we are discussing the standard here, I think the right question is: from a data consumer standpoint, how useful/important is it to distinguish between those different kinds of non-data:

If it's a very niche usage: let's keep things simple and only keep a single value (null?)(subsequent implementation: converters will convert all three to this null value (data loss)/ consumers will have no way to distinguish those values
If that's an important nuance, let's express them as 3 different things in the data: consumers will then be able to choose if they want to distinguish those values or not for their use-case. The standard would work for more use-cases, the drawback is that it makes it slightly more complex.

Another way to think of it is: "when we later start building VPTS files from other sources (CAJUN?): will those nuances still make sense or not?"

For users it is important to distinguish between 0, -Inf, nodata and undetect (and bioRad plotting functions already use this info, not niche usage).
Instead of giving options to users, I feel it's important to force / strongly encourage users to be aware of the distinction between zero, nodata and undetect, as it's a potential source of confusion and incorrect interpretation of the data.
For NaN there is currently a double usage: both for undetect, and for cases where the algorithm failed to calculate a quantity, e.g. due to incomplete or insufficient data. So you could split those two (but that requires a change to vol2bird)
Re: how to code things in csv: -Inf is the equivalent of zero for logarithmic quantities like DBZH and dbz, so you could get rid of it by storing these as zero on a linear scale (although that is quite uncommon). There is no NULL value currently in use, so you could code NaN as NULL if that makes things easier

So, -Inf should not be interpreted as Null, but as 0 on a logarithmic scale

Thanks @adokter: I will check exactly how to do it best in CSV/frictionless, but I definitely wants to keep the distinction between 0, -inf, nodata and undetect (I might come back to you if I need more precision about those).
About, For NaN there is currently a double usage: both for undetect, and for cases where the algorithm failed to calculate a quantity, e.g. due to incomplete or insufficient data. So you could split those two (but that requires a change to vol2bird): are you referring to the CSV (console) output of vol2bird? My current implementation of vph5_to_vpts  doesn't use it, but the ODIM vertical profiles in h5 format. At first look I saw no NaN values there. So if I'm not mistaken, we have everything we need already, without requiring a change to vol2bird. Is that correct?

You're right, I was referring to the CSV output - in the hdf5 profiles the nodata and undetect are coded with an explicit value that is stored as an attribute.

If I'm not mistaken, the conclusion/decision here is that the standard should distinguish between -inf, nodata and undetect for different variables.
For clarity, I suggest closing this issue and discussing how to achieve that in a different one.


python312Packages.yalexs: 6.4.2 -> 6.4.3

Diff: https://github.com/bdraco/yalexs/compare/refs/tags/v6.4.2...v6.4.3
Changelog: https://github.com/bdraco/yalexs/releases/tag/v6.4.3
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 332065 run on x86_64-linux 1

9 packages built:

home-assistant-component-tests.august
python311Packages.freenub
python311Packages.freenub.dist
python311Packages.yalexs
python311Packages.yalexs.dist
python312Packages.freenub
python312Packages.freenub.dist
python312Packages.yalexs
python312Packages.yalexs.dist


Added link to plunker demo.

This commit corrects the plnkr URL.  If you merge this it's simply adding a link to a demo making use of your JavaScript file to let people hear it in all it's glory.


Added a "number of threads" argument

Added the number of threads argument and created a separate function that contains the resources' parameters.
The changes are only local to offline_transucer_asr.py and will propagate if the overall structure is approved.

Thanks for your contribution!


Support different versions of common types

Today we are generating v2 of the common types only and placing them into Azure.ResourceManager.Models, which will have issues in the long term: there are two other versions of the common types and each RP snaps to a different version and some RPs snap to multiple versions.  We will eventually need to generate something that works for all of them since customers can include RPs that snap to different types in their program.

In common-types\resource-management swagger there have 4 versions, and currently autorest.csharp take v2, ARM team prefer service team to use v3 but still lots of RPs are using v2, or even v1.
To mgmt. sdk, the major change between v2 and v3 is the common type 'Resource', v3 add a new property 'systemData', so what we want to do is keeping using v2 for GA, then after GA we can upgrade to support v3 which need us to upgrade the matching algorithm that can be compatible with both v2 and v3.


Fixing types of maximumValue and minimumValue from Slider component

When using string, the runtime gives me a dynamic type error as the
following: "TypeError:expected dynamic type 'double',but had type
'string'"
This commit fixes this problem.

Thanks!


Allow etag and last_modified to be specified when creating Whitehall assets via API

Add optional legacy_etag & legacy_last_modified parameters for the API endpoint which allows creation of Whitehall assets. We're going to need these when we move existing Whitehall assets to Asset Manager in order to avoid wholesale cache invalidation. See #234 for more details.
I've chosen to use legacy_xxx vs just xxx as the parameter names, because once we've moved the existing Whitehall assets to Asset Manager they will become redundant. Hopefully the names will also discourage anyone from using the parameters in any of the other publishing apps.
I've aliased WhitehallAsset#legacy_xxx= to Asset#xxx= partly in recognition that we'll only ever need to set Asset#xxx via the API when we move existing Whitehall assets to Asset Manager and partly to keep the code as simple as possible. I think it's correct that the canonical reader method is still just Asset#xxx vs Asset#legacy_xxx, because that code is used more generally within Asset Manager.
I think there is a case for preventing calls to Asset#etag= or Asset#last_modified= except from within Asset#store_metadata which is called after creation of an Asset, but I'm not sure it's that important so I haven't done anything about it for now.

I've opened alphagov/gds-api-adapters#760 to document these new optional attributes.

I've added notes to the descriptions for #215 & #216 to remind us to set legacy_etag and legacy_last_modified when migrating existing Whitehall assets to Asset Manager in order to avoid wholesale cache invalidation.


[HOT] [TEST] Disable a Test that Requires Nested Union Support.

What changes were proposed in this pull request?
Since "[SPARK-13321][SQL] Support nested UNION in parser" is reverted, we need to disable the test case that requires this PR. Thanks!
@rxin @yhuai @marmbrus
How was this patch tested?
N/A

I'm going to merge this in master.


[BUG] Unable to create snapshot: cannot get engine client because it isn't deployed

Describe the bug (🐛 if you encounter this issue)
Run test case test_engine_image_daemonset_restart Repeatedly. After engine image DaemonSet restarted, even though the engine image status.conditions[0].status has become True:
status:
    buildDate: "2023-12-05T06:21:33+00:00"
    cliAPIMinVersion: 3
    cliAPIVersion: 9
    conditions:
    - lastProbeTime: ""
      lastTransitionTime: "2023-12-25T09:44:10Z"
      message: Engine image ei-b907910b (longhornio/longhorn-engine:master-head) is
        fully deployed on all ready nodes
      reason: ""
      status: "True"
      type: ready

It failed at create_snapshot step with error message with reproducibility ~ 20%:
longhorn.ApiError: (ApiError(...), '500 :
failed to create snapshot: cannot get client for volume longhorn-testvol-rayxu0 on node ip-10-0-2-245: cannot get engine client with image longhornio/longhorn-engine:master-head because it isn\'t deployed\n
{\'code\': 500, \'detail\': \'\', \'message\': "failed to create snapshot: cannot get client for volume longhorn-testvol-rayxu0 on node ip-10-0-2-245: cannot get engine client with image longhornio/longhorn-engine:master-head because it isn\'t deployed", \'status\': 500}')

https://ci.longhorn.io/job/private/job/longhorn-tests-regression/5560/
Not sure if it's a bug or the test case needs to be refined.
To Reproduce
Run test case test_engine_image_daemonset_restart Repeatedly
Expected behavior

Support bundle for troubleshooting

Environment

Longhorn version: master-head
Installation method (e.g. Rancher Catalog App/Helm/Kubectl):
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:

Number of management node in the cluster:
Number of worker node in the cluster:

Node config

OS type and version:
Kernel version:
CPU per node:
Memory per node:
Disk type(e.g. SSD/NVMe/HDD):
Network bandwidth between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster:
Impacted Longhorn resources:

Volume names:

Additional context

From master? this should be a transient issue while merging some v2 changes. Let's revisit this issue later after all related PRs are merged.
cc @derekbit @shuo-wu

Hi @yangchiu How did you capture the state of the engine image at the time the test failed?
status:
    buildDate: "2023-12-05T06:21:33+00:00"
    cliAPIMinVersion: 3
    cliAPIVersion: 9
    conditions:
    - lastProbeTime: ""
      lastTransitionTime: "2023-12-25T09:44:10Z"
      message: Engine image ei-b907910b (longhornio/longhorn-engine:master-head) is
        fully deployed on all ready nodes
      reason: ""
      status: "True"
      type: ready

The test case will check the status before taking a snapshot:
# Wait for the restart complete
common.wait_for_engine_image_condition(client, default_img.name, "True")

# Longhorn is still able to use the corresponding engine binary to
# operate snapshot
check_volume_data(volume, snap1_data)
snap2_data = write_volume_random_data(volume)
create_snapshot(client, volume_name)

Which ensure image['conditions'][0]['status'] = True

Analysis
When deleting the engineimage daemonset (similar to the test step test_engine_image_daemonset_restart), watching the status of engineimage CR shows that the status.state normal becomes deploying then deployed. However, sometime, it could transition to deploying -> deployed -> deploying -> deployed like this:
---
apiVersion: longhorn.io/v1beta2
kind: EngineImage
metadata:
  creationTimestamp: "2023-12-27T00:20:43Z"
  finalizers:
  - longhorn.io
  generation: 1
  labels:
    longhorn.io/component: engine-image
    longhorn.io/engine-image: ei-b907910b
    longhorn.io/managed-by: longhorn-manager
  name: ei-b907910b
  namespace: longhorn-system
  resourceVersion: "609096"
  uid: 0bfb1dca-b8d9-4d3a-88b8-206369986dee
spec:
  image: longhornio/longhorn-engine:master-head
status:
  buildDate: "2023-12-05T06:21:33+00:00"
  cliAPIMinVersion: 3
  cliAPIVersion: 9
  conditions:
  - lastProbeTime: ""
    lastTransitionTime: "2023-12-27T21:26:55Z"
    message: engine binary check failed
    reason: daemonSet
    status: "False"
    type: ready
  controllerAPIMinVersion: 3
  controllerAPIVersion: 5
  dataFormatMinVersion: 1
  dataFormatVersion: 1
  gitCommit: 014125a20fd26e78be607365b6d090fe93d1f00f
  noRefSince: "2023-12-27T21:10:00Z"
  nodeDeploymentMap:
    phan-v607-engine-image-pool2-e1b8ff09-cmchx: false
    phan-v607-engine-image-pool2-e1b8ff09-ktjfk: true
    phan-v607-engine-image-pool2-e1b8ff09-nk75k: true
  ownerID: phan-v607-engine-image-pool2-e1b8ff09-nk75k
  refCount: 0
  state: deploying
  version: 014125a2
---
apiVersion: longhorn.io/v1beta2
kind: EngineImage
metadata:
  creationTimestamp: "2023-12-27T00:20:43Z"
  finalizers:
  - longhorn.io
  generation: 1
  labels:
    longhorn.io/component: engine-image
    longhorn.io/engine-image: ei-b907910b
    longhorn.io/managed-by: longhorn-manager
  name: ei-b907910b
  namespace: longhorn-system
  resourceVersion: "609150"
  uid: 0bfb1dca-b8d9-4d3a-88b8-206369986dee
spec:
  image: longhornio/longhorn-engine:master-head
status:
  buildDate: "2023-12-05T06:21:33+00:00"
  cliAPIMinVersion: 3
  cliAPIVersion: 9
  conditions:
  - lastProbeTime: ""
    lastTransitionTime: "2023-12-27T21:26:59Z"
    message: Engine image ei-b907910b (longhornio/longhorn-engine:master-head) is
      fully deployed on all ready nodes
    reason: ""
    status: "True"
    type: ready
  controllerAPIMinVersion: 3
  controllerAPIVersion: 5
  dataFormatMinVersion: 1
  dataFormatVersion: 1
  gitCommit: 014125a20fd26e78be607365b6d090fe93d1f00f
  noRefSince: "2023-12-27T21:10:00Z"
  nodeDeploymentMap:
    phan-v607-engine-image-pool2-e1b8ff09-cmchx: true
    phan-v607-engine-image-pool2-e1b8ff09-ktjfk: true
    phan-v607-engine-image-pool2-e1b8ff09-nk75k: true
  ownerID: phan-v607-engine-image-pool2-e1b8ff09-nk75k
  refCount: 0
  state: deployed
  version: 014125a2
---
apiVersion: longhorn.io/v1beta2
kind: EngineImage
metadata:
  creationTimestamp: "2023-12-27T00:20:43Z"
  finalizers:
  - longhorn.io
  generation: 1
  labels:
    longhorn.io/component: engine-image
    longhorn.io/engine-image: ei-b907910b
    longhorn.io/managed-by: longhorn-manager
  name: ei-b907910b
  namespace: longhorn-system
  resourceVersion: "609161"
  uid: 0bfb1dca-b8d9-4d3a-88b8-206369986dee
spec:
  image: longhornio/longhorn-engine:master-head
status:
  buildDate: "2023-12-05T06:21:33+00:00"
  cliAPIMinVersion: 3
  cliAPIVersion: 9
  conditions:
  - lastProbeTime: ""
    lastTransitionTime: "2023-12-27T21:27:01Z"
    message: 'Engine image is not fully deployed on all nodes: 2 of 3'
    reason: daemonSet
    status: "False"
    type: ready
  controllerAPIMinVersion: 3
  controllerAPIVersion: 5
  dataFormatMinVersion: 1
  dataFormatVersion: 1
  gitCommit: 014125a20fd26e78be607365b6d090fe93d1f00f
  noRefSince: "2023-12-27T21:10:00Z"
  nodeDeploymentMap:
    phan-v607-engine-image-pool2-e1b8ff09-cmchx: true
    phan-v607-engine-image-pool2-e1b8ff09-ktjfk: true
    phan-v607-engine-image-pool2-e1b8ff09-nk75k: false
  ownerID: phan-v607-engine-image-pool2-e1b8ff09-nk75k
  refCount: 0
  state: deploying
  version: 014125a2
---
apiVersion: longhorn.io/v1beta2
kind: EngineImage
metadata:
  creationTimestamp: "2023-12-27T00:20:43Z"
  finalizers:
  - longhorn.io
  generation: 1
  labels:
    longhorn.io/component: engine-image
    longhorn.io/engine-image: ei-b907910b
    longhorn.io/managed-by: longhorn-manager
  name: ei-b907910b
  namespace: longhorn-system
  resourceVersion: "609162"
  uid: 0bfb1dca-b8d9-4d3a-88b8-206369986dee
spec:
  image: longhornio/longhorn-engine:master-head
status:
  buildDate: "2023-12-05T06:21:33+00:00"
  cliAPIMinVersion: 3
  cliAPIVersion: 9
  conditions:
  - lastProbeTime: ""
    lastTransitionTime: "2023-12-27T21:27:01Z"
    message: 'Engine image is not fully deployed on all nodes: 2 of 3'
    reason: daemonSet
    status: "False"
    type: ready
  controllerAPIMinVersion: 3
  controllerAPIVersion: 5
  dataFormatMinVersion: 1
  dataFormatVersion: 1
  gitCommit: 014125a20fd26e78be607365b6d090fe93d1f00f
  noRefSince: "2023-12-27T21:10:00Z"
  nodeDeploymentMap:
    phan-v607-engine-image-pool2-e1b8ff09-cmchx: true
    phan-v607-engine-image-pool2-e1b8ff09-ktjfk: true
    phan-v607-engine-image-pool2-e1b8ff09-nk75k: false
  ownerID: phan-v607-engine-image-pool2-e1b8ff09-ktjfk
  refCount: 0
  state: deploying
  version: 014125a2
---
apiVersion: longhorn.io/v1beta2
kind: EngineImage
metadata:
  creationTimestamp: "2023-12-27T00:20:43Z"
  finalizers:
  - longhorn.io
  generation: 1
  labels:
    longhorn.io/component: engine-image
    longhorn.io/engine-image: ei-b907910b
    longhorn.io/managed-by: longhorn-manager
  name: ei-b907910b
  namespace: longhorn-system
  resourceVersion: "609165"
  uid: 0bfb1dca-b8d9-4d3a-88b8-206369986dee
spec:
  image: longhornio/longhorn-engine:master-head
status:
  buildDate: "2023-12-05T06:21:33+00:00"
  cliAPIMinVersion: 3
  cliAPIVersion: 9
  conditions:
  - lastProbeTime: ""
    lastTransitionTime: "2023-12-27T21:27:01Z"
    message: Engine image ei-b907910b (longhornio/longhorn-engine:master-head) is
      fully deployed on all ready nodes
    reason: ""
    status: "True"
    type: ready
  controllerAPIMinVersion: 3
  controllerAPIVersion: 5
  dataFormatMinVersion: 1
  dataFormatVersion: 1
  gitCommit: 014125a20fd26e78be607365b6d090fe93d1f00f
  noRefSince: "2023-12-27T21:10:00Z"
  nodeDeploymentMap:
    phan-v607-engine-image-pool2-e1b8ff09-cmchx: true
    phan-v607-engine-image-pool2-e1b8ff09-ktjfk: true
    phan-v607-engine-image-pool2-e1b8ff09-nk75k: true
  ownerID: phan-v607-engine-image-pool2-e1b8ff09-ktjfk
  refCount: 0
  state: deployed
  version: 014125a2
---

The flapping flow deploying -> deployed -> deploying -> deployed may caused by the fact that the engine image pods are being restarted and come up not at perfectly the same time like:

Start with 3 healthy engine image pods (pod-1, pod-2, pod-3)  -> engineimage.status.state is deployed (and the ready condition is true)
Kill the engineimage daemonset
pod-1 is being terminated  -> engineimage.status.state becomes deploying (and the ready condition is false)
pod-1-new becomes healthy -> engineimage.status.state becomes deployed (and the ready condition is true)
pod-2 is being terminated  -> engineimage.status.state becomes deploying (and the ready condition is false)
pod-2-new becomes healthy -> engineimage.status.state becomes deployed (and the ready condition is true)
...

I think this behavior is not a bug in Longhorn. We just need to adjust the e2e test so that it doesn't expect the engineimage.status to strictly follow the flow deploying -> deployed when deleting engineimage daemonset. The e2e test should expect that sometimes the engineimage.status may have a flapping flow deploying -> deployed -> deploying -> deployed. One approach is making sure the e2e waits for engineimage.status to remain stably in deployed for a certain period of time before continuing the test.

Verified passed on master-head (longhorn-tests 9b36237) by running test case test_engine_image_daemonset_restart for 10 times.
Test results: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/5733/ ~ https://ci.longhorn.io/job/private/job/longhorn-tests-regression/5742/


Expanded definition and overview

Elaborated on the data structure that is block chain, also added some information around a popular blockchain implementation called bitcoin

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Looks good to me, and congratulations on your first Pull Request!  🎉🎉🎉
We look forward to future contributions!


Nick: Watch opstree.com

Nick requests the watch of the watch_keyword opstree\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

opstree\.com has been seen in 1 true positive, 5 false positives, and 0 NAAs.

Rejected by Jeff Schaller in Charcoal HQ. Reason: 'watching a tighter version of this to exclude some common FP'


non-alpha picker

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
All input types include alpha. While you can disable opacity in the options, the input will still allow you to enter an alpha value.
What is the expected behavior?
Is it possible for the picker to return hex instead of hexa, rgb instead of rgba etc, when opacity is disabled? Or for a specific setting to initiate the picker in a 'non-alpha' mode?
Your environment:
Pickr-version (see Pickr.version): 1.0.0-beta
Used Pickr-bundle (es5 or normal one): normal
Browser-version:  chrome 75.0.3770.90
Operating-system:  win10

Good idea! I'll take a look at it :)

Okay, I think one solution would be to ignore the opacity part, though it's always possible to use rgb / hsl... without the a part. Forbidding all inputs which contain a alpha value (e.g. hsla, rgba...) would require a lot of more code - and therefore increase the code-base drastically (And I still try to keep it as small as possible).
My idea is to lock opacity at 1 if the user tries to enter something like rgba(32, 52, 122, 0.3), calling
pickr.getColor().toRGBA().toString(0) // 0 param is new: round values

would therefore result in rgba(32, 52, 122, 1). This could be implemented in a few lines and wouldn't require that many changes...
Any thoughts?

that would work in theory. The problem would be with input enabled, that the users would see a fouth param to change, and seeing it default to 1. Without providing an explanation this could cause confusion.
I haven't looked into the picker code in detail yet, so please tell me if it's not possible (or way too much work),
But would it be possible to add input types? like you can dis/enable hex(a), rgba, hsla, hsva?
If hex, rgb, hsl, hsa were added, with it you could toggle separate input handling?

Okay, I've added it. You can use lockOpacity: true in options to do so.
After it the user won't be able anymore to enter any type with alpha value, the buttons will show the schemas without an a and the opacity slider will be removed.
Checkout this demo: https://jsfiddle.net/Simonwep/psdokgr1/
It was a lot of refactoring and many changes must be done, please check it out and be sure everything works as you expect :)

perfect. exactly what I was looking for 👍

Available in 1.2.0 :)


fix acme operations when using multiple accounts

acme.sh stores some account-related information in
/var/etc/acme-client/home/ca
this leads to "validation failed" messages every time a certificate
with a different account is validated
this is fixed by adding ACCOUNT_JSON_PATH and CA_CONF to account.conf

@ghostwheel42 Thanks for your report!  Please excuse my confusion. :)


oncodrive and OncodriveCLUSTL

I was interested to try the oncodrive function but I noticed that the OncodriveCLUST is now outdated (see a message on the corresponding webpage:http://bg.upf.edu/group/projects/oncodrive-clust.php) and that now there is new algorithm OncodriveCLUSTL so I was wondering if it will be or not implemented in maftools to decide how to proceed.

Hi,
Thanks for pointing it out. I was not aware of the updates made. However, I have not immediate plans to implement it into maftools :|


Cache dir for downloads

Look for environment variable CROSSWALK_APP_TOOLS_DOWNLOAD_DIR and cache downloads there, so tests run faster when this is being used.

Closing, we're searching in the parent dir anyway. Commit db4df77


[BugFix] Make storage volume sql test stable

Problem Summary:
Fixes # (issue)
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:disappointed: fail : 1 / 5 (20.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
0
4
00.00%
[2574, 2575, 2576, 2577]

:large_blue_circle:
com/starrocks/common/ErrorCode.java
1
1
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/StorageVolumeAnalyzer.java
1
1
100.00%
[]


The problem is Texture And the lines

Tested versions
4.2
System information
Mobile / Android
Issue description
Hello, the problem is when adding Texture To a solid, for example, a large world of approx 30kilometer Width and length And raise the UV1 to 30,000 And activate Triplanar In the middle of the world there is no problem, but when you move away from the center of the world, there is a problem of lines and squares as well. These are some pictures and this project.
In the first picture, there is no problem because it is in the center of the world

The second and third when moving away from the center of the world

This project
the problem(Copy).zip
Steps to reproduce
I want it to stay the same filter If the squares and lines visible on the line disappear Texture
Minimal reproduction project (MRP)
Thank you for helping us

Seems likely to be float precision issues. Check this page for general guidance on what to do when dealing with very large worlds: https://docs.godotengine.org/en/stable/tutorials/physics/large_world_coordinates.html.
However, from that page:

Triplanar mapping doesn't benefit from increased precision. Materials using triplanar mapping will exhibit visible jittering when far away from the world origin.

Can you explain to me, I don't understand what's going on

Can you explain to me, I don't understand what's going on

When dealing with very large values, floats start losing precision, and may no longer be able to encode a specific value without rounding it to a noticeably different value.
For example, between values 8388608 and 16777216, the precision has degraded to only 0.5, and you're only able to encode values on that increment, such as 8388608.0, 8388608.5, 8388609.0 and so forth. If you try to encode 8388608.3, it gets rounded to either 8388608.0 or 8388608.5 (not sure which one right now), causing either an error of 0.3 or 0.2 regarding the original value.
Long story short; this is a limitation of how floating point numbers are encoded. These problems only become noticeable if you work with values that begin to approach these limits. You can compile the engine with double precision floats to reduce the issue, but still, your world is already too big. There are other techniques you can do to prevent this, such as origin shifting.

❤Thank you. I searched for months and finally found the solution. Thank you

Closing per the above comments.


page break in between text line while convert html to pdf

@eKoopmans
Hii sir,
i am facing an issue in the html2pdf.js
when i convert my section into pdf through the html2pdf then it break the page in between text please see the screen shot below

and this is my html2pdf configuration
code :-
function exportToPDF() {
var element = document.getElementById('invoice');
var opt = {
// margin: [0.3, 0.3, 0.3, 0.3],
mode: ['legacy'], margin: [0.2, 0.1, 0.6, 0.2],
filename: 'Audit-Report.pdf',
enableLinks: false,
// pagebreak: {
// avoid: '.no-split',
// mode: ['avoid-all', 'css', 'legacy']
// },
pagebreak: {mode: 'css', after: '.section_wise_div'},
image: {
type: 'jpeg',
quality: 1
},
html2canvas: {
scale: 4
},
jsPDF: {
unit: 'in',
format: [7.5, 12], ////'a4',
orientation: 'landscape'
}
};
html2pdf().from(element).set(opt).toPdf().get('pdf').then(function(pdf) {
var totalPages = pdf.internal.getNumberOfPages();
for (i = 1; i <= totalPages; i++) {
pdf.setPage(i);
pdf.addImage("http://localhost/glocoach_dev/new_glocoach/images/analytical_report_images/report_footer.png", "PNG", 0, pdf.internal.pageSize.getHeight() - 0.49, 12.2, 0); //second last is width and third last is height
}
}).save();
}
so do you have any solution regarding this ?

I've solved with this code:
      ```

var body = document.body
var html = document.documentElement
var height = Math.max(body.scrollHeight, body.offsetHeight,
html.clientHeight, html.scrollHeight, html.offsetHeight)
var element = document.querySelector('#content')
var heightCM = height / 35.35
  var opt = {
	margin: 1,
	filename: file_name + '.pdf',
	html2canvas: { dpi: 192, letterRendering: true },
	jsPDF: {
		orientation: 'portrait',
		unit: 'cm',
		format: [heightCM, 33]
	  }
  };

Hii @ikaroweb
Thanks for your response
hope you are doing well, i am using your solution which good for single page or a4 portage page and actually i am generating an landscape format PDF with the larger amount data and i want to shift the overlapped text into next page of PDF which is already in real time happen but sometime it breaks the text content also when rest larger text moved into next page so i want to move out from this problem .

do you have any solution or any temporary way regarding this ?

Try to add more margin on bottom

ikaroweb

but why?