leiningen: 2.9.6 -> 2.9.7

Motivation for this change
Upgrade Leiningen to 2.9.7.
The jar no longer has a zip file extension to workaround a GitHub issue.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 140053 run on x86_64-linux 1

1 package built:

leiningen


Update ba-minigame to 1.66

Fixes the currently broken menu entry reorder for the "tell-defensive" option on the collector horn.

You can add an authors field as is here: https://github.com/runelite/plugin-hub/blob/master/plugins/osrs-wiki-crowdsourcing


fix: speedup docs rendering

Fix werf compose up for "real time" development.
Add jekyll_base image (as in werf/website).
Use include-cached plugin to render sidebar.
Change js that activate sidebar item.

TODO fix js: expand first level items on page load.


Add usage of NodeJS/NPM in compose files.

Current master branch of Akeneo introduced the use of webpack to manage the assets of the PIM. What's more, NPM and grunt are currently necessary to run static analysis and tests on CSS and JS files.

[ ] For Akeneo 1.7 and previous, add digitallyseamless/nodejs-bower-grunt:5 image to compose examples
[ ] For Akeneo master (next version), add node:8 image (also provides NPM) to compose examples
[ ] Remove oro:requirejs from pim-initialize and pim-assets in akeneo-fpm:php-7.1, as this command does not exists anymore in Akeneo master
[ ] Documentation should be updated to explain how to use those images:

[ ] they do not have a process that keep them alive, so containers should be instantiated just when needed
[ ] the PIM have to be shared as volume with in /home/docker/pim (mandatory for symlinks to run), but container must be run as node user (exists in node image, with UID 1000, like docker user)
[ ] add that carcel/akeneo-fpm:php-7.1 is only to be used with Akeneo version following 1.7, and that 1.7 and previous should only be run with carcel/akeneo-apache:php-5.6, all other flavors being experimental.

[ ] Remove carcel/akeneo-apache from master branch and Docker hub (it will not exists in PHP 7.2)

See issue https://github.com/damien-carcel/Dockerfiles/issues/225.

Hi,
Locally, I added this in my docker-compose.yml
  nodejs:
    build: docker/node/
    image: nidup/pim-node
    volumes:
      - .:/home/docker/pim
    depends_on:
      - akeneo
    user: 1000:1000
    tty: true

My node/DockerFile only contains the following command to use the same path than in akeneo container,
FROM node:boron

# Create app directory
RUN mkdir -p /home/docker/pim
WORKDIR /home/docker/pim

Maybe we can avoid this but i don't know how to avoid to create the folder here (still discovering docker ;) ).
Then, I run the classic install command + the npm & webpack stuff like this:
docker-compose exec akeneo php -d memory_limit=-1 /usr/local/bin/composer update
docker-compose exec akeneo pim-initialize

docker-compose exec akeneo app/console pim:installer:dump-require-paths
docker-compose exec akeneo app/console assets:install --symlink
docker-compose exec nodejs npm install
docker-compose exec nodejs npm run webpack

It works in production mode.
I still have the group by mode stuff problem with mysql conf (not related to this issue, cf https://github.com/damien-carcel/Dockerfiles/issues/225 + configure a my.cnf)
I also have an issue in dev mode, it fails to load http://localhost:8080/app_dev.php/css/pim.css  and js translations. Dunno yet why.

Hi @nidup.
Thank you, I will try that on my side as soon as possible, see if we can avoir the creation of the directory.
For MySQL 5.7, indeed, I will soon add it to the doc.
Meanwhile, this is what I use:
  mysql:
    image: mysql:5.7
    environment:
      - MYSQL_ROOT_PASSWORD=root
      - MYSQL_USER=akeneo_pim
      - MYSQL_PASSWORD=akeneo_pim
      - MYSQL_DATABASE=akeneo_pim
    ports:
      - '3306:3306'
    volumes:
      - ./docker/mysql.cnf:/etc/mysql/conf.d/sql_modes.cnf
    networks:
      - akeneo

The mysql.cnf file contains the following:
[mysqld]
sql_mode=ERROR_FOR_DIVISION_BY_ZERO,NO_ZERO_IN_DATE,NO_ZERO_DATE,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION

Just had to try it, node image contains a node user with UID and GID 1000, like docker user in my images. So it can works as it is :tada:

  node:
    image: node:8
    user: node
    volumes:
      - ./:/srv/pim
      - ~/.npm:/home/node/.npm
    working_dir: /srv/pim
    networks:
      - akeneo
      - behat

With this new service, one can init the PIM with

docker-composer run node npm install
docker-composer run node npm run webpack


Added Type Definitions

Added type definitions for formatDuration
Thanks for the small yet useful library! :)

@bcomnes I have successfully avoided getting slurped into the world of TypeScript maintenance so far. Any downsides to this? I know in the past other libraries have recommended maintaining types separately through some third party type definition aggregation library or something.

My only preference would be to use js-doc, unless this offers a speific-to-this-library advantage with the index.d.ts approach. That way you get the little poppy uppy docs in your ed and I think type checking.

@guytepper can you get the same mileage out of just modifying the main file to have the function definition in jsdoc?

Sure, but I think it might result in a more complicated flow - at least that's how it seems.
But I haven't done the jsdoc-to-ts approach before so I might be wrong here - @bcomnes have you ever done that?

Thats converting types. If types are defined in a module as a js-doc, TS should pick those up automatically without work. .d.ts definitely has more capabilities and features, but in the case of this module, we would not be using any of those.  Let me draft up an example (based on your work).

@guytepper Ok, I converted it over here https://github.com/hypermodules/format-duration/pull/6
I'm going to publish a beta version, would you be willing to test it out and let me know if it works (or doesn't work) to the level you expect?

@ungoldman can you give me publish rights on npm? I'm going to try this out as a beta

@bcomnes you should be added now!

lol wait!!!!
look at this: https://www.npmjs.com/package/@types/format-duration

I knew this sounded familiar https://github.com/DefinitelyTyped/DefinitelyTyped/pull/21893

I think thats the workaround people have to install additionally if they want types.

yup, I'd prefer to not install an additional package for getting types :)
ready to report once the beta gets released!

Ok, I published a beta tag (1.3.2-beta.0) @guytepper can you let me know if that works for you?

It doesn't seem to be working, the type declarations are not found. You can see an example here

K, gonna play around with it.

Just messed up and accidentally published on the latest channel. I wen't ahead and republished a version ahead since you can't unpublish on npm any more. Sorry for the noise, npm is unforgiving if you hit enter too early.

Ok, so I did a little bit of digging to finally figure this out.
So TS doesn't actually consume JSDoc strings from node_modules, because of performance or reasons. But you can author a typed module from JSDoc strings, you just need to adopt the ts toolchain and add a build step. @voxpelli wrote a great article on this method:
https://voxpelli.com/2019/10/use-type-script-3-7-to-generate/
I don't want to do that here. What I would be fine with:

Landing this and just calling it good. Yay for doccy poppy uppys.

or

Be a conservative maintainer and just declare that types are not really going to help anyone with a function this small, and that if you really want types just use automaticTypeAquisition. (that isn't to say I don't appreciate your time and effort @guytepper, I do, thank you)

@ungoldman your call.
Glad to have finally figured this question I had out about the usefulness of JSDocs though.

Thanks for that information.
In that case I wonder why not to go with the index.d.ts method - isn't it better than not having types at all?
I'm using this function frequently in a project and it'd be nice to have the benefits TS provides

@bcomnes I don't feel strongly either way. if you both want to just merge and call it good I'm fine with that.

OK we can just land this then.

released as 1.4.0


Update BattleBit Remastered

Game Title
BattleBit Remastered
Status of the Anti-Cheat
👍 Running
Tinkering Steps
I played BattleBit Remastered via Steam Proton (Ubuntu 20.04) on official servers yesterday, there was no issue with the AC.
Proof of Mention
https://www.protondb.com/app/671860

Nevermind, seems like it will only work temporarily but a different AC will be used in the future (for official servers only). The current info on the website will be correct again soon it seems.


[bug] with_title on macos not working when called after SystemTray::new()

Describe the bug
As documentation states and I've found people replying in issues, you should be able to display text next to tray icon by just calling with_title on the tray, but apparently it does not work when getting called after SystemTray::new() and only works if you call set_title in setup(). It's best if documentation mentions this as well
Reproduction
No response
Expected behavior
No response
Platform and versions
mac os

Stack trace
No response
Additional context
No response

Can you show an example of what you tried? I don't really get what you mean to be honest.
Also please add the output of the tauri info command as requested in the issue template, thanks :)

Sorry for not outputting tauri info as I don't have access to my macbook rn. It's not a critical bug to break anything but still it's better if it's fixed maybe?
This is the scenario:
I wanted to make an app that displays current date in the menubar in Mac os. I've been an electron user but for such thing electron was definitely not good because of 90MB package size, so I decided to give Tauri a shot.
I followed as mentioned in the documentation and tried the following but got no result:

Adding title to systemTray in taufi.conf.json
Creating a tray like the documentation said and using with_title like let tray = SystemTray::new().with_title('This is the date in menubar');
You can test it for yourself to see that it does not display any title next to the Tray icon in menubar.
set_title() works though


[Doc] Error in building Sphinx docs

Hi everybody! 👋
First of all thanks for your efforts! That's a great library.
I was looking for a documentation beyond the README.md, but I found nothing ready to be used. Therefore I tried to build the docs from the doc directory using the Makefile provided (Sphinx based). These errors occurred:
WARNING: autodoc: failed to import module 'gui' from module 'remi'; the following exception was raised:
No module named 'remi'

I solved by inserting at the beginning of  the conf.py Sphinx file this line
sys.path.insert(0, os.path.abspath('..'))

In this way I notify Sphinx that it should look for modules in its parent directory (that is the repo root directory), that is where remi is.
With this modification the HTML build went good; only rst syntax warning like this one were raised:
remi\gui.py:docstring of remi.gui.CheckBoxLabel.set_on_change_listener:1: WARNING: Inline emphasis start-string without end-string.

These warnings are not so bad, the docs may not be built as you meant to be.
Shall I pull-request this change? After a short search I've found no issue about doc.
Also, is there any doc available anywhere (readthedocs, GitHub Pages, elsewhere)?
Thanks,
Robin
PS: this is my very first issue, I'm sorry whether I missed some information. Anyway, I found no contribution code of conduct...

Hello @Robin-Castellani you are really welcome to create a pull request. There is no additional documentation unfortunately. However there are some example, and the graphical editor can be also really useful. Nonetheless  you can ask me for questions/suggestions.  😉👍

Thank you Davide!
I'll create it as soon as possible. 👍

Thank you too @Robin-Castellani 😉


Update dependencies and workflows

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (884e3bb) to head (37b0c2d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #137   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           33        33
  Lines          634       634
  Branches        37        37
=========================================
  Hits           634       634

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[chore] mesheryctl: rename registry import to registry generate

Signed-off-by: Lee Calcote<EMAIL_ADDRESS>Notes for Reviewers
This PR is a chore for mesheryctl: rename registry import to registry generate.
Fixes https://github.com/meshery/meshery/issues/10360
Signed commits

[x] Yes, I signed my commits.

Failing tests are orthogonal to this PR. @Althaf66 @RipulHandoo will you investigate?


Rename MatrixStatsAggregation.php to MaxAggregation.php

Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #298   +/-   ##
=========================================
  Coverage     78.49%   78.49%
  Complexity      730      730
=========================================
  Files           122      122
  Lines          1883     1883
=========================================
  Hits           1478     1478
  Misses          405      405

Impacted Files
Coverage Δ
Complexity Δ

src/Aggregation/Matrix/MaxAggregation.php
0% <ø> (ø)
10 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4edab...5730a06. Read the comment docs.


Compatible with React 0.14

I get the following error message:
Uncaught Error: Invariant Violation: TreeMenu.render(): A valid ReactComponent must be returned. You may have returned undefined, an array or some other invalid object.

@gregorym thanks for bringing this to my attention.
I've created a branch react-0.14....let me know how that works for you. I can't produce your specific error. This branch bundles fine w/ react + react-dom and the examples all work. The console is also free of any deprecation warnings.
https://github.com/MandarinConLaBarba/react-tree-menu/tree/react-0.14

Cool!
I'll give it a try and let you know.

I  am able to reproduce using the data props.
data = { label: 'test'};

<div className={classes.join(' ')}>
        <TreeMenu data={data} />
      </div>

Ok thanks

Ok thanks


Define order when infusing if extract used --split

Currently, all my FR string are first and EN are second.
When I extract this is fine.
When I infuse, the string are inserted by alphabetical order of lang, which mean EN first.
This and #246 mean all my lines are changed if i were to commit the updated translation.

I have about 3000 string in 200-300 components so this is a big issue for me.

Relates to #255


Add caption support for table elements.

The regulations-site side of presenting TTITLE elements from the source XML as caption elements in the HTML output. Should fix the regulations-site side of https://github.com/18F/atf-eregs/issues/156

Good stuff. What do you think about a negative test, i.e. that, if the "caption" field isn't present (or is empty or whatever we're expecting), no <caption> tag is rendered?

The caption element is supposed to be the first child of a table element per the spec, so I thought that negative test was covered by the self.assertEqual(1, len(tree.xpath("table/thead"))) line in test_apply_layer_table. We could add a check to ensure there's no caption element anywhere in the children of table if you think that's needed.

Of course, as soon as I write that out, I see that it's not covered… I'll add a line.

:+1: thank you kindly


Want to be able to save my work in V-Sekai.xr-grid

Describe the proposed feature and how it helps to overcome a problem or limitation
After working on a project for an hour, I want to be make sure if I crash and when I exit I want to have a copy of my work.
Other information about your context or usecase.
Stroke by stroke saves is possible too.
Probably want a gltf export. OBJ export is acceptable.
If known, describe how your proposal will work, with code, pseudo-code, mock-ups, or diagrams
Every change that geometrically affects project needs save to a Godot Engine resource.
Anything else
No other info.

XR Grid works well enough. Can revisit later.


feat: support adding labels to PRs

Adds support for adding labels to pull requests.
Fixes #172

What is a good way to cover the lines added to src/index.ts? I don't see tests for that method.

What is a good way to cover the lines added to src/index.ts? I don't see tests for that method.

@noahdietz, for your issue test why don't you do this:
import {addLabels} from '../src';

This will pull in your helper from the index.ts file and should get the coverage up to 100%.

@noahdietz, for your issue test why don't you do this:
import {addLabels} from '../src';

This will pull in your helper from the index.ts file and should get the coverage up to 100%.

index.ts doesn't export the addLabels function though - so this doesn't compile?
Also, I think one coverage issue is that the call to addLabels is behind a check (options.labels && options.labels.length > 0), that never gets exercised. I was thinking of moving that check into addLabels, so it just returns empty list if there are no labels to set, and the createPullRequest call site unconditionally calls it, making the line covered(?) and I can write a test for the addLabels no-op logic. WDYT?

What's your specific use case out of curiosity?

The gapic-showcase project has some code regeneration steps that run on PRs (to verify that, for example, a proto change results in compilable regenerated code, then runs tests with that newly generated code). I'm using code-suggester to open PRs with those generated changes when the original PR is merged, and I want to add the automerge label to the generated PR :) See here.

Thanks for you review @bcoe! I tweaked things a bit WRT the no-op case fo addLabels and improved the coverage. LMK if you prefer it the way it was before.

Thanks guys for the reviews. I can't actually merge this PR so one of you will have to. Thanks!


QueenAnnotationNode.java: Write some unit tests for thi...

The puzzle -2024019957 originating from #10 has to be resolved:
https://github.com/jvmqueen/queen-of-java/blob/090c0b48c0dd2ca67bd9acd869dfcad8121385d1/src/main/java/org/queenlang/transpiler/nodes/QueenAnnotationNode.java#L40-L40
"Write some unit tests for this class.".
The puzzle was created by amihaiemil at 2022-12-02 20:48:13 +0200.
Estimation is 60 minutes.
If you have any technical questions, don't ask me, I won't be able to help. Open new issues instead.

@amihaiemil Don't forget to close this ticket before the deadline (2022-12-12T18:50:31). You are past the first half of the allowed period.

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role DEV available or because the project does not have enough funds.
Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

Puzzle disappeared from the code, that's why I closed this ticket.


[Proposal] Plugin system

Is your feature request related to a problem? Please describe.
Cadence provides multiple options/clients for components like:
Storage:

Cassandra
MySQL
PostgreSQL
Others

Document search:

Elasticsearch
Opensearch

Archival:

S3
GCloud

Having so many components built-in makes dependency version control complicated. Adding another component/client most likely will bring more dependencies to the code.
This also makes problematic to keep up with dependency versioning and introducing/experimenting with additional features will require approval from Cadence team.
Proposed Solution
I propose to implement a "plugin" system where you could declare external repository to be used.
Plugins interface can be declared to represent a concrete component in Cadence, for example:

Storage plugin
RPC Middleware plugin
Archival plugin
Etc.

One of possible implementation method: generate an entry main.go file where "import" section would be generated based on plugins you defined.
This gives at least two benefits:

Having a possibility to declare a plugin as go module, community could use publicly available plugin which is not placed in Cadence github repository.
Cadence code will have less internal dependencies, or even some existing components could be placed on another repository.

Additional context
Relates to https://github.com/uber/cadence/pull/5584

this would be perfect for advanced visibility without Kafka


Improve grunt workflow

Combine the grunt commands into a single one: perhaps automatically run what grunt does immediately after grunt vendor automatically?

Paging @anselmbradford

Fixed in https://github.com/cfpb/cfgov-refresh/pull/545


Assertion Error in train_gfn.py file

Hi,
Thanks for this great implementation. When I try to experiment with your code in discrete_vae/gfn part training stops due to Assertion Error that is inside of the sample(.) function. It succeeds for M-Step (decoder) but when sampling for E-Step (gflownet) it fails. Any help is much appreciated.
Edit: to be more specific it fails when sample is called with p=1.

Could you provide a few more details? Which assertion error are you getting? Are you running the code with no modifications? Which version of pytorch/torchvision are you using?

I can replicate it only when running the code on CPU. Are you also running on CPU?
If yes, could you try changing line 46 from
pred_probs = (pred_probs + 1e-9) / torch.sum((pred_probs + 1e-9) * mask, dim=-1, keepdims=True)
to
pred_probs = (pred_probs + 1e-4) / torch.sum((pred_probs + 1e-4) * mask, dim=-1, keepdims=True)?
To me it seems like a numerical issue...


LIVD SARS-CoV-2 Catalog with FDA Attributes to be uploaded to ReportStream

Problem statement
We received an updated LIVD to the Reportstream inbox. The LIVD table needs to be uploaded into ReportStream.
What you need to know
LIVD-SARS-CoV-2-2024-06-13 PRIME.xlsx
Acceptance criteria
none
To do
Please upload the new LIVD table to ReportStream.

Done.


Cpp stereoisomer enumeration

Reference Issue
Port EnumerateStereoisomers to C++ (#2110)
What does this implement/fix? Explain your changes.
Adds the ability to enumerate stereoisomers to the MolEnumerator library
Todos:

Update docs about new parameter to enumerate and new enumeration op type
Port EnumerateStereoisomers.py tests to C++
Update python wrappers for new api

@whosayn : the CI failures here are real

wrapped the new enumerator for python, but still thinking about what to do with the existing python implementation.
Also in the process of porting the old tests for the new C++ enumerator

@whosayn let me know when you are ready to have this reviewed.

@greglandrum thanks for the reminder


(PDB-2732) Refactor message retry logic for Stockpile

Message retries will work differently once Stockpile is introduced to the codebase. Currently retried messages are enqueued with a delay. In the future, we'll schedule a delayed task to reprocess the message. This PR refactors what before was called our message handling middleware to a single function, parameterized three functions. A function to delay a message (for retry), one function to discard a message and a function to process the message. With Stockpile, we switch the delay function and maybe the discard function.
This PR should only introduce one behavior change from the existing code. It removes the exponential backoff that was in place. Now it sleeps 1 second for each retry. This change is temporary as setting a higher value (i.e. 60 seconds) causes our tests to fail without a faster retry loop in place.

OK, I think that's all the comments I had at the moment.

@rbrw @ajroetker addressed your comments


Implement ACME backoff in the correct place + improve logic

What this PR does / why we need it:
This improves the logic added in #3215 to:

be used in the correct place (insert facepalm)
stop the Go retry logic after 10 attempts, some calls ended up with an infinite retry

Which issue this PR fixes:
fixes #3267
Special notes for your reviewer:
Let's backport this to v1.0 as many hit this bug
Release note:

Improve ACME backoff logic + prevent infinity retry without surfacing errors

/cc @james-w

/kind bug
/cherry-pick release-1.0

/lgtm

/cherry-pick release-1.0


Use Travis CI build config to choose the Scala version

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   91.96%   91.96%
=======================================
  Files          62       62
  Lines         996      996
  Branches       49       49
=======================================
  Hits          916      916
  Misses         80       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e976605...5f15e32. Read the comment docs.


Add keepalive option to mysql database connections

The wait_timeout option of mysql databases terminates idle connections
for that specific amount of time but the tcp connection might be
terminated earlier for example if the database server is behind ipvs
with default tcp timeout of 900 seconds (15 minutes).
This keepalive value is compared to the wait_timeout value and the
smallest is used as an interval at which the database connection is
checked to ensure it's not terminated. If the value is less zero it's
not used.

resolves #1213

I'm afraid it won't work for now. You should check these code for mysql connection details.
https://github.com/drogonframework/drogon/blob/6971f84dae707da7d37e1e045d5e06c6b3443e5d/orm_lib/src/mysql_impl/MysqlConnection.cc#L95-L109

I think I should have checked mariadb api first. I may try to fix this later.

I was about to say the same thing when I saw you close the pr...
I checked the mariadb and mysql doc. Calling MysqlConnection::handleTimeout() doesn't seem to be able to keep the conenction alive. It's just a regular step during connection establishment.


Source of pre-training data

Thanks for your work. I would like to know the source of KG, record and report data in the pre-training data. Can you provide it, please?

We use the CMeKG Chinese medical knowledge graph, you can contact the author of the original paper to request . The medical record and report data can't share becuase of the Hospital Privacy Policy. But if you are interested in conducting academic research, we can discuss the details of collaboration. Email<EMAIL_ADDRESS>

Thanks for sharing!


[FLINK-23773][connector/kafka] Mark empty splits as finished to cleanup states in SplitFetcher

What is the purpose of the change
This pull request fixes a bug that empty split is only unassigned from KafkaConsumer but not be cleaned up in SplitFetcher.
Brief change log

Add a set for tracking splits discovered empty at KafkaPartitionSplitReader#handleSplitsChanges
Mark empty splits in the set above as finished in KafkaPartitionSplitReader#fetch

Verifying this change
This change added tests and can be verified as follows:

Assign an empty split to KafkaPartitionSplitReader
Make a fetch and check if the empty split is added to finished split in the returning RecordsWithSplitIds

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@flinkbot run azure

@PatrickRen Thanks for updating the patch. LGTM.
Merged to master: fe17ca6042c570ce603bf4308775f61db1d515c9


Does the system hook api support the merge request?

I need this feature, but I didn't find it in org.gitlab4j.api.systemhooks.SystemHookListener
log
com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.gitlab4j.api.systemhooks.SystemHookEvent]: missing type id property 'event_name'
 at [Source: (String)"{"object_kind":"merge_request","event_type":"merge_request",

@magaofei
Support for the merge_request system hook has been added and release 4.10.0 has been published.  Please verify and close this issue when you have time.

2019-04-17 15:54:15.364  WARN <IP_ADDRESS> --- [nio-8123-exec-7] c.t.e.s.s.i.GitLabServiceImpl            : get post data error e =
com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.gitlab4j.api.systemhooks.SystemHookEvent]: missing type id property 'event_name'
 at [Source: (String)"{"object_kind":"merge_request","event_type":"merge_request","user"

@gmessner
com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.gitlab4j.api.systemhooks.SystemHookEvent]: missing type id property 'event_name'
 at [Source: (String)"{"object_kind":"merge_request","event_type":"merge_request","user"

@magaofei
Based on the JSON you have provided, It appears that the documentation at:
https://docs.gitlab.com/ee/system_hooks/system_hooks.html#merge-request-events
is not correct.
Notice that the documentation excludes the "event_name" property.  I actually had to add code to make it work because "event_name" was missing. From the JSON you provided it appears that ````"event_name"``` is actually present, which is what is causing this problem.   This is an easy fix, which I will release later today.

@magaofei
4.10.1 has just been released, please re-verify and close if it is now working.

@magaofei
4.10.2 has been that improved things the handling of MergerRequestSystemHookEvent, and added a test for SystemHookManager.handleEvent(), please verify this version.

@gmessner
2019-04-18 15:38:28.809  WARN <IP_ADDRESS> --- [nio-8123-exec-9] c.t.e.s.s.i.GitLabServiceImpl            : get post data error e =
com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.gitlab4j.api.systemhooks.SystemHookEvent]: missing type id property 'event_name'
 at [Source: (String)"{"object_kind":"merge_request","event_type":"merge_request","user"

It works fine


Expose API to know current theme (light/dark)?

I'd like to propose that the API which is used to determine whether the current theme is light/dark be made public (if possible) so that extensions can use it to style their components. I've felt the need for this while redesigning the git history extension where the plugin itself is hosted within a webview, and thus can't access the parent's classes to determine whether the vscode editor has dark or light theme.

dup of #10010


Out of memory exception

When you load large images into the program, it eventually crashes with an out of memory exception. Most likely not fixable until a change is made with the electron code.

This is a limitation outside of my control, for now there's a max file size for images set to 2MB


Issue with NoActiveAccessTokenException

Trying to solve this for 2 weeks now but can not get it to work. I am able to get an Access Token with client credetntials grant, no issues there.
{
  "access_token": "gUjdu9idSHkE973oxBoknPPUqwZ8IifL25TmtfIW",
  "token_type": "Bearer",
  "expires_in": 36000
}

But now when trying to access following route:
Route::group(['prefix' => 'v1', 'before' => 'oauth'], function()
{
    Route::resource('users', "UsersController");
});

and access following function:
    public function index(Authorizer $authorizer)
    {
        $user_id = $authorizer->getResourceOwnerId(); // the token user_id
        $user = \App\User::find($user_id);// get the user data from database
        return User::all()->toArray();
    }

I always get back a
NoActiveAccessTokenException in Authorizer.php line 104:
Tried to access session data without an active access token

in Authorizer.php line 104
at Authorizer->getAccessToken() in Authorizer.php line 265
at Authorizer->getResourceOwnerId() in UsersController.php line 22
at UsersController->index(object(Authorizer))
...

I tried supplying it via the URL:
http://<IP_ADDRESS>:8004/v1/users?access_token=gUjdu9idSHkE973oxBoknPPUqwZ8IifL25TmtfIW

and via the header
GET /v1/users HTTP/1.1
Host: <IP_ADDRESS>:8004
Authorization: Bearer gUjdu9idSHkE973oxBoknPPUqwZ8IifL25TmtfIW
Cache-Control: no-cache
Postman-Token: a9aa9439-752b-4341-cc2a-488cac53d19f

But I always get the exception back.
Already tried debugging into it but I am not able to locate where the token is get from the resource server.
Any help on this is highyl appreciated. Thanks ....

This is expected behaviour. You have to run both the OAuthMiddleware and OAuthClientOwnerMiddleware if you want to check the current requests owner id.

Thanks. Can you at least also point me to where I can find some documentation on this?

Done https://github.com/lucadegasperi/oauth2-server-laravel/commit/df2247df4524415ebcf730caac22b050b185c7a0

Thanks!


Adding a VLAN on a LAGG breaks connectivity

(Tested on OPNsense 18.7.8 as well as 18.1.3)
I've added a new VLAN on a LAGG interface and this broke connectivity to/from OPNsense for 1-2 minutes:
Dec  2 22:19:42 opnsense kernel: vlan12: changing name to 'lagg0_vlan140'
Dec  2 22:19:43 opnsense kernel: ix0: link state changed to DOWN
Dec  2 22:19:43 opnsense kernel: ix1: link state changed to DOWN
Dec  2 22:19:43 opnsense kernel: lagg0: link state changed to DOWN
Dec  2 22:19:43 opnsense kernel: carp: 220@lagg0_vlan220: MASTER -> INIT (hardware interface down)
Dec  2 22:19:43 opnsense kernel: carp: demoted by 240 to 240 (interface down)
Dec  2 22:19:43 opnsense kernel: lagg0_vlan220: link state changed to DOWN
...

As can be seen from the log output, both uplink interfaces ix0 and ix1 went DOWN while adding the VLAN. As a result, the LAGG went down too and all CARP addresses followed.
Is there anything that could be improved to minimize the downtime? I'd think that adding a VLAN should not cause a downtime at all.

@fraenki is this the latests version of OPNsense? I know there was a similar issue a long time ago, but some cards cause the same issue too.

@AdSchellevis Sorry for that. 18.7.8 it is.

any hardware offloading enabled? "VLAN Hardware Filtering" should be set to "Leave default" for this to work without interruptions.

just checked on my vm, no interruptions there, I kind of expect settings in this case.

@AdSchellevis Settings on the affected host:

can you try to set VLAN HW filter to "leave default" + reboot

Sure, will try.

Disabling VLAN HW filter fixed the issue, a new VLAN could be added without any downtime. Thanks!

4ba0fa679d it's the default for the 18.7.8 images coming this week. We missed this default configuration change for 18.7 unfortunately.


Snomed cross-references

https://www.hl7.org/fhir/valueset-food-type.html is a list of Snomed entities for food.  FoodOn should create the dbXref mapping.

Note there are probably new food terms in SNOMED list that foodon should have, like "colostrum".


Unable to read property of undefined (reading 'startsWith')

🐛 The bug
When upgrading the package from:
v0.7.1 -> v0.8.0
We encountered the following issue:
Error in the console:
[nuxt] error caught during app initialization TypeError: Cannot read properties of undefined (reading 'startsWith')
From source:
 ss(n.vueApp.config.globalProperties, "$nuxt", n);
    {
        window.addEventListener("nuxt.preloadError", s => {
            n.callHook("app:chunkError", {
                error: s.payload
            })
        }
        ),
        window.useNuxtApp = window.useNuxtApp || le;
        const i = n.hook("app:error", (...s) => {
            console.error("[nuxt] error caught during app initialization", ...s)
        }
        );
        n.hook("app:mounted", i)
    }
    const r = n.payload.config;
    return n.provide("config", r),
    n
}

🛠 To reproduce
/
🌈 Expected behavior
No error
ℹ Additional context
No response

Hi, thanks for the issue. It's not exactly clear where the issue is from, ideally a reproduction would be provided so I could verify.
However, I have pushed up a fix for a possible issue where a script is registered without a src.
If you still have issues with 0.8.1 please provide a reproduction :pray:


Add shields for Ring of Antwerp, Belgium

Renders the yellow shields used for Ring 1 and Ring 2 of Antwerp, Belgium. This system is unique in Belgium and is explained here (includes road sign example).

Thank you for contributing!


chore: update dependency URLs

All of Mathlib's dependencies now live under leanprover or leanprover-community! 🎉

Thanks :tada:
bors merge

bors merge


Kafka Listener listening on wrong port

The Kafkalistener listens on kafka:9092 regardless of what is configured in the .env file.
The intended env value gets passed correctly to application.yaml and to the code.
Even the log at the start prints out the correct config.
2022-01-05 21:22:26.345  INFO 3404 --- [  restartedMain] o.a.k.clients.consumer.ConsumerConfig    : ConsumerConfig values:
	allow.auto.create.topics = true
	auto.commit.interval.ms = 5000
	auto.offset.reset = latest
	bootstrap.servers = [localhost:29092]
        ....

Removing the spring.kafka.bootstrap.servers key from application.yaml causes kafka to try to connect to localhost/<IP_ADDRESS>:9092 and the config log at the start also prints this as the value for bootstrap.servers.
2022-01-05 21:25:27.784  INFO 20984 --- [  restartedMain] o.a.k.clients.consumer.ConsumerConfig    : ConsumerConfig values:
	allow.auto.create.topics = true
	auto.commit.interval.ms = 5000
	auto.offset.reset = latest
	bootstrap.servers = [localhost:9092]

This does not seem to be a configuration issue, rather that kafka reads the value from somewhere else if its set. kafka:9092 is nowhere to be found in the source except in .env.docker, but changing it in there does not affect the broken behaviour of the listener.
Maybe helpful reference: https://stackoverflow.com/a/51638268 (I've checked but could not find any @Configuration Beans that where overwriting these options. But I am not very familiar with this topic)

see https://github.com/The-Microservice-Dungeon/local-dev-environment/issues/4


Cannot access .cache file

I have setup env vars but still getting this error
❯ python3 spotifypod.py
Couldn't read cache at: .cache
Couldn't read cache at: .cache
Enter the URL you were redirected to: http://google.com
Enter the URL you were redirected to: no ints
Couldn't read cache at: .cache

+1 have the same issue

Hey y'all,
The reason why you get that error is because there is no .cache file created yet. And you are setting the application for the first time.
After getting the Spotify API recall url set to http://<IP_ADDRESS>, and entering this website below:
https://accounts.spotify.com/authorize?client_id=XXXXXXXXXXXXXXXXXXXXXXXX&response_type=code&redirect_uri=http%3A%2F%2F<IP_ADDRESS>&scope=user-read-playback-state user-modify-playback-state user-read-currently-playing app-remote-control streaming playlist-modify-public playlist-modify-private playlist-read-private playlist-read-collaborative user-library-modify user-library-read streaming (replace x with client_id)
Once you sign in with your Spotify Credentials, it will forward you to a link with <IP_ADDRESS>/?........ when u paste that link to the console, you should be able to launch the application.
I have been preparing a detailed instructions based on the project information. Let me know if there's something missing.

Hey all - I wish I could give better instructions, but I don't have bandwidth at the moment.
What I would do (and what I did initially) is follow spotipy's quick start guide for setting up the "client credentials flow" in a separate application. Once you get authenticated, the .cache file will be generated. Then you can just copy it into this project.

Thank you @utkut I appreciate all the help.

@dupontgu No worries, it might be a good idea to write a documentation regarding the needed scopes as well. I went a bit overkill with getting full permission from the user.

@utkut I managed to get the url call back in my browser http://<IP_ADDRESS>/?code=XXXXXXXX
What console do you mean to paste it into? do you just create a .cache file in the directory and paste the code?

@mattkerrison When you are executing the python file for the first time, it asks you "Enter the URL you were redirected to:"
and you paste the callback url to that prompt and then it generates the cache with your key.

Ahh, mine doesn't even get that far, just sitting at:
Couldn't read cache at: .cache
Couldn't read cache at: .cache
will keep debugging, thanks!

Apologies for the rookie question, but Im having trouble finding the .cache file that the Client Connect Flow sample app created. Any insight on where to find it and where to copy it so it can be used by spodifypod would be super appreciated.

@nsier The cache file is created afterwards the you paste the redirect url. The cache file contains the credentials, so unless you get authenticated with the Spotify API, there will be no cache file in your directory.

@nsier The cache file is created afterwards the you paste the redirect url. The cache file contains the credentials, so unless you get authenticated with the Spotify API, there will be no cache file in your directory.

I hate to bother with such silly questions, Im not much of a programmer,  but with headless Raspberry OS, how do I tell what what URL that a browser is redirected to?

@nsier just use this one:
https://accounts.spotify.com/authorize?client_id=XXXXXXXXXXXXXXXXXXXXXXXX&response_type=code&redirect_uri=http%3A%2F%2F<IP_ADDRESS>&scope=user-read-playback-state user-modify-playback-state user-read-currently-playing app-remote-control streaming playlist-modify-public playlist-modify-private playlist-read-private playlist-read-collaborative user-library-modify user-library-read streaming (replace x with client_id)
and the address you get (starting with 127.0.0....) is the one you paste in your console ;)

@nsier just use this one:
https://accounts.spotify.com/authorize?client_id=XXXXXXXXXXXXXXXXXXXXXXXX&response_type=code&redirect_uri=http%3A%2F%2F<IP_ADDRESS>&scope=user-read-playback-state user-modify-playback-state user-read-currently-playing app-remote-control streaming playlist-modify-public playlist-modify-private playlist-read-private playlist-read-collaborative user-library-modify user-library-read streaming (replace x with client_id)
and the address you get (starting with 127.0.0....) is the one you paste in your console ;)

Im getting an INVALID_CLIENT: Invalid redirect URI
thanks

@nsier u are welcome.
Set the environment variables using extern

@nsier u are welcome.You should read here:
https://spotipy.readthedocs.io/en/2.16.1/#client-credentials-flow
Set the environment variables using :
export SPOTIPY_CLIENT_ID='your-spotify-client-id'
export SPOTIPY_CLIENT_SECRET='your-spotify-client-secret'
export SPOTIPY_REDIRECT_URI='your-app-redi

thanks again for this, I figured out the URL and def am getting further, but not have run into an error after pasting.
File "/home/pi/.local/lib/python3.7/site-packages/spotipy/oauth2.py", line 508, in get_access_token
error_description=error_payload['error_description'])
spotipy.oauth2.SpotifyOauthError: error: invalid_request, error_description: code_verifier required
any thoughts?

@mattkerrison When you are executing the python file for the first time, it asks you "Enter the URL you were redirected to:"
and you paste the callback url to that prompt and then it generates the cache with your key.

Maybe i'm doing something wrong, but I can't manage to do this.
I did all the setup ( the 3 environnemental variables, setting up http://<IP_ADDRESS> in my app dashboard and all ) but whenever I paste the link I got ( http://<IP_ADDRESS>/?code=XXXXXXX )
It returns me every time :
Enter the URL you were redirected to: no ints
Using <IP_ADDRESS> as redirect URI without a port. Specify a port (e.g. <IP_ADDRESS>:8080) to allow automatic retrieval of authentication code instead of having to copy and paste the URL your browser is redirected to.
I tried to understand for few hours but it's driving me crazy
Thanks for the help.

@rsappia many thanks for your help here. You're guidance helped me solve this issue!

I also was having two nights of trouble getting the .cache file.  In my case the solution turned out to be simple--install a browser on the Pi Zero.  I don't believe this step was mentioned in the guides.  From past experience I thought Midori might be a good lightweight browser to install but it took some time because of the many dependencies.  Also, it really taxes the Pi Zero, so to speed thing up a lot, I popped the SD card from the Zero into a Pi 4 and Midori ran at an acceptable speed.  It was called automatically when I tried to run the spotifypod.py script and I had to log into spotify to approve the authorization.  This only needs to be done once (unless you somehow erase the .cache file).  I don't think the browser gets called again, which is fortunate given how many resources it takes up.
If you get an "address already in use" error, just reboot the Pi.  Also, as mentioned above the environment variables need to be set, particularly paying attention that the SPOTIPY_REDIRECT_URI matches the redirect URI you entered into your project in developer.spotify.com exactly.
Finally, at least one of the following commands needs to be uncommented--i.e., active--in spotifypod.py (the second calls the first, so no need for both):
spotify_manager.refresh_devices()
spotify_manager.refresh_data()


How to customize Content-Disposition?

Similar gems let you do the following:
@uploader.add_field('Content-Disposition', 'inline')
I don't see an API to add custom fields to be taken into account by S3?
Cheers - Victor

This should be fixed with #196

Thanks - will try it in production this week!
I'd be good to keep the issue open until we check it works. Then a snippet could be added to the documentation.

I think it'll work fine but I can't check it at the moment (https://github.com/dwilkie/carrierwave_direct/issues/206), will retry later.
In any case, a gem version bump is needed for this feature!

I could try it now. It doesn't work, request will fail with 403:
<Error>
   AccessDenied
   <Message>Invalid according to Policy: Policy Condition failed: ["eq", "$response-content-disposition", "inline"]</Message>
   <RequestId>yyyyy</RequestId>
   <HostId>xxxxxx</HostId>
</Error>

This is the relevant ruby code I wrote:
@uploader.policy do |conditions|
  conditions << {"response-content-disposition" => "inline"}
end

Maybe S3 policies really don't have to do with setting content-disposition?

Content-disposition should not be set when uploading. You can pass it to the download url:
model.attachment.url(:query => { 'response-content-disposition' => 'attachment' } )


Bug "Encountered an error, please try again" when Send NFT

Describe the bug
Bug "Encountered an error, please try again" when Send NFT
To Reproduce
Pre-condition: Account A have no balance or balance not enough to cover fees
Steps to reproduce the behavior:

Open Send NFT screen and Send NFT from A to B
Input Valid data for the all fields
Click on Send button
Observe Sign & Submit screen
Click Sign & Submit button multiple times
Actual: see files attachment

Pls check case: The balance not enough to cover fees & user input wrong password

Actual: Do not showing message wrong password


Use UTF-8 to encode text and html parts.

This PR lets you use international characters in Mail messages

Looks good. Thank you for your contribution 👍


Bump markdownlintcli to v0.32.0

Why
https://github.com/igorshubovych/markdownlint-cli/releases/tag/v0.32.0
What
Bump markdownlintcli to v0.32.0

Codecov Report

Merging #1177 (a35d9f2) into main (deadda9) will decrease coverage by 4.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
- Coverage   78.81%   74.62%   -4.20%
==========================================
  Files          55       55
  Lines        2719     2719
==========================================
- Hits         2143     2029     -114
- Misses        528      636     +108
- Partials       48       54       +6

Flag
Coverage Δ

Linux
?

Windows
?

macOS
74.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

build/pipeline.go
2.75% <0.00%> (ø)

....com/gomodule/redigo/splunkredigo/option/option.go
50.00% <0.00%> (-50.00%)
:arrow_down:

...hub.com/gomodule/redigo/splunkredigo/redis/conn.go
64.15% <0.00%> (-35.85%)
:arrow_down:

...n/gopkg.in/olivere/elastic/splunkelastic/option.go
66.66% <0.00%> (-33.34%)
:arrow_down:

...c/confluent-kafka-go/kafka/splunkkafka/producer.go
68.00% <0.00%> (-19.00%)
:arrow_down:

...hub.com/gomodule/redigo/splunkredigo/redis/dial.go
86.88% <0.00%> (-13.12%)
:arrow_down:

...c/confluent-kafka-go/kafka/splunkkafka/consumer.go
75.80% <0.00%> (-12.91%)
:arrow_down:

...n/github.com/lib/pq/splunkpq/internal/connector.go
50.25% <0.00%> (-6.54%)
:arrow_down:

.../gopkg.in/olivere/elastic/splunkelastic/elastic.go
94.91% <0.00%> (-5.09%)
:arrow_down:

instrumentation/database/sql/splunksql/config.go
80.67% <0.00%> (-2.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deadda9...a35d9f2. Read the comment docs.

@MrAlias PTAL (sorry that the PR initially was having a failing build)

This PR seems to have surpassed initial scope it was created for. Ideally PRs should be scoped to do one thing and one thing only.
Given how small it is I'm okay with merging this as is, but we should try to refrain from such PRs going forward.
Please update the commit message to reflect what is being merged when this is merged.

It also fixes the issues reported by the new version of markdownlint. Nothing more than that 😉

This PR seems to have surpassed initial scope it was created for. Ideally PRs should be scoped to do one thing and one thing only.
Given how small it is I'm okay with merging this as is, but we should try to refrain from such PRs going forward.
Please update the commit message to reflect what is being merged when this is merged.

It also fixes the issues reported by the new version of markdownlint. Nothing more than that wink

Oh, gotcha! That makes more sense :facepalm:


samples/react-multimedia-gallery - dependency on unpublished<EMAIL_ADDRESS>

Sample react-multimedia-gallery depends on something which depends on unpublished version of<EMAIL_ADDRESS>Package lock json shall be removed - then all installs properly.
https://www.npmjs.com/package/websocket-driver - only 0.7.1 and 0.7.3 available, 0.7.2 is not available.

Thanks @latonita for this. I'm unsure whether you're asking a question or providing the answer for this issue.
I'll mark it as closed as there has been no activity for a while. If you still need help with this, please feel free to open a new issue so we can help. I also encourage you to take the time to fill the issue template, as it helps us better route the issue to the right people and -- hopefully -- get the answers we need.


Fix Gitlab CI integration

Running tests on CI will help with checking PRs :+1:

Hello @orsinium :)
Yep, our current integration with GitLab CI seems to be broken, thank you for reporting it

Oh, haven't noticed it, sorry. Cool.

@svtkachenko could you help, please?

@Stranger6667 AFAIK, it is not broken, just slow.


Fix memory leak when executing BHJ

You have to provide the following information whenever possible.

Fix memory leak when executing BHJ.
When executing BHJ, there are some JVM Object not to be GC and lead to memory leak.

A clear and concise description of what works not as it is supposed to.

A link to reproducer in https://fiddle.clickhouse.com/.

Does it reproduce on recent release?
The list of releases
Enable crash reporting

If possible, change "enabled" to true in "send_crash_reports" section in config.xml:

<send_crash_reports>
        <!-- Changing <enabled> to true allows sending crash reports to -->
        <!-- the ClickHouse core developers team via Sentry https://sentry.io -->
        <enabled>false</enabled>

How to reproduce

Which ClickHouse server version to use
Which interface to use, if matters
Non-default settings, if any
CREATE TABLE statements for all tables involved
Sample data for all these tables, use clickhouse-obfuscator if necessary
Queries to run that lead to unexpected result

Expected behavior

A clear and concise description of what you expected to happen.

Error message and/or stacktrace

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

done by #317


Fixed the text - box

Fixed the Text box issue
Fixes: https://github.com/zulip/zulip/issues/20831
I have fixed the text box issue but still, the remaining are not yet fixed I pulled request to see if this is working from your end and to correct me if I did wrong

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Closing as https://github.com/zulip/zulip/issues/20831 was fixed via another PR.


Add support for snowflake dialect

Steps to run snowflake dialect tests.

Update bft/testers/snowflake/config.yaml file with snowflake user,account,db,schema etc.
export SNOWSQL_PWD=<your password>
To run the snowflake tests pytest bft/tests/test_snowflake.py

Closing this as I opened PR on the volrtondata/bft repo


More metadata for Language/ and for routines

This issue is a part of TODO.

Not sure what this means either. Metadata added to the page headers?

What kind of metadata do you mean here? Does anyone remember the context for this issue?

Unfortunately, no clue. I see https://github.com/perl6/doc/commit/9f1b25cea91891258bd40759929e3e308e838baf#diff-b7b1e314614cf326c6e2b6eba1540682, not sure if @Mouq can advice us something after four years.

I'm afraid I'll have to close this. If anyone can clarify what it means, please open it back.


Add Foods for Tomorrow / Heura

Checklist

Reviewed MRs:

https://github.com/nglgzz/awesome-clean-tech/pull/53

https://github.com/nglgzz/awesome-clean-tech/pull/56

[x] I reviewed 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.

[x] I read and followed the CONTRIBUTING guidelines.

[x] This pull request has a title in the format Add Company Name. Or Add Company1, Company2 and Company3 if it adds multiple companies.

:x: Update README.md
:x: Added Orbital Systems
:white_check_mark: Add Orbital Systems
:white_check_mark: Add Orbital Systems and Bulb

[x] I added entries in alphabetical order.

[x] The description is simple and doesn't contain unnecessary buzzwords. It needs to say what the company does, it's not a sales pitch.

:x: Disruptive company developing cutting-edge AI-enabled solutions to provide farmers with a decision support system.
:white_check_mark: They use satellites to help farmers monitor crops and lower their emissions by reducing their nitrogen usage.

Hey @aalises, thank you for your contribution, this seems like a great addition to the list!
Only one thing, I would replace the | in Foods for Tomorrow | Heura with some other separator, as currently that is used to separate between different types of information.

Sure @nglgzz ! Changed ^^

Awesome, thank you again for your contribution ✨


security issue: imposes one doman context over the other

The issue is observed when there is a common access to the data source, which is cached as a promise.
The domain from which resolve/reject is called imposes its context on all other promise.then/catch calls.
This was fixed in bluebird by using process.domain.bind().
'use strict';

var Q = require('q');
var Assert = require('assert');

describe.only("security issue when accessing common data via promise", function () {
    var Domain = require("domain");

    var cache;
    function getCommonData(reject) {
        if (cache) {
            return cache;
        }

        var deferred = Q.defer();

        setTimeout(function () {
            if (reject) {
                return deferred.reject(new Error("test error"));
            }
            deferred.resolve("data");
        }, 100);

        cache = deferred.promise;
        return cache;
    }

    function setupContext(name, next) {
        var domain = Domain.create();
        domain.run(function () {
            domain.testName = name;

            next();
        });
    }

    function validate(expected, done) {
        try {
            Assert.equal(expected, process.domain.testName);
        }
        catch (err) {
            return done(err);
        }
        done();
    }

    function request(name, reject, done) {
        setupContext(name, function () {
            // now access common data
            getCommonData(reject).then(function () {
                // validate context
                validate(name, done);
            }, function (err) {
                validate(name, done);
            });
        });
    }

    function countDone(count, done) {
        return function _done(err) {
            if (err) {
                count = -1; // skip the rest
                return done(err);
            }
            count--;
            if (!count) {
                done();
            }
        };
    }

    it("one domain should not impose its domain context onto the other domain context via common promise, resolve", function (done) {
        cache = undefined;
        done = countDone(2, done);

        setImmediate(request.bind(null, "John", false, done));
        setImmediate(request.bind(null, "Bob", false, done));
    });

    it("one domain should not impose its domain context onto the other domain context via common promise, reject", function (done) {
        cache = undefined;
        done = countDone(2, done);

        setImmediate(request.bind(null, "John", true, done));
        setImmediate(request.bind(null, "Bob", true, done));
    });

});

Compatibility with domains is begrudgingly in-scope for Q. PR’s to address issues with domains (with tests!) are welcome.

it is really confusing how to add tests in PR for the module.
Here's the possible fix:
https://github.com/dimichgh/q/commit/e9d3fec5dcfd8503e68ad089b9a5e93f35692f16
You can integrate the above tests into the spec.


Update ruby logo

This fixes #846 for future deployments of our landing page.

LGTM.

Coverage remained the same at 85.634% when pulling e244a3d5fcb72714892ed41ea4f210bcb5bdf22a on mziccard:ruby-logo into 545f099cffff5d444f32e6b586e802c4fd79e429 on GoogleCloudPlatform:master.


Reverse grade bins

I reversed the grade bins to show possible grade values from A+ to F. Before, the bins were being shown from F to A+. This is because we fetched the rows in order from this spreadsheet https://docs.google.com/spreadsheets/d/1kaCebQXcx0DCu0-FNPbJlmF_XfN8QOOyI4LJxg4_J74/edit#gid=1306410194 where the bins are in ascending order in the spreadsheet. The new changes have the bins for the website in descending order (from A+ to F).

Also it looks like you have a couple of commits on this branch that aren't related to your ticket.  If you could create a new branch and git cherrypick the commits with changes, it would be much cleaner.

#113


System reporting as HS but is LS

Ayeroilen (system sec status 0.49) is being rounded up it to 0.5 in pathfinder and showing as High Sec and not Low Sec. http://i.imgur.com/DvMwxhy.png screen shot of values.

Thanks for reporting!

TrueSec rounding is now removed from DB query and moved into ccpsystemsmapper.php.

This will be fixed with the upcoming release.

This is now fixed in the map, but (still) broken in the Routes table. Low Sec systems like Aunenen show up with orange L in the map, but with a yellow system icon in the route. The average function seems to use the correct number though, as Jita route with any wh exit using Aunenen shows up with an orange 0.44, although the whole way has only yellows, greens and blues listed with first being a yellow Aunenen as mentioned above (which is wrong). So this is not yet fully fixed.

I just got a report yesterday that this is still a thing in the routes table, so please reinvestigate. Aunenen for instance still gets a yellow dot although it is a lowsec.

This is now fixed with the upcoming release. If you have a private installation running, You should (re)build your index.
Check #125 for more information about that.


Fix readme.md

The description, it should describe what the project is not what you felt when you created this.
Minor changes are very necessary.

bhen ke lode chup ho ja

chup ho jaana ab
kar diya


Not able to Publish or Subscribe to ROS

Hi,
Thanks for great repo [Farmsim 19 with ROS].
I tried following:

Install FarmSim 19 [Windows 10]
Installed modROS

When I try to "rosPubMsg = True" I am getting error: Could not find named Pipe: Unknown reason (FS Lua does not seem to provide it]
Errors:

Folder struct:

Symbolic_link : Created

Please let me know what am I missing?

(venv_modROS) C:\Users\Thejesh\Desktop\fs_mod_ros_windows\nodes>python all_in_one_publisher.py
symbolic link has already been created
WARNING: cannot load logging configuration file, logging is disabled
Unable to immediately register with master node [http://localhost:11311/]: master may not be running yet. Will keep tryi
Unable to immediately register with master node [http://localhost:11311/]: master may not be running yet. Will keep tryi
Unable to immediately register with master node [http://localhost:11311/]: master may not be running yet. Will keep tryi
Unable to immediately register with master node [http://localhost:11311/]: master may not be running yet. Will keep tryi
Unable to immediately register with master node [http://localhost:11311/]: master may not be running yet. Will keep trying.
Traceback (most recent call last):
  File "C:\Users\Thejesh\PycharmProjects\pythonProject\venv_modROS\lib\site-packages\rospy\impl\registration.py", line 375, in cleanup
    multi()
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\xmlrpc\client.py", line 879, in __call__
    return MultiCallIterator(self.__server.system.multicall(marshalled_list))
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\xmlrpc\client.py", line 1109, in __call__
    return self.__send(self.__name, args)
  File "C:\Users\Thejesh\PycharmProjects\pythonProject\venv_modROS\lib\site-packages\rospy\core.py", line 665, in _ServerProxy__request
    return xmlrpcclient.ServerProxy._ServerProxy__request(
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\xmlrpc\client.py", line 1450, in __request
    response = self.__transport.request(
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\xmlrpc\client.py", line 1153, in request
    return self.single_request(host, handler, request_body, verbose)
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\xmlrpc\client.py", line 1165, in single_request
    http_conn = self.send_request(host, handler, request_body, verbose)
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\xmlrpc\client.py", line 1278, in send_request
    self.send_content(connection, request_body)
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\xmlrpc\client.py", line 1308, in send_content
    connection.endheaders(request_body)
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\http\client.py", line 1250, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\http\client.py", line 1010, in _send_output
    self.send(msg)
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\http\client.py", line 950, in send
    self.connect()
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\http\client.py", line 921, in connect
    self.sock = self._create_connection(
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\socket.py", line 808, in create_connection
    raise err
  File "C:\Users\Thejesh\AppData\Local\Programs\Python\Python38\lib\socket.py", line 796, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [WinError 10061] No connection could be made because the target machine actively refused it

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\Thejesh\PycharmProjects\pythonProject\venv_modROS\lib\site-packages\rospy\core.py", line 575, in signal_shutdown
    h(reason)
  File "C:\Users\Thejesh\PycharmProjects\pythonProject\venv_modROS\lib\site-packages\rospy\impl\registration.py", line 377, in cleanup
    (se_errno, msg) = se.args
ValueError: too many values to unpack (expected 2)
Traceback (most recent call last):
  File "all_in_one_publisher.py", line 138, in <module>
    rospy.init_node('ros_publisher', anonymous=True)
  File "C:\Users\Thejesh\PycharmProjects\pythonProject\venv_modROS\lib\site-packages\rospy\client.py", line 323, in init_node
    raise rospy.exceptions.ROSInitException("init_node interrupted before it could complete")
rospy.exceptions.ROSInitException: init_node interrupted before it could complete

I believe the order of commands needed is perhaps unclear.
As the readme states (in the Running section):

Note: Before proceeding to the next step, make sure you see waiting for client from FarmSim19 in the cmd window

the errors in the FS prompt are to be expected I believe if you haven't started all_in_one_publisher.py yet.
The errors from all_in_one_publisher.py you show seem to be due to not having correctly configured the required environment variables (ie: ROS_IP and ROS_MASTER_URI). This is the same configuration needed for a regular ROS 1 installation when using multiple hosts.
@tckarenchiang: we should consider updating the documentation to add some information on that.
@thejeshk: for now, refer to General Usage in the d3dshot_screen_grabber readme. This does not use ROS_IP or ROS_MASTER_URI environment variables, but passes them directly to the script as arguments.
Something like this should work:
python path\to\all_in_one_publisher.py __ip:=<ip of this PC> __master:=http://<ip of the PC running roscore>:11311

Note: there is no point in trying to continue with the next step in the documentation until you can successfully run the .py scripts.

@thejeshk: were you able to get things to work?

I'm going to close, assuming the initial problems reported by the OP have been addressed/explained.
I've followed all instructions myself again and while there are some possible issues (such as #25), and the UX could be improved, we're tracking those or they are manageable.
@thejeshk: if you're still having difficulties getting things to work, comment here and we can see whether this needs to be re-opened.

Hi @gavanderhoorn
Sorry! It's been a while now. I was not working with FarmSim for a while now because my personal PC had some issues.
recently, I joined as a researcher at JD and will be working with Farmsim 22. after setting up everythin (ROS, Farmsim, etc ), I would update this thread of how this integration goes!
Thank you
TK

Just to clarify: we've developed modROS for FS19. I'm not sure newer versions will work.
But we're interested to hear about your experiences.


Global - Investigate why sometimes after logging in all your chats/files will be missing and not return

Isssue:
Sometimes when the app either crashes or logging in after a long period of time not being on, all of your chats and files will be missing and they will not return but all of your friends remain
OS:
MacOS
Windows
Linux
Screenshot:

Just to add a note here that after inspecting a profile, the data remains intact inside warp, while with uplink, it doesnt show, despite it loading into the state just fine.

it would be helpful if this ticket included the ~/.uplink folder. otherwise not sure how to proceed

@sdwoodbury This is due to the state file being corrupted with the conversations not loading into the in_sidebar after it is created again. We may want to either rethink that field (eg maybe have an excluded field to exclude conversations from the sidebar instead) or on creating the state.json file to load the conversations there.


Set flags instead of different config format

Switch all the "easy" settings to flags instead of config.  There is a little bit more that isn't too hard, but requires config observation changes.  Let's clear the early stuff first.  This makes us more kube-like and will help answer questions about "how do we do benchmark X" and it helps focus our patches.
/assign @sttts

see https://github.com/openshift/origin/pull/24960 for comparison

/retest

lgtm

lgtm
Would like to have another pair of eyes on it.

/retest
/lgtm


Documentation is incomplete

Please provide more detail on how to set up the fetchChunk method.
I have a table with approx 800k rows. I'm executing
const queryOperation = await session.executeStatement('select * from table',options)
const result = queryOperation.fetchChunk({maxRows: 20})
It does not matter what value I use with maxRows. 3,740 rows is always returned.
If I use fetchAll, I get an out of memory exception.
How do I process an entire table in chunks so that I do not receive an out of memory exception?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c5c5950a-17b9-210a-d5e3-d851252262f2
Version Independent ID: c5c5950a-17b9-210a-d5e3-d851252262f2
Content: Databricks SQL Driver for Node.js - Azure Databricks
Content Source: databricks/dev-tools/nodejs-sql-driver.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@edtguy
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for providing feedback that helps improve our documentation. We've created an internal work item (DOC-9966) to address your feedback. The timeline for resolution varies based on resourcing.
#please-close


Add getServiceDomain function for cases domain is customized.

Signed-off-by: xuezhaojun<EMAIL_ADDRESS>

/assign @qiujian16

/hold

/close


What do you consider a BC break?

@Symphony rules changed over time in the 2.x series. If someone uses it, this leads to different results for different php-cs-fixer versions.
Furthermore, most of the classes are marked as @internal, IMHO meaning that maintainers are free to break BC even in dot releases.
So, it'd be fine to know what does the maintainers consider a BC break.

I think a clear separation between code and rules & sets should be made to answer the question.
For code, we basically follow symfony https://symfony.com/doc/current/contributing/code/bc.html
For the rules and sets however it is a bit different. While we like to provide a complete implementation of a fixer for PSR1, 2, Symfony, etc. we know we don't have everything in place.
So lets say someone makes a new rule for PSR2 and you configured the fixer to fix towards PSR2, than when you update the new fixers gets to work and might change code it did not do before.
This is not consider a BC break because your code is still fixed to PSR2 and that is what you configured.
For the SF set even more changes happen because the standard changes more frequent than lets say a PSR.
If you do not want you code to be fixed to let say PSR2 but only want to apply the rules we currently have for PSR2 you are better of configuring these rules separately as a list and not as the set.
That way, when we add new rules to the set your code is far less likely to be changed after updating the fixer.
You might be interested in https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/1112


Add Laravel Achievements

Laravel Achievements for Laravel 5.3+

Sorry, not enough stars https://github.com/chiraggude/awesome-laravel/blob/master/CONTRIBUTING.md


New rubygems release?

Hello,
Any chance for a rubygems.org release of version 0.7.0 (or 1.0.0) of this gem? The latest version released on rubygems.org is version 0.6.0, which does not support sidekiq 3.x. I am currently using github source in my Gemfile, which is OK when developing applications, but not so practical when writing libraries (gemspec files do not understand github sources).
Thank you in advance.

:+1:

👍


GoodReads API Key No longer available 😞

You Developed this Kit Really well I am here to appreciate your work, your linked profile is private can you make it public.

https://www.linkedin.com/in/godwin-a-36b124147/


How does the author turn unequal video into equal length? rescaled the feature length of all videos to same length 100,

Is each video  sampled at different intervals
How does the author turn unequal video into equal length? rescaled the feature length of all videos to same length 100,

The author released the rescaling code in BSN repo:
https://github.com/wzmsltw/BSN-boundary-sensitive-network/blob/master/data/activitynet_feature_cuhk/data_process.py

The author released the rescaling code in BSN repo:
https://github.com/wzmsltw/BSN-boundary-sensitive-network/blob/master/data/activitynet_feature_cuhk/data_process.py

The feature length of one frame about RGB and flow must be 400?


⚠ Fetchers has degraded performance

In 5e1825e, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 350 ms

Resolved: Fetchers performance has improved in e472322.


Alternate deployment of Flask App

Currently, we have instructions to consume machine learning model using a python flask application that is run locally on participants machines. Need to explore ways to run the applications beyond local machines so that users do not face the python dependencies (i.e. containerize and run in play with docker or straight on cluster).

tracking in upstream


Kernel status indicator fails to update, click does not find running kernels

This just started when I upgraded to 0.13
When I restart the python kernel, the indicator remains indefinitely on "Starting." Once I start running code, the transitions between "running" and "idle" seem to function correctly.

Also, when I click the indicator, it does not properly list kernel commands (like interrupt and restart):

Using the command pallet to restart or interrupt works fine.

When I restart the python kernel, the indicator remains indefinitely on "Starting." Once I start running code, the transitions between "running" and "idle" seem to function correctly.

We initialize the status bar with Kernel: starting but jupyter does not send a status message when the kernel is started completely.
@rgbkrk @n-riesco Should we simply initialize the status bar with Kernel: started since it is created on construction of the Kernel class after the process was spawned?

Also, when I click the indicator, it does not properly list kernel commands (like interrupt and restart):

This is interesting. The status bar is working for me just fine on macOS 10.11.6 and Atom version 1.9.9 or 1.10.0.
Lets try debugging this:

Could you open the dev console (by pressing shift-ctrl-i) and post an screenshot after trying to open the kernel commands?
Which atom version are you using?
Does it happen every time you click on the status bar?

Should we simply initialize the status bar with Kernel: started since it is created on construction of the Kernel class after the process was spawned?

I would, though I'd probably send a kernel_info_request and make sure you get a kernel_info_reply within reasonable time. Might even want to send several requests after a delay to give the kernel time to start up.

We initialize the status bar with Kernel: starting but jupyter does not send a status message when the kernel is started completely.

Ahh, apologies - I guess I'd never noticed this before.

Could you open the dev console (by pressing shift-ctrl-i) and post an screenshot after trying to open the kernel commands?

Nope, 'cause I can't reproduce this now. I updated Atom between posting this issue and your reply - I wasn't that far behind, but apparently that fixed it. Apologies for not doing that first (I didn't notice the little blue squirrel).
I'll let you close the issue in case you want to keep the other conversation open. Again, sorry for the newb mistake.

Okee doke, if it's working then we can go ahead and close this. We can reopen if it comes up again.


Loosening and tightening pulleys on R2 and C2

Tutorial showing how to loosen and tighten pulleys on R2 and C2 for fixing spacing (maybe the creeking noise) - dont forget to use the rod holders for keeping the gantry alligned. May need to put these up on thingiverse for users to print before they start the tutorial.

Gantry Alignment. Here's a rough pass at a gantry aligning tutorial.

@CobyKabili  Revised it! Let me know if you want it done any differently.

still not quit right. Ill let you know, but its almost there.

@mnacinopa all 4 pulleys of one axis have to be loosened. Also, if there can be a picture highlighting which pulleys to loosen it would be nice.

@peries can you review these and make sure they make sense to you

@CobyKabili  I added the picture highlighting the pulleys into the R2 article

@CobyKabili made a couple tiny edits but it looks good to me

@mnacinopa can you copy this to the C2 page and just put a note that it is the same process. Then you can close out this issue.

@CobyKabili @peries
Its liveee.


PipelineHandler implementation

I'm playing with this on staging, so there might still be some fixups/amends, but mostly it should be ready for review.
Prerequisite packit/packit-service#1229

recheck


crop blocks missing names.

Playing on 1.15.2. crop blocks don't display proper names with Hwyla.

This will be corrected in v1.0.7


[BUG] Custom AES KEY is never getting used

Describe the bug
Well I was working on implementing AES custom IV keys on OB but I was shocked that the encryption is always the same even after changing keys, I tought I fucked up something so I came back to the original current build and I retested to find out that the aesKey that we actually provided never gets used, it's always null as you can see in the screenshots.
I tried debugging it but I kinda got lost, but my vision is that the actual aeskey isn't getting saved to the config settings somehow or fails to get fetched, so it always as a null string.
To Reproduce
Steps to reproduce the behavior:

MAke a config
Add a AES Encryption function and provide a custom key

Expected behavior
It was expected that the algorithms uses our key to encrypt the input data
Screenshots

Version

1.1.3#254

yep the argments of that specific function arent getting saved. Simply by setting the aes key and switching to loliscript you find that the key is already gone, p
p2

Fixed here https://github.com/openbullet/openbullet/commit/cfcbd76ff3c4e8bb3c74e3141f60e6fe1dde2224
Also mind that the IV and the Key are two different things. The IV is the initialization vector, it's just a random value it's not your secret key! You can look below for reference

The algorithm inside OB uses the IV equal to the key just because I decided to do so for simplicity, but usually they are different ^_^

There is also an issue https://github.com/openbullet/openbullet/issues/31 that requested the ability to customize the IV, but it's very low priority as OB does not have a comprehensive list of encryption functions, so I would need to add a lot of stuff to really make it usable and complete not just the IV on that specific block cipher mode.


Dyson Pure Hot+Cool Link™ HP02 purifying heater + fan -- Oscillation

Hello everyone,
I have a Dyson Pure Hot+Cool Link™ HP02 purifying heater + fan, and after migration to the ha-dyson component, I lost control of its Oscillation.

Are you facing an error? You should see it under the fan entity, like so:

Following up here: Oscillation is supported by this integration on the HP02. @dieu are you able to confirm whether or not there is an oscillation control on the Fan entity on your setup? On the page in your screenshot, you'd want to click the "Dyson Office" label next to the on/off switch.
This is part of Home Assistant's design: Fan devices supporting oscillation are intended to provide it on the fan entity. If you'd like to read on the Home Assistant docs, here's a few links that you might find interesting!

https://www.home-assistant.io/integrations/fan/#service-fanoscillate
https://developers.home-assistant.io/docs/core/entity/fan/#oscillate

Hi @dotvezz @codyc1515 ,
Nope, I don't have this setting.

This looks like a climate entity. Can you click through to the settings icon please?

Ah, damn, found. Sorry to bother you, folks. Can we keep the Oscillation choice as previously because it defaults to off every time you do the on/off toggle?

When are you seeing it default to off? I noticed that the fan is not oscillating all the time, despite having it enabled. It turns out there was a recent update from Dyson that means the fan does not oscillate in auto mode if the air quality is okay.

The only way to force it to oscillate is by I put your fan speed to manual mode.

I’m not seeing that.


[CARBONDATA-2341] Added Clean up of files for Pre-Aggregate table

Added support For Clean up files for Pre-Aggregate tables when Cleanup on main table is fired

[x] Any interfaces changed?
NA
[x] Any backward compatibility impacted?
NA
[x] Document update required?
NA
[x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
Added UT test case
[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4429/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4433/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4985/

retest SDV please

LGTM

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3848/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5071/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3942/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5227/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4451/


Not all pages shown on Channels page (missing pagination)

Similar to https://github.com/lbryio/lbry-desktop/issues/3112 in that it happens randomly when viewing channels. In this case, you don't see the pagination options at the bottom but there is more than 1 page. Refreshing fixes it.  It could be some timing issue between showing the page and when we get the total number of claims in channel.

Fixed in #3237

This is still happening randomly. One example I'm able to reproduce: add @JOELwindows7:a to subs, close app, reopen, and navigate to channel from sidebar.  He does have a 2nd chanenl under @joelwindows7#7, not sure if that's related to the issue here.
Looks like sometimes we try to resolve the channel URL and other times not. We should not need to since the signing channel is available in the claim search response.

This should be fixed now.


Duplicate devices after update to 1.x

custom_component/hahomematic version (if applicable):
1.0.4
Home Assistant version (if applicable):
2022.4.0b5
CCU version:

Model (CCU2/3, Raspi3/4, NUC, ProxmoxVE, ...): Raspberry Pi 4
OS (Original, RaspberryMatic, debmatic/...): RaspberryMatic
Version: latest

Problem-relevant configuration:
Do you use tls? No
Do you use callback? No
Do you use username and password? Yes
Which interfaces do you use? HM, HmIP
Describe the bug
I followed the migration manual (upgrade) and now I have duplicate devices:

The devices are named "... (Gerät)" on the CCU3 and were renamed by me to "..." before the upgrade.
These renamed variants seem to have another "Verbunden über" entry as well:
"Old" device:
wettersensor.txt

This is the "KG.Flur Homematic CCU3" entry:
kg_flur_ccu3.txt

"New" device:
wettersensor_geraet.txt

This is the CCU3 entry:
ccu3.txt

The automations seem to still link to the renamed (=old) devices.
What do I do to consolidate those duplicates in a way that my automations still work?
Restoring my backup for now.
To Reproduce
Steps to reproduce the behavior:

Rename device before migration
Migrate
Look at the duplicates in device view ;-)

Screenshots (if applicable)
See above
Relevant HA log entries (full log)

Diagnostic Information (available on every device)

Expected behavior
Devices are migrated as well or there is a warning on the migration page that the devices need to have their original names before migration.
Screenshots
See above. By the way, this is a duplicate entry in your issues form ;-)
Additional context
n/a

Please post some device entry from .storage/core.device_registry

I guess something is wrong with your .storage/core.device_registry
Each device should have an identifier section like this:
                "identifiers": [
                    [
                        "homematicip_local",
                        "000B5BE999XXXX@CCU3-HmIP-RF"
                    ]
                ],

or
                "identifiers": [
                    [
                        "homematicip_local",
                        "000B5BE999XXX@CCU3-BidCos-RF"
                    ]
                ],

Before v1 it should be hahm instead of homematicip_local

Option 2:
You missed to execute step sed -i "s/hahm/homematicip_local/g" .storage/core.device_registry BEFORE restarting HA with the new version.
There is no need to rename devices, but when the above step missed out new devices (with the new name) will be created after restart.

This is what I did before the restart:

Looks right to me?

Yes, so now you have to check .storage/core.device_registry as mentioned above.

This is the device from before the update:
            {
                "config_entries": [
                    "2565974ba7d32a6a80e7f2f4a43e1f7e"
                ],
                "connections": [],
                "identifiers": [
                    [
                        "hahm",
                        "00185A498C4401@CCU3-HmIP-RF"
                    ]
                ],
                "manufacturer": "eQ-3",
                "model": "HmIP-SWO-PR",
                "name": "AU.Garten Wettersensor (Ger\u00e4t)",
                "sw_version": "1.0.18",
                "hw_version": null,
                "entry_type": null,
                "id": "fbfbc02fb8178c9b9c89948ece4ea0e3",
                "via_device_id": "655d25f0685d9d2534bc5b52e6d762ee",
                "area_id": "au_garten",
                "name_by_user": "AU.Garten Wettersensor",
                "disabled_by": null,
                "configuration_url": null
            },

This is 655d25f0685d9d2534bc5b52e6d762ee (also before the update)
            {
                "config_entries": [
                    "2565974ba7d32a6a80e7f2f4a43e1f7e"
                ],
                "connections": [],
                "identifiers": [
                    [
                        "hahm",
                        "CCU3"
                    ]
                ],
                "manufacturer": "eQ-3",
                "model": "CCU",
                "name": "CCU3",
                "sw_version": "<IP_ADDRESS>20330",
                "hw_version": null,
                "entry_type": "service",
                "id": "655d25f0685d9d2534bc5b52e6d762ee",
                "via_device_id": null,
                "area_id": "kg_flur",
                "name_by_user": "KG.Flur Homematic CCU3",
                "disabled_by": null,
                "configuration_url": "http://<IP_ADDRESS>"
            },

I have no backup of the migrated entries but I can do the migration again and post the results.

Klingt nach einem ähnlichen Problem, das ich hier auch erwähnt hatte: Dev-Talk
sed -i "s/hahm/homematicip_local/g" .storage/core.config_entries musste ich auch zwei Mal ausführen.
Eventuell überschreibt HA da etwas, wenn man nicht schnell genug ist...

@Lemocin Could be. But what is so active on the registries. Do you use mqtt?
@eikowagenknecht please make a copy of .the files before and after restart.
Please check the files before restart.

@Lemocin Could be. But what is so active on the registries. Do you use mqtt?

Yes, I'm using EMS-ESP32

The files on all my machines (Raspi/PVE, beta/latest) where updated after the last restart and then not touched for hours.

So I managed to execute the command so often and then quickly restarting that the files stayed on "homematicip_local". But that definitely needs a warning or safer method in the migration doc.
It works fine now, though. No more duplicates :-)

Thanks a lot, i added the warning.


Please document what the advantage is of having interfaces that implement Named for attributes

Issue type
Missing information
Problem description
What is the advantage of having interfaces that implement Named for attributes like public interface Usage extends Named?
I mean opposed to just having the attributes with type String.
In the module metadata they are just strings.
To set them you use the String constants in the interface.
You can also use any arbitrary other string.
So the only effect I can realize right now is, that it is more cumbersome to set the attributes by needing to use objects.named to create  the value instead of just setting a String as value.
Page with the problem
https://docs.gradle.org/current/userguide/variant_attributes.html#sec:declaring_attributes

Thank you for your interest in Gradle!
This is a valid documentation issue.


Add mime type detection, default headers.

This also adds Checkstyle, PMD and Jacoco. The last one still needs more
work to work properly.
Also, not commited from last release is the userOrganization for publishing it properly into Concrete Solutions account.

:+1:


Parameter callbackFrequency seems to have no effect

When calling UVAtlasCreate with a callback for a given mesh, the number of times the callback is called is always the same no matter callbackFrequency was given: about once per 1 ms.
Would it be a bug or something that I missed?

The callbackFrequency implementation is a little odd in this codebase. It's implemented as a 0-1 scalar instead of as a time-based value:
// Call callback function per m_dwCallbackDelta steps
m_dwCallbackDelta = static_cast<size_t>(
            m_fCallbackFrequency * float(dwTaskWork) / fPercentOfAllTasks);

static const float UVATLAS_DEFAULT_CALLBACK_FREQUENCY = 0.0001f;

What values have you tried?

I tried 0, 1, 0.5, 0.01.
I also tried 25 but there is a check that returns a failure (something like bad argument) if this value is not between 0 and 1.
Reading the code, I understood that it is supposed to ensure that the callback is called each time callFrequency "percent" is added to the overall process "percentage". Which seems not to be the case.


Could not resolve dependency: dependencies conflicts issue for Angular 14

Hi @niccolofanton,
Thanks for taking time on this, tried but did not resolved the issue, maybe you should upgrade the libs, or allow as a peerDependencies the Angular v.14.2

I would also be interested in Angular 14 as I tried to force install the libs and follow along but getting too many errors.

Hey, we're not too active on GitHub as we primarily use GitLab - this mirrors a project at https://gitlab.com/minds/web3modal-angular
Our main codebase is currently running Angular 13 - when we upgrade it to Angular 14, we will have to make this sub-project compatible with Angular 14 - however, I can, unfortunately, offer no timeframes on when this will be.

Hey - the modal has now been upgraded to Angular 15 - having skipped over 14.

@bhayward93 just tried adding this to my project but getting these errors
 error TS2345: Argument of type '{ providerOptions: { walletlink: { package: typeof WalletLink; options: { infuraUrl: string; appName: string; appLogoUrl: string; darkMode: boolean; }; logoUrl: string; }; }; }' is not assignable to parameter of type 'IProviderControllerOptions'.
  Type '{ providerOptions: { walletlink: { package: typeof WalletLink; options: { infuraUrl: string; appName: string; appLogoUrl: string; darkMode: boolean; }; logoUrl: string; }; }; }' is missing the following properties from type 'IProviderControllerOptions': disableInjectedProvider, cacheProvider, network

  providers: [
    {
      provide: Web3ModalService,
      useFactory: () => {
        return new Web3ModalService({
          network: "mainnet", // optional
          cacheProvider: true, // optional
          providerOptions // required
        });
      },
    }
  ],


ISPN-10395 Fix missing version for ispn-cli

https://issues.jboss.org/browse/ISPN-10395
Fixes compile error in Distribution profile.

new commit: fix version for protocol-parser-generator plugin

should fix https://ci.infinispan.org/view/Infinispan/job/Infinispan/job/master/1295/console

Merged, thanks


Zues cannot be accessed after dying

Zues cannot be accessed after dying
Steps to reproduce the behavior:

Spawn in as any player that is not spectator
Die
Attempt to enter zues

Problem lies in the fact the the Zues module requires an alive unit to base itself from, to solve this a dummy unit (Spectator module?) should be setup and the dead zues transferred into it via selectPlayer possibly with a single use check in the spectator init file or on death

Workaround:
Using admin menu, respawn self, teleport self to edge of map, and hide self
Usual elimination of player events will not be accurate therefor admin should be paying attention


emails do not appear to be sending via powershell or the web site

is this a known issue?
I can see previous posts about it but they all go back to last year and appear to have been resolved.

I am seeing this today on the website - any update?

I just did a test on the site and via the API.
I haven't received any email.

Ran some tests today using the API and didn't get the e-mail. Tried a few different e-mail addresses with no luck. API response looks OK as per below. Web console also shows confirmation that the secret was sent successfully - no e-mail received though.

{
"custid"<EMAIL_ADDRESS>"metadata_key": "zzzzzzzzzzzzzzzzzzzzzzzzzz",
"secret_key": "zzzzzzzzzzzzzzzzzzzzzzzzzzzzz",
"ttl": 3600,
"metadata_ttl": 3599,
"secret_ttl": 1799,
"state": "new",
"updated":<PHONE_NUMBER>,
"created":<PHONE_NUMBER>,
"recipient": [
<EMAIL_ADDRESS>],
"passphrase_required": true
}


Test multiple local signers/landlords, improve text field interaction such as...

Clears text field before typing in it
Uses effective selectors to get the right text field

[Note: The checkboxes for the tests are focused on features, not scenarios. We should chat about that]
Thinking about combining the 2 text field operations into 1 to eventually allow a sentence like I type "a thing" and I type a thing in the first field.
Also thinking about how to standardize input text a bit between repositories. May change 'Landlord 1' etc. to 'Other Party 1' or something.

Forgot to test for correct signature request text