[BUG] Bottom part of app is covered by android navigation buttons

Version
OSS Document Scanner: 1.7.0 from Github
What platform are you using?
Android
OS Version
LinageOS 18.1 (Android 11)
What happened?
The bottom part of the app is covered by android navigation buttons, hence it is very cumbersome to press any button on the bottom (for example the green Camera button on the start page).

Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

More info: no other app behaves this way on my system, only OSS Document Scanner has this problem.

@SanskritFritz it is a bug ! Should not happen. But have started after a recent change . will ftry to reproduce then fix

Thank you for caring!
Can you reproduce it? I thought I was the only one having this issue.

@SanskritFritz yes thanks i did reproduce it and fixed it! Will be in next version (hopefully today)

I just tried the new release, yes, thank you, it is perfect now!


Model 111 labels incorrect

See:

https://github.com/sunspec/models/blob/master/smdx/smdx_00111.xml#L82 mixture of amps/current
https://github.com/sunspec/models/blob/master/smdx/smdx_00111.xml#L121 label only contains the unit

Wrong positive- these have already been fixed.


pick: fix the condition that check valid in option

#31684
the valid in option should be
! (op.min > expr.max or op.max < expr.min)
=============>
op.min <= expr.max and op.max >= expr.min

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


How to set start number?

I want to set a start number and end number.
Example:

10000

counterUp(document.getElementById('number'), {
    start: 2000, // start number
    duration: 1000,
    delay: 16,
});

I too would love to see an API for the start number.
Could also be the minimum amount of digits to start counting from. Eg: If my number is 1,500, I could set minDigits to 4 so that it never starts with a number below 1,000.


Lock down the default branch

Specific Demand
The Dioxus repository should be configured to only allow PRs to modify the default branch and all PR merges should be enforced as squash-merges. This ensures a linear commit history, which is essential for any automation of semantic versioning. It also reduces the overall size of the repo metadata when cloning, since the total number of commits that must be downloaded and replayed is reduced, and ensures all commits are held to the same validation procedures, reducing the chance that a repo could be hijacked by stolen maintainer credentials.
Implement Suggestion
This can be configured in the repository settings under branch policies

Just did this!


Reduce password score from 3 to 2

What this PR does:
Reduce the password complexity requirement of the zxcvbn library from 3 to 2.
Notes
The password-strength-indicator.js has room for improvements, but this is out of the scope of this PR.

 [QAE16IMP] Reduce the password complexity


fixed readme from pull request #17

Just updated the readme to remove text about a Transit API

Thanks!


⚠ Bofrost.be has degraded performance

In 464eeee, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1243 ms

Resolved: Bofrost.be performance has improved in c60f860 after 11 minutes.


Fix Mypy errors for untyped functions

I'm not sure if this is the best way of fixing it, but it works.


Text within an element to be queried without doing normalization as is

There were use-cases where we wanted text to be queried with normalizing the text inside (Not removing whitespace).
This seem to be a legit use-case with jsoup, there were lot of stackoverflow questions for doing the same
http://stackoverflow.com/questions/5454172/prevent-jsoup-from-discarding-extra-whitespace
http://stackoverflow.com/questions/20295098/how-to-parse-html-and-keep-all-line-breaks
If there is a better way to handle the same please let me know @jhy

Thanks and sorry for the late reply.
https://jsoup.org/apidocs/org/jsoup/nodes/Element.html#wholeText() exists now for this use-case


ERROR_KEYCHAIN_ERROR SecItemAdd 100002

Description
Users sometimes hit keychain errors while logging in using Firebase Auth. We are using signInAsync(withCustomToken:)
This is the specific error:
Error Domain=FIRAuthErrorDomain
Code=17995
"An error occurred when accessing the keychain. The NSLocalizedFailureReasonErrorKey field in the NSError.userInfo dictionary will contain more information about the error encountered"
UserInfo={
FIRAuthErrorUserInfoNameKey=ERROR_KEYCHAIN_ERROR,
NSLocalizedFailureReason=SecItemAdd (100002),
NSLocalizedDescription=An error occurred when accessing the keychain. The NSLocalizedFailureReasonErrorKey field in the NSError.userInfo dictionary will contain more information about the error encountered
}

I used SecCopyErrorMessageString to understand what 100002 meant:

UNIX[No such file or directory]

But I don't have enough context to know how the Firebase SDK uses SecItemAdd and why it is getting that error.
The last time a user hit this, they hit it twice in a row. After restarting our app, it worked.
Reproducing the issue
Unfortunately, we don't have steps to reproduce the issue. But please let us know if you need us to add any logging or instrumentation into our app.
Firebase SDK Version
10.19.0
Xcode Version
15.0.1
Installation Method
Zip
Firebase Product(s)
Authentication
Targeted Platforms
macOS
Relevant Log Output
Unfortunately, as this is in prod, I don't have Firebase logs. These are part of our logs:

message
Error while logging in
Error
18:03:51

Error Domain=FIRAuthErrorDomain Code=17995 "An error occurred when accessing the keychain. The NSLocalizedFailureReasonErrorKey field in the NSError.userInfo dictionary will contain more information about the error encountered" UserInfo={FIRAuthErrorUserInfoNameKey=ERROR_KEYCHAIN_ERROR, NSLocalizedFailureReason=SecItemAdd (100002), NSLocalizedDescription=An error occurred when accessing the keychain. The NSLocalizedFailureReasonErrorKey field in the NSError.userInfo dictionary will contain more information about the error encountered}

http
POST https://www.googleapis.com/identitytoolkit/v3/relyingparty/getAccountInfo [200]
{
http.query: key=*,
reason: no error,
request_body_size: 1147,
response_body_size: 0
}
Info
18:03:51

http
POST https://www.googleapis.com/identitytoolkit/v3/relyingparty/verifyCustomToken [200]
{
http.query: key=*,
reason: no error,
request_body_size: 772,
response_body_size: 0
}

If using Swift Package Manager, the project's Package.resolved
No response
If using CocoaPods, the project's Podfile.lock
No response

We keep hitting this. Restarting the app seems to fix it. Any suggestions about how to avoid restarting the app? Thank you!

Thanks for the report. This will be hard to debug without a reproducible example.


[imguizmo] new port

Adding a port for the ImGuizmo library to go along with ImGui and ImPlot
Source library uses a make build so this port uses the same method of ImPlot to define a CMakeLists.txt in the port and copy it over during install to correctly build the project
Source library is not versioned, I have an open issue about whether there they will use releases. Currently I am using a yyyy-mm-dd as the version string

What does your PR fix?
Adds a port for ImGuizmo

Which triplets are supported/not supported? Have you updated the [CI baseline]
Tested x86-windows, x64-windows, x64-linux  sucessfully, unable to test others

Does your PR follow the maintainer guide?
As far as I know. Port is very similar to pre-existing ImPlot port, and the example code in source repo is excluded by the custom CMakeLists.txt included in the port directory

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?
Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@JonathanHiggs ,Please take a look:
https://dev.azure.com/vcpkg/public/_build/results?buildId=56231&view=artifacts&pathAsName=false&type=publishedArtifacts

@JonathanHiggs ,Could you please take a look?
https://dev.azure.com/vcpkg/public/_build/results?buildId=56292&view=artifacts&pathAsName=false&type=publishedArtifacts

Does osx run without std11 even?

@JonathanHiggs, you need 'add_compile_options(-std=c++11)' in your CMakeLists.txt for osx if it needed.

Is it add_compile_options() or target_compile_options() I need to set the cxx std? Will the both work cross-platform?

@JonathanHiggs, please use target_compile_options().

Thanks for the PR!


feat: migrate JSBI implemention to BI in method body

[x] base
[x] ckb-indexer
[x] common-script
[x] config-manager
[x] hd
[x] hd-cache
[x] helpers
[x] indexer
[x] rpc
[x] sql-indexer

maybe we should open a new PR to the develop branch and close this PR https://github.com/nervosnetwork/lumos/pull/246, I found the #246 is so difficult to review

We have migrated to another JSBI wrapped implementation @ckb-lumos/bi #248 so close this one


Work with react-app-rewired

Hi! Astroturf can work with  react-app-rewired and without eject create-react-app?

Ok, i find this config sample, it's correct? Thanks!
	config.module.rules.push({
		test: /\.(js|mjs|jsx|ts|tsx)$/,
		use: [
			{
				loader: 'astroturf/loader',
				options: { extension: '.module.css' }
			}
		]
	})
	return config
}```


There is no obvious link between the DILCIS website and the specifications microsites

If there is a link, I couldn't find it. The way it stands now propitiates incoherences in versions and aspect.
What I mean is that the DILCIS website has their own pages for each of the SPECS, and simultaneously, there are microsites that are always up-to-date with the latest version of the specs.

Can we make both point to the same information so that we eliminate incoherences?

As you can see from the examples, the microsite is already on version 2.0.4-DRAFT and the DILCIS site is still on 2.0.0.

That's since I havent had the chance to send the request to get the DILCIS webpage updated. Its on its way.

Fixed.


[SMALLFIX] Port shell module to wip_master_client

All tests in shell module passed.

The mkdirInvalidPathTest hangs there before, because the InvalidPathException is not caught in thrift service, so it is promoted to TException and caught by FileSystemMasterClient, then the client won't know the exception is due to invalid path, it may consider it a network problem, so it will try to reconnect to master with a retry policy which takes a lot of time.
The solution is to update exceptions thrown in thrift service definition to catch the InvalidPathException.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4702/
Test PASSed.

LGTM, I'll look into the slow down.


Grammar errors

This page is poorly written and has what appear to be grammatical errors.. Please have a native English speaker/editor read this and adjust it.
---o
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ff136fb-c076-b37a-9772-1c30a07fabec
Version Independent ID: ea5cf8c8-2ff3-7ebc-1c16-adc80912cb50
Content: Federating multiple Azure AD with single AD FS - Azure
Content Source: articles/active-directory/hybrid/how-to-connect-fed-single-adfs-multitenant-federation.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

@billmath Could you please review this request ?

Thank for submitting this. I have created a work item for it and will reviewing this in the coming weeks. I am not sure what the timeline will be, so I am going to close this for now. But once I have an update I will drop it in here and let you know.
Thank you!
Bill
#please-close


Add elasticsearch comrade to readme

https://github.com/moshe/elasticsearch-comrade Elasticsearch admin panel built for ops and monitoring

Merged. Thank you @moshe !


Recommendation: Generated Web API is running failed with error 500.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-21H2
ML.Net Model Builder 2019&2022: <IP_ADDRESS>2201 (Main Build)
Microsoft Visual Studio Enterprise: 2019(16.11.18); 2022(17.3.0)
.Net: 5.0 & 6.0
Describe the bug

On which step of the process did you run into an issue:
Generated Web API is running failed with error 500 Recommendation scenario.

TestMatrix
https://testpass.blob.core.windows.net/test-pass-data/recommendation-ratings.csv
https://testpass.blob.core.windows.net/test-pass-data/iris.mdf
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio start window.
Choose the C# Console App (.NET Core) project template.
Add model builder by right click on the project.
Select "Recommendation" scenario to complete the training;
Click "Add to solution" to add the Web Api project to your current solution.
Run the application.
Open PowerShell and enter the following code where PORT is the port your application is listening on.
$body = @{
UserId = 1
MovieId = 3
}
Invoke-RestMethod  "https://localhost:PORT/predict"-Method Post -Body ($body | ConvertTo-Json) -ContentType "application/json"

Expected behavior
Run successful and display the expected output.
Screenshot

Additional context:
Repro on both of VS2022&2019.

Verify on latest main and no reproduce

The bug has been fixed on the latest main branch: <IP_ADDRESS>5801


raidboss: Remove instanceof Check for Browser TTS

Fixes https://github.com/quisquous/cactbot/issues/2809

You can probably keep the check if you compare against iframe.contentWindow.HTMLAudioElement instead. That said, why does this code use iframes in the first place and why are they never cleaned up? Considering that each iframe needs its own v8 and blink context and a new iframe is created for each TTS line, this seems like a wonderful way to waste RAM.

I had suggested iframe.contentWindow.HTMLAudioElement offline but we couldn't get it to work.
I think enough people are complaining (somehow? why is this so popular??) on discord that I'd rather land this now and figure out what followups make sense.
@ngld I was planning to rip out this particular path anyway in favor of window.speechSynthesis but it's waiting on the CEF version upgrade so it can be used in overlays as well.  Do you have any thought of when/if that CEF version bump might happen?

somehow? why is this so popular??

Speaking for myself, I use it because I get really unpleasant audio artifacts (sounds like clipping) using the built in ACT TTS system unless I turn the volume down to a level I can barely hear over the game audio.


Feature Suggestion Section

Considering this is a platform where citizens will be interacting with matters affecting their country, I'd suggest we have a feature suggestion section where users can point out the features they want to see on this platform.
Also users should be able to create a feature suggestion, upvote a suggestion and follow up on whether the feature suggestions have been implemented.
Users should also add comments on a specific suggestion.
A user should perform all actions on this section without having to be logged in.

Good suggestion. Something like this that we have for Autohaven? https://autohaven.canny.io/requests
It ticks all the checkboxes above except the last one.
The having to login feature is a security feature. Without requiring login, it can be badly misused by eg bots who can create thousands of records automatically since they do not have to create accounts
Let me know if you like the one we have on Autohaven and I can create the same.

Not quite a feature, but a security issue. I have been looking at the routes drawn using the madmin gem and see that there is the madmin users link that shows the user details. I'm thinking the user details should be private(mostly user email).


Allinone

@ielis
Hi Daniel -- can we touch bases on Mon or Tue about this -- I added two functions to streamline processing the template. Everything seems to work but there is one error.
One question -- I think you remove the hpo ontology getter from the HpoCr class, which is reasonable, but maybe we can add back a hpo-version function? This would simplify things and the HPO version is arguably an important attribute of the CR.
Here is how the new functions would be used
from pyphetools.creation import import_phenopackets_from_template, create_hpoa_from_phenopackets
template = "../phenopacket-store/notebooks/SPTAN1/input/SPTAN1_DEVEP_individuals.xlsx"
hpjson = "../phenopacket-store/notebooks/hp.json"

# individuals, cvalidator = import_phenopackets_from_template(template, hpjson)
# The above line will initially lead to a warning that we need to add four deletions manually
# The following lines do this -- note the additional argument
deletions = {"arr{hg38}9q34.11(128,609,213-128,613,675)x1",
                "arr{hg38}9q34.11(128591376-128600369)x1",
                "arr{hg38}9q34.11 (128,582,754-128,587,726)x1",
                "arr{hg38}9q34.11 (128,587,422-128,600,316)x1"}
individuals, cvalidator = import_phenopackets_from_template(template, hpjson, deletions=deletions)

### Here, we begin QC and display
from pyphetools.visualization import IndividualTable, QcVisualizer
from IPython.display import display, HTML
qc = QcVisualizer(cohort_validator=cvalidator)
display(HTML(qc.to_summary_html()))
# new cell
individuals = cvalidator.get_error_free_individual_list()
## For some reason, the following does not work
#table = IndividualTable(individuals)
#display(HTML(table.to_html()))
# new cell
df = create_hpoa_from_phenopackets(moi="Autosomal dominant", pmid="PMID:29050398")
## all done or check the dataframe

I hope this is getting to a place where a borader audience can use this tool. Also, for phenopacket store, maybe it is enough to just use a Python script for some of the genes -- I want to use this for all new annotations to the HPO and want to make things as efficient as possible!

Hi @pnrobinson
I think the workflow is OK from the high-level.
The thing regarding removal of HPO from the concept recognizer - that is an example of what I consider as a code smell. It makes CR doing two things: 1) recognize concepts 2) provide HPO. I think CR should only do the 1st thing and we must update the code that used to rely on the 2nd functionality and simply ask for the HPO via the constructor.
I think using the HPO version in CR is OK as long as the CR does not expose it as a property. This should be OK because we should be using just one HPO version during the phenopacket creation anyway.
Last, regarding the HPOA, I haven't got there yet, so I honestly do not know what the best course of action should be. I'll get there eventually and we will work it out.


Can A9G be flashed by command line?

CoolWatcher is great tool to flash firmware to A9G.
However if I would like to flash by command line too,
Is there any way to flash by command line to A9G?

no command line tool yet, for we have no download protocol designed by RDA, they just provide us lib file on windows.
there's some ways to make it for us, ask RDA for help, or try to decode the protocol and write our own tool

And as you see, the code provided from RDA is open source by some one, you startd it before https://github.com/cherryding1/RDA8955_W17.44_IDH

I have already downloaded RDA89655_W17.44_IDH from the site.
Do you have the web-page to teach about how to build this RDA's  lib files?

no doc

Do you mind to descript how to build them?
Thank you .

I could write the command-line programmer, not a big problem (investigated the protocol a bit yet), if I could use the a9g in my project. currently the serial-port issue (https://github.com/Ai-Thinker-Open/GPRS_C_SDK/issues/232) is the biggest showstopper ..


Use a different port for dev/prod environments

As of https://github.com/GoogleChrome/application-shell/pull/63 there's a different service worker generated based on whether you're in the 'dev' or 'prod' environments. When working on similar setups, I've found it useful to use a different port number for your server depending on the environment as well. That way your 'dev' SW registration will remain separate from your 'prod' SW registration, and you won't keep triggering the SW update flow every time you switch from 'dev' to 'prod'.

And you might want to use process.env.PORT for 'prod' and some arbitrary number for 'dev', since I know some hosting environment specifically require listening on process.env.PORT.


Modify 'verify' target to execute 'go mod vendor'

Currently our CI tests do not run 'go mod vendor'
This commit ensures 'vendor' target in Makefile is ran on every PR in
order to check that all the packages vendored in are downloadable.

/assign @csrwng
/cc @staebler

This is not what verify should do. The CI should be using what is already in vendor. We could verify that the vendor directory is correct, but the tests should not be relying on updating the contents of vendor.

@staebler it's not about updating the contents of vendor, it's really verifying that the vendor directory can be rebuilt with the contents of go.mod.
@suhanime I would probably go about this differently. In a test specific to validating that the vendor directory can be rebuilt, I would rename the existing vendor directory, try to do a go mod vendor and have it succeed or fail, then discard the resulting vendor directory and restore the original one.

@staebler it's not about updating the contents of vendor, it's really verifying that the vendor directory can be rebuilt with the contents of go.mod.
@suhanime I would probably go about this differently. In a test specific to validating that the vendor directory can be rebuilt, I would rename the existing vendor directory, try to do a go mod vendor and have it succeed or fail, then discard the resulting vendor directory and restore the original one.

Yes, that is what I am suggesting. And we should take it one step further than just verifying that the directory can be rebuilt. We should be verifying that there are no changes to the directory or to go.mod.


Update finagle-core, util-core to 19.4.0

Updates

com.twitter:finagle-core
com.twitter:util-core

from 19.3.0 to 19.4.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "com.twitter" }]

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #111   +/-   ##
=====================================
  Coverage      52%    52%
=====================================
  Files           9      9
  Lines         200    200
  Branches        3      3
=====================================
  Hits          104    104
  Misses         96     96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0f164...4b32c40. Read the comment docs.


Nonexistent links

In the popup tutorial in the docs, all the links in the examples section at the bottom no longer exist.

This issue is a week old.


Photon Controller cloud provider: handle expensive loop for get VM ID

In photon.go function getVMIDbyIP and NodeAddresses have very expensive loops to get the VM ID from IP address.
Alain's comment about this usage:
"This is an extremely expensive function. Each call to get the VM IP addresses is expensive (you make an API caller to Photon Controller, which makes an API call to hostd on the appropriate host, and that call isn't cheap). If there are a lot of VMs, this will be extremely expensive."
These functions are called everytime when a Pod is created.
A temporary solution to cut down the cost by recording the IP and ID mapping.
Better solution:
Check if it's possible to PC API can add one more option for VmGetOptions to include IP address.
Another thing to explore: when using docker multi-node, hostname is overriden by IP using '--hostname-override=${IP_ADDRESS}'. Master only have the information of worker's IP address as hostname. Why this is required? Any other way to get node name? If we can get the node name from something else, we can remove this expensive loop.

CC/ @govint


fix: test accessible before getIndices

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
#456
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:

Codecov Report

Merging #465 (6c0639d) into main (f4e6398) will increase coverage by 0.17%.
The diff coverage is 100.00%.

:exclamation: Current head 6c0639d differs from pull request most recent head 79d043e. Consider uploading reports for the commit 79d043e to get more accurate results

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   44.67%   44.84%   +0.17%
==========================================
  Files         314      314
  Lines       17501    17434      -67
  Branches     2341     2329      -12
==========================================
  Hits         7818     7818
+ Misses       9683     9616      -67

Impacted Files
Coverage Δ

packages/core/src/mesh/ModelMesh.ts
97.90% <100.00%> (-0.21%)
:arrow_down:

packages/draco/src/decoder.ts
0.00% <0.00%> (-0.92%)
:arrow_down:

packages/loader/src/scene-loader/Oasis.ts
0.00% <0.00%> (ø)

...ackages/loader/src/scene-loader/ResourceManager.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e6398...79d043e. Read the comment docs.


Refactor sci model

Types of changes

[x] Enhancement (project structure, spelling, grammar, formatting)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

A description of the changes proposed in the Pull Request
Simplifies SCI model logic, refactors model code and adds new unit tests.
Closes https://github.com/Green-Software-Foundation/if/issues/279


⚠ Bofrost.lu has degraded performance

In 6f5acec, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2056 ms

Resolved: Bofrost.lu performance has improved in 5124d1e after 2 hours, 33 minutes.


484 box sizing border box (2)

Fix #484
Added universal star selector for box-sizing: border-box (normalization, reset, streamline).
Test URLs

Before: https://main--hlx-test--urfuwo.hlx.page/design/design-system
After: https://484-box-sizing-border-box-2--hlx-test--urfuwo.hlx.page/design/design-system (looks the same)

Please ignore PR #486.

Please proceed with #496.


Hello... A tad of an issue.

[Wed Jan 24 14:36:10.829448 2024] [proxy_fcgi:error] [pid 9381] [client <IP_ADDRESS>:60498] AH01071: Got error 'PHP message: PHP Fatal error:  Uncaught mysqli_sql_exception: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND (name LIKE '%Var%' OR description LIKE '%Var%')  LIMIT 0,101' at line 1 in /var/www/html/public_html/services/opensim.phplib/mysql.func.php:118\nStack trace:\n#0 /var/www/html/public_html/services/opensim.phplib/mysql.func.php(118): mysqli_query()\n#1 /var/www/html/public_html/services/helper/query.php(430): DB->query()\n#2 [internal function]: dir_classified_query()\n#3 /var/www/html/public_html/services/helper/query.php(590): xmlrpc_server_call_method()\n#4 {main}\n  thrown in /var/www/html/public_html/services/opensim.phplib/mysql.func.php on line 118'
<IP_ADDRESS> trunk on both. Using updates, but problem with OpenSimSearch. Latter PHP installed. Most all works, this doesn't on this end.
Thank you!

Also you have in /opensim.modules/Profile/conf/OpenSim.ini.example
--
;Add the following to your own OpenSim.ini file to make the UserProfile service working
[Profile]
Module = "OpenSimProfileModule"
; Change it to your own HTTP server to have the Profile server work
ProfileURI = "YOUR_HELPER_URL/profile.php"

--
Couldn't get it to work, but change "ProfileURI" to "ProfileURL" and it works.
Thank you!

Also, even with issues, thank you for continuing the work on the helper scripts and modules.


Introduce provisioning throttling cap + increase delay between provisioning attempts

Creating a different change as per discussion in https://github.com/jenkinsci/openstack-cloud-plugin/pull/365 to address https://github.com/jenkinsci/openstack-cloud-plugin/issues/56
Testing done
More changes are needed as I am seeing failures https://gist.github.com/scottmarlow/f691ecc3f3eff496ad1a75e59f2ad9f5

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Thanks Scott, merging!

@olivergondza is openstack-cloud-plugin/pull/368 in Jenkins 2.415 (2023-07-18)?
When was the last release of https://github.com/jenkinsci/openstack-cloud-plugin?  I am not sure I can go by the https://github.com/jenkinsci/openstack-cloud-plugin/releases information.  Thanks!

@scottmarlow, What you see on the releases page is a "Draft" release. IOW, it is prepared to be part of the next release. When it will get out, it will be independent of Jenkins core release and hence installable to the newest Jenkins cores.


Update with upstream

@joannis review please 🙂
After this i can do the other one for the actual fixes

Kind of forgot to wait for @crarau.


Create cluster - list region filtered by OCP version

Use the aws_inquiries endpoint and pass the version to fetch the supported regions.
Related: SDA-6765

@zgalor @pvasant @ciaranRoche PTAL


MIAD-221 Allow creating alert with inactive code if request has Admin UI role

MIAD-221

Codecov Report
Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.11%. Comparing base (87e870b) to head (659e392).

Files with missing lines
Patch %
Lines

...mppsalertsapi/resource/PrisonerAlertsController.kt
75.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #211      +/-   ##
============================================
- Coverage     94.16%   94.11%   -0.05%
- Complexity      537      540       +3
============================================
  Files            88       88
  Lines          1765     1768       +3
  Branches        106      107       +1
============================================
+ Hits           1662     1664       +2
  Misses           66       66
- Partials         37       38       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


As a guest I want to get info what happens when Admin deletes board.

Currently all 404 ending requests are set to redirect the user to the workspace. We should probably add some sort of a "Resource not found" message along with explanation for normal users.

There is actually a message, but it disappears almost instantly when user is kicked out

Change the redirect to happen with the BOARD_REMOVE event and otherwise just display some sort of an error message?

There is message about deleted board. Acceted as fixed!
Client versio	v1.2.118
API versio	v0.4.42
IMG versio	v0.1.10


Opacity issue fixed / button changed to 'added to favoutites and turn…

1 - Opacity issue fixed - see 'border' class in CSS to modify this further. This class is added to the movie posters images when they are clicked. It previously added the green border now it also changes opacity to 1.
2 - green border also added on hover over these posters (feel free to remove)
3 - add to favourites button text changes to 'Added to favourites' if movie is already in favourites  / on click - button also turns green.
Cheers

Great job! Was banging my head on that opacity for too long, think I overcomplicated it...


Hi from NWB!

We were excited to see you cited the new NWB eLife paper in your recent publication on this software. We see that you export data to NWB. Do you also read NWB files?
We would like to invite you to submit a PR including a description of your software in our gallery of supported tools here.

Hi @bendichter
Yes, Patchview converts Heka or Axon file format for patch-clamp data, exports to NWB files. It has APIs to read those NWB files . A quick demo  here.
Thanks for the invitation. The gallery looks awesome. We will submit a PR soon.

Excellent!

A PR is submitted.
Thanks!


delete return;

that code after return should be removed. it's unnecessary. :-D

that code after return should be removed. it's unnecessary. :-D


[SPARK-9825][yarn] Do not overwrite final Hadoop config entries.

When localizing the gateway config files in a YARN application, avoid
overwriting final configs by distributing the gateway files to a separate
directory, and explicitly loading them into the Hadoop config, instead
of placing those files before the cluster's files in the classpath.
The implementation is a little hacky, but mostly because there's no API
that tells you which are the files that are loaded by a YarnConfiguration
object; so the list of files was obtained empirically and is hardcoded
in the code.
Tested with existing unit tests, and by verifying the behavior in a YARN
cluster (final values are not overridden, non-final values are).

I also tried a different approach (dumping the conf object to a new XML file and adding that as a resource), but the dumped file contained all the default values from the config object (in spite of what the API docs say), so even though my config files only had a handful of entries, the final XML file was over 100k (way bigger than the sum of the original files).
That might be cleaner, but it is slower.

Test build #78323 has started for PR 18370 at commit 4c35cce.

Test build #78323 has finished for PR 18370 at commit 4c35cce.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78323/
Test PASSed.

Merged build finished. Test PASSed.

@tgravescs any options about this (or the alternate solution described above)?

so the issue here is that the gateway boxes have a different hadoop config on purpose because from those boxes you need one proxy but on the actual yarn nodes you don't need the proxy?
I thought someone had the exact other issue where they wanted the gateway configs to work over the server side configs.  I guess that is fine if its not final.
I agree with you that its a bit hacky and not very nice we have to hardcode the files.
I was actually thinking of the second approach you tried.  Like you mention it will definitely pull in all the defaults so that might be larger then the config files but its going to depend on that setup.  How large is that file (in KB/MB)?

Yeah, the original feature was for someone who wanted to override certain configs locally; that makes sense (e.g. some user has a custom config with a different replication factor than the cluster's), but it shouldn't overwrite final configs. It's still possible to override final configs if the user really wants to (e.g. by setting spark.hadoop.* in Spark's config).

How large is that file (in KB/MB)?

The generated XML is about 100k (compared to about 10k for the XML files in the config directory). It's not too horrible if you think about it. Maybe it's better to go that route.

Yeah I think that is going to be safer.   That is what mapreduce does with its job.xml file.  I'm not sure about tez.

Test build #79480 has started for PR 18370 at commit 3d59f0b.

Test build #79480 has finished for PR 18370 at commit 3d59f0b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79480/
Test PASSed.

Test build #79573 has started for PR 18370 at commit 302f16c.

Test build #79573 has finished for PR 18370 at commit 302f16c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79573/
Test PASSed.

+1, the only downside here is we are now shipping the xml files twice.  still the entire hadoop conf dir and now as the single xml file.  it feels like we shouldn't ship the hadoop conf dir but that might break some people.  on running, my combined spark_hadoop_conf.xml was about 160k.

it feels like we shouldn't ship the hadoop conf dir but that might break some people

Yeah, we rely on that to ship other configs (like Hive and HBase) with the application without the user having to mess with --files and whatnot.
Thanks, merging to master.


wait_for_services.py handles if pg never responds in the timeout window

Currently, if postgres never responds, wait_for_services.py  just hangs indefinitely, never returning.

Task linked: QF-3825 wait_for_services.py handles if pg never responds in the timeout window

I tried many ways to get more details on errors as advertised in the documentation, or here, with no success.


prefer-regexp-test doesn't account for non-RegExp arguments

The String.prototype.match function allows non-RegExp arguments which isn't accounted for. This causes incorrect auto fixes.
For more information, see sindresorhus/eslint-plugin-unicorn#1150.

I didn't know that 😓.  I will fix it.


Feature: Sign in methods

User story
As an end user of the app, I would expect to see simple sign in flow.
Acceptance criteria

[ ] In the App bar, I can see whether I am logged in or not
[ ] When logged in, I can see my profile name and log out button
[ ] When not logged, I can see log in button
[ ] When visiting from android or iphone, I see my default sign in method first (may not be possible)

Developer notes
If we decide to use Azure B2C, we may not be able to build our custom sign in page as it is delegated to Azure.
We may consider, if we allow custom sign in solution without Azure B2C or classic Azure.
Possible methods:

Username and password
3rd party OAuth like AAD, Google or other socials
Magic link or QRCode

User will also expect to see native login method first (Google or QRCode on android, AppleID on iPhone, SSO on corporate device etc.

MOM is by default SPA app with optional PWA takeover and mobile app and possibly extension
Compare libs
https://npmtrends.com/adal-node-vs-msal-vs-oidc-client-vs-passport-azure-ad-vs-passport-oauth2
FOR AZURE
https://learn.microsoft.com/en-us/azure/active-directory/develop/active-directory-v2-protocols
FOR SPA
SPA is public client, because javascript in browser does everything.
Because of that, we need to use MSAL.js v2.0+ and that supports only auth code flow (+ Proof Key for Code Exchange (PKCE) and OpenID Connect (OIDC)).
https://learn.microsoft.com/en-us/azure/active-directory/develop/authentication-flows-app-scenarios#single-page-application
https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow
https://datatracker.ietf.org/doc/html/rfc6749
Some helpful help page with nice links
https://learn.microsoft.com/en-us/answers/questions/852430/help-with-microsoft-authentication-library-(msal)
https://devblogs.microsoft.com/azure-sdk/vue-js-user-authentication/
https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/samples/msal-browser-samples/vue3-sample-app <-- Currently implementing this
FOR BACKEND
Protect itself
For user (SPA client) to call our API, we will receive Acces token in the header that we need to validate.
https://learn.microsoft.com/en-us/azure/active-directory/develop/scenario-protected-web-api-overview
Access other resources
If we want to access other resources in the tenant, we will create another app registration, add persmissions and add client id and secret to app.
Currently there are no official libs for Rust. This may be official one day https://github.com/Azure/azure-sdk-for-rust
Ideas:

send e-mail using MS API
Call AI for some analysis or content generation

QR code generation as serverless function in azure
FOR OTHER OIDC
MSAL.js should be usable for other providers
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/configuration.md
https://stackoverflow.com/questions/67934505/using-msal-with-non-microsoft-identity-providers


Fix loginpath for Caddy usage (issue #108)

Fixes #108.
@smancke please review if behaviors are right.
This PR would probably need test cases added. I didn't add new ones yet as I'm unsure if current behaviors are expected or not.

Coverage remained the same at 90.781% when pulling ce840618ab20645c42a1738710b08f804f57bd60 on magikstm:issue-108 into 7a8566d795ccd0337dbd35078817f06ae5edccb1 on tarent:master.

Closing this PR as it needs to be reevaluated as mentioned in #108.


Feature/merge data stream

Some additions to be made, but this works well! Hopefully can get this pulled in

Thanks, I'll make some updates

Closing as superseded by #55 and #56.


IntelliSense hangs

IntelliSense hangs. In order to get it working again need to restart vs code. Then, after the restart, it stops working very soon again.
It is just so sad to see that there are still almost in 2021 no proper reliable robust dev tools to work with Azure - it looks that Azure is still a very immature technology.

Same issue.


feat(tooltip+popover): add boundary config option

Related to issue #24251, larger popovers and tooltips which have the trigger element placed inside an element with overflow: scroll (or similar) will end up with weird placements that cover the trigger element (note the trigger button is completely hidden by the popover):

This PR, similar to PR #24976, adds a boundary config option, that allows the user to specify what element constrains the positioning of the tooltip or popover. The  boundary option accepts a string - either 'scrollParent' (the Popper.js default), 'viewport' or 'window' - or a reference to an HTMLElement (which can only be set via the JavaScript option, not data-boundary="...").  The new config option boundary is passed directly to the Popper.js config modifiers.preventOverflow.boundariesElement as is.
Popover with boundary set to 'viewport', which now can properly breakout of the scrollable parent:

This PR doesn't include the position: static fix required in PR #24976 (dropdowns), as tooltips and popover are typically appended to <body> and not the scrollable container, nor is there an obvious parent element to place position: static on.
/cc @Johann-S

But same as your other PR, you have 15 commits in this PR, and I don't think we need all of those commits so please do a rebase so we can have only what's needed :+1:

Yeah, not sure how to clear out those older commits from the previous PR that was merged.

We cannot :worried:


No sound when built in Testflight on iOs

Question
Hi there,
So I've implemented the audio toolkit according to the documentation and I've added my sound files to the bundle (right click -> add files to project) in XCode.
My problem is, it's working fine in the development (both on simulator + device) but as soon as I build the project and run it either on the simulator, device or publish through XCode I get no sound.
Has anyone else had that issue?

Hi, did you find a solution? I have the same problem. Thanks!

I am having the same issue.

I am having the same issue.

Just run the app via xCode in Release mode and it won't play the sound as well. It was a bug in the code. I've no idea what was the solution but at least you hopefully can test it :)

I added a line to add Info.plist and I'm going to test again to see if this works for my issue. It was just crashing when I tried to record.
<key>NSMicrophoneUsageDescription</key>
<string>This app requires access to your microphone for speech-based reporting</string>

oh ok, got it. So in my situation it didn't crash in Release mode but didn't play the sound.

Any one fixed the same issue??? There was no crash but in Development mode sound is coming Release mode sound is not coming. Please help me out if anyone found the solution for this.

Question
Hi there,
So I've implemented the audio toolkit according to the documentation and I've added my sound files to the bundle (right click -> add files to project) in XCode.
My problem is, it's working fine in the development (both on simulator + device) but as soon as I build the project and run it either on the simulator, device or publish through XCode I get no sound.
Has anyone else had that issue?

Did You find the solution???

Hi, did you find a solution? I have the same problem. Thanks!

Did you got solution?

Hi there, same issue here, do you find any solution??


no matches for kind "Route" in version "route.openshift.io/v1"

I cannot create a default Grafana instance in my Openshift 4.2 cluster. I installed the operator through the Openshift web console and tried to create the instance from there as well, using the default YAML. The error in the operator pod indicates the issue in the title, see logs below. This is pretty recent as I was able to install it just fine about a month ago.
Thanks
kind: Grafana
metadata:
  name: example-grafana
  namespace: awswebinar
spec:
  ingress:
    enabled: true
  config:
    auth:
      disable_signout_menu: true
    auth.anonymous:
      enabled: true
    log:
      level: warn
      mode: console
    security:
      admin_password: secret
      admin_user: root
  dashboardLabelSelector:
    - matchExpressions:
        - key: app
          operator: In
          values:
            - grafana

{"level":"error","ts":1588108258.5341883,"logger":"kubebuilder.controller","caller":"controller/controller.go:209","msg":"Reconciler error","Controller":"grafana-controller","Request":"awswebinar/example-grafana","error":"no matches for kind \"Route\" in version \"route.openshift.io/v1\"","stacktrace":"github.com/integr8ly/grafana-operator/vendor/github.com/go-logr/zapr.(*zapLogger).Error\n\t/home/travis/gopath/src/github.com/integr8ly/grafana-operator/vendor/github.com/go-logr/zapr/zapr.go:128\ngithub.com/integr8ly/grafana-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/home/travis/gopath/src/github.com/integr8ly/grafana-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:209\ngithub.com/integr8ly/grafana-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1\n\t/home/travis/gopath/src/github.com/integr8ly/grafana-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:157\ngithub.com/integr8ly/grafana-operator/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\t/home/travis/gopath/src/github.com/integr8ly/grafana-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133\ngithub.com/integr8ly/grafana-operator/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/home/travis/gopath/src/github.com/integr8ly/grafana-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134\ngithub.com/integr8ly/grafana-operator/vendor/k8s.io/apimachinery/pkg/util/wait.Until\n\t/home/travis/gopath/src/github.com/integr8ly/grafana-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88"}```

This goes away when removing the ingress spec, but doesn't create the route in that case

Hi @mrethers , sorry for letting this slip by, are you still seeing this issue or perhaps found a cause for it?

Seems like the latest version is working so I'm unblocked. Looking at other
operators it looks like it might have been some missing import in the go
code.
Keep up the awesome work guys.
On Wed, Aug 19, 2020, 5:27 AM Hubert Stefanski<EMAIL_ADDRESS>wrote:

Hi @mrethers https://github.com/mrethers , sorry for letting this slip
by, are you still seeing this issue or perhaps found a cause for it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/integr8ly/grafana-operator/issues/175#issuecomment-676024048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBZ37NPVTNJAAW5M7I2R6TSBOLJBANCNFSM4MTF57EQ
.

@mrethers Cool, Happy to hear! let us know when you find anything else that needs attention :smile:


Hash Links in docs

If I write (for example) The #Num.abs function in a doc string, that should get converted to a link to the docs for the Num.abs function, because I put the # in there.
The rules for how this should work:

If there's a # followed immediately by a letter in a doc string (but outside a code block), we parse that as a hash link.
Hash links use the module's scope to resolve the identifiers and figure out what to link to. (For example, if the module has foo imported unqualified, then I can reference it with #foo, and if the module header has Json.Decode imported as JD then #JD.str should link to the docs for Json.Decode.str)
If there's a naming error when resolving one of these (e.g. we encounter #blah but we can't find a blah in scope), we should report it as a naming error in the console. Like with all other Roc compilation, this shouldn't block progress (we should generate a broken link there and continue), but it should mean we exit with a nonzero status when the command finishes.
If you actually really want a # there, and don't want it to become a link, we should allow this with \#. If you really want to write a \#, then you'd write \\# instead.

Links in docs exist now (though with [] instead of #). Here's a random example: https://github.com/roc-lang/roc/blob/b7c2cb084e15a56320e652ad3c77fdb8262bc1a4/crates/compiler/builtins/roc/Str.roc#L530


feat: port Algebra.Group.With_One

Mathlib commit 1fc36cc9c8264e6e81253f88be7fb2cb6c92d76a .

This is currently blocked by the Algebra.Hom.Group PR

Actually perhaps its' just easier to close this and start a new PR.

https://github.com/leanprover-community/mathlib4/pull/841


Set a heuristic for deciding on the best number of neurons

Cross validation to find the best number of neurons takes unacceptably long. We need to decide on a good heuristic that doesn't require cross validation and implement it ASAP.

Fixed in commit dbb101d.


Error: WebSocket is not open: readyState 3 (CLOSED)

setupLocalChrome is generating an error when I invoke the Lambda function more than once. Here's my trace.
Error: WebSocket is not open: readyState 3 (CLOSED)
    at WebSocket.send (/var/task/node_modules/ws/lib/websocket.js:314:19)
    at WebSocketTransport.send (/var/task/node_modules/puppeteer/lib/WebSocketTransport.js:57:14)
    at Connection.send (/var/task/node_modules/puppeteer/lib/Connection.js:71:21)
    at Browser._getVersion (/var/task/node_modules/puppeteer/lib/Browser.js:233:29)
    at Browser.version (/var/task/node_modules/puppeteer/lib/Browser.js:208:32)
    at Browser.<anonymous> (/var/task/node_modules/puppeteer/lib/helper.js:145:23)
    at isBrowserAvailable (/var/task/starter-kit/setup.js:31:19)
    at Object.exports.getBrowser (/var/task/starter-kit/setup.js:15:51)
    at exports.handler (/var/task/index.js:14:31)

Afterward, the function logs launch done: HeadlessChrome/67.0.3361.0 and runs the function as expected...Let me know if I can provide more information to help reproduce this error.

I am experiencing the same on the second and third invocation. Any fix? Please advise.

Same here.

Okay FWIW, I was facing this because I was registering the event handlers on callback passed to ws method as shown below.
 app.ws('/websocket', (ws, req) => {     console.log('Websocket connection');     myEventEmitter.on('customEvent', (data) => {         ws.send(JSON.stringify(data))     }) })
This was causing the a new instance of listener to be registered everytime. However the old listener was still around but it was referring to an instance of ws that was already disconnected. As a consequence whenever the old listener was called this error was being thrown. I had to create another custom end event to signal end of the process in which I removed the listener (See below).
app.ws('/websocket', (ws, req) => {
console.log('Websocket connection');
console.log('Query string => ', req.query)
myEventEmitter.on('customEvent', (data) => {
ws.send(JSON.stringify(data))
})
myEventEmitter.on('endEvent', () => {
    // Remove all listeners.
   myEventEmitter.removeAllListeners('customEvent')
   ws.close()
})

})`
I was doing this using express-ws

This comment on this GitHub issue may help: https://github.com/puppeteer/puppeteer/issues/4428#issuecomment-500184469


ref/update_example

Update the example to support the dark mode.  Also, update the UI to mimic the RN.

Scale the image, and delete the old icons.


libical: 3.0.9 -> 3.0.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/libical/libical/releases.
meta.description for libical is: "An Open Source implementation of the iCalendar protocols"
meta.homepage for libical is: "https://github.com/libical/libical"
meta.changelog for libical is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.0.10 with grep in /nix/store/a8arnxvkfn2rx5bh1mlya92mpd1m2q8p-libical-3.0.10

found 3.0.10 in filename of file in /nix/store/a8arnxvkfn2rx5bh1mlya92mpd1m2q8p-libical-3.0.10

directory tree listing: https://gist.github.com/1fce7e78dac474e75f39dd9b174f243d

du listing: https://gist.github.com/e1241140ee385ac93c53b8122888918a

Rebuild report (if merged into master) (click to expand)

3667 total rebuild path(s)

1285 package rebuild(s)

1285 x86_64-linux rebuild(s)
1173 i686-linux rebuild(s)
54 x86_64-darwin rebuild(s)
1155 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
adapta-gtk-theme
adoptopenjdk-icedtea-web
almanah
anydesk
apostrophe
appgate-sdp
aravis
arc-theme
areca
arx-libertatis
asciidoc-full
asciidoc-full-with-plugins
astroid
audio-recorder
aws-workspaces
azureus
balsa
banking
baresip
bibata-cursors
bibata-cursors-translucent
bibata-extra-cursors
birdfont
bitwig-studio
bitwig-studio2
bitwig-studio3
bluejeans-gui
blueman
bluetooth_battery
bluez
bluez-alsa
bluez5
bolt
bookworm
brasero
brasero-original
brltty
bt-fw-converter
btrbk
bubblemail
byzanz
cadence
caerbannog
calligra
calls
capitaine-cursors
cawbird
ccache
ccacheStdenv
ccacheWrapper

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/a8arnxvkfn2rx5bh1mlya92mpd1m2q8p-libical-3.0.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libical https://github.com/r-ryantm/nixpkgs/archive/dd6c14a80949509797544ad7c873283107522d07.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/a8arnxvkfn2rx5bh1mlya92mpd1m2q8p-libical-3.0.10
ls -la /nix/store/a8arnxvkfn2rx5bh1mlya92mpd1m2q8p-libical-3.0.10/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings

Result of nixpkgs-review pr 120826 at dd6c14a8 run on x86_64-linux 1

185 packages marked as broken and skipped:

gimpPlugins.exposureBlend
gimpPlugins.texturize
glimpsePlugins.exposureBlend
glimpsePlugins.texturize
gnokii
gnome3.gnome-books
gnome3.gnome-documents
gnunet-gtk
libsForQt512.akonadi-calendar
libsForQt512.akonadi-import-wizard
...

772 packages skipped due to time constraints:

adapta-gtk-theme
adoptopenjdk-icedtea-web
almanah
anydesk
apostrophe
appgate-sdp
aravis
arc-theme
areca
arx-libertatis
...

16 packages built successfully:

bluez (bluez5)
cwiid
libical
libnma
linuxPackages.xpadneo (linuxPackages_5_10.xpadneo)
networkmanager
obex_data_server
obexfs
obexftp
openobex
python38Packages.bleak
python38Packages.pybluez
python38Packages.python-dbusmock
ubertooth
urserver
wiiuse

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/libical/default.nix:92:3:
   |
92 |   meta = with lib; {
   |   ^


feature: changes to support upgrade to Fabric v2.5 TLS in Firefly CLI

Updated GO to version 1.20 (Fabric 2.5 compatibility) and Ubuntu as the base instead of Alpine.
Fixes this Issue: #1414
Related to the Firefly CLI change here: #https://github.com/hyperledger/firefly-cli/issues/268
E2E test passed:
--- PASS: TestFabricMultipartyE2ESuite (137.02s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EBroadcast (3.97s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EBroadcastBlob (34.51s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EPrivate (3.74s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EPrivateBlobDatatypeTagged (3.71s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EWebhookExchange (7.61s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EWebhookRequestReplyNoTx (4.78s)
--- PASS: TestFabricMultipartyE2ESuite/TestStrongDatatypesBroadcast (7.58s)
--- PASS: TestFabricMultipartyE2ESuite/TestStrongDatatypesPrivate (7.29s)
--- PASS: TestFabricMultipartyE2ESuite/TestCustomChildIdentityBroadcasts (7.88s)
--- PASS: TestFabricMultipartyE2ESuite/TestCustomChildIdentityPrivate (11.26s)
--- PASS: TestFabricMultipartyE2ESuite/TestInvalidIdentityAlreadyRegistered (9.39s)
--- PASS: TestFabricMultipartyE2ESuite/TestE2EContractEvents (2.69s)
PASS
ok  	github.com/hyperledger/firefly/test/e2e/runners	137.028s

Codecov Report

Merging #1415 (505dc2d) into main (13bf4e1) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 505dc2d differs from pull request most recent head 2bdec12. Consider uploading reports for the commit 2bdec12 to get more accurate results

@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   99.99%   99.99%
=======================================
  Files         321      321
  Lines       23027    23027
=======================================
  Hits        23025    23025
  Misses          1        1
  Partials        1        1

Closing this PR due to inactivity. Please feel free to re-open if this work is still ongoing.
I believe the changes in the PR are actually included in this one as well: https://github.com/hyperledger/firefly/pull/1454


⚠ GitHub has degraded performance

In 7801f00, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 177 ms

Resolved: GitHub performance has improved in 8694e98.


Zookeeper and connected event

How do you know with kafka-node if the connection to zookeeper has been succesfull ?
Ideally  I would like to have something like this:
var client = new kafka.Client('localhost:2081', 'rtc-client');
client.once('connected', function () {
    console.log('Connected to ZK.');
});

I have noticed that zookeeper.js expose a 'connected' event which work as expected. However, how do you use it with kafka.Client ?
kafka-node/lib/zookeeper.js
var Zookeeper = function (connectionString, options) {
    this.client = zookeeper.createClient(connectionString, options);

    var that = this;
    this.client.on('connected', function () {
        that.listBrokers();
    });
    this.client.connect();
};

That is done by this.client.on('connected')

I tried to do it on kafka.Client but it does not seem to work: It never triggers the event. However, it is triggering properly in zookeeper.js
this.client.on('connected', function () {console.log("connected!"});

app.js
var client = new kafka.Client('localhost:2081');
client.on('connected', function () {
    console.log('Connected to ZK.'); // it never goes here
});

yes, kafka.Client will not emit connected event. If you really need this you should use client.zk.on('connected', fn)

It does not seem to work with(also tried with client.zk.once) :
var client = new kafka.Client('localhost:2081');
client.zk.on('connected', function () {
    console.log('Connected to ZK.'); // it never goes here
});

However, a simple test like this works fine:
var zookeeper = require('node-zookeeper-client');
var client = zookeeper.createClient('localhost:2181');
client.once('connected', function () {
    console.log('Connected to the server.');
});
client.connect();

sorry, the code should be client.zk.client.on('connected', cb), but doing so also won't work, because before the code which listen the event executed, the connected event already emitted.

Ok I see, thanks for your reply


Feature: add "requested destination" or other save specs?

Should we add something like requested_destination to MDASequence?
I don't (immediately) want to add a whole lot of specific saving stuff, but a single field requesting a destination path might be very useful for possible downstream writers: It would provide a directory, base name, and extension.  Writers could then increment that base name as desired (until any further spec added instructions on that sort of thing)
@ianhi ?

Sounds good to me! Maybe also an extra metadata dictionary to allow for downstream uses we can't conceive of now?
Are you imagining these all as required arguments, or optional?

everything optional.  you should probably always be able to call MDAEvent() or MDASequence() without args.

ooh right because requested_destination is the name. Rather than something like "save_params" which would be it's own object

yeah, for now, the writer (over in pymmcore-plus) would have all the parameters.  This is just a bare-minimum sort of start.
I can imagine something like this:
seq = MDASequence(requested_destination='...')

class MDARunner():
    def run(self, events: MDASequence):
        if seq.requested_destination:
            for writer in self.writers:
                writer.set_destination(seq.requested_destination)

but... I dunno

yeah, good question.  I can't see an immediate use case for multiple writers... but I do think that so far, the writer "spec" fits a general category of something that I can see multiple of: namely, anything that wants to be notified at the start, end, and each frame of an acquisition, let's call it a handler:
class Handler:
    def sequenceStarted(): ...
    def frameReady(): ...
    def sequenceFinished(): ...

so, I'm kinda mentally leaving that possibility open :)


phonenumbers from tagexpr... taking memory in heap

Describe the bug
i saw phonenumbers... and only from tagexpr...
it is taking mem in heap alloc mem profile.
can u check screenshot and see if it's a bug or something?
Screenshots
Hertz version:
latest

error on my part. resolved.


adding rgbcolor and stackblur as deps

I had some trouble getting canvg to work with webpack because the dependencies on rgbcolor and stackblur.
I don't think this change would cause many problems.

:+1:


Property missing in Viridian Amber Medallion +3

The Viridian Amber Medallion +3 talisman is missing the isDLC property.
https://github.com/Gobluebro/Elden-Ring-Checklist/blob/63893606137ede788b7ce9afb0a0d3cb3f45f804/data/lists/collectables.ts#L2274-L2280

Thanks!


Anchor IDL different (incorrect?) from Solana Playground IDL generated

I was following this guide to learn anchor: https://www.quicknode.com/guides/solana-development/anchor/transfer-tokens
When deploying the program via Solana Playground (as instructed), everything runs fine. The issue comes from trying to replicate on my local machine using anchor. The code is exactly the same; however I was running into this issue when trying to invoke the transferLamports function:
    'Program log: Instruction: TransferLamports',
    'Program log: AnchorError caused by account: to. Error Code: ConstraintMut. Error Number: 2000. Error Message: A mut constraint was violated.',

After much, much frustration I discovered that the issue is with the IDL that Anchor generates when building the program. Comparing to the one that Solana Playground generates (remember - exact same lib.rs):
Solana Playground
"accounts":[
{"name":"from","isMut":true,"isSigner":true},
{"name":"to","isMut":true,"isSigner":false},
{"name":"systemProgram","isMut":false,"isSigner":false}],
"args":[{"name":"amount","type":"u64"}]}]

Local Anchor
      "accounts": [
        {
          "name": "payer",
          "writable": true,
          "signer": true
        },
        {
          "name": "recipient",
          "writable": true
        },
        {
          "name": "system_program",
          "address": "11111111111111111111111111111111"
        }
      ],
      "args": [
        {
          "name": "amount",
          "type": "u64"
        }
      ]

Pulling down the IDL from Solana Playground and using that in my Typescript module instead allows the code to run just fine.
    const sig = program.methods.transferLamports(new BN(10000)).accounts({
        from: from.publicKey,
        to: to.publicKey,
        system_program: system_program
    })

What is causing anchor to produce a completely different IDL type that isn't compatible with anchor itself?

This is because the IDL has been rewritten, and it's incompatible with the old IDL.
There is also a new release (v0.30.0) which was released 2 days ago. Solana Playground has not yet upgraded to the latest version, so if you use the IDL generated from there (or any other place), you can use the 0.29.0 version of @coral-xyz/anchor locally (instead of 0.30.0).

This is because the IDL has been rewritten, and it's incompatible with the old IDL.
There is also a new release (v0.30.0) which was released 2 days ago. Solana Playground has not yet upgraded to the latest version, so if you use the IDL generated from there (or any other place), you can use the 0.29.0 version of @coral-xyz/anchor locally (instead of 0.30.0).

Hi, appreciate the quick response.
Before I go messing around with all my configuration, can you clarify for me if there is a version of the 'npm' anchor package which can correctly invoke program functions with this new IDL format? Any quick references on syntax?

Before I go messing around with all my configuration, can you clarify for me if there is a version of the 'npm' anchor package which can correctly invoke program functions with this new IDL format? Any quick references on syntax?

It will work as long as you use the same Anchor version for all tooling (crates, packages, CLI).
See https://www.anchor-lang.com/release-notes/0.30.0#type-script

Adding extra context for anyone else finding this in the future; not quite there yet:
I've updated everything to the most recent version but now I'm getting an error when the final method .rpc() is called.
I've tracked it to the build function in the NamespaceFactory index.js,  the issue stems from coder.instruction.encode(ixName, ix):
TypeError: Cannot read properties of undefined (reading 'encode')
I believe this means I've setup my provider wrong? I can't find any changes from 0.26 (the version i had before) and the current version; I did not change any other code. Currently the provider is setup like this:
    const provider = new AnchorProvider(conn, new Wallet(myPK), AnchorProvider.defaultOptions());
    setProvider(provider);

I'm calling the function via
    const sig = await program.methods.transferSol(new BN(10000)).accounts({
        payer: from.publicKey,
        recipient: to.publicKey,
        system_program: system_program
    }).rpc()

Always use camelCase in TS package : https://www.anchor-lang.com/release-notes/0.30.0#case-conversion
Instead of system_program use systemProgram. It's also not even necessary to specify program accounts in the new version if you get the correct types from target/types and initialize your program with that type.

How to define program with @coral-xyz/anchor 0.30.0 in typescript?
My current code, which is not working.
import * as splStakingIdl from './idl/spl_staking.json';
const program = new anchor.Program(splStakingIdl, provider);

In version 0.29.0, I used to implement it by this:
import {
  IDL as SplStakingIdl ,
  SplStaking,
} from "./idl/spl_staking";
const program = new anchor.Program(SplStakingIdl as SplStaking, programId, provider);

After upgrading to 0.30.0, anchor doesn't generate IDL in target/types.
Is there any example codebase to integrate program with @coral-xyz/anchor 0.30.0 in typescript?

All you need is to cast the idl.json's type to the generated camelCased IDL type in target/types. For example:
import * as idl from "./idl/spl_staking.json";
import type { SplStaking } from "./types/spl_staking";

const program = new anchor.Program(idl as unknown as SplStaking, provider);

or
import type { SplStaking } from "./types/spl_staking";

const idl: SplStaking = require("idl/spl_staking.json");
const program = new anchor.Program(idl, provider);

All you need is to cast the idl.json's type to the generated camelCased IDL type in target/types. For example:
import * as idl from "./idl/spl_staking.json";
import type { SplStaking } from "./types/spl_staking";

const program = new anchor.Program(idl as unknown as SplStaking, provider);

or
import type { SplStaking } from "./types/spl_staking";

const idl: SplStaking = require("idl/spl_staking.json");
const program = new anchor.Program(idl, provider);

I tried both of these but they both seem to spew out: Argument of type  '<name_of_my_program> is not assignable to the parameter Idl'.
I'm using crates: anchor-lang "0.30.1", anchor-spl "0.30.1"
and package @coral-xyz/anchor "0.30.1". Does the above method only work for 0.30.0?

I got the missing name and version properties for idl issue as well - still looking for a solution

@Sidkjr, @thiruofficalsp
If you get ... is not assignable to the parameter Idl error, it means the TS package and the crate/CLI version used to generate the IDL doesn't match.
It's the same if it says missing name and version properties. You'd get this if you used @coral-xyz/anchor 0.29.0 with a new IDL for example.

@acheroncrypto Yep. Got what I was doing wrong.

It's the same if it says missing name and version properties. You'd get this if you used @coral-xyz/anchor 0.29.0 with a new IDL for example.

But eventually decided to revert back to the version of 0.29 for both anchor-lang and anchor-spl crates and it seemed to work perfectly fine.
The old IDL was better😔.

same problem, but i need use new anchor version but want to use solanaFM local idl (to help better debugging), so im try to make tools to convert my new idl to old idl, so can compatible to use in solanaFM
https://github.com/viandwi24/anchor-idl-converter


Refactor this code to a more OOP version

This is a BFS implementation for Shortest Reach for a Graph in Python.
How will you refactor this code to implement a Graph class?

Graph Python - http://www.python-course.eu/graphs_python.php


finisher_app.go Add ExecRaw Method.

[x] Do only one thing
[x] Non breaking API changes
[x] Tested

What did this pull request do?

im some time, you need to exe
finisher_app.go Add ExecRaw Method.
it use
** Do no processing and execute the original sql **
Sometimes you execute some super complex SQL statements that cannot be done with gorm or even with gorm.Raw . eg:
with idx as (
    select ('{' || odr.idx-1 || ',sub_orders,' || subOdr.idx-1 || '}')::text[] as path
      from (
        select idx, data->'sub_orders' as sub_orders
          from user_orders, jsonb_array_elements(orders) with ordinality as odr(data, idx)
         where user_id=$1 and jsonb_path_exists(data,'$ ? (@[*].id==1)')
     ) odr, jsonb_array_elements(sub_orders) with ordinality as subOdr(data, idx)
    where jsonb_path_exists(data,'$ ? (@.id==11)')
)
UPDATE user_orders
   SET orders=jsonb_set(orders, idx.path, $2, false)
  FROM idx
 WHERE user_id=$3

User Case Description

func main() {

	type UserOrder struct {
		ID        int64
		UserID in64
                Orders datatypes.JSON `gorm:"type:jsonb"`
	}

	db, err := gorm.Open(postgres.New(postgres.Config{
		DSN: `dsn`,
		PreferSimpleProtocol: false,
	}), &gorm.Config{
		Logger:                 logger.Default.LogMode(logger.Info),
		SkipDefaultTransaction: true,
	})
	if err != nil {
		log.Fatal(err)
	}

       uo ：= &UserOrder{
                 UserID :1,
                 Orders: datatypes.JSON(`
[
    {
        "id": 1,
        "sub_orders": [
            {
                "id": 11,
                "remark":"this is a remark"
            }
        ]
    }
]`)
        }

	if err := db.AutoMigrate(&UserOrder{}); err != nil {
		t.Fatal(err)
	}

	if err := db.Create(al).Error; err != nil {
		t.Fatal(err)
	}

        err:=db.ExecRaw(`with idx as (
    select ('{' || odr.idx-1 || ',sub_orders,' || subOdr.idx-1 || '}')::text[] as path
      from (
        select idx, data->'sub_orders' as sub_orders
          from user_orders, jsonb_array_elements(orders) with ordinality as odr(data, idx)
         where user_id=$1 and jsonb_path_exists(data,'$ ? (@[*].id==1)')
     ) odr, jsonb_array_elements(sub_orders) with ordinality as subOdr(data, idx)
    where jsonb_path_exists(data,'$ ? (@.id==11)')
)
UPDATE user_orders
   SET orders=jsonb_set(orders, idx.path, $2, false)
  FROM idx
 WHERE user_id=$3`,1,'{"id":1,"remark":"remark changed"}')

      if err != nil {
		t.Fatal(err)
	}
    .......

}

hello, Why not use DB.Exec  ?

Thank you for your PR, but not going to accept it.
If this is needed, maybe just use the generic DB for the job.
Thank you. https://gorm.io/docs/generic_interface.html

hello, why not use DB.Exec ? 🙃

because db.Exec will set '?' as  a paramter and set '@' as named paramter.  but the follow sql, the '?' and '@' is the raw sql  symbol.
with idx as (
    select ('{' || odr.idx-1 || ',sub_orders,' || subOdr.idx-1 || '}')::text[] as path
      from (
        select idx, data->'sub_orders' as sub_orders
          from user_orders, jsonb_array_elements(orders) with ordinality as odr(data, idx)
         where user_id=$1 and jsonb_path_exists(data,'$                                              ? (@[*].id==1)')
     ) odr, jsonb_array_elements(sub_orders) with ordinality as subOdr(data, idx)
    where jsonb_path_exists(data,'$ ? (                                       @.id==11)')
)
UPDATE user_orders
   SET orders=jsonb_set(orders, idx.path, $2, false)
  FROM idx
 WHERE user_id=$3

@jinzhu @li-jin-gou

Thank you for your PR, but not going to accept it.
If this is needed, maybe just use the generic DB for the job.
Thank you. https://gorm.io/docs/generic_interface.html

because db.Exec will set '?' as  a paramter and set '@' as named paramter.  but the follow sql, the '?' and '@' is the raw sql  symbol.
with idx as (
    select ('{' || odr.idx-1 || ',sub_orders,' || subOdr.idx-1 || '}')::text[] as path
      from (
        select idx, data->'sub_orders' as sub_orders
          from user_orders, jsonb_array_elements(orders) with ordinality as odr(data, idx)
         where user_id=$1 and jsonb_path_exists(data,'$                                              ? (@[*].id==1)')
     ) odr, jsonb_array_elements(sub_orders) with ordinality as subOdr(data, idx)
    where jsonb_path_exists(data,'$ ? (                                       @.id==11)')
)
UPDATE user_orders
   SET orders=jsonb_set(orders, idx.path, $2, false)
  FROM idx
 WHERE user_id=$3


Group food options together

When there is a food option for enrollment it would be nice if they can be grouped together in the result. This makes it easy to pass along to the food delivery company. This happened when we had multiple food options

What do you mean with grouped together? Food options are already grouped together by restaurant since #484 was implemented.
Do you have an example activity where the grouping is currently not working?

I think I found what he means; at the ouderdag it was possible to order multiple pizza's for which they added multiple food options at Domino's. This makes the grouping table look very weird: https://www.inter-actief.utwente.nl/activities/6835/

That is indeed the problem I’m talking about. I included this time an image as reference

Ah right, this is indeed a quite unique situation, to have the same restaurant for multiple food options. I agree with @Kurocon we should not combine them in this case. Separator would be nice. Another solution would be having food options where multiple items can be selected, but this is also really complex for how often it will be used.


Console output during zsh initialization detected

I'm trying to install dircolors using oh my zsh. I cloned the repo, added the plugin as the second plugin:
plugins=(
    colors
    theme-neutral
    git
    zsh-autosuggestions
    docker
    zsh-syntax-highlighting
    ls
)

but after restarting the terminal this warning is shown and there is no color highlighting:
[WARNING]: Console output during zsh initialization detected.

When using Powerlevel10k with instant prompt, console output during zsh
initialization may indicate issues.

You can:

  - Recommended: Change ~/.zshrc so that it does not perform console I/O
    after the instant prompt preamble. See the link below for details.

    * You will not see this error message again.
    * Zsh will start quickly and prompt will update smoothly.

  - Suppress this warning either by running p10k configure or by manually
    defining the following parameter:

      typeset -g POWERLEVEL9K_INSTANT_PROMPT=quiet

    * You will not see this error message again.
    * Zsh will start quickly but prompt will jump down after initialization.

  - Disable instant prompt either by running p10k configure or by manually
    defining the following parameter:

      typeset -g POWERLEVEL9K_INSTANT_PROMPT=off

    * You will not see this error message again.
    * Zsh will start slowly.

  - Do nothing.

    * You will see this error message every time you start zsh.
    * Zsh will start quickly but prompt will jump down after initialization.

For details, see:
https://github.com/romkatv/powerlevel10k/blob/master/README.md#instant-prompt

-- console output produced during zsh initialization follows --

[oh-my-zsh] plugin 'theme-neutral' not found

same

@catman85 for your interest, I decided to drop theme-colors and instead use ls_colors. This works flawlessly for me


Add a file caching mechanism

Description
When downloading files we shall add a caching mechanism so large files do not have to be requested multiple times.

Solved in https://github.com/JamitLabs/Jetworking/pull/54

Solved in https://github.com/JamitLabs/Jetworking/pull/54


Dask Array's NEP-13 and NEP-18 protocols should use common utils

NEP-{13, 18} could and should use common codebase where possible. This issue is a follow up from https://github.com/dask/dask/pull/6632#issuecomment-697869991.
For example:

chunk_types has both is_valid_chunk_type (NEP-18) and is_valid_array_chunk (NEP-13), this could be simplified and consolidated
__array_function__ (NEP-18) should probably generalise _should_delegate and both __array_ufunc__ (NEP-13) and __array_function__ (NEP-18) should just use general _should_delegate

Environment:

Dask version: 2.17.0/master

FYI @jthielen, in case you want to look into this.

Related discussion: https://github.com/dask/dask/issues/6673

Hey @ravwojdyla it's been a while and this hasn't received much discussion - is this still something you're interested in, or have you taken time to look into this independently?

Hey @charlesbluca this is a follow up from a PR, I do not intend to work on this in the near future.


Wrong argument error thrown when running jest storyshot

Hello!
I've been trying to get this project to work with storyshots and i followed the steps with #52 where i am adding the markdown loader and babel-jest to our jest config. However when i do that, I get an error when running a storyshot with the error "wrong arguments"
The way i'm doing things right now is something like
import readme from './README.md'

const stories = storiesOf('Story name', module);
stories.addDecorator(withReadme(readme));

With my typings set up to handle the readme import like
declare module "*.md" {
    const value: string;
    export default value;
}

When running the storybook ui everything does work.
Also while debugging the storyshot test, i'm finding that the readme import does have the markdown text in it, but when the function is called, it is getting an undefined parameter, which is a little odd.
I think these are all the packages that would impact this, but please let me know if you need anything else!
babel-jest: 23.6.0
storybook-readme: 4.0.2
@storybook: 4.0.7 (all are up to date)
markdown-loader-jest: 0.11.1

Again if there's anything else i can provide to help out i have no problem doing that, as this feature is amazing and i'd like to get this into our storybook!

Going to investigate this issue tomorrow

Close this for now.
If face it again reopen or create new issue. Will be cool if provided repo with reproduction.


Crash if cliName exists as executable

This PR addresses Issue #71.
Sidekick is now crashing if the cliName collides with an existing system executable like sudo or ls.

dash collides with an existing shell on Linux & MacOS
Ideas for renaming dash in tests?


frame_width and frame_height settings

@spajus @EddieOne

Invalid PR.
couldn't find file '/home/yvon/discourse/plugins/discourse-oauth2-basic/auto_generated/plugin_50f64cdcd9a52eba11d2be31d6506c7def11eadd.js'
  (in /home/yvon/discourse/app/assets/javascripts/application.js.erb)


Direct nearby uploads

I didn't feel comfortable enough to solve git issues on older branch (direct-nearby-uploads), then I decided to create a new branch, since the branch was already empty. Additionally resolved conflicts by new commits to our master. So, closing other branch.
Still working on it, but I think it is time to get feedbacks and change things accordingly.
Known issues:

Buttons don't work
Orientation change will be handled by side sheet
FAB appears on upper left corner when I remove its anchor (to hide them), I have some hacks to solve this but would love to learn the best practice
Comments aren't added
Leaks occurs

I am waiting your feedbacks for rest
And here are screenshots @maskaravivek , thanks for the remind:)

@neslihanturan The screenshots look awesome! Great work. :)
One minor suggestion - do you think it might make sense to have the camera and gallery buttons (expanded FABs) slightly larger and closer to the main FAB button (the + or x) ?

I like where things are heading - this new UI is a definite improvement - and your instinct to utilize a retained fragment to preserve data across config changes is good.  Thanks for adding screenshots to the PR!
List mode
When the NearbyActivity first loads it centers the map in the center of the whole window, great if you're looking at just the map display, but with the list my current location (the red place marker) is obscured by the list of places.
I scrolled down the list to look what was there, and then back up again. It closed the list view when I arrived at the top and "scrolled a little to hard" That is, it did exactly what I would have expected a bottom sheet to do (it went into collapsed state on a down-swipe) but not what I (as a user) expected.
After the list closed I didnt have any way to make it appear again.
If the map and list occupied the same layout - weighted 2:1 in favour of the list - and we
just show/hide the list, the map should appear correctly centered and the list would scroll
the way we expect.  Making that change might simplify the content of the bottom sheet - it
is always details about the selected place.
Map Mode
There's a grey bar across the bottom of the screen - the map doesnt extend all the way to the bottom once it's fully revealed.  This is exacerbated when the footer appears, as it's hovering above the bottom of the window too.
Long place names are obscured by the FAB.
On my emulator, the floating "switch to list" button is showing a white-on-white icon, not sure why (Pixel XL emulator running API 25).  Google discourages multiple FAB on a single screen so it might be worth changing the shape of the floating "list mode" button to avoid confusion.
When I tap to show the list, the floating place name bubble stays visible - it should be hidden when you switch modes.
I was dragging the footer up and down, then it vanished but the place name bubble was still visible - indicating I have a place selected but the footer was gone (suggesting that nothing is selected) - I think they should track together.  If we hide the footer, his the place bubble.  That said, I dont think that the down-swipe should hide the footer if a place is still selected.
Performance
The activity waits until it's finished all of its data loading before it displays anything.  This isn't new, its how the activity has always functioned.  I just think we could serve our users with something better since we're in the code anyway.  Think of this as a "nice to have" rather than a blocker on the feature as it heads toward the finish line.
It would be a great improvement if we add the map and an empty list (containing a spinner) as soon as we have a location of the user.  The nearby search moves in a series of steps (steadily increasing its search radius and re-querying the server) as it attempts to load at least 40 locations.  That would give us an estimate of progress, and we could display them each time a search result was returned by the server.  The user would see something useful pretty quickly and the list would progressively fill in with data - although we havent actually optimized the search it will feel better, as they will at least get partial results quicker, and have a progress indicator indicating the overall progress.
FAB Popup
I agree with @misaochan - the popup FAB buttons should move a little closer to the main
FAB.  Android has standard sizes for the buttons (the SIZE_NORMAL / SIZE_MINI enum).

Thanks for the feedback, @psh ! Re: performance, I agree with you, but I do think that in this case we would want to prioritize getting the feature out to users first. Perhaps we could make that bullet point a separate enhancement issue?

Thanks for your detailed feedbacks team, you made my mind cleaner.
@maskaravivek , I agree what you wrote inline, and totally agree, will fix them on my next commits.
@misaochan ,

One minor suggestion - do you think it might make sense to have the camera and gallery buttons

I chose their size according to material documentation, which suggest 56dp for large, 40dp for mini. But I also think it looks weird, so I will try @psh 's advise SIZE_NORMAL/MINI

I wonder if it might confuse the user as greyed-out buttons are usually associated with the feature not being available.

I agree about gray tone, what about our main blue?
@psh ,

When the NearbyActivity first loads it centers the map in the center of the whole window, great if you're looking at just the map display, but with the list my current location (the red place marker) is obscured by the list of places.

I think we should add a button to re-center the map, and red marker should be located at visible part of the map. But this makes 2 buttons, one for list, one for recenter map. And I don't know where to put it.

Long place names are obscured by the FAB.

Needs to be solved, thanks for point it out.

Google discourages multiple FAB on a single screen so it might be worth changing the shape of the floating "list mode" button to avoid confusion.

I agree, actually we have already discussed this button on #922 , but I also think we need to re-consider list button. Maybe we can put list button and re-center map button next to refresh button?

After the list closed I didn't have any way to make it appear again.
In theory, there should be. Because I added visibility to button sheet callback. But somehow (I worked on it but couldn't solve) callback isn't called.

And I agree about  place name bubble, thanks.
For performance, I think this would be great. Maybe we can create a new issue just after we merge this. And you already defined how to do this enhancement.
My questions:

While I try to make FABs visible, I need to remove their anchor. But whenever I remove their anchor, FABs appear on left upper corner for a moment, and then disappears. Do you know a solution for this?

Do you have any idea why callback of bottom sheet for listview isn't triggered?

Thanks all of you for feedbacks.

I chose their size according to material documentation, which suggest 56dp for large, 40dp for mini. But I also think it looks weird, so I will try @psh 's advise SIZE_NORMAL/MINI

Yeah, now that you guys have clarified about the sizes, I agree that we should stick to the standard sizes suggested in material design guidelines. It's possible that the size issue is an optical illusion, and simply putting the expanded FABs closer to the main FAB may magically solve the problem. :)

I agree about gray tone, what about our main blue?

Sounds good to me!

@misaochan @neslihanturan I think it's a great idea to pull the thoughts about performance out into a separate issue.

The latest situation is:
-Requested code quality changes by Vivek made
-Actions are added to buttons
-Overlay menu is activated
-FAB sizes are fixed (actually nothing changed when we use default sizes:))
-Light and dark theme dependency is added
-FAB buttons visibility bug has solved
-FAB to show list removed, and added to menu bar
Currently, only problem is leaks, which I am working on. So, I can request waiting 1 or 2 more days to merge it without leaks. I pushed it current changes to here so that @misaochan can work on adding photos to nearby functionality, without waiting me to fixing leaks.

Hi @neslihanturan ,
Thanks for the great job so far! The color and distance of the expanded FABs look good to me now. :) I am currently testing your PR on an Android 7.0 real device and have noted the following issues with the map UI, as displayed in this screenshot:

The grey bar at the bottom of the screen that @psh mentioned has not been fixed for me
Long place names do not appear to have been fixed either, in this screenshot the title is being obscured
I strongly feel that the FAB expansion should only include the Camera and Gallery buttons, and the Commons link should be in the bottom sheet instead

Issues with the list UI:

In narrower screens, the text underneath the icons wraps in a somewhat unaesthetic manner
Do you think there should be more margin/padding between the camera/gallery icons and the place description?

I love the PR in general and am happy to merge once these issues have been fixed. We can work on the memory leaks afterwards, as this branch doesn't need to be stable. :)

Additionally, the user's location not being centered in the visible map area on first load is problematic, I think. There are multiple ways to fix this - a re-center button, or the 2:1 weighted layout that @psh mentioned. However, I think that if those are difficult to implement or require discussion before we can implement them (e.g. the re-center button), perhaps as a temporary fix we can simply load ONLY the map by default the first time the user loads the activity? Then their position and the surrounding area won't be obscured, and they won't wonder why they aren't seeing any pins on the map. They can still bring up the list by tapping the list button.

@misaochan , I have worked on the issue you mentioned. Tried the change Mapbox camera position etc. However, it requires some calculation since we don't display same area size for each location. So temporarily I will make listview down first, as you suggested.

@neslihanturan No worries, sounds good to me. :)

Hi @misaochan , your requested changes have been made. If there is further things please let me know :)

@neslihanturan Nice work! I will go ahead and merge this. We can carry on working on this branch to fix leaks etc. :)


ci: use latest ksctl during kubesaw deployment

See these PRs for context:

https://github.com/codeready-toolchain/toolchain-e2e/pull/1034
https://github.com/redhat-appstudio/infra-deployments/pull/4324

/hold
Wait until https://github.com/codeready-toolchain/toolchain-e2e/pull/1034 merges, then this is safe to merge.

/unhold


MicrosoftML/Microsoft R Client for R 3.4??

MicrosoftML is a great package that comes with Microsoft R Client. But there is no update for R 3.4. This makes it difficult to use other packages like caret in a workflow. Is there any development version available for R 3.4 or higher?

https://mran.microsoft.com/news#mro343

3.4.3 Just released: https://www.r-bloggers.com/new-releases-microsoft-r-client-3-4-3-microsoft-ml-server-9-3/


[android] ConfigurationManager refactor

Here's an idea on how to fix the ConfigurationManager disk I/O issues on the main thread.
The configuration manager keeps an up to date in memory map of all configuration keys and values stored on disk and the app interacts with this memory based data structure.
The configuration manager should only do actual read and write from the system configurations on disk on a background thread. For instance, when it's first initialized it reads all available settings to populate the in-memory map.
A calls to "get" (read) a value simply interacts with the latest version stored in our in-memory map.
Whenever there is a call to write a value, first the in-memory map is updated, and then the actual setting writing on disk through android's api is done on a deferred background thread.
This way I believe we woudn't need to touch much all over the application, this logic could be contained within our ConfigurationManager.

will open up a branch to implement this.
A few days ago, as an anecdote I was reading java's Properties and it does something very similar.

Read how the Preferences editor works and it does something similar except it's full of lots of blocking code all over.
When .apply() is called, it tries to do an asynchronous commit to memory and if there are any issues when doing the actual commit to disk we're not notified and the last call to .apply() wins.
Google's .apply() code makes you want to puke with nested synchronized blocks


Add settings dataset-level tag.

Coverage remained the same at 0.0% when pulling 1fdf97823b4245a8a09ee393e675b2fd380dfe42 on mars-lan:ui2 into 715afee1595ab7ad189b0654aaa10cce28189854 on linkedin:linkedin.


clarify what should be output with debug?

hi,
trying and struggling to use gulp-hb and your associated handlebars-layout (hb-layout?).
w/r/t gulp-hb,
can you add more clarification and detail to what the debug parameter will do, and what the contents of the various out sections should display?
in particular:

some references suggest that debug takes only true/false, while some discussion threads indicate 1 or 2 as passable values.
what should be appearing in the debug output category of local data? files specific to that main file, or data declared in the file?
"blockHelperMissing" and "helperMissing" feel like err, but what exactly is missing?

thanks.
right now, a run will give me something like this:
pages/project.html
    global data:
      Volumes        site           sitePortfolio
    local data:

    decorators:
      inline
    helpers:
      blockHelperMissing  helperMissing       log                 unless
      each                if                  lookup              with
    partials:
      project-a            project-css             project-header               project-section-heading-4
      project-figure               project-font            project-js
      project-ico             project-section-heading-2
      project-foor               project-meta            project-section-heading-3

The purpose of the debug flag is to give a quick glimpse into the state of Handlebars when a file is rendered. This can be useful to tell if a glob pattern has converted into the state you expect to be there when writing your templates.
debug
The debug flag can be a Boolean or a Number:

0 and false are equivalent
1 and true are equivalent
2 will output the same as 1 and true plus glob-matching debug information. Very noisy, rarely needed, but there if you want it.

When the debug flag is not 0 or false, gulp-hb will log the top-level object keys (like your example) for pertinent internal Handlebars objects where the list is the result of running Object.keys(handlebars[property]):
global data
Top-level object keys of data that was registered using hb({ data: ... }) or the .data() method. Gives you a sense of what you can access at the root-level of your templates using {{foo}} or<EMAIL_ADDRESS>In your case you'd be able to access {{site}}<EMAIL_ADDRESS>etc.
local data
Top-level object keys of data passed into the template at render time. This will be the file.data property if it exists. In your case, you haven't used a plugin to populate the file.data property.
decorators, helpers, and partials
Top-level object keys of Handlebars registries. Same as Object.keys(handlebars.partials) for example.

The handlebars-layouts module is separate, though, as the author, I often include it. :)

thank you!

Of course!