loadblance connect zookeeper error, broker down

broker.log
17:13:45.213 [pulsar-web-30-22] INFO  org.eclipse.jetty.server.RequestLog - <IP_ADDRESS> - - [21/Nov/2018:17:13:45 +0800] "GET //<IP_ADDRESS>:8080/metrics HTTP/1.1" 302 0 "-" "Prometheus/1.8.2" 1
17:13:45.220 [prometheus-stats-31-1] INFO  org.eclipse.jetty.server.RequestLog - <IP_ADDRESS> - - [21/Nov/2018:17:13:45 +0800] "GET //<IP_ADDRESS>:8080/metrics/ HTTP/1.1" 200 80540 "http://<IP_ADDRESS>:8080/metrics" "Prometheus/1.8.2" 6
17:13:45.344 [pulsar-zk-session-watcher-7-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 23 seconds
17:13:47.344 [pulsar-zk-session-watcher-7-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 21 seconds
17:13:49.345 [pulsar-zk-session-watcher-7-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 18 seconds
17:13:51.345 [pulsar-zk-session-watcher-7-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 16 seconds
17:13:53.345 [pulsar-zk-session-watcher-7-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 14 seconds
17:13:55.345 [pulsar-zk-session-watcher-7-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 12 seconds
17:13:57.346 [pulsar-zk-session-watcher-7-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 10 seconds
17:13:59.346 [pulsar-ordered-OrderedExecutor-2-0-SendThread(<IP_ADDRESS>:2181)] WARN  org.apache.zookeeper.ClientCnxn - Client session timed out, have not heard from server in 20002ms for sessionid 0x2671a156ce8012d
17:13:59.346 [pulsar-ordered-OrderedExecutor-2-0-SendThread(<IP_ADDRESS>:2181)] INFO  org.apache.zookeeper.ClientCnxn - Client session timed out, have not heard from server in 20002ms for sessionid 0x2671a156ce8012d, closing socket connection and attempting reconnect
17:13:59.346 [pulsar-zk-session-watcher-7-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 8 seconds
17:13:59.449 [pulsar-ordered-OrderedExecutor-2-0-EventThread] INFO  org.apache.bookkeeper.zookeeper.ZooKeeperWatcherBase - ZooKeeper client is disconnected from zookeeper now, but it is OK unless we received EXPIRED event.
17:13:59.449 [pulsar-ordered-OrderedExecutor-2-0-EventThread] INFO  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - Received zookeeper notification, eventType=None, eventState=Disconnected
17:13:59.449 [pulsar-ordered-OrderedExecutor-2-0-EventThread] INFO  org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:30000 sessionid:0x2671a156ce8012d local:null remoteserver:null lastZxid:210600836001 xid:45314 sent:45314 recv:46227 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: WatchedEvent state:Disconnected type:None path:null
17:13:59.450 [pulsar-ordered-OrderedExecutor-2-0-EventThread] INFO  org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:30000 sessionid:0x2671a156ce8012d local:null remoteserver:null lastZxid:210600836001 xid:45314 sent:45314 recv:46227 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: WatchedEvent state:Disconnected type:None path:null
17:13:59.450 [pulsar-ordered-OrderedExecutor-2-0-EventThread] INFO  org.apache.pulsar.zookeeper.ZooKeeperChildrenCache - [State:CONNECTED Timeout:30000 sessionid:0x2671a156ce8012d local:null remoteserver:null lastZxid:210600836001 xid:45314 sent:45314 recv:46227 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: WatchedEvent state:Disconnected type:None path:null
17:13:59.450 [pulsar-ordered-OrderedExecutor-2-0-EventThread] INFO  org.apache.pulsar.zookeeper.ZooKeeperChildrenCache - [State:CONNECTED Timeout:30000 sessionid:0x2671a156ce8012d local:null remoteserver:null lastZxid:210600836001 xid:45314 sent:45314 recv:46227 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: WatchedEvent state:Disconnected type:None path:null
17:13:59.449 [pulsar-load-manager-6-1] WARN  org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Error writing broker data on ZooKeeper: {}
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /loadbalance/brokers/<IP_ADDRESS>:8080
        at org.apache.zookeeper.KeeperException.create(KeeperException.java:102) ~[org.apache.pulsar-pulsar-broker-2.2.0.jar:2.2.0]
        at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) ~[org.apache.pulsar-pulsar-broker-2.2.0.jar:2.2.0]
        at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1336) ~[org.apache.pulsar-pulsar-broker-2.2.0.jar:2.2.0]
        at org.apache.bookkeeper.zookeeper.ZooKeeperC21:07:43.427 [main] INFO  org.apache.pulsar.broker.PulsarService - Starting Pulsar Broker service; version: '<IP_ADDRESS>'

before broker down zookeeper error log:
ERROR [CommitProcessor:2:NIOServerCnxn@178] -Unexpected Exception:java.nio.channels.CancelledKeyException

Thanks @baby1937 for reporting this.  Dumped the content out from Broker.log, and add some description in the issue.
Discussed with @baby1937 Here is the situation:

deploy broker and bookie on same machine.
zookeeper had an exception:

ERROR [CommitProcessor:2:NIOServerCnxn@178] -Unexpected Exception:java.nio.channels.CancelledKeyException

3, broker down, with above stack
7:13:59.449 [pulsar-load-manager-6-1] WARN  org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Error writing broker data on ZooKeeper: {}
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /loadbalance/brokers/<IP_ADDRESS>:8080
        at org.apache.zookeeper.KeeperException.create(KeeperException.java:102) ~[org.apache.pulsar-pulsar-broker-2.2.0.jar:2.2.0]
        at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) ~[org.apache.pulsar-pulsar-broker-2.2.0.jar:2.2.0]
        at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1336) ~[org.apache.pulsar-pulsar-broker-2.2.0.jar:2.2.0]
        at org.apache.bookkeeper.zookeeper.ZooKeeperC21:07:43.427 [main] INFO  org.apache.pulsar.broker.PulsarService - Starting Pulsar Broker service; version: '<IP_ADDRESS>'

@baby1937 is expecting broker could tolerate zk failure instead of panic.

@jiazhai - I think it happens during broker starting up on registering itself to zookeeper. it seems that the broker can't register itself to zookeeper, so it fails to start.

@sijie It is happening after the broker runs for a period of time. After the above error occurs, the broker is down. thx.

@sijie it is the right log for the broken that crashed.

@baby1937 okay I see. will take a look at how to improve this.

Are there any updates regarding this issue?
We are experiencing something very similar every 2-3 days. It looks like Zookeeper is disconnected on arbitrary broker and this makes whole pulsar cluster unavailable for a couple of minutes, which is fatal for our system.
We are running single Pulsar 2.4.1 cluster on a bare metal and haven't noticed any problems with network.
Such failures are beginning like described in this issue:
01:11:01: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 25 seconds
01:11:03: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 23 seconds
01:11:05: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 21 seconds
01:11:07: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 19 seconds
01:11:09: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 17 seconds
01:11:11: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 15 seconds
01:11:13: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 13 seconds
01:11:15: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 11 seconds
01:11:17: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 9 seconds
01:11:19: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 6 seconds
01:11:21: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 4 seconds
01:11:23: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 2 seconds
01:11:25: [pulsar-zk-session-watcher-5-1] WARN  org.apache.pulsar.zookeeper.ZooKeeperSessionWatcher - zoo keeper disconnected, waiting to reconnect, time remaining = 0 seconds

Then there are two cases possible:

Broker restarts itself and gets a lot of errors like this:

 08:15:33.649 [BookKeeperClientWorker-OrderedExecutor-10-0] WARN  org.apache.pulsar.broker.service.ServerCnx - [/<host>:<port>][persistent://xxx][xxx] Failed to create consumer: Connection was closed while the opening the cursor
  java.util.concurrent.CompletionException: org.apache.pulsar.broker.service.BrokerServiceException: Connection was closed while the opening the cursor
  #011at java.util.concurrent.CompletableFuture.encodeRelay(CompletableFuture.java:326) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.completeRelay(CompletableFuture.java:338) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.uniRelay(CompletableFuture.java:911) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.uniCompose(CompletableFuture.java:953) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:926) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) ~[?:1.8.0_181]
  #011at org.apache.pulsar.broker.service.BrokerService$2.lambda$openLedgerComplete$1(BrokerService.java:668) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1]
  #011at java.util.concurrent.CompletableFuture.uniRun(CompletableFuture.java:705) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.uniRunStage(CompletableFuture.java:717) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.thenRun(CompletableFuture.java:2010) ~[?:1.8.0_181]
  #011at org.apache.pulsar.broker.service.BrokerService$2.openLedgerComplete(BrokerService.java:661) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1]
  #011at org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl.lambda$asyncOpen$7(ManagedLedgerFactoryImpl.java:328) ~[org.apache.pulsar-managed-ledger-original-2.4.1.jar:2.4.1]
  #011at java.util.concurrent.CompletableFuture.uniAccept(CompletableFuture.java:656) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:632) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) ~[?:1.8.0_181]
  #011at org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl$2.initializeComplete(ManagedLedgerFactoryImpl.java:316) ~[org.apache.pulsar-managed-ledger-original-2.4.1.jar:2.4.1]
  #011at org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl$3$1.operationComplete(ManagedLedgerImpl.java:467) ~[org.apache.pulsar-managed-ledger-original-2.4.1.jar:2.4.1]
  #011at org.apache.bookkeeper.mledger.impl.ManagedCursorImpl.lambda$null$2(ManagedCursorImpl.java:362) ~[org.apache.pulsar-managed-ledger-original-2.4.1.jar:2.4.1]
  #011at org.apache.bookkeeper.client.LedgerHandle$6.onSuccess(LedgerHandle.java:802) ~[org.apache.bookkeeper-bookkeeper-server-4.9.2.jar:4.9.2]
  #011at org.apache.bookkeeper.client.LedgerHandle$6.onSuccess(LedgerHandle.java:799) ~[org.apache.bookkeeper-bookkeeper-server-4.9.2.jar:4.9.2]
  #011at org.apache.bookkeeper.common.concurrent.FutureEventListener.accept(FutureEventListener.java:42) ~[org.apache.bookkeeper-bookkeeper-common-4.9.2.jar:4.9.2]
  #011at org.apache.bookkeeper.common.concurrent.FutureEventListener.accept(FutureEventListener.java:26) ~[org.apache.bookkeeper-bookkeeper-common-4.9.2.jar:4.9.2]
  #011at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442) ~[?:1.8.0_181]
  #011at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_181]
  #011at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_181]
  #011at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
  #011at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]
  Caused by: org.apache.pulsar.broker.service.BrokerServiceException: Connection was closed while the opening the cursor
  #011at org.apache.pulsar.broker.service.persistent.PersistentTopic.lambda$subscribe$9(PersistentTopic.java:528) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1]
  #011at java.util.concurrent.CompletableFuture.uniAccept(CompletableFuture.java:656) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.uniAcceptStage(CompletableFuture.java:669) ~[?:1.8.0_181]
  #011at java.util.concurrent.CompletableFuture.thenAccept(CompletableFuture.java:1997) ~[?:1.8.0_181]
  #011at org.apache.pulsar.broker.service.persistent.PersistentTopic.subscribe(PersistentTopic.java:514) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1]
  #011at org.apache.pulsar.broker.service.ServerCnx.lambda$null$10(ServerCnx.java:697) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1]
  #011at java.util.concurrent.CompletableFuture.uniCompose(CompletableFuture.java:952) ~[?:1.8.0_181]
  #011... 27 more

08:15:33.651 [pulsar-io-20-4] WARN  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:50190] Got exception NativeIoException : syscall:read(..) failed: Connection reset by peer

The same error appears at other brokers at the same time.

Broker remains up and running but there are lots of zookeeper related errors:

01:11:26.224 [pulsar-ordered-OrderedExecutor-1-0-SendThread(pulsar-prod-fsn-03.onde.in:2181)] WARN  org.apache.zookeeper.ClientCnxn - Client session timed out, have not heard from server in 20000ms for sessionid 0x301a288dd2d000a

01:11:26.325 [bookkeeper-ml-workers-OrderedExecutor-6-0] WARN  org.apache.pulsar.broker.service.BrokerService - Failed to create topic persistent://xxx
 org.apache.bookkeeper.mledger.ManagedLedgerException: org.apache.bookkeeper.mledger.ManagedLedgerException$MetaStoreException: org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss
 Caused by: org.apache.bookkeeper.mledger.ManagedLedgerException$MetaStoreException: org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss
 Caused by: org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss
 #011at org.apache.zookeeper.KeeperException.create(KeeperException.java:102) ~[org.apache.pulsar-pulsar-zookeeper-2.4.1.jar:2.4.1]
 #011at org.apache.bookkeeper.mledger.impl.MetaStoreImplZookeeper.lambda$null$0(MetaStoreImplZookeeper.java:154) ~[org.apache.pulsar-managed-ledger-original-2.4.1.jar:2.4.1]
 #011at org.apache.bookkeeper.mledger.impl.MetaStoreImplZookeeper.lambda$null$18(MetaStoreImplZookeeper.java:380) ~[org.apache.pulsar-managed-ledger-original-2.4.1.jar:2.4.1]
 #011at org.apache.bookkeeper.mledger.util.SafeRun$1.safeRun(SafeRun.java:32) ~[org.apache.pulsar-managed-ledger-original-2.4.1.jar:2.4.1]
 #011at org.apache.bookkeeper.common.util.SafeRunnable.run(SafeRunnable.java:36) ~[org.apache.bookkeeper-bookkeeper-common-4.9.2.jar:4.9.2]
 #011at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_191]
 #011at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_191]
 #011at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
 #011at java.lang.Thread.run(Thread.java:748) [?:1.8.0_191]

01:11:26.326 [pulsar-load-manager-4-1] WARN  org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl - Error writing broker data on ZooKeeper: {}
 org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /loadbalance/brokers/<host>:<port>
 #011at org.apache.zookeeper.KeeperException.create(KeeperException.java:102) ~[org.apache.pulsar-pulsar-zookeeper-2.4.1.jar:2.4.1]
 #011at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) ~[org.apache.pulsar-pulsar-zookeeper-2.4.1.jar:2.4.1]
 #011at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1336) ~[org.apache.pulsar-pulsar-zookeeper-2.4.1.jar:2.4.1]
 #011at org.apache.bookkeeper.zookeeper.ZooKeeperClient.access$3101(ZooKeeperClient.java:70) ~[org.apache.bookkeeper-bookkeeper-server-4.9.2.jar:4.9.2]
 #011at org.apache.bookkeeper.zookeeper.ZooKeeperClient$21.call(ZooKeeperClient.java:1065) ~[org.apache.bookkeeper-bookkeeper-server-4.9.2.jar:4.9.2]
 #011at org.apache.bookkeeper.zookeeper.ZooKeeperClient$21.call(ZooKeeperClient.java:1059) ~[org.apache.bookkeeper-bookkeeper-server-4.9.2.jar:4.9.2]
 #011at org.apache.bookkeeper.zookeeper.ZooWorker.syncCallWithRetries(ZooWorker.java:140) ~[org.apache.bookkeeper-bookkeeper-server-4.9.2.jar:4.9.2]
 #011at org.apache.bookkeeper.zookeeper.ZooKeeperClient.setData(ZooKeeperClient.java:1059) ~[org.apache.bookkeeper-bookkeeper-server-4.9.2.jar:4.9.2]
 #011at org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl.writeBrokerDataOnZooKeeper(ModularLoadManagerImpl.java:863) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1]
 #011at org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerWrapper.writeLoadReportOnZookeeper(ModularLoadManagerWrapper.java:120) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1]
 #011at org.apache.pulsar.broker.loadbalance.LoadReportUpdaterTask.run(LoadReportUpdaterTask.java:41) ~[org.apache.pulsar-pulsar-broker-2.4.1.jar:2.4.1]
 #011at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_191]
 #011at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) ~[?:1.8.0_191]
 #011at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) ~[?:1.8.0_191]
 #011at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) ~[?:1.8.0_191]
 #011at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_191]
 #011at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_191]
 #011at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
 #011at java.lang.Thread.run(Thread.java:748) [?:1.8.0_191]

01:11:26.327 [BookKeeperClientWorker-OrderedExecutor-2-0] WARN  org.apache.bookkeeper.mledger.impl.ManagedCursorImpl - [xxx-xxx][xxx] Failed to delete ledger 13237042: Error while using ZooKeeper

Any ideas what can cause this issue? It's very important for us to make pulsar cluster more stable to avoid crashes every few days.

Any update? I have the same issue

There is an ongoing effort on improving this situation - https://github.com/apache/pulsar/wiki/PIP-57%3A-Improve-Broker's-Zookeeper-Session-Timeout-Handling
We just get the first change merged. More changes are coming for improving that.
/cc @codelipenghui


Include python 3.12 into CI

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (01e570e) 79.39% compared to head (5329d92) 80.21%.
 Consider uploading reports for the commit c49ad99 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   79.39%   80.21%   +0.81%
==========================================
  Files           9        9
  Lines         728      758      +30
  Branches      197      201       +4
==========================================
+ Hits          578      608      +30
  Misses        125      125
  Partials       25       25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


RTView: important fixes

This PR introduces a lot of small fixes/improvements, including:

Better backup/restoring for historical data.
More efficient work with node's name (taken from NodeInfo).
Names-based logging instead of ids-based logging.
Better timeline charts.
"Static" colors for the nodes.

bors r+


Changing ServiceWorkerClient.hidden to visibilityState

In Chrome for Android, and I suspect other mobile browsers as well, the operating system may kill any renderer process at any time, for any reason. Tabs whose process has been killed will still show up in the tab switcher, so as far as the user is concerned the tab is opened.
This creates an interesting problem when iterating over the clients:
clients.getAll().then(function (clients) {
    clients.forEach(function (client) {
        client.postMessage('hello!');
    });
});

Unless we wake up the client to deliver the message send to them (which I don't want to do from a resource consumption point of view), it'll just silently disappear in a black hole, with no way for the developer to know.
The client.hidden property is not sufficient for to deal with this. A window which is hidden on desktop platforms can still be assumed to be alive, and thus be able to receive messages.
I propose removing client.hidden, and instead exposing client.visibilityState. Like hidden, it would be a snapshot, but next to hidden and visible it also indicates if the client is unloaded.
http://www.w3.org/TR/page-visibility/#dom-document-hidden

Yes, we not have WindowClient.visibilityState. Closing.


TypeError: Class constructor View cannot be invoked without 'new'

TypeError: Class constructor View cannot be invoked without 'new'
NativeScript 7 with Vue.js when trying to create the map.

Same error with NativeScript 7 with typescript (NativeScript Core)

Same error

same error

I managed to invoke this error by trying to create an instance outside of the registerElement
CoreFoundation) *** Terminating app due to uncaught exception 'NativeScript encountered a fatal error: Uncaught TypeError: Class constructor View cannot be invoked without 'new' at MapViewBase(file: node_modules/nativescript-google-maps-sdk/map-view-common.js:128:46) at MapView(file: node_modules/nativescript-google-maps-sdk/map-view.ios.js:240:27) at (file:///app/bundle.js:887:12) at ./main.js(file:///app/bundle.js:907:30) at __webpack_require__(file: src/webpack/bootstrap:816:0) at checkDeferredModules(file: src/webpack/bootstrap:43:0) at webpackJsonpCallback(file: src/webpack/bootstrap:30:0) at (file:///app/bundle.js:2:57) at require(:1:137) ', reason: '(null)' *** First throw call stack: ( 0   CoreFoundation                      0x00007fff2043a126 __exceptionPreprocess + 242 1   libobjc.A.dylib                     0x00007fff20177f78 objc_exception_throw + 48 2   NativeScript                        0x000000010d7f62b4 _ZN3tns21NativeScriptException15OnUncaughtErrorEN2v85LocalINS1_7MessageEEENS2_INS1_5ValueEEE + 882 3   NativeScript                        0x000000010dc23668 _ZN2v88internal14Me<…>

So my issue turned out be the handling of the plugin by babel
presets: [        [         '@babel/preset-env',          {            targets: { esmodules: true },          ----> include: ["transform-classes"]         }       ]     ],
the inclusion of "include":"[transform-classes"] solved it for me, I arrived to this answer through this https://stackoverflow.com/questions/36577683/babel-error-class-constructor-foo-cannot-be-invoked-without-new answer. I hope this helps something.

So my issue turned out be the handling of the plugin by babel
presets: [ [ '@babel/preset-env', { targets: { esmodules: true }, ----> include: ["transform-classes"] } ] ],
the inclusion of "include":"[transform-classes"] solved it for me, I arrived to this answer through this https://stackoverflow.com/questions/36577683/babel-error-class-constructor-foo-cannot-be-invoked-without-new answer. I hope this helps someone.

Hi, could you show your code please?  I include a .babelrc file with your presets but this solution doesn't work for me :(

@benco8186
try this:

tns install babel
put this in .babelrc

{
  "presets": [
    [
      "@babel/preset-env",
      {
        "targets": {
          "esmodules": true
        },
        "include": [
          "transform-classes"
        ]
      }
    ]
  ]
}

@benco8186
try this:

tns install babel
put this in .babelrc

{
  "presets": [
    [
      "@babel/preset-env",
      {
        "targets": {
          "esmodules": true
        },
        "include": [
          "transform-classes"
        ]
      }
    ]
  ]
}

Thank you, but it still doesn't work, may be it's because i'm using angular and not vue, also i'm not on nativescript 7, i use nativescript 6.5.3

I have created a fork and updated nativescript dependencies and typescript compiler version, if you compile the files and replace in the node module by these (map-view-common.js,map-view.android.js,map-view.ios.js,map-view.d.ts),it works
the fork url : https://github.com/benco8186/nativescript-google-maps-sdk/

I have created a fork and updated nativescript dependencies and typescript compiler version, if you compile the files and replace in the node module by these (map-view-common.js,map-view.android.js,map-view.ios.js,map-view.d.js),it works
the fork url : https://github.com/benco8186/nativescript-google-maps-sdk/

Tried but wasn't able to get this achieved

I have created a fork and updated nativescript dependencies and typescript compiler version, if you compile the files and replace in the node module by these (map-view-common.js,map-view.android.js,map-view.ios.js,map-view.d.js),it works
the fork url : https://github.com/benco8186/nativescript-google-maps-sdk/

Tried but wasn't able to get this achieved

Clone my fork, in the src folder open a terminal and run npm install, then tsc, don't worry about error informations. After that copy the .js files and in your project, in the original dependency nativescript maps sdk (in node_module), paste these files (replace the Originals). Normally that will work

I have created a fork and updated nativescript dependencies and typescript compiler version, if you compile the files and replace in the node module by these (map-view-common.js,map-view.android.js,map-view.ios.js,map-view.d.js),it works
the fork url : https://github.com/benco8186/nativescript-google-maps-sdk/

Tried but wasn't able to get this achieved

Clone my fork, in the src folder open a terminal and run npm install, then tsc, don't worry about error informations. After that copy the .js files and in your project, in the original dependency nativescript maps sdk (in node_module), paste these files (replace the Originals). Normally that will work

I tried this and now I got new error : Error: This value is not a native object.

getting the same error

see #420

@hypery2k cool staff 👍
the infoWindowTemplate does not showing on !

hi @kefahB, when the infoWindow is not showing?  thx

@funder7 .. this happen when I click on the marker .. I've did some debugs, it seems the infowindow does not exist at all on the plugin side.

.. this happen when I click on the marker .. I've did some debugs, it seems the infowindow does not exist at all on the plugin side.

Okay! Does it happen with the stable version of the plugin and nativescript 7+ or with the plugin version of #420?  (nativescript 7 compatibility PR)

It work as expected with NS6.3

I have created a fork and updated nativescript dependencies and typescript compiler version, if you compile the files and replace in the node module by these (map-view-common.js,map-view.android.js,map-view.ios.js,map-view.d.js),it works
the fork url : https://github.com/benco8186/nativescript-google-maps-sdk/

@benco8186 got this worked..but cameraChanged function not working after i tired this...!!!

sorry, don't replace map-view.d.ts by a js file but by the ts file
I attach a zip file with the files I used
maps.zip

@benco8186 got this worked..but cameraChanged function not working after i tired this...!!!

I could not get this working either with NS7.  But based on this, I was having problems still trying to use the old CLI with ios.  So I'm basically using NS7 cli with my NS6 project, and it seems to work I just have to use --force.  This will probably hold me over for now, but would really like to get it working with NS7 fully at some point.

sorry, don't replace map-view.d.ts by a js file but by the ts file
I attach a zip file with the files I used
maps.zip

@benco8186 got this worked..but cameraChanged function not working after i tired this...!!!

@benco8186  same issue

Hi,
to resolve this issue you should declare NativeClass() on MapViewDelegateImpl and IndoorDisplayDelegateImpl then you add ts-patch at your package.json (dev), then add the flowing to your tsconfig.json
"plugins": [{
            "transform": "@nativescript/webpack/transformers/ns-transform-native-classes",
            "type": "raw"
        }]

and edit the script file on the build commande like this :
"build": "npm run clean && ts-patch install && tsc",

same error...anyone handle this problem ...please describe breafly


HTTP headers not applied in the layout pane on Firefox

Version 0.3.1
Tested in Firefox
When I open the layout headers pane it's empty. I can select a preset and hit Save and reload, but then the fields disappear again and nothing seems to happen.

Turns out this was user error 🤦 Look for the blue dot and allow the extension access to run on the domain you're working on.


Hide books with no cover in the Homepage

Describe the bug
This is more an improvement than a bug. I suggest that in the homepage we hide books that have no cover (they have only a placeholder). Of course, this does not apply to the search results, only to the homepage.
Screenshots
(see books with no cover)

Rather than hide books without cover, create a new generic book cover (see issue 527).


bpf: lxc: clarify kube-proxy workaround in to-container path

ipv*_policy() (the pod ingress policy code) can be called in two ways:

as an EP-specific tail-call via CILIUM_MAP_POLICY (here tail_ipv*_policy() calls the policy code), or
when cil_to_container() is attached to the veth interface (here tail_ipv*_to_endpoint() is the caller)

Lift the kube-proxy workaround into the callers, so we can fine-tune its behaviour. As cil_to_container() calls bpf_clear_meta(), we can trust that CB_IFINDEX is 0 and don't need to include the call to redirect_ep() from this path.
This makes it perfectly clear that the cil_to_container() path simply lets the packet pass through to the veth peer.
Note: it's very likely that we could also remove the PACKET_HOST part, but let's not change behaviour for now.

/test

/test


[COD-214]feat: add support for reachability analysis call

[ ] Ready for review
[ ] Linked to Jira ticket

What does this PR do?
Adding support for reachable analysis results
This is Is currently blocked by https://github.com/snyk/octopus/pull/772 . as the tests on code client  are making calls to the API server. so will merge after confirming it's working on the API server
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots
Additional questions

:tada: This PR is included in version 3.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Request for Training Setup Details

Hello, I'm interested in replicating your neural network training for whole model in the paper. Could you please provide me with some details on your training setup? Specifically, I'm curious to know:
What GPU did you use for training?
How many GPUs did you use?
How long did the training process take?
Do you have any suggestions for accelerating training?
I'm asking because I'm currently unable to train the model due to a lack of available GPU resources in my lab. I'll need to rent GPU resources online, so it would be helpful to have an estimate of the resources required and the potential cost. Thank you in advance for your help!

I'm excited you're working to replicate the work! I'm happy to help however I can. Most of these details are in paper itself but here are the answers to your questions:
What GPU did you use for training? V100
How many GPUs did you use? 8 GPUs
How long did the training process take? 1-2 days to see reasonable results. 5 days to full convergence.
Do you have any suggestions for accelerating training? I'm sure there are plenty of optimizations that could be made to train faster--some of which I've looked into and some of which I haven't. If you come up with anything, I'd be very interested to hear. Some small things you could do: use the new robofin/geometrout libraries, which have much faster CPU operations for point cloud sampling, you could use Pytorch 2.0 and compile more of the tools (perhaps including the GPU point cloud sampling), tune the optimizer better (this paper used Adam with a relatively low learning rate, but there are probably fancier, faster optimization setups), you could pregenerate more of the data and store it on SSD instead of generating the point clouds on the fly.
If you want to discuss further, you can shoot me an email (email address on my website).


[cxx-interop] Fix test failures after https://github.com/apple/swift/…

…pull/68846
rdar://117205273

@swift-ci please test

Thanks, I confirmed that this got the Android armv7 CI passing again.


Use user_typing event instead of hard coded loading message

Description
@elisalimli please use https://api.slack.com/events/user_typing instead of hardcoding in I'm thinking....

@homanp Right, but that feature is only works with RTM, but it's deprecated and we don't use it either.

@elisalimli ok, just rename it to Typing...


pip install does not install configuration.yaml

If I run this on python3.9 or python3.10:
python3 -m venv .venv && .venv/bin/pip install git+https://github.com/mpi-astronomy/gdr3apcal
.venv/bin/python -c 'import gdr3apcal; calib = gdr3apcal.GaiaDR3_GSPPhot_cal()'

Then I get the following error:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/.venv/lib/python3.10/site-packages/gdr3apcal/calibration.py", line 115, in __init__
    self._configuration = _read_configuration(configuration_file)
  File "/tmp/.venv/lib/python3.10/site-packages/gdr3apcal/calibration.py", line 18, in _read_configuration
    with open(fname, 'r') as conf:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/.venv/lib/python3.10/site-packages/gdr3apcal/configuration.yaml'

...But if instead I run gdr3apcal directly from a git checkout:
git clone https://github.com/mpi-astronomy/gdr3apcal &&
cd gdr3apcal &&
python3 -m venv .venv && .venv/bin/pip install -U wheel pip && .venv/bin/pip install astropy pandas joblib requests sklearn &&
PYTHONPATH=src .venv/bin/python -c 'import gdr3apcal; calib = gdr3apcal.GaiaDR3_GSPPhot_cal()'

Then I get no error. It seems like pip install doesn't copy over the configuration.yaml file. There are no yaml files in /tmp/.venv/lib/python3.10/site-packages/gdr3apcal.
This might be the same issue as in #1.

Thanks for the explanation! Seems like the problem with the missing "configuration.yaml" when following the instructions to install with pip is still present.


Updated EasyCrypt proofs

This pull request does the following:

Removes old .ec files taken from libjc.
Adds new .ec files from my personal correctness proof repository.

These new .ec files prove almost all procedures to be correct. The missing proofs are all done in Cryptoline (found here in the ref and avx2 folders). Integrating these proofs into this repository is future work. All lemmas that are proven in Cryptoline contain admits and are in the Curve25519_auto_mulx.ec and Curve25519_auto_ref4.ec files.
Running make extract-to-easycrypt and then make check-all runs successfully.

Thanks for the PR. Some notes:

the contents of mulx/ and ref/ are basically the same (file by file); and even the files CorrectnessProof_Mulx.ec and CorrectnessProof_Ref4.ec share many similarities; This means that files need to be moved around / reorganized to improve maintainability;
there are *Array* auto generated files outside the array folder: https://github.com/formosa-crypto/formosa-25519/tree/main/proof/arrays ; these need to be removed;
There should be a README.md file providing a proof overview (and mentioning the admits);
We can address the Cryptoline integration in a separate PR (as long as it is not done too far in the future);

Regarding deletion of files:

If IIUC, the basis of the proposed work is the existing files from libjc; For instance, minus spacing and a couple of changes, the Spec is the same: why not patch the file (and then move if needed) to keep history?
Other files with similarities: Hop1 and Operations; Hop2 and Procedures; Hop3 and PHoare; Hop4 and *auto

I propose that you patch the existing files (and avoid unnecessary space insertion)  to keep history and help traceability if something goes wrong.
Regarding Specs, this should eventually be moved to crypto-specs (but it can be delayed a bit); For now, let's keep it here to reduce integration complexity.

In light of your comments, I will change this to a draft pull request as I mess around with patching files along with the other changes you mentioned.
I also have a new approach for the maintainability, which includes having the proof as a submodule so that any updates to the Easycrypt files in the main proof repository are immediately available to the formosa-25519 repository. I did this by changing the layout of my repo to match the formosa-25519 proof folder structure, then adding my repo as a submodule.
Naturally, it would be better in the future if the proofs were hosted not in my personal repo but in a more "official" repository.
This is particularly useful as I've noticed that sometimes the workflow of extracting Easycrypt files from Jasmin for formal verification is that the resulting .ec file is then copied to a separate folder and then manually reintegrated in when the proof is done. This would remove that manual and cumbersome workflow.
Tell me what you think and if it fits within the libjade structure.

I have some questions about the proposed approach. To be more efficient, let's schedule a meeting to discuss about this. I will reach out to you soon.


update jruby from 1.7.26 to 1.7.27

https://mvnrepository.com/artifact/org.jruby/jruby

Especially since this is only used for generating PDF documentation, we should just upgrade to the latest version, currently <IP_ADDRESS>.

Superseded by https://github.com/jenkinsci/credentials-plugin/pull/172

Superseded by https://github.com/jenkinsci/credentials-plugin/pull/172


[Dynamic Regions] improve the network traffic spikes when partitioned-raft-kv is enabled

Feature Request
Is your feature request related to a problem? Please describe:

partitioned-raft-kv brings significant overhead of network between tikv, after remove the schedulers, the overhead is not observed

Describe the feature you'd like:

need to reduce the network traffic spike
Describe alternatives you've considered:

remove the scheduler, but it's not applicable for real-world application
» config set region-schedule-limit 0
Success!
» config set hot-region-schedule-limit 0
Success!
» config set replica-schedule-limit 0
Success!

Teachability, Documentation, Adoption, Migration Strategy:

/severity critical

/assign @bufferflies

with the pr #6314, the QPS and network throughput is much more stable.

close by https://github.com/tikv/pd/pull/6375


won't compile on mac os x

Cloning from github and running make on OS X (10.10) gives this error:
$ make
g++ -c -O2 src/main.cpp -o src/main.o
src/main.cpp:350:17: error: use of undeclared identifier 'CLOCK_MONOTONIC'
                clock_gettime(CLOCK_MONOTONIC, &tpstart);
                              ^
src/main.cpp:353:17: error: use of undeclared identifier 'CLOCK_MONOTONIC'
                clock_gettime(CLOCK_MONOTONIC, &tpend);
                              ^
2 errors generated.
make: *** [src/main.o] Error 1

https://github.com/SIPp/sipp/issues/81 might be useful, since they seem to have solved this for another tool. My C or C++ isn't sharp enough to fix this.
thanks

I think I've fixed this with PR#9.

Pretty sure relipmoc has abandonded this, would you be up for taking over as the fork we use, @wltrimbl?

Oh nm, activity last month-- it has been months between activity though. Would you be down for a group of us helping to maintain this @relipmoc?

Thank you for using skewer! Now skewer can be compiled on OS X. Please check out the codes.


Report an error when invalid timeout is provided

Invalid value of the timeout for option -t/--timeout was ignored and the default timeout of 20 seconds was applied.
Now invalid number of millisecontds in this argument is reported as an error and no conversions take place.
Example command:
htop -t twenty single index.html

Output:
Error: parsing value 'twenty' failed with reason: ParseIntError { kind: InvalidDigit }

Implemented in version v0.2.0


Payment options are not displayed in production

Hello, @MangeshKadam.
In production mode, when I'm saving a payment option citrusClient.savePaymentOption(creditCard, callback), the callback triggers success method.
But when I'm querying for this payment option later, citrusClient.getWallet(callback), I can see that it actually wasn't saved: {"type":"payment","defaultOption":"","paymentOptions":[]}
On the other hand, saved options are returned correctly in the test mode.

Hi @AlexeySheiko  - could you please share the logs? Logs will help us to resolve the problem quickly.
Please share logs to<EMAIL_ADDRESS>

Hi @AlexeySheiko,
Also let us know which card you are trying to save i.e. VISA or MASTERCARD or other.
The card might be getting saved correctly but the card scheme may not be available for you on production.
Please provide details so that we can investigate this.

Hi, @salilgodbole. I'm using a debit Visa card, issued in Poland. There's also a person who uses an Indian MasterCard, and he has the same problem.
You're right that the cards are saved correctly, because I'm getting a successful response after saving it.
And to retrieve it later, could you tell me which cards are supported in production? Perhaps only from India, and only Visa?

@MangeshKadam, here are the logs, and you'll find the version with uncommented Authorization token in your inbox.
The card used in this example is an Indian credit MasterCard.
---> HTTP PUT https://admin.citruspay.com/service/v2/profile/me/payment
Authorization: Bearer 20881d62-5229-4b71-8408-790aa6e2XXXX
{"paymentOptions":[{"owner":"XXXXXX X XXXXXXXX","number":"53XXXXXXXXXXXXXX","scheme":"MASTER_CARD","expiryDate":"01/2021","type":"credit"}],"type":"payment"}
<--- HTTP 204 https://admin.citruspay.com/service/v2/profile/me/payment
---> HTTP GET https://admin.citruspay.com/service/v2/profile/me/payment
Authorization: Bearer 20881d62-5229-4b71-8408-790aa6e2XXXX
<--- HTTP 200 https://admin.citruspay.com/service/v2/profile/me/payment
{"type":"payment","defaultOption":"","paymentOptions":[]}

@AlexeySheiko  - after debugging the issue, problem seems with the token. Seems like few of the scopes are missing for the keys. Request you share keys used in prod environment along-with all the logs from signin. Please share the logs on email , it contains sensitive data.

@MangeshKadam, I've sent you my production keys, and will add signin logs later as well.


Maya publish on Test PC fails

Running version
[3.15.2-nightly.1]
Describe the bug
After this PR https://github.com/ynput/OpenPype/pull/4340 previously working Maya workfile fails with:

[cuID:OP-5035]

Test file here
test_project_test_asset_test_task_v001.zip
Problem seems to be in old Maya version (2020) and Arnold.


[Task]: Fix the hanging of stdlib tests for the new Testerina framework

Description
Some of the std lib gradle build commands hang without exiting. This is likely due to some processes not exiting.
eg:- in http module, an instance where a callback is not properly closed was found.
Describe your task(s)
The following std-lib repos have the above issue.

[x] module-ballerina-http
[x] module-ballerina-graphql
[x] module-ballerina-transaction
[x] module-ballerina-websub
[x] module-ballerina-websubhub

Related area
-> Test Framework
Related issue(s) (optional)
Main issue for keeping track of the testerina migration progress: https://github.com/ballerina-platform/ballerina-lang/issues/38092
HTTP fix for one hanging instance: https://github.com/ballerina-platform/ballerina-standard-library/issues/3536
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Graphql, websub works as expected after the HTTP fix of https://github.com/ballerina-platform/ballerina-standard-library/issues/3536

HTTP working with https://github.com/ballerina-platform/module-ballerina-http/pull/1313


ButtonUpload 控件，文档描述将ShowUploadList更正为ShowUploadFileList

{PR title}

Description
close #{bug number}

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


statement about permissions is ambiguous

The page states "User must be a member of the sysadmin fixed server role or the db_ddladmin and db_owner fixed database roles.".
This implies that if sysadmin is not granted, both db_ddladmin and db_owner are required.  Rebuilding an index can be achieved with either of these accounts, since db_owner includes the permissions granted to db_ddladmin.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40c68674-b35e-416e-33d5-da18290e1640
Version Independent ID: 7310124c-a4ff-a221-0ece-82bab37d6f62
Content: Reorganize and Rebuild Indexes - SQL Server
Content Source: docs/relational-databases/indexes/reorganize-and-rebuild-indexes.md
Product: sql
Technology: table-view-index
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@MikeRayMSFT Hi Mike, This Issue 2244 concerns an article that is assigned to you.
@VanMSFT The Issue specifically concerns Security, so just FYI, maybe there is a chance that you would also be interested in this Issue 2244.

Thank you @kewelaka
I'm staging an update

@kewalaka
Would this clarify it for you?
Requires ALTER permission on the table or view. User must be a member of at least one of the following roles:

db_ddladmin database role 1
db_owner database role
sysadmin server role

1db_ddladmin database role is the least privileged.

(y) looks good to me
Thanks Mike.
On Thu, 6 Jun 2019, 07:25 Mike Ray<EMAIL_ADDRESS>wrote:

@kewalaka https://github.com/kewalaka
Would this clarify it for you?
Requires ALTER permission on the table or view. User must be a member of
at least one of the following roles:

db_ddladmin database role 1
db_owner database role
sysadmin server role

1db_ddladmin database role is the least privileged
https://docs.microsoft.com/windows-server/identity/ad-ds/plan/security-best-practices/implementing-least-privilege-administrative-models
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/sql-docs/issues/2244?email_source=notifications&email_token=AAYAGXWG2FESNQCWLUH2XXDPZAHLJA5CNFSM4HSD6KJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXAYGPY#issuecomment-499221311,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYAGXXD5AUAMSRHOA5W3ODPZAHLJANCNFSM4HSD6KJQ
.

Thanks. The change is in flight. I'm having it reviewed. Will close the issues. Appreciate your submission & reply


optimizer: add property sorted to plan nodes

We can have a struct like PlanBase, which is included in all optimizer plan nodes. Then, we can have sorted inside, along with the sort keys (e.g. struct PlanBase { sorted: Vec<usize> }), and add code to infer the property across plan nodes.

Let me have a try! : )

I think we can start with https://github.com/risinglightdb/risinglight/issues/645 first, and later make range filter scan more powerful and useful with sorted property induction. 🤪 We can postpone this issue a little bit.

In the new planner, this can be implemented as an analysis. The associated data could be Vec<(key: Id, asc_or_desc: bool)>. After this is done, we could have sort-merge-join and sort-group-agg.


retire the TestPyPI workflow

With the recent addition of the workflow to upload nightly releases to anaconda.org/scientific-python-nightly-wheels, we don't really need the TestPyPI workflow anymore, especially since PyPI instances are not designed to automatically delete very old releases.

[x] Follow-up to #7863 and #7865
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Thank you @keewis


Distributed zqd manager

Support recruiting workers from static list: Allow a list of worker endpoints to be specified to a zqd instance, and allow it to use those workers while executing parallel queries to a remotely accessible zar archive.
Initially, the static list of worker will be provided as command line flag which will be a comma separated list of host:port.

I had previously referred to this an a zqd "manager" process, but I prefer the terminology that Al uses to refer to it as the "root" process. The function is still the same -- the root process can recruit worker processes. In future iterations (like the continuous shuffle) there may be a possibility that a "worker" process could recruit additional workers.


change external report urls to fix on chrome

PR to fix this issue - https://github.com/extent-framework/extentreports-csharp/issues/163

This is not only a chrome problem, it affects all browsers.  rawgit.com stopped serving files in late 2019, and the redirect to jsdelivr.net stopped working for older files the week this PR was created.

We are waiting for this merge. Could you close this PR


Godeps: update cobra to get suggestions

This updates the cobra cli library.  The last update of cobra was from June.
What it gives us out of the box with this update is suggestions which should make using rkt a little bit nicer. For example if we misstype the rkt gc as rkt gcc then we get the following.
Error: unknown command "gcc" for "rkt"

Did you mean this?
	gc

Run 'rkt --help' for usage.

I'm not %100 convinced it's worth the update for just the suggestions as it brings in 3 additional dependencies (blackfriday, shurcooL & go-md2man) and also requires updating pflags. I'll let the maintainers decide that. ;)

grep -c '"Rev"' Godeps/Godeps.json tells me that we depend (directly or indirectly) on a stunning number of 73 packages now, so additional 3 deps sound like a minor change. IMO of course.

Looks like this is going to have to be landed before we can mark --insecure-skip-verify as hidden as we'd like to do for #912. That functionality is only found in more recent versions of pflag than the version we have.

I'm closing this and will just add it to the #1738 PR since it's a dependency.


fix(README): Updating README

:tada: This PR is included in version 2.27.1 :tada:
Your semantic-release bot :package::rocket:


HIVE-24632: Replace with null when GenericUDFBaseCompare has a non-interpretable val

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?
Added tests

retrigger the build test...

retrigger the build test...


[Investigation] CI speed/tooling choices

Apps, etc...

As much as we'd always like CI to run faster, we won't be able to schedule time to investigate this, especially as the speed of CI currently isn't much of a blocker.


Expected a valid instance of ExpressiveCodeAnnotation, but got ... (InlineStyleAnnotation)

Problem description
After upgrading to<EMAIL_ADDRESS>I'm getting the error
Plugin "Shiki" caused an error in its "performSyntaxAnalysis" hook. Error message: Expected a valid instance of ExpressiveCodeAnnotation, but got {"inlineRange":{"columnStart":0,"columnEnd":88},"renderPhase":"earliest","color":"#99A0A6","italic":false,"bold":false,"underline":false,"styleVariantIndex":0}

when rendering syntax-highlighted code.
Analysis
After digging around a bit, I've found that this happens when @expressive-code/plugin-shiki attempts to add an InlineStyleAnnotation, whose definition it has imported from its dependency on @expressive-code/core:
https://github.com/expressive-code/expressive-code/blob/24697495ac33a88339e0d0073c5548ba0ea0265d/packages/%40expressive-code/plugin-shiki/src/index.ts#L113-L126
This instance is then passed to the calling code, and eventually makes its way into @expressive-code/core's validateExpressiveCodeAnnotation, which validates it using instanceof ExpressiveCodeAnnotation:
https://github.com/expressive-code/expressive-code/blob/24697495ac33a88339e0d0073c5548ba0ea0265d/packages/%40expressive-code/core/src/common/annotation.ts#L219
Unfortunately there is a subtle trick of package management here, which causes this code to fail its intended function: when plugin-shiki instantiates an InlineStyleAnnotation, it does so based on the class definition imported from its dependency (node_modules/@expressive-code/plugin-shiki/node_modules/@expressive-code/core). When @expressive-code/core (the root dependency, not the dependency from plugin-shiki) runs the instanceof, it does so using the class definition in its own package (node_modules/@expressive-code/core).
Although node_modules/@expressive-code/core and node_modules/@expressive-code/plugin-shiki/node_modules/@expressive-code/core contains the same code, they are not referentially equivalent. For this reason, annotation instanceof ExpressiveCodeAnnotation returns false.
flowchart TD
    subgraph shiki [plugin-shiki]
        subgraph shikicore [core]
            shikiInline[[InlineStyleAnnotation]]
            shikiAnno[[ExpressiveCodeAnnotation]]
            shikiInline -.->|Extends| shikiAnno
        end
        annotation -.->|Instance of| shikiInline
    end
    subgraph core [core]
        anno[[ExpressiveCodeAnnotation]]
        validate(["validateExpressiveCodeAnnotation(annotation)"])

        validate -.->|Checks inheritance of| anno
    end

    annotation -->|Passed to|validate

Reproduction
When trying to create a reproduction repo for this issue, I found that installing a fresh install of Astro and Expressive Code didn't replicate the issue. When looking at the installed node_modules, there was no node_modules/@expressive-code/plugin-shiki/node_modules.
It looks like this issue depends a lot on whether NPM decides to install @expressive-code/core as a dependency of @expressive-code/plugin-shiki, or keeps it deduplicated in the root node_modules. Usually NPM only does this if the version specified in dependencies of plugin-shiki doesn't match the version specified in the root dependencies, but in my case it looks like it got confused.
One way I've found of replicating this behavior:

Check out or create a workspace of the reproduction repo (a simple Astro starter from version ^3.4.3, with astro-expressive-code and @expressive-code/plugin-collapsible-sections on version ^0.26.2)
Run npx @astrojs/upgrade (or change the version of Astro in package.json to ^4.4.15
Change the version of astro-expressive-code to ^0.33.4 while removing @expressive-code/plugin-collapsible-sections. This is the crucial step - upgrading one package while removing an old plugin seems to get NPM confused in the install order..
Run npm install
Verify that node_modules/@expressive-code/plugin-shiki/node_modules exists, and that /test throws the error from this issue when rendered.

Workaround
The workaround looks to be to delete package-lock.json and running npm install again. This seems to force NPM back to its intended functionality, where it installs @expressive-code/core only in the root node_modules, not also in plugin-shiki/node_modules.
I'd still consider this a bug in Expressive Code, since plugin-shiki doesn't work in some valid dependency configurations, e.g. with different versions of plugins installed.


adapting latest changes in hpipm for evaluating feedback matrices

See also discussion in https://github.com/giaf/hpipm/issues/76


small update in regex in flutter.groovy

/(\\ |[^\s])+/  and /(\\ |\S)+/ are basically equivalant but the last one won't trigger android Studio warnings
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Can you add some more context to the description? It's not clear what lint is failing, so maybe including a link to the documentation for the failing lint would be helpful.

It's not clear what lint is failing:


Improve performance

Return early if $toResove is already a callable and remove string checking.
This reduces 2 function calls. (is_callable(), is_string())

Coverage remained the same at 96.603% when pulling 7ac36dcdfe75ac53e936920c9ac5b43e704c4149 on phpinfo-in-th:patch-2 into 30cfe3c07dac28ec1129c0577e64b90ba11a54c4 on slimphp:3.x.


Update front-door-caching.md

@jessie-jyy : Thanks for your contribution! The author(s) have been notified to review your proposed change.


add a sample for IsOk

Adds a sample for IsOk and re-exports the parse error in the module that actually used it.

I'll wait until https://github.com/elastic-rs/elastic-responses/issues/42 to merge this. Having to derive IsOk yourself is a bit of a hassle.


Create your own enumerable

Create a class MyList that has an instance variable @list.
In MyList implement a method #each that yields successive members of @list and uses the MyEnumerable module.
Create a module MyEnumerable that implements the following methods (they should have the same funcionality as methods in Enumerable):
#all?
#any?
#filter
Each class and module should has a separate .rb file.
Verify your solution:

Hi @Iptysam and @AbdimulhinYussuf3675,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
Kindly use the readme template with all the headers
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Custom translation keys can't be set or overridden by Keycloak Realm Overrides

I'm using keycloak 25.0.2 and keycloakify 11.3.4 and added a custom "teestvaar" in the test realm as override, also in the same realm i have the following keycloak theme enabled. The translations set withCustomTranslations in i18nBuilder work, but won't be overridden with Keycloak Override. If i use advancedMsgStr like in console.log('advancedMsgStr', advancedMsgStr('teestvaar')); it outputs only the key again (teestvaar) without finding the translation from realm override.
Realm override:

i18n.ts (also tested in login and account):
import { i18nBuilder } from "keycloakify/account";
import type { ThemeName } from "../kc.gen";

const { useI18n, ofTypeI18n } = i18nBuilder
    .withThemeName<ThemeName>()
    .withCustomTranslations({
        en: {
            // teestvaar: "en test" // works when uncommented but also cant be overridden by realm override
        },
        de: {
            // teestvaar: "de test"
        }
    })
    .build()

type I18n = typeof ofTypeI18n;

export { useI18n, type I18n };

login/Template.tsx:
import { useEffect } from "react";
import { clsx } from "keycloakify/tools/clsx";
import type { TemplateProps } from "keycloakify/login/TemplateProps";
import { getKcClsx } from "keycloakify/login/lib/kcClsx";
import { useInitialize } from "keycloakify/login/Template.useInitialize";
import { useSetClassName } from "keycloakify/tools/useSetClassName";
import type { I18n } from "./i18n";
import type { KcContext } from "./KcContext";
import "../main.css"
import bitaloSvgUrl from "../account/assets/bitalo.svg";
import { kcSanitize } from "keycloakify/lib/kcSanitize";

export default function Template(props: TemplateProps<KcContext, I18n>) {
    const {
        displayInfo = false,
        displayMessage = true,
        displayRequiredFields = false,
        headerNode,
        socialProvidersNode = null,
        infoNode = null,
        documentTitle,
        bodyClassName,
        kcContext,
        i18n,
        doUseDefaultCss,
        classes,
        children
    } = props;

    const { kcClsx } = getKcClsx({ doUseDefaultCss, classes });

    const { msg, msgStr, advancedMsgStr, currentLanguage, enabledLanguages } = i18n;

    console.log('advancedMsgStr', advancedMsgStr('teestvaar')); // not working, outputs: teestvaar

Hello @novelnet,
Currently, not every key can be overridden at the realm level. While this is something I could address, the reasoning behind it is as follows:

For keys like termsText or any label, placeholder, or helper text related to custom user attributes, it makes sense to define them at the realm level. In such cases, Keycloakify will apply any overrides defined at the realm.
For everything else, particularly custom i18n keys, these are specific to the theme. The Keycloak server doesn't necessarily need to manage them, so defining translations at the realm level for keys that originate from the theme can feel out of place. Additionally, theme variants allow for different translations of a given key. See documentation.

If you realy need to do if for some reason you can implement this hack:
import { defineConfig } from "vite";
import react from "@vitejs/plugin-react";
import { keycloakify } from "keycloakify/vite-plugin";

// https://vitejs.dev/config/
export default defineConfig({
    plugins: [
        react(),
        keycloakify({
            // Don't mind the sementic here, it's not the inded purpose of the fuction.
            kcContextExclusionsFtl: [
                '<@addToXKeycloakifyMessagesIfMessageKey str="teestvaar" />',
                '<@addToXKeycloakifyMessagesIfMessageKey str="someOtherVar" />',
                // ...
            ].join("\n")
        })
    ]
});

It's levraging this function:  https://docs.keycloakify.dev/configuration-options/kccontextexclusionsftl

Thanks a lot for you fast and very helpful answer, that understanding of only specific keys can be overridden by realms was unclear before. Also the theme variants are a good solution, but i choose kcContextExclusionsFtl where i change a url via translation by each realms only, which works great.


add insertion sort method

What does the program do ?
add insertion sort method
In what programming language it is written?
C

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


control plane load balancing does not work

Describe the bug
control plane load balancing does not work
To Reproduce
Steps to reproduce the behavior:
root@master1:~# cat kubeadm.yaml
apiVersion: kubeadm.k8s.io/v1beta3
bootstrapTokens:
- groups:
  - system:bootstrappers:kubeadm:default-node-token
  token: abcdef.0123456789abcdef
  ttl: 24h0m0s
  usages:
  - signing
  - authentication
kind: InitConfiguration
localAPIEndpoint:
  advertiseAddress: <IP_ADDRESS>
  bindPort: 6443
nodeRegistration:
  criSocket: unix:///var/run/containerd/containerd.sock
  imagePullPolicy: IfNotPresent
  name: master1
  taints:
  - effect: NoSchedule
    key: node-role.kubernetes.io/master
---
apiServer:
  timeoutForControlPlane: 4m0s
  extraArgs:
    authorization-mode: Node,RBAC
  certSANs:
  - apiserver.k8s.local
  - master1
  - master2
  - master3
  - worker1
  - <IP_ADDRESS>
  - <IP_ADDRESS>
  - <IP_ADDRESS>
  - <IP_ADDRESS>
apiVersion: kubeadm.k8s.io/v1beta3
certificatesDir: /etc/kubernetes/pki
clusterName: kubernetes
controllerManager: {}
dns: {}
etcd:
  local:
    dataDir: /var/lib/etcd
imageRepository: registry.aliyuncs.com/google_containers
kind: ClusterConfiguration
kubernetesVersion: 1.25.0
controlPlaneEndpoint: apiserver.k8s.local:6443
networking:
  dnsDomain: cluster.local
  serviceSubnet: <IP_ADDRESS>/12
  podSubnet: <IP_ADDRESS>/16
---
apiVersion: kubeproxy.config.k8s.io/v1alpha1
kind: KubeProxyConfiguration
mode: "ipvs"

init cluster with
 kubeadm init --upload-certs --config kubeadm.yaml

Expected behavior
control plane load balancing with ipvs and vip.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS/Distro:  Ubuntu 2204
Kubernetes Version: v.1.25.0
Kube-vip Version:  0.5.0

Kube-vip.yaml:
root@master1:~# cat /etc/kubernetes/manifests/kube-vip.yaml
apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: null
  name: kube-vip
  namespace: kube-system
spec:
  containers:
  - args:
    - manager
    env:
    - name: vip_arp
      value: "true"
    - name: port
      value: "6443"
    - name: vip_interface
      value: ens160
    - name: vip_cidr
      value: "32"
    - name: cp_enable
      value: "true"
    - name: cp_namespace
      value: kube-system
    - name: vip_ddns
      value: "false"
    - name: svc_enable
      value: "true"
    - name: vip_leaderelection
      value: "true"
    - name: vip_leaseduration
      value: "5"
    - name: vip_renewdeadline
      value: "3"
    - name: vip_retryperiod
      value: "1"
    - name: lb_enable
      value: "true"
    - name: lb_port
      value: "6443"
    - name: lb_fwdmethod
      value: local
    - name: address
      value: apiserver.k8s.local
    - name: prometheus_server
      value: :2112
    image: ghcr.io/kube-vip/kube-vip:v0.5.0
    imagePullPolicy: IfNotPresent
    name: kube-vip
    resources: {}
    securityContext:
      capabilities:
        add:
        - NET_ADMIN
        - NET_RAW
    volumeMounts:
    - mountPath: /etc/kubernetes/admin.conf
      name: kubeconfig
  hostAliases:
  - hostnames:
    - kubernetes
    ip: <IP_ADDRESS>
  hostNetwork: true
  volumes:
  - hostPath:
      path: /etc/kubernetes/admin.conf
    name: kubeconfig
status: {}

Additional context
can not see ipvs loadbalaning with vip <IP_ADDRESS>
root@master1:~# ipvsadm -Ln
IP Virtual Server version 1.2.1 (size=4096)
Prot LocalAddress:Port Scheduler Flags
  -> RemoteAddress:Port           Forward Weight ActiveConn InActConn
TCP  <IP_ADDRESS>:443 rr
  -> <IP_ADDRESS>:6443           Masq    1      0          0
TCP  <IP_ADDRESS>:53 rr
TCP  <IP_ADDRESS>:9153 rr
UDP  <IP_ADDRESS>:53 rr
root@master1:~# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: ens160: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 00:50:56:ad:69:e1 brd ff:ff:ff:ff:ff:ff
    altname enp3s0
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global ens160
       valid_lft forever preferred_lft forever
    inet <IP_ADDRESS>/32 scope global deprecated dynamic ens160
       valid_lft 59sec preferred_lft 0sec
    inet6 fe80::250:56ff:fead:69e1/64 scope link
       valid_lft forever preferred_lft forever
3: kube-ipvs0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN group default
    link/ether 46:88:38:90:21:f1 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/32 scope global kube-ipvs0
       valid_lft forever preferred_lft forever
    inet <IP_ADDRESS>/32 scope global kube-ipvs0
       valid_lft forever preferred_lft forever
root@master1:~#

kube-vip pod logs
root@master1:~# kubectl -n kube-system  logs  kube-vip-master1 | more
time="2022-09-21T14:34:44Z" level=info msg="Starting kube-vip.io [v0.5.0]"
time="2022-09-21T14:34:44Z" level=info msg="namespace [kube-system], Mode: [ARP], Features(s): Control Plane:[true], Services:[true]"
time="2022-09-21T14:34:44Z" level=info msg="prometheus HTTP server started"
time="2022-09-21T14:34:44Z" level=info msg="Starting Kube-vip Manager with the ARP engine"
time="2022-09-21T14:34:44Z" level=info msg="beginning services leadership, namespace [kube-system], lock name [plndr-svcs-lock], id [master1]"
I0921 14:34:44.427389       1 leaderelection.go:248] attempting to acquire leader lease kube-system/plndr-svcs-lock...
time="2022-09-21T14:34:44Z" level=info msg="Beginning cluster membership, namespace [kube-system], lock name [plndr-cp-lock], id [master1]"
I0921 14:34:44.434777       1 leaderelection.go:248] attempting to acquire leader lease kube-system/plndr-cp-lock...
E0921 14:34:44.435347       1 leaderelection.go:330] error retrieving resource lock kube-system/plndr-cp-lock: Get "https://kubernetes:6443/apis/coordination.k8s.io/v1/nam
espaces/kube-system/leases/plndr-cp-lock": dial tcp <IP_ADDRESS>:6443: connect: connection refused
E0921 14:34:44.435313       1 leaderelection.go:330] error retrieving resource lock kube-system/plndr-svcs-lock: Get "https://kubernetes:6443/apis/coordination.k8s.io/v1/n
amespaces/kube-system/leases/plndr-svcs-lock": dial tcp <IP_ADDRESS>:6443: connect: connection refused
I0921 14:34:48.449944       1 leaderelection.go:258] successfully acquired lease kube-system/plndr-cp-lock
time="2022-09-21T14:34:48Z" level=info msg="Node [master1] is assuming leadership of the cluster"
time="2022-09-21T14:34:48Z" level=info msg="starting the DNS updater for the address apiserver.k8s.local"
I0921 14:34:48.450467       1 leaderelection.go:258] successfully acquired lease kube-system/plndr-svcs-lock
time="2022-09-21T14:34:48Z" level=info msg="Starting IPVS LoadBalancer"
time="2022-09-21T14:34:48Z" level=info msg="IPVS Loadbalancer enabled for 1.2.1"
time="2022-09-21T14:34:48Z" level=info msg="Gratuitous Arp broadcast will repeat every 3 seconds for [<IP_ADDRESS>]"
time="2022-09-21T14:34:48Z" level=info msg="Kube-Vip is watching nodes for control-plane labels"
time="2022-09-21T14:34:48Z" level=info msg="setting <IP_ADDRESS> as an IP"
time="2022-09-21T14:34:51Z" level=info msg="setting <IP_ADDRESS> as an IP"
time="2022-09-21T14:34:52Z" level=error msg="Error querying backends file does not exist"
time="2022-09-21T14:34:52Z" level=info msg="Created Load-Balancer services on [<IP_ADDRESS>:6443]"
time="2022-09-21T14:34:52Z" level=info msg="Added backend for [<IP_ADDRESS>:6443] on [<IP_ADDRESS>:6443]"
time="2022-09-21T14:34:54Z" level=info msg="setting <IP_ADDRESS> as an IP"
time="2022-09-21T14:34:57Z" level=info msg="setting <IP_ADDRESS> as an IP"
time="2022-09-21T14:35:00Z" level=info msg="setting <IP_ADDRESS> as an IP"
time="2022-09-21T14:35:03Z" level=info msg="setting <IP_ADDRESS> as an IP"
time="2022-09-21T14:35:06Z" level=info msg="setting <IP_ADDRESS> as an IP"

same here

Kubekey uses kube-vip to deploy ha cluster, same issue found and can be solved by add node cidr into kube-proxy configuration.
Refer to : kubekey-1702
Maybe we should add some instruction on kube vip's website to remind users of this bug

me too
os：Rocky Linux release 9.2
kernel：5.14.0-284.18.1.el9_2.x86_64
kubernetes：1.27.4
containerd：1.6.20
kube-vip：0.6.0

Has anyone solved this problem yet?

I'm still fuzzy on the details, but in the issue linked by @lwabish, it looks like the issue was resolved by telling the proxy service to ignore the subnet the control plane nodes live on.  my guess is there is something like a race condition being generated.  i added that subnet to the no_proxy config for my kubespray deployment, but it does not seem to have made a difference after running the playbook again.

I had a similar issue, but using kubespray and metallb. The LB IP from the CP was gone, and I got the same error messages as above. Fortunately, Kubespray has a way to specify this exclusion --> https://github.com/kubernetes-sigs/kubespray/blob/747d8bb4c2d31669b2d7eed2b38bc4da2c689fab/roles/kubernetes/control-plane/defaults/main/kube-proxy.yml#L68

Kubekey uses kube-vip to deploy ha cluster, same issue found and can be solved by add node cidr into kube-proxy configuration. Refer to : kubekey-1702 Maybe we should add some instruction on kube vip's website to remind users of this bug

This worked for me. My kubeadm-config.yaml
apiVersion: kubeadm.k8s.io/v1beta3
kind: InitConfiguration
localAPIEndpoint:
  advertiseAddress: "<IP_ADDRESS>" #control plane node local ip
  bindPort: 6443
---
apiVersion: kubeadm.k8s.io/v1beta3
kind: ClusterConfiguration
imageRepository: registry.k8s.io
kubernetesVersion: 1.28.2
kubeProxyArgs: ["--ipvs-exclude-cidrs=<IP_ADDRESS>/24"] ###### cidr of node network #######
controlPlaneEndpoint: "<IP_ADDRESS>:6443" # loadbalancer VIP
networking:
  serviceSubnet: <IP_ADDRESS>/12
  podSubnet: "<IP_ADDRESS>/12"
apiServer:
  timeoutForControlPlane: 4m0s
  certSANs:
      - "master01"
      - "master02"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
dns:
  type: CoreDNS
etcd:
  local:
    dataDir: /var/lib/etcd
    serverCertSANs:
      - "master01"
      - "master02"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
    peerCertSANs:
      - "master01"
      - "master02"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
      - "<IP_ADDRESS>"
---
kind: KubeletConfiguration
apiVersion: kubelet.config.k8s.io/v1beta1
cgroupDriver: "systemd"
  #cgroupDriver: cgroupfs

Yeah we should better add this to the doc


Scrap all additional cards

Scrap information about all additional (summon) cards like Rock, Mjolnir, Tiger Spirit etc.

so I noticed it's only supposed to scrap the "released" cards well it scrapped all 247 what setting do we change to make it only scrap the "released" ones 202

Before appending a character to the dictionary you can add an if condition, which will filter for status here https://github.com/vlmaier/marvel-snap-scrapr/blob/main/scrapr.py#L38:
if character['status'] == 'released':
    characters.append(character)

ahh ok ty


General: Localize ngx-datatable

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] I translated all newly inserted strings into English and German.

Motivation and Context

The ngx-datatable contains strings that were not localized.
Description

Provides localized messages via the datatables messages property.
Steps for Testing

Prerequisites:

1 Instructor or Admin

Change the client language to german
Visit the various datatables and check that the footer (and, when empty, body) contains german text
Applicable datatables are:

Course student list
Exercise scores, participation, submission pages
Exercise teams list
possibly more, check the diff for a full list, I just used Ctrl-F to find all datatables

Review Progress

Code Review
There is a whole bunch of code duplication with data tables, but i didn't want to do a big refactor to fix that.

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Screenshots

When I go through the code I find 16 appearances of the ngx-datatable (use <ngx-datatable[^-] as regex in the search function of IntelliJ). You only have 11 appearances here. Did you leave out the rest on purpose?

There are 15 changed occurrences in this PR, did you miss the second commit? The last missing one is in the jhi-feature-toggle because the admin pages are not translated anyways and i didn't want to duplicate the messages block more than necessary (and also because i missed that at first since it is not in a html file).

You could also try to put the get messages() {... into a shared component, to reduce the copy+pasting and make further development easier

that would be the jhi-data-table but the components where i duplicated that don't use that component but rather ngx-datatable directly and i didn't want to refactor them to use it (and also reduce the incredible amount of duplication that using jhi-data-table requires) when when i was just translating things for an other PR.
if you think this cleanup is important we can mark this PR as draft and i'll get around to doing the refactor later.

When I go through the code I find 16 appearances of the ngx-datatable (use <ngx-datatable[^-] as regex in the search function of IntelliJ). You only have 11 appearances here. Did you leave out the rest on purpose?

There are 15 changed occurrences in this PR, did you miss the second commit? The last missing one is in the jhi-feature-toggle because the admin pages are not translated anyways and i didn't want to duplicate the messages block more than necessary (and also because i missed that at first since it is not in a html file).

You could also try to put the get messages() {... into a shared component, to reduce the copy+pasting and make further development easier

that would be the jhi-data-table but the components where i duplicated that don't use that component but rather ngx-datatable directly and i didn't want to refactor them to use it (and also reduce the incredible amount of duplication that using jhi-data-table requires) when when i was just translating things for an other PR.
if you think this cleanup is important we can mark this PR as draft and i'll get around to doing the refactor later.

When I go through the code I find 16 appearances of the ngx-datatable (use <ngx-datatable[^-] as regex in the search function of IntelliJ). You only have 11 appearances here. Did you leave out the rest on purpose?

There are 15 changed occurrences in this PR, did you miss the second commit? The last missing one is in the jhi-feature-toggle because the admin pages are not translated anyways and i didn't want to duplicate the messages block more than necessary (and also because i missed that at first since it is not in a html file).

You could also try to put the get messages() {... into a shared component, to reduce the copy+pasting and make further development easier

that would be the jhi-data-table but the components where i duplicated that don't use that component but rather ngx-datatable directly and i didn't want to refactor them to use it (and also reduce the incredible amount of duplication that using jhi-data-table requires) when when i was just translating things for an other PR.
if you think this cleanup is important we can mark this PR as draft and i'll get around to doing the refactor later.

Sorry for closing, was an accident

Tested it locally! Nice change to have that translated also!


exit with 1 when Exception catched and raise exception when HTTP error code is client error

On https://github.com/scylladb/scylla-machine-image/issues/498, status of scylla-image-post-start.service is NOT "failed" even
the script causing error, because scylla_post_start.py catches all
exceptions and just logging it, so the script finishes without error.
To getting notify users the script failed operation during running, we
should sys.exit(1) when the exception catched.
Also, when curl catched HTTP error 4xx = client error such as "404 Not Found"
or "403 Forbidden", it likely our script bug not server side issue, we
should re-raise exception immediately instead of retrying.
fixes https://github.com/scylladb/scylla-machine-image/issues/505

Also please paste your verification

@syuu1228 ping

@syuu1228 please rebase and run verification

Rebased, running next-machine-image at:
https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/328/

@syuu1228 Running full verification failed twice, https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/330/ , please make sure it's not related to your changes

I found that full verification actually can pass with May 27, 2024 version of scylla-master/next build (It was the latest build on scylla-master/next when I tested).
Test result: https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/339/
I guess the error is not related this patch.

I found that full verification actually can pass with May 27, 2024 version of scylla-master/next build (It was the latest build on scylla-master/next when I tested).
Test result: https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/339/
I guess the error is not related this patch.

https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/340/ passed


Repository of vanilla JavaScript starter template

Is there one as mentioned in the README.md?

Also wondering where that would be.

same

not sure where the link is to the github repo, but the first page of their doco https://reactflow.dev/learn has a link to a codesanbox of the  js version
https://new.reactflow.dev/js
go figure!

Hmm, I'm not sure that counts as vanilla.
Vanilla to me would be HTML + JS + CSS.

it's not Typescript. I guess I assumed they were still only referring to a react example that was either TS or just js