How do I wait for JavaScript to finish executing?

I am simulating user interaction with a web page and I need to know how to either register a callback or wait for JavaScript to finish, preferably without using Thread.sleep().
For example, I am using myDocument.query(SUBMIT_BUTTON).get().click() to simulate submitting a form, which makes an Ajax call and then updates the DOM with the results.  My Java code needs to wait for that Ajax call to finish and the DOM to be updated before it can use the next call to myDocument.query().  The same goes for the inital page load; I need to wait for the onLoad() javascript to finish before querying the DOM.
How do I accomplish this?  Thank you in advance...

I need to wait for the onLoad() javascript to finish before querying the DOM.

Ui4j automatically waits pageLoad event. Its not required to use sleep or etc to wait the pageLoad event. Check this example for sample usage. After the click event Ui4j waits until the pageLoad event.

My Java code needs to wait for that Ajax call to finish and the DOM to be updated before...

I just add add new sample code snippet to show listen DOM modifications. Let me know if this sample usage is enough to simulate your use case to wait DOM modifications without using Thread.sleep(long).

I tried using the DOMSubtreeModified event like you put in your sample code, but that fires on every DOM modification, right?  I somehow need to know when the DOM is done being modified, then I can continue my code execution.  The Javascript in the page will perform an unknown number of modifications.

@JoeJErnst  Agreed. I'm assessing this library for my company and if I cannot know when angular is done doing it's magic it's a deal-breaker...
@ui4j please give us a graceful solution as I see that your underlying webEngine has a stateProperty listener but when I use it it complains that the thread is not an FX Application Thread.
Page page = browser.navigate("http://localhost:8084/whatever");

WebEngine engine = (WebEngine) page.getEngine();

engine.getLoadWorker().stateProperty().addListener((observable, oldValue, newValue) -> {
            System.out.println(observable);
            System.out.println(oldValue);
            System.out.println(newValue);
        });

gives me

java.lang.IllegalStateException: Not on FX application thread; currentThread = main
at com.sun.javafx.tk.Toolkit.checkFxUserThread(Toolkit.java:204)
at com.sun.javafx.tk.quantum.QuantumToolkit.checkFxUserThread(QuantumToolkit.java:438)
at javafx.scene.web.WebEngine.checkThread(WebEngine.java:1182)
at javafx.scene.web.WebEngine$LoadWorker.stateProperty(WebEngine.java:1223)

Hi,

I use it it complains that the thread is not an FX Application Thread.

You must execute all JavaFx methods from JavaFx Thread.
Please execute your sample code with javafx.application.Platform.runLater()
javafx.application.Platform.runLater(() -> {
engine.getLoadWorker().stateProperty().addListener((observable, oldValue, newValue) -> {
            System.out.println(observable);
            System.out.println(oldValue);
            System.out.println(newValue);
        });
});


ability to pause / resume downloads

@Kriesse in https://github.com/datproject/dat-desktop/issues/184#issuecomment-281316401:

As shown in the suggestion, I think we should tie this in with another feature: Users should be able to pause the transfer (download+upload) of a dat. In context:

@yoshuawuyts please assign priority and milestone

needs: paused state in multidat

work has started here: https://github.com/datproject/dat-desktop/tree/add/toggle-pause

needs two things:

multidrive: add {set,get}Meta
dat-worker: add .{join,leave}{,Network}

pull request here: https://github.com/datproject/dat-desktop/pull/291


Validate all game inputs

The nestrischamps server right now is much too trusting on incoming game frames:

binary messages are appended to game files regardless of their size and format
if a non-supported version is received, the binary frame constructor can throw and crash the server

Expected
No user input should ever be able to crash the server.
Replay game files should be of the correct format so they should protect themselves.
TODO:
Do minimum inspection on game frames before they are used for anything. No need to do full parsing of the data, but at least extract the version field and from it validate binary frame size

Done in https://github.com/timotheeg/nestrischamps/commit/00602042eb40a06eedd94b1cbc811ce730c9aad7
(alongside some other minor cleanups)


Add Xamarin implementation

For a project using Xamarin, I had to integrate libsodium. I could not find readily available packages.
There are minimal changes needed to make it work:

Update the way DllImport is called, because of the way Xamarin.iOS packages dlls
Use msbuild instead of dotnet, because dotnet does not support Xamarin

For now, the binary files for Android and iOS still have to be included manually to the project, because the libsodium Nuget itself does not contain them, but at least the "C# wrapper" part can be automated.
Instead of publishing my own nuget under a different name, I though it would be nicer to submit a PR first to see what you thought about it.
The PR has to be improved a bit (squashing commits, updating the readme), but I'll wait for your feedback before spending more time on it.
What do you think ?

Looks like codecov is broken on master.

FYI I published a custom version here. My goal would be to deprecate it if my PR can be merged here.

Thanks @tabrath. I wanted to make sure that you would accept the PR before doing a final pass on all my changes. I now updated and rebased my work.
You can see that I added a separate document explaining how to use the library with Xamarin, because you still need to compile libsodium yourself, as the NuGet does not provide it for Xamarin.

I noticed a bug. Please do not merge yet!

@tabrath sorry for the back and forth. There was still a bug with the NuGet package. I fixed it, and now the diff is even cleaner.
You can merge if it's all good on your side.


coffeeClasses improved compatibility: private static class fields via =, bound methods via => , constructor shouldn't return

Improved compatibility with CoffeeScript under coffeeClasses mode:

Private static classic fields via x = y within a class body, by wrapping body in an IIFE and adding some local variables. Probably only works with autoVar enabled (like various other coffeeCompat features). Fixes #457
Bound methods via f: => within a class body, by adding to the constructor (after super call if there is one). Also rewrite into method, similar to f: ->. Fixes #55.
Fix constructor getting an automatically inserted return in most cases. (Recent regression perhaps? This would make coffeeClasses pretty unusable.)

Compilations should match CoffeeScript's compilations.

@edemaine many thanks for all this. The generated code even looks nicer than Coffeescript!
This will unblock me on my major CS->Civet migration. I'll aim to make another attempt after Christmas. Fingers crossed on no more big bugs..
Thanks again.

Great, thanks! Let us know how it goes. (Feel free to join us on Discord too.) Have a good Christmas!


Error with uglify & commonjs while building

I am trying to build the app I have worked on but keep on getting error while building and not exactly sure where the main issue lies. Any idea on what's going wrong here?
{ Error: commons.js from UglifyJs
Unexpected character '`' [commons.js:41299,37]
    at /Volumes/macHome/wahmed/Workspaces/coding/Projects/Phonic/node_modules/next/dist/server/build/index.js:182:21
    at emitRecords.err (/Volumes/macHome/wahmed/Workspaces/coding/Projects/Phonic/node_modules/next/node_modules/webpack/lib/Compiler.js:269:13)
    at Compiler.emitRecords (/Volumes/macHome/wahmed/Workspaces/coding/Projects/Phonic/node_modules/next/node_modules/webpack/lib/Compiler.js:375:38)
    at emitAssets.err (/Volumes/macHome/wahmed/Workspaces/coding/Projects/Phonic/node_modules/next/node_modules/webpack/lib/Compiler.js:262:10)
    at applyPluginsAsyncSeries1.err (/Volumes/macHome/wahmed/Workspaces/coding/Projects/Phonic/node_modules/next/node_modules/webpack/lib/Compiler.js:368:12)
    at next (/Volumes/macHome/wahmed/Workspaces/coding/Projects/Phonic/node_modules/tapable/lib/Tapable.js:218:11)
    at Compiler.compiler.plugin (/Volumes/macHome/wahmed/Workspaces/coding/Projects/Phonic/node_modules/next/node_modules/webpack/lib/performance/SizeLimitsPlugin.js:99:4)
    at Compiler.applyPluginsAsyncSeries1 (/Volumes/macHome/wahmed/Workspaces/coding/Projects/Phonic/node_modules/tapable/lib/Tapable.js:222:13)
    at Compiler.afterEmit (/Volumes/macHome/wahmed/Workspaces/coding/Projects/Phonic/node_modules/next/node_modules/webpack/lib/Compiler.js:365:9)
    at require.forEach.err (/Volumes/macHome/wahmed/Workspaces/coding/Projects/Phonic/node_modules/next/node_modules/webpack/lib/Compiler.js:360:15)
  errors: [ 'commons.js from UglifyJs\nUnexpected character \'`\' [commons.js:41299,37]' ],
  warnings: [] }

This is not related to electron-next. It's either because you have a syntax error in your code or there's some ES2015 code (which Uglify doesn't support yet). 😊


fix(auth): revert to using decode instead verify for jwt

The move to verify was a bit shortsighted. It requires a public key or secret as an argument to verify the signed token. Typical usage of IBM's IAM service doesn't lend itself to this flow and the tokens returned don't have valid JWT signatures. This led to a runtime error everytime the core made an IAM request - a bit of a showstopping bug.
Additionally, we never had a goal of performing client-side validation of these tokens, we only decode them to determine the expiration time for usage in our refresh logic. The decode method is perfectly sufficient for that and indeed is called within the verify method anyways. Perhaps this flow will change in the future but this is all we need for now.
This reverts the logic to what we were using before but still using the safe version of the dependency. The new version makes the decode function read-only so I had to adjust our approach to mocking in the unit tests.

:tada: This PR is included in version 4.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Can WithdrawTask chain prerequisites?

If a single source is not sufficient to fill the Carrier (or meet the request's capacity), can we specify a MustHaveEnergy prerequisite? How can we exclude previously tapped sources?

Fixed in latest logistics rewrite


Optimize joins to lookup joins if one relation is relative small

Problem Statement
When joining 2 tables with a join condition, all rows for each tables are processed and then filtered by the join condition afterwards.
Such the underlaying collect operation will be a full table scan (if no further filters are defined).
Example query:
SELECT t1.id
FROM t1
JOIN t2
  ON t1.id = t2.id

Results in full table scans of t1 and t2:
+----------------------------------------------------+
| QUERY PLAN                                         |
+----------------------------------------------------+
| Eval[id] (rows=unknown)                            |
|   └ HashJoin[(id = id)] (rows=unknown)             |
|     ├ Collect[doc.t1 | [id] | true] (rows=unknown) |
|     └ Collect[doc.t2 | [id] | true] (rows=unknown) |
+----------------------------------------------------+

If there is a large imbalance in size between the two tables and one of the table size is relatively small and the bigger table has an INDEX on the column used in the join condition, adding a filter to the large relation to match only rows contained in the second table can significantly improve performance as only a subset of rows of the larger relation is emitted, avoiding a complete table-scan.
This is afaik known as a lookup join.
Example:
SELECT t1.id
FROM (
  SELECT id FROM t1 WHERE id = ANY(SELECT id FROM t2)
) t1
JOIN t2
  ON t1.id = t2.id

Resulting plan:
+------------------------------------------------------------------------------------------+
| QUERY PLAN                                                                               |
+------------------------------------------------------------------------------------------+
| Eval[id] (rows=unknown)                                                                  |
|   └ HashJoin[(id = id)] (rows=unknown)                                                   |
|     ├ Rename[id] AS t1 (rows=unknown)                                                    |
|     │  └ MultiPhase (rows=unknown)                                                       |
|     │    └ Collect[doc.t1 | [id] | (id = ANY((SELECT id FROM (doc.t2))))] (rows=unknown) |
|     │    └ OrderBy[id ASC] (rows=unknown)                                                |
|     │      └ Collect[doc.t2 | [id] | true] (rows=unknown)                                |
|     └ Collect[doc.t2 | [id] | true] (rows=unknown)                                       |
+------------------------------------------------------------------------------------------+

On a dataset with one table having 1_000_000 rows and the other 10_000 rows, a rough comparison indicates and improvement by ~10x.

Benchmarks
Setup
CREATE TABLE t1 (id int);
CREATE TABLE t2 (id int);

INSERT INTO t1 (id) (SELECT b FROM generate_series(1, 1000000) a(b));
INSERT INTO t2 (id) (SELECT b FROM generate_series(1, 10000) a(b));

Results
% echo 'SELECT t1.id FROM t1 JOIN t2 ON t1.id = t2.id ORDER BY 1 LIMIT 10;' | cr8 timeit --hosts localhost:4200
Runtime (in ms):
    mean:    8533.710 ± 54.553
    min/max: 8234.485 → 9684.405
Percentile:
    50:   8456.683 ± 278.331 (stdev)
    95:   9057.346
    99.9: 9684.405

% echo 'SELECT t1.id FROM (SELECT id FROM t1 WHERE id = ANY(SELECT id FROM t2)) t1 JOIN t2 ON t1.id = t2.id ORDER BY 1 LIMIT 10;' | cr8 timeit --hosts localhost:4200
Runtime (in ms):
    mean:    974.375 ± 6.049
    min/max: 930.558 → 1094.588
Percentile:
    50:   967.506 ± 30.860 (stdev)
    95:   1034.499
    99.9: 1094.588

The smaller the imbalance between the 2 tables is, the less improvements can be archived by this optimization. Additional, this may hit storage engine (in our case Lucene) limitations on how much clauses can be used, see https://cratedb.com/docs/crate/reference/en/5.4/config/node.html#indices-query-bool-max-clause-count.
Relates to #14820 and #11183.
Possible Solutions
Implement an optimizer rule to convert joins into lookup joins when there is a large imbalance in size between the two tables.
Considered Alternatives
Rewrite the query manually.

Hi @seut It looks like a good optimization to do with respective join operation. I am new to open source. can you please give me a push about how to get started and make it done. I am new to open source this will help me a lot.

@seut  in the process of writing optimization rule for the lookup join it have tried to execute the different formats of the lookup query (which are small changes itself to the query) that you have given ,where the query has given same time of execution as shown in below photos.
The original  :
    echo 'SELECT t1.id FROM (SELECT id FROM t1 WHERE id = ANY(SELECT id FROM t2)) t1 JOIN t2 ON t1.id = t2.id ORDER BY 1 LIMIT 10;' | cr8 timeit --hosts localhost:4200
      100 requests [00:01, 60.06 requests/s]
      Runtime (in ms):
          mean:    15.405 ± 0.134
          min/max: 14.600 → 18.944
      Percentile:
          50:   15.315 ± 0.683 (stdev)
          95:   16.581
          99.9: 18.944

other two formats:
echo 'SELECT t1.id FROM t1 JOIN t2 ON t1.id = t2.id WHERE t1.id IN (SELECT id FROM t2) ORDER BY 1 LIMIT 10;' | cr8 timeit --hosts localhost:4200
  100 requests [00:01, 58.62 requests/s]
  Runtime (in ms):
      mean:    15.636 ± 0.196
      min/max: 14.797 → 23.518
  Percentile:
      50:   15.412 ± 1.001 (stdev)
      95:   16.942
      99.9: 23.518

echo 'SELECT t1.id FROM t1 JOIN t2 ON t1.id = t2.id WHERE t1.id = ANY(SELECT id FROM t2) ORDER BY 1 LIMIT 10;' | cr8 timeit --hosts localhost:4200
    100 requests [00:01, 61.03 requests/s]
    Runtime (in ms):
        mean:    15.130 ± 0.081
        min/max: 14.648 → 16.469
    Percentile:
        50:   14.979 ± 0.414 (stdev)
        95:   15.970
        99.9: 16.469

and the optimization rule is where i am trying to read the source code where to include. Here is the pseudo code for lookup join i am looking at with respective the size of two tables:
function convertToLookupJoin(original_query):
    if original_query is of the form "SELECT ... FROM t1 JOIN t2 ON t1.id = t2.id ..."
        and join condition is based on equality (t1.id = t2.id)
        and query includes ORDER BY and LIMIT clauses
    then
        size_t1 = getTableSize("t1")
        size_t2 = getTableSize("t2")

        if size_t1 > size_t2 and size_t1 / size_t2 > size_threshold
            transformed_query = "SELECT ...
            preserve ORDER BY and LIMIT clauses in transformed_query
            return transformed_query
        else if size_t2 > size_t1 and size_t2 / size_t1 > size_threshold
            transformed_query = "SELECT ...
            preserve ORDER BY and LIMIT clauses in transformed_query
            return transformed_query

    return the original query

@vamsikrishnacse
Your are right, the optimization can be also achieved by adding the filter directly to the query.
I'd slightly favor my initial query as it would replace the relation with a sub-select, this will ensure that the filter will be applied on the table collect operation itself.
When adding a filter to the original query, pushing down this filter to the relevant relation (and thus eventually on the collect operation) depends on other optimizations rules to be applied. I think this would be much simpler to implement, maybe worth doing as the first iteration.
Implementation wise, we'd create a dedicated optimizer rule to achieve this optimization.
The RewriteNestedLoopJoinToHashJoin is a good and simple example of such a rule. I think all rules are worth reading to dive into this topic, see https://github.com/crate/crate/tree/master/server/src/main/java/io/crate/planner/optimizer/rule.

Limited variant is implemented with https://github.com/crate/crate/pull/15664
But it only works for:
Join
 ├ Collect
 └ Collect

It keeps the join.
Doesn't work if there are other operators between the join and collect (or with Get/ForeignCollect).

Possible improvements going forward:

[ ] Lift the concrete Collect restrictions; Should work with any child operators
[ ] Replace the applyOptimization condition. E.g. rule could always apply, and then a cost model decides which variant is used.
[ ] Drop the parent join if only outputs from one side are used
[ ] Add a runtime query/bloom-filter push-down . This is complementary and could be used if the rule isn't used.


Disallow duplicates when adding Product Feature

It's currently possible to add a second ProductFeature with the same product + feature combination in the productfeature view. This should not be possible and fail either gracefully or with an error popup.

We can do this with @@unique constraint.
See Prisma Docs and possible pitfall

implemented, so completed, (the pitfall mentioned above is not relevant since our ProductFeatures have their own id)


auto-close failed dependabot PRs

I think we should probably go ahead and close dependabot PRs which don't build.  It's not the end of the world if they hang around and get rebased until they actually work, but dependabot has an upper limit on how many it opens at one time.  So, to avoid inadvertently going over that limit and missing valid updates, we probably need to clean PRs up.

It might be possible to look for "resolution Impossible" in the build output, possibly adding a label if that happens and clearing it when the job restarts.


docs: translated Fragments.md

Follow the existing translation pattern and translate Fragments.md, feel free to let me know if there is any problem, thank you.

Thanks @bugtender & @neighborhood999 for both of your helps, I will review it carefully and create another PR.

Hi @RickyWooo, you don't need to close this PR, just edit and push it.

@neighborhood999 I see :) it just my working habits :joy:, I have modified on the documents for your reference, thank you.

Thanks for @neighborhood999's effort,  I have push the latest translation :)


[stable/prometheus-node-exporter] Add rootfs mount by default

Is this a new chart
No
What this PR does / why we need it:
The current chart excludes rootfs mount by default, this causes metrics for rootfs to be incorrect when docker storage isn't on the rootfs, a very confusing situation for users.
Which issue this PR fixes

fixes #22905

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

Woow it is a nice patch!, the community needs this change!, It's sad to not rely on node_filesystem.* metrics.
@gianrubio and @vsliouniaev could you review this patch for us ?
Thanks

/hold
Let’s hold PRs to stable prometheus charts for a short time until prometheus-community/community#28 (comment) is resolved. If you want to help with that effort, to test etc, that would be great!

🚧 This chart is now deprecated.
Further development has moved to prometheus-community/helm-charts.
If applicable, please re-open this PR there. Thanks!


TODO labels are not readable

Hello! I'm finding my TODO labels in comments to be unreadable. Wondering if I have a terminal color problem or if this is broken for you as well?

Here is what TODOs look like for me in Neovim when run on Alacritty:

It looks like you are running with transparency enabled, correct?

I have just committed a change where I explicitly set the TODO foreground color.
I think that should fix your issue. Give it a try and let me know.

@bluz71 Thanks for the update! It looks to have cleared the TODO highlight:

This is definitely better than before but curious if that was the intention to drop the highlight?

No, todos should be black text on yellow as seen here (with my recent update):

Are you using transparency? If you are then it may be the case that this is simply not fixable when in that mode. It may be your terminal that is changing the colors. You should pass on your details to see if I can repeat it.
Note, my nightfly and moonfly themes were designed for opaque background.

@dbalatero,
Any progress on this issue? It would be good to solve this or close this if it is unfixable.
Do you have a series of repeatable steps I can test?
Cheers.

This is my Alacritty config: https://github.com/dbalatero/dotfiles/blob/master/alacritty.yml
(but I changed background_opacity to 1.0, just haven't pushed yet).
I removed transparency in Alacritty but it's still blank:

Steps I guess would be:

open any Ruby file (.rb)
add a # TODO blah comment
it isn't highlighted

I think the change you made just removed the highlight color altogether, because I used to at least have a highlight before the change?

I am an Alacritty user, so I will experiment with your settings to see if I can repeat your issue.

I removed transparency in Alacritty but it's still blank:

Ok, something super weird is going on. Maybe something strange with your terminal setup.
Currently on my Alacritty setup TODOs are displayed just fine:

What is the value of your $TERM? In my case I use the Alacritty terminfo, hence my $TERM is alacritty.

I think the change you made just removed the highlight color altogether, because I used to at least have a highlight before the change?

The change merely explicity set the text color of TODOs, not the background color as noted in the Git commit
Which version of Vim are you using? I am using Neovim 0.5 on Linux. If I use Vim 8.1 all is good as well.
Also, what does :hi TODO output? This is my result:

Let's figure this out.
Cheers.

With your Alacritty configuration I see the following:

All works.
I will do some experiments on my Macbook to see if that makes any difference.
I am using Alacritty 0.6.0 by the way; I haven't upgrade to 0.7.0 yet.

A minimal vimrc file would also be handy.
Note, I just tested on my Macbook (Alacritty + Neovim), no issue with TODO.
Strange one. But let's try and fix it.

Ok, I restarted everything, reset tmux, reset my terminal, double checked that I updated your plugin, and it's working now.

Something must have been stuck/cached in some Alacritty -> tmux -> vim layer, but I think I'm sorted now. Sorry for the churn!

Ok, I am very happy that the issue cleared out.
But I am perplexed about what the actual cause was. It would have been quite useful to get the bottom. Alas this was a weird glitch of sorts. Maybe even non-reproduceable.
I appreciate the effort. We move on.
Best regards.


Major revamp of the docs.

This is a major rejigger of the documentation:

README is much smaller and points to docs for details.
Existing docs have been moved around slightly.
Added a demo for the API for new users.
Client has been updated to have default args.

I would hope to merge this quickly, and then tag v0.1.0a3. We then make a PyPI package and the docs should automatically be built on read-the-docs. We can then review the docs today and tomorrow and fix the bugs that we find.

+1 modulo nits

Okey dokey, nits addressed.
Merge me?


Post Transaction Hook

@b1bart @victorj8
I found preexecution_hook is under development. I implemented post_transaction_hook feature for applying different transaction fee mechanism.
https://github.com/turnpike/eos/commits/feature/post_transaction_hook
In enterprise environment (private/consortium network), there was a request for fixed (reference fee table by contract::action name combination) or flexible (similar to Ethereum Gas instead of CPU/NET/RAM, CPU/NET/RAM usage can be used to calculate fee amount) transaction fee system.
The current design of post_transaction_hook is calling eosio::ontx in the end of transaction execution, and CPU/NET/RAM usage will be passed as payload. (The list of action name can be passed to find fixed fee rate from table instead of deserializing transaction in wasm). CPU/NET will not be charged during post_transaction_hook execution, so the target contract of post_transaction_hook should be managed carefully. It woud be possible to make eosio::setcode for the target contract of post_transaction_hook requires BP multi-sig, or restrict changing RAM usage during post_transaction_hook execution.
Code diff makes things difficult, so if it is allowed, I would implement post_transaction_hook feature to fit the current design of preexecution_hook. Can you share any schedule or plan about transaction hook feature?

Hey @conr2d - we were working on the preexecution hook, but it created a significant performance degradation since it required us to instantiate the WASM engine (which is extremely expensive) twice per transaction.  Would your approach introduce a similar issue?


RuntimeError installing blanc via brew on Mac

I'm encountering the following error when install blanc from Mac's brew.

No checksum was provided for this resource.
For your reference, the checksum is:
  sha256 "a06d523fbabf0a58676e4ab1dc84bc65f48f666e35078378e2e63ba1758f1075"
Error: An exception occurred within a child process:
  RuntimeError: Error, only supporting binary packages at this time

Upgrading to MacOS Big Sur (currently on macOS Catalina)

Upgrading to MacOS Big Sur (currently on macOS Catalina)

What version of MacOS do you use? Currently, the prebuilt binary of blanc is provided only for Big Sur, so brew will complain about not supporting prebuilt binaries for other version of MacOS. I would provide binaries for lower versions.

What version of MacOS do you use? Currently, the prebuilt binary of blanc is provided only for Big Sur, so brew will complain about not supporting prebuilt binaries for other version of MacOS. I would provide binaries for lower versions.

Looks like everything is working once I upgraded to MacOS Big Sur

Looks like everything is working once I upgraded to MacOS Big Sur


GDScript: Improve usability of setter chains

Consider PackedArrays non-shared since they are copied on C++/script boundaries.
Add error messages in the analyzer when assigning to read-only properties.
Add specific error message at runtime when assignment fails because the property is read-only.

Fix #62857

modules/gdscript/tests/gdscript_test_runner.cpp:209: ERROR: CHECK( result.passed ) is NOT correct!
  values: CHECK( false )
  logged: /Users/runner/work/godot/godot/modules/gdscript/tests/scripts/analyzer/errors/assign_to_read_only_property_indirectly.gd
          GDTEST_ANALYZER_ERROR
Cannot call non-static function "body_get_direct_state()" on the class "PhysicsServer3D" directly. Make an instance instead.

Leak sanitizer doesn't seem to be happy.

Thanks!


websocket is disconnected: Invalid HTTP upgrade

I'm trying to use Starscream on AppleTV.
    socket = WebSocket(url: URL(string: url)!)
    socket?.delegate = self
    socket?.connect()

My url is valid "wss://hooq.com/blablabla"    (replacing the blablabla part)
My delegate is sometimes called with the error "websocket is disconnected: Invalid HTTP upgrade", and other times nothing is called. Not connected or disconnected.
Any thoughts as to what might be wrong?

Same thing here (on iPhone though). I tried https://www.websocket.org/echo.html and everything seems to be working ok with the url.

Just so you know, I've tried https://github.com/tidwall/SwiftWebSocket and I did manage to connect to the server that failed with Starscream. Starscream doesn't set a user agent header by default so I tried adding it, but that didn't make it work.

Thanks for your help on this. Using the suggested SwiftWebSocket seemed to work for me.
On April 6, 2017 at 9:40:21 AM, David<EMAIL_ADDRESS>wrote:
Same thing here (on iPhone though). I tried https://www.websocket.org/echo.html and everything seems to be working ok with the url.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Not sure if outdated, but I noticed that using Starscream with wss:// forced 'host' header to be site.com:443, while it had to be just site.com. So I had to set it manually socket.headers["host"] = site.com - that fixed the issue for me

Thanks.
On April 20, 2017 at 6:25:26 PM, muchprogrammer<EMAIL_ADDRESS>wrote:
Not sure if outdated, but I noticed that using Starscream with wss:// forced 'host' header to be site.com:443, while it had to be just site.com. So I had to set it manually socket.headers["host"] = site.com - that fixed the issue for me
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi all, not sure what you are seeing here. I have been able to successfully connect with the default Starscream configuration in the past to multiple WebSocket servers over both secure and non secure connections. That being said, some WebSocket servers might have a specific host name requirement or user agent requirement that isn't apart of the RFC. This of course makes it impossible for Starscream to handle all cases requirement by different servers, but as you have all found, you can easily set your own headers as needed by your WebSocket server to connect. If anyone finds anything specific, feel free to open a issue or PR.


[ca] Enable node cert signing by external CA

This patch adds support for node certificate signing by an external CA.

ping @diogomonica @aaronlehmann

currently working on testing

... as well as a "how-to" guide

[Current coverage][cc-pull] is 54.06%

Merging [#969][cc-pull] into [master][cc-base-branch] will decrease coverage by 3.31%

@@             master       #969   diff @@
==========================================
  Files            70         76      +6
  Lines          9165      11550   +2385
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           5259       6245    +986
- Misses         3221       4423   +1202
- Partials        685        882    +197

[][cc-pull]

Powered by Codecov. Last updated by [682e0b6...ed24788][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/682e0b69be208176d6055cba855a5e9cf15c7cb4...ed24788e2e50018928d70e9d3c1f8620a0d1005a
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/969?src=pr

LGTM
There may be a few mechanical concerns:

What is the protocol used for CSR to authority? Seems to be part of cfssl.
Is this a prototype of how we do system plugins?

All in all, the design looks good.

What is the protocol used for CSR to authority? Seems to be part of cfssl.

Yep, looks like I forgot to link this to https://github.com/docker/swarmkit/issues/297#issuecomment-223458001

Is this a prototype of how we do system plugins?

I did not have this intention.

I'm currently working on a configuration example. I remember hearing/seeing chat about moving swarmd and swarmctl into an examples directory at the top of the repo. If I want to just add a simply cfssl CA server example, can I put it in cmd for now? Or should I take the initiative and create an examples directory now with an external-ca example with a README?

😢  I think it would have been okay to merge #984. I could very easily rebase.

@tonistiigi @vieux we're probably going to need this exposed on docker swarm init --external-ca

This looks good. I know you're still working on docs and so on. Once you think this is ready to merge, let us know.
This change will impact engine-api, so ping @vieux.

Looks like we would not be able to merge this PR because of merge conflicts. Please rebase, fix conflicts, and force push to your branch.

@diogomonica @aaronlehmann PTAL While I initially put a lot of work into writing a separate external TestCA in the testutils package I decided that it would be much easier to make it configurable in the existing TestCA type. What's really cool is that I did not have to write any extra tests - instead I added a custom TestMain() function which actually runs all of the tests in the ca package twice: once with everything like it was before and again with the testutils package configured to create new TestCA objects with an external ca server. So every condition which is already being tested now automatically gets tested in an environment configured with an external CA server!

This seems very close to being ready for merging. I left a few comments - I think all minor things.
This is great work and I'm looking forward to having it in the project.

Thanks @aaronlehmann I've also rebased.

eh, rebased again to reword the commits since I did a bunch of fixups on the last one.

LGTM
ping @diogomonica

It seems unfortunate to bring in the abstract notion of an external CA and tie it directly to a particular implementation. It'd be much nicer if CFSSL-specific code was kept as an interface implementation. It's not just about other implementations having to shim in a CFSSL-like signing endpoint in order to work here; other implementations may not need parameters CFSSL supports, or have extra capabilities CFSSL does not.

@jefferai while this implementation uses the sign request JSON format from CFSSL we are not limited to this format going forward - other plugins could be added in the future to support whatever capabilities are required to meet your organization's policy on TLS certificates.

@jlhawn That kind of misses my point, which is that this is being billed generically as a capability to sign certificates externally -- but it's really a capability to sign certificates externally with CFSSL. Changing terminology and APIs will be harder once this is initially released, so this is a good opportunity to keep things abstract from the get-go to make multiple implementations much easier.

@jlhawn LGTM. Thank you for all the work.
@aaronlehmann feel free to merge.
@jefferai In general I agree with your concern: it would be ideal to have a plugin system that allowed a more generic external-ca interaction, and it will be harder to implement later. This said, the capability of signing certificates with a well popular open-source CA server is definitely good enough for this first release. It would be great to see real-world use-cases drive a community designed and contributed plugin system later on.

@diogomonica I'm not asking for a plugin system; I'm asking for abstract interfaces...if nothing else at this point, at the UX level. CFSSL is not the only popular open-source CA server, and it seems very likely that other implementations will appear, especially considering that this isn't even merged yet and users came to me asking about Vault support.
There's no point trying to argue metrics about the relative popularity of CFSSL vs. Vault vs. DogTag vs. EJBCA vs. anything else, but clearly there is interest from users of other projects. At least UX-wise, it would be nice not to codify assumptions in at the base level in favor of treating other implementations as equal parties.

@jefferai: I agree it makes sense to avoid tying the CLI/API to a particular CA protocol. I am going to open a separate PR today to make this more future-proof. I'll merge this one so I can build on top of it. I'll ping you when I open the followup PR.

@aaronlehmann I already have a code going (not pushed yet) that makes this usable by multiple signing services.
I'll open a PR today, although it likely won't be finished today (I'll keep status updated in the PR).

@jefferai: Great! It sounds like we should work in parallel - there's a new docker rc release coming up and I want to make sure we get the API/CLI right and don't have to change it later. We can support for other signing services later.
What do you think about doing something like this at the API level:
message ExternalCA {
        enum CAType {
                CFSSL = 1;
        }
        CAType type = 1;
        string url = 2;
        string options = 3;
}

...

repeated string external_cas = 2;

At the CLI level, this could look something like:
--external-ca type=cfssl,url=https://ca1.example.com
(cc @stevvooe)

@aaronlehmann See https://github.com/docker/swarmkit/pull/1099, which is a push of the code I'd already written. That might be a good place to discuss this.


Online Demo please?

Looks interesting -- would an online demo be possible? Would like to add to react.rocks, thanks

Good idea. I'll look into this.

@phopkins I would be happy to get this running on github pages for the repo if you want me to

That would be super awesome. Shouldn't be tooo much of a thing to export
the demo bundle in some fashion. But I suppose there's always wrinkles.
On Wed, Oct 7, 2015 at 4:47 PM, Joseph Furlott<EMAIL_ADDRESS>wrote:

@phopkins https://github.com/phopkins I would be happy to get this
running on github pages for the repo if you want me to
—
Reply to this email directly or view it on GitHub
https://github.com/twitter-fabric/velocity-react/issues/25#issuecomment-146322912
.

Nah. Will check it out after work!

I will link the demo from the velocity docs too.

Sorry for the delay @phopkins but I just got it up running on my fork on the gh-pages branch.  I added a build task which the same as the demo script but it uses webpack instead of the dev server.  Additionally, I broke out the demo/index.html and put it in the root with updated paths.
I had to remove build from the .gitignore so that the files would be available as well in version control.  Obviously this branch should never be merged into master.
It is visible here http://jmfurlott.github.io/velocity-react/
@phopkins if you want me to merge this in, I think I need you to create a gh-pages so I have a branch that I can make a PR on

Shiny! Made the gh-pages branch.
Ideally, I think we should check any code / location changes in to master
(i.e. make the demo index.html work from wherever) and then just have
gh-pages for the pre-built build directory.
Did you run into anything where the webpack-dev-server doesn't like
referencing the bundle.js file from build? I'd like to figure out how
to sort that out if it's possible. I can look at it if it's out-of-scope
for you. (This came up in another bug, where webpacking and just opening
the index.html file didn't work, but running through the dev server did.)
On Fri, Oct 16, 2015 at 9:10 PM, Joseph Furlott<EMAIL_ADDRESS>wrote:

Sorry for the delay @phopkins https://github.com/phopkins but I just
got it up running on my fork on the gh-pages branch. I added a build task
which the same as the demo script but it uses webpack instead of the dev
server. Additionally, I broke out the demo/index.html and put it in the
root with updated paths.
I had to remove build from the .gitignore so that the files would be
available as well in version control. Obviously this branch should never be
merged into master.
It is visible here http://jmfurlott.github.io/velocity-react/
@phopkins https://github.com/phopkins if you want me to merge this in,
I think I need you to create a gh-pages so I have a branch that I can
make a PR on
—
Reply to this email directly or view it on GitHub
https://github.com/twitter-fabric/velocity-react/issues/25#issuecomment-148873558
.

Ugh so weird. I couldn't make the PR because it said our commit history was completely different.  I ended up having to re-fork and re-add the changes.
I think we have to have a index.html in the root for gh-pages. There may be a better way to do this.
I am not sure what you mean by the webpack-dev-sever and referencing the build? I didn't touch the dev sever as I don't want it running at all.  If you can point me to more info (via another issue), I can check it out

Here's the PR that was put in regarding build/bundle.js vs. bundle.js: https://github.com/twitter-fabric/velocity-react/pull/16
I'm ok with index.html in the root for the demo. Could just .npmignore it out.

In the gh-pages you don't need to start a server in order to view the index.html. Making that possible is essentially all my PR is.  You have to run npm run build, which executes and just spits out build/bundle.js (but this path could be anything), and then the index.html just loads in that bundle.  Obviously nothing is watching the changes or anything, but it works completely statically

Cool. Thank for sorting this out. I'll merge the PR to the gh-pages
branch, which will get the demo up there, and then I can look into the
paths and keeping the static version consistent with the demo going forward.
On Mon, Oct 19, 2015 at 2:32 PM, Joseph Furlott<EMAIL_ADDRESS>wrote:

In the gh-pages you don't need to start a server in order to view the
index.html. Making that possible is essentially all my PR is. You have to
run npm run build, which executes and just spits out build/bundle.js (but
this path could be anything), and then the index.html just loads in that
bundle. Obviously nothing is watching the changes or anything, but it works
completely statically
—
Reply to this email directly or view it on GitHub
https://github.com/twitter-fabric/velocity-react/issues/25#issuecomment-149306325
.

Thanks to @jmfurlott, the basic demo is accessible at: http://twitter-fabric.github.io/velocity-react/


Items get dragged in a non-draggable formulize instance when formula contains above 5 elements

Steps to Reproduce:

!


Enabled deprecation warnings for all future deprecations

Thanks! Some of those warnings have been ready for a very long time so it is good to make sure everyone sees them now and eventually apply the deprecations.


libvirtd

@IMCAgro hi, was this intentional?

@IMCAgro, could you provide a bit more details what you meant by this libvirtd issue? Thanks.


Test masking options

Now implemented as part of the test battery available at https://github.com/incf-nidash/nidmresults-examples.


Lost access

Sorry, guys - I accidentally removed myself as a collaborator. Can you add me again? @MylesBorins @mikeal

@leo Not sure if @mikeal has access anymore. Let me see if I can help raise this for you.

Thank you!

Closing this now, as it seems like someone else took over... 😊


Merge refs/heads/feature/find-as-cursor into alpha

Merge refs/heads/feature/find-as-cursor into alpha

This PR has been merged into alpha and tagged as 1.6.0-alpha-202304121441. Thanks for your contribution!


SCM_DO_BUILD warning silently blocks deploy

Repro steps:

Open a simple node web app
Deploy with blue up arrow
Create a new web app with basic create
Look away for a little while

Actual:
The following warning popped up, prevented the deploy from starting, and went away. I had to open the notification bell just to know why it didn't finish.

Expected:
I feel like this dialog should either be modal so that it doesn't disappear after a few seconds or it shouldn't block deploy from continuing

@fiveisprime TODO: Oryx might do this by default so investigate that

It doesn't. :( Sent mail to get a better understanding of if/when this is coming.

Verified on Win 10 & Mac with build 20191125.3, there is no warning dialog pops up when deploying.


Setting custom PAN id (TZ-92)

I'd like to be able to use the ESP32-C6 as a coordinator for an already existing Zigbee device which implements only the bare minimum of the Zigbee protocol.
These devices use a specific PAN id, the ESP32-C6 automatically generates a PAN id during network formation, how can I set the PAN id manually?
Can you add an API interface for setting the PAN id?

@renzenicolai we will add set PAN id api in the next release round.

Thank you!


Modify the user sql to governed sql

[ ] Explore google cloud sql proxy

How is this in relation to the enforcement at scale work done in the past?

@simanadler What is the enforcement at scale work?
The goal of this issue is to have a proxy server (for trino-module for example) that modify the input sql query according to governance policies. (For example: modify select a,b from table to select b from table when we have a policy to delete column a for the user who requested the query).
We used trino-poxy for the trino-module in this PR https://github.com/fybrik/trino-module/pull/5.
Also added a dbt-module that can modify sql queries https://github.com/Mohammad-nassar10/dbt-module.


Feedback form for nominations

When viewing the nominations list as an administrator, add a "Review" button to nominations not marked as reviewed.

Need to make a migration to add a reviewed and approved flag to the household table. Both integers that default to 0. Need to add a reason (varchar 255) field as well.
Need to include VueStrap :)
See (hopefully) attached diagram to show the flow of submitting a review.
If the modal is powered by Vue that would be way cool. From the modal to submitting / updating the record.

I also think a delete functionality would be good for half entered and duplicate nominations.

@Jillzey For now marketing as "duplicate" will have a similar effect. We can handle legitimately deleting in the future.

Finished in v1.1.0


Add converter CLI

Codecov Report

Merging #30 (87cf994) into main (867702c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          278       279    +1
  Branches        60        43   -17
=========================================
+ Hits           278       279    +1

Impacted Files
Coverage Δ

src/curies/web.py
100.00% <100.00%> (ø)

src/curies/api.py
100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


not force user to set variables in  file path.

fix： https://github.com/lviggiano/owner/issues/264

Coverage remained the same at 92.966% when pulling 3baa65086031d65b853714f179bcf0ece8218c3c on readilychen:master into 00096dfdf8924477ee3629c30ec0ce644bd92c5c on lviggiano:master.

Fixed in #227
Better to not print the stacktrace on System.out.


Misbehaviour when actions are pinned

This is related to (and aggregates):

https://github.com/senecajs/seneca-redis-pubsub-transport/issues/8
https://github.com/senecajs/seneca-redis-pubsub-transport/issues/19

When the actions are pinned for some reason even if the topic is specified the client is not able to reach the server.

Code to reproduce:
Client:
'use strict'

let seneca = require('seneca')()
seneca.use('../../../lib').ready(function () {
  this.act({foo: 'one', bar: 'aloha'}, function (err, response) {
    if (err) {
      return console.log(err)
    }
    console.log(response)
  })
}).client({type: 'redis', topic: 'my-topic', pin: {foo: 'one'}})

Server:
'use strict'

let seneca = require('seneca')()
seneca.use('../../../lib').ready(function () {
  this.add({foo: 'one'}, function (args, done) {
    done(null, {bar: args.bar})
  })
})

seneca.listen({type: 'redis', topic: 'my-topic', pin: {foo: 'one'}})

@dgonzalez This code seems to work if you run Server with:
'use strict'

let seneca = require('seneca')()
seneca.use('seneca-redis-transport')

seneca.add({foo: 'one'}, function (args, done) {
    done(null, {bar: args.bar})
})

seneca.listen({type: 'redis', topic: 'my-topic', pin: {foo: 'one'}})

It might have been fixed already. I'll have a look. Thanks!

With that being said if you add an additional pattern to the .add, then I think there's an issue.

Pinning does not work for me either. Is there any progress on this topic?


update embedded object cycle detection

It was reported that a cycle is incorrectly detected in the case of a diamond pattern of paths; eg. given the relationship graph A->B->C, and A->D->C.
Also fixed detecting cycles through top level objects, as this should be allowed by the server. Eg. Given a top level object with an embedded object which also has a link to the same top level object, this is not considered a loop we should restrict.

Related to https://github.com/realm/realm-object-store/issues/1065 and https://github.com/realm/realm-object-store/pull/1112.
@adamchel could you also double check the test cases here and make sure they agree with the cases the server will restrict?

@nirinchev @jbreams could I get one of you to review the updated loop checking code before merging?


MapView.Marker image won't rerender after being destroyed

Bug
On Android, if the Map is destroyed and recreated, markers with a custom Image will not be recreated, but will revert to the standard red Google Pin.
Environment info
React native info output:
  React Native Environment Info:
    System:
      OS: macOS 10.14
      CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
      Memory: 19.99 MB / 32.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 10.7.0 - ~/.nvm/versions/node/v10.7.0/bin/node
      Yarn: 1.16.0 - /usr/local/bin/yarn
      npm: 6.1.0 - ~/.nvm/versions/node/v10.7.0/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
      Android SDK:
        API Levels: 27, 28
        Build Tools: 27.0.3, 28.0.3
        System Images: android-28 | Google APIs Intel x86 Atom
    IDEs:
      Android Studio: 3.4 AI-183.6<IP_ADDRESS>22156
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: 0.59.9 => 0.59.9

Library version: 0.24.2
Steps To Reproduce

Open Android Developer options, select "Destroy activities immediately"
Open app, minimize it, open again.

First open:

After activity was destroyed:

Describe what you expected to happen:
That the marker would show as it did before minimizing.
Reproducible sample code
import React, { Component } from "react";
import { StyleSheet } from "react-native";

import MapView from "react-native-maps";

export default class App extends Component<Props> {
  render() {
    return (
      <MapView
        style={styles.map}
        initialRegion={{
          latitude: 60.15,
          longitude: 24.95,
          latitudeDelta: 0.03622,
          longitudeDelta: 0.05
        }}
      >
        <MapView.Marker
          coordinate={{
            latitude: 60.15,
            longitude: 24.95
          }}
          image={require("./ic_driver_dot_car.png")}
          anchor={{ x: 0, y: 0.5 }}
        />
      </MapView>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    ...StyleSheet.absoluteFillObject
  },
  map: {
    flex: 1
  }
});

Let me know if there's anything I could do to help with this.

Same issue


Don't expect full paths in the varialbe CMAKE_PREFIX_PATH

Catkin interprets the paths of the variable CMAKE_PREFIX_PATH as full paths which is not always true and is different to the usage of CMake. CMake uses the variable CMAKE_PREFIX_PATH together with the variable CMAKE_FIND_ROOT_PATH.
[1]: The CMake variable CMAKE_FIND_ROOT_PATH specifies one or more directories to be prepended to all other search directories. ... It is especially useful when cross-compiling to point to the root directory of the target environment ..."
[1] http://www.cmake.org/cmake/help/v2.8.12/cmake.html

Closing due to inactivity.


Handle arguments checking of min/max function to avoid crashes

Which issue does this PR close?

Closes #12011.
Rationale for this change
Handles min/max args checking and throw error instead of crash.

What changes are included in this PR?

Are these changes tested?
Yes.

Are there any user-facing changes?
No.

I couldn't help myself -- we should have a regression test for this code so I added one in https://github.com/apache/datafusion/pull/12024


"Command + V" does not paste; Takes cursor to top of the page

VSCode Version: 1.44.2
ff915844119ce9485abfe8aa9076ec76b5300ddd
x64
OS Version: macOS Mojave 10.14.6

Steps to Reproduce:

Copy any text or code. ( Command + V)
Try to paste it in vscode ( Command + C)
Text not copied but cursor returned to left corner of editor.

My user bindings are empty, so not sure why this is happening.

Does this issue occur when all extensions are disabled?: Yes/No
No

@Genysys sorry for the late response, are you still seeing this issue on latest version?


Added a slaves-tab to show the id, status and number of users running on each slave.

The tab is only visible when running in master mode. The slave-counter uses the same data (slave_count is no longer passed).

And the tests pass.
Is this good to go?

Please only merge in 23c49cc, I didn't expect the pull request to keep tracking my further changes.

Didn't realise that github will actively track my master branch. I've moved some commits out of master to fix the issue.

@TZer0 Are you still interested in having this merged?

@mbeacom I don't use Locust anymore, but sure - why not? It may save someone else from some serious trouble.

@TZer0 Great! Thank you for the contribution! Would you mind rebasing the branch?

@mbeacom I'll fix it after work in ~9 hours.

@mbeacom Should be it. I'll check up on it if the tests do not pass.

Does anyone have time to merge this?

@TZer0 I'm going to test this in a few. If everything look's good, I'll merge it in!


The HTML Language Server server crashed 5 times in the last 3 minutes. The server will not be restarted.

VSCode Version: 1.8.0-insider
OS Version: Win 7

Steps to Reproduce:

Open lengthy html file with divs and inline script tags.
Attempt to write code within first couple key strokes intellisense fails and the titled error appears.

Does this occur with any 'lengthy' html file or just one? Could you attach one?
What does the console in the devtools show (Help > Toggle Developer Tools)?

Sorry I can't attach code as it is corporate policy.  However its any file that I open which contains script blocks. Handlebars like syntax

What version of VSCode? Likely this was fixed by a603e8a.

Yes for the most part that did fix the issue.  But the error comes back
when dealing with the larger file.  Ill test more but I'm not sure if the
size of the file has anything to do with the error.  Its hard to determine
the actual cause.
On Wed, Nov 30, 2016, 1:04 AM Martin Aeschlimann<EMAIL_ADDRESS>wrote:

What version of VSCode? Likely this was fixed by a603e8a
https://github.com/Microsoft/vscode/commit/a603e8a765ea1cce688af291db60e7fe7e02c07c
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/16237#issuecomment-263808403,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFFsSVtFfjca4DNbz6va9u9Ht6dpcsknks5rDS4mgaJpZM4K_Xci
.

Closing for now. Please reopen with details

Hey I am also getting this.
In Handlebars templates with latest Insiders Build

The file is a .hbs file with 66 lines of code
Log from HTML Language Server Console
`module.js:457
throw err;
^
Error: Cannot find module 'typescript'
at Function.Module._resolveFilename (module.js:455:15)
at Function.Module._load (module.js:403:25)
at Module.require (module.js:483:17)
at require (internal/module.js:20:19)
at Object. (c:\Program Files (x86)\Microsoft VS Code Insiders\resources\app\extensions\html\server\out\modes\javascriptMode.js:9:10)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)
at Module.load (module.js:473:32)
at tryModuleLoad (module.js:432:12)
at Function.Module._load (module.js:424:3)
[Info  - 10:08:16 AM] Connection to server got closed. Server will restart.
module.js:457
throw err;
^
Error: Cannot find module 'typescript'
at Function.Module._resolveFilename (module.js:455:15)
at Function.Module._load (module.js:403:25)
at Module.require (module.js:483:17)
at require (internal/module.js:20:19)
at Object. (c:\Program Files (x86)\Microsoft VS Code Insiders\resources\app\extensions\html\server\out\modes\javascriptMode.js:9:10)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)
at Module.load (module.js:473:32)
at tryModuleLoad (module.js:432:12)
at Function.Module._load (module.js:424:3)
[Info  - 10:08:18 AM] Connection to server got closed. Server will restart.
module.js:457
throw err;
^
Error: Cannot find module 'typescript'
at Function.Module._resolveFilename (module.js:455:15)
at Function.Module._load (module.js:403:25)
at Module.require (module.js:483:17)
at require (internal/module.js:20:19)
at Object. (c:\Program Files (x86)\Microsoft VS Code Insiders\resources\app\extensions\html\server\out\modes\javascriptMode.js:9:10)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)
at Module.load (module.js:473:32)
at tryModuleLoad (module.js:432:12)
at Function.Module._load (module.js:424:3)
[Info  - 10:08:19 AM] Connection to server got closed. Server will restart.
module.js:457
throw err;
^
Error: Cannot find module 'typescript'
at Function.Module._resolveFilename (module.js:455:15)
at Function.Module._load (module.js:403:25)
at Module.require (module.js:483:17)
at require (internal/module.js:20:19)
at Object. (c:\Program Files (x86)\Microsoft VS Code Insiders\resources\app\extensions\html\server\out\modes\javascriptMode.js:9:10)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)
at Module.load (module.js:473:32)
at tryModuleLoad (module.js:432:12)
at Function.Module._load (module.js:424:3)
[Info  - 10:08:21 AM] Connection to server got closed. Server will restart.
module.js:457
throw err;
^
Error: Cannot find module 'typescript'
at Function.Module._resolveFilename (module.js:455:15)
at Function.Module._load (module.js:403:25)
at Module.require (module.js:483:17)
at require (internal/module.js:20:19)
at Object. (c:\Program Files (x86)\Microsoft VS Code Insiders\resources\app\extensions\html\server\out\modes\javascriptMode.js:9:10)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)
at Module.load (module.js:473:32)
at tryModuleLoad (module.js:432:12)
at Function.Module._load (module.js:424:3)
[Error - 10:08:23 AM] Connection to server got closed. Server will not be restarted.
`
Dev Tools

@Alonski Thats unrelated. I created https://github.com/Microsoft/vscode/issues/21743

Thanks!
On Mar 2, 2017 11:58 AM, "Martin Aeschlimann"<EMAIL_ADDRESS>wrote:

@Alonski https://github.com/Alonski Thats unrelated. I created #21743
https://github.com/Microsoft/vscode/issues/21743
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/16237#issuecomment-283609025,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbmZ5hBppuATdCSlGPMMrL-ytdmfS2Kks5rhpLEgaJpZM4K_Xci
.


OVOS is detecting my speech but no audio is playing

@austin-b, can you post information from your audio.log and voice.log files?  They are likely in $HOME/.local/state/mycroft. What happens when  you enter
ovos-speak "hello"
Thanks

$ ovos-speak "hello"
2023-11-05 10:09:52.485 - OVOS - ovos_bus_client.session:from_message:447 - WARNING - No session context in message:connected

and in audio.log after my recent restart of all the services:
2023-11-05 10:05:55.241 - audio - ovos_audio.service:__init__:58 - INFO - Starting Audio Service
2023-11-05 10:05:55.242 - audio - ovos_audio.service:on_started:40 - INFO - Audio service started.
2023-11-05 10:05:55.258 - audio - ovos_bus_client.session:from_message:447 - WARNING - No session context in message:connected
2023-11-05 10:05:55.500 - audio - ovos_audio.service:_maybe_reload_tts:317 - INFO - (re)loading TTS engine
2023-11-05 10:05:55.516 - audio - ovos_audio.playback:run:194 - INFO - PlaybackThread started
2023-11-05 10:05:55.692 - audio - ovos_utils.configuration:get_xdg_base - WARNING - Deprecation version=0.1.0. Caller=ovos_tts_plugin_mimic:93. configuration moved to the `ovos_config` package.
2023-11-05 10:05:55.725 - audio - ovos_utils.configuration:read_mycroft_config - WARNING - Deprecation version=0.1.0. Caller=ovos_tts_plugin_mimic:106. configuration moved to the `ovos_config` package.
2023-11-05 10:05:55.726 - audio - ovos_plugin_manager.tts:create:197 - INFO - Found plugin ovos-tts-plugin-server
2023-11-05 10:05:55.767 - audio - mycroft:<module>:37 - WARNING - mycroft has been deprecated! please start importing from ovos_core and companion packages
mycroft module remains available for backwards compatibility and will be removed in version 0.2.0
2023-11-05 10:05:56.835 - audio - ovos_plugin_manager.tts:create:200 - INFO - Loaded plugin ovos-tts-plugin-server
2023-11-05 10:05:56.836 - audio - ovos_audio.service:_maybe_reload_tts:336 - INFO - (re)loading fallback TTS engine
2023-11-05 10:05:56.863 - audio - ovos_plugin_manager.tts:create:197 - INFO - Found plugin
2023-11-05 10:05:57.057 - audio - ovos_plugin_manager.tts:create:200 - INFO - Loaded plugin
2023-11-05 10:05:57.078 - audio - ovos_audio.audio:load_services:95 - INFO - Loading audio service plugin: ovos_audio_simple
2023-11-05 10:05:57.079 - audio - ovos_audio.audio:load_services:95 - INFO - Loading audio service plugin: ovos_common_play
2023-11-05 10:06:02.347 - audio - ovos_audio.audio:find_ocp:62 - INFO - OCP - OVOS Common Play set as default backend
2023-11-05 10:06:02.349 - audio - ovos_audio.service:on_alive:36 - INFO - Audio service is alive.
2023-11-05 10:06:06.030 - audio - ovos_plugin_common_play.ocp:register_ocp_intents:120 - INFO - OCP intents missing, registering for <ovos_plugin_common_play.ocp.OCP object at 0x7fa573c8aef0>
2023-11-05 10:06:23.341 - audio - ovos_audio.service:execute_tts:348 - INFO - Speak: ten oh six
2023-11-05 10:09:52.492 - audio - ovos_audio.service:execute_tts:348 - INFO - Speak: hello

The "ten oh six" is a response to "what time is it":
2023-11-05 10:05:54.632 - voice - ovos_dinkum_listener.service:__init__:125 - INFO - Starting Voice Service
2023-11-05 10:05:54.679 - voice - ovos_dinkum_listener.service:on_alive:60 - INFO - DinkumVoiceService is alive.
2023-11-05 10:05:54.683 - voice - ovos_dinkum_listener.service:_before_start:314 - INFO - Starting service...
2023-11-05 10:05:54.695 - voice - ovos_bus_client.session:from_message:447 - WARNING - No session context in message:connected
2023-11-05 10:05:54.847 - voice - ovos_dinkum_listener.service:_connect_to_bus:413 - INFO - Connected to Mycroft Core message bus
2023-11-05 10:05:55.407 - voice - ovos_dinkum_listener.service:on_alive:60 - INFO - DinkumVoiceService is alive.
2023-11-05 10:05:55.410 - voice - ovos_dinkum_listener.voice_loop.hotwords:load_hotword_engines:108 - INFO - creating hotword engines
2023-11-05 10:05:55.438 - voice - ovos_plugin_manager.wakewords:load_module:165 - INFO - Loading "hey_mycroft" wake word via ovos-ww-plugin-precise-lite with config: {'module': 'ovos-ww-plugin-precise-lite', 'model': 'https://github.com/OpenVoiceOS/precise-lite-models/raw/master/wakewords/en/hey_mycroft.tflite', 'expected_duration': 3, 'trigger_level': 3, 'sensitivity': 0.5, 'listen': True, 'fallback_ww': 'hey_mycroft_vosk', 'sound': 'snd/start_listening.wav'}
2023-11-05 10:05:55.756 - voice - ovos_plugin_manager.wakewords:load_module:172 - INFO - Loaded the Wake Word hey_mycroft with module ovos-ww-plugin-precise-lite
2023-11-05 10:05:55.760 - voice - ovos_dinkum_listener.voice_loop.hotwords:load_hotword_engines:158 - INFO - Loading hotword: hey_mycroft with engine: <ovos_ww_plugin_precise_lite.PreciseLiteHotwordPlugin object at 0x7f730ef0ae90>
2023-11-05 10:05:55.762 - voice - ovos_plugin_manager.wakewords:load_module:165 - INFO - Loading "wake_up" wake word via ovos-ww-plugin-pocketsphinx with config: {'module': 'ovos-ww-plugin-pocketsphinx', 'phonemes': 'W EY K . AH P', 'threshold': 1e-20, 'lang': 'en-us', 'wakeup': True}
2023-11-05 10:05:55.798 - voice - ovos_plugin_manager.wakewords:load_module:172 - INFO - Loaded the Wake Word wake_up with module ovos-ww-plugin-pocketsphinx
2023-11-05 10:05:55.843 - voice - ovos_dinkum_listener.voice_loop.hotwords:load_hotword_engines:158 - INFO - Loading hotword: wake_up with engine: <ovos_ww_plugin_pocketsphinx.PocketsphinxHotWordPlugin object at 0x7f730ef0aa10>
2023-11-05 10:05:55.844 - voice - ovos_dinkum_listener.voice_loop.hotwords:load_hotword_engines:191 - WARNING - No stop words loaded
2023-11-05 10:05:56.618 - voice - ovos_plugin_manager.ocp:load:54 - INFO - Loaded OCP plugin: ovos-ocp-news-plugin
2023-11-05 10:05:56.831 - voice - ovos_plugin_manager.ocp:load:54 - INFO - Loaded OCP plugin: ovos-ocp-m3u-plugin
2023-11-05 10:05:57.085 - voice - ovos_plugin_manager.ocp:load:54 - INFO - Loaded OCP plugin: ovos-ocp-files-plugin
2023-11-05 10:05:57.298 - voice - ovos_plugin_manager.ocp:load:54 - INFO - Loaded OCP plugin: ovos-ocp-rss-plugin
2023-11-05 10:05:57.343 - voice - ovos_dinkum_listener.voice_loop.voice_loop:start:169 - INFO - Listening mode: wakeword
2023-11-05 10:05:57.344 - voice - ovos_dinkum_listener.service:on_started:64 - INFO - DinkumVoiceService started.
2023-11-05 10:05:57.345 - voice - ovos_dinkum_listener.service:on_started:64 - INFO - DinkumVoiceService started.
2023-11-05 10:05:57.346 - voice - ovos_dinkum_listener.service:run:289 - INFO - Service ready
2023-11-05 10:05:57.347 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:194 - INFO - Starting loop in mode: wakeword
2023-11-05 10:06:13.682 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:222 - INFO - Wakeword detected
2023-11-05 10:06:16.975 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:252 - INFO - speech finished
2023-11-05 10:06:22.094 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:669 - INFO - transcribed: "What time is it?"

I do not hear any listening sound/beep as I would expect.   Is it listed with the command pactl list sinks

pactl list sinks gives
Sink #1
	State: IDLE
	Name: alsa_output.pci-0000_00_1f.3.analog-stereo
	Description: Built-in Audio Analog Stereo
	Driver: module-alsa-card.c
	Sample Specification: s16le 2ch 44100Hz
	Channel Map: front-left,front-right
	Owner Module: 22
	Mute: no
	Volume: front-left: 65536 / 100% / 0.00 dB,   front-right: 65536 / 100% / 0.00 dB
	        balance 0.00
	Base Volume: 65536 / 100% / 0.00 dB
	Monitor Source: alsa_output.pci-0000_00_1f.3.analog-stereo.monitor
	Latency: 40207 usec, configured 40000 usec
	Flags: HARDWARE HW_MUTE_CTRL HW_VOLUME_CTRL DECIBEL_VOLUME LATENCY
	Properties:
		alsa.resolution_bits = "16"
		device.api = "alsa"
		device.class = "sound"
		alsa.class = "generic"
		alsa.subclass = "generic-mix"
		alsa.name = "ALC255 Analog"
		alsa.id = "ALC255 Analog"
		alsa.subdevice = "0"
		alsa.subdevice_name = "subdevice #0"
		alsa.device = "0"
		alsa.card = "0"
		alsa.card_name = "HDA Intel PCH"
		alsa.long_card_name = "HDA Intel PCH at 0xb1220000 irq 129"
		alsa.driver_name = "snd_hda_intel"
		device.bus_path = "pci-0000:00:1f.3"
		sysfs.path = "/devices/pci0000:00/0000:00:1f.3/sound/card0"
		device.bus = "pci"
		device.vendor.id = "8086"
		device.vendor.name = "Intel Corporation"
		device.product.id = "9d71"
		device.product.name = "Sunrise Point-LP HD Audio"
		device.form_factor = "internal"
		device.string = "front:0"
		device.buffering.buffer_size = "352800"
		device.buffering.fragment_size = "176400"
		device.access_mode = "mmap+timer"
		device.profile.name = "analog-stereo"
		device.profile.description = "Analog Stereo"
		device.description = "Built-in Audio Analog Stereo"
		module-udev-detect.discovered = "1"
		device.icon_name = "audio-card-pci"
	Ports:
		analog-output-speaker: Speakers (type: Speaker, priority: 10000, availability unknown)
		analog-output-headphones: Headphones (type: Headphones, priority: 9900, availability group: Legacy 2, not available)
	Active Port: analog-output-speaker
	Formats:
		pcm

alsamixer looks like so:
┌──────────────────────────────────────────────────────────── AlsaMixer v1.2.6 ────────────────────────────────────────────────────────────┐
│ Card: HDA Intel PCH                                                                                F1:  Help               │
│ Chip: Realtek ALC255                                                                                F2:  System information │
│ View: F3:[Playback] F4: Capture  F5: All                                                                         F6:  Select sound card  │
│ Item: Master [dB gain: 0.00]                                                                                Esc: Exit               │
│                                                                                │
│                                                                                │
│                                                                                │
│      ┌──┐      ┌──┐      ┌──┐      ┌──┐                                    ┌──┐                ┌──┐      ┌──┐      ┌──┐                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │  │                │  │      │  │      │  │                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │  │                │  │      │  │      │  │                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │  │                │  │      │  │      │  │                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │  │                │  │      │  │      │  │                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │  │                │  │      │  │      │  │                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │  │                │  │      │  │      │  │                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │  │                │  │      │  │      │  │                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │  │                │  │      │  │      │▒▒│                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │  │                │  │      │  │      │▒▒│                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │▒▒│                │  │      │  │      │▒▒│                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │▒▒│                │  │      │  │      │▒▒│                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │▒▒│                │  │      │  │      │▒▒│                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │▒▒│                │  │      │  │      │▒▒│                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │▒▒│                │  │      │  │      │▒▒│                  │
│      │▒▒│      │  │      │▒▒│      │▒▒│                                    │▒▒│                │  │      │  │      │▒▒│                  │
│      ├──┤      ├──┤      ├──┤      └──┘      ┌──┐      ┌──┐      ┌──┐      ├──┤    Disabled    ├──┤      └──┘      └──┘    Disabled      │
│      │OO│      │MM│      │OO│                │MM│      │OO│      │OO│      │MM│                │MM│                                      │
│      └──┘      └──┘      └──┘                └──┘      └──┘      └──┘      └──┘                └──┘                                      │
│      100       0<>0    100<>100  100<>100                                 37<>37               0<>0      0<>0     53<>53                 │
│   < Master  >Headphone  Speaker     PCM     S/PDIF   S/PDIF 1  S/PDIF 2    Beep    Auto-Mute Headset M Headset M Internal  Loopback      │
│                                                                                │
│                                                                                │
│                                                                                │
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

The only thing I see is the onboard audio.  What speaker are you using?

That's all I'm working with at the moment, my laptop's onboard audio. I will find a speaker or headphones to test with and see if there's any difference.

You are using a x86.  How did you install OVOS?  This repo is optimized for a Rpi, so I am curious what you did.

I cloned the repo and ran manual_user_install.sh. I had a few issues to clear up but those were mainly related to getting the services running.

That is good to know that it can be installed on an x86 with that script.  I would like to make this script work with an option for x86 and for OS's other than Ubuntu.  It should be able to autodetect hardware and run the correct setup for each.

I just installed using the newest manual_user_install.sh on my HP Intel laptop.  ovos-admin-phal.service didn't start, but everything else did.  ovos-speak "hello" gives me a hello with some deprecation messages. Still looking for the log files, but in a fuzzy sense it's working for me too.

Logs were in the customary spot, I was chasing a command typo.  All I needed to do was turn up my microphone volume and OVOS works as expected.
Ovos-speak gives me the same "WARNING - No session context in message:connected" output but does vocalize "hello".
If it helps, I am running Ubuntu 23.10, HDA Intel PCH, and the Driver listed in pactl list sinks is Pipewire.

Both of these have been helpful to me in the past:
https://openvoiceos.github.io/community-docs/troubleshooting_audio/
https://mycroft-ai.gitbook.io/docs/using-mycroft-ai/troubleshooting/audio-troubleshooting

On my Raspberry Pi 3B+ the pactl list sinks driver is module-alsa-card.c and the sound is working.

Another place to look for odd output would be in /var/log/syslog.

Thank you for the syslog recommendation, I have came across this which I'm trying to decipher right now that I'm hoping is part of my issue:
Nov  5 16:15:13 tommyboi-Swift-SF314-51 pipewire-media-session[9033]: ms.mod.policy-node: 0x55d3ad799950: no node found for 38, stream error
Nov  5 16:15:13 tommyboi-Swift-SF314-51 python3[9188]: remote error: id=3 seq:7 res:-2 (No such file or directory): no node available
Nov  5 16:15:13 tommyboi-Swift-SF314-51 python3[9188]: stream node 38 error: no node available

For the past few weeks I have been having problems with OVOS occasionally dropping syllables, and this problem report talks about 'stuttering' as well as the ms.mod.policy-mode problem.  https://bbs.archlinux.org/viewtopic.php?id=270610

I see at https://github.com/QubesOS/qubes-issues/issues/8193 that pipewire is supposed to be a replacement for pulseaudio.  So I tried deleting pulseaudio and pulseaudio-utils from my pc install (Ubuntu 13.10 - pipewire) and OVOS is now correctly pronouncing the words. I notice that Ubuntu has a process running called pipewire-pulse.  You may be seeing competition between PW and PA. From the OVOS point of view I think you can try removing pulseaudio.
The intermittent speech problems have happened since I started running Debian bookworm on my Pi, and I know that bookworm has also switched to pipewire.  I tried removing pulseaudio from my Pi, but there is no equivalent to pipewire-pulse, and the dinkum-listener failed after starting. So I've removed pipewire from my Pi and the pronunciation is correct. Let's see how long that lasts!

About 15 minutes.  Hope you have better luck.

I tried a couple of things and have seemed to completely break my audio, no sound and no input or output devices are found at the moment. I'm not exactly sure what broke it so I will try again on a fresh Ubuntu install and will reinstall OVOS.

I think that the bug with the strange voices has been fixed, and AFAK, USB devices are working pretty well with the new images.  I am still working on i2c devices, eg respeaker devices.
please try out the new images and see if your issue is fixed
https://ovosimages.ziggyai.online/raspbian/newest

I haven't been able to get the pulseaudio input to work for my RPi 4 and a plantronics calypso mic/speaker.  I tried all of the pactl sources with no success. I was also unable to set the alsamixer input/output device (I think because I was logged into the venv.  Is pactl the preferred tool?  Should I be using pulseaudio? Thanks
Good news is that garbled speech is gone, tested with ovos-say-to. All good now.

Garbled speech was a bug with another package caching wrong, yes hope it was fixed.
Is your device usb? Or i2c?  pactl is part of pulseaudio, so yes, that is preferred. Bigger question, if a usb device why won't it work.

Yes, it is a USB device that worked without modification a week or so ago on a 3B install done with the script.
journalctl | grep -i pulsevoice - Last entry is: ovos_microphone_plugin_sounddevice:find_input_device:42 - INFO - Searching for input device: pulse
$ pactl get-default-source
OpenVoiceOS.monitor
$ pactl get-default-sink
OpenVoiceOS
ovos-say-to produces correct results
Microphone looks like it's not recording: "arecord  test.wav" records nothing, "hey mycroft" was not recognized as noted in journalctl.
PulseAudio capture volume is up all the way.

Please try the latest image. There have been some audio fixes

Will do. I'm traveling now. Look for something by next weekend.

Fixed.


[PORT] Update design-tokens package to version 4.0.0

PR here: https://github.com/consensys-vertical-apps/metamask-portfolio/pull/772

PR above ready for review @brianacnguyen

This has been completed in https://github.com/consensys-vertical-apps/metamask-portfolio/pull/772


Add Indexes to ValidatorSets queries

Adds indexes to LatestValidatorSet, should help with mongo slow queries, as before resulted from COLSCAN instead of IXSCAN https://github.com/w3f/1k-validators-be-PRIVATE/issues/7

this PR should target staging not master

Changed base


Support for 3D sync to physics

Same implementation as in 2D, based on the code from PR #49327.
Closes https://github.com/godotengine/godot-proposals/issues/961.

I've just pushed an extra modification in move_and_slide that can help with moving platforms, the same one that's already done in 2D:
https://github.com/godotengine/godot/blob/090e4c4abdd406a7ed7fc33d0a4670bba69a4c0a/scene/2d/physics_body_2d.cpp#L925-L932

Thanks!


Failed download directory

[x ] Using latest version as provided on the master branch
[ x] Searched for similar issues including closed ones

What is the purpose of your issue?

[ ] Script won't run
[ x] Encountered bug
[ ] Feature request
[ ] Question
[ ] Other

System information

Your python version: python 3.6.1
Your operating system: Ubuntu 14.04 on Windows

Description

wmp@LUBN366:/tmp/test$ spodl -s "lollipop Porn - Crazy Town"
Crazy Town~ Lollipop Porn
  4,009,023 Bytes [100.00%] received. Rate: [6381 KB/s].  ETA: [0 secs]
Converting Crazy_Town_Lollipop_Porn.m4a to mp3
Fixing meta-tags
wmp@LUBN366:/tmp/test$ ls
wmp@LUBN366:/tmp/test$ ls -la
total 8
drwxrwxrwx 2 wmp  wmp  0 Jul  7 18:58 .
drwxrwxrwt 2 root root 0 Jul  7 18:58 ..
wmp@LUBN366:/tmp/test$ alias -p | grep spodl
alias spodl='python /home/wmp/skrypty/pobrane/spotify-downloader/spotdl.py --avconv'
wmp@LUBN366:/tmp/test$ find /home/wmp/skrypty/pobrane/spotify-downloader/Music/ -iname "*Lollipop*"
/home/wmp/skrypty/pobrane/spotify-downloader/Music/Crazy_Town_Lollipop_Porn.mp3
wmp@LUBN366:/tmp/test$

In README.md you write:
The script will automatically look for the best matching song and download it in the folder Music/ placed in your CURRENT directory.

Seems like that text in README.md is misleading, I'll update it. The song will be download in the Music folder placed in the root directory of the code base.

Actually, this would be a nice option to add. Like python3 spotdl.py --target "/path/to/music" -u spotify, probably not too hard to implement (just make an absolute path of the relative one if given and replace "Music/" by the given path). I may open a new issue for this and a PR, which will hopefully be more simple than the last one :wink:

@linusg I agree but first I'd want to switch completely to python 3. Then later of course, we can add all these convenient features! :smile:


Extend JSON3 write method for ACSets

We should add
using JSON3
JSON3.write(io, acs::ACSet; kwargs...) = JSON3.write(io, generate_json_acset(acs); kwargs...)

so that JSON3.write just works for ACSets. The extra level of indirection is useless for most users who aren't debugging serialization code.

I've created PR #79 to add this enhancement.


Rotate an array to the right by 3 position.

add in array folder.
Rotate an array to the right by 3 position.
n<=10

I want to work on this

Hey @akshitagupta15june, can you please assign this issue to me for hecktober?

Hey @akshitagupta15june  i wanna work on this

I want to work on this.Pls assign it to me.

I would like to work on this.

I can do this task in 4 different langs Python, Java, C, Kotlin.
i would I to add the code to your project

I wanted to work on this issue can you please assign it to me for hacktoberfest.

@akshitagupta15june Can you please assign it to me?

I would like to implement this on java. Plz, assign me.

Hello @akshitagupta15june , I would like to work on this issue.


When study is opened, it defaults to the oldest analysis and not the latest

When I make a series of analyses in GEMS1 (naming them QA1, QA2, QA3 in succession), when I go back to the GEMS1 home page and click on the "explore the data" icon, it automatically opens QA1 and not QA3, which was the last analysis I was working on.

This is fixed. Opens to the latest analysis


Working with multi-configuration (matrix) jobs

When working with matrix jobs, where multiple configurations are used to build the code, “Post to Phabricator" is called as soon as the first sub-job is done.  If that job succeeds while other jobs fail, Phabricator still thinks that the whole matrix of build jobs succeed, which is bad.
Is it possible to somehow allow the plugin to notify Phabricator only after all sub-jobs finish?  Something similar to the "Trigger build from child projects" option in the Parameterized Trigger Plugin?
Thanks for your consideration.

Did you came up with a solution?

Did you came up with a solution?


Add options to choose different date ranges to view data in graphs

Currently just shows the current week's data.

[x] Options to view previous week's data
[x] Options to view current month's data
[x] Options to view previous month's data
Option to view custom date range of data

For now I am opting to have the dashboard only be for current and previous week/month. I am going to add custom date ranges when I get to adding the reports feature, though that does not mean I won't add custom date ranges to the dashboard in the future.


[FLINK-14438][core] Fix RowTypeInfo.equals()

What is the purpose of the change
FLINK-14438: Fix RowTypeInfo.equals() to consider field names.
Brief change log

Update hashCode and equals in RowTypeInfo to also consider field names.

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
Unit tests are added to RowTypeInfoTest.java.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@flinkbot run azure


Implement a drain script for postgres 10 properly use the fast shutdown mode

What is this change about?
Here we propose to use SIGINT in order to shut down the Postgres daemon with the Fast Shutdown mode. See the Shutting Down the Server documentation chapter for more details.
This Fast Shutdown mode is implemented here in the drain script.
Please provide contextual information.
While we were upgrading from Postgres v10 to Postgres v13 at SAP, we found out that Postgres 10 was not properly shut down, which leaded to blocking issue with the migration. The error message was “The source cluster was not shut down cleanly”.
When SIGTERM is send to Postgres, the daemon enters the Smart Shutdown mode and can take a while to shut down. In our tests, we stopped waiting after 7 minutes: Postgres hadn't shut down yet!
This explains why the postgres-release is sending a SIGINT at monit stop.
See: https://github.com/cloudfoundry/postgres-release/blob/develop/jobs/postgres/templates/postgres_ctl.sh.erb#L58
This Fast Shutdown mode is implemented here in the drain script. We could not get BPM to properly send a SIGINT because the SIGTERM is hardcoded in the BPM Golang code. An upcoming PR in BPM should address this issue and provide proper configuration for the actual first signal to send to the process.
In its hardcoded shutdown sequence, BPM then sends a SIGQUIT which means “Immediate Shutdown” mode for Postgres. That's where bad things happen, and the cluster state doesn't reach the expected shut down status (see below).
See also https://bosh.io/docs/job-lifecycle/#stop where the hardcoded BPM shutdown sequence is now documented.
What tests have you run against this PR?
When running the pg_controldata utility, the “Database cluster state” is expected to be shut down for the v10-to-v13 migration to succeed.
But with the BPM sequence SIGTERM/15/SIGQUIT/2/SIGKILL, that turns out to be inappropriate for Postgres, we get an unexpected “Database cluster state” of in production. And the migration fails.
Here is how we run the pg_controldata utility:
su - vcap -c "/var/vcap/packages/postgres-10/bin/pg_controldata  -D /var/vcap/store/postgres-10" \
    | grep -F "Database cluster state"

Test sequence:

After implementing the drain script, we could reproduce the issue commenting out our new code and running bosh stop then checking the cluster state with the pg_controldata utility.

After that, when properly running the drain script, we could run bosh stop and then conclude the cluster state was correct with the pg_controldata utility.

How should this change be described in bosh release notes?

Implemented drain scripts for the postgres-9.4, postgres-10 and postgres jobs, in order to implement a proper “fast shutdown” sequence for the Postgres daemon.

Does this PR introduce a breaking change?
No. Just fixes an issue that had been there for a long time.
Tag your pair, your PM, and/or team!
Co-authored-by: Benjamin Gandon

Matthias is going to fix the EasyCLA issue by the way.

Hi, is there any chance to get this merged?

i don't see any breaking changes so for me this can be accepted

Has this change been tested in combination with the director drain script? The workers won't be able to complete their active tasks while Postgres performs a fast stop.

Good catch indeed, this is a concern to take into account. Here is what we've modified:

Remove Postgres drain scripts
Create custom stop scripts to be called at monit stop postgres
Have those custom stop scripts both send a SIGINT and call bpm stop postgres in sequence.

With these changes, we'll leave enough time for the Director drain script to nicely stop the workers and we'll properly stop the database afterwards with the fast shutdown mode.
Then if you want us to rely on pg_ctl instead of killing the process directly, we're open to that either.


Adding light background to the cards on the home page

🚀 Feature
I want to add light background to these cards so that the text and border of the cards and the background image are clearly visible.
I will add a background and keep its opacity low for better viewing.
Kindly assign me this issue as a part of LGMSOC21

There are few open issues regarding the changing of style of the cards @shriya030


Handle uncaught exceptions from vscode-languageserver-node

Currently, if a malformed message is received from any language server then Riju crashes, due to an upstream bug https://github.com/microsoft/vscode-languageserver-node/issues/270. There is a workaround proposed in https://github.com/microsoft/vscode-languageserver-node/issues/270#issuecomment-678961875, which we should implement.

Upstream says the bug is now fixed, I suppose we should upgrade and use the new onError event handler.


Azure Blob Storage paths are not URL-escaped

Bug Report
Import path: github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/container
SDK version: v0.5.1
Go version: go1.18.5 windows/amd64
When opening a blob on Azure Blob Storage with a path that contains a special character (e.g. foo%5Cbar), the path doesn't get properly URL-escaped.  It comes back with a not found error, even though a blob with the specified name actually exists.
For example, this fails:
blobClient := containerClient.NewBlobClient("foo%5Cbar")

But this succeeds:
path := url.PathEscape("foo%5Cbar")
blobClient := containerClient.NewBlobClient(path)

Hi @dgolub ! Thank you for reporting an issue! I just wanted to clarify that in your scenario, the blobname is 'foo%5Cbar', is this correct?

Yes, that's correct.

@dgolub Thank you for your prompt reply! We are working on this and will update this thread when we have additional updates.

Hi @dgolub ! I am not able to reproduce. Could you please share the failure/error you are getting?

I'll just note that the rclone test suite picks up this bug also @siminsavani-msft - its a bug which has been present in Onedrive in the past too! Though I think it is an SDK bug this time since the original Azure blob SDK github.com/Azure/azure-storage-blob-go/azblob does not have this problem.

The fix will roll out in v0.6.0.


Could not resolve all files for configuration ':react-native-video:debugCompileClasspath'

Current behavior
When I run the command ： react-native run-android ,
FAILURE: Build failed with an exception.

What went wrong:
Could not resolve all files for configuration ':react-native-video:debugCompileClasspath'.

Could not find support-compat.jar (com.android.support:support-compat:27.1.1).
Searched in the following locations:
https://jcenter.bintray.com/com/android/support/support-compat/27.1.1/support-compat-27.1.1.jar

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 2s
63 actionable tasks: 1 executed, 62 up-to-date
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/getting-started.html
Reproduction steps
Expected behavior
it should run without any problem
Platform
Which player are you experiencing the problem on:

iOS
Android ExoPlayer
Android MediaPlayer
Windows UWP
Windows WPF

Video sample
If possible, include a link to the video that has the problem that can be streamed or downloaded from.

So I had the same issue while building got resolved it by adding this to the bottom of my android/build.gradle
subprojects {
afterEvaluate {project ->
if (project.hasProperty("android")) {
android {
compileOptions {
sourceCompatibility 1.8
targetCompatibility 1.8
}
}
}
}
}

So I had the same issue while building got resolved it by adding this to the bottom of my android/build.gradle
subprojects {
afterEvaluate {project ->
if (project.hasProperty("android")) {
android {
compileOptions {
sourceCompatibility 1.8
targetCompatibility 1.8
}
}
}
}
}

Didn't work for me. Still having the same error

So I had the same issue while building got resolved it by adding this to the bottom of my android/build.gradle
subprojects {
afterEvaluate {project ->
if (project.hasProperty("android")) {
android {
compileOptions {
sourceCompatibility 1.8
targetCompatibility 1.8
}
}
}
}
}

didnt work...

I get the same issue here after upgrading to RN 0.56->0.57.8 and react-native-video to version 4.

I am getting the same issue when installing fresh

Has anyone been able to solve this issue?

My project:
react-native: 0.59.8
react-native-video: 4.4.1
compileSdkVersion = 28
supportLibVersion = "28.0.0" // updating 27.0.1 => 28.0.0 was the solution for me
// implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"

nu?

put maven { url "https://maven.google.com" } in your build/gradle


Support HTTP2

I'm trying to record/replay requests to Google Cloud APIs, specifically SecretsManager, which apprears to be grpc which is over http2.
Should http2 be working with this library?

Hey, @lox.
No, Interceptors don't support the node:http2 module right now. I gave the docs a quick look and it seems that client/server communication is dramatically different from node:http so our existing interceptors simply won't work.
You can give it a try and help us implement that support though, if you have enough insight into HTTP2 internals in Node.js. It's not on the roadmap otherwise.

No problems @kettanaito, perhaps one day I will, not familiar enough with the internals of http2 right now either.

@lox, let me know if you come to that. We can brainstorm the implementation together.


Make it possible to have files generated outside of the app folder

These changes make it possible to have files generated outside on the app folder.
They also allow namespacing to be as deep as you want something like
php artisan make:repository Path/To/The/Very/Deep/Namespace/You/Wanted/File

would give a namespace of Path\To\The\Very\Deep\Namespace\You\Wanted in FileRepository.php

Does it work now?

It works for our needs but I realise now that this would be a breaking change. I have a compatability fix in mind but will not be able to push this for a couple of days.

I am thinking abour refactoring my repos, so actually we can make it v2.

On 12 Jan 2016, at 19:54, Warrick Hill<EMAIL_ADDRESS>wrote:
It works for our needs but I realise now that this would be a breaking change. I have a compatability fix in mind but will not be able to push this for a couple of days.
—
Reply to this email directly or view it on GitHub.

that would work for us. always nice to have a version bump :+1: