sitecore-jss-react-native depends on unsupported react-native-svg-uri

Description
react-native-svg-uri was last published 5 years ago and uses deprecated react features.
Expected behavior
sitecore-jss-react-native should work with current react-native versions
Steps To Reproduce
npx create-sitecore-jss react-native and attempt to run with yarn start-ios
Possible Fix
Newer versions of react-native-svg now have similar functionality built in so it would be preferable to use that instead.
Your Environment

Sitecore Version: All
JSS Version: 21.0.0-canary.111
Browser Name and version: N/A
Operating System and version (desktop or mobile): Mobile
Link to your project (if available):

Screenshots

Thank you for reporting it, and especially for the PR request follow up!
We are currently planning a more expanded update and refresh to React Native JSS (in the scope of the next major release). React native svg should be updated along with some other libraries as a part of it, so we will post in this thread once that is done.

I should update this. Unfortunately the react-native work has been postponed by other features and tasks.
Currently no ETA on when this might be implemented, as react-native remains in "experimental" support for the time being.


Add --load-restrictor flag to Kustomize build

Adds --load-restrictor=LoadRestrictionsNone to the Kustomize build to allow Kustomizations to read files outside of the root directory
Adds e2e test coverage for the change by modifying existing e2e hydration test data
Modifies install-kustomize.sh to make sure Kustomize is executable
b/342237927

@tiffanny29631  Sure, done

/ok-to-test

Yup! It was done in https://github.com/GoogleContainerTools/kpt-config-sync/pull/1243

/retest

/retest


fix: filter invalid events in consolelogger

:tada: This PR is included in version 2.30.2 :tada:
The release is available on:

v2.30.2
v2.30.2
GitHub release

Your semantic-release bot :package::rocket:


process excel files

Note that if layer name is declared all sheets will get merged into a single table.

@cmclscourtney Good spot, did setting the layer to null fix that

@cmclscourtney Good spot, did setting the layer to null fix that

It did but I took it out since it would be nice to be able to have the option of renaming if you only have one sheet. For instance a lot of UKPN open data has a single sheet call "Data" and that could conflict if that becomes the name of the table


document and refactor main transpiler into markdown

move code from .py source files into multiple markdown files. refactor rusthon.py to load the markdowns instead of importing pythonjs.

multi-markdown is now working
https://github.com/rusthon/Rusthon/wiki/Multiple-Markdowns

almost everything has been removed from the pythonjs folder and converted into markdown in the src folder.
TODO: documentation


Added the ability to activate promotion from the UI

Added the ability to activate promotion from the UI

Codecov Report

Merging #74 (503ea23) into main (9a8077f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   96.40%   96.40%
=======================================
  Files           7        7
  Lines         278      278
=======================================
  Hits          268      268
  Misses         10       10

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


#Support : Way to get batch messages and commit if the batch is successful

There doesn't seems a way to  implement the below flow

Read batch messages from Kafka.
Process all the messages.
If all messages processing succesful - Commit the offset
If any of the message processing fails - Do not commit the offset and read the same batch again and try to process the messages and if successful commit the offset.

Unfortunately, there isn't, at least not easily. That's why I have put a lot of effort into https://github.com/Shopify/sarama/pull/1099 :) This repo is going to be deprecated in favour of the latest sarama release.


get user confirmation before setting execution policy in RunSamples.cmd

Set-ExecutionPolicy is used in RunSamples.cmd and it changes the user preference for the Windows PowerShell execution policy. A warning has to be displayed to the user and execution policy should be updated only upon confirmation from the user. If it is possible to check the execution policy prior to doing anything regarding that, it would be preferable.

This can be done as easy as add -Confirm parameter to Set-ExecutionPolicy
However, I find that the only PS script run in the this cmd file is downloadtools.ps1, if this is the case it would be better to set ExecutionPolicy when invoke the script without altering the registry settings, i.e.
powershell -ExecutionPolicy Unrestricted -File downloadtools.ps1 run !VERBOSE!

Thanks @ohwang . I like the second option.

@ohwang suggestion added to the script.


Remove TweetReceived.EndpointName

I don't think it's required since both endpoints have the same name.

We should do https://github.com/Particular/HashBus/issues/105 first


update readme for C submodule

Yes that's better. The C submodule should be doable to keep fully auto-generated. For the rest I'm not so sure yet, perhaps only as a bootstrap.
Ignore Travis, I just turned it on because I'm working on #4


Automatically grantRead for apiKeySecretArn

Currently, the documentation mentions that you have to remember to manually grant GetSecretValue when passing the API key as an ARN: https://github.com/DataDog/datadog-cdk-constructs/blob/8ffefd8dd5432805de312ade0f60d1015682b123/README.md#L175
It would be nice if this construct did it for you.
Instead of passing a secret arn string:
new Datadog(scope, 'Datadog', {
  apiKeySecretArn: 'arn:aws:secretsmanager:us-west-2:12345678910:secret:DATADOG_API_KEY'
});

If the user could pass an ISecret:
const secret = Secret.fromSecretPartialArn(this, 'DatadogApiKeySecret', 'arn:aws:secretsmanager:us-west-2:12345678910:secret:DATADOG_API_KEY');
new Datadog(scope, 'Datadog', {
  apiKeySecret: secret
});

Then, in the construct, you could grantRead for us:
apiKeySecret.grantRead(lambda)

Hi @blimmer thanks for this suggestion. We're going to work on implementing this and I will leave this ticket open for tracking

Btw, this is made worse by the fact that the extension doesn't tell you clearly that you're missing this permission: https://github.com/DataDog/datadog-agent/issues/16927

Hi @blimmer, we've implemented this feature and it has been included in the most recent v2-1.7.0 release (pypi, npm).
We're working on getting the associated docs changes merged, but in the meantime here's an example of how to use it (just like what you suggested):
const { Secret } = require('aws-cdk-lib/aws-secretsmanager');
const secret = Secret.fromSecretPartialArn(this, 'DatadogApiKeySecret' 'arn:aws:secretsmanager:us-west-1:123:secret:DATADOG_API_KEY');

const datadog = new Datadog(scope, 'Datadog', {
  ...
  apiKeySecret: secret
  ...
});

Thanks for your suggestion, please let me know if you've got any questions!


Text API

A proposal for the text API.
Interesting links (for inspiration):

https://www.npmjs.com/package/troika-three-text
https://github.com/almarklein/visvis/wiki/Text
https://vispy.org/api/vispy.visuals.text.text.html

General discussion
Which props belong on the world-object, and which on the material? ThreeJS' troika has everything at the Object3D and uses a modified mesh material. Initially I liked the idea of putting most props on the material, since they affect how the text is rendered. But most of these props affects the positioning of the text, so they feel quite "structural".
Alternative 1
A Text wobject and corresponding material. Not sure how to to bold/italic unless it is applied to the whole text.
class Text(WorldObject), with properties:

text
font: the name of a builtin or system font, or a path to a font file
font_size
color
anchor_x
anchor_y
angle
max_width: if text goes beyond this, it will wrap
line_height
text_align

class TextMaterial(Material), with properties:

color

Maybe this could be a MeshMaterial ...
Alternative 2
To have better support for formatting, we could introduce an object to hold a piece of text plus its formatting. We can then provide ways to generate these easily from e.g. Markdown, HTML or Latex.
class TextPiece, with properties:

text: the Unicode text
font
font_size
weight: bold, normal, etc.
italic

We could have e.g. a MathTextPiece that has its own specific font and shaper, based on Latex input. Or a MusicalNotesTextPiece, if someone wants to go crazy. Bottom line is that with this we solve the "itemization" step, and that the TextPiece is responsible for the shaping. In comes Unicode, out come font indices and (relative) vertex positions.
class Text(WorldObject), with properties:

pieces: a list of TextPiece objects.
text: shortcut to create a single text piece.
markdown: shortcut to create simple formatted text.
html: shortcut to create somewhat more advanced formatted text (e.g. <small> etc.)

... rest the same as alternative 1.
Alternative 3
The geometry consists of an array of TextPiece objects. We have some functions to generate it.
text = Text(
    gfx.text_geometry(markdown="hello **world**"),
    gfx.TextMaterial(...)
)

All props go on the material (except the specifics for the TextPiece). The buffers with positions and atlas indices are private.
Alternative 4
The geometry consists of the actual positions and atlas indices, and we have functions to generate it. The code sample is the same as above, except now TextPieces are an internal construct, and the text_geometry function has arguments for all "properties" that affect positioning (e.g. text_align). In effect the material is "clean" and you can always put a different material on the same geometry without incurring unexpected CPU processing.
This is actually quite clean. The only downside that I see now, is that users may be a bit confused why some aspects are set as arguments in text_geometry and some as material properties.

What data would be stored in the geometry buffers, and what data would go into the material properties?
The world object's core role is transformation.

Okay, let's write out what we need for rendering:

A texture for the atlas (this one is global to the device/application).
A buffer with texcoords, or maybe just 1D integer indices into the atlas. One per text object.
A buffer with positions (a quad for each glyph). One per text object.

These could be exposed/public, but we could also hide them (consider them an implementation detail).
Now, let's see how the different properties affect these data. These properties affect the glyph, thus the content of the atlas:

the text itself
font
weight: bold, normal, etc.
italic

These properties relate to positioning and layout, so they change the positions buffer during the pre-processing:

max_width: if text goes beyond this, it will wrap
line_height
text_align

I think we can handle these props in the shader, so they can be uniforms:

font_size (font size for the whole object)
anchor_x
anchor_y
angle

And of course this one can be a uniform :)

color

What data would be stored in the geometry buffers, and what data would go into the material properties?

I'd consider the text or text pieces (or maybe TextItems is a nicer name) the "geometry" or source data. If we place most properties on the material - which makes sense IMO - I think it would be better to hide the position and texcoord buffers, because it would be weird if changing the material affected the public geometry.

What computations have to run as preprocessing, and which ones run on the GPU at runtime?

Selecting the glyph, calculating the SDF, determining the relative positions of the glyph are all done on the CPU. The positioning that applies to the whole text object (like the anchor and size, can be done in the vertex shader.

Note: I don't support adding properties to world object, it's important to be able to share geometry and materials between world objects. This also goes for text.

Yeah, right now none of our world objects have properties beyond that of the base (only the InstancedMesh has a method).

Imagine a scene where a bit of text keeps coming back in different locations. I want to create the geometry and material once (performs any expensive preprocessing?), and add it to the scene multiple times via world objects.

Good point. If we are careful, taking into account which props change the internal buffers, we can even re-use the internal buffers for objects that have the same geometry, but a different material.

I added two more alternatives in the top post. I like alternative 4, and I have a feeling you might too :)

I really do like #4 :)

only downside that I see now, is that users may be a bit confused why some aspects are set as arguments in text_geometry and some as material properties

You could see this as an upside too: it communicates to users which arguments affect what (material or geometry).

There is a use-case that our current API choice does not really support. Consider a piece of text that changes quickly (e.g. an FPS counter), or pieces of text that appear/disappear quickly (like ticks). It would potentially hurt performance in a significant way if these changes required new pipeline compositions. I wonder if we can somehow avoid that.

Can you explain why?

I don't fully understand why you couldn't update an existing geometry object?

My point is that with the API that we've come up with so far does not allow updating the text anywhere :) A solution could indeed be to make this possible. This is a bit tricky though, because the number of glyphs cannot be increased (I guess we can reduce it by ignoring unused glyph slots).

Looks like one of the reference implementations we linked above in this thread also goes the route of updating geometries:

https://github.com/protectwise/troika/blob/main/packages/troika-three-text/src/GlyphsGeometry.js


Fixed integration tests run

Here's an error: https://gitlab.parity.io/parity/substrate/-/jobs/160376.
I guess it just hasn't been updated in #2752

Please approve this one: https://github.com/paritytech/substrate/pull/2842


Fix C++11 to use set_directory_properties

Avoids corrupting CMAKE_CXX_FLAGS for catkin_make users.

I've now merged this, thanks!


OASIS-25850: Fix incomplete replacing of projection variables in traversals

Scope & Purpose
Backport of https://github.com/arangodb/arangodb/pull/21078 & https://github.com/arangodb/arangodb/pull/21083
Fixes https://arangodb.atlassian.net/browse/OASIS-25850
Enterprise companion PR: https://github.com/arangodb/enterprise/pull/1497
Replace additional variables in various members of TraversalNode, EnumeratePathsNode and ShortestPathNode for the projection optimization.
Also fix variable replacement in filter conditions inside EnumeratePathsNode for filters of type FILTER p.edges[*].value ALL op value. Previously this only supported filters of type FILTER p.edges[* RETURN ...] op value and ran into exceptions "unsupported node type no-op" with the other form.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[x] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.12.0: -
[ ] Backport for 3.11: -
[ ] Backport for 3.10: -

Related Information

[ ] Docs PR:
[x] Enterprise PR: https://github.com/arangodb/enterprise/pull/1497
[ ] GitHub issue / Jira ticket:
[ ] Design document:

Will be added directly to devel and then 3.12.1.


gam report docs no longer working

The "gam report docs" command no longer works, it gives the following error "Error: Parameter "applicationName" value "docs" does not match the pattern "(admin)|(calendar)|(drive)|(login)|(token)"
"
The suggested command of "gam report drive" shows "Got 0 items"

The docs report was deprecated by Google and no longer available. The drive report requires Google Apps Unlimited or EDU in order to retrieve. Closing this as working as intended.

@jay0lee Is this still the case? "The drive report requires Google Apps Unlimited or EDU in order to retrieve".
Respectfully, Jim

Jim,
See: https://developers.google.com/admin-sdk/reports/v1/guides/prerequisites
It says The Reports API applies to G Suite Basic, Education, and Government
accounts.
Ross
On Mon, Feb 26, 2018 at 1:23 PM, jimwest405<EMAIL_ADDRESS>wrote:

@jay0lee https://github.com/jay0lee Is this still the case? "The drive
report requires Google Apps Unlimited or EDU in order to retrieve".
Respectfully, Jim
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jay0lee/GAM/issues/68#issuecomment-368655439, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIU8L8Dzh8-u-VJR8KSFqQQNTe7VNDDTks5tYyDngaJpZM4Eu8qU
.

--
Ross Scroggs
<EMAIL_ADDRESS>


Adding a new section to demonstrate Pandas table joins

Added a new section 5 to describe how to do Pandas table join between a user-created table and the DP0.3 retrieved table.

Thank you @MelissaGraham for your feedback.
Regarding your last suggestion: how about replacing the current plot with a new plot comparing the orbital parameters from the Gaia table and the MPCORB table for the merged table?

Thank you @MelissaGraham for your feedback.
Regarding your last suggestion: how about replacing the current plot with a new plot comparing the orbital parameters from the Gaia table and the MPCORB table for the merged table?

That sounds like a good demo!

@MelissaGraham I implemented all your feedback and took a workaround by using fullDesignation instead of mpcDesignation for table joins. The NB is ready for the final review.


Actions.currentRouter.currentRoute is not updated

Hi,
I'm having a strange issue, whenever I try to get the current route name from Actions.currentRouter.currentRoute I get the previous outdated route.
The strange thing is that if I check currentRoute of Actions.currentRouter in the developer console I can see the correct route.
function onEnterHandler() {
  console.log(Actions.currentRouter)
  console.log(Actions.currentRouter.currentRoute)
  return true
}

export default class Routes extends React.Component {
  render() {
    return (
      <Router sceneStyle={{ paddingTop: topPadding }}
        onPop={onEnterHandler}
        onReplace={onEnterHandler}
        onPush={onEnterHandler}
      >
        <Route
          name='session'
          component={SessionScreen}
          type="replace"
          initial={true}
        />
        <Route
          name='place'
          component={PlaceScreen}
          type="replace"
          title='Ristoranti'
        />
      </Router>
    )
  }
}

The result from the logging when I navigate to the place route from the session route is the following:

As you can see the log of Actions.currentRouter shows the correct currentRoute, while Actions.currentRouter.currentRoute show the outdated one.
I even tried checking the currentRoute from different places (e.g.: componentDidMount) and components with different Actions (pop/replace) but the issue persist.
Thank you in advance,
Matteo.

I'm having the same problem.

I've noticed this during an onPop event too. Maybe that's what is happening here - at the time of the console.log call, the route state hasn't been updated. But when you check the dev console it appears correctly.

I've found a workaround: you can use the navigationContext of the React-Native Navigator to get the current route from the component itself.
componentWillMount() {
  const navigationContext = this.props.route.parent.delegate.refs.nav.navigationContext
  console.log(navigationContext)
  navigationContext.addListener('didfocus', event => {
    console.log(navigationContext.currentRoute.name) // This is the current focused route
  })
}

You can find info about the listenere here.
The listener is called on every route change, which means that if you need to know if the component is the focused one you can do something like this in the listener callback (and you can update the state in redux/flux here too):
const isComponentFocused = navigationContext.currentRoute.name === 'componentName'

It worked fine for me so far, but it doesn't seem to be an optimal solution  in my opinion because you need to dig deep to find the navigationContext and also for the same reasons stated by @lynndylanhurley in the issue #158
Related issues:
#158 #78

Please check 2.2.0 version and its Example

Thank you for the new version aksonov! (And also thank you for the awesome work you're doing with this router).
The Redux support seems to be working, now I can update my store currentRoute from my own reducer:
case Actions.AFTER_ROUTE:
case Actions.AFTER_POP:
  return state.set('currentRoute', action.name)

...but I'm still trying to find out the best way to handle the currentRoute information from a component.
For example:
I have a component that shows a list of items fetched from a server.
I need to trigger the server request (update the list) when the component is focused.
componentDidMount is not the right place, because I need to trigger the request on POP too.
What I'm doing at the moment is using the didFocus listener like in my previous comment:
componentWillMount() {
  const navigationContext = this.props.route.parent.delegate.refs.nav.navigationContext
  console.log(navigationContext)
  navigationContext.addListener('didfocus', event => {
    console.log(navigationContext.currentRoute.name) // This is the current focused route
  })
}

Am I missing something? Does anyone know an alternative solution?
(maybe #158 is a better place for talking about this)

@mmazzarolo Hm... If you can change redux state with currentRoute, what problem to pass this state to the component? It is Redux, isn't?

Yes, it's Redux.
You mean something like changing the state (i.e.: setting justFocused to true) and catching the state change from the component in componentDidUpdate/componentWillUpdate and trigger the fetching?
I thought about it at first but it just didn't seem the optimal solution... but it's still probably better than the above solution.

Maybe the component could call something like routeDidFocus (if it exists)? Maybe you could submit PR (just add that listener to ExRouter?)

Did it this way (using Redux):
1. Connect the Router with Redux and before using it
import ReactNativeRouter, { Route } from 'react-native-router-flux'
const Router = connect()(ReactNativeRouter.Router)

Now when you use a <Router> it will be connected to the store and trigger the following actions:

Actions.BEFORE_ROUTE
Actions.AFTER_ROUTE
Actions.AFTER_POP
Actions.BEFORE_POP
Actions.AFTER_DISMISS
Actions.BEFORE_DISMISS

Take a look at this for an example.
2. Catch the interested actions in your reducer
I have a global reducer (where I keep the information needed by all my app) where I set the currentRoute.
case Actions.AFTER_ROUTE:
case Actions.AFTER_POP:
  return state.set('currentRoute', action.name)

Now global.currentRoute will always have the currently focused route.
3. Update your component on focus
I'm doing it on componentDidUpdate of my payment component.
If global.currentRoute is payment and the previous global.currentRoute was different that the component has just been focused.
  componentDidUpdate(prevProps) {
    const prevRoute = prevProps.global.currentRoute
    const currentRoute = this.props.global.currentRoute
    if (currentRoute === 'payment' && prevRoute !== currentRoute) {
      this.props.actions.doSomething()
    }
  }

@mmazzarolo Looks very good, could you add it to README and i will close this issue

Of course, I'll do it this after work.

Very good and easy solution to implement! @mmazzarolo Thanks for doing this, I was trying to find a "good" way of doing this exact thing for a while.

@jamesone for some reason I can't get this to work. Did you get it working with the latest rnrf version?


⚠ AGEG website (redirect) has degraded performance

In 889f190, AGEG website (redirect) (https://ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2071 ms

Resolved: AGEG website (redirect) performance has improved in a2b3f21.


[pinmux/dif] Rebase pinmux init code atop the DIFs

Also update the checklist.

Also, you could mark this line as Done, since almost every chip-level test uses the test ROM which uses the pinmux :).

Added a first commit to fix up some bazel deps.

Added a first commit to fix up some bazel deps.

...and split it off into another PR so that could get merged immediately.


Wakeword detection is looping...

Hi there,
I'm really not sure why but for some reason, when a wakeword is detected (tried Alexa, Hey Mycroft and Hey Jarvis), the wakeword detection keeps looping very randomly.
I don't have any special noise around. Here are two videos:
https://github.com/dscripka/openWakeWord/assets/614115/da4cadcf-1a78-4425-939c-af21a9ca7cd7
https://github.com/dscripka/openWakeWord/assets/614115/37659ea2-0275-4fd5-a688-6abbfebb2539

Are you using openWakeWord in OVOS, by chance (since it looks like you are using Mycroft hardware)? If so, are you using this plugin? There is some logic in this plugin to clear out buffers and avoid looping detection like this, but perhaps something isn't working.
If you aren't using the plugin in OVOS, and instead are using custom code, you'll need to either continue feeding in audio after the activation (the recommended approach) and just ignore any detections until you are ready to accept them again, or manually clear the audio buffers.

@dscripka Yes I'm using a Mark II device with OVOS and the plugin your linked.

The plugin currently has the buffer clearing functionality in place, so it should work.
And I do try and track that plugin and make sure it works with correctly with openWakeWord; not sure why it isn't working now. Are you perhaps running a newer version of OVOS?

And I do try and track that plugin and make sure it works with correctly with openWakeWord; not sure why it isn't working now. Are you perhaps running a newer version of OVOS?

I'm using the dev branch https://github.com/OpenVoiceOS/ovos-dinkum-listener

@dscripka I will let the ovos-installer keep installing the ovos-ww-plugin-openWakeWord plugin but will not enable it by default (which was my initial plan), this will be a user decision.
I will close the issue for now, feel free to re-open it if you want me to run some tests. :+1:


[FEATURE] Add husky

Description
We're getting inconsistent code formatting when new PRs are created, and it makes reviewing new changes difficult. With husky, we can set up a git pre-commit hook for formatting code with prettier to ensure consistent code formatting.
Screenshots
No response

It's great having you contribute to this project by creating an issue Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community :nerd_face:

Yeah I can just repeat the same husky used in code Magic


Update README.md

I thought it might be a good idea to explain in the examples that you can (and in my experience, have to, but I could be wrong) send the acces_token along as a parameter when you call an endpoint. When I first tried doing it as explained in the README I got stuck because it expected you to provide an access token when creating the Instagram instance. Yet, first you have to get an access_token from the user, and to get this, you already need to have an instance of Instagram so that you can call instagram.getAuthorizationUrl. Putting the access_token in the endpoint examples might help people understand this process better.

Coverage remained the same at 100.0% when pulling cd7579897ec533ca688c2fcc66cfd80a5a250925 on khendrikse:master into 991b3a78a79a3d0f54911d40314a36814d45b279 on pradel:master.

That's a great idea thank you!
Maybe instead of modify all examples we can add one more with the explanation you provided for the pr description?

That would also be a great idea! Thank you!
Met vriendelijke groet,
Karin Hendrikse
2017-12-04 20:05 GMT+01:00 Léo Pradel<EMAIL_ADDRESS>
That's a great idea thank you!
Maybe instead of modify all examples we can add one more with the
explanation you provided for the pr description?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pradel/node-instagram/pull/25#issuecomment-349070263,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdKTE_qTvOD-_S6rT3yz-f02roUbEOFNks5s9EKKgaJpZM4QzX1K
.

Do you want to update or create a new pr?


Create new variable for asset type from ftrack

Brief description
Create a new variable named asset[type] for templates in project settings. This variable is based on AssetBuild type from ftrack.

Hi, thanks for the PR, we would like to make this change too, but the change is not as easy as just these lines. All templates and places in code, that are using these data, must be prepared for this data structure change first, before any change of structure will happen. All the code must be backwards and forwards compatible so it does not matter what data are passed in or what template is passed in. We did it the same way with tasks.
As you can imagine that is a lot more job then few lines of code. We will have to do it, but it will probably happen before AYON release. At this moment we don't have capacity to make the changes, or do review of those changes. This is massivelly affecting every aspect of pipeline which is crutial to work and is important for use to not break productions.
If you would like to handle only the Asset Build from ftrack, it could be possible. I didn't test it, or looked into it closer, because of the changes in template data, so I don't know if the changes are right.
If you have opinions, write them down. For now the PR can be considered as on hold, and may be closed over time.

I found the PR for adding tasks, even if it is dated, it gives an idea of the work to be done.
https://github.com/ynput/OpenPype/pull/2157

This is really tricky. Cannot be merged in this state for the reasons state by Jakub and at the same time with AYON being almost done, it's a bit of a wasted effort.
We won't be able to give it resources to properly test all the scenarios this might break at the moment. Sorry @ClementHector but I don't see how we could get this in at this point.

No problem, we'll keep that to ourselves before moving on to Ayon :)


services.exe is polling registry

It seems PH is causing services.exe to poll ObjectNames for all services in quick succession.
HKLM\System\CurrentControlSet\Services<service>\ObjectName
The services.exe consumes 0.2% CPU on a fast notebook, and 2% in a VM environment.
Tried to disable all notifications in View->Tray Icons->Notifications to no effect. Exiting PH stops polling.
(Win 6.2.9200 and 6.3.9600)

EnableServiceNonPoll seem to solve the issue.
Thank you!


(PUP-8227) puppet apply/resource should not overwrite transactionstore

In the past enforcing change using "puppet apply" or "puppet resource"
would cause the transactionstore.yaml file to be overwritten. This
happened because persistence was enabled regardless of how
puppet was being run.
This commit adds the enabled? method to Transaction::Persistence which
now checks how puppet is being run to determine if persistence should be
enabled, which means we no longer overwrite transactionstore.yaml
during a "puppet apply" or "puppet resource" run.

CLA signed by all contributors.

Looks good to me.


Support both vertical and horizontal gestures at the same time

Instagram Stories allow you to move the page along both directions. Can we have the same too? Thanks

Thank you very much.

Note that scrollable widget inside DismissiblePage might limit the functionality.

If scroll direction matches DismissiblePage direction

What Instagram does is, if the scrolling widgets scroll position is not on the start position, swipe gestures keeps on scrolling the inner scroll.
If the scroll position is on start, then the page dismiss happens.
I want to try to achieve this, I know it is not the responsibility of this package but it is a common use-case.
Do you have any suggestions on how this could be done @Tkko ?

I'd love to implement that functionality as well, Airbnb app does it perfectly. If you manage to replicate it please let me know.
DraggableDismissibleSheet is doing kinda similar thing for reference.
Thank you for asking, I'm safe for now, well, until Putin decides to occupy Georgia (my country) again 😡

Do you mean DraggableScrollableSheet?
I could not find any info on DraggableDismissibleSheet?

Do you mean DraggableScrollableSheet?
I could not find any info on DraggableDismissibleSheet?

Ahh Yes, it's DraggableScrollableSheet.


Error: Set cross-namespace owner are disallowed

Describe the bug
The modelmesh controller is trying to set owner reference for resources outside of the current namespace.
{"level":"error","ts":1660671661.3458428,"logger":"controller.ServiceReconciler","msg":"Reconciler error","reconciler group":"apps","reconciler kind":"Deployment","name":"wmlserving-controller","namespace":"wo-nba","error":"could not set Service owner reference: cross-namespace owner references are disallowed, owner's namespace argo-wo, obj's namespace wo-nba","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":1660671661.352311,"logger":"controller.ServiceReconciler","msg":"Reconciler error","reconciler group":"apps","reconciler kind":"Deployment","name":"router-default","namespace":"openshift-ingress","error":"could not set Service owner reference: cross-namespace owner references are disallowed, owner's namespace argo-wo, obj's namespace openshift-ingress","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:227"}

To Reproduce
Steps to reproduce the behavior:
Deploy the default model mesh controller and you will see the error in the model mesh controller pod
Expected behavior
Should only looking for current name space resources.
Screenshots

Environment (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context

The error went away when i set the NAMESPACE_SCOPE to False, so i suspect if this block of code should be if not r.NamespaceOwned https://github.com/kserve/modelmesh-serving/blob/b79d771fe43b72cbba1f0fcdf052917761c6ac6a/controllers/service_controller.go#L130-L170

@gaodan-fang hopefully this should be addressed by https://github.com/kserve/modelmesh-serving/pull/212.

@njhill thanks for addressing the issue!

Closing since this should be fixed per above, @gaodan-fang please feel free to reopen if it's still a problem.


maximum recursion depth exceeded while calling a Python object

I've successfully created a cluster and migrated my existing data into it. It works fine.
Now I want to setup the backup, and there I've run into an issue.
I've configured a Minio endpoint, which is in my local network.
The error I got is:
ERROR: Barman cloud WAL archive check exception: maximum recursion depth exceeded while calling a Python object

The complete log:
{"level":"info","ts":"2023-03-11T22:18:10Z","logger":"postgres","msg":"record","logging_pod":"dsmr-reader-2","record":{"log_time":"2023-03-11 22:18:10.989 UTC","process_id":"40873","connection_from":"<IP_ADDRESS>:34668","session_id":"640cfe22.9fa9","session_line_num":"1","session_start_time":"2023-03-11 22:18:10 UTC","transaction_id":"0","error_severity":"LOG","sql_state_code":"XX000","message":"could not accept SSL connection: Success","backend_type":"not initialized","query_id":"0"}}
{"level":"info","ts":"2023-03-11T22:18:32Z","logger":"postgres","msg":"record","logging_pod":"dsmr-reader-2","record":{"log_time":"2023-03-11 22:18:32.370 UTC","process_id":"25","session_id":"640b3ed2.19","session_line_num":"95","session_start_time":"2023-03-10 14:29:38 UTC","transaction_id":"0","error_severity":"LOG","sql_state_code":"00000","message":"checkpoint starting: time","backend_type":"checkpointer","query_id":"0"}}
{"level":"info","ts":"2023-03-11T22:18:42Z","logger":"wal-archive","msg":"barman-cloud-check-wal-archive checking the first wal","logging_pod":"dsmr-reader-2"}
{"level":"info","ts":"2023-03-11T22:18:45Z","logger":"postgres","msg":"record","logging_pod":"dsmr-reader-2","record":{"log_time":"2023-03-11 22:18:45.766 UTC","process_id":"25","session_id":"640b3ed2.19","session_line_num":"96","session_start_time":"2023-03-10 14:29:38 UTC","transaction_id":"0","error_severity":"LOG","sql_state_code":"00000","message":"checkpoint complete: wrote 105 buffers (0.6%); 0 WAL file(s) added, 0 removed, 1 recycled; write=11.739 s, sync=1.206 s, total=13.397 s; sync files=47, longest=0.180 s, average=0.026 s; distance=16464 kB, estimate=29830 kB","backend_type":"checkpointer","query_id":"0"}}
{"level":"info","ts":"2023-03-11T22:18:47Z","logger":"barman-cloud-check-wal-archive","msg":"2023-03-11 22:18:47,651 [40894] ERROR: Barman cloud WAL archive check exception: maximum recursion depth exceeded while calling a Python object","pipe":"stderr","logging_pod":"dsmr-reader-2"}
{"level":"error","ts":"2023-03-11T22:18:48Z","logger":"wal-archive","msg":"Error invoking barman-cloud-check-wal-archive","logging_pod":"dsmr-reader-2","currentPrimary":"dsmr-reader-2","targetPrimary":"dsmr-reader-2","options":["--endpoint-url","http://********","--cloud-provider","aws-s3","s3://backup/postgres","dsmr-reader"],"exitCode":-1,"error":"exit status 4","stacktrace":"github.com/cloudnative-pg/cloudnative-pg/pkg/management/log.(*logger).Error\n\tpkg/management/log/log.go:127\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/barman/archiver.(*WALArchiver).CheckWalArchiveDestination\n\tpkg/management/barman/archiver/archiver.go:257\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/walarchive.checkWalArchive\n\tinternal/cmd/manager/walarchive/cmd.go:383\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/walarchive.run\n\tinternal/cmd/manager/walarchive/cmd.go:169\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/walarchive.NewCmd.func1\n\tinternal/cmd/manager/walarchive/cmd.go:81\ngithub.com/spf13/cobra.(*Command).execute\n\tpkg/mod/github.com/spf13/cobra@v1.6.1/command.go:916\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\tpkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044\ngithub.com/spf13/cobra.(*Command).Execute\n\tpkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968\nmain.main\n\tcmd/manager/main.go:64\nruntime.main\n\t/opt/hostedtoolcache/go/1.19.5/x64/src/runtime/proc.go:250"}
{"level":"error","ts":"2023-03-11T22:18:48Z","msg":"while barman-cloud-check-wal-archive","logging_pod":"dsmr-reader-2","error":"unexpected failure invoking barman-cloud-wal-archive: exit status 4","stacktrace":"github.com/cloudnative-pg/cloudnative-pg/pkg/management/log.(*logger).Error\n\tpkg/management/log/log.go:127\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/log.Error\n\tpkg/management/log/log.go:165\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/walarchive.checkWalArchive\n\tinternal/cmd/manager/walarchive/cmd.go:384\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/walarchive.run\n\tinternal/cmd/manager/walarchive/cmd.go:169\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/walarchive.NewCmd.func1\n\tinternal/cmd/manager/walarchive/cmd.go:81\ngithub.com/spf13/cobra.(*Command).execute\n\tpkg/mod/github.com/spf13/cobra@v1.6.1/command.go:916\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\tpkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044\ngithub.com/spf13/cobra.(*Command).Execute\n\tpkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968\nmain.main\n\tcmd/manager/main.go:64\nruntime.main\n\t/opt/hostedtoolcache/go/1.19.5/x64/src/runtime/proc.go:250"}
{"level":"error","ts":"2023-03-11T22:18:48Z","logger":"wal-archive","msg":"failed to run wal-archive command","logging_pod":"dsmr-reader-2","error":"unexpected failure invoking barman-cloud-wal-archive: exit status 4","stacktrace":"github.com/cloudnative-pg/cloudnative-pg/pkg/management/log.(*logger).Error\n\tpkg/management/log/log.go:127\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/walarchive.NewCmd.func1\n\tinternal/cmd/manager/walarchive/cmd.go:83\ngithub.com/spf13/cobra.(*Command).execute\n\tpkg/mod/github.com/spf13/cobra@v1.6.1/command.go:916\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\tpkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044\ngithub.com/spf13/cobra.(*Command).Execute\n\tpkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968\nmain.main\n\tcmd/manager/main.go:64\nruntime.main\n\t/opt/hostedtoolcache/go/1.19.5/x64/src/runtime/proc.go:250"}
{"level":"info","ts":"2023-03-11T22:18:48Z","logger":"postgres","msg":"record","logging_pod":"dsmr-reader-2","record":{"log_time":"2023-03-11 22:18:48.139 UTC","process_id":"38111","session_id":"640ceefa.94df","session_line_num":"113","session_start_time":"2023-03-11 21:13:30 UTC","transaction_id":"0","error_severity":"LOG","sql_state_code":"00000","message":"archive command failed with exit code 1","detail":"The failed archive command was: /controller/manager wal-archive --log-destination /controller/log/postgres.json pg_wal/00000004000000000000007E","backend_type":"archiver","query_id":"0"}}

I wonder if anyone could help me with this.
If there are more details required, let me know, so I can provide them.

Hi, similar issue popped up for me, when trying to bootstrap a new cluster from a backup. Im using azure tho. Pasting my log output, hopefully it helps:
{"level":"info","ts":"2024-03-20T09:31:11Z","msg":"barman-cloud-check-wal-archive checking the first wal","logging_pod":"cloudnative-restore-cluster-1-full-recovery"}
{"level":"info","ts":"2024-03-20T09:31:28Z","logger":"barman-cloud-check-wal-archive","msg":"2024-03-20 09:31:28,544 [13] ERROR: Barman cloud WAL archive check exception: maximum recursion depth exceeded while calling a Python object","pipe":"stderr","logging_pod":"cloudnative-restore-cluster-1-full-recovery"}
{"level":"error","ts":"2024-03-20T09:31:28Z","msg":"Error invoking barman-cloud-check-wal-archive","logging_pod":"cloudnative-restore-cluster-1-full-recovery","currentPrimary":"","targetPrimary":"cloudnative-restore-cluster-1","options":["--cloud-provider","azure-blob-storage","https://***********.blob.core.windows.net/cloudnative-pg/","cloudnative-restore-cluster"],"exitCode":-1,"error":"exit status 4","stacktrace":"github.com/cloudnative-pg/cloudnative-pg/pkg/management/log.(*logger).Error\n\tpkg/management/log/log.go:128\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/barman/archiver.(*WALArchiver).CheckWalArchiveDestination\n\tpkg/management/barman/archiver/archiver.go:257\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/postgres.(*InitInfo).checkBackupDestination\n\tpkg/management/postgres/restore.go:868\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/postgres.InitInfo.Restore\n\tpkg/management/postgres/restore.go:236\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/instance/restore.restoreSubCommand\n\tinternal/cmd/manager/instance/restore/cmd.go:87\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/instance/restore.NewCmd.func2\n\tinternal/cmd/manager/instance/restore/cmd.go:60\ngithub.com/spf13/cobra.(*Command).execute\n\tpkg/mod/github.com/spf13/cobra@v1.8.0/command.go:983\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\tpkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1115\ngithub.com/spf13/cobra.(*Command).Execute\n\tpkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1039\nmain.main\n\tcmd/manager/main.go:64\nruntime.main\n\t/opt/hostedtoolcache/go/1.21.6/x64/src/runtime/proc.go:267"}
{"level":"error","ts":"2024-03-20T09:31:28Z","msg":"Error while restoring a backup","logging_pod":"cloudnative-restore-cluster-1-full-recovery","error":"unexpected failure invoking barman-cloud-wal-archive: exit status 4","stacktrace":"github.com/cloudnative-pg/cloudnative-pg/pkg/management/log.(*logger).Error\n\tpkg/management/log/log.go:128\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/log.Error\n\tpkg/management/log/log.go:166\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/instance/restore.restoreSubCommand\n\tinternal/cmd/manager/instance/restore/cmd.go:89\ngithub.com/cloudnative-pg/cloudnative-pg/internal/cmd/manager/instance/restore.NewCmd.func2\n\tinternal/cmd/manager/instance/restore/cmd.go:60\ngithub.com/spf13/cobra.(*Command).execute\n\tpkg/mod/github.com/spf13/cobra@v1.8.0/command.go:983\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\tpkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1115\ngithub.com/spf13/cobra.(*Command).Execute\n\tpkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1039\nmain.main\n\tcmd/manager/main.go:64\nruntime.main\n\t/opt/hostedtoolcache/go/1.21.6/x64/src/runtime/proc.go:267"}

This is the cluster definition:
apiVersion: postgresql.cnpg.io/v1
kind: Cluster
metadata:
  annotations:
  generation: 1
  labels:
    app.kubernetes.io/instance: cloudnative-restore
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: cluster
    app.kubernetes.io/part-of: cloudnative-pg
    argocd.argoproj.io/instance: cloudnative-restore
    helm.sh/chart: cluster-0.0.3
  name: cloudnative-restore-cluster
  namespace: madme-lab
spec:
  affinity:
    podAntiAffinityType: preferred
    topologyKey: kubernetes.io/hostname
  backup:
    barmanObjectStore:
      azureCredentials:
        storageAccount:
          key: AZURE_STORAGE_ACCOUNT
          name: cloudnative-restore-cluster-backup-azure-creds
        storageKey:
          key: AZURE_STORAGE_KEY
          name: cloudnative-restore-cluster-backup-azure-creds
      data:
        compression: gzip
        encryption: AES256
        jobs: 2
      destinationPath: 'https://*****.blob.core.windows.net/cloudnative-pg/'
      wal:
        compression: gzip
        encryption: AES256
    retentionPolicy: 30d
    target: prefer-standby
  bootstrap:
    recovery:
      backup:
        name: cloudnative-cluster-daily-backup-20240320000000
      database: app
      owner: app
  enableSuperuserAccess: true
  externalClusters:
    - barmanObjectStore:
        azureCredentials:
          storageAccount:
            key: AZURE_STORAGE_ACCOUNT
            name: cloudnative-restore-cluster-backup-azure-recovery-creds
          storageKey:
            key: AZURE_STORAGE_KEY
            name: cloudnative-restore-cluster-backup-azure-recovery-creds
        destinationPath: 'https://*****.blob.core.windows.net/cloudnative-pg/'
      name: objectStoreRecoveryCluster
  failoverDelay: 0
  imageName: 'ghcr.io/cloudnative-pg/postgresql:15.2'
  imagePullPolicy: IfNotPresent
  instances: 3
  logLevel: info
  maxSyncReplicas: 0
  minSyncReplicas: 0
  monitoring:
    customQueriesConfigMap:
      - key: queries
        name: cnpg-default-monitoring
    disableDefaultQueries: false
    enablePodMonitor: true
  postgresGID: 26
  postgresUID: 26
  postgresql:
    parameters:
      archive_mode: 'on'
      archive_timeout: 5min
      dynamic_shared_memory_type: posix
      log_destination: csvlog
      log_directory: /controller/log
      log_filename: postgres
      log_rotation_age: '0'
      log_rotation_size: '0'
      log_truncate_on_rotation: 'false'
      logging_collector: 'on'
      max_connections: '300'
      max_parallel_workers: '32'
      max_replication_slots: '32'
      max_worker_processes: '32'
      shared_memory_type: mmap
      shared_preload_libraries: ''
      ssl_max_protocol_version: TLSv1.3
      ssl_min_protocol_version: TLSv1.3
      wal_keep_size: 512MB
      wal_receiver_timeout: 5s
      wal_sender_timeout: 5s
    syncReplicaElectionConstraint:
      enabled: false
  primaryUpdateMethod: switchover
  primaryUpdateStrategy: unsupervised
  replicationSlots:
    highAvailability:
      enabled: true
      slotPrefix: _cnpg_
    updateInterval: 30
  resources: {}
  smartShutdownTimeout: 180
  startDelay: 3600
  stopDelay: 1800
  storage:
    resizeInUseVolumes: true
    size: 4Gi
    storageClass: az-standard
  switchoverDelay: 3600

Im running version:
image: ghcr.io/cloudnative-pg/cloudnative-pg:1.22.1
on Kube:
1.27.5

This is being tracked on the Barman repo here https://github.com/EnterpriseDB/barman/issues/770
Closing this issue


chore: 🤖 Add support for optional arg procedures

Description
Add support for optional args procedures. This will help up pass optional parameters to those procedures which are converted from NoArgsProcedureMethod to ProcedureMethod
Breaking Changes
NA
JIRA Link
NA
Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 21.0.0-alpha.3 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 21.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix embedded image cid for named senders with a 'from' address like 'Sender<EMAIL_ADDRESS>

I was struggeling with embedding an image in an html mail body. The picture was attached however it didn't show up in Outlook.
The issue was caused by the sender address which was something like 'AnyFancyName<EMAIL_ADDRESS>To be precise the issue is caused by the '>' at the end of the string which survives with your current split logic and causes the cid to have two '>' characters at the end.
I would suggest to use parseaddr function from email.utils to get the raw email address from the msg['from'] field.

Thanks for pointing this out and making a fix! This indeed seems sensible. I'll try tomorrow to test this myself as well so I get gasp on how the issue actually looks like (and possibly make a test case for this), and then I'll merge this PR.

Codecov Report

Merging #33 (0449b6d) into master (87c255e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   99.48%   99.48%
=======================================
  Files          13       13
  Lines         584      584
=======================================
  Hits          581      581
  Misses          3        3

Impacted Files
Coverage Δ

redmail/email/body.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c255e...0449b6d. Read the comment docs.

Yep, I now realized what you meant the issue was. Interestingly, it seems Gmail is able to display the image correctly but Outlook does not even though the embedding of CID is indeed wrong. Thanks again for the fix.
I'll try to release a patch about this in the current week.


Job id is different from result job id

Environment

Qiskit Terra version: 0.23.3
Python version: 3.9.12
Operating system:

What is happening?
job.job_id() is different from job.result().job_id.
There is probably some logic here, maybe related to backend versus runtime jobs. I nevertheless think it's a bug, because a user unfamiliar with this logic may justly assume that they're equal, and rely on it (for example look for results with a given job id).
Ccing @gadial, who has already been in touch with some people about it. I think it's related to the new provider.
P.S. For uniformity, it would be nicer if job_id is either a method for both jobs and results, or a property for both. Right now it's a method for jobs and a property for results, for users it's confusing with the brackets, see in the code snippet below.
How can we reproduce the issue?
from qiskit import QuantumCircuit
from qiskit_ibm_provider import IBMProvider

provider = IBMProvider()
backend = provider.backend.ibmq_qasm_simulator

circ = QuantumCircuit(1, 1)
circ.measure(0, 0)

job = backend.run(circ)
print("Job id:", job.job_id())

res = job.result()
print("Result job id:", res.job_id)

What should happen?
.
Any suggestions?
No response

This is how it looks on the website (two different job ids appearing in the same page):


Single end sample names identical to read file basenames

Ampliseq failed when running with a sample sheet where sample names were identical to file's basenames, i.e. sample0 read from sample0.fastq.gz. This PR modifies the existing, but not used in any test AFAIK, Samplesheet_single_end.tsv so that a fix for this problem can be tested.

Hi, I had a short look, but I am a little puzzled by all that commit history (31 commits!), what is this? Other than that it looks fine.

but not used in any test AFAIK, Samplesheet_single_end.tsv

Hm, that sample sheet should be used in another test. I can take care of that, could you open an issue in nf-core/ampliseq?

Den ons 21 juli 2021 10:08Daniel Straub @.***> skrev:

Hi, I had a short look, but I am a little puzzled by all that commit
history (31 commits!), what is this? Other than that it looks fine.

No idea and not by the computer until Monday. I'll check then.

but not used in any test AFAIK, Samplesheet_single_end.tsv
Hm, that sample sheet should be used in another test. I can take care of
that, could you open an issue in nf-core/ampliseq?

I have a PR waiting, in which I added a test and "fixed" the issue. Monday.
—

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nf-core/test-datasets/pull/283#issuecomment-883982939,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALTHQAPDK6SMS5QMDKHAFTTYZ57RANCNFSM5ATVO4UQ
.


Unbound: enable QNAME minimisation

This is a followup on #91.
There, using QNAME minimisation (to further reduce the amount of information leaked in DNS queries) was suggested, but not implemented due to the lack of support in Unbound 1.4.x (version in jessie).
However, v1.5.8 is is jessie-backports.
Any objections to using that version and enabling QNAME minimisation?

Approved by @dpflug


PP-5672 Always authorise with payment intents

All issues have been ironed out with using payment intents, so
fully switch to using them to create and authorise payments.
All downstream operations are still backwards compatible with
both payment intents and charges. I will switch them over in
subsequent PRs.

To help reviewing:

Reassure yourself that the tests I have changed or removed only concerned the 'old' way of authorising charges
look at how I have changed the main method in StripeAuthoriseHandler from dealing with two cases to dealing with one, without changing any other logic


feat(taiko-client): improve progress tracker

Actually lastSyncedBlockID is used for recording the current syncing blockID, how about rename to lastSyncingBlockID?


Code Quality: installed version of NuGet package LiteDB has a critical vulnerability

Description
Currently, we're using a version of LiteDB which has  a vulnerability of critical severity. We should upgrade the package to avoid that.
Concerned code

Files.Shared

Gains

A safer code

Requirements

Update LiteDB to the latest version (or one that has no issues)

Comments

Unfortunately we are unable to switch to LiteDB 5.x due to a concurrency issue.
See #10577.

The vulnerability doesn't affect Files so we should be safe.


localized version of a webpage

ref : https://developers.google.com/search/docs/specialty/international/localized-versions?hl=fr
<link rel="alternate" hreflang="en-gb"
       href="https://en-gb.example.com/page.html" />
  <link rel="alternate" hreflang="en-us"
       href="https://en-us.example.com/page.html" />
  <link rel="alternate" hreflang="en"
       href="https://en.example.com/page.html" />
  <link rel="alternate" hreflang="de"
       href="https://de.example.com/page.html" />
 <link rel="alternate" hreflang="x-default"
       href="https://www.example.com/" />

This feature can be implemented by using an array as input or defining each country code and giving the url (following next example)
<SEO
   alternate= {{
       en: "https://en.example.com/page.html",
       en_US: "https://en-us.example.com/page.html",
       de: "https://de.example.com/page.html",
       default: "https://www.example.com/"
   }}
/>

Sounds great, I am working on it this week end

done #68

Hey @jonasmerlin , Waiting for your approval

Hey @C0casio45, sorry I dropped the ball on this one. Only saw your PR today. Thank you for looking into this! I fixed a few issues with your PR, so if you're interested what has changes, take a look.
I will release a new version with the changes.


[Windows] Add sbt to Windows 2022 image

Description
Adds sbt to the Windows 2022 image. It's already installed for the Windows Server 2016 and 2019 images, and this PR adds it also to the 2022 image.
Check list

[ ] Related issue / work item is attached
[x] Tests are written (if applicable)
[x] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

Hi @EwoutH!
Have you tried using https://github.com/olafurpg/setup-scala action for your needs? Or do you need sbt for Azure DevOps builds?

Yes, I use that action frequently. The install time is somewhat longer if you're using the latest version and it isn't pre-installed on the image though. All other platforms provide a pre-installed sbt version, so it would be nice to make it consistent by also installing it on the Windows Server 2022 image.

@EwoutH thanks, sounds reasonable as I thought the action takes only a few seconds to install sbt.
Could you also update the software generator?
https://github.com/actions/virtual-environments/blob/main/images/win/scripts/SoftwareReport/SoftwareReport.Generator.ps1#L79

Good catch, I update the software generator!

/azp run windows2016, windows2019, windows2022

@EwoutH thank you for the contribution! The changes will probably be available later this week


[Feature Request]add method to convert to time.Time

In somecase,  I need convert carbon object to time.Time.
Currently, I need convert carbon to timestamp and then convert to time.Time
For example a database model defined in legacy project as below,

type Post struct {
  ID string
  CreatedAt null.Time
  UpdatedAt null.Time
  ...
}

post := Post{}
c := carbon.Now()
timestamp := c.ToTimestamp()
post.CreatedAt = null.FromTime(time.Unix(timestamp))
...

If there are many time fields in Post struct, it's boring to do the converting manually on each field.
But it would be clean like this
post.CreatedAt = null.FromTime(carbon.Now().ToTimeDotTime())

It's much appreciate if this awesome project add a method to get time.Time.

carbon.CreateFromGoTime(time.Now())

carbon.CreateFromGoTime(time.Now())

I had found ToTimestamp() method as described above.
The problem is I need convert manually on each time fields.
Is there any way to get time.Time directly or why not provide a way to convert to time.Time?
BTW, null.FromTime() need a time.Time but not timestamp as params .

I had found ToTimestamp() method as described above.
The problem is I need convert manually on each time fields.
Is there any way to get time.Time directly or why not provide a way to convert to time.Time?
BTW, null.FromTime() need a time.Time but not timestamp as params .

中文沟通吧

中文沟通吧

能加个方法直接从 carbon 转换到 time.Time 吗？
有些场景需要 time.Time 入参。
现在虽然可以通过 timestamp 转换，但是如果库就自带了这个方法，使用起来不是更方便吗，你说呢？

能加个方法直接从 carbon 转换到 time.Time 吗？
有些场景需要 time.Time 入参。
现在虽然可以通过 timestamp 转换，但是如果库就自带了这个方法，使用起来不是更方便吗，你说呢？

其实代码就两行，如果需要的话，我可以提 PR。
就是方法取啥没想好。

其实代码就两行，如果需要的话，我可以提 PR。
就是方法取啥没想好。

可以看下carbon.go源码，
type Carbon struct { 	Time time.Time 	loc  *time.Location }
carbon.Now().Time就是time.Time类型

可以看下carbon.go源码，
type Carbon struct { 	Time time.Time 	loc  *time.Location }
carbon.Now().Time就是time.Time类型

Got it.
Thanks.

Got it.
Thanks.


net_ip.h documentation enhancements

Codecov Report

Merging #13666 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #13666   +/-   ##
=======================================
  Coverage   52.41%   52.41%
=======================================
  Files         322      322
  Lines       46596    46596
  Branches    10772    10772
=======================================
  Hits        24422    24422
  Misses      17267    17267
  Partials     4907     4907

Impacted Files
Coverage Δ

include/net/net_ip.h
68.13% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2d5e7b...53096de. Read the comment docs.


Register device for push notifications

Endpoint URL
TBD
Proposed payload
{
  uuid: "<str>",
  cloud_messaging_token: "<str>",
  build_number: "<sematic-version-str>",
  bundle: "<str>",
  device_type: "<str>",
  version: "ANDROID|IOS|WEB",
  timestamp: "<iso-str>",
  safes: [{
    chainId:  "<int>",
    address: "<checksummed-address>",
    signature: "<str-hex>"
  }]
}

Open for discussion

Signing chainId?

Sample JSON:
{
  "uuid": "c50750df-700c-4b17-98ca-b95a5c27ca18",
  "safes": [
    {
      "address": "0x00E17aA063fbDB3BFdEfc2c3b2c13173d2711a35",
      "chainId": 1,
      "signature": "0x4b574e7c729db54b427dd17a6b2ae3481221642a9d61c52a53f77500d98ddc1d739c39dfb117619fb09a20e3f5070d018e62c37f89fb622ae10b56a6be9af5c11b"
    },
    {
      "address": "0x00E17aA063fbDB3BFdEfc2c3b2c13173d2711a36",
      "chainId": 4,
      "signature": "0x4b574e7c729db54b427dd17a6b2ae3481221642a9d61c52a53f77500d98ddc1d739c39dfb117619fb09a20e3f5070d018e62c37f89fb622ae10b56a6be9af5c11b"
    }
  ],
  "cloudMessagingToken": "eWv4Ya6OSaiuDI91S0_C6D:APA91bGpprbGOCa1Qev0h3vlMu2nXa9nWpaL7N9fEcX2G4byZ3TSKXircrMtuWg1H4nSG9Ugu7a7rgY1eDKAR9UaxgaP1egTRj3taqAfAQblApuiWFfRRkyxdD3N23t7wYi9ZBIXZ88Z",
  "bundle": "io.gnosis.safe.debug",
  "version": "2.13.0",
  "deviceType": "ANDROID",
  "buildNumber": "703",
  "timestamp": "1618906387"
}

Question regarding the type of chain_id, The sample json shows it as a String but the json definition shows it as <int> . We generally treat it as a String in the gw anyway, considering the size of the int I would prefer leaving it as a string for the sake of simplicity.


Create a logic to provide execCmd for standard benchmarks

Right now in standard benchmarks we need to hardcode "execCmd" in SAVE.toml.
We need to have a window on the frontend and logic on the backend that will help us to override the configuration for execCmd in save.toml if provided

We also should let user choose, whether their tool supports batch mode when setting execCmd


[CSS] box sizing, Fx 71 tasks

Trello: https://trello.com/c/99AKTpVj/186-css-values-and-units-level-4-box-sizing-level-4-fx-71

[ ] Ship the mapping of img width and height to aspect-ratio.

Note that I wrote a related guide that needs publishing at some point:https://docs.google.com/document/d/1RAqaONrO7Zka2Q7IL3yyGDskwycBATS46SeE167PDdY/edit

@chrisdavidmills do you want me to publish the guide as part of this?

Chrome are shipping too https://www.chromestatus.com/feature/5695266130755584

do you want me to publish the guide as part of this?

Ah yes, that would be really nice thanks. Jen is very interested in getting it published.

@chrisdavidmills where should the guide go do you think? Poking around I realise that the properties which should be under the CSS Box Sizing Spec are listed under "box model" which is suboptimal at this point.

@rachelandrew that's a good question. We do have a replaced elements page — https://developer.mozilla.org/en-US/docs/Web/CSS/Replaced_element — which is related, but maybe just put it under the main CSS page for now, until we decide what to do with it?
@a2sheppy I think you also had some ideas about this. What were your thoughts on where it should go?

So, I feel like this should go under Web/Media, perhaps at https://developer.mozilla.org/en-US/docs/Web/Media/Aspect_ratio_mapping or something similar. Then it should be added to the "Guides" list in the second column of the page at Web/Media.
That's my opinion, anyway.

I suppose we could also consider if it would make sense to add a Web/Media/Images subtree for content specific to images, like the image type documents, the aspect ratio document, and other articles about using images and things like that.

Maybe later, but I think for now we should concentrate on this page. I'm happy to put it where you suggest; we can always move it later if a good reason pops up. @rachelandrew , this ok?

@chrisdavidmills ah, I just built that images page as it seemed to make sense! Was just coming to comment as such. I can remove it again but:

https://wiki.developer.mozilla.org/en-US/docs/Web/Media/images
https://wiki.developer.mozilla.org/en-US/docs/Web/Media/images/aspect_ratio_mapping

I'm making an aspect-ratio property page even though this is currently only being implemented internally for the mapping.
Compat data PR, if there is a better way to indicate this internal-mapping-without-full-implementation let me know!
https://github.com/mdn/browser-compat-data/pull/5114

@rachelandrew Once created, might as well just leave it. :)

Yup, that's fine! Great minds think alike and all that ;-)

I've given the new pages a small edit, and I think we can call this done now. Thanks!

Page here: https://wiki.developer.mozilla.org/en-US/docs/Web/CSS/aspect-ratio
Added to release notes for 71 and flagged the bug.

Reviewed; LGTM!


[Roots 3] lit pyre does not provide light

When lit the pyre does not affect light levels.

Uh, I'll try to fix this today if nobody precedes me :P

got it to light up, but it does provide light even when the recipe is finished and also when the block is broken, so I might need to work out a better solution 🤣


[BD_annotations] Add relevant Operator level annotations on BD

This commit makes Operator controller to add annotations on BundleDeployments realted to operator version and channel. This will be useful for runtime based resolutions to identify the BDs that are installed by the operator controller and already running on cluster.
Relates to: #268
Description

Reviewer Checklist

[ ] API Go Documentation
[ ] Tests: Unit Tests (and E2E Tests, if appropriate)
[ ] Comprehensive Commit Messages
[ ] Links to related GitHub Issue(s)

I'm getting the feeling that this is a problem that we need to noodle on a design for. This honestly feels like it requires a Brief and multiple follow-on RFCs (to use our new favorite terminology)

should we close this PR for now? I think more thought it needed, and we solved the upgrade issue without needing the annotations (we just used the bundle id and documented the limitations). I think that's sufficient for now as we work out the nitty gritty.

should we close this PR for now? I think more thought it needed, and we solved the upgrade issue without needing the annotations (we just used the bundle id and documented the limitations). I think that's sufficient for now as we work out the nitty gritty.

Fair! Closing this


How to implement optional values?

I have a following store, where message is only optional:
@model('geodas/Modal')
export class ModalStore extends Model({
  message: tProp(types.model<ModalMessage | null>(ModalMessage), null)
}) {}

when I initialise this store new ModalStore() I receive an error that the message is not of type ModalMessage.
Is there any way how to do this?

Without having tried it, does new ModalMessage({}) work?

The problem here is with types.model. It should be a model class, not Model | null. In order to use null, you need to use maybeNull like here:
@model('geodas/Modal')
export class ModalStore extends Model({
  message: tProp(types.maybeNull(types.model<ModalMessage>(ModalMessage)), null)
}) {}

@terrysahaidak thats what I was after thanks! I did not see that type ...


Latest version of the Android Plugin for Gradle (2.0.0) requires Gradle 2.10 or later

The latest version of the Android Plugin for Gradle (2.0.0) released recently requires Gradle 2.10 or later.
The latest version of the J2ObjC Gradle plugin (0.6.0-alpha) requires Gradle 2.8 and does not work with later versions of Gradle.
Thus any project which uses the latest version of the Android Plugin for Gradle cannot use the J2ObjC Gradle plugin as it currently stands. This together with the inability to use the latest version of the J2ObjC library (1.+) means I'm going to have to drop the J2ObjC Gradle plugin for now. It worked well when it did but at this point the cost is too high :-(

You can work around the version checking in your application build.gradle :
buildscript {
    ...
    System.properties['com.android.build.gradle.overrideVersionCheck'] = 'true'
}

Not a good permanent solution, but so far had no problem compiling with the 2.0.0 android gradle plugin (mandatory with the new 2.0 Android Studio) and 2.8 gradle.

is support for gradle 2.10 coming...?


WIP: Improving the text API to be able to reuse font between regular draw functions and draw 2d using different renderers

This is a work in progress, it needs a lot of cleaning, removing dependencies/packages, and redoing the internals of the draw2d text API.

This PR contains so many `useless/dirty´ commit that I'll Squash before the merge.

Closed in favour of #72


Only 3 nested replies are visible, and others get vanished

Description:
Only the first 3 replies can be seen for a parent comment after refreshing the Publisher portal. (Same for Developer portal as well)
Steps to reproduce:

Add comments to an API as shown below. (With one parent comment and more than 6 replies)

Refresh the page, you can only see the first 3 replies for the parent comment.

Environment details (with versions):

OS: Ubuntu 20.04.1 LTS
Web browser: Chrome

Related #10261


Use proper xml tag for ListUserTagsResult's Tags

boto3 is forgiving on this front but other SDKS are not.
I made this change on my localstack container and it did indeed fix the Go SDK behavior.
https://docs.aws.amazon.com/IAM/latest/APIReference/API_ListUserTags.html
This should resolve https://github.com/spulec/moto/issues/4341

Codecov Report

Merging #4350 (9441e19) into master (3a203d3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4350   +/-   ##
=======================================
  Coverage   95.11%   95.11%
=======================================
  Files         493      493
  Lines       55651    55669   +18
=======================================
+ Hits        52931    52951   +20
+ Misses       2720     2718    -2

Flag
Coverage Δ

servertests
52.81% <ø> (-0.01%)
:arrow_down:

test_responses
32.77% <ø> (+<0.01%)
:arrow_up:

unittests
95.02% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/iam/responses.py
98.66% <ø> (ø)

moto/apigateway/responses.py
93.43% <0.00%> (-0.02%)
:arrow_down:

moto/s3/responses.py
95.61% <0.00%> (+<0.01%)
:arrow_up:

moto/elb/responses.py
98.80% <0.00%> (+<0.01%)
:arrow_up:

moto/ec2/models.py
95.73% <0.00%> (+0.04%)
:arrow_up:

moto/apigateway/models.py
93.27% <0.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a203d3...9441e19. Read the comment docs.


Updated devcontainer requirements for PyTorch and CUDA

Fixes #598
Proposed Changes

updated requirements for torch and cuda
no need to calculate code coverage for this folder

Checklist

[x] I have read the CONTRIBUTING guide
[x] My PR is based from the current GaNDLF master
[x] Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change
[x] Function/class source code documentation added/updated
[x] Code has been blacked for style consistency
[x] If applicable, version information has been updated in GANDLF/version.py
[x] If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
[x] Usage documentation has been updated, if appropriate
[x] History has been updated, if appropriate
[x] Tests added or modified to cover the changes; if coverage is reduced, please give explanation
[x] If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

Is there a way for us to automate the testing of the devcontainer creation (perhaps along with the gandlf_verifyInstall script to ensure that the environment is correctly set up)?

You can create a dev container with @devcontainers/cli and add checks to the dev container.
Eg. Reference - This is how a container is built with build.sh and tested with test.sh
@sarthakpati Probably you could do something similar to validate the dev config?

Can we add some relevant documentation for users to get started with this in an easy way?

I am not sure if I understand your question, are you looking forward to update your contribution docs with "Getting Started with Codespaces" section? I can help add that if needed.

EDIT: Would this action be something that can be used for this purpose?

Yep, I think so. You might be interested in "Using a Dev Container for a CI build:" section of https://github.com/devcontainers/ci/blob/main/docs/github-action.md

Opened https://github.com/mlcommons/GaNDLF/pull/602 ⚡

We offer prebuilds as a feature, you can pin it to a branch like main: https://docs.github.com/en/codespaces/prebuilding-your-codespaces
You can open a container as a gpu instance from this page, that lets you choose options for the machine type
https://github.com/codespaces/new?hide_repo_select=true&ref=master&repo=342691278
You get there from the code drop down, then clicking on the ... on the right side of the new codespace option.
This should give you Cuda bindings I believe as that is a devcontainer feature.


Invalid JSON RPC response: {}

I can't use the portfolio at faa.st, I get the error Invalid JSON RPC response: {} also tried sending a message to<EMAIL_ADDRESS>but haven't received any response, although this issue is not exclusively related to the source code in repository, there is still a change that it is so I' posting it here nonetheless.

thanks for letting us know, i'll let the right people know about your email! I am pretty sure this is something we are looking into/working on fixing right now.

Actually, just got word it should be fixed! Let us know if you have any more issues

@dwolfgram Awesome! Thanks, it's very much appreciated.


Web support

Web platform is not supported.
A few weeks ago it worked, but now it doesn't work anymore.
It would be very useful if it would be supported

I also found the same problem and the developers of this repository suddenly removed the web support in the new version without even mentioning this in their changelog!!
This is really ridiculous

Same problem here. I went back to 1.3.9.

Version 1.3.9 works on the web. I'm using it.

What version of flutter do you have?
I have 3.24.3 installed and even if i go back to version 1.3.9 I still have thiis error on web:
SEVERE: 2024-10-15 21:24:26.392: WebSocket connection to 'wss://...ENDPOINT...' failed: Unsupported operation: Platform._version
SEVERE: 2024-10-15 21:24:26.393: Failed to start the transport 'HttpTransportType.WebSockets': Unsupported operation: Platform._version
SEVERE: 2024-10-15 21:24:31.689: (SSE transport) error when listening to stream: [object Event]
SEVERE: 2024-10-15 21:24:31.691: Connection disconnected with error '[object Event]'.

Even if you change the version in flutter, it may still be using 1.4.0 from that cache (it happened to me). Try using flutter pub cache clean and flutter clean. To see which version it is using, you can see the version used by clicking on the imported file in the editor.

before i forget, the versions i used:
Flutter 3.24.3
Dart 3.5.3

I tried cleaning pub cache and do a flutter clean and, even if in the pubspec.yaml it's specified the version 1.3.9 somehow it uses the 1.4.0.
In the cache folder there is only signalr_netcore-1.4.0 and the dependency is not inherited by others, is the only present in my pubspec

When adding the package, add it as signalr_netcore: 1.3.9, not signalr_netcore: ^1.3.9. Try without the ^ character.

@autocar you saved my day! Thank you very much!
Why does it work in a different way signalr_netcore: 1.3.9 vs signalr_netcore: ^1.3.9?
Let's hope they will support again web version in the next releases like before...

Specifying Versions in pubspec.yaml
The versions in pubspec.yaml can be specified as follows:
Package name: [space]
　If no version is specified, the latest version is automatically selected. It is recommended to specify a concrete version for important packages to avoid breaking changes.
Package name: 1.0.0
　The specified version is selected.
Package name: “>=1.0.0 <2.0.0”
　The version is selected within the specified range.
Package name: ^1.0.0
　Automatically selects the version within the range with the same major version as the specified version. This is equivalent to “>=1.0.0 <2.0.0”.
If no version is specified, the latest version is automatically selected, but it is recommended to specify a concrete version for important packages to avoid unexpected issues.
source:
https://flutterdevelop.blog/en/pubspec-yaml/#:~:text=Conclusion-,“pubspec.,crucial for Flutter app development.

I'm glad your problem is solved.
For your question about versions;

Specifying Versions in pubspec.yaml
The versions in pubspec.yaml can be specified as follows:
Package name: [space]
　If no version is specified, the latest version is automatically selected. It is recommended to specify a concrete version for important packages to avoid breaking changes.
Package name: 1.0.0
　The specified version is selected.
Package name: “>=1.0.0 <2.0.0”
　The version is selected within the specified range.
Package name: ^1.0.0
　Automatically selects the version within the range with the same major version as the specified version. This is equivalent to “>=1.0.0 <2.0.0”.
If no version is specified, the latest version is automatically selected, but it is recommended to specify a concrete version for important packages to avoid unexpected issues.

source: https://flutterdevelop.blog/en/pubspec-yaml/

I have issue with version 1.4.0 on Flutter web. Farsi text is converted to characters like Ù�Ø§Ù�Ù�Ù�Ù�.


Streamlines?

It would be awesome if ipyvolume was also able to render streamlines from velocity or magnetic field vectors.
For instance, helical magnetic topologies are one of the most difficult things to visualize in 2D and having a 3D view on them is often essential.
Thanks for such a great project and keep up the awesome work!

Dear Neil,
Yes, that's also what I really like to see. I started working on this a long time ago (really early prototype, not worth a look), so I have some ideas already. I think the calculations of this should be an external package (maybe there is already something out there, but I cannot find anything). ipyvolume could then use that to calculate the streamlines (at the Python side).
I don't have the bandwidth to implement this myself (even if I had the funding), but I'm happy to help out where I can.
cheers,
Maarten


Fix for compiling under case-insensitive systems like OSX

OSX doesn't know the difference between 'freertos.h' and 'FreeRTOS.h' - so the code doesn't compile. I renamed 'freertos.h' to  'freertos_vars.h' and changed the includes - now it compiles just fine on OSX.
Seems like my editor also removed some whitespace :)

Thanks for the PR. I will merge your rename.
But can you please undo the whitespace changes? I agree that the whitespace shouldn't be there, but this is autogenerated code. I'd rather avoid changing it manually, since it will show up as different if autogenerated again.

OK, I put the spaces back in


Add core plugins zips to published artifacts

Description
Create build artifacts (zips) for core plugins and copy those into artifacts/core-plugins directory.
Issues Resolved
#200
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda<EMAIL_ADDRESS>

Btw, if you say Closes #200 in the PR body, it will auto-close that issue when this PR is merged.

Are we calling those as core-plugins or native-plugins?

Are we calling those as core-plugins or native-plugins?

Historically the community knows these as core plugins, so it makes sense to be consistent. Also, calling these "native" may create confusion that these plugins rely on JNI.


Minor script improvements

Add kube context flag for ddk8s script
Add help flag to print_usage
Added timestamp logging
update parameters logging

resolves #13


NpcPlugin - API

Hello, I did not try your plugin already, it seems really great and I would like to use it.
However, I did not find any API so I would like to request you to add an API with all the creation, get, ... methods and a PlayerNpcInteractEvent :)
I hope you can make it ASAP ty :D

Hey, nice that you are interested in using the plugin. I will add more API to it shortly and keep you updated in this issue

@Ducki0210 I have added a buch of API stuff. Check out Documentation.md
If you have questions feel free to ask them here or on discord (Oliver#6538).

I took a look quickly and it seems full, I will try it and ask you if I have an question ! :D

Hey, I found the gradle project repository and dependency but not the maven one, is there one ?
Also, I was wondering if there is an option to set multiple lines above the NPC's head ?
or maybe a command like /npc displayName (name) (line) (text) ?

I'm not too familiar with Maven but it should be something like this:
<dependency>
    <groupId>de.oliver</groupId>
    <artifactId>NpcPlugin</artifactId>
    <version>1.1.1</version>
    <scope>provided</scope>
</dependency>

About the multi line: You would need to use holograms for that. I have planned to integrate my FancyHolograms plugin but I'm currently very busy.

Ahh sorry, I hate to ask that much but I am not very good with all the maven and gradle stuff...

All good, I'm not very good with maven and gradle aswell 👀

@Ducki0210 do you have any more questions or can I close this issue?


Update README.md

@moyantri You are supposed to setup the codebase for the algorithm,documentation is assigned to someone else :)

This is to be closed @moyantri


Create example classifier figure

Also moves logo to media.

Example image is currently:

Used OmniGraffle to make the figure, which is not open source, but I figured it's fine since we really only need the exported figure.
DNA sketch was from Vecteezy by charlieburst. The license states:

You are allowed to:

Download to obtain the non-exclusive right to use Eezy files to create new, derivative, unique works, however the original Eezy file or artwork must be largely unrecognizable.
Download, edit, and remix for personal and commercial use, but give credit back to the author

Using this viz in my OpenCon 2016 presentation at http://slides.com/dhimmel/opencon-2016#/1/1


Render Excalidraw in an iframe so that page styles do not break the drawing

Sometimes the host page's styles conflict with Scrawl. This can cause the drawing to be rendered at the wrong size or even disable the ability to use text in excalidraw.
The solution is to wrap excalidraw in an iframe. The easiest way to do this seems to be react-frame-component. However there are some challenges we need to solve since the iFrame needs to communicate with the extension processes. For example Excalidraw uses assets provided by the extension to render CSS and fonts and other things. Unfortunately I'm not sure that we can access extension files in an iframe even if we have the url provided by getURL

We can make the iframe transparent by setting html, body {background-color: transparent} and adding allowtransparency={true} to the iframe declaration
we could run the extension in all frames but this feels like it would have a negative performance impact. We really want to run the extension in a single iframe.

another solution here is using shadow-dom, which allows you to isolate the styles/etc you use for your extension in a separate namespace & does not impose additional complexity on communicating with extension infrastructure

example from extension I'm working on: https://github.com/transclude-me/extension/blob/main/source/utils/tippy.ts#L88


Add verbosity option to build_bootloader

It seemed strange to me that --verbose was not passed through to build_bootloader, so I updated it so that it gets passed through from build_impl.

Nevermind, this isn't the option I thought it was. My bad. Closing.


Minified JS and CSS does not include license information

Problem
The minified JavaScript and CSS included in sphinx_rtd_theme do not include licenes text.  This prevents Fedora from packaging documentation that uses sphinx_rtd_theme.
Reproducible Project
Please give a link to a public reproducible project or provide an example of the Restructured Text that gives an issue.
https://bugzilla.redhat.com/show_bug.cgi?id=2006555#c4
Error Logs/Results
Generated documentation includes minified JS and CSS without license text.
Expected Results
Generated documentation includes license text in all generated JS and CSS files.
Environment Info
Not sure, but presumably this is Fedora 35 or 36 provided packages.

Thanks for reporting this @DemiMarie. We'll look into it.

Additional info here: https://github.com/sphinx-doc/sphinx/issues/10172#issuecomment-1038300760

You’re welcome @nienn!  The original report is https://bugzilla.redhat.com/show_bug.cgi?id=2006555#c4.