unable to run witness demo -- ERR: Non zeroed prepad bits = 100000 in b'r'.

I've got a fresh clone of the development branch of keripy. I've setup venv, activated it, and done pip install -r requirements.txt. I've also started vLEI-Server without error, and I've run rm -rf /usr/local/var/keri/*; and cd scripts/demo; source demo-scripts.sh. All of this works fine.
Now I'd like to start witnesses. I run: kli witness demo. I immediately get this: ERR: Non zeroed prepad bits = 100000 in b'r'.
I am unable to proceed.
I thought this might be caused by a late-breaking change in the development ranch, so I coordinated with Arsh, another Provenant developer who is not having the problem. He was running from commit 85e6ae421c, so I did a git reset --hard to that commit and tried again. This did not change the outcome at all.
I'm happy to debug further, but since I'm such a KERI noob, I'm a little bit unsure which sorts of debug tools I ought to use. For example, is there a way to turn on logging when running the demo scripts? Is there an environment variable that enables "verbose mode" or something?
@pfeairheller

The only thing I can think of that might explain my difference is that I'm on a windows machine, running Windows Subsystem for Linux. The shell and environment are essentially Ubuntu 22.04 -- bash, etc. The installed python is . Normally the WSL solution is excellent and produces behavior that's more or less indistinguishable from running native on Ubuntu. However, there are very subtle differences. One is that the mime type subsystem for web servers has very slight config differences. This causes a default web server launched on my box to report that a .json file is of type text/json instead of application/json, for example. That breaks one unit test in keripy, but I investigated the breakage and decided that it was trivial and unimportant. Perhaps I'll submit a fix. I think it's a red herring on this issue, though.

I did a check to make sure the OS (the Ubuntu in the WSL, not the windows container) was fully patched. A few things got patched, but no difference in outcome.

Completely reset my local clone and started over from scratch. Created a new orphan branch in git, and merged upstream/development (from WebOfTrust). This should guarantee that my local repo is bit-for-bit identical to what's checked in to the development branch of the WebOfTrust repo.
I got exactly the same error.

The quickest was to debug this is to change a few lines (comment/uncomment) in kli.py to get the full stack trace.  (Once upon a time I tried to add a --debug flag to accomplish this but was unable to apply a single flag to all commands).
If you swap the commenting on lines 25, 26 and 27 (comment 25, 26 and uncomment 27) then run the command again and post the stack trace here.
        print(f"ERR: {ex}")
        return -1
        # raise ex

to
        # print(f"ERR: {ex}")
        # return -1
        raise ex

Thanks. That makes the info a lot more useful. I am feeling a bit embarrassed that I didn't try that myself. I should have dived in a little deeper before asking such a basic question.
Here's the stack trace.
  File "/home/daniel/code/keripy/src/keri/app/cli/commands/witness/demo.py", line 34, in demo
    wanHby = habbing.Habery(name="wan", salt=Salter(raw=b'wann-the-witness').qb64, temp=False, cf=wancf)
  File "/home/daniel/code/keripy/src/keri/app/habbing.py", line 284, in __init__
    self.db = db if db is not None else basing.Baser(name=self.name,
  File "/home/daniel/code/keripy/src/keri/db/basing.py", line 619, in __init__
    super(Baser, self).__init__(headDirPath=headDirPath, reopen=reopen, **kwa)
  File "/home/daniel/code/keripy/src/keri/db/dbing.py", line 349, in __init__
    super(LMDBer, self).__init__(**kwa)
  File "/home/daniel/code/keripy/venv/lib/python3.10/site-packages/hio/base/filing.py", line 150, in __init__
    self.reopen(clear=clear, reuse=reuse, clean=clean, **kwa)
  File "/home/daniel/code/keripy/src/keri/db/basing.py", line 835, in reopen
    self.reload()
  File "/home/daniel/code/keripy/src/keri/db/basing.py", line 846, in reload
    if (state := self.states.get(keys=data.prefix)) is not None:
  File "/home/daniel/code/keripy/src/keri/db/subing.py", line 1110, in get
    return coring.Serder(raw=bytes(val)) if val is not None else None
  File "/home/daniel/code/keripy/src/keri/core/coring.py", line 4956, in __init__
    super(Serder, self).__init__(raw=raw, ked=ked, kind=kind, sad=sad, code=code)
  File "/home/daniel/code/keripy/src/keri/core/coring.py", line 4707, in __init__
    self.raw = raw  # raw property setter does the deserialization
  File "/home/daniel/code/keripy/src/keri/core/coring.py", line 4801, in raw
    self._saider = Saider(qb64=ked["d"], code=self._code)
  File "/home/daniel/code/keripy/src/keri/core/coring.py", line 3355, in __init__
    super(Saider, self).__init__(raw=raw, code=code, **kwa)
  File "/home/daniel/code/keripy/src/keri/core/coring.py", line 870, in __init__
    self._exfil(qb64)
  File "/home/daniel/code/keripy/src/keri/core/coring.py", line 1157, in _exfil
    raise ValueError(f"Non zeroed prepad bits = "
ValueError: Non zeroed prepad bits = 100000 in b'r'.

Alright, this stack trace indicates that the database the process is using is not empty.  KERIpy will use one of three locations for its database:
/usr/local/var/keri if it is available and writable by the current user
~/.keri if the previous is not available
/tmp/keri_****** if temp is passed as a flag
The /tmp directory is only used for tests.  My guess is that your user can not access /usr/local/var/keri so it is writing to your home directory which you haven't deleted yet (and probably has an old database prior to the neo branch).
The directions for the scripts needs to spell out the directory usage more clearly.  I'll open an issue to add documentation to the scripts README to make this clear.  Sorry for the confusion.

Yep, that fixed it. Thank you!


what is "gtItem"?

@hexiangnan ! Thanks for publishing this code.
In evaluate.py, there's code like below
`def eval_one_rating(idx):
rating = _testRatings[idx]

items = _testNegatives[idx]

u = rating[0]

gtItem = rating[1]

items.append(gtItem)`

In this code, what is gtItem ?

@hexiangnan Thank you !


QueryDSL MDC logging fields contain dots

QueryDSL MDC logging fields contain dots in the field names. All logging infrastructure based on ELK (Elasticsearch, Logstash, Kibana) will require the dots in fields to be removed when upgrading to 2.0 (see: https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking_20_mapping_changes.html#_field_names_may_not_contain_dots).

What do they mean by 'field name'?
Do they mean that they serialize the key as-is, and dots are not allowed?

As far as I know, the 'field name' is just the key for key-value pairs you put in MDC. They are enforcing keys with no dots in them. Also see: https://github.com/elastic/elasticsearch/pull/12068

Okay, that's clear.

@timowest Sounds fine, what do you think?
What do we do with the current key?
I'm sure there are people who depend on the current value.
We can maybe wait with this until the next minor release (4.2.0 maybe?)

All logging infrastructure based on ELK (Elasticsearch, Logstash, Kibana) will require the dots in fields to be removed when upgrading to 2.0

For what it is worth this is fixed in Elasticsearch 5 which is in alpha now: https://github.com/elastic/elasticsearch/pull/17759 https://github.com/elastic/elasticsearch/pull/18106

I also found this, but I am not quite sure how it was resolved
https://github.com/elastic/elasticsearch/issues/15951

I wasn't super close to that work but my understanding is that they should "just work" now. It looks like Elasticsearch creates "object" mappers for all of the steps along the dots. So {"foo.bar.baz": 1} is kind of like a short hand for {"foo": {"bar": {"baz": 1}}}. The neat thing about this is that it keeps all of the query parsing stuff unambiguous. I'm not 100% clear on this and I don't have time to read all the code around it to get clear. I've filed https://github.com/elastic/elasticsearch/issues/19149 asking for someone who knows more to add it to the docs.
You may still want to remove the dots - I'm not sure. 5.0 is still in alpha. We allow ourselves to break disk and wire compatibility in alphas and betas so you really shouldn't deploy that to production.


cloudstack-agent incorrectly assigning private.network.device

ISSUE TYPE

Bug Report

COMPONENT NAME

Agent

CLOUDSTACK VERSION

<IP_ADDRESS>

CONFIGURATION

Advanced Networking
cloudbr0 - Guest/Private (VXLAN)
cloudbr1 - Public Network (VLAN)
cloudbr2 - Management Network (VLAN)
OS / ENVIRONMENT

Ubuntu 22.04 LTS
KVM Hypervisor
Netplan configuration:
---
network:
  version: 2
  ethernets:
    ens1f0: {}
    ens1f1: {}
    lo:
      match:
        name: lo
      addresses:
        - <IP_ADDRESS>/32
  bonds:
    bond0:
      dhcp4: false
      dhcp6: false
      interfaces:
        - ens1f0
        - ens1f1
      parameters:
        mode: 802.3ad
        mii-monitor-interval: 100
  bridges:
    cloudbr0:
      interfaces:
        - bond0.2007
      addresses:
        - <IP_ADDRESS>/24
      parameters:
        stp: false
        forward-delay: 5
      mtu: 9000
    cloudbr2:
      interfaces:
        - bond0.2003
      addresses:
        - <IP_ADDRESS>/24
      dhcp4: false
      routes:
        - to: default
          via: <IP_ADDRESS>
      nameservers:
        addresses:
          - <IP_ADDRESS>
          - <IP_ADDRESS>
      mtu: 1500
    cloudbr1:
      interfaces:
        - bond0
      parameters:
        stp: false
      mtu: 1500
  vlans:
    bond0.2000:
      id: 2000
      link: bond0
    bond0.2003:
      id: 2003
      link: bond0
      mtu: 1500
    bond0.2007:
      id: 2007
      link: bond0
      mtu: 9000

SUMMARY

When adding a host to CloudStack, the auto-detected private NIC value is cloudbr2, which does not appear to respect the assigned traffic labels in CloudStack. When attempting to hard-code the values in agent.properties the values are not respected and are modified to values that do not correctly reflect the traffic labels.
STEPS TO REPRODUCE

1. Update agent.properties with a private.network.device=cloudbr0.
2. Start cloudstack-agent.
3. Add host in CloudStack UI using the IP address associated with cloudbr2.

EXPECTED RESULTS

Host is added successfully to CloudStack.

ACTUAL RESULTS

Host does not add and times out with a 530 error.

Manually updating private.nic.device agent.properties during the host add process can successfully complete the host add.

This was a source of confusion regarding the names of interfaces in the agent file. It was not abundantly clear in the documentation that private could also be considered the management bridge.


Color Themes

New colors themes ? Awesome ! How can i change it ? Thanks

The themes have been moved to a "plus" pack called "COBOL Plus pack"
Once this is installed look for themes that start with the name "throwback".
https://marketplace.visualstudio.com/items?itemName=bitlang.cobol-plus-pack


Rename mapPropsOnUpdate -> mapPropsOnChange

The word "update" wrongly implies that shouldComponentUpdate() is somehow involved.

Yes!


CI build job "install-charts" should install charts with k8s 1.18, 1.21 and 1.23

Motivation
We should make sure that the Helm chart is compatible with older and newer versions of k8s.
Proposed change
Use a matrix job in .circleci/config.yml to run the install-charts job with multiple k8s versions

With a small change it's possible to make the k8s version parameterized in the CI scripts:
https://github.com/datastax/pulsar-helm-chart/blob/master/tests/e2e-kind.sh#L10
readonly K8S_VERSION="${K8S_VERSION:-"v1.21.2"}"

the available K8S_VERSIONs supported by kind can be checked from kindest/node docker image: https://hub.docker.com/r/kindest/node/tags?page=1&ordering=last_updated


Any suggestions to creating a translated menu?

menu{locale}.yml or would you
main:
    - label: home/{locale}
      title: This is the first menu item.
      path: homepage
      class: first
[etc...]

p.s.: Sorry for skipping on the SEO. I'm still working on it.
*edit:
nvm. Found the answer: removing the title property from the menu will replace it with the title for the set language.

I usually do something like this:
main:
  - label: 'Om Oss'
	enlabel: 'About Us'
	path: sidor/om-oss
  - label: 'Om tjänsten'
	enlabel: 'About the solution'
	path: sidor/om-loesning

and then in my menu.twig I do {{ item[app.request.get('_locale')~'label'] ?: item.label }}.


new api route to get list of account holders with their balance

I'd love to see new api routes for the dashboard.
Here is one of them (I'll make a different issue per route to easily track and get examples so that others can add such routes in the future)
GET /api/[:tokenAddress|:tokenSymbol]/holders.json

returns
[
  {
    "address": "0x...",
    "username": "xavier",
    "profile_ipfs": "cid",
    "balance": "BigInt balance string",
    "firstTransactionAt": datetime,
    "lastTransactionAt": datetime
  },
 ...
]

Would we want to model all calls like RPC requests (https://ethereum.org/en/developers/docs/apis/json-rpc#eth_getlogs)?
For example:
POST /rpc
method_name: cw_accountHolders
params: [:tokenAddress|:tokenSymbol, :limit, :offset]
Then people can just use the JSONRPCProvider from ethers

For calls to evm nodes, it's methods with eth_..., for the indexer, it could be cw_...

I don't have a strong opinion on it. My preference is for a classic easy old fashion REST api but that's because I'm old. As long as the feature works and there is no friction for people to try it (it's a read only call so no auth should be required), I'm good.


Fix Child Process not working for BGREWRITEAOF on MacOS + Logging Improvements

This PR fixes BGREWRITEAOF failing completely, Specifically for MacOS for now .
The root cause is that macos doesn't set pid to 0 for child process
The solution is to record get original pid of main process and do isChild := syscall.Getppid() == originalPID. The pid == 0 check is unreliable and breaks on maocs m2 in my testing.
This PR also adds logging features and a bit of refactoring to reuse code and allow for logger.With(...attrs) to be logged correctly

@lucifercr07 @vinitparekh17 could you review the changes here?

Please rebase on the latest master

@JyotinderSingh , done

@JyotinderSingh are there any blockers to merge this? Any effort required from my end?

@JyotinderSingh are there any blockers to merge this? Any effort required from my end?

Reviewing this

@lucifercr07 i couldn't find the exact docs, but i did find a lot of people facing the same issue: https://news.ycombinator.com/item?id=19622758
also, apparently, both implementations of golang and python had to deal with such peculiarities on MacOS

Thank you for these changes.


Fix/documents

Description

rename document file : ScanGroundFilter.md -> README.md
remove template comments

Review Procedure

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Read pull request guidelines
[x] Code follows coding guidelines
[x] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code follows coding guidelines
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the guidelines.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@satoshi-ota Please change the PR title to Remove template comments from node documents or something like that.


Use active tag filters as default tags for new tasks

If the user has filtered the task page by certain tags, use those tags by default for new tasks

Done in https://github.com/NickSavage/Zettelgarden/commit/008e8f2f2a563b4222ad25dcfbc015ed481e53f3


Input format of test data for the neural group classification model

Hi, can you please uploade some test data that I may use for doing a validation run of the classification model? From the provided code I am not completely sure about which format I should provide my beta values in - should it be samples in rows and beta values in columns for each of the 1289 CpG sites, with or without the cg-identifiers as headers?
thanks in advance

Hi Jakjes,
Pardon me for the late reply. I'll upload test data and the instructions about the format in a couple of days!
robin

Hi Robin,
Thanks, I look forward to trying it out 😊
Best regards,
jakob
Jakob Schmidt Jespersen, PhD
Staff Scientist
Weischenfeldt group
University of Copenhagen
Biotech Research and Innovation Centre (BRIC) /
Finsen Laboratory, Rigshospitalet
Ole Maaløes Vej 5
Building 3, 3rd floor
2200 Copenhagen N
DENMARK
TEL +45 35 33 61 57
<EMAIL_ADDRESS>http://www.bric.ku.dk/
[Logo for Københavns Universitet]
How we protect personal datahttps://informationssikkerhed.ku.dk/english/protection-of-information-privacy/privacy-policy/
From: Robin @.>
Reply to: imsb-uke/epigenetic-neural-glioblastoma @.>
Date: Wednesday, 12 June 2024 at 12.55
To: imsb-uke/epigenetic-neural-glioblastoma @.>
Cc: Jakob Schmidt Jespersen @.>, Author @.***>
Subject: Re: [imsb-uke/epigenetic-neural-glioblastoma] Input format of test data for the neural group classification model (Issue #1)
Du får ikke ofte mails fra @.*** Få mere at vide om, hvorfor dette er vigtigthttps://aka.ms/LearnAboutSenderIdentification
Hi Jakjes,
Pardon me for the late reply. I'll upload test data and the instructions about the format in a couple of days!
robin
—
Reply to this email directly, view it on GitHubhttps://github.com/imsb-uke/epigenetic-neural-glioblastoma/issues/1#issuecomment-2162708058, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BJAUMTLBHD2BVXE5SQUUTJ3ZHASLDAVCNFSM6AAAAABI6X3QU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRSG4YDQMBVHA.
You are receiving this because you authored the thread.Message ID: @.***>

Hi Jacob,
I added example data and notebook at https://github.com/imsb-uke/epigenetic-neural-glioblastoma/tree/main/code/example_neural_classification
To keep the same processing as the training data, I would recommend to also process the IDAT. The notebooks contains the steps from IDAT to prediction and displays the data formats.
Let me know if something is unclear.

closing the issue for now as an example run is added. Reopen if necessary.

Thanks Robin,
it looks like a good and adequate description of the required data format and pre-processing steps. I will give it a try and get back to you if I experience problems with running the classifier.
Best regards,
jakob
From: Robin @.>
Reply to: imsb-uke/epigenetic-neural-glioblastoma @.>
Date: Saturday, 15 June 2024 at 14.21
To: imsb-uke/epigenetic-neural-glioblastoma @.>
Cc: Jakob Schmidt Jespersen @.>, Author @.***>
Subject: Re: [imsb-uke/epigenetic-neural-glioblastoma] Input format of test data for the neural group classification model (Issue #1)
Du får ikke ofte mails fra @.*** Få mere at vide om, hvorfor dette er vigtigthttps://aka.ms/LearnAboutSenderIdentification
Hi Jacob,
I added example data and notebook at https://github.com/imsb-uke/epigenetic-neural-glioblastoma/tree/main/code/example_neural_classificationhttps://github.com/imsb-uke/epigenetic-neural-glioblastoma/tree/main/code/example_neural_classification
To keep the same processing as the training data, I would recommend to also process the IDAT. The notebooks contains the steps from IDAT to prediction and displays the data formats.
Let me know if something is unclear.
—
Reply to this email directly, view it on GitHubhttps://github.com/imsb-uke/epigenetic-neural-glioblastoma/issues/1#issuecomment-2169445529, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BJAUMTO443ZYL4ZYZZO6KL3ZHQWVLAVCNFSM6AAAAABI6X3QU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGQ2DKNJSHE.
You are receiving this because you authored the thread.Message ID: @.***>


Resting badge count to 0 on app launch

Hi Guys,
I am facing one issue on iOS i.e on app launch my app icon badge resetting to zero that means not showing badge count on icon. I have to keep those as it is.@raix Any help?
Thanks,

@raix Need your help into this.

@mitiaptest are you saying that when you open up the app after receiving a push notification (when notification count is lets say 2) it resets it to 0?
Just want to confirm, because if that is the case - thats desired functionality, after a users opens the app following a push notification the badge should reset to zero.
If you referring to something else please describe

Hey @harryward thanks for reply,Yes when I open the app (not coldstart) by clicking on app icon its resets badge count to 0.How to overcome it because on message read I need to decrement badge count and set decremented value for badge on app icon.
In this plug-in we have  Push.setBadge() method but if app open and close between one or less than second it will reset badge to zero.If app open and user keep app open more than 2 or 3 second then this method invokes and assigned badge count value set(it works) but for quick open and close its not works.
Any idea?
Thanks,

@harryward Need your help on this.

Please try<EMAIL_ADDRESS>

I have to Hit following command in my meteor directory
$ meteor remove raix:push
$ meteor add<EMAIL_ADDRESS>correct? @raix

or edit the .meteor/packages file

Thanks @raix


Add chart for consul-exporter

What this PR does / why we need it:
Adds a chart to the stable track for consul_exporter from prometheus.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X ] DCO signed
[X ] Chart Version bumped
[ X] Variables are documented in the README.md

Thanks @davidkarlsen. Added RBAC and PSP to the chart, and have renamed to fit the existing pattern for prometheus exporters

/assign @davidkarlsen

@timm088 can you signoff your commits please?

@davidkarlsen could you add the /approve please so the test can proceed

/ok-to-test

/lgtm


docs(do): add more details about the operator

Description: Add detail about do operator regarding error handling.
Related issue: Related to #2425.

Coverage remained the same at 97.687% when pulling 8d43d87165afab05256cc72fd09bcd76075742a4 on lemind:update-do-doc into ee1ce301b275b2f537cbe3418eed47b7c91fbdc0 on ReactiveX:master.

LGTM, thanks @lemind


Fix sysrepo bindings up to sysrepo v2.1.42

v3 go brrrr
I mainly fixed the bindings and the examples in order to make it work with last sysrepo version. Probably some stuff is missing, since I fixed naming and deleted missing definitions, but didn't pay much attentions to add new ones.
btw, thnks for your work @sjtakada. I really enjoyed discovering Rust with your code :)

Fix https://github.com/sjtakada/sysrepo-rs/issues/3


implement dynamic resize

have not merged centre icon resize yet...

@jianxuancao need your help on the fullscreen function and also integrating the icon resize also here.
The radial menu is now dynamic based on the current window size.
Once we get this to work, ill add the expand/dock feature to the building area

I've made the icon(with the center icon) resize on the radialmenu branch, do you wangt me to merge it to the master first?

sounds good, can you review this as well?

I've made the icon(with the center icon) resize on the radialmenu branch, do you wangt me to merge it to the master first?
sounds good, can you review this as well?

Im trying to do something like this with the magifier icons
https://marketplace.visualstudio.com/items?itemName=VisualStudioPlatformTeam.Double-ClickMaximize&ssr=false#overview
If you remember, Dean wanted us to do a fullscreen button.
One idea is just to bundle this extension with ours, and use askKita doubleclick, however I feel like the current implementation is very close I might be missing some details

I have the fullscreen working better now @jianxuancao . I think it is "good enough" we will integrate the other things tomorrow


Rewrite the parser with parser combinators

This PR uses the Chumsky library to rewrite the parser using parser combinators with the goal of the parser being smaller, more maintainable, and have better error recovery schemes.
Current state of this PR:

All existing Noir projects in the examples directory (and files included from the stdlib) parse correctly
I may experiment more with error recovery schemes or error reporting in general tomorrow. When this happens I may upload pictures if there's any noticeable difference in error quality. Current errors are very similar to the previous parser's save for some wording changes.
I'm opening this PR before then due to its size and the time difference in our team. It is in a merge-able state without these changes.

A few notes:

Chumsky's parsers are encoded via the same trick Iterators use in rust: each method returns a new type which implements the same trait so that they can be fused and monomorphised. In general this works well, though readability suffers for recursive parsers (parse_type and expression in this PR). The reason for this is the intermediate structure must be constructed, and if this is done recursively then the program will not terminate. The workaround is to use the recursive combinator and pass around the recursive part explicitly.
Chumsky supports more error recovery schemes than I used here. In particular we can skip to the next semicolon if a statement fails to parse, skip to the next } if a block fails to parse, or even infer a mismatched ] was a typo for } to close a block, and use that to recover.
The majority of the parser is now in noirc_frontend/src/parser/parser.rs. There are also some helper combinators in parser/mod.rs along with the NoirParser<T> trait for a parser that parses into a T value.

LGTM


adding presentationMode flag to CLI

This PR adds support to --presentationMode flag (alias --pm) to default Flame app in presentation mode
Usage example:
clinic flame --presentationMode -- NODE ../node-clinic-doctor-examples/slow-event-loop outputs
or
clinic flame --pm -- NODE ../node-clinic-doctor-examples/slow-event-loop outputs

why was this closed?


Bower support

Hi!
First of all tanks for your work. I really appreciate this plugin. But could you add even the bower support?
Thanks :D

@callmecavs are you adding it to bower registry? If not, I can give a hand if okay.

really torn here. I'm an ES6 proponent, and this is an ES6-first project. I believe that NPM isn't only for Node packages anymore. I'd like to encourage people transitioning to a modern workflow (ES6, module bundling), and away from script tags. Bower also doesn't support nested dependencies, which for this library isn't an issue, but is for many others. in all likelihood, projects using Bower are also using NPM, and for that reason as well as the others, I'm opting to no longer support Bower with my libraries.
on the other hand, I do understand making the library as accessible as possible. for that reason, I wrap my dist files in a UMD module, which can be run directly in the browser, with a simple script tag. my recommendation would be to use it that way, if not with NPM. I do appreciate your input tho


📝 arrowParentheses asNeeds breaks the code

Environment information
❯ biome rage
CLI:
  Version:                      1.4.1
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "alacritty"
  JS_RUNTIME_VERSION:           "v20.10.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              true
  Organize imports disabled:    true
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

Go to https://github.com/getsentry/sentry
Clone it
Copy the following biome.json

{
  "$schema"<EMAIL_ADDRESS>  "vcs": {
    "enabled": true,
    "clientKind": "git",
    "useIgnoreFile": true
  },
  "organizeImports": {
    "enabled": false
  },
  "linter": {
    "enabled": false
  },
  "files": {
    "ignoreUnknown": true
  },
  "formatter": {
    "enabled": true,
    "formatWithErrors": true,
    "ignore": [
      "api-docs",
      ".github",
      "tests",
      "fixtures",
      "scripts",
      "src",
      "static/app/data/world.json",
      "static/app/**/*trace.json",
      "package.json"
    ]
  },
  "javascript": {
    "formatter": {
      "enabled": true,
      "bracketSpacing": false,
      "bracketSameLine": false,
      "lineWidth": 90,
      "semicolons": "always",
      "quoteStyle": "single",
      "indentWidth": 2,
      "trailingComma": "es5",
      "arrowParentheses": "asNeeded",
      "indentStyle": "space",
      "jsxQuoteStyle": "double",
      "quoteProperties": "asNeeded"
    }
  },
  "json": {
    "formatter": {
      "enabled": true,
      "indentStyle": "space"
    }
  }
}

Run the following:

npx @biomejs/biome check ./static/app/components/charts/eventsRequest.tsx

Expected result
The produced code is wrong:
❯ npx @biomejs/biome check ./static/app/components/charts/eventsRequest.tsx
./static/app/components/charts/eventsRequest.tsx format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ℹ Formatter would have printed the following content:

    394 394 │     calculateTotalsPerTimestamp(
    395 395 │       data: EventsStatsData,
    396     │ - ····getName:·(
    397     │ - ······timestamp:·number,
    398     │ - ······countArray:·{count:·number}[],
    399     │ - ······i:·number
    400     │ - ····)·=>·number·=·timestamp·=>·timestamp·*·1000
        396 │ + ····getName:·(timestamp:·number,·countArray:·{count:·number}[],·i:·number)·=>·number·=
        397 │ + ······timestamp
        398 │ + ····=>·timestamp·*·1000
    401 399 │     ): SeriesDataUnit[] {
    402 400 │       return data.map(([timestamp, countArray], i) => ({

Code of Conduct

[X] I agree to follow Biome's Code of Conduct

I reduced this down to a minimal repro here: Playground Link
There are two issues that combine here:

First is the formatting itself. Prettier uses a shortcut when the parentheses for an arrow function get omitted that avoids adding a group around the parameter, but Biome doesn't have this logic. I believe that is the reason for the initial formatting difference.
The second issue is that when re-formatting, Biome is unable to parse the result, I believe because of the ambiguity about a default parameter value and an arrow function. This is a separate manifestation of #1077, which was fixed in #1113, but will need to be resolved for Biome to be able to format and parse this consistently.


[Deploy] gpt memory issue

Gpt cannot reference correct past responses for memory retain in product env

memory issue fixed after streaming corrected


If I change to another keyboard layout, it doesn't get any better, just different characters and symbols.
Using Ubuntu 18.04
ledger nano s firmware 1.4.2

I think you're confused as to how this works - the password string you enter yourself is just a piece of metadata for the real password. The real password is derived from it, AND your mnemonic seed. This means that you can simply keep a (preferably secure) backup of the metadata that you enter into the device along with your seed, so you can restore every password should you break/lose your device.

Ok - got it. I couldn't find a good documentation about this feature, so this was not obvious to me.
Thanks for the clarification.


Allow for empty body without headers for void responses

Resolves #79
Addresses two issues:

a Context-Type was expected even for void responses
a response of an empty dict would fail validation (because it wasn't None)

Coverage remained the same at 100.0% when pulling 06b33cde6297829f26e0a891153a0a2fb5e0c426 on dnephin:fix_void_body into e57b344272766e49dcb89c66fe5e1a878733fa50 on striglia:master.

Coverage remained the same at 100.0% when pulling 74f0fcd19a6f1cf8730a12aa9102fad42e26f2ec on dnephin:fix_void_body into e57b344272766e49dcb89c66fe5e1a878733fa50 on striglia:master.

Coverage remained the same at 100.0% when pulling e731bd24b9e1d34eb469f4f0e470a6517735fe01 on dnephin:fix_void_body into e57b344272766e49dcb89c66fe5e1a878733fa50 on striglia:master.

Mind adding a bugfix note in the changelog too?

Added a note to the changelog, and also fixed the url warnings for urls that were being redirected now that the github repo has moved.

Coverage remained the same at 100.0% when pulling 23651d1972ff200fa9e93f5b5832dd2b2b223b14 on dnephin:fix_void_body into e57b344272766e49dcb89c66fe5e1a878733fa50 on striglia:master.


"@getters::package:flutter/src/ widgets/widget_inspector.dart::_location is already bound"

I got a crash when hot restarting, as shown below. I've no idea how to reproduce, but I suspect the (legitimate) compilation error I got in the previous hot restart may be related?
Here's the logs with commentary:
ianh@burmese:~/dev/house-of-rooves/dashboard$ flutter run -d linux --pid-file /tmp/flutter.pid
Launching lib/main.dart on Linux in debug mode...
Building Linux application...

The above is just the regular flutter run output. Then there's some dbus issue:
(house_of_rooves_dashboard:14187): GLib-GIO-CRITICAL **: 15:09:55.897: g_dbus_proxy_new_sync: assertion 'G_IS_DBUS_CONNECTION (connection)' failed

Then there's some logs from my code which we can ignore:
flutter: requesting records...
flutter: receiving records...

The sync finishes:
Syncing files to device Linux...                                   119ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h Repeat this help message.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).
An Observatory debugger and profiler on Linux is available at:
http://<IP_ADDRESS>:33651/SVCyHnI9l6w=/

Running with unsound null safety
For more information see https://dart.dev/null-safety/unsound-null-safety

Then there's some more logs from my code and an exception because I'm using a plugin for sound that doesn't have a Linux port yet; we can ignore all that:
flutter: 720 records received in 1s
[ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: MissingPluginException(No implementation found for method initSoundpool on channel pl.ukaszapps/soundpool)
#0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:156:7)
<asynchronous suspension>
#1      Soundpool._connect (package:soundpool/soundpool.dart:290:20)
<asynchronous suspension>

At this point I hit R to hot restart, but I had a typo in my code so that failed. Weirdly, the logs are all out of order here, with the "Performing hot restart" being printed after the compilation error message:
lib/main.dart:47:57: Error: The getter 'inMillieconds' isn't defined for the class
'Duration'.
 - 'Duration' is from 'dart:core'.
Try correcting the name to the name of an existing getter, or defining a getter or field
named 'inMillieconds'.
  print('$count records received in ${stopwatch.elapsed.inMillieconds}ms');
                                                        ^^^^^^^^^^^^^
Performing hot restart...
Restarted application in 259ms.
Try again after fixing the above error(s).

I then fixed the typo and hit R again, and that's when the exception that this bug is about happened:
Unhandled exception:
root::package:house_of_rooves_dashboard/main.dart::Dashboard::@getters::package:flutter/src/
widgets/widget_inspector.dart::_location is already bound
#0      CanonicalName.bindTo (package:kernel/canonical_name.dart:200:7)
#1      Class.computeCanonicalNames (package:kernel/ast.dart:1205:51)
#2      Library.computeCanonicalNames (package:kernel/ast.dart:561:14)
#3      Component.computeCanonicalNamesForLibrary (package:kernel/ast.dart:10800:13)
#4      Component.computeCanonicalNames (package:kernel/ast.dart:10762:7)
#5      sortComponent (package:vm/kernel_front_end.dart:679:13)
#6      FrontendCompiler.writeDillFile (package:frontend_server/frontend_server.dart:656:5)
#7      FrontendCompiler.recompileDelta
(package:frontend_server/frontend_server.dart:766:13)
<asynchronous suspension>
the Dart compiler exited unexpectedly.
Performing hot restart...                                              ⣟the Dart compiler exited unexpectedly.
the Dart compiler exited unexpectedly.
ianh@burmese:~/dev/house-of-rooves/dashboard$

Full unedited logs
ianh@burmese:~/dev/house-of-rooves/dashboard$ flutter run -d linux --pid-file /tmp/flutter.pid
Launching lib/main.dart on Linux in debug mode...
Building Linux application...

(house_of_rooves_dashboard:14187): GLib-GIO-CRITICAL **: 15:09:55.897: g_dbus_proxy_new_sync: assertion 'G_IS_DBUS_CONNECTION (connection)' failed
flutter: requesting records...
flutter: receiving records...
Syncing files to device Linux...                                   119ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h Repeat this help message.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).
An Observatory debugger and profiler on Linux is available at:
http://<IP_ADDRESS>:33651/SVCyHnI9l6w=/

Running with unsound null safety
For more information see https://dart.dev/null-safety/unsound-null-safety
flutter: 720 records received in 1s
[ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: MissingPluginException(No implementation found for method initSoundpool on channel pl.ukaszapps/soundpool)
#0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:156:7)
<asynchronous suspension>
#1      Soundpool._connect (package:soundpool/soundpool.dart:290:20)
<asynchronous suspension>

lib/main.dart:47:57: Error: The getter 'inMillieconds' isn't defined for the class
'Duration'.
 - 'Duration' is from 'dart:core'.
Try correcting the name to the name of an existing getter, or defining a getter or field
named 'inMillieconds'.
  print('$count records received in ${stopwatch.elapsed.inMillieconds}ms');
                                                        ^^^^^^^^^^^^^
Performing hot restart...
Restarted application in 259ms.
Try again after fixing the above error(s).

Unhandled exception:
root::package:house_of_rooves_dashboard/main.dart::Dashboard::@getters::package:flutter/src/
widgets/widget_inspector.dart::_location is already bound
#0      CanonicalName.bindTo (package:kernel/canonical_name.dart:200:7)
#1      Class.computeCanonicalNames (package:kernel/ast.dart:1205:51)
#2      Library.computeCanonicalNames (package:kernel/ast.dart:561:14)
#3      Component.computeCanonicalNamesForLibrary (package:kernel/ast.dart:10800:13)
#4      Component.computeCanonicalNames (package:kernel/ast.dart:10762:7)
#5      sortComponent (package:vm/kernel_front_end.dart:679:13)
#6      FrontendCompiler.writeDillFile (package:frontend_server/frontend_server.dart:656:5)
#7      FrontendCompiler.recompileDelta
(package:frontend_server/frontend_server.dart:766:13)
<asynchronous suspension>
the Dart compiler exited unexpectedly.
Performing hot restart...                                              ⣟the Dart compiler exited unexpectedly.
the Dart compiler exited unexpectedly.
ianh@burmese:~/dev/house-of-rooves/dashboard$

I believe the issue with linux builds will be fixed by https://github.com/flutter/flutter/pull/72196
The actual compilation error should already be fixed, but it is waiting on a dart roll. You can work around this by running flutter config --no-experimental-invalidation-strategy

I believe the issue with linux builds will be fixed by https://github.com/flutter/flutter/pull/72196
The actual compilation error should already be fixed, but it is waiting on a dart roll. You can work around this by running flutter config --no-experimental-invalidation-strategy

The underlying dart issues has been fixed (though after looking I can't find the commit :(   )


Sample improve

fix location of cursor icon, install it
fix drdynvc load

@pnowack not sure this affects g-r-d or not, could you verify?


Open Telemetry : Adds query text in attribute

Description

Added db.query.text attribute to record queries in Traces.
Introduced new ShowQueryMode, which will have valid values as
a) NONE :Do not show query.
b) PARAMETERIZED_ONLY : Print parameterized query only.
b) ALL
It can be set as part of CosmosClientTelemetryOptions and RequestOptions (i.e. QueryRequestOptions and ChangeFeedRequestOptions)

Type of change

[] New feature (non-breaking change which adds functionality)

Reqeustlevel override feels over engineering, Thoughts?

verride feels over engineering, Thoughts?

It is taken from Java SDK and I believe, It will provide customers with the option to enable or disable the inclusion of query text in OpenTelemetry (OTel) traces for specific types of queries.


Rename GetAssetBundleRequest

https://github.com/vegaprotocol/protos/blob/develop/sources/data-node/api/v2/trading_data.proto#L421
This provide the bundle for the ListAsset method, the call should be rename to reflect that (that doesn't sounds like much, but a new call will be require some day to DelistAsset too, so it'll make things easier).

related to

https://github.com/vegaprotocol/system-tests/issues/337


[Bug]: Unable to take screenshot on multiples pages that are playing video in fullscreen

Bug description
My purpose is to take  screenshots on multiple pages at the same time while those pages are playing video on fullscreen
but it`s not working for me, in my observation it taking screenshot by changing the tab one by one and it caused it cannot take screenshot while pages playing video on fullscreen
Steps to reproduce the problem:

run the onePageIsFine function in the script
after the function finished check the onePageIsFine.png file in the current path you will see it works
run the oneMorePageWillNotWork function in the script
after the function finished check the images start with oneMorePageWillNotWork*.png in the current path
you will see it does not work, it did not take a screenshot while the page playing the video on fullscreen

const puppeteer = require('puppeteer')
let browser = null;

async function newPage(browser) {
    const page = await browser.newPage()
    let currentScreen = await page.evaluate(() => {
        return {
            width: window.screen.availWidth,
            height: window.screen.availHeight,
            deviceScaleFactor: 1
        };
    });

    await page.setViewport(currentScreen);
    await page.setUserAgent('Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.5112.79 Safari/537.36')
    return page;
}

async function takeScrrenshot(page, nameForSaveTheImg, times) {
    if(times > 0) {
        await page.screenshot({ path: nameForSaveTheImg })
        await page.waitForTimeout(500);
        await takeScrrenshot(page, nameForSaveTheImg, times - 1)
    }
}

async function playTheVideoInFullScrren(page) {
    await page.waitForSelector('.ytp-fullscreen-button')
    await page.click('.ytp-fullscreen-button')
}

async function onePageIsFine(page) {
    const onePageScrrenshotOnFullScrrenVideo = {
        page: await newPage(browser),
        goto: 'https://www.youtube.com/watch?v=gvAF9mboxFM',
        nameForSaveTheImg: 'onePageIsFine.png'
    }
    await oneMorePageWillNotWork([onePageScrrenshotOnFullScrrenVideo])
}

async function oneMorePageWillNotWork(pages) {
    pages = pages !== null && pages !== undefined ? pages : [
        {page: await newPage(browser), goto: 'https://www.youtube.com/watch?v=Nb5yppVh_4A', nameForSaveTheImg: 'oneMorePageWillNotWork1.png'},
        {page: await newPage(browser), goto: 'https://www.youtube.com/watch?v=kZC12U6EhTc', nameForSaveTheImg: 'oneMorePageWillNotWork2.png'},
        {page: await newPage(browser), goto: 'https://www.youtube.com/watch?v=0oBi8OmjLIg', nameForSaveTheImg: 'oneMorePageWillNotWork3.png'}
    ]

    await pages.forEach(async pageEl => {
        await pageEl.page.goto(pageEl.goto)
        await playTheVideoInFullScrren(pageEl.page)
        setTimeout(async () => {
            await takeScrrenshot(pageEl.page, pageEl.nameForSaveTheImg, 3)
            await pageEl.page.close()
        }, 3000);
    });
}

async function init() {
    browser = await puppeteer.launch(
        {
            executablePath: '/usr/bin/chromium',
            headless: false,
            userDataDir: './userData',
            args: ['--start-maximized', '--proxy-server=<IP_ADDRESS>:1080', "--window-size=1920,1080", "--window-position=1921,0"],
            ignoreDefaultArgs: ["--enable-automation"]
        })
}

async function closeTheBrowserAtTheRightTime() {
    //close the browser after 20 seconds.
    setTimeout(async () => {
        await browser.close()
    }, 20000);
}

async function main() {
    await init()
    // await onePageIsFine()
    // await oneMorePageWillNotWork()
    await closeTheBrowserAtTheRightTime()
}

main()

Puppeteer version
^16.1.0
Node.js version
v18.7.0
npm version
8.17.0
What operating system are you seeing the problem on?
Linux
Relevant log output
No response

Here is the script
script.zip

before run the script you may need to change the arguments of the puppeteer.launch function.

The issue sounds similar to https://github.com/puppeteer/puppeteer/issues/8819 As for taking screenshots in parallel, I am not sure that's expected to work.

@OrKoN  Thanks for your reply.
It is not same issue. #8819 is the issue about unable to play video on fullscreen in headless mode. This issue is about unable to take a scrrenshot on each page while all of the pages are playing the video in fullscrren mode. Do you mean it is not possible take screenshot on multiple pages while those pages are playing videos in fullscreen mode ?

Ah, I see. Which version is /usr/bin/chromium?

@OrKoN
I tested the script in the windows system and the result is the same but any way here is the version of the /user/bin/chromium

Chromium
104.0.5112.79 (Official Build) Arch Linux (64-bit)

Revision
3cf3e8c8a07d104b9e1260c910efb8f383285dc5-refs/branch-heads/5112@{#1307}

OS
Linux

JavaScript
V8 <IP_ADDRESS>

User Agent
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.5112.79 Safari/537.36

Command Line
/usr/lib/chromium/chromium --enable-crashpad --enable-features --disable-features=EventPath --flag-switches-begin --flag-switches-end --desktop-startup-id=gnome-shell/Chromium/1342-1-ontheroad-81yw_TIME28635

Executable Path
/usr/lib/chromium/chromium

Profile Path
/home/ontheroad/.config/chromium/Default

Active Variations
8d569531-4f54ac4d

@OrKoN
I tested the script in windows system but the result is the same but anyway here is the version of the /user/bin/chromium

Chromium
104.0.5112.79 (Official Build) Arch Linux (64-bit)

Revision
3cf3e8c8a07d104b9e1260c910efb8f383285dc5-refs/branch-heads/5112@{#1307}

OS
Linux

JavaScript
V8 <IP_ADDRESS>

User Agent
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.5112.79 Safari/537.36

Command Line
/usr/lib/chromium/chromium --enable-crashpad --enable-features --disable-features=EventPath --flag-switches-begin --flag-switches-end --desktop-startup-id=gnome-shell/Chromium/1342-1-ontheroad-81yw_TIME28635

Executable Path
/usr/lib/chromium/chromium

Profile Path
/home/ontheroad/.config/chromium/Default

Active Variations
8d569531-4f54ac4d

@OrKoN
Maybe this is a bug of the puppeteer but  I found a solution for this problem. I don't need to play the video in full screen and then take a screenshot, I just need to screenshot the element of the video stream.
Here is the core change of the script above
async function takeScrrenshot(page, nameForSaveTheImg, times) {
    if(times > 0) {
        const video = await page.waitForSelector('.video-stream')
        await video.screenshot({path: nameForSaveTheImg})
        // await page.screenshot({ path: nameForSaveTheImg })
        await page.waitForTimeout(5000);
        await takeScrrenshot(page, nameForSaveTheImg, times - 1)
    }
}


unreachable error running Benchmark test on M1 Mac

This PR is related to https://github.com/line/cosmwasm/pull/250
After checking, this problem in the benchmark test was not specific to M1, but was caused by differences in machine performance.
Therefore, the problem is not specific to M1, but can be caused by the performance of Intel machines as well.
Summary
When test is executed, the following error occurs for M1.
$pwd
~/cosmwasm/packages/vm
$cargo bench --no-default-features --features bench -- --color never --save-baseline singlepass
Benchmarking DynamicLink/native_dynamic_link_trampoline with dummy contract_call
Benchmarking DynamicLink/native_dynamic_link_trampoline with dummy contract_call: Warming up for 3.0000 s
Benchmarking DynamicLink/native_dynamic_link_trampoline with dummy contract_call: Collecting 12 samples in estimated 10.000 s (12M iterations)
Benchmarking DynamicLink/native_dynamic_link_trampoline with dummy contract_call: Analyzing
DynamicLink/native_dynamic_link_trampoline with dummy contract_call
                        time:   [839.67 ns 848.11 ns 853.57 ns]
                        change: [-35.259% -26.509% -16.533%] (p = 0.00 < 0.05)
                        Performance has improved.
Benchmarking DynamicLink/native_dynamic_link_trampoline with mock cache environment
Benchmarking DynamicLink/native_dynamic_link_trampoline with mock cache environment: Warming up for 3.0000 s
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: RuntimeErr { msg: "Wasmer runtime error: RuntimeError: unreachable" }', packages/vm/benches/main.rs:286:64
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This could be a problem with comswasm, or it could be a problem with INSTANCE_CACHE, a thread-local variable, or elsewhere.
However, when the thread is temporarily stopped by sleep!(), etc., test runs without error even in M1, so the cause may be around INSTANCE_CACHE, a thread-local variable.
Environment
$ rustup --version
rustup 1.25.1 (bb60b1e89 2022-07-12)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.63.0 (4b91a6ea7 2022-08-08)`
$ sysctl machdep.cpu.brand_string
machdep.cpu.brand_string: Apple M1 Pro

At this time, the team has taken the decision that M1 Mac developers (or those with high-spec PCs) will not benchmark locally.
This issue is low priority.

Since INSTANCE_CACHE is no longer used, this problem is also solved.
And this benchmarking test(native_dynamic_link_trampoline with mock cache environment) is also deleated.
via: https://github.com/Finschia/cosmwasm/pull/294, https://github.com/Finschia/cosmwasm/issues/295, https://github.com/Finschia/cosmwasm/pull/296


Add documentation and examples covering object data type.

Add documentation and examples showing how to insert, query, update objects... including arrays and nested objects.

Completed in #14


Better tools for "wait for promise or cancel"

Artax already has a withCancellation function to ease the "wait for promise or cancel" case. This is especially important for promises that won't resolve after cancellation such as backpressure promises.
Instead of adding a function, we could also add support for it within coroutines with yield $promise => $cancellationToken.

Amp v3 will introduce Future::await with an optional cancellation argument.


new OffHeapIncrementalIndex that does only aggregations off-heap

Our groupBy queries contain many metric columns of type thetaSketch which are big and lead to significant GC pressure on the process, this PR enables doing metric aggregation for group by queries completely off-heap.
changes introduced:

new OffHeapIncrementalIndex that is same as OnHeapIncrementalIndex but does aggregations in off-heap buffers.
configuration, "useOffheap",  to use OffHeapIncrementalIndex while GroupBy merging
configuration, "druid.computation.buffer.pool.cacheSize",  to set the upper limit on number of buffers that StupidPool can cache

Fixes #2297
I understand that this PR would have conflicts with some other open PRs. I will rebase and fix merge conflicts as and when other PRs get merged.

@himanshug have you thought at all about extending this PR and enabling on disk computations with groupBys?

@fjy This is a self-sufficient step that has immediate gains without introducing any major query latency.
I'm thinking about on-disk, but it is a challenge to do that without adding significant query latency... currently, I'm in the stage of brainstorming on that in the background. That said, current PR might enable larger groupBys than before.

@himanshug, does this need to be a blocker for 0.9.0 ?

@himanshug Have you guys ever tried enabling swap and using more direct byte buffers than available memory?

@drcrallen thanks for review, I will probably rework this a bit after https://github.com/druid-io/druid/pull/2085 is merged.
we have very high memory brokers and don't usually need swap at all. this PR is intended to avoid GC pauses really. at historicals, we have some subsets where more segments than available memory are loaded, but we have SSDs there and it works ok.

also, I do not want to block 0.9.0 RC because of this so setting the milestone for this to be 0.9.1
However, I will pull it in my internal distribution as soon as it is merged.

@drcrallen all review comments addressed.

:+1:

@drcrallen addressed comments.

Cool :+1: with 4 commits (after travis) @himanshug would you be willing to update this thread with performance numbers between onheap and offheap after your internal testing?

@drcrallen thanks, will update with test results, thatz why I haven't made the off-heap default but opt-in.


how to fix width of bars in bar chart

can anyone suggest how to fix the width of bars in bar chart? any option to set?

This is a question related to using Chart.js in the real world. We recommend you to also post this question to stackoverflow.com and tag with CHARTJS in order to get the most attention to your question.
If you do, please link from here to there and vice versa to get the most eyes on this.

closing, unresponsive, no SO link


Add extractor for downloading a complete series from iView

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[X] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[X] Searched the bugtracker for similar pull requests
[X] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[X] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[X] New extractor (playlists for IView)
[ ] New feature

Download series
This PR adds support for finding all episodes in a show from the ABC IView API (as a playlist).

@dstftw I think I've made all those changes.

@dstftw anything else required to merge?

I think that covers everything now, right?

Thanks for the pointers, python is not my strong suit. I've updated each of those sections.

@dstftw Are you happy with these changes?

@dstftw is there anything still outstanding on this?

@dstftw Builds are passing now and I believe all changes have been addressed.

@dstftw Anything still blocking this getting merged?


Context menu?

Anyone knows a context menu that works with RST?
I've tried both react-contexify and react-contextmenu but none of them works as expected.
Thanks

@rogerjak What exactly is wrong with the context menu libs you mentioned? Can you show us a demo?

I got it working with react-contextmenu, by wrapping the title with ContextMenuTrigger in generateNodeProps. Guess I have to use customNodeRenderer to be able to wrap the whole node?

@rogerjak you probably meant nodeContentRenderer not customNodeRenderer and yes - it looks like it. Why are you not able to wrap the whole the whole node with the way you are using it now? You can put multiple components in a title (or subtitle or whatever) and therefore the title will be you whole node.
Here's an example:
 title: (
	<div>
	  <NodePrefix prefix={node.prefix} />
	  <Autosuggest suggestions={this.props.state.suggestions} />
	  <NodeNumber number={node.number} />
	</div>
  )

I was using the provided icon prop, but you're right, I can move the icon into the title and wrap it. Thanks!

I have used this context menu and it is working fine.
https://github.com/vkbansal/react-contextmenu

I am going to close this. Seems to be resolved.


Moving ref frame

This pull request includes changes :

Adds a frame property such that the map can be shifted in the X/Y plane with a moving robot.
Change the reload behavior so that reloads are triggered after a larger amount of motion (~100 meters). This will be a parameter in future. (Credit to @chataign for these last two).
Added a pull-down for selecting the frame convention. ROS (X/Y -> North/West) and libGeographic (X/Y -> East/North) conventions are both supported now (ROS is the default, libGeographic was the previous default behavior). At present the rotation option does not actually use the quaternion in the TF, which we may wish to correct in future.
Some general comments on things to cleanup in future.

On the subject of 1 and 2, in my original use case, it was previously expected that the GPS topic would be latched (and published once) such that data would only be loaded once at the start of bag playback. However it seems more common for the topic to be constantly publishing, hence the larger reload distance and frame option for moving robots.

@chataign, merge whenever ready

Hi Gareth,
I just pushed some changes into a separate 'chataign' branch (is this the
right way to do it?)
The main change is that imagery is reloaded whenever the new vehicle
lat,lon (NavSatFix) falls outside the current centre tile, as that should
mean that some new tiles are needed to cover the specified number of
blocks. If that works then we don't need a distance threshold. I also made
a few of the changes you mentioned, like using shared pointers when
possible.
I haven't tested this properly yet as I don't have any data where the
vehicle travels long distances. I'll generate some fake GPS data tomorrow
to test. You might want to wait until I verify this works before having a
look.
Regards,
Francois
On 26 November 2015 at 21:04, Gareth Cross<EMAIL_ADDRESS>wrote:

@chataign https://github.com/chataign, merge whenever ready
—
Reply to this email directly or view it on GitHub
https://github.com/gareth-cross/rviz_satellite/pull/10#issuecomment-159986951
.

Yup, looks good. Just submit a pull request whenever you think it is ready. As for branch names, I usually try to describe the change in the name, for example 'fix/crash-in-startup' or 'feature/add-new-options'

Ok will do, just a quick question -- what's the purpose of the
received_msg_ flag?
is received_msg=false not equivalent to loader=NULL?
On 27 November 2015 at 09:18, Gareth Cross<EMAIL_ADDRESS>wrote:

Yup, looks good. Just submit a pull request whenever you think it is
ready. As for branch names, I usually try to describe the change in the
name, for example 'fix/crash-in-startup' or 'feature/add-new-options'
—
Reply to this email directly or view it on GitHub
https://github.com/gareth-cross/rviz_satellite/pull/10#issuecomment-160066093
.

Yes, I believe they are redundant, if not equivalent. I suspect the mutex_ is probably also not necessary, since it only gets locked in one place anyways. Probably just a bit of cruft from a previous implementation.


Replaced deprecated PackageInfo.signatures with PackageInfo.signingInfo

Replaced the deprecated PackageInfo.signatures with PackageInfo.signingInfo. Created a utility method across code and tests for compatibility reasons.
Work Item: https://identitydivision.visualstudio.com/Engineering/_workitems/edit/1226178
Issue: https://github.com/AzureAD/microsoft-authentication-library-common-for-android/issues/851

Another thought, actually:
#1256 (comment)

This is done - https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/1256/commits/69f62a9d150388bf80881fc8a4eb7cd7586e9366


Sometimes linebreaks are handled incorrectly

Sometimes linebreaks (<br />) immediately after links and/or images get removed incorrectly.
Also, when quoting certain messages, linebreaks ("\n") after  links and/or images may be doubled sometimes.
Example: #266 on https://lihkg.na.cx/thread/1465/page/11

Fixed, closing this

Is this really fixed?

@g3335491 I believe so

It seems to me that quoting still adds tons of linebreaks to the quoted message., even when there are no links or images... but perhaps it is a separated issue?

@g3335491 Can you give me the link to the thread?


Add in-app changelog

Would this simply pull the milestones from Github and display them?

I would probably want it to be compiled into the release. I found this library but I haven't had time to experiment: https://pub.dev/packages/flutter_whatsnew
In terms of implementation, I would want this to open once on first launch of a new version (after database re-download if required) and also to be accessible from the settings menu.


[BE] - Deprecate colab

Motivation and Context
Colab is a shifting foundtation for hosting tutorials. Back-end changes require updates to installers and scripts resulting in tutorial downtime and extra developer bandwidth load. Instead, we opt to deprecate Colab support and convert existing tutorials to locally-executable Jupyter notebooks.
examples/tutorials/colabs/ directory renamed to examples/tutorials/notebooks/
NOTE: partner habitat-sim PR: https://github.com/facebookresearch/habitat-sim/pull/2298
How Has This Been Tested
Locally ran the Jupyter notebooks
Types of changes

[Docs change] Addition or changes to the documentation

Checklist

[x] My code follows the code style of this project.
[x] I have updated the documentation if required.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes if required.

One quick question: are those jupyter notebook runnable?

Yes, I have been running them locally to test the changes. I didn't write the tutorials, so there may be some content decay, but the cells all run and produce output with no show-stopping runtime errors.


read: cache abbreviations at offset 0

This optimises for the case where there is a single set of abbreviations that is used for all units.

This would work perfectly for us, we wouldn’t even need any code changes vs the normal gimli calls.
Drawbacks as you said is a Mutex, plus the additional public field on Dwarf that is technically a breaking change.

Maybe you could use an AtomicPtr pointing to the cached data and have a null pointer represent not yet computed. Then multiple threads can race to compute it and when setting it compare_exchange can be used to detect if there was a race or not. If there was a race the local version can be discarded and the new version read.

Perhaps what I'll do is use AtomicPtr for no_std, and Mutex otherwise.

Using arc-swap might also be an option I think. I would argue in most cases you are single threaded anyway.

Another option might be to make it generic over traits from lock_api, and default to Mutex when using std. Probably not something I'll look into though unless someone wants this.

I would argue in most cases you are single threaded anyway.

We do need to support multi-threaded still. The dwarfdump example uses threads, and I think not-perf does too.

I think the locking question boils down to doing all this lazily. In my workaround I just pre-parse abbrevs at offset 0 at the very beginning when constructing the Dwarf, so I don’t need interior mutability at all. But the current API design (with everything being a public member) does not make that too easy either.

I think the locking question boils down to doing all this lazily. In my workaround I just pre-parse abbrevs at offset 0 at the very beginning when constructing the Dwarf, so I don’t need interior mutability at all.

Right, but do you think that interior mutability a problem? If we didn't need to support no_std, would this PR be fine as is? Does the benefit of all users automatically getting this improvement outweigh the cost of one mutex lock per unit?

But the current API design (with everything being a public member) does not make that too easy either.

Can you expand on how that does not make it easy? The current API design is because we don't have a strong commitment to stability, and having public members is meant to make things more flexible for users. For example, I think your workaround is only possible because of the public members?

Indeed, the fields being public was one reason why I was able to work around this in the first place.
I was just thinking that because of public members and struct literals, you don’t have a constructor to do work in. So you would either have to do lazy parsing with internal mutability, or put the burden on the user to correctly initialize the cache ahead of time. Which I found out I might have done wrong and was too overeager to just parse at offset 0 and propagate EOF errors for objects that have no abbrevs at all.
I don’t think there is anything wrong with that interior mutability, and I think its a good tradeoff to have locking there.

@bjorn3 Are you aware of any examples of using AtomicPtr with Arc? I think I want AtomicPtr<Abbreviations>, where the pointer is obtained from Arc::into_raw. I've seen an example of using it with Box::into_raw to initialize a static, but that's not what I want here.

Using arc-swap might also be an option I think.

Unfortunately it doesn't appear to support no_std.

Still looking into the code, but: I would normally use once_cell::sync::Lazy for this kind of thing. Unfortunately it looks like once_cell::sync::* is unavailable if the std feature is not enabled.


Docs listening: Clarified telemetry opt-out processes

Increased visibility in the product docs that telemetry data collection is opt-out, as well as the steps to opt-out via the System Console. Included links to the individual configuration setting docs for additional reference.

I love the changes. Much clearer.
The only thing I would like to add is a link somewhere within the sidebar/menu.
What do we think?

@jordanafung - You're correct that this page isn't accessible via the navigation pane. That's a historical choice worth revisiting.
@wiersgallak - Any concerns from your perspective about improving accessibility to this page by adding it to the nav pane?

I have no issues with moving it to the navigation, but I'll let @jasonblais also weigh in.

No concerns with having it in the navigation

@jordanafung - You'll find the Telemetry page available from the navigation pane via Mattermost administration > Self-hosted administration > Manage telemetry.
A new generated preview of the docs will be available soon.


Why do we need this premise?

https://github.com/Beluga-lang/McTT/blob/c33ec078d950caef349b48075db3abcadb5b5bee/theories/Core/Syntactic/System/Definitions.v#L86
Why is this? @Ailrun Things like this are good to recall, as we might need to talk about them in the paper.

I think it has something to do with subtyping being unidirectional. see also
https://github.com/Beluga-lang/McTT/blob/c01fbc90ac6b741fcc0872bf138e48f6fd28b5eb/theories/Core/Soundness/SubtypingCases.v#L91-L94
This lemma doesn't need the semantic well-formedness of A'.

Hm, that might the case for subtyping as well. I mean, completeness might resolve the need of the extra IH.


Create deadline group/pool implicitly while configuring SEP

After creating and configuring a spot fleet via RFDK constructs SpotEventPluginFleet & ConfigureSpotEventPlugin, there is a requirement for manually creating deadline groups and pools before the spot fleet request can be created.
Details here
This can be done by either

Running a deadline command to create group/pool, or,
Creating group/pool using deadline monitor.

This manual stop of creating the deadline groups/pools can be automated while deployment.
Use Case

With this feature, once a farm is deployed by the user, the only step required by an user to start using the spot fleet is to submit a job for this deadline group.
Proposed Solution

In order to eliminate this manual step of creating group/pool, an additional call can be made to RCS to automatically create the deadline group for which the spot request is being configured.

[ ] :wave: I may be able to implement this feature request
[ ] :warning: This feature might incur a breaking change

This is a :rocket: Feature Request

Note: Group/Pool names in Deadline must be lower-case.


Content root should be explicitly set

When running under linux, the content root default is not correct.

Fixed in 03d3b904793f789ab23004067c39b9b667f01d88


to_shapely and from_shapely updates

I noticed issue #54 was pushed to a next milestone and thus decided to put some work into it.
This PR adds a to_shapely() function and improves the from_shapely() function to also work when the GEOS versions of both library do not match, by going through the WKB format (similarly to how geopandas handles things).
This implementation is implemented purely in python, as I do not know how we should create shapely objects from C.
I still believe it is worth adding, as this fills a "gap" in the current pygeos pipeline, and we can still optimize it without affecting the public API, later down the road...
Remarks / TODO:

[ ] Unit Test to_shapely() when GEOS versions are the same. This would mean mocking shapely.geos.lgeos.GEOSGeom_clone() and shapely.geometry.base.geom_factory(). I am not completely sure if it is worth it / necessary, as we would effectively be mocking 90% of the functionality...
[X] ~Contrary to geopandas, these implementations do not work with the __geo_interface__. I don't have any experience with this interface and don't really know what to expect here, so I currently cannot work on this.~
Let's keep the to_* and from_* functions simple.
[X] ~Instead of using shapely.geos.lgeos.GEOSGeom_clone(), we could probably use the get_geos_handle and GEOSGeom_clone_r from pygeos/_geos.pxd. This would mean either rewriting this function in cython or exposing this functionality in python (get_geos_handle should be quite trivial with cpdef, not sure about the geos functions). Again,  I am not completely sure if it is worth it / necessary.~
Not implementing this for now. If anyone wants to try to get an even faster conversion, feel free...
[X] ~Add ignore_shapely2_warnings, similarly to GeoPandas. I have not done this yet, as I do not use Shapely V2 and did not immediately see a need for this. Let me know if this is necessary and I can add it.~
I do not think this is necessary, as Shapely V2 will contain PyGEOS, hence making this library unnecessary.
[x] Add to_shapely() to documentation.

Performance Note:
At first, I implemented things more like geopandas, by having a single python loop and performing the necessary transformations in  that loop:

pygeos -> wkb -> shapely
shapely -> wkb -> pygeos

However, after performing some tests, I found out it is faster to perform the "pygeos -> wkb" / "wkb -> pygeos" seperately and run it on the entire array at once. Obviously, having the same GEOS version is still much faster!
The test also shows that from_shapely() is quite a bit faster when you have the same GEOS version, compared to to_shapely(). My guess is that this is because most of the compute happens in C, whilst to_shapely() is built with python.
You can find my test-code and charts below.
# Note: I only tested with boxes, so maybe the results can be slightly different when having different geometries

# pygeos -> shapely
times = []
nums = []
for i in range(0, 5001, 50):
    if i == 0:
        box = None
    else:
        box = pygeos.box(0,0,range(i),range(i))

    result = %timeit -o pygeos.to_shapely(box)
    nums.append(i if i != 0 else 1)
    times.append(result.best)

# shapely -> pygeos
times = []
nums = []
for i in range(0, 5001, 50):
    if i == 0:
        box = None
    else:
        box = np.array([shapely.geometry.box(0,0,j,j) for j in range(i)], dtype='object')

    result = %timeit -o pygeos.from_shapely(box)
    nums.append(i if i != 0 else 1)
    times.append(result.best)

@0phoff  I took the liberty of finishing this PR, thanks again for your contribution. I put your github username in the attribution list, if you want me to replace it with your full name, please tell me and I'll change it after.

Given the almost complete state of this PR, I think we could merge this still. What is your opinion @jorisvandenbossche ?

Sorry for the slow reply here. Yes, fine with this being merged on the short term, but I hope we will be able to remove this addition again sooner rather than later! ;)
@0phoff thank a lot for your contribution


some folders are overplus

hello saeed ,
this boilerplate is powerful , but something is overplus .
for example :

pay ,
proxy ,
invitation ,
receipt ,
countries.js (we can use a package if needed),
services (zarin pal or any payment are not use able for every one) ,

i think for a boilerplate , we need some useful functions that every body needs .
you can make a package for functions above , and offer theme as library
thanks again for this powerful boilerplate

Hello dear @nimahkh,
the goal of this boilerplate was implementing the most challenging parts of a Real Project
implementing Receipt and Invitation models in MongoDB is a headache, achieving a good practice schema design in enterprise level applications is not such a easy thing and need to break and bake the whole things from scratch multiple times and it costs, I thought that's a good place to hold all challenges for anyone needs to start or restructure theirs projects.
any suggestions or PRs is really welcome buddy :D

#373420ddb5f2a89e7b2a9fa9364c4325ee1fffcf

so that it is like an example project not a boilerplate. boilerplates are introducing a structure and a point , to start aith a ready project. for example , I dont need proxy , why use it in my project?
so I think it is better to pack theme , and Introduce theme in a separated repository


New Role or New Crop for old images?

any way to apply the new role or new crop to existing images?

Hi @imknight,
This is not something Twill is currently shipping with but could certainly become a great Artisan command with a helper behind it that can be called programmatically if needed. At AREA 17 this is something we've solved by some doing some maths with the current crop values and new ratio value in a database migration. If you're not changing the ratios but only the names you should also be able to identify the appropriate rows in the mediables and alter them through a database migration.

thanks for the reply, will work on Artisan commit and submit for PR


Refactor the whole SharkInference API.

SharkInference API is refactored to target any frontends or files,
i.e. pytorch, tensorflow, mhlo, linalg, tosa.
Refactor all torch APIs.

@pashu123 LGTM, but I have some questions. What is the rationale behind moving the compile step into SharkInference, and why did we remove the save_mlir and save_vmfb, which is quite useful to debug the code generated.

I think we could do a low level api:  compile / run  and a high level: SharkInference()
save mlir / vmfb seems like we need to re-add those options.

@raikonenfnu now it is your turn to push and iterate. so when @pashu123 wakes up it has evolved :D


mid and high frequencies missing

I've been training a six-track separation model, but I've encountered an issue where the "other," "piano," and "guitar" tracks tend to lose mid-to-high frequencies. The cutoff point corresponds to the crossover frequency in the band configuration.
For example, with a band configuration of {'low': { 'SR': .175, 'stride': 1, 'kernel': 3 },'mid': { 'SR': .392, 'stride': 4, 'kernel': 4 },'high': {'SR': .433, 'stride': 16, 'kernel': 16 }}, frequencies above 3858Hz (22050 * 0.175) or 12502Hz(22050 * 0.567)are missing.
After investigation, I found that this issue is influenced by both the data and the model. My private data for these tracks often has sparse frequency content and long silent segments. However, using the same data to train models like Demucs or BSRNN does not result in this frequency loss. Have anyone ever encountered a similar situation before?

Perhaps you could provide the mixture of this split sample

Perhaps you could provide the mixture of this sample
courage.mp3.zip
This mixture is just a random pop song from the internet.

I used 4-tracks separation model, the 'other' track is ok. If 'guitar' and 'piano'  track have this problem, it might be due to insufficient training data,  causing the model focuses on low-frequency.
There are two ways to mitigate this. 1. Using waveform loss instead of spectrum loss 2. Retraining a model for 'guitar' and 'piano' and adjust its SR.

Thanks for the reply. My loss is waveform loss + spectrum loss, without any weight. I'll try to adjust the ratio of waveform loss.

I found that I had an improvement of high frequency separation fidelity when using the log-WMSE loss, which I adapted for PyTorch here: https://github.com/crlandsc/torch-log-wmse
It is basically a frequency weighted loss that can handle digital silence.


RFC: etcdmain, pkg: CN based auth for inter peer connection

This commit adds an authentication mechanism to inter peer connection
(rafthttp). If the cert based peer auth is enabled and a new option
--peer-require-cn is passed, an etcd process denies a peer
connection whose CN doesn't match.
/cc @luxas this is what we talked before, will it be useful for kubeadm?

This PR is related to https://github.com/coreos/etcd/issues/8262 , so I'm ccing @ericchiang
If it is valuable for k8s and acceptable by etcd, I'll add tests and docs.

@gyuho @ericchiang @jpbetz updated the way of looking CN based on the discussion. Also I renamed the command line flag to --peer-cert-allowed-cn as originally proposed in #8262. I'm adding an e2e test and doc.

@gyuho added the doc and test, could you take a look?

@gyuho updated for your comments, could you take a look?

@gyuho updated for the CN checking part, could you take a look?

lgtm. Thanks!
/cc @xiang90 @jpbetz

Thank you @gyuho!


Account for font in attributed text

Hello, my apologies but I forgot to account for font when working with attributedText, this can result in collapsedText being calculated incorrectly.
Sorry

Thanks!


[Feature][UI Next]Improve modal component, add link function

Purpose of the pull request
Please refer to the issue #8070.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #8426 (0c749b3) into dev (53869cb) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #8426      +/-   ##
============================================
- Coverage     45.38%   45.34%   -0.05%
+ Complexity     4028     4026       -2
============================================
  Files           686      686
  Lines         26702    26702
  Branches       2867     2867
============================================
- Hits          12119    12108      -11
- Misses        13438    13450      +12
+ Partials       1145     1144       -1

Impacted Files
Coverage Δ

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
48.21% <0.00%> (-7.15%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
83.60% <0.00%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53869cb...0c749b3. Read the comment docs.


django-dbbackup + celery

Hi there, i am trying to figure out how can i use django-dbbackup with celery without having to invoke the management command from inside a task. Something like importing a function or a few functions keeping my runserver --settings=blabla that is already in use.

@psychok7
What's wrong with call_command('dbbackup', option=value)...?

@benjaoming i did not know this command, thanks


Drawing ASCII codes which have been mapped to tiles in font crashes, drawing text from same tiled font is offset

I have a project, here. I'm attempting to use a tileset, using the tcod_sys functions to map ASCII codes to the locations of the tiles. However, my program crashes as soon as I try to draw these tiles to the screen. If I disable the tiles (but still use the font where they are placed) then all text bitmaps are shifted down by roughly two and a third lines. Here is how to navigate my project: in assets, the master16x16_ro.png has the tileset/font, and my tile loading logic is in src/main.rs at the top of the file. I tried using OpenGL, GLSL, and SDL, and all three crash on my attempt to use the tiles that I mapped. You can see my mapping code in worldgen/terrain.rs near the top of the file (after the imports).
Here is a picture of my program running without tiles enabled:

As you can see in that image, not only are characters wrong, but they are taking small clips of others below them.  For your convenience, here is my tileset:

The tileset on roguecentral is missing so my organization of the tileset is complete conjecture. I would appreciate any kind of help I can get!

I mentioned this in issue #244.

Based on conversation in #244, I'm closing this. Feel free to reopen it or create a new issue if think it's necessary.


Docs: SubmitMessage API redirects to 404

Description
Surfing the official documentation I've been welcomed by 404 page when attempting access SubmitMessage API section.

Related: is the docs repo available publicly?

Thanks for the report! Fixed in #1791.


FC error after decompile & recompile with MiuisystemUI.apk

Hi Guys!
I  like to help in this problem:
I use next:
apktool-2.1.0-285da3-SNAPSHOT-BZ with jBART v3h build 20160329.03
Windows 7 x64 ultimate with jdk-8u77-windows-x64.exe
MIUI 7 6.3.25 4.4.4
I want to modified MiuiSystemUI.apk, but i got always  FC.
I tried lot of Apktool and MIUI framewoks from dev and stable rom but i got always same.
Decomplie and compile run without any errors.
I tried more MiuisystemUI.apk decompile, and i got same thing in this case.
In public.xml I found next:
<public type="drawable" name="APKTOOL_DUMMY_0102" id="0x7f020102" />     <public type="drawable" name="APKTOOL_DUMMY_0103" id="0x7f020103" />     <public type="drawable" name="APKTOOL_DUMMY_0104" id="0x7f020104" />     <public type="drawable" name="APKTOOL_DUMMY_0105" id="0x7f020105" />     <public type="drawable" name="APKTOOL_DUMMY_0106" id="0x7f020106" />     <public type="drawable" name="APKTOOL_DUMMY_0107" id="0x7f020107" />     <public type="drawable" name="APKTOOL_DUMMY_0108" id="0x7f020108" />     <public type="drawable" name="APKTOOL_DUMMY_0109" id="0x7f020109" />     <public type="drawable" name="APKTOOL_DUMMY_010b" id="0x7f02010b" />     <public type="drawable" name="APKTOOL_DUMMY_010c" id="0x7f02010c" />     <public type="drawable" name="APKTOOL_DUMMY_010d" id="0x7f02010d" />     <public type="drawable" name="APKTOOL_DUMMY_010e" id="0x7f02010e" />     <public type="drawable" name="APKTOOL_DUMMY_010f" id="0x7f02010f" />     <public type="drawable" name="APKTOOL_DUMMY_0110" id="0x7f020110" />     <public type="drawable" name="APKTOOL_DUMMY_0111" id="0x7f020111" />     <public type="drawable" name="APKTOOL_DUMMY_0112" id="0x7f020112" />     <public type="drawable" name="APKTOOL_DUMMY_01a4" id="0x7f0201a4" />     <public type="drawable" name="APKTOOL_DUMMY_01a7" id="0x7f0201a7" />     <public type="drawable" name="APKTOOL_DUMMY_01aa" id="0x7f0201aa" />     <public type="drawable" name="APKTOOL_DUMMY_01ad" id="0x7f0201ad" />
and apktool ganarate values-mcc9460-mnc9000-xhdpi-v4 folder with dummy drawables.xml.
I read lot of thing but didnt solved my problem. Please help me.
Thanx!

Sorry. Not supporting or researching MIUI any further. What is in apktool now will stay, future research into a 3rd party OEMs that constantly change AOSP is not worth my time.
#806

Just notice (for @iBotPeaches ): apktool-2.1.0-285da3-SNAPSHOT-BZ is just an original apktool, but with changed ALLOWED/IGNORED packages to match latest MIUI changes.
And I think that I've found some issues in source code of the apktool. Testing now.


FINERACT-1079: Run spotlessCheck for automated builds, spotlessApply for manual ones

Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.

[x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.

[x] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.

[ ] Integration tests have been created/updated for verifying the changes made.

[x] All Integrations tests are passing with the new commits.

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

@vorburger that was exactly my view as well - as I mentioned here: https://github.com/apache/fineract/pull/1155#issuecomment-654017489
This PR tried to strike a balance between those who wanted code autoformatting to be applied automatically, and still ensuring that we check in the same code that we build and test (and that passes the quality checks).


apply modifier shape key keeps creating double models when applying it.

hi i need some help im making a model that has a mirror mod on which is not problem with the shape key, the only problem im having is that every time i add the apply shape key with the mirror mod i keep getting a message and my model (mirror mod is still on my first model) is creating 2 other models (without mirror mod or shape key):
Shape keys ended up with different number of vertices!
All shape keys needs to have the same number of vertices after modifier is applied.
Otherwise joining such shape keys will fail!
if theirs any advice id be appreciated

this is not our addon. You're looking for the ApplyModifierForObjectWithShapeKeys project


QUIZ-108

This is a branch for the small changes outlined for QUIZ-108
Changes:

QUIZ-112: Due to login forums changing with organisations on another branch this ticket is being held till those changes are done.
QUIZ-113: Emails have been revamped with styling, all 5 emails now styled. Styling is red for now but likely to change. See push for further details about gems.
QUIZ-88: Universal navbar added - Signup + Login when user not signed in, Scenarios, Edit profile and logout displayed for a logged-in user.
QUIZ-90: Small change to add new question styling. Updated to match styling for rest of the form.
QUIZ-89: General improvements such as titles for cards, number of attempts etc.
QUIZ-74: Replaced some Lorem with general instructions for forms.

Other changes:
Fixed issue where opacity for some login screens was changed
Updated routes so "checkout the app" leads to /app page
Removed old navbar logout, made redundant with new navbar implementation
Changed mentions of "Quiz" to "Assessment"
Anything else or any changes let me know :)

I'm not really a fan of the off-white header with white buttons, I feel like either the buttons should be coloured or the header should be.
Also can we have the brand section ("Scenario Platform") link either to the app root or the scenarios sections? This text also appears to be off the vertical middle as there's visibly more white below the text than above.
Edit: Perhaps it's just me but the header also seems quite big, if you remove the padding it still looks decent without taking up so much of the page 🤷♂


Run smoke tests with instant execution

This PR introduces a :smokeTest:instantSmokeTest task that runs smoke tests with instant execution enabled.

CI job where the tests were run on this branch https://builds.gradle.org/viewLog.html?buildId=29426254&buildTypeId=Gradle_Check_SmokeTestsJava13 by letting the existing smoke tests CI jobs run :smokeTest:smokeTest :smokeTest:instantSmokeTest.
Note that this branch now splits regular smoke tests and instant execution smoke tests into separate CI jobs which is the intended goal.


How to set form submission date with API?

I have successfully submitted form through Escopecz\MauticFormSubmit\Mautic
However the event_timestamp is generated by mautic system automatically. Can I manually set it because the real form submission date may be yesterday rather than now.

No, the timestamp is internal Mautic field. But you can create one more form field where you store the date you need.

Thank you for your advice.


Adds maximumWriteValueLength to Peripheral

Calls maximumWriteValueLength on iOS
Returns latest know value from onMtuChanged() - 3 on Android, or the default (23 - 3) if the callback haven't been called
Return default (23 -3) on Web

Closes #729

Note: :kable-core:androidApiCheck Gradle task failure can be fixed by running ./gradlew apiDump then pushing the updated API dump files.

It would be awesome if we could get this in a near release as I need this for my current project. @cedrickcooke does this solution look ok for you?

I'll release this w/ 0.35.0 in the coming days.

@ErikHellman released with 0.35.0.

[!NOTE
Compared to 0.34.0, the internals include a major refactor. I believe the 0.35.0 RC releases have been out long enough to get word of any major bugs, but please don't hesitate to report any issues you come across.