Source Capabilities

In some cases it's possible to know some of Source capabilities (e.g. Gateway Sender has its own restrictions which are narrower than HDMI Sources' ones). Utilizing caps of Source should be considered for it as well as a new HTTP response code for PUT /media-profiles operation.

The spec changed crucially but the idea of Sender Capabilities is still actual and should be considered in future. Renaming the issue: Source Capabilities -> Sender Capabilities.

Describing it seems more clear than before so we may want to consider adding Sender Capabilities in the closer prospective than versions after v1.0.

A Sender should have constraint_sets, filled in the same way as for Receivers, inside caps object.
When PUT /senders/{senderId}/constraints/active, the Sender checks that each Constraint Set of Active Constraints is a subset of any of Constraint Sets in the Sender Capabilities. If this check fails, the server responds with 422.
Constraint Set B is a subset of Constraint Set A if all of Parameter Constraints of Constraint Set B, except for meta, are present in Constraint Set A and each Parameter Constraint of Constraint Set B, except for meta, is a subconstraint of the according Parameter Constraint of Constraint Set A.
Constraint B is a subconstraint of a Constraint A if:

Constraint B has enum keyword when Constraint A has it and enum of Constraint B is a subset of enum of Constraint A
Constraint B has enum or minimum keyword when Constraint A has minimum keyword and allowed values for Constraint B are less than allowed values for Constraint A
Constraint B has enum or maximum keyword when Constraint A has maximum keyword and allowed values for Constraint B are greater than allowed values for Constraint A

Who's responsibility should it be to make a subset. If the Node has to evaluate whether something is a subset, how much more work is it to try to produce an intersection when it isn't? E.g. when parameter constraint in Sender caps has min 1, max 10, proposed one has min 5, max 15. But even evaluating everything involves a lot of combinations, probably every proposed constraint set has to be evaluated against each one from Sender caps, and there could be multiple possible intersections. Hmm.

Sender capabilities are for the Controller, similar to Receiver capabilities ... Receiver capabilities today are more important than Sender capabilities because of the lack of Source/Flow on the receiver side. On the Sender side, IF there is a valid signal the actual Flows and Sources associated to the various Senders of a device provide some information about what the device is capable of ... But having Sender capabilities would help a Controller know without any active signals what a Sender is capable of and then know before getting a 422 status that a Sender is not capable of supporting some constraint value.
I think we should see it as a way for a Controller to prevent getting a 422 status. I would not have normative language in IS-11 indicating that a Sender shall behave in any specific way regarding its declared capabilities and the active constraints ... relying only on returning a 422 status when it is not capable of supporting a given constraint value or combination of constraint values.

Regarding my previous message, I would say the Node is responsible for validating Active Constraints against Sender Capabilities. The work for producing an intersection looks as complex as now: the Controller never knows when it'll get 422, but Sender Capabilities at least give some hints. Though, I don't insist on validating, it may be just declaration as Alain described.

I agree. Without Sender capabilities (e.g. in IS-04 caps), the 422 (Unprocessable Entity) response to PUT /senders/{senderId}/constraints/active leaves the Controller with no information about what to change.

The /supported endpoint describes the constraints that a Sender supports, these are not Sender's capabilities, but I agree that on error 422 a Controller could verify if some Sender's capabilities matching the /supported constraints have values outside the Sender's capabilities. For example a Sender indicates capabilities urn:x-nmos:cap:format:frame_height maximum 1080 and receives a constraint urn:x-nmos:cap:format:frame_height equal 2160 and return error 422, the Controller could understand why. I think it should be allowed for a Sender to have  /supported being a superset of what the sender describes as capabilities.

What would be the point of supporting constraints that weren't used to express the Sender's capabilities?

OK, I see, you are saying it may make sense to not enumerate all possible width x height in separate constraint sets in IS-04 Sender caps but still to indicate in IS-11 /supported that you understand constraints on width and height?


How to edit camera projection?

Greetings!
I managed to get it to work and modified the virtual camera texture onto which the camera renders to have a 9:16 ratio as I need to send camera feed as a portrait camera view.
The problem is that the camera assigned to the prefab's script is set to landscape mode by default.(Set to Perspective)
Is there any way to alter this mechanism? I couldn't find a solution.
The only solution I have in mind is to rotate the camera, switch the texture's ratio back to the previous and then rotate the texture before sending through Agora but I wanted to ask first.

Edit: the camera projection was fixed by assigning the texture to it, but when sending it stretches it vertically quite a bit.
Testing on just a quad:
Texture in editor:

Result on mobile:

Solved it by changing orientation mode to portrait in line 163 in AgoraVirtualCamera.cs


Support Dagbladet (Norwegian newspaper)

Request support for downloading videos from Dagbladet (Norwegian newspaper):
~/$ youtube-dl -v http://www.dagbladet.no/2016/02/23/nyheter/nordlys/ski/troms/ver/43254897/
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.dagbladet.no/2016/02/23/nyheter/nordlys/ski/troms/ver/43254897/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.02.10
[debug] Python version 2.7.11 - Darwin-15.3.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 2.8.3, ffprobe 2.8.3, rtmpdump 2.4
[debug] Proxy map: {}
[generic] 43254897: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 43254897: Downloading webpage
[generic] 43254897: Extracting information
ERROR: Unsupported URL: http://www.dagbladet.no/2016/02/23/nyheter/nordlys/ski/troms/ver/43254897/

dbtv.no is already supported, which is what dagbladet.no uses. Extracting the iFrame URL from the provided URL yields www.dbtv.no/lazyplayer/4769123329001, which is supported.

@remitamine Thanks to 8a8590a61784b9f4a8ff380058a1571d5400ba3d, it is now supported.

As of 8a8590a61784b9f4a8ff380058a1571d5400ba3d, some videos on the site, such as this one are working, although not the provided URL as it seems that they've seen to changed their layout.

Still failing. Any update on this? Shouldn't https://github.com/rg3/youtube-dl/pull/10364 have fixed this?


Check every query for a counter (_total) is irate'd, and that we never use rate

Always use irate instead of rate.

Hi not sure about the explanation, it seems to me that this thread explain more the disadvantages using irate than anything else? I also think that rate should be preferred over irate almost everywhere...

@MrFreezeex Yes that is the consensus and we will be putting in a check for that in the dashboard linter.
I will remove the link to the confusing discussion :)

Do you mind explaining why? I mean I very much agree to the the thread you posted that explain why irate skip metrics and the graph will be "incorrect" (quoting directly: No, irate doesn’t capture spikes - it just returns random sample of data points for the given time series.)... Also not sure if this is very much a consensus since even mimir dashboards seems to prefer rate over irate if I am not mistaken.

Yeah I think in hindsight best not to mandate the use of irate; still worth having a rule that checks counters (ie anything ending in _total) is rate'd/irate'd/increased etc, no?


order Aries labels by population and scalerank

See #26 for more discussion.
In this screenshot, Mexico City should show up. http://localhost:8080/flat/#8/19.329/-98.871

I wonder if the airport icon has anything to do with Mexico City not showing? I assume the layer order determines priority of labeling as well, but if that's so then the airport icon wouldn't be an issue as the city labels are stacked on top of the airports.

@almccon the same issue is happening in Seattle, believe it has to do with the highway shield icons. This leads me to believe the issue is a label conflict with layers that are using shield- vs text- properties and TileMill is giving preference to shield- layers.
For example if I turn off the #highway_shield layer then the label for Seattle renders at zoom 12:

Same thing happens for Mexico City with the airport icon at lower zooms:

Any ideas what a solution to this might be?

Also posted this in #42, but the following changes in 2804c4d seems to help:

Not rendering airport icons until zoom 12 to give city labels a better chance of rendering. This seems to help with Mexico City.
Setting the text-wrap-width property helps keep the text in a smaller area, giving it a better chance of rendering.
Using population to determine what labels get rendered at zooms 9 - 12 which helps with areas outside of the U.S

New sorting in the Aries query keeps Mexico City on top. There's only one zoom (11) where the sorting fails. Not sure why. But I'm calling this done.

See also #42.


Update validations.py python script.

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

fix the script to test if the first character of the name is an alpha.


The button "I've completed this challenge" used to submit the project "Exercise Tracker" have bug

Describe the Issue
I have pass all test case of "Exercise Tracker" challenge except the 7th test case("you can POST to /api/users/:_id/exercises with ..."), I tried many way but still can't pass this test case. When i open the console of Chorm, i found the bug "Date.now(...).subtingr is not a function" when i click on the button "I've completed this challenge" to submit the `project```
Affected Page
https://www.freecodecamp.org/learn/back-end-development-and-apis/back-end-development-and-apis-projects/exercise-tracker
Steps to Reproduce

Open the console of brower
Fill the link into Solution Link
Click on "I've completed this challenge"
See error

Expected behavior
This error should be disappear
Screenshots

System

Device: [Laptop]
OS: [Windows 11]
Browser: [Chrome]
Version: [106.0.5249.103]

Additional context
No response

Please provide the link to the project that you submitted

Thanks for opening this issue.
This looks something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix:
List of files:

https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/05-back-end-development-and-apis/back-end-development-and-apis-projects/exercise-tracker.md

Line https://github.com/freeCodeCamp/freeCodeCamp/blob/93347ea2856ce267e016b6690cef2ca64afaf293/curriculum/challenges/english/05-back-end-development-and-apis/back-end-development-and-apis-projects/exercise-tracker.md?plain=1#L167
contains the typo, substingr should be substring.
Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this.
Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first.
Happy contributing.

@surajrane42 hey there, I suggest reading our contributing guidelines! as it says, all issues with https://github.com/freeCodeCamp/freeCodeCamp/labels/first timers only and https://github.com/freeCodeCamp/freeCodeCamp/labels/help wanted labels are up for grabs

@ieahleen I have fixed this issue and raised a PR.
https://github.com/freeCodeCamp/freeCodeCamp/pull/47892


Fix button bar in Copay

When only one addon added to Copay, menu bar shows five items and free space for sixth item. Doesn't look good. Let's get rid of this free space

bitpay/copay#3127


Implement Linestring/Polygon without iterators

File 	Coverage 	Lines 	Branches
All files 72% 84% 59% 	white_check_mark
include/shpxx/coordinate_cast_impl.hpp 	100% 100% 0% 	white_check_mark
include/shpxx/shpfile.hpp 	100% 100% 0% 	white_check_mark
include/shpxx/shpfile_impl.hpp 	87% 95% 78% 	white_check_mark
include/shpxx/feature/linestring.hpp 	100% 100% 0% 	white_check_mark
include/shpxx/feature/multi_point.hpp 	0% 0% 0% 	white_check_mark
include/shpxx/feature/polygon.hpp 	0% 0% 0% 	white_check_mark
include/shpxx/feature/polyline_part.hpp 	100% 100% 0% 	white_check_mark
src/shpfile.cpp 	76% 93% 60% 	white_check_mark
src/shplib_helpers.cpp 	100% 100% 0% 	white_check_mark
src/feature/linestring.cpp 	85% 100% 70% 	white_check_mark
src/feature/multi_point.cpp 	43% 45% 41% 	white_check_mark
src/feature/polygon.cpp 	79% 100% 58% 	white_check_mark
src/feature/polyline_part.cpp 	65% 94% 37% 	white_check_mark
Minimum allowed coverage is 0%
Generated by monkey cobertura-action against 86d9508

The coverage report doesn't show the change in coverage :frowning:


Do you support buildtry.com as well?

Do you have plugin to support buildtry.com?

Hi, @arvindkumar-gr. No, i haven't.


(ql:quickload "quicklisp-slime-helper") fails

On the very fresh Ubuntu system, SBCL <IP_ADDRESS>.debian.
March 2012 Quicklisp distro.

(ql:quickload "quicklisp-slime-helper")

[ ... lot of compilation output ...]
debugger invoked on a SIMPLE-TYPE-ERROR in thread #<THREAD
"initial thread" RUNNING
{AA657E9}>:
Argument X is not a REAL: NIL
HELP for debugger help, or (SB-EXT:QUIT) to exit from SBCL.
Backtrace: http://paste.lisp.org/+2QWF. Fails somewhere in alexandria...

Thanks, it looks like a bug in alexandria. I have emailed the author of the offending commit. I'll probably release a Quicklisp update very soon as a result.

Meantime I worked this around by downgrading to the previous QL release:
(install-dist "http://beta.quicklisp.org/dist/quicklisp/2012-02-08/distinfo.txt" :replace t)

installed quicklisp-slime-helper, and then updated to the newest release by:
(ql:update-dist "quicklisp")

If you will update the QL release, it probably makes sense to include the slime fix for SBCL on Windows (as posted on the slime-devel).


autocomplete converting space to dash

Hi team,
autocomplete converting space to dash on tag added

I fixed the issue, you may close it

You can set replace-spaces-with-dashes attribute to false like : "replace-spaces-with-dashes='false'"

Thanks Sapna, I had figured it :)


move test, update requirements

The test was in the wrong directory:
Moved it to the correct tests location.
____________ ERROR collecting zeta/nn/modules/test_dense_connect.py ____________
ImportError while importing test module '/usr/src/zeta/zeta/nn/modules/test_dense_connect.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
zeta/__init__.py:1: in <module>
    from zeta.utils.disable_logging import disable_warnings_and_logs
zeta/utils/__init__.py:10: in <module>
    from zeta.utils.disable_logging import disable_warnings_and_logs
zeta/utils/disable_logging.py:5: in <module>
    import numexpr as ne
E   ModuleNotFoundError: No module named 'numexpr'

Added numexpr to requirements.  Tests now running.

One of the tokenizer tests depended on writing a file. Removed it.

Removed test to fix #77

model/base.py did not raise NotImplemented here, The test was looking for that.

Fixing  tests

The base model test checks for Not Implemented. If it stays as is, then the test should be removed.

@evelynmitchell then have them removed so i can accept

Dine


Language client is not ready yet

After I installed the Solidity plugin from the vscode marketplace, it cannot prompt syntax errors of sol files during use. I uninstalled all other plugins related to solidity, but the result is still the same: syntax prompting does not work.
When I opened the plugin page, I saw an uncaught error message: Language client is not ready yet.
VS Code Version: 1.76.0 (user setup)
Commit: 92da9481c0904c6adfe372c12da3b7748d74bdcb
DateTime: 2023-03-01T10:22:44.506Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
SandBox: No
Solidity version v0.6.11
OS : Window 11

Hello @LingCoder, by 'cannot prompt syntax errors` do you mean that you have no syntax highlighting or that you don't get compiler warning and errors appearing as you edit the code (i.e. red/yellow underlines on the code)?

Closing as we would need more information to progress this issue.

meet the same question

@bit23665 can I confirm, are you not seeing syntax highlighting or that you don't get compiler warning and errors appearing as you edit the code?

@bit23665 can I confirm, are you not seeing syntax highlighting or that you don't get compiler warning and errors appearing as you edit the code?

yes, the same question。code formatting is ok。
plugin version: v0.7.1
node version: v14.20.0
OS: mac

my project is init by: npx hardhat。when i open .sol file，here is the tips:
Validation blockedCorrupted lockfile: You installed Hardhat with a corrupted lockfile due to the NPM bug #4828. Please delete your node_modules, package-lock.json, reinstall your project, and try again.. Some versions of NPM are affected by a bug that leads to corrupt lockfiles being generated. This bug can only affect you if you, or someone at your team, installed the project without a lockfile, but with an existing node_modules. To avoid it, please delete both your node_modules and package-lock.json, and reinstall your project. Note that you don't need to do this every time you install a new dependency, but please make sure to delete your node_modules every time you delete your package-lock.json.

@bit23665 can I confirm, are you not seeing syntax highlighting or that you don't get compiler warning and errors appearing as you edit the code?

because my project default folder is 'src', if .sol file out of src, the plugin dose not work.

Turns out if you specify solidity version ambiguous, you got this error.
I really think this scenario deserves a better error message.


Ruff format and README.md

Changelog Description
This is a follow-up of https://github.com/ynput/ayon-kitsu/pull/79 by @iLLiCiTiT
This PR adds the following:

Removed the top pyproject.toml dependencies that were already present in the tests folder and added Ruff as the only dev dependencies (so devs don't have to install Ruff globally on their machine and can install it with Poetry in the project's venv)
Applied ruff format on all the client Python source files using the Ruff config
Added the repo's README.md file (which you can see here) with instructions on how to install the dev dependencies and format using Ruff + the basic structure found on other repos.

I didn't make any manual changes, it's just the output of ruff format but not sure how you applied it on your side? Because in your PR you had a lot of changes too but I don't know if they overlap if the ones here.

You've also removed all other dev dependencies, not sure why?

Sorry I just thought they were for the tests subfolder and running the tests. From what I can see, the tests, client and services/processor subfolders have their own pyproject.toml file for managing dependencies but the pyproject.toml root file applies to the server folder?

I didn't make any manual changes, it's just the output of ruff format but not sure how you applied it on your side? Because in your PR you had a lot of changes too but I don't know if they overlap if the ones here.

I didn't use ruff format because it does exactly this, a lot of unwanted changes.

Sorry I just thought they were for the tests subfolder and running the tests. From what I can see, the tests, client and services/processor subfolders have their own pyproject.toml file for managing dependencies but the pyproject.toml root file applies to the server folder?

Root pyproject.toml is only for development of the addon, nothing else.

I didn't use ruff format because it does exactly this, a lot of unwanted changes.

My bad, I thought Ruff was used to format the code as well but you just fixed the lint errors.
Let me close this PR, I went too fast!


backport 2.2.x - Bump Oasis Core to 22.1.6

shouldn't be anything that affects the rosetta gateway, but here's a backport anyway

probably will wait until we update our mainnet version recommendation. converting to draft

back to draft, 22.1.8 is out

gonna be proceeding with 22.2.x branch


Show a link instead of inline photo for photos served by other domains in zero-rating mode. #218

LGTM

Thanks. Merged.


Server 2019 - Defender Reinstallation not possible!

Hi,
I am having an issue.
Some "software provider" decided that by removing Windows Defender completely (Payloads too....) was the best way to make sure his software works.
I came across the matter as I am onboarding server to M365 Defender and Endpoint Manager.
Your tutorial to reinstall Windows Defender using Dism /Online /Enable-Feature /FeatureName:Windows-Defender  DOES NOT WORK.
Neither using the payloads/sources from another machine or a local WIM Dism /Online /enable-feature /featurename:Windows-Defender /all /source:WIM:C:\Temp\install.wim:2 /LimitAccess
Does someone have a working workaround to reinstall Windows Defender again.
TY in advance.
BR
Greg

Hi,
A little update:
Checking registry settings from a "healthy" Server 2019 Standard Server, it seems to that all entries for Windows Defender have been removed from [HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Component Based Servicing] and related Subkeys.
M$ does make available a package to service (defender-update-kit-x64) Windows Defender but it cannot be used with DISM /Online
Any change to get that option working as we cannot leave a server with a non working Windows Defender AV.
TY in advance for the feedback.
BR,
Greg
ComponentBasedServicing_DEFENDER_ISSUE.zip
ComponentBasedServicing_WORKING.zip

@ggriffinorg Thank you for your feedback. This looks more like a technical issue and needs to be handled by our support team. I'd recommend you click on the need help Icon on the admin center to create a support ticket so that a Support engineer can assist you or create a bug if it is a product bug.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @ggriffinorg Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also


Updated the transformer greedy method

In this PR, I added a greedy decoder function that generates the decoder input for inference. This is important for translating sentences as we don't know the target input beforehand. In the paper, they mentioned that they ran Beam Search with a k=4. In the greedy approach, k = 1.

@dmmiller612 Hello. I added 'Masked' Multi head attention using torch.triu and edited your greedy decoder code in my new branch(Transformer)! Are you agree?
Please See my diff commit

'Masked' Multi head attention in your greedy decoder
https://github.com/graykode/nlp-tutorial/commit/005d34bfa3cafb822599a526b85b732e2846213d

'Masked' Multi head attention in Original Transformer
https://github.com/graykode/nlp-tutorial/commit/5b4fb5ebca712f72e747674333dafc10182367e5

Thanks


Fixes to capabilities and CI

Hey @gianarb if you're every bored.. I presumed updating the go.mod to look in the current directory for the imports would fix things :'( Any ideaS?


Add variation group name to Banners page

This fixes an accessibility error that Lighthouse discovered.
Without this change, the heading order goes h1, h3.
This adds the missing h2.

If you run Lighthouse against the preview link above, it score 100%, unlike the current version which scores 98% and thus fails the nightly GitHub Actions check (here).
Granted, this layout doesn't look ideal with only a "Types" heading but I'm not sure of an easier way to easily fix this:

@contolini sorry I know this isn't the right place to ask, but is anyone from your team planning to add use cases to this page, so people know when to use the dark banner ?

@sonnakim this is a smart idea. One that I like quite a bit.


Failed to mount certs for new SA

Bug Description
Recently we upgraded istio from 1.5.10 to 1.6.14,
And we notice that the istio.<service_account> does not have been created as in the old version (expected behavior)
So we tried to mount the secrets using :
proxy.istio.io/config: |           proxyMetadata:             OUTPUT_CERTS: /etc/istio-output-certs         sidecar.istio.io/userVolumeMount: '[{"name": "istio-certs", "mountPath": "/etc/istio-output-certs"}]'
And then added the volume, and mounted it to the relevant container, And it just worked perfectly with old service account (that still have istio. secret)
when tried to create a new service account and tried to use it, the directory was empty
We are trying to mount the certs into init container, cause in this stage the istio-proxy not ready yet, and we need to call another service into the mesh, so we must mount the certs. to be able to pass the mtls
my full deployment yaml:
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: test
  name: test
  selfLink: /apis/apps/v1/namespaces/apps/deployments/test
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 0
  selector:
    matchLabels:
      app: test-certificate
  template:
    metadata:
      annotations:
        proxy.istio.io/config: |
          proxyMetadata:
            OUTPUT_CERTS: /etc/istio-output-certs
        sidecar.istio.io/userVolumeMount: '[{"name": "istio-certs", "mountPath": "/etc/istio-output-certs"}]'
      labels:
        app: test-certificate
    spec:
      serviceAccount: test123
      serviceAccountName: test123
      containers:
        - image: kennethreitz/httpbin
          imagePullPolicy: Always
          name: certificate
          ports:
            - containerPort: 8080
              name: client
              protocol: TCP
      imagePullSecrets:
        - name: regcred
      initContainers:
        - command:
            - /bin/sh
            - -c
            - |
              echo "starting"
              ls -la /etc/istio-output-certs
          image: kennethreitz/httpbin
          imagePullPolicy: Always
          name: init
          volumeMounts:
          - name: istio-certs
            mountPath: /etc/istio-output-certs
      volumes:
      - emptyDir:
          medium: Memory
        name: istio-certs
      restartPolicy: Always

BTW: tried the same in the main container and not just in the init container, and got the same behaviour
Version
client version: 1.6.14
internal-ingressgateway version:
pilot version: 1.6.14
pilot version: 1.6.14
data plane version: 1.6.14 (7 proxies)

Additional Information
No response

i followed this doc:
https://istio.io/latest/docs/ops/integrations/prometheus

I think you are following a doc for Istio 1.11 but using Istio 1.6.

Can you send me the link for 1.6? cannot find it in istio doc


docs(README): add Commit Message for standardization commit messages

@morpheusthewhite
I modified some content based on the last time (#381), and match your format in the README.md.
Is there anything that need to be changes or adds?
Thanks for invited me to collaborate this repository! And sorry to created the PR too late, because i am busy recently.

Contributions
...
How to contribute

...
Add the theme preview to THEMES.md (themes are in alphabetical order) following this structure if it has only one color scheme
...
Commit only one message, more details in the Commit Message
Open a Pull Request and mention the most important changes you've made to the UI (ignoring the color scheme)

Thanks to all the contributors.
Commit Message
NOTE: commit only one message when you add a new theme or scheme, you can commit other messages later.
Format
<type>(<scope>): <subject>
<BLANK LINE>
<body>[optional]

Any line of the commit message cannot be longer than 100 characters!

type: feat | fix | docs | chore

feat: A new theme | A new scheme | A new feature
fix: A bug fix
docs: Change the README.md of the theme | Change the THEMES.md
chore: Add more screenshots | Change the screentshots | Other things

scope: THEMES | <ThemeName>

THEMES is a fixed format: docs(THEMES)
In other cases, use the theme name

subject: What changes you have done

Use the imperative, present tense: "change" not "changed" nor "changes"
Don't capitalize first letter
No dot (.) at the end

body: More details of your changes, you can mention the most important changes here

Example (Turntable theme)

feat

feat(Turntable): add Turntable theme

feat(Turntable): control the rotation of the turntable

Rotate the turntable by playing state.

fix

fix(Turntable): show the cursor outside the context menu

docs

docs(Turntable): update README.md

docs(THEMES): add preview for the Turntable

chore

chore(Turntable): add screenshots of the Turntable

If you want to learn more, view the Angular - Git Commit Guidelines.

@morpheusthewhite I think it has effect. (#385, #387)

@harbassan Is there anything that is not easy to understand? 🤔

i think this should be in a separate CONTRIBUTION.md

I think it is easy to understand, but agree with @Blacksuan19, it would be clearer if it was in a separate doc

i think this should be in a separate CONTRIBUTION.md

Thanks for your advice.
I thought about it too.

I think it is easy to understand, but agree with @Blacksuan19, it would be clearer if it was in a separate doc

Thanks for your feedback.
About the CONTRIBUTING.md, we need to consider.

I agree, we can move the README section to another file (probably after this PR is merged)


add section on WIS2/ODIS interoperability (#105)

Fixes #105

cc @golfvert
FYI I will cut a version following this PR.


"no response" in homekit, apple-tv ?

yes, as per advisory I did screen the available resources, my fault, if I missed something. But thanks in advance for guiding to a solution ...
Homekit ist top of the tree, feeded by HUE plugin (homebridge, deconz-II usb stick, orange pi zero, no other plugins) and by red-node (ELV homematic devices) and by native homekit 'non certified' devices (koogeek, dohome).
After iOS 14 upgrade I stumbled 2 weeks to find reason for "no response" devices, when not at home (i.e. not WLAN, but ATV bridging).  Taking iphones out of "home", "icloud", "keychain" did not help - solution was to take the old iphones (not running ios 14) completely(!) out of the apple account.
Result: no more "no response" from any device regardless of in reach of home WLAN or remotely via iCloud/ATV-bridge -
BUT the HUE plugin devices ONLY still exhibit an unstable respones. As well as in home WLAN as well as remote via iCloud/ATV.
As per the described excercise I learned, that (even in a home WLAN) connectivity of the homekit bridges to the local LAN ATV(s) is a must for a proper response status. Even an iphone connected to the home WLAN does not talk to the bridges straight, but involves iCloud.
Just my 2 cents - might connectivity of homebridge and/or HUE plugin with ATV (after their TV OS Upgrade) be root cause ... ???
take care & stay @home - Donald

The connectivity with HomeKit clients, incl. the Apple TV or other home hub, is handled by Homebridge (or rather the underlying HAP-NodeJS).  Nothing Homebridge Hue or any other plugin can do.  You can check using netstat on the server running Homebridge that the Apple TV has an active session to Homebridge (you should see an incoming session for each active HomeKit client).  If, for some reason, your iPhone cannot find Homebridge on the local network, it reverts to remote access over iCloud to the home hub.  HomeKit uses https to control devices, but Bonjour (multicast DNS) to locate Homebridge.  If the latter fails, devices show as not responding.  Bonjour isn’t routable by default, and IGMP snooping on your switch or router tends to break it.  Best connect the Homebridge server and Apple TV by ethernet, using a dumb, unmanaged switch.

Hi Erik,
identified the culprit ... It is congestion of radio channels.
I am using 5 access points (Draytek AP90x), with AUTO channel selection, i.e. they 'see' their AP neighbours and operate on unoccupied channels. ZIGBEE operates on 2,4 GHz as the APs do I found from the spec.
Fix: put the ZIGBEE channel on the highest (25, Phoscon UI) and block channels 11-13 on the AP from the AUTO selection range, thats all. Stable operation after that change.


Guest ABORT: Attempt to finish kAFL run but never initialized

Bug
fuzz.sh run build -p1 --debug

<snip>

Worker-00 Guest ABORT: Attempt to finish kAFL run but never initialized

Worker-00 Failed to connect to Qemu: Guest ABORT: Attempt to finish kAFL run but never initialized

Worker-00 Shutting down Qemu after 0 execs..
qemu-system-x86_64: terminating on signal 15 from pid 609811 (/home/bill/workspace/ccc-linux-guest-hardening/kafl/.venv/bin/python3)
Worker-00 Qemu exit code: None
Worker-00 Failed to launch Qemu.
Worker 0 sent ABORT..
Manager exit: Workers aborted before becoming ready. Likely broken VM or agent setup.
Waiting for Workers to shutdown...

Workaround
The "fix" is to change the KConfig (.config file under build directory, in my case ~/data/test1/BOOT_POST_TRAP/build) with the diff as
below where ~/config.bak is the good config and .config is the broken config. AND THEN BUILD MANUALLY by going into the build dir and typing make -j$(nproc)
# ~/config.bak is goog .config is broken
diff ~/config.bak .config

331c331
< # CONFIG_TDX_FUZZ_KAFL_SKIP_CPUID is not set
---
> CONFIG_TDX_FUZZ_KAFL_SKIP_CPUID=y
333,334c333,334
< # CONFIG_TDX_FUZZ_KAFL_SKIP_ACPI_PIO is not set
< # CONFIG_TDX_FUZZ_KAFL_SKIP_RNG_SEEDING is not set
---
> CONFIG_TDX_FUZZ_KAFL_SKIP_ACPI_PIO=y
> CONFIG_TDX_FUZZ_KAFL_SKIP_RNG_SEEDING=y
348d347
< # CONFIG_TDX_FUZZ_KAFL_VANILLA_INJECTION_SAMPLE is not set

The linux-guest at the time of this bug was set on:
commit 9950c09711a6e413c167ba0752381d64d292b822 (HEAD -> kafl/fuzz-5.15-4, origin/kafl/fuzz-5.15-4)

Hi @williamcroberts, could you share the full broken .config?  So far, I can't reproduce this bug by changing the Kconfig options above, rebuilding, and testing the same Linux guest (same commit).
I also cannot find any loopholes (from the code) between init_harness.py <dir> BOOT_POST_TRAP to fuzz.sh build that could result in leaving these config options not set.

Hi @williamcroberts, could you share the full broken .config? So far, I can't reproduce this bug by changing the Kconfig options above, rebuilding, and testing the same Linux guest (same commit).
I also cannot find any loopholes (from the code) between init_harness.py <dir> BOOT_POST_TRAP to fuzz.sh build that could result in leaving these config options not set.

Are you sure you're understanding the diff correctly? The working build is the ones with the options turned off.

Yes, I think so.  I have the .config under the build directory changed the same as yours.
The reason I mentioned the second half paragraph above is that they are in charge of the automation of copying the config template, selecting a set of Kconfig options/values related to the specific harness you choose, combining and copying to your build dir (~/data/test1/BOOT_POST_TRAP/build/ in your case) for final 'make olddefconfig' and compilation with additional flags.
And that part works also fine from my side. So I was also trying figure out how you had the .config mismatched at the first place.

@tz0 here is the working config
config.bak.txt

@tz0 here is the broken config
config.broken.txt

I can reproduce the issue after tried a few more machines.
The actual option that causes the issue (from my side) is CONFIG_TDX_FUZZ_KAFL_SKIP_RNG_SEEDING=y. I created a PR to link the problem with a temporary fix.
@williamcroberts, if you have time, please help check whether the proposed fix (only disabling  CONFIG_TDX_FUZZ_KAFL_SKIP_RNG_SEEDING) would work or not on your side. Leaving the other options set, you can still avoid having input injections for CPUIDs or ACPI subsystems.
Need further inspection for the underlying reason and fix.

One way to fix this is switching off the option CONFIG_TDX_FUZZ_KAFL_SKIP_RNG_SEEDING in the .config under your guest kernel's build directory and re-build the guest.

Are you sure this is the right fix? It seems you are just enabling RNG_SEEDING as a workaround but the actual problem is that your harness does not consume inputs.
The underlying issue is that no injection is happening, meaning the kernel/agent is not configured properly or the VM settings (kafl/qemu config) do not match. A typical example is trying to fuzz virtio but not enabling any virtio subsystems in the VM config. No devices will be enabled and kernel skips any virtio setup, meaning no virtio-specific injection will be executed. The harness may see "enable" and "done" events somewhere in core kernel code before and after the virtio subsystem, but it will complain on "done" that no actual injection occured.
This is why init_harness.py not only outputs a kernel .config but also a kafl/qemu config. They should be picked up automatically when you use "fuzz.sh build" and "fuzz.sh run" with the generated target directory.

I can build a broken version, apply this patch and it works.

@williamcroberts do you still experience issues here or are you able to test things with default configs from harnesses?

Closing this one since the issue was resolved


Update README.md

Update link to ISC license.

Anything further required from me?

No, I just haven't had time yet.

Thanks!

My pleasure!


The library does not support android 9.

Heya, Seems that on android 9 there are issues with this library.

what issues are you facing? I just used it and it is working fine


Collider wireframes

Are there plans to add an equivalent to RapierDebugRenderPlugin ? Especially wireframes, as meshes and materials do not guarantee to exactly match the collider's shape and state (e.g. is a force applied) while also adding boilerplate.
If not, what are your solutions to visualize colliders that do not require an external tool ?
Thanks in advance.

This already exists, see PhysicsDebugPlugin.


Shooting unreasonably takes into account player vertical velocity, resulting in aim not toward crosshair

Scenario: I am trying to use a technique in my modpack where I fire a gun whilst jumping.
What happens: the mathematics of the bullet's travel adds the velocity of the player's vertical/horizontal movement, which is unexpected as bullets should be flying toward the crosshair instead.  this results in, say, when the player jumps and is rising whilst taking the shot, the bullet will diagonally fly upwards, rather than straight ahead.  same with whilst falling, making the bullet fly downward so fast you miss the shot by several blocks, not because your crosshair missed, but because the bullet took your velocity into account when firing.

I'll see what I can do.

awaiting for this change to be backported to 1.16.5

I'm not supporting 1.16 anymore.

If i fork it myself and fix it, would you push it to curseforge, or should I simply spend time figuring out the other things to fix things up and post it on my own curseforge page.


Missing token location in EarlyExitException if token is EOF

Hi, for my VS Code linter I need the exact token locations for every parser error. If the error is an EarlyExitException and the token is of type chevrotain.EOF, the location properties of the token are all set to null. As a workaround I can check for this case in my linter and replace the location info in the error with the endLine and endColumn of the last token. But it would be nice if Chevrotain could do this for me.

For anyone having the same issue, the workaround requires to create a new token, as the token location properties are read only. Use:
chevrotain.createTokenInstance(chevrotain.EOF, "", startOffset, endOffset, startLine, endLine, startColumn, endColumn);

the EOF does not really have a location.
But what can be done is add another property to the EarlyExitError.
The previous (real) Token
https://github.com/SAP/chevrotain/blob/master/src/parse/parser_public.ts#L3083-L3085
        // old code
        throw this.SAVE_ERROR(new exceptions.EarlyExitException(msg, this.LA(1))

      // new code, LA(0) will return the previously successfully parsed Token.
      throw this.SAVE_ERROR(new exceptions.EarlyExitException(msg, this.LA(1), this.LA(0))

The one edge case is what if the error is for a completely empty text input.
In that case there would be no previously successfully parsed token...
So that edge case would have to be tested.

This seems fairly trivial to implement, So I'll happily accept pull requests for this 😄
Or implement this myself when I get around to it (after 1.0.0 release and new web-page creation)

That is a good solution. I will add the changes today and send you a pull request.
The edge case will be no problem for the linter, as VS Code will put the error marker at the beginning of the file if the location is missing.

The edge case will be no problem for the linter

We still need to check the edge case does not cause some weird runtime exception for Chevrotain.
I guess in the edge case both token properties should be EOF, so anyone using a Chevrotain parser
could easily identify it and handle it in their code.

The cleanest solution would be up upgrade LA to handle this.
    protected LA(howMuch: number): IToken {
        // Maybe add another check here that:
        // currIdx + HowMuch > 0
        if (this.tokVectorLength <= this.currIdx + howMuch) {
            return END_OF_FILE
        } else {
            return this.tokVector[this.currIdx + howMuch]
        }
    }

The problem is that it might actually cause a slight performance regression as LA(x) is used a-lot.
There are performance benchmarks here to inspect that
https://github.com/SAP/chevrotain/tree/master/benchmark_web
But they are working 100% as i've made a lot of breaking changes in the upcoming 1.0.0 version.
So just start with the clean solution and I will hack it later if needed for performance reasons.

Sorry, I am not sure I understand your last comment. Our edge case is that this.tokVector is empty because the file was empty, right? In this case this.tokVectorLength is 0 and if I ask for LA(0) this.currIdx + howMuch will also be 0, so LA will return END_OF_FILE. This is already the behavior you wanted, isn't it? It seems to me I can simply use LA(0) for saving the previously parsed token without any further checks.

In this case this.tokVectorLength is 0 and if I ask for LA(0) this.currIdx + howMuch will also be 0

this.currIdx starts at -1
Because normally you look at the next token so you call LA(1).
Which means on the first token you would need to access

this.tokVector[this.currIdx + howMuch] // -1 + 1 === 0

I know its confusing 😿

Ah ok, now I get it. Thank you for the explanation.

How about this:
        if (this.tokVectorLength === 0 || this.tokVectorLength <= this.currIdx + howMuch) {
            return END_OF_FILE
        } else {
            return this.tokVector[this.currIdx + howMuch]
        }

Mhm, while this would work in the edge case it might still cause problems if one calls LA(0) and you probably want a general solution. So I will simply do what you proposed. Sorry for thinking out loud.

ok, last question: What should happen if tokVectorLength > 0and this.currIdx + howMuch < 0? It would be misleading to return EOF in this case.

I think it is still correct that it is EOF, just that the EOF is also the Start Of File, for an "empty" file.
Also consider that if LA(x) is EOF LA(x+1) is also EOF.
So it is kinda of a "null"/"undefined" for tokens.
I don't see a good alternative, creating a SOF virtual seems redundant, and returning null/undefined
seems even less informative.

Today I finally managed to update Chevrotain in my parser to 2.0.1 and remove the workaround I posted above. I made some tests and realized that the same issue can occur in MismatchedTokenException and NoViableAltException as well. I previously thought that error.token can only be an instance of EOF if the error is an EarlyExitException, but this is not the case. MismatchedTokenException and NoViableAltException can also have EOF as their token and will not contain any location information in these cases. I have not been able to produce such a case with a NotAllInputParsedException but maybe the same issue can occur there.
So I guess it would make sense to add error.previousToken for all types of exceptions, right?

Sorry for the delay, I knew I missed replying somewhere 😄
NotAllInputParsedException can never have EOF as its token as the condition to throw it requires that
the next token is not EOF.
So it makes sense to expend whatever solution you implemented to those other Exceptions types as well.

Hi, have you added the previousToken information for MismatchedTokenException and NoViableAltException?
Or did you expect a pull request from me and closed the issue because I did not send you one (to be honest, I forgot this issue)?

Actually I was pruning the backlog and thought this issue was closed as I did not re-read the whole conversation. I will re-open it until once of us will get around to finishing it. 😄


Update harmony to 1.5.0

Please update my adapter ioBroker.harmony to version 1.5.0.
This pull request was created by https://www.iobroker.dev c0726ff.

RE-CHECK!


Add a note in the README to setup PostgreSQL for testing

Merged https://github.com/hibernate/hibernate-rx/pull/8
Thanks


Compatibility with Dice Tooltip.

Having this mod activated together with Dice Tooltip will still work, but when you put your mouse on the activity name, or the dice icon, you'll get errors in the console, because it seems to think that it's a weapon or something.
With the error coming up by hovering over both the icon and the name, the console quickly gets littered with errors.
Here is the error I'm getting.

dicetooltip.js:171 Uncaught TypeError: Cannot read property 'hasAttack' of null
at checkItemTooltip (dicetooltip.js:171)
at HTMLDivElement.mouseenter (dicetooltip.js:54)
at HTMLDivElement.handle (jquery.min.js:2)
at HTMLDivElement.dispatch (jquery.min.js:2)
at HTMLDivElement.v.handle (jquery.min.js:2)

So it might be an idea to check that up. :)
Other than that, thanks for a nice, practical and very helpful module! :)

Hey thanks for the report! I'm currently in the process of basically re-writing the module from scratch so I don't have a timeline for if/when a fix might be pushed out for this. It may be a matter of having support for this mod built into Dice Tooltip rather than the other way around, but I'll keep this in mind as I'm working and see what can be done!

Cool! As long as you're not stressing yourself out for it. :)

Soooo I'm pretty sure that the issue causing the console error spam was resolved a while ago completely by accident. I haven't actually verified this, but I do know for a fact that it doesn't spew errors all over the place as of the upcoming release (0.6.0).
As far as true compatibility, it doesn't look like that's going to be technically feasible. I could probably add an option in this module to display similar tooltips, though, if people are interested in that.


Create gulp task to facilitate TDD

Currently developers must manually run builds of the library, manually vet code & manually run tests. Create a gulp task(s) that will watch for code changes and automate the above stuff.

Putting this back in the pool. It's needed and I won't get to it for a few days due to other work. So, if someone wants to tackle it between now & then, go for it.
The idea here is that you can create a new gulp task... something like gulp live-dev that does the following:

[ ] watch for changes to any *.ts, *.js or *.html file... if anything changes...
[ ] run all tests & vetting: 'gulp vet' & 'gulp test'

note there seems to be an issue in the test site where karma doesn't release... it seems to hang and you have to manually kill it with CTRL+C... this will hold up additional work...

[ ] rebuild the library in debug mode: `gulp build-lib'
[ ] support all the existing arguments --verbose, `--specs', '--debug'... the first one should list out the file  that triggered the rerun

anything else i missed?

I can do that for a day or two. If that acceptable estimate I'm ready to go)

thx!

I'm using this new watcher when working on the uif-button and have run into a few things...

auto testing on build: This change introduced a dependency on the build-lib task in that it runs test prior to building. If any tests fail, it won't build.  But if you remove this precondition, the watcher won't run the tests because it only watches for changes to the tests to trigger running tests.
Scenario: With uif-button I wrote tests first to test against the spec I'm working against, 22 tests in total. I also created a demo page so I can see if the renderings are correct or if I missed something with a test. As it sits now... I have to code the directive to pass all tests before I can preview how it looks.

Locally I've made a few changes... curious on opinions:

in task build-lib, remove the dependency on the task test
in task watch, for the last watcher, added ./src/**/*.ts to the files to watch & added the task vet before running test

This way the first watcher will always build the library on any test / src change & the last one will always vet & test everything on the same condition. Merge these two watchers?
Thoughts?
Would also be nice to add a browsersync option to watch for changes in the built ./dist/*.js & ./src/**/*.html to reload the browser automatically. Thoughts?

Agreed on both points.
But I'd rather add transpile-ts as dependency for the test task, because tests require .js files and transpile-ts in its turn depends on vet.
Also thinking about something like this - gulp watch --dev --debug - in this case karma should start with option singleRun=false and additional browser param for debugging tests in chrome.

Works for me... that's another thing I noticed. When you startup watch it waits... ideally it should do the first pass on everything.

Hmm.. do you know how to do that? Normally gulp watcher don't start anything on initial watch.

Just a dependency on the watch task itself?

Yes! The answer is extremely simple :). Thank you! Never think in that way, that watch can have deps.

Started implementation.

Question: do we really need dependency on watch?
Scenario: I'm working on directive, made a lot of changes, tests are not finished and still failing. Closed cmd because it crashed\reboot\need to go\whatever reason. Later I back to work, run gulp watch and it fails because I still has unfinished tests. In this case task (test) which is dependent on watch is failing and that prevents watchers from starting. This prevents me to start watchers until I fix all tests.
Is it better to live it as is? No dependencies for watch, if you need to run build before watch, then you need explicitly run gulp build-lib

From my POV, when I run a watcher like this, I want it to do everything (vet, run tests, build library) without any blockers… it would do all that, report errors & then go back to watching.
Our gulp tasks SHOULD be written today to log the errors, not fail… if not, then IMHO that’s a bug.
So with this thinking I don’t think having dependency in place is bad… calling watch would run everything the first time, then just watch to see what it needed to do from there. Thoughts?

From my POV, when I run a watcher like this, I want it to do everything (vet, run tests, build library) without any blockers… it would do all that, report errors & then go back to watching.

Agreed. This is how it's working right now. The problem is, when running everything first time before watch and there is an error (at least one, vet error, or failing test), it prevents other task to run (watch task itself). Because of this we can't start watchers at all.
Let me illustrate this into following workflow. We added test as dependency on watch (test in turns depends on transpile-ts and transpile on vet). On first run, right after gulp watch, following will occur:
vet -> transpile -> test -> watch. If vet fails, then watch won't run, if test fails, watch won't run, etc. The process simply exits because preceding tasks are failed.
The question is how to deal with that? I'm not sure how to handle this through the gulp.
Do you know any workaround or practice for that?

Ah now I see what you're saying... Offhand I don't know. What if instead of within the task instead of the dependency it triggers the first three tasks and when they all finish it then sets of the watchers. Maybe using the module run-sequence?

Yep, sorry, my first explanation was not so clear.
run-sequence should work, will try that, thanks!

Hi, good job @s-KaiNet ! However, I don't like that it stops when my vet test fails. E.g. in development I don't worry too much about vet issues, I fix those at the end. I'm interested to know if my tests fail or pass.
I think part of your changes "gulp test" now also fails when vet fails.
So yes, I think run-sequence is the way to go.
And again good stuff, this will make our lifes easier :)

Thank you @rolandoldengarm !!!
I understand you issue, will make a change to support you scenario too.
How it looks like:
gulp watch - on first start vet, test, build on a sequence, if any errors - just continue
On any change *.ts under sources vet, test, build run on a sequence, if any errors - continue, no more dependencies
On any change *.ts under demo folder - transpile
On any change *.ts  under build files - transpile
good?

That looks good... one day would be cool if we got to the point where we could also use something like browsersync to have the demo page up and we can see the components working visually with auto refreshes... but that's down the road...

Good news @andrewconnell
That's already done! Just need to do final tests for all of this all together and PR will be on the way.

Also what I'm thinking about. When we run test task, it runs all tests, but in case of watching we probably need to run only one .spec.ts file from our directory where we are working. For example I have following issue: I'm working on directive under components/contextualmenu, I saved file and triggers test task in progress. Currently there are more than 140 tests and it produces a really long output, I need to scroll up to find which exact test failed and why. Also it takes more time to run all 140 tests instead of only 10-20 which a related to my directive.
What I'm proposing:
If watch detects that .spec.ts file changed - then run only this particular test.
If watch detects that .ts (say file components/contextualmenu/contextualmenu.ts) file changed - then find in current directory (contextualmenu) corresponding .spec.ts file (contextualmenu.spec.ts) and run only this particular test.
Benefits - faster workflow, significantly reduced output for test task during watch, test output contains only tests related to directive (folder) you are working on.
All this is relevant to watch task only, regular run gulp test will do the test for all of the directives.
Does that make sense?

I’d personally love this capability… specifically having a way to filter to a specific spec file. If the watcher can detect and only run that test, that would be ideal.
Would be nice if we also added this as an option to the basic test task to… something like gulp test —filter:table. That doesn’t have to be part of this update, but something to think about…

Thank you guys for your feedback. My first attempt didn't take all cases into account, but now with your help I believe "watch" story looks much better.
Short description:
gulp watch
On first run (before watchers setup) executes vet, transpile, build-lib, test in a sequence. Any errors just reported into the console, no blocking.
When watching:
[source or spec changed] -> runs vet, transpile, build, test in a sequence, any errors also are reported and also no blocking. For tests it grabs only spec files under folder you are working on, i.e. if src/components/icon/icon.ts changed, then test will run only specs which are in the folder src/components/icon. NOTE - I assume that all source and spec files located under src/components/<directive>/. If in future we will have some source or spec files under nested folders (src/componets/<directive>/source/file.ts), then watcher needs to be changed to address this
[build or demo files changed] -> vet and transpile only
gulp browser-sync
Runs browser-sync in a static mode with default port of 3000. After run it opens browser window with url pointed to http://localhost:3000/. After that you need to open your demo by using mentioned url, such as http://localhost:3000/src/components/icon/demo/index.html, you will see a message at the top right corner Connected to BrowserSync. Now changes in demo assets will trigger browser refresh.
gulp test --watch
Allows you to debug test in Chrome and automatically watch on file changes.
That's it.
If you want to use all of this tasks at the same time, you need to run it separately, i.e. 3 console instances (or tabs in Conemu). I've tried to put them in one watch and they are totally messed up, because every use it's own watcher.
I did my best in testing for all different situations, but of course there still might be errors\issues\inconsistencies. You are welcome to report all this and I will try to address.

Cool cool cool, can't wait to check it out.

Very nice work! Love this! Functionality you’ve nailed it… looking forward to using this! I have a few questions / comments… before merging this in I’d like to see what some others say with this. Mostly I’m thinking about the experience of the developer and help them understand what’s going on without much docs.
BTW - I added a few line comments in the PR as well that I think we should address before merging this in so please check those out as well…
Regarding browser-sync -
First the name (yes, I’m being a little picky here)… I think we could rename this to be more descriptive of what this is doing… for the name to speak the intent. Browser sync as a name doesn’t say what this does. What this is doing is doing live reloading of a new server. Maybe “serve-demo” or “static-serve” or just “serve”?
Also, for me, this really should be part of the watcher… not saying we should remove the ability that lets you run it independently… but right now it’s not possible to do live dev (that the new “watch” facilitates) AND see the demo… seems like a gap. The only way around this is two console windows, one kicking off browser-sync, one kicking off watcher. Maybe a switch for “gulp browser-sync —watch” or the other way around (“gulp watch —browser-sync”) <<< these would be pending the name changes I’m proposing…
The description in the task needs to explain that you will have to manually type the URL  => demo… I admit that I ran it and was looking at the gulp help description as well as the code and couldn’t figure out why my stuff wasn’t loading. I see it’s mentioned in the gulp task doc, but maybe updating the actual task file & description written in the gulp help?
Regarding watch -
Again, I”m going to be picky, but it’s a naming thing. Maybe “auto-test” or “live-test” or “continuous-dev” (or a shorter version) or “live-dev”? Does the name “watch” work for others? Some project use the word watch, I’ve always preferred task names that speaks more to the intent.
Regarding run-all-sequence -
Same thing with the name… we don’t need to use the module name in the task name. Current name implies every gulp task is run, but that isn’t what it does… What does this do? It runs all the dev stuff… vet, transpire, build & test. Some ideas: “build-check”, “check-build”, “build-all”, “build-full”, “validate-build”. Personally I favor the last one… thoughts?

Very good points, @andrewconnell , thank you! Agreed with all of them. I was thinking from my own view and definitely miss the point that all of this should be obvious and intuitive for others (especially for those who wants to quickly jump-in to the project). The only thing which make me sad, is that both watch and browser-sync don't want to work well together for me. The process exit with error, but I will give them another shot, may be I did something wrong.
For the memory:

[ ] rename browser-sync to serve-demo
[ ] combine serve-demo and watch (or try at least)
[ ] make description for serve-demo more informative and descriptive
[ ] rename watch  to live-dev
[ ] rename run-all-sequence to validate-build
[ ] address issues commented out in the PR

I believe your points looks good for the team and it doesn't make big sense to wait response from other guys. This task is rather helpful and wanted, so I'm just trying to speed up all the things.   I'm starting this changes, and if any comments\thoughts etc. will address them.
Agreed?

Whew… glad you took my feedback like like that… you did great work and didn’t want to come across wrong :)
Everything looks good. As for the combination of serve-demo & watch… maybe it’s just a flag? We do want two separate tasks because maybe someone is just working on demos while someone else wants to work on the directive and look at the demos live. At any rate, the way you have it supports both of these scenarios, the user would just have to open a second console window to run the browser sync while watching happens in one. I think that’s perfectly acceptable for now.
If adding the option to the watcher to startup browser sync isn’t a simple thing like you say, then remove that from your checklist. Two console windows is acceptable IMHO.


Redirect to Dev Center article on node + grunt?

Heya, I maintain the node buildpack over at Heroku. With grunt + grunt-cli in dependencies, you can run grunt tasks on postinstall by default:

https://devcenter.heroku.com/articles/node-with-grunt

What do you think of sending folks that way so they can keep up with regular buildpack updates while they use grunt?

Thank you, I finally got around doing that.
This buildback will no longer be maintained.


Fix PeerTaskInstancePriorityQueue cannot contains method use taskInstanceId to check

Purpose of the pull request
Since we don't have the taskInstanceId until we insert it into database, so we cannot use taskInstance to check if we already have this task in queue.
(PS: Maybe we can generate the TaskInstance by ourselves by using some way like https://tech.meituan.com/2017/04/21/mt-leaf.html, so that we don't rely on the database to generate id and we will not have these problems)
Brief change log
Use processInstanceId-taskCode-taskDefinitionVersion to identify a unique taskInstance.

Codecov Report

Merging #10491 (8f5a9b0) into dev (f1a9c0d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev   #10491   +/-   ##
=========================================
  Coverage     40.87%   40.87%
+ Complexity     4849     4848    -1
=========================================
  Files           886      886
  Lines         35990    35996    +6
  Branches       3993     3993
=========================================
+ Hits          14710    14715    +5
  Misses        19822    19822
- Partials       1458     1459    +1

Impacted Files
Coverage Δ

.../server/master/runner/WorkflowExecuteRunnable.java
7.74% <ø> (ø)

...r/service/queue/PeerTaskInstancePriorityQueue.java
93.54% <100.00%> (+1.54%)
:arrow_up:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a9c0d...8f5a9b0. Read the comment docs.


docker: Add gen_trace and move spike-dasm to /usr/bin

This moves spike-dasm to /usr/bin so it will be on PATH by default.
It also moves /gen_trace to be inside the docker container (we need it in snax-mlir even without the snax_cluster repository).
This is required to move forward with https://github.com/KULeuven-MICAS/snax-mlir/pull/165

Okay. rerunning all tests on the new docker build now

Push this! So that the docker builds! Or actually, you can kick the docker build from here from the git actions. @JosseVanDelm
But note it will over-write the main of course hehe.

@rgantonio @xiaoling-yi , any thoughts/ideas on why the wide gemm build is behaving so weird?

@rgantonio @xiaoling-yi , any thoughts/ideas on why the wide gemm build is behaving so weird?

Such sorcery! I mean it passed previous ones right?... I'll try to run on my side but that's so weird...


[SPARK-44384][SQL][TESTS] Use checkError() to check Exception in ViewSuite, NamespaceSuite, DataSourceSuite

What changes were proposed in this pull request?
The pr aims to use checkError() to check Exception in *View*Suite, *Namespace*Suite, *DataSource*Suite, include:

sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite
sql/core/src/test/scala/org/apache/spark/sql/NestedDataSourceSuite
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2FunctionSuite
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2Suite
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/ShowNamespacesSuite
sql/core/src/test/scala/org/apache/spark/sql/sources/ResolvedDataSourceSuite
sql/core/src/test/scala/org/apache/spark/sql/streaming/sources/StreamingDataSourceV2Suite
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/AlterNamespaceSetLocationSuite

Why are the changes needed?
Migration on checkError() will make the tests independent from the text of error messages.
Does this PR introduce any user-facing change?
No.
How was this patch tested?

Manually test.
Pass GA.

cc @MaxGekk

+1, LGTM. Merging to master.
Thank you, @panbingkun and @HyukjinKwon for review.


Replace signing method with aws4 module

The signing method used was not up to date and was not posting
to amazon. This updates the module to use aws4  to sign
requests.
I tried to stay true to your original tests as much as possible, but the pathname -> prefix change
warrants a major version release.

Removes the custom signing method and any variables associated.
Adds logic for parsing region from the URL or options.
Extends curly to sign all requests passed using aws4
Changes a few tests to match
Move more info into the returned object
use that moved info inside of the request methods

Also, there is an issue with the string parsing, where
buckets delimited with '.' will fail, because the bucket
and region cannot be located / built properly. I added
a warning in the code and in the README to publicize this
Side Effects:

README spelling corrections
Renamed pathname to prefix for clarity
Update travis to test v4 and v5
Removes v.10 from the tests due to an inconsistency with http request

Closed in light of just using the aws-sdk module: http://docs.aws.amazon.com/AWSJavaScriptSDK/guide/node-examples.html#Examples_Using_Node_js


The number of step in *.feature

Hello!
The new version allure-report does not have numbers of step in the test scenario (*.feature). I want to sort the steps in the order in which they are performed.
Please, look at the screen-shot:

My package.json:
"dependencies": {
    "babel-preset-es2015": "~6.24.0",
    "babel-register": "~6.24.0",
    "chai": "~4.0.0",
    "cucumber": "~2.2.0",
    "wdio-cucumber-framework": "~0.3.0",
    "wdio-selenium-standalone-service": "~0.0.8",
    "wdio-spec-reporter": "~0.1.0",
    "webdriverio": "~4.8.0"
},
"devDependencies": {
    "allure-commandline": "^2.1.1",
    "babel-jest": "~20.0.0",
    "babel-polyfill": "~6.23.0",
    "eslint-config-airbnb-base": "~11.2.0",
    "eslint-plugin-import": "~2.6.0",
    "wdio-allure-reporter": "^0.1.2"
}```

duplicate https://github.com/allure-framework/allure2/issues/403


bug:  Multiple Variants and Lock files

Meltano Version
3.5.1
Python Version
3.10
Bug scope
CLI (options, error messages, logging, etc.)
Operating System
Ubuntu 20.04
Description
Try to take the meltano.yml from https://docs.meltano.com/guide/plugin-management/#multiple-variants and run meltano install and then run the required lock commands. You'll find this doesn't work.
I personally don't have the issue but dean in slack does https://meltano.slack.com/archives/C068YB1BMD5/p1725410727155789
To Reproduce
Steps to reproduce the behavior:

Take the yaml from https://docs.meltano.com/guide/plugin-management/#multiple-variants
Run meltano install
Run meltano lock --update --all as requested
Run meltano install, it won't work

To get things working.

Start from an empty meltano project
Run  meltano add extractor tap-postgres
Run meltano add extractor tap-postgres--transferwise --inherit-from tap-postgres --variant transferwise

Now everything works for you as your lock files are setup properly
Code
No response
Link to Slack/Linen
https://meltano.slack.com/archives/C068YB1BMD5/p1725410727155789

Related to https://github.com/meltano/meltano/issues/6731 , might want to close for that one. I'm not sure

Related to #6731 , might want to close for that one. I'm not sure

Let's do that


FIX Permissions on DNDataArchives weren't creating unique cache keys.

This fixes permission checks for listing snapshots.

Looks A+ apart from that random indentation :)

Well done, you both passed the test. Cleaned up the clearly intentional whitespace...

Sweet, looks good. I'll wait for tests to pass.


[share image gallery]: fix update commands, support --no-wait

Fix #7352 Fix #7363
Change summary:

Expose --no-wait from az sig create/update commands

Expose az sig image-version wait command in case you invoke the the create command with --no-wait flag but later want to wait before create the VM

Fix the az sig update, az sig image-definition update, and az sig image-version update so they are usable

Add more examples, particularly on image-version

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

Fix the linter. Help missing for the wait command.


syslog/channel: rename syslog_channel() to syslog_channel_register()

Summary
syslog/channel: rename syslog_channel() to syslog_channel_register()
Change syslog API naming more reasonable:

rename syslog_channel() to syslog_channel_register()
rename syslog_channel_remove() to syslog_channel_unregister()

Signed-off-by: chao an<EMAIL_ADDRESS>Impact
N/A
Testing
ci-check

[Experimental Bot, please feedback here]
This PR appears to meet the basic NuttX requirements, but it's missing some key information:
Summary:

Why change is necessary?  The summary mentions making the naming "more reasonable," but doesn't explain why the current naming is unreasonable or what benefits the new naming brings.
What functional part of the code is being changed?  While "syslog/channel" is mentioned, a slightly more detailed description of this part of the codebase would be helpful.

Impact:

While marking everything as "N/A" might be technically correct, it's best to be explicit.  For example:

Impact on user:  Will users need to update their applications to use the new function names? If so, is this change backwards compatible?
Impact on documentation: Even if the changes are small, the documentation likely needs updating to reflect the new function names.

Testing:

"ci-check" is not enough information.  Provide details about the build host(s) and target(s) used for testing.
Include relevant testing logs before and after the change. This helps demonstrate the issue the PR addresses and proves that the change works as intended.

In short, the PR needs more context and details to be considered complete.


Bug: Time interval value is disorder in group by month

How to reproduce:

Set your system zone to: +04:00
Open Server
Open Cli
Execute set time_zone=+08:00
Execute the query above.


Fix last bug and optimise catalog function

fixes #3233 OCI Conformance: GET start of tag is set by last query parameter
Basically this implementation will only stat n times, and only look at the dirs required.
E.g. with around 6.500 images, this will only call the rec function ~100 times (which also means stat that amount), whereas the other will be called ~20.000 times, where it will stat them all.
This also fixes a bug where if you specify something close to a last entry, e.g. fo, and foo is meant, then it will work.
This should not be the behavior, as it can cause various bugs.
Removed the lessPath as it isn't needed anymore.
Fun fact, the non-native method is slower than native.
BenchmarkPathCompareEqual-4         	 3906804	         297 ns/op
BenchmarkPathCompareNotEqual-4      	148567686	         7.93 ns/op
BenchmarkPathCompareNative-4        	212109276	         5.61 ns/op
BenchmarkPathCompareNativeEqual-4   	283666616	         3.83 ns/op

Should be ready to merge!

@eyJhb can you please rebase this PR

@eyJhb can you please rebase this PR

Trying to get this up-to-date, but there is some logic I need to look at :)

So the checks fail on
=== RUN   TestHMACValidation
--- PASS: TestHMACValidation (0.00s)
FAIL
coverage: 59.0% of statements
FAIL	github.com/distribution/distribution/v3/registry/handlers	136.047s
FAIL
make: *** [Makefile:75: coverage] Error 1
Error: Process completed with exit code 2.

and
Uncontrolled data used in path expression

Both seems to be some new checks that have been introduced. I am not sure what the best way would be to fix these two things? Is there a "validation" function for the uncontrolled path, or would you rather handle this higher up?

I have not yet reviewed this properly, yet. I am aiming to do so tomorrow but wanted to give people a nudge so the code is in sync with main.

Uncontrolled data used in path expression

This, from CodeQL scanner is an interesting catch, but that should not prevent the regular test suite from passing.

I have not yet reviewed this properly, yet. I am aiming to do so tomorrow but wanted to give people a nudge so the code is in sync with main.

Uncontrolled data used in path expression

This, from CodeQL scanner is an interesting catch, but that should not prevent the regular test suite from passing.

I think the coverage dropped, and thereby the regular test failed. I am not quite sure.
But they are both rebased now, and should be ready for a review. Not sure how much time I have on my hands, but I will try to do my best to fix whatever might come up.
Anything to make this pass the CI/CodeQL is highly appreciated as well.
Appreciate you taking these up! :)

@eyJhb I can pick this up if you want me to, but you'd have to allow write access to this branch to the maintainers. See here

That might be the best, as I have exams until the 11th if June.
I will do it once I get on the university campus! Thanks for offering your help, it is highly appreciated! :)
On 27 May 2021 22:58:01 CEST, Milos Gajdos @.***> wrote:
@.***Jhb I can pick this up if you want me to, but you'd have to allow

write access to this branch to the maintainers. See
here
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/distribution/distribution/pull/3145#issuecomment-849936732

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

@eyJhb I can pick this up if you want me to, but you'd have to allow write access to this branch to the maintainers. See here

Just looked, this should already be enabled :)

Tests are passing now. I need to have a think about the CodeQL report. I understand why it's moaning (filesystem driver potentially ending up in path traversal situations), but I'm not quite to sure how to fix it at the moment.

Don't think it is so easily fixed, and it would be a issue if the current code was pushed today, right? :)

Don't think it is so easily fixed, and it would be a issue if the current code was pushed today, right? :)

Ugh, I've completely forgotten about this one.
Yeah, so the biggest problem with merging this as is would be, it would keep on breaking all the subsequent builds :-/


[add] gina.vim's url

Hi, Christian.
I forget to write gina.vim's url in extensions/gina.vim file so I added it.

thanks!


CHANGELOG.md

Would be nice to see whats new with v0.3 (and other new versions in the future).

Good idea, agree!

@amcdnl You should take a look at this: https://github.com/semantic-release/semantic-release

automatically releases on NPM
automatically releases on GitHub with nice changelogs generated from conventional commit messages.

(Planning to use it for angular-model-factory)

@amcdnl by assigning me to this, does that mean u like it and I should configure that? :wink:

doing this in release page now

@amcdnl did activate semantic-release?

no, just did a release page for now


Add imajes

Looks perfect! Can you rename the repo to just imajes or if you must use a prefix choose one from:

fish-
fisher-

Because fm- is not a recognized prefix and users will have to type fm-imajes to refer to the plugin instead of just imajes which is what we want right?

done

Thanks and welcome aboard.


Linters for Rust

[ ] rustc
[ ] Clippy

It would be nice to use --error-format=jsonv1 for this instead of trying to parse the output.

That could be done. We'd have to first change a few things to let you enable accepting JSON output. We'd have to make sure it would also work in NeoVim. That could be an issue.

@w0rp NeoVim has stricter JSON parser, but IIRC it doesn't matter as Rust always output valid JSON.

Per neovim/neovim#4131 the jsondecode() function exists in both Vim 8 and NeoVim.

I think we'd probably have to take the raw JSON text in NeoVim, and then decode the data ourselves, but in Vim 8 we can make it pass on JSON data instead. It will be a bit of work, but it's possible. I'd open up another issue for it. I'd be in favour of first parsing text output for the warnings and errors, if that's not too much trouble, and then later work with the JSON data once that works.

I would just take in text and jsondecode() it for now (in the handler) in vim and neovim, and later decide if we want to use Vim 8's system() json support.

Yeah, that could be one step along the way. The advantage of using Vim 8's built in JSON encoding and decoding in the job itself is that it can run the decoding asynchronously, as to not slow down editing files.

There is also the question on whether to use -Z parse-only vs. -Z no-trans.

@euclio there is bigger problem: all -Z options will soon stop working on stable rust-lang/rust#31847

Also I would vote for -Z parse-only as -Z no-trans forces us to build whole project, otherwise we will get a lot of "module not found"-kind of errors (as it also try to resolve dependencies).

Seems like a moot point now that rust-lang/cargo#3296 is merged. However, there's still the trickiness of figuring out when to send --bin, --lib, etc.

Just wanted to inform you that I made an integration for rustc and cargo as linters (without noticing this issue here). See #230. I didn't use cargo check, because it's at the moment only included in nightly and AFAIK won't be included before rust 1.16 and because it has some bugs.

The pull request looks like it could work, but not as you type. It might not be possible for some linters to check for problems as you type, but only on enter or on save. We could consider disabling particular linters with a new option for checking for changes while you type.

I think Clippy is supposed to be used as plugin for cargo check, which can be configured in a configuration file, so I'll close this. If anyone has anything they want to add for Clippy, open up a pull request.

@w0rp, how can I use clippy as a plugin for cargo-check?

Ok, it's possible to use with adding clippy to projects directly.
But there is a problem with this approach: it requires
let g:ale_rust_cargo_include_features = 'clippy'

So, every project that do not use explicitly clippy as plugin, will fail checking with cargo check.
It seems more flexible to have a separate clippy linter, am I right?


[Conversation UX] When copying mention, don't copy assisant description

Description
Fixes https://github.com/dust-tt/dust/issues/5699 and relatedly https://github.com/dust-tt/tasks/issues/882
Before:

After:

Risk & deploy
na

Good point; will try to make it work at the tooltip component level
(not sure I can avoid the setTimeout though; can try, but will limit investigation since i'm already 2 hours+ in this rather mild but surprisingly challenging issue)

Actually, the little issue I'd see with this is that sometimes you may want to select the tooltip text...

Actually, the little issue I'd see with this is that sometimes you may want to select the tooltip text...

I just discussed it with @Duncid and he confirms we don't want to allow selecting the tooltip texts, tooltips content are not meant to be copy/pasted 🙏🏻

closing, moved to https://github.com/dust-tt/dust/pull/5890

Reopening. Doing this at the tooltip level does not work unfortunately
This is because onCopy events are only sent to the largest enclosing element; so the tooltip only receives them if you only select the content it tooltips, which defeats the point here
I think I have to timebox it now, so would like to fix the original issue with this if ok with you?

After irl discussion, we'll just remove the tooltip on the mentions cc @Duncid

closed in favor of https://github.com/dust-tt/dust/pull/5892


started getting failure to notify

With the upgrade from 0.7.2 - 0.7.4 our build/test system started dying on the following error.  Doing a role back to 0.7.2 fixes it.
    ================================================================================
    Error executing action `apply` on resource 'sysctl_param[vm.swappiness]'
    ================================================================================

    Chef::Exceptions::ResourceNotFound
    ----------------------------------
    resource execute[sysctl[vm.swappiness]] is configured to notify resource ruby_block[save-sysctl-params] with action run, but ruby_block[save-sysctl-params] cannot be found in the resource collection. execute[sysctl[vm.swappiness]] is defined in /var/chef/cache/cookbooks/sysctl/providers/param.rb:23:in `block in class_from_file'

    Resource Declaration:
    ---------------------
    # In /var/chef/cache/cookbooks/hadoop/recipes/_system_tuning.rb

     25: sysctl_param 'vm.swappiness' do
     26:   value 0
     27: end
     28:

    Compiled Resource:
    ------------------
    # Declared in /var/chef/cache/cookbooks/hadoop/recipes/_system_tuning.rb:25:in `from_file'

    sysctl_param("vm.swappiness") do
      action [:apply]
      updated true
      updated_by_last_action true
      retries 0
      retry_delay 2
      default_guard_interpreter :default
      declared_type :sysctl_param
      cookbook_name "hadoop"
      recipe_name "_system_tuning"
      value 0
      key "vm.swappiness"
    end

Please see #51

ok defaulting to that issue


Create MSIX package for WinForms Core app

Summary
This sample uses the Windows Packaging project to produce an MSIX from a .NET Core self contained application.

This looks good, @rido-min. Is it ready to merge, or should anyone else review it?

@sbanni can help with the review of the wapproj customizations based on @onovotny suggestion.

@rido-min  Looks good to me.

Can we merge this one now?


Allow cancelling orders

Fixes #120
🚨 We need to backport this on main/master + release new versions.
Summary
Implementing #try_void on the PayPal payment method, we can now cancel orders from the admin panel.
With try_void ready, Solidus will try to void the payment, if it's too late and the order is already captured, it will immediately issue a refund, otherwise it will just void the payment.
Test
I've made two orders locally and canceled them.
The first one was not captured, and it's correctly voided:

The second one was captured and it's correctly cancelled + refund issued:

Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed (~cross them out~ if they are not):

[x] I have added automated tests to cover my changes.
[x] I have attached screenshots to demo visual changes.
[ ] I have opened a PR to update the guides.
[ ] I have updated the README to account for my changes.

There's a delegate on the payment method that points to the gateway. I went that route because all the other methods are defined there. Is there a specific reason to have it in the payment method instead?

There's a delegate on the payment method that points to the gateway. I went that route because all the other methods are defined there. Is there a specific reason to have it in the payment method instead?

We separated gateway from payment method a while ago to make multiple payment methods per gateway possible (easier to implement), mostly to clarify things up for future payment implementations. And I think since this is such an official extension from the core team, we should follow solidus_core design principles as an example for community extensions.

You are right. I was thinking that since it deals with void on the gateway and ActiveMerchant::Response objects, it was better to have it on the gateway, but this is the right place for the method. Updated + I will try to move this to the core.

I'm trying to change the default implementation in core but it's not as linear as I thought initially: apparently each gateway has a different signature for void (see store credits, bogus credit card, solidus_paypal_braintree gateway, solidus_paypal_commerce_platform gateway).
Not sure if it's worth add conditional code that works for all the signatures in this default method, WDYT @elia @tvdeyen ?

@kennyadsl I think there are only 2 signatures, one with source as the second argument and one without, and that is dependent on payment_method.payment_profiles_supported?:
https://github.com/solidusio/solidus/blob/16d1e3704fbbe630a584c919de1a640a6ab6c6f8/core/app/models/spree/payment/processing.rb#L74-L81
There's probably a larger conversation that we could have about the double signature, but for now I think reproducing that if somewhere else should be fine.
I any case this PR can and should be merged in the meantime 🙌

@elia @tvdeyen: https://github.com/solidusio/solidus/pull/4843 WDYT?


[Citadel] Update JointCmd and PID messages to support optional fields

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

In gazebo::msgs and ign-msgs2 and earlier, we used proto2 syntax, in which it could be determined which fields were unset. Since ign-msgs3, we are using proto3 syntax, in which unset fields of primitive leaf types (string, int, float, etc) are indistinguishable from fields with a default value. This is problematic for the JointController in osrf/gazebo, in which position PID, velocity PID, and force control can be applied additively in any combination. It is common to use a PID control along with a feed-forward force parameter to counteract constant disturbances (like gravity compensation).
Currently this is problematic for the JointCmd and PID messages because JointCMD::force is a double, and the target and gain values in PID are double. So it will work if you are only sending a force, but if you simply want to update the target of a PID controller, that will reset the force and the PID gains unless you repeat those values.
cc @chapulina  @iche033  @azeey
Let's think about doing this before the ign-msgs5 cutoff.

I believe this was addressed on this PR: https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-msgs/pull-requests/162/page/1


Add workflow to mark issue/pr stale

Add workflow to mark PR/Issue stale and close them.
TODO

[ ] Discuss options exempt-pr-labels, only-issue-labels etc

cc: @phanikumv as discussed. let me know if this help in some cleanup. thanks!

Sorry did not check this earlier. Do we also want to apply this to issues? It looks like we'll be closing issues after 6 months of inactivity?

I just put it for discussion and I'm open to changing it. please feel free to suggest any improvement.


Tags and branches should use same naming convention as other NMOS specification repos

Tags and branches should use same naming convention as other NMOS specification repos to ensure the NMOS Testing Tool and GitHub Pages documentation can be generated consistently, shouldn't they?
If so:

master branch should be deleted
v1.0_rc1 tag should be deleted
v1.0_spec tag should be renamed simply v1.0

If so, this section should also be revised: https://github.com/AMWA-TV/nmos-network-control#releases

As discussed in today's call, above should be done before making a v1.1-dev branch and subsequent PRs for NAT, etc.

Done - thanks, @peterbrightwell


feat: add support of cloudflare workers runtime

HI thank you for you work 😄 ,
I resolved two problems that are needed to make the lib work in cloudflare workers runtime:

removed credentials http header which is not available
changed the way that the global fetch function is passed to the Platform class

And I have implemented the cache for cloudflare workers

Thanks!


rename stream.Cancel to stream.CloseAbruptly

No functional changes expected.
stream.CloseAbruptly is only called when the session is closed.

Codecov Report

Merging #1023 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1023   +/-   ##
=======================================
  Coverage   90.56%   90.56%
=======================================
  Files         103      103
  Lines        7087     7087
=======================================
  Hits         6418     6418
  Misses        435      435
  Partials      234      234

Impacted Files
Coverage Δ

crypto_stream.go
100% <ø> (ø)
:arrow_up:

streams_map.go
92.22% <100%> (ø)
:arrow_up:

stream.go
94.07% <100%> (ø)
:arrow_up:

session.go
83.49% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3679c56...119bbf4. Read the comment docs.

If it's only called by the session, can we put that in the name? E.g. OnSessionClosed()?

@lucas-clemente: Done. PHAL.


@FieldDefaults(makeFinal = true) and bitwise operators produce an error message

This is fine:
class A {
	final short s1 = 2;
	final short s2 = 4;

	void foo() {
		short s3 = s1 ^ s2;
	}
}

This compiles and runs but produces an error message when looking into the class:
@FieldDefaults(makeFinal = true)
class A {
	short s1 = 2;
	short s2 = 4;

	void foo() {
		short s3 = s1 ^ s2;
	}
}

Same with this:
@FieldDefaults(makeFinal = true)
class A {
	short s1 = 2;
	short s2 = 4;

	void foo() {
		short s3 = 1;
		switch (s3) {
			case s1 | s2:
				break;
		}
	}
}

It looks like the compiler does not see that the fields are final when checking bitwise operators.

Unfortunately, this cannot easily be fixed:( It's the same problem, like in #137 and #56. There are no extension points in Intellij, to change the visibility of existing fields or methods.

Thank you for the insightfull comment :)

+1


consider specific  type of number in orderBy

All numbers are considered as integers. Although some of them are floating numbers. This should be taken into account. This affects the results

done

Now all numbers are considered as floats.
It may slightly affect performance. But the effect is not noticeable.


AddressSheet doesn't trigger callbacks after upgrading to react-native 0.76.2

Describe the bug
AddressSheet component doesn't trigger onError or onSubmit callbacks anymore. It was working fine on react-native version 0.74. I am using Expo (v 52) and I tried using 3 different versions of this module (38.6, 39.0 and 40.0) and neither works.
To Reproduce
Steps to reproduce the behavior:

Create new Expo project through their CLI npx create-expo-app@latest
Reset project npm run reset-project
Replace index.tsx with

import { Button, Text, View } from "react-native"
import { AddressSheet, StripeProvider } from "@stripe/stripe-react-native"
import { useMemo, useState } from "react"

export default function Index() {
    const [visible, setVisible] = useState(false)
    const addressDefaultValues = useMemo(() => {
        return {
            name: "John Doe",
            address: {
                city: "San Francisco",
                country: "US",
                line1: "123 Market St",
                line2: "Suite 500",
                postalCode: "94103",
                state: "CA"
            }
        }
    }, [])
    return (
        <StripeProvider
            publishableKey={"some_stripe_pk_key"}
        >
            <View
                style={{
                    flex: 1,
                    justifyContent: "center",
                    alignItems: "center"
                }}
            >
                <Text>Edit app/index.tsx to edit this screen.</Text>
                <Button title={"Open Address Sheet"} onPress={() => {
                    setVisible(true)
                    console.log("im here")
                }
                }></Button>
                <AddressSheet visible={visible}
                              defaultValues={addressDefaultValues}
                              onSubmit={(data) => {
                                  console.log(data)
                                  setVisible(false)
                              }}
                              onError={(err) => {console.log(err)}}></AddressSheet>
            </View>
        </StripeProvider>
    )
}

Start the app
Click on the Open Address Sheet button
Click Save address button
Observe no log and inability to open the sheet again due to visible not being reset

Expected behavior
Expectation is for onSubmit and onError to trigger
Additional context
My presumption is that there is a change to how native components should be merged into react-native:
0.74 native components
0.76 native components

New architecture is on by default in 0.76. Did you leave it on? Did you have it off before?
I suspect it is in issue with stripe-react-native and new architecture - https://github.com/stripe/stripe-react-native/issues/1774

This is my suspicion as well. I didn't have it enabled before and I naively tried to disable it via a config on 0.76, but I wasn't able to validate if I managed to do it. I decided to drop the problem after this suspicion

Similar error here. I upgraded to Expo 52 and now the CardForm component does not trigger the onFormComplete event handler, tried to set newArchEnabled to false but it didn't help :disappointed:


WIndows XP browser

Its a Macbook Air with a fresh install of windows XP
I need to get a new browser as the default browser does not work as it has been discontinued(internet explorer). However I cannot look up a new browser as the one I have is dead. But I cant use shared files for whatever reason either.

https://mac.getutm.app/gallery/windows-xp
Due to the age of this operating system, Internet Explorer 6 will NOT work at loading most websites even if internet is working. You should download Firefox 52 ESR, the last version to support Windows XP and use UTM’s directory sharing feature to install it.
Firefox 52 link: https://ftp.mozilla.org/pub/firefox/releases/52.9.0esr/win32/en-US/

What about Mypal? I used Mypal on my Windows XP and Windows Vista virtual machine.

@ProfessorKett https://github.com/win32ss/supermium/releases/tag/v126-r6


linux: add 4.6

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thank you for the patch, but looks like it was overlooked


Add Debian 10 and Red Hat, CentOS & OL 8

Coverage remained the same at 88.068% when pulling 0f5343e6c77195db9b5558892dc57f7e6f5f525b on ekohl:add-distros into 338b8908f76d27a0520e6b1cc939a6ce82e2ef4d on hercules-team:master.

Any chance this will be merged in? We are currently trying to use rhel8 in our environment and this is currently a blocker.


deps: update deps for security.

also fix a test that i thought broke w node 16 but i guess somehow
also breaks sooner with some dep combinations?

I'm seeing some merge conflicts, so I think a rebase would be helpful? I'm also noticing some dependency updates that were already made in previous commits (e.g., eslint was also updated in 442ec8ba18d87bbe45e976c78f0e32565b2c2418). Not sure, but I also think that 42cfc8d9ec89ee49dbeee51c09c4396d25d62c59 fixed the PartialPipe test.
Might also be helpful to review and merge #402 so that that error doesn't affect this PR?

oops


Enter click within dropdown now moves selection forward

Clicking enter when focused on a dropdown moves you over to the next structured field. I haven't implemented a shift-enter functionality because it feels somewhat foreign to me, but if someone feels passionately that shift-enter should move you backwards, I'm happy to implement that feature!

Nice! Enter moves the selection to the next dropdown and gets rid of that strange bug where pressing enter creates new drop downs.
One thing, can you remove the console logs you used for testing? Other than that, looks good!