Opening the BT editor with F5 in multiplayer after spawning a few deer then trying to open the drop-down meant to hold BT entities crashes the game

To replicate: Run or join a multiplayer game with WildAnimals enabled. Press F5 and click the drop down in the top left.
To troubleshoot: Follow the stacktrace or consider running in debug mode with a breakpoint close to where the NPE happens. Figure out what the null is and harden the code so the game won't crash - just log a useful error instead :-)
Results in the following crash log on the client:
12:55:47.947 [main] ERROR o.t.e.event.internal.EventSystemImpl - Failed to invoke event
java.lang.NullPointerException: null
	at org.terasology.logic.behavior.nui.BehaviorEditorScreen$4.get(BehaviorEditorScreen.java:124)
	at org.terasology.logic.behavior.nui.BehaviorEditorScreen$4.get(BehaviorEditorScreen.java:121)
	at org.terasology.rendering.nui.widgets.UIDropdown.getOptions(UIDropdown.java:163)
	at org.terasology.rendering.nui.widgets.UIDropdown$1.onMouseClick(UIDropdown.java:64)
	at org.terasology.rendering.nui.internal.CanvasImpl.processMouseClick(CanvasImpl.java:243)
	at org.terasology.rendering.nui.internal.NUIManagerInternal.mouseButtonEvent(NUIManagerInternal.java:606)
	at org.terasology.rendering.nui.internal.NUIManagerInternalMethodAccess.invoke(Unknown Source)
	at org.terasology.entitySystem.event.internal.EventSystemImpl$ByteCodeEventHandlerInfo.invoke(EventSystemImpl.java:531)
	at org.terasology.entitySystem.event.internal.EventSystemImpl.sendConsumableEvent(EventSystemImpl.java:301)
	at org.terasology.entitySystem.event.internal.EventSystemImpl.send(EventSystemImpl.java:280)
	at org.terasology.entitySystem.entity.internal.BaseEntityRef.send(BaseEntityRef.java:204)
	at org.terasology.input.InputSystem.send(InputSystem.java:496)
	at org.terasology.input.InputSystem.sendMouseEvent(InputSystem.java:469)
	at org.terasology.input.InputSystem.processMouseButtonInput(InputSystem.java:212)
	at org.terasology.input.InputSystem.processMouseInput(InputSystem.java:191)
	at org.terasology.input.InputSystem.update(InputSystem.java:134)
	at org.terasology.engine.modes.StateIngame.handleInput(StateIngame.java:192)
	at org.terasology.engine.subsystem.lwjgl.LwjglInput.postUpdate(LwjglInput.java:55)
	at org.terasology.engine.TerasologyEngine.tick(TerasologyEngine.java:467)
	at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:421)
	at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:397)
	at org.terasology.engine.Terasology.main(Terasology.java:156)
12:55:47.960 [main] ERROR o.terasology.engine.TerasologyEngine - Uncaught exception, attempting clean game shutdown

Still present as per the March 2020 play test

Found that this is still present as of July 16 2020.  Attempted to apply the fix outlined in PR by kaen for #4076  and found that this issue persists even after.

Seems like the context object lacks the BehaviorSystem class when using a client in multiplayer, so when the BehaviorEditor is initialized, it gets a null behaviorSystem field. This causes the error when you go to get Interpreters from the behaviorSystem

Adding some more information here why #4088 got closed and what another take on this issue might be.
Option 1: If the behavior editor screen needs to interact with the code running as authority then the editor should probably only be availabale on the authority system. We could "fix" the crash by at least checking whether the injected system is non-null, and gracefully fail otherwise. We could evene show a meaningful message in that case stating that in order to use the behavior editor you'll need to be running as the host.
This could also be a short-term solution, even if Option 2 is considered.
Option 2: If the behvior editor can work with minimal to none interaction with code that actually needs to be run on the authority system the system coude could be split up into authority and client systems. This would involve a coordination overhead for sending events around between client and system, but would potentially allow a clean implemenation of the behavior editor based on the client system. @AndyTechGuy did recently figure out how to enable things for multiplayer, introducing server and client events and replicating data.
@IsaiahBlanks I hope you're still up for the challenge here, Option 1 would definitely make for a better experience!

@skaldarnar Definitely still up to the challenge! I would be interested in implementing Option 2, but for now I can set up option 1 as a temporary fix

👍  let's start with Option 1 and make it not crash anymore. You could straight on continue with Option 2 as follow up (in which case I'd recommend a chat with @AndyTechGuy and do some conceptual work on how the system, events, and components should be structured before diving into coding) 😉


auto update top command line

This give the top function to mimic the top command by auto updating the
current running processes on the project.Most of the existing
functionalities have been moved to Toolshed.TopServer module.The
module(Toolshed.TopServer) has GenServer which ensure that the top
after every 1_000 milliseconds the processes are refreshed.Pressing
the enter exits the command

Thanks! I'll take a look this weekend.


Where did ViewLocationFormats go?

I'm not sure if this is ASP.NET, Razor, or Razor Tooling, but with RC1 and RC2 we were overriding ViewLocationFormats of the RazorViewEngine to serve views from custom locations. This appears to be gone now with RTM. How can I go about getting this behavior back? I check the Announcements section and didn't see any listing of a breaking change.

@BrianVallelunga could you move this issue over to aspnet/Mvc?


Shrotcut dont open

Powertoys are very strange with shortcuts helper, with my pc one time that functional one time that not functional so i tried to restart my pc but nothing happends that not functionnal. (Im french)

if that my config bad telle me !

is PowerToys running under admin?
What version of PowerToys
When you try to open shortcut guide (press and hold WinKey for the 200ms), is a window that could be run under admin or elevated (Task manager, Hyper-v instances)?


Mouse cursor position in Pharaoh and Zeus

Yesterday I reported in an issue for cnc-ddraw that I also tried DxWrapper with Pharaoh and Wine and it fixed the problem with the position of the mouse cursor being incorrect. After some further playtesting, I realised that while the game is certainly playable this way, the mouse cursor is still somewhat off.
When I launch the game, as I hover the mouse over and off the main menu items, it can be seen right away that it’s as if the whole screen content has been shifted slightly downward and even more to the right.
I can reproduce this with DxWrapper v1.0.6387.21, with multiple Lutris versions of Wine (namely the packages lutris-fshack-5.5-2 and lutris-fshack-5.6-5), both with and without a widescreen hack, and with DdrawUseNativeResolution set to either 0 or 1.
I’ve also installed Zeus to take a glimpe at how DxWrapper performs with it and I have the exact same results so far as with Pharaoh.

Ok, try this update.  I put a full fix in for this.  You no longer need to enable DdrawUseNativeResolution.  I basically simulate what DirectDraw does.  This should work with only Dd7to9 enabled.
dxwrapper.zip

With this update, the mouse cursor position is now correct in both games. Thank you very much!

Actually, now if I leave DdrawUseNativeResolution disabled, scrolling no longer works if the mouse cursor touches the right or lower edge of the screen. If I enable DdrawUseNativeResolution, scrolling works but the cursor position is wrong again.
Shall I create a separate issue for this?

Scrolling work for me.  I tried all three games with multiple resolutions.  Scrolling works with both the keyboard and the mouse.  Moving the mouse to any of the four sides of the screen scrolls the game in that direction.
I am testing on Windows 10 64bit with the GOG version of the games.  No patches, just native game play.
Here is the build I am using, should work the same as the one I gave you: dxwrapper.zip

It’s still the same here on Wine and Proton’s fullscreen hack, which upscales the internal resolution (e.g. 1280x720) to the screen resolution (1920x1080). If the internal resolution is also 1920x1080, mouse scroll works, but the visuals look too small for comfortable playing.
(As a sidenote, the author of cnc-ddraw pushed a commit and a test build today that fixed both the issue with the mouse position and scrolling, even with fshack. I don’t know how it works, but if you do, you might be able to use it as a reference.)

It’s still the same here on Wine and Proton’s fullscreen hack

This could be a bug with the Proton fullscreen hack.  I tried with WineD3D and scrolling seemed fine for me.  I did, however, create an update to see if it helps.
Here is the update: dxwrapper.zip
If that updated does not work you may also want to try setting the FullscreenWindowMode option to see if that helps.

As a sidenote, the author of cnc-ddraw pushed a commit and a test build today that fixed both the issue with the mouse position and scrolling

Yeah, I saw his update.  He adds a custom option into the config file for this and does some custom hacks (here and here) that may not work with other games.  I am trying to build a generic solution that works with all games.  It is a bit harder to implement, but makes it easier for the user and should be more compatible in the long run.

It's gonna be impossible to mimic the original DirectDraw in this case because we have custom features like windowed mode and windowed fullscreen (which both, the original DirectDraw isn't doing) so there will never be a WM_DISPLAYCHANGE message in our case and a hack is unavoidable. You could try to just change the resolution to something random and then change it to the final resolution to trigger the WM_DISPLAYCHANGE instead of using PostMessageA. But in the end it's also a hack :D
If you just want to have it working in fullscreen without any additional features then yeah, you can create a generic solution. (It will not work with fshack though)

@FunkyFr3sh, thanks for your comments.  I am trying to convert DirectDraw and Direct3D to Direct3D9, just like d3d8to9 does.  I am trying to do as straight of a conversion as possible, so you can see for example, as I am working on the 3D functions I call the Direct3D9 equivalent directly.

we have custom features like windowed mode and windowed fullscreen (which both, the original DirectDraw isn't doing)

Yeah, those are just there for convince.  They don't work on all games.
For the case of these games, when the game calls SetDislpayMode() and DirectDraw is in exclusive mode I will change the resolution to the requested resolution.  This seems to work for this game in all my tests.

If you just want to have it working in fullscreen without any additional features then yeah, you can create a generic solution. (It will not work with fshack though)

Why won't this work with the work with fshack?  What does the fshack do that breaks this?

Oh I see, didn't know you treat these additional features as optional bonus. I always try hard to make windowed mode and upscaling work with all games :)

Why won't this work with the work with fshack? What does the fshack do that breaks this?

With fshack you can't call ChangeDisplaySettings, it was made to prevent that to ensure the display resolution will always stay the same and instead it will just upscale the game to the native resolution. That means there will never be a WM_DISPLAYCHANGE message.

I always try hard to make windowed mode and upscaling work with all games :)

Yeah, you do a good job also!  That is what's so great about the Internet.  We can have different projects with different focuses. :-)

With fshack you can't call ChangeDisplaySettings, it was made to prevent that to ensure the display resolution will always stay the same and instead it will just upscale the game to the native resolution. That means there will never be a WM_DISPLAYCHANGE message.

I see.  Thanks for the information!

Ok, I found a fix for this.  I just added the following code to the SetDisplayMode() function if exclusive mode is set.
DWORD bpp = displayModeBPP;
DWORD res = (WORD)displayWidth | ((WORD)displayHeight << 16);
SendMessage(HWND_BROADCAST, WM_DISPLAYCHANGE, (WPARAM)bpp, (LPARAM)res);

Here is the new update:  dxwrapper.zip

With fshack you can't call ChangeDisplaySettings, it was made to prevent that to ensure the display resolution will always stay the same and instead it will just upscale the game to the native resolution

That sounds a hella lot like GPU scaling... Which does still allow all calls to succeed.
I'm really skeptical wine's bugs should be covered here.

I posted a comment about it here too: https://github.com/ValveSoftware/Proton/issues/2858#issuecomment-698888259
Maybe they're going to fix it. But we need the patch on windows too if we want upscaling support (It's not just a problem on wine)

Here is the new update: dxwrapper.zip

When I try it with the internal resolution being 1280x720, the game crashes at launch. If both the internal and screen resolution are 1920x1080, the game works fine.
Here’s the message that appears in the terminal output:
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  12 (X_ConfigureWindow)
  Value in failed request:  0x0
  Serial number of failed request:  145
  Current serial number in output stream:  149

In addition, here’s the generated log file that I found next to dxwrapper: dxwrapper-pharaoh.log

But we need the patch on windows too if we want upscaling support

Upscaling is a nice convenience feature, but you shouldn't start from the assumption a generic utility ought to support it.
Anyway.. the games are platinum since like a decade. What's the deal now? And why aren't you first testing vanilla stable wine?

@maxigaz, thanks for testing this for me.  I can only test it on Windows.  Can you try this one?
Here is the update:  dxwrapper.zip

@maxigaz, thanks for testing this for me. I can only test it on Windows. Can you try this one?
Here is the update: dxwrapper.zip

I’ve just playtested it for an hour in Pharaoh and for a few minutes in Zeus. Scrolling works now in both. Thank you very much! I truly appreciate your work.


Add psr workflow to application

@aarongreen85 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


MetalPetal like package dependency. 'MTIShaderLib.h' file not found

Hello, I add MetalPetal in my package like a dependency, in my package sources I implement custom filters, but when I trying to build it I got an error in .metal files on #include "MTIShaderLib.h". -  'MTIShaderLib.h' file not found. I tried to use different paths for MTIShaderLib.h, but nothing helped me, also I tried to add MTIShaderLib.h to Header Search Path(just drag and drop file to the header search path context window), any results. May be when you add package to another package you should implement additional settings? Thanks for your work.

Please read README: https://github.com/MetalPetal/MetalPetal#build-custom-filter

hi @YuAo Metal Search path Not show in my Project as like I example code .what I have to do

@akshpreet-singh It only shows up when there're .metal files in your project.


Clean raspbian-lite install. Failed to start ovos.service: Unit ovos.service not found.

This may well be an oversight on my part, but I think I followed the instructions.
Following documentation at https://github.com/OpenVoiceOS/ovos-technical-manual/blob/master/docs/raspbian_ovos.md using a 3B+
Downloaded and modified the latest raspbian-lite image (this step is where I believe the user error happened). Then
sudo apt install build-essential python3-dev python3-pip swig libssl-dev libfann-dev portaudio19-dev libpulse-dev cmake git libncurses-dev pulseaudio-utils
cd
git clone https://github.com/OpenVoiceOS/raspbian-ovos.git
cd raspbian-ovos
./manual_install.sh
There was a repeated warning message:
WARNING: The script * is installed in '/home/ovos/.local/bin' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no->
The script ended with ovos failing to start:
Failed to start ovos.service: Unit ovos.service not found.
"systemctl --user start ovos" also produces the ovos.service not found message
There are some errors in the output:

Installing systemd files
cp: cannot stat 'stage-ovos/00-build/files/usr/libexec/ovos*': No such file or directory
chmod: cannot access '/home/ovos/.local/bin/ovos-systemd*': No such file or directory
Defaulting to user installation because normal site-packages is not writeable
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Collecting sdnotify
Downloading https://www.piwheels.org/simple/sdnotify/sdnotify-0.3.2-py3-none-any.whl (3.5 kB)
Installing collected packages: sdnotify
Successfully installed sdnotify-0.3.2
cp: cannot stat 'stage-ovos/00-build/files/usr/lib/systemd/user/*': No such file or directory
Done installing systemd files
Installing extra skills

It dawned on me that I might not have answered the prompts correctly so I looked back in the scroll and I think this looks ok:

To be honest, that script  was a hack to test with. It will ONLY work on the dev branch,  and I'm not sure even then. There have been package changes since I wrote this. For instance,  it does not contain any reference to dinkun-listener. I think the script itself is handy to have, and an update should be done with new packages ans systemd files. PR's are more than welcome,  and should be as simple as changing/addind/removing a few lines.

LOL! Well, it looked pretty good to me. Given the docs, I had thought it was the script you use to create the build image. I was puzzled by the lack of dinkum-listener but figured it was just one of the many things I don't understand yet.  As for PR's, I'll work towards that but it may be have to wait until I can generate a useful suggestion. :)


ERROR:tensorflow:Model diverged with loss = NaN

Hi supporters,
I intent to train a face detection model using training_toolbox_tensorflow and WIDER face dataset which are converted to COCO format. The config.py is as same as vlp/config.py, and I changed annotation_path to WIDER face path.
But when run train.py, i am facing with a problem "ERROR:tensorflow:Model diverged with loss = NaN"
I searched in the stackoverflow, tensorflow and following their instructions but still failed.
Did you meet the same problem before ?
Do you know how to overcome this issue ?
Thank you in advance !
Regards,
Michael

I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
If you're describing a bug, tell us what should happen.
If you're suggesting a change/improvement, tell us how it should work.

Current Behavior
If describing a bug, tell us what happens instead of the expected behavior.
If suggesting a change/improvement, explain the current behavior.

Steps to Reproduce (for bugs)

Convert Wider face to COCO format (I use tools in this repo :https://github.com/the-house-of-black-and-white/morghulis)
add full image path for above COCO format
Change annotation_path in vlp/config.py to Wider face COCO format
start training "python3 tools/train.py vlp/config.py"

Context
How has this issue affected you? What are you trying to accomplish?
Providing context helps us come up with a solution that is most useful in the real world.

Your Environment

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow installed from (source or binary): Conda
TensorFlow version (use command below): 1.12.0

python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"

Python version: 3.6.8

CUDA/cuDNN version: 7.6.0 build cuda9.0_0

GPU model and memory: nvidia geforce gtx 1050 4G, NVIDIA-SMI 390.116
Include as many relevant details about the environment with which you experienced the bug.

Hi @michaelnguyen11
Unfortunaly, we did not try to train on WIDER faces.
Look at PyTorch object detection, it newer model that based on mmdetection toolkit and have better precision.

Hi @AlexanderDokuchaev ,
Thank you so much for your response.
I've trained the pytorch face detection above, but when load face_detector.onnx model to OpenCV with API : net = cv::dnn::readNetFromONNX("face_detector.onnx"), I got errors :
/media/opencv/modules/dnn/src/layers/prior_box_layer.cpp:241: error: (-215:Assertion failed) !params.has("step") in function 'PriorBoxLayerImpl'
On the other hand, when i try to convert onnx format to tensorflow format with repo : https://github.com/onnx/onnx-tensorflow, I got another problems:
onnx.onnx_cpp2py_export.checker.ValidationError: No Op registered for PriorBoxClustered with domain_version of 9
==> Context: Bad node spec: input: "477" input: "input.1" output: "486" op_type: "PriorBoxClustered" attribute { name: "clip" i: 0 type: INT } attribute { name: "flip" i: 0 type: INT } attribute { name: "height" floats: 15 floats: 39.6 floats: 25.5 floats: 63.2 floats: 227.5 floats: 162.9 floats: 124.5 floats: 105.1 floats: 72.6 type: FLOATS } attribute { name: "img_h" i: 0 type: INT } attribute { name: "img_size" i: 0 type: INT } attribute { name: "img_w" i: 0 type: INT } attribute { name: "offset" f: 0.5 type: FLOAT } attribute { name: "step" f: 16 type: FLOAT } attribute { name: "step_h" f: 0 type: FLOAT } attribute { name: "step_w" f: 0 type: FLOAT } attribute { name: "variance" floats: 0.1 floats: 0.1 floats: 0.2 floats: 0.2 type: FLOATS } attribute { name: "width" floats: 9.4 floats: 25.1 floats: 14.7 floats: 34.7 floats: 143 floats: 77.4 floats: 128.8 floats: 51.1 floats: 75.6 type: FLOATS }

Do you think this is a bug of "tools/ssd_export_helpers.py" or did I miss something while training as face detection instruction
Thank you in advance !
Regards,
Michael

@michaelnguyen11  It is expected, onnx does not support PriorBoxClustered.
We used onnx as intermediate stage to convert to OpenVINO format..
You can build OpenCV with IE backend or look on dldt sample to run model in OpenVino format (.xml and .bin)

Thank a lot for the information and your support.


react/jsx-curly-newline rule in conflict with eslint-config-airbnb

eslint-config-airbnb enabled the rule react/jsx-curly-newline in version 18.
https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb/rules/react.js#L477-L480
This is in conflict with the current config for eslint-config-prettier. Would it be ok to open a PR enabling it here too?

Hi! That rule seems to be already turned off:
https://github.com/prettier/eslint-config-prettier/blob/dcca556e260af985ece4d9af92531fa649268f80/react.js#L11
Maybe you forgot to add "prettier/react" to the "extends" array in your ESLint config? Also make sure that the Prettier configs come last so it gets a chance to override.

@lydell the request is to turn it on/enable it, so that it replicates what eslint-config-airbnb (a de facto standard) does.
This would of course mean removing it from prettier/eslint-config-prettier too, but I started the conversation here.

react/jsx-curly-newline conflicts with Prettier ("consistent" seems to only be unnecessary when using Prettier after a quick glance at it) so it has to be turned off if you want to use Prettier.
Am I missing something? What would you gain by enabling this rule when using Prettier?

For people using prettier together with eslint-config-airbnb, this rule creates a conflict, one has it to off and the other to error. This is proposing to use the same rule changing Prettier's config. Does that make more sense?

No, I’m sorry, that makes no sense at all.
There is nothing special about the react/jsx-curly-newline rule. Here is the full list of rules in eslint-config-airbnb that are unnecessary of conflict with Prettier:
❯ npx eslint --print-config index.js | npx eslint-config-prettier-check
The following rules are unnecessary or might conflict with Prettier:

- array-bracket-spacing
- arrow-parens
- arrow-spacing
- block-spacing
- brace-style
- comma-dangle
- comma-spacing
- comma-style
- computed-property-spacing
- dot-location
- eol-last
- func-call-spacing
- function-paren-newline
- generator-star-spacing
- implicit-arrow-linebreak
- indent
- jsx-quotes
- key-spacing
- keyword-spacing
- linebreak-style
- new-parens
- newline-per-chained-call
- no-extra-semi
- no-floating-decimal
- no-mixed-spaces-and-tabs
- no-multi-spaces
- no-multiple-empty-lines
- no-spaced-func
- no-trailing-spaces
- no-whitespace-before-property
- nonblock-statement-body-position
- object-curly-newline
- object-curly-spacing
- object-property-newline
- one-var-declaration-per-line
- operator-linebreak
- padded-blocks
- quote-props
- react/jsx-closing-bracket-location
- react/jsx-closing-tag-location
- react/jsx-curly-newline
- react/jsx-curly-spacing
- react/jsx-equals-spacing
- react/jsx-first-prop-new-line
- react/jsx-indent
- react/jsx-indent-props
- react/jsx-max-props-per-line
- react/jsx-one-expression-per-line
- react/jsx-props-no-multi-spaces
- react/jsx-tag-spacing
- react/jsx-wrap-multilines
- rest-spread-spacing
- semi
- semi-spacing
- semi-style
- space-before-blocks
- space-before-function-paren
- space-in-parens
- space-infix-ops
- space-unary-ops
- switch-colon-spacing
- template-curly-spacing
- template-tag-spacing
- unicode-bom
- wrap-iife
- yield-star-spacing

The following rules are enabled with options that might conflict with Prettier. See:
https://github.com/prettier/eslint-config-prettier#special-rules

- curly
- no-confusing-arrow

The following rules are enabled but cannot be automatically checked. See:
https://github.com/prettier/eslint-config-prettier#special-rules

- arrow-body-style
- max-len
- no-mixed-operators
- no-tabs
- no-unexpected-multiline
- prefer-arrow-callback
- quotes

eslint-config-prettier has one job: Turning off all of those.
eslint-config-airbnb is not compatible with Prettier. That’s just how it is. That’s why eslint-config-prettier exists. It turns off all conflicting (or unnecessary) rules, so that you can use both without trouble.
If you prefer airbnb’s choices, you might want to look into prettier-eslint.

Thanks for the thorough response and suggestions.


Is there a way to determine how far along the search indexing has progressed?

GH built in search is really buggy lately and burned me twice in the last week, so I'm giving hound a try. I added all my org's repos to the config, set the max indexers to 20, and its going through the repos but I dont know how  far along it is or how long it has left to complete.
I thought that I could count the number of data folders but that more than the number of repos currently (~1300 repos, > 1400 folders). I did have to stop and restart houndd because running 20 indexers was making other programs slow.
Is there a way to tell roughly when I can start using the indexed results?

Hey! I don't know off-hand of a way to monitor indexer progress, but the logs should show you how many searchers have been started, which gives you a rough idea of how far along in the indexing process Hound is. Does that help at all?

Counting the number of "Searcher started" is not really feasible when they are scrolling by.  I cant count that fast. =D

I found that counting the two subfolder types (vcs, idx) in the data directory was close enough for the initial seeding where its downloading and indexing repos. The closer they get to the count of the repos in the config file, the closer it is to being ready.  (If you are curious, it took about 2-3 hours total for a pared down repo list of only about 800 and with 20 searchers/indexers. About 70 or so repos failed due to "filename too long" or similar issues.)
It may be useful to post a stat line to the console/log every 30 seconds with the count of done, in progress, and awaiting repos. Thats up to you, I dont know Go or this program's design well enough to PR it and I think I can get the info I need without it.

Totally — that makes sense. I'm gonna leave this issue open and flag it as a "help wanted" for the time being. I'm glad to hear this is (mostly) working as expected on your windows machine! I'm unclear about what the bottleneck is for that startup time (i.e. if it's network time, or if the indexers take a while due to the size of your repo, etc), but if you have any intuitions there, I'd love to hear them. If you're really struggling for a loading indicator in the interim, it could be worth teeing these logs through a script that counts "Searcher started for" log lines for you.

The 799 of our repos I'm targeting average about 462 files per repo. That doesnt seem  out of the "medium" size range, so i suspect its just the number of repos that it has to index and possibly network speed (speed test reports ~80 Mbps down).
Is there a specific log message to look for when the Web UI is ready?

Yes! I believe either All indexes built! should do the trick there.


Route to the main workspace screen now that it is in rightpane

Fixed Issues
$ https://github.com/Expensify/Expensify/issues/180748
Tests/ QA Steps

Log into oldDot
Go to Settings->Policies->New Policy and Select Free
You should be redirected to NewDot. Make sure the main workspace screen opens in rightpane (not the card one):

Tested On

[X] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

🚀 Deployed to staging by @nkuoch in version: 1.1.7-25 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


opt  Avoid copying while holding a lock.


Mount shared drive for map studio

Create a share on diglib(?) for the map and gis lab.

Coordinate setting up the share with @gpmenos


Update php.yml

Fix escaping on namespaces

thx !

you're welcome ! ;)

Will http://www.certificationy.com be updated to reflect the changes ?

This website is not related to this organisation, but I guess @ProPheT777 use our data.


Add security section

This is WIP for adding security settings as discussed in the meeting.
The settings are based on security profiles in nsinit and Seccomp configuration in https://github.com/opencontainers/runc/pull/70

On Thu, Jul 30, 2015 at 01:46:35PM -0700, Mrunal Patel wrote:

The settings are based on security profiles in nsinit and Seccomp
configuration in #70

I think you meant opencontainers/runc#70.
I realize this spec isn't going to be a tutorial on container
security, but linking to something more specific than each tool's main
page would be nice (although I also like having main-page links).  In
particular, notes about what sort of strings are valid would be
welcome (like the current the CAP_ note for Linux capabilities).  So
there's no need to explain the security model, but we do need to
explain the mapping from the security model to the configuration JSON.
For example, the ‘3’ value for the
security.seccomp.syscalls[name=getcwd].action, seems like it's the
decimal version of the SECCOMP_RET_ACTION portion of SECCOMP_RET_TRAP.
It would be nice to allow string forms there ("action": "trap"?),
but if we're going to have folks matching kernel #defines, we should
explain the mapping.

@wking Yeah, I will flesh out the Seccomp section some more.

I like adding the apparmor, selinux, seccomp and capabilities stuff but I don't see any reason to group them in a security section. rlimits may be thought of as a security mechanism to avoid denial-of-service to the rest of the system, for example.

Got rid of the separate Security struct.

Overall this change makes sense to me.

@lizf-os Updated to mention that we use the header from libseccomp.

@mrunalp IIRC we also have MountLabel for SELinux, should it be part of specs.Mount?

@LK4D4 Yes, I think we should probably add that as well. I think I will do a follow-on PR for that.

overall looks fine. rebase needed though.

Rebased.

LGTM

LGTM


Can not inline multiple css

When there are multiple css in the page that need to be inlined，a part of css will not be inlined。
I readed the source code in v4.ts, maybe the problem is here:
private prepareCSSStyle(data: BeforeAssetTagGenerationData) {
    data.assets.css.forEach((cssLink, index) => {
      if (this.isCurrentFileNeedsToBeInlined(cssLink)) {
        const style = this.getCSSStyle({
          cssLink,
          publicPath: data.assets.publicPath,
        })

        if (style) {
          if (this.cssStyleMap.has(data.plugin)) {
            this.cssStyleMap.get(data.plugin)!.push(style)
          } else {
            this.cssStyleMap.set(data.plugin, [style])
          }
          // prevent generate <link /> tag
          data.assets.css.splice(index, 1)
        }
      }
    })
  }

for example:

the element in the middle is deleted, it results in a part of css cannot be inlined.

I want to be sure that  if there is a historical reason for this code, can I pull a request to resolve this problem?

@mixueXiang  I think it is a bug.

Hi @mixueXiang , Sorry for the late reply. This does seem to be a problem and I'm looking forward to your pull request! 😃

@Runjuu , Thanks for your reply, I pulled a request, can you help me to review changes?

Hi @mixueXiang , I've released a new version for it.

@Runjuu Thanks, new version works well.


Single definition of batch size in indexing vs transformers

Batch size in indexing should either be on the pipeline only and inherited by the transformer, or set on the transformer only and used by the pipeline.
EmbeddingModels currently have a double batch size, it's confusing and not needed. I think the latter with a sane default could have the cleanest api.

Can you please clarify a bit more where to look for the code so I can help fix the issue

@mdabir1203 Thanks for the interest and wanting to pick this up! 🚀
Currently there are two batch sizes defined, one in the indexing pipeline itself. The indexing pipeline needs to know how many chunks it should batch up, and will send those as a list to the batch transformer. However, some batch transformers also have a batch size (regardless of the pipeline's). FastEmbed for instance takes a batch size for embeddings for internally in its models as well.
This leads to the following weird api:
let batch_size = 100;

       Pipeline::from_loader(loaders::FileLoader::new(tempdir.path()).with_extensions(&["rs"]))
            .then_in_batch(batch_size, transformers::Embed::new(FastEmbed::builder().batch_size(batch_size).build().unwrap()))

It's double and it needs to be aligned. Specifically for FastEmbed, the default is None, so then the library will use it's own default batch size.
Ideally I'd have the batch size specified once for transformers, and only on the transformer, with sensible defaults (256 is great). This would need to be set in pipeline defaults. Transformers with children that determine the batch size would need to propagate it.
See the Persist trait for how I think it should work.
Then in batch would be like this instead:
.then_in_batch(transformers::Embed::new(FastEmbed::builder().batch_size(batch_size).build().unwrap()

For example, a possible implementation could look like this:

Remove batch size as argument from then_in_batch
Add a batch_size -> Option to the BatchTransformerTrait
I think Embed and SparseEmbed might need a batch size then given the generics, maybe there's a nice way to avoid it.
Ensure any integrations with batch sizes have sensible defaults if needed, otherwise they could use the default from the pipeline, afaik mostly fastembed.
Add a default_batch_size to PipelineDefaults
In then_in_batch, it should try to get the batch size from the transformer or fall back to the pipeline default.

Can you show which file and which line of the code is this. I have a probable implementation in my mind like this. But I need to see a bit more :
// Define a struct for pipeline defaults
struct PipelineDefaults {
    default_batch_size: usize,
}

// Define the BatchTransformerTrait
trait BatchTransformerTrait {
    fn batch_size(&self) -> Option<usize>;
}

// Example implementation for Embed
struct Embed {
    batch_size: Option<usize>,
}

impl BatchTransformerTrait for Embed {
    fn batch_size(&self) -> Option<usize> {
        self.batch_size
    }
}

// Modify the Pipeline struct
struct Pipeline {
    defaults: PipelineDefaults,
}

impl Pipeline {
    fn then_in_batch(self, transformer: impl BatchTransformerTrait) {
        let batch_size = transformer.batch_size().unwrap_or(self.defaults.default_batch_size);
        // Proceed with processing using the determined batch_size
    }
}

// Usage
fn main() {
    let defaults = PipelineDefaults { default_batch_size: 100 };
    let pipeline = Pipeline { defaults };

    let embed_transformer = Embed { batch_size: None }; // No specific batch size set

    pipeline.then_in_batch(embed_transformer); // Uses default batch size of 100
}

@mdabir1203 Almost everything is in swiftide-indexing, traits and core share types are in swiftide-core.

// Usage
fn main() {
    let defaults = PipelineDefaults { default_batch_size: 100 };
    let pipeline = Pipeline { defaults };

    let embed_transformer = Embed { batch_size: None }; // No specific batch size set

    pipeline.then_in_batch(embed_transformer); // Uses default batch size of 100
}

What's this? Have you looked at our examples or tried to run a pipeline? For searching code ripgrep and rust-analyzer are your friends. Best of luck!


Feature/149 search api

Fixes #149

Current coverage is 0.00% (diff: 100%)

Merging #154 into develop will not change coverage

@@           develop   #154   diff @@
=====================================
  Files            1      1
  Lines           36     36
  Methods          0      0
  Messages         0      0
  Branches         0      0
=====================================
  Hits             0      0
  Misses          36     36
  Partials         0      0

Powered by Codecov. Last update f296e97...bb6cd4c


Need's Documentation on how to use

Awesome work here! Let's make this easy to use with a readme!

will add when get free time.

README is here now


Add a new synonym for the legacy transaction pool

Description
As an enterprise user planning to set up a permissioned chain, I want to be able to choose a TX pool that's more suitable to my requirements, and isn't called legacy which implies it might be deprecated.
Acceptance Criteria
A new transaction pool name for what is currently called the legacy pool is decided, and either legacy or the new name can be set as a value for the --tx-pool configuration parameter.
For maintainers and community members to vote on the most suitable term for the pool, I've added a comment for each option that was discussed in the 11/28/2023 EMEA/AMER contributor call, with a short explanation. People can vote with a thumbs-up on the one they are most happy with and after a week or two I'll raise a PR with the new name.

Suggestion 1: sequenced
Reasoning: The layered pool primarily describes its implementation, as opposed to any particular use-case, so sequenced would be following that precedent. Since the legacy pool has had changes recently to make it more FIFO-like in its behaviour (see for example https://github.com/hyperledger/besu/pull/6106 / https://github.com/hyperledger/besu/pull/6022) and thus a little "fairer" from the point of view of individual senders, sequenced describes a little about its implementation and about how TX selection is done.

Suggestion 2: flat
Reasoning: Similar to comment 1, flat describes a little about its implementation without being specific about any particular use-case.

Anti-Suggestion: enterprise
Reasoning for avoiding: It implies that the layered pool isn't suitable for enterprise use-cases, which is not the case.

Anti-Suggestion 2: trusted
Reason for avoiding: It implies too much about permissioning-like features.

sequenced (or FIFO) works well in the case it is used in a gas free network, less if there is a gas market, in which case the main order is dictated by the gas price.
Another use case for this pool, is to be suitable for more throughput, at the cost of lowering some anti-DoS protection (this required some more development), since it is to be used on trusted network
It is not simple to find a name that summarize all these feature, and since I see that the development of this pool should target the use cases of gas free (fairness) and private network (throughput w/o spam protection) I am proposing also a new approach to naming, a kind of acronym that could be expanded to cover the different features.


Unable to set dataset creations exporting a data frame to GeoPackage

Expansion of comment in https://github.com/geopandas/pyogrio/issues/71#issuecomment-1313891950.
I am trying to export a dataframe to a GeoPackage but with two dataset creation options set, specifically VERSION and ADD_GPKG_OGR_CONTENTS documented in https://gdal.org/drivers/vector/gpkg.html#dataset-creation-options.
The code I'm using:
from pathlib import Path

from pyogrio import read_dataframe, write_dataframe

geojson_path = Path('input.geojson')
output_path = Path('output.gpkg')

write_dataframe(read_dataframe(geojson_path), path=str(output_path), VERSION=1.3, ADD_GPKG_OGR_CONTENTS='NO')

Running this code gives the following:
Warning 6: dataset output.gpkg does not support layer creation option VERSION
Warning 6: dataset output.gpkg does not support layer creation option ADD_GPKG_OGR_CONTENTS

From this I assume all **kwargs are being set as layer creation options rather than dataset creation options but I'm unsure how to set these (without using another tool).
Python version: 3.9.1
pyogrio version: 0.4.2
$ gdalinfo --version                                                                                15:17:34
GDAL 3.5.2, released 2022/09/02

Happy to provide any other information and apologies if I've missed anything useful to debug this.

To sanity check the ADD_GPKG_OGR_CONTENTS option isn't being applied I checked whether the generated GPKG had a gpkg_ogr_info table (I expected it not to):
$ sqlite3 output.gpkg
SQLite version 3.39.4 2022-09-29 15:55:41
Enter ".help" for usage hints.
sqlite> .tables
gpkg_ogr_contents
gpkg_contents
gpkg_spatial_ref_sys
gpkg_extensions
gpkg_tile_matrix
gpkg_geometry_columns
gpkg_tile_matrix_set
input

Yes, so currently we pass options (**kwargs) only to the layer creation step (GDALDatasetCreateLayer):
https://github.com/geopandas/pyogrio/blob/bdd7bf4fd9fda544c8b781596eea84cee4248ddd/pyogrio/_io.pyx#L1275-L1287
And so passing dataset creation options is right now not possible (and I am not aware of any workaround ..).
But this is something we should certainly solve.
One option is to have an explicit dataset_options vs layer_options keywords that take a dict (as mentioned in https://github.com/geopandas/pyogrio/issues/71#issuecomment-1105487378), or at least have this for the dataset options, and leave generic kwargs for the layer creation options.
Another option could be to split the user-passed kwargs automatically into dataset and layer creation options, using the driver metadata (cfr https://github.com/geopandas/pyogrio/issues/103).

Another option could be to split the user-passed kwargs automatically into dataset and layer creation options

Are they always exclusive to dataset or layer?

Another option could be to split the user-passed kwargs automatically into dataset and layer creation options

Are they always exclusive to dataset or layer?

Using the code in https://github.com/geopandas/pyogrio/pull/189, checking this:
In [17]: for driver in pyogrio.list_drivers().keys():
    ...:     dataset_options = pyogrio.raw._parse_options_names(pyogrio.raw._get_driver_metadata_item(driver, "DMD_CREATIONOPTIONLIST"))
    ...:     layer_options = pyogrio.raw._parse_options_names(pyogrio.raw._get_driver_metadata_item(driver, "DS_LAYER_CREATIONOPTIONLIST"))
    ...:     common_options = set(dataset_options).intersection(set(layer_options))
    ...:     print(f"{driver}: {list(common_options) if common_options else '-'}")
    ...:
    ...:
ESRIC: -
FITS: -
PCIDSK: -
netCDF: -
PDS4: -
VICAR: -
JP2OpenJPEG: -
PDF: -
MBTiles: ['MINZOOM', 'DESCRIPTION', 'NAME', 'MAXZOOM']
BAG: -
EEDA: -
OGCAPI: -
ESRI Shapefile: -
MapInfo File: ['ENCODING']
UK .NTF: -
LVBAG: -
OGR_SDTS: -
S57: -
DGN: -
OGR_VRT: -
REC: -
Memory: -
CSV: ['GEOMETRY']
NAS: -
GML: -
GPX: -
LIBKML: ['LISTSTYLE_ICON_HREF', 'VISIBILITY', 'OPEN', 'SNIPPET', 'DESCRIPTION', 'LISTSTYLE_TYPE', 'NAME']
KML: -
GeoJSON: -
GeoJSONSeq: -
ESRIJSON: -
TopoJSON: -
Interlis 1: -
Interlis 2: -
OGR_GMT: -
GPKG: -
SQLite: -
OGR_DODS: -
WAsP: -
PostgreSQL: -
OpenFileGDB: -
DXF: -
CAD: -
FlatGeobuf: -
Geoconcept: -
GeoRSS: -
GPSTrackMaker: -
VFK: -
PGDUMP: -
OSM: -
GPSBabel: -
OGR_PDS: -
WFS: -
OAPIF: -
EDIGEO: -
SVG: -
CouchDB: -
Cloudant: -
Idrisi: -
ARCGEN: -
XLS: -
ODS: -
XLSX: -
Elasticsearch: -
Carto: -
AmigoCloud: -
SXF: -
Selafin: ['DATE']
JML: -
PLSCENES: -
CSW: -
VDV: -
GMLAS: -
MVT: ['MINZOOM', 'DESCRIPTION', 'NAME', 'MAXZOOM']
NGW: ['KEY', 'DESCRIPTION']
MapML: -
TIGER: -
AVCBin: -
AVCE00: -
HTTP: -

So there are some drivers where an option name can be passed both to dataset creation and layer creation .. (although for the most common ones it is not the case, so automatically splitting might still be convenient for those).
(I didn't check the specific cases, for some it might also give no difference in practice if it is passed as dataset or layer option)
We could also have both: explicit dataset_options and layer_options keyword where you need to pass a dict, but still allow **kwargs as well that is passed automatically to either of those. Then we give the convenience for most cases, but give the explicit option when needed.

We could also have both: explicit dataset_options and layer_options keyword where you need to pass a dict, but still allow **kwargs as well that is passed automatically to either of those. Then we give the convenience for most cases, but give the explicit option when needed.

That is not a bad solution. +1

OK, I updated https://github.com/geopandas/pyogrio/pull/189 to take that route


Multiple subgraph support

[ ] Have an index page listing subgraphs https://github.com/graphprotocol/graph-node/issues/303
[x] Support hosting multiple subgraphs https://github.com/graphprotocol/graph-node/issues/226
[ ] Add remove, update, list admin API commands https://github.com/graphprotocol/graph-node/issues/282 - just missing list
[x] Authorization for subgraph deployment https://github.com/graphprotocol/graph-node/issues/304
[ ] Add a deploy command to the CLI graphprotocol/graph-cli#94 - missing remove
[x] Watch mode for deploy command https://github.com/graphprotocol/graph-cli/issues/95

@leodasvacas Now that we have an admin token, we could allow subgraph_list only when that token is provided.

@Jannis agreed

We've decided not to do the index page.

Done


add run route unit tests

Title
Add unit tests
Description
Add unit tests to test success and failure in the run route
How to test
run pytest within the project.
Screenshots

Hey @zmc @amathuria @kamoltat
Kindly find my changes for your review.

Sure on it :)


Address bug in add_variables_to_expression

thanks for this fix @nbfritz .  you're right - my refactor was overenthusiastic - i had forgotten what this utility was even being used for, and my changes to it made no sense, but because we didn't have any unit tests within this repo for it, nothing popped up.
i'm publishing this now. We should at some point be able to put a Jenkinsfile around this and typecats as well.

incidentally, even AWS is not strict about their own requirements - double-underscore will work just fine despite technically violating the alphanumeric rule.
For what it's worth, I wouldn't have written the additional validation - trying to mimic someone else's validation is usually a recipe for false confidence. I think the simpler fix (not renaming the input variables) would have been a little cleaner, and since, as you say, it's the caller that's responsible for assembling the rest of the query and then running it, there's not much utility in raising our own exception when AWS was going to raise their more 'accurate' one. Still, this shouldn't be a major issue so we can leave it as is.

I implemented the validation mostly because I didn't have the full context
behind the original change, so it was my way of ensuring that the new code
would fiction as closely to what I could interpret as the original intent
as possible. (That's also why I wrote it to use the same transformation
function rather than some other approach to check the contents...) If it's
not necessary, it can certainly be pulled back out!
On Wed, Aug 19, 2020, 6:11 PM Peter Gaultney<EMAIL_ADDRESS>wrote:

incidentally, even AWS is not strict about their own requirements -
double-underscore will work just fine despite technically violating the
alphanumeric rule.
For what it's worth, I wouldn't have written the additional validation -
trying to mimic someone else's validation is usually a recipe for false
confidence. I think the simpler fix (not renaming the input variables)
would have been a little cleaner, and since, as you say, it's the caller
that's responsible for assembling the rest of the query and then running
it, there's not much utility in raising our own exception when AWS was
going to raise their more 'accurate' one. Still, this shouldn't be a major
issue so we can leave it as is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xoeye/xoto3/pull/2#issuecomment-676802557, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACM6SOALZB3ETJ6TDHQZ3SBRL2DANCNFSM4QBYX5KQ
.

I wonder if AWS is actually using "word" characters, in RegEx parlance --
[A-Za-z0-9_]
On Wed, Aug 19, 2020, 6:28 PM Nathan Fritz<EMAIL_ADDRESS>wrote:

I implemented the validation mostly because I didn't have the full context
behind the original change, so it was my way of ensuring that the new code
would fiction as closely to what I could interpret as the original intent
as possible. (That's also why I wrote it to use the same transformation
function rather than some other approach to check the contents...) If it's
not necessary, it can certainly be pulled back out!
On Wed, Aug 19, 2020, 6:11 PM Peter Gaultney<EMAIL_ADDRESS>wrote:

incidentally, even AWS is not strict about their own requirements -
double-underscore will work just fine despite technically violating the
alphanumeric rule.
For what it's worth, I wouldn't have written the additional validation -
trying to mimic someone else's validation is usually a recipe for false
confidence. I think the simpler fix (not renaming the input variables)
would have been a little cleaner, and since, as you say, it's the caller
that's responsible for assembling the rest of the query and then running
it, there's not much utility in raising our own exception when AWS was
going to raise their more 'accurate' one. Still, this shouldn't be a major
issue so we can leave it as is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xoeye/xoto3/pull/2#issuecomment-676802557, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACM6SOALZB3ETJ6TDHQZ3SBRL2DANCNFSM4QBYX5KQ
.


Revocation lists are not filtered for non-EU countries

Test case reference
https://jira.apps.dev.otc.coronawarn.app/browse/TXR-5580
⚠ When this bug was logged, the decision whether the corresponding feature should be enabled was still open. Bug was opened against the interpretation that the filter should be enabled.
Expected behavior
When a non-EU country downloads the revocation lists, it should see a filtered list containing only entries from other non-EU countries. EU batches shall not appear in the list.
Actual behavior
Every country with the READ role on revocation can download all revocation batches

Current mode of operation is to either have full access or no access for a country. No filtering.


Change fly command

Change the fly and flynoclip commands to fly and flyclip.

I suggest to just removed the flynoclip

Closed due to conflicts

Closed due to conflicts


isomorphic-style-loader example

Would you welcome an isomorphic-style-loader example–the loader used in react-starter-kit–or is there a reason it hasn't been done yet? I think it would be matter of adding a css loader to next.config.js and either setting/concating the styles property for the head tag in _document.js or creating a separate style tag in _document.js for non-styled-jsx styles.
I don't want to attempt it if it's already been tried and discarded.

I started working on this, but it's more complicated than I thought. next is doing some pretty special things in webpack. For instance, CSS loaders seem to be completely ignored when writing output to the .next directory. Any guidance would be appreciated.

Ok, finally read this. Hmmm.

Looking foward to that so much! Hope you can make it!
I tried that, but didn't wok out. We need this very much.

I'm going to work on this more when I have time. I will need to spend more time understanding the next code.

@timmywil I'm interested in seeing this as well. One major piece of plumbing is the context.insertCss which has to be passed as a prop to the App container at some point. I've been going through next/server/render and next/lib/app to see if there are any good starting points to making this modular/userland without modifying next itself, but it isn't looking promising

@timmywil as for the css loaders writing out to .next/dist, I've come up with this so far, but then it fails since it has a relative path in the output file that can't be resolved properly. That's one of the last pieces I think that I need to get it to work. Here's what I have in next.config.js
module.exports = {
  webpack: (config, { dev }) => {
    const isDebug = !!dev;

    config.module.rules.push({
      test: /\.scss$/,
      use: [
        'isomorphic-style-loader',
        'raw-loader',
        {
          loader: 'emit-file-loader',
          options: {
            name: 'dist/[path][name].[ext]'
          }
        },
        {
          loader: 'css-loader',
          options: {
            // CSS Loader https://github.com/webpack/css-loader
            importLoaders: 1,
            sourceMap: isDebug,
            // CSS Modules https://github.com/css-modules/css-modules
            modules: true,
            localIdentName: isDebug ? '[name]-[local]-[hash:base64:5]' : '[hash:base64:5]',
            // CSS Nano http://cssnano.co/options/
            minimize: !isDebug,
            discardComments: { removeAll: true },
          },
        },
        'postcss-loader',
      ]
    })

    return config
  }
}

@winglian Thanks! I think adding emit-file-loader is a step in the right direction. I'll look further asap.

@timmywil @winglian yeah, i also want this! can i help with something? have you checked @timmywil?

@sergiokopplin I should have some time today. I'll reply here again with any discoveries, or I'll just open a PR if I get it working.

thanks man! let's get this to work!

btw, are you trying to use in a simple css-modules way?
component that imports a style and apply on nodes?
example:

@sergiokopplin exactly

I'm not going with next because of this. :/
Still need to do some tests, but this is a big no for my team.

I started this and opened a PR for collaboration.
https://github.com/zeit/next.js/issues/1664
I can get either server rendering or client rendering to work correctly, but not both at the same time and I'm not sure why yet.

Watching this with interest. I love next but I think we are going to pass until we can use the most common css solutions...

The CSS standard is what

I'm thinking you could use babel to transform SCSS files to a string, then dump that string to styled-jsx, provide a pre-process function, and let styled-jsx handle the scoping, autoprefixing, minifying, ensuring only one block of CSS is used for each component, etc
Fingers crossed! This would be a pretty awesome CSS setup!

Entire our team struggling with not supported scss modules by next.js. We have completely complex scss structure and we basically can't refuse it in favor of styled-jsx. The funny thing is that unsupported scss modules is the only but the crucial thing which stops of from migrating to next.js.
@timmywil Watching your great work with a deep hope.

@dvakatsiienko same here!

Personally, I'd love to be able to create a custom build of a CSS framework like Bootstrap 4 or Foundation and then import global and local scoped SCSS files.
So rather than importing the entire CSS framework, import the CSS framework's core .scss files as global CSS and then import the individual SCSS components as local scoped CSS.

Found this https://github.com/davibe/next.js-example-with-global-stylesheet/issues/8
the discussion just yet, guys created some setup that makes me believe that it is possible to make next.js to work with scss

Some slight changes I propose to example that would make it much easier: https://github.com/zeit/next.js/issues/2382

@winglian same issue, i have tried resolve wrong paths with babel-plugin-module-resolver but with no positive results. I think and hope there is not so much effort to handle this issue. Yet still just with raw-loader and postcss-loader. Using babel-loader for CSS doesn't work well with some postcss plugins.

@dvakatsiienko Would https://github.com/moxystudio/next.js-style-loader be of any help? It's been recently deprecated as the original creators moved away from next.js, but it works for us (we use it with CSS modules, not SCSS, though).

@agurtovoy did't tried that yet, and I'll do. Thank you very much for a suggestion!

For what it's worth, I spent 2 days trying to get .scss files to work as imports/css-modules with no luck after going through all the various examples, gists and SO posts. Given the importance of this feature we had to drop Next for ReactQL which supports this "out of the box" and has worked out very well for us. I have no affiliation with ReactQL but I would recommend others with this issue have a look.

@NotJustClarkKent are you talking about isomorphic-style-loader specifically, or .scss files in general?
FWIW using the latest Next 4, along with styled-jsx-plugin-sass I have bootstrap's SCSS along with all of our own functioning just fine. It only took maybe ~1 hour to get everything working the way I wanted to.
Given the way Next works, isomorphic-style-loader itself is not particularly necessary.

@codinronan specifically .scss files next to components UserBar.js, UserBar.scss (not the isomorphic-style-loader specifically although this was one of the methods I tried). The goal was to import the .scss styles and have them load as CSS Modules scoped to the component that imported it. I could not get this working over the 2 days of work I put in.
I was sort of able to get global scss files working using the externally global scope example and this thread but found that sometimes it would generate the .css to the static folder and sometimes it wouldn't. Often I would just get a comment /* imported from ... */ and nothing else. Other times I'd see the generated CSS for either the route requested only but the imported style class was never added/applied to the element (
Foo
 would just render as
Foo
 even when the CSS did generate and I didn't have any build errors.


Add double click functionality on a todo to edit

WIP: Needs some styling polish on the todo edit input. I'm new to Rust, so it likely needs some work to make idiomatic. Feedback welcome.
Fixes #30 , adds double-click to edit a todo.

Nice job @machineloop I think you could likely just inherit the styles from here https://github.com/tastejs/todomvc-common/blob/master/base.css instead of the elm-todomvc one that is currently copied into the examples.

@machineloop This is perfect! Thank you again! 👍


Fixing a small issue in trainer logging

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs? No changes required
[x] Did you write any new necessary tests? I don't think this requires any new tests, does it?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG? Should this be on the changelog?

What does this PR do?
Fixes half of #1520. This is the simpler half, where the epoch is logged into a dict that isn't passed to the loggers.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
As much as can be in a one-line fix.

Unsurprisingly, this broke the logging tests, probably since the epoch field now appears in the dictionary that arrives in the logger. Can I get approval to change the tests to account for this new field?

I added the change to the tests. Let's see that everything passes now.
Two questions:

Do you merge directly to master? Or is there a develop or some other branch that this should be merged into?
Is this (the epoch field arriving properly to the loggers) a change that should be documented anywhere?

yes
i don't think so right now? maybe if people bring it up but it seems like intuitive default behavior.

Okay cool. The only test that's failing is the PyTorch-v1_5 one that timed out. Does that make sense? As far as I'm concerned it's ready to merge, but if there's a way to return this test, that might be even better.

@guydav rebased


Support using tags in annotation formats

So, we supported working with tags on the server.
We are going to support annotation with tags in client soon.
But, as far as I understand, the server isn't able to dump tags to annotation files
Probably we should update specification for CVAT XML and support dumping. Initially, at least in CVAT format.

[x] Update CVAT XML format and its specification in docs
[x] Implement dumping/uploading of tags in CVAT XML format
[ ] Investigate which of other formats can contain tags and provide implementation for them

I will close the issue.


fv3fit.train uses tfdataset instead of xr.Dataset sequences

This PR replaces the use of batches inside the fv3fit.train training code with tfdatasets. This should improve the performance of the data pipelining, reduce the amount of user code we have to rely on for data pipelining, and improve compatibility of fv3fit.train routines with emulation training code (which already uses tfdatasets).
Refactored public API:

Added clipping to convolutional training
Default batch size for convolutional training is now 1
Added clipping configuration to precipitative training
refactored loss in precipitative training to be configured identically to the dense training
TrainingLoopConfig/keras model training will now shuffle across a configurable number of samples (2,000,000 by default, approximately 144 timesteps worth of C48 columnwise data), instead of shuffling within single batches
The serialized format of random forest predictors has changed, such that old models cannot be loaded by the updated code and vice-versa

Significant internal changes:

Added train_column_model and ModelBuilder, which refactor the dense and precipitative models to re-use as much code as possible

Added functions which operate on tfdatasets: pack_tfdataset, unpack_tfdataset

refactored all training functions used by fv3fit.train to take tf.data.Dataset instead of Sequence[xr.Dataset] for their train_batches and validation_batches arguments.

Added functions which operate on mappings of string to tensor: clip_sample, select_keys, apply_to_mapping,

Added functions which operate on tensors: unpack_sample, ensure_nd

Added function tfdataset_from_batches which converts batches to tfdataset

The format used by EpochResult has changed from history: tf.keras.callbacks.History to a batch_logs and epoch_logs value centered around dictionaries of keras metrics, which better reflects the values given by keras to keras callbacks

[x] Tests added

Resolves # [JIRA-TAG]
(Delete this for the commit message)
You are encouraged to check the PR against the Code Review Checklist.

I have to update the regtest outputs for sklearn training because the numpy version was incremented. Not sure when it was incremented or why they aren't already updated, if I pulled the increment in from master.

I have to update the regtest outputs for sklearn training because the numpy version was incremented. Not sure when it was incremented or why they aren't already updated, if I pulled the increment in from master.

This was expected...and required by bumping to a numpy that is compatible with tensorflow 2.8. FWIW, I think git log constraints.txt can help you understand why a certain file changed:
commit 97d2e459d917dc7d879c5405bd830b82ac8b1b82
Author: Noah D. Brenowitz<EMAIL_ADDRESS>Date:   Mon Mar 7 21:42:09 2022 -0800

    fix dataflow submission

    The dependencies in `workflows/dataflow/setup.py` were incompatible with
    constraints.txt. Dataflow now supports running via a docker image, which will be
    easier to ensure a consistent environment.

    * switch to using docker for dataflow jobs
    * ensure dependencies are compatible with the versions installed in the dataflow
      base image

    These dependencies mostly match our stack, but did force some updates to
    libraries in the google stack like tensorflow and the google-cloud-* packages.

    Resolves #1678

FWIW, I think git log constraints.txt can help you understand why a certain file changed

Smart! The confusing part for me is, why is CircleCI not respecting the updated constraints.txt?

Found a bug where sklearn training fails if data inputs are mixed types. Will fix.

I have a local fix for the failing unit test, will push it tomorrow to avoid resetting an image build.


Switching inventories doesn't work properly

Description
When swapping between inventories, the second inventory you try to open doesn't display.
Reproduction
Switch between any two inventories (ie, a toolbelt and a backpack). You will notice the first inventory you opened close normally, but the second one will briefly flash on-screen for a split second before disappearing. The second inventory is actually still open, but is invisible.
Screenshots
First inventory opened:

Second inventory opened:

A split second later, the second inventory is now invisible (no buttons pressed):

If you right-click the second inventory, you can see it shows "Close Inventory", meaning it's still open but just not visible:

Additional context
This is a fairly recent bug, so may have been introduced by one of the last couple updates.

I think this bug was in when newstorage was added, I dunno if it was fixed for a time between then but yeah.

https://github.com/space-wizards/space-station-14/issues/31466

resolved by https://github.com/space-wizards/space-station-14/pull/31616
will mark this as fixed when I merge upstream

resolved by #555


cmake: kconfig: preserved quotes for Kconfig string values

Fixes: #48950
Kconfig requires quoted strings in its configuration files, like this:

CONFIG_A_STRING="foo bar"

But CMake requires that strings are without additional qoutes,
and therefore quotes are stripped when loading Kconfig config filers
into CMake.
This is particular important when the string in Kconfig is a path to a
file. In this case, not stripping the quotes leads to an error as the
file cannot be found.
When users pass a string to Kconfig through CMake, they are expected to
pass it so that qoutes are correct seen from Kconfig, that is:

cmake -DCONFIG_A_STRING=\"foo bar\"

In CMake, those qoutes are written as-is to Kconfig extra config file,
and then removed in the CMake cache.
After Kconfig processing, the Kconfig settings are read back to CMake
but without quotes. Settings that was passed through the CMake cache,
for example using -D are written back to the cache, but this time
without the qoutes. This results in Kconfig errors on sub-sequent CMake
runs.
Instead of writing the Kconfig value setting back to the CMake cache,
introduce an internal shadow symbol in the cache prefixed with CLI_.
This allows the CMake cache to keep the value correctly formatted for
Kconfig extra config creation, while at the same time keep existing
behavior for CONFIG_ symbols read from Kconfig.
Signed-off-by: Torsten Rasmussen<EMAIL_ADDRESS>

@xudongzheng  please verify it fixes your problem.

Thank you for the patch. I can confirm that this fixed my issue as well.


Alpha property for animations

Hey @manuelodelain ,
Here is the new alpha feature.

Added new alpha property to the animation. Currently only supported on canvas mode.
Added documentation for x, y and alpha properties of the animation on the README
Added alpha test on the one canvas example.

thanks @miguelmoraleda !

Np man, I'm really motivated with this project. I'm looking forward to start using it as the standard at my company.
Do you have more features on mind? I would love to keep helping. Maybe it would be nice to create a simple landing page for the project, hosting the 3 demos. How do you feel about?

It would be great ! Are you talking about Jam3 ?
I have some ideas for new features like TexturePacker support or mutliple animations per spritesheet.
I will open possible enhancements in issues.
A landing page would be really nice.


Dotenv: Unused Loader instance in __construct

loadData() will always create a Loader instance, so creating one in Dotenv::__construct() is only useful for Validate.
Hopefully travis agrees.

Hmm. Not sure this is the best fix actually.

I think we have a more fundamental design problem here.

Completely agree that this is not the best fix. This only makes it more clear what is happening whereas right now, it's somewhat misleading. Feel free to close this out when you have a better solution. If you can, please link to that better solution here.

Just merged #215 which fixes this problem in loadData.

Thanks @vlucas, closing.


NPM Audit Failure - Compiler - v7.2.5

Hey guys,
Im not sure if this is under acceptable circumstances, we have reported an npm audit failure here:
https://github.com/angular/angular/issues/28796
Not sure if you guys are aware of it, tldr:
│ Low           │ Regular Expression Denial of Service
│ Package       │ braces
│ Patched in    │ >=2.3.1
│ Dependency of │ @angular/compiler-cli [dev]
│ Path          │ @angular/compiler-cli > chokidar > anymatch > micromatch > braces
│ More info     │ https://npmjs.com/advisories/786

Heya, it sure is important that we are aware of these, so thank you for bringing it up. The main issue we're using to track it is https://github.com/angular/angular/issues/28771 because that package is part of that repository. We have a fix incoming in https://github.com/angular/angular/pull/28797.

Closing as the fix for this has been released in @angular/compiler-cli v7.2.6


Network,Services: refactoring and json export

Last things to fix:

I found this code block:

            | :? AggregateException as aggException ->
                match aggException.InnerException with
                | :? SocketException as ex ->
                    return raise <| GuardConnectionFailedException ex
                | _ -> return raise <| FSharpUtil.ReRaise aggException

That is very fragile, can you replace it with FSharpUtil.FindException please.

The commit NOnion.Tests: update fallback server list should explain how you did it.
 And in another commit there's no point in using "NOnion: ".

Good work! Last thing to fix here is the nuget upload commit, because of the following reasons:

We shouldn't use Powershell if we can avoid it, it's not crossplatform (it somehow is crossplatform lately, but I'm sure setting it up is a pain, and anyway powershell is ugly). We used it sometimes before in cases where we were forking a project that already used Powershell or a project whose main build CI scripts were using Windows.
We shouldn't use Windows jobs if we can avoid it. We used them sometimes before in cases where we were forking a project that already used build CI scripts that were using Windows (and would be a nightmare to migrate).
Now that you switch to Linux, best strategy to generate the version number is, instead of fiddling with horrible bash, just clone fsx and call nugetPush with the appropiate flags.

How about pulling out the nuget commit to a different PR to not block this one?


feat(#71): update version to 0.1.9

The new version of jtcop is 0.1.9.
In order to use, just update version:
<plugin>
      <groupId>com.github.volodya-lombrozo</groupId>
      <artifactId>jtcop-maven-plugin</artifactId>
      <version>0.1.9</version>
      <executions>
        <execution>
          <goals>
            <goal>check</goal>
          </goals>
        </execution>
      </executions>
</plugin>

Closes: #71

@l3r8yJ Could you have a look, please? It should help you.

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 1min)


Add a validateAll function to useInputValidator

Not sure if it should validate entire schema or just properties which have inputs. Maybe validate entire schema and provide a otherErrorMessages array for errors without a corresponding <InputErrorMessage />

addressed by #534


Specify Encoding when getting Setup.py Description

Was downloading a repo fork with Python 3.9 on windows, and
autodetection would return the wrong encoding for README.md

Description

GitHub Issues

Enables devs to target latest in between full releases

Closing as duplicate of #1050, which is now merged.


Issue 120 resource add edit position & access

Describe your changes

Move up the add resource and edit buttons out of the filter group (fixes for screen size 320px / zoomed)
Add sr-only new tab warning on target blank links
add keyboard functionality on filter collapse: use details summary elements (and fix needing to double click)

Related issue number/link
Fixes https://github.com/ClimateTown/knowledge-hub/issues/120
Thanks for contributing! 🥳🚀🌳

@all-contributors please add @dmlb for code


Unable to Open Unicode File Containing XML

hmmm.txt
I'm unable to open files like the attached Unicode file and get the following error:
"The file will not be displayed in the editor because it is either binary, very large or uses an unsupported text encoding."
If the file is saved as UTF-8 in a different editor, it is then able to be opened by VSCode.

VSCode Version: Code 1.10.2 (8076a19fdcab7e1fc1707952d652f0bb6c6db331, 2017-03-08T14:02:52.799Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

vscode-eslint
dbaeumer
1.2.7

xml
DotJoshJohnson
1.7.0

csharp
ms-vscode
1.7.0

vscode-docker
PeterJausovec
0.0.12

theme-obsidian
rprouse
0.2.0

Steps to Reproduce:

Open the attached hmmm.txt file in VSCode.
Observe error message.

If the file is using UTF-16 LE or BE you are required to add a BOM to it, otherwise we think the file is binary because it contains 0-bytes.


Pin snapshot not working

Using Gradle 6.0.1, pinning a dependency SNAPSHOT version is not working for us:

Could not find crypto-pfx-1.0.0-20191122.161310-5.jar (prodist-jvm:crypto-pfx:1.0.0-SNAPSHOT:20191122.161310-5).
Searched in the following locations:
http://nexus.prodist.com.br:8081/repository/maven-beta/prodist-jvm/crypto-pfx/1.0.0-20191122.161310-5/crypto-pfx-1.0.0-20191122.161310-5.jar

This seems to be a regression to GRADLE-2784.
Expected Behavior
Coordinates (prodist-jvm:crypto-pfx:1.0.0-SNAPSHOT:20191122.161310-5) map to location http://nexus.prodist.com.br:8081/repository/maven-beta/prodist-jvm/crypto-pfx/1.0.0-SNAPSHOT/crypto-pfx-1.0.0-20191122.161310-5.jar
Current Behavior
http://nexus.prodist.com.br:8081/repository/maven-beta/prodist-jvm/crypto-pfx/1.0.0-20191122.161310-5/crypto-pfx-1.0.0-20191122.161310-5.jar
Context
Dependency published with Gradle 6.0.1.
Steps to Reproduce
Publish SNAPSHOT version of component to Maven repository with Gradle 6.0.1.
Define a project with a pinned dependency on this specific SNAPSHOT.
Build project.
Your Environment
Build scan URL: https://scans.gradle.com/s/ujgfj6keayjpq

Thanks for the report, I have been able to reproduce.
Looks like while doing fixes for #9462, some corner cases were still missed.

We did a quick check today:

5.6.4 [succeds]
6.0.1 [fails]
6.1<PHONE_NUMBER>0035+0000 [succeeds]

Thanks for taking time to confirm the fix is working.


modified with names and content

you have conflicts. declined. you need to use updated version. best sync with upstream


Reorder build phases so firebase crashlytics is last

📲 What
The crashlytics script needs to be run last in the build phases; otherwise it breaks the build.
✅ Acceptance criteria

[x] Building (beta version) works again

Clever find!

Thanks! This was teamwork :)


Commenting out lines breaks paragraphs

(Pretty sure this is a Pandoc-Markdown issue, not LP, but it's annoying enough to me that I wouldn't mind fixing it in LP.)
I split my paragraphs into one-sentence-per-line:
Sentence 1.
Sentence 2.
Sentence 3.

I comment out the second sentence:
Sentence 1.
<!-- Sentence 2. -->
Sentence 3.

Now it's formatted as two paragraphs! No good.

Yes, this has burned me before, too, and arises from the Pandoc parser output. I will need to take a closer look to figure out if the Pandoc AST has the right info in it to know when and when not to "stitch" things back together into a single paragraph.


[Release 2.3.x] fix(traits): don't skip for synthetic kits

This PR fix some regressions as identified in https://camel.zulipchat.com/#narrow/stream/257299-camel-k/topic/Catalog.20not.20found.20for.20sourceless.20integration.20after.20upgrade

Release Note
fix(traits): don't skip for synthetic kits

@squakez Many thanks on our team's behalf for this speedy PR. I was able to verify the mount and camel traits work as expected. Looking good from our end!


Fix bugs in ONNXRT examples for v2.4

Type of Change
bug fix
API not change
Description
Fix bugs in ONNXRT examples for v2.4
How has this PR been tested?
CI, extension test
Dependency Change?
no

extension test is running

BiDAF_dynamic, hf_bart-large_dynamic, hf_bart-large: pass extension test
onnxrt-roberta_base_MRPC_dynamic: pass extension test
onnxrt-roberta_base_MRPC_qdq: pass extension test
onnxrt-unet: pass extension test


What are s1 and s2 for?

I mean, I see in the code how are they used, and also see the algorithm in Wikipedia. I wonder though, why may we need s1 and s2 being non-null, what benefit does their presence carry?..
It looks like in some cases (e.g. when the encrypted message is not sent over the wire to someone, but instead is stored locally and is encrypted just for privacy/security reasons), making s1+s2 process optional (and removing the tag suffix from the message) may free up some CPU resources.

Yes, lots of performance optimization could be made to current implementation. I was just trying to make the code simple because I believe the performance cost of those parts would be very small compared to ecdh calculations. What is your use case? Is that very performance-critical?

My usecase is encryption of the users’ data before writing it to some storage. The ciphertext is not transmitted over a public network, so there is no need for authentication.

What about doing encryption on client side or simply using a symmetric block cipher? The first choice resulting an end-to-end encryption and the second one is better than ecies for streaming and reading from random offsets.


Update _base.scss

Change to appropriate site header

Codecov Report

Merging #13 (e9ae138) into master (6fd3b93) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fd3b93...e9ae138. Read the comment docs.


Removed separate proto compile step

setup.py file does the necessary setups and configurations.

Hello Haridas,
Thank you for taking the initiative to help improve this repo! Appreciate your efforts.
I fully agree that compiling the proto files automatically during package installation makes it easier to pull upstream changes and remove the needs of the manual compilation.
One caveat with this current implementation is the introduction of "protoc" as an out-of-channel dependency. Users need to somehow make sure the right version of protoc is properly installed. As a thin wrapper aiming to install TF object detection with a simple pip install, is there a way we could remove the assumption of protoc availability in this PR?
Two approaches come to my mind to make this work:
Option 1. Package and publish protoc binary as a separate PyPI package. tf_object_detection would then specify that package as a dependency. (Maybe someone else has already done this)
Option 2. Download protoc binary during installation. Use the downloaded protoc binary to compile protobuf instead of assuming the existence of protoc.

Thanks @junjuew
I was thinking in this line only, my take on these scenarios are,
Option 1:
This is the normal flow expected, users just download and use the library from PyPI server using pip install object_detection_tf. The library author can publish any future updates to the PyPI server, by ensuring locally things are good.
Option 2:
This Is for those who download the source repo and play with it or customise and install under their environment using python setup.py install, I guess in that case giving user the flexibility to supply the protoc binary is right option. Having the clear Readme helps to avoid the version and other issues. We could do the download and handling of protoc but I feel as a library standpoint we can keep the external dependency as external.

I see. Sounds good. Could you publish the package to the test PyPI server and send me the link? I'll merge the PR once I confirm the published wheel can be successfully installed through pip.

Sure, will update you once the test PyPI package ready.

LGTM

Thanks @junjuew


fix: bump solid to 1.6.1

:tada: This PR is included in version 0.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


azure-functions-dotnetcore-latest does not build

azure-functions-dotnetcore-latest fails to build with the following error:
Unable to locate package azure-functions-core-tools
build image.txt

VSCode Version:1.38.1 and 1.39.0-insider
Local OS Version: Windows 10 version 1903 (OS Build 18362.356)
Name of Dev Container Definition with Issue: azure-functions-dotnetcore-latest

Steps to Reproduce:
Prereqs - remote (containers) extension and docker.

Open an empty folder in vscode.
Run 'Remote Containers: Add Development Container Configuration Files...' command and select 'Azure Functions and C# (.Net Core Latest)'.
Reopen folder in container.

I've compared the Dockerfile and devcontainer.json between azure-functions-dotnetcore-2.1 and azure-functions-dotnetcore-latest and the only difference is the base image referenced in each Dockerfile.  Could this be related to .NET Core latest Docker tags updated to 3.0 given that azure functions doesn't yet support .Net core 3.0?

Good catch - in the case of the Azure functions containers, we may need drop the "Latest" versions of the .NET ones and just go with specific versions as they're supported.

@allanwright If you update the FROM statement in the Dockerfile to reference 2.2 instead of latest, does it work for you?

Fixed with https://github.com/microsoft/vscode-dev-containers/commit/c415c961f7d9d303f994e974250153a483bf7a8f
//cc @chrmarti

Thanks @Chuxel, builds just fine now!


Change default to remove Pretty JSON and make it user configurable

Pretty JSON is costly in the RPC stack and in file sizes. This issue tracks removing Pretty JSON as the default for Besu and creates a new flag:
--pretty-json-enabled with a default of false
This will be considered a breaking change and should be included in the RC series.

@non-fungible-nelson, I started looking into this.
From what I see writerWithDefaultPrettyPrinter is called from 2 different utility classes (JsonUtil and JsonUtils), however both are in different modules and have different command interfaces (BesuCommand and  EvmToolCommand). The second one it's easy to update with a command argument but for the first one the things are a lot complicated as I can't find any proper configuration class referred inside BesuCommand that could help.
Could you share your thoughts about this? what might be a possible hint?


source_max is broken on returned paths.

I'm still getting those results on testnet, so I assume it has not been deployed yet.
When should this go to testnet/livenet respectively?

Sorry about that @TbLtzk!  It has been deployed to both testnet and livenet now.

Thanks @nullstyle, perfect! Sorry to bother you again with a final question: the paths result (see link below) now contains 2 Options for sending 50 XLM:

50 XLM direct
98 XLM via Asset 'AAA' (and back)
I think it does not make sense to have multiple options with the same source Asset, because I would obviously choose the lower amount. What do you think? And would you consider this be part of horizon or should clients filter if desired?
Example again: https://horizon-testnet.stellar.org/paths?destination_account=GDJXQYEWDPGYK4LGCLFEV6HBIW3M22IK6NN2WQONHP3ELH6HINIKBVY7&source_account=GAN65D2FEI63T4MBMOWWOP3K7VS6SVI5T6NNKIHNCI6PN32IGF6OVKSS&destination_amount=50&destination_asset_type=native

No worries!  It's not a bother at all @TbLtzk
The behavior is by design. The simple path finder in horizon is not to be the most efficient, but rather it simply aims to provide useable paths. It's the client's responsibility to filter and find the appropriate/best path given the current path finding implementation.
The system is pluggable, however, and encourage others to build additional implementations (you can see the go interfaces to satisfy here: https://github.com/stellar/horizon/blob/master/src/github.com/stellar/horizon/paths/main.go)

Furthermore, IMO it's in the client's best interest to decide the best path itself...  your software will perform better because it will have fewer dependencies on externalities to achieve correct behavior.

Hmm idk. I think it should only return 1 path per sending asset. Seems better to make the behavior of this default pathfinder simpler for the client and if people want more complex behavior then they can customize the pathfinder rather than the other way around.
The client would still be able to choose between paths in different assets.

My concern is that people will start making the same assumption the TbLtzk did.  I can change it, but I believe that picking the best path for a given source asset should be the client libraries responsibility, and I think we're taking a risk around people misinterpreting what will amount to an implicit protocol.

Sorry what was his assumption?Why would the client ever want to pick a worse path?

Even worse: the example above is XLM -> AAA -> XLM which would mean: one path per any asset on the entire network that has at least one bid and one ask of sufficient size.
At least we should exclude paths that buy and sell on the same orderbook.
But still I can't think of any use case where I want the more expensive path except the cheaper one does not work for whatever reason, which of course should not happen when it is returned as a valid payment option.

@jedmccaleb for example, a bank may want to route a payment through it's own forex desk.  That said, you know I don't like to get into the gave of making assumptions when the use case is not clear.
I'm convinced this is worthy to be considered a bug for our pathfinder.  I'll open up an issue.


Feature Request - Get due date of assignment

Currently, from reading the function get_assignments, there seem to be 4 attributes. Those are:
assignment_id
class_
grading_period
name

However, I don't see any way to get the due date of an assignment. Am I missing something, or was this not added? I find this to be a pretty crucial feature.

This was already added in v1.2.3. https://github.com/kajchang/StudentVue/commit/41ddd9715b75fd7b5e545a9bed9ad80bd04fbc70


[P0] LUIS CLI: --msbot option should include authoringRegion

This will complete the other part of #329 by enabling the LUIS CLI with --bot option to include authoringRegion to be piped to msbot connect command.
Today:
>luis get application --msbot
{
  "type": "luis",
  "name": "xxxx",
  "id": "xxxx",
  "appId": "xxxx",
  "authoringKey": "xxxx",
  "subscriptionKey": "xxxx",
  "version": "0.1"
}

Expected:
>luis get application --msbot
{
  "type": "luis",
  "name": "xxxx",
  "id": "xxxx",
  "appId": "xxxx",
  "authoringKey": "xxxx",
  "subscriptionKey": "xxxx",
  "authoringRegion": "westus"
  "version": "0.1"
}

This needs to be fixed in all places we support --msbot flag.
Once we have this, users can do this to chain these commands together.
> luis get application > msbot connect luis --stdin

Fixed.


Fixed two typos

Description (required)
Fixed two typos at src/content/docs/en/guides/cms/apostrophecms.mdx and src/content/docs/en/upgrade-astro.mdx.

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌑 This pull request will not trigger status changes.

Learn more
Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: typo.
You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Locale
File
Note

en
guides/cms/apostrophecms.mdx
Source changed, localizations will be marked as outdated.

en
upgrade-astro.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.