Lint nohllogic

Description

Refactor qbit module and address various pylint issues
add doc strings
rename/cleanup vars that did not comply to snake_case

Refactor NoHardLinks Logic
This is a material change in previous logic.
Previous State for noHardLinks:
- Max Ratio from noHL Cat
- Max Time from noHL Cat
- MinSeedTime from Tracker if exists; else noHL Cat
Future State for noHardLinks:
For Max Ratio, Max Time, and MinSeedTime:
- Larger of Tracker or noHL Cat
- if tracker and noHL Cat are not set use -1 (unlimited)
Fixes #218
Fixes #229
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated the docstring for new or existing methods
[x] I have added tests when applicable
[ ] Testing

Tested Dry Run output
|================================ Tagging Torrents with No Hardlinks ================================|
|    Torrent Name: Avatar.The.Way.of.Water.2022.1080p.WEB-DL.DDP5.1.Atmos.H.264-FLUX.mkv             |
|         Tracker: https://tracker.beyond-hd.me:2053                                                 |
|         Min seed time not met: 4 days, 2:54:32 <= 5 days, 0:00:00. Removing Share Limits so qBittorrent can continue seeding. |
|         Adding Tag: MinSeedTimeNotReached                                                          |
|    Torrent Name: Avatar.The.Way.of.Water.2022.1080p.WEB-DL.DDP5.1.Atmos.H.264-FLUX.mkv             |
|         Tracker: https://tracker.beyond-hd.me:2053                                                 |
|     Share Limit: Max Ratio = 3.0, Max Seed Time = 43200 min                                        |
|    Torrent Name: The.Rookie.Feds.S01E19.720p.WEB.h264-ETHEL.mkv                                    |
|         Tracker: http://landof.tv                                                                  |
|         Min seed time not met: 2 days, 7:00:48 <= 5 days, 0:00:00. Removing Share Limits so qBittorrent can continue seeding. |
|         Adding Tag: MinSeedTimeNotReached                                                          |
|    Torrent Name: The.Rookie.Feds.S01E19.720p.WEB.h264-ETHEL.mkv                                    |
|         Tracker: http://landof.tv                                                                  |
|     Share Limit: Max Ratio = 3.0, Max Seed Time = 14400 min                                        |
|    Torrent Name: The.Rookie.S05E19.720p.HDTV.x264-SYNCOPY.mkv                                      |
|         Tracker: http://landof.tv                                                                  |
|         Min seed time not met: 2 days, 17:00:59 <= 5 days, 0:00:00. Removing Share Limits so qBittorrent can continue seeding. |
|         Adding Tag: MinSeedTimeNotReached                                                          |
|    Torrent Name: The.Rookie.S05E19.720p.HDTV.x264-SYNCOPY.mkv                                      |
|         Tracker: http://landof.tv                                                                  |
|     Share Limit: Max Ratio = 3.0, Max Seed Time = 14400 min                                        |
|    Torrent Name: Avatar.The.Way.of.Water.2022.2160p.WEB-DL.DDP5.1.Atmos.DV.HDR.H.265-FLUX.mkv      |
|         Tracker: https://tracker.beyond-hd.me:2053                                                 |
|         Min seed time not met: 4 days, 2:41:27 <= 5 days, 0:00:00. Removing Share Limits so qBittorrent can continue seeding. |
|         Adding Tag: MinSeedTimeNotReached                                                          |
|    Torrent Name: Avatar.The.Way.of.Water.2022.2160p.WEB-DL.DDP5.1.Atmos.DV.HDR.H.265-FLUX.mkv      |
|         Tracker: https://tracker.beyond-hd.me:2053                                                 |
|     Share Limit: Max Ratio = 3.0, Max Seed Time = 14400 min                                        |
| Did not Tag/set share limits for 4 .torrents.                                                      |


fix: restore group field item type exports

Types of changes

[ ] Chore (a non-breaking change which is related to package maintenance)
[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
This PR restores exports for a group field's item interface.
Checklist:

[ ] My change requires an update to the official documentation.
[x] All TSDoc comments are up-to-date and new ones have been added where necessary.
[x] All new and existing tests are passing.

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (a020818) 97.11% compared to head (843fdbd) 97.11%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   97.11%   97.11%
=======================================
  Files          20       20
  Lines        1490     1491    +1
  Branches      161      161
=======================================
+ Hits         1447     1448    +1
  Misses         42       42
  Partials        1        1

Files Changed
Coverage Δ

src/lib/buildFieldProperties.ts
97.11% <100.00%> (+<0.01%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.15.6 to before v5.15.11",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e25bdbc7e951ae5728fee1f4c09485df113d013c",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=491c1253441e2fdc8f6a6f4976e3f13440419b7a"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "e25bdbc7e951ae5728fee1f4c09485df113d013c",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "491c1253441e2fdc8f6a6f4976e3f13440419b7a",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net/sched: sch_ets: don't remove idle classes from the round-robin list\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.11 by commit 491c1253441e2fdc8f6a6f4976e3f13440419b7a, it was introduced in version v5.15.6 by commit e25bdbc7e951ae5728fee1f4c09485df113d013c. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002742


[Compute] az vm create: Support creating VM from shared gallery image

Feature request: https://github.com/Azure/azure-cli/issues/18870
Description

Gallery team currently has a feature called shared gallery, user can directly share their gallery to another subscription/tenant. This request is to allow user to deploy VM from these shared gallery.
Therefore, the command az vm create supports referencing shared gallery image to create VM with parameter --image
Testing Guide

az vm create -n MyVm -g MyResourceGroup --image /SharedGalleries/{gallery_unique_name}/Images/{image}/Versions/{version}

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Compute


PRs don't show up if the source repository has been deleted

I'm trying to resolve the conflict for https://github.com/microsoft/vscode-wiki/pull/196 but I cannot as it doesn't show up in the PR view. Trying to use a codespace makes it clear that the issue is the repo the PR was created from has already been deleted:

Output:
[Info] C:\Users\Daniel\.ssh\config: ENOENT: no such file or directory, open 'C:\Users\Daniel\.ssh\config'
[Info] Registering git provider
[Info] Looking for git repository
[Info] Found 1 repositories during activation
[Info] Git repository found, initializing review manager and pr tree view.
[Info] Review> Validate state in progress
[Info] Review> Validating state...
[Info] Cannot updates repositories as git is uninitialized
[Info] Review> Queuing additional validate state
[Info] Review> Validating state...
[Info] Cannot updates repositories as git is uninitialized
[Info] Git initialization state changed: state=initialized
[Info] Review> Queuing additional validate state
[Info] Review> no matching pull request metadata found for current branch main
[Info] Review> no matching pull request metadata found on GitHub for current branch main
[Info] Review> Validating state...
[Info] No remote with name 'ups' found.
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch main
[Info] Review> no matching pull request metadata found on GitHub for current branch main
[Info] GitHubRepository> The remote branch for this PR was already deleted.
[Info] GitHubRepository> The remote branch for this PR was already deleted.

It's arguable what should happen here, but I was pretty confused as no error was surfaced at the least. The PR should show up in the list, perhaps with a ⚠ and custom hover or something?

PRs where the PR branch has been deleted now show, but you can't check them out.


New version: TeamSpeakSystems.TeamSpeakClient version 3.6.0

Pull request has been created with Komac v1.6.0 :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/109828&drop=dogfoodAlpha

Duplicate of #109808


Issue 2716 part 1

This eliminates the "Failed to decode S3Readme" log message, on of three tracked in #2716 .
Because this comes with a migration (migration 71), it's based on top of the funding changes (which has migration 70 but which we've reverted for now). Therefore this must not be merged until we've either merged the funding changes for good or decide to swap the migrations around (make this one here migration 70 and the one in funding 71).

Go ahead and make this migration #070, I have a new local branch for fetch-funding and I'll make it #071 in that branch. 👍


pytest doesn't work for simple workspace

Describe the bug
pytest doesn't work for simple projects, but unittest does. Project structure here:

Steps to Reproduce

Create any open folder scenario with both pytest and unittest enabled.
try to discover tests using the pytest framework. This doesn't work, but unittest does.

Expected behavior
both testing frameworks should work.
Additional context and screenshots

Configuration information (If you are providing a diagnostics file (see below), skip this section)
VS Version: 16.3.0 Preview 3.0 (29204.9.master)
PTVS version:
Python version:3.7
Debugger Type (if applicable):
Diagnostics file
Diagnostic Info 2019-08-05T141725.txt

VS is caching test list in this folder, which is worth trying to delete: .vs\PythonApplication2\v16\TestStore

Related issue https://github.com/microsoft/PTVS/issues/5425

Added more error checking and warnings around this case.. Please try again on tmr's build. related PR  #5572


How to create a new function in page-edit toolbar ?

Describe the feature you'd like
I want to add an editor like SVG-edit to the toolbar in page-edit.
Describe the benefits this would bring to existing BookStack users
You can use the editor you used before using bookstack, such as Gantt chart, self-made editor, it will be more convenient.
Can the goal of this request already be achieved via other means?
no
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
0 to 6 months
Additional context

Hi @E60502,
The underlying editor, and its toolbar, can be modified using some custom events we emit.
See my comment here for an example which modifies the toolbar with an extra button.
Note, these options of extension are not fully stable and may break upon updates.
In  addition, SVG usage (and more advance content formats in general) may affect other parts of the system and cause issues (PDF exporting for example).

@ssddanbrown let me try, thanks.

Will therefore close this off.

Are BookStack Editor Events custom in Custom HTML Head Content?

@E60502 They can be used with any method to add custom JavaScript, but yes, the "Custom HTML Head Content" setting is the main way to add code for these events.

@ssddanbrown Thank you for your reply.
Then if I want to import the application I want to use in the button I added, where should I put the code folder of the application I want to import?
And this code window.addEventListener('*', event => console.log('*', event.detail));
What do I import in ' * ' ?

where should I put the code folder of the application I want to import?

There's no ideal place within BookStack right now to add additional assets. You'd have to use a CDN link for your library, or host in yourself in some public web space, or embed the code directly into BookStacks extension options.

What do I import in ' * '

If editing the tinymce config you'd typically want to use window.addEventListener('editor-tinymce::pre-init', eventHandler);.
If you wanted a much simpler example of editing TinyMCE config, you could see my comment here.

I have already put the bookstack and the application's code folder on the same server, so can I extend it directly in the themes folder?

Thank you for answering me patiently, I will reorganize the functions I want to add, I have a project system that needs to be logged in, this system's code and Bookstack's code are placed on the same server, I want to create a button in the editing toolbar and when I clicking it, the system does not need to log in again.
My current idea is to remove the login page of the project system and click the button to enter the window for selecting a project.
Q1. I think this will involve the connection of the database. They are all in MSSQL. I would like to ask if Bookstack can connect to another database? I have seen the connection to the database in .env.
Q2. I have read the article about adding a PDF button, and I can already add a button. I want to change the window for inputting PDF to input project name. After inputting, I can connect to the database to capture the project I want to open. If Q1 can be achieved, this should also be edited in Custom HTML head content?
Sorry to keep bothering you.

I think this will involve the connection of the database. They are all in MSSQL. I would like to ask if Bookstack can connect to another database? I have seen the connection to the database in .env.

It is possible via custom hacking of the BookStack PHP code (Perhaps via the logical theme system) , and the base framework in use (Laravel) does have some support for MSSQL, but this kind of thing is not supported in any way.

After inputting, I can connect to the database to capture the project I want to open. If Q1 can be achieved, this should also be edited in Custom HTML head content?

Q1 could not be done in custom HTML head content alone. You'd need to write some custom logic to handling a lookup to a custom endpoint to run your query of the other database. Getting a bit advanced at this stage so you'd need to be fairly confident with this. Ideally you'd want some level of full-stack web experience since this would involve writing and combining custom front-end and back-end code.

Can I embed the link of the project system in the Custom HTML head content?

@E60502 Maybe, but I'm not really sure what you mean by that to be honest.

Do you mean inserting a link into the content of the page?
Or do you mean attaching a link-based attachment? (Which would show in the sidebar of the BookStack page when viewed.)

On the button.

For jQueryGantt, can it be implemented with TinyMCE?

For jQueryGantt, can it be implemented with TinyMCE?

Probably possible in some way, but It would take a fair amount of work, and expertise of the JavaScript code at play, to integrate to be honest.

In order to complete this what skill is must require ? And is this possible for a beginner?

In order to complete this what skill is must require ?

Primarily a fair amount of JavaScript skill and experience. Some PHP/Laravel experience may help to understand usage with back-end functions, since the addition may cause further problems that need to be addressed.
Ideally some experience with TinyMCE, although this could be learnt by someone with enough JavaScript skill.

And is this possible for a beginner?

Not really beginner level stuff to be honest.

Thank you for your reply, if there is any problem, I will contact you again.


Add skip-input-bucket-sync flag.

Add a flag to skip input bucket data sync when it's not needed.

New feature (non-breaking change which adds functionality)
[x] Lint and unit tests pass locally with my changes

Could we rename this option to --skip-sync?
I think this is a great idea!

Renamed, thank for the suggestion!


Feature Request: C++ gradient for LRN

this resolves #13789
Registers the LRNGrad op as the gradient for LRN by implementing LRNGradHelper
Single test case proves that everything was wired up correctly since I assume the LRNGrad code was thoroughly tested.
This is my first PR to TensorFlow. When giving feedback, please assume that I barely know what I'm doing.

Can one of the admins verify this patch?

TF Test Suite and Ubuntu CC state have been in "Waiting for status to be reported" for a while now

@benoitsteiner @suharshs @skye @andydavis1 @asimshankar
Sorry for the broadcast ping, but not sure who would be best at this point.
This has been sitting for a while. Can it be merged?
If not, why? It's not clear.
thanks

Jenkins test this please.
Sorry for the delay, I think we're a little behind on PRs this week.

@gdeer81 it looks like the test you added is failing: https://ci.tensorflow.org/job/tensorflow-pull-requests-cpu/7468/consoleFull (search for NNGradTest.LRN)

@skye looks like the failure was due to test timeout that I didn't experience in my local environment.
When I changed the test data I got the test time from 171s to 12s on my laptop so now it shouldn't timeout during the jenkins test run

Jenkins test this please.

@gdeer81 can you check how long just your test takes to run on your machine? (You can do this via: bazel test //tensorflow/cc:gradients_nn_grad_test --test_filter=*LRN) On my machine, all the current tests run in < 3 seconds. Assuming your test actually adds 9 seconds to the total test time, I think it'd be good to shrink it even more.

@skye here is the output when I do bazel test //tensorflow/cc:gradients_nn_grad_test --test_filter=*LRN

I might have been looking at the wrong value when I said it takes 12 seconds so I'll just let the screenshot speak for itself and hopefully clear up any confusion

Ah ok. I'm honestly not sure what all this means either but looks good to me :) FYI I would do something like: time ./bazel-bin/tensorflow/cc/gradients_nn_grad_test
Jenkins test this please.

excellent, all checks have passed

@jhseu can you merge? I don't have permission apparently.

@skye or @jhseu is there anything else that I need to do? Those Internal CI build failures don't look like they have anything to do with the changes I made


PR: Improve startup time

Description of Changes

Use new lazy modules defined in Spyder-kernels for Numpy, Pandas and PIL to avoid load them at startup. That also helps to simplify the code.
Call QApplication.processEvents before and during calling on_mainwindow_visible, so that users don't have to wait until those methods finish before seeing the main window.
Compute dependencies in a thread and after a 10 seconds delay to not block the interface at startup.
Avoid importing Matplotlib and Numpy at startup.
Don't compute stylesheets when importing their module.

Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

Hello @ccordoba12! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/variableexplorer/widgets/collectionsdelegate.py:

Line 187:13: E731 do not assign a lambda expression, use a def
Line 479:13: E731 do not assign a lambda expression, use a def

In the file spyder/plugins/variableexplorer/widgets/objecteditor.py:

Line 84:9: E731 do not assign a lambda expression, use a def


Use AWS EC2 in nightly tests

After a discussion w/ @soenkeliebau and @lfrancke we decided to introduce at least one AWS EC2 based nightly integration test (preferably agent-integration-test) early, even if AWS EC2 support in T2 might still be missing some features (wireguard for example)
Using more than one cloud provider in the nightly tests helps us to decide whether, in case of a failure, the problem lies on our side or within the cloud provider.

[x] enable AWS authentication in T2 production system
[x] provide Stackable client script for AWS clusters
[x] TEST: use AWS EC2 CentOS 8 template for agent-integration-test
[x] replace IONOS CentOS 8 test w/ new AWS EC2 test
[x] TEST again (2 runs)
[x] after success: re-use new terraform module for client script in older templates as well

Pull Request https://github.com/stackabletech/agent-integration-tests/pull/51


[Question]: How to use metadata extractors for adding metadata to documents

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I am using an Ingestion Pipeline like that one:
from llama_index.core.extractors import (
    #SummaryExtractor,
    QuestionsAnsweredExtractor,
    #TitleExtractor,
    KeywordExtractor,
    #BaseExtractor,
)
from llama_index.core.ingestion import (
    DocstoreStrategy,
    IngestionPipeline,
    IngestionCache,
)
from llama_index.storage.kvstore.redis import RedisKVStore as RedisCache
from llama_index.storage.docstore.redis import RedisDocumentStore
from llama_index.core.node_parser import SentenceSplitter
from llama_index.vector_stores.redis import RedisVectorStore

pipeline = IngestionPipeline(
    transformations=[
        SentenceSplitter(chunk_size=1024),
        QuestionsAnsweredExtractor(questions=3, llm=llm),
        KeywordExtractor(keywords=5, llm=llm),
        Settings.embed_model,
    ],
    docstore=RedisDocumentStore.from_redis_client(
        redis_client=redis_client, namespace="document_store"
    ),
    vector_store=RedisVectorStore(
        redis_client=redis_client,
        schema=schema,
    ),
    cache=IngestionCache(
        cache=RedisCache.from_redis_client(redis_client=redis_client),
        collection="redis_cache",
    ),
    docstore_strategy=DocstoreStrategy.UPSERTS,
)

What i have:
An ingestion pipeline that runs on documents, that were extracted from PDF Data using the SimpleDirectoryReader. Each site of the pdf is a single document. The documents are stored in the docstore and the resulting nodes are stored in the vector store. Each node in the vectorstore contains metadata extracted by the Metadata extractors.
What i would like:
I would like to add metadata to the documents. I want to extract keywords, that are important for the whole pdf file and questions the whole pdf file can answer, not just the single nodes. Additionally it would be nice if i could simply store this metadata in the docstore for every documents (page of the pdf file).

@dosu this is exactly what i already have. Can you tell me more about how to ensure that the extracted metadata is stored in the docstore?

There is an in_place variable in the pipelines run() function.


Increase height as image is cut off

Need to increase the height as the top of the image is cutoff

Before:

After:

@p32929

Thanks man :) really appreciate 👍


chore: upgrade<EMAIL_ADDRESS>

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?
Updates @eslint/plugin-kit dependency to the latest v0.2.3.
What changes did you make? (Give an overview)
Updated package.json
Related Issues

Is there anything you'd like reviewers to focus on?

CI fix: https://github.com/eslint/markdown/pull/302


Added New Rebus

Summary of Changes

change --> Added New Rebus

If this pull request is right, can you merge it in October, I am a first-time participant in Hacktoberfest 2022


Link colors looking different

Not sure why some of the links are darker blue vs. teal, and some underlined and some not?

@jbskolnik This looks like you fixed it? The best I can guess is cutting and pasting from a styled document. I see a bunch here set as a font that isn't are font. I'll try to put in some overrides. But maybe you can paste without style. I know most software you do that with command+shift+v. But, you might have to paste first into a plain text document.

Put in overrides that should work.


In authorized_keys use double-quote for windows compatibility

It appears that windows OpenSSH cannot cope with single quoted strings. Use double-quotes instead.
Fix #10813

make lgtm work

As @guillep2k says it may be that strconv.Quote/fmt.Sprintf("%q") does not completely quote things correctly but I guess this is a good start.


Add CMS "expert" modus for user/regions

Motivation
The region team requested a special mode for users to reduce their function view and only enable them, if they are considered experienced enough. These functionalities are:

Live Content
DoNotTranslate
Recurring Events
... More to come.

Proposed Solution
Add a special user permission, which is deactivated for all user by default. Grant the permission to specific user after a "expert" workshop.
Alternatives
Add an additional option on the region level.
Additional Context
...

Duplicate of #499


Update storage-import-export-service.md

Disk size supported up to 6TB.
If tracking number is not updated in 2 weeks after job creation, job expires.
Snapshot of the blob in use during export and copy snapshot
Added FAQ for export job disk preparation

Hi @ms-prkhad, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@ms-prkhad - Hi Pradnya - as a storage PM, it's probably best if you work in the azure-content-pr repo in the future. You can obtain perms at http://aka.ms/azuregithub.
@tamram - update to import/export article, fyi.


Schedule execution as a job

Implemented as part of https://github.com/FriendsOfSilverStripe/silverstripe-maintenance


[BUG] Empty HttpEntity results in DeliveryStatus exception

What is the bug?
The status is retrieved from the response of sendMessage. In this case it'll be calling the execute of DestinationHttpClient to send the message. The responseString here is what becomes the statusText.
The response string is derived from the entity of the response. An HTTP entity in the response can be empty ("") or there can be no entity (null). The null case is being covered by replacing it with the {} string but it looks like the empty case wasn't being covered differently and was just returning an empty string. This is not a valid argument for the statusText param of what gets passed to DeliveryStatus, resulting in an IllegalArgumentException.
What is the expected behavior?
I think we should just check for isNullOrEmpty when getting the response string and make both represented as {}. I only see that method being used to return to the contents of what populates DestinationMessageResponse. If we want to distinguish between null and empty and not use {} for both for whatever reason, then I think DeliveryStatus should support empty statusText if that's derived from the HTTPEntity.
From an HTTP perspective, an empty entity is different from no entity. However, since we're talking about what ultimately becomes the string representation of the statusText, I'd prefer the former approach between the two above as it's simpler.

Cheers,
we upgraded some environments to 2.5 but it seems it broke our custom webhook. It’s a very simple one, just a server:port with an extension, nothing complex. We have some environments still at 1.3 and the exact same setup works.
Within the logs we get this error [status_exception] statusText is null or empty

Another user of OpenSearch project ran into the same issue. The workaround is for the downstream system the webhook is calling needs to return something in the message payload which could be "{}" or "null". This is something which needs to be fixed promptly since https status codes are commonly used. @xluo-aws as a heads up.

@hailong，Hailong, could you help take a look at this issue?

I agree with @qreshi that the string representation of null and an empty HTTPEntity can be the same as {}. If we want to distinguish between them, we could consider replacing the empty value with ok as a possible solution.


WDE creates the tun adapter and fails, when the old one is in hung state

WDE creates the tun adapter and fails, when the old one is hung. This loop will be repeated until someone manually deletes the hung adaptor

https://github.com/openziti/desktop-edge-win/pull/477 - This fix cleans up the tun adaptor if WDE fails during the initialisation of tun. I could not reproduce the issue where the tun will be in hung state. So I could not test the clean up of adaptor that is in hung state.


allow settings to be set in a settings file as well as on command line

Currently, goat-guardian only accepts settings from environment variables.
Eventually, it would be nice to allow settings to be set in a settings file (possibly YAML or dhall) as well as on the command line.
We will have to decide which settings override each other.  For example, if you specify both the --twitter-oauth-key command line flag and the GG_TWITTER_OAUTH_KEY environment variable, but with different values, which one takes precedence?

Basically, I do not agree to provide multiple ways to specify a same setting.
Each way (env vars, config files, command line args) has its pros. and cons.
It's important to use them properly for good end user UX.
For example, config files can treat arrays, so some complicated settings should be specified by config files, but they have defeats of hardness to inform their place to the daemon program.
Let's check how some reverse proxy apps do that.

It makes sense.

The best course of action for us may be to wait for an enterprising developer on Github to send us a PR implementing this!
Cool!


Class Cast Exception with Decision Node and Case value

I tried to edit a "line" to set the condition for a decision node, by clicking the one that is connected to the "case" endpoint of the icon, and the subsequent action. The properties were not editable. I then edited the XML directly, inserting the condition (a simple check for true, for example, ${var}) I needed. But now when trying to save the same workflow from the Oozie editor I get the following error:
An error has occurred. See error log for more details.
io.mashin.oep.model.connection.WorkflowConnection cannot be cast to io.mashin.oep.model.connection.WorkflowCaseConnection

Thanks for the report :+1:
Issue is now fixed on version 0.3.3 http://oep.mashin.io/version-history/version033


Use arrow keys or tab to traverse among the elements will break the scroll bar and container

Way to reproduce:

In the demo page, change all "items" from <div> to <button>.
focus on item 1.
press "tab" to traverse among items, and stop at item 8.

How it looks:

@souhe Please feel free to let me know if any other information needed. 😸


Raise authentication exception when authentication fails

First, thanks for making this package! I'm trying to see if I can use it for building a Home Assistant integration. But for that I need a way to check if authentication failed, therefore this PR.
It adds an authentication check to PicnicApiSession.login() and PicnicAPI._get()/PicnicAPI._post() and raises an exception if authentication failed.
I've also added a test, but they're written in an unusual way as they are doing actual requests to the Picnic API. Are they not meant as unit tests? As far as I've seen it's then more common to mock e.g. the Session class.
Let me know if anything needs changing!

I guess the checks are failing because secrets.PICNIC_COUNTRY_CODE is not set?

Hi,
Glad you are enjoying the wrapper and thanks for the work! The secrets should all be set, but I'll look into that tomorrow.
I agree with you that the unit tests are not optimal, but is was a quick solution, and I am also really interested for when the API fails. This tells me that picnic has updated their API (I run the tests periodically).
If you are working on an integration for HA, please have a look at https://github.com/MikeBrink/home-assistant-picnic. If you want I can add you as a collaborator, since I do not yet have the time to sink the time into it that is needed. Wrapping up my masters research at the moment.

Hi,
I've looked into it today, but all secrets are set and spelled correctly. I tried to reproduce the error locally with act, but had no success. Do you have any ideas? The only thing I can think of is that the PR is dependent on your secrets being set? Would be a clumsy implementation I'd think, but I can't come up with another reason. I am eager to hear your ideas on this and will wait with merging.

Hi Mike,
I'll have a look if I can find the culprit, but it can take a few days though!
And I only found out about your custom Picnic component after I was well underway, and I've also added a config flow e.g., which is now the preferred way for HA to set-up integrations, so I'll continue working on that as well and make a PR for HA core when it's stable.

I could reproduce the test error locally by setting the country code constant to an empty string. I guess it has to be related to how the .env file is created or how the secrets are loaded.
To fix things I've done the following:

Moved the existing tests to another directory integration_tests. Essentially tests that do real requests are not unit tests because the unit-under-test is not isolated, but are integration tests because they test de integration between client/api. One can still run them manually, but as the API is versioned it should not change (then also the Picnic app breaks).
Added new tests to the tests directory that don't do real requests, but use mocks for the Session. They only test the behaviour of the methods in this repo.
Added 2 extra API endpoints to get the delivery position/scenario, these gives information when the delivery is in progress about where the delivery truck is, who the driver is and an ETA with smaller window (20m).

Let me know what you think!

Thanks a lot Mike!
FYI, I've made a Picnic integration PR for HA core: https://github.com/home-assistant/core/pull/47507

Hi,
No thank you for your contribution! I'll update my repo for my HA integration + the forum post to point to yours. I didn't have the time to maintain and update it sadly.


Mark for death (Assassins Dedication)

In GitLab by @AGulyaev12 on Jun 3, 2022, 01:24
The action right now has only the description but neither the GM nor a player can drag'n'drop the effect onto a target. does the effect actauly exists and work ?

Presently this is the same as hunted shot. We can't use an effect that needs to know who two actors are. We could, similar to hunted shot, create toggles.


Update azure-app-apis.md

@jasongroce : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Feature Request: Increase Volume Control Steps

It would be great to add the possibility to change the volume control steps.
What I mean by this is, fine tuning the percentage points that each button press of the volume control raises or lowers the volume.
In the following image you can see that the media slider has 15 steps, meaning that each volume control step translates roughly to a 6.67 % volume increase or decrease. My Google Pixel 3 has 25 steps (4 % increase/decrease). It would be amazing, if I would have the option to change this to e.g., 50 or 100 which translates to 2 % and 1% respectively.
This would allow for a much more fine tuned audio volume control, especially on devices where this is severely limited to 25 steps or less.

shoul be the option increase or decrease !

Dear Stas,
It would be very nice if the plus and minus buttons of the Android notification widget could be lowered or raised one by one.  The jump by two is too big when listening to music.


No support for command line arguments

The current script doesn't support command line arguments or default values.

Now supports custom image stores and local connection endpoints


Error: ETag does not match MD5 checksum

Getting above error while downloading file from Leofs S3 bucket using this method.

aws-sdk version: 2.246.0

It download some chunks of data correctly and then truncates the file.
I am seeing this problem frequently.

+1


Do not use the deprecated field name for VPC

See: https://registry.terraform.io/providers/aliyun/alicloud/latest/docs/resources/vpc#vpc_name

Duplicate of #33


tests: convert to TS

Convert tests to Typescript. Update CI workflow to install types/mocha package used by tests.

Hi @webwarrior-ws can you add a lightning invoice with an amount of 100000 sats as a comment on this PR? thanks for your contribution

lnbc1m1pnnxwxnpp5rml03nlyrxgyv0gh8agl424ne2f8y7awcvysln6fkvxlxj8578kqdqhfdexz6m9dcsygetsdaekjaqcqzysxqrrsssp5ux3gl8eqc0ytlu4kf49kjjjplmn9vh3hmtt5aqqdkhn4dwatznqq9qyyssqnwnf3g2p39ae3l35wkunw09vpldw06e2vc6knmy8drnjlmrh0pjsas3nuzvuty55t6seh00wevkzw875d3xy7gwy5cxmj2sywv8aurqpl30kkl

lnbc1m1pnnxwxnpp5rml03nlyrxgyv0gh8agl424ne2f8y7awcvysln6fkvxlxj8578kqdqhfdexz6m9dcsygetsdaekjaqcqzysxqrrsssp5ux3gl8eqc0ytlu4kf49kjjjplmn9vh3hmtt5aqqdkhn4dwatznqq9qyyssqnwnf3g2p39ae3l35wkunw09vpldw06e2vc6knmy8drnjlmrh0pjsas3nuzvuty55t6seh00wevkzw875d3xy7gwy5cxmj2sywv8aurqpl30kkl

invoice expired. Valid until 2024-11-12 12:15:31 +0000 UTC

My first invoice was from Phoenix, my second was from Kraken. Would a “reusable QR code” (as named by Phoenix wallet) work? If yes, here it is:
lno1zrxq8pjw7qjlm68mtp7e3yvxee4y5xrgjhhyf2fxhlphpckrvevh50u0q2wakhvmc6crh3me6a0tfqdefplqq9pk6rkny7crhhgswyc6ve326qsrkmcq89hxyj3yf5c8u9a3rp2hact2yu5sne6aylet5k7ah5wgd29qqve2fwtuh8fcj89c83alr6sqllr9kqlf6n7axz3yfqzw0fux8dgmqqgdyc2l2fq5flanc2mkamlqds0j8mrxqw5ydeef37mqvt9fqgkj34mysyd7xdcvzc7make4ljvn5kak0wglqqqs2cqqznh6tdgkky3gndl8v2772y

My first invoice was from Phoenix, my second was from Kraken. Would a “reusable QR code” (as named by Phoenix wallet) work? If yes, here it is:
lno1zrxq8pjw7qjlm68mtp7e3yvxee4y5xrgjhhyf2fxhlphpckrvevh50u0q2wakhvmc6crh3me6a0tfqdefplqq9pk6rkny7crhhgswyc6ve326qsrkmcq89hxyj3yf5c8u9a3rp2hact2yu5sne6aylet5k7ah5wgd29qqve2fwtuh8fcj89c83alr6sqllr9kqlf6n7axz3yfqzw0fux8dgmqqgdyc2l2fq5flanc2mkamlqds0j8mrxqw5ydeef37mqvt9fqgkj34mysyd7xdcvzc7make4ljvn5kak0wglqqqs2cqqznh6tdgkky3gndl8v2772y

Paid!


⚠ Bofrost.at has degraded performance

In 874ea12, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1425 ms

Resolved: Bofrost.at performance has improved in 52b5bf3 after 13 minutes.


[Event Request] Codeunit 1000 "Job Calculate WIP" - Add  an event with handled parameter in InsertWIPGL procedure

Hi Team ,
In Codeunit 1000 , we need to post the GL line separately in the procedure InsertWIPGL ,one line with Account and other with balancing account assigned . we need to do this because we need to assign different dimension for Account and Balancing account lines. Also need to have "JobWIPGLEntry" parameter passed into procedure InsertWIPGL so that we can get some values related to job in this procedure.
local procedure InsertWIPGL(AccNo: Code[20]; BalAccNo: Code[20]; JnlPostingDate: Date; JnlDocNo: Code[20]; SourceCode: Code[10]; GLAmount: Decimal; JnlDescription: Text[100]; JobNo: Code[20]; JobWIPGLEntryDimSetID: Integer; JobWIPGLEntry :Record "Job WIP G/L Entry")
var Handled : Boolean;
begin
OnBeforeInsertWIPGL(AccNo, BalAccNo, JnlPostingDate, JnlDocNo, SourceCode, GLAmount, JnlDescription, JobNo,
JobWIPGLEntryDimSetID , Handled , JobWIPGLEntry)
if Handled then
exit;
end
[IntegrationEvent(false, false)]
local procedure OnBeforeInsertWIPGL(AccNo: Code[20]; BalAccNo: Code[20]; JnlPostingDate: Date; JnlDocNo: Code[20]; SourceCode: Code[10]; GLAmount: Decimal; JnlDescription: Text[100]; JobNo: Code[20]; JobWIPGLEntryDimSetID: Integer ; var Handled: Boolean ; JobWIPGLEntry :Record "Job WIP G/L Entry")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10804.


Hash Type change

Is there a way to change the default hash type for FileHash property to MD5?

The filehash is a property attached to the "Alphaleonis.Win32.Filesystem.FileInfo" type so if you want to change it you can. You would need to modify the file: "TypeData\PSAlphaFS.Types.ps1xml"  -- change:
[Alphaleonis.Win32.Security.HashType]::SHA256
to
[Alphaleonis.Win32.Security.HashType]::MD5
for more info see the link: http://alphafs.alphaleonis.com/doc/2.1/api/html/2338F1FF.htm

That works, thank you!


BaseGame Script Review

Just listing off some issues I encounter when converting scripts to C#:
Core_GameObjects module does not exist.
https://github.com/GarageGames/Torque3D/blob/development/Templates/BaseGame/game/core/Core.cs#L27
PrefPath logic exists twice
https://github.com/GarageGames/Torque3D/blob/development/Templates/BaseGame/game/core/Core.cs#L30-L34
And:
https://github.com/GarageGames/Torque3D/blob/development/Templates/BaseGame/game/main.cs.in#L34-L39
OnExit should not be a part of the Core Module, rather main.cs or similar root-level script should destroy the Core Module on exit
https://github.com/GarageGames/Torque3D/blob/development/Templates/BaseGame/game/core/Core.cs#L81-L87
I know this one is a bit subjective, but I think it's confusing to have CoreModule's clean-up logic in the root-level "OnExit" function.
Should TerrainBlendShader prefix samplerNames with $?, it seems to be prefixed everywhere else.
https://github.com/GarageGames/Torque3D/blob/development/Templates/BaseGame/game/core/rendering/scripts/gfxData/terrainBlock.cs#L32-L33
I'll add to this as I find more

should note with the new stuff, theres a callonmodule method triggering a cascade of callbacks for a couple of those cases

There are few copy-pastas in SpectatorGameplay where it references elements from "FPSGameplay" module.
https://github.com/GarageGames/Torque3D/blob/development/Templates/Modules/spectatorGameplay/scripts/gui/playGui.cs#L40
https://github.com/GarageGames/Torque3D/blob/development/Templates/Modules/spectatorGameplay/scripts/server/VolumetricFog.cs#L80
null_color_ramp is missing in spectatorGameplay
https://github.com/GarageGames/Torque3D/blob/development/Templates/Modules/spectatorGameplay/levels/Empty_Room.postfxpreset.cs#L1


Similar operations with different produced ContentType are not handled correctly

Here's a valid SpringMVC code:
@RequestMapping("/multiple-produced-content-types")
public class MultipleProducedContentTypes {

	@GetMapping(path = "/", produces = MediaType.APPLICATION_JSON_VALUE)
	public String json() {
		return "json";
	}

	@GetMapping(path = "/", produces = MediaType.TEXT_XML_VALUE)
	public String xml() {
		return "xml";
	}
}

It currently results with the following blocking error:

More than one operation mapped on GET : /multiple-produced-content-types/ in tag MultipleProducedContentTypes

See related SpringDoc issue

@kbuntrock : If you have some guidance here on how to resolve this. I'm not sure if it should be better for "merge" endpoints in SpringMvcReader, or if this should rather be handled in YamlWriter.

My initial feeling would be to put it in the SpringMvcReader. I would find it more logical. But I don't have the full picture right now. 😋


Add whereabouts-cleaner.sh script

Hi,
Hereby I share my Whereabouts cleaner implementation. I know that reconciler command is being developed to address the stale IP reservations (first feature below). But this script handles the IP duplication issue as well (second feature below). Maybe this script is useful until the go implementation (reconciler) covers all the problematic cases we have in field deployments.
Features:

It detects if a reserved IP is not used by the referenced Pod anymore. In this case the IP is released. Special StatefulSet Pod case is handled (same Pod name with different IP).
It detects if Whereabouts served the same IP to multiple Pods (due to missing K8s locking implementation). It deletes all the non-referenced Pods using the same IP address. The restarted Pods will get new IPs from the pool.

Usage: Let it run continuously in an un-attended terminal (ideally in a Pod dedicated for this purpose).
Pre-requisites:

Recent Whereabouts version, which contains the #86 patch
kubectl with permissions to query/manage Pods and IPPool CRD
Python 2/3 with ipaddress module
bash & jq

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 40.866%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
434

Relevant Lines:
1062

💛  - Coveralls

Does this PR still make sense, now that the reconciler can be deployed as a cronjob ?
Do you find anything missing from it ? If so, we can collaborate and add it there.

While we're currently deploying the reconciler on a cronjob - that indeed does have the limitation you meantion - there is an ongoing discussion about introducing a controller for whereabouts. If that is accepted, the reconciler functionality will eventually be moved there.

But that is not ready at the moment, while the latest Whereabouts release can serve duplicate IPs, so I need a quick solution now to be able to operate big clusters.

Plus, I also see negative impacts in running the reconcile loop too often in large clusters - actually, even once every minute seems too much to me.

What are those negative impacts? Can you please elaborate more?
I prefer to run frequent reconcile cycles to be able to fix the problems during a helm chart deployment, so helm won't timeout due to bad Pod states (caused by duplicate IPs or exhausted pools/ranges).

Lastly, do you think you can reconcile all the whereabouts IPs on a large cluster under 10 seconds ? IMO, that is too ambitious, and puts a lot of pressure the kubernetes API.

My implementation does not contain any parallelization/threading. Once a reconcile task is done (taking the time as much as it is needed to complete), there's a 10 sec sleep before the next reconcile task is started.
In large clusters we have dedicated master nodes, their cpu consumption is not an issue.

This is replaced by the reconciler / reconciliation control loop.


makeBinaryWrapper: remove cc dependency on aarch64-darwin

Description of changes
This intends to address https://github.com/NixOS/nixpkgs/issues/172249 on aarch64-darwin (which was reverted in https://github.com/NixOS/nixpkgs/pull/174038). I think it should be possible now that https://github.com/NixOS/nixpkgs/pull/238323 is committed.
I am still building and testing this locally.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I was able to build luarocks with this change on staging.
@ncfavier would you be a good person to review this change?

@ofborg build makeBinaryWrapper

Thank you for kicking off those builds. I'll change the commit message to makeBinaryWrapper after seeing the results.

Looking good!

Interesting! From ofborg:
error: builder for '/nix/store/wbw4m0379blgpwy4jzvmylzzg80nhvvh-make-binary-wrapper-test-cross.drv' failed with exit code 1;
       last 1 log lines:
       > expected x86_64, got Advanced Micro Devices X86-64
       For full logs, run 'nix log /nix/store/wbw4m0379blgpwy4jzvmylzzg80nhvvh-make-binary-wrapper-test-cross.drv'.
error: 1 dependencies of derivation '/nix/store/3vh8nzn9y75bm8ij6056kb1b4xdhbgd3-make-binary-wrapper-tests.drv' failed to build

That failure also occurs on master. Something to be looked at separately, but worth doing.
@ofborg build makeBinaryWrapper makeBinaryWrapper.tests


Fix markdown syntax in README

Thanks, @lovasoa ! Merged! What a helpful catch. I really appreciate it.


includeInApi set to false still shows in API Swagger

When I use includeInApi = false on a field, it still appears in the API Swagger.
Here is the entity.
@Entity('organizations', {
  allowApiCrud: true,
  allowApiDelete: false,
})
export class Organization extends IdEntity {
  @Fields.string()
  organization_type!: string;

  @Fields.string()
  organization_name!: string;

  @Fields.createdAt({ includeInApi: false, allowApiUpdate: false })
  date_created = new Date();

  @Fields.updatedAt({ includeInApi: false, allowApiUpdate: false })
  date_updated = new Date();

  @Fields.string({ includeInApi: false, allowApiUpdate: false })
  user_created = '';

  @Fields.string({ includeInApi: false, allowApiUpdate: false })
  user_updated = '';

  @Fields.object<Organization>((options, remult) => {
    options.serverExpression = async (org) =>
      remult
        .repo(OrganizationAlias)
        .find({ where: { organization_id: org.id } });
  })
  organizationAliases: OrganizationAlias[] = [];
}

Here is the schema in Swagger.

Please fix this where it does not appear in the Swagger doc.

@Brock-Homee
I've fixed it for release v0.20.3
Can you please check it out?
It'll behave as follows:
When allowApiUpdate is set to false, the field will only show on the response types.
When includeInApi is set to false it'll not show at all - note that when you set includeInApi to false, there is no need to set the allowApiUpdate to false.
If they are set to a role or an arrow function, the open doc will include them - but of course, the role and the arrow function will be enforced when executed

Thank you for the quick turnaround.  I got the update and it fixed the issue.  I am closing this issue now.


location in setting is disabled

Describe your environment

React-Native version : 0.55.4
Platform: iOS, Android, both? both
Device (which one?), simulator? simulator "iphone x"
OS version : Mac Os
react-native-permissions version : "^1.1.1"
Devtools: Xcode? Android Studio version? :visual studio code
(Android only: buildToolsVersion)
in PodFile : platform :ios, '9.0'

How to repeat issue and example
componentDidMount = () => {
		Permissions.check('location').then(response => {
			// Response is one of: 'authorized', 'denied', 'restricted', or 'undetermined'
			this.setState({photoPermission: response});
			this._alertForPhotosPermission();
		});
	};
	_requestPermission = () => {
		Permissions.check('location', {type: 'always'}).then(response => {
		 	this.setState({locationPermission: response});
		});
	};

	_alertForPhotosPermission = () => {
		Alert.alert(
			'Can we access your location?',
			'We need access so you can use onthemonve app',
			[
				{
					text: 'No way',
					onPress: () => console.log('Permission denied'),
					style: 'cancel',
				},
				this.state.photoPermission == 'undetermined'
					? {text: 'OK', onPress: this._requestPermission}
					: {text: 'Open Settings', onPress: Permissions.openSettings},
			]
		);
	};

Location section is disabled ?
What should be
how to enable it ? so that user can change it

after clicking on back settings then goin navigation


Replace Dependabot Preview with Dependabot

In theory it shuts down the 3rd of August 2021
https://github.blog/2021-04-29-goodbye-dependabot-preview-hello-dependabot/

I've merged #366 so this should be resolved.


Setup the Analytics and the user consent in the Android documentation

Description
As a User of the dev documentation
I want be asked if I consent to share the information of my usage of the site
So that I can decide to accept or refure to contribute to the data analytics gathering
As a Product Owner of the Design System
I want to view the dev documentation usage
So that I can drill down all the plateform specific usage
Requirement

The current Analytics tag used in the ODS documentation should be used in this dev documentation as well
The current consent request used in ODS setup should be used in this dev documentation as well

This issue will be treated in the #9 Create the basics of a documentation. I copy/paste the requirements inside.

is this available for test yet?


Fix visualization of path points in the change to sets

@aymanhab raised this in the sprint review.

I believe this has been fixed by my commit to revert PathPointSet to a Set of Objects


Cpp encoder test

Added cpp function to encode grid objects
Added js test to ensure js encode and cpp encode work the same

@apendleton Updated incorrect comments, added a couple more comments, and fixed formatting.

Actually wait, looks like there are merge conflicts. This is a PR to merge from the cpp_encoder_test branch into the setgrid branch, so if there have been changes on both sides to the same part of the file those will need to be resolved before it will let you merge.

👋 @fredngeorge @apendleton - I noticed the latest build for this branch failed at https://travis-ci.org/mapbox/carmen-cache/jobs/250553074#L537-L551. I wanted to flag, in case it is not obvious, that those failures are unrelated to your changes. They are happening because I recently changed the coalesce.bench.test.js to run even for debug builds in https://github.com/mapbox/carmen-cache/commit/b5b2564e40ed008a820fbf7cb817250d0336a6c3. And it looks like the thresholds I set for how long the tests are expected to take need to be increased for Debug builds. Btw, the motivation for changing the benchmark so that it would run, even in debug mode, was that the benchmarks offered a good stress test of the code. And I wanted to ensure that they did not crash or otherwise behave incorrectly in debug mode. I would recommend bumping up the expected_ops 2x for debug modes - that should ensure they pass and don't distract again from your work.


Integration Test - Release - 2019/02/13 19:05:15

Auto create for integration test. IssueCommandFlow

@adunndevster : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


Dispatch a Snackbar from a Redux Thunk

To fully replace the toastr in existing projects that prominently rely on Redux Thunks for CRUD operations we need the ability to dispatch a Snackbar from a Thunk.
I haven't done any discovery yet but the ideal solution would be custom Redux Middleware for this.

Long day....Snackbar lives in the bitbucket SSC repo....closing this issue as it's not relevant to SQForm.


[Feature] Make the head service headless

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
https://github.com/ray-project/ray/pull/33030#pullrequestreview-1330044213
https://github.com/kubernetes-sigs/kind/issues/3118
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Other use case: Istio
https://ray-distributed.slack.com/archives/C02GFQ82JPM/p1679595828577909?thread_ts=1678309468.145329&cid=C02GFQ82JPM

@kevin85421 is this solved now, such that we can continue with istio and ray on kubeflow?

Other use case: https://ray-distributed.slack.com/archives/C02GFQ82JPM/p1712780988188599?thread_ts=1712333199.632539&cid=C02GFQ82JPM

@rueian will take this issue.

Closed by https://github.com/ray-project/kuberay/pull/2117


completed tasks?

Hi!
This thing is actually brilliant and I really appreciate it.  I want completed tasks too tho.
Is it hard or easy to add this?  Not sure what the API is like yet. Happy to work on helping you do it if I can.
Thanks tho, this gadget saved my @ss.

I'm using the Sync API v5.3, which returns all data with one call. It doesn't return completed tasks, though.
The current API v6 was simplified and now it's obviously possible to get all completed tasks without traversing the projects. I will look into this.

Thanks for your response!  I ended up learning the API and building myself something on PHP to pull the whole lot out.  It's not too complex but it did take a bit of time to de-cypher the whole thing.
What I found most intriguing is that sub-projects actually don't have parents, they are simply indented. This somewhat reduces the usefulness of todoist for me. I'm not sure if the next version of todoist will address this.

After API v5.3 was discontinued, I've updated the app to API v7 and added support for completed tasks. It's for JSON only, though, since the data for active and completed tasks differs and the CSV parser doesn't like that.


File datatype do not support OPEN,CREATEINSTREAM functions

I am trying to use a Variable with datatype File, when I am using this variable to Open a file from a specific location AL is throwing an error :
"message" : The type or method 'Open' cannot be used for 'Extension' development.
Code snippet :
Var
DataFile : File;
begin
DataFile.Open();
end;
Note : same is happening with DataFile.CREATEINSTREAM and ourstream functions as well.

Hi @rishiaurrishabh ! Are you developing for the Cloud or for OnPrem? Those methods cannot be used in extensions. This has been asked a couple of times: https://github.com/Microsoft/AL/search?q=cannot+be+used+for+'Extension'+development.&type=Issues . Please check the existing issues before opening a new one.


NextJs APP router instantsearch hooks rendering problem

🐛 Current behavior
Using the experimental InstantSearchNext, I sometimes seem to get weird behaviour during rendering. In which not all of the content is directly rendered from the server, you will always see a flash of no content, followed by the hits rendering and then the refinements rendering, which gives a lot of CLS.
There is a codesandbox setup below, which reproduces the issue.
Video as proof of result:
https://github.com/algolia/instantsearch/assets/38532331/31dfcc65-1040-4c7a-ad32-e3408f55947d
🔍 Steps to reproduce

Go to the live codesandbox example
Press a brand page
Go back
Press another brand page
Notice that the layout is jumping around and not everyting is rendered correctly at the same time.

Live reproduction
https://codesandbox.io/p/sandbox/dank-hooks-t4w5d8
💭 Expected behavior
All content is SSR'd correctly.
Package version
"react-instantsearch": "^7.2.0",   "react-instantsearch-nextjs": "^0.1.2",

Operating system
No response
Browser
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I can confirm a similar behavior when refining the results. For me, it almost always jumps back to default unrefined results. Is that the same for you? My searchClient is properly defined outside the component.
Using the react-instantsearch-router-nextjs like so:
<InstantSearch
      searchClient={searchClient}
      indexName={index}
      insights={false}
      future={{
        preserveSharedStateOnUnmount: true,
      }}
      routing={{
        router: createInstantSearchRouterNext({ singletonRouter }),
      }}
    >
      <SearchView />
</InstantSearch>

I'm facing the same problem, using hooks and components that depend on the context, eg: auto-complete-core, useSearchBox, useDynamicWidgets etc.

I have solved the initial loading issues/flickering, using "VirtualWidgets", for the dynamicWidgets. But I don't know if this has any downsides looking at requests, since I'm instantiating a virtual widget and a real widget for the refinementlits and dynamicwidgets.

@wesleyjanse this approach doesn't have any downside(I think), do you have a sandbox with your solution?

I need to free up some time for it, pretty stacked for now on work..
But i just created some virtual widgets, that use the hooks and return null.
And then imported those in the HOC. Seems to solve these issues for me.

Hi @wesleyjanse,
When you are navigating, the rendering is done client-side, you can check in the network tab it does not request documents and no HTML is received from the server.
This is normal for CSR to flicker as queries are being made, React InstantSearch's default example does it
We would need to see with Next.js if it's possible to force server-side rendering on navigation, or perhaps for a way to transition only when requests are done

Hi @aymeric-giraudet you're right, this is expected behavior in CSR environment, but not in SSR(is my case), right?

Solved this by just searching once in the server:
    const initialSearchResult = await helper.searchOnce({
      // stuff
    });
   <Component initialSearchResult={JSON.parse(JSON.stringify(initialSearchResult.content))} /> // JSON.parse(JSON.stringify()) so it works with passing the object from server -> client components

and using it as follows:
  const { results: r } = useHits<AlgoliaHit>();
  const results =
    typeof window !== 'undefined'
      ? r
      : initialSearchResult;

But is this really ideal?

Seems like this issue is still open and I'm having the same problem so might as well:
Using<EMAIL_ADDRESS>Issue: Delayed rendering with client side navigation. As an example navigating from Home -> Search, Algolia does not seem to have any results yet for a bit of time, but going directly to Search has results immediately, so this seems to only happen through client side navigation
Repo: https://github.com/fcasibu/algolia-test
Is this a known problem with the app router? Is there a way to fix this because ideally we want immediate results after navigation. (Using a tag for hard navigation instead of Link is not an option)
Solved this by just searching once in the server:
    const initialSearchResult = await helper.searchOnce({
      // stuff
    });
   <Component initialSearchResult={JSON.parse(JSON.stringify(initialSearchResult.content))} /> // JSON.parse(JSON.stringify()) so it works with passing the object from server -> client components

and using it as follows:
  const { results: r } = useHits();
  const results =
    r.hits.length // not really ideal of a condition
      ? r
      : initialSearchResult;

But is this really ideal?
I missed this reply:

Hi @wesleyjanse,
When you are navigating, the rendering is done client-side, you can check in the network tab it does not request documents and no HTML is received from the server. This is normal for CSR to flicker as queries are being made, React InstantSearch's default example does it
We would need to see with Next.js if it's possible to force server-side rendering on navigation, or perhaps for a way to transition only when requests are done

Do you perhaps have any updates on this? @aymeric-giraudet

#6275 may have resolved this, what do you think @aymeric-giraudet?

Latest changes made it worse for me where it does not even render in the server anymore 😓

@fcasibu
Sorry about this, may I get a reproduction to see what goes wrong ?
Regarding the CSR issue, I've seen your solution and while this works if you know params ahead of time, we can't integrate this into the library as there is no way to infer query params from the React tree in a server component.
On our end we have to make use work on the browser, meaning a big overhaul on how we instantiate promises, React core team has started documenting a bit more about how to do that but we won't be able to ship a proper solution until React 19 ships.

Thanks for the fast response @aymeric-giraudet I'll try to create a reproducible example when I get some time.

guys, any news?


Prefer SaveFields(record, params[] expressions) over many overloads.

Can make calls like SaveFields(record, (r) => r.Property1, (r) => r.Property2, (r) => r.Property3);

Thank you @Monsoonexe  for the update!
Additional feature updates are all welcome with this repo :)

Thanks, Steve. I'll be using this a lot and will forward any more features
as they come up.
Thank you for accepting my first pull request.
On Tue, Jan 18, 2022 at 6:07 PM Steve Winward @.***>
wrote:

Thank you @Monsoonexe https://github.com/Monsoonexe for the update!
Additional feature updates are all welcome with this repo :)
—
Reply to this email directly, view it on GitHub
https://github.com/SteveWinward/GoogleSheetsWrapper/pull/7#issuecomment-1016009147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKNKVBJGSEEVZ2RSIYL5STTUWYMGTANCNFSM5MIVUB2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Awesome.  I just pushed an updated version (1.0.29) and its now available on nuget :)
https://www.nuget.org/packages/GoogleSheetsWrapper/
Thank you again for your contributions!


ui-fixes

Ready to merge?

Fixes #10887.

i want add other ticket @xavijam

@hacheka could you take a look?
Fix - https://github.com/CartoDB/cartodb/issues/10887
Fix - https://github.com/CartoDB/cartodb/issues/10849 sorry @jorgesancha !!!!
Fix - https://github.com/CartoDB/cartodb/issues/10870 cc @alonsogarciapablo


webview not expanded to fill group on window resize

Issue Type: Bug
Repo

On mac
With a window that does not fill screen
Open a md file in the editor
Open preview to side
No double clicke title bar to expand VS Code window to fill screen

Bug
Markdown preview does not expand to fill editor group

VS Code version: Code - Insiders 1.38.0-insider (20dd80d91a76cbe80fb1d1979c3a9f02d94ba161, 2019-08-29T14:02:52.867Z)
OS version: Darwin x64 18.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 3

Memory (System)
16.00GB (0.20GB free)

Process Argv
-psn_0_9410809

Screen Reader
no

VM
22%

Does not seem related to experimental grid layout. Repos with it on and with it off

Seems that something has changed with when layout is called: https://github.com/microsoft/vscode/blob/79e52cb3e4818c58147ff7d324af63c8be0462e5/src/vs/workbench/contrib/webview/browser/webviewEditor.ts#L91
Before,  layout was called when the parent element of the editor was already the correct size. Now layout is called before the parent element is the correct size


Remove-CertificateEnrollmentPolicyServer examples fixes

removed extra white space (lines) which makes the code sample unnecessarily long

Docs Build status updates of commit d27664a:
:clock10: Pending: waiting for processors (13 builds ahead of you)
:warning: Docs Build is busy, currently there are 13 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit d27664a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/pkiclient/Remove-CertificateEnrollmentPolicyServer.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

close and reopen to fix prob

Docs Build status updates of commit d27664a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/pkiclient/Remove-CertificateEnrollmentPolicyServer.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


bundle config set path not work for gems

@runphp reported this issue to me and he keenly found the cause.
If we run bundle config set --local path 'vendor/bundle'，then all gems will be installed into ./vendor/bundle.
Then if we call bundle exec jekyll, the jekyll.bat inside the .\vendor\bundle\ruby\3.2.0\bin will be invoked. However, the bat files writes:
@ECHO OFF
@ruby.exe "%~dpn0" %*

Here the fake ruby.exe got invoked, so the gem binary will not work.

Fixed. @runphp


GetSection and AsEnumerable problem

I have a config structure that imports config of other components as children.
In the code, the outer component uses GetSection to pull out each child configuration and passes to the child. If child uses the keys directly, everything is fine. If child uses AsEnumerable, then the full part from the root shows up in the key, which the child is not expecting.
Configuration:
{
  "A": { "a": 1},
  "B": { "b": 1}
}

When using keys directly:
config.GetSection("A")["a"] => 1
When enumerating:
config.GetSection("A").AsEnumerable().First().Key => "A:a" // Should be only "a"

I believe this is by design. cc @HaoK @divega

Yeah it is, AsEnumberal returns the path of each node as the key, which is the full path from the root.
See:
https://github.com/aspnet/Configuration/blob/dev/src/Microsoft.Extensions.Configuration.Abstractions/ConfigurationExtensions.cs#L39

Is there a recommended way then pass down a scoped section so child components using AsEnumerable can consume it unmodified?

You can iterate recursively via get children. AsEnumerable basically flattens the nodes into a single list.

Actually on second thought, we might change the behavior to strip out the current path from the results, tracking via https://github.com/aspnet/Configuration/issues/473

Makes sense. Here's the fragment I am using:
public static IConfiguration GetScopedSection(this IConfiguration config, string key) {
    var section = config.GetSection(key);
    var data = section.AsEnumerable()
        .Where(kv => kv.Key.Length > key.Length + 1)
        .Select(kv => new KeyValuePair<string, string>(kv.Key.Substring(key.Length + 1), kv.Value));
    return new ConfigurationBuilder().AddInMemoryCollection(data).Build();
}


Texts are visible now in the dark mode.

Description
Changed the text colour according to the dark/Light mode options .
Fixes:  #757
Type of change

[ x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ x] I have made this from my own
[ x] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK
BEFORE

AFTER

https://swapreads.vercel.app/#genre

@anuragverma108 Please add gssoc label 2 to this PR and accept it . Thank you.

Great contribution to GSSOC'24! 🎉

Thank you


ng serve error message does not indicate which file it is

Bug Report or Feature Request (mark with an x)
- [X ] bug report -> please search issues before submitting
- [ ] feature request

Area
- [X ] devkit
- [ ] schematics

Versions

yarn: 1.7.0
Angular CLI: 6.0.8
Node: 8.11.1
OS: win32 x64
Angular: 6.0.6
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic
... platform-server, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/cdk                      6.2.1
@angular/cli                      6.0.8
@angular/flex-layout              6.0.0-beta.16
@angular/material                 6.3.0
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
rxjs                              6.2.1
typescript                        2.7.2
webpack                           4.8.3

Repro steps
get a typo with *ngIf:

        parent: {{edit.parent}}

The log given by the failure

ng serve output:
ERROR in : Can't bind to 'ngI' since it isn't a known property of 'div'. ("

]*ngI='edit.parent'>
        parent: {{edit.parent}}

")
: Property binding ngI not used by any directive on an embedded template. Make sure that the property name is spelled correctly and all directives are listed in the<EMAIL_ADDRESS>("

      [ERROR ->]

        parent: {{edit.parent}}

")

well explained, but didn't tell me which file has the problem, let alone the line number.
Desired functionality

report error with file name and line number like what it usually does.
Mention any other details that might be useful

Moreover, after this error, ng will stall. It won't watch for source file changes, and won't recompile when files are changed. The only way to continue is to kill the process.'
I have witnessed several errors that can lead to this stall state, but I do not know the general condition for it to happen.


Default relabelling to (.*) and $1 ?

Relabelling has a lot of irreducible complexity due to the abundance of different configurations we must allow for, however I think there's some scope for making the syntax a little easier.
I propose that we default the regex to (.*) and the replacement to $1. The effect of this is that copies and setting static labels will both be much easier, both of which are very common uses.
- regex: .*
  replacement: staticvalue
  target_label: myLabel
- source_labels: [src]
  regex: (.*)
  replacement: $1
  target_label: myLabel

would become
- replacement: staticvalue
  target_label: myLabel
- source_labels: [src]
  target_label: myLabel

This is a small bit magic which may cause confusion, but overall I think it'd be a benefit.
@fabxc @beorn7 @juliusv

That's a good idea :+1:

:+1:

:+1:

Should the default regex actually be (.+) so at least something should be present?

Then the case for assigning a static value wouldn't work. No source labels are present, so the concatenated value is the empty string, .+ wouldn't mach, and the replacement would be skipped.
Did you see an issue with .* for any particular case?

Good point.
The problem was actually with Kubernetes discovery (of course ;)) where we relabel the metrics path from the service annotation, but this was setting empty path if there was no annotation. I'll update the config there instead.
Closing.


Removing SearchType and SearchOrder + Move to new date search behaviour

Improves #1371

Coverage increased (+0.02%) to 33.499% when pulling ebd56b22f7a81a9c8166550c448af2e2fafdc95e on pr/1371 into c49fba015cfdc03acc511d966062362e977238d1 on dev.


Fullscreen-Mode / Progressive Web App (PWA)

Is your feature request related to a problem? Please describe.
When exporting photobooth-app to home screen and open in Kiosk Mode (Testet iPadOS 17), the address bar is still visible.
So the Kiosk-Mode is pretty useless, since everyone could put in another link.
Describe the solution you'd like
Make app available as PWA, so the address bar is not visible.
Kiosk-Mode will then allow the photobooth-app to be the only usable tablet-function.
Describe alternatives you've considered
I tried fullscreen browser, but the url can be changes easily by the user.
Additional context
Maybe this is easy to integrate, since vite5 is used: https://github.com/vite-pwa/vite-plugin-pwa
Alternative: https://gist.github.com/irae/1042167
For old Apple Devices, adding this to the index.html would help (will try myself)
https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html#//apple_ref/doc/uid/TP40002051-CH3-SW2

Quasar has all it needs to build as PWA: https://quasar.dev/quasar-cli-vite/developing-pwa/introduction
But if it is not neccessary and just some html tags control the behaviour, that would be better, since there is no use of all the other PWA features.

Adding the meta tags as stated in the link worked:
https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html#//apple_ref/doc/uid/TP40002051-CH3-SW1
I did a pull request:
https://github.com/photobooth-app/photobooth-app/pull/223
This issue can be closed.

Feature implemented in https://github.com/photobooth-app/photobooth-frontend/commit/4853df864de4b955b80edf9304088372aaf50e21
Included in next release; release just now.


First parameter of galDivide is always 1

Hi, I was scrolling through the code and found that galDivide 1st param is always 1 (4 usages in code and 1 in tests).
https://github.com/klauspost/reedsolomon/blob/3db84f17c9add1f09b1a2bb397b1c624230fea24/galois.go#L873
This func doesn't look like a hot function, but maybe propagating a const might give a small benefit (smaller binary, caching, etc.). WDYT?
Thanks.

Good observation. It simplifies down to something like this:
// galOneOver is the same as galDivide(1, a).
func galOneOver(a byte) byte {
	if a == 0 {
		panic("Argument 'divisor' is 0")
	}
	logResult := logTable[a]
	if logResult != 0 {
		logResult ^= 255
	}
	return expTable[logResult]
}

If it was super-hot we could eliminate the if with another table, but it doesn't seem worth it.

but it doesn't seem worth it.

Feel free to close the issue, thanks.

@cristaloleg I am sending in a PR.. I was mainly saying "adding a separate table isn't worth it".

https://github.com/klauspost/reedsolomon/pull/254

I was mainly saying "adding a separate table isn't worth it".

Ah, my bad.

@cristaloleg Actually expTable[255] == expTable[0], so we don't need the "if".

Nice! By the way, logResult := logTable[a] ^ 255 looks like a new table to me.
logTable values are in [0, 255) range, so we can store the result of logTable[a] ^ 255 instead, wdyt? (if I'm not missing something)

The XOR is so fast that I don't really see any point in adding 256 bytes to binaries just for that.

#254 Merged


[GOBBLIN-1627] provide option to convert datanodes names

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1627

Description

[x] Here are some details about my PR, including screenshots (if applicable):
data node names may need some conversion, e.g. we may only have one node Node1, but it may be referred by multiple names Node1-dev, Node1-prod, so I am providing a config to supply a map for all this conversation.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
added a unit test

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3484 (8992bf0) into master (8c9c8a8) will decrease coverage by 3.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3484      +/-   ##
============================================
- Coverage     46.62%   43.38%   -3.24%
+ Complexity    10360     2030    -8330
============================================
  Files          2076      405    -1671
  Lines         81071    17408   -63663
  Branches       9049     2126    -6923
============================================
- Hits          37801     7553   -30248
+ Misses        39789     9020   -30769
+ Partials       3481      835    -2646

Impacted Files
Coverage Δ

.../java/org/apache/gobblin/cluster/SleepingTask.java
39.39% <0.00%> (-6.07%)
:arrow_down:

...in/java/org/apache/gobblin/cluster/HelixUtils.java
31.70% <0.00%> (-4.27%)
:arrow_down:

...dules/flowgraph/pathfinder/AbstractPathFinder.java

...qualitychecker/row/RowLevelPolicyCheckResults.java

...converter/string/KafkaRecordToStringConverter.java

...pache/gobblin/data/management/trash/MockTrash.java

...src/main/java/org/apache/gobblin/r2/R2Request.java

...bblin/data/management/copy/AllEqualComparator.java

...ache/gobblin/runtime/app/ApplicationException.java

.../gobblin/runtime/commit/FsCommitSequenceStore.java

... and 1664 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9c8a8...8992bf0. Read the comment docs.

Ah actually missed that comment.
Sometimes the flowgraph has old names of data node. e.g. LinkedIn's internal flowgraph has name griduse, but the correct name used by Azkaban was gridmem1e. Both actually mean the same node. But if we change the node, it will break old customer's code, if we add a duplicate node, it will be a tech debt to slowly deprecate the old name. I made a client side change, where it would change the name, but @Will-Lo  suggested that it would be better if we make changes on server side, because change here will be applicable to all kinds of clients and deployment will be a less step process.


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

This change is

Coverage remained the same at 80.101% when pulling b1fe63e463f6fadd16c344d753ec3c19ae9cacd6 on analysis-5Zjn5B into 150ef9dcf5f658c3e1c0220e1606e81123657aaa on master.


Implement generic AddressRegistry event listener

Copy AddressRegistry abi from https://github.com/gnosis/olympia-token
Make ethreum ADDRESS_LENGHT a constant for models (40)
Add optional mainnet_address to TournamentParticipant
Remove factory from TournamentParticipant
Rename TournamentParticipantSerializer -> UportTournamentParticipantSerializer
Create GenericIdentityManagerReceiver
Don't allow same registrant twice
Add environment variable GENERIC_IDENTITY_MANAGER_ADDRESS
Fix serializers
Add tests

Coverage increased (+0.2%) to 86.58% when pulling 0d9daf5992fc741d0b3fa73b12837a3e496c1e1c on feature/PM-515-Registration-Contract-Events into e29f24b7efab0f46ad819c03d9886465bab8daa6 on develop.


Email and password login issues

I'm trying to get comments from one public page for academic purposes and it's saying that my password and email login is invalid, but when I try to log in via on fb's page it's all fine. How can I handle with this situation?

I had an issue with my email and password rejected. I removed a '!' from my password, after which it only contained numbers and letters. Now it works.


Design update for deployment screen

Editing a deployment is confusing since there are three levels of entity -> Deployment, Pod and Container - the UI does not allow labels and annotations at the deployment level to be changed and is confusing to understand which entity the side tabs refer to.
We need to look to redesign the UX for deployments.
Also, we render controls in a view mode for non-edit case and these aren't great - we use a disabled presentation and we sometimes show buttons (e.g. Remove) which relate to the edit case, so should not be shown.

This will help fix what we're seeing with fields appearing in places that we could find more easily.

this is the doc that I will be updating: https://xd.adobe.com/view/3a0ff278-5d42-4f38-82fe-647fe3472cc7-6f5c/

@nwmac @lvuch Given that this is still at the design review stage this isn't going to be completed for 2.6.3. There is a growing count in the community that are interested in an improved workload view, it would be good to get this in to 2.6.4?

I'm OK to push this out to 2.6.4, especially since QA already has a lot on their plate for 2.6.3 testing. I'll defer to @nwmac since he's the main driver for this workflow improvement.

What's the status of this issue? It's assigned to Team 3, but it looks like a UI issue. I'm confused.

It is a design issue / I've. P idea why it's been assigned to tram 3 to review

@lvuch will provided a wireframe


fixes FF installation on linux

closes #6
tested on Ubuntu 18.04

I was following the example in the first answer here: https://unix.stackexchange.com/questions/11018/how-to-choose-directory-name-during-untarring which says:

-C changes to the specified directory before unpacking (or packing). --strip-components removes the specified number of directories from the filenames stored in the archive.


? and % must be escaped when substring search is enabled

When the substring search mode is enabled, there is no result for the я? or я queries. They have to be escaped like я\? or я\

No. The reason is wrong: level=error msg="error while processing inline query: Bad Request: RESULTS_TOO_MUCH"

Nevertheless, let's implement the escaping, following the initial concept.


add compile/release target for m1

my work machine is an M1, and while I can easily compile this locally, it would be even nicer to have a release to download and use directly.
Awesome tool! 👏

Thank you! :heart:


Alternative of require

I would like to understand require in the samples like this... Is it RequireJS?
It creates trouble when we want to use Monaco Editor with angularJS, eg, here and there. Isn't it possible to just load everything in any case rather than using require?

We are using inhouse amd loader and you can use requirejs to load monaco as well. Please details I put in https://github.com/Microsoft/monaco-editor/issues/534#issuecomment-321375985.


Feature Request: bash/zsh completion implemented inside App

As mentioned in https://github.com/remkop/picocli/issues/725, calling into the app can provide a lot richer completions.
I've implemented this myself in my own apps, but it's very specific code with caching, but with graal startup speeds it's probably possible to do a much simpler implementation.

Feel free to close, this is a suggestion, I don't have plans to actively work on this.

Can you expand a bit on the "inside App"?
One idea is to have a command that generates the completion script (https://github.com/remkop/picocli/issues/456).
Another idea is to let the Bash completion script call the app itself to get completion candidates (https://github.com/remkop/picocli/issues/506) - this requires the Bash completion script to be able to invoke the command, so path, classpath etc. needs to be set up correctly.
Is this what you have in mind?

#506 is exactly it. I think it’s a safe assumption if you can output as part of usage help a command name, that at completion time you can call that command and it should work. You can see how I do it for fish in the other issue I raised.


[WIP] Trying multiple jobs on travis to separate linting, unit-testing, and security checking

Work in progress, do not merge

Out of sync. Will cherry-pick the useful changes and open new PR


mtkennerly.madamiru version 0.1.0

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.9 schema?

Microsoft Reviewers: Open in CodeFlow

Hmm, the errors don't sound like anything related to my changes specifically:
##[error]1ES PT Error: Job 'ContentValidation' uses the release tasks ["AzureFunction@1","AzureFunction@1","AzureFunction@1"] but is not marked as a release job. Release tasks will soon be disallowed outside of release jobs. See [https://aka.***/1espt/custom-release-job](https://aka.%2A%2A%2A/1espt/custom-release-job)

I was expecting a runtime error if GStreamer wasn't available on the test system (missing DLL), but not sure what this is.

Manual Validation ended with:

2024-12-13 12:57:27.461 [FAIL] Installer failed security check. Url: https://github.com/mtkennerly/madamiru/releases/download/v0.1.0/madamiru-v0.1.0-win64.zip Result: 0x80004005 Property(S): ErrorDialog = ErrorDlg MSI (s) (B8:E8) [12:57:16:077]: Windows Installer installed the product. Product Name: GStreamer 1.0. Product Version: 1.24.10. Product Language: 1033. Manufacturer: GStreamer Project. Installation success or error status: 0.

(Automated response - build 904.)

@stephengillie Could you please advise how I can resolve the security check?
For what it's worth, Madamiru does get a clean report on VirusTotal: https://www.virustotal.com/gui/url/48658a8c56573aa8aee2bb98fdf26ab95d5f31c01608d7d75b6f1839cd9f247a

The security check didn't recur.
Is a dependency missing?

Yes, Madamiru depends on GStreamer ( https://gstreamer.freedesktop.org ), which the user is expected to install separately. I did specify the dependency in the manifest, but I think that's just for documentation purposes and not automatically installed, right? Is there any way to set up the test environment for this or bypass it?

The dependency is automatically checked, and installed if missing. The process of manually checking that field and installing was automated around I believe, the 1.5 release.
The dependency seems to depend on VCRedist:

So I added it as another dependency on this manifest, and it works now:

Issue created: https://github.com/microsoft/winget-pkgs/issues/199443

But there was no change in overall outcome.  It seems like the dependency isn't being found by the main application in my testing VMs. This might be unique to the VMs, so if
this isn't happening on other systems, then I'd be happy to merge it.
Verify while here:

It looks like the GStreamer installer doesn't automatically add C:\gstreamer\1.0\msvc_x86_64\bin to the PATH environment variable. If you add that, then it should find the DLLs.

Verify:

(With the workaround described above of manually adding gstreamer to the path.)


bulk update coreness

Regarding the override correness task, nothing happens when you select multiple papers and you click 'Accept' - you are supposed to get the buttons on the top of the screen, as you do when you select multiple papers in other cases in the holdingpen

buttons now appear, but don't do anything. Continued in #2282.


Add collection

https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=3476%3A102243

Resolved in #1383.


Client/Server api version mismatch

What happened?
Updating the Walrus Site object on Sui ... 2024-10-20T12:25:36.124304Z  WARN sui_sdk::wallet_context: Client/Server api version mismatch, client api version : 1.34.2, server api version : 1.35.1
[warn] Client/Server api version mismatch, client api version : 1.34.2, server api version : 1.35.1
Search terms
/issues?q=is:issue is:open version
Steps to reproduce
Example:

Publish site with the following contents: [./target/release/site-builder publish ./examples/snake --epochs 100]

Deviation steps
No response
Relevant log output
No response
Version

[X] walrus and site-builder are up to date.

If applicable, what browsers are you seeing the problem on?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct.

You can ignore this (it is not a bug).
It happens when the client version (the Sui SDK in the Walrus binaries) is a different version than the RPC servers.
You will observe this from time to time because the network constantly updates... and it is typically not cause for concern between small version differences.
Keep also in mind that not all RPC servers runs the same version, so there is no way to "perfectly" always eliminate these warnings... just keep your client up to date with latest like you already did :slightly_smiling_face:


Applying watermark in setTimeout doesn't make an effect

Lightweight Charts Version:
Steps/code to reproduce:
It is not effective when i use setTimeout to set applyOptions

Actual behavior:

Expected behavior:

Screenshots

CodeSandbox/JSFiddle/etc link:

Yeah, looks like a bug. Meantime, may I ask to provide a repro code please?

Never mind, I reproduce it 😉

Never mind, I've reproduced it 😉

Sorry for the delayed response, it may just be a minor bug!


RMTB does not build properly on OSX >= 10.13

this is the error i get:
    from smt.surrogate_models.rmtsclib import PyRMTB
ImportError: dlopen(/Users/jsgray/anaconda3/envs/py3.6/lib/python3.6/site-packages/smt/surrogate_models/rmtsclib.cpython-36m-darwin.so, 2): Symbol not found: __ZTINSt8ios_base7failureB5cxx11E
  Referenced from: /Users/jsgray/anaconda3/envs/py3.6/lib/python3.6/site-packages/smt/surrogate_models/rmtsclib.cpython-36m-darwin.so
  Expected in: flat namespace
 in /Users/jsgray/anaconda3/envs/py3.6/lib/python3.6/site-packages/smt/surrogate_models/rmtsclib.cpython-36m-darwin.so```

I was able to get it to build correctly by setting the compilers to g++ explicitely. neither apple's built in clang or gcc worked for me.

I could have it compile with gcc and clang by setting the deployment target in setup.py (rather at the top).
if sys.platform == 'darwin':
    os.environ['MACOSX_DEPLOYMENT_TARGET'] = '10.9'

Thank you for reporting. No way for me to test that directly. I've just upgraded the travis macos config to test with 10.13 and it seems ok.

I had a similar problem installing smt on MacOS 10.14: c++ compiler not finding stdlibc++

I found this explanation in a pandas GitHub issue: https://github.com/pandas-dev/pandas/issues/23424

The compiler standard library defaults to either libstdc++ or libc++, depending on the targetted macOS version - libstdc++ for 10.8 and below, and libc++ for 10.9 and above. This is determined by the environment variable MACOSX_DEPLOYMENT_TARGET or the compiler option-mmacosx-version-min, defaulting to the system version otherwise.

@cyrilpic workaround seems to have fixed it


Lf wf 86828952 standardize repo

standardize package with yo generator, bump version
will be used with tealium

Just a heads up — tagging in a PR can make it difficult to track down changes. m.AG broke b/c it's version of jquery-autotagging (an old version) uses the latest version of this repo (which has a dist/ dir).

:+1: @c0 are you talking about versioning of the package?, if yes i agree, i prefer a separate commit for just version update.

i just spoke to caleb - we got greedy earlier by pushing tag before PR was merged, thats what caleb was referring to.

that's sounds good @lfender6445

:+1:


Use JSON mode

https://platform.openai.com/docs/guides/text-generation/json-mode
Perfect for getting structured outputs with texttunnel. Need to discuss how it interacts with function calling.

Function calling already implies JSON output. So this is not needed in texttunnel.


Flake8 rule 'E901' reported an invalid point

Flake8 reported an invalid point for the rule E901, with the messge SyntaxError: invalid syntax.

Debug information:
Atom version: 1.16.0
Flake8 version: 2.5.5 (pep8: 1.5.7, pyflakes: 0.8.1, flake8-docstrings: 1.0.3, pydocstyle: 1.1.1, hacking.core: 0.0.1, ProxyChecker: 0.0.1, mccabe: 0.2.1) CPython 2.7.12 on Darwin

Please update your flake8 version (pip install -U flake8). This particular error should be fixed in flake8>=3.2.1.

Closing due to a lack of response, if you are still having issues after updating flake8 please provide code to reproduce this!