[Tracking] Add CI tests

Add tests for all supported environments to CI and list known working environment. Also should be collecting coverage.

[x] Formatting - Black (#8)
[x] Debian/Ubuntu - System (#10)
[x] Arch - System (#21)
[x] Alpine - System (#22)
[x] RHEL 7 - System (#14 and #36)
[x] RHEL 7 - Appstream (#36 and #38)
[x] RHEL 8 - System (#36)
[x] RHEL 8 - Appstream (#36)
[x] RHEL 9 - System (#40)
[x] Linux - python.org (#28)
[x] Linux - Conda (#11)
[ ] Linux - Conda 32 bit (#13)
[ ] Windows - Chocolately
[x] Windows/msys2 - System (#16)
[x] Windows/mingw-w32/64 - System (#16)
[x] Windows - python.org Installer (#28)
[x] Windows - Conda (#12)
[ ] Windows - Conda 32 bit (#13)
[x] Mac OS - Homebrew (#19)
[x] Mac OS - python.org Installer (#28)
[x] Mac OS - Conda (#12)

The Python installation for Chocolately is just the python.org installer. And we can't really test the 32-bit miniconda environment anymore, so I'm fine with dropping support. I'm calling this done for now.


Fix issue with compiling virtual editor files

Issue came when better validation was done when the main file is not a file that cadl can compile.

Hmm, there are test failures


Not working on Meteor 1.2.1

Hi,
I'm using meteor 1.2.1, and tried all the different examples with a newly created app (default meteor create app), and none of them work. I noticed that the helpers (linked to the data-source prop) is never triggered.
Is there any version-related issue here?

@rpesciotta the reason is usage of internal meteor functions by this package. Hope this should be easy to fix having ready environment with just debugger (and BTW I don't have such environment now). So as usual please feel free to make PR fixing this issue. Also it is fine to fix with breaking changes for previous meteor versions, and maybe start following semantic versioning rules.

@rpesciotta Did you find any workaround to make it work on 1.2.1?

I ended up using the following code until the helper is fixed:
Template.templateName.onRendered(() => {
  Meteor.typeahead.inject();

  $('.typeahead').on('typeahead:selected', function(evt, suggestion) {
    console.log(suggestion.id);
    console.log(suggestion.value);
  });
});

@sergeyt: I'm willing for file a PR, but I'm going through some basics about version dependencies, and how the package actually works. So far no luck...
@lucatros: found no workaround yet.
I will try the workaround from @lucatros for the moment and see if I can at least get it to work.

@rpesciotta I've just checked that demo app (inside this repository) is still working without any changes in the package code on latest meteor 1.3.


About t2i weights

Hi, will t2i weights be released?

We strive to release T2I models before July 1st

We strive to release T2I models before July 1st

Thank you for your response. So, you are completing it rather than waiting for company approval?


Add navbar

Fixes: #8
Adds a navigation bar at the bottom of the app to allow users to skip between lessons.

This looks super clean! Awesome work Jamie.


ARROW-9742: [Rust] [DataFusion] Improved DataFrame trait (formerly known as the Table trait)

This PR renames the Table trait to DataFrame and also contains the following improvements:

Updates the collect method signature to remove the reference to an execution context (which made no sense because the table/dataframe struct was created by the context).
Adds rustdocs for DataFrame and ExecutionContext with code examples
Updates existing examples to call ExecutionContext.sql() instead of referencing logical and physical query plans - these are internal implementation details that should be of no concern to typical users
Adds a new example that uses the DataFrame trait to build a query
A few other minor UX improvements so that I could show some real examples

Note that the goal of this PR is mostly to document the API as it is today. There are number of design flaws that still need fixing and I will be creating follow-up PRs for those.

@alamb @jorgecarleitao

I went through this, and it looks great. I admit I am still not fully familiar when to use Rc vs Arc yet (e.g. why nor Arc instead? because we do not expect the context to be sharable between threads?), so take that into account.
I have an extra suggestion, that I pushed here. Essentially, with this change I think that we can remove ExecutionContextSchemaProvider altogether and let ExecutionContextState implement SchemaProvider.

@jorgecarleitao @alamb @houqp @jhorstmann This is ready for re-review. Please see the updated PR description.

Thanks @jorgecarleitao  I wanted to move the aggregate functions too but ran into a problem and it probably relates to your PRs .. I will file a JIRA to explain this.

Thanks @jorgecarleitao I wanted to move the aggregate functions too but ran into a problem and it probably relates to your PRs .. I will file a JIRA to explain this.

Yes, currently aggregate functions are impossible to correctly declare in the logical realm because they have a variable return type, while all logical expressions have a hard-coded return type. I propose a fix for that in one of my PRs. The planets are aligning!


fix compiling HLG

Someone is trying the TIMIT recipe and gets the following error

The error is introduced by https://github.com/k2-fsa/k2/pull/1140
This PR fixes the error.

@csukuangfj I still encounter the problem on yesno :( Any suggestions?
(testing) user@computer:~/workspace/icefall/egs/yesno/ASR$ ./prepare.sh
2023-05-08 08:27:41 (prepare.sh:27:main) dl_dir: /home/user/workspace/icefall/egs/yesno/ASR/download
2023-05-08 08:27:41 (prepare.sh:30:main) Stage 0: Download data
2023-05-08 08:27:41 (prepare.sh:39:main) Stage 1: Prepare yesno manifest
2023-05-08 08:27:44 (prepare.sh:45:main) Stage 2: Compute fbank for yesno
2023-05-08 08:27:46,058 INFO [compute_fbank_yesno.py:63] train already exists - skipping.
2023-05-08 08:27:46,058 INFO [compute_fbank_yesno.py:63] test already exists - skipping.
2023-05-08 08:27:46 (prepare.sh:51:main) Stage 3: Prepare lang
2023-05-08 08:27:49 (prepare.sh:66:main) Stage 4: Prepare G
2023-05-08 08:27:49 (prepare.sh:92:main) Stage 5: Compile HLG
2023-05-08 08:27:51,750 INFO [compile_hlg.py:124] Processing data/lang_phone
2023-05-08 08:27:51,750 INFO [lexicon.py:168] Loading pre-compiled data/lang_phone/Linv.pt
2023-05-08 08:27:51,751 INFO [compile_hlg.py:48] Building ctc_topo. max_token_id: 3
2023-05-08 08:27:51,752 INFO [compile_hlg.py:52] Loading G.fst.txt
2023-05-08 08:27:51,752 INFO [compile_hlg.py:62] Intersecting L and G
2023-05-08 08:27:51,754 INFO [compile_hlg.py:64] LG shape: (4, None)
2023-05-08 08:27:51,754 INFO [compile_hlg.py:66] Connecting LG
2023-05-08 08:27:51,754 INFO [compile_hlg.py:68] LG shape after k2.connect: (4, None)
2023-05-08 08:27:51,754 INFO [compile_hlg.py:70] <class 'torch.Tensor'>
2023-05-08 08:27:51,754 INFO [compile_hlg.py:71] Determinizing LG
2023-05-08 08:27:51,755 INFO [compile_hlg.py:74] <class '_k2.ragged.RaggedTensor'>
2023-05-08 08:27:51,755 INFO [compile_hlg.py:76] Connecting LG after k2.determinize
2023-05-08 08:27:51,755 INFO [compile_hlg.py:79] Removing disambiguation symbols on LG
2023-05-08 08:27:51,756 INFO [compile_hlg.py:91] LG shape after k2.remove_epsilon: (6, None)
Traceback (most recent call last):
  File "/home/user/workspace/icefall/egs/yesno/ASR/./local/compile_hlg.py", line 136, in <module>
    main()
  File "/home/user/workspace/icefall/egs/yesno/ASR/./local/compile_hlg.py", line 126, in main
    HLG = compile_HLG(lang_dir)
          ^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/workspace/icefall/egs/yesno/ASR/./local/compile_hlg.py", line 93, in compile_HLG
    LG = k2.connect(LG)
         ^^^^^^^^^^^^^^
  File "/home/user/workspace/testing/lib/python3.11/site-packages/k2-1.24.1.dev20230507+cpu.torch2.0.0-py3.11-linux-x86_64.egg/k2/fsa_algo.py", line 522, in connect
    if fsa.properties & fsa_properties.ACCESSIBLE != 0 and \
       ^^^^^^^^^^^^^^
  File "/home/user/workspace/testing/lib/python3.11/site-packages/k2-1.24.1.dev20230507+cpu.torch2.0.0-py3.11-linux-x86_64.egg/k2/fsa.py", line 446, in properties
    raise RuntimeError(
RuntimeError: The fsa attribute (labels) has been inappropriately modified like:
    fsa.labels[xxx] = yyy
The correct way should be like:
    labels = fsa.labels
    labels[xxx] = yyy
    fsa.labels = labels

@csukuangfj I still encounter the problem on yesno :( Any suggestions?

(testing) user@computer:~/workspace/icefall/egs/yesno/ASR$ ./prepare.sh

2023-05-08 08:27:41 (prepare.sh:27:main) dl_dir: /home/user/workspace/icefall/egs/yesno/ASR/download

2023-05-08 08:27:41 (prepare.sh:30:main) Stage 0: Download data

2023-05-08 08:27:41 (prepare.sh:39:main) Stage 1: Prepare yesno manifest

2023-05-08 08:27:44 (prepare.sh:45:main) Stage 2: Compute fbank for yesno

2023-05-08 08:27:46,058 INFO [compute_fbank_yesno.py:63] train already exists - skipping.

2023-05-08 08:27:46,058 INFO [compute_fbank_yesno.py:63] test already exists - skipping.

2023-05-08 08:27:46 (prepare.sh:51:main) Stage 3: Prepare lang

2023-05-08 08:27:49 (prepare.sh:66:main) Stage 4: Prepare G

2023-05-08 08:27:49 (prepare.sh:92:main) Stage 5: Compile HLG

2023-05-08 08:27:51,750 INFO [compile_hlg.py:124] Processing data/lang_phone

2023-05-08 08:27:51,750 INFO [lexicon.py:168] Loading pre-compiled data/lang_phone/Linv.pt

2023-05-08 08:27:51,751 INFO [compile_hlg.py:48] Building ctc_topo. max_token_id: 3

2023-05-08 08:27:51,752 INFO [compile_hlg.py:52] Loading G.fst.txt

2023-05-08 08:27:51,752 INFO [compile_hlg.py:62] Intersecting L and G

2023-05-08 08:27:51,754 INFO [compile_hlg.py:64] LG shape: (4, None)

2023-05-08 08:27:51,754 INFO [compile_hlg.py:66] Connecting LG

2023-05-08 08:27:51,754 INFO [compile_hlg.py:68] LG shape after k2.connect: (4, None)

2023-05-08 08:27:51,754 INFO [compile_hlg.py:70] <class 'torch.Tensor'>

2023-05-08 08:27:51,754 INFO [compile_hlg.py:71] Determinizing LG

2023-05-08 08:27:51,755 INFO [compile_hlg.py:74] <class '_k2.ragged.RaggedTensor'>

2023-05-08 08:27:51,755 INFO [compile_hlg.py:76] Connecting LG after k2.determinize

2023-05-08 08:27:51,755 INFO [compile_hlg.py:79] Removing disambiguation symbols on LG

2023-05-08 08:27:51,756 INFO [compile_hlg.py:91] LG shape after k2.remove_epsilon: (6, None)

Traceback (most recent call last):

  File "/home/user/workspace/icefall/egs/yesno/ASR/./local/compile_hlg.py", line 136, in <module>

    main()

  File "/home/user/workspace/icefall/egs/yesno/ASR/./local/compile_hlg.py", line 126, in main

    HLG = compile_HLG(lang_dir)

          ^^^^^^^^^^^^^^^^^^^^^

  File "/home/user/workspace/icefall/egs/yesno/ASR/./local/compile_hlg.py", line 93, in compile_HLG

    LG = k2.connect(LG)

         ^^^^^^^^^^^^^^

  File "/home/user/workspace/testing/lib/python3.11/site-packages/k2-1.24.1.dev20230507+cpu.torch2.0.0-py3.11-linux-x86_64.egg/k2/fsa_algo.py", line 522, in connect

    if fsa.properties & fsa_properties.ACCESSIBLE != 0 and \

       ^^^^^^^^^^^^^^

  File "/home/user/workspace/testing/lib/python3.11/site-packages/k2-1.24.1.dev20230507+cpu.torch2.0.0-py3.11-linux-x86_64.egg/k2/fsa.py", line 446, in properties

    raise RuntimeError(

RuntimeError: The fsa attribute (labels) has been inappropriately modified like:

    fsa.labels[xxx] = yyy

The correct way should be like:

    labels = fsa.labels

    labels[xxx] = yyy

    fsa.labels = labels

Are you using the latest master of k2?
You have to install k2 from the latest master.
Please show the output of
python3 -m k2.version

Yes using latest master (8740cc821c10a48723cb4d0cbef75b18c68f4878):
(tesing) user@computer:~/workspace/icefall/egs/yesno/ASR$ python3 -m k2.version
Collecting environment information...

k2 version: 1.24.1
Build type: Release
Git SHA1: 8740cc821c10a48723cb4d0cbef75b18c68f4878
Git date: Sun May 7 17:52:20 2023
Cuda used to build k2:
cuDNN used to build k2:
Python version used to build k2: 3.11
OS used to build k2: Debian GNU/Linux 12 (bookworm)
CMake version: 3.25.1
GCC version: 12.2.0
CMAKE_CUDA_FLAGS:
CMAKE_CXX_FLAGS:  -D_GLIBCXX_USE_CXX11_ABI=0 -Wno-unused-variable  -Wno-strict-overflow
PyTorch version used to build k2: 2.0.0+cpu
PyTorch is using Cuda:
NVTX enabled: False
With CUDA: False
Disable debug: True
Sync kernels : False
Disable checks: False
Max cpu memory allocate:<PHONE_NUMBER>00 bytes (or 200.0 GB)
k2 abort: False
__file__: /home/user/workspace/testing/lib/python3.11/site-packages/k2-1.24.1.dev20230507+cpu.torch2.0.0-py3.11-linux-x86_64.egg/k2/version/version.py
_k2.__file__: /home/user/workspace/testing/lib/python3.11/site-packages/k2-1.24.1.dev20230507+cpu.torch2.0.0-py3.11-linux-x86_64.egg/_k2.cpython-311-x86_64-linux-gnu.so

Yes using latest master (8740cc821c10a48723cb4d0cbef75b18c68f4878):
(tesing) user@computer:~/workspace/icefall/egs/yesno/ASR$ python3 -m k2.version
Collecting environment information...

k2 version: 1.24.1
Build type: Release
Git SHA1: 8740cc821c10a48723cb4d0cbef75b18c68f4878
Git date: Sun May 7 17:52:20 2023
Cuda used to build k2:
cuDNN used to build k2:
Python version used to build k2: 3.11
OS used to build k2: Debian GNU/Linux 12 (bookworm)
CMake version: 3.25.1
GCC version: 12.2.0
CMAKE_CUDA_FLAGS:
CMAKE_CXX_FLAGS:  -D_GLIBCXX_USE_CXX11_ABI=0 -Wno-unused-variable  -Wno-strict-overflow
PyTorch version used to build k2: 2.0.0+cpu
PyTorch is using Cuda:
NVTX enabled: False
With CUDA: False
Disable debug: True
Sync kernels : False
Disable checks: False
Max cpu memory allocate:<PHONE_NUMBER>00 bytes (or 200.0 GB)
k2 abort: False
__file__: /home/user/workspace/testing/lib/python3.11/site-packages/k2-1.24.1.dev20230507+cpu.torch2.0.0-py3.11-linux-x86_64.egg/k2/version/version.py
_k2.__file__: /home/user/workspace/testing/lib/python3.11/site-packages/k2-1.24.1.dev20230507+cpu.torch2.0.0-py3.11-linux-x86_64.egg/_k2.cpython-311-x86_64-linux-gnu.so

Are you using the latest icefall? You can use
git log

to view the commit to check that.

latest master is 1.24.2 no?  Or is that a more recent PR?

I just released 1.24.2 this morning, which only changed CMakeLists.txt.
(The latest was 8740cc821c10a48723cb4d0cbef75b18c68f4878 after merging https://github.com/k2-fsa/k2/pull/1186)

@rouseabout
Please use changes from https://github.com/k2-fsa/k2/pull/1188
It should fix your issue.

成功！


Replace np.long with np.int64

Motivation
This is a small PR to replace np.long. It has obviously already been done in most places in https://github.com/open-mmlab/mmdetection3d/pull/1270 and should silence warnings from numpy as np.long is deprecated since numpy version 1.20 (https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations)
Modification
Replace the last occurrence of np.long by np.int64.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
No breaking changes, just a minor fix.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Bug]: Empty response in Chat Configuration

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
dev
Commit ID
4454ba7
Other environment information
ASUS Tuf Gaming F15 Pro 13980HX 4060 Laptop Graphics Card
Win11
WSL2

Actual behavior
Chat Settings → Assistant Settings → Empty Response Section.
If you set the content for the empty response, it will cause all questions that do not match the knowledge base to be directed to this empty response, and it will be used as the preferred answer for subsequent similar questions by the assistant.
This will result in the default empty response filling up all the alternative answer options for questions.

Expected behavior
No response
Steps to reproduce
1. In the empty response option, set a custom reply content;

2. A question for which there is no answer in the knowledge base;

3. A similar question that does have an answer in the knowledge base.

Additional information
I suspect it's related to the "self-rag" mechanism.

hi @morler  thank for mention that, I was unable to reproduce this issue. It seems that the problem is related to not recalling any parsing blocks. Could you please check if your knowledge base is set correctly (i.e., if it's set to another knowledge base)? Can the parsing blocks be recalled when you test with questions that have answers in the knowledge base?
Could you provide more information to help reproduce this issue, such as the name of the chat model used, the embedding model name, the file  parse way , and the files being parsed If it's convenient for you.  Thank you for your assistance.

Close due to no response.


Incompatible for meteor version > 0.9.0

Are you doing any work on making the ace-embed compatible with the latest meteor released version - <IP_ADDRESS>?
If you can tell me what all needs to be done for the compatibility, may be I can help you.

This worked for me:
ace.config.set("modePath", "/packages/mrt_ace-embed/ace");
ace.config.set("themePath", "/packages/mrt_ace-embed/ace");
ace.config.set("workerPath", "/packages/mrt_ace-embed/ace");
ace.config.set("basePath", "/packages/mrt_ace-embed/ace");

I had lost all syntax highlighting and it was sad :)


Update object-store-connector.adoc

Incorrect: Note that the Mule app is deployed into CloudHub workers through Anypoint Platform Runtime Manager, the contents of the Mule app's default Object Store are visible in Runtime Manager, within the Mule app's Application Data tab.
Correct: Note that the Mule app is deployed into CloudHub workers through Anypoint Platform Runtime Manager, the contents of the Mule app's default Object Store are invisible in Runtime Manager, within the Mule app's Application Data tab.

Verified correction with @estebanwasinger. See #665.


A dependency npm library citeproc which is licensed under CPAL or AGPL. I think it's not compatible with MIT. We need to revert this PR or use another library instead.

This PR introduced a dependency npm library citeproc which is licensed under CPAL or AGPL. I think it's not compatible with MIT. We need to revert this PR or use another library instead.
Originally posted by @lunny in https://github.com/go-gitea/gitea/issues/19999#issuecomment-1869262439

https://github.com/go-gitea/gitea/pull/21815#issuecomment-1315018744


dynamic IP?

Describe what feature you want added
what if I have homeserver with dynamic real IP-address?
Recommended approaches
Any addons, plugins or softwares you think would be beneficial in implementing this request.
Additional Information
Add any other context about the feature here.

Hmm, it becomes a bit complicated with a dynamic IP.
The forward DNS is easy enough to configure, we already have all the pipeline in place for updating the dynamic IP in DNS.
The problem comes with reverse DNS, reverse DNS is generally not something that is configured on your host machine. You generally use some web UI to manage reverse DNS.
Basically forward DNS: mail.domain.tld -> <IP_ADDRESS>
and reverse DNS: <IP_ADDRESS> -> mail.domain.tld
The second one, the reverse DNS translation, is controlled by your ISP. So whenever your ISP gives you a new IP address (say <IP_ADDRESS>), we can do the mail.domain.tld -> <IP_ADDRESS> update, BUT the ISP is be the one who needs to update the reverse DNS.
So unfortunately, really not much I can do here.

Hmm, it becomes a bit complicated with a dynamic IP.
The forward DNS is easy enough to configure, we already have all the pipeline in place for updating the dynamic IP in DNS.
The problem comes with reverse DNS, reverse DNS is generally not something that is configured on your host machine. You generally use some web UI to manage reverse DNS.
Basically forward DNS: mail.domain.tld -> <IP_ADDRESS>
and reverse DNS: <IP_ADDRESS> -> mail.domain.tld
The second one, the reverse DNS translation, is controlled by your ISP. So whenever your ISP gives you a new IP address (say <IP_ADDRESS>), we can do the mail.domain.tld -> <IP_ADDRESS> update, BUT the ISP is be the one who needs to update the reverse DNS.
So unfortunately, really not much I can do here.

I guess we should treat homeservers+VPSes as AS (autonomous system) and provide autoconfig service

I guess we should treat homeservers+VPSes as AS (autonomous system) and provide autoconfig service

good option is use VPS IP with my domain PTR as MTA and store messages on my homeserver

good option is use VPS IP with my domain PTR as MTA and store messages on my homeserver

We already have some amount of decentralization.
The webmail + calendar/contacts + php + postgresql, can be setup on a different server, as they are quite heavy.
Currently dovecot + rspamd + opensmptd need to be on the same server.
I use three different servers, all interconnected with wireguard for easy access:

A small VPS which has site-install.yml
A homeserver which is configured using site-extras.yml - a beefy machine for running postgresql and php + webmail and contacts.
A second homeserver which runs clamav (this one is not managed by the current excision mail setup)
It is possible to setup things that can work in a fully decentralized environment with each service being replicated with redundancy, but that that point, it is a task for an experienced sysadmin, not a small ansible script.

We already have some amount of decentralization.
The webmail + calendar/contacts + php + postgresql, can be setup on a different server, as they are quite heavy.
Currently dovecot + rspamd + opensmptd need to be on the same server.
I use three different servers, all interconnected with wireguard for easy access:

A small VPS which has site-install.yml
A homeserver which is configured using site-extras.yml - a beefy machine for running postgresql and php + webmail and contacts.
A second homeserver which runs clamav (this one is not managed by the current excision mail setup)
It is possible to setup things that can work in a fully decentralized environment with each service being replicated with redundancy, but that that point, it is a task for an experienced sysadmin, not a small ansible script.

I'd like to find a way to truly autoconfig ... somehow

I'd like to find a way to truly autoconfig ... somehow

I feel like we need autoconfig features to be intrinsic to openbsd ...

I feel like we need autoconfig features to be intrinsic to openbsd ...

btw, to many problems to make playbook to through, I'm triing a few days already
doas /usr/sbin/relayd -n
/etc/relayd.conf:59: macro 'extras_port' not defined
/etc/relayd.conf:59: syntax error
no actions, nothing to do

btw, to many problems to make playbook to through, I'm triing a few days already
doas /usr/sbin/relayd -n
/etc/relayd.conf:59: macro 'extras_port' not defined
/etc/relayd.conf:59: syntax error
no actions, nothing to do

btw, to many problems to make playbook to through, I'm triing a few days already
doas /usr/sbin/relayd -n
/etc/relayd.conf:59: macro 'extras_port' not defined
/etc/relayd.conf:59: syntax error
no actions, nothing to do

Ah, I can help with debugging, there might be a few kinks still.
You can come on the irc chatroom, that might be faster to debug - https://webchat.freenode.net/?channels=#excision-mail

btw, to many problems to make playbook to through, I'm triing a few days already
doas /usr/sbin/relayd -n
/etc/relayd.conf:59: macro 'extras_port' not defined
/etc/relayd.conf:59: syntax error
no actions, nothing to do

Ah, I can help with debugging, there might be a few kinks still.
You can come on the irc chatroom, that might be faster to debug - https://webchat.freenode.net/?channels=#excision-mail

All major email providers block list mail servers coming from home ISP's. This isn't a fruitful venture IMO. On top of that you'll be deranked in spam lists for the dynamic IP as well. You might be able to send mail out, but you'll almost always land in someone's SPAM folder even if they mark you as not spam. This is all of course assuming your ISP doesn't already block out going smtp from your home connection due to so many spammers. Just my two sense @epsilon-0.

All major email providers block list mail servers coming from home ISP's. This isn't a fruitful venture IMO. On top of that you'll be deranked in spam lists for the dynamic IP as well. You might be able to send mail out, but you'll almost always land in someone's SPAM folder even if they mark you as not spam. This is all of course assuming your ISP doesn't already block out going smtp from your home connection due to so many spammers. Just my two sense @epsilon-0.

@gregf yea, i totally agree.

@gregf yea, i totally agree.

well, one could use VPS as proxy, but I prefer to store my mail at home

well, one could use VPS as proxy, but I prefer to store my mail at home

I get that, and I think the IP stuff should be fixed.

I get that, and I think the IP stuff should be fixed.

honestly, I think IP-addresses are obsolete and should be deprecated

honestly, I think IP-addresses are obsolete and should be deprecated


Handle more event types

our current main.py has a condition check:
https://github.com/SeineAI/SeineSailor/blob/19e02192e9eaedaa4e8fc7a410467a547b4f253b/app/main.py#L62-L67
it restricted the action to only work on 3 types of events. But we want to work with all the events in the workflow yaml:
https://github.com/SeineAI/SeineSailor/blob/19e02192e9eaedaa4e8fc7a410467a547b4f253b/.github/workflows/llm-review.yml#L9-L47
can the code_review and handle_review_comment function handle all of them? do we need to write some new functions?

GPT4 suggests:
Based on the diverse range of GitHub event types you want to handle and the specific conditions in your YAML configuration, it's clear that your current main.py setup needs to be expanded to cover more scenarios. The code_review and handle_review_comment functions are specific to pull request-related events and wouldn't appropriately handle other types of events like issues, discussions, or comments on these.
Event Handling Strategy

Expand Main Script: Modify main.py to handle different types of GitHub events, routing to the appropriate functions based on the event type.
Create Event-Specific Functions: Develop new functions to handle the logic specific to issues, discussions, and various types of comments.

Suggested Modifications in main.py
Here’s a possible expansion for main.py to handle different events:
import os
import asyncio
from context import light_bot, heavy_bot, options, prompts

async def main():
    event_name = os.getenv("GITHUB_EVENT_NAME")

    if event_name in ["pull_request", "pull_request_target"]:
        # Handle pull request events
        await code_review(light_bot, heavy_bot, options, prompts)

    elif event_name == "pull_request_review_comment":
        # Handle pull request review comment events
        await handle_review_comment(heavy_bot, options, prompts)

    elif event_name in ["issue_comment", "discussion_comment"]:
        # Handle comments on issues and discussions
        await handle_general_comment(heavy_bot, options, prompts)

    elif event_name in ["issues", "discussion"]:
        # Handle issues and discussions
        await handle_issues_and_discussions(heavy_bot, options, prompts)

    elif event_name == "pull_request_review":
        # Handle pull request review events
        await handle_pull_request_review(heavy_bot, options, prompts)

    else:
        print(f"Skipped: this action does not handle {event_name} events")

asyncio.run(main())

New Functions to Implement

handle_general_comment: Handles comments on issues and discussions.

handle_issues_and_discussions: Handles opening and editing of issues and discussions.

handle_pull_request_review: Handles events related to pull request reviews.

Example of New Function: handle_general_comment
async def handle_general_comment(bot, options, prompts):
    # Extract data from the event payload
    comment_body = os.getenv("GITHUB_EVENT_PAYLOAD").get('comment', {}).get('body', '')
    if '@SeineSailor' in comment_body:
        # Process the comment
        print("Handling a general comment...")
        response = await bot.respond_to_comment(comment_body, options, prompts)
        # Logic to post response back to GitHub

Integration and Testing

Implement the Functions: Implement the logic within these functions based on the actions you need to take (e.g., analyzing comments, responding to discussions).
Test Each Event Type: Ensure that each event type is correctly handled and that the appropriate GitHub API calls are made.
Handling Concurrency and Errors: Make sure to handle concurrency issues and potential errors in API calls or data handling.

By structuring your main.py to appropriately route and handle different GitHub events, and by implementing specific functions for each event type, you can ensure that your GitHub Action is robust, flexible, and maintainable.

for pull_request/pull_request_target, pull_request_review_comment, pull_request_review, what will be different in the payload that github action provides? and what kind of operations we can conduct differently that require us to use different functions to handle them?

ChatGPT4:
When GitHub Actions processes different types of events related to pull requests, the payload provided for each event type varies slightly. These differences primarily relate to the specifics of the event context—such as whether a comment, a review, or the pull request itself is the focus. Understanding these differences is crucial for designing functions that correctly handle each type of event.
Differences in Event Payloads

pull_request / pull_request_target:

Payload Details: Includes comprehensive details about the pull request, such as its number, state (open, closed), the pull request body, title, the commits associated with it, and more.
Operations: Actions typically performed include checking the pull request for compliance with project standards, running automated tests, linting, code analysis, merging, or closing.

pull_request_review:

Payload Details: Focuses on a specific review submitted to a pull request. Includes details about the review itself, the state of the review (submitted, edited, dismissed), and the reviewer.
Operations: Common actions include analyzing the content of the review, perhaps triggering further actions based on approval status, comment content in the review, or dismissing outdated reviews.

pull_request_review_comment:

Payload Details: Specifically deals with comments on the code diffs in a pull request review. Includes information about the individual comment, the part of the code it refers to, and details about the commit to which it was attached.
Operations: Often used to handle specific feedback on code lines, such as responding to questions, making requested changes, or further clarifications.

Handling Different Operations
Given these payload distinctions, operations can be tailored to the context of each event type:

Handling Pull Requests (pull_request):

Function: code_review
Purpose: Automate checks like formatting, security scans, or running unit tests. Can also manage merge operations based on conditions, such as labels, comments, or approvals.

Handling Pull Request Reviews (pull_request_review):

Function: handle_pull_request_review
Purpose: React to state changes in reviews, such as approvals. Could trigger integration tests or deploy actions based on approvals from certain team members. Also useful for compliance checks and audit trails on how code reviews are handled.

Handling Review Comments (pull_request_review_comment):

Function: handle_review_comment
Purpose: Engage in discussions on code specifics. Useful for bots that suggest code improvements, formatting fixes, or automated security feedback directly on code lines.

Example Code Adjustment for Pull Request Review
Here's a basic outline of what a function handling pull request reviews might look like:
async def handle_pull_request_review(bot, options, prompts):
    review_body = os.getenv("GITHUB_EVENT_PAYLOAD").get('review', {}).get('body', '')
    review_state = os.getenv("GITHUB_EVENT_PAYLOAD").get('review', {}).get('state', '')

    if review_state == 'approved':
        # Maybe trigger deployment or further integration tests
        print("Review approved. Triggering deployment...")
        # (Deployment logic here)
    elif review_state in ['changes_requested', 'commented']:
        # Handle requested changes or review comments
        print("Handling review feedback...")
        # (Feedback handling logic here)

Conclusion
Each function you create to handle these different types of events should be tailored to the specific data and potential actions relevant to that event. It's important to structure your code to cleanly separate concerns, making it easier to maintain and scale as your project's GitHub Actions become more complex.


README.md example does not work

Hi,
Trying to switch from JSPM to OpalRB and hyper-react. I've tried following the README.md but it results in a runtime error (in the browser console): every: undefined method every' for main`
I've also tried to follow the two links in the README.md given for gem installation rather than using reactrb-express (http://ruby-hyperloop.io/get_started/, http://ruby-hyperloop.io/installation/) but the first is specifically for reactrb-express and the second is for integration with Rails.
I'm developing a static site and followed OpalRB's instructions here but I'm now stuck trying to figure out which gems need to be installed and what api the classes or modules are providing. It's especially confusing since there aren't any examples with require statements in them.
From reading various reference pages (some older), I believe I need the following:
Gemfile
source 'https://rubygems.org'

gem 'hyper-react'
gem 'opal'
gem 'opal-browser'
gem 'opal-jquery'
gem 'opal-rspec'
gem 'rake'
gem 'rubocop'

Rakefile
require 'bundler'
Bundler.require

Opal.append_path(File.expand_path('../app', __FILE__))

require 'opal'
require 'opal/rspec/rake_task'

desc 'Compile app/application.rb to build.js'
task :build do
  File.binwrite('build.js', Opal::Builder.build('application').to_s)
end

Opal::RSpec::RakeTask.new do |_, task|
  task.runner = :node
end

app/application.rb
require 'opal'
require 'browser'
require 'opal-jquery'
require 'react/react-source'
require 'hyper-react'

class HelloWorld < React::Component::Base
  param :time, type: Time
  render do
    p do
      span { "Hello, " }
      input(type: :text, placeholder: "Your Name Here")
      span { "! It is #{params.time}"}
    end
  end
end

every(1) do
  Element["#example"].render do
    HelloWorld(time: Time.now)
  end
end

I first looked at reactrb-express and it was nice to not have to compile, but I didn't see how I could load other libraries via a Gemfile or make tests for the components via opal-rspec.
If anyone could point me in the right direction where there's solid instructional material to stand up a server-less application with hyper-react, I'd really appreciate it.
Thank you.

Looked through opal-browser, found #every defined in browser/interval.rb. Updated application.rb to:
require 'opal'
require 'browser/interval'
require 'opal-jquery'
require 'react/react-source'
require 'hyper-react'

class HelloWorld < React::Component::Base
  param :time, type: Time
  render do
    p do
      span { "Hello, " }
      input(type: :text, placeholder: "Your Name Here")
      span { "! It is #{params.time}"}
    end
  end
end

every(1) do
  Element["#example"].render do
    HelloWorld(time: Time.now)
  end
end

It's now rendering the HelloWorld component to the page but is also throwing an error on each #every iteration:
[Error] Warning: Using deprecated behavior of `React.render`, – "require \"react/top_level_render\" to get the correct behavior."
	$$render (build.js:71373)
	TMP_4 (build.js:74575)
	TMP_5 (build.js:75154:140)

Following the message, I updated application.rb again to:
require 'opal'
require 'browser/interval'
require 'opal-jquery'
require 'react/react-source'
require 'react/top_level_render'
require 'hyper-react'

class HelloWorld < React::Component::Base
  param :time, type: Time
  render do
    p do
      span { "Hello, " }
      input(type: :text, placeholder: "Your Name Here")
      span { "! It is #{params.time}"}
    end
  end
end

every(1) do
  Element["#example"].render do
    HelloWorld(time: Time.now)
  end
end

This does not fix the error and it is still being thrown on each #every iteration.

Thanks for the detailed report, I am looking into it.
Kyle Whittington<EMAIL_ADDRESS>於 2017年2月8日週三 下午10:56 寫道：

Looked through opal-browser, found #every defined in browser/interval.rb
https://github.com/opal/opal-browser/blob/master/opal/browser/interval.rb.
Updated application.rb to:
require 'opal'require 'browser/interval'
require 'opal-jquery'require 'react/react-source'require 'hyper-react'
class HelloWorld < React::Component::Base
param :time, type: Time
render do
p do
span { "Hello, " }
input(type: :text, placeholder: "Your Name Here")
span { "! It is #{params.time}"}
end
endend
every(1) do
Element["#example"].render do
HelloWorld(time: Time.now)
endend
It's now rendering the HelloWorld component to the page but is also
throwing an error on each #every iteration:
[Error] Warning: Using deprecated behavior of React.render, – "require "react/top_level_render" to get the correct behavior."
$$render (build.js:71373)
TMP_4 (build.js:74575)
TMP_5 (build.js:75154:140)
Following the message, I updated application.rb again to:
require 'opal'require 'browser/interval'require 'opal-jquery'require 'react/react-source'require 'react/top_level_render'
require 'hyper-react'
class HelloWorld < React::Component::Base
param :time, type: Time
render do
p do
span { "Hello, " }
input(type: :text, placeholder: "Your Name Here")
span { "! It is #{params.time}"}
end
endend
every(1) do
Element["#example"].render do
HelloWorld(time: Time.now)
endend
This does not fix the error and it is still being thrown on each #every
iteration.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ruby-hyperloop/hyper-react/issues/210#issuecomment-278350800,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAzRJXN-Lenhr1xW7_MEcsw_XxbBKr_Vks5radeugaJpZM4L65cX
.

I will watch how this turns out then update the website docs accordingly. I also think we could do with a tutorial focused on using HyperReact without Rails.
@kWhittington have a look at https://github.com/ruby-hyperloop/hyper-spec - it should be compatible with Hyperloop Express

@kWhittington ,try put the require of react/top_level_render after require "hyper-react".

@zetachang changing application.rb to your specifications:
require 'opal'
require 'browser/interval'
require 'opal-jquery'
require 'hyper-react'
require 'react/top_level_render'

class HelloWorld < React::Component::Base
  param :time, type: Time
  render do
    p do
      span { "Hello, " }
      input(type: :text, placeholder: "Your Name Here")
      span { "! It is #{params.time}"}
    end
  end
end

every(1) do
  Element["#example"].render do
    HelloWorld(time: Time.now)
  end
end

and re-building the application removes the deprecation warning, thank you.
Note I also removed the require 'react/react-source' from before the require 'hyper-react' and it functions correctly. Is that expected behavior?
It's kinda confusing keeping track of which dependency is overwriting what other dependency, would it be helpful to add these dependency requires (and the order they need to appear) to the README.md?

Note I also removed the require 'react/react-source' from before the require 'hyper-react' and it functions correctly. Is that expected behavior?

The reactjs source may be already loaded in other place, do you manually load it from your html template?

It's kinda confusing keeping track of which dependency is overwriting what other dependency, would it be helpful to add these dependency requires (and the order they need to appear) to the README.md?

Totally agreed, I would update the deprecation warning above to be more clear.

@zetachang nice catch, thank you! I did have a ReactJS CDN link in my index.html. I removed the link and it failed without the require 'react/react-source' as expected.
I am able to place the require 'react/react-source' after require 'hyper-react' and no HTML JS link:
application.rb
require 'opal'
require 'browser/interval'
require 'opal-jquery'
require 'hyper-react'
require 'react/react-source'
require 'react/top_level_render'

class HelloWorld < React::Component::Base
  param :time, type: Time
  render do
    p do
      span { "Hello, " }
      input(type: :text, placeholder: "Your Name Here")
      span { "! It is #{params.time}"}
    end
  end
end

every(1) do
  Element["#example"].render do
    HelloWorld(time: Time.now)
  end
end

this require order works successfully, too:
require 'opal'
require 'browser/interval'
require 'opal-jquery'
require 'hyper-react'
require 'react/top_level_render'
require 'react/react-source'

class HelloWorld < React::Component::Base
  param :time, type: Time
  render do
    p do
      span { "Hello, " }
      input(type: :text, placeholder: "Your Name Here")
      span { "! It is #{params.time}"}
    end
  end
end

every(1) do
  Element["#example"].render do
    HelloWorld(time: Time.now)
  end
end

Is that expected behavior?

react/react-source should be required before hyper-react,  I think we do have a warning for this situation.

Kool. I'm not sure if that's working 100%, I didn't get any warnings with the above configuration and it functioned as if the requires were in the order you specified (react-source, hyper-react, top_level_render).
I made a P.R. for the fix the to README.md, tho: https://github.com/ruby-hyperloop/hyper-react/pull/211


Fix snpe a device handling

add SNPE-A to device tests
fix device handling
depend on new pyknos with bug fix

Tests will pass once pyknos https://github.com/mackelab/pyknos/pull/19 is merged and released.

Codecov Report

Merging #482 (34d2d19) into main (9d321ba) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   68.55%   68.55%
=======================================
  Files          55       55
  Lines        3788     3788
=======================================
  Hits         2597     2597
  Misses       1191     1191

Flag
Coverage Δ

unittests
68.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

sbi/inference/snpe/snpe_a.py
66.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d321ba...34d2d19. Read the comment docs.

feel free to merge


Better error reporting if problematic session path

Addresses #3431. Benefits only.

warning thrown as previously, but with more useful message
logged too

https://github.com/bcit-ci/CodeIgniter/issues/3431#issuecomment-71276025
https://github.com/bcit-ci/CodeIgniter/issues/3431#issuecomment-67773640

we never use trigger_error() (except in compat/, where the goal is to emulate PHP as close as possible). Also, the intent is that a message should not be shown at all, but I just don't want to use error suppression to avoid that when it's clearly the user's fault.


error when try to add custom erc20xdai token

can't reproduce with 4 different erc20 tokens. I tried with a clean browser. Maybe there is some collisions, but the error says there is no such standard: https://github.com/swaponline/MultiCurrencyWallet/blob/0fab4056c1fa36c107b3733d822a093fa83a5340/src/front/shared/redux/actions/erc20LikeAction.ts#L83
but xDai standard is there: https://github.com/swaponline/MultiCurrencyWallet/blob/master/src/front/shared/helpers/constants/TOKEN_STANDARDS.ts

I'm found this bug at https://swaponline.github.io/ and only with erc20matic

can't reproduce with new local storage


2005 generate adversarial dataset

What does this MR do and why?
Add engine to support creation of adversarial datasets (datasets with an evasion attack pre-applied to all samples for the ability to perform quicker real-time demonstrations).
Also refactors the batches from tuples of (x, y) to dictionaries (where the x_key and y_key are provided so armory knows how to obtain x/y from the dictionary). This is done to avoid reducing or dropping information from the original dataset.
Related issues
#2005
How to set up and validate locally
In the examples/src/charmory_examples/image_classification/eurosat_precomputed_pgd/ folder:

Run create_adversarial_eurosat.py [convnext|swin|vit] to create an adversarial dataset
Run run_against_pregenerated.py [convnext|swin|vit] [convnext|swin|vit] to perform evaluation using the adversarial dataset

first argument is the name of the model to be evaluated
second argument is the name of the model used to generate the adversarial dataset (i.e., what was used with create_adversarial_eurosat.py)

Run run_with_attack.py [convnext|swin|vit] to perform inline attack evaluation (typical armory usage)

MR approval & acceptance process
Areas of focus for the review:

Briefly look over changes to examples introduced by LightningEngine rename and evaluation.Dataset changes
Tuple vs dict batch changes in src/charmory/data.py and src/charmory/tasks/base.py
New adversarial dataset engine in src/charmory/engine/adversarial_dataset.py
EuroSAT example in examples/src/charmory_examples/image_classification/eurosat_precomputed_pgd/
New exports of target info in src/charmory/tasks/image_classification.py and src/charmory/tasks/object_detection.py

Not strictly necessary, but was put in place when the initial plan was to rely on mlflow exports and is still useful

Closes #2005

There are two deprecation warnings on vit at least.
/home/msw/.virtualenvs/cdao/lib/python3.10/site-packages/transformers/models/vit/feature_extraction_vit.py:28: FutureWarning: The class ViTFeatureExtractor is deprecated and will be removed in version 5 of Transformers. Please use ViTImageProcessor instead.
/home/msw/.virtualenvs/cdao/lib/python3.10/site-packages/datasets/load.py:2086: FutureWarning: 'task' was deprecated in version 2.13.0 and will be removed in 3.0.0.

There are two deprecation warnings on vit at least.
/home/msw/.virtualenvs/cdao/lib/python3.10/site-packages/transformers/models/vit/feature_extraction_vit.py:28: FutureWarning: The class ViTFeatureExtractor is deprecated and will be removed in version 5 of Transformers. Please use ViTImageProcessor instead. /home/msw/.virtualenvs/cdao/lib/python3.10/site-packages/datasets/load.py:2086: FutureWarning: 'task' was deprecated in version 2.13.0 and will be removed in 3.0.0.

Yeah, those are coming right out of HuggingFace because of the model's built-in configuration/metadata. I've seen similar deprecation warnings on a lot of the models picked at random from the HF hub (even from popular models). If HF goes through with the deprecated feature removal in version 3.0, there will be a lot of broken/unusuable models in their hub.


Pitch sequence

Hi thanks for your great work, I am planning to integrate NSF with tacotron, how do I get pitch sequence?

Oh no problem, I solved the problem I found the code that extract pitch sequence in this repo


State file

I looked into the code and couldn't find the path for the state file to be stored.
It seems that as data was never saved to the state file the IAQ accuracy measurement will reset to '1' for more than 24 hours (approximately) until it reaches an IAQ accuracy of '3' when the program is terminated and re-runs.
Also, as I may need the state file location, I want to move the state file to a different Raspberry Pi.

Thanks - we're going to look into supporting state files in the future - right now our work is focused on the new AI parts

In the meantime, if you wish you can also contribute code :-)

Sorry, C++ is not my area of expert. Just Python and PHP.
I am trying to include two functions; bsec_set_state() and bsec_get_state(). I am still struggle with fwrite to attempt save state to file.
See https://github.com/pi3g/bme68x-python-library/compare/main...nkatanaa:patch-1

Thanks - we're going to look into supporting state files in the future - right now our work is focused on the new AI parts

Just for my own curiosity, does your AI application leverage the IAQ value or do you rely on some combination of the remaining measurements?

We do not leverage the IAQ value - we use the other BSEC capabilities.
Here, there is a demo of the capabilities:
https://github.com/pi3g/MagicShow/tree/main/MagicShow
(note I've asked Nathan to rename the repo)
Here is also a video showing the capabilities:
https://www.youtube.com/watch?v=Dm7lWAg-W3M
We are currently working on integrating the AI functionality as an App into PiCockpit:
https://picockpit.com

Sweet!  Thank you for sharing the links to that work.  You've helped me think about those BME68x sensors in a new way.

My pleasure. Note that the BME688 is the only one with these AI features - the BME680 does not support detecting smells that way.


Fixes lint issues

Signed-off-by: Vishal Choudhary<EMAIL_ADDRESS>Purpose of PR?:
Fixes lining issues generated while running make golint
Fixes #1018
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[x] Bug fix. Fixes #1018
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

Codecov Report

Merging #1024 (3c97693) into main (a2dd030) will decrease coverage by 3.35%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
- Coverage   38.70%   35.35%   -3.36%
==========================================
  Files          31       31
  Lines       10013    10011       -2
==========================================
- Hits         3876     3539     -337
- Misses       5620     5993     +373
+ Partials      517      479      -38

Impacted Files
Coverage Δ

KubeArmor/core/dockerHandler.go
0.00% <ø> (-47.48%)
:arrow_down:

KubeArmor/core/karmorprobedata.go
81.81% <ø> (ø)

KubeArmor/enforcer/appArmorEnforcer.go
48.31% <0.00%> (-0.25%)
:arrow_down:

KubeArmor/core/crioHandler.go
0.00% <0.00%> (-60.52%)
:arrow_down:

KubeArmor/monitor/processTree.go
83.87% <0.00%> (-11.83%)
:arrow_down:

KubeArmor/core/kubeArmor.go
45.79% <0.00%> (-4.21%)
:arrow_down:

KubeArmor/common/common.go
39.38% <0.00%> (-3.87%)
:arrow_down:

KubeArmor/enforcer/runtimeEnforcer.go
34.68% <0.00%> (-1.16%)
:arrow_down:

KubeArmor/core/kubeUpdate.go
37.97% <0.00%> (-0.45%)
:arrow_down:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I am mostly good to merge these changes. Can you please fix the merge conflicts?

@nyrahul done!


Automatic instruction performance evaluation tool / script

Currently the evaluation on instruction convert is quite hard.
The way in dogbolt is good, but just can do one or several instructions at a time and need lots of code writting.
Would suggest to develop a script to do some kind of automatic way of compile and count the asm insts. This should help a lot and provide ideas on initial performance of the instructions.

Thanks @wuye0109 ! Yes, even a one-time report sorted by the number of instructions generated for a large number of compiler and build option combinations would be very useful to highlight places to optimize.
An automated check for every PR would be even better! We would be able to catch regressions and evaluate new instruction implementations much more easily than we do now.

This sounds a lot like #349, maybe we should close this in favor of that issue?
That issue is a lot more ambitious, but the first part is basically what you've described above.  Note that it's not just the instruction count we need to be concerned about; some instructions are much more expensive than others.  Raw instruction count correlates to performance, but it's not a hard rule.  LLVM MCA should provide much more accurate estimates.
While this would be really nice to have, I don't think this is something that I'll have time to get to in the foreseeable future.

This sounds a lot like #349, maybe we should close this in favor of that issue?
That issue is a lot more ambitious, but the first part is basically what you've described above.  Note that it's not just the instruction count we need to be concerned about; some instructions are much more expensive than others.  Raw instruction count correlates to performance, but it's not a hard rule.  LLVM MCA should provide much more accurate estimates.
While this would be really nice to have, I don't think this is something that I'll have time to get to in the foreseeable future.

Yes, just look at #349, this topic is already discussed and it is same thing. So closed this issue and we can direct to #349 for this idea.


Some remarks/questions about the documentation

Category\EOP anti-spam policy settings: Should the Phishing email settings be mentioned here? and I didn't find any specific setting for High Confidence Phish email detection
Category\Safe link settings: Does disabled mean that the check box is selected, or does it mean that the checkbox should be enabled, since the setting is called: "Do not track when users click safe links and Do not let users click through safe links to original mail

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0c77e1cb-1509-83cc-7c2a-564d5e3e91ea
Version Independent ID: 9f07278c-37ab-beac-a5dd-fa4f4825b3a4
Content: Microsoft recommendations for EOP and Office 365 ATP security settings, recommendations, Sender Policy Framework, Domain-based Message Reporting and Conformance, DomainKeys Identified Mail, steps, how does it work, etc
Content Source: microsoft-365/security/office-365-security/recommended-settings-for-eop-and-office365-atp.md
Service: o365-seccomp
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

Thank you for noting that there is some phishing data in anti-spam right now. That's noted. This document is a work in progress, and changes are being considered even now. Some Phish functions will remain in the anti-spam section because it resides in the antispam policy now. Finally, 'disabled' in your example means you should not check the box. I hope this helps! Thanks for your comment here!


Child Application Context AOT Support

I'm opening this Feature Request to go with https://github.com/spring-projects-experimental/spring-native/issues/766 and https://github.com/spring-projects/spring-framework/issues/28486 cases and see
if we have any estimate of when we will have a compatible version.

Any news about the ongoing of this case?

This has already been implemented for the use-case that is present in SC Commons, which is load-balancing, within this PR.


Move Pulse btn rules from _shine.less to _pulse.less

I moved the Pulse button rules in _shine.less to a new file named _pulse.less

Issue: #168

I think it's ready now. Sorry for the import, I did the whole thing again due to a bad prettier install.
I don't have much experience with npm... 🤦♂

Great! Thank you.
@all-contributors please add @JoanRosell for code


Update to 2.7.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Report cluster startup failed

We need to report error in case some of cluster could not start at all.
Signed-off-by: Andrey Sobolev<EMAIL_ADDRESS>Description
Update CloudTest app to generate junit.xml report entry in case all instances of configured cluster could not start.
Motivation and Context
To make our CI testing more clean.
How Has This Been Tested?

[x] Covered by existing integration testing
[ ] Added integration testing to cover
[x] Tested locally
[ ] Have not tested

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@edwarnicke  @nickolaev Build should fail if we could not start any cluster for public cloud configuration. Will wait for review, before will re-trigger. Thanks,


Generating html report in selenium with c# on vs

   OneTimeSetUp: System.InvalidCastException : Unable to cast object of type 'NicholasTestProject1.EntentHtmlReporter' to type 'AventStack.ExtentReports.Core.IExtentReporter'.

@Amodunicholas Can you add a link to the article you were following when you encountered this?


AutoConnectAsync error: Timed out trying to read data from the socket stream!

busy trying to look at the source code to see if i can see why the below happens
Error	Failed Timed out trying to read data from the socket stream!
System.TimeoutException: Timed out trying to read data from the socket stream!
 at FluentFTP.FtpSocketStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)
 at FluentFTP.FtpSocketStream.ReadLineAsync(Encoding encoding, CancellationToken token)
 at FluentFTP.FtpClient.GetReplyAsync(CancellationToken token)
 at FluentFTP.FtpClient.HandshakeAsync(CancellationToken token)
 at FluentFTP.FtpClient.ConnectAsync(CancellationToken token)
 at FluentFTP.FtpClient.AutoDetectAsync(Boolean firstOnly, Boolean cloneConnection, CancellationToken token)
 at FluentFTP.FtpClient.AutoDetectAsync(Boolean firstOnly, Boolean cloneConnection, CancellationToken token)
 at FluentFTP.FtpClient.AutoConnectAsync(CancellationToken token)

trying to see the source code for GetReplyAsync cant see it/ find it

this is with latest version 36.0.0
ok found it
https://github.com/robinrodricks/FluentFTP/blob/d9d9945ce0c77f90408e06dfc4f009af4d879839/FluentFTP/Client/FtpClient_Stream.cs
which then goes to
https://github.com/robinrodricks/FluentFTP/blob/d9d9945ce0c77f90408e06dfc4f009af4d879839/FluentFTP/Streams/FtpSocketStream.cs#L597
and well then that exception...

@robinrodricks
defiantly something funky with the AsyncConnect...

it connects with normal Connect in about 35 secs.
but seems to hang... i increased the timeouts on the Async version as I get
"Timed out trying to read data from the socket stream!" otherwise....
is there something you think im going incorrectly, PS if i use an ftp connection which connects faster... aka closer...
then it connects.. but not with this client which takes like 40 secs

not sure who to debug this source code
but one thing i can see is isnt
while (await ReadAsync(buf, 0, buf.Length, token) > 0) {
				data.Add(buf[0]);
				if ((char) buf[0] == '\n') {
					line = encoding.GetString(data.ToArray()).Trim('\r', '\n');
					break;
				}
			}

meant to be , not the extra brackets
while ((await ReadAsync(buf, 0, buf.Length, token)) > 0) {
				data.Add(buf[0]);
				if ((char) buf[0] == '\n') {
					line = encoding.GetString(data.ToArray()).Trim('\r', '\n');
					break;
				}
			}

@robinrodricks  could you tell me what the intended why is to debug.. the source code... aka download source code, then add configuration manager ASYNC, problem i face when selecting this is i get all sorts of build issues, so not sure how im meant to get the config for ASYNC as the selected option, is there a guide setup?

ok i figure out most of it...
i was using AutoConnectAsync(ct) which then does thing i didnt expect but to be fair i should read more
anyway what ive found is by increasing timeouts you just prolong the one which would fail! as it tries more than 1,
aka its going through all till it find 1 which works, it just so happens that the first 1 it tries is wrong and fails... cool.
at this point increasing the timeout just makes it look like its hanging.
leaving the timeout to 15 secs... it will then fail... BUT more coming
public override async Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken token)
{
	if (BaseStream == null) {
		return 0;
	}

	m_lastActivity = DateTime.Now;
	using (var cts = CancellationTokenSource.CreateLinkedTokenSource(token))
	{
		cts.CancelAfter(ReadTimeout);
		cts.Token.Register(() => Close());
		try {
			var res = await BaseStream.ReadAsync(buffer, offset, count, cts.Token);

			// CTS for Cancellation triggered and caused the exception
			if (token.IsCancellationRequested)
			{
				throw new OperationCanceledException("Cancelled read from socket stream");
			}

			//CTS for Timeout triggered and caused the exception
			if (cts.IsCancellationRequested)
			{
				throw new TimeoutException("Timed out trying to read data from the socket stream!");
			}
			return res;
		}
		catch (Exception ex)
		{
			// Nothing of the above. So we rethrow the exception.
			throw;
		}
	}
}

if these lines are there...
if (token.IsCancellationRequested)
{
throw new OperationCanceledException("Cancelled read from socket stream");
}

//CTS for Timeout triggered and caused the exception
if (cts.IsCancellationRequested)
{
throw new TimeoutException("Timed out trying to read data from the socket stream!");
}

then it does not try the next config getting's. and never get to the 1 which would work.
aka just commenting these lines out make it then at least try the next auth and protocols, which then works perfectly

Can you try this and see if it works?
https://www.nuget.org/packages/FluentFTP/37.0.0

@robinrodricks  thx i tired the latest, at least there are no buld issues now, thx
now that I'm more familiar with the project i could check it faster...
In tests, see

No changes...
the strange thing is! that if u just Run this its passes, but if u debug it fails.
put a break point on this catch

it should hit this more than once.... as the point of auto is that it should try each until it fails....
but on first catch it exists...
but what is amazing!!! is removing

makes it work... you should be able to implement the correct logic with this information.

my guess is the timeout token is not reset when retrying.. next connection..
aka each attempt should have at least the default timeout 15 secs, my guess is that
token.CandellationRequest is triggering... before it even has the time to go through the connections.

@jnyrup, project owner seems busy atm, could you confirm what I'm saying.

HI @jnyrup, thanks for looking sozs there is a lot going on before as i was trying to figure out what is going on....
What I'm saying is;

download, latest repo...
2 Run TestAutoConnectAsync in debug

does it pass....? it fails for me and does not do what I except when trying to follow the logic...aka it never loops over the other connection settings.
but removing the throw inside the catch, then allows it to try the other connection settings which then allows it to pass...

I tried running TestAutoConnectAsync compiled in debug mode for the net50 target framework and it passed.
I tried both with and without a debugger attached and it made no difference.

I didn't set any break points.
Settings break points would increase the risk of a timeout, which from your initial stack trace seems to be the problems you're experiencing.
There are a plenty of reasons why a test could work on one machine but fail on another.
While deeply frustrating it's unfortunately not uncommon.
These tests makes a real internet connection, which makes them unstable.
E.g. if you turn off the WIFI while running the test will fail.

@Seabizkit
I would recommend closing this. The description "where is the implementation of GetReplyAsync" and the entire evolution of the documentation does not motivate well to understand the actual problem you are trying to solve.
Please reopen this as a new issue documenting what your real problem is, in a concise fashion.
Is the problem:
Connect does not work?
Connect does not work if in debug mode?
Test do not work?
I gave up after a while. Sometimes a fresh start will be the best way to succeed.

I'm sorry, I don't follow what you're trying to say and I don't have the time to try to figure it out.
I agree with everything @FanDjango wrote above.
I can recommend reading https://stackoverflow.com/help/minimal-reproducible-example for tips on how write a good question.
If you haven't already read the documentation of this library, please see https://github.com/robinrodricks/FluentFTP/wiki#3-logging-and-troubleshooting

@FanDjango

Connect does not work?

AutoConnectAsync doesn't work 100% not even 50% of the time.

Connect does not work if in debug mode?
AutoConnectAsync
A little more complex to answer, sometime passes sometimes fails,

Test do not work?
test validates what I was experiencing in my own code. TestAutoConnectAsync has the same experience.

I gave up after a while. Sometimes a fresh start will be the best way to succeed.
perhaps but was simple trying to try work through this massive lib.
I'm surprised that no 1 else is see the same results, needed some validation...
Honing down on what is happening.... giving details may help uncover what is happening, if i knew it would be easy and i wouldnt be here.

Ok. Lets be systematic.
If not in debug mode, AutoConnectAsync fails always.
Questions:
Only for this one server, or for many servers or for all servers?
Does AutoConnect (not async) work? I am assuming: yes.
Can you put together a minimum piece of code that tries to autoconnect, post this here and also the log?
Then you posted:

but what is amazing!!! is removing

and an image

makes it work... you should be able to implement the correct logic with this information.

Question: Removing what? Are you saying: Removing the comments makes it work? Do you realize what that sounds like?

Afaik there is no difference in debug/release code, so the lib should have matching behavior regardless of build flags. Maybe just some .net exception handling is different in these modes, which may be triggering an edge case.

@FanDjango  and @jnyrup, firstly, thank you guys for responding on issues faced by other users, I appreciate it.
I agree with the both of you. The issue makes no sense to me either.
@Seabizkit can you please confirm if AutoConnect works and the async API does not work. Is this the crux of your question?

In my case the problem is the async version of AutoConnect(), it does not honor the timeout settings. If I wrap the sync version into await Task.Factory.StartNew(client.AutoConnect) then the timeout values are honored.

In my case the problem is the async version of AutoConnect(), it does not honor the timeout settings. If I wrap the sync version into await Task.Factory.StartNew(client.AutoConnect) then the timeout values are honored.

So please post this as a new issue. Random issues posted to existing threads are not observed.

Closing this. Stale issue


Infinite loop with latest remix version

Hello there!
I just tried to implement your package with existing project with instructions provided in Readme file and also checked example dir how it's done.
I have latest remix version 2.11.1 and after start dev server I got infinite loop of requests.

Added new route /test and removed root loader to make sure that it's not something on my side. I saw that remix 2.11.0 introduced some infinite loop but they patched with 2.11.1 so I am not sure if that's somehow connected or not.
Vite version is 5.3.5 and remix-hono 0.0.16

I have a pending PR to move the Remix dependency as a peer so it doesn't interfere (I only use types though). Do you see 2.11.0 in your package-lock or equivalent?
I will push this new version now if it helps.

npm i https://pkg.pr.new/rphlmr/react-router-hono-server@1 to test it if you want.
Remix hono and hono should not be mandatory in the future 0.0.3

Check this out. Seems that remix-hono brings that 2.11.0 server runtime

Check "node_modules/@remix-run/server-runtime" this is what has been resolved. I'm trying to force peers for 2.11.1 min

Ok so:
I removed remix-hono and hono as dependecies, added https://pkg.pr.new/rphlmr/react-router-hono-server@1  version, removed pnpm-lock / node_modules, fresh install and I can confirm that local dev is now working without infinite loop.

Wow, thanks. I’m finishing my PR and will release it next

Just tested build and start, no issues so far! :)
I guess it will work also once I build in Docker and deploy it.

0.0.3 has been released!
https://github.com/rphlmr/react-router-hono-server/releases/tag/v0.0.3
I hope it definitely fixes the issue. Thanks for reporting it. 🫡


Make "new windows" appear neatly

Describe the bug
The folder is opened in a new window (or a new window of any software). When the next file is often opened, it will easily appear on the other side of the screen, and it is also a different size from the previous window, which is not the same size as expected.
This "new window" jumping around can easily cause discomfort to the user
To Reproduce
Steps to reproduce the behavior:

Open any software. e.g. Terminal ,Falkon
Select the new window in the Top menu and repeat 2-7 times
See error

Or

Open from the hard disk'Startvolume' on the desktop.
Open the files one by one until this file e.g. :/usr/local/etc/devd/
See error

Expected behavior
It should be arranged neatly, no matter where the new window is moved, it can still be arranged neatly.
e.g.

Screenshots

Version (please complete the following information):

Live ISO and installed
FreeBSD version  12.2
helloSystem build https://github.com/helloSystem/ISO/releases/tag/experimental-12.2 0F28
Running in a virtual machine: no

Computer (please complete the following information):

Device: Acer Aspire 3810T

Additional context
No.

For Filer this is intended behaviour. Windows stay right where you left them, even when they're closed.
For other apps KWin should fix this.

For Filer this is intended behaviour. Windows stay right where you left them, even when they're closed.

But opening the next folder will be a different place on the screen.

With KWin (0.6.0 build 0F...) this should work as expected ("stacked").

They are neatly arranged in 0I46, but if multiple windows touch the lower left edge of the screen, the new windows will start to be misplaced.


Kiwix.WikiMed version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

The relevant bit of the logs:
2022-04-24 12:45:15.994 [CORE] Valid settings file not found. Using default values.
2022-04-24 12:45:15.994 [CORE] WinGet, version [1.1.12653], activity [{E58EE5BA-2CDF-4D8D-9E8A-74A431505F1B}]
2022-04-24 12:45:15.995 [CORE] OS: Windows.Desktop v10.0.19042.1052
2022-04-24 12:45:15.995 [CORE] Command line Args: C:\Users\validator\AppData\Local\Microsoft\WindowsApps\winget.exe install --manifest D:\TRANSFER\8e5f03dd-06c4-ec11-9509-000d3a9ed19d\Manifest.yaml --accept-package-agreements
2022-04-24 12:45:15.995 [CORE] Package: Microsoft.DesktopAppInstaller v1.16.12653.0
2022-04-24 12:45:15.997 [CORE] IsCOMCall:0; Caller: winget-cli
2022-04-24 12:45:16.029 [CLI ] WinGet invoked with arguments: 'install' '--manifest' 'D:\TRANSFER\8e5f03dd-06c4-ec11-9509-000d3a9ed19d\Manifest.yaml' '--accept-package-agreements'
2022-04-24 12:45:16.029 [CLI ] Found subcommand: install
2022-04-24 12:45:16.029 [CLI ] Leaf command to execute: root:install
2022-04-24 12:45:16.043 [CLI ] Executing command: install
2022-04-24 12:45:16.047 [CLI ] Manifest fields: Name [WikiMed by Kiwix], Version [<IP_ADDRESS>]
2022-04-24 12:45:16.053 [CLI ] Starting installer selection.
2022-04-24 12:45:16.053 [CLI ] Completed installer selection.
2022-04-24 12:46:18.708 [FAIL] AppInstallerCLI.exe!00007FF65A8F0672: LogHr(1) tid(1300) 80072EFF
2022-04-24 12:46:18.718 [FAIL] AppInstallerCLI.exe!00007FF65A9061F2: ReturnHr(1) tid(108c) 80072EFF     Msg:[winrt::hresult_error: The text associated with this error code could not be found.]

2022-04-24 12:46:18.739 [FAIL] D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\MsixInfo.cpp(150)\AppInstallerCLI.exe!00007FF65A7B5837: (caller: 00007FF65A765B49) Exception(1) tid(108c) 80072EFF
2022-04-24 12:46:18.740 [CLI ] Caught wil::ResultException: D:\a\_work\1\s\external\pkg\src\AppInstallerCommonCore\MsixInfo.cpp(150)\AppInstallerCLI.exe!00007FF65A7B5837: (caller: 00007FF65A765B49) Exception(1) tid(108c) 80072EFF

It's such a crazy error that there's no text associated with it.

OK, thanks @jedieaston . I'll try closing an re-opening the PR, to see if it validates correctly this time.

Local installation of the same file (downloaded from same source on Github) is working fine:


Improve package structure

Summary

Contents (#11)
Enhancements

Log version source file and mkver.conf file paths

Fixes

Update package entrypoint

Operations

Update version numbers

Refactoring

Move CLI into separate module
Simplify get_current_version function
Factor out version matching
Rename functions

Testing

Remove outdated tests
Split tests into two test classes

Other

Use development version of package

Codecov Report

Merging #11 (090b774) into main (541e45a) will decrease coverage by 0.49%.
The diff coverage is 93.67%.

:exclamation: Current head 090b774 differs from pull request most recent head 93ee739. Consider uploading reports for the commit 93ee739 to get more accurate results

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   93.75%   93.25%   -0.50%
==========================================
  Files           1        3       +2
  Lines          48       89      +41
==========================================
+ Hits           45       83      +38
- Misses          3        6       +3

Impacted Files
Coverage Δ

check_semantic_version/cli.py
85.71% <85.71%> (ø)

check_semantic_version/check_semantic_version.py
91.83% <92.30%> (-1.92%)
:arrow_down:

check_semantic_version/configuration.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Investigate (+ clean up) the external celo-monorepo and celo-blockchain deps in Rosetta

When building from source, the previous instructions required having a local version of the celo-monorepo and celo-blockchain. Investigate if these are necessary any more. They are both required for the make-gen-contracts command that generates contract bindings, but from early investigation, I think that isn't actually being used by Rosetta (in favor of kliento).
Motivation:

Getting rid of additional stuff in order to build from source would make it easier for folks to get set up (not need to build the monorepo + blockchain)
If it turns out we need them, we need to update this information + have a plan for dealing with contracts releases (i.e. making sure that the generated contracts versions correspond exactly to the versions of contracts on the different networks) and adding docs to the README for this

Estimate: probably around a day (perhaps a bit of additional time cleaning up + testing). This excludes time for dealing with contracts releases if it turns out we need the monorepo/blockchain dependencies to build from source.

@eelanagaraj is this more a headache for existing users or just a barrier for greater adoption of rosetta?

@aslawson both, but motivation here would be the former particularly in the context of testing out the new construction changes. Happy to provide more context on this as well, but generally: I think this has caused frustration for getting this set up on new environments, and this is something that has come up multiple times and feels like a "detoil" -- not urgent but will probably save us time down the line if we don't need folks to build the monorepo in particular.


Use DEPS file for checking out third party code.

This CL simplifies the DEPS file in SPIRV-Tools and removes all the Chrome stuff. The git-sync-deps script is also added which allows using the DEPS file and script to handle all the bot updates. The README.md is updated to make this the preferred way of syncing the external dependencies.

Closing this for now. We can re-open when we investigate getting auto-rolls up for the dependencies.


Login - logout templates missing?

I receive this error:
django.template.exceptions.TemplateDoesNotExist: registration/login.html
from the following line:
https://github.com/matthiask/django-authlib/blob/0c49aa7e9ef889f0c7862d5039bd1b12e780b3f9/authlib/views.py#L82
Are the templates missing?

Yes; django-authlib doesn't ship any templates. This is somewhat intentional; django.contrib.auth also references registration/login.html and doesn't ship such a template.
I'm not fundamentally opposed to shipping a set of templates but it should probably happen in a separate app, or for example in a new authlib.packages.registration_templates app (or something) to prevent the problem where django-authlib's templates would suddenly start overriding e.g. the templates used by django.contrib.admin by default (resp. depending on the ordering of INSTALLED_APPS)

By the way, https://docs.djangoproject.com/en/4.0/topics/auth/default/#django.contrib.auth.views.LoginView says:

It’s your responsibility to provide the html for the login template , called registration/login.html by default. This template gets passed four template context variables:

Oh, OK, indeed!
I had the impression that magic links would need a special template to work.
Actually, I have not yet grasped the idea of the procedure, but I will dive into the code, it is not so hard, thank you!

It is unbelievable how many things this code achieves with just a few lines.
Thank you for sharing!
Browsing it, is amazing and inspiring.

Wow, thank you! That's a really nice compliment ❤


Add Schema.const

Another thing I found useful and thought it might be useful here too 😅

Closing for age.


Clean ALCPlugFix folder

Hi,
I just successfully upgraded from 10.13 to 10.14. At first I had kernel panic when booting into MacOS Install partition but after upgrading my EFI folder to v1.2.8 it worked just fine.
After booting, I noticed that the ALCPlugFix wasn't working anymore. I remembered when first doing it it took me some tries to get it to work.
So I'm opening this issue to suggest to clean this folder a little.
From my experiences, install.sh doesn't work. Also, it's using relative path so you'd have to cd into that directory to make it works. It should be removed.
install.command works fine. It's using absolute path by defining path=${0%/*}. It also clears the kext caches. install双击自动安装.command is the equivalent of install.command and could be removed OR renamed to chinese_install.command (and then install.command would become english_install.command).
uninstall.command works. install双击自动卸载ALCPlugFix.command is the same as uninstall.command but with one more output (Uninstalling the ALCPlugFix daemon is complete!).
Here's my final files structure suggestions:
- fix/
- fix/ALCPlugFix
- fix/good.win.ALCPlugFix.plist
- fix/hda-verb
- english_install.command
- chinese_install.command
- english_uninstall.command
- chinese_uninstall.command
- README.md (so that there are instructions when browsing with github)

I can open a PR if you'd like.

Did you use the auto update via app store or you reinstalled the hackingtosh with 10.14 from scratch ?

@paajake auto update! Incredibly easy. I was ready for some struggle and got none.
My laptop is my main working computer so there are lot of stuffs installed. brew, apache, multiple php versions, ruby, python, node w/ n, npm etc etc. Running 2 external monitors (LG 24" UltraWide QHD + LG 29" Ultrawide FHD) with laptop's clamshell closed.
I just had to re-do the ALCPlugFix like I said, and that's it.

@orditeck Hi, thank you so much for your suggestion. If you have time, it would be really nice that you can open a PR.  install.sh is a legacy item and should be removed. I will add Credit in README.

It's the least I can do! PR #88


fix(native-filters): Fix native filters config modal

SUMMARY

This PR fix next flows:

There was regression, when you mark filter as Required it doesn't shows errors under filter and also not marks it with red (also FilterBar also FiltersConfigModal)

When user switch between filter types with Default Value some times it crashes dependent on what filter were changed

For filter without Column field it doesn't load default value

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@simcha90 is that behavior valid?

on range filter with default value with the full range it doesn't considered to be a default value

@simcha90 is that behavior valid?

on range filter with default value with the full range it doesn't considered to be a default value

yes it's valid as discussed with @villebro it means as unset value, it also behavior when you clicks Clear all

The removal of "Value is required" was not a regression. It was a design decision to eliminate the unnecessary spacing among filters. That's why we added the asterisk. This PR reintroduced the text and the spacing.

@simcha90 Can you please roll back to the previous behavior?
@villebro @junlincc @amitmiran137

@amitmiran137 @simcha90 Hi friends! according to the thread, we are seeing some regressions from this PR. To prevent this from happening Please do leave enough time for community reviews, and we would do the same :). One thing that could help the project is all parties to sync what feature goals we each wanna achieve on a weekly basis.
We try to stabilize this native filter for prime time, and are investing more resources into QA, we would love to help keeping the PR standard high by testing more, please simply leave us 48 for code reviews and testing.
cc @rosemarie-chiu @graceguo-supercat

Another regression found: the default value Select is not checked when there's a default value.
https://user-images.githubusercontent.com/70410625/124639865-09a6ff80-de63-11eb-9338-2a4e8f613f51.mp4

@simcha90 let's make sure we have both behavior reverted. many thanks 🙏

Hi @junlincc @michael-s-molina yep, you are right it's good point to wait for some more feedbacks before merge, I will take it in account for next PRs
About notes, because this PR fix some other behavioral bugs, I'd prefer create one new PR to fix your notes rather then revert this one, to fix your notes I have some questions:

About Spacing / Coloring:
We have here 2 features in one:
a. Adding red colors to filters dependent on the type of filter: like border for Select Filter or make Range Filter is red for required state - this feature is not affecting layout, only change color of the filters
b. Adding Value is required text and spacing between items - this feature affecting layout and add spacing, so we have 2 ways here:

Revert this text for all filters as you proposed in first
Add this text only when needed and in other cases just remove this space

Bug with initial value I'll create separate PR for it

@junlincc @michael-s-molina can you please give your input for first item? And I will create PR ASAP to fix it, thanks

1- About Spacing / Coloring:
a. Keep as it is with the red colors.
b. Remove the text only in the filter bar, not in the modal. The asterisk and the color are sufficient. We don't want the flick effect that happens when we add the text dynamically.
Thank you.

@michael-s-molina @junlincc
Hi, I created PR according your proposals: https://github.com/apache/superset/pull/15572
Can you please review it and give your input? Thanks...

Hello, I started front end engineering in the superset-frontend folder, but get lots of errors.

In the superset-frontend folder, npm ci
npm run dev-server
98% of the process, get lots of errors, includes the type error of the data and the error not found by the module

It should be unable to parse JSX, But how do I need to solve it?Looking forward to your reply


Gradle: Unable to instantiate JDBC driver declared as buildscript dependency

What version of Flyway are you using?
4.1.1
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Gradle plugin
What database are you using (type & version)?
MariaDB 5.5.52
What operating system are you using?
MariaDB server on CentOS, grable build on Windows 8
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
trying to run flywayInfo, flywayMigrate tasks. It worked with all Flyway versions from 4.0 to 4.1.0 and now fails with 4.1.1
What did you expect to see?
Succesful build
What did you see instead?
Build fails with "Unable to instantiate JDBC driver: com.mysql.cj.jdbc.Driver : com.mysql.cj.jdbc.Driver".
This looks very similar to the issue #1527 , the difference is that we're using mariadb jdbc driver, and dependence is declared via buildscript->dependencies:
buildscript {
    repositories {
        maven {
...
        }
        mavenCentral()
    }
    dependencies {
...
        classpath 'org.flywaydb:flyway-gradle-plugin:4.1.0'    // 4.1.1 fails with "unable to instantiate jdbc driver com.mysql.cj.jdbc.Driver"
        //classpath 'mysql:mysql-connector-java:5.1.38'
        classpath 'org.mariadb.jdbc:mariadb-java-client:1.5.8'
    }
}

apply plugin: 'org.flywaydb.flyway'
...

So why you close this issue? In your commit there is nothing about the buildscript-block and loading any classpath dependencies from it. It works not with 5.1.4. And not all project have compile, runtime or other java dependency configuration in gradle. Only java based project have these scope by default. So please adjust your Docu or fix this bug or provide some comment what users should do if they upgrade...

@dzwicker Please file a new issue with clear steps how to reproduce.


[Storage] az storage blob copy start: Fix issue in copy from different account

Description

Fix #18539
With copy start moving to track2 SDK, we need to change the replied validators, too. In previous validator, sas generation is using track1 sdk and now we need to change to track2 SDK.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

/azp run

Storage


Wrong dialog icon for "Wallet to be encrypted"

The used icon in the "Wallet to be encrypted" is rather one used for "errors":

Ideally there is a non-red icon so people aren't thinking something went wrong.

On the other hand, we might want to use a warning icon to make people actual read the content... so unsure if we should fix this.

I'd say this was intentional

Hmm, I've got a yellow triangle:

The red circle is the default icon for QMessageBox::critical, which would make this an interesting quirk. Also, it's entirely possible that what is shown is a QMessageBox::warning with the wrong icon being passed because of your systems GTK cache files. Certain GTK themes can influence what icon actually comes up as Qt >5.7 implemented a feature that uses the system's GTK cache files to load some icons. For example, I can get this white error symbol to come up:

To stay consistent, we could just provide our own custom icon via:
QMessageBoxName.setIcon(QMessageBox::setIconPixmap(arg))

@jarolrod

... as Qt >5.7 implemented a feature that uses the system's GTK cache files to load some icons.

Could elaborate?


feature(maps): refactor Maps

Refactor Maps in maps package:

Make the method a bit more generic, returning the whole layergroup --> Get layergroup.metadata.tilejson.vector.tiles to consume MVT tiles
Manage request with GET or POST, based on size
Allow custom server URL
Add a simple index.html for manual tests

This completes the pending refactor started at https://github.com/CartoDB/toolkit/pull/7

@jesusbotella I've done several changes thx to the previous CR. If you're ok with it, we can merge it.

So, you didn't like it before? :trollface:

I said really :trollface:


Make events easy to copy

🚀 Feature
the ability to copy/deepcopy events
Motivation
When writing a mouse callback within napari, a nice pattern is to provide a utility function which takes mouse event(s) as input (as done for the labels layer by @jni). This means these utilities can be reused by users writing their own custom functionality.
https://github.com/napari/napari/blob/3e72711007728e3c420985151b793a67a28a0096/napari/layers/labels/_labels_utils.py#L171-L192
Drag callbacks often depend on the initial as well as the final state. Currently, the Event object is updated and its attributes overwritten during the callback, it is up to the user to store each variable they want later in the first part of the callback. For custom functionality within a drag, it would be nice to be able to quickly make a copy of an event which can be passed to a utility function during the drag functionality
Pitch
An implementation of __copy__ and __deepcopy__ on the Event object.
Additional context
This has only recently become something that might be particularly useful with the extra attributes on mouse events related to 3D interactivity in #3037, previously, only the position would need to be stored which was pretty simple
cc @kevinyamauchi

Currently, the Event object is updated and its attributes overwritten during the callback, it is up to the user to store each variable they want later in the first part of the callback. For custom functionality within a drag, it would be nice to be able to quickly make a copy of an event which can be passed to a utility function during the drag functionality

I believe vispy supported this and then we didn't expose it. It might be worth looking at what they did


OBDA disappears when I change the ontology

Hi,
mapping disappear when I change ontology
Steps to Reproduce
Open an ontology using Protege and load the dependencies,
Move to another ontology,
Return to the previous ontology,
There is mapping no more.
Expected behavior:
I need to work in many ontologies at the same time, when I change I would like to see the appropriate mapping.
Actual behavior:
If I change ontology, the mapping disappear.
Reproduces how often:
Always
Attached material
If I save after changing the ontology, the OBDA file is overwritten with an empty one.
http://g.recordit.co/GfO49sa1RF.gif

Hi, we never worked with multiple ontologies in Protege before, and we will look into the issue your reported.
Btw, I like the way you report the bug via GIF. This communicates the problem immediately,.

I have suffered this issue too.  My Ontology has some imports and when I switch to one of those I have lost my work.

Fixed with 478b0a660f6f1e98e660d9c75bcce5d4a7bd5f72.