Copying ACL's - Unexpected Results

Hi Folks
Module Version: 3.7.2
OS: Windows 2019
Possibly related to #113
I have downloaded and am using the updated .dll from #113
Using the following code snippet I'm not getting the expected results.
$template = 'Test Template'
$SourceACL = Get-CertificateTemplate -Name "WebServer" | Get-CertificateTemplateAcl
$DestinationACL = Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl | Remove-CertificateTemplateAcl -Force
$DestinationACL | Add-CertificateTemplateAcl -AcessRule $SourceACL.Access | Set-CertificateTemplateAcl | Out-Null

Before making any changes I get this:
PS C:\Windows\system32> (Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl).Access

CertificateTemplateRights : Read, Write
Rights                    : Read, Write
AccessControlType         : Allow
IdentityReference         : NT AUTHORITY\Authenticated Users
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, FullControl
Rights                    : Read, Write, FullControl
AccessControlType         : Allow
IdentityReference         : CONTOSO\Domain Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, FullControl
Rights                    : Read, Write, FullControl
AccessControlType         : Allow
IdentityReference         : CONTOSO\Enterprise Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

When running my code snippet above, $SourceACL.Access has the following values and these are what I expect:
PS C:\Windows\system32> $SourceACL.Access

CertificateTemplateRights : Read
Rights                    : Read
AccessControlType         : Allow
IdentityReference         : NT AUTHORITY\Authenticated Users
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, Enroll
Rights                    : Read, Write, Enroll
AccessControlType         : Allow
IdentityReference         : CONTOSO\Domain Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, Enroll
Rights                    : Read, Write, Enroll
AccessControlType         : Allow
IdentityReference         : CONTOSO\Enterprise Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

After running my code snippet above, the ACLs have changed, but are not what I expect:
PS C:\Windows\system32> (Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl).Access

CertificateTemplateRights : Read, Write
Rights                    : Read, Write
AccessControlType         : Allow
IdentityReference         : NT AUTHORITY\Authenticated Users
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Write, Enroll, Autoenroll
Rights                    : Write, Enroll, Autoenroll
AccessControlType         : Allow
IdentityReference         : CONTOSO\Domain Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Write, Enroll, Autoenroll
Rights                    : Write, Enroll, Autoenroll
AccessControlType         : Allow
IdentityReference         : CONTOSO\Enterprise Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

Note that if I run the following code, all the permissions are removed and I have to use ADSI Edit to fix the object up in AD so I can access it, it is no longer visible in the to PowerShell or via the Certificate Template Console.  I think this is the expected outcome and I ran it just to test the individual lines of my snippet above.
Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl | Remove-CertificateTemplateAcl -Force | Set-CertificateTemplateAcl

Am I doing something wrong or is there a bug here?
Thanks!
PS:  Perhaps related, the code is also not removing inheritable permissions, I haven't dug into that in any detail but the results above show IsInherited being false and my first assumption is inheritable permissions should be removed, but I haven't really thought that through in detail.   In my tests above I have manually removed inheritable permissions via ADSIEdit before running the examples and I haven't fully tested this.

Hi, I'm not really understand the problem you are facing. The snippet from the top is working just fine. Last snippet indeed removes all ACEs from security descriptor and you have to use ADSIEdit to use owner rights and re-gain access to certificate template.

Perhaps related, the code is also not removing inheritable permissions

From my understanding, certificate templates use only explicit permissions on every template. There is no template (at least from default list) that inherits permissions from parent container? Can you tell more about your configuration:

What permissions you have before modification
Code you are running to modify permissions
Actual results
Expected results

On the inheritable permissions ...
I'm using ADCSTemplate to import certificate templates and it seems to create them with inheritable permissions.  I don't seem to get inheritiable permissions when using the the Certificate Template Console, so perhaps its an issue with ADCSTemplate.
As noted in my original post, I haven't dug into this in to much detail at the moment.

Hi
Here is the full process of what I'm doing, including the template export and subsequent import ... I've repeated much of what is above for clarity.  I hope this is answering your question?
Step 1 - Manually copy a suitable default template to create two new templates using the Certificate Template Console, adjusting properties as required.
Step 2 - Export templates from the development PKI environment so I can deploy the templates to other PKI environments:
Install-Module ADCSTemplate -Force

$ExportPath = 'C:\Temp\PKITemplates'

if (-not (Test-Path -Path $ExportPath)) {
    New-Item -Path $ExportPath -ItemType Directory | Out-Null
}

$Templates = @(
    'Test SSL Certificate Template'
    'Test Code Signing Template'
)

foreach ($template in $Templates) {
    $fileName = "$(($template -replace ' ', '').Trim()).json"
    Export-ADCSTemplate -DisplayName $template | Set-Content -Path "$ExportPath\$fileName"
}

Step 3 - Import the templates into a new environment
Install-Module ADCSTemplate -Force

$ImportPath = 'C:\Temp\PKITemplates'

$Templates = @(
    'Test SSL Certificate Template'
    'Test Code Signing Template'
)

foreach ($template in $Templates) {
    $fileName = "$(($template -replace ' ', '').Trim()).json"
    New-ADCSTemplate -DisplayName $template -JSON (Get-Content "$ImportPath\$fileName" -Raw)
}

After this step the permissions on the two new templates look like this:
PS C:\Windows\system32> (Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl).Access

CertificateTemplateRights : Read
Rights                    : Read
AccessControlType         : Allow
IdentityReference         : NT AUTHORITY\Authenticated Users
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, FullControl
Rights                    : Read, Write, FullControl
AccessControlType         : Allow
IdentityReference         : NT AUTHORITY\SYSTEM
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, FullControl
Rights                    : Read, Write, FullControl
AccessControlType         : Allow
IdentityReference         : CONTOSO\Domain Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, FullControl
Rights                    : Read, Write, FullControl
AccessControlType         : Allow
IdentityReference         : CONTOSO\Enterprise Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

NOTE: The new templates also have permissions that are being inherited, but let's ignore that for now.
Step 4 - Fix up permissions:
foreach ($template in $Templates) {
    $SourceACL = Get-CertificateTemplate -Name "WebServer" | Get-CertificateTemplateAcl
    $DestinationACL = Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl | Remove-CertificateTemplateAcl -Force
    $DestinationACL | Add-CertificateTemplateAcl -AcessRule $SourceACL.Access | Set-CertificateTemplateAcl | Out-Null
}

After running this step the permissions on my new templates look like this (they have changed from what they were earlier).
PS C:\Windows\system32> (Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl).Access

CertificateTemplateRights : Read, Write
Rights                    : Read, Write
AccessControlType         : Allow
IdentityReference         : NT AUTHORITY\Authenticated Users
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, Enroll, Autoenroll
Rights                    : Read, Write, Enroll, Autoenroll
AccessControlType         : Allow
IdentityReference         : CONTOSO\Domain Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, FullControl, Enroll, Autoenroll
Rights                    : Read, Write, FullControl, Enroll, Autoenroll
AccessControlType         : Allow
IdentityReference         : CONTOSO\Enterprise Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

However, the permission on the WebServer template that I'm using as a source location to copy permissions from look like this.
PS C:\Windows\system32> (Get-CertificateTemplate -DisplayName 'Web Server' | Get-CertificateTemplateAcl).Access

CertificateTemplateRights : Read
Rights                    : Read
AccessControlType         : Allow
IdentityReference         : NT AUTHORITY\Authenticated Users
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, Enroll
Rights                    : Read, Write, Enroll
AccessControlType         : Allow
IdentityReference         : CONTOSO\Domain Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, Enroll
Rights                    : Read, Write, Enroll
AccessControlType         : Allow
IdentityReference         : CONTOSO\Enterprise Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

I also get this result if I output $SourceACL.Access from the code above (as I would expect).  You can see the actual permissions on the new templates does not match the permissions on the WebServer certificate template (that is correct in $SourceACL.Access).  NT AUTHORITY\SYSTEM does get removed, but the permissions for the remaining objects are not what I expect and don't match the WebServer certificate template.
If I repeat the process and use ADSI Edit to remove the inheritable permissions before running step 4 above (selecting the option to convert all inheritable permissions to direct permissions) the permissions look like this (same as above):
PS C:\Windows\system32> (Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl).Access

CertificateTemplateRights : Read
Rights                    : Read
AccessControlType         : Allow
IdentityReference         : NT AUTHORITY\Authenticated Users
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, FullControl
Rights                    : Read, Write, FullControl
AccessControlType         : Allow
IdentityReference         : NT AUTHORITY\SYSTEM
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, FullControl
Rights                    : Read, Write, FullControl
AccessControlType         : Allow
IdentityReference         : CONTOSO\Domain Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

CertificateTemplateRights : Read, Write, FullControl
Rights                    : Read, Write, FullControl
AccessControlType         : Allow
IdentityReference         : CONTOSO\Enterprise Admins
IsInherited               : False
InheritanceFlags          : None
PropagationFlags          : None

If I now run Step 4, having removed the inheritable permissions, the resulting permissions look like this (different from above, but still not the expected result ...):

Import the templates (Step 3 above).
Use ADSI Edit to remove inheritiable permissions
Use ADSI Edit to remove all permissions and give Enterprise Admins 'Full Controll'
Run the following code

Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl | Remove-CertificateTemplateAcl -Force | Add-CertificateTemplateAcl -Identity 'CONTOSO\Enterprise Admins' -AccessType Allow -AccessMask Read | Set-CertificateTemplateAcl
Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl | Add-CertificateTemplateAcl -Identity 'CONTOSO\Enterprise Admins' -AccessType Allow -AccessMask Write | Set-CertificateTemplateAcl
Get-CertificateTemplate -DisplayName $template | Get-CertificateTemplateAcl | Add-CertificateTemplateAcl -Identity 'CONTOSO\Enterprise Admins' -AccessType Allow -AccessMask Enroll | Set-CertificateTemplateAcl

The result from line 1 and 2 from this snippet looks okay, the template gets read and write permissions only.  When I run the third line to configure 'enroll' things break and I have to use ADSI Edit to fix them as the template is no longer available to PowerShell or the Certificate Template Console.
I hope this information is useful and I'm not missing something obvious.

Looks like I see the problem and can replicate.

Awesome.  Thanks for the your efforts here!

A small update (not related to this issue, but same subject): https://github.com/PKISolutions/PSPKI/issues/130

Another related: https://github.com/PKISolutions/PSPKI/issues/131

Another related: https://github.com/PKISolutions/PSPKI/issues/132

After all, it seems, the issue is fixed (after my quick tests). Would you like to test patched DLL in your environment? I still haven't looked at inherited permissions (I strongly believe it is not supported to have inherited permissions on templates), but with explicit permissions looks working.
Extract ZIP and replace the DLL in module's Library folder.
SysadminsLV.PKI-v<IP_ADDRESS>.zip

Finally, got it working. Please, check if this DLL works for you:
SysadminsLV.PKI-v<IP_ADDRESS>.zip

That appears to be working for me thank you!  With the updated .DLL I am now getting the results I expect when both copying ACLs to a new template or attempting to set new permission on a certificate template.
I still have to deal with inheritable permissions separately using ADSI Edit and not in my script.

Thanks for confirming this!

@jimchurches  I was facing the same problem with inheritable permissions on new templates created outside of the console. Maybe you can use this sample code for removing inheritable permissions:
# Set permissions for deployment account before remove inheritance
Get-certificateTemplate -Name "$NewTemplateName" | Get-CertificateTemplateAcl `
| Add-CertificateTemplateAcl -User $DeploymentAccount -AccessType "Allow" -AccessMask Read, Write `
| Set-CertificateTemplateAcl -Verbose

# Remove Inheritance from new template.
<#
isProtected Boolean
true to protect the access rules associated with this ObjectSecurity object from inheritance; false to allow inheritance.

preserveInheritance Boolean
true to preserve inherited access rules; false to remove inherited access rules. This parameter is ignored if isProtected is false.
#>
$template = Get-certificateTemplate -Name "$NewTemplateName" -ErrorAction Stop -verbose
$adsi = [ADSI]("LDAP://" + $template.DistinguishedName)
$adsi.ObjectSecurity.SetAccessRuleProtection($true, $false)
$adsi.CommitChanges()

# Set wanted permissions
Get-certificateTemplate -Name "$NewTemplateName" | Get-CertificateTemplateAcl  `
| Add-CertificateTemplateAcl -User "Domain Admins", "Enterprise Admins", $CATemplMgr -AccessType "Allow" -AccessMask Read, Write  `
| Set-CertificateTemplateAcl  -Verbose

Get-certificateTemplate -Name "$NewTemplateName" | Get-CertificateTemplateAcl  `
| Add-CertificateTemplateAcl -User $inputTemplate.DomainLocalGroupName -AccessType "Allow" -AccessMask $inputTemplate.AccessMask  `
| Set-CertificateTemplateAcl -Verbose

# Remove temporary deployment account permissions
Get-certificateTemplate -Name "$NewTemplateName" | Get-CertificateTemplateAcl  `
| Remove-CertificateTemplateAcl -User $DeploymentAccount -AccessType "Allow" `
| Set-CertificateTemplateAcl  -Verbose

Fixed in v4.0.0


ModuleNotFoundError: No module named 'tensorflow.python'

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 64bit
TensorFlow installed from (source or binary): binary
TensorFlow version: 2.3
Python version: 3.7.7
Installed using virtualenv? pip? conda?: Neither pip or conda worked
CUDA/cuDNN version: 10.1, V10.1.243
GPU model and memory: Nvidia GeForce 960M Notebook

Describe the problem
I get this when I import tensorflow:

Traceback (most recent call last):
File "", line 1, in
File "C:\Users\nicol\AppData\Roaming\Python\Python37\site-packages\tensorflow_init_.py", line 41, in
from tensorflow.python.tools import module_util as _module_util
ModuleNotFoundError: No module named 'tensorflow.python'

Provide the exact sequence of commands / steps that you executed before running into the problem
conda create -n tf python=3.7
pip install tensorflow
python

import tensorflow

Any other info / logs
If I run help('modules') in Python, I get:

Failed to import TensorFlow. Please note that TensorFlow is not installed by default when you install Gin-Config. This is so that users can decide whether to install the GPU-enabled TensorFlow package. To use Gin-Config, please install the most recent version of TensorFlow, by following instructions at https://tensorflow.org/install.

@nicolas-gervais
Request you to uninstall python and tensorflow .Please, install it again and see if the problem still persists.(You need a 64-bit version of Python and in your case are using a 32-bit version)
Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019.
I don't think Tensorflow support 32 bit architecture.Please, refer the issue #32315
Please, follow the instructions from here..Thanks!
Please refer to these issues with similar error:
#34722  link

@Saduf2019
Hello and thanks for the response. May I ask what leads you to believe that my Python is 32bit? I have been using Tensorflow for a long time with no problem. I've been using RNNs more than usual and that's when the problem started. Now the problem is generalized to all my environments (venv, conda) and reinstalling hasn't worked.
I will still do everything you listed to be absolutely sure.

Python 3.7.7 (default, May  6 2020, 11:45:54) [MSC v.1916 64 bit (AMD64)] :: Anaconda, Inc. on win32
Type "help", "copyright", "credits" or "license" for more information.

>>> import sys
>>> sys.version

'3.7.7 (default, May  6 2020, 11:45:54) [MSC v.1916 64 bit (AMD64)]'

So I deleted this folder:
C:\Users\nicol\AppData\Roaming\Python\Python37

And everything fell into place, after a few days of not being able to do my work. For now, I guess it works...

So I deleted this folder:
C:\Users\nicol\AppData\Roaming\Python\Python37

And everything fell into place, after a few days of not being able to do my work. For now, I guess it works...

@nicolas-gervais
Thank you for your update,glad the issue is resolved.

still not working I've updated my TensorFlow to version 2.9.0


Error: Match error: Missing key 'file_type'

Exception while invoking method 's3_sign' { stack: 'Error: Match error: Missing key 'file_type'\n    at exports.check (packages/check.js:57:15)\n    at [object Object].Meteor.methods.s3_sign (packages/lepozepo_s3/server/sign_request.coffee:19:3)\n    at [object Object].methodMap.(anonymous function) (packages/meteorhacks_kadira.js:2731:30)\n    at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1711:12)\n    at packages/ddp-server/livedata_server.js:711:19\n    at [object Object]..extend.withValue (packages/meteor.js:1122:17)\n    at packages/ddp-server/livedata_server.js:709:40\n    at [object Object]..extend.withValue (packages/meteor.js:1122:17)\n    at packages/ddp-server/livedata_server.js:707:46\n    at Session.method (packages/ddp-server/livedata_server.js:681:23)',
I20170213-11:40:12.016(-5)?   source: 'method' }
I20170213-11:40:12.017(-5)? Sanitized and reported to the client as: Match failed [400]
I20170213-11:40:12.017(-5)?

I didn't need to set a "file_tye" when uploading? Is there something I am missing?
I am using code similar to https://github.com/Lepozepo/S3/issues/133 I only noticed this error recently I have tried to run that code before and it worked. Previously my s3 was working fine one file at a time.
Removed personal info:
S3.config = {
  key: '..',
  secret: '...',
  bucket: '...'
};

The problem from #133 seems to be for only single upload


Needed to convert to string in headers

In make_request, the code is:
auth_headers = {
            'Authorization': self.clientKey + ':' + signature.decode('utf8'),
            'X-Auth-Timestamp': timestamp,
            'X-Auth-Nonce': nonce,
            'Content-Type': 'application/json'
}

It threw errors. I was able to get it to run by updating to:
auth_headers = {
            'Authorization': self.clientKey + ':' + signature.decode('utf8'),
            'X-Auth-Timestamp': str(timestamp),
            'X-Auth-Nonce': str(nonce),
            'Content-Type': 'application/json'
        }

#3 fixes.
#8 fixes.
#9 fixes.
But this repo looks abandoned...


Media storage config for S3 backend in existingSecret

The chart allows to have almost all of the credentials in an existing secret and therefore not to have them in the values.yaml.
The only credentials that can not yet be extracted like that are the credentials (storageConfig) for the media storage backend.
Enabling that would be much appreciated. Thanks in advance!
Cheers.

The trouble is this requires domain-specific knowledge for the storage provider(s) you want to use.
Really this chart needs a way to add arbitrary additional configuration settings from other ConfigMaps and Secrets or similar, but that's not straightforward. I'll put some thought into it.

My plan for this is to let people supply arbitrary ConfigMaps and Secrets, and any *.yaml keys within those secrets will be treated as configuration, and imported into NetBox's configuration. I'd like to do similar for *.py but that may need to wait for a future update as I don't want to delay releasing version 4.0 of the chart.

I've just released version 4.0.1 of this chart which resolves this issue.

Hi there @bootc
I'm not sure if you'll see this if the issue is closed but I'll try anyway.
So, I was trying out the extraConfig field today because I wanted to extract the S3 config to an existing secret like discussed above. But, at some point I realized that this is not going to work because the mechanism creates files with the filename being the key and the value being the file content.
I just tried and get a botocore exception saying that the credentials couldn't be found. The container does have the files though:
bash-5.1$ ls /run/config/extra/0/
AWS_ACCESS_KEY_ID      AWS_SECRET_ACCESS_KEY

Did I misunderstand something? I guess so...


request was banned

python main.py
请输入BV号：BV135yaYfESJ
获取的cid:<PHONE_NUMBER>8, aid:<PHONE_NUMBER>37692
下载链接请求失败: request was banned
Traceback (most recent call last):
File "/Users/shijianing/CodingTime/bili2text/main.py", line 9, in
foldername = run_split(filename)
File "/Users/shijianing/CodingTime/bili2text/exAudio.py", line 47, in run_split
flv_mp3(name, target_name=folder_name)
File "/Users/shijianing/CodingTime/bili2text/exAudio.py", line 8, in flv_mp3
clip = VideoFileClip(f'{folder}/{name}.mp4')
File "/opt/homebrew/Caskroom/miniconda/base/envs/testing/lib/python3.10/site-packages/moviepy/video/io/VideoFileClip.py", line 88, in init
self.reader = FFMPEG_VideoReader(filename, pix_fmt=pix_fmt,
File "/opt/homebrew/Caskroom/miniconda/base/envs/testing/lib/python3.10/site-packages/moviepy/video/io/ffmpeg_reader.py", line 35, in init
infos = ffmpeg_parse_infos(filename, print_infos, check_duration,
File "/opt/homebrew/Caskroom/miniconda/base/envs/testing/lib/python3.10/site-packages/moviepy/video/io/ffmpeg_reader.py", line 270, in ffmpeg_parse_infos
raise IOError(("MoviePy error: the file %s could not be found!\n"
OSError: MoviePy error: the file bilibili_video/None.mp4 could not be found!
Please check that you entered the correct path.

是的，我更新了一个新的方法，是用网上的解析API，可以试试新的代码


Work in progress function level analysis

Quick PR to get feedback on if this fits in with the major architectural plans.

Just out of curious, will this function level analysis work on restored registers and return value? Because some similar functions has been finished in src/analysis/interproc, like fixing the calling information, analysing restored registers and etc. I think I might be a good choice to combine them together.

I wouldn't mind merging together any of the interproc stuff that actually works. For now I'm just focused on making a well tested implementation to detect function arguments. I made a crate that picks out function details here that I'm going to be using to test: https://github.com/ammaraskar/rust-dwarf-x86

Any update on this?

Yeah, I've got a fair bit of progress locally. Will push for review on Tuesday.

Committed what I have so far. I'll detail it below.
Basic Design
<somefunc>:
    lea      edx,[rdi+rsi*1]
    mov      eax, edx
    add      eax, rsi
    ret

When we step through the instructions, we can see that rdi and rsi are the actual arguments, whereas edx is just used as a temporary register.
Algorithmically, this is determined by keeping a set of tainted registers that is initialized to empty. When we go through the instructions, this is how it changes:

lea      edx,[rdi+rsi*1] dest = edx, src = [rdi, rsi], tainted = {}
mov      eax, edx      dest = eax, src = [edx], tainted = {rdi, rsi, edx}
add      eax, rsi     dest = eax, src = [eax, edx], tainted = {rdi, rsi, edx, eax}

Every time we encounter a register in the source registers that is not tainted, in this case only rdi and rsi, it is considered to be an argument. We set a register to be tainted if we have used its value or used it as a destination register.
Some Design Decisions
So one problem with this is that we will inadvertently pick up a few false positives. For example, the return address is technically an argument passed to a function, though most people would not consider it to be since it is automatically generated by the compiler and not really important as far as the user code goes. Same thing for shrinking and expanding the stack, the original stack pointer is technically an argument but its not nearly as important as the actual data arguments being passed.
In order to avoid picking these up, I added a filtering system. A lot more detail can be found in the in-code comments here: https://github.com/radare/radeco-lib/pull/108/files#diff-07c7b28b47cd5cdc44251d1ac2777929R25
Essentially, you have an option of choosing to see these as arguments or passing in a filter to remove them and only expose the user arguments.
Next Steps
From some quick testing it looks like this algorithm picks up arguments fairly effectively and accurately but like I said before I intend to automate and really make sure this is well tested. So now I'm going to be integrating my crate from above (https://github.com/ammaraskar/rust-dwarf-x86) and adding a bunch of integration tests to see exactly how well this analysis is running. There's probably going to be a bunch of bugs and design decisions that need to be made based on the testing.

@sushant94 what with this one?

Closing this for now, I'll reopen if/when I have time to work on it. As it stands there are a lot of tangential issues that need to be resolved in order for the implementation to be correct.


how to trigger event "locationfound" with a location

Hi, i want to trigger "locationfound" with a specified location. How to do that?
By the way, we have the system to locate the location more presizly.

This is a bug tracker, not a place to ask questions. The place to ask questions is StackOverflow.

Hi, i want to trigger "locationfound" with a specified location. How to do that?

map.fire('locationfound', {latlng: foo, bounds: baz, timestamp: quux});

Also read through https://github.com/Leaflet/Leaflet/blob/master/src/map/ext/Map.Geolocation.js . Consider making a plugin with a structure similar to that file.

sorry to the mistake.


Pagination count is wrong

Hey, I just imported the project and have still a hustle with the multiplatform thing.
Can't provide a patch but a quick shot:
val scope = PaginatedRowScope(start, start + state.pageSize, this)
should rather be
val scope = PaginatedRowScope(start, start + state.pageSize -1, this)
or something like that.

Thanks. Fixed in 71cc1a3


in/out/all filtering not working

Only happens when you have tx's from a different chain saved in local storage. Fixed by clearing localstorage


implement new API

https://docs.google.com/spreadsheets/d/1Aoi0vapT-vK2DCo3qwHTCiMFg1NVGUegC2exrVTw0w4/edit?usp=sharing

closing this for now. we have a good start.


[Bug] [dolphinscheduler-service][V2.0.3] delayTime of TaskInstance  can not work

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
DelayTime of TaskInstance  not work in V2.0.3。

What you expected to happen
it can work after set delaytime in ui，then the task can delay running。
How to reproduce
set delayaTime and then running a workflow.
Anything else
no
Version
2.0.3
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can you describe the detail of delay time not work? Such as show the UI of task instance and log.

dolphinscheduler-worker.log not print the delay log:

i do not have this problem on the latest code of branch dev


feat: perform selected strategy for isbsvc fields to support PPND

Fixes #248
Modifications
Integrates the USDE logic to derive an upgrade strategy (that we currently have for PipelineRollouts) into the ISBServiceRollout reconciliation process.
Verification
Ran make test to verify unit tests are passing.
Ran make test-e2e locally and on CI to see that updating with and without excluded fields works properly.

nice job

Spoke to @dpadhiar and when he gets time he'll explore why the previous test for updating isbsvc with PPND is sometimes failing before we merge this. (Merging this is not critically important to be done by Q1)

Actually, I went through the artifacts I had when I saw the failure locally - not sure if numaplane is really doing anything wrong - we ultimately need to get the fixes from numaflow and try with that. I'm still a little nervous about merging this in since we weren't seeing this failure before.

FYI, Sidhant says he can get his numaflow changes ready to merge into our testing soon, so then we can see if that intermittent failure with the CI that we were seeing before goes away (and if not, we may have something for him to look at). Thanks for your patience.

@juliev0 Addressed all review changes, I did see that intermittent failure a few times (I believe its when the ISBService is ready-ing) so I suppose we will still wait to merge on this.


pods of jobs are not automatically deleted

Using job-executor-service 0.1.5, jobs are cleaned up/deleted, but pods are not, e.g.:
$ kubectl -n keptn get pods | grep job
job-executor-service-job-045986d5-5342-4673-9df9-4311-1-znxw2     0/1     Completed    0          6d18h
job-executor-service-job-04ac7243-0dfb-4320-98ba-57b7-1-gz59b     0/1     Error        0          21d
job-executor-service-job-0852acb3-c40e-4698-90d8-11ef-1-5gwjk     0/1     Completed    0          22d
job-executor-service-job-087f737b-d86a-417c-b16f-e064-1-2b862     0/1     Init:Error   0          22d
job-executor-service-job-08efd292-9734-4e4c-91fe-01ab-1-tvrtx     0/1     Init:Error   0          30d
job-executor-service-job-092f1737-01ff-4847-a7e1-65e8-1-mb7qf     0/1     StartError   0          22d
job-executor-service-job-0f37fe2a-13ff-4e77-b7f8-cfc6-1-t775s     0/1     Completed    0          22d
job-executor-service-job-10af78b3-b3e0-4744-a7e5-d116-1-znzn4     0/1     Completed    0          22d
job-executor-service-job-114adf28-5eba-42c9-a5c3-76c1-1-nn79b     0/1     Completed    0          21d
job-executor-service-job-12efe30b-8cc4-47c8-a40e-7f54-1-fj74l     0/1     Init:Error   0          22d
job-executor-service-job-138d54b5-1fd7-4c4d-aafd-9310-1-jn5xn     0/1     Init:Error   0          21d
job-executor-service-job-13af637e-4846-43a4-932b-eb4a-1-hmjmb     0/1     Completed    0          21d
job-executor-service-job-14752fc9-4709-4daf-9eda-7fb1-1-mhw7g     0/1     Error        0          22d
job-executor-service-job-151c78ff-c80b-4505-9bf6-c2ba-1-kdks2     0/1     Completed    0          21d
job-executor-service-job-1d1e5c86-146b-4b9b-bccd-c86a-1-l8ztr     0/1     Completed    0          22d
job-executor-service-job-1de90dcb-f1f5-4af2-998e-b4e1-1-cb827     0/1     Init:Error   0          22d
...

Not sure if this qualifies as a bug, but most certainly this is more than just annoying, as it impacts the performance of the Kubernetes cluster.
Definition of Done

[ ] Same as with Job clean-up/ttlSecondsAfterFinished, pods need to be cleaned up as well

Multiple issues here:

Job executor will delete the job at the end of task execution leaving the pod orphaned --> specify the correct propagation (fix in https://github.com/keptn-contrib/job-executor-service/blob/e60d2df97508d721002c8b38fbfc4a16606246d7/pkg/k8sutils/job.go#L244-L252)
Job executor always deletes the job when it's completed, making ttlSecondsAfterFinished completely redundant: I think we should leave the TTLController take care of job deletion (which is propagated to pods) in such case

I will open the pull request for the first point but I think we should probably complement the fix with some logic around ttlSecondsAfterFinished


Race condiotion is detcted at TestFifoCancel

Maybe an issue maybe not, but would be nice to remove race condition from the test.
--- FAIL: TestFifoCancel (0.00s)
fifo_test.go:280: All pipelines should be cancelled
WARNING: DATA RACE
Write at 0x00c4200ca2b0 by goroutine 36:
github.com/laszlocph/woodpecker/cncd/queue.(*fifo).Resume()
/Users/richard/Development/woodpecker/src/github.com/laszlocph/woodpecker/cncd/queue/fifo.go:202 +0x50
github.com/laszlocph/woodpecker/cncd/queue.TestFifoPause()
/Users/richard/Development/woodpecker/src/github.com/laszlocph/woodpecker/cncd/queue/fifo_test.go:302 +0x50f
testing.tRunner()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:746 +0x16c
Previous read at 0x00c4200ca2b0 by goroutine 38:
github.com/laszlocph/woodpecker/cncd/queue.(*fifo).process()
/Users/richard/Development/woodpecker/src/github.com/laszlocph/woodpecker/cncd/queue/fifo.go:210 +0x54
Goroutine 36 (running) created at:
testing.(*T).Run()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:789 +0x568
testing.runTests.func1()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:1004 +0xa7
testing.tRunner()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:746 +0x16c
testing.runTests()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:1002 +0x521
testing.(*M).Run()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:921 +0x206
main.main()
github.com/laszlocph/woodpecker/cncd/queue/_test/_testmain.go:66 +0x1d3
Goroutine 38 (finished) created at:
github.com/laszlocph/woodpecker/cncd/queue.(*fifo).Push()
/Users/richard/Development/woodpecker/src/github.com/laszlocph/woodpecker/cncd/queue/fifo.go:61 +0xa8
github.com/laszlocph/woodpecker/cncd/queue.TestFifoPause()
/Users/richard/Development/woodpecker/src/github.com/laszlocph/woodpecker/cncd/queue/fifo_test.go:300 +0x4f1
testing.tRunner()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:746 +0x16c
--- FAIL: TestFifoPause (0.02s)
testing.go:699: race detected during execution of test
WARNING: DATA RACE
Read at 0x00c4201101f0 by goroutine 45:
github.com/laszlocph/woodpecker/cncd/queue.(*fifo).process()
/Users/richard/Development/woodpecker/src/github.com/laszlocph/woodpecker/cncd/queue/fifo.go:210 +0x54
Previous write at 0x00c4201101f0 by goroutine 44:
github.com/laszlocph/woodpecker/cncd/queue.(*fifo).Resume()
/Users/richard/Development/woodpecker/src/github.com/laszlocph/woodpecker/cncd/queue/fifo.go:202 +0x50
github.com/laszlocph/woodpecker/cncd/queue.TestFifoPauseResume()
/Users/richard/Development/woodpecker/src/github.com/laszlocph/woodpecker/cncd/queue/fifo_test.go:325 +0x43c
testing.tRunner()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:746 +0x16c
Goroutine 45 (running) created at:
github.com/laszlocph/woodpecker/cncd/queue.(*fifo).Push()
/Users/richard/Development/woodpecker/src/github.com/laszlocph/woodpecker/cncd/queue/fifo.go:61 +0xa8
github.com/laszlocph/woodpecker/cncd/queue.TestFifoPauseResume()
/Users/richard/Development/woodpecker/src/github.com/laszlocph/woodpecker/cncd/queue/fifo_test.go:324 +0x42b
testing.tRunner()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:746 +0x16c
Goroutine 44 (running) created at:
testing.(*T).Run()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:789 +0x568
testing.runTests.func1()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:1004 +0xa7
testing.tRunner()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:746 +0x16c
testing.runTests()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:1002 +0x521
testing.(*M).Run()
/Users/richard/Development/common/go-1.9.7/src/testing/testing.go:921 +0x206
main.main()
github.com/laszlocph/woodpecker/cncd/queue/_test/_testmain.go:66 +0x1d3
--- FAIL: TestFifoPauseResume (0.00s)
testing.go:699: race detected during execution of test

Appreciate your proactivity on this. The found race condition was my mistake from recent code changes.


Does a Minified Version of the Library exist?

This library is perfect for a use case I need to accomplish for a project, but unfortunately the person who architected the project architected it in a strange fashion, such that I can't simply import the node module. Our dependencies are all in minified js form, and using dependencies which don't match this format would required overhauling our build process in a way that's not feasible for my current development cycle.
Is there somewhere I can find an all-in-one minified version of exceljs?

node_modules/exceljs/dist/exceljs.min.js

That was simple. Thank you!

I'm re-opening the issue because I while I man

@johnrileybjss Did the minified file work for you? When I include only it, my code can't recognize the basic keywords like Excel or Workbook

@shivavelingker No, I'm having the same problem. Is the minified library designed for browsers? Maybe we need to minify the excel.browser.js file?


[Plugin] Allure Test Report

Summary
Allure is a test report framework supporting many test frameworks across programming languages.
Allure reports are html based, can be embeded as iframe to backstage UI under catalog component.
Project website (if applicable)
https://docs.qameta.io/allure/
https://github.com/fescobar/allure-docker-service
Context
Allure Framework is a flexible lightweight multi-language test report tool that not only shows a very concise representation of what have been tested in a neat web report form, but allows everyone participating in the development process to extract maximum of useful information from everyday execution of tests.

I would like to work on this

Can someone, please, assign this to me :)

Can we close this now as the Allure plugin is published.


Fix open expanded redirected FAQs

Due to this issue #2669 I have fixed the issue related to the redirected FAQs on the FAQ page.
Here is an example video:
https://user-images.githubusercontent.com/56647378/162219209-abcd402b-341e-4e6c-8265-d3e856dd7e97.mp4

@MikeMcC399 Also here, thanks a lot for testing and reviewing!


"Add stack label" CI/CD step fails on PRs from forks

Description

The auth token we provide for CI/CD workflow does not have the permissions necessary to run on forks.
This means that that the CI/CD on forks is failing.
Reproduction

See https://github.com/WordPress/openverse/actions/runs/4562891150/jobs/8050684128?pr=1062

Environment
https://github.com/WordPress/openverse/blob/839418fabb0972ec3c3ccf48c72fd64cbba03cb9/.github/workflows/ci_cd.yml#L148
Priority high because the community PRs are failing CI.

The entire label_new_pr.yml → label_pr.yml → label_pr.py can be hugely simplified (if not entirely removed) using action/labeler.


Simplified SQLite vector store creation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Plugin Jobs and Kingdoms cause spam on the actionbar

When the player is employed as an "Explorer" when the message about earned money appears, after a moment a message from kingdoms appears about entering unoccupied territory
https://youtu.be/fUvePrR3zAA

So what seems to be strange here?

Normally, this message appears when I leave the kingdom area. The player traverses the map (e.g. 1000 blocks) and 3 seconds +- receives information that he is in an unoccupied area. By default, the player is in an unoccupied area, should he get a message only when he enters a kingdom?. See my video on youtube how it looks like

If you're not using v1.15.4 you should update to the latest version, that should fix your issue.

The bug is present on version 1.15.4

Then I don't think I understood your report.

By default, the player is in an unoccupied area, should he get a message only when he enters a kingdom

This is not technically true. The player will get a message when they enter a different "type" of land. Types of lands include wilderness, claimed and nation zones. And these types have different types itself like allies, truces, etc. So technically speaking a player will still receive a message when they go to an unclaimed land from a claimed land.


Can i try making Plugin support?

One of the thing I read here on GitHub before working on someone else project and write any code  is talk about want you want to make first in a issue to make sure it be acceptable to there project and that they don't have any better ideas .  So i decided to write this to do just that
The first thing i want to work on is add support for plugins.
So my first question Would you mind if I try to implement plugin support for Hatch and if so what do you think of my plan below.

Change it so each command (new, install etc.), including there sub commands can be add on throw plugins
Change hatch new to support sub commands.  I want it to create more then just projects I want it to create plugins, templates and more throw plugins.  So new help would then look like this.

Plugin --create a new plugin
Project  --create new project [default]

with plugins

bfst  -- Create a new basic file system template for use with hatch new project.
exe -- create a new executable for current project
other   --and even more.

Add 2 new command
   1.  Add  so i can add plugin and other things to the project
   2. Remove so i can remove plugin and other thing from my project

I don't know if all this is possible but that want i want to try to do.
I would like to do such thing in the future such as

hatch new exe myexe1 --and have it create a executable for a project
hatch new exe myexe2 --and have it create another executable fro project
hatch new bfs -- and have it create a new template for a file system
do some edit in the file system
hatch bfs save ---save the file system as a reusable templete for when you execute
hatch new proj -- I want it to get a list of basic file system it can make maybe even ones from cookie  throw plugins

Thank you for any help.  Please note i am not that good of a programmer(self thought) so don't get you hope up but i am very stubborn.
Oh here an egg for you snake
.. code-block::
           /^\/^\
         _|__|  O|
\/     /~     \_/ \
 \____|__________/ \      /========/
        \_______,   \     \________\
                \    \       | |           \
          _______|    |______===            \\
         /  ____/    /_______====            \\
         \  \  /     /       ===              \ \
          \  \/      /                         \ \           _____             _____
            \/     /                            \  \        /      \         /       \
           /     /             _----_            \   \     /\         \     /\       /\
          /     /           _-~      ~-_         |   |     |v\        /v|   |vvVvVvVvV|
         (      (        _-~    _--_    ~-_     _/   |     | \/ \//\vVv/ |  |TT     KK|
          \      ~-____-~    _-~    ~-_    ~-_-~    /      |TTT Hatch KKK|  |T Hatch K|
            ~-_           _-~          ~-_       _-~        \TTT     TTT/    \TTT_TTT/
               ~--______-~                ~-___-~             \TTT_TTT/

Hello @frog-o, thank you for being so eager to help! Unfortunately, I don't foresee myself having any time to devote to this project in the coming months.
That is great ascii art, thank you 😃

That OK. I want to work on it probably without success not for you to do it.  I was told I have to return to work so I am not going to have much time also. I just want to make sure it good enough for you to get merged in with your if i was able to do it and not wasting my time which i don't have much of.  I also wanted to make sure no one has any better ideas with naming and such you todo list is perty empty and dont know your plans going forward.

Hatch has been rewritten from scratch and now supports this, see https://ofek.dev/hatch/latest/plugins/about/


[Snyk] Upgrade @typescript-eslint/parser from 6.13.1 to 6.13.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @typescript-eslint/parser from 6.13.1 to 6.13.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 8 versions ahead of your current version.
The recommended version was released 23 days ago, on 2023-12-04.

Release notes

Package name: @typescript-eslint/parser

6.13.2 - 2023-12-046.13.2 (2023-12-04)
Note: Version bump only for package @ typescript-eslint/typescript-eslint
You can read about our versioning strategy and releases on our website.

6.13.2-alpha.7 - 2023-11-29

6.13.2-alpha.5 - 2023-11-29

6.13.2-alpha.4 - 2023-11-29

6.13.2-alpha.3 - 2023-11-28

6.13.2-alpha.2 - 2023-11-28

6.13.2-alpha.1 - 2023-11-28

6.13.2-alpha.0 - 2023-11-28

6.13.1 - 2023-11-286.13.1 (2023-11-28)
Bug Fixes

default to parse all JSDoc and provide options to configure it (#7999) (779e13e)

You can read about our versioning strategy and releases on our website.

    from @typescript-eslint/parser GitHub release notes

Commit messages

Package name: @typescript-eslint/parser

cc2c6d3 chore: publish v6.13.2
ac3d5bd chore(website): use less text for type checked filter (#7993)
37f34f4 docs: add 'When Not To Use It' or an intentional omission notice on all rules (#7447)
96abf18 chore: finish enabling no-unnecessary-condition internally (#8004)
9bd0c39 chore(deps): update babel to v7.23.4 (#7978)
12bfd46 chore(deps): update babel to 7.23.3 (#7922)
b872154 chore(website): fixed most no-unnecessary-condition complaints (#7836)
217c1f3 chore: streamline issue templates (#7994)
88b2b0b docs: updated globalSetup to setupFiles (#8000)
4dae083 chore: prefix all nx package scripts with npx (#7988)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ed0bfab) 92.34% compared to head (3cf7d58) 92.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   92.34%   92.34%
=======================================
  Files           6        6
  Lines         418      418
  Branches       11       11
=======================================
  Hits          386      386
  Misses         32       32

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUG][NOWEB] - all sesssion are in FAILED status

[BUG][NOWEB] - all sesssion are in FAILED status

fixed in 2024.8.5

or when session stuck in STARTING


[Distributed] Improve error messages for protocol conformances

Include the 'distributed method' wording when we report conformance errors about distributed methods.

@swift-ci please smoke test

@swift-ci please smoke test windows Platform

Yeah you're right, I'll keep cleaning this up -- will do more of that in today's followup PRs I think right away.


Dataset is broken in Power BI after crating calculation groups

When using Tabular Editor to create calculation groups in Power BI the measures in the dataset are seen as dimensions by PBI. I have found no way to recover the dataset afterwards. The measures are still not usable even after deleting the calculation groups. Any other datasets added to the model are also broken after this. Calculated measures do not seem to be affected by the issue.
I am able to recreate the issue with datasets based on a HANA View and a CSV file.
The calculation groups work fine when created, but only for calculated measures.
To Reproduce
Steps to reproduce the behavior:
PBI Desktop:
Import CSV and create a visual to validate that the data is working as expected.
From external tools open tabular editor
Right click tables and create a calculation group
Click 'Save changes to the connected database
Return to PBI Desktop
All measures no behave as a dimension and no longer show the sum-sign left of them
(Bang head repeatedly on table in annoyance and be frustrated about working on your main report and not having a recent backup - this step is optional and not recommended)
Expected behavior
That the measures would still be a measure and not act as dimensions.
Observed behavior

Application specifics
PBI Desktop, PBI Service
TE Version: 2.12.0
Dataset from HANA Calculation View and CSV

Duplicate of #614
Please view the documentation for calculation groups.
Specifically, note that you have to enable DiscourageImplicitMeasures, before calculation groups can be added to a model. Tabular Editor does this for you automatically when adding the first calc group. When you later delete the calc groups from your model, you will have to manually set this property back to false.

Thank you for a very quick response! And sorry for missing the other issue report.

Hopefully there will be a way to handle this in the future

That won't happen. Calculation Groups, by design, cannot work with implicit measures, so in order to use them, the engine will likely always require the DiscourageImplicitMeasures flag to be set to true.

just adds a ton of extra work having to create calculated key figs from already existing ones

For tabular modelling, it is a best practice to always create explicit measures. Why? Well, first of all, you run the risk of report creators using the wrong kind of aggregation (avg/min/max/sum), when using implicit measures. Secondly, if you have users that connect to your dataset using MDX-based client tools like Excel, Tableau, etc., they will not be able to query the model, since MDX requires the presence of explicit measures.
Luckily, with Tabular Editor, there's a very easy way to create explicit measures from columns.

Hi
Great support! Thanks a lot - I think I'll experiment with reading the documentation...


Fix resize bug and add move constructor for Bitset

The resize function of Bitset generates memory error.

Codecov Report

Merging #149 (0e617ea) into master (25d1284) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   63.96%   63.96%
=======================================
  Files          67       67
  Lines        6310     6310
=======================================
  Hits         4036     4036
  Misses       2274     2274

Flag
Coverage Δ

app_tests
63.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

grape/utils/bitset.h
75.00% <ø> (ø)


Wrap Alias call for Mixpanel

Using Mixpanel with Segment requires the alias method to be called just once at exactly the right time for Mixpanel to associate an anonymous track with a named track when the user signs up.
This PR adds the alias wrapper to both Andorid and iOS.

Closing because I created #10, cleaner with one commit only


Overly aggressive extension pruning

When removing unknown slices currently even valid extensions are sometimes removed
i.e. check slicing does not properly work for extensions

Handled in https://github.com/medizininformatik-initiative/torch/pull/122


Added some standard flavors to the Android build

Some basic Android flavors. Properties for each flavor can be set up into a property file.
For now only versionName is supported

I have not done a lot of work with Android, but reading from here: https://developer.android.com/studio/build/build-variants.html
I choose buildTypes rather than flavors so I can specify a sourceSets for each build type where I can have different resources i.e.: API_KEYS and ENV
Also it gives me the possibility to install both debug and production on the same device.
I am still learning which way is better, but so far this works for me. I am interested in hearing your thoughts.
android {
    compileSdkVersion 23
    buildToolsVersion "23.0.3"

    defaultConfig {
       // ...
    }
    signingConfigs {
        release {
            storeFile file(MYAPP_RELEASE_STORE_FILE)
            storePassword MYAPP_RELEASE_STORE_PASSWORD
            keyAlias MYAPP_RELEASE_KEY_ALIAS
            keyPassword MYAPP_RELEASE_KEY_PASSWORD
        }
    }

    splits {
        abi {
            reset()
            enable enableSeparateBuildPerCPUArchitecture
            universalApk false  // If true, also generate a universal APK
            include "armeabi-v7a", "x86"
        }
    }
    buildTypes {
        debug {
            minifyEnabled false
            debuggable true
            applicationIdSuffix '.debug'
            versionNameSuffix '-debug'
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
        release {
            minifyEnabled enableProguardInReleaseBuilds
            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
            signingConfig signingConfigs.release
            debuggable false
        }
    }
    // applicationVariants are e.g. debug, release
    applicationVariants.all { variant ->
        variant.outputs.each { output ->
            // For each separate APK per architecture, set a unique version code as described here:
            // http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits
            def versionCodes = ["armeabi-v7a":1, "x86":2]
            def abi = output.getFilter(OutputFile.ABI)
            if (abi != null) {  // null for the universal-debug, universal-release variants
                output.versionCodeOverride =
                        versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
            }
        }
    }
}

Thanks for your comments!
As far as I understood, buildTypes describe the way your development lifecycle (i.e. release, debug) while developing and testing your app whilst productFlavors describe your product 'deployment' characteristics.
For example in Kick we had two build types: Release and Debug and three product flavors: development, staging, release
The first two were mainly used to enable/disable the debug features of the app (logs and an addititional Activity we used during the debug phase to trigger events manually) and the flavors to customise the final APK to deal with a particular backend environment.
Thus, I don't think they should be seen as alternatives to each other, but rather that one compliments the other.
Ideally we should be able to easily configure all of them.

very good explanation.
I will be curious to see it applied to these files:
https://github.com/futurice/pepperoni-app-kit/tree/master/android/app/src/main/res/values
And yes we should provide an example where to configure all of them!

Yeah that'd be a good example indeed!
Will look into it asap.

With flavors you can customise sourceSets as well, similar as with buildTypes @fabriziomoscon .
Flavors are also a much powerfult cusmotisation tool, as you can have multi-dimension flavors. For example:

freeStaging
freeRelese
paidStaging
paidRelese
(...)

More info here: http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Build-Variants


Readme improved

@rultor merge

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (4dae345) compared to base (2ba7aee).
 Consider uploading reports for the commit 4073428 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #52   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity        12        12
===========================================
  Files              7         7
  Lines             29        29
===========================================
  Hits              29        29

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@rultor merge

@l3r8yj OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@l3r8yj Done! FYI, the full log is here (took me 1min)


test: global components prop validation

Add test case for https://github.com/vuejs/language-tools/wiki/Global-Component-Types

LGTM, thanks!


change the report it refers to

Sorry,
How can I change the report it refers to?

Power BI Playground Showcases do not support changing the report reference directly. To change the report reference, you'll need to update the embedConfig object in the code by providing the new accessToken, embedUrl, and reportId.
To generate the access token, use the following REST API: Embed Token - Generate Token - REST API (Power BI Power BI REST APIs) | Microsoft Learn
To generate the embed token, use the following REST API: Reports - Get Report In Group - REST API (Power BI Power BI REST APIs) | Microsoft Learn


APP-1140 fix

Can one of the admins verify this patch?

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@6906f82). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #112   +/-   ##
======================================
  Coverage       ?   89.32%
======================================
  Files          ?      165
  Lines          ?     3241
  Branches       ?      307
======================================
  Hits           ?     2895
  Misses         ?      270
  Partials       ?       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6906f82...01688d7. Read the comment docs.


main: Add highlighting for hashed directories with autocd and cdablevars

See #930 (or at least just https://github.com/zsh-users/zsh-syntax-highlighting/issues/930#issuecomment-1590633859).
What this PR does:

If a hashed directory foo exists and the path it resolves to also exists, it will highlight it as a hashed-command

What this PR does not do:

Does not highlight after further Tab-complete expansion of the hashed directory, even though it should be valid

If this feels like enough to be a PR on its own, then you could merge. If it feels incomplete, but on the right path, someone else could offer guidance and I'll see if I can complete it or they could pick it up themselves, or if it's completely wrong then it could just be closed.

Starting

I think we can take the CDABLE_VARS documentation fairly literally
          If the argument to a cd command (or an implied cd with the
          AUTO_CD option set) is not a directory, and does not begin with
          a slash, try to expand the expression as if it were preceded by
          a `~' (see the section `Filename Expansion').

and just call _zsh_highlight_main_highlighter_expand_path again, but prefixed with a tilde. Something like
    elif (( autocd && cdablevars )) && [[ ${1[1]} != / ]]; then
      _zsh_highlight_main_highlighter_expand_path "~$1"
      if [[ -d $REPLY && -x $REPLY ]]; then
        REPLY=autodirectory
        return 0
      fi

That covers the case where the path continues and the case where a username is provided.


fix(Button): Added align-items: center to Button styles

Overview
PR Checklist

~[ ] Related to Abstract designs:~
[x] Related to JIRA ticket: TR2-298
[x] I have run this code to verify it works
~[ ] This PR includes unit tests for the code change~

Description
When buttons are given a custom height, they should still center text.
codecademy.explore/try has a weird big button right now. 😢

📬Published Alpha Packages:@codecademy/gamut-labs@1.7.51-alpha.5fdc74.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f19a10135177784e3ab2f0e--codecademy-styleguide.netlify.appDeploy Logs


added invalid-xml style html parser

Non-XHTML style html parser initialization.
This PR is depended on https://github.com/PerfectlySoft/Perfect-libxml2/pull/1 .
So, if you like this and when you merge this, please merge the depended PR first.
And change version of Perfect-libxml2 and depended package version of this Repo, then merge this.
Thanks.

Thank you for a commit 7c01c522a84d09e237a892d4b020ed8916e6d25d 🎊


Refreshing a data type page loses the flow counts on the sub tree nodes

Navigate to the data types list
Click on a data type that has sub types
The data type page will show the sub-tree with flow counts
Refresh the data type page
Flow counts will be lost

No longer relevant


make error

Hello, I am trying to install uWebSockets on ubuntu 20.04.
I git uWebSockets and git uSockets, but when make, error has occured:
make -C uSockets
make[1]: Entering directory '/uWebSockets/uSockets'
rm -f *.o
cc -flto -DLIBUS_NO_SSL -std=c11 -Isrc -O3 -c src/*.c src/eventing/*.c src/crypto/*.c
lib.exe /out:uSockets.a *.o || ar rvs uSockets.a *.o
/bin/sh: 1: lib.exe: not found
r - bsd.o
r - context.o
r - epoll_kqueue.o
r - gcd.o
r - libuv.o
r - loop.o
r - openssl.o
r - quic.o
r - socket.o
r - udp.o
make[1]: Leaving directory '/uWebSockets/uSockets'
cc build.c -o build
./build examples
--> g++ -O3 -Wpedantic -Wall -Wextra -Wsign-conversion -Wconversion -std=c++2a -Isrc -IuSockets/src -flto examples/Client.cpp  uSockets/*.o -lz -o Client

g++: error: unrecognized command line option ‘-std=c++2a’; did you mean ‘-std=c++03’?
make: *** [GNUmakefile:7: examples] Error 255

Is the version of g++ not consistent with wanted and how can I change it ?
I can't even find the flag -std=c++2a in Makefile...
Could you please give me some help? thanks!

Ubuntu 20.04 is too old, yes

Ubuntu 20.04 is too old, yes

Does uWebSocket not support ubuntu 20.04 now? Is there no way to run it on ubuntu 20.04?

The implementation is header-only C++17 (but examples use C++20 features for brevity and elegance!)


M47959 Possible typo

Translator has reported possible source content issue.
Description: "The MinnowBoard Max will not boot unless the firmware is version .092 or later." should be "The MinnowBoard Max will not boot unless the firmware is version 0.92 or later."
Affected Line: 110

Docs Build status updates of commit 57719b0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/release-notes/commercial/CreatorsUpdate.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@imingc Thanks for merging!


Hide slack channel in Jenkins scripts

1, Hide slack channel in Jenkins scripts
2, Only update Jenkins scripts, no source change. No unit tests needed.
3, No Github issue related to the PR.

build


[BUG] Get-PnPView does not retrieve ViewQuery

Reporting an Issue or Missing Feature
Get-PnPView does not retrieve ViewQuery
Expected behavior
Cmdlet gets all available information from view
Actual behavior
Only retrieve Title, Id, Default and Personal
Steps to reproduce behavior
$view = Get-PnPView -List "list name" -Identity "view name"
$view
$view.ViewQuery --> no output
$view.Properties.ViewQuery --> no output
What is the version of the Cmdlet module you are running?
2.20
Which operating system/environment are you running PnP PowerShell on?

[X] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Hi @sp00kyDD the ViewQuery option can be returned in the View object by including it in the request, e.g:
$view = Get-PnPView -List "list name" -Identity "view name" -Include ViewQuery

Hi @sp00kyDD the ViewQuery property can be returned in the View object by including it in the request, e.g: $view = Get-PnPView -List "list name" -Identity "view name" -Includes ViewQuery

@danielcecil  Thank you!!! Didn't know that. Maybe the docu can be adjusted at this point?

No worries :-) FYI the Includes parameter is in most or all of the 'Get' commands albeit not explicitly explained in the docs for this particular command.

Thanks for your input @danielcecil 👍🏻


Option "do not update" for single mangas

Describe your suggested feature
Like, a little option on each manga to not update one specifically, so we wouldn't have to create a new category just to not update some manga
Other details
I can't know if this has been issued in Mihon
There is already an option for this but it is exclusive for categories as a whole, not single manga
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an request for a feature in the original Tachiyomi, I am opening because multiple versions of Yōkai have been released without this feature.
[X] If this is an issue with an extension, or a request for an extension, I should be contacting the extensions repository's maintainer/support for help.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have checked through the app settings for my feature.
[X] I will fill out all of the requested information in this form.

I'll think about it. You can workaround it by manually edit the manga status to completed for now, that should make it stop updating.


Fix issue 986 & 1146

Fix issue 986: Web socket request gets handled by get route

Fix issue 1146: Spark.webSocketIdleTimeoutMillis should handle Long instead of Integer

I did an initial review of this and it looks good.
There are some backwards compatibility issues I'll have to think about how to solve before merging it.


fix: using opendatahub-operator for odh-nightlies

We switched last week to use opendatahub-operator tag in the ODH nightlies build, and not using rhods-operator anymore. Aligning the changes to unblock the ODH installation

@CFSNM could you please share what changes you're referring to (unless it's internal repo of course)?


404 at /docker-for-mac/engine/security/trust.md

I found a broken link : https://docs.docker.com/docker-for-mac/engine/security/trust.md
I arrived on this page through: https://docs.docker.com/docker-for-mac/release-notes/

Thanks for reporting the issue. The issue appears no longer valid. If you're still able to reproduce the issue, please provide more details about how you accessed the broken link, such as being redirected from another link.


Unhandled Exception: MissingPluginException(No implementation found for method getApplicationDocumentsDirectory on channel plugins.flutter.io/path_provider)

As I'm using the get_storage in my app, my app freezes on the startup showing the white screen while building the release apk.
Getting the following error:
[+2458 ms] E/flutter (11801): [ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception:
MissingPluginException(No implementation found for method getApplicationDocumentsDirectory on channel
plugins.flutter.io/path_provider)
[   +2 ms] E/flutter (11801): #0      GetStorage._init (package:get_storage/src/storage_impl.dart:47)
[   +1 ms] E/flutter (11801): <asynchronous suspension>
[   +1 ms] E/flutter (11801): #1      new GetStorage._internal.<anonymous closure>
(package:get_storage/src/storage_impl.dart:28)
[   +1 ms] E/flutter (11801): <asynchronous suspension>
[   +1 ms] E/flutter (11801): #2      Initializer._initStorage
(package:scm_study/app/common/util/initializer.dart:22)
[   +1 ms] E/flutter (11801): <asynchronous suspension>
[        ] E/flutter (11801): #3      Initializer.init
(package:scm_study/app/common/util/initializer.dart:12)
[   +1 ms] E/flutter (11801): <asynchronous suspension>
[   +1 ms] E/flutter (11801): #4      main (package:scm_study/main.dart:13)
[        ] E/flutter (11801): <asynchronous suspension>
[   +1 ms] E/flutter (11801):

me too!

me too!

me too! only in release mode.

duplicate of https://github.com/jonataslaw/get_storage/issues/33


fix(cli): import relative to user config

What's the problem this PR addresses?
@graphql-codegen/cli is trying to require user provided packages from itself making it rely on hoisting which does not guarantee that the packages are placed in an accessible location and when using PnP the resolution is rejected because @graphql-codegen/cli doesn't declare them.
Fixes https://github.com/yarnpkg/berry/issues/1599#issuecomment-686629356 cc @xenoterracide
How did you fix it?
Use createRequire to resolve packages relative to the user config

@dotansimha I see you have a partial fix for this in https://github.com/dotansimha/graphql-code-generator/pull/4433 but it's using the PnP API directly, but that wont fix it for workspaces using node_modules so this should be preferred

That's great! Thank you so much @merceyz !
You are right, I was trying to solve that partially in the Yarn v2 branch, but you solution should fix that in a better way.
Can you please take a look at the CI? It seems to be broken.

Thank you so much @merceyz , this is great :)

Hey @merceyz, I am investigating native ESM support right now, and this change prevents the loading of ESM modules. Do you have any recommendations for handling this situation for both ESM and CommonJS?
The relativeRequire.resolve call will always resolve the CommonJS module path. So to me, it seems like we need to detect within codegen.ts whether we are within an ESM or CommonJS context.

I suppose you could try import.meta.resolve and if that fails fall back to relativeRequire.resolve.
https://nodejs.org/docs/latest-v16.x/api/esm.html#importmetaresolvespecifier-parent.


How to import less modules with JSX?

Hi, I am using Vue2 with JSX template, when I want to load the less as modules, but there got a little errors, such as
import styles from './ListItem.less'

got the errors
 This relative module was not found:
* ./ListItem.less in ./src/pages/treatment/ListItem.js

my webpack loaders is
     {
        test: /\.less$/,
        loader: 'style!css-loader?modules&importLoaders=2&localIdentName=[name]__[local]___[hash:base64:5]',
        include: [resolve('src'), resolve('test')]
      },

How to config can be make it to be worked?

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server, gitter or StackOverflow.

I'm not sure about what you're trying to do but webpack is telling you the file doesn't exist. Maybe it's in another folder


Write a Rust program to find length of a string

Description
Write a Rust program to find length of a string
Input  : abcd
Output : 4

How to contribute

Save the solution in find_length_of_a_string.rs file
Add find_length_of_a_string.rs file in program/find-length-of-a-string folder

!assign


Exception when joining 1.8.8 server with 1.12 client (dev builds 170 up to 172)

What is the output link of /viaversion dump?
https://gist.github.com/anonymous/6f5cb79e1f5af0f3d1db3b0f8dc898fa
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
Yes, BungeeCord - Without any special plugins
This server is running BungeeCord version git:BungeeCord-Bootstrap:1.12-SNAPSHOT:6958943:1244 by md_5
How does this error happen? login? Using an item?
When logging in to a 1.8.8 server with a 1.12 client - it did not happen in the last ViaVersion release but in the recent dev builds.
Is there an error in the console? Use pastebin.com. Is there a kick message?
http://cubeimage.de/images/2017/06/26/GXx.png
No error in the console

Fixed :)


fix(map_extension): revert Map copy in fillEmptyKeyValues

Reverts #95
Context
Copying the Map inside fillEmptyKeyValues led to undesired downcasting issues. E.g., when called on a SplayTreeMap it was copied as a Map, and subsequent operations ignored the fact that the original collection was respecting a sorting condition.

Coverage decreased (-0.1%) to 87.288% when pulling 38598af28dc9161d6b4bcb95f6314f86420b6776 on fix/revert-map-copy-fill-empty-key-values into d7cca7613fc206556dd8393911530e0a577142aa on main.


Update Django requirement

#7

Thank you for this. I'll check how to update Django, and then merge this PR

Actually I'm planning to publish my HelloWorld tutorial video with 2.1, so it might take me a while to get to this PR. sorry


refactor(api, robot-server): removal of automatic drop tip from Flex while maintaining OT2 behavior

Overview
This will currently remove the automatic drop tip behavior from do_stop_and_recover for Flex protocols. The decision is made in robot-server under the engine store when create_protocol_run is called. For the time being, this is determined based on Robot type. If the robot is a Flex, we set drop_tips_after_run to false, otherwise it is always true. This could be changed to a settings flagged triggered boolean in the future to enable-drop tip behavior on Flex (other changes would be needed covered below related to loaded trashes).
In do_stop_and_recover, if there are still tips attached it will home the gantry and the gripper, but it will not home the plunger. The private _drop_tip function called there now has a changed behavior utilizing move_to_addressable_area. Eventually we will want to update this to pull a dynamic list of loaded trashes, for which I have added a function that returns the list of loaded trash addressable areas within protocol engine. We cannot do this currently, as a trash (and any addressable area) is not loaded to the PE addressable area store unless it is actually used. We will need to change that behavior in the future. What this will eventually allow us to do is automatically drop the tip in a trash can so long as it exists within the deck configuration, regardless of if it is used. For now, only the OT2 supports this functionality (as only the OT2 should automatically drop tips) and is simply provided a hard-coded "fixedTrash" addressable area to move to for tip drop. If a Flex protocol reaches this point (which it should not, except in analysis), for the time being it will log a debug message that states "Flex protocols do not support automatic tip dropping at this time".
Test Plan
Run both OT2 and Flex protocols where the following happens:

Tips are picked-up
Tips are dropped in a trash
Tips are picked-up

Nothing else should occur in the protocol after this.
The expected results are as follows:
FLEX:
The robot should pickup and throw away tips as expected, then pick up the second set of tips and end the protocol. After this, it should home the gantry and the grippers but NOT the plungers. It will then end the protocol and prompt the user, on both the App and ODD that there are still tips attached, and allow them to do a manual drop (if they want) through the tip drop wizard.
OT2:
The robot should pickup and throw away tips as expected, then pick up the second set of tips and go to the trash and throw away the remaining tips automatically.
Risk assessment
On Flex protocols users are now expected to explicitly drop any remaining tips at the end of their protocols. This means that any protocol designed before this refactor will now be stuck with tips at the end if the users designed a protocol that would end with tips still on the pipette at the end.

Protocols meeting the description of the test case above were ran on both OT2 and Flex, and the desired behavior was seen. OT2 automatically dropped tips at the end then homed, and Flex simply homed (without the plungers) keeping the tips attached.


LuceneIndex has hard-coded StandardAnalyzer

Motivation
When I want to build index for Kentico, I'd like to cover some specifics (e.g. diacritics, umlaut and so on) of desired language by picking adequate Analyzer and not rely on preset StandardAnalyzer.
Standard analyzer does not correctly work with diacritics (I'd like to find "über" either as "über" and "uber").
Proposed solution
I'd like to add arbitrary analyzers during service registration (probably via new method RegisterAnalyzer on ILuceneBuilder) and then pick appropriate analyzer along with indexing strategy in Kentico admin.
I expect to have possibility to obtain selected analyzer in code.

Thank you for highlighting this request. We will review it internally and keep you informed of any developments.

Approved for development.

We have created GitHub release v7.0.0 which enhances this integration with Lucene Analyzer selection.


[SPARK-30050][SQL] analyze table and rename table should not erase hive table bucketing info

What changes were proposed in this pull request?

This patch adds Hive provider into table metadata in HiveExternalCatalog.alterTableStats. When we call HiveClient.alterTable, alterTable will erase if it can not find hive provider in given table metadata.
Rename table also has this issue.
Why are the changes needed?

Because running ANALYZE TABLE on a Hive table, if the table has bucketing info, will erase existing bucket info.
Does this PR introduce any user-facing change?

Yes. After this PR, running ANALYZE TABLE on Hive table, won't erase existing bucketing info.
How was this patch tested?

Unit test.

Test build #114483 has started for PR 26685 at commit da74e05.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19316/
Test PASSed.

cc @cloud-fan

Test build #114485 has started for PR 26685 at commit e2b321b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19319/
Test PASSed.

Test build #114483 has finished for PR 26685 at commit da74e05.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114483/
Test PASSed.

Test build #114485 has finished for PR 26685 at commit e2b321b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114485/
Test PASSed.

cc @felixcheung

Test build #114513 has started for PR 26685 at commit bc58197.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19343/
Test PASSed.

Test build #114513 has finished for PR 26685 at commit bc58197.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114513/
Test FAILed.

retest this please.

Test build #114517 has started for PR 26685 at commit bc58197.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19347/
Test PASSed.

Shall we update HiveClientImpl.toHiveTable? We shouldn't use DDLUtils.isHiveTable(table) to check if it's a hive table

Test build #114517 has finished for PR 26685 at commit bc58197.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114517/
Test PASSed.

Test build #114543 has started for PR 26685 at commit 64dd269.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19372/
Test PASSed.

Test build #114543 has finished for PR 26685 at commit 64dd269.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114543/
Test PASSed.

Shall we update HiveClientImpl.toHiveTable? We shouldn't use DDLUtils.isHiveTable(table) to check if it's a hive table. We should use !DDLUtils.isDatasourceTable

In this case, because we get raw table metadata by getRawTable, the provider info is not propagated yet.
We should use HiveExternalCatalog.isDatasourceTable, which will also check provider in table properties.

Test build #114544 has started for PR 26685 at commit 5457276.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19374/
Test PASSed.

Test build #114544 has finished for PR 26685 at commit 5457276.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114544/
Test PASSed.

thanks, merging to master/2.4!

thanks!


A simple forward model build

Hi Brendan et al,
Is there a simple way of making a forward model for a given dataset? We have some inversion results and we would like to predict another dataset, independently. I am sure this is possible but how :-)
There is an empty wiki page with that topic, so I guess that was part of the plan at some point
Cheers
R

@jolivetr Great question!  It's definitely high up on the todo list!


Icon request: System76

URL for the brand / site / app
https://system76.com/
Logo resources for the icon
https://github.com/system76/brand
Proof of the Aegis-compatible 2FA
https://github.com/2factorauth/twofactorauth/issues/6940
Screenshot_20230223-043200
Anything else?
No response
Confirmation

[X] I have read and followed the issue guidelines & issue form.

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/icons/1_Primary/System76.svg

:question: How to add icon(s) to Aegis?
:star: Support this project by giving a star! Just adding like to this comment is also appreciated.


[REQUEST FOR INFORMATION] Deployment of attacknet

Is it possible to share the way in which the attacknet has been deployed, including scripts to conveniently deploy private identical/similar test networks? We want to clone the full network to better try certain cases and have more insights into the behavior and debug messages of the validator nodes.

Hey, that sounds great! I am happy to help you set up a similar network, but sadly the original approach how we set up the current attacknets is not so convenient. To change this, and scale to bigger multi-client attacknets, I started refactoring the ansible roles, vars, playbooks etc. into a new public repository, built to work more as a library. This way everyone should be able to spin up a testnet with their own ansible inventory definition. (if you are unfamiliar with Ansible, have a look at this great tutorial: https://www.youtube.com/watch?v=MfoAb50Br94)
Work in progress here:
https://github.com/protolambda/ansible_eth2/
The set up, used in attacknets now, generally looks like:

define ansible hosts, attach client metadata to them with ansible group-vars
roles to get docker containers running, and put them on the host network:

beacon runs an Eth2 beacon node. Publicly exposed on TCP and UDP port 9000
validator run an Eth2 validator, communicating with the beacon node on port 4000 (and 4001 for GRPC, prysm client)

multi-client validator key deployment, with a lot of keys, is complex. But automated with ansible, and https://github.com/protolambda/eth2-val-tools
a permissioned deposit contract was used, so we keep attacks limited to the nodes themselves for now, and not something like a sudden 1000+ new validators. (The mainnet spec has things to avoid sudden chain take-overs, but at small validator counts it doesn't work)

The process looks like:

Create validator seeds (two mnemonics)
Define a fork-version for your testnet
Deploy some deposit contract. Public (see specs repo), or permissioned (see https://github.com/protolambda/testnet-dep-contract/). Use an Eth1 testnet. You can use the public goerli testnetwork. With the permissioned deposit contract, you don't need any goerli eth, except for gas fees.
Create validator deposits, for a range of derived keys
Spin up a few machines
Make sure to get configuration for a specific client right. They have different options to load it. The fork version, deposit contract address, and genesis conditions, need to match for a successful network launch
Deploy beacon nodes to the machines (the beacon docker container on each machine)
If not running the Teku client (which has a validator client built into the beacon node itself), deploy validator clients (the validator docker container on each machine)
Now that your things are running, submit the deposits to the testnet.
The nodes will start processing the deposits, and schedule genesis!
Genesis happens, the network should be running, and validators are proposing blocks and attesting things.

Have you tried running a single beacon node and validator already, on e.g. Altona testnet? I would recommend getting familiar first.

Also, something to add: you can run a beacon node without a validator, and still join the attacknet. That would be a good, easy, start to become familiar with things. And at the same time, you will have some attacknet data at hand by syncing the network (the API of the client you are running may be useful).
You could then maybe use trace logs or a debugger to find interesting things in the client, to then try and exploit in the other attacknet nodes.
If you want to avoid other attacknet users from accidentally finding your node, you can disable the "discv5" part of the client (this is the discovery part where node records are advertised).


windows wsl installation instructions added

Turns out installing on WSL-Windows works just fine as long as the path for the Cha log is specified correctly. Added some instructions for installation using WSL-Ubuntu on Windows.

Does this solve the false offline notification problem?

Was not aware of that problem. But the short answer is NO.
This just proposes you run the chia-dog on WSL-Ubuntu instead of native Windows (with simplers installation process).

I thought it might because I dont think the problem exists on linux as far as i'm aware

My guess is also that it will solve the mentioned above problem if it reuses the tail -F command.

I was hoping so, but so far in my testing it does not because I'm actually
getting the problem more often now....I think its a way the logs roll
over in windows, problem probably wouldn't exist if I was also running chia
on wsl2
On Sat, May 15, 2021 at 2:06 PM Martin Mihaylov @.***>
wrote:

My guess is also that it will solve the mentioned above problem if it
reuses the tail -F command.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/martomi/chiadog/pull/125#issuecomment-841709770, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6RHIIJEV5XLSYXTBYIE2TTN3A2ZANCNFSM445N4EOQ
.


do not use event.layerX

In current Chrome (Chromium 16.0.912.63 (Developer Build 0 Linux)) I get a warning when I click on a map:
event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future.

See: http://trac.osgeo.org/openlayers/ticket/3599

No need to worry. This warning will go away when WebKit does not
populate event objects with layerX and layerY any more. In other
words: as soon as they remove it from the engine, you won't see the
warning again.


UI redesign: message highlights and UI

As part of the redesign we want to update styles messages. This issue is not about typography  but about all the different ways to highlight the whole message.
New design of the possible message highlights consist from such layers:

[ ] 0. theme message background (https://github.com/zulip/zulip/pull/22419)
[x] 1. kind of message background (https://github.com/zulip/zulip/pull/22419)
[ ] 2. hover background (https://github.com/zulip/zulip/pull/22419) [dropping as a 7.0 release goal, as initial CZO feedback was that a basic implementation of this change can be confusing/distracting for keyboard navigation users]
[ ] 3. message content, including author's name and user pic [not a 7.0 release goal]
[ ] 4. hover buttons [not a 7.0 release goal]
[x] 5. zulip focus rectangle
[ ] 6. unread indicator [7.0 release goal]

Here is the Figma area with all the variations:

Specification each layer
In Figma layers don't exactly reflect the order of containers/backgrounds in html/css. My proposal of implementation might not be optimal, so suggestions are welcome.
0. Theme message background
White for light theme hsla(0, 0%, 100%, 1)

and almost black in dark hsla(0, 0%, 14%, 1)

1. Kind of message background
This replaces the theme background.

viewer's user mention in light hsla(240, 24%, 96%, 1) and in dark hsla(240, 13%, 20%, 1)
viewer's group mention in light hsla(180, 13%, 95%, 1) and in dark hsla(180, 13%, 15%, 1)
personal message in light hsla(45, 20%, 96%, 1) and in dark hsla(46, 25%, 14%, 1)

2. Hover background
This goes on top of previous layer. In light theme is 2% black hsla(0, 0%, 0%, 0.02) and in dark theme is  2% white background: hsla(0, 0%, 100%, 0.02);

3. Message content
Partly specified in https://github.com/zulip/zulip/issues/22022
4. Hover buttons (appear on the whole message hover)

Every button width is 26px, height in the design sketch is 25px, but just to be aligned good with datetime label, so I suggest to start with 26x26 buttons and see if it would be ok to tune top margin.
Button icons has 50% opacity until hovered, to have 100% opacity. In light theme icon color is`#1D2E48` and in dark `#DBE3F0`
Icons:
more-vertical - custom icon
star - https://feathericons.com/?query=star 1.33 stroke
star-filled - https://feathericons.com/?query=star 1.33 stroke + filled
smile - https://feathericons.com/?query=smile 1.33 stroke
5. Zulip focus rectangle
Color in light hsla(217, 64%, 59%, 0.6) and in dark is hsla(217, 64%, 59%, 0.7). In the figma border-radius: 4px; and stroke is 1px inside, so box-sizing: border-box;

6. Unread indicator
1px left border, inside the whole message rectangle. Could be done with a shadow box-shadow: inset 1px 0px 0px #3380FF; (same for dark theme)

Related thread: https://chat.zulip.org/#narrow/stream/431-redesign-project/topic/font.20size

Steps 0, 1 and 2 can be worked on.

I made an update to a PR that mentions this issue two days ago!

yup still working on it, I'm just waiting on review

@zulipbot  claim

yup

@evykassirer @terpimost @amanagr can you update the checkboxes with what's been completed here?
Like with #25247, we are likely at the point with this issue where we should open issues for what remains and then close it out -- I almost always want to do that with checkbox list issues with long threads that are >75% done.

2, 3, 4, 6 aren't done as far as I know, though Aman might have done some of them. Having individual issues for the remaining items seems good regardless though

I believe (6) is done, and there are no remaining release goals here, but @amanagr should confirm.

Yes, (6) is done.

For the remaining parts:

Hover background was attempted as #22419, but feedback on CZO was that a basic implementation of this change can be confusing/distracting for keyboard navigation users. Next step: Decide if there's some version of this that we want to implement; see CZO discussion about why it's tricky.
Message content changes are tracked in https://github.com/zulip/zulip/issues/22022.
I filed #25903 to track the hover buttons changes.

Closing this issue as the rest has been completed.


3DCityDB 4.x: delete CityObjectGroup WITHOUT its members?

Hi,
In the 3DCityDB 3.x you could choose where to delete a CityObjectGroup with or without its CityObject members.
It seems to me that in the 3DCityDB 4.x the default and only option is that a CityObjectGroup is always deleted with all its members via del_cityobjectgroup(....).
Do you confirm? I am not sure if I am missing out something.
Best regards,
GA

Yes, the behaviour of this delete function has been changed since 3DCityDB 4.0.  When deleting a CityObjectGroup, its members are only deleted if they are not referenced by another CityObjectGroup.

Hi Zhihang!
Thanks for the quick reply. A couple of comments:

Maybe this behaviour should be stated somewhere in the documentation. The del_cityobjectgroup behaves indeed a bit differently from the other functions (and compared to the past!) and my impression is that it could lead to unwanted "disasters"... :-)

Then we are missing the option to simply delete the cityobject group.

Maybe:

a) the default behaviour of function del_cityobjectgroup should NOT delete the group members. This is also the one that it is called from within del_cityobject().
b) To delete also the members, there could be another ad hoc function (e.g. del_cityobjectgroup_cascade(int[]) which works as the current one. On the one hand we have another function (unlike 3DCityDB 3.x), but on the other hand it is rather easy to add.
What do you think? Just my two cents! ;-)
All the best!
GA

Hi Giorgio,
thanks very much for your comments. Since 3DCityDB version 4.0, all delete and envelope function code have been automatically derived using the ADE-Manager plugin. The derivation follows a set of common rules in order to support CityGML ADEs in a generic way. One rule is the followings:

Classes with association relationship: If one object is deleted, the associated objects will not be deleted.
Classes with aggregation relationship: If a parent is deleted, the children will only be deleted if it has no other parent. (This is the case for CityObjectGroup)
Classes with composition relationship: If a parent is deleted, the children will be deleted immediately.

The meta-information about the class association types can be obtained from the 3DCityDB aggregation_info table, where the first row refelects the aggregation relationship between CityObjectGroup and _CityObject.
I fully agree with your points. Although the CityObjectGroup and _CityObject has an aggregation relationship, the delete function should behave differently, since the children are top-level features and they shall not be deleted in a cascaded fashion. (in most practical use cases)
I'll try to improve this for the next 3DCityDB version.
Cheers,
Zhihang

Since v4, the delete scripts are generated automatically from the 3DCityDB schema in a generic way. Changing the delete behaviour just for CityObjectGroups would require specific exceptions in this algorithm. After an internal discussion, we decided against it for v4. A workaround would be to define your own delete function for CityObjectGroups.


Solve recaptcha

Have you tried adding https://anti-captcha.com to the tool?

I think that's really beyond the scope of this project. Besides, the user a adoption rate for a method that costs money would be extremely low and likely not worth the effort IMHO.

Exceptions are now raised for captchas, but there are no plans to provide a way to solve captchas.