Call a Function

We forgot to call the function that displays the contribution to elements. So when the "contribution" menu in "dashboard.html" is clicked, the entire pop-up is still until you click another tab.
You task is to call the function that will display the contribution form for elements.

can this be assigned to me ?
Have the function been created?

alright 👍 I have assigned this to you

i went through the website now, you mean the contribute link, right.
I clicked on it and the pop up showed, do you want it to display only when it is clicked

For further explanation, We have two functions.
The first function is activated when you click on the "contribute"
menu/link as you have earlier said. The aim of the first function is to
display the contribution page containing(Element contribution, Style,
Attribute and module contribution). That works just fine.
However, When the contribution pop-up appears it only displays headers and
no bodily content in the iframe. The reason is because the function that
handles that was not called. To display the bodily content, You may then
need to click the headers again.
Your Job is to search for both functions. Your contribution will only be in
the function that is called when user clicks on "contribute". append a call
on the end of this function to provide bodily content when the users click
"contribute".
On Fri, Oct 7, 2022, 21:43 Ogunmisi Oluwafemi @.***>
wrote:

i went through the website now, you mean the contribute link, right.
I clicked on it and the pop up showed, do you want it to display only when
it is clicked
—
Reply to this email directly, view it on GitHub
https://github.com/KwickerHub/frontend/issues/47#issuecomment-1272072294,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOKWIBLLUOST524N5QWJVJDWCCDQFANCNFSM6AAAAAAQ7BX3B4
.
You are receiving this because you authored the thread.Message ID:
@.***>


New releases should be published to PyPI by pushing a tagged commit to GitHub

Acceptance

[x] This tool is automatically published on PyPI every time a tagged commit is pushed to the repo.

Tasks

[x] Set up GitHub Actions and workflow.

Analysis

It is inconvenient to have to publish manually each time. So I don't have to remember how to do it and can also move it out of the README, this could go inside a GitHub Actions workflow as explained at https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

FIXED: Done. Creating a new release on GitHub triggers a GitHub Actions workflow, i.e. https://github.com/sglavoie/uol-grades-calculator/blob/12c19b8d70d0685a80e5057f62f6d959f20bc741/.github/workflows/python-publish.yml, and automatically publishes to PyPI.


Issue with generation of the CMakeLists.txt file

When CMakeLists.txt is generated quotes are not inserted before and after the path meaning that if there is a space in the SDK path cmake fails to generate the build files.
I have submitted a pull request with a fix for this bug.

https://github.com/raspberrypi/pico-project-generator/pull/3

https://github.com/raspberrypi/pico-project-generator/pull/3

Thanks, will take a look on Monday. There's going to be a number of things like this, so be prepared!

Thanks, will take a look on Monday. There's going to be a number of things like this, so be prepared!

Yeah i can imagine! all i did was just add one line and it seems to work fine for me.

Yeah i can imagine! all i did was just add one line and it seems to work fine for me.

Fix merged. Thanks!

Fix merged. Thanks!


Bump requests to v2.31.0

Resolving reported vulnerability

@genestack-okunitsyn, could you please fix up whatever required to make the tests pass?

Yep, sure.
Should works. PR

We can merge PR's like this only in the same time to keep autotests in green state.
I did it.


feat: adopt pydantic-lite rewrite

@xgui3783
Thats sound good.
I will create a dev branch from the current master und merge #67 into it.
And after we merge the pydantic branch on the siibra-python side into the main, we can catch up with the other changes.


n:nonce marked as uknown attribute

@matej21 @JanTvrdik if I prepare PR will you approve it and release new version ?

@soundake You know that you can just hit alt+enter and register the n:nonce, right?

of course, but it is not custom macro, it is official macro from latte, there is no reason why it should not have direct support

Resolved in 1.0.0


openvpn-auth-ldap.so plugin not being loaded in CentOS 7

I am deploying an openvpn server on CentOS 7, and openvpn fails to start due to an invalid config. I've traced it to this line (https://github.com/voxpupuli/puppet-openvpn/blob/master/manifests/params.pp#L33) unsetting the lib file. This writes out an invalid plugin line in the config causing the following error to appear.
Thu Oct 11 10:49:30 2018 us=958804 PLUGIN_INIT: could not load plugin shared object /etc/openvpn/vpnserver/auth/ldap.conf: /etc/openvpn/vpnserver/auth/ldap.conf: invalid ELF header: No such file or directory (errno=2)
The config looks like this:
plugin  "/etc/openvpn/vpnserver/auth/ldap.conf"
when it should look like this:
plugin /usr/lib64/openvpn/plugin/lib/openvpn-auth-ldap.so "/etc/openvpn/vpnserver/auth/ldap.conf"
Error is in the current commit, as well as the module on puppetforge which I'm currently trying to use.

Hey @kindred, thanks for reporting this. Can you provide a pull request for this bug?


[Model] Add Gemma 2

This PR adds Gemma 2, a new family of open LLMs from Google.
Two major issues to note:

Attention logit soft-capping: Gemma 2 models soft-cap the attention logits. This requires changes to all the attention kernels vLLM is using, so this PR removes soft-capping as a temporary workaround. While this makes the model different from the original implementation, it does not significantly affect the model's generation capability.
Sliding window attention: Gemma 2 uses sliding window attention for every other layer. vLLM currently ignores it and uses global attention for all layers. This might affect the model's behavior when the context length is larger than the sliding window size (4K). Therefore, this PR temporarily truncates the model's maximum length to 4K.

These issues will also be explicitly mentioned in warning messages.

@WoosukKwon running with --disable-sliding-window should resolve this. We could also set this as the default if gemma2 arch is detected

@robertgshaw2-neuralmagic Yes I did a similar thing in config.py Could you please take a look?

@robertgshaw2-neuralmagic Yes I did a similar thing in config.py Could you please take a look?

The only issue with what you have done is that model_max_len will get set tomax_position_embedding rather than sliding_window_size
If you set disable_sliding_window=True in https://github.com/vllm-project/vllm/blob/df2c007974b09777259f5bc55ba4b94092f9f475/vllm/config.py#L137, then you all of the logic associated with selecting the max_seq_len will be capped at sliding window size
If we do not want this as the default behavior, we could instead let the user know about this flag in the print_warning_once

@robertgshaw2-neuralmagic Thanks for letting me know! Update the PR. PTAL.

Attention logit soft-capping: Gemma 2 models soft-cap the attention logits. This requires changes to all the attention kernels vLLM is using, so this PR removes soft-capping as a temporary workaround. While this makes the model different from the original implementation, it does not significantly affect the model's generation capability.

For the 27b model, logit soft-capping seems to be very important: https://github.com/huggingface/transformers/pull/31698. 9b model works fine without it.

@zifeitong Thanks for letting us know! We are planning to use the latest version of FlashInfer to include the soft-capping. Please stay tuned.

@zifeitong Thanks for letting us know! We are planning to use the latest version of FlashInfer to include the soft-capping. Please stay tuned.

Would also like to report that install from source of current vllm with gemma2 support is working fine for gemma-2-9b and completely failing for gemma-2-27b. Exact same code, same prompts, etc and it all is fitting on single H100. Gemma-2-27B only outputs 0 tokens, while Gemma-2-9B outputs as expected. Working with the base models downloaded from huggingface repos.

@zifeitong Thanks for letting us know! We are planning to use the latest version of FlashInfer to include the soft-capping. Please stay tuned.

Would also like to report that install from source of current vllm with gemma2 support is working fine for gemma-2-9b and completely failing for gemma-2-27b. Exact same code, same prompts, etc and it all is fitting on single H100. Gemma-2-27B only outputs 0 tokens, while Gemma-2-9B outputs as expected. Working with the base models downloaded from huggingface repos.

I obtained results similar to  @Rallio67 . When using vLLM on A800 with bf16 for generation, Gemma2-9B generates normally, but sometimes Gemma2-27B cannot complete the generation properly and continuously produces a large number of meaningless words.

Will the 8k context length be supported in the future?

Multiple sources (e.g., https://www.reddit.com/r/LocalLLaMA/comments/1dusu3s/gemma_2_finetuning_2x_faster_63_less_memory_best/) have confirmed that softcapping is an absolute necessity for the 27b checkpoint. Are there any plans of making this available in vllm? Otherwise, the generation of the 27b checkpoint is useless...

Multiple sources (e.g., https://www.reddit.com/r/LocalLLaMA/comments/1dusu3s/gemma_2_finetuning_2x_faster_63_less_memory_best/) have confirmed that softcapping is an absolute necessity for the 27b checkpoint. Are there any plans of making this available in vllm? Otherwise, the generation of the 27b checkpoint is useless...

Release v0.5.1 from the weekend supports logits soft capping with the FLASHINFER attention backend

Multiple sources (e.g., https://www.reddit.com/r/LocalLLaMA/comments/1dusu3s/gemma_2_finetuning_2x_faster_63_less_memory_best/) have confirmed that softcapping is an absolute necessity for the 27b checkpoint. Are there any plans of making this available in vllm? Otherwise, the generation of the 27b checkpoint is useless...

Release v0.5.1 from the weekend supports logits soft capping with the FLASHINFER attention backend
run error

Please do not post screenshots of error messages, they are difficult to parse and are not searchable
You have the wrong versions of FlashInfer installed.

Make sure that you match the proper torch and CUDA versions (torch 2.3 and likely cuda 12.1 is what you want)

Multiple sources (e.g., https://www.reddit.com/r/LocalLLaMA/comments/1dusu3s/gemma_2_finetuning_2x_faster_63_less_memory_best/) have confirmed that softcapping is an absolute necessity for the 27b checkpoint. Are there any plans of making this available in vllm? Otherwise, the generation of the 27b checkpoint is useless...

Release v0.5.1 from the weekend supports logits soft capping with the FLASHINFER attention backend

Thank you very much for your contribution, but @Hi-archers in https://github.com/vllm-project/vllm/issues/6166#issuecomment-2214219533 currently has several users experiencing a "Segmentation fault (core dumped)" error after performing extensive Gemma2 inferences using the FlashInfer backend. My current environment is Torch 2.3.0, Cuda 12.1, and FlashInfer 0.08. I hope you can address this issue. Thank you.

FlashInfer is built for specific CUDA versions and PyTorch versions. So you can have CUDA 12.1 and Torch2.3.0 but you may have installed FlashInfer built with Torch 2.2.0.
When this happens, we will get the error BatchDecodeWithPagedKVCacheWrapper
The default whl for vllm is Python 2.3 and CUDA 12.1. So you likely want to install the following FlashInfer whl:
PYTHON_VERSION=310
wget https://github.com/flashinfer-ai/flashinfer/releases/download/v0.0.8/flashinfer-0.0.8+cu121torch2.3-cp${PYTHON_VERSION}-cp${PYTHON_VERSION}-linux_x86_64.whl

FlashInfer is built for specific CUDA versions and PyTorch versions. So you can have CUDA 12.1 and Torch2.3.0 but you may have installed FlashInfer built with Torch 2.2.0.
When this happens, we will get the error BatchDecodeWithPagedKVCacheWrapper
The default whl for vllm is Python 2.3 and CUDA 12.1. So you likely want to install the following FlashInfer whl:
PYTHON_VERSION=310
wget https://github.com/flashinfer-ai/flashinfer/releases/download/v0.0.8/flashinfer-0.0.8+cu121torch2.3-cp${PYTHON_VERSION}-cp${PYTHON_VERSION}-linux_x86_64.whl

TKS, Has been running, but the openai interface call answer has been empty.

Please refrain from posting images of your errors. Rather, paste the the test so that I can copy/paste and so that it is searchable
Can you please try the instruction model rather than the pretrained model with the chat interface?

FlashInfer is built for specific CUDA versions and PyTorch versions. So you can have CUDA 12.1 and Torch2.3.0 but you may have installed FlashInfer built with Torch 2.2.0.
When this happens, we will get the error BatchDecodeWithPagedKVCacheWrapper
The default whl for vllm is Python 2.3 and CUDA 12.1. So you likely want to install the following FlashInfer whl:
PYTHON_VERSION=310
wget https://github.com/flashinfer-ai/flashinfer/releases/download/v0.0.8/flashinfer-0.0.8+cu121torch2.3-cp${PYTHON_VERSION}-cp${PYTHON_VERSION}-linux_x86_64.whl

Thank you for your response. However, even after following your instructions to install FLASHINFER, I still encountered a Segmentation fault (core dumped). This time it occurred at 3729/3822 lines, whereas previously it happened at 3708/3822 lines. Should I open a new issue to address this problem?

Can you do pip show vllm and tell me what you see?

Can you do pip show vllm and tell me what you see?

pip show vllm:
Name: vllm
Version: 0.5.1
Summary: A high-throughput and memory-efficient inference and serving engine for LLMs
Home-page: https://github.com/vllm-project/vllm
Author: vLLM Team
Author-email:
License: Apache 2.0
Location: /home/weizihao/miniconda3/envs/gemma/lib/python3.10/site-packages
Requires: aiohttp, cmake, fastapi, filelock, lm-format-enforcer, ninja, numpy, nvidia-ml-py, openai, outlines, pillow, prometheus-client, prometheus-fastapi-instrumentator, psutil, py-cpuinfo, pydantic, ray, requests, sentencepiece, tiktoken, tokenizers, torch, torchvision, tqdm, transformers, typing-extensions, uvicorn, vllm-flash-attn, xformers
Required-by:
My Code:
import json
import time

from vllm import LLM, SamplingParams
from transformers import AutoModelForCausalLM, AutoTokenizer
import torch

import argparse

from tqdm import tqdm

import os
import sys

os.environ["VLLM_ATTENTION_BACKEND"] = "FLASHINFER"
os.environ["HF_TOKEN"] = "<TOKEN>"

parser = argparse.ArgumentParser()
parser.add_argument('--top', type=str, default="3")
parser.add_argument('--seed', type=int, default=42)
parser.add_argument('--cuda', type=int, default=1)
parser.add_argument('--utili', type=float, default=1)
parser.add_argument('--model_name', type=str, default="/data1/**/Gemma2/gemma-2-9b-it")
parser.add_argument('--title', type=int, default=1)
parser.add_argument('--temperature', type=float, default=0.)

args = parser.parse_args()

print(args)

os.environ["CUDA_VISIBLE_DEVICES"] = str(args.cuda)
sys.path.append(os.path.abspath("../../"))

from system_prompt import system_prompts, demonstration, instruction

sampling_params = SamplingParams(
    temperature=args.temperature,
    seed=args.seed,
    max_tokens=100,
    )

print(sampling_params)

model_name = args.model_name
tokenizer = AutoTokenizer.from_pretrained(model_name)

llm = LLM(
    model=model_name,
    seed=args.seed,
    gpu_memory_utilization=args.utili,
    )

if __name__ == "__main__":

    answer = []
    prompts = []

    for i, line in tqdm(enumerate(que), total=len(que)):
        for i_line in tmp:
            prompts.append(get_template(i_line["que"], i_line['A'], i_line["B"]))

    print(len(prompts)) # 3822

    outputs = llm.generate(prompts, sampling_params)

I removed the irrelevant code from my code.

Please refrain from posting images of your errors. Rather, paste the the test so that I can copy/paste and so that it is searchable
Can you please try the instruction model rather than the pretrained model with the chat interface?

I downloaded the wrong version. It's working fine now.

I can get it to run with flashinfer as the attention backend, but results are still abysmal.
Any idea what could still be different from the original implementation?

Hi! I'm using the latest vLLM image on docker, on GCP using A100 GPUs. I'm getting the following error when making many requests to the OpenAI server:
2024-07-09 13:06:08.540 | NotImplementedError |
-- | -- | --
  |   | 2024-07-09 13:06:08.540 | raise NotImplementedError |
  |   | 2024-07-09 13:06:08.540 | self.attn_backend.copy_blocks(self.gpu_cache, src_to_dsts) |
  |   | 2024-07-09 13:06:08.540 | self.cache_engine[virtual_engine].copy(worker_input.blocks_to_copy) |
  |   | 2024-07-09 13:06:08.540 | return func(*args, **kwargs) |
  |   | 2024-07-09 13:06:08.540 | self.execute_worker(worker_input) |
  |   | 2024-07-09 13:06:08.540 | raise result |
  |   | 2024-07-09 13:06:08.540 | async for request_output in stream: |
  |   | 2024-07-09 13:06:08.540 | raise e |
  |   | 2024-07-09 13:06:08.540 | async for output in self._process_request( |
  |   | 2024-07-09 13:06:08.540 | async for res in result_generator: |
  |   | 2024-07-09 13:06:08.540 | return await self.chat_completion_full_generator( |
  |   | 2024-07-09 13:06:08.540 | return await dependant.call(**values) |
  |   | 2024-07-09 13:06:08.540 | await app(scope, receive, sender) |
  |   | 2024-07-09 13:06:08.540 | raise exc |
  |   | 2024-07-09 13:06:08.540 | await wrap_app_handling_exceptions(app, request)(scope, receive, send) |
  |   | 2024-07-09 13:06:08.540 | await self.app(scope, receive, send) |
  |   | 2024-07-09 13:06:08.539 | await route.handle(scope, receive, send) |
  |   | 2024-07-09 13:06:08.539 | await self.middleware_stack(scope, receive, send) |
  |   | 2024-07-09 13:06:08.539 | await app(scope, receive, sender) |
  |   | 2024-07-09 13:06:08.539 | raise exc

This is with vLLM 0.5.1 with
VLLM_ATTENTION_BACKEND=FLASHINFER and --disable-sliding-window flags. I sshed to the machine and saw that the correct version of FlashInfer is installed (0.0.8, torch 2.3).
What am I doing wrong?

Hi! I'm using the latest vLLM image on docker, on GCP using A100 GPUs. I'm getting the following error when making many requests to the OpenAI server, using the 27GB instruction tuned model:
2024-07-09 13:06:08.540 | NotImplementedError |
-- | -- | --
  |   | 2024-07-09 13:06:08.540 | raise NotImplementedError |
  |   | 2024-07-09 13:06:08.540 | self.attn_backend.copy_blocks(self.gpu_cache, src_to_dsts) |
  |   | 2024-07-09 13:06:08.540 | self.cache_engine[virtual_engine].copy(worker_input.blocks_to_copy) |
  |   | 2024-07-09 13:06:08.540 | return func(*args, **kwargs) |
  |   | 2024-07-09 13:06:08.540 | self.execute_worker(worker_input) |
  |   | 2024-07-09 13:06:08.540 | raise result |
  |   | 2024-07-09 13:06:08.540 | async for request_output in stream: |
  |   | 2024-07-09 13:06:08.540 | raise e |
  |   | 2024-07-09 13:06:08.540 | async for output in self._process_request( |
  |   | 2024-07-09 13:06:08.540 | async for res in result_generator: |
  |   | 2024-07-09 13:06:08.540 | return await self.chat_completion_full_generator( |
  |   | 2024-07-09 13:06:08.540 | return await dependant.call(**values) |
  |   | 2024-07-09 13:06:08.540 | await app(scope, receive, sender) |
  |   | 2024-07-09 13:06:08.540 | raise exc |
  |   | 2024-07-09 13:06:08.540 | await wrap_app_handling_exceptions(app, request)(scope, receive, send) |
  |   | 2024-07-09 13:06:08.540 | await self.app(scope, receive, send) |
  |   | 2024-07-09 13:06:08.539 | await route.handle(scope, receive, send) |
  |   | 2024-07-09 13:06:08.539 | await self.middleware_stack(scope, receive, send) |
  |   | 2024-07-09 13:06:08.539 | await app(scope, receive, sender) |
  |   | 2024-07-09 13:06:08.539 | raise exc

This is with vLLM 0.5.1 with VLLM_ATTENTION_BACKEND=FLASHINFER and --disable-sliding-window flags. I sshed to the machine and saw that the correct version of FlashInfer is installed (0.0.8, torch 2.3).
What am I doing wrong? Indeed this seems to be the case:
https://github.com/vllm-project/vllm/blob/08c5bdecae5c5186c39a1d1ff444c3bf01f7fa0e/vllm/attention/backends/flashinfer.py#L56

can you please share your code sample? how you load the gemma with its params

Hi! I'm using the latest vLLM image on docker, on GCP using A100 GPUs. I'm getting the following error when making many requests to the OpenAI server, using the 27GB instruction tuned model:
2024-07-09 13:06:08.540 | NotImplementedError |
-- | -- | --
  |   | 2024-07-09 13:06:08.540 | raise NotImplementedError |
  |   | 2024-07-09 13:06:08.540 | self.attn_backend.copy_blocks(self.gpu_cache, src_to_dsts) |
  |   | 2024-07-09 13:06:08.540 | self.cache_engine[virtual_engine].copy(worker_input.blocks_to_copy) |
  |   | 2024-07-09 13:06:08.540 | return func(*args, **kwargs) |
  |   | 2024-07-09 13:06:08.540 | self.execute_worker(worker_input) |
  |   | 2024-07-09 13:06:08.540 | raise result |
  |   | 2024-07-09 13:06:08.540 | async for request_output in stream: |
  |   | 2024-07-09 13:06:08.540 | raise e |
  |   | 2024-07-09 13:06:08.540 | async for output in self._process_request( |
  |   | 2024-07-09 13:06:08.540 | async for res in result_generator: |
  |   | 2024-07-09 13:06:08.540 | return await self.chat_completion_full_generator( |
  |   | 2024-07-09 13:06:08.540 | return await dependant.call(**values) |
  |   | 2024-07-09 13:06:08.540 | await app(scope, receive, sender) |
  |   | 2024-07-09 13:06:08.540 | raise exc |
  |   | 2024-07-09 13:06:08.540 | await wrap_app_handling_exceptions(app, request)(scope, receive, send) |
  |   | 2024-07-09 13:06:08.540 | await self.app(scope, receive, send) |
  |   | 2024-07-09 13:06:08.539 | await route.handle(scope, receive, send) |
  |   | 2024-07-09 13:06:08.539 | await self.middleware_stack(scope, receive, send) |
  |   | 2024-07-09 13:06:08.539 | await app(scope, receive, sender) |
  |   | 2024-07-09 13:06:08.539 | raise exc

This is with vLLM 0.5.1 with VLLM_ATTENTION_BACKEND=FLASHINFER and --disable-sliding-window flags. I sshed to the machine and saw that the correct version of FlashInfer is installed (0.0.8, torch 2.3).
What am I doing wrong? Indeed this seems to be the case:
https://github.com/vllm-project/vllm/blob/08c5bdecae5c5186c39a1d1ff444c3bf01f7fa0e/vllm/attention/backends/flashinfer.py#L56

can you please share your code sample? how you load the gemma2 27b with its params?

We use vLLM through k8s, this is the relevant snippet from the yaml:
containers:
        - name: main
          command:
          # https://github.com/huggingface/text-generation-inference/issues/1330
          # Without this weird ldconfig trick, we will get a "libcuda.so not found" error.
            - bash
            - -c
            - |
              ldconfig
              echo "Setting VLLM_ATTENTION_BACKEND to FLASHINFER to use the FlashInfer backend. Required for gemma2 logit capping"
              export VLLM_ATTENTION_BACKEND=FLASHINFER
              echo "Starting vLLM server with --disable-sliding-window as version 0.5.1 requires it with FlashInfer backend."
              python3 -m vllm.entrypoints.openai.api_server --model google/gemma-2-27b-it --disable-sliding-window
          image: vllm/vllm-openai:latest

When I am running gemm2-9b-it on h100, 80GB. The speed is very slow for me, like 20 TPS, any idea why? I launched with Lora adapter. its like much faster on sglang, with 43TPS.

Is there currently a plan to support sliding windows?

Has it been changed since then? Is SLA supported without cap on the context length?


Delete Bucket Privileges if Just Restoring?

Do you need delete privileges on the AWS bucket files if the Elastic server is just restoring? (not snapshotting)

You need delete privileges when you create the repository because elasticsearch will check that it can write a file to the repo and then will remove it.
From elasticsearch 2.1.0, a readonly parameter is supported. So I think you can create a S3 repository with readonly parameter and in that case you won't need the delete privilege.
If it does not work for you, please open a thread on discuss.elastic.co or open an issue at https://github.com/elastic/elasticsearch/issues


Dev Tools causing performance issues with MdSelect

Bug, feature request, or proposal:
REQUEST, maybe BUG
What is the expected behavior?
When using MdSelect with dev tools open, render should be closer to the speed for when dev tools are closed.
What is the current behavior?
With dev tools open, loading a select takes about 4 to 5 times longer for a list of 2000 items than with dev tools closed.  As the list grows, the length of time increases proportionally.
For large lists, this makes development very cumbersome.  The native select does not have this issue.  The manner in which the app is built does not matter, AOT and JIT exhibit the same behavior.   I think some slow down is to be expected, but 5x seems like a lot.
What are the steps to reproduce?
Providing a StackBlitz/Plunker (or similar) is the best way to get the team to see your issue.
https://angular-material2-issue-3e9zci.stackblitz.io
Test with dev tools open and closed and notice how long it takes to load the mdselect list.  Do the same test with the native select.  You will notice that the MdSelect slows down much more than the native select.
What is the use-case or motivation for changing an existing behavior?
Faster development. It's slow and locks up the screen regardless but its bearable with dev tools closed, but that makes development much more difficult.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
"@angular/core": "^4.4.6",
"@angular/material": "^2.0.0-beta.12",
"typescript": "~2.3.3",
Tested with Edge & Chrome 61 on Windows 10
Is there anything else we should know?

@rkajbaf

You have angular change detection error in app (ExpressinChanged....)
I think performance is weak due to around 4000 log into devtools console (event if they are filtered out and not visible) - [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event ...

@tytskyi - The latter has a PR already thankfully. The touchstart issue was resolved for a while & is back in 5.0.0 & definitely has an adverse effect on performance.

The issue with a touchstart warning being logged has been resolved for a long time now. Closing.


User doesn't have a role property upon token refresh. Leads to false 403's

Describe the bug
Upon refreshing the auth token, the "user" object attached to the "request" is missing the "role" property. When using the "RolesGuard", the user must have the "role" property present in order to pass; it does not. This leads to the RolesGuard rejecting with a 403
To Reproduce
Steps to reproduce the behavior:

Set the token expiration to a small number.
Trigger the login, log the "request.user" from RolesGuard, observe that is has a "role" property upon the initial login.
Trigger the refresh.
Test the same route as in step 2. The user doesn't have a role property anymore.

Expected behavior
I would expect request.user to have consistent properties, and for the route's specifying roles.user to not reject the user on a 403.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Mac
NodeJS Version 20.9.0

Additional context
none.

Side note: Thank you so much for making this and putting it out. I would fix the problem, but I myself am learning more about  Nest from the examples laid forth in this project.

@JordanTreDaniel thank you! Fixed.


Add a note to fix shims issue on Windows

Description
On V2, there is a known issue that some npm scripts are not working in template-* packages. eg. npm start in template-retail-react-app. This is because shims are not properly added on Windows during the installation steps.
To fix this, running npm run lerna link --force-local after npm ci finishes
Ref sources:

https://github.com/lerna/lerna/issues/385#issuecomment-948402686

Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

(change1)

How to Test-Drive This PR

(step1)

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

Due to the change in this PR, I've renamed the branch and open a new PR here


Performing a LINK request

I'm working an API client for some (needlessly) experimental API.
I need to do an HTTP LINK request.
See: https://tools.ietf.org/id/draft-snell-link-method-01.html#rfc.section.2
Seeing as it's not defined on the module, I tried this (inspired by rest-client's own implementation of the get, post, head, etc...):
RestClient::Request.execute(
      method: :link,
      url: "https://target.dev/api/link/123/with/456",
      headers: generate_headers
    )

This sadly triggers a
NameError: uninitialized constant Net::HTTP::Link

It seems that rest-client is fundamentally incapable of supporting LINK requests, since it constantizes the HTTP verb on https://github.com/rest-client/rest-client/blob/master/lib/restclient/request.rb#L510 and Net::HTTP does not include any implementation for LINK requests.
Can anyone confirm my conclusion or am I missing something?

Yeah, I'd be surprised if there's any way to do this with rest-client. Do you know if Net::HTTP has any support for specifying custom HTTP verbs?

I have dug into it and found that Net::HTTP doesn't have any programmatic API or DSL for doing it, but the way each verb is implemented makes it trivial to add more verbs.
To support the link action, one has to define the following class:
class Net::HTTP::Link < Net::HTTPRequest
  METHOD = "LINK"
  REQUEST_HAS_BODY = false
  RESPONSE_HAS_BODY = false
end

With this defined, rest-client will support link.
It works, it's simple. I doubt it's officially endorsed though, so it's hard to know if time will be lenient against this expansion of the standard library in Ruby.

Neat!


use slf4j instead of java.util.logging

The default logger uses JUL which is hardy ever used in modern applications. It would be nice if FoxHttp just used the slf4j-api like many other Java frameworks.
It would allow users to be flexible with the loggging-implementation while still providing logging out of the box.

see Slf4jLogger


How to create Webhook for Azure Automation runbook when it's only visible in portal

Bicep version
Bicep CLI version 0.21.1 (https://github.com/Azure/bicep/commit/d4acbd2a9f47281340d1315e1b6e4bbfb9c4e257)
Describe the issue
We need to create a Webhook to run Azure Automation runbooks via bicep.
I am using bicep to deploy an event grid subscription that should have the runbook's webhook as endpoint url. For security reasons, you can only view the URL in the Azure portal when creating the webhook. That seems to makes it impossible to create it with bicep?
In the Azure Event Subscription resource im trying to fetch the webhook uri by using:
endpointUrl: webhook.properties.uri
Error code
I get this when deploying bicep below:
Invalid event subscription request: Supplied URL is invalid. It cannot b deployment operations for de null or empty and should be a proper HTTPS URL like https://www.example.com."
Code
param Location string = resourceGroup().location

resource automationAccount 'Microsoft.Automation/automationAccounts@2022-08-08' = {
  identity: {
    type: 'SystemAssigned'
  }
  location: Location
  name: 'automationAccount'
  properties: {
    disableLocalAuth: false
    encryption: {
      identity: {}
      keySource: 'Microsoft.Automation'
    }
    publicNetworkAccess: true
    sku: {
      name: 'Basic'
    }
  }
}

resource runbook 'Microsoft.Automation/automationAccounts/runbooks@2019-06-01' = {
  name: 'keyvault-events'
  parent: automationAccount
  location: Location
  properties: {
    runbookType: 'PowerShell'
    logProgress: true
    logVerbose: true
    publishContentLink: {
      uri: 'https://powershell.blob.core.windows.net/runbooks/keyvault-events.ps1'
      contentHash: {
        algorithm: 'SHA256'
        value: 'hash-value-of-myRunbook.ps1'
      }
    }
  }
}

resource webhook 'Microsoft.Automation/automationAccounts/webhooks@2015-10-31' = {
  parent: automationAccount
  name: 'Webhook_1'
  properties: {
    expiryTime: '2024-01-01T18:00:00Z'
    isEnabled: true
    uri: ''
    runbook: {
      name: 'keyvault-events'
    }
  }
  dependsOn: [
    runbook
  ]
}

resource eventTopic 'Microsoft.EventGrid/systemTopics@2023-06-01-preview' = {
  location: Location
  name: 'eventTopic'
  properties: {
    source: '/subscriptions/resourceGroups/rg-keyvault/providers/Microsoft.KeyVault/vaults/cozyfrog-keyvault'
    topicType: 'Microsoft.KeyVault.vaults'
  }
  dependsOn: [
    webhook
  ]
}

resource eventSubscription 'Microsoft.EventGrid/systemTopics/eventSubscriptions@2023-06-01-preview' = {
  parent: eventTopic
  name: 'kv-notifications'
  properties: {
    destination: {
      endpointType: 'WebHook'
      properties: {
        endpointUrl: webhook.properties.uri
        maxEventsPerBatch: 1
        preferredBatchSizeInKilobytes: 64
      }
    }
    eventDeliverySchema: 'EventGridSchema'
    filter: {
      enableAdvancedFilteringOnArrays: true
      includedEventTypes: [
        'Microsoft.KeyVault.CertificateNewVersionCreated'
        'Microsoft.KeyVault.CertificateNearExpiry'
        'Microsoft.KeyVault.CertificateExpired'
        'Microsoft.KeyVault.SecretNewVersionCreated'
        'Microsoft.KeyVault.SecretNearExpiry'
        'Microsoft.KeyVault.SecretExpired'
        'Microsoft.KeyVault.KeyNewVersionCreated'
        'Microsoft.KeyVault.KeyNearExpiry'
        'Microsoft.KeyVault.KeyExpired'
      ]
    }
    labels: []
    retryPolicy: {
      eventTimeToLiveInMinutes: 1440
      maxDeliveryAttempts: 30
    }
  }
}

Tried to fetch the events from keyvault and use runbook as an eventhandler without success. I set it up with Azure Function App with Event Grid Trigger and that works. Closing this issue.


Code boxes - redundant labeling

Issue in /src/pages/implement/server-side/sdk-guides/getting-started/index.md
Code boxes throughout repo - redundant labeling of language (e.g. Java, .NET, Python, Node.js)
Within the code box, the language (e.g. Java, .NET, Python, Node.js) appears in both the tab headers on the left, as well as the dropdown on the right - should remove one for a cleaner experience.

Figured out this is a bug for the IO team to handle. Logged DEVSITE-448.
At present time, cannot choose either the tabs or the dropdown -- must have both present, even though it'll be redundant. (Theoretically, you should be able to not have the dropdown.)


Getting compilation error while running gulp command

I am getting this error while running gulp.
/Users/k0m00qd/projects/swiv-master/node_modules/@types/express-serve-static-core/index.d.ts(179,11): error TS1005 ',' expected.
/Users/k0m00qd/projects/swiv-master/node_modules/@types/express-serve-static-core/index.d.ts(180,12): error TS1005 ',' expected.
/Users/k0m00qd/projects/swiv-master/node_modules/@types/express-serve-static-core/index.d.ts(181,13): error TS1005 ',' expected.
/Users/k0m00qd/projects/swiv-master/node_modules/@types/express-serve-static-core/index.d.ts(178,10): error TS1005 ',' expected.
/Users/k0m00qd/projects/swiv-master/node_modules/@types/express-serve-static-core/index.d.ts(179,11): error TS1005 ',' expected.
/Users/k0m00qd/projects/swiv-master/node_modules/@types/express-serve-static-core/index.d.ts(180,12): error TS1005 ',' expected.
/Users/k0m00qd/projects/swiv-master/node_modules/@types/express-serve-static-core/index.d.ts(181,13): error TS1005 ',' expected.```

Any suggestion would help?

I have
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Hello,
This employee can no longer access email on this account.  Your email will not be forwarded.
If you have a sales inquiry, please contact<EMAIL_ADDRESS>If you require assistance with a legal matter, please contact<EMAIL_ADDRESS>Thank you!


Setup Registration Page Backend and frontend for Recruitment

The registration page needs to be setup for recruitment form submission. The  backend should be connected to firebase where the data is to be stored. Ideally, we want this form to be validation proof and DDOS secure.
This will use the existing frontend at /form route

I'll work on this.


Feature Request: shared references

Is it possible to add a feature for a shared reference to the notification system?  Perhaps we could register this in the root application layer:
<NotificationSystem shared="app" />
Each time it were rendered, it would store its reactjs ref in a simple object in shared_notices.js:
import shared_notices from 'react-notification-system/shared-notices'
shared_notices.app.addNotification(

The idea is to encourage component nesting.  Creating good modular components often means there will be many of them and they will be nested often.  It is better and easier to program to not have any requirements to pass redundant references.   If you have an alternative please let me know.

To clarify: The issue we are having is that we have to pass the root NotificationSystem component's ref to every child that needs to use it.  Any nested component under those children also need to have the ref specified as wel.  If at any point in the tree, the ref was left off, the notification system will be unavailable.  It is a global notify so this should not be necessary.

Hi @jcalfee. Are you using React with any Flux implementation?
If so, I'm using this component with Flux and this is what I did:
I created a notification store (and notification action) and created this component on a top level element on my HTML. On mounting, I add a listener to the notification store. After that, all I need is import my notification action where I want to raise the notification and call:
notificationAction.success({
  title: 'Title',
  message: 'Message'
  ...
});

.success is one of the four alias that I created in my notification action (.info, .error and .warning).
If you are not using Flux, the idea could be subscribe to channels, and for this you may consider use Postal: https://github.com/postaljs/postal.js
Let me know if any of these works for you.

Good news, we are using flux... Could you easily copy/paste each relevant component?  That will save us a lot of time.  Thank you!

Correction, we are using Alt

Well, I don't know exactly how Alt works. The flow from Facebook Flux is almost the same, but they have sightly differences from methods, how to register stores and actions. I'll try to implement this using flux implementations like Alt or Marty.
For now, I think it would be something like this:
Actions
import alt from './alt';

class NotificationActions {
   // Add notification
   addNotification(notification) {
      return notification;
   }
   // Creating aliases
  success(notification) {
     notification.level = 'success';
     this.addNotification(notification);
  }
}

export default alt.createActions(NotificationActions);

Store
import alt from './alt';
import NotificationActions from './NotificationActions'

class TodoStore {
  constructor() {
    this.bindListeners({
      addNotification: NotificationActions.addNotification
    });

    this.state = {
      notification: null
    };
  }

  addNotification(notification) {
    this.setState({ notification: notification });
  }
}

export default alt.createStore(NotificationStore, 'NotificationStore');

View
import connectToStores from 'alt/utils/connectToStores';
import { Component } from 'react';
import NotificationSystem from 'react-notification-system'
import NotificationStore from './NotificationStore';

@connectToStores
class NotificationView extends Component {
  static getStores() {
    return [NotificationStore];
  }

  _notificationSystem = null

  _onChange() {
    let notification = NotificationStore.getState().notification;
    this._notificationSystem.addNotification(notification);

  }

  componentDidMount() {
     this._notificationSystem = this.refs.notificationSystem;
     NotificationStore.listen(this._onChange)
  }

   componentWillUnmount() {
     NotificationStore.unlisten(this._onChange)
  }

  render() {
    return (
      <NotificationSystem ref="notificationSystem" />
    );
  }
}

As I said, I never used Alt and I'm not familiar with ES2015, so the code above was based on a quick read on Alt docs.

I'm still working with it... The issue I'm having is that componentDidMount() { this.refs.notificationSystem == null.  The reason is probably due to our render method.  When the app first renders it is loading, then it re-renders showing your NotificationSystem.  The componentDidMount method does not run again, it runs only once.
    render() {
        if (this.state.loading) {
            return <LoadingIndicator />;
        } else {
            return (

                    <MobileMenu isUnlocked={this.state.isUnlocked} id="mobile-menu"/>
                    <NotificationSystem ref="notificationSystem" />
                    <AccountNotifications/>

                        <RouteHandler/>

                    <ReactTooltip type="dark" effect="solid" />

            );
        }
    }

wait, sorry .. I was testing it wrong by calling the notification too early.. stand by.

I'm getting closer, must take a break though.
Is there a better way to get a reference to this.refs.notificationSystem?  The componentDidMount function does not re-execute when render is re-called (the state changes).  In this way the reference is lost.  In our case, we do not even add the NotificationSystem until after some API calls complete so we never see a reference to the reference to <NotificationSystem ref="notificationSystem" />.

Well, it shouldn't loose the reference. Please paste here your code..

It starts out loading then changes after the API calls finish:
render() {
        if (this.state.loading) {
            return <LoadingIndicator />;
        } else {
            return (

                    <MobileMenu isUnlocked={this.state.isUnlocked} id="mobile-menu"/>
                    <NotificationSystem ref="notificationSystem" />
                    <AccountNotifications/>

                        <RouteHandler addNotification={this._addNotification.bind(this)}/>

                    <ReactTooltip type="dark" effect="solid" />

            );
        }
    }

I could change the loading indicator to support child elements once loaded.  It is our own component.

Sorry, I did not think it was relevant so I deleted it.. Your solution if far more elegant!  Thank you!  I'll post the changes I make to get it to work after I test it.

This is not a issue related with this component so I'm closing this issue.

View
import NotificationSystem from "react-notification-system"
import NotificationStore from "stores/NotificationStore"

var notificationSystem

class App extends React.Component {

    componentWillUnmount() {
        NotificationStore.unlisten(this._onNotificationChange)
    }

    componentDidMount() {
        NotificationStore.listen(this._onNotificationChange)
        notificationSystem = this.refs.notificationSystem
    }

    /** Usage: NotificationActions.[success,error,warning,info] */
    _onNotificationChange() {
        let notification = NotificationStore.getState().notification
        notificationSystem.addNotification(notification)
    }

    render() {
        return

                {content}
                <NotificationSystem ref="notificationSystem"/>

    }

Store
import alt from "alt-instance"
import NotificationActions from "actions/NotificationActions"

class NotificationStore {

    constructor() {
        this.bindListeners({
            addNotification: NotificationActions.addNotification
        })

        this.state = {
            notification: null
        }
    }

    addNotification(notification) {
        this.setState({ notification: notification })
    }
}

export default alt.createStore(NotificationStore, 'NotificationStore')

Action
import alt from "alt-instance"

class NotificationActions {

    addNotification(notification) {
        this.dispatch(notification)
    }

    // Creating aliases: success, error, warning and info

    success(notification) {
        notification.level = 'success'
        this.addNotification(notification)
    }

    error(notification) {
        notification.level = 'error'
        this.addNotification(notification)
    }

    warning(notification) {
        notification.level = 'warning'
        this.addNotification(notification)
    }

    info(notification) {
        notification.level = 'info'
        this.addNotification(notification)
    }
}
export default alt.createActions(NotificationActions)

The code above it great. I have a question though:
What if we have a Store that is handling a callback from a respective Action, and depending on the response from that Action, we need to send an appropriate notification?
I've got my app set up pretty much like the code above, but the listener in the top-level view seems to complain when trying to add the notification from any Store (since the Store is already handling a dispatch from its respective Action). It never gets to the this.waitFor(Store) that I've placed within the NotificationStore addNotification method.
I get the error: Uncaught (in promise) Error: Invariant Violation: Dispatch.dispatch(...): Cannot dispatch in the middle of a dispatch.


Changed yes/no in feature request template to checkboxes

Under the question "If the feature request is approved, would you be willing to submit a PR?" I changed the response template to checkboxes. This matches the template for PRs (under "Does this introduce a breaking change?")
Pull request type
Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
Unclear what one is supposed to do when responding to the Yes/No question -- bold the answer? Delete the non-answer? And the italicized help text makes it a little more confusing.
Issue Number: N/A
What is the new behavior?

plain text => checkboxes

Other information
None

Hello, @rootwork! Thanks for contribution!


Add nappgui

NAppGUI is a professional SDK to build cross-platform desktop applications using The C Programming Language (ANSI C90). NAppGUI has built as a lightweight layer on top of the operating system native APIs, that allows create portable programs extremelly fast and small without any external dependency.

Building on macOS requires https://github.com/frang75/nappgui_src/pull/136 to be merged, and I don't know how to add it as a patch.

use add_patches to add patch, you can see other packages

Thanks for review, I'll fix


🌱 apiexport: strongly type enqueue params

Summary
Strongly type the params used in our enqueue functions to avoid accidentally enqueueing the wrong kind of object.
Also switch to struct function pointers for lister access.
Related issue(s)
Fixes #

/approve


Portable Yt-dlp Unable to Detect .CONF Config File

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
Using Yt-dlp in portable mode on a non-system drive, Yt-dlp seems unable to detect the config file that is placed in the same folder (beside the EXE file).
To rule out this being caused by the presence of hyphen & underscore in the filename, yt-dlp_min.exe has been renamed to ytp.exe & the folder structure is as follows:-
G:\zTemp\ytp.exe
G:\zTemp\ytp.conf

The ytp.conf file (extension = conf) contains the below content:-
# Shorten Video Filenames:
-o "%(title).200s.%(ext)s"

# Disable Filesystem Caching
--no-cache-dir

Observed Behaviour:
The line [debug] Portable config file: G:\zTemp\ytp.conf (ref: #1280) is missing from the verbose log. There are no lines mentioning [debug] Portable config in the log.
Yt-dlp fails to download from the sample video URL, & throws a FileNotFoundError: [Errno 2] No such file or directory error -- which is typical for Twitter URLs where the post contains an "excessive" number of characters (ref: #1280).
Expected Behaviour:
Yt-dlp should have successfully downloaded the video with an automatically shortened filename -- as instructed by the option -o "%(title).200s.%(ext)s" stated in the config file.
Instead, one has to manually specify a short filename using the -o option in the download command, & repeat this for every affected video URL, eg. ytp -v https://twitter.com/UNDP/status/1453210331308691459  -o "OutputVideo.mp4".
Tested: Yt-dlp v2<IP_ADDRESS> x64 & earlier versions
OS: Win 10 x64
Verbose log
G:\zTemp>ytp -v https://twitter.com/UNDP/status/1453210331308691459

    [debug] Command-line config: ['-v', 'https://twitter.com/UNDP/status/1453210331308691459']
    [debug] Encodings: locale cp65001, fs utf-8, out utf-8, err utf-8, pref cp65001
    [debug] yt-dlp version 2<IP_ADDRESS> (py2exe)
    [debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.18363
    [debug] exe versions: ffmpeg 4.4.1-essentials_build-www.gyan.dev (setts), ffprobe 4.4.1-essentials_build-www.gyan.dev
    [debug] Optional libraries: mutagen, sqlite, websockets
    [debug] Proxy map: {}

    [debug] [twitter] Extracting URL: https://twitter.com/UNDP/status/1453210331308691459
    [twitter]<PHONE_NUMBER>308691459: Downloading guest token
    [twitter]<PHONE_NUMBER>308691459: Downloading JSON metadata
    [twitter]<PHONE_NUMBER>308691459: Downloading m3u8 information

    [debug] Sort order given by extractor: res, br, size, proto
    [debug] Formats sorted by: hasvid, ie_pref, res, tbr, vbr, abr, filesize, fs_approx, proto, lang, quality, fps, hdr:12(7), vcodec:vp9.2(10), acodec, asr, vext, aext, hasaud, source, id
    [debug] Default format spec: bestvideo*+bestaudio/best

    [info]<PHONE_NUMBER>308691459: Downloading 1 format(s): http-2176
    [debug] Invoking downloader on "https://video.twimg.com/amplify_video/1453031541362212868/vid/1280x720/vc42DdFjro3TqCaN.mp4?tag=14"

    ERROR: unable to open for writing: [Errno 2] No such file or directory: "UN Development - We can’t ignore #ClimateChange any longer. Unless we end the excuses, we’ll be another species facing extinction.   Join us and @FrankieTheDino, and let's take #ClimateAction before it’s too late -  #DontChooseExtinction #COP26 [1453210331308691459].mp4.part"
    Traceback (most recent call last):
      File "yt_dlp\downloader\http.pyc", line 266, in download
      File "yt_dlp\utils.pyc", line 2094, in sanitize_open

    FileNotFoundError: [Errno 2] No such file or directory: "UN Development - We can’t ignore #ClimateChange any longer. Unless we end the excuses, we’ll be another species facing extinction.   Join us and @FrankieTheDino, and let's take #ClimateAction before it’s too late -  #DontChooseExtinction #COP26 [1453210331308691459].mp4.part"

From docs:

Portable Configuration: yt-dlp.conf in the same directory as the bundled binary.

The config file's name should always be yt-dlp.conf - even if you renamed the exe

The config file's name should always be yt-dlp.conf - even if you renamed the exe

Ah ...  so that's it ! I'd thought that Yt-dlp is like other portable programs, where the config/INI file has to be the same name as the main executable. Perhaps it would be helpful to state the name requirement clearly in the ReadMe.
Using yt-dlp.conf as the filename, I confirm that Yt-dlp now detects the config file, & the Twitter video downloads successfully with a shortened 200-char filename.
Verbose Log (beginning):
G:\zTemp>yt -v https://twitter.com/UNDP/status/1453210331308691459
[debug] Command-line config: ['-v', 'https://twitter.com/UNDP/status/1453210331308691459']
[debug] Portable config file: G:\zTemp\yt-dlp.conf
[debug] Portable config: ['-o', '%(title).200s.%(ext)s', '--no-cache-dir']
[debug] Home config file: yt-dlp.conf
[debug] Home config: ['-o', '%(title).200s.%(ext)s', '--no-cache-dir']
[...]

Thanks !


Execution of I_Type Instructions

Subset of instructions specified in Card: Parse File with MIPS Code
Objectives:
Support for a subset of MIPS Instructions

LW SW not yet complete, addressing needs to be solved before that can be completed

LW SW not yet complete, addressing needs to be solved before that can be completed


[WFLY-19034] Upgrade nimbus-jose-jwt to 9.37.3

https://issues.redhat.com/browse/WFLY-19034

I have re-queued just the failed jobs - looks like something may have been merged and updated the merge branch.

Looks like the 31.x PR made it onto CI so hopefully results there first.

@darranl thanks!


[Bug Report] :border="false" is not working in Multi-level Header Table

Element UI version
2.15.1
OS/Browsers version
MacOS/Chrome 89
Vue version
2.6.12
Reproduction Link
https://codepen.io/boboooooo/pen/poNMwXa
Steps to reproduce
多级表头下配置 :border="false"无效
What is Expected?
多级表头情况下border属性生效可以控制边框是否显示
What is actually happening?
多级表头下配置 :border="false"无效

After looking at this part of the code, I guess it may have been designed that way on purpose. You can do this by rewriting the css style。


Can't import Graph.

I installed keras with pip and I'm having an issue trying to create a Graph model:
In [1]: from keras.models import Graph
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-74d2d1fd7bad> in <module>()
----> 1 from keras.models import Graph

ImportError: cannot import name 'Graph'

The version I have installed is 0.1.1. Do you guys have any idea what is happening?

Install Keras from the Github source. Pip version is outdated.

I did an upgrade with the command
sudo pip install git+git://github.com/fchollet/keras.git --upgrade
I am still having this error :(

On Keras 1.2.0, I can't import the Graph package, can you use another package to work with this new version of Keras?


envoy to GRPC endpoint naming issues

Issue Template
Title: One line description
envoy connect to GRPC endpoint naming issues
Description:
I've found that there are certain endpoints are "taken" while building the envoy proxy to several GRPC servers,
I've been trying to use the endpoint "sessions" in for one of the GPRC service and using route prefix "/sessions" to route, it would give a HTTP 404(service not found) error. but if I should some other endpoint(say "accounts"), I would be able to route correctly with prefix "/accounts"
My question is if are certain endpoints already taken in envoy that we should be aware. Maybe health check related?

Describe the issue. Please be detailed. If a feature request, please
describe the desired behaviour, what scenario it enables and how it
would be used.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

Bug Template
Title: One line description
Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Note: The Envoy_collect tool
gathers a tarball with debug logs, config and the following admin
endpoints: /stats, /clusters and /server_info. Please note if there are
privacy concerns, sanitize the data prior to sharing the tarball/pasting.

Admin and Stats Output:

Include the admin output for the following endpoints: /stats,
/clusters, /routes, /server_info. For more information, refer to the
admin endpoint documentation.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Config:

Include the config used to configure Envoy.

Logs:

Include the access logs and the Envoy logs.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Call Stack:

If the Envoy binary is crashing, a call stack is required.
Please refer to the Bazel Stack trace documentation.

One more piece of info:
if I change the "prefix" to "/" in and keep everything else the same.(so in .proto, it is still  post:"/sessions"), it seem to work properly. Another thing I tried for prefix is "/sess" which doesn't work either and gives HTTP 404 error

ha, I think it makes sense to match gRPC path, thank you very much Lizan!


Add separate GitHub issue templates for feature requests and bugs

At the moment, the Wagtail repository only has a single issue template (https://github.com/wagtail/wagtail/blob/master/.github/ISSUE_TEMPLATE.md), which is well suited for bug reports but not for other types of issues.
I think we should take advantage of GitHub’s support for multiple issue templates (https://help.github.com/en/articles/about-issue-and-pull-request-templates) – for example here is ESLint’s: https://github.com/eslint/eslint/issues/new/choose

Each of these is a file in https://github.com/eslint/eslint/tree/master/.github/ISSUE_TEMPLATE with some frontmatter to define a title and labels to pre-select for the new issue.
I also quite like the wording in create-react-app’s templates: https://github.com/facebook/create-react-app/tree/master/.github/ISSUE_TEMPLATE

I think we should start with 3 templates:
🐞Bug report

Description: Create a report to help us improve
Labels: type: Bug

And the existing template as content (https://github.com/wagtail/wagtail/blob/master/.github/ISSUE_TEMPLATE.md)
🚀Feature request

Description: Suggest an idea for improving Wagtail
Labels: type: Enhancement

We don’t have an existing template for this so I think we could start with the one from create-react-app:
### Is your proposal related to a problem?

<!--
  Provide a clear and concise description of what the problem is.
  For example, "I'm always frustrated when..."
-->

(Write your answer here.)

### Describe the solution you'd like

<!--
  Provide a clear and concise description of what you want to happen.
-->

(Describe your proposed solution here.)

### Describe alternatives you've considered

<!--
  Let us know about other solutions you've tried or researched.
-->

(Write your answer here.)

### Additional context

<!--
  Is there anything else you can add about the proposal?
  You might want to link to related issues here, if you haven't already.
-->

(Write your answer here.)

⛔Question
This isn’t something we want to handle via GitHub issues, so the main idea in having a template for this is to clearly signpost people towards StackOverflow or Slack.

Description: Please use StackOverflow or Slack for support
Labels: none

Template:
Please do not use GitHub for asking questions. Instead, if you have a general question about Wagtail or about building a site with Wagtail we encourage you to post on our Slack workspace instead of this issue tracker: https://github.com/wagtail/wagtail/wiki/Slack. The maintainers and other community members can provide help and answer your questions there.

Please keep in mind that many of Wagtail's core and expert developers prefer to handle support queries through [Stack Overflow](https://stackoverflow.com/questions/tagged/wagtail), since the non-realtime format encourages more structured and fully-formed questions. Asking questions on Stack Overflow requires more up-front effort (see Stack Overflow's advice on how to ask a good question), but you may well find you get a better response as a result.

If you've discovered a bug or would like to propose a change please use one of the other issue templates.

Thanks!

@thibaudcolas I am interested in taking a stab at the issue

Hey @souravsingh, that’s great to hear! Please let me know if you need some support with this.

New contributor here. Can I have a crack at this issue?

Hey @pmk21, sure! I haven’t heard back from @souravsingh so not sure whether they do intend to take this on.

Nice one 👍 💃

Very cool, thanks :+1:


[Ember-Migration] Create a cookie for checking if a user is logged in

What to do?

Create a cookie named as loggedIn and set it's value to true when user is logged in.
And if the user Signs out, then remove the cookie.

The following enchancement is not needed anymore for migration


Use the SimpleLinkService when running "annotations" reference tests

Rather than (basically) duplicating the SimpleLinkService in test/driver.js, with potential test failuires if you forget to update the test mock, it seems much nicer to just re-use the viewer component.
Note that SimpleLinkService is already bundled into the build/components/pdf_viewer.js file. Hence we only need to expose it similar to the other viewer components in that file, and make sure that the gulp components command runs as part of the test-setup.

/botio test

While this commit in itself looks good, I'm worried about the increase in time on the Windows bot. I saw that while it takes only a few seconds to run Webpack on the Linux bot it takes up to 10 minutes on the Windows bot.  I think we should figure out what the problem is on the Windows bot first. I had hoped updating Webpack to the latest version would help, but unfortunately it did not change anything.
@yurydelendik Would you be able to help out here? Do you know what may cause the Windows bot to be so slow with Webpack?

I'm not convinced that the added gulp components step is the culprit here, since according to the logs: [13:33:02] Finished 'components' after 7.06 s.
Looking further below, you can see [13:39:57] Finished 'generic' after 6.92 min, which is obviously slower than one would like but still on par with other (older) test runs on Windows.
Furthermore, it's not actually Webpack that's slow on Windows. Instead, it's Babel which takes a long time to run. Locally on Windows, I'm running all tests with PDFJS_NEXT=true gulp {test name here}, which disables the transpilation step and is thus very quick. Perhaps we want to skip Babel when running tests on the bots as well?

Perhaps we want to skip Babel when running tests on the bots as well?

I agree with that. The bots run the most recent Firefox and Chrome versions, so there should be no need for the transpilation step. Could you add a commit to disable that so we can do a new test run?

Could you add a commit to disable that so we can do a new test run?

The changes would need to be done at https://github.com/mozilla/botio-files-pdfjs, and then pushed to the bots manually. I'll see about submitting a PR for that tomorrow!
In the meantime, I'll trigger a new round of testing to check that the Windows bot wasn't just temporarily slow when the tests ran earlier today.

/botio test

In the meantime, I'll trigger a new round of testing to check that the Windows bot wasn't just temporarily slow when the tests ran earlier today.

It seems to have been just a temporary problem, since the runtime of the Windows bot is now back to its usual value.

Thank you for improving this!
Good to know that the runtime is not a new issue. The other patch will hopefully improve the runtime.


"fixed" the sudoers line in the Dockerfile.

i had to made this change to get provisioning working with ansible in the docker container. else it couldnt use "become_user" in the ansible playbook file. i dont know if this has some side-effects but after i changed this it worked out. so i thought i make a pull request and see if you can use it or not :) thanks for your great repo. it was alot help for getting started with vagrant + docker.

thanks!


npm run build production报错

求指点问题出在哪里:)
><EMAIL_ADDRESS>build D:\rep\crm
> roadhog build "production"

Creating an optimized production build...
Failed to compile.

Template execution failed: TypeError: Cannot read property 'Symbol(Symbol.iterat
or)' of null

  TypeError: Cannot read property 'Symbol(Symbol.iterator)' of null

  - entry.ejs:75
    D:/rep/crm/src/entry.ejs:75:40

  - entry.ejs:82 module.exports
    D:/rep/crm/src/entry.ejs:82:3

  - index.js:264
    [crm]/[html-webpack-plugin]/index.js:264:16

  - util.js:16 tryCatcher
    [crm]/[bluebird]/js/release/util.js:16:23

  - promise.js:512 Promise._settlePromiseFromHandler
    [crm]/[bluebird]/js/release/promise.js:512:31

  - promise.js:569 Promise._settlePromise
    [crm]/[bluebird]/js/release/promise.js:569:18

  - promise.js:606 Promise._settlePromiseCtx
    [crm]/[bluebird]/js/release/promise.js:606:10

  - async.js:138 Async._drainQueue
    [crm]/[bluebird]/js/release/async.js:138:12

  - async.js:143 Async._drainQueues
    [crm]/[bluebird]/js/release/async.js:143:10

  - async.js:17 Immediate.Async.drainQueues
    [crm]/[bluebird]/js/release/async.js:17:14

npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\ASUS\\AppData\\R
oaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "run" "build" "production"
npm ERR! node v7.7.1
npm ERR! npm  v4.3.0
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `roadhog build "production"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'roadhog build "production"
'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the antd-admin package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     roadhog build "production"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs antd-admin
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls antd-admin
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\ASUS\AppData\Roaming\npm-cache\_logs\2017-09-17T15_56_09_2
37Z-debug.log

你拉下最新代码


Fix crash when open currency selector page

Details

The app crashes when we visit the currency selector page. This is a regression from https://github.com/Expensify/App/pull/27850.
Fixed Issues

$ https://github.com/Expensify/App/issues/27396
$ https://github.com/Expensify/App/issues/28317
PROPOSAL:
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open the request money page
Switch to Manual tab
Press the currency button
Verify you are navigated to currency selector page without crash

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/50919443/13ffde19-89a0-4c04-b0fb-1d3acca9846d

Mobile Web - Chrome

https://github.com/Expensify/App/assets/50919443/9dfa7cd4-94e0-4ef4-9f97-a4b7ed649b29

Mobile Web - Safari

https://github.com/Expensify/App/assets/50919443/3d9913b9-6e94-4c25-bda2-fb9656de7c47

Desktop

https://github.com/Expensify/App/assets/50919443/56723aa9-523f-46e3-a5e0-4a4bdc2af504

iOS

https://github.com/Expensify/App/assets/50919443/1c8e2420-69f4-4046-a3ce-601bae068924

Android

https://github.com/Expensify/App/assets/50919443/fd607726-a0f3-44c8-a483-9b9784b0e3be

@bernhardoj I am not available to review this PR. Can you assign the original C+ or another C+ here for that matter.

I can take this as C+ as I am the one who found crash.

Doing expedited review as it's breaking important feature of the app

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/108292595/90e30194-9199-43ab-9440-522f3fba9c54

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@bernhardoj Just to make sure that this regression didn't came from your PR.
0 is always filled in currency amount input when first open this page
https://github.com/Expensify/App/assets/108292595/809e03d1-f23f-467a-aef2-abfaa3750193

@bernhardoj looks like jest tests are failing. Could you please take a look

@bernhardoj looks like jest tests are failing. Could you please take a look

It's fixed in #28307. Please pull main.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.75-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.76-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Get mcmc sampling to work

Unobserved variables accessible
Sampling works

TODO:
Write Tests

@ferrine
What do you suggest model.target_log_prob_fn() give? The logp function of only the result of model.f or all the intermediate RVs too?
If we give it only the final logp function then we wont be able to sample traces of intermediate RVs.
One more problem is tfp.mcmc.sample_chain() might work for only single RV(in current implementation,  final) logp function

@ferrine Could I merge this PR?

@ferrine I have changed it to a class based interceptor

And test point is better get via model.test_point()

@ferrine Currently model.test_point() is how you get the test point.
I am not sure I understand what you are saying.


analytics: Add summary statistics section to page.

Adds a summary statistics section to the organization /stats/ page. and adds the first three statistics using the data already there from the charts. Also, reorders the charts on the page and changes HTML/CSS to use Flexbox.

Number of users
Total number of messages
Number of messages in the last 30 days

Part of #20162. Relevant CZO conversation.

Notes:

The first commit is the reordering of the charts and switching to Flexbox.
The second commit adds the summary statistics section to the HTML and the active users stat. This value matches the last updated count to the related chart.
The 30 days statistic matches the Messages sent over time chart when set to daily and last 30 days, which means the current day is likely a partial sum since this count is updated every hour.

Screenshots and screen captures:

All charts

Summary section

Screencast of resizing the window
Screencast from 28-09-22 17:32:10.webm

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

The implementation looks good; posted a comment on structure. Looking at the screenshots, I'm thinking I might prefer the following formatting:

1200 total users
123 users active in last 30 days
120321 total messages sent
12312 messages sent in last 30 days

rather than the field: value structure, but I'm not sure. One downside is that'd be worse for i18n. Another option would be to do a simple table, where we could do "all time", "last 30 days" as columns, and "messages sent" and "users" -- though explaining the 'active' aspect of the users bit active definition may get complicated there.

I don't know how to fully test on dev (see below), but the screenshots, etc. in the PR description look great to me!

While we're here, can we do something less silly when the data for the charts is missing? Ideally explicitly displaying text that says "Data not available.", but at the very least not showing broken axis labels?
This can be a separate PR, of course.

I'm thinking I might prefer the following formatting:
* 1200 total users
* 123 users active in last 30 days
* 120321 total messages sent
* 12312 messages sent in last 30 days

Here's a screenshot with that formatting, though I agree that format due to pluralization would be more difficult:

Alternate list format

Another option would be to do a simple table, where we could do "all time", "last 30 days" as columns, and "messages sent" and "users" -- though explaining the 'active' aspect of the users bit active definition may get complicated there.

We don't have active users for the last 30 days, but we do for the last 15 days. So we could do a column with "last 15 days" and adjust the messages sent statistic. If we want the users, then we'd have to create another count statistic for that.
Also, would we want to make that chart in HTML or use Plotly.js? Would we want the simple list for now and then have the goal of a chart when/if we switch to another graphing library since Plotly.js isn't something we want to continue to work with in the long run?

Updates:

Renamed the user statistic function (per this comment) and added the active in the last 15 days user stat.
I did not change the list format, so it's still field: value structure (see this comment with screenshots of potential changes).

Merged, thanks @laurynmm! I think this is a nice checkpoint.
I'm not sure which of those alternative presentations might be best, and they're all more work than the current version, so I figure we can discuss that and fix forward, in parallel with running this on chat.zulip.org, where we'll be able to see how real data ends up being presented.
One other thing on my mind in this is the word "Active" -- there's two definitions one might imagine in the Zulip context -- non-deactivated accounts, and active in the sense of having actually used the product in a UI (which is what the 15 day actives number captures; I suspect email-only use doesn't get counted).

Yeah, I'm not sure about the format ideas... I think with the current number of bullets, the format in this PR seems fine, but we might end up wanting to structure it more once more fields get added.


loosen jinja2 dependency for airflow 2.2.4

The latest versions of airflow depend on jinja2==3.0.3.
Soda-sql core right now depends on jinja2 < 3.0.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @vijaykiran ,
please trigger the workflow for this PR.


[NEW] Add SSTIC 2024

Name: SSTIC
Website: https://www.sstic.org
Date(s): 5-7 June 2024
Location: Rennes, France
Twitter/Mastodon Handle:  @sstic
Free: N

Merci ! ✅


Enable Glacier support

Let's consider this superseded by https://github.com/dandi/dandi-archive/issues/524


update for 4.9.0

Upgrade release to 4.9.0;
update library for building from source.
Include PR #28 and #29.
fixes some confusion about nfs,  to help #27
CentOS 6 reference updated from 6.5 to 6.8

This LGTM.


Type nodes and assignability analysis

Adds type nodes to the feature graph and edges between type nodes indicating whether the source type is assignable to the destination type.
Currently type nodes are added for variable statements, assignment statements, arguments of method invocations, and binary expressions.  This might be something we want to expand.

LGTM


[4.1.0][Feature] withLinks() helper for columns

After the Fluent syntax is finished and merged for Columns, we should probably create a helper for automatically adding column links. Instead of having to define the path yourself, we should be able to determine that if there's a CrudController for that entity. Then you could do:
// you should be able to do
CRUD::column('categories')->type('relationship')->withLinks();
// instead of
CRUD::column('categories')->type('relationship')->wrapper([
    'href' => function ($crud, $column, $entry, $related_key) {
        return backpack_url('category/'.$related_key.'/show');
    },
]);

This is one of the benefits of having the fluent syntax - that you can do stuff like that.

This just seems beautifull. Want me to have a look at the withLinks ?

HA! I knew I'd turn you around 😄
Yes please, not right now, better next week. I'm still polishing the fluent syntax. It's 95% complete, but I might just rewrite the whole thing so it's exactly the same for Fields, Columns, Filters, Buttons, Widgets. Right now the syntax is the same, but the implementations are pretty different - I played around to see which one works best.
If you want to play around with this, branch out from the fluent-syntax branch, and take a look at this example for a convenience method for fields.


Guarantee that c# auth callbacks are async to core

Seeing the added tests here segfault every time before the change to NativeMetadataCredentialsPlugin.cs here - it looks like an existing bug in c# with composite credentials.
(in the case where the async auth interceptor callback is inlineable, we end up hitting a use-after-free in the composite credentials core code due to notifying completion of auth callback synchronously. use in https://github.com/grpc/grpc/blob/master/src/core/lib/security/credentials/composite/composite_credentials.c#L103 and earlier free in https://github.com/grpc/grpc/blob/master/src/core/lib/security/credentials/composite/composite_credentials.c#L72).

updated, reverted loss of ConfigureAwait(false) on the interceptor


jupyter support

Work on supporting Jupyter and IPython 4.
The transition from IPython 3 to 4 was marked by the splitting of the monolithic IPython packages into a number of smaller packages (e.g. nbformat and nbconvert are now standalone).
There were a few import changes (which produced a warning if you used the old import path) and also some changes to the internals of nbconvert (the API of which I wasn't using properly). These have been addressed and this branch is now passing all tests.
However, this was done at the expense of IPython 3 compatibility (for ease of hacking). This shouldn't be hard to re-implement - I think it just needs import shims putting in.
TODO:

[x] put in import shims to permit IPython 3
[x] does nbconvert usage change from 3 to 4?

I think this is ready to go. Appears to be working just fine with ipython 3 & 4 on my machine.
Only problem is the requirements in setup.py, which aren't compatible with IPython 3. At this point I think it isn't unreasonable to expect an upgrade to IPython 4 / Jupyter.

closes #26

At this point I think it isn't unreasonable to expect an upgrade to IPython 4 / Jupyter.

I support this. If ipython < 4.0, the older version of notedown are available.

Current master should be all jupyter now. I've not made a release yet because I've been trying out upgrade edge cases. Will make one soon though. Is master working fine for you?

Seems to be working. This is great ! Thanks.
This will let me build the notebook tutorials for the rpy2 doc (.md -> .ipynb -> .rst =[sphinx]=> .html) with jupyter-4.0.