Targeted data control component2

This creates the TargetedDataControl as described in the mockups. It contains the Condition dropdown and the encounter/workflow selector which is now also a dropdown. Buttons have been added to switch between narrative and tabular data display - but they currently just update state and do not change how the data is displayed.
SummaryPanel has been renamed to TargetedDataPanel and DataSummaryPanel has been renamed to TargetedDataSubpanel.
The SVGs are displayed very small in IE. We may want to discuss the layout and whether these dropdowns should be in the left panel or should be moved back to the top, it's a little jarring to have one panel affect the whole app. A test has been added for the new buttons.
Pull requests into Flux require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (N/A) and :white_check_mark:.
Submitter:
Running the Application

[X] Manually tested in Chrome
[X] Manually tested in IE  - tiny SVGs

Documentation

[X] This pull request describes why these changes were made
[X] Recognizes any potential shortcomings/bugs in the description
[N/A] Cheat sheet is updated
[N/A] Demo script is updated
[N/A] Documentation on Wiki has been updated
[N/A] Additional technical components and libraries are documented and added to wiki as needed

NoteParser

[N/A] Note parser has been updated if structured phrases change

Code Quality

[X] 4-space indents - convert any tabs to spaces
[X] Use public class field syntax for binding functions - ex. handleChange = () => { ... };
[X] Code is commented

Tests

[ ] Existing tests passed
[N/A] Added UI tests for slim mode
[X] Added UI tests for full mode
[N/A] Added backend tests for fluxNotes code
[N/A] Added note parser examples to test new functionality

Reviewer 1: Name

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2: Name

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

@mtorchio it looks like travis is saying CI tests failed and this branch also has conflicts and should be rebased. Is there an issue with rebasing?

Julia and I are working through the Travis error, the new test is failing. I don't see an issue with rebasing.

[DP1] We need to add PropTypes to the TargetedDataControl.

Good catch @Dtphelan1 ! Still having nightmares about adding them to everything?

I worked with Dylan to get some of the outstanding tasks on this branch. It has been rebased, the PropTypes have been added, the new test was fixed and now passes, and the icons were resized. Let me know if anyone else sees anything to change.

It looks like all of the issues have been addressed. I tested this manually in chrome and IE and it looks good. All the tests pass


cost_map_ros is failing to build due to moved header

It looks like https://github.com/ethz-asl/grid_map/pull/96 moved the location of the header.
I've ticketed it for a backwards compatibility header: https://github.com/ethz-asl/grid_map/issues/111 but until that's available or the include is switched this is broken.
http://build.ros.org/view/Ibin_uT64/job/Ibin_uT64__cost_map_ros__ubuntu_trusty_amd64__binary/8/console
00:07:47.321 /tmp/binarydeb/ros-indigo-cost-map-ros-0.3.1/src/lib/converter.cpp:23:47: fatal error: grid_map_ros/Costmap2DConverter.hpp: No such file or directory
00:07:47.321  #include <grid_map_ros/Costmap2DConverter.hpp>
00:07:47.321

That release was reverted.


LVL Fixups to finalize ICD removal from VulkanTools

Some leftover/stale references in the repo,

Pushed to Master.


LE Coded PHY scanning on nRF9160DK fails

Describe the bug
If LE Coded PHY scanning is executed on nrf9160dk_nrf9160 it exits with Scanning failed to start (err -5).
To Reproduce
Steps to reproduce the behavior:
Flash nrf9160dk_nrf52840
In order to prepare nRF52840 on the nRF9160DK board, the hci_uart sample with the following prj.conf has been used:
CONFIG_CONSOLE=n
CONFIG_STDOUT_CONSOLE=n
CONFIG_UART_CONSOLE=n
CONFIG_SERIAL=y
CONFIG_UART_INTERRUPT_DRIVEN=y
CONFIG_BT=y
CONFIG_BT_HCI_RAW=y
CONFIG_BT_HCI_RAW_H4=y
CONFIG_BT_HCI_RAW_H4_ENABLE=y

CONFIG_BT_CTLR_PHY_CODED=y
CONFIG_BT_LL_NRFXLIB=y
CONFIG_BT_LLL_VENDOR_NORDIC=y
CONFIG_BT_LL_SW_SPLIT=y

Flash nrf9160dk_nrf9160
The central_hr_coded sample is used, with the following modifications:
$ mkdir boards
$ cat > boards/nrf9160dk_nrf9160ns.conf << EOF
CONFIG_BT_H4=y
CONFIG_BT_WAIT_NOP=y
CONFIG_UART_INTERRUPT_DRIVEN=y

# Set UARTE2 as non-secure, used for HCI
CONFIG_SPM_NRF_UARTE2_NS=y

CONFIG_BT_CTLR_PHY_CODED=n
CONFIG_BT_LL_NRFXLIB=n

CONFIG_BSD_LIBRARY_TRACE_ENABLED=n
EOF
$ cat > boards/nrf9160dk_nrf9160ns.overlay << EOF
CONFIG_BT_H4=y
CONFIG_BT_WAIT_NOP=y
CONFIG_UART_INTERRUPT_DRIVEN=y

# Set UARTE2 as non-secure, used for HCI
CONFIG_SPM_NRF_UARTE2_NS=y

CONFIG_BT_CTLR_PHY_CODED=n
CONFIG_BT_LL_NRFXLIB=n

CONFIG_BSD_LIBRARY_TRACE_ENABLED=n

Expected behavior
Sample scans and connects to a board running peripheral_hr_coded. This works if the central_hr_coded is flashed to nrf9160dk_nrf52840.
Logs and console output
*** Booting Zephyr OS build v2.3.0-rc1-ncs1-1437-g9c6523e0349e  ***
Bluetooth initialized
Scanning failed to start (err -5)
[00:00:00.027,008] <wrn> bt_hci_core: opcode 0x0000 pool id 5 pool 0x2002049c != &hci_cmd_pool 0x20020474
[00:00:00.049,499] <inf> bt_hci_core: Identity: d4:a3:d4:62:c8:b0 (random)
[00:00:00.049,530] <inf> bt_hci_core: HCI: version 5.2 (0x0b) revision 0x0000, manufacturer 0x05f1
[00:00:00.049,530] <inf> bt_hci_core: LMP: version 5.2 (0x0b) subver 0xffff
[00:00:00.052,734] <wrn> bt_hci_core: opcode 0x2041 status 0x01

Environment (please complete the following information):

OS: Ubuntu 18.04
sdk-nrf v1.3.0 (https://github.com/nrfconnect/sdk-nrf/pull/2617)
Zephyr SDK: 0.11.2

Additional context
Another strange thing that I experienced is that the CONFIG_BT_LL* configs in the prf.conf file for the hci_uart sample has to be in exact this order. Otherwise it will generate warnings that some configs aren't selected.
The communication between the nRF52840 and nRF9160 has been tested with the central_hr sample and another board running the peripheral_hr sample. This works well.

FYI @joerchan

I think this is likely because coded phy scanning is not implemented at the LL level right @joerchan and @andrzej-kaczmarek?

I think this is likely because coded phy scanning is not implemented at the LL level right @joerchan and @andrzej-kaczmarek?

@carlescufi No this is with CONFIG_BT_LL_NRFXLIB=y, so it should be supported. He is saying that it works with board nrf52840dk_nrf52840, but not on nRF9160DK and doing the same with a HCI UART to the nrf52840 on the DK.

@ChristianHirsch You have mixed up a few configs, and hci_uart has been compiled with the wrong controller.
CONFIG_BT_LL_SW_SPLIT and CONFIG_BT_LL_NRFXLIB are choices, you can only select one of them, and in this case you want  CONFIG_BT_LL_NRFXLIB=y.`
So remove these from hci_uart/prj.conf
CONFIG_BT_LLL_VENDOR_NORDIC=y
CONFIG_BT_LL_SW_SPLIT=y

Also you can remove these from the nrf9160 conf files:
CONFIG_BT_CTLR_PHY_CODED=n
CONFIG_BT_LL_NRFXLIB=n

Not needed when you have CONFIG_BT_H4=y

@joerchan well CONFIG_BT_LL_NRFXLIB=y is what I had in the first place, but I got the following warning when compiling/configuring:
warning: BT_CTLR_DTM_HCI (defined at subsys/bluetooth/controller/Kconfig:492) was assigned the value
'y' but got the value 'n'. Check these unsatisfied dependencies: BT_CTLR_DTM_HCI_SUPPORT (=n). See
http://docs.zephyrproject.org/latest/reference/kconfig/CONFIG_BT_CTLR_DTM_HCI.html and/or look up
BT_CTLR_DTM_HCI in the menuconfig/guiconfig interface. The Application Development Primer, Setting
Configuration Values, and Kconfig - Tips and Best Practices sections of the manual might be helpful
too.

And in order to get rid of this warning, I had to add CONFIG_BT_LL_SW_SPLIT=y and CONFIG_BT_LLL_VENDOR_NORDIC=y. Anyway I removed it and flashed the nRF52840 with it. I also changed the nRF9160 config and flashed it and now, it tells me that scanning successfully started, but it is not receiving any advertising packets:
*** Booting Zephyr OS build v2.3.0-rc1-ncs1-1437-g9c6523e0349e  ***
Bluetooth initialized
Scanning successfully started
[00:00:00.643,188] <wrn> bt_hci_core: opcode 0x0000 pool id 5 pool 0x2002049c != &hci_cmd_pool 0x20020474
[00:00:00.659,881] <inf> bt_hci_core: Identity: db:ea:20:3f:c0:4b (random)
[00:00:00.659,881] <inf> bt_hci_core: HCI: version 5.2 (0x0b) revision 0x10be, manufacturer 0x0059
[00:00:00.659,881] <inf> bt_hci_core: LMP: version 5.2 (0x0b) subver 0x10be
[00:00:01.291,625] <wrn> bt_hci_core: opcode 0x0000 pool id 5 pool 0x2002049c != &hci_cmd_pool 0x20020474

BT_CTLR_DTM_HCI is enabled in the hci_uart/boards/.conf file. But the controller does not support it, so it gets deselected because of that. Which is fine, you don't need DTM (direct test mode).

I also changed the nRF9160 config and flashed it and now, it tells me that scanning successfully started, but it is not receiving any advertising packets:

Well did you flash the peripheral_hr_coded as well? You are scanning on coded only after all.

Well did you flash the peripheral_hr_coded as well? You are scanning on coded only after all.

Of course, and I also checked that it is working by flashing the central_hr_coded on the nRF52840 and everything works fine. This is the output of the nRF52840 running it:
Scanning successfully started
[DEVICE]: 33:bc:66:12:b8:a1 (random), AD type 5, AD props 17, AD data len 11, RSSI -37, Primary PHY 4, Secondary PHY 4
[AD]: 1 data_len 1
[AD]: 3 data_len 6
Connection pending
Connected: 33:bc:66:12:b8:a1 (random), tx_phy 4, rx_phy 4
[ATTRIBUTE] handle 20
[ATTRIBUTE] handle 21
[ATTRIBUTE] handle 23
[SUBSCRIBED]
[NOTIFICATION] data 0x20006a67 length 2
[NOTIFICATION] data 0x20006a67 length 2

Ok, just checking :)
One thing I noticed is that the hci_uart  buffer lengths needs to be increased when enabling EXT_ADV.
Can you try adding these to the hci_uart/prj.conf?
BT_RX_BUF_LEN=258
BT_DISCARDABLE_BUF_SIZE=257

These are the default values when CONFIG_BT_EXT_ADV=y, please confirm that they are set correctly in the build/zephyr/.config file for the central_hr_coded and peripheral_hr_coded.

@ChristianHirsch I had a look at some of my older branches where I was using hci_uart and extended advertising. And there I had these configuration options in addition:
CONFIG_MAIN_STACK_SIZE=1024
CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=1024

You should give those a try as well.

Yes! Finally it works, thank you so much for your help :)
Increasing CONFIG_MAIN_STACK_SIZE and CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE in the hci_uart sample did the trick. It is not necessary to increase BT_RX_BUF_LEN and BT_DISCARDABLE_BUF_SIZE though, but I did it anyway.
Wouldn't it make sense to permanently increase the stack sizes in the hci_uart sample, at least for the nrf9160dk_nrf52840 in the boards/nrf9160dk_nrf52840.conf file? I could also imagine that increasing the stack size for the hci_usb samples may be useful as well if somebody want to use LE Coded PHY on a PC with a dongle..

Wouldn't it make sense to permanently increase the stack sizes in the hci_uart sample, at least for the nrf9160dk_nrf52840 in the boards/nrf9160dk_nrf52840.conf file?

Actually. I had already done this. But I missed the nrf9160dk_nrf52840 board. So I will have to update that one as well.
It is only the CONFIG_MAIN_STACK_SIZE=1024 that is needed `, the system worqueue stack size is large enough at 512.
thread_analyzer:  main                : unused 208 usage 816 / 1024 (79 %)
thread_analyzer:  sysworkq            : unused 376 usage 136 / 512 (26 %)

It is not necessary to increase BT_RX_BUF_LEN and BT_DISCARDABLE_BUF_SIZE though, but I did it anyway.

No, it is. hci_uart crashed for me using the shell when trying to set advertising data. Advertising data with extended advertising can be up to 251 bytes in a single HCI command.

Does this apply to hci_usb example as well?

@TwistedSim I guess so, but I'm not an expert. @joerchan does it apply to the hci_usb sample as well?

@TwistedSim Increasing the buffer sizes should be done if you want to use Extended Advertising in the hci_usb sample.
BT_RX_BUF_LEN=258
BT_DISCARDABLE_BUF_SIZE=257

Changing the MAIN_STACK size is not needed it seems, the main function of that sample is simple, and the sample prj.conf does not change the default, which means it should be 1024 by default.


Config not existing

Hey I’m really excited for this update, but when I open the file I see no config

I have updated the patch. Let's check it


llvm install on linux should test for presence of C headers, and prompt user to install

This should be sufficient:
const c = undent`
    #include <stdio.h>
    int main() {
      printf("Hello World!\n");
      return 0;
    }
`
Deno.write("test.c", c)
try {
  run({ cmd: ["clang", "-o", "out", "test.c" }]
} catch {
  console.error("You're missing your C headers. Try: `sudo apt-get update; sudo apt-get -y install libc-9-dev libgcc-dev` (on ubuntu)")
} finally {
  Deno.unlink("test.c")
  if "out".exists { Deno.unlink("out") }
}

add to hacks.ts for now. though this’ll slow down resolution for llvm…

hopefully only needs to be checked on install, not on resolve.

We think that the only way to do this is providing glibc or equivalents


Inspection for Lombok annotations incorrectly highlights 'var'

Short description
Please refer to the YouTrack issue for the description.
Inspection for Lombok annotations makes var red.
Error highlighted: var works only on local variables on for/foreach loops
However project compiles without errors.
Expected behavior
No errors.
Version information

IDEA Version:
IntelliJ IDEA 2018.3 EAP (Ultimate Edition)
Build #IU-183.3050, built on September 27, 2018
IntelliJ IDEA EAP User
Expiration date: October 27, 2018
JRE: 1.8.0_152-release-1343-b2 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13.6
JDK Version:
JDK 11
OS Type & Version:
macOS High Sierra Ver. 10.13.6
Lombok Plugin Version:
v0.19-LATEST-EAP-SNAPSHOT

Steps to reproduce

Add the following method to the project class:
public static void main(String[] args) {  	System.out.println(List.of("AAA", "BBB", "CCC")  			.stream()  			.map((var s) -> s.toLowerCase())  			.collect(Collectors.toList()));  }

Same here, when declaring a functional interface.

@OljaKli @MichelSchudel
Why do you think that it is a plugin bug?
I think Lombok annotation processor doesn't support using var with lambda parameters.

You can use val as the type of a local variable declaration

from val description
Lambda parameters are more similar to method parameters :)

Similar @var issue #472

@Lekanich Thank you for your PR. I'll look on it!


newline needed in settings

Likely a lint regression brought by pull#128. @buweixin please make sure pipeline passes before mege.

ok, will pay attention to it


Events › Coimbra › Convento de São Francisco

Events are already reported in detail by Coimbra City Council / CoimbrAgenda
Direct JSON-LD integration blocked by syntax errors (see EventsCoimbraSaoFrancisco.md)
Direct RSS integration not worth, as it provides less details than Coimbra City Council / CoimbrAgenda

@ec2u/mmt


Ensure Docusaurus v3 (MDX v3) compatibility

Is your feature request related to a problem?
I would like to easily upgrade my Docusaurus site to v3 in the future (https://docusaurus.io/blog/preparing-your-site-for-docusaurus-v3) and I'm uncertain whether this plugin supports Docusaurus v3 / MDX v3
Describe the solution you'd like
Confirmation that the plugin works with the updated framework version
Describe alternatives you've considered

Additional context
Just trying to open a preemptive issue so testing can be started before full release

Since we are still in v2 beta yet, shall we consider making v2 release https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/439 compatible with docusaurus 3?

Since we are still in v2 beta yet, shall we consider making v2 release #439 compatible with docusaurus 3?

Yes please. Our team is testing docusaurus-openapi-docs v2 beta with Docusaurus v2.4.3 and at least the mdx files were considered valid when checking against MDX v2 (npx docusaurus-mdx-checker). So I assume most breaking changes should be already figured out?

Since we are still in v2 beta yet, shall we consider making v2 release #439 compatible with docusaurus 3?

Yes.

Is this already available? I need to use a plugin that requires docusaurus v3.

@jasikpark Well, if you use OpenAPI >= 3.1.0 , you can use my plugin as starting this version, OpenAPI is fully compatible with JSON Schema

my plugin

Thank you for the suggestion, but I'm looking to keep the same plugin for the UI and design choices we've made, and because this OpenAPI plugin has purpose built components for showing api definitions. I'm more interested in teaching my users about how to use the API than being specific about the shape of the spec, it's just a nice way to format the documentation.

at least the mdx files were considered valid when checking against MDX v2 (npx docusaurus-mdx-checker). So I assume most breaking changes should be already figured out?

For me, when running against my definition I get these errors:
Error while compiling file docs/api/role-get.api.mdx (Line=37 Column=1)
Details: Expected a closing tag for `<div>` (37:440-37:445) before the end of `paragraph`
---
Error while compiling file docs/api/roles-list.api.mdx (Line=37 Column=1)
Details: Expected a closing tag for `<div>` (37:1035-37:1040) before the end of `paragraph`
---

Query Parameters

<ParamsItem className={"paramsItem"} param={{"name":"includeCounts","in":"query","description":"If true, return count of total records and current page start and count in metadata","required":false,"schema":{"type":"boolean","default":false}}}></ParamsItem><ParamsItem className={"paramsItem"} param={{"name":"cursor","in":"query","description":"Cursor value at which to start the results, provided in `nextCursor` or `prevCursor` of a prior request","example":"bmV4dA.eyJsb2dzLmNyZQ5iIiwiX3ZhbHVlIjo9In19","schema":{"type":"string"}}}></ParamsItem><ParamsItem className={"paramsItem"} param={{"name":"pageSize","in":"query","description":"Number of records to return in each page","required":false,"schema":{"type":"integer","default":25,"maximum":500}}}></ParamsItem>

<ApiTabs><TabItem label={"200"} value={"200"}>

Not sure exactly what the issue is..

ah, the issue is that markdown surrounded by JSX always generates a paragraph now unless it is inline I believe.
https://docusaurus.io/blog/preparing-your-site-for-docusaurus-v3#unintended-extra-paragraphs

at least the mdx files were considered valid when checking against MDX v2 (npx docusaurus-mdx-checker). So I assume most breaking changes should be already figured out?

For me, when running against my definition I get these errors:
Error while compiling file docs/api/role-get.api.mdx (Line=37 Column=1)
Details: Expected a closing tag for `<div>` (37:440-37:445) before the end of `paragraph`
---
Error while compiling file docs/api/roles-list.api.mdx (Line=37 Column=1)
Details: Expected a closing tag for `<div>` (37:1035-37:1040) before the end of `paragraph`
---

Query Parameters

<ParamsItem className={"paramsItem"} param={{"name":"includeCounts","in":"query","description":"If true, return count of total records and current page start and count in metadata","required":false,"schema":{"type":"boolean","default":false}}}></ParamsItem><ParamsItem className={"paramsItem"} param={{"name":"cursor","in":"query","description":"Cursor value at which to start the results, provided in `nextCursor` or `prevCursor` of a prior request","example":"bmV4dA.eyJsb2dzLmNyZQ5iIiwiX3ZhbHVlIjo9In19","schema":{"type":"string"}}}></ParamsItem><ParamsItem className={"paramsItem"} param={{"name":"pageSize","in":"query","description":"Number of records to return in each page","required":false,"schema":{"type":"integer","default":25,"maximum":500}}}></ParamsItem>

<ApiTabs><TabItem label={"200"} value={"200"}>

Not sure exactly what the issue is..
https://mdxjs.com/playground/:

When I ran into that it was due to the lack of new line chars and the presence of non-escaped characters. I did replacements following Docusaurus migration guide:

https://docusaurus.io/docs/migration/v3#bad-usage-of--1
https://mdxjs.com/migrating/v2/#update-mdx-files

I managed to fix the MDX output with this simple patch, it's very rudimentary but pnpm dlx docusaurus-mdx-checker passed on the ~360 MDX files this plugin generates for our API.
diff --git a/lib/markdown/utils.js b/lib/markdown/utils.js
index 09d5baef75e5f495c19610021771094463e69ce5..19519432acbe3918dc2db90246bf184fee53f2d5 100644
--- a/lib/markdown/utils.js
+++ b/lib/markdown/utils.js
@@ -13,7 +13,7 @@ function create(tag, props) {
     for (const [key, value] of Object.entries(rest)) {
         propString += ` ${key}={${JSON.stringify(value)}}`;
     }
-    return `<${tag}${propString}>${render(children)}</${tag}>`;
+    return `\n<${tag}${propString}>${render(children)}</${tag}>\n`;
 }
 exports.create = create;
 function guard(value, cb) {

However, the UI still crashes with Hook useDoc is called outside the <DocProvider>. when I add docItemComponent: "@theme/ApiItem" to my config. I believe it's due to the breaking changes related to the removal of docLayoutComponent option and the docs theme refactoring https://docusaurus.io/docs/migration/v3#docs-theme-refactoring.

Thanks @jcwillox, have you seen the changes proposed in https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/648?

Thanks @jcwillox, have you seen the changes proposed in https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/648?

Oh look at that, that's very similar to what I did but an even nicer output 👍, should fix the same issue with mdx, I believe the main issue was multiple opening tags on one line.

Anyone have a chance to try 3.0.0-beta.1?

I left a comment here https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/660#issuecomment-1817499261, but tldr, everything looks to be working well, except some syntax highlighing

3.0.0-beta.1 works for me with Docusaurus 3.0.1, except for the highlighting as @jcwillox noted. For my documentation I also noticed that I had to add json and bash to additionalLanguages to fix the highlighting for these, while this was not needed for previous Docusaurus versions.
With 3.0.0 I get Hook is called outside the <DocProvider>. However, I had this issue with previous versions as well and am not quite sure if it is completely related.
Great work on the quick release!

After some more testing I ran into an issue with path parameters.
Looking at the Swagger specifications for describing parameters, each parameter is denoted each denoted with curly braces. In MDX3 these paramters will be considered to be expressions (see the Docusaurus migration guide for this common issue as well).
Thus, for endpoints with path parameters (in this specific case {type}), you will get the following error:

After some more testing I ran into an issue with path parameters.

I believe this issue was addressed in v2 #663 and will be ported to v3 soon.

After another inspection I noticed that this error occurs because of parameters that are in the description. We use this to, for example, show what endpoints you should use instead of an deprecated endpoint.
I believe this is another issue than is described in #663 (but I might be mistaken). Since the specifications allow you to use curly braces in summaries, descriptions and other places, I think it would be nice if these are escaped by default where possible.

When I was testing with following testcases, got these errors

dacusaurus/core:3.0.0 - docusaurus-plugin-openapi-docs:3.0.0-beta.1
dacusaurus/core:3.0.0 - docusaurus-plugin-openapi-docs:3.0.0-beta.2
dacusaurus/core:3.0.1 - docusaurus-plugin-openapi-docs:3.0.0-beta.1
dacusaurus/core:3.0.1 - docusaurus-plugin-openapi-docs:3.0.0-beta.2

ERROR
could not find react-redux context value; please ensure the component is wrapped in a <Provider>
    at useReduxContext (webpack-internal:///./node_modules/react-redux/es/hooks/useReduxContext.js:31:11)
    at useSelector (webpack-internal:///./node_modules/react-redux/es/hooks/useSelector.js:136:28)
    at MethodEndpoint (webpack-internal:///./node_modules/docusaurus-theme-openapi-docs/lib/theme/ApiExplorer/MethodEndpoint/index.js:6:932)
    at renderWithHooks (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:16306:18)
    at mountIndeterminateComponent (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:20070:13)
    at beginWork (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:21583:16)
    at HTMLUnknownElement.callCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4165:14)
    at Object.invokeGuardedCallbackDev (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4214:16)
    at invokeGuardedCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4278:31)
    at beginWork$1 (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:27447:7)
ERROR
Hook useScrollController is called outside the <ScrollControllerProvider>.
ReactContextError
    at useScrollController (webpack-internal:///./node_modules/docusaurus-theme-openapi-docs/node_modules/@docusaurus/theme-common/lib/utils/scrollUtils.js:27:145)
    at useScrollPositionBlocker (webpack-internal:///./node_modules/docusaurus-theme-openapi-docs/node_modules/@docusaurus/theme-common/lib/utils/scrollUtils.js:45:63)
    at TabList (webpack-internal:///./node_modules/docusaurus-theme-openapi-docs/lib/theme/MimeTabs/index.js:20:339)
    at renderWithHooks (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:16306:18)
    at mountIndeterminateComponent (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:20070:13)
    at beginWork (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:21583:16)
    at HTMLUnknownElement.callCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4165:14)
    at Object.invokeGuardedCallbackDev (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4214:16)
    at invokeGuardedCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4278:31)
    at beginWork$1 (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:27447:7)

dacusaurus/core:3.0.0 - docusaurus-plugin-openapi-docs:3.0.0-beta.1
dacusaurus/core:3.0.0 - docusaurus-plugin-openapi-docs:3.0.0-beta.2
dacusaurus/core:3.0.1 - docusaurus-plugin-openapi-docs:3.0.0-beta.1
dacusaurus/core:3.0.1 - docusaurus-plugin-openapi-docs:3.0.0-beta.2

As far as my testing brought me any difference in version matching between docusaurus and docusaurus-plugin-openapi-docs will cause issues with redux and hooks. I feel like this might be due to slight mismatches in dependencies, comparable to this issue.
You should be able to use the v3.0.0-beta.3 release in combination with docusaurus 3.0.1. It will not work with docusaurus 3.0.0 or any older versions.

Yep, you're totally right, adding json and bash fixed all the highlighting issues, can't believe I didn't think to do that 😄

I think this issue still persists with v3.0.0-beta.3, and is due to some necessary updates in the theme package. I started refactoring this package but this is a somewhat slow process...

Hello! Adding<EMAIL_ADDRESS>to my project introduces a dependency to "@docusaurus/theme-common" ">=2.4.1 <=2.4.3". Can we bump this dependency to ^3.0.0?

@Gijsdeman The regex for matching curly braces would probably need a little tweaking.
Right now, if there are two pairs of curly braces on a single line, for example:
{key, value} {key, value}

The regex would match them as a single pair of brackets and only escape the first and the last one.

I'm stuck. I was getting the same error @lucasassisrosa was getting:

For me, when running against my definition I get these errors:
Error while compiling file docs/api/role-get.api.mdx (Line=37 Column=1)
Details: Expected a closing tag for `<div>` (37:440-37:445) before the end of `paragraph`
---
Error while compiling file docs/api/roles-list.api.mdx (Line=37 Column=1)
Details: Expected a closing tag for `<div>` (37:1035-37:1040) before the end of `paragraph`
---

But fortunately his fix worked for me (thanks @lucasassisrosa!):

When I ran into that it was due to the lack of new line chars and the presence of non-escaped characters. I did replacements following Docusaurus migration guide:

https://docusaurus.io/docs/migration/v3#bad-usage-of--1
https://mdxjs.com/migrating/v2/#update-mdx-files

I only did the first of those fixes — I literally just replaced < with /< — because I'm not sure what the second link means I should do.
But now I'm getting an error I don't know how to fix:
ERROR
Objects are not valid as a React child (found: object with keys {}). If you meant to render a collection of children, use an array instead.
    at throwOnInvalidObjectType (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:14888:9)
    at createChild (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:15140:7)
    at reconcileChildrenArray (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:15405:25)
    at reconcileChildFibers (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:15822:16)
    at reconcileChildren (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:19163:28)
    at updateHostComponent (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:19920:3)
    at beginWork (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:21614:14)
    at HTMLUnknownElement.callCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4165:14)
    at Object.invokeGuardedCallbackDev (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4214:16)
    at invokeGuardedCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4278:31)

More specifically, that first part is sometimes Objects are not valid as a React child (found: object with keys {textAlign, marginBottom}). So it seems that code like \
 is now problematic.
Does anyone know how I can fix this?

Is there anyone who have some trouble like the react-redux error?

The regex would match them as a single pair of brackets and only escape the first and the last one.

Good catch, I did not take greedy matching into account. I also realized I could just escape all curly brackets instead of just the ones that surround text, thus I opted for that approach.

Is there anyone who have some trouble like the react-redux error?

Have you tried deleting your yarn.lock and all node modules and reinstalled everything (with aligned versions of docusaurus-*-openapi-docs and docusaurus)? I only had this error due to version mismatches, but a fresh install of all packages always fixed the issue for me.

Is there anyone who have some trouble like the react-redux error?

Have you tried deleting your yarn.lock and all node modules and reinstalled everything (with aligned versions of docusaurus-*-openapi-docs and docusaurus)? I only had this error due to version mismatches, but a fresh install of all packages always fixed the issue for me.

Sure, I have deleted and reinstalled all the things with "@docusaurus/core": "3.0.1" and "docusaurus-plugin-openapi-docs": "^3.0.0-beta.3". But it doesn't work with same react-redux error

I am getting the same error as @kjeom
https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/issues/654#issuecomment-1854087759
Running these versions:
  "dependencies": {
    "@docusaurus/core": "^2.3.1",
    "@docusaurus/preset-classic": "^2.3.1",
    "@docusaurus/theme-live-codeblock": "2.3.1",
    "@mdx-js/react": "^1.6.21",
    "docusaurus-plugin-openapi-docs": "^2.0.2",
    "docusaurus-theme-openapi-docs": "^2.0.2",

So does not seem to be only a 3.0.0 issue.

3.0.0-beta.3
It worked for me like this

presets: [
    [
      'classic',
      /** @type {import('@docusaurus/preset-classic').Options} */
      ({
        docs: {
          sidebarPath: require.resolve('./sidebars.js'),
          docRootComponent: "@theme/DocRoot",
          docItemComponent: "@theme/ApiItem", // Derived from docusaurus-theme-openapi
        },
        blog: {
          showReadingTime: true,
        },
        theme: {
          customCss: require.resolve('./src/css/custom.css'),
        },
      }),
    ],
  ],

versions:
  "@docusaurus/core": "3.0.1",
    "@docusaurus/preset-classic": "3.0.1",
        "docusaurus-plugin-openapi-docs": "3.0.0-beta.3",
    "docusaurus-theme-openapi-docs": "3.0.0-beta.3",

I have also checked it working well

"@docusaurus/core": "3.1.0",
"@docusaurus/preset-classic": "3.1.0",
"docusaurus-plugin-openapi-docs": "3.0.0-beta.4",
"docusaurus-theme-openapi-docs": "3.0.0-beta.4",

Hello i m still facing the issue, with those versions.

I'm also facing same issue as
[Error [ValidationError]: "docLayoutComponent" is not allowed] {   _original: {     sidebarPath: '/Users/dj/git/GTN/gtn-portal/sidebars.js',     editUrl: 'https://github.com/facebook/docusaurus/tree/main/packages/create-docusaurus/templates/shared/',     docLayoutComponent: '@theme/DocPage',     docItemComponent: '@theme/ApiItem'   },   details: [     {       message: '"docLayoutComponent" is not allowed',       path: [Array],       type: 'object.unknown',       context: [Object]     }   ] }

I'm also facing same issue as
[Error [ValidationError]: "docLayoutComponent" is not allowed] { _original: { sidebarPath: '/Users/<>/sidebars.js', editUrl: 'https://github.com/facebook/docusaurus/tree/main/packages/create-docusaurus/templates/shared/', docLayoutComponent: '@theme/DocPage', docItemComponent: '@theme/ApiItem' }, details: [ { message: '"docLayoutComponent" is not allowed', path: [Array], type: 'object.unknown', context: [Object] } ] }

You should refer https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/issues/654#issuecomment-1880640360
change the docLayoutComponent to docRootComponent

You should refer #654 (comment)
change the docLayoutComponent to docRootComponent

Unfortunately, It doesn't help:
Module not found: Error: Can't resolve '@theme/DocPage' in '/workspaces/project-name/.docusaurus'

I have also checked it working well

"@docusaurus/core": "3.1.0",
"@docusaurus/preset-classic": "3.1.0",
"docusaurus-plugin-openapi-docs": "3.0.0-beta.4",
"docusaurus-theme-openapi-docs": "3.0.0-beta.4",

I'm still hitting the Cause: Expected a closing tag for '
' (31:488-31:544) before the end of 'paragraph' with these versions using the openapi-docs example with petstore.yaml.

I have also checked it working well

"@docusaurus/core": "3.1.0",
"@docusaurus/preset-classic": "3.1.0",
"docusaurus-plugin-openapi-docs": "3.0.0-beta.4",
"docusaurus-theme-openapi-docs": "3.0.0-beta.4",

I'm still hitting the Cause: Expected a closing tag for '
' (31:488-31:544) before the end of 'paragraph' with these versions using the openapi-docs example with petstore.yaml.

Try to cleanup the generated api docs and run. Also check that "  themes: ["docusaurus-theme-openapi-docs"], " is on config.js

I'm also facing same issue as
[Error [ValidationError]: "docLayoutComponent" is not allowed] { _original: { sidebarPath: '/Users/<>/sidebars.js', editUrl: 'https://github.com/facebook/docusaurus/tree/main/packages/create-docusaurus/templates/shared/', docLayoutComponent: '@theme/DocPage', docItemComponent: '@theme/ApiItem' }, details: [ { message: '"docLayoutComponent" is not allowed', path: [Array], type: 'object.unknown', context: [Object] } ] }

You should refer #654 (comment)
change the docLayoutComponent to docRootComponent

Thank you this is working now

I'm also facing same issue as
[Error [ValidationError]: "docLayoutComponent" is not allowed] { _original: { sidebarPath: '/Users/<>/sidebars.js', editUrl: 'https://github.com/facebook/docusaurus/tree/main/packages/create-docusaurus/templates/shared/', docLayoutComponent: '@theme/DocPage', docItemComponent: '@theme/ApiItem' }, details: [ { message: '"docLayoutComponent" is not allowed', path: [Array], type: 'object.unknown', context: [Object] } ] }

You should refer #654 (comment)
change the docLayoutComponent to docRootComponent

Thank you this is working now

Hello all. With the same deps I got:
ERROR
Hook  is called outside the <DocsSidebarProvider>.
ReactContextError@webpack-internal:///./node_modules/@docusaurus/theme-common/lib/utils/reactUtils.js:37:83
useDocsSidebar@webpack-internal:///./node_modules/@docusaurus/theme-common/lib/contexts/docsSidebar.js:21:132
useSidebarBreadcrumbs@webpack-internal:///./node_modules/@docusaurus/theme-common/lib/utils/docsUtils.js:55:120
DocBreadcrumbs@webpack-internal:///./node_modules/@docusaurus/theme-classic/lib/theme/DocBreadcrumbs/index.js:28:641
renderWithHooks@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:16306:27
mountIndeterminateComponent@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:20070:13
beginWork@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:21583:16
callCallback@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4165:14
invokeGuardedCallbackDev@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4214:16
invokeGuardedCallback@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4278:31
beginWork$1@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:27447:28
performUnitOfWork@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26556:12
workLoopConcurrent@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26539:22
renderRootConcurrent@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26501:7
performConcurrentWorkOnRoot@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:25734:38
workLoop@webpack-internal:///./node_modules/scheduler/cjs/scheduler.development.js:267:42
flushWork@webpack-internal:///./node_modules/scheduler/cjs/scheduler.development.js:240:14
performWorkUntilDeadline@webpack-internal:///./node_modules/scheduler/cjs/scheduler.development.js:534:21

I have also checked it working well

"@docusaurus/core": "3.1.0",
"@docusaurus/preset-classic": "3.1.0",
"docusaurus-plugin-openapi-docs": "3.0.0-beta.4",
"docusaurus-theme-openapi-docs": "3.0.0-beta.4",

I'm still hitting the Cause: Expected a closing tag for '
' (31:488-31:544) before the end of 'paragraph' with these versions using the openapi-docs example with petstore.yaml.

Try to cleanup the generated api docs and run. Also check that " themes: ["docusaurus-theme-openapi-docs"], " is on config.js

Is there a recommended way to do that? I can go through and remove the accidental newlines in the generated mdx files manually, but it would take ages on the petstore example to do by hand. I've got " themes: ["docusaurus-theme-openapi-docs"], " in my config already.

Hello, I am also getting following error, as soon as I click on one of the endpoint displayed in sidebard
could not find react-redux context value; please ensure the component is wrapped in a <Provider>
    at useReduxContext (webpack-internal:///./node_modules/react-redux/es/hooks/useReduxContext.js:31:11)

    "@docusaurus/core": "3.1.1",
    "@docusaurus/preset-classic": "3.1.1",
    "docusaurus-plugin-openapi-docs": "3.0.0-beta.5",
    "docusaurus-theme-openapi-docs": "3.0.0-beta.5",
    "prism-react-renderer": "^2.3.0",

same config and same error :(

There's an Open PR #660, What's missing on that PR to be merged and release v3.0?

Hello, I am also getting following error, as soon as I click on one of the endpoint displayed in sidebard
could not find react-redux context value; please ensure the component is wrapped in a <Provider>
    at useReduxContext (webpack-internal:///./node_modules/react-redux/es/hooks/useReduxContext.js:31:11)

    "@docusaurus/core": "3.1.1",
    "@docusaurus/preset-classic": "3.1.1",
    "docusaurus-plugin-openapi-docs": "3.0.0-beta.5",
    "docusaurus-theme-openapi-docs": "3.0.0-beta.5",
    "prism-react-renderer": "^2.3.0",

same config and same error :(

Yes same here

Same, plus "Expected a closing tag for
" error.

Hello, I am also getting following error, as soon as I click on one of the endpoint displayed in sidebard
could not find react-redux context value; please ensure the component is wrapped in a <Provider>
    at useReduxContext (webpack-internal:///./node_modules/react-redux/es/hooks/useReduxContext.js:31:11)

    "@docusaurus/core": "3.1.1",
    "@docusaurus/preset-classic": "3.1.1",
    "docusaurus-plugin-openapi-docs": "3.0.0-beta.5",
    "docusaurus-theme-openapi-docs": "3.0.0-beta.5",
    "prism-react-renderer": "^2.3.0",

same config and same error :(

Yes same here

Same, plus "Expected a closing tag for
" error.

Hi, have you tried it after deleting .lock and node_module files? I checked it doesn't occur the error with https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/issues/654#issuecomment-1888279640

@kjeom That worked. Thank you!
That solved the following issues:

"Expected a closing tag for
" error https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/issues/654#issuecomment-1792904919
could not find react-redux context value; error https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/issues/654#issuecomment-1880640360

More things that helped me to solve other problems:

https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/issues/654#issuecomment-1895970081 for Hook useDoc is called outside the <DocProvider> error

I appreciate that everyone's bringing up issues and helping each other here, but I'm very confused as to the state of the plugin currently.  Is it fully compatible with docusaurus v3, or are the approaches here just workarounds until the plugin is updated to work with v3?  @sserrata could you share what you believe to be the current state?  That would really help bring clarity to those of us waiting to update.

Hi everyone, the latest v3 beta is definitely not tested with the latest docusaurus (3.1.1). It's possible a breaking change was introduced in docusaurus, which is quite common for plugins/themes. That said, I would recommend downgrading to either 3.1.0 or 3.0.1. Also, please ensure all docusaurus dependencies are on the same release - this sometimes requires configuring yarn resolutions or manually pinning versions in package.json.

Great, so it sounds like v3 beta is compatible with at least some versions of docusaurus 3.x?  If so, I'd suggest closing out this issue so that people can open separate individual ones if they have problems.

Had to make these changes to dedupe dependencies:
"resolutions": {
        "@docusaurus/core": "3.1.1",
        "@docusaurus/theme-common": "3.1.1",
        "@docusaurus/plugin-content-docs": "3.1.1",
        "@docusaurus/utils": "3.1.1",
        "@docusaurus/utils-validation": "3.1.1",
        "docusaurus-plugin-openapi-docs": "3.0.0-beta.5",
        "react": "18.2.0",
        "react-redux": "7.2.6"
    },

After that I don't see major dupes anymore:
$ ls node_modules/docusaurus*openapi-docs/node_modules/

node_modules/docusaurus-plugin-openapi-docs/node_modules/:
clsx/     fs-extra/

node_modules/docusaurus-theme-openapi-docs/node_modules/:
@types/                        sass-loader/
clsx/                          unified/
hast-util-from-parse5/         unist-util-is/
hast-util-parse-selector/      unist-util-position/
hast-util-raw/                 unist-util-stringify-position/
hast-util-to-parse5/           unist-util-visit/
hastscript/                    unist-util-visit-parents/
html-void-elements/            vfile/
parse5/                        vfile-location/
prism-react-renderer/          vfile-message/
rehype-raw/

Make sure to include these to avoid the Redux Provider error:
docRootComponent: "@theme/DocRoot",
docItemComponent: "@theme/ApiItem",

After that the only issue remaining seems to be hr and br in MDX files:
# For macOS, on Linux you have to remove ''
find ./docs/api -type f -name "*.mdx" -exec sed -i '' 's/
/
/g' '{}' +
find ./docs/api -type f -name "*.mdx" -exec sed -i '' 's/
/
/g' '{}' +

Great, so it sounds like v3 beta is compatible with at least some versions of docusaurus 3.x?  If so, I'd suggest closing out this issue so that people can open separate individual ones if they have problems.

Closing my issue 👍


[BUG dev] type key of serialized polymorphic belong_to relationships is underscored

I have a business model where a Board has many BoardStrips, and the board strip belongs_to :strip, polymorphic: true.
Strip uses STI and has three subclasses.
When a board is serialized this is the shape of the payload:
{
  "id": "4",
  "type": "board-strip",
  "attributes": {
    "sequence": 0
  },
  "relationships": {
    "board": {
      "data": {
        "id": "23",
        "type": "board"
      }
    },
    "strip": {
      "data": {
        "id": "15",
        "type": "work_strip"  // <------------------- here
      }
    }
  }
}

All my serializers have set_key_transform :dash, so I'd expect the type to be dasherized, like it is with non-polymorphic belongs_to relationships.
I am using the dev branch

Looks like this is an issue with how we have implemented polymorphic support. I am taking a look. I will update you when i have a fix ready.

The fix for this issue should be released in Version 1.4


Missing information about MQTT 5.0 support.

File: /docs/en_US/README.md
Missing information about MQTT 5.0 support.

Thank for your kindly reminder!! Gonna update the docs soon!

Docs updated


Inspections for iterable types

[x] For checking foreach value, must be array or iterable
[ ] If use array access, it must be iterable type

would this cover also Nette\Database\Table\Selection?

@lulco What do you mean? What exactly?

I mean for example \Nette\Database\Table\Selection or other classes implementing \Iterator:
If I use this:
{varType Nette\Database\Table\Selection $files}

I got error:
Invalid argument supplied to 'foreach'. Expected types: 'array' or 'object', '\Nette\Database\Table\Selection' provided.
We know that all items in $files are ActiveRows from annotation of current() method. There is also "false" type but it could be ignored in foreach imho because it will never happen.

@lulco yes, I think you mean this issue: https://github.com/nette-intellij/intellij-latte/issues/86 :)

Yes, that's it :)


Overscan Rendering

I've done a first pass at implementing overscan rendering, which allows you to add extra pixels to the render outside the display window. For example, a setting of 100x100px adds 50px to each side of the image.

This is useful if you want a little bit of safety to reframe the image in post, avoid blurring issues near image borders or you need to do some lens distortion.

Currently it works like this...

Set the ScreenWindow and Resolution in the RIB file to the new image area (this doesn't modify the FOV)
Runs oiiotool on the renders at the end of the job to set the DisplayWindow back to it's intended format so the view looks correct against your Blender viewport. As a bonus this autocrops the render based on the alpha.

There is one big glaring issue with this that will affect how this is implemented and that's the second point.
I'm currently using oiiotool to set the DisplayWindow as there isn't an existing Renderman tool to do this. Oiiotool is an external tool and would require the user to have it in their PATH. Without this the user would need to reformat the images manually using something like a Reformat node in Nuke - which might not be obvious how to do this. I can add an option "post convert using oiiotool".
Does anyone have any thoughts about this?

I like the idea and see the need for post production, especially for blurring. The option for resetting the display window back should only be available if 'oiiotool' where found. If not, the user should know what somebody had enabled and have to deal with it.
I'm not fully satisfied with the terms 'width' and 'height' because they have to be recalculated by brain, I would name them something like "Vertical Overscan: 50px" and "Horizontal Overscan: 50px" which describes exactly whats going on: overscanning a single border by 50px. But this is my own point of view and may be biased.
From the fellows of printing post production comes the term bleed, which describes the overprinting for cutting the sheet. Typically they are given for any single border (like CSS-Border-Attributes), but mostly used with a single value which is applicable for all four side. I like the wording bleed a lot, but didn't know if that would fit here.

Thanks, that's great feedback. It's actually easier to not include the postconvert using oiiotool, currently trying to figure out all the displays that get written out and process isn't obvious. Maybe need to think about oiiotool postconvert as another separate feature (optional add-on 😊), this come from the way I work - with local queue I post convert exr to dpx and then convert those to prores using ffpeg for editing in resolve while comp with the exrs.
Point of overscan width/height is good, more obvious what it's doing. In Katana they offer control over each side, but dealing with lopsided overscan can be tricky which is why I didn't go that option. Bleed could also be used to describe this (especially for print), overscan is a bit more common term in vfx - both katana and nuke use it.

Naming it "overscan" is absolutely fine, even if i came from the printing world I understand immediately what you wanted to do.
I would keep in mind, that the user could have enabled percentage scaling  under Dimensions and you have to make clear how do you handle this. Since this is an option for generating final images (in my humble opinion) and percentage scaling is mostly enabled during prerendering, a boolean option for toggle overscanning like the following would do the trick:
[x] Full size render only
Should be enabled by default because it impacts render times a lot and  a good description for the property should mention something about "100%", "Dimensions" or so. :-)
You can get the percentage scaling o the current scene with:
bpy.data.scenes[bpy.context.scene.name].render.resolution_percentage

I did a lot of my testing at 25%, so I know what you mean (adding 512px to an HD@25% image ends up doubling the intended resolution :) ). I'm thinking the following drop-down.

Full Size Render Only (default), this only applies overscan when rendering at 100% resolution.
Relative to Render Percentage, this scales the overscan according to the resolution percentage.
Absolute Values, renders with the set overscan, ignoring the render percentage.

Even better. Perfect. :)


update fiddle to 2.1.x

@rsbondi thanks! I've just updated the original one on jsfiddle.
http://jsfiddle.net/cognitom/wf7bkvur/

ok, I will close

@cognitom I show no external resources and no hello world in the result

Ooops, I've fixed it again.


ci: fix bazel.debug toolchain issue.

This was breaking the debug build.
Also, add to Travis CI, since this is a build target that folks rely on.

@tschroed for the fix. @mattklein123 to decide if it's worth burning a Travis CI slot on.

My feeling right now is to just fix the bug and not use a slot. I don't think the actual test coverage is any different from what we get on the coverage build.


Do not log traceback when log format is json

resolves #7972
When calling logger.debug with exc_info set to True, logger will actually print out the formatted log to stdout(?). We want to avoid it when we set log_format to JSON
Will backport to 1.2 and 1.1 and 1.0 once this is merged.

@ChenyuLInx Change itself seems fine to me.

Will backport to 1.2 and 1.1 and 1.0 once this is merged.

We've no longer been cutting patches of v1.0 and v1.1 (since they've reached EOL) - let's discuss offline if there's a need to do this?


Training only on 2B tokens (openwebtext)

Hi !
Interesting work on the role of explicit bias!
I was wondering what training settings got you an eval PPL ~3.04. The paper mentions that 50K iterations are required to train the GPT-2 model on 2B tokens. What was the bacth_size_per_device and block_size for the same? Did you do training from scratch or fine-tune the pre-trained model (trained on 300B tokens)?
Thanks!

Hi, Thanks for your interest in our work.
The training config is shown here, which i think will be automatically divided by the number of GPUs available (here).
We do not perform any fine-tuning but instead train all the GPT-2 models from scratch.

Thanks for your reply.
The training configurations you referred to seem configured for the 600K training steps.
As mentioned in the paper, for training only on 2B tokens (eval PPL you got is ~3), you ran for 50K iterations.  Did

Thanks for your reply.
The training configurations you referred to seem configured for the 600K training steps.
As mentioned in the paper, you ran for 50K iterations to train only on 2 B tokens (the eval PPL you got is 3). Did you change anything else, such as learning rate, weight decay, etc.?
I trained for 50K iterations; however, my val loss remained ~3 (PPL >30).

No, i did not change anything such as learning rate or weight decay, my number is around those reported in the original nanogpt repo (https://github.com/karpathy/nanoGPT?tab=readme-ov-file#baselines).


ImportError: No module named pdfminer.converter

This is the stacktrace:
Traceback (most recent call last):
File "/usr/local/bin/cvscan", line 11, in
load_entry_point('cvscan==0.0.1', 'console_scripts', 'cvscan')()
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 560, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 2648, in load_entry_point
return ep.load()
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 2302, in load
return self.resolve()
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 2308, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/usr/local/lib/python2.7/dist-packages/cvscan-0.0.1-py2.7.egg/cvscan/init.py", line 8, in
import converter
File "/usr/local/lib/python2.7/dist-packages/cvscan-0.0.1-py2.7.egg/cvscan/converter.py", line 13, in
from pdfminer.converter import TextConverter
ImportError: No module named pdfminer.converter

Has been resolved. Check issuing the command
python setup.py install
Thanks for pointing it out...:)


CAP license changed into "Microsoft Teams Shared Devices"

["CAP license" has been changed to "Microsoft Teams Shared Devices". If you look for it in "purchase services" in admin portal, you will not find it anymore ]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b4ab5215-f24f-75cf-bb92-16ac0ff5e5ca
Version Independent ID: 701cc58f-d2ea-cbb6-f5fc-47b9fbfb1119
Content: Set up the Common Area Phone license - Microsoft Teams
Content Source: Teams/set-up-common-area-phones.md
Service: msteams
GitHub Login: @DaniEASmith
Microsoft Alias: danismith

@Emsabare We are currently updating all docs that reference this license name. There are many docs that need to be updated, but they will published this week.


Cloud: Incorrect front-end price display (‘From’), when using different visibilities with variant article:

Example:
The father article costs 5.99 and is assigned to sales channel A. The parent product has two variants with prices of €5.99 and €5,000.
The 1st variant item (5.99) is assigned to sales channel A and B. The 2nd variant article (5,000) is assigned to sales channel C.
The price of the 1st variant article is displayed in the article overview as ‘From €5.99’, although this is not correct, as the €5,000 article is not assigned to the sales channel of variant article 1.
If the ‘parent article’ is deactivated, the display in the frontend for the 1st variant article is correct again.
Apparently the ‘From’ display does not recognise that the variants have been assigned to different sales channels. It is strange, however, that the display is correct after deactivating the parent article.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-40104
[created from NEXT-40104, comment 528860]


Upgrade Duet to <IP_ADDRESS>

You grabbed some unrelated commits.

You grabbed some unrelated commits.

Urgh… Sorry. I think I screwed something up.

Urgh… Sorry. I think I screwed something up.


Address PHPCS issues

Type: refactoring
Breaking change: no

Turns out i fixed this in https://github.com/phpmd/phpmd/pull/1202


Validation

Hello,
I want to get appropriate validation error in the JSON file returned if tried to register and has validation errors.
I used this -
 $this->validate($request, Config::get('boilerplate.sign_up.validation_rules'));
     $user = new User($request->all());
    if(!$user->save()) {
      throw new HttpException(500);
    }

In SignUpController and as you can see I added the first line.
When I visit the page, I get this error ->
{   "error": {     "message": "The given data failed to pass validation.",     "status_code": 500   } }

https://github.com/francescomalatesta/laravel-api-boilerplate-jwt/issues/26 Helped!


Revert "Refactor pkg/subctl/cmd/ -> pkg/cloud for RHOS"

Reverts submariner-io/submariner-operator#2048
Unfortunately the commits were squashed which destroyed the commit history preserved by the mv commit.

If I sent this PR our three votes could merge it :thinking:

If I sent this PR our three votes could merge it thinking

https://github.com/submariner-io/submariner-operator/pull/2057


No Intellisense for Trigger OnBeforeAction OnAfterAction in Page Extensions

Please include the following with each issue:
1. Describe the bug
Currently the AL Language Extension does not suggest the Triggers when you modify an action in a pagee extension.
2. To Reproduce
Steps to reproduce the behavior:

Go to '...'

pageextension 50000 "PTE Contact Card" extends "Contact Card"
{
    actions
    {
        modify(CreateAsCustomer)
        {
// Try to type trigger an then Ctrl+Space for Intellisense
/*
            trigger OnBeforeAction()
            var
                Magic: Codeunit "PTE Magic";
            begin
                Magic.Do(Rec);
            end;
*/
        }
    }

}

3. Expected behavior
When you type trigger then intellisense should suggest the both valid triggers
4. Actual behavior
Currently only snippets are shown.
5. Versions:

AL Language: v15.0.1177813 (pre-release)

It works for me:


Fix: Update containerized-python-components.md. fixes #3871

This PR fixes the documentation for containerized Python components. The current documentation doesn't work and errors out as described in #3871

Move the import into the component
Update base_image to Python 3.11
Import the component in pipeline.py

@kubeflow/kubeflow-steering-committee can please help to review this change?

@diegolovison are you willing to take a look at this?

@stephenleo can you edit https://github.com/kubeflow/website/pull/3873#issue-2526350689 to link this PR to the issue?


Method destroy

The  $('.mentions').mentionsInput().destroy() giive me the following error $(...).mentionsInput(...).destroy is not a function.
How works ?

$('.mentions').mentionsInput('destroy')


Unable to compile sample

Required Info

Camera Model
{ D400 }

Firmware Version
<IP_ADDRESS>

Operating System & Version
{Win (8.1/10) }

Kernel Version (Linux Only)
N/A

Platform
PC

SDK Version
{  2.0.0  }

Language
{C++ }

Segment
N/A

Issue Description
Trying to run the Displaying Color Frame example in the Get Started With OpenCV step by step guide, I am getting an error at compilation. Is there something I am doing wrong?
Error	C2228	left of '.get_data' must have class/struct/union	RealSense-OpenCV	C:\Users\steph\source\repos\RealSense-OpenCV\RealSense-OpenCV\RealSense-OpenCV.cpp	36	```

Never mind, the issue was a simple typo in the retyping of the code.
Instead of writting
Mat color(Size(640, 480), CV_8UC3, (void*)color_frame.get_data(), Mat::AUTO_STEP);```
I wrote

Mat color(Size(640, 480), CV_8UC3, (void*)color_frame.get.get_data(), Mat::AUTO_STEP);```
The .get causing the issue


SCP-1687: use freer logging in Cardano.Node.Server

TL;DR: Update Node Mock Server to use the tracer from iohk-monitoring

Introduce Cardano.Node.Types.MockServerLogMsg
Refactor Cardano.Node.Server.main

Pre-submit checklist:

Branch

[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Relevant tickets are mentioned in commit messages

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

If you updated any cabal files or added Haskell packages:

[ ] nix-shell shell.nix --run updateMaterialized to update the materialized Nix files
[ ] Update hie-*.yaml files if needed

If you changed any Haskell files:

[ ] nix-shell shell.nix --run fix-stylish-haskell to fix any formatting issues

If you changed any Purescript files:

[ ] nix-shell shell.nix --run fix-purty to fix any formatting issues

Pre-merge checklist:

[ ] Someone approved it
[ ] Commits have useful messages
[ ] Review clarifications made it into the code
[ ] History is moderately tidy; or going to squash-merge

This will need #2724 to pass CI


Multiple instances of MSAL

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Other...  As web applications move towards a more Micro Frontend architecture style where multiple parts of a page are essentially different independent applications, each with their own authentication requirements, this presents problems. With the current implementation of MSAL, it is not currently possible to have more then one MSAL  instance. For example when one component of the page which using this architecture is its own app in and of itself, its client ID needs to be different then that of another or that of the host page, and the current implementation does not allow for this.
Expected behavior

MSAL should be able to create multiple instances on a single page so that Micro Frontend style architectures where multiple independent apps are running on the page are supported. Authentication can then be encapsulated within the applications, and not attached to the global context.
Minimal reproduction of the problem with instructions

Not Applicable

We are working on solving this, assigning to @sameerag who is leading that effort.

We are working on solving this, assigning to @sameerag who is leading that effort.

Do you have a timeline for it?

Absolutely, let me know whatever I can do to help!

Hi @shane7218, We have fixed this issue in MSAL JS 1.2.0-beta.3. Please try and let us know if you have any further issues.
Thanks,
Neha

@negoe I'm using the redirect flow, and I need 2 instances of UserAgentApplication, each with a different client Id. As soon as I add the second instance, everything breaks.
Looking at the PR that claims to fix this, it only seems to be targeting the popup flow. Are there any workarounds?


Create a landing page for NodeSecure

The idea is to create a landing page for the NodeSecure project. This was originaly proposed by @im-codebreaker.
The goal of the landing page would/could be:

Explains what NodeSecure is.
Highlight contributors.
Highlight and explains our "main" projects (CLI, JS-X-Ray, Vuln, CI etc).
Highlight social networks.

I guess I'm still missing a lot of things. A first version could be relatively "simple" and then we can iterate to improve it.

I really like this idea.
This could be a game changer to explain what is NodeSecure, who is behind etc...

Do not hesitate to post ideas of design or example of landing page you found.

https://keet.io/

https://hypercore-protocol.org/

https://developer.redis.com/

https://bit.dev/


Path matching for path that ends with question mark

I stack with some problem using simple routes hierarchy below:
<Route name="login" handler={DefaultLayout}>
	<DefaultRoute handler={LoginPage}/>
	<NotFoundRoute handler={NotFound}/>
</Route>

But router matches paths differently on server and client, when I use question mark in address (not Route's "path" property):

Path
Server
Client

/login
LoginPage
LoginPage

/login/a
NotFound
NotFound

/login?a=1
LoginPage
LoginPage

/login?a
LoginPage
LoginPage

/login?
NotFound
LoginPage

I don't know is it a bug or I just have to set "path" property of  with some specific value.

Chiming in. This happens when I'm using gulp-connect.
It works fine if you're using the deprecated way
Router.run(routes, function (Handler) {
  React.render(<Handler/>, document.body);
});

Which has a /#/ in the URL
But if you're using
Router.run(routes, Router.HistoryLocation, function (Handler) {
  React.render(<Handler/>, document.body);
});

Which removes the /#/, having a question mark in the suffix of the URL will cause it to not be found.


TypeError: Cannot read properties of undefined (reading 'style')

Description
I am having this error
TypeError: Cannot read properties of undefined (reading 'style')
Version
0.64.3
Output of react-native info
./node_modules/react-native-elements/src/config/ViewPropTypes.js:3:22
"export 'ViewPropTypes' (imported as 'RNViewPropTypes') was not found in 'react-native-web/dist/index'
1 | import { View, ViewPropTypes as RNViewPropTypes } from 'react-native';
2 |

3 | const ViewPropTypes = RNViewPropTypes || View.propTypes;
|                      ^
4 |
5 | export default ViewPropTypes;
6 |
./node_modules/react-native-ratings/src/SwipeRating.js:332:9
"export 'ViewPropTypes' was not found in 'react-native-web/dist/index'
330 |   onFinishRating: PropTypes.func,
331 |   showRating: PropTypes.bool,
332 |   style: ViewPropTypes.style,
|         ^
333 |   readonly: PropTypes.bool,
334 |   startingValue: PropTypes.number,
335 |   fractions: fractionsType,

Steps to reproduce
Run Npm i and then npm start
of this repo
Snack, code example, screenshot, or link to a repository
No response

Problem solved

Problem solved

Hi there, how'd you solve it?

@Muhammad-Bilal-7896  I just started encountering this issue as well - what was the solution that you found?

Thank you for asking Actually I will find out the solution because I solved
that months ago.Please give me some time so that I can reopen the app on
which I was working then I will be able to figure it out.Thanks.
Regards
Muhammad Bilal
On Sat, Jan 29, 2022 at 2:33 AM Jordan @.***> wrote:

@Muhammad-Bilal-7896 https://github.com/Muhammad-Bilal-7896 I just
started encountering this issue as well - what was the solution that you
found?
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/32753#issuecomment-1024659290,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOEOKDIZN7IPP4SC6GLHQI3UYMDSVANCNFSM5KAQMCJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Alright, thanks @Muhammad-Bilal-7896 . I will be waiting on the solution

Hi @Sbonelo01 Can you please send me the link of the app on which you are working because I am no longer having this error and not remembering of the solution.May be if I have this error again then I again come up with the solution so please send me your source code link so that I can view it.Thanks.

Will be waiting for your reply and if I found your code then may be I will
be able to figure it out.
On Sat, Jan 29, 2022 at 9:38 AM Sbonelo @.***> wrote:

Alright, thanks @Muhammad-Bilal-7896
https://github.com/Muhammad-Bilal-7896 . I will be waiting on the
solution
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/32753#issuecomment-1024832277,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOEOKDKV5ETRM2RQ6R5CEOTUYNVLPANCNFSM5KAQMCJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @Sbonelo01 Can you please send me the link of the app on which you are working because I am no longer having this error and not remembering of the solution.May be if I have this error again then I again come up with the solution so please send me your source code link so that I can view it.Thanks.What I remember is that I had actually edited node modules but I forgot which file I actually changed.So i need to look at your code.

Unfortunately it's a work application, I can't share the code . And also, I'm using ReactJS, not Native. I guess I'll try figure it out

Sure but if you will give some more details then i will be able to
figure it out.Thanks
On Sat, Jan 29, 2022, 3:11 PM Sbonelo @.***> wrote:

Hi @Sbonelo01 https://github.com/Sbonelo01 Can you please send me the
link of the app on which you are working because I am no longer having this
error and not remembering of the solution.May be if I have this error again
then I again come up with the solution so please send me your source code
link so that I can view it.Thanks.What I remember is that I had actually
edited node modules but I forgot which file I actually changed.So i need to
look at your code.
Unfortunately it's a work application, I can't share the code . And also,
I'm using ReactJS, not Native. I guess I'll try figure it out
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/32753#issuecomment-1024882028,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOEOKDLA3DJBB2CMGOKHTY3UYO4M5ANCNFSM5KAQMCJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Sure but if you will give some more details then i will be able to figure it out.Thanks
…
On Sat, Jan 29, 2022, 3:11 PM Sbonelo @.> wrote: Hi @Sbonelo01 https://github.com/Sbonelo01 Can you please send me the link of the app on which you are working because I am no longer having this error and not remembering of the solution.May be if I have this error again then I again come up with the solution so please send me your source code link so that I can view it.Thanks.What I remember is that I had actually edited node modules but I forgot which file I actually changed.So i need to look at your code. Unfortunately it's a work application, I can't share the code . And also, I'm using ReactJS, not Native. I guess I'll try figure it out — Reply to this email directly, view it on GitHub <#32753 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOEOKDLA3DJBB2CMGOKHTY3UYO4M5ANCNFSM5KAQMCJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.>

Hi @Muhammad-Bilal-7896 , I have this file Component - called ReviewPopUp:
`import React from "react";
import Typography from "@material-ui/core/Typography"
import Markdown from "react-markdown";
import Modal from "../../widgets/Modal";
const ReviewPopUp = ({ review, openReviewPopUp, setOpenReviewPopUp }) => {
return (
<Modal
open={openReviewPopUp}
onClose={() => {
setOpenReviewPopUp(false);
}}
>

{review.reviewerUserEmail}'s review:

);
};
export default ReviewPopUp;`
It makes use of a component within the app - which has a code that looks like this:
`import React from "react";
import Modal from "@material-ui/core/Modal";
import Backdrop from "@material-ui/core/Backdrop";
import Fade from "@material-ui/core/Fade";
import { makeStyles } from "@material-ui/core/styles";
const useStyles = makeStyles((theme) => ({
modal: {
display: "flex",
alignItems: "center",
justifyContent: "center",
},
backDrop: {
background: "rgba(0,0,0,0.15)",
},
}));
export default ({ open, onClose, children }) => {
const classes = useStyles();
return (
<Modal
aria-labelledby="transition-modal-title"
aria-describedby="transition-modal-description"
className={classes.modal}
open={open}
onClose={onClose}
closeAfterTransition
BackdropComponent={Backdrop}
BackdropProps={{
timeout: 500,
classes: {
root: classes.backDrop,
},
}}
>
{children}

);
};
`
And then I am using them in a component called Review, which has a code that looks like this:
`import React, { useState } from "react";
import { makeStyles } from "@material-ui/core/styles";
import Card from "@material-ui/core/Card";
import CardHeader from "@material-ui/core/CardHeader";
import CardContent from "@material-ui/core/CardContent";
import IconButton from "@material-ui/core/IconButton";
import Typography from "@material-ui/core/Typography";
import Markdown from "react-markdown";
import ReviewStatus from "../../widgets/ReviewStatus";
import ReviewValidationIcons from "../../widgets/ReviewValidationIcons";
import { trimLongReview } from "./utils";
import CropFreeIcon from "@material-ui/icons/CropFree";
import Button from "@material-ui/core/Button";
import ReviewPopUp from "./ReviewPopUp";
const useStyles = makeStyles((theme) => ({
root: {
maxWidth: "100%",
},
iconAlignment: {
position: "absolute",
right: "10px",
},
timeFont: {
fontSize: 11,
},
reviewerFont: {
fontSize: "100%",
fontWeight: "bold",
},
cardFont: {
fontSize: "100%",
},
cardHeader: {
paddingBottom: 0,
"&:last-child": {
paddingBottom: 0,
},
},
iconColor: {
color: "black",
},
cardContent: {
paddingTop: 0,
paddingBottom: 0,
},
footer: {
paddingTop: 0,
"&:last-child": {
paddingTop: 0,
},
},
}));
const Review = ({ review }) => {
const classes = useStyles();
const [openReviewPopUp, setOpenReviewPopUp] = useState(false);
const timestamp = new Date(review.timestamp);
return (

<CardHeader
title={

{timestamp.toLocaleString()}
<Button
type="button"
size="small"
className={classes.iconAlignment}
onClick={() => setOpenReviewPopUp(true)}
>
{review.comments.includes("\n") ? (

) : (
React.Fragment
)}

}
subheader={

{review.reviewerUserEmail}

}
className={classes.cardHeader}
/>

);
};
export default Review;
`
As soon as I click the button created in line 67, the error occurs

Sure, I will let you know. If i will find out solution and if you found
please let us know. Thanks and Regards
Muhammad bilal
On Sun, Jan 30, 2022, 5:10 PM Sbonelo @.***> wrote:

Sure but if you will give some more details then i will be able to figure
it out.Thanks
… <#m_-3145584836681403642_>
On Sat, Jan 29, 2022, 3:11 PM Sbonelo @.> wrote: Hi @Sbonelo01
https://github.com/Sbonelo01 https://github.com/Sbonelo01
https://github.com/Sbonelo01 Can you please send me the link of the app
on which you are working because I am no longer having this error and not
remembering of the solution.May be if I have this error again then I again
come up with the solution so please send me your source code link so that I
can view it.Thanks.What I remember is that I had actually edited node
modules but I forgot which file I actually changed.So i need to look at
your code. Unfortunately it's a work application, I can't share the code .
And also, I'm using ReactJS, not Native. I guess I'll try figure it out —
Reply to this email directly, view it on GitHub <#32753 (comment)
https://github.com/facebook/react-native/issues/32753#issuecomment-1024882028>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOEOKDLA3DJBB2CMGOKHTY3UYO4M5ANCNFSM5KAQMCJQ
https://github.com/notifications/unsubscribe-auth/AOEOKDLA3DJBB2CMGOKHTY3UYO4M5ANCNFSM5KAQMCJQ
. Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.>
Hi @Muhammad-Bilal-7896 https://github.com/Muhammad-Bilal-7896 , I have
this file Component - called ReviewPopUp:
`import React from "react";
import Typography from @.***/core/Typography"
import Markdown from "react-markdown";
import Modal from "../../widgets/Modal";
const ReviewPopUp = ({ review, openReviewPopUp, setOpenReviewPopUp }) => {
return (
<Modal
open={openReviewPopUp}
onClose={() => {
setOpenReviewPopUp(false);
}}

{review.reviewerUserEmail}'s review:
);
};
export default ReviewPopUp;`
It makes use of a component within the app - which has a code that looks
like this:
`import React from "react";
import Modal from @./core/Modal";
import Backdrop from @./core/Backdrop";
import Fade from @.***/core/Fade";
import { makeStyles } from @.***/core/styles";
const useStyles = makeStyles((theme) => ({
modal: {
display: "flex",
alignItems: "center",
justifyContent: "center",
},
backDrop: {
background: "rgba(0,0,0,0.15)",
},
}));
export default ({ open, onClose, children }) => {
const classes = useStyles();
return (
<Modal
aria-labelledby="transition-modal-title"
aria-describedby="transition-modal-description"
className={classes.modal}
open={open}
onClose={onClose}
closeAfterTransition
BackdropComponent={Backdrop}
BackdropProps={{
timeout: 500,
classes: {
root: classes.backDrop,
},
}}

{children}
);
};
`
And then I am using them in a component called Review, which has a code
that looks like this:
`import React, { useState } from "react";
import { makeStyles } from @./core/styles";
import Card from @./core/Card";
import CardHeader from @./core/CardHeader";
import CardContent from @./core/CardContent";
import IconButton from @./core/IconButton";
import Typography from @./core/Typography";
import Markdown from "react-markdown";
import ReviewStatus from "../../widgets/ReviewStatus";
import ReviewValidationIcons from "../../widgets/ReviewValidationIcons";
import { trimLongReview } from "./utils";
import CropFreeIcon from @./icons/CropFree";
import Button from @./core/Button";
import ReviewPopUp from "./ReviewPopUp";
const useStyles = makeStyles((theme) => ({
root: {
maxWidth: "100%",
},
iconAlignment: {
position: "absolute",
right: "10px",
},
timeFont: {
fontSize: 11,
},
reviewerFont: {
fontSize: "100%",
fontWeight: "bold",
},
cardFont: {
fontSize: "100%",
},
cardHeader: {
paddingBottom: 0,
"&:last-child": {
paddingBottom: 0,
},
},
iconColor: {
color: "black",
},
cardContent: {
paddingTop: 0,
paddingBottom: 0,
},
footer: {
paddingTop: 0,
"&:last-child": {
paddingTop: 0,
},
},
}));
const Review = ({ review }) => {
const classes = useStyles();
const [openReviewPopUp, setOpenReviewPopUp] = useState(false);
const timestamp = new Date(review.timestamp);
return (
<CardHeader
title={
{timestamp.toLocaleString()}
<Button
type="button"
size="small"
className={classes.iconAlignment}
onClick={() => setOpenReviewPopUp(true)}

{review.comments.includes("\n") ? (
) : (
React.Fragment
)}
}
subheader={
{review.reviewerUserEmail}
}
className={classes.cardHeader}
/>
);
};
export default Review;
`
As soon as I click the button created in line 67, the error occurs
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/32753#issuecomment-1025129690,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOEOKDILZ4WD76UNF2QMPZ3UYUTBTANCNFSM5KAQMCJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

@Muhammad-Bilal-7896 , I have solved the problem. I had to remove Typography.
Thanks for you time

Glad to hear it!
On Sun, Jan 30, 2022 at 7:27 PM Sbonelo @.***> wrote:

@Muhammad-Bilal-7896 https://github.com/Muhammad-Bilal-7896 , I have
solved the problem. I had to remove Typography.
Thanks for you time
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/32753#issuecomment-1025154898,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOEOKDI5HQPJO63HMXEJCHTUYVDEHANCNFSM5KAQMCJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

I changed const url = ws.upgradeReq.url; (in <project_folder/node_modules/metro/src/lib/attachWebsocketServer.js> ) to const url = ws?.upgradeReq?.url;  to ensure the value of url is not undefined. This is most likely not the best way to solve this issue, but it did allow the app to run for me.


Parsing solver name and regularizer

move instantiate_solver from Regularizer to BaseRegressor class: this grabs the strings and construct the solver run, update and init_solver functions.
add a parsing method to BaseRegressor that checks the config compatibility for solver and regularizer.
If you change thing in the regularizer changes will be reflected in glm fit as well.

Solved in #183


Feat/draft v standard

I agree, that's why the tests are failing. But I'm not sure how to actually do that.

Is anyone pulling the latest master automatically or are all the known libraries keeping their own cached version?

go-multihash is pulling into a submodule but (a) that's locked against a specific commit and (b) we're only using it for tests.
@vmx?

In the JS world there is a script that takes the file that generates JS code. It's a manual process.
In Rust, there is not even a script, there it's totally manually.

So, merging this and breaking people's stuff will tell them that they should probably be relying on the header to know what the columns are rather than hard-wiring it in. So I'm +1 on merging and taking care of the consumers that we control and adding in documentation that if you're consuming the table you must use the header to determine column contents.

You know - we could just switch to a slightly more extensible format: JSON, YAML, whatever: something that allows us to grow the metadata without rebreaking the world every time.
We can also keep the .csv around by siply having a step that regenerates it from the now-canonical master-spec.
I would volunteer to implement this, together with the necessary CI hooks, provided there is buy in to go that route.

For this case I don't like JSON for the lack of being able to add comments, but so is CSV => I think we should go with JSON as canonical representation, and generate CSV out of it (as CSV is really so much easier to read/look things up).

Why don’t we just use a markdown table and write a simple script that bulids a .csv and .json file on every checking using GitHub Actions?

just use a markdown table

Because it's not that much different from a CSV then, we haven't solved very much. We may as well have an "input CSV" an a "consume-me CSV" if we head down that route. The only thing a Markdown table really buys us is the ability to embed it in a large Markdown doc (the table is getting large enough that this probably isn't something we need to be doing) or to discourage it from being consumed as the primary source (documentation can do that job, as can naming).
@vmx is there much more than we'd need in terms of comments than we could fit into a "comments" field for each entry? That can be arbitrary text with comments about anything relating to an entry.

@vmx is there much more than we'd need in terms of comments than we could fit into a "comments" field for each entry?

Good point. I think that's enough.

I don't have the time to refactor how we store multicodecs but I really want this merged so we can more easily merge new multicodec registrations.

@Stebalien you mention that having "draft" and "permanent" would make merging new multicodecs easier. My impression is that this wasn't really the problem so far when we didn't merge things. I think the problem is that we miss a clear definition what multicodec codes (and their categories) are about. It boils down to: Is it just a random table with numbers in it, or do they have a certain meaning.

It boils down to: Is it just a random table with numbers in it, or do they have a certain meaning.

Well, that part usually boils down to "are they using IPLD right". But draft v permanent would make me feel better about adding new codes.

only one of the blake2b hashes has widespread usage yet they are all permanent here

My concern is that poking holes in this range could be troublesome if someone actually needs one of the others. But then again, we might as well stick to our policy.

sha2-256-trunc254-padded and poseidon-bls12_381-a2-fc1 are the CID pairs for fil-commitment-unsealed and fil-commitment-sealed respectively. The former are draft but the latter are permanent.

Will fix.

I think the bitcoin* and eth* codecs should be permanent, they are being used in the wild, outside of PL, and as more than just examples (dbl-sha2-256 would come along with bitcoin*)

Fair enough.

cbor and json would be nice to have as permanent, although I can't point to active non-example uses of them
dag-cose is getting more use in the wild I think, but we could wait for input from those users

SGTM.

dag-cose is getting more use in the wild I think, but we could wait for input from those users

Jose or Cose or both?

@rvagg I've fixed everything but jose/cose.


Add 1x1 and hollow-3x3 modes to compacter

Adds two new modes to the compacter block.
Single item mode (1x1) because there are dozens of items in modded Minecraft that have single-item recipes to turn into something else, and not many automated solutions that don't require dozens of dedicated autocrafters.
Hollow mode (eg: wooden chest) is for feature parity with AutoPackager.  (Mainly so my users stop bugging me to add AutoPackager when we already have Compacters)

Thanks!


Better toc on the website

In the old website, there was a toc of all the widgets on the right when browsing a widget, making it very easy to go through all the widgets (https://web.archive.org/web/20121015184637/http://kivy.org/docs/api-kivy.uix.slider.html).
In the current website everything kivy is listed in the toc, making it very difficult to find anything in particular without scrolling through the whole list. So this is a request to add a context sensitive toc.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

By web-site, I think this is referring to the HTML version of the documentation, right?


updating role arn

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

s