Teach tmt test create to link relevant issues

Similarly to beaker-wizard -b BZ# it would be convenient to let tmt prefill some values based on a bugzilla.

I'm a little bit hesitant about this feature. From the past experience with beaker-wizard it seems that people quite often blindly take whatever beaker-wizard detects from Bugzilla which then resulted in weird test names (e.g. cut in the middle of the sentence), copy-pasted PURPOSE files which no one used.
Which information do you suggest to be detected from the bug? Perhaps there are still some useful data which could be auto-filled but as far as summary and description are concerned I would rather encourage/force users to write something reasonable.

It is mainly about the laziness. Actually I do not care of the name much so I'm one of those who blindly take anything. :-)

I think main issue with prefilled name were inability to rename test later. Would that be also issue with tmt?

Adding 'should' priority as this has been raised several times already.

I think main issue with prefilled name were inability to rename test later. Would that be also issue with tmt?

Yes, renaming is no problem. But I don't see benefit in defaulting to create an ugly name with possible future (and usually not very probable) possibility of change to something better. Why should we not create tests with nice names directly? I'd like to repeat my question:

Which information do you suggest to be detected from the bug? Perhaps there are still some useful data which could be auto-filled but as far as summary and description are concerned I would rather encourage/force users to write something reasonable.

With the one-year experience with tmt I find it very useful to organize tests reasonably according to the area they cover. This allows for example to easily execute all tests related to given area which I have just modified with my patch:
tmt run test --name execute

With beaker-wizard, my workflow is:

cd <comp_git>
beaker-wizard -b
modify or use provided test name, provide test type, description and test run time, confirm
vim /runtest.sh and write test code

I'd like to have main.fmf and test.sh ready to write code with similar simple steps.

I agree with @psss . Our old tests created using beaker-wizard didn't really provided descriptive test summary (what the actual test does) and  Jira ticket clearly can't.

As discussed on today's stakeholders meeting, let's introduce a new option for specifying the related issue:
tmt test create /tests/name --issue https://bugzilla.redhat.com/show_bug.cgi?id=1234567

By default I'd say verifies relation should be used. Optionally, it could be specified on the command line, for example:
tmt test create /tests/name --relation=verifies --issue ...
tmt test create /tests/name --relation=relates --issue ...

Or the naming could be more close to the link key, perhaps something like this?
tmt test create /tests/name --link-verifies https://issues.redhat.com/browse/TT-123
tmt test create /tests/name --link-relates https://issues.redhat.com/browse/TT-123

In order to use the default relation, the short --link version could be used:
tmt test create /tests/name --link https://issues.redhat.com/browse/TT-123

Providing the full url allows to use different issue tracking systems rather than limiting the functionality to a single tool.

This is one of the blockers to provide a comfortable & concise way to create new tests, blocking TT-242. Let's try to implement in 1.27 as it is an easy fix.

Hi @psss, I'd like to help to fix this issue.

It makes a perfect sense to me to create a link section pointing to the related bugzilla.

Do we just need to add one line to the fmf file? e.g.
link: https://issues.redhat.com/browse/TT-123

By default I'd say verifies relation should be used. Optionally, it could be specified on the command line, for example:
tmt test create /tests/name --relation=verifies --issue ...
tmt test create /tests/name --relation=relates --issue ...

I'm not sure relation should be added too, please help to clarify, thanks!

The newly created test should have the link with appropriate relation included in the fmf metadata. From the options brainstormed above I'd vote probably for the shortest way for the most common use case (e.g. writing a test verifying an issue), so that:
tmt test create /tests/name --link https://issues.redhat.com/browse/TT-123

would create a new test with the following link:
link:
  - verifies: https://issues.redhat.com/browse/TT-123

We should also allow choosing a different relation if needed. For that I'd propose using:
tmt test create /tests/name --relation relates --link https://issues.redhat.com/browse/TT-123

which would lead to:
link:
  - relates: https://issues.redhat.com/browse/TT-123

What do you think?

The final solution is to support multiple links via relation:target.   For example,

Create one link without relation, which will use the default one - relates
$ tmt test create /tests/foo1 -t shell --link foo

which would lead to:
link:
  - relates: foo

Create one line with relation
$ tmt test create /tests/foo1 -t shell \
  --link verifies:https://issues.redhat.com/browse/TT-123

which would lead to:
link:
  - verifies: https://issues.redhat.com/browse/TT-123

Create multiple links
$ tmt test create /tests/foo1 -t shell \
  --link foo \
  --link verifies:https://issues.redhat.com/browse/TT-123 \
  --link relates:https://issues.redhat.com/browse/TT-124

which would lead to:
link:
  - relates: foo
  - verifies: https://issues.redhat.com/browse/TT-123
  - relates: https://issues.redhat.com/browse/TT-124


Workaround for Mono bug

where ParameterInfo returns an empty string in case of return argument.
I know this is "not your fault", but Mono returns an empty string "" when the ParameterInfo object is the return value, which makes your library firing an exception incorrectly...
If you accept this change I could use your lib still from your official distribution, otherwise I'll have to keep a forked version, with packages and stuffs.. :(
The bug will be reported to mono team, but it's gonna take some time before the fix is released.
Thanks

Thank you for bringing up this problem! I will merge this PR but unfortunately I won't be able to publish the release until next week. Before then, you may consider doing a local build and perhaps just replacing the DLL dependency.

Yep, that's what we're doing, thanks.

Just found this statement on docs:

If this ParameterInfo represents a return value (that is, if it was obtained by using the MethodInfo.ReturnParameter property), this property will be null.

So Mono team should definitely fix this, were they going to conform the .NET Standard.


Mobile version not working.

Looks like theme is not usable on mobile devices.
How to reproduce?

Go with Windows Phone browser to https://blog.appernetic.io/2016/06/01/appernetic-theme-showcase-gallery/
Try to click Start the discussion... in disqus comments section.
You can't start the discussion.

It probably doesn't work with Android/Chrome as well.

I have tested with Chrome on my Mac and when I resize to width: 767px it is not possible to add comments in the Disqus comment field or use the Disqus buttons.  It works in iPad mode 768px wide.
My code is checked with the W3 validator and there are only 2 warnings nothing that can cause this. Here is the link: https://validator.w3.org/nu/?showsource=yes&showimagereport=yes&doc=https%3A%2F%2Fblog.appernetic.io%2F2016%2F06%2F01%2Fappernetic-theme-showcase-gallery%2F
Is Disqus causing this issue?

The issue is with the columns.
To make it work the Disqus column need to have: ´´´  ´´´
and  the right column need to have col-xs-12 col-sm-12 added:  ´´´ ´´´

Fixed!


#342, 343, 344 Changed the annotations according to the task

In controller EcoNewsController in method update I added next changes:

According to task #342 added Response code 401 (Unauthorized)
According to task #343 added Response code 404 (Not Found)
According to task #344 deleted Response code 303 (See Other)

You should resolve merge conflict.

Conflict resolved


Authorization applied to pages

What would that feature address
With the authentication & authorization features, Taipy is able to identify a user as being granted a number of roles.
We want to leverage this feature so that the graphical user interface serves pages that potentially depend on the connected user roles.
Developers should be able to precisely indicate what user roles can access what page content: starting with a common, public page, users can authenticate, and the back-end associates roles for that user. From now on, these roles are used to control which pages the
user can access.
Description of the ideal solution
I don't see the necessity of dealing with user roles at the visual elements level: that would greatly complicate the definition of pages, and one can tune the access to elements on different pages, as long as Taipy has a way to define different page content based on different roles.
As a programmer, there should be a way to register different page contents depending on the assigned user roles.
Something like:
page = RestrictedPage(
    { PublicRole, Page(...) },
    { Role1, Page(...) },
    { [Role2, Role3], Page(...) }
)
gui.add_page(page)

Caveats

The definition of what a role is is still unclear, making proposals for APIs impossible.
It's also unclear if we want to prevent users to access pages, or allow users to access pages that other users cannot.
(meaning: do roles add or remove access rights).
In the example above, what if a user has Role1 and Role2?

Acceptance Criteria

[ ] Ensure new code is unit tested, and check code coverage is at least 90%
[ ] Propagate any change on the demos and run all of them to ensure there is no breaking change
[ ] Ensure any change is well documented

The roles are defined in the specification document here. This should help answer the first and second caveat.
In the implementation section, the role hierarchy could help to answer the third caveat.


add lang="scss" or sass report error

why? the error msg is
!!vue-style-loader!css-loader?{"minimize":false,"sourceMap":false}!../node_modules/vue-loader/lib/style-rewriter?{"id":"data-v-5a66ccc8","scoped":false,"hasInlineConfig":false}!sass-loader?{"indentedSyntax":true,"sourceMap":false}!../node_modules/vue-loader/lib/selector?type=styles&index=0!./App.vue in ./src/App.vue

Do you have installed sass-loader and node-sass ?

node-sass and sass-loader have to be installed by you.


Refactor watch task to remove Gulp

What
Update tasks/gulp/watch.js to replace Gulp with our own watch script. This task is responsible for watching source code changes.
Why
We have made the decision to move away from Gulp and write our own build scripts.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when

[x] tasks/gulp/watch.js no longer depends on Gulp
[ ] ~docs/contributing/tasks.md has been updated~
[x] watch.js has been relocated to tasks folder

Since the watch task relies on the gulp tasks styles, sassdoc and scripts, I'm going to adjust its positioning in this work.

This issue was picked up in:

https://github.com/alphagov/govuk-frontend/pull/3428

It's ready for review but we'll need to decide:

Do we keep gulp.watch() and close this?
Do we replace gulp.watch() but keep gulp.parallel() for logging (based on #3384 feedback)
Do we replace gulp.watch() with a better tool (Browsersync?) versus a like-for-like replacement

I'm inclined to do 1 or 3.
gulp.watch() is a pretty core part of Gulp's functionality so I think 2 (deftly shown in #3428) feels like a step too far.
I vote we go with 1 for now and open an issue to investigate an alternative which we can pick up if we find the solution holds us back from anything.


CallstackDeminifier requires SourceCodeProvider?

Hi,
This may not be a good place to ask this, but perhaps someone can give some answers.
The SourceMapConsumer in https://github.com/mozilla/source-map#sourcemapconsumer only requires the sourceMap content. So why does the GetStackTraceDeminfier require ISourceCodeProvider? Shouldn't souceMap be enough to deminify a stack trace?
Thanks

This is a fine place to ask. It's a great question.
So when you get a stack trace in the browser, it gives you the line number where the exception was thrown.
Something like this:
at i (http://localhost:11323/crashcauser.min.js:1:113)
In order to accurately get the original method name corresponding to the minified method i, we need the line number of i. However, the stack trace gives you the line number where the exception happened, not the line number of the function declaration. We use the original source code to be able to find line number of the function declaration that contains the line number of the exception. In the example, above, it would tell us the line and column number of the declaration of i. Once we have the location information of i, we can look in the source map for the original name.
So to summarize, we don't need the source code to deminify the method name, but we need it to get the location of the function wrapping the exception in the stack trace.

Also, to clarify, you don't need the source code to parse the source map, you just need it if you want to deminify a stack trace accurately.

Thanks for the information. This is really interesting. Not just the original line and column number of the stack trace, but It can also get the original name of an anonymized function.
I'll read the source code further to get a better understanding on how it works.
I'll close this issue. Thank you very much


example2

int(1.99)
1
int(7.7)
7
int(7.7) + 1
8
The above does not round up

Hey Yukti, if you import math and use the ceil() function it rounds up. Is there somewhere in the documentation that says otherwise? Cuz if so I'd love to change it!
Here's your code with the ceil() function:
import math as m
print(m.ceil(1.99))
print(m.ceil(7.7))
print(m.ceil(7.7 + 1))

Closing this in the favor of above comment.
The expected behavior of int casting is to truncate the floating point which is exactly what's being done.


Update volunteers page

I've added a button like the one we had in mentorship page!

@hypha (I cannot ping


Create paragraph component

Add styles to the <p> tag.

Donde puedo ver el diseno que se requiere ?

Where can I see the design that is required?

We are creating a design on Figma and talking about it on the @Gentleman-Programming's Discord. But for now, the  will have a font-size of 16px;

This will be worked on #92


Bug: Subgraph failed with non-deterministic error: Failed to transact block operations

NFT indexing subgraph(on Rinkeby) deployed on hosted service a month ago is not working now
The subgraph worked well for a month, but it suddenly stopped indexing
Error Info on Subgraph Logs
https://thegraph.com/hosted-service/subgraph/sunny0714/madsubgraph?selected=logs
Subgraph failed with non-deterministic error: Failed to transact block operations: subgraph writer poisoned by previous error, retry_delay_s: 1800, attempt: 19

Please help me to fix this

Hey, @sunny0714
Did you solve  your problem?
I faced same problem

I am facing the same error. any help?


Dynamic Code Evaluation breaking middleware auth

I protected /gm on my site using withMiddlewareAuthRequired, like so:
pages/gm/_middleware.ts:
import { withMiddlewareAuthRequired } from '@supabase/supabase-auth-helpers/nextjs';

export const middleware = withMiddlewareAuthRequired({
  redirectTo: '/login',
});

And when I npm run build, I get these errors:
./node_modules/lodash.clonedeep/index.js
Dynamic Code Evaluation (e. g. 'eval', 'new Function') not allowed in Middleware pages/gm/_middleware

Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./pages/gm/_middleware.ts

./node_modules/lodash.isequal/index.js
Dynamic Code Evaluation (e. g. 'eval', 'new Function') not allowed in Middleware pages/gm/_middleware

Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./pages/gm/_middleware.ts

This is after putting the user context provider in _app, as well.

I just updated supabase-js and it now works - looks like @supabase/realtime-js  got patched here
"@supabase/supabase-js": "^1.33.3"

Confirmed fixed for me. Closing the issue.


Execution expired

Issue Description
In these latest months, the "Execution expired" error appears almost once out of two for action firebase_app_distribution_get_latest_release.
Configuration
firebase_app_distribution_get_latest_release(
    service_credentials_file: "../service-credentials.json",
    app: "1:xxxxxxxx:ios:xxxxxxxx"
)

Environment

Library
Version

fastlane
2.225.0

fastlane-plugin-firebase_app_distribution
0.9.1

Please elaborate. Could you supply any more details  (including the output in --verbose mode) about the "Execution expired" error?

The error message most likely comes from the timeout method, which is used by httpclient which in turn is used by the Google API client libraries.
The default send_timeout is 120 seconds and the default receive_timeout is 60 seconds.
Is it possible that your network connection is so slow that it takes more than a minute to receive a response?
Or maybe the server is very slow. Do you have an unusually large number of releases?

Sadly, obtaining the logs in debug mode it's difficult: when I release and it fails, the second retry (with the debug option) usually is ok. My connection is not slow and I have at maximun 5 releases.

Maybe you can try to run firebase_app_distribution_get_latest_release in isolation? It should be possible to run that repeatedly without any unwanted side-effects.

Closing for now. Please reopen if you have logs and need more help.


alternative keymap support?

Hi,
since my recently found keymap nirvana through keyd, I naturally looked through your projects and started using warpd as well, thanks again for making both programs! Since I'm using Dvorak, I had to alter the source code by hand so that the hint chars actually match this layout (which is of course a very ugly solution). It would be much nicer to make warpd agnostic of the currently active X keymap, in the sense that the hint-chars drawn on screen are matched with the X keysyms associated to the keys. If that would require substantial coding, how about introducing a simple translation table between drawn hint-chars and actual keys (which one would have to edit by hand)?

I've been avoiding publicizing this project too much since it still has some warts, but it is nice to see people are still discovering it independently :P.

It would be much nicer to make warpd agnostic of the currently active X keymap,

It shouldn't be too hard to do this for the English alphabet (I believe the original implementation did this), but adding proper multi language support (and making it cross platform) would involve some additional effort. It's worth noting that if you do all your remapping in keyd and keep a qwerty X map you can avoid this problem ;).

I've gone ahead and pushed a patch which should solve this for English layouts.

Thanks for the quick reply. You're absolutely right that all remapping should be done in keyd. In my case, the reason why I'm keeping a separate dvorak keymap (also in /etc/vconsole.conf)  is that I have to enter a rather long unlock-password when booting up (which I would like to do in dvorak) and don't want to fiddle with a custom initrd. As I also do my regular login via vconsole, while keyd is already running, I chose the path of least resistance and kept dvorak outside of keyd. However, I will take your answer as motivation to get dvorak into the initrd and then move all dvorak remapping from vconsole.conf and X into keyd.
I'm closing this issue for now, thanks again and have a nice weekend!

Oh, just saw your patch after my last comment, thanks so much!

I have to enter a rather long unlock-password when booting up (which I would like to do in dvorak) and don't want to fiddle with a custom initrd.

Ah, that makes sense :P. cryptsetup and the like can indeed be nuisance.

Oh, just saw your patch after my last comment, thanks so much!

I haven´t extensively tested it, so let me know how it goes. Feel free to reopen this if you encounter any issues.

I have just used it for a couple of hours and it works like a charm. Will still switch to doing all dvorak mapping in keyd now, getting dvorak into the initrd is actually rather simple (trivial modification of the stock 'keymap' hook), and it gets rid of nonstandard xorg.conf and vconsole.conf files.
Another question, not directly related: when keyd creates its virtual input device, the options in xorg.conf are not honored (i.e. the device has neither dvorak layout, nor the 'compose:menu' option, so I have to issue 'setxkbmap' explicitly after starting keyd). Is there something keyd could do (emit some event?) to make X aware that a new keyboard has been added and the options should be applied to it? This is of course not a big issue at all.

the options in xorg.conf are not honored (i.e. the device has neither dvorak layout, nor the 'compose:menu' option

What does your xorg.conf look like? The virtual device should appear as a normal keyboard bound by the described X rules. If you use setxkbmap and restart the daemon, you will lose any changes, since this is the equivalent of unplugging and re-plugging the device, but your xorg.conf rules should still be honoured.

Sorry, completely forgot to reply to this: My xorg.conf used to look like
Section "InputClass"
    Identifier "keyboard defaults"
    MatchIsKeyboard "on"
    Option "XkbLayout" "dvorak"
    Option "XKbVariant" "dvorak"
    Option "XKbOptions" "compose:menu"
EndSection

and it was actually not in xorg.conf but in the /etc/X11/xorg.conf.d directory. After moving dvorak remapping into keyd and changing the above to us-layout, the compose:menu option is still not applied after starting (or restarting) keyd, and the same is true the newly added  keypad:pointerkeys option. However, I ended up removing the file altogether and activating these two options in a keyd launcher script.

Odd, I can't seem to reproduce this. Restarting keyd whilst X is active seems to have no effect on my xorg config options (setxkbmap excepted, but this is expected).


Mercurial: check if revision is null or empty

This change is

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

downloader/src/main/kotlin/vcs/Mercurial.kt, line 74 at r1 (raw file):
Previously, sschuberth (Sebastian Schuberth) wrote…
Better extend the original code by && vcsRevision.isNotBlank() to still be able to benefit from the smart cast, and to check for blank strings, too, to be on the safe side.

Done.

Comments from Reviewable

Now the commit message needs to be adjusted, too :-) Maybe say

Mercurial: Also check that the vcsRevision is not blank

Done.

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


docs: add contributing guide

discovered these while working on #20 and #21, so thought I might as well document to help the next guy or girl

Another great PR!
Thanks for contributing!


token-2022: Make Extension::get_account_len fallible

Problem
We want to add metadata support directly in token-2022, but token-2022's extensions only support extensions whose sizes are known at compile-time.
Solution
This is going to be done in a few steps for ease of review. This step just makes ExtensionType::get_account_len fallible, so that if you put in ExtensionType::Metadata, you get an error.
Thoughts on renaming the function to make that clearer? I went the lazy route and kept it the same name, but I thought about get_static_account_len or get_account_len_with_sized, but the added words didn't seem worth it.

The rusty name for fallible methods might be something like try_get_account_len (try_get_type_len, etc).

Ooh yeah that's much better. I was fixated on the "this only works if the types are sized" bit, but try_ already helps a lot

All your feedback should be addressed


monthSelectPlugin arrow move bug

https://jsfiddle.net/tj2Lo4z7/
Your Environment

flatpickr version used: 4.6.3
Browser name and version: chrome 81.0.4044.69
OS and version: mac catalina 10.15.3

When moving the year with an arrow, the month also moves with it.
Reproduction Method :

Select a month from the calendar
Move Year to Arrow

The bug can also be implemented below.
https://flatpickr.js.org/plugins/

Same issue.


Update userguide doc and developerguide doc on features implemented

Resolves https://github.com/CS2113-AY1819S1-T16-1/main/issues/106

Coverage remained the same at 70.943% when pulling 9582ed9965664169cbc366204333869d8afaf8ac on zhicaizack:DocUpdate into bcd0898cff1c40978bf806d7410e1b64072ad3fb on CS2113-AY1819S1-T16-1:master.


Always cast database ID to int in dataloader

Shipping methods ID can be of two types:

int - when a shipping method from Saleor is used
string - when an eternal shipping method is used.

Internally string is used to pass the ID between functions, but when this happens the ShippingMethodByIdLoader fails to resolve the shipping method, as it uses integers internally. This quick-fix casts IDs to int inside the data loader, which should always resolve shipping methods from Saleor DB.
Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Hey @maarcingebala,
I believe you're fixing the issue where checkoutComplete isn't returning the deliveryMethod attribute correctly on the first send?
This actually came up in QA as an issue that was present on 3.1 since introducing external shipping methods. The main culprit is the second line here:

We're assigning a dataclass instance to a model field and it magically saved to the database due to some default casts, but maybe we should fix the origin of the error, rather than patching the data loader. The fact that a dataclass is assigned instead of the shipping method instance could have other, yet unidentified consequences in the system

Yep I saw it but wasn't sure if I can cast to int in that place, as I'm not sure how it works with external shipping methods, which doesn't have numeric IDs if I'm correct? If we are sure that we will always have a numeric value there, I'm happy to change it.

For external shipping methods checkout.shiping_method is None and the string id is kept in private metadata


Expand trailing comma implementation

This continues the work that I began in https://github.com/apple/swift-syntax/pull/2515#event-12563352688. After feedback from the language steering group I have expanded the original proposal to allow trailing comma in more places. See the updated proposal text in https://github.com/swiftlang/swift-evolution/pull/2344.

@ahoppen I've updated the PR to match https://github.com/swiftlang/swift/pull/74522.

@ahoppen Don't you prefer that I squash the commits before merging?

@swift-ci Please test

@swift-ci Please test Windows

Could you run swift-format on your changes?

@swift-ci Please test

@swift-ci Please test


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/opstest2/docs-archive-test-source.git

Docs Build status updates of commit 25d46fc:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Create LICENSE

This makes it easier to package this project in Fedora since a license must be included.

@major Do you need a new pip package/version released for that or is the presence in the repo sufficient?

Just having it in the repo is fine for now. Thanks!

Thanks for the PR to help make this acceptable for Fedora. ❤


Frontend: loading indicators are not shown correctly

System information
OS & Version: All
Browser & Version: All
Commit hash: when using checkout
Expected behavior
Loading indicator should be present on page load & when a transfer is being created inside the "Transfer Funds" button.
Actual behavior
Loading indicator is not visible in the aforementioned cases.
I believe this happened as a result of refactoring the Spinner component to use string concatenation for applying tailwind classes to the DOM elements inside the Spinner component
Reading the tailwinds docs, the classes should exist as complete strings inside the codebase so the tailwind engine can recognize and pick them up for the final bundle. More info can be found here

Update: loading indicators are now showing but only because one of the parent components of <Spinner> is assigning the border & size classes inline.
For this reason, i am removing the bug label and adding an optimization label as the code inside Spinner component needs to be refactored to avoid this behavior

#1219 fixed it


Clear all the database on new user login

Currently we are keeping database excluding User and UserDetailtables on log out. Which is problem for new login as it still shows old data for new user.
Correct approach should be keeping all the database on logout. On login if data exist check for the user id. If user id of the new user doesn't matches with existing id then clear all the database otherwise keep the same.
@iamareebjamal you may want to take up this.

Correct. Thanks for pointing out. Taking it up

Changing to this. The User and USerDetail are not cleared when the user is logged out. But when someone logs in. It is checked if the login username is different from the already saved one. And if so, then the database is cleared

login username is different from the already saved one

Are we storing email ? I think checking user id should be preferred.

We won't get user id from the login response

The email is stored with the user object and is available when the user logs in. Secondly, we won't get user ID till we fetch organizer and till then, it might be too late to delete the database


Inaccurate Best Squared Error

The overall best squared error displayed at the end of a simulation does not always seems to be entirely accurate. This bug was frequently found while simulating with populations of 3 for 3 generations.

I think the error lies within the Population class within the genetic.py module.

Indeed it was. Apparently, each chromosome was being tested for whether or not its squared error was greater than, instead of less than.


Excel export name is not correct

If I'm going to export the report as Excel I got a wyrd filename: report-name.xlsx.xls.
Why is that doubled with xlsx.xls?

Cannot reproduce the error.


Use Squeak instead of unix line endings

Squeak uses CR as line ending for all platforms.
Trivia: no major OS has used this style of line endings since the 90s, Unix uses LF, Windows CRLF

Pull Request Test Coverage Report for Build 895770117

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 18.644%

Totals

Change from base Build 892837333:
0.0%

Covered Lines:
176

Relevant Lines:
944

💛  - Coveralls


fix: release v1.16

:tada: This PR is included in version 1.15.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


⚠ ClamAV has degraded performance

In 83406f9, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 54 ms

Resolved: ClamAV performance has improved in 10b78c1.


incorrect sample for attributes

The attribute sample can't compile. There are many things wrong with it:

It doesn't seem like [attributeusage(target_runtimeclass_member)] is valid:

1>D:\dev\src\WinUIPrototype\Win32XamlHost\XamlApplication.idl(22): error MIDL2025: [msg]syntax error [context]: expecting AttributeUsageList near "target_runtimeclass_member"
1>D:\dev\src\WinUIPrototype\Win32XamlHost\XamlApplication.idl(23): error MIDL2026: [msg]cannot recover from earlier syntax errors; aborting compilation
1>Done building project "Win32XamlHost.vcxproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

If I change this to [attributeusage(target_runtimeclass)] i get passed this error and hit this:

1>D:\dev\src\WinUIPrototype\Win32XamlHost\XamlApplication.idl(25): error MIDL2025: [msg]syntax error [context]: expecting ) near "classUri"
1>D:\dev\src\WinUIPrototype\Win32XamlHost\XamlApplication.idl(25): error MIDL5074: [msg]the only special keyword that may be used in a custom attribute is "version" [context]: HelpAttribute
1>D:\dev\src\WinUIPrototype\Win32XamlHost\XamlApplication.idl(26): error MIDL2025: [msg]syntax error [context]: expecting a declarator
1>D:\dev\src\WinUIPrototype\Win32XamlHost\XamlApplication.idl(26): error MIDL5063: [msg]the custom attribute definition contains a field th

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2dacbdf2-172f-dd41-829f-94295cd0c621
Version Independent ID: b511accc-e0b1-9b30-d044-231d5204024d
Content: Introduction to Microsoft Interface Definition Language 3.0 - Windows UWP applications
Content Source: winrt-related-src/midl-3/intro.md
Product: uwp
Technology: winrt-reference
GitHub Login: @stevewhims
Microsoft Alias: stwhi

Hi, @stevenbrix, thanks for filing this issue. I'm looking into it, and I'll get back to you when I have info.
Thanks!
Steve


Added payload field to BuildValidationEvent to help to build inter-field dependant rules

1. Why is this change necessary?
I had troubles to make one field on registration being required or not. It was possible with a sub definition but it was a hassle. Having the data to validate on validation building is helpful for that.
2. What does this change do, exactly?
Add an optional payload field and parameter to the \Shopware\Core\Framework\Validation\BuildValidationEvent. This is done in a non-breaking manner.
3. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

I am looking for a solution to change the interface definition of \Shopware\Core\Content\ContactForm\Validation\ContactFormValidationFactory to allow passing data to it without making it a breaking change. This is the only point for the event that is not supporting the new data field yet.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-12391
Please use this issue to track the state of your pull request.

I am looking for a solution to change the interface definition of Shopware\Core\Content\ContactForm\Validation\ContactFormValidationFactory

interface DataValidationFactoryInterface
{
    /**
     * @param array $data - @deprecated tag:v6.4.0 - Will be introduced in v6.4.0
     * @param SalesChannelContext $context
     * @return DataValidationDefinition
     */
    public function create(SalesChannelContext $context /* array $data */): DataValidationDefinition;

    /**
     * @param array $data - @deprecated tag:v6.4.0 - Will be introduced in v6.4.0
     * @param SalesChannelContext $context
     * @return DataValidationDefinition
     */
    public function update(SalesChannelContext $context /* array $data */): DataValidationDefinition;
}

class ContactFormValidationFactory implements DataValidationFactoryInterface
{
    public function create(SalesChannelContext $context): DataValidationDefinition
    {
        $data = func_get_arg(1) ?? [];
        return $this->createContactFormValidation('contact_form.create', $context->getContext());
    }

    public function update(SalesChannelContext $context): DataValidationDefinition
    {
        $data = func_get_arg(1) ?? [];
        return $this->createContactFormValidation('contact_form.update', $context->getContext());
    }
    // ....
}

Thanks for the great example. I knew I've seen it somewhere but wasn't sure where exactly 😊 gonna work it out

Hey @JoshuaBehrens, is this still being worked on?

Hey @JoshuaBehrens, is this still being worked on?

It is :)

It is :)

so T-14 it is :wink:

so T-14 it is :wink:

Thank you @OliverSkroblin for the explanation but I decided against it. Reviewing the current state the ContactFormValidationFactory is the only class implementing DataValidationFactoryInterface right now that propagates the event itself. All the other callers through the event themselves. That is why my current implementation just moves the call.

Thank you @OliverSkroblin for the explanation but I decided against it. Reviewing the current state the ContactFormValidationFactory is the only class implementing DataValidationFactoryInterface right now that propagates the event itself. All the other callers through the event themselves. That is why my current implementation just moves the call.

I refactored, rebased added value to the changelog. Just tests are missing 😅

I refactored, rebased added value to the changelog. Just tests are missing 😅

Hey @JoshuaBehrens, when do you think will you be able to add these tests? Are there any open questions or did you just didn't find the time for them?

I have an assumption how to do the tests. Adding listeners via runtime end check their execution. Time... You know it :D

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://docs.shopware.com/en/shopware-platform-dev-en/contribution/contribution-guideline


D01 languageparser

Description: Add support for Java language
Issue: n/a
Dependencies: n/a
@ThatsJustCheesy please verify and accept this PR

Thanks! We will make sure to credit you for the help in the main Langchain PR.


Only capture metrics for supported ContainerImages

The OpenShift provider collects a mixture of ContainerImages some of which support metrics capture and some which do not.  We have an issue with ContainerImage class names (https://github.com/ManageIQ/manageiq/pull/21828) but even with that fixed fundamentally we are trying to capture metrics from ContainerImages which do not support it.
Fixes https://github.com/ManageIQ/manageiq/issues/21825

>> ems.container_images.count
   (0.7ms)  SELECT COUNT(*) FROM "container_images" WHERE "container_images"."ems_id" = $1 AND "container_images"."deleted_on" IS NULL  [["ems_id", 2]]
=> 363
>> ems.container_images.supporting(:capture).count
  ContainerImage Load (1.5ms)  SELECT "container_images".* FROM "container_images" WHERE "container_images"."ems_id" = $1 AND "container_images"."deleted_on" IS NULL AND "container_images"."type" = $2  [["ems_id", 2], ["type", "ManageIQ::Providers::Openshift::ContainerManager::ContainerImage"]]
  ContainerImage Inst Including Associations (119.1ms - 306rows)
=> 306

We have this handy supports feature already https://github.com/ManageIQ/manageiq/blob/master/app/models/metric/ci_mixin.rb#L23-L28 and the InfraManager::MetricsCapture class already uses it for hosts and vms, wondering if we should use this for all of the target types

Backported to najdorf in commit 5d665cdd06b9aa86062be67168434311f882715d.
commit 5d665cdd06b9aa86062be67168434311f882715d
Author: Jason Frey<EMAIL_ADDRESS>Date:   Tue Apr 26 11:13:15 2022 -0400

    Merge pull request #21829 from agrare/only_capture_metrics_supported_container_images

    Only capture metrics for supported ContainerImages

    (cherry picked from commit 32750cf7e828ebb14f235c8470a2c8653db397bd)


enable race condition checking during tests

closes https://github.com/tellor-io/telliot/issues/192

Pull Request Test Coverage Report for Build 926769503

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 4.933%

Totals

Change from base Build 926422201:
0.0%

Covered Lines:
95

Relevant Lines:
1926

💛  - Coveralls


Grouping tests runs by launch fix

and also, can we do a deployment to prod? Is it a long process?

not sure if I good it 100%, but cool!
The issue was that not all launches had the new params?

The issue was that we were returning the same launch several times, based on the amounts of test runs, so we had to group these test runs in an array inside each launch.
Basically, the db is returning something like this:

Launch
Test_Run
Counters

Launch One
Test Run One
20. 7. 13

Launch One
Test Run Two
13, 6, 7

The problem was that we were returning something like:
[
  {
   "launch": "Launch One",
   "test_runs": [
     {
        "name": "Test Run One",
        "total": 20,
        "passed": 7,
        "failed": 13
     }
   ]
  },
  {
   "launch": "Launch One",
   "test_runs": [
     {
        "name": "Test Run Two",
        "total": 13,
        "passed": 6,
        "failed": 7
     }
    ]
  }
]

So, as you can see Launch One was returned several times, which is not good...
So now we are returning this:
[
  {
   "launch": "Launch One",
   "test_runs": [
     {
        "name": "Test Run One",
        "total": 20,
        "passed": 7,
        "failed": 13
     },
     {
        "name": "Test Run Two",
        "total": 13,
        "passed": 6,
        "failed": 7
     },
    ]
  }
]

Far better :) don't you think @opishcheiko ?

I'll just merge this and publish new images for a new release


No integration test for using WS program_subscribe with a filter

I'd really like to know how to use a filter based on offset and bytes in a call to program_subscribe. Do you think you could add an integration test for this? program_subscribe has only one test so far.

I don't think we need an integration test for this but documentation would be good. We do have examples for get_program_accounts though. The filters work the same for get_program_accounts and program_subscribe


Added number of commit inspected.

Showing how many commits where inspected after the error reports would be really useful as you can check if git-cop it is running properly and what you expect (for exampel in case that your master branch is not updated). Also, in linters such as haml-lint or Rubocop this information is provided.

Good idea. I'm returning from vacation and will review your changes this evening.


MP3 Preview issue on Android SDK

Hello,
We are trying to preview mp3 file using Box SDK, The preview works fine with other files such as videos, pdf, doc, ppt, etc. However with mp3 file, it throws the following exception (although the file id is set when sending the Boxfile to the activity), the code we use to preview any file is the same:
Code:
BoxPreviewActivity.IntentBuilder builder =
BoxPreviewActivity.createIntentBuilder(getContext(), boxSharedLinkSession, boxFile);
startActivityForResult(builder.createIntent(), PREVIEW_FILE_REQUEST_CODE);
Exception:
1325-1325/com.ibm.cio.be.ppm E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.ibm.cio.be.ppm, PID: 1325
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String com.box.androidsdk.content.models.BoxFile.getId()' on a null object reference
at com.box.androidsdk.preview.fragments.BoxPreviewMediaFragment.getMediaUri(BoxPreviewMediaFragment.java:175)
at com.box.androidsdk.preview.fragments.BoxPreviewAudioFragment.initPlayer(BoxPreviewAudioFragment.java:107)
at com.box.androidsdk.preview.fragments.BoxPreviewAudioFragment.notifyFragmentLoaded(BoxPreviewAudioFragment.java:142)
at com.box.androidsdk.preview.fragments.BoxPreviewFragment.setUserVisibleHint(BoxPreviewFragment.java:145)
at android.support.v4.app.FragmentStatePagerAdapter.setPrimaryItem(FragmentStatePagerAdapter.java:157)
at android.support.v4.view.ViewPager.populate(ViewPager.java:1266)
at android.support.v4.view.ViewPager.populate(ViewPager.java:1116)
at android.support.v4.view.ViewPager.setAdapter(ViewPager.java:540)
at com.box.androidsdk.preview.BoxPreviewViewPager$4.run(BoxPreviewViewPager.java:206)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Hi can you tell us what version of the sdk you are using? Also if you are
using any android support libraries the versions of those, and build tools
and target of your app? Finally are you using any snapshots from maven, or
do you have a reference to the repo. I wqnt to make sure you are not using
on of our snapshots.
On May 14, 2017 4:06 AM, "RosalineMakar"<EMAIL_ADDRESS>wrote:

Hello,
We are trying to preview mp3 file using Box SDK, The preview works fine
with other files such as videos, pdf, doc, ppt, etc. However with mp3 file,
it throws the following exception (although the file id is set when sending
the Boxfile to the activity), the code we use to preview any file is the
same:
Code:
BoxPreviewActivity.IntentBuilder builder =
BoxPreviewActivity.createIntentBuilder(getContext(),
boxSharedLinkSession, boxFile);
startActivityForResult(builder.createIntent(), PREVIEW_FILE_REQUEST_CODE);
Exception:
1325-1325/com.ibm.cio.be.ppm E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.ibm.cio.be.ppm, PID: 1325
java.lang.NullPointerException: Attempt to invoke virtual method
'java.lang.String com.box.androidsdk.content.models.BoxFile.getId()' on a
null object reference
at com.box.androidsdk.preview.fragments.BoxPreviewMediaFragment.
getMediaUri(BoxPreviewMediaFragment.java:175)
at com.box.androidsdk.preview.fragments.BoxPreviewAudioFragment.
initPlayer(BoxPreviewAudioFragment.java:107)
at com.box.androidsdk.preview.fragments.BoxPreviewAudioFragment.
notifyFragmentLoaded(BoxPreviewAudioFragment.java:142)
at com.box.androidsdk.preview.fragments.BoxPreviewFragment.
setUserVisibleHint(BoxPreviewFragment.java:145)
at android.support.v4.app.FragmentStatePagerAdapter.setPrimaryItem(
FragmentStatePagerAdapter.java:157)
at android.support.v4.view.ViewPager.populate(ViewPager.java:1266)
at android.support.v4.view.ViewPager.populate(ViewPager.java:1116)
at android.support.v4.view.ViewPager.setAdapter(ViewPager.java:540)
at com.box.androidsdk.preview.BoxPreviewViewPager$4.run(
BoxPreviewViewPager.java:206)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(
ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/box/box-android-preview-sdk/issues/11, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAmHYti056nGCEkSiZW2Xhti_S4C-rW7ks5r5uArgaJpZM4NaWD8
.

Hi,
Kindly find below the details you are asking for:
Preview SDK from Maven: compile 'com.box:box-android-preview-sdk:2.0.3'
buildToolsVersion: 25.0.2
Target SDK version: 25
android support:
compile 'com.android.support:cardview-v7:25.2.0'
compile 'com.android.support:appcompat-v7:25.2.0'
compile 'com.android.support:support-v4:25.2.0'
compile 'com.android.support:design:25.2.0'

Thanks.  I believe you are running into an issue due to our sdk being
incompatible with the newer android support libraries cause certain code to
be called in a different order. We will release a new version of the sdk
that will fix this shortly.
On May 14, 2017 9:35 AM, "minaEweida"<EMAIL_ADDRESS>wrote:

Hi,
Kindly find below the details you are asking for:
Preview SDK from Maven: compile 'com.box:box-android-preview-sdk:2.0.3'
buildToolsVersion: 25.0.2
Target SDK version: 25
android support:
compile 'com.android.support:cardview-v7:25.2.0'
compile 'com.android.support:appcompat-v7:25.2.0'
compile 'com.android.support:support-v4:25.2.0'
compile 'com.android.support:design:25.2.0'
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/box/box-android-preview-sdk/issues/11#issuecomment-301324013,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmHYt-uLq8exXxSEKYiP_ZXr2E35YPvks5r5y1ngaJpZM4NaWD8
.

Thanks for your reply

I just published 2.0.4 of the preview sdk to maven. It may take a while to
be updated, but hopefully should solve your issue.
On May 14, 2017 10:47 AM, "minaEweida"<EMAIL_ADDRESS>wrote:

Thanks for your reply
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/box/box-android-preview-sdk/issues/11#issuecomment-301328211,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmHYlwzYUGDeP4Q8vGI9-KXmk0J_Kdmks5r5z4kgaJpZM4NaWD8
.

@doncung Thank you very much for the fix. It works fine now.


Vulkan: Environment fog's Sun Scatter isn't fully drawn over the background sky

Godot version: master Git 92d4deeda
OS/device including version: Fedora 33, GeForce GTX 1080 (NVIDIA 455.45.01)
Issue description:
The Fog Sun Scatter property isn't fully drawn over the sky, which breaks the illusion of the fog smoothly fading into the sky even if Aerial Perspective is set to 1:
Aerial Perspective: 1
Sun Scatter: 1

Sun Scatter: 0

Aerial Perspective: 0
Sun Scatter: 1

Sun Scatter: 0

If you set Sun Scatter to a very high value, you'll notice that it is being drawn over the background sky, but not strongly enough.

If this can't be fixed, this should be documented in the class reference.
I'm using a PhysicalSkyMaterial on all the above screenshots, but I can also reproduce this issue when using ProceduralSkyMaterial.
Steps to reproduce:

Create a new project.
Add a MeshInstance with a large PlaneMesh.
Edit default_env.tres in the FileSystem dock, add a Sky (PhysicalSkyMaterial or ProceduralSkyMaterial) then enable fog and sun scatter.

Minimal reproduction project: N/A

I'm not sure this is a bug. Sun scatter is impacted by the distance from the sample to the viewer. So it looks different on objects in the foreground vs the background.

Closing per the above comment.

I'm not sure this is a bug. Sun scatter is impacted by the distance from the sample to the viewer. So it looks different on objects in the foreground vs the background.

Is it? I made a hemisphere with a 4000m radius/height and set up a camera with a 4000m far plane. Here's fog with Sun Scatter set to 1 with the hemisphere:

And here it is without the hemisphere:

If I understood the comment correctly, the results should be equivalent.
Actually, after playing around, I realized that for whatever reason the sun doesn't affect the sky at all. I increased the Sun Scatter to 1000 and disabled the glow effect, and it doesn't affect the sky at all:

Tested on Godot 4.1.1, Forward+ renderer, Fedora Linux 38, AMD Radeon RX 570 8GB

UPD: So, apparently it works just fine when using PhysicalSky, which is odd


Fixed incorrect documentation with .click() calls

to: @ljharb
Fixing issue https://github.com/airbnb/reagent/issues/39

simulate(LGTM)

Not sure how/why code coverage decreased here. Merging anyway.


Add IPv6 support

Specified in RFC2428

EPSV is implemented. I don't thing EPRT will be needed ever, so I'm skipping it.


Expose metric kind from index_dense_gt

Wrong target branch, sorry.

@rschu1ze, no worries at all 🤗


Dependabot not resolving proper python version for project

Package ecosystem
Python 3.6.10 with Poetry 1.1.8

What you expected to see, versus what you actually saw

We expect dependabot to respect our pyproject.toml python version which is strictly set to 3.6.10. We also added a .python-version file to the repo but no luck.

Images of the diff or a link to the PR, issue or logs

🕹 Bonus points: Smallest manifest that reproduces the issue

WIP
Output logs:
updater | INFO <job_202563193> Finished job processing
updater | time="2021-09-14T17:39:18Z" level=info msg="task complete" container_id=job-202563193-file-fetcher exit_code=0 job_id=202563193 step=fetcher
updater | I, [2021-09-14T17:39:19.182633 #8]  INFO -- sentry: ** [Raven] Raven 3.1.2 ready to catch errors
updater | warning: parser/current is loading parser/ruby27, which recognizes
updater | warning: 2.7.4-compliant syntax, but you are running 2.7.1.
updater | warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
updater | INFO <job_202563193> Starting job processing
updater | INFO <job_202563193> Starting update job for Rippling/rippling-main
updater | INFO <job_202563193> Checking if django 1.9 needs updating
  proxy | 2021/09/14 17:39:30 [048] GET https://pypi.org:443/simple/django/
  proxy | 2021/09/14 17:39:30 [048] 200 https://pypi.org:443/simple/django/
updater | INFO <job_202563193> Latest version is 3.2.7
updater | INFO <job_202563193> Handled error whilst updating django: dependency_file_not_resolvable {:message=>"Dependabot detected the following Python requirements for your project: '[[#<Dependabot::Python::Requirement:0x000055fa66a3e830 @requirements=[[\"=\", #<Dependabot::Python::Version 3.6.10>]]>], [#<Dependabot::Python::Requirement:0x000055fa66a3e0b0 @requirements=[[\"=\", #<Dependabot::Python::Version 2.7.11>]]>]]'.\n\nCurrently, the following Python versions are supported in Dependabot: 3.9.6, 3.9.5, 3.9.4, 3.9.3, 3.9.2, 3.9.1, 3.9.0, 3.8.11, 3.8.10, 3.8.9, 3.8.8, 3.8.7, 3.8.6, 3.8.5, 3.8.4, 3.8.3, 3.8.2, 3.8.1, 3.8.0, 3.7.11, 3.7.10, 3.7.9, 3.7.8, 3.7.7, 3.7.6, 3.7.5, 3.7.4, 3.7.3, 3.7.2, 3.7.1, 3.7.0, 3.6.14, 3.6.13, 3.6.12, 3.6.11, 3.6.10, 3.6.9, 3.6.8, 3.6.7, 3.6.6, 3.6.5, 3.6.4, 3.6.3, 3.6.2, 3.6.1, 3.6.0, 3.5.10, 3.5.8, 3.5.7, 3.5.6, 3.5.5, 3.5.4, 3.5.3."}
updater | INFO <job_202563193> Finished job processing
updater | time="2021-09-14T17:39:31Z" level=info msg="task complete" container_id=job-202563193-updater exit_code=0 job_id=202563193 step=updater

relates to: https://github.com/dependabot/dependabot-core/issues/1455
I'm curious if there's anyway to get more debug logs from dependabot runs for this. We have a large amount of dependencies so I would like to know where it's inferring python2.7 from.

I was able to debug this locally by running dependabot-core in a docker container. Turns out we had a old runtime.txt file. Removing that fixed this error.


Revert "MTV-1656 | Disable snapshot consolidation"

Reverts kubev2v/forklift#1193
as this causes further issues https://issues.redhat.com/browse/MTV-1681

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 15.65%. Comparing base (baee077) to head (1938f92).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

pkg/controller/plan/adapter/vsphere/client.go
0.00%
4 Missing :warning:

pkg/controller/plan/migration.go
0.00%
2 Missing :warning:

pkg/controller/plan/adapter/openstack/client.go
0.00%
1 Missing :warning:

pkg/controller/plan/adapter/ova/client.go
0.00%
1 Missing :warning:

pkg/controller/plan/adapter/ovirt/client.go
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   15.68%   15.65%   -0.04%
==========================================
  Files         112      112
  Lines       23075    23071       -4
==========================================
- Hits         3620     3612       -8
- Misses      19167    19174       +7
+ Partials      288      285       -3

Flag
Coverage Δ

unittests
15.65% <0.00%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Use substitution (Fn::Sub) in VTL Resolvers files - make the Appsync BatchGetItem resolver usable

Is your feature request related to a problem? Please describe.
We can't correctly use all the "Batch*Item" functions in AppSync custom resolvers as they all require passing the table name in the returned object
This can be seen here
Describe the solution you'd like
To be able to use the API tables in the VTL file, I'd like to be able to write things like this in the VTL templates:
{
"version" : "2018-05-29",
    "operation" : "BatchGetItem",
    "tables" : {
        "${UserTable}": {
          "keys": {

Notice the UserTable variable
This issue doesn't depend on AppSync as it is just an Amplify CLI build improvement - therefore it should hopefully be solvable pretty quickly for people who just want to use the BatchGetItem operation.
Describe alternatives you've considered
We tried to write a custom resolver in a YAML template and to use directly the RequestMappingTemplate attribute, to take advantage of Fn::Sub.
Resources:
  QueryHelloTestResolver:
    Type: AWS::AppSync::Resolver
    Properties:
      ApiId: !Ref 'GraphQLApiID'
      DataSourceName: UserTable
      TypeName: Query
      FieldName: helloTestResolver
      RequestMappingTemplate: !Sub
        |
          {
            "version" : "2018-05-29",
            "operation" : "BatchGetItem",
            "tables" : {
                "${UserTable}": {
                  "keys": {
          }
        - UsersTable: !Sub ['Users-${ApiId}-${env}, { ApiID: '!Ref 'GraphQLApiID', env: !Ref 'env' }]

That would have been acceptable, but YAML templates are not supported for custom resolvers.
We also considered using a serverless-plugin to generate the VTL files, but it's very heavy to switch to serverless just for an issue like that.
We're currently trying to do the same in JSON, but as you can guess it will be a very ugly and hard to maintain template.
Additional context
We're surprised to see BatchGetItem not being supported by Amplify as it is a pretty basic need. Maybe we missed a simple solution. If not, we hope to be listened on that very basic need as our production product relies on it. This is not a fancy need, we just want to create a basic pipeline resolver.

Thanks for the feature request.

This may related to my feature request.
https://github.com/aws-amplify/amplify-cli/issues/6616
The table name could be generated automatically, and inserted in to the VTL as a simple variable
## [meta data given by Amplify.js]
#set( $tableName = "xxx")

... the reset of your VTL


[1.5] update pytorch-lightning to v1.5.9 and revert pydeprecate to v0.3.1

Checklist before submitting

[x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description

update pytorch-lightning to v1.5.9
revert pydeprecate to v0.3.1
update the pydeprecate pin in lightning recipe.
https://github.com/open-ce/open-ce/issues/584

Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

This fixes the pydeprecate part of the pip issue - https://github.com/open-ce/open-ce/issues/587


Issue#46 fixed "Added brand logo on navbar and footer.

INCLUDE ALL NECESSARY FIELDS AND DELETE FIELDS THAT ARE NOT NECESSARY.
Description
Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.
Fixes # [ISSUE]
Type of Change:
Delete irrelevant options.

Code
Quality Assurance
User Interface
Outreach
Documentation

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.


fix: send periodic keepalive packets on eventstream connections

When Argo is operating behind load balancers / ingress controllers that have
an idle timeout configured, it's not uncommon to get disconnected and have
an error shown in the UI if you're looking at a relatively inactive workflow
or workflow list.
In the SSE spec, :\n is a sequence that you can send to the client which
should be ignored by the client, so we can use that to periodically send
something in the response without affecting the code in the UI at all.
Fixes #5006
Signed-off-by: Daniel Herman<EMAIL_ADDRESS>

Closing this for the moment while I'm debugging an error I just found.


Add compliance policy for empty name and version

Adds a new compliance configuration to handle what to do when there is a missing name or version:
compliance:
  # action to take when a package is missing a name (env: SYFT_COMPLIANCE_MISSING_NAME)
  missing-name: 'drop'

  # action to take when a package is missing a version (env: SYFT_COMPLIANCE_MISSING_VERSION)
  missing-version: 'drop'

Above are the default values, but the possible values a user can put in are:

keep, add a trace log but the non-compliant package is still added to the SBOM
warn, add a warn log but the non-compliant package is still added to the SBOM
fail, return an error, stop cataloging, do not produce an sbom, and results in a syft return code 1
drop, exclude the package from results, add a debug log
stub, replace the non-compliant empty value with UNKNOWN

Open questions:

configuration-wise should this land within the pkgcataloging package? (instead of the cataloging package?)

Closes #2132
Closes #2652
Closes #2038
Closes #2039

One observation: once the known-unknowns lands perhaps some of these options would go away / change? E.g. a user could surface something in the files section with something like:
/package.json
  unknowns: dropped package due to missing name

Wouldn't both be valuable? That is, dropping the package from the SBOM but also listing the file in the SBOM with potential issues?
Does the known-unknowns PR filter package with empty name/version values? I thought it was capturing unknown reasons directly to files and that was it, but I might be missing something.

I think the config placement and package organization is correct here from and API standpoint so 🟢 from me. Was there any other discussion you wanted @wagoodman on this PR?


Transform attribute giving error in IE8

I am trying to render a force layout using R2D3 in IE 8.
node.attr("transform", function(d) {
                return "translate(" + d.x + "," + d.y + ")";
            });

Inside the force tick() method when I call transform for the node I get this error:Arg: Illegal input string in Vector2D at line 4793 skew.offset = matrix.offset() in the r2d3.js. Problem what I see here is IE8 browser engine is not able to read the large numbers which are returned by this translate method. I am not able to understand how are this large numbers returned by the translate method which should ideally return each nodes x and y position.

Hi there,
This project is no longer being maintained so this issue is being closed. Thank you for using r2d3 and taking the time to report this issue.


Upgrade DataFusion to 21.0.0

Which issue does this PR close?

Upgrade DataFusion to 21.0.0
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Thanks @r4ntix. How about extracting the feature based store into a single method, like the following does
https://github.com/yahoNanJing/arrow-ballista/blob/84a98d73a164b655b80f4391611de4c499b27f73/ballista/core/src/utils.rs#L105-L179?

Thanks @r4ntix. How about extracting the feature based store into a single method, like the following does https://github.com/yahoNanJing/arrow-ballista/blob/84a98d73a164b655b80f4391611de4c499b27f73/ballista/core/src/utils.rs#L105-L179? Then we can separate the get and register logic.

@yahoNanJing thanks for the feedback. i will submit a new commit for it a little later.


Freecam combo axis

The new movement customizability features are great!
Wondering what you think on this one. I personally like having an easy way to switch between sets of axis movements. Since Combo + LStick is effectively doing the same as LStick, I thought it might be a good idea to have an alternate axis set on LStick if Combo is held down. If the behavior is undesired then one can simply set the move axes settings to be the same axes.

Makes sense to me, and all the code/documentation looks good. Merging!


Cryptography docs

Describe the bug

Documentation for the cryptography library is returning a 403 Forbidden error.
Expected behavior

View and/or download package documentation
To Reproduce

goto https://cryptography.io/
My Platform

Page inaccessible from both Chrome and Firefox on Windows 10
Additional context

Hi, this issue tracker is for issues with the codebase behind https://pypi.org itself, not the projects hosted on PyPI.
You should report this issue to the tracker for the project in question instead: https://github.com/pyca/cryptography/issues


[4pt]  Fetch rockets - Fetch data

Fetch data from the Rockets endpoint  (https://api.spacexdata.com/v3/rockets) when the application starts (as Rockets is the default view).
Once the data are fetched, dispatch an action to store the selected data in Redux store:

id
name
type
flickr_images

NOTE: Make sure you only dispatch those actions once and do not add data to store on every re-render (i.e. when changing views / using navigation).

https://github.com/oluwatobi-fasasi/react-group-project/pull/30


Question

Good morning and thanks for all of this. I have been to the personal website indicated and was impressed by the results. I have two questions:

Can the pre-trained models been used to effectively remove the background for 20+ megapixel portraits?
I am just a user. Is there an instruction how to install this on a Unix machine or (preferably) a Mac and use it from the command line? Alternatively, is there a Docker image with an API or a Web interface (preferably an API).

Thank you again, also for helping here.

I took the `ìnference.pyfrom the Docker image mentioned in the documentation - which worked after installingtorchand other things in the runtime environment of my M1 MacBook. What does not work out of the box is any non-images in the input directory, such as .DS_Store``. If the Python script only looked for JPG/PNG, it would be perfect.
Would it be possible to add a working `ìnference.py`` to the project (like in the Docker image) and a brief description to run stuff locally?


Use VirtualTimeScheduler

The PR adds usage of the VirtualTimeScheduler which allows tests that wait for timeout periods to elapse to run instantaneously.

I'm excited about this!!!


Scopes

Given a login-with instance how could an application request additional scopes for the authorisation request?
Should we allow this?
I work for a streaming site that has a lot of varied scopes, sometimes just having the user's record isn't enough.
I've taken a stab at this here: https://github.com/ProbablePrime/login-with/commit/a6e0d305da32521e02150215e4aba7890c7edc27 but wanted to open an issue before the PR to see if this was something that would be welcome.

Great! Supporting scopes totally makes sense. PR is very welcome :)

Opening a pr :)

Closing out this one due to #23


Migrate to GitHub Actions for CI

Following up on conversation in #820 - Travis CI currently isn't running on new commits, looks like migrating to GitHub Actions might be worthwhile.
Opening an issue for easier tracking, will try to work on this in the next few days

Done, should be fixed now!

@mweststrate sorry for the delay! Had to go out of town for the weekend, was going to take a look at this today but looks like you beat me to it 😅
Just rebased #820 and it still looks like tests aren't running, just the Netlify deploy. Maybe just needs a new PR / commit?
Also interestingly, it looks like the release job tried to run on my fork after updating from upstream. It failed since I don't have semantic-release correctly configured - I wonder if there's way to disable that job on forks? https://github.com/chrissantamaria/immer/runs/2992235778

Just rebased #820 and it still looks like tests aren't running, just the Netlify deploy. Maybe just needs a new PR / commit?

That is because Github doesn't run github actions automatically anymore for first-time contributors to a repo, so a maintainer has to kick it off manually for the first time. (Thank you bitcoin miners :-/)

Also interestingly, it looks like the release job tried to run on my fork after updating from upstream. It failed since I don't have semantic-release correctly configured - I wonder if there's way to disable that job on forks? https://github.com/chrissantamaria/immer/runs/2992235778

I added a check, probably won't work the first time, lol :-P

It actually did work 😄  thanks for the fix!


Connect with Openfire 4.1.3

Hi,
When I tried to connect with the last version of stanza.io with Openfire 4.1.3 , I'm receiving no-authenticated. I'm using bosh:
stanza.io
openfire  <stream:features><mechanisms xmlns="urn:ietf:params:xml:ns:xmpp-sasl"><mechanism>PLAIN</mechanism><mechanism >SCRAM-SHA-1</mechanism><mechanism>EXTERNAL</mechanism><mechanism>CRAM-MD5</mech anism><mechanism>DIGEST-MD5</mechanism></mechanisms><register xmlns="http://jabber.org/features/iq-register"/><bind xmlns="urn:ietf:params:xml:ns:xmpp-bind"/><session xmlns="urn:ietf:params:xml:ns:xmpp-session"><optional/></session></stream:featu res>
stanza.io <auth xmlns="urn:ietf:params:xml:ns:xmpp-sasl" mechanism="EXTERNAL"></auth>
stanza.io
openfire  <failure xmlns="urn:ietf:params:xml:ns:xmpp-sasl"><not-authorized/></failure>

I answer my own question. Openfire offers different protocols for validation and EXTERNAL does not work fine. I have disabled this method in sasl mechanisms, you can do this adding this server property:
sasl.mechs      PLAIN
DIGEST-MD5
CRAM-MD5
SCRAM-SHA-1
This solution is also applicable is you are using Kaiwa, because Kaiwa uses this stack


Provide an option to specify user provided docker options

Right now storage options for docker are read from /etc/sysconfig/docker-storage. And this file is created by docker-storage-setup. There is no way a user can provide its own storage options to docker during first start itself.
For example, if one wants to specify dm.basesize or dm.fs or dm.mountopt, one can do it only after docker-storage-setup has run once. Some of these options like dm.basesize need to be specified during first run itself.
So provide a new option for docker-storage-setup, say USER_DOCKER_OPTIONS which will take an option string from user and simply append it to finally generated DOCKER_STORAGE_OPTIONS

This is fixed now.


Devcontainers/Codespaces: automate GitHub App creation

Continuing on #1236 and #1671.
The server requires a valid GitHub App configuration to even boot.
We should try to automate this as much as possible (or maybe get rid of it)?
GitHub does provide a way for the user to add Codespace secrets via via https://github.com/settings/codespaces

Maybe we could leverage the App Manifest flow for this: https://docs.github.com/en/apps/sharing-github-apps/registering-a-github-app-from-a-manifest
Basically, we build a URL containing the manifest for our GitHub app. We should redirect the user to this URL, and after they submit the app creation, they are redirected back to another URL with a temporary code (similar to OAuth2). At that point, we could retrieve the app's secret and set it in .env.

@frankie567 That's really cool, I didn't know that App Manifests existed 🤯 Thanks for sharing!

Fixed by #1701 and #1678


acdsee photo studio 2022 crack latest

https://pcappcrack.com/acdsee-photo-studio-ultimate-crack/[](url)

SPAM!!!


[fix] repair a bug: Sometimes we will get a big chunk when use splitOneUnevenlySizedChunk

when use splitOneUnevenlySizedChunk, sometimes we will get a big chunk. For example when the value of primaryKey like ['0000','1111','2222','3333','4444','aaaa','bbbb','cccc','dddd','ZZZZZ',...] almost all of the values which starts with a [a-zA-z] will be split into a big chunk

When a table in mysql, the result of  select 'a' >'Z' is false   , but in java, 'a'.compareTo('Z') > 0

Please resolve the conflicts and add some ut cases for it.

Please resolve the conflicts and add some ut cases for it.

qwq! Sorry, I will close this PR,  there are some problems,  when a mysql use "utf8mb4_general_ci" but a table/database use "utf8mb4_bin", the data in table test likes:
| field1 |
| aaaa |
| bbbb |
| ZZZZ |
SELECT MAX(field1) FROM test  will get "bbbb",
but SELECT STRCMP('bbbb', 'ZZZZ') will get -1,  because the collation and Case-Sensitive， i will find other ways to deal with this problem.

a new pull request is https://github.com/ververica/flink-cdc-connectors/pull/2963 to fix this bug

Please resolve the conflicts and add some ut cases for it.

qwq! Sorry, I will close this PR, there are some problems, when a mysql use "utf8mb4_general_ci" but a table/database use "utf8mb4_bin", the data in table test likes: | field1 | | aaaa | | bbbb | | ZZZZ |
SELECT MAX(field1) FROM test will get "bbbb", but SELECT STRCMP('bbbb', 'ZZZZ') will get -1, because the collation and Case-Sensitive， i will find other ways to deal with this problem.

please how do you fix it? i have same question.

Please resolve the conflicts and add some ut cases for it.

qwq! Sorry, I will close this PR, there are some problems, when a mysql use "utf8mb4_general_ci" but a table/database use "utf8mb4_bin", the data in table test likes: | field1 | | aaaa | | bbbb | | ZZZZ |
SELECT MAX(field1) FROM test will get "bbbb", but SELECT STRCMP('bbbb', 'ZZZZ') will get -1, because the collation and Case-Sensitive， i will find other ways to deal with this problem.

please how do you fix it? i have same question.

I has added a method to compare the value through sql to repair this problem,  the pr is  #2968


Error: params should include "fields" and/or non-empty "data" array of objects

copy\paste example and Error..  node 4,6,8 macos
const json2csv = require('json2csv');
const fs = require('fs');
const fields = ['car', 'price', 'color'];
const myCars = [
  {
    "car": "Audi",
    "price": 40000,
    "color": "blue"
  }, {
    "car": "BMW",
    "price": 35000,
    "color": "black"
  }, {
    "car": "Porsche",
    "price": 60000,
    "color": "green"
  }
];
const csv = json2csv(myCars, { fields });

console.log(csv);

The documentation in Github is for the next release, 4.0, which will introduce a lot of changes and goodness.
For the current release, you should follow the instructions in npm.
The main change is that instead of const csv = json2csv(myCars, { fields }); you should do const csv = json2csv({ data: myCars, fields });

@udanpe please confirm if that was your issue.

just used the library & const csv = json2csv({ data: myCars, fields }); helped. thanks mate!

I'll keep this open until the 4.0 release in case anyone else gets into the same confusion.

@juanjoDiaz
const csv = json2csv({ data: myCars, fields });
Its works. Thanks.

What about quotes? How its works?
const csv = json2csv(myCars, { fields, quote: '' });
const csv = json2csv({ data: myCars, fields, quote: '' });

v4.0.0 released


Documentation for running sensu-flow on Bitbucket pipelines.

I'm using it in the way described in this pull request at work. If the documentation is acceptable, I'd really like to add it here.
This would be resolved by #40

I called my branch js/add-bitbucket-docs because I thought it was some kind of naming convention (after looking at the Gitlab request), but js stands for "Jef Spaleta," doesn't it?

it does indeed.
closing..as ive merged the pr.


[ASSETS-36125] Update SVG creation logic

Description
We had some logic for default sizes of SVG files that only took width into account. This PR updates this logic to look at both width and height when picking (default) sizes for rendition generation.
Fixes # ASSETS-36125
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have ~added~ updated tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report
Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 55.35%. Comparing base (49d52a1) to head (3361e8c).
Report is 1 commits behind head on master.

Files	Patch %	Lines
lib/postprocessing/image.js	0.00%	8 Missing ⚠
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

Covered in the worker tests!


Vertical phonons producing NaNs in spherical shells with quadratic gradients

Phonons trending exactly vertically (towards or away from model center) in SphereShell cells with radial quadratic velocities have infinite arc radius (they follow straight lines).  This is actually handled by falling back to the linear handlers used for uniform-velocity SphereShells, which gives correct answers for distances, and then a special case solver is used for travel times.  The math seems right, and gives correct answer for roughly 49 out of every 50 phonons simulated, but about 1 in 50 picks up a NaN somewhere and "gets stuck".  Haven't figured out where this is happening yet except I think it has it's origins in SphereShell::GetRayArc_RD2(), where a check for verticality is (sometimes) failing to trigger, and and the intended sentinel value for Ray.Center isn't getting assigned. But again, no idea why.
The good news is these perfectly vertical phonons are exceedingly rare in practice, and are only statistically likely to produce a NaN.  (In fact, I've only been able to test them by force injecting them — haven't actually seen one in the wild.)  Still, I'm not quite comfortable with the chance that one of these could scuttle a simulation that is potentially hours or days into computing.
So... need to track down and squash.

Note: with issue #8, these phonons are now trapped and killed, without halting the simulation, making this even less of a concern (aside from the burning curiosity about what's actually causing it).


Add byte array literal and xml attribute access expression parsing

Purpose

Add byte array literal and xml attribute access expression support

Fixes #23271
Fixes #23269
Approach

N/A

Samples

N/A

Remarks

N/A

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #23497 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23497   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe66df...7a138b1. Read the comment docs.


handle can run when endpoint functions are not exported

Describe the bug
Empty .js or .ts file that does not export any endpoint functions (eg. GET) can still trigger handle.
Reproduction
Used<EMAIL_ADDRESS>and SvelteKit demo app template.
Prerequisite
Log request method and pathname in the beginning of the handle function.
export const handle: Handle = async ({ event, resolve }) => {
	const { request: { method }, url: { pathname } } = event;
	console.log(method, pathname);
...

Control Group
Run vite dev, open /, then navigate to /about.
  VITE v3.0.2  ready in 205 ms

  ➜  Local:   http://localhost:5174/
  ➜  Network: use --host to expose

GET /

Experimental Group
Create a blank about.ts file alongside about.svelte
├── __layout.svelte
├── about.svelte
├── about.ts // Created
├── index.svelte
└── todos
    ├── _api.ts
    ├── index.svelte
    └── index.ts

Run vite dev, open /, then navigate to /about.
  VITE v3.0.2  ready in 199 ms

  ➜  Local:   http://localhost:5174/
  ➜  Network: use --host to expose

GET /
GET /about

GET /about is logged in the experimental group only.
System Info
System:
  OS: macOS 12.4
  CPU: (8) arm64 Apple M1
  Memory: 92.70 MB / 8.00 GB
  Shell: 5.8.1 - /bin/zsh
Binaries:
  Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
  npm: 8.5.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
Browsers:
  Chrome: 103.0.5060.134
  Firefox: 102.0
  Safari: 15.5

Severity
annoyance

Hooks run for every request that reaches the server, regardless of whether there's an endpoint involved. This is expected behavior, unless I've misunderstood?

@Rich-Harris Is there a reason why GET /about is not logged in the control group?
I was expecting a consistent behavior regardless of an empty routes/about.ts file.

It's easier to answer why it IS logged in the experimental group first. It's because about.ts is a page endpoint for about.svelte. When visiting /about, about.svelte sends a GET request to the server automatically (this request will fail since there's no GET handler implemented, but it has to go through handle first).
This should make the lack of logging obvious: When client-side navigating to /about when no about.ts is present, no GET request for the page endpoint is fired. (There may or may not be a GET request for the page content, but that doesn't cause handle to run because it's client-side navigation.) I'd bet if you hard reloaded or navigated to /about directly, you'd see a log.
I don't believe there's an issue here.

@tcc-sejohnson I was expecting endpoint requests to be made only when there is a matching request handler function.
Since there is no GET request handler exported from the about.ts (experimental group), I was expecting a client-side navigation, just like in the control group. (when opening / and then navigating to /about)
Opening /about directly or hard reloading the page does log GET /about in both cases.

Shouldn't Page Endpoint requests be made only when there is a matching request handler function? (e.g. GET)

I was expecting Page Endpoint requests only when there is a matching request handler function.

The client has no idea what functions are exported from the server AFAIK. The existence of a matching .ts file determines whether the page gets built with a page endpoint.

Since there is no GET request handler exported from the about.ts (experimental group), I was expecting a client-side navigation, just like in the control group. (when opening / and then navigating to /about)

You are getting client-side navigation. It's just that your page is making a fetch request to its page endpoint for data because you put a matching .ts file in there. That fetch request is what's triggering handle.

Opening /about directly or hard reloading the page does log GET /about in both cases.

Yep, expected.
TL;DR: Don't create a matching .ts file if you don't want your page to try to fetch from its page endpoint.

@tcc-sejohnson Thank you for the replies. I had misconceptions about how a page gets built with a page endpoint.

The client has no idea what functions are exported from the server AFAIK. The existence of a matching .ts file determines whether the page gets built with a page endpoint.

I guess I should not make a .js or .ts file with a matching name.
I was using it to create a shared request handler for the child routes.

I have updated my existing comment from 'client-side navigation' to 'client-side fetch' as you commented.

FYI, files starting with an underscore in routes do not turn into routes, so that can be a good way to share logic. Also, if you rename the file to about.json.ts, it will not become a page endpoint (about.json !== about), meaning you can fetch from it: fetch('/about.json').
I mean technically you could name it anything other than literally about.ts, but it's convention to name non-page endpoints .json, since you're generally hitting them for a json document.

Creating a .ts file that starts with an underscore does not generate a RequestHandler type.
Since this file is for utility purpose only, I guess I should convert it into a standalone endpoint.
Thank you once again.


Introduce optional concept of "experiment" and ensure wandb run is resumed

I am running many different experiments and have experienced the following problems:

Each experiment is just called version_x in wandb and on disk and it is pretty much impossible to keep track of which version was which experiment.
I train many models at once and need to be able to restart any of them if they crash/run out of time etc.
Sometimes I have to stop a run and restart from scratch because I made a stupid mistake and I want to keep track of which version was the most recent in a given experiment.
I am not using the Manager infrastructure but have rolled my own setup based on bash and argparse to control the experiments. It is pretty neat! You can have a look at Agave's run.bash, experiments and configs, where the latter allows me to make configurations for both gbar (dtu cluster) and hendrix. The script can then be used like this:

For each experiment I need to be able to log both a pre-training run and fine-tuning runs in wandb and have a neat way of keeping track of these.

This PR thus proposes the following changes:

Change save dir to contain an optional subfolder named after the experiment inside the fold_x folder. In this way each experiment is one configuration of the model, while the experiment folder still contains versions. This allows us to keep track of different versions of each experiment separately.
One can easily resume the most recent version of any experiment since the save_dir folder is now unique per experiment.
Fixes wandb to have resume="must" when we are resuming a run.
If the experiment is given, wandb is grouped by experiment instead of task.
 It seems a bit wasteful to send it for each job when it doesn't change and the path to the plan is logged in the checkpoint, so I have added an optional without keyword in the lm_hparams of the relevant configs allowing one to filter out the plans or other data. It seems this might break prediction, but this is not relevant for pretrained models afaik. In agave I then do:

      config=
        ....
        | ckpt_config.lm_hparams(without=["ckpt_plans"])
        ...
        | plan_config.lm_hparams(without=["plans"])
        ...

Please don't look at this before you get back from vacation @Sllambias and @jakobamb :-)

Nice PR, good spot with the plans. I should probably look into splitting the dataset_properties and plans (which would be extremely lightweight). I don't think there would be any drawback to this.
(1) So this is two things I suppose. Structure on disk and structure on WandB.
On disk they are stored in something like “Task123/Manager123/UNet__2D/Fold_0/Version_123” which I think is quite clear, do you feel like this is ambiguous?
On WandB they are also just called version_123 but I don’t see how your PR changes this. It seems to me you’re changing the group rather than the version, no?
(2 & 3) So this is already possible to some extent by changing the manager name, but that might not always be the nicest solution so I see your problem.
My issue here is the unpredictable path, which I think is very difficult to work with in Yucca - we pretty much need to always know that we have the exact same folder structure (with varying folder names) and not have cases where we may have dir: /A/B/C OR /A/B/X/C because that will make it very difficult to work with.
I think I could see a solution in going away from PyTorch Lightning’s “version_123” format, and instead going with an “experiment_123” format. In this format experiment could default to e.g. “base_123” for standard settings while allowing something like the “experiment” (which I would prefer to be “experiment_name”) variable to change it to e.g. “adam_123”. What do you think about that?

@Sllambias I have updated the pr with the changes we discussed yesterday, so that we now always have a default experiment.

@jakobamb I am ready to merge this pr now, but I means that runs will now be stored in a new folder data/yucca/models/TaskXXX_XYZ/MODEL__XD/XYZManager__UnsupervisedPlanner/{EXPERIMENT}/fold_X/version_X instead fo data/yucca/models/TaskXXX_XYZ/MODEL__XD/XYZManager__UnsupervisedPlanner/fold_X/version_X. Does that break anything for you and would you be okay if I merged this?

from yucca.utils.files_and_folders import recursive_rename
from yucca.paths import yucca_models
recursive_rename(
yucca_models,
patterns_in_file={},
patterns_in_name={"Planner/fold": "Planner/default/fold"},
)


TaxonConstraintsEngine deprecated

From<EMAIL_ADDRESS>on February 01, 2013 17:16:26
owltools.gaf.inference.TaxonConstraintsEngine is deprecated, with a comment "There is now a taxon checks using an OWL resoner."
Where is this new taxon checker? I can't find any other class performing the same task as isClassApplicable(OWLClass, OWLClass)
Original issue: http://code.google.com/p/owltools/issues/detail?id=47

From<EMAIL_ADDRESS>on February 07, 2013 09:47:22
Hello,
the TaxonConstraintsEngine is deprecated, because it also produces false positive results. The engines uses all relations between two classes, meaning it also propagates contraints over relations, where this should not be the case.
The alternative is to use an OWL-API reasoner. Violations of taxon contraints should lead to unsatisfiable classes.
HermiT should find all violations. ELK is faster, but at the moment ELK will not find all violations, e.g. violations relying on inverse properties (part_of inverse of has_part).

From<EMAIL_ADDRESS>on February 07, 2013 14:01:03
And what about the owltools command line option --make-class-taxon-matrix? I believe it uses the owltools.gaf.inference.ClassTaxonMatrix, which itself uses the TaxonConstraintsEngine deprecated class.
Do you plan to update it so that the false positives are removed?

From<EMAIL_ADDRESS>on February 07, 2013 14:07:26
Good questions.
We have not looked at the matrix generator, yet. I'll have to talk to Chris about that.

From<EMAIL_ADDRESS>on October 21, 2013 11:31:26
TaxonConstraintsEngine can still be used - the deprecation annotation may be premature.
It will return false positives if the ontology contains relations like homologous_to, which cross organisms. So long as the user is aware of this and filters the ontology prior to using the engine it should be fine. In some cases it can be useful to err on the side of false positives.
The preferred route is to use generic OWL reasoning. This will err on the side of false negatives. Relations have to be explicitly added. E.g.
R o in_taxon -> in_taxon
Some of these are already in RO.
A disadvantage of using OWL reasoning is that more plumbing has to be done to do something like remove classes from an ontology. We essentially make a false axiom that false assumes some invalid context - e.g. organism SubClassOf only_in Aves. Then remove unsatisfiable classes. But cross-organism relations should be removed here.

From<EMAIL_ADDRESS>on October 22, 2013 08:50:13
So, would it be correct to:
i) keep only is_a and part_of relations in the ontology
ii) propagate the ..._in_taxon relations over is_a/part_of
iii) launch the TaxonConstraintsEngine
Would that be the proper way to go?

From<EMAIL_ADDRESS>on October 22, 2013 10:52:00
propagation over is_a comes from OWL semantics already, and propagation over part_of already comes from property chain axioms in the RO
This would be a conservative set. develops_from should not cross species barriers. has_part is also safe (There is a discussion to be had on viruses, gut bacteria, located_in vs part_of....)

From<EMAIL_ADDRESS>on October 22, 2013 10:56:04
the uberon release (now fixed) uses SpeciesSubsetterUtil, which uses OWL reasoning to exclude classes.
From the javadoc:

This implements species subsetting (module generation) using
OWL reasoning.

The procedure is

to assert

 Thing SubClassOf in_taxon some My-taxon-of-interest

Remove all unsatisfiable classes.

This is a somewhat brutal way of doing things. A more
elegant approach would be to test every class (C in_taxon some T),
but this would be a little slower. But it avoids stating falsehoods.

The current approach requires removing all taxon-crossing
relationships first to avoid removing too many
(e.g. if C is unsatisfiable, then homologous_to some C is
also unsatisfiable, we don't want to remove the homologs).

A few of these are hardcoded in the module, but the user
should be careful to remove others depending on their ontology.

See: https://github.com/obophenotype/uberon/wiki/Taxon-constraints

From<EMAIL_ADDRESS>on October 22, 2013 11:35:07
Questions:
line 87:
Set props = new HashSet();
props is never used, I guess you wanted to obtain sub-properties of "RO:0002162"?
line 80:
IRI iri = graph.getIRIByIdentifier("RO:0002162");
In the RO, I see only RO:0002160 as a subclass of RO:0002162, and I can't find "never in taxon", is it normal?
line 117:
OWLClassExpression rx = fac.getOWLObjectSomeValuesFrom(viewProperty,
taxClass);
How are the sub-taxa taken into account? Is it the job of the reasoner? If yes, when is the reasoner fed with the NCBI taxonomy?

From<EMAIL_ADDRESS>on October 22, 2013 11:37:20
In http://berkeleybop.org/ontologies/uberon.obo , nerver_in_taxon is not related to in_taxon:
[Typedef]
id: never_in_taxon
name: never_in_taxon
def: "S never_in_taxon T iff: S SubClassOf in_taxon only not T" [PMID:20973947]
xref: RO:0002161
expand_assertion_to: "Class: < http://www.w3.org/2002/07/owl#Nothing > EquivalentTo: ?X and (RO_0002162 some ?Y)" []
is_class_level: true
is_metadata_tag: true

From<EMAIL_ADDRESS>on October 22, 2013 13:25:50
never in taxon is an annotation property (non-logical) that is expanded to an OWL expression (expand assertion to)
It makes no sense to pre-compose negation into a property in OWL. You express negation directly using OWL constructs. The current situation is something of a compromise between simple graph-like obo-like formalisms a logic language like OWL. http://oboformat.googlecode.com/svn/trunk/doc/obo-syntax.html#7

From<EMAIL_ADDRESS>on November 13, 2013 16:08:11
I manage to get SpeciesSubsetterUtil to work on small test ontologies, but not on Uberon:

using ext.owl produces some (partial) results, but no classes are filtered with the composite-metazoan. Could it be because of a cross-species relation not removed by SpeciesSubsetterUtil by default?
The code I use is at the end of this message, and I also attach the results of my test on ext.owl and composite-metazoan.owl, if you could have a look and tell me if I'm doing something wrong.

Following your previous message: and what happened to "only_in_taxon"? Is it still supposed to be used?
I see it is used in ext.owl, but not in uberon.owl, where there is only "present_in_taxon". Is there a documentation somewhere for me to understand the difference, and the evolution of these relations?

Am I supposed to obtain results on the core uberon.owl? It doesn't work on it neither.

My code:
ParserWrapper parserWrapper = new ParserWrapper();
parserWrapper.setCheckOboDoc(false);
OWLGraphWrapper uberonWrapper = new OWLGraphWrapper(parserWrapper.parse(uberonFile));
uberonWrapper.mergeOntology(parserWrapper.parse(taxslim.obo));
OWLClass taxClass = uberonWrapper.getOWLClassByIdentifier(myTaxonId);
SpeciesSubsetterUtil subSetter = new SpeciesSubsetterUtil(uberonWrapper);
subSetter.taxClass = taxClass;
subSetter.reasoner = new ElkReasonerFactory().createReasoner(uberonWrapper.getSourceOntology());
subSetter.removeOtherSpecies();
//then I get the OWLClasses in signature and build a TSV file, attached to this message.
Attachment: taxonConstraints_ext_owl.tsv taxonConstraints_composite_owl.tsv taxonConstraints_core_owl.tsv


Fix for private accounts' posts + Fix story buttons placement for verified accounts

The share button does not always appear, especially for private accounts' posts.

For normal posts, check for Like, Comment, and Save. In all cases, at least the Like and Save buttons appear.
For the independent post page, check for the save button (whether pressed or not).
Fix story buttons placement for verified accounts

Perhaps not the best implementation, but at least you don't need to depend on class names.
This way, the script will work for private accounts' posts.

Sorry, I'm busy these weeks.
Have merged it, great PR! Thanks.


Rubocop autocorrections

Enhance code quality with Rubocop autocorrections.

Looks good, thanks :)

👍 Thanks!

+1
i thought we liked trailing commas 🤔

+1
i thought we liked trailing commas 🤔

Is it not that we have them in hashes but not arrays?

My vote is for the consistency. Since our main codebase has trailing commas, I'd say we should follow the same rule here as well.

Sure, I will remove the trailing commas commit.

Dropped the commit with the removal of trailing commas in arrays.