Rollup build does not work with common 3rd party libraries

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior
When I try to use some common 3rd party library (like lodash) with the seed and run production build with Rollup:
npm run build.prod.rollup.aot

I get the following error:
[13:13:56] Finished 'build.bundles.app.rollup.aot' after 2.83 s
[13:13:56] Starting 'transpile.bundles.rollup.aot'...

/home/nyxz/dev/workspaces/js/angular-seed/node_modules/lodash/lodash.js:494
      case 0: return func.call(thisArg);
                          ^
SyntaxError: Invalid or unexpected token
    at /home/nyxz/dev/workspaces/js/angular-seed/node_modules/lodash/lodash.js:14843:16
    at apply (/home/nyxz/dev/workspaces/js/angular-seed/node_modules/lodash/lodash.js:494:27)
    at /home/nyxz/dev/workspaces/js/angular-seed/node_modules/lodash/lodash.js:15227:16
    at apply (/home/nyxz/dev/workspaces/js/angular-seed/node_modules/lodash/lodash.js:496:27)
    at /home/nyxz/dev/workspaces/js/angular-seed/node_modules/lodash/lodash.js:6600:16
    at template (/home/nyxz/dev/workspaces/js/angular-seed/node_modules/lodash/lodash.js:14842:20)
    at DestroyableTransform._transform (/home/nyxz/dev/workspaces/js/angular-seed/node_modules/gulp-template/index.js:20:14)
    at DestroyableTransform.Transform._read (/home/nyxz/dev/workspaces/js/angular-seed/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:182:10)
    at DestroyableTransform.Transform._write (/home/nyxz/dev/workspaces/js/angular-seed/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:170:83)
    at doWrite (/home/nyxz/dev/workspaces/js/angular-seed/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:406:64)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>serve.prod.rollup.aot: `gulp serve.prod.rollup.aot --color --env-config prod --build-type prod`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>serve.prod.rollup.aot script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/nyxz/.npm/_logs/2017-09-26T10_14_01_511Z-debug.log

Expected behavior
Build without error as it builds with:
npm run build.prod.aot

Minimal reproduction of the problem with instructions

➜  ~ npm install --save lodash @types/lodash

In project.config.ts:
let additionalPackages: ExtendPackages[] = [{
    name: 'lodash',
    path: 'node_modules/lodash/lodash.js'
  }];

this.addPackagesBundles(additionalPackages);

In app.component.ts:
import { Component } from '@angular/core';

import * as _ from 'lodash';

@Component({
  moduleId: module.id,
  selector: 'sd-app',
  templateUrl: 'app.component.html',
  styleUrls: ['app.component.css'],
})
export class AppComponent {
  constructor() {
    console.log('Is equal? ' + (_.isEqual({age: 1}, {age: 1})));
  }
}

Run the following to get the error:
➜  ~ npm run serve.prod.rollup.aot

NOTE:
➜  ~ npm start

runs without any error and I get the following message in the console:

Is equal? true

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Fedora 24, VS Code, NPM 5.4.1

Angular Seed Version: eace08df83f8d632a4705e29cfa492d4060b4f54

Node: node --version = v6.10.2

@nyxz sorry for the delay. The problem is from lodash's template which produces invalid JavaScript, which later tries to evaluate.
You can workaround the issue by commenting part of transpile.bundles.rollup.aot.ts:
export = () => {
  const tsProject = makeTsProject(
    {
      allowJs: true,
      noFallthroughCasesInSwitch: false
    },
    Config.TMP_DIR
  );
  const src = [join(Config.TMP_DIR, 'bundle.js')];
  const result = gulp
    .src(src)
    .pipe(plugins.plumber())
    .pipe(
      Config.PRESERVE_SOURCE_MAPS
        ? plugins.sourcemaps.init({ loadMaps: true, largeFile: true })
        : plugins.util.noop()
    )
    .pipe(tsProject())
    .once('error', function(e: any) {
      this.once('finish', () => process.exit(1));
    });

  return result.js
    .pipe(
      Config.PRESERVE_SOURCE_MAPS
        ? plugins.sourcemaps.write()
        : plugins.util.noop()
    )
-    .pipe(
-      plugins.template(
-        new TemplateLocalsBuilder().build(),
-        Config.TEMPLATE_CONFIG
-      )
-    )
+//    .pipe(
+//      plugins.template(
+//        new TemplateLocalsBuilder().build(),
+//        Config.TEMPLATE_CONFIG
+//      )
+//    )
    .pipe(plugins.rename(Config.JS_PROD_APP_BUNDLE))
    .pipe(gulp.dest(Config.JS_DEST))
    .on('error', (e: any) => {
      console.log(e);
    });
};

This will respectively disable the template replacements that we provide in JavaScript.

Yes, this fixed the issue. Thank you, @mgechev !


Add configuring proxy server docs

WHY
Configuring proxy is a commom task that user may do. It's better to highlight it in the documentation, in the http parameters section.

It's was published to the docs:
https://prawn-cake.github.io/vk-requests/#using-http-proxy


Unknown 'gray2' in multiple components

I've noticed there's invalid color gray2 set on multiple components (Input, Select, Textarea, Slider, Border, Card, Progress, Tabs) background-colors and box shadows set by default.  Thus the intended properties don't render.
A sample code from my page:
.iUtigF {
	font-family: inherit;
	line-height: inherit;
	display: inline-block;
	vertical-align: middle;
	border: 0;
	box-shadow: inset 0 0 0 1px gray2;
	border-radius: 25px;
	-webkit-appearance: none;
	-moz-appearance: none;
	appearance: none;
	text-align: center;
	font-weight: 400;
}

Similar issue here. Just noticed it with the Card component. Have you noticed it with any color other than gray2?

@mannie-faux nope, just gray2 seems to be a problem

@selrond @mannie-faux this is because the components don't have the theme context.
Rebass has a <Provider /> component that will properly configure the theme, just need to use it at the root of your application.
See http://jxnblk.com/rebass/theming.

I don't really have this "issue" anymore as I'm not really using the same components much at the moment, but I wanted to point out that I already had the Provider with a theme wrapping my app when I posted that comment.
<Rebass.Provider theme={theme}>
    {props.children}
</Rebass.Provider>

with a theme setup like so:
import colors from './colors';

export default {
  colors,
  font: '"Open Sans", -apple-system, BlinkMacSystemFont, sans-serif',
  monospace: 'Inconsolata, "SF Mono", "Roboto Mono", Menlo, monospace',
  radius: 0,
};

The gray2 color is definitely present and accessible as colors.gray[2], but I'm not sure how to works with the gray2 color being referenced in the Rebass component definition itself.
Oh, and my colors variable is just a custom color palette I made using palx.

@mannie-faux Ah palx returns an array of grays, that's why you're able to access it with colors.gray[2], but rebass looks for colors.gray2. The array needs to be flattened onto the colors object.
Rebass also use palx to generate colors then flattens it to a single colors object. https://github.com/jxnblk/rebass/blob/29701cbd394925d9d4b1f69d7d9a0b34cf69df3a/src/theme.js#L38-L59

Oh duh. I took Rebass using palx too literally, and I figured the answer was something similar to this! Thanks for the help, this should probably fix a lot of styling errors that I probably never even realised were there.
What about you @selrond? Was the lack of Provider the issue?

@mannie-faux @epilande I have properly used theme provider in the root of my app, the problem still persists.

@selrond does the theme prop get propagated down to your styled components? When the theme prop reaches those components you mentioned (Input, Select, Textarea, Slider, etc..), how does the colors object look?

@selrond Hmm. Well, the problem personally occurred due to me not flattening the Palx-generated palette prior to passing it into the Rebass theme. The error suggests that your own theme is being passed an incorrectly-formatted color object as well or one that is missing. Does the component that actually has that bad CSS actually have the theme/colors as props in React Dev Tools? Could you share your repo, and if not, just some affected code?

for me, the cause of confusion was this example:

The theme object has the following shape. Any custom values passed to the Provider component will be merged with the defaults.

// Default values
const theme = {
  breakpoints: [
    32,
    48,
    64,
    80
  ],
  space: [
    0,
    4,
    8,
    16,
    32,
    64,
    128,
  ],
  fontSizes: [
    12,
    14,
    16,
    20,
    24,
    32,
    48,
    64,
    72,
    96
  ],
  weights: [
    400,
    700
  ],
  colors: {
    black: '#000',
    white: '#fff',
    ...palxColors       <--  wat
  },
  radius: 4,
  font: '-apple-system, BlinkMacSystemFont, sans-serif',
  monospace: '"SF Mono", "Roboto Mono", Menlo, monospace'
}

@epilande 's snip was perfect though

Closing this since palx has been removed in v2


Update asm-configuration.md

Adding correct reference for how to configure SWAP in Linux VMS on Azure. It is not recommended to manually set that up in /etc/fstab, the waagent has an automatic way to manage that which will also always use the temporary/ephemeral disk which helps in performance too.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mabicca : Thanks for your contribution to the Azure documentation! The author, @v-shiuma, has been notified to review your proposed change.

Pinged doc owner.

Oracle required minimum 6GB to start the installation, how do I setup the SWAP space to have 6GB to start with?

Due to conflicts and documents in flight - can't merge. BUT we did take all the recommendations and included in pending version.

@RicksterCDN - To resolve this pull request, please add an appropriate comment so that automation can take appropriate action. In this case, please-close. Thanks

#please-close


Fix intermittent issue where the reloadNginx function never finishes

Proposed changes
Fix intermittent issue where the reloadNginx function never finishes
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[ ] I have read the CONTRIBUTING document
[ ] I have run make install-tools and have attached any dependency changes to this pull request
[ ] If applicable, I have added tests that prove my fix is effective or that my feature works
[ ] If applicable, I have checked that any relevant tests pass after adding my changes
[ ] If applicable, I have updated any relevant documentation (README.md)
[ ] If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.12% :warning:

Comparison is base (7cc0918) 67.48% compared to head (4226daf) 67.37%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   67.48%   67.37%   -0.12%
==========================================
  Files         113      113
  Lines       12777    12772       -5
==========================================
- Hits         8623     8605      -18
- Misses       3584     3597      +13
  Partials      570      570

Files Changed
Coverage Δ

...dor/github.com/nginx/agent/v2/src/plugins/nginx.go
71.75% <100.00%> (+0.10%)
:arrow_up:

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Skip property... is this possible?

I would like to be able to have one of the properties in a data point not be used and instead interpolated based on its neighboring data points.
data-35p-top="top: 150vh; @show--video-btn: !0;"  << A: top: 150vh
data-10p-top="top: ???vh; @show--video-btn: !1;"  << B: the top property here should be a function of A and C
data--0p-top="top: 50vh; @show--video-btn: !1;"  << C: top: 50vh

I imagine a logical notation for point B could be
    data-10p-top="!top: ANYTHING_HEREvh; @show--video-btn: !1;"

I am using this to trigger a class on a moving element. I would like to trigger at a specific point in the movement, without having to manually calculate the top value for this specific data point.
Is this possible?
Note: This is the CSS for the above:
  .button[show--video-btn="0"] & {
    opacity: 0;
    transform: translate(0, 5vh);
  }
  .button[show--video-btn="1"] & {
    opacity: 1;
    transform: translate(0, 0);
  }
  .button[show--video-btn="2"] & {
    opacity: 0;
  }

this is not implemented https://github.com/Prinzhorn/skrollr#filling-missing-values

I am wondering if it would be possible to implement it? I looked at the code but it's beyond my level of JS. Do you think that this API would be OK?
 data-10p-top="!top: [THIS WILL BE EVALUATED BASED ON NEIGHBORING PROPERTIES]; @show--video-btn: !1;"

If I understand correctly, this would be difficult to implement because currently the code only evaluates neighboring properties, correct?

If I understand correctly, this would be difficult to implement because currently the code only evaluates neighboring properties, correct?

yes, this happens here https://github.com/Prinzhorn/skrollr/blob/1da1627e80ffb5c569880e4c77845e116905cf9f/src/skrollr.js#L1013 left/right are the two keyframes we are in between at the current scroll position.
This would have to be implemented on a different level. We'd have to interpolate the missing value once the properties are parsed.

I am wondering if it would be possible to implement it?

well, everything is possible. But I don't have any motivation to implement new features at the moment.

I understand. Thank you for the quick reply and thank you for this awesome contraption :) I love the simplicity of the API and the speed.


Adding assets folder to paths copied when running buildApplicationStaticAssets

Title says it all.

@dannycroft Ha! Couldn't help myself, dropped it in this commit.

Nice stuff.


Upload to 37% click pause, but still upload from 0%

The client uses uppy.js ,  Only when it is 100%, the backend will respond to the request of the patch, and the file will be uploaded

Closing as a duplicate of #44


support for laravel 5.6

It seems like this will still work under laravel 5.6, can you update the dependency in the composer.json?

Seconded.

Thirded.

Fourthded.

Fifthed

I tagged a new release with 5.6 and 5.7 support


Promotion / create PR feature for Bitbucket server

We are currently evaluating Kargo and we would like Kargo to have a feature to open up Pull requests to Bitbucket server for our prod staging promotion process. We see that Kargo has a feature to support GitHub and GitLab, but not BB server. Is that some thing that can be added in the future releases , that will enable us to get going with Kargo.

This isn't a high priority for the maintainers at the moment, but we would fully support this. It's an issue of medium difficulty and we would welcome someone from the community to pick it up and run with it.

I would like to take this, and thinking to use this https://github.com/ktrysmt/go-bitbucket or BitBucket API

No objection to that package.

krancour

Awesome. I'll start working on it

krancour

Awesome. I'll start working on it

Hey @chamodshehanka, any news regarding the development of the Bitbucket PR functionality? Do you still plan to do it?

dspereira004

yes. Can I open a draft PR?

dspereira004

yes. Can I open a draft PR?

That would be awesome! But, for more context: we are also evaluating Kargo for our company and our initial impression is good. However, we really need Bitbucket PR support, which is why I was asking you if you'll add support for it.

dspereira004

yes. Can I open a draft PR?

That would be awesome! But, for more context: we are also evaluating Kargo for our company and our initial impression is good. However, we really need Bitbucket PR support, which is why I was asking you if you'll add support for it.

that's great! we could work together then

Calling attention to #3128 which is an in-progress PR to add Azure DevOps support. It's a good example of how support for a new Git provider is added.

Hi  @krancour , after reading the issue I get for Azure Devops and Bitbucket is community made right? In my case is  Gitea integration, would it follow the same proccedure?
Thanks in advanced!

Yes. Support for any/all Git hosting providers all should implement the same interface.


Create Report page

Address issues raised on the review. Mainly:

Quick UI review

Comment list on 1. Add comments is broken (missing keyboard_arrow_down icon, misaligned > info row of homepage link, date, etc.)

Show comments on 2. Edit comments tab is also broken

buttons on Close report dialog on 3. Take action tab don't work.

And any new issues that will be discovered.

@kilemensi The UI looks different from my side.

The close report buttons also work as expected

Have you tried different browsers @kelvinkipruto?

@kilemensi The keyboard_arrow_down icon works a...

Will also find time to test this @kelvinkipruto but don't FF/Edge log any error when they fail to load the image?

FF-> The resource at “http://....jpg” was blocked because content blocking is enabled.
Edge-> Tracking Prevention blocked an Image resource from loading <URL>.


Expand acceptable bounds to [-360,-95,360,95]. Fixes #113

Coverage increased (+0.0%) to 96.8% when pulling ac1298694a5e76f40cb8effdb229b160ec4ef4e5 on bounds-simplify into 8e75e6e6f666b63dd4bc987b67fab56dcc43b1f5 on master.

The only difficulty that I'm seeing here is that the read streams rely on taking the dataset bounds and running them through sphericalmercator.xyz(bounds, zoom) to find the range of tiles that will be pulled from the source.
We start getting strange behavior if we hand in wrapping bounds:
> var bounds = [-290,-10,-170,10];
> sm.xyz(bounds, 5);
{ minX: -10,
  minY: 15,
  maxX: 0,
  maxY: 16 }
> var bounds = [175,-10,275,10];
> sm.xyz(bounds, 5);
{ minX: 31,
  minY: 15,
  maxX: 31,
  maxY: 16 }

This could as simple as an adjustment of the rendering bounds in the stream-scanline and stream-pyramid cases, I believe.

@rclark @tmcw right, so fix is to just clip overflowing bounds to [-180,-90,180,90] respectively in these streams?

:+1: added a method that limits the bounds that those streams iterate over

Looks great -- @rclark third pair of eyes before merge?

Coverage increased (+0.04%) to 96.84% when pulling 7e633acdc7ec99f70619ed3bc415fcd3ec57127f on bounds-simplify into 8e75e6e6f666b63dd4bc987b67fab56dcc43b1f5 on master.

:+1: Let's just make sure that we make it as clear as possible that we're still going to clip your data at the dateline, but that at least we won't throw the whole thing out.


Missing trailing CR + LF if field "bill information" is empty

Type of issue
[X] Bug
[ ] Question (e.g. about handling/usage)
[ ] Request for new feature/improvement
Expected Behavior
The following is with respect to the standard "Schweizer Implementation Guidelines QR-Rechnung" version 2.0. The chapter 4.2.3 mandates that CR + LF separates fields, as opposed to delimit them. The table in chapter 4.3.3 mandates that the field QRCH/RmtInf/AddInf/AstrdBgkInf "Bill information" is an optional field. That is it must be delivered but can be empty. Thus if the field "Bill information" is empty, and the Alternative scheme parameters are not delivered, then the last 5 characters of the payload must be "EPD\r\n": the "\r\n" separates the field "Trailer" from the necessarily delivered field "Bill information", however "Bill information" is empty.
Current Behavior
In the above-described scenario, the payload ends with "EPD", i.e. the trailing "\r\n" is missing.

Hi @sensorflo ,
At first I thought the library would behave correct, because the standard says that it is ok to remove the trailing "\r\n". But you are right - it should remove only the very last and trailing "\r\n" and not all trailing "\r\n"s... I corrected the behaviour in this commit: https://github.com/codebude/QRCoder/commit/6d657525dc0e6480f760131763e897e9bfa51c2b


[Event Request] codeunit 12153 SubcontractingPricesMgt - OnRoutingPricelistCostAfterFilters

In codeunit 12153 SubcontractingPricesMgt please add the following event:
    procedure RoutingPricelistCost(var InSubcPrices: Record "Subcontractor Prices"; WorkCenter: Record "Work Center"; var DirUnitCost: Decimal; var IndirCostPct: Decimal; var OvhdRate: Decimal; var UnitCost: Decimal; var UnitCostCalculation: Option Time,Unit; QtyUoM: Decimal; ProdQtyPerUom: Decimal; QtyBase: Decimal)
    begin
        PricelistQtyPerUOM := 0;
        PricelistQty := 0;
        PricelistCost := 0;
        DirectCost := 0;
        PricelistUOM := '';

        UnitCostCalculation := WorkCenter."Unit Cost Calculation";
        IndirCostPct := WorkCenter."Indirect Cost %";
        OvhdRate := WorkCenter."Overhead Rate";
        if WorkCenter."Specific Unit Cost" then
            DirUnitCost := (UnitCost - OvhdRate) / (1 + IndirCostPct / 100)
        else begin
            DirUnitCost := WorkCenter."Direct Unit Cost";
            UnitCost := WorkCenter."Unit Cost";
        end;

        if InSubcPrices."Start Date" = 0D then
            InSubcPrices."Start Date" := WorkDate;

        SubcontractorPrices.Reset();
        SubcontractorPrices.SetRange("Vendor No.", InSubcPrices."Vendor No.");
        SubcontractorPrices.SetFilter("Work Center No.", '%1|%2', InSubcPrices."Work Center No.", '');
        SubcontractorPrices.SetRange("Standard Task Code", InSubcPrices."Standard Task Code");
        SubcontractorPrices.SetFilter("Item No.", '%1|%2', InSubcPrices."Item No.", '');
        SubcontractorPrices.SetRange("Start Date", 0D, InSubcPrices."Start Date");
        SubcontractorPrices.SetFilter("End Date", '>=%1|%2', InSubcPrices."Start Date", 0D);
        // New event
        OnRoutingPricelistCostAfterFilters(SubcontractorPrices, InSubcPrices, WorkCenter);
        // New event
        if SubcontractorPrices.FindLast() then begin
            if SubcontractorPrices."Unit of Measure Code" = InSubcPrices."Unit of Measure Code" then begin
                PricelistQtyPerUOM := ProdQtyPerUom;
                PricelistQty := QtyUoM;
                PricelistUOM := SubcontractorPrices."Unit of Measure Code";
            end else
                GetUOMPrice(InSubcPrices."Item No.", QtyBase);
...

    [IntegrationEvent(false, false)]
    local procedure OnRoutingPricelistCostAfterFilters(var SubcontractorPrices: Record "Subcontractor Prices"; var InSubcPrices: Record "Subcontractor Prices"; WorkCenter: Record "Work Center")
    begin
    end;

Thank you

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[Tree Details - Design] Report Tree Image (sort of like a survey)

We need a filtering system for images uploaded that are deemed inappropriate or just incorrect when posting. We need a system similar to the "delete tree" section about why the image is being reported.
A few sections could include:

Inappropriate Image - Nudity / sexual activity / Hate Speech / Symbols / Suicide / Self-Injury / Disorder
Not the correct Tree
Blurry Image
Spam
"I just don't like it"
Sale of Illegal or regulated goods

Design to be similar to report page

@zoobot for reporting an image uploaded by a user. What filters would be a good starting point? I already have 3, not sure if we need more filters to be more specific or just keep it simple and general.

Do we want to show the image if it should be censored?


CAS is not supported by the client. Minimum client version is 6.0

I get the message CAS is not supported by the client. Minimum client version is 6.0. It is already fixed in openconnect https://gitlab.com/openconnect/openconnect/-/issues/651#note_1577713956 commit https://gitlab.com/openconnect/openconnect/-/commit/50428ca0f3165382a4ee13e0469b63cd9e52c9e5. Should we wait until it's released?

It looks like this issue is with openconnect itself, which is an unbundled dependency of the gp-saml-connect formula, so soon after the fix makes its way to a release, you should be able to brew upgrade to benefit from it 😊


can't import easydict on windows 10

After running the demo.py file, I've got this error.
from easydict import EasyDict as edict
ModuleNotFoundError: No module named 'easydict'
platform : anconda spyder.
OS : windows 10

Run Command Prompt as Administrator and Type the Following Command
pip install easydict


[REQUEST] Compile CUDA programs all the way and show the assembly

Problem:
For most (all?) languages other than CUDA, the compiler explorer produces target machine code (e.g. x86_64 assembly), not the compiler's intermediate representation. However, for CUDA, the output we see is PTX code. PTX is a (sort of) an intermediate representation - it might be a compiler backend target for LLVM, but it is not any machine's assembly. PTX gets compiled by PTXAS into a concrete microarchitecture's assembly (SASS) - with additional potential optimizations, by the way - which is then written in binary form.
Solution: Get GPU assembly with cuobjdump
The NVCC compiler cannot itself produce SASS text files; but from the compiler output it produces (.o file, .cubin or .fatbin; or an executable if it also links) - the SASS assembly can be extracted with the cuobjdump binary, part of the CUDA toolkit:
cuobjdump --dump-sass some_compiled_file

it is usually a good idea to compile for only just one microarchitecture, or to specify just one in cuobjdump, e.g.
cuobjdump --dump-sass some_compiled_file

Example output
The output looks something like this:
Fatbin elf code:
================
arch = sm_61
code version = [1,7]
producer = <unknown>
host = linux
compile_size = 64bit

        code for sm_61
                Function : _Z9vectorAddPKfS0_Pfi
        .headerflags    @"EF_CUDA_SM61 EF_CUDA_PTX_SM(EF_CUDA_SM61)"
                                                                                /* 0x001cfc00e22007f6 */
        /*0008*/                   MOV R1, c[0x0][0x20] ;                        /* 0x4c98078000870001 */
        /*0010*/                   S2R R0, SR_CTAID.X ;                          /* 0xf0c8000002570000 */
        /*0018*/                   S2R R2, SR_TID.X ;                            /* 0xf0c8000002170002 */
                                                                                /* 0x001fd842fec20ff1 */
        /*0028*/                   XMAD.MRG R3, R0.reuse, c[0x0] [0x8].H1, RZ ;  /* 0x4f107f8000270003 */
        /*0030*/                   XMAD R2, R0.reuse, c[0x0] [0x8], R2 ;         /* 0x4e00010000270002 */
        /*0038*/                   XMAD.PSL.CBCC R0, R0.H1, R3.H1, R2 ;          /* 0x5b30011800370000 */
                                                                                /* 0x001ff400fd4007ed */
        /*0048*/                   ISETP.GE.AND P0, PT, R0, c[0x0][0x158], PT ;  /* 0x4b6d038005670007 */
        /*0050*/                   NOP ;                                         /* 0x50b0000000070f00 */
        /*0058*/               @P0 EXIT ;                                        /* 0xe30000000000000f */
                                                                                /* 0x081fd800fea207f1 */
        /*0068*/                   SHL R6, R0.reuse, 0x2 ;                       /* 0x3848000000270006 */
        /*0070*/                   SHR R0, R0, 0x1e ;                            /* 0x3829000001e70000 */
        /*0078*/                   IADD R4.CC, R6.reuse, c[0x0][0x140] ;         /* 0x4c10800005070604 */
                                                                                /* 0x001fd800fe0207f2 */
        /*0088*/                   IADD.X R5, R0.reuse, c[0x0][0x144] ;          /* 0x4c10080005170005 */
        /*0090*/         {         IADD R2.CC, R6, c[0x0][0x148] ;               /* 0x4c10800005270602 */
        /*0098*/                   LDG.E R4, [R4]         }
                                                                                /* 0xeed4200000070404 */
                                                                                /* 0x001fd800f62007e2 */
        /*00a8*/                   IADD.X R3, R0, c[0x0][0x14c] ;                /* 0x4c10080005370003 */
        /*00b0*/                   LDG.E R2, [R2] ;                              /* 0xeed4200000070202 */
        /*00b8*/                   IADD R6.CC, R6, c[0x0][0x150] ;               /* 0x4c10800005470606 */
                                                                                /* 0x001fc420fe4007f7 */
        /*00c8*/                   IADD.X R7, R0, c[0x0][0x154] ;                /* 0x4c10080005570007 */
        /*00d0*/                   FADD R0, R2, R4 ;                             /* 0x5c58000000470200 */
        /*00d8*/                   STG.E [R6], R0 ;                              /* 0xeedc200000070600 */
                                                                                /* 0x001ffc00ffe007ea */
        /*00e8*/                   NOP ;                                         /* 0x50b0000000070f00 */
        /*00f0*/                   EXIT ;                                        /* 0xe30000000007000f */
        /*00f8*/                   BRA 0xf8 ;                                    /* 0xe2400fffff87000f */
                ................................

Fatbin elf code:
================
arch = sm_61
code version = [1,7]
producer = <unknown>
host = linux
compile_size = 64bit

        code for sm_61

(This is for a variant of nVIDIA's vectorAdd example. Yes, there is an extra header with no code at the end. For multiple functions, the "code for" part is replicated after the separator line.)
Notes

The dumped SASS needs a bit of parsing to get the instruction addresses and numeric values from the comments, but that should be pretty simple to add. It may also be possible to related SASS locations to source file lines. However, even without parsing - this is already very useful.
The choice of GPU architecture should probably be in the list of compiler configurations - like for other compiler+platform combinations.
I believe that SASS output should be the default, and PTX output should be an option users can choose; but some will argue that they other way around is more appropriate.

In fact, I believe that it

Thanks for filing this! I think this is related to #922 ? Perhaps a duplicate , though the amount of useful information here is great so we should either combine or close 922 in favour of this.
I confirmed our installation does indeed include cuobjdump (at first I didn't know if we had it).

@mattgodbolt : No, it's not that related. This issue only about the "device-side" code - the code which gets executed on the GPU. Right now, Compiler Explorer discards the host-side code, compiles the device-side  halfway (= to PTX) and shows the result. I'm just suggesting that the compilation of device-side code proceed all the way.

Ok. thanks for clarifying. As is now abundantly clear I really don't understand any of this, nor have the time to learn about it in order to implement it. So I'm hoping someone can submit PRs to fix these issues!


React step 5

Closes #
http://carbon-tutorial-ibmer20.mybluemix.net/#/
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

I did it.  I'll get a tshirt and a badge some day.


fix: Remove stream from registry after it's closed

I noticed this while going through the linting on https://github.com/libp2p/js-libp2p/pull/1566 , doesn't seem intentional

Not sure how to fix the caching issue  which is causing the builds to fail but there is a fix which would be required to upgrade to latest connection interface anyways so I opened that PR https://github.com/libp2p/js-libp2p/pull/1622

Notes from triage discussion - the muxer should be responsible for managing and storing references to streams, not the connection.


Simple presentation option of the map (no cluster, no heatmap)

Ok so the three display modes would be:

POI
POI with cluster
Heatmap

Just to be sure we are on the same page @vinber

yes, we're on same


fix multiple-line not drawing issue on line chart

fix multiple-line not drawing issue on line chart, added sample for the same

Unit test Results:

Sample app UI changes:


Added Web.config for Microsoft Internet Information Server (IIS) for …

….jscad and .amf file types.
And added code to enable file saving/downloading on Microsoft Internet Explorer 11 and Microsoft Edge.

I see that you've taken up the challenge to put a Blockify wrapper around OpenJSCAD.org. Very cool!
However, I'd like to finish off the current release (0.3.1) as there are some nice functional changes and bug fixes in this release. Can the changes in this pull request wait until the next release?

Sure - How do I separate out the work?
On Mon, Nov 23, 2015 at 5:42 PM, Z3 Development<EMAIL_ADDRESS>wrote:

I see that you've taken up the challenge to put a Blockify wrapper around
OpenJSCAD.org. Very cool!
However, I'd like to finish off the current release (0.3.1) as there are
some nice functional changes and bug fixes in this release. Can the changes
in this pull request wait until the next release?
—
Reply to this email directly or view it on GitHub
https://github.com/Spiritdude/OpenJSCAD.org/pull/104#issuecomment-159124731
.

--
Michael S. Scherotter
<EMAIL_ADDRESS>http://www.charette.com

The Commits on November 3 and November 5 are the ones that add the
web.config and fix the file saving support for Microsoft Edge and IE.
On Mon, Nov 23, 2015 at 8:01 PM, Michael Scherotter<EMAIL_ADDRESS>wrote:

Sure - How do I separate out the work?
On Mon, Nov 23, 2015 at 5:42 PM, Z3 Development<EMAIL_ADDRESS>wrote:

I see that you've taken up the challenge to put a Blockify wrapper around
OpenJSCAD.org. Very cool!
However, I'd like to finish off the current release (0.3.1) as there are
some nice functional changes and bug fixes in this release. Can the changes
in this pull request wait until the next release?
—
Reply to this email directly or view it on GitHub
https://github.com/Spiritdude/OpenJSCAD.org/pull/104#issuecomment-159124731
.

--
Michael S. Scherotter
<EMAIL_ADDRESS>http://www.charette.com

--
Michael S. Scherotter
<EMAIL_ADDRESS>http://www.charette.com

You can see the site here: http://openjscad.azurewebsites.net/
On Mon, Nov 23, 2015 at 8:04 PM, Michael Scherotter<EMAIL_ADDRESS>wrote:

The Commits on November 3 and November 5 are the ones that add the
web.config and fix the file saving support for Microsoft Edge and IE.
On Mon, Nov 23, 2015 at 8:01 PM, Michael Scherotter<EMAIL_ADDRESS>
wrote:

Sure - How do I separate out the work?
On Mon, Nov 23, 2015 at 5:42 PM, Z3 Development<EMAIL_ADDRESS>
wrote:

I see that you've taken up the challenge to put a Blockify wrapper
around OpenJSCAD.org. Very cool!
However, I'd like to finish off the current release (0.3.1) as there are
some nice functional changes and bug fixes in this release. Can the changes
in this pull request wait until the next release?
—
Reply to this email directly or view it on GitHub
https://github.com/Spiritdude/OpenJSCAD.org/pull/104#issuecomment-159124731
.

--
Michael S. Scherotter
<EMAIL_ADDRESS>http://www.charette.com

--
Michael S. Scherotter
<EMAIL_ADDRESS>http://www.charette.com

--
Michael S. Scherotter
<EMAIL_ADDRESS>http://www.charette.com

Interesting, Blocky as "overlay", which creates .json - nice idea.

@mscherotter Happy New Year!
I suggest we try to break this into some smaller pieces. Are there some "fixes" for Windows 10? If so then let's start there.
Please don't loose any changes in your local repository. You should be able to make a full copy for backup.

OK - I am caught up with a few things right now but will start that soon.
Michael
On Wed, Jan 13, 2016 at 12:17 AM, Z3 Development<EMAIL_ADDRESS>wrote:

@mscherotter https://github.com/mscherotter Happy New Year!
I suggest we try to break this into some smaller pieces. Are there some
"fixes" for Windows 10? If so then let's start there.
Please don't loose any changes in your local repository. You should be
able to make a full copy for backup.
—
Reply to this email directly or view it on GitHub
https://github.com/Spiritdude/OpenJSCAD.org/pull/104#issuecomment-171212777
.

--
Michael S. Scherotter
<EMAIL_ADDRESS>http://www.charette.com

I think that the best way forward would be...
Close this pull request (and #102)
Save the old local repository
Make a new local repository & sync with DEV (let me know if you need help here)
Make changes for Windows 10 & test (run all the examples at least)
Push the changes back to your forked version of OpenJSCAD.org
Make a new pull request for the Windows 10 changes
Sorry about all this extra work.

@mscherotter Please try again. There are too many changes to determine what is important versus what is a new library.
Please split this pull request into pieces, which can be reviewed independently.
We would love to have support for Explorer and Edge.
We would love to see Blockify based webpages.


#126: Developed Kubernetes yml files

#126: Developed Kubernetes yml files

Still service discovery needs to be implemented.

Looks good to me.


'Credential removed' toast hidden behind modal initially

Description of problem
When removing a credential from the wallet, a toast pops up to confirm it has been removed successfully. This toast is initially hidden underneath the remove modal
Expected behavior
The toast should appear above everything else
Steps to reproduce
Remove a credential
Screenshots and/or log output

Environment

[x] Occurs on Android
[x] Occurs on iOS

Build #: 972
Android Device Model: Pixel 4
iOS Device Model: iPhone 13
Workaround
N/A
Severity

[ ] High
[ ] Medium
[x] Low

This seems difficult to address due to the nature of modals in React Native and the library we are using for toasts. It's possible to have a toast appear over a modal (https://github.com/calintamas/react-native-toast-message/blob/main/docs/modal-usage.md), but when the modal is gone so is the ref the toast library uses, so it will disappear immediately in this case, where the modal is only briefly still visible.
We can:

Move toast popups after navigation takes place, shortening the time it appears behind the modal but not eliminating it completely
Add a short delay before the toast is shown long enough to make it only appear once the modal is gone (a bit janky)


Add an 'index.html' file to represent the index of all CLI artifacts.

This PR adds files to the scripts folder for publishing a list of all CLI artifacts to S3. The artifacts themselves are scraped from downloads.dcos.io/cli/releases and published as an artifacts.json file that is then read and rendered by a small html/css/javascript app.
A live version of the index can be seen here:
https://downloads.dcos.io/cli/index.html
Two different script are used to publish the necessary artifacts for this index.
The first is publish_index.py which publishes all of the necessary files required to render the index. This script should not need to be ran very often, and is only necessary if changes are made to any of the files used to implement the rendering of the index.
The second is publish_artifacts.py which publishes a JSON file listing all of the artifacts that should be displayed in the index. This script should be ran every time we publish a new artifact to S3 which we want to publish as a new release. This applies to both CLI releases themselves, as well as plugins.
In a subsequent commit we should add the calling of publish_artifacts.py to our CI as a step in publishing any of our release artifacts.

I might not be up-to-date here, what is the status of this PR and what are the next steps? eg. how to automate the build of the web page, where will it be documented.

I think the script itself is ready to be merged. We need to update the Jenkins tooling to call it, and republish it whenever a new artifact is pushed to S3. We also need to update our documentation on the DC/OS docs to point to it so people can go to it and know where to download things from.

Added https://jira.mesosphere.com/browse/DCOS_OSS-4537 and https://jira.mesosphere.com/browse/DCOS_OSS-4538 to our sprint in order to track the upcoming work to do. IMO this PR is ready to be rebased and merged.


Add support for new relay directives @prependEdge @deleteEdge, and so on

Describe the bug
First of all, really appreciate the work put into this package as it saves so much time writing graphql queries 🙏 . And this is not so much a bug, but a feature request. TLDR: Would be nice to have this plugin recognize the following new relay directives.
@prependEdge
@prependNode
@appendEdge
@appendNode
@deleteEdge
https://relay.dev/docs/guided-tour/list-data/updating-connections/#adding-edges
https://relay.dev/docs/guided-tour/list-data/updating-connections/#removing-edges
All the other relay directives seem to be recognized perfectly.
Screenshots

@ronaldcurtis hi! It's already done and would be released in the next update.


Use case: Use Yoga to expose a GraphQL API on an existing database

It's a quite compelling approach to start developing a GraphQL API by exposing your underlying database as a starting point and then iterate from there. Yoga should make this getting started workflow extremely easy by leveraging Prisma's DB introspecting functionality.

Released under<EMAIL_ADDRESS>


Need docs on type conversion

Per this tweet (https://twitter.com/prigithj/status/1634109778757820418), it would be good for us to have some examples in the docs of how to convert types (eg string to number and vice versa) using @mutate. We need to consider composite types and relatedly, how missing values are handled during type conversion.

I don't think Julia support the string to number conversion (see this). We need to achieve this using string parsing. Will think about an example and comment on this issue.

I'm interested in pitching in, but am a total newb to Julia. Caveat: I may not have time until Q2 begins in ~1.5 weeks.

Thanks @danfulop. We would love your help! No worries regarding time.
Two quick questions that may help orient you to the best way to contribute:

Are you experienced with either R or Python?
Have you submitted a pull request to GitHub (or know how that works)?

Don't worry if the answer is no to question 2. Just want to support you through the process as you consider working on this.

@kdpsingh The answers to those are yes and yes. I'm just new to Julia.

Perfect. Let's aim to create 3 functions for now:

as_float()
as_integer()
as_string()

These functions should work on a single value provided to them. Don't try to make them work on vectors -- Tidier.jl will auto-vectorize them when they are called.
Take a look at the Julia language manual on strings and on type conversion/promotion.
When we test them, they should be able to take any of these 3 types and convert to any of the others using the above functions.
Good luck on this, and keep us posted!

The new functions can go in a new type_conversion.jl file. Would reference it in the includes at the top of the main Tidier.jl file.
@danfulop, is it okay if @alonsoC1s works on this? I know you mentioned you would have time in a couple of weeks, but if you've already started, would be good to know. Want to ensure there is no duplicate work if possible (as there is lots to go around!).
I may have forgotten to mention in my earlier message, but all 3 of the functions should return missing values if they encounter a missing value -- they shouldn't produce an error.

@kdpsingh @alonsoC1s Yes, that's totally fine. I wouldn't have time until next week.

@alonsoC1s feel free to take a look! Will "assign" this issue to you on GitHub but no pressure 😀

Just so we're all on the same page, the final implementation should work like:
@chain movies begin
    @mutate(Budget = as_integer(Budget))
end

Am I missing something?

Exactly. The only thing to know is that when you code it, as_integer() will get automatically vectorized into as_integer.(), so you only need to get the function to work on a single scalar value and not on a vector.
In other words, focus on getting this to work:
as_integer(2.0) and as_integer("2")
and NOT as_integer([1.0, 2.0]).
Let me know if that doesn't make sense. Thank you again.

and if someone enters as_integer("hello"), it should return a missing and not an error.

Awesome thank you! 🙏
I will review and take it from here. I'll let you know if I have questions.

The new as_float(), as_integer(), and as_string() functions are now implemented in #83. They are documented in dostrings - will consider adding a dedicated documentation page for these functions in the future.


MicroWin Windows 10 Snip & Sketch Bug

Describe the bug
After using MicroWin on a windows 10 ISO, and installing, trying to use the Snip & Sketch tool fails. You are unable to use the "Win+Shift+S" method and clicking "New" with the app open brings up a prompt (See below). It should be noted that it was not installed originally and I installed it from the Microsoft store.
To Reproduce
Steps to reproduce the behavior:

Open Snip & Sketch
Click on New
Result

Expected behavior
Snip & Sketch region select tool to appear
Screenshots

Additional context
Used MicroWin to debloat a win10 ISO and added no drivers of my own. Used Rufus in creation as well.
I have tried restarting after installing, resetting S&S, uninstalling and reinstalling but nothing worked.

A fix I have found for this is running a DISM command. I am unsure as to why MicroWin would affect the snipping tool.

Fixed in latest release. PR #2737


Add new params to getMarkets

Closes https://github.com/AugurProject/augur/issues/2864. Remaining TODO items are in https://github.com/AugurProject/augur/issues/3023

@bthaile Thanks for the feedback! Will make a few more changes to this tomorrow and then merge.

I removed the reportingStates & includeMarketsWithoutOrders params from getMarkets & updated the tests. I made a note to make market creator full-text-searchable & take another look at category3 indexing as part of #3023.


galleriajs.github.io not working

Examples are not loading on https://galleriajs.github.io/

Thats probably because Vimeo API has changed and for some reason broken video causes gallery stops working.

still not loading

The demos are still not working on the website.

So the demo has been broken for more than 3 years. Perhaps use something else than galleria...


Add total_limbo_balance to balance total

We recently added the pending open channel balance to the balance total so the users balance doesn't go down when moving funds onto LN. The same should be for limbo balance on force close. For example, if the user has one channel open and force closes it, their balance will go to zero. That would be a scary experience if they weren't clued into what's going on.
We should add the total_limbo_balance to the total balance (this data can be found in the pending channels call, see screenshot below)

Closed via https://github.com/LN-Zap/zap-desktop/pull/1793


Cell preselection

I'm trying to preselect a cell in cellForItem(at index: Int) -> UICollectionViewCell by cell.isSelected = true in section controller.
It works fine and cell becomes selected. When I try to deselect a cell by tapping it cell doesn't react at all. Tap triggers isHighlighted method but doesn't want to trigger neither isSelected in cell nor didDeselectItemAt delegate method.
This issue is related only to preselected cells. All other cells work fine in the same collection.

@pharosproduction can you describe a bit what you're trying to do? UICollectionViewCell selection APIs aren't really supposed to be changed manually, you're supposed to let the UICollectionView internals handle all of that for you.
The docs say:

You typically do not set the value of this property directly. Changing the value of this property programmatically does not change the appearance of the cell. The preferred way to select the cell and highlight it is to use the selection methods of the collection view object.

If you're trying to do custom selection state, we recommend making your own properties and settings.

There is a Set of groups displayed as a two column list, one section with one row for each group. Some of them should be selected when list appears. Each group contains a selection state(bool). Groups amount is a variable(pagination load). What is the best way to select marked for selection cells and where?
I have tried already different approaches including selectItem(at: IndexPath?, animated: Bool, scrollPosition: UICollectionViewScrollPosition) but no luck to find the best way to do this. The goal is just to select a cell without triggering any delegate methods so user can deselect it or proceed with a default selection set(fetched by indexPathForSelectedItems)

@pharosproduction at Instagram we use custom properties to represent selected state in our UI instead of relying on the UICollectionView built-in stuff. We would do something like:

Add a custom @property BOOL checkmarkDisplayed; to our cell subclass
In the setCheckmarkDisplayed:(BOOL)checkmarkDisplayed setter, set the state and call [self setNeedsLayout] and set hidden on our checkmark image view
Position the view in layoutSubviews

Then in cellForItemAtIndex: we can manually set the state w/out worrying about UICollectionView internals.
Then in didSelectItemAtIndex: you can flip the selection state, both in the cell and wherever you're tracking it.

Got it. Thanks.
BTW, collectionView doesn't trigger didSelectItemAtIndex:, only deselect. Is it possible to switch from didSelectItem(at index: Int) in section to collectionView delegate without loosing all other IGListSectionController functionality?

@pharosproduction you mean to use the UICollectionViewDelegate APIs alongside IGListSectionController? It's possible, but not at the section-controller level. You can attach a collectionViewDelegate to the adapter to get all the normal delegate events.

No, on ViewController level. didDeselectItemAtIndex works fine, but didSelectItemAtIndex doesn't work, instead IGListKit triggers didSelectItem at section level. Is it possible to trigger both of them(didSelectItemAtIndex and didSelectItem)?
Actually I understand it's possible by digging inside IGListKit and changing current code, but maybe I'm wrong and I have missed something in docs.

@pharosproduction it should be totally possible. That collectionViewDelegate should just forward events to the delegate while also notifying the section controller. Here's the source.

I have updated IGListKit to the latest master. It works, thank you.

💯

I know it might be a little late to solve this issue, but for those who still need to resolve this issue without too much hassle, you just need to call the selectItem(at: IndexPath?, animated: Bool, scrollPosition: UICollectionViewScrollPosition) inside  cellForItem(at index: Int) -> UICollectionViewCell:
override func cellForItem(at index: Int) -> UICollectionViewCell {
    reusableCell(at: index, isNib: false) {
      let item = self.item?.items[safe: index]
      $0.item = item
      $0.isSelected = item?.isSelected ?? false
      if item?.isSelected == true {
        self.collectionContext.selectItem(at: index,
                                          sectionController: self,
                                          animated: false,
                                          scrollPosition: [])
      }
    } as Cell
  }

Then the didSelect and didDeselect delegates will be called.

Here is the syntactic sugar I used for the previous comment:

extension ListSectionController {

  public func reusableCell<T: UICollectionViewCell>(at index: Int, isNib: Bool, configCell: ((T) -> Void)? = nil) -> T {

    if isNib {
      guard let cell = collectionContext?.dequeueReusableCell(withNibName: String(describing: T.self), bundle: nil, for: self, at: index) as? T else {
        fatalError("Could not dequeeu nib cell of type: {\(type(of: T.self))}")
      }
      configCell?(cell)
      return cell
    } else {
      guard let cell = collectionContext?.dequeueReusableCell(of: T.self, for: self, at: index) as? T else {
        fatalError("Could not dequeeu class cell of type: {\(type(of: T.self))}")
      }
      configCell?(cell)
      return cell
    }

  }
}


UI: Wrong number of executions

Hello, I found that if I run many workflows at the same time, let's say 10000 in 1 hour, and during that time I applied the RUNNING filter in executions search, then after they all will be executed I still see a positive number like 1750 executions supposed to be running but the list of executions is empty already.
Do you know possible reasons for that? And how to fix? Are there any restrictions of updating interval for ElasticSeach index? Maybe I send too many requests (I tried 100 concurrent requests to start workflows) and somehow ES index is updated in the wrong way?
Thank you.

I think I found the reason while debugging the UI requests to the server. The actual status of these workflows is already COMPLETED but somehow this was not updated for search/filtering purpose. So, I have a "result->hits" response with a chunk of 100 workflows when clicking Seach on this page, but their status is COMPLETED so probably UI isn't showing them (that is right). So, the number of "found workflows" also should be zero in that case.

I also think it is maybe related to the issue #759, because before that workflows were stuck in RUNNING but later all of them magically changed to COMPLETED after I manually paused and resumed 24 of them.

@dskarataev Thanks for testing and the feedback. We are looking into #759 and will post an update soon. Please follow along on #759


add parent child relationships in nodes

Add parent and child relationships to node v2. Useful for trees such as JSON and YAML.
Is the Union OK (for multiple children) or should we separate out children into a separate attribute?

Hmm... mypy is complaining about the Dict -> Union due to invariance?
typing docs say that Dict is deprecated for dict. https://docs.python.org/3/library/typing.html#typing.Dict and List is deprecated for list, but there's another error if I use list (lowercase)
Going to try Mapping and see if it fixes things.

this is great! will take a look soon

I ended up putting the children in a separate field but we can change it. The Union was causing errors in other places so if we want to do it we may have to change the other places the Node is used.

I ended up putting the children in a separate field but we can change it. The Union was causing errors in other places so if we want to do it we may have to change the other places the Node is used.

i'm ok with changing the typing (would prefer that over defining a separate field imo). does changing value type to Any work? allows the dictionary entry to contain arbitrary values
if that doesn't work, i can also help take a look at this PR
cc @Disiok

Made the change to Any. Checks seem to pass.


feat: new stacking integration guide using stacking lib

This PR updates the stacking integration guide to use the new stacking lib https://github.com/blockstack/stacks.js/pull/850

Routes are working with the library


Better label than "Plum" for Cicognara export

Esp. for the fiche, that's not a good label

But see https://github.com/pulibrary/cicognara-rails/issues/182


build: always build swift-reflection-dump

We always build swiftReflection now for the tools which allows us to
always build this tool.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge

@swift-ci please clean test macOS platform


stocazzo enhancement enhancer

want to enhance your stocazzo? looking for stocazzo enhancement pills?

Nice pattern. I would change field names in the object you are passing:
{
    "big": "gran",
    "bigger": "grandissimo"
}

Much more lollish. :D

@sirmmo still want this PR to be merged? Please update your changes to match the code written by @enrichman in #11 :+1:

Closing this due to refactoring needed


--no-circular option

Parity with dpdm's --no-circular option.
dpdm uses yargs which allows negating values for boolean flags via a --no- prefix: http://yargs.js.org/docs/#api-booleankey
I don't think the argv.circular argument was used in main.rs. This should be backwards-compatible since the default behavior is the same

I'm very sorry for only seeing your PR today. I will test it later and restart the process


Fix web command list

Use rjsmin instead of jsmin
Add changelog entry

Fixes #1891
Pull request checklist:

[x] CHANGELOG.md was updated, if applicable
[x] Documentation in docs/ or install-docs/ was updated, if applicable
[x] I have tested all changes

@pajlada Is the behaviour broken in the last release? Or was pajbot never released with the broken behaviour?
(Just asking because in the latter case a changelog entry shouldn‘t be added.)

the

It was never in a release, can amend it in the release pr

the


Use Rust Analyzer

Use Datadog's new Rust-based static analyzer.

CircleCI is non-blocking. This project was followed on there (causing these errors) and I've removed it, so there should be no more errors moving forward.


How should a server handle a missing or extra id?

How should a server respond in the following situations?

The method of a message is a notification and the message has an id
The method of a message is a request and the message does not have an id

1.) An id clearly defines a message as a request. So I would return an error with an ID https://github.com/microsoft/vscode-languageserver-node/blob/main/jsonrpc/src/common/messages.ts#L43 since no request message exist.
2.) this is harder since no error can be reported back. All that can be done is to log this and report it back to the client in the log.


bearer: 1.19.1 -> 1.19.2

Description of changes
change log: https://github.com/Bearer/bearer/releases/tag/v1.19.2
diff: https://github.com/Bearer/bearer/compare/v1.19.1...v1.19.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 250478 run on x86_64-linux 1

1 package built:

bearer


JSX Element type 'ImagePicker' does not have any construct or call signatures

Just started using this and I already get this error...
It's an Expo project, within a functional component, imported like this:
import * as ImagePicker from 'expo-image-multiple-picker';

Hi!
Yes, the import is wrong. Is
import { ImagePicker } from 'expo-image-multiple-picker'
Cheers

Oh wow, my bad, thanks!


2.6.0 - General bugfixs and precursor merge for RTLSDR-OGN

Just some re-factoring of the rtlsdr-ogn.sh script to ensure that double square bracket tests and curly brace variables throughout, this will make it possible for me to merge the changes I am making in my 2.7.0 for issue #129

glad i can help, thou for the dump978 changes i only merged them from master as i think they may have got lost in my recent deluge of tweaks ;)

Right, this myriad of small fixes seems to have got 2.6.0 back to working order.. havent tested a fresh install but have upgraded a Pi that was running 2.5.0 and it seems not to have broken anything, at least that ive spotted so far.
Hopefully this will be an easy merge and its worth noting that i had to set automated_install to false in install.sh as the current run time flags only have the option to enable rather than disable this feature :)

Mostly small fixes and the addition of Travis build file, which I have also submitted against the master branch as #290
One outstanding issue is that I seem to have broken the whiptail text box coloring, hopefully an easy fix once i find it ;)

Mostly small fixes and the addition of Travis build file, which I have also submitted against the master branch as #290
One outstanding issue is that I seem to have broken the whiptail text box coloring, hopefully an easy fix once i find it ;)

This pull request against the 2.6.0 branch now includes:
#276 - Dump1090 basic sanity checking of user supplied LAT/LON
#293 - Initial work towards graphing on non-Pi hardware
#294 - Fix python indent error that was filling syslog
#298 - Dump1090 peak range capped at 269.9 nm / 500 km
#305 - PiAware Client update to version 3.3
#306 - PiAware Make 'claim my pi' default instead of local credentials
#310 - MLAT Client update to version 0.2.8

This pull request against the 2.6.0 branch now includes:
#129 - OGNReceiver / FLARM Receiver
#276 - Sanity checking of user entered LAT/LON during setup
#293 - Initial work towards graphing on non-Pi hardware
#294 - Fix python indent error that was filling syslog
#298 - Dump1090 peak range capped at 269.9 nm / 500 km
#305 - PiAware Client update to version 3.3
#306 - PiAware Make 'claim my pi' default instead of local credentials
#310 - MLAT Client revert to version 0.2.7
#314 - Set correct PHP version for Ubuntu releases after 16.04
#316 - MLAT client will not install if the configured version does not match the latest version
#317 - PlaneFinder ARM Client update to version 3.5.469
#318 - Add support for automated build testing with Travis
And various small typo corrections and bugfixes :)

:(


Fix formatter instability with half-indented comment

Summary
The bug was happening in this loop.
Basically, In the first iteration of the loop, the comment_indentation is bigger than child_indentation (comment_indentation is 7 and child_indentation is 4) making the Ordering::Greater  branch execute. Inside the Ordering::Greater branch, the if block gets executed, resulting in the update of these variables.
parent_body = current_body;
current_body = Some(last_child_in_current_body);
last_child_in_current_body = nested_child;

In the second iteration of the loop, comment_indentation is smaller than child_indentation (comment_indentation is 7 and child_indentation is 8) making the Ordering::Less branch execute. Inside the Ordering::Less  branch, the if block gets executed, this is where the bug was happening. At this point parent_body should be a StmtFunctionDef but it was a StmtClassDef. Causing the comment to be incorrectly formatted.
That happened for the following code:
class A:
    def f():
        pass
       # strangely indented comment

print()

There is only one problem that I couldn't figure it out a solution, the variable current_body in this line now gives this warning "value assigned to current_body is never read maybe it is overwritten before being read?"
Any tips on how to solve that?
Closes #5337
Test Plan
Add new test case.

The original implementation was to complex, we only need to track the parent and the current node, the last child in the parent. If the indentation is less, assign to the parent. If it is equal, assign to the current node. If it is greater, try doing a recursion step where we look at the children of the current node. If a comment is half-indented, the indentation is first greater and then less, i.e. we assign it to the parent/less indented node.


Helpers doesn't work with github pipelines?

I'm not sure if I'm going crazy, but copying and pasting the exact example in the repo throws a build error in github pipelines.
I was trying to re-write my config, but couldn't get anything to build. But then copying and pasting the example config throws as well
devicetree error: /tmp/zmk-config/config/corne.keymap:44 (column 110): parse error: expected '{', '=', or ';'
CMake Error at /tmp/zmk-config/zephyr/cmake/modules/dts.cmake:279 (message):
-- In: /tmp/tmp.bSoIm3OaTr/zephyr, command: /usr/bin/python3;/tmp/zmk-config/zephyr/scripts/dts/gen_defines.py;--dts;/tmp/tmp.bSoIm3OaTr/zephyr/zephyr.dts.pre;--dtc-flags;'-Wno-unique_unit_address_if_enabled';--bindings-dirs;/tmp/zmk-config/zmk/app/module/dts/bindings;/tmp/zmk-config/zmk/app/dts/bindings;/tmp/zmk-config/zephyr/dts/bindings;--header-out;/tmp/tmp.bSoIm3OaTr/zephyr/include/generated/devicetree_generated.h.new;--dts-out;/tmp/tmp.bSoIm3OaTr/zephyr/zephyr.dts.new;--edt-pickle-out;/tmp/tmp.bSoIm3OaTr/zephyr/edt.pickle;--vendor-prefixes;/tmp/zmk-config/zmk/app/dts/bindings/vendor-prefixes.txt;--vendor-prefixes;/tmp/zmk-config/zephyr/dts/bindings/vendor-prefixes.txt

Thanks for pointing out the issues with the example. There were a couple of typos that slipped into the keymap file. They should all be fixed in 2017eb52eb3febf34da3324ac3f7c944a117055c, which now builds cleanly in my test. Sorry for the inconvenience.

Closing for now. But feel free to reopen if it's still not working.


Mismatch between Total "Online tickets" of Dashboard and Saura-emitra

Describe the bug
Mismatch between Total "Online tickets" of Dashboard and Saura-emitra
To Reproduce
Steps to reproduce the behavior:

Go to Kibana Dashboard
Check the Total number of Online Tickets Card.
Go to https://saura-emitra.selcofoundation.org/
Log in and navigate to Home Page
Ticket Card show the "Total" count

Expected behavior
Mismatch between Total "Online tickets" of Dashboard compared to Total in Tickets card of saura-emitra
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser : chrome
Version: NA

Additional context
NA

not yet fixed @deepikaarora88

It will get fixed once any action is taken on the two tickets. Both are pending for Resolution. KA-RCH-6748722243-0001, KA-RCH-2474684558-0001

The current number of Online Tickets shown in Kibana is 198, whereas the platform indicates 201. The count of Online Tickets reflects the total number of tickets created on the platform, regardless of their status.
Let me know if further clarification is needed.
Sorry i am unabel to understand your above comments which is
"It will get fixed once any action is taken on the two tickets. Both are pending for Resolution. KA-RCH-6748722243-0001, KA-RCH-2474684558-0001"


Code review - the use of RData

Hi @imfeldn,
Just some observations while doing code review for reproducibility. During all the procedures you heavily rely on RData files for storing results. I would advice you not to do so. Mainly the variables are declared within the RData itself, and which will invariably lead to bugs which are incredibly hard to trace.
An example:
load(file)

will restore a variable called "meteo_data" in your workspace, but there is no way to figure this out from either the filename or any assignment of the variable.
In short you can't do:
meteo_data <- load(file)

load therefore obscures things and might actually override existing variables unbeknownst to you, or create additional ones if you accidentally save more than what was needed. This lack of explicit declarations for variables often leads to bugs which are 1. not visible 2. consequentially very hard to trace, 3. can be a cause of grave errors because of it (as you might load data which is not what you think it is).
For speed I've split out the generation of the driver data from the model calibration see here:
https://github.com/khufkens/swiss_pheno/blob/main/analysis/019_generate_model_drivers.R
This will save the prepared model drivers, from which the various subsets will be generated. This would allow you to only upload these data (what is required) and work from there on - this should speed things up and keep the data preparation separate from the true analysis (model calibration and summary stats). One can argue for putting this in data-raw or data.

I will do a pull request of the changes if you like. Let me know what your take is on my notes above.

Dear Koen,
sorry, I haven't used github for a while. I only saw your reply now,
since it went to my private e-mail account. That's changed now.
Yes, I'm aware of the issues with load(). We can work using rds instead.
It's also fine for me to flatten the data as you do in 019 and adjust
the selection accordingly in 020.
So, you can do a pull request and add your changes. The adjustments
didn't fully work for me yet though, but, I guess you're aware of this
and it was more exemplary.
I'm not sure about the following lines in the two scripts
020...alternating and 020...late_period though, if I test it on a
flattened stn_list object. It's setting all FALSE selection in the
training selection to TRUE again? Also, if we only work on the long
series, it might not be needed, because in the preselection script
(012_stnsel_pheno_longseries.R) it is already tested how long a series
is?
select training years
selection <- selection |>
dplyr::group_by(site) |>
mutate(
train = ifelse(
length(which(train)) > 1,
TRUE,
FALSE
)
)
select test years
selection <- selection |>
dplyr::group_by(site) |>
mutate(
train = ifelse(
length(which(test)) > 1,
TRUE,
FALSE
)
)
Cheers,
Noemi
Am 2023-08-15 10:33, schrieb Koen Hufkens:

Hi @imfeldn [1],
Just some observations while doing code review for reproducibility.
During all the procedures you heavily rely on RData files for storing
results. I would advice you not to do so. Mainly the variables are
declared within the RData itself, and which will invariably lead to
bugs which are incredibly hard to trace.
An example:
load(file)
will restore a variable called "meteo_data" in your workspace, but
there is no way to figure this out from either the filename or any
assignment of the variable.
In short you can't do:
meteo_data <- load(file)
load therefore obscures things and might actually override existing
variables unbeknownst to you, or create additional ones if you
accidentally save more than what was needed. This lack of explicit
declarations for variables often leads to bugs which are 1. not
visible 2. consequentially very hard to trace, 3. can be a cause of
grave errors because of it (as you might load data which is not what
you think it is).
For speed I've split out the generation of the driver data from the
model calibration see here:
https://github.com/khufkens/swiss_pheno/blob/main/analysis/019_generate_model_drivers.R
This will save the prepared model drivers, from which the various
subsets will be generated. This would allow you to only upload these
data (what is required) and work from there on - this should speed
things up and keep the data preparation separate from the true
analysis (model calibration and summary stats). One can argue for
putting this in data-raw or data.
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
You are receiving this because you were mentioned.Message ID:
@.***>
Links:
[1] https://github.com/imfeldn
[2] https://github.com/imfeldn/swiss_pheno/issues/1
[3]
https://github.com/notifications/unsubscribe-auth/AH67PVCMLNIIHFEMEO3A72LXVMX55ANCNFSM6AAAAAA3QYV3F4

Bug mentioned above fixed by
https://github.com/khufkens/swiss_pheno/commit/9cd4e3db8f2b132060510877c423535b1b5fa4c8
@imfeldn I'll keep the routine to check for ultra-short years in there anyway, sticking close to your original code. If you feel confident that this has been checked before in generating the pheno_meta  files then we can remove this later on still.

Yes, it's okay to keep the routine for very short series.

I think most of it is addressed now in pull request #2
Do an independent check however (via cloning my project), as I found bugs (late afternoon is not the best time to be fresh enough to code).

Yes, I found bugs too. I'll check the second pull request then and get back to you.

Yes, do clone my project (under my github account) first and spot check if it works, if not either put a comment in this issue or the pull request itself. Then I can fix it and it will be included in the pull request. I just don't have access to all the original files to test it all.

I cloned your project, checked it, and made small changes to most of the scripts. There were some details not working, eg. variables missing, the naming wasn't changed everywhere, etc. Since it's already changed in my code, I don't know how to proceed best? I can send it to you, then you can do a new pull request and it remains your refactoring? I can add it to your fork...

Von: Koen Hufkens @.>
Gesendet: Dienstag, 15. August 2023 16:16
An: imfeldn/swiss_pheno @.>
Cc: Imfeld, Noemi (GIUB) @.>; Mention @.>
Betreff: Re: [imfeldn/swiss_pheno] Code review - the use of RData (Issue #1)
Sie erhalten nicht oft eine E-Mail von @.*** Erfahren Sie, warum dies wichtig isthttps://aka.ms/LearnAboutSenderIdentification
Yes, do clone my project (under my github account) first and spot check if it works, if not either put a comment in this issue or the pull request itself. Then I can fix it and it will be included in the pull request. I just don't have access to all the original files to test it all.
—
Reply to this email directly, view it on GitHubhttps://github.com/imfeldn/swiss_pheno/issues/1#issuecomment-1679009134, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH67PVBHWOP4MM6HNBJ2MNDXVOAEPANCNFSM6AAAAAA3QYV3F4.
You are receiving this because you were mentioned.Message ID: @.***>

closed as per #2


Feature: Batch Request - CSRF Token

Add X-CSRF-TOKEN on each batch request. This is necessary to do execute PUT/MERGE operations on S/4HANA Cloud

Thanks for commit, and I need some time to review it.
Firstly, console.log should be removed and do not change the code original behaviour, add your feature by add indicator like withCsrf in newBatchRequest instead of change whole code logic, some others projects will be affected.
and, do not store cookie by header, access it bydocument.cookie directly

Please check commit 0111b06 for fix on remaining open points

I'll search some SAP internal resources about HANA or S4HANA OData spec.
Once I get the odata implementation detail, I'll update this PR status.

Not required, only HTTP header will require csrf token, inner requests are not required.


WIP: Code cleanup

Simplify object parsing.
Fix end of line parsing bugs that causes object and array parsing.
Resolves #75
Merge and closes #73 pull request

Resolves #70

Merge and closes #74 pull request

Fix problems with CI not running test in their build directory causing it to fail to read included external test files.

@Arkatufus unfortunately the file renames I did to make builds run on Linux appear to have created some conflict issues here - best bet is to rebase probably

CI should play much more nicely now though

@Aaronontheweb, Seems like at least one file were not copied from the git repo to the build directory in Linux PR validation build. Build failed on Hocon.Configuration.Test because it could not find the app.config file in the source directory.


Remove unused address_short.html file

I want to merge this change because...
This file is not being used.
Fixes #1466
Pull Request Checklist

[x] Privileged views and APIs are guarded by proper permission checks.
[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Database queries are optimized and the number of queries is constant.
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] Python code quality checks pass: pycodestyle, pydocstyle, pylint.
[x] JavaScript code quality checks pass: eslint.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@12fa75f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1467   +/-   ##
=========================================
  Coverage          ?   83.39%
=========================================
  Files             ?      128
  Lines             ?     5798
  Branches          ?      666
=========================================
  Hits              ?     4835
  Misses            ?      804
  Partials          ?      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12fa75f...20828af. Read the comment docs.


Add outage costs analogous to curtailment

Include option to not meet the full demand at a defined price analogous to curtailment.

Feature was added in 0.8.2


Support for PyTorch 2.0+

Hi,
Thanks for releasing this very interesting model!
I see that the current code only works for PyTorch 1.10.1 ~ 1.13.0. Would you also consider supporting newer PyTorch versions such as 2.0+. It would be very helpful for people who only have PyTorch 2.0+ in their environment as they don't have to install a new environment for running this evaluation.

Thanks for the great suggestion!
I initially restricted the code to PyTorch < 2 to avoid warnings, but it turned out to be a false alarm.
So I have updated the supported PyTorch version as you pointed out.
See the pull request below for more details.
https://github.com/Takaaki-Saeki/DiscreteSpeechMetrics/pull/3
So please try the latest version. If you have any other issues, please let me know.


Fix circuit.append() to use protocols.commute to verify if two operations can be "crossed" or not.

Description of the issue
Since #4870 breaks the assumption that two operations acting on disjoint qubits always commute, circuit.append() should use protocols.commute to find the leftmost moment in which an operation can be inserted.
As part of the work done for CCO, this was implemented by adding a special case of checking whether the current operation is a CCO and if yes, whether the previous moment has a measurement with matching control keys.
https://github.com/quantumlib/Cirq/blob/90679d27e0967c0a7fe59848e789a5d6ba49b66d/cirq-core/cirq/circuits/circuit.py#L1972-L1975
This is problematic because it works only in one direction and breaks optimizers which relies on doing operations on the circuit in reverse order.
How to reproduce the issue
>>> import cirq
>>> q =  cirq.LineQubit.range(2)
>>> c = cirq.Circuit(cirq.Moment(cirq.X(q[0])), cirq.Moment(cirq.measure(q[1], key="m")), cirq.Moment(cirq.X(q[0]).with_classical_controls("m")))
>>> print(c)
0: ───X───────X───
              ║
1: ───────M───╫───
          ║   ║
m: ═══════@═══^═══
>>> cirq.AlignLeft().optimize_circuit(c) # Works as expected.
0: ───X───X───
          ║
1: ───M───╫───
      ║   ║
m: ═══@═══^═══
>>> cirq.AlignRight().optimize_circuit(c) # Does not work as expected because implementation depends on inserting operations in the reverse circuit.
>>> print(c) # Wrong output
          ┌──┐
0: ───X────X─────
           ║
1: ────────╫M────
           ║║
m: ════════^@════
          └──┘

Cirq version
0.14.0.dev

Cirq sync: we support the general idea here (ensure append works in both directions), but we need to be careful about using protocols.commute for it. For example, appending X(q1) after CX(q0, q1) should keep the X after the CX, even though the two commute.


Deserialize empty file to struct containing no required fields

... even though there are no non-optional fields in the struct.
Or any fields at all, for that matter.
Attempting to deserialize an empty file (or a file containing only newlines) produces the following error:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: EndOfStream', /checkout/src/libcore/result.rs:916:4

IMO deserializing an empty file should succeed as long as there are no required fields in the struct.
(I'm using serde_yaml 0.7.3)

Thanks! I changed the title because I was not able to reproduce the panic -- probably the panic is coming from an unwrap() in your code.
I would welcome a PR to support deserializing an empty YAML input to a struct containing no required fields.

A minimal test case:
fn main() {
    let value: serde_yaml::Value = serde_yaml::from_str("").unwrap();
    println!("value = {:?}", value);
}

Should result in a YAML null, I think (the spec isn't too clear here, IMO), but instead panics. (PyYAML, for comparison, returns None/null.)
In my case, the file isn't literally empty, but contains only comments.
I tried to coerce the value by doing from_str("!!map") … PyYAML errors on that (it wants a mapping to follow the !!map) but it parses in serde_yaml … to a String(""), which also seems wrong.

I'd like to write a PR for this, but I'm not familiar with serde internals. I added some tests to get started.
In the case of a completely empty document (no --- document start) the event loader will be totally empty. Looking at the code it looks like src/de.rs:1039 is the cause for failure for a completely empty document. But I'm not sure how to detect whether or not the type we're deserializing T is tagged as #[serde(default)], if that makes any sense. Any advice would be appreciated.

So I've looked into this too and I have a bit more information on the matter. The #[serde(default)] annotation is handled by serde and we don't have access to a restriction like T: Default either of course. So my understanding is that we'd have to step through the deserializers in a way that constructs a proper, but empty, value.
The deserializer called first for an empty file is deserialize_map, so that's already nice since a map can be empty (in theory). Of course we can't just construct an empty value since there's only access to V::Value from the visitor, no concrete type. But it turns out patching this line to return None on end_of_stream will help out a bit.
Since this is an interruption in an active map, that means that end_mapping will fail though, but it's simple enough to temporarily disable that error here.
At this point it's possible to just call return self.visit_mapping(visitor); whenever self.next() returns an error in deserialize_map and I think that should have successfully created an empty mapping. The tests all still work too, but the problem still isn't solved.
And this is where I don't quite understand what's going on. Next the deserialize_any method is called, but I'm not sure why. And making any significant changes here just blows everything up.
Obviously the other changes also change serde_yaml's behavior, so it would for example not error correctly anymore when reaching EOS in the middle of a mapping. So I'm relatively certain this is the wrong approach, but there's just enough indirection that the solution isn't quite clear to me.
@dtolnay are you aware of which are of code this change is likely required to touch? I've seen that toml which handles things properly seems to take a completely different approach to serde (it uses deseralize_any to just create a map for everything) so hopefully this can be solved without a complete rewrite? From the code I've touched it seems like things just blow up all over the place with an empty stream.

It would be helpful for us if at least the error raised when an empty document is detected (if I'm interpreting this code correctly) was a different error type and distinguishable from other unexpected EOF cases.

This is fixed in 0.9.
use serde::Deserialize;

#[derive(Deserialize, Debug)]
struct Struct {
    optional: Option<String>,
}

fn main() -> Result<(), serde_yaml::Error> {
    let value: Struct = serde_yaml::from_str("")?;
    println!("{:#?}", value);
    Ok(())
}

Struct {
    optional: None,
}


build(tools): test-filter: improved compatibility

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (30379b2) to head (74fa105).

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #58    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           76         5    -71
  Lines         1328       415   -913
==========================================
- Hits          1328       415   -913

Flag
Coverage Δ

gi
?

optional
100.00% <ø> (ø)

result
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

coverage: 100.0%. remained the same
when pulling 74fa105f668228b51d5a102da311afaecea93a40 on feature/tools-1
into 30379b277d823811d91043c2e60ad8cfcb783aa8 on main.


Push workflow status to Loki

Push workflow status to Loki to make it easier to monitor CI stability over time. Unfortunately there is no wildcard support for workflow_run trigger, so we need to explicitly list individual workflow names.
Signed-off-by: Michi Mutsuzaki<EMAIL_ADDRESS>

no need for the full CI run since this only takes effect once it's in the default branch. marking as ready to merge.

Should this be backported to the stable branches? We still seem to be using slack notification there (noticed while reviewing https://github.com/cilium/cilium/pull/21443).


Optimization: don't request API status on every route change

It probable makes sense not to check it again if we have checked it within 30 seconds or so, but I don't think completely disabling re-checking would be a good idea, since a lot of time might have passed since the last route change, and the network connection could have gone down, etc.


arrangedSubviews is not behaving as expected.

From Apple's doc:

The stack view ensures that the arrangedSubviews array is always a subset of its subviews array. Therefore, whenever the addArrangedSubview: method is called, the stack view adds the view as a subview, if it is not already. Whenever an arranged view’s removeFromSuperview method is called, the stack view removes the view from its arrangedSubview array.

I've just found it to be true.


what the license?

Describe
I recommend using GNU GPLv3

Hmm. I copied (translated from javascript) some code into this script from a MIT licensed code, so maybe a MIT license would be easier for the whole script.


Edit address url

What is the location of your example repository?
0
Which package or tool is having this issue?
Hydrogen
What version of that package or tool are you using?
0
What version of Remix are you using?
0
Steps to Reproduce
Edit any address
Expected Behavior
Only id in the url
Actual Behavior
Right now we are encoding
'gid://shopify/MailingAddress/9586653495623?model_n…XsbduYzRGDLmEa1SN9RHx53h1y-B2nb106uljrZ6aErnokDXb'
in the url when clicking edit address in the account page, looks ugly! and it shouldn't be needed, just<PHONE_NUMBER>623 should be fine.

Hi @jamalsoueidan, thank you for pointing this out. We'll be improving the demo store implementation in the future, and probably fix this. In the mean time, the demo store is just a demo, and you are free to update and change the code however you like!

Hi @jamalsoueidan, thank you for pointing this out. We'll be improving the demo store implementation in the future, and probably fix this. In the mean time, the demo store is just a demo, and you are free to update and change the code however you like!

Demo or not, good patterns should used :)


Consider adding generated sources into OpenSSL release or source tree

Background
I'm working on OpenSSL wrap for Meson build system and there are things that could be done upstream that would help massively.
NOTE: I'm not asking to add alternative build system to OpenSSL here, just to facilitate its support with generally useful changes.
The implementation approach I took actually comes from Node.js (and abuses Node.js implementation): https://github.com/nodejs/node/tree/v16.6.0/deps/openssl
The basic idea there is to generate everything into header and assembly files upfront, such that it is possible to build those files later with any build system (GYP in case of Node.js or Meson in my case).
The biggest issue here is Perl scripts that generate a bunch of platform-specific assembly files. Since those files are not a part of upstream release, they need to be bundled with Meson wrap and thus raise security-related questions.
Request
It would make things much easier if OpenSSL release tarball (or even source tree) included pre-generated files in a similar way to what Node.js does, such that there is no need to rely on external generators and no need to verify whether generated sources correspond to the upstream release. At least ASM files would be nice to have as the first step.
Impact
I think this will simplify not only Meson integration I'm working on, but also CMake integration that I know others support and will generally reduce the barrier for OpenSSL usage for many projects.

Note that as statically defined source code which is machine generated, it's fairly common for projects to ship this sort of thing in their make dist equivalents, e.g. by specifying the files as EXTRA_DIST in autotools. Same with prebuilt manual pages. In fact, autotools also internally does this to ship the generated build system produced from *.am and configure.ac
Doing so will, as a general rule of thumb, save work by the consumer and in most cases reduce build dependencies in one way or another.
In this case it allows the python-based meson build system to avoid also having a dependency on perl in the compilation rules.

Do you imply the asm generation for all the supported platforms?

Yes, all supported platforms.
In the initial Meson wrap linked above following were included (and Meson generally doesn't support all platforms OpenSSL does), but I don't see why others shouldn't be generated upstream:

BSD-x86
BSD-x86_64
darwin64-arm64-cc
darwin64-x86_64-cc
darwin-i386-cc
linux32-s390x
linux64-mips64
linux64-s390x
linux-aarch64
linux-armv4
linux-elf
linux-ppc
linux-ppc64
linux-ppc64le
linux-x32
linux-x86_64
solaris64-x86_64-gcc
solaris-x86-gcc
VC-WIN32
VC-WIN64-ARM
VC-WIN64A

It is quite likely that some of them can only be generated on a native host.  Nobody has checked AFAIK.

For platforms above + aix-gcc and aix64-gcc it is certainly possible because Node.js already does it. Can't say anything about others as I have not tried it.
Even in case it is not possible to generate sources for some platforms, the number of platforms for which it is possible will be a significant improvement if implemented.

Currently, this would have to be in form of pre-generated work files on a per config basis.  Because we don't have any indication of the config in the generated asm file names, we may have overlapping file names but with slightly different contents, depending on flavors used when generating the asm files, so having all variants at once is risky if not impossiible with our current file names.
However, it would be perfectly possible to generate them, one config at a time, and capture each in a suitably named tarball, which could then be layed over the usual OpenSSL source tree.
[this is food for thought...]

Node.js stores each platform in a separate subdirectory to avoid any conflicts, but only supports one config for each: https://github.com/nodejs/node/tree/v16.6.0/deps/openssl
Is there really any variation in ASM files depending on configuration within the same platform?

Is there really any variation in ASM files depending on configuration within the same platform?

Not necessarily, but just to pick an example crypto/bn/asm/x86_64-gf2m.pl will result in the exact same assembler file name for many different platforms.

Node.js stores each platform in a separate subdirectory to avoid any conflicts, but only supports one config for each: https://github.com/nodejs/node/tree/v16.6.0/deps/openssl

The same could be achieved by creating build directories for each config as subdirectories of the source directory, or parallell to the source directory, and bundle that all together.
After configuring each of them, make build_all_generated is the command needed to generate all generatable files (that includes the assembler stuff)

@nazar-pc given that we've arrived at some consensus on https://github.com/openssl/openssl/issues/16812
Does it make sense to keep this around, or would you prefer to make a new issue for asm source generation once you have a PR in place for a new build system, and you know better how you might better know how said future build system can make use of our current perlasm?

I'd say this is a sub-task of implementing any second build system in OpenSSL, regardless of whether it is Meson or CMake or something else. And it is something that probably should be submitted as a separate PR. With that context I do not see why this issue should be closed, but let me know if you have a different point of view.

No, keeping it open is fine by me, but if you agree to take on the creation of a Pr in https://github.com/openssl/openssl/issues/16812 , I think it would make sense to mark this as a community issue for you to tackle as well (though this probably will have to have its own set of discussions, as this will have implications to our release process)

Community issue is fair. While I don't have the bandwidth to tackle the issue myself, I can try to organize someone to start making progress by upstreaming Meson wrap piece by piece. Adding generated sources will help both Meson wrap downstream and Node.js since they are doing generation themselves and might be interested in contributing upstream.
@RafaelGSS and @lpinca, I see you were reviewing OpenSSL upgrade PRs in Node.js recently, would you or maybe someone you know among Node.js contributors or maintainers be interested in this issue? This should reduce downstream maintenance burden for you folks and help others in the process as well.

Ok, I'll mark this and #16812 as community issues, please assign them as soon as you are able


3.2 and 3.3 were retired long back

@prashanthmadi : Thanks for your contribution! The author, @bhanupr, has been notified to review your proposed change.

@prashanthmadi Thanks for your eagle eyes and fixing this old text. We appreciate the help!
#sign-off
cc: @mamccrea

@JasonWHowell: I'm sorry - only the author of this article, @bhanupr, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@GitHubber17 : Thanks for your contribution! The author, @bhanupr, has been notified to review your proposed change.


Update Options.js

cleaned up various comments.

Thanks for fixing all the comments.
To accept this you also have to sign the Google CLA and add yourself to AUTHORS. See https://github.com/google/traceur-compiler/blob/master/CONTRIBUTING.md for more details.
Assigning to @johnjbarton since only Googlers can verify that you have signed the CLA.

Done. Thank you Erik!
On Tue, Jan 26, 2016 at 9:21 PM, Erik Arvidsson<EMAIL_ADDRESS>wrote:

Thanks for fixing all the comments.
To accept this you also have to sign the Google CLA and add yourself to
AUTHORS. See
https://github.com/google/traceur-compiler/blob/master/CONTRIBUTING.md
for more details.
Assigning to @johnjbarton https://github.com/johnjbarton since only
Googlers can verify that you have signed the CLA.
—
Reply to this email directly or view it on GitHub
https://github.com/google/traceur-compiler/pull/2069#issuecomment-175403506
.


Dispatch CLI - Evaluate entity extractions

Currently only intents are evaluated and reported in Summary.html.  Dispatch CLI should also evaluate entity extractions.

Closing this for now, will reevaluate with new tool work.


Update readme for clarity on retrieve calls

As discussed in #280 this PR slightly changes the wording in the readme to clarify that a single call will not return all available results from the API but rather the first page of results.

Thanks! Not sure why it failed — prob old versions of ruby no longer supported on Travis or something.


When adding datasources or graphs using the Add button, a space will always be added

When pressing the Add buttong for "Graph Selector" on the Nodes Screen or "Graphs Selector" and "Data Soiurce Selector" on Link screen a space will be added to the front of the "Data Source(s)" and "Hover Graph URL(s)" even when the field is empty.
The expected behaviour is that for the first/initial item ( field is still empty ), there will be no additional space added.

This has been resolved here: https://github.com/TheWitness/plugin_weathermap/commit/aaf9ce9b92194f75a9d4f18b11d4ce34bf944f0f


Use ALSA for Linux

OpenAL is a kind of overkill and I want to avoid unnecessary dependency.

See also http://0pointer.de/blog/projects/guide-to-sound-apis.html

Is ALSA available on Android?
https://source.android.com/devices/audio/

Note: If you use ALSA, we recommend external/tinyalsa for the user portion of the driver because of its compatible licensing (the standard user-mode library is GPL-licensed).

Now @faiface is working on this issue.


[Hexagon] [runtime] Support VTCM alignments of 128 or 2k

In order to simplify the dynamic VTCM memory pool, it will support the following alignments:
2k boundaries, allocated from the front of the pool in the smallest open spot possible.
128 byte boundaries, allocated from the end of the pool.
Made this support explicit, modified test to hit these boundaries.
cc:  @kparzysz-quic, @supersat, @csullivan

@tvm-bot rerun