Support Resource Based Policy for DynamoDB

Description of your changes
Support Resource Based Policy for DynamoDB tables
I have:

[x] Read and followed Crossplane's [contribution process].
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested
Tested locally using Uptest, verified that the resource policy get created for the DynamoDB table:
NAME                                    SYNCED   READY   EXTERNAL-NAME   AGE
table.dynamodb.aws.upbound.io/example   True     True    example         3m7s

NAME                                             SYNCED   READY   EXTERNAL-NAME   AGE
resourcepolicy.dynamodb.aws.upbound.io/example   True     True    example         3m7s

/test-examples=examples/dynamodb/v1beta1/resourcepolicy.yaml
@ShayYannay Unfortunately you won't be able to trigger this yourself until after your first PR is merged.

/test-examples="examples/dynamodb/v1beta1/resourcepolicy.yaml"

Each individual commit needs to be signed off. The output of the DCO job will tell you how to fix it.

/test-examples="examples/dynamodb/v1beta1/resourcepolicy.yaml"

/test-examples="examples/dynamodb/v1beta1/resourcepolicy.yaml"

@mbbush I have read some nice documentation on how upjet use cross resources dependencies, from what I understand  the generated examples use the terraform registry in order to correlated between the resources (e.g resource policy to table in DynamoDB):
https://github.com/crossplane/upjet/blob/main/docs/configuring-a-resource.md#cross-resource-referencing

Tried to add Type in config.Reference explicitly to DynamoDB table (e.g https://pkg.go.dev/github.com/upbound/provider-aws/apis/dynamodb/v1beta1#Table) saw the make generate did not changed anything since the generated code already automatically inferred the Type
Saw that in the terraform registry for dynamodb policy the example is missing aws_dynamodb_table e.g the generated example for resource policy does not include the table as depended manifest.
I suspect that the external name for resource policy create some trouble correlating between ResourcePolicy and Table managed resources.
I used in my code "aws_dynamodb_resource_policy": config.IdentifierFromProvider, and put it under TerraformPluginFrameworkExternalNameConfigs (saw that its framework and not sdk according to the terraform source code), but could be that this configuration is also wrong since resource policy attached to table is not IAM resource rather than configuration to the Table, another assumption is the terraform state used to parse the arn is missed because of this configuration.

Please advise, thanks!

@mbbush Finally figured it out!!
The resource policy id in dynamodb is equal to the dybamodb table arn, e.g the external name should be from template (see my last commit), able to understand that by looking carefully at the terraform state file on the id property.
I've ran Uptest locally and now it pass

I've pieced together what the error message means now.
It strikes me as potentially relevant that none of the existing framework providers use the IdentifierFromProvider external name config. It looks like there's some bug in the upjet Framework client that sends invalid read requests when the resource has not yet been created. I can try to track that down separately from your PR.
As far as what external name configuration you should use, I'd recommend config.TemplatedStringAsIdentifier("", "{{ .parameters.resource_arn }}"),
This will result in the resource not reconciling at all until after it's resolved the reference to the dynamodb table it's referring to, and then as soon as that's done, it will know that's supposed to be the terraform id. The "" is simply to indicate that there's no field in the resource's spec that should be removed and replaced with the external name.
Can you make that change, rebase, and run codegen again, and then I can uptest it in github actions?
One development practice that I try to follow when working on this provider is to put all of the generated changes in separate commits. Then when I'm rebasing, I can just drop all of those commits, not have to deal with conflicts in generated files, and just rerun make generate.

Thanks! @mbbush I will follow your recommendations and change that.

@mbbush tried changing in config/externalname.go
from "aws_dynamodb_resource_policy": config.TemplatedStringAsIdentifier("name", "arn:aws:dynamodb:{{ .setup.configuration.region }}:{{ .setup.client_metadata.account_id }}:table/{{ .external_name }}"),
to "aws_dynamodb_resource_policy": config.TemplatedStringAsIdentifier("", "{{ .parameters.resource_arn }}"),
However got this error when running make generate:
angryjet: error: error loading packages using pattern ./...: provider-upjet-aws-dynamodb-rbp/apis/dynamodb/v1beta1/zz_generated.resolvers.go:194:62: mg.Spec.InitProvider.ResourceArn undefined (type ResourcePolicyInitParameters has no field or method ResourceArn)
exit status 1
apis/generate.go:34: running "go": exit status 1
09:30:33 [FAIL]
make[1]: *** [go.generate] Error 1
make: *** [generate] Error 2

Do you know why?

If you delete all the generated resolvers files before running make generate, you won't get that error.

Got it I will check it out thanks

Hi @ShayYannay,
Many thanks for your effort in this PR. Would you like to move forward with this PR?
If you have not time to work on this, please let us know.

/test-examples="examples/dynamodb/v1beta1/resourcepolicy.yaml"

/test-examples="examples/dynamodb/v1beta1/resourcepolicy.yaml"

Covered in https://github.com/crossplane-contrib/provider-upjet-aws/pull/1392

@turkenf thanks for reaching closure on this PR, I was busy with other tasks, saw the new PR in here
I'll be glad to contribute to this great project in the future if we stumbled on aws provider features that integrate in our work.
@mbbush many thanks for the guidance in this PR.


Globalfunctions seperated from global constraints

Based on the discussion in #343, I did split the GlobalConstraint and NumericGlobalConstraint classes. I renamed the NumericGlobalConstraint to GlobalFunctions, as this was the main point of splitting them, that they are not really constraints. I have strong feelings about keeping the name GlobalConstraint for the boolean global expressions, as it is a well-established name in CP community.
I think this PR has to be merged before #335 so the necessary changes can be done there to.

It is ready after updating it with the new master (decomposing in tree etc) and can be merged

Looks good to me, merged with master, let's see what the online checks say.

Allright, let's merge?


[TextField] FormHelperTextProps component prop error in TypeScript

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
I am trying to replace the FormHelperText component used by a TextField with my own variant but am getting a TS error when attempting to override the component prop. Here is the code:
// Custom helper text component
const HelperText = ({ children }: FormHelperTextProps) => (
  <Stack direction="row" spacing={0.5} alignItems="center" sx={{ p: 1 }}>
    <ErrorOutlineIcon color="error" />
    <Typography component="span" variant="body2" color="error">
      {children}
    </Typography>
  </Stack>
);

<TextField
  label="Enter some stuff"
  defaultValue="Hello"
  helperText="Hello, world!"
  // ts(2322) error here
  FormHelperTextProps={{ component: HelperText }}
/>

The full TS error is:
Type '{ component: ({ children }: FormHelperTextProps<"p", {}>) => JSX.Element; }' is not assignable to type 'Partial<FormHelperTextProps<"p", {}>>'.
  Object literal may only specify known properties, and 'component' does not exist in type 'Partial<FormHelperTextProps<"p", {}>>'.

The code works and I get my fancy helper text replacement but I cannot fix the TS error.
Expected behavior 🤔
I would expect to be able to override the component prop of FormHelperTextProps to replace the implemenation.
The MUI docs state:

The component used for the root node. Either a string to use a HTML element or a component.

https://mui.com/material-ui/api/form-helper-text/#props
Steps to reproduce 🕹
https://codesandbox.io/s/upbeat-lamarr-z7f72d?file=/src/App.tsx
Context 🔦
I want to customise the component used to render TextField helperText.
Maybe there is another way to do this without incurring the wrath of TypeScript?
Your environment 🌎
@mui/material 5.8.4

Seems to be related to this:
https://github.com/mui/material-ui/issues/27703
And maybe more. Looks like there's no workaround other than ts-expect-error 🤷♂

Also related to #32392 and #32872

any updates on this?

any updates on this?

@auduongtuan There is a fix provided in #35924.

any updates on this?

@auduongtuan There is a fix provided in #35924.

It doesn't really fix the issue. The component prop now only allows 'p' | undefined. Is this intended or still broken?
Updated the codesandbox of @robcaldecott here: https://codesandbox.io/s/rough-tree-cxvcgc

@JanPretzel this will be fixed in https://github.com/mui/material-ui/pull/38084

The issue is solved for the standard component prop on a mui component.  However, its still a regression for styled components as passing the component prop causes a type error.  Since it worked previously, can we revert again till the styled case is fixed?
Let me know if a new issue would help.
See updated sandbox - https://codesandbox.io/s/nifty-paper-gqcq77?file=/src/App.tsx


Flash messages do not work on index when no user is logged in.

This is most noticeable when a user creates an account. Normally a flash message should appear, but flash messages are stored in the session, which we drop to prevent cookies. The user is left with no instructions regarding the email they will then receive.
Storing them server side is a potential memory leak. They have to be stored in the session. As a temporary fix, I am changing the manage_cookies plug to not drop the session if it detects a flash in the session, as well as if the user is logged in.

When a user creates a new account he/she accepts that we use cookies. So your solution is fine.
In addition please have a look at https://github.com/vutuv/vutuv/commit/280ae5a419028e7f1947e17d51925c5909b11414
=> I changed the workflow so that a users#create will lead to a different page. I feel that this is easier to understand for a new user than to have the same index page again.


Livestreamer and Twitch problem.

If i try to open a stream from twitch nothing happens. The command line just says:
error: no plugin can handle URL : best
livestreamer twitch.tv/faceittv best, is this correct?

I had to use the token oauth. Now it's working. No idea why.


feat: show fen position when encountering an illegal pv move

closes https://github.com/Disservin/fast-chess/issues/477

I don't see much value in having the Command there


Update cache-failover.md

AzureRedisEvents is only available for Basic, Standard and Premium Tiers and not for Enterprise/Enterprise Flash, hence proposing documentation update for the same

@Amrinder-Singh29  - I pulled this into an internal PR and published it after a few edits.

@flang-msft - Can we close this PR?


ci: Drop .github/ directory with workflows

We use travis and tox so the github workflows are not needed
currently.
Signed-off-by: Thomas Bechtold<EMAIL_ADDRESS>

We have the same over at https://github.com/SUSE/sesdev and I thought about deleting this directory, but then it occurred to me:

what if the GitHub workflows become available again, and in the meantime we have forgotten that we had code in the repo to use them?

In this case, I can easily envision someone "reinventing the wheel", whereas if we keep the code in the repo (it does no harm to carry it), this "reinvention of the wheel" cannot happen because whoever decides to re-implement GitHub workflows will see the directory containing the code.
If we delete the code, people would have to (1) know or suspect that the code used to be present, and (2) search the git history for it, and I'm not confident both of these would happen.

@smithfarm so should I close the PR?

@smithfarm so should I close the PR?

I personally don't see a compelling reason to rip out this directory right now. If you prefer, you could keep the PR open - maybe others will weigh in?

What about keeping those files in the repo, but adding a .github/workflows/README.txt file that explains we are not using it? Something equivalent to:
Github workflows are not being used ATM (travis and tox are being used instead)

Closing in favor of https://github.com/ceph/ceph-salt/pull/178


[SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

What changes were proposed in this pull request?
This PR tries to use MemoryBlock in OffHeapColumnVector. There are two advantages to use MemoryBlock.

Has clean API calls rather than using a Java array or PlatformMemory
Improve runtime performance of memory access instead of using Object with Platform.get/put....

** TODO: I will add result of ColumnarBatchBenchmark **
How was this patch tested?
Used existing UTs

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1680/
Test PASSed.

Merged build finished. Test PASSed.

Test build #88468 has started for PR 20874 at commit dec5e51.

Test build #88468 has finished for PR 20874 at commit dec5e51.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88468/
Test FAILed.

retest this please

Test build #88473 has started for PR 20874 at commit dec5e51.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1683/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1689/
Test PASSed.

Test build #88483 has started for PR 20874 at commit dec5e51.

Test build #88473 has finished for PR 20874 at commit dec5e51.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88473/
Test FAILed.

Merged build finished. Test FAILed.

Test build #88483 has finished for PR 20874 at commit dec5e51.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88483/
Test PASSed.

Test build #88966 has finished for PR 20874 at commit 0112d03.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88966/
Test FAILed.

Merged build finished. Test FAILed.

Test build #88971 has started for PR 20874 at commit 0112d03.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2028/
Test PASSed.

Test build #88971 has finished for PR 20874 at commit 0112d03.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88971/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2048/
Test PASSed.

Test build #88993 has finished for PR 20874 at commit 0112d03.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88993/
Test FAILed.

Test build #89014 has started for PR 20874 at commit 9ef19df.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2063/
Test PASSed.

Test build #89014 has finished for PR 20874 at commit 9ef19df.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89014/
Test PASSed.

retest this please

Test build #89149 has started for PR 20874 at commit 9ef19df.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2175/
Test PASSed.

Test build #89149 has finished for PR 20874 at commit 9ef19df.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89149/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #89168 has started for PR 20874 at commit 9ef19df.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2190/
Test PASSed.

Test build #89168 has finished for PR 20874 at commit 9ef19df.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89168/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2205/
Test PASSed.

Test build #89190 has started for PR 20874 at commit 9ef19df.

Test build #89190 has finished for PR 20874 at commit 9ef19df.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89190/
Test FAILed.

retest this please

Test build #89203 has started for PR 20874 at commit 9ef19df.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2218/
Test PASSed.

Test build #89203 has finished for PR 20874 at commit 9ef19df.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89203/
Test FAILed.

retest this please

Test build #89214 has started for PR 20874 at commit 9ef19df.

Test build #89214 has finished for PR 20874 at commit 9ef19df.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89214/
Test FAILed.

retest this please

Test build #89231 has started for PR 20874 at commit 9ef19df.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2235/
Test PASSed.

Merged build finished. Test PASSed.

Test build #89231 has finished for PR 20874 at commit 9ef19df.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89231/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2249/
Test PASSed.

Test build #89250 has finished for PR 20874 at commit 9ef19df.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89250/
Test FAILed.

retest this please

Test build #89263 has started for PR 20874 at commit 9ef19df.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2261/
Test PASSed.

Test build #89263 has finished for PR 20874 at commit 9ef19df.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89263/
Test FAILed.

retest this please

Test build #89281 has started for PR 20874 at commit 9ef19df.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2277/
Test PASSed.

Test build #89281 has finished for PR 20874 at commit 9ef19df.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89281/
Test PASSed.

Test build #89325 has started for PR 20874 at commit 088ac7d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2305/
Test PASSed.

Test build #89325 has finished for PR 20874 at commit 088ac7d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89325/
Test PASSed.

Test build #104818 has started for PR 20874 at commit 088ac7d.

Test build #104818 has finished for PR 20874 at commit 088ac7d.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104818/
Test FAILed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15768/
Test PASSed.


fix: Allow overriding server fetch dependency (#9803)

Fixes #9803 by allowing custom fetch invalidation dependcy in server load which prevents default behavior of exposing all (including private) urls to clients.

Used svelte key for providing custom dependency string in fetch, similar to how Next.js does.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

closing in favour of #9945


Do some code cleaning

Looks already quite good!
I did some reindentation, avoided some code repetition and avoided lines with more than 80 character. Would you like to merge? (not checked on my side!)

Thanks @hsonne LGTM. Just added kwb.utils::catIf() to the NAMESPACE file by adding @importFrom kwb.utils catIf  to the relevant R code (see: https://github.com/KWB-R/kwb.site/pull/2/commits/3421ac93e2adc24371d4528b83b86d47fa3fe97f)


chore: add quick-setup docker compose to run APIM with openSearch

https://github.com/gravitee-io/issues/issues/6423
add quick-setup docker compose to run APIM with openSearch

Gravitee.io Automatic Deployment
📚 View the storybook of this branch here

Gravitee.io Automatic Deployment
Congrats, all the CI steps were 🟢 . The Bot was able to deploy the build of this PR, so you can now try it directly here! 🚀
Notes: The deployed app is linked to the management API of the Element Zero team's environment.

Gravitee.io Automatic Deployment
📚 View the storybook of this branch here

Gravitee.io Automatic Deployment
Congrats, all the CI steps were 🟢 . The Bot was able to deploy the build of this PR, so you can now try it directly here! 🚀
Notes: The deployed app is linked to the management API of the Element Zero team's environment.

Gravitee.io Automatic Deployment
📚 View the storybook of this branch here

Gravitee.io Automatic Deployment
Congrats, all the CI steps were 🟢 . The Bot was able to deploy the build of this PR, so you can now try it directly here! 🚀
Notes: The deployed app is linked to the management API of the Element Zero team's environment.

Gravitee.io Automatic Deployment
📚 View the storybook of this branch here

Gravitee.io Automatic Deployment
Congrats, all the CI steps were 🟢 . The Bot was able to deploy the build of this PR, so you can now try it directly here! 🚀
Notes: The deployed app is linked to the management API of the Element Zero team's environment.


Removed set and get hostname functionality from miqnet.sh

Removing in favor of using LinuxAdmin.
@Fryguy @jrafanie @kbrock
Requires https://github.com/ManageIQ/manageiq/pull/4558

this is looking good.
You know, systemd is an abstraction that most operating systems are adopting.
Is there a reason we need to build an abstraction above this using linux_admin? Is it possible for us to just call systemd directly?


PCI: Use goto states for state machine handling

Use the goto framework to allow the state machine to properly transition
to allow commands to be run.
Signed-off-by: Deb McLemore<EMAIL_ADDRESS>

Closing, PR #442 incorporates complete fix.


COMMONSRDF-65

https://issues.apache.org/jira/browse/COMMONSRDF-65
Also a small fix for problems building on Mac, and includes https://github.com/apache/commons-rdf/pull/39/ to fix COMMONSRDF-62 (just so that I could build! :) )

Thanks!
This PR mixed up a couple of things which made it a bit tricky to merge - sorry for not merging #39 earlier!
2982446 merged fine and fixes COMMONSRDF-65 -- cheers!  (I'll update RDF4j to 2.2.2 as well)
abdb6ca does indeed fix COMMONSRDF-63 on my OS X machine, but I get now build errors on Windows in your new compareBases:
Tests run: 11, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.28 sec <<< FAILURE! - in org.apache.commons.rdf.simple.experimental.AbstractRDFParserTest
parseFile(org.apache.commons.rdf.simple.experimental.AbstractRDFParserTest)  Time elapsed: 0.079 sec  <<< ERROR!
java.nio.file.InvalidPathException: Illegal char <:> at index 4: file:///C:/Users/stain/AppData/Local/Temp/test2836546964601538785.nt
        at org.apache.commons.rdf.simple.experimental.AbstractRDFParserTest.compareBases(AbstractRDFParserTest.java:139)
        at org.apache.commons.rdf.simple.experimental.AbstractRDFParserTest.parseFile(AbstractRDFParserTest.java:122)

I think this was caused by a dangerous pattern I have spotted with other colleagues - using java.nio.file.Paths to parse relative URI path strings:
Path basePath = Paths.get(baseUri.substring(1, baseUri.length() - 1));

This might work well enough on OSX and Linux, but on Windows : is a special character (C:) and the path separator is \ rather than /.  Paths use the FileSystems.getDefault().
Instead I fixed this with a simple:
assertEquals("<" + testNt.toRealPath().toUri() + ">", firstPredicate(g, "base"));
and then we can avoid the suggested new parseFileSymlink().
(See COMMONSRDF-63)

No, there were no relative URIs being parsed into Paths in my code-- that string munging was to remove the < and > around the URI as retrieved from the RDF. But I'm a-okay with whatever gets a toRealPath() in there (because of the Mac symlinked /tmp) and avoids any confusion over leading slashes. I can see that I created more problems with Windows.
Sorry for mixing things up-- please always feel free to kick stuff back if you feel it's liable to mess up the history or confuse people-- I can always redo the PR!
All speed to 1.0!


[zh] sync 1.24 ref-k8s-api /authorization-resources/self-subject-.md

Accepted localization task in #33798 from @tengqm. This is refer-5 to submit.

Since this has a dependency on 'content/zh/docs/reference/kubernetes-api/authorization-resources/subject-access-review-v1.md', please translate the depended page first and put this on hold.

You don't have to close this one, which is almost ready to be merged.
Just put a '/hold` on it should be okay.

You don't have to close this one, which is almost ready to be merged. Just put a '/hold` on it should be okay.

oh, understood. I don't know how to open two PRs at the same time. The dependency is added here -_!.

@windsonsea
Suppose you propose another PR #123456, you can put an explicit hold on this one: /hold, and add a comment like depends on: #123456.
When #123456 is merged, you then rebase this one on to main and remove the hold (/hold cancel).

@windsonsea
Suppose you propose another PR #123456, you can put an explicit hold on this one: /hold, and add a comment like depends on: #123456. When #123456 is merged, you then rebase this one on to main and remove the hold (/hold cancel).

Got it, thanks. Could I combine three files here at this time? Three clauses are modified here based on your comments in #33963. Feel a little frustrated if failed to rebase and squash commits :)

Preview looks good.
/lgtm
/approve


Update slf4j-nop to 2.0.4

Updates org.slf4j:slf4j-nop from 2.0.3 to 2.0.4.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.0.3).
You might want to review and update them manually.
doc/website/package-lock.json
modules/cli/src/test/scala/coursier/cli/ResolveTests.scala
modules/coursier/shared/src/test/scala/coursier/complete/CompleteTests.scala
modules/tests/shared/src/test/resources/artifacts/com.splicemachine/splice_spark/<IP_ADDRESS>5-SNAPSHOT

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.slf4j", artifactId = "slf4j-nop" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.slf4j", artifactId = "slf4j-nop" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #2600.


Fix docs links for single changes

The links for SingleAddChange or a SingleDeleteChange are broken at https://www.vinyldns.io/api/get-batchchange.html#http-response-attributes-
They should be updated to point to https://www.vinyldns.io/api/batchchange-model.html#singleaddchange-attributes and https://www.vinyldns.io/api/batchchange-model.html#singledeletechange-
The updates need to be made in this file in order to post to the docs: https://github.com/vinyldns/vinyldns/blob/master/modules/docs/src/main/tut/api/get-batchchange.md#http-response-attributes-

Hello there! I would like to help you with that, could I?

@RupeshGoud looks like we already have a PR on this - this issue is still open though https://github.com/vinyldns/vinyldns/issues/260, and is a similar docs fix (maybe a little more typing, but not crazy) if youre interested!


Implement with instance chains

I think as per #9 we probably want to deprecate this library and put these classes with Either/Coproduct, but just thought I'd try this out.
@LiamGoodacre I was a little surprised to find that it didn't raise an error even when these were defined without instance chains until used. I thought purescript/purescript#3129 would have changed that? Maybe I misunderstood.

Ooooh, I will have a play tomorrow and see if I messed something up.  Thanks!

Ack, maybe it was user error on my part then... I did pull master and stack install for sure, but maybe I still did something wrong in there / it was using the wrong PATH or something.
The other thing I thought of, is this version using instance chains can inject into the left or the right, the original definition is biased to one side, so perhaps I tested with that and it failed. I'll try and reproduce again later today, sorry to waste your time!

@LiamGoodacre I figured it out. I did git pull master but not git pull purescript master 🤦♂

Requested changes are addressed in https://github.com/purescript/purescript-inject/pull/11, so you can merge that, then merge this PR later.

Closing as we will move these type classes and instances to functors/either.


Please add "Terminus TTF" font

HI.
I would like to know if you would add the "Terminus TTF" font?
You can find it Here
Thanks in advance
/MrUlmo

Thanks for the link! Can't remember what was wrong with previous versions, but the latest seems to work just fine. It's available in the test driver and in version 2.1.0 of the Fonts package.


Can't go to line with error from problems tab

VSCode Version: Code 1.12.2 (19222cdc84ce72202478ba1cec5cb557b71163de, 2017-05-10T13:20:36.315Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.1.0

ng-template
Angular
0.1.3

python
donjayamanne
0.6.4

xml
DotJoshJohnson
1.7.0

code-runner
formulahendry
0.6.17

vscode-csproj
lucasazzola
0.6.6

csharp
ms-vscode
1.10.0

debugger-for-chrome
msjsdiag
3.1.2

vscode-icons
robertohuertasm
7.7.0

Steps to Reproduce:

Go to Debug Tab
Click Start Debugging Button
Click at the error show it in problems tab
Get error Unable to open file 'AccountController.cs': File not found (\Controllers\AccountController.cs)
Click Create File

So the problem is that the file is created in C:\Controllers\AccountController.cs, but there is not my project folder and i cant go to error line by clicking the error in the problems tab.

This issue was moved to OmniSharp/omnisharp-vscode#1519

@DavoBR
Could you see if my answer on https://github.com/OmniSharp/omnisharp-vscode/issues/1519 can solve your problem?


Not toggleable Integrated Resource Pack

I don't know why but the integrated resource pack named "supporteatinganimation" in resource pack folder of the mod is automatically active and i didn't find any other way to deactivate it than to delete it from the jar.
I tested with clean fabric install with only your mod.

?

as you can see here there isn't the arrow to disable the pack like there is on another integrated resource pack from another mod

Why do you want to turn it off?

Because it only contains foodplusid things that aren't useful and if it's not intended to be toggleable put all the things with the other textures so it doesn't take space on the resource pack selection screen

Btw i think you should make all the textures toggleable so if for any reason you want to disable the mod you can disable the resource pack. And in addition to that as i need to have a texture pack that will override your whole textures so it permit to lessen the work MC has to do if i could disable your textures when enabling my owns.

@Julienraptor01 that resource pack for cloak fix is unnecessary since you can have that from vanillatweaks pack and it doesn't need CEM to work :D

@EGOIST1372

sadly the cloak fix pack from vanilla Tweaks doesn't fix the models but instead simply remove pixels from only the villager texture and not from other affected mobs
But this isn't related at all to my issue
(btw if you want ot take a look at what this pack does it's made by me so you can find by searching cloak fix through my repos)

The multiple pack that you can see with an icon that ressemble to VT's one are private custom packs made by me that integrates many VT Tweaks and all have differents purposes

oh cool thanks for info :D


fix github topic

@levithomason Please update topic from js-libary to js-library 😄

Fixed, good catch :).

Haha, oh my goodness.


YouTube acts like it's in the background when in the app

I'll get straight to the point. Update 2.0.1 shows the notification just like beta, but it also causes autoplay to be instant when you're in the app. Is there any code that can be modified so that the notification is only visible when YT is in the background? I personally keep autoplay enabled so music will automatically play when YT is in the background. But I haven't updated to 2.0.1 because the notification stays active when in the app which causes autoplay to start after I'm finished watching a video.[whilst in the app] Just asking if there's any code that can be modified to fix this issue. Any and all help is greatly appreciated

Actually there is - if you want to make notification visible only in background, build new module apk with changed link to json file to this one https://raw.githubusercontent.com/th3an7/YouTubeBackgroundPlayback/th3an7-BACKGROUND-ONLY/assets/hooks-1.json
It's json from my fork and (as branch name says) it makes notification visible only in background (at least it should :P)

@th3an7 Alright, I've recompiled the apk multiple times but to avail. As soon as I attempt to install it, I'm greeted with the wonderful "App not installed". I really don't mean to put more work on you, but is there a possibility that you can recompile it?

Oops, my bad, sorry... Forgot to tell you that you would probably have
signature mismatch. Have you tried uninstalling old version before
installing that newly compiled by you? Try that first - if it won't work,
let me know so I can build it myself :P
On Sun, Jan 22, 2017, 20:08 SirUltimateBass<EMAIL_ADDRESS>wrote:

@th3an7 https://github.com/th3an7 Alright, I've recompiled the apk
multiple times but to avail. As soon as I attempt to install it, I'm
greeted with the wonderful "App not installed". I really don't mean to put
more work on you, but is there a possibility that you can recompile it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/297#issuecomment-274351461,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxxbCJpW36g0qNKqX70K7RPzrHjCJGKks5rU6kPgaJpZM4Lpxe6
.

Yes, I have tried that, multiple times actually

But no success

Try this one then - https://drive.google.com/file/d/0B8j7vCsf6RXcaUhlU09FRENOYVk/view?usp=sharing

Thanks man, I owe you one!


RBloomfilter need addAll

RBloomFilter only have
boolean add(T object);

@mrniko I would like to add code for this issue. Is it a good idea to loop through the list of objects and call boolean add(T object) inside the loop?
public void addAll(List elements) {
for(T element : elements){
try{
add(element);
}
catch (RedisException e){
if (e.getMessage() == null || !e.getMessage().contains("Bloom filter config has been changed")) {
throw e;
}
}
}
}

@vaibhavdesai16 It's inefficiency. We need a batch mode to add list.

I will work on it.

@vaibhavdesai16 It's inefficiency. We need a batch mode to add list.

Do you have a good solution to this problem?

Implemented in https://github.com/redisson/redisson/issues/5130


added functionality of multiple quotees

Added functionality to create and retrieve quotes from multiple quotes. Also added new quotes by Conor Mcgregor.
Updated and added tests

Codecov Report
Base: 50.81% // Head: 60.81% // Increases project coverage by +9.99% :tada:

Coverage data is based on head (49d4c23) compared to base (1476a14).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #2      +/-   ##
===========================================
+ Coverage    50.81%   60.81%   +9.99%
===========================================
  Files            6        6
  Lines           61       74      +13
===========================================
+ Hits            31       45      +14
+ Misses          30       29       -1

Flag
Coverage Δ

unittests
60.81% <87.50%> (+9.99%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

quotes/quote.py
70.00% <0.00%> (ø)

setup.py
0.00% <ø> (ø)

quotes/quote_engine.py
81.81% <86.66%> (+17.53%)
:arrow_up:

tests/test_quote_generator.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Request

Users should be able to turn off teleport request from Groups..
/grouptpaoff ♥

Just disable it from the configuration file


Add Kubernetes namespace discovery

Description for namespace discovery introduced in  for https://github.com/prometheus/prometheus/pull/2642
@brancz @brian-brazil does this fit the formatting better than https://github.com/prometheus/docs/pull/729 ?

:+1:

Thanks!


Fix headers in README.md

Just noticed there's actually already a PR for this (#56). Closing this one as a duplicate.


Might be of interest: duecredit

https://github.com/duecredit/duecredit
Disclaimer: I am involved
Ran into pvlib for possible integrations of asv into GitHub workflow, saw that you take citations seriously, cared to chime in
Cheers!

Thanks for the suggestion. duecredit looks interesting. I'll keep an eye on the project and adoption and consider adding in the future.


add [jekyll-coffeescript]

I needed to add this to enable conversion. Is it the right way?

Thanks

U r most welcome ;)


Hooks

A before_rsync hook e.g. related to #81, could allow the user to check his key.
A after_rsync could allow the user to set a custom message.

Closed by #89, before hook was not added, since the user can add this on his own.


As a user, I want to view all the content for an individual editorial essay so that I can read analysis and scholarship related to the project.

Included in #370


How to train a new model

Hi, first of all I want to thank you for sharing your work :smiley:  on the other hand, after several attempts, I was wondering what I was missing/misinterpreting on the default.yaml file to train a new model.
The structure of my dataset looked like this:

DataSetX/

ModelCad/

info.yml
obj_Model01.ply
...
obj_ModelXX.ply

TrainSet/

Model01/

rgb/

img00.jpg
...
imgXX.jpg

info.yml

...
ModelXX/

TestSet/

The config.yaml:
data:
dataset_name: DataSetX
path: data/DataSetX
...
input_type: image
...
n_views: 0
n_views_input: 0
pointcloud_chamfer_file: pointcloud.npz
...
img_folder: image
img_folder_input: img_choy2016
...
img_extension: png
img_extension_input: jpg
...
train_split: train
val_split: val
test_split: test
...
Questions:

What are the differences btw. img_folder and img_folder_input?
After modifying both values independently I still got the following error:
"Error occurred when loading field img of model rgb (05)"

Would you recommend to change the number of views value? or it is not strictly necessary?

Since my training set, validation set and cad models are separated in folders, do you consider it easier to change the structure to the structure presented by shapenet?

Thank you for your help,
Lizeth

Hi,
I would suggest you download one of our datasets (e.g. like you mentioned the ShapeNet one), and you write a script which converts the data from your format to our format. Then it should be much easier to adapt the config to your needs - you rather change small things like the image folder name or the image extension in the config, but not structural things like what you mention.
Good luck!

I got the same problem when trying the train.py, with DTU data. I really think there should be something work that people can reproduce the results.


Map will not render if any location is "null"

It raises a confusing CORS error

Fixed in https://github.com/zhaomh1998/InstaFurniture/commit/9322801dc7d57ceb82c451e2c3d8a0f53e90ee20


Update Vector version and related test file changes (#2674)

In 0.7 version of pgvector, there are now new types added. Although we do not support it entirely with this commit, we fix the changes required to the test files. These changes, change in error messages and adding explicit casts while calling a the SQL utility function, are expected and have been updated in the pgvector extension as well.
Issues Resolved
BABEL-5058
Signed-off-by: Kushaal Shroff<EMAIL_ADDRESS>Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.965%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
41850

Relevant Lines:
57356

💛  - Coveralls


Configure the AllContributors bot

Per spec: https://allcontributors.org/docs/en/bot/configuration
I would probably prefer not using README.md, but instead using a CONTRIBUTORS file.

Hmmm, I think we'll stick with the readme for now


Question about image types

Hello,
by default the rpi-sdimg image is built which is defined a separate class. But one could also use thewic option. Since I wanted to add another partition to my build I tried the wic option and it also seems to work. I can still dd on the SD card, like I could before. So why are there two options? Why isn't there just the wic option, where one could easily add for example partitions or similar things? Should I be aware of things that are now different in my build?
Just for completion the bootloader --append= function to add kernel cmdline options in the wic files doesn't work, which is a shame.
Thanks,
Michael

When the sdimg image type was implemented there was no wic in place. Generally, sdimg gave us more flexibility and I, personally, still use it as the main image generation tool. So at this point, I'd say use whatever makes you feel more comfortable.

Alright thanks :)
Good, I don't have to have a bad feeling using wic. Is there any way to get bootloader --append= to work?

That sounds like a question for oe-core. If you figure out something wrong in our configuration, ping me.

I assume it's something wrong with the raspberry layer. For another non-raspberry build I can use the bootloader --append= without trouble. I suspect it's because of the custom bootloader, maybe there is nothing we could to about it. Just want to through it out there, because it would make separating filesystem and kernel stuff easier. Right now I'm using the CMDLINE_append variable in a kernel append recipe for filesystem stuff.
The wic help it states:
* bootloader

      This command allows the user to specify various bootloader
      options.  The following are supported 'bootloader' options:

        --timeout: Specifies the number of seconds before the
                   bootloader times out and boots the default option.

        --append: Specifies kernel parameters. These will be added to
                  bootloader command-line - for example, the syslinux
                  APPEND or grub kernel command line.

      Note that bootloader functionality and boot partitions are
      implemented by the various --source plugins that implement
      bootloader functionality; the bootloader command essentially
      provides a means of modifying bootloader configuration.

you might have to write a wic bootloader source plugin for rpi bootloader.


Metric depth estimation or relative depth estimation？

After watching the video, I want to know whether the output depth imgae result is metric depth or relative depth?
If it is metric depth, how is it obtained?
Thank you

Thank you for opening issue.
This package uses relative depth only.
For your information, the conversation of this issues can help you.

@Redreadblack
Thank you for opening issue.
This package uses relative depth only.
For your information, the conversation of this issues can help you.

ths for your reply, this is what I want


adding Dot Icon to design system. Icon provided by Wilfred Morales

Codecov Report

Merging #494 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #494   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          52     52
  Lines         530    530
=====================================
  Hits          530    530

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63cb450...68f7960. Read the comment docs.

Thanks @jes708. Ping/ @anuj-kapoor , can you check out what Jon observed? (I can still wait for this PR until later today to merge the approved PRs and publish for the week)

Thanks @BeniCheni , The svg Icon was provided by Wilfred Morales, I can probably reach out to Wilfred or @wesleymartin85 , who may be able to look at it

@BeniCheni @jes708 , I updated the svg with new file provided by Wesley. Please review when you get chance, Thanks!

🎊 Landing in 1e93df3.


ffmpeg postprocessor use playlist_index for track metadata when track_number does not set

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[X] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[X] Searched the bugtracker for similar pull requests
[ ] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[X] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[X] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
When using the --add-metadata option and with regard to the ffmpeg postprocessor use playlist_index for track metadata in lieu of track_number when the latter does not exist.
This is a useful behavior to me of which I think would be of use to others. As well, there are also issues filed in regard to this - #13271 and #7393

playlist_index is not related to track numbers in general thus it should not be written as track metadata by default.

Maybe an option then?

Maybe an option then?


Protect from AllocateLoadBalancerNodePorts=false

When aforementioned option is set on the Service .spec, the NodePorts
stop being set, effectively defaulting .spec.ports[*].nodePort to 0. When
cloud provider tries to create a member with such a port, Octavia fails.
This commit makes sure we are not adding members when nodePort value
is 0. We also omit the SG manipulations for such ports.

openstack-cloud-controller-manager (occm)

What this PR does / why we need it:
It's to make sure we are not making requests to Octavia that it cannot fulfill.
Which issue this PR fixes(if applicable):
fixes #1996
Special notes for reviewers:
Release note:
NONE

@mdbooth, you might want to take a quick look here.

/ok-to-test

When aforementioned option is set on the Service .spec, the NodePorts
stop being set, effectively defaulting .spec.ports[*].nodePort to 0. When
cloud provider tries to create a member with such a port, Octavia fails.

do you mind create a bug to track this? just want to keep record and know the impact /reason etc as reference

code looks reasonable @dulek
but I guess if there's more info in the issue talk about AllocateLoadBalancerNodePorts in commit msg will be helpful
as I think it's come from k8s core defintion which lack some background in the PR itself

@dulek could you please help rebase this? Thanks

Don't we also need to add a guard to ensureAndUpdateOctaviaSecurityGroup() as well?
edit: replying to myself, yes, most likely. The code was added in #1984 after you first submitted your PR.

Done, thanks for spotting this!

@jichenjc: Hi! I've updated the commit message a bit, can you take another look at this?

/lgtm
/approve


Prevent the scan results screen from jumping back to the main page

if u ENABLE_NO_SCAN_TIMEOUT
u would also want the scan result to stay on screen until exit key

Ah  I make a mistake  it should be #ifdef  not  #ifndef


Set up system logging

We should set up proper logging in OCELoT apps, and clean up print calls used for logging debug messages.
Logging in development could write to both ocelot.log and to stdout of runserver.

This would be a good first issue 🍰


Auto Commenting when a PR is merged

This feature aims to solve the problem of inconsistent and delayed communication following the merging of PRs. By automating the commenting process, it ensures that contributors receive timely feedback and acknowledgments. It also reduces the administrative burden on maintainers, allowing them to focus more on code reviews and other critical tasks.
Could you please assign me this issue under GSSOC'24.

Please add the label of appropriate level on this issue as per gssoc guidelines.


Add docker containers and release actions

Solves #16, we will have to merge and create release to debug GHA

Then your entry point will be shell and then you write nkv-server "<IP_ADDRESS>:4222" or nkv-client "<IP_ADDRESS>:2222", okay that makes sense, I'll group it all in :) Thanks, Avi!

@deitch this too

Rebased to master so that Cargo.lock is a valid file


hass becomes unresponsive after a few hours

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.39.2
Python release (python3 --version):
3.5.3
Component/platform:
HASS Docker image
Description of problem:
after a few hours, the docker container and hass are unresponsive. The front end shows disconnected. the log no longer reports anything. The log is full of errors like this:
17-03-02 02:27:39 ERROR (Thread-3) [homeassistant.components.sensor.command_line] Timeout for command: python3 /config/sensor/getBIProfile.py
17-03-02 02:27:39 ERROR (MainThread) [homeassistant.core] Timer got out of sync. Resetting
17-03-02 02:27:44 ERROR (MainThread) [homeassistant.core] Timer got out of sync. Resetting
17-03-02 02:27:48 ERROR (MainThread) [homeassistant.core] Timer got out of sync. Resetting
17-03-02 02:27:52 ERROR (MainThread) [homeassistant.core] Timer got out of sync. Resetting
17-03-02 02:28:05 ERROR (MainThread) [homeassistant.core] Timer got out of sync. Resetting
17-03-02 02:28:11 ERROR (MainThread) [homeassistant.core] Timer got out of sync. Resetting
17-03-02 02:28:32 WARNING (Thread-13) [pychromecast.socket_client] Heartbeat timeout, resetting connection
17-03-02 02:28:50 WARNING (Thread-17) [pychromecast.socket_client] Error communicating with socket, resetting connection
Full log here:  https://hastebin.com/gabikeyayo.sql
Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:

Also noticed this running on Docker as well.
Think it is related to #6253 with too many events causing things to slow down to a crawl, and eventually unresponsive.

This has nothing to do with too many events. I think that something is causing high CPU usage, not sure what it could be.

@balloob When #6369 goes live, are there any specific logs/experiments you'd like if I can replicate?

I'm not using the Z-wave component... so it can't be that for me.
I am using nmap device tracker and/or asus router device tracker. I've tried using only one or the other and the issue persists. Could it be either of those? Anything you want to know from my setup or anything you want me to do?

I turned off both nmap and Asus device trackers and I haven't seen the timer out of sync error in a while.

I spoke too soon. It crashed overnight :(

Same issue. Previously running 0.35.3 which was solid. Reverting now to 0.39.2 to reproduce.

Reproduced within hours. Back to 0.38.4.

@markferry did you use pip to downgrade?

Nope, setup.py. Working from git.

In gdb: #0  0x76f51b30 in __pthread_cond_timedwait (cond=0x3c3f68, mutex=0x3c3f98, abstime=0x7ef0d4a4) at pthread_cond_timedwait.c:199
which I'll admit is not exactly surprising.

Backtrace for all threads:
bt.txt
Almost all waiting on OpenZWave.

0.37.0dev0 lasted longer but still died. Should probably also drop my DB tables before the next run.
Back to 0.36.0dev0 (64800fd).

Died again. Bisected back to 0.36.0.dev0 (c14a5fa) now. If this proves fruitless there's also bisecting the config. What joy.

I'm getting the same issue in a docker as well! It is driving me nuts!

These issues have been resolved. Don't want to create a catch all issue so closing this.


[enhancement] add list of models to the api-models page

Currently this page  http://apis-guru.github.io/api-models/ returns 404 errer. It would be great if it had list of links to all the modles in this repo

Here's the link:
http://apis-guru.github.io/api-models/api/v1/list.json
Ivan, maybe redirect to that page from apis-guru.github.io/api-models?
Bobby Brennan
<EMAIL_ADDRESS>On Thu, Nov 5, 2015 at 5:21 PM, Roman Hotsiy<EMAIL_ADDRESS>wrote:

Currently this page http://apis-guru.github.io/api-models/ returns 404
errer. It would be great if it had list of links to all the modles in this
repo
—
Reply to this email directly or view it on GitHub
https://github.com/APIs-guru/api-models/issues/17.

@bobby-brennan I think it rude to show JSON as main page of site.
And I understand use case, Github disable CORS on raw links inside repo.
So if you want to use spec in some online service without proxy you need to make url http://apis-guru.github.io/api-models/ +  which is not so obvious and easy.
I think simple html with links to specs and small text section will satisfy all needs.

I'm not sure but I believe that it's not possible to have redirects on Github pages.

I generally agree with this, there should definitely be something on the root page. But @IvanGoncharov - are you thinking this should be human friendly? Seems so by this comment:

I think it rude to show JSON as main page of site.

If so, I think the main gh-page should default to a simple splash screen of all the models and they should link to the swagger,etc. generated docs with an additional link to the actual json.
Thoughts?

they should link to the swagger,etc. generated docs

I think generating docs is out of scope of this project. I don't want to compete with companies which provide API related service, instead I want to supply them with API specs. So https://any-api.com/ is showing generated docs and https://sdks.io/ is generating SDKs. At the same time I want this project to be vendor-independent so I link them only in this section.
Ideally I want to create main page that explain this project(Reveal.js is good candidate). But I don't have time and knowledge at the moment.
@RomanGotsiy pointed to real problem, at the moment it's hard to guess link to particular Swagger spec.
And thinking about KISS solution, very simple HTML with links like that:
<a href="https://apis-guru.github.io/api-models/googleapis.com/drive/v1/swagger.json">
  googleapis.com/drive/v1/swagger.json
</a>

@brennebeck What do you think?
P.S. I'm gladly accept any help and I'm really open to PRs :)
If you have some questions you we can chat on Gitter

I definitely think linking to all the specs is better than 404'ing and is a good placeholder until something matching a proper explanation page, like you describe, is in place.
Do you have any preference for a language or kit to automate the building of this? I have a few extra hours this week and would be glad to give it a go - nobody wants to manually edit that page with every addition, I'm sure ;)

I use collection.js script to do all operations with collection.
After each commit deploy_gh_pages.sh script is executed and it already have commands for generating CSV and REST API.
You can add separate command to generate HTML, to get list of files use getSpecs function.

Thanks! I'll work on putting something together this week :+1:

@brennebeck Do you have any progress?
You can make PR with unfinished code and I will help.


net/url: make URL parsing return an error on IPv6 literal without brackets

What version of Go are you using (go version)?

go version go1.11.2 windows/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GOARCH=amd64
set GOHOSTARCH=amd64
set GOHOSTOS=windows

What did you do?
url.URL provides the methods .Hostname() and .Port() which schould split the URL's host (.Host) into its address and port part. In certain cases, these functions are not able to interpret IPv6 addresses correctly, leading to invalid output.
Here is a test function feeding different sample URLs, demonstrating the issue (all test URLs are valid and should succeed!):
func TestUrl(t *testing.T) {
	tests := []struct {
		name        string
		input string
		wantHost     string
		wantPort string
	}{
		{"domain-unknonw-scheme", "asfd://localhost/?q=0&p=1#frag", "localhost", ""},
		{"domain-implicit", "http://localhost/?q=0&p=1#frag", "localhost", ""},
		{"domain-explicit", "http://localhost:80/?q=0&p=1#frag", "localhost", "80"},
		{"domain-explicit-other-port", "http://localhost:80/?q=0&p=1#frag", "localhost", "80"},

		{"ipv4-implicit", "http://<IP_ADDRESS>/?q=0&p=1#frag", "<IP_ADDRESS>", ""},
		{"ipv4-explicit", "http://<IP_ADDRESS>:80/?q=0&p=1#frag", "<IP_ADDRESS>", "80"},
		{"ipv4-explicit-other-port", "http://<IP_ADDRESS>:80/?q=0&p=1#frag", "<IP_ADDRESS>", "80"},

		{"ipv6-explicit", "http://[1::]:80/?q=0&p=1#frag", "1::", "80"},
		{"ipv6-explicit-other-port", "http://[1::]:80/?q=0&p=1#frag", "1::", "80"},

		{"ipv6-implicit-1", "http://[1::]/?q=0&p=1#frag", "1::", ""},

		{"ipv6-implicit-2", "http://1::/?q=0&p=1#frag", "1::", ""},
		{"ipv6-implicit-3", "http://1::2008/?q=0&p=1#frag", "1::2008", ""},
		{"ipv6-implicit-4", "http://1::2008:1/?q=0&p=1#frag", "1::2008:1", ""},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			// Prepare URL
			u, err := url.Parse(tt.input)
			if err != nil {
				t.Errorf("could not parse url: %v", err)
				return
			}

			// Extract hostname and port
			host := u.Hostname()
			port := u.Port()

			// Compare result
			if host != tt.wantHost {
				t.Errorf("TestUrl() got = %v, want %v", host, tt.wantHost)
			}
			if port != tt.wantPort {
				t.Errorf("TestUrl() got1 = %v, want %v", port, tt.wantPort)
			}
		})
	}
}

Output:

What did you expect to see?
All sample URLs in the test cases above are valid ones, hence, all tests should succeed as defined
What did you see instead?
The top test samples work as expected, however, the bottom three return incorrect results. The bottom three samples are valid IPv6 URLs with inplicit port specification, but .Hostname() and .Port() interpres them as IPv4 addresses returning parts of the IPv6 address as if it was the explicit port of an IPv4 input. E.g., in one of the test outputs, ":2008" is returned as the port, but it is actually part of the IPv6 address.
Where is the bug?
.Hostname() and .Port() implement their own logic to split the port from the hostname. I've found that there is already a close function in the net package, called net.SplitHostPort(), which does it's job correctly. If  .Hostname() and .Port() just called that function instead of re-implementing the logic, everything should work as expected. Below is the proof in form of a test function with exactly the same inputs as above, but using net.SplitHostPort() instead of  .Hostname() / .Port().
func TestUrlNetSplit(t *testing.T) {
	tests := []struct {
		name        string
		input string
		wantHost     string
		wantPort string
	}{
		{"domain-unknonw-scheme", "asfd://localhost/?q=0&p=1#frag", "localhost", ""},
		{"domain-implicit", "http://localhost/?q=0&p=1#frag", "localhost", ""},
		{"domain-explicit", "http://localhost:80/?q=0&p=1#frag", "localhost", "80"},
		{"domain-explicit-other-port", "http://localhost:80/?q=0&p=1#frag", "localhost", "80"},

		{"ipv4-implicit", "http://<IP_ADDRESS>/?q=0&p=1#frag", "<IP_ADDRESS>", ""},
		{"ipv4-explicit", "http://<IP_ADDRESS>:80/?q=0&p=1#frag", "<IP_ADDRESS>", "80"},
		{"ipv4-explicit-other-port", "http://<IP_ADDRESS>:80/?q=0&p=1#frag", "<IP_ADDRESS>", "80"},

		{"ipv6-explicit", "http://[1::]:80/?q=0&p=1#frag", "1::", "80"},
		{"ipv6-explicit-other-port", "http://[1::]:80/?q=0&p=1#frag", "1::", "80"},

		{"ipv6-implicit-1", "http://[1::]/?q=0&p=1#frag", "1::", ""},

		{"ipv6-implicit-2", "http://1::/?q=0&p=1#frag", "1::", ""},
		{"ipv6-implicit-3", "http://1::2008/?q=0&p=1#frag", "1::2008", ""},
		{"ipv6-implicit-4", "http://1::2008:1/?q=0&p=1#frag", "1::2008:1", ""},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			// Prepare URL
			u, err := url.Parse(tt.input)
			if err != nil {
				t.Errorf("could not parse url: %v", err)
				return
			}

			host, port, err := net.SplitHostPort(u.Host)
			if err != nil {
				// Could not split port from host, as there is no port specified
				host = u.Host
				port = ""
			}

			// Compare result
			if host != tt.wantHost {
				t.Errorf("TestUrl() got = %v, want %v", host, tt.wantHost)
			}
			if port != tt.wantPort {
				t.Errorf("TestUrl() got1 = %v, want %v", port, tt.wantPort)
			}
		})
	}
}

Output:

/cc @rsc @bradfitz (per net/url owners)

Your ipv6-implicit-2, ipv6-implicit-3, and ipv6-implicit-4 aren't valid URLs. IPv6 literals need to be in square brackets.

Closing for now. Let me know if I'm wrong, though.

Thank you for your response @bradfitz !
The rfc2732 recommends the use of brackets in all cases. However, it is not mandatory and can be technically omitted if no explicit port needs to be defined.
The thing is: In many cases the URL might not be built by the developer, but be received from some other source. Using url.Parse() is already an small indicator that URLs are received and parsed rather than built by the developer.
One common example, would be parsing URLs returned by a website. The website is free to return any URL format (can be decided by the web application developer). Relative URLs but also absolute ones. If the website returns absolute URLs, they might not follow the recommendation of the RFC but omit the brackets. url.Parse() would not return an error but garbage difficult to catch.
Sanitizing every received URL before parsing would be a fix, but unnecessasry overhead. It would be related to re-implementing the url.Parse() function.
The following might be a less valid argument in the views of some, but there is already the net.SplitHostPort() function in a closeby package. It is a little more forgiving and having duplicate code might not be the best practice either.
It would be also okay if parsing "http://1::2008" and calling .Hostname() returned "[1::2008]" in compliance with the RFC's suggestion for
rfc2732 : https://www.ietf.org/rfc/rfc2732.txt
definition of "should": https://tools.ietf.org/html/rfc2119

Well, that SHOULD is news to me. I thought it was a requirement. I think it might've been upgraded to a requirement in later (post 1999) RFCs.
In any case,
3. SHOULD   This word, or the adjective "RECOMMENDED", mean that there
   may exist valid reasons in particular circumstances to ignore a
   particular item, but the full implications must be understood and
   carefully weighed before choosing a different course.

Who decided that the valid reasons were to not use square brackets? Did they carefully weigh that libraries (such as Go) might reject them?
Is there any other software today that generates them? That is, how did this bug come about? Is this real or hypothetical?

It was hypothetical based on the RFC's definition and that IPv6 addresses go without brackets by default unless a specific endpoint (port) is to be specified.
However, I now tried how browsers (Chrome, FF, IE, Edge) react on IPv6 URLs without brackets. It seems they don't accept it and understand such input as search terms. Obviously, the general understanding is that brackets are mandatory for IPv6 URLs. Hence, no working website could apply it without. Web developers could build it but it wouldn't be useful.
If being forgiving is not desired in this case, I'm suggesting, that url.Parse() throws an error in order to prevent from continuing with garbage data! See garbage output in sample below.
func main() {
	u, err := url.Parse("http://1::12:2008")
	if err != nil {
		log.Fatal(err)
	}
	fmt.Println(u.Hostname()) // => 1
	fmt.Println(u.Port()) // => :12:2008
}

Okay, I've repurposed this bug to be about rejecting them instead.

I'm pretty sure that RFC 3986 (which obsoletes RFC 2732) requires square brackets for IPv6 literals.  The ABNF rules defined in RFC 3986 only allow an IPv6address inside square brackets, and there is nothing in the text to suggest that a reg-name that looks like an IPv6address should be interpreted that way.
This silence on IPv6 addresses without square brackets is notable, because the text does acknowledge the ambiguity between reg-name and IPv4address:

The syntax rule for host is ambiguous because it does not completely
distinguish between an IPv4address and a reg-name.  In order to
disambiguate the syntax, we apply the "first-match-wins" algorithm:
If host matches the rule for IPv4address, then it should be
considered an IPv4 address literal and not a reg-name.

Well, an IPv6 address cannot be interpreted as a hostname due to the colons, in contrast to an IPv4. Anyways, it seems clear now that brackets are required to be compliant.
Any suggestions how to make the function detect and reject mentioned invalid URLs? Validating the host part might be error prone because its content could be IPv4, IPv6 or a hostname. The error actually materializes in the port part. So I thought, a test whether the port is either empty or a valid integer would catch the issue. It would also catch potential other issues not directly related with IPv6 and brackets. But I can't help it feels too cheap.

I would suggest that RFC 3986 provides the solution - it is the literal source of truth for what can be a valid URL.  That does mean parsing it as IPv4, IPv6, IPvFuture (yes, that's a thing), or a reg-name.
I note also that currently, net/url thinks that https://[::y] is a valid URL, which is another non-RFC-3986-compliant URL string.

Have you progressed on this bug?

Not to go off-tangent too much. But what is the intent in url.Parse on strings that have no scheme?  I came across this in a library that was using url.Parse on ipv4 addresses and would fail when given implicit or explicit ipv6 addresses. The library should not have been using url.Parse on plain ip address strings, but it did make me wonder why net.Parse was not returning an error.
For example, url.Parse("<IP_ADDRESS>") parses, but returns url.URL{Path: "<IP_ADDRESS>"} which struck me as nonsensical. When I checked RFC3986 Section 3.1 and Section 1.1.1 I got the impression scheme has to exist to be a valid URL.
The behavior I'm looking at is demonstrated here: https://play.golang.org/p/MzW9lCD7Min

@dekimsey
I'm using url.Parse to parse hrefs extracted from web sites, but they can be defined in various ways (and are seldomly with scheme):

absolute: "/app/page"
relative: "page" (without leading slash) meaning "/app/page" if the current browser location is "app"
full URL: "https://www.domain.tld/app/page"

Different web developers or content management systems may chose different variants and or a combination for reasons.

For example, url.Parse("<IP_ADDRESS>") parses, but returns url.URL{Path: "<IP_ADDRESS>"} which struck me as nonsensical. When I checked RFC3986 Section 3.1 and Section 1.1.1 I got the impression scheme has to exist to be a valid URL.

5.2.  Relative Resolution allows those as URI references. The ResolveReferences method on url.URL strongly hints at the intention to support this in net/url.
The parsing  of <IP_ADDRESS> seems to be correct as per the above.


25.1.0 issue with window.location.reload giving '...Cannot assign to read only property...'

🐛 Bug Report
TypeError: Cannot assign to read only property 'reload' of object '[object Location]'
Reloading a page using Jest mocking is causing an issue with jest version 25.1.0
To Reproduce
import axios from 'axios'
jest.mock('axios')

const location_reload = window.location.reload
beforeAll(() => {
  Object.defineProperty(window.location, 'reload', { configurable: true })
  window.location.reload = jest.fn()
})
afterAll(() => { window.location.reload = location_reload })

beforeEach(() => jest.resetAllMocks() )

Courtesy of my colleague @jchiam, this allows me to mock window.location.assign:
    Object.defineProperty(window, 'location', {
      writable: true,
      value: { assign: jest.fn() }
    });

It might work for the other properties in window.location, too.

What worked for me is:
Object.defineProperty(window, 'location', {
  writable: true,
  value: { assign: jest.fn() }
})

Object.defineProperty(window.location, 'reload', {
  writable: true,
  value: { assign: jest.fn() }
})

I don’t understand why restoring the old function. I always do :
// GIVEN a mocked location
delete window.location
window.location = {
      reload: jest.fn()
}
// WHEN the method is called
method()
// THEN the page should have been reload
expect(window.location.reload).toHaveBeenCalledTimes(1)

In test environment, you don’t need to restore original window methods behaviour.

What worked for me is:
// location.assign
Object.defineProperty(window.location, 'assign', {
  value: jest.fn()
})
expect(window.location.assign).toHaveBeenCalledWith('/path/to/url')

// location.reload
Object.defineProperty(window, 'location', {
  value: { reload: jest.fn() }
})
expect(window.location.reload).toHaveBeenCalled()

Maybe helpful to some. The above examples will work if you execute them in a setupFilesAfterEnv script defined in .jestrc.
{
  ....
  "setupFilesAfterEnv": [
    "<rootDir>/config/jest/setupAfterEnv.js"
  ],
  ....
}

I don’t understand why restoring the old function. I always do :
// GIVEN a mocked location
delete window.location
window.location = {
      reload: jest.fn()
}
// WHEN the method is called
method()
// THEN the page should have been reload
expect(window.location.reload).toHaveBeenCalledTimes(1)

In test environment, you don’t need to restore original window methods behaviour.

You have to restore it if a possible next test uses the variable, otherwise, the mocked value could bias on the result.

Just fyi for anyone landing here after google, using object assign stopped working, but this does (and it's a much simpler way of expressing it)
window.location = {
    ...window.location,
    reload: jest.fn()
}

What worked for me is:
Object.defineProperty(window, 'location', {
  writable: true,
  value: { assign: jest.fn() }
})

Object.defineProperty(window.location, 'reload', {
  writable: true,
  value: { assign: jest.fn() }
})

This doesn't look correct you are changing location object to function, then you are trying to assign reload property to the function.


Support for ECMAScript Modules?

Thoughts on supports ECMAScript modules?
Using dynamic import?

Currently, We want to supports node v8.9.0 and later, which is the minimum version of node supported by hapi. On the other hand, ES6 module stills experimental on these node version.

I'll accept PR for these but we need to supports the minimum version of node supported by hapi.


PIXI.CanvasRenderer resize not working

Hello,
The resize method of the PIXI.CanvasRenderer of the latest version looks broken.
You can have a look here
Everything looks ok but when I resize my browser and the renderer.resize is triggering, the elements in the canvas disappears.
When I switch to PIXI.WebGLRenderer is working fine though.
Thanks

Ok I forgot to update the renderer.render(stage) in my resize method.
It's weird that it was working for WebGLRenderer though


[TODO] Figure out integration testing of this extension

Is your feature request related to a problem? Please describe.
No tests.
Describe the solution you'd like
Tests must exist.
Describe alternatives you've considered
Giving up on quality.
Additional context
There's not many good examples of writing integration tests for VS Code extensions so here's some pointers I've found:

https://developers.redhat.com/blog/2019/11/18/new-tools-for-automating-end-to-end-tests-for-vs-code-extensions
https://github.com/redhat-developer/vscode-extension-tester/wiki
https://github.com/redhat-developer/vscode-extension-tester
https://vscode.rocks/testing/
https://github.com/mlewand-org/vscode-test-content
https://viatsko.github.io/awesome-vscode/#resources-for-extension-developers

I don't think this should be closed. There's no test examples, it's not solved.

True, it should be open until we finish setting the framework and a minimal battery of testing, so others can easily add more of them while adding other features of bugfixes.
vscode-extension-tester is already used now and it looks promising.


dbcrossbar conv claims it takes --if-exists, which is confusing

what does it do with it?

--if-exists specifies what to do if the destination schema file exists. Should it overwrite? Error out?


Reg up plus

Enhance connectivity reliability; fix client object_device examples; add object_location implementation; pure lwm2m_malloc() & lwm2m_free() usage, add client arguments for more convenience local/server port configuration with defaults matching to eclipse leshan.

already done!


Update unsecure dependencies

No related issue
Updates some dependencies to make the package more secure. As per npm, this fixes 29 security vulnerabilities in dependencies.

Warnings

:warning:

Please include an updated CHANGELOG.md file.This way we can keep track of all the contributions.

  Generated by :no_entry_sign: dangerJS


D435i mechanical parameters for installation between various camera modules?

Hi, thank you for you guys great work about librealsense. I have some problem with my realsense D435i. I want to use my lidar to provide depth param for my D435i color image. And I have the installation params between my lidar and D435i. So I need the translation and RPY params between RGB module and my ouster lidar. I found some calibration project for calculating the extrinsic parameter for lidar and camera. While these projects seem to be cumbersome. Are there external parameters installed between each lens of D435? For example, the distance parameter between the RGB lens and the installation space on the back of the camera. Or the distance between the RGB lens and the binocular lens. Could you give me some advice?

Hi @JACKLiuDay  You can obtain the extrinsic parameters between two sensors on the same camera (such as color to depth or depth to infrared1) by launching the RealSense SDK's 'rs-enumerate-devices' tool in calibration information mode with the command rs-enumerate-devices -c

Hi @JACKLiuDay You can obtain the extrinsic parameters between two sensors on the same camera (such as color to depth or depth to infrared1) by launching the RealSense SDK's 'rs-enumerate-devices' tool in calibration information mode with the command rs-enumerate-devices -c

Hi,thank you for your quick reply. I will try it with my D435i camera.


DockerComposeContainer does not remove the network after using a version 2 compose file

I'm not using the ambassador containers so am not affected by #146, meaning that I am successfully running with a version 2 docker-compose file. This means that each test run creates a network which is not removed at the end of the test.
Once I hit 32 networks, I ran into an error when trying to run docker-compose:
ERROR: failed to parse pool request for address space "LocalDefault" pool "" subpool "": could not find an available predefined network

We need to either remove the network ourselves, or run docker-compose down to clean up.

Good catch, thanks! As discussed, I'll work this into the docker compose
refactoring I'm doing. I think I'd like to:

make use of docker-compose down in normal shutdown scenarios
leave the container reaper prepped to kill any containers on exceptional
JVM shutdown
(possibly) set up docker-compose down in a JVM shutdown hook too, to
avoid networks slipping through the cracks
On Thu, 2 Jun 2016 at 17:25 Andrew Haines<EMAIL_ADDRESS>wrote:

I'm not using the ambassador containers so am not affected by #146
https://github.com/testcontainers/testcontainers-java/issues/146,
meaning that I am successfully running with a version 2 docker-compose
file. This means that each test run creates a network which is not removed
at the end of the test.
Once I hit 32 networks, I ran into an error when trying to run
docker-compose:
ERROR: failed to parse pool request for address space "LocalDefault" pool "" subpool "": could not find an available predefined network
We need to either remove the network ourselves, or run docker-compose down
to clean up.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/testcontainers/testcontainers-java/issues/152, or mute
the thread
https://github.com/notifications/unsubscribe/AAIETw4EFwieJn1mmtJi-LqWitAPMzuKks5qHwP-gaJpZM4IsvMn
.

--
Richard

FWIW I backported the remove network command from docker-java 3.0.0-RC5 into our test suite (I see they released 3.0.0 final on Friday night!) and (with a sprinkling of nasty reflection to access private fields in the docker client), we have it successfully dropping the default network after the test run. This is sufficient for our use case; we have no plans to use additional custom networks.

Resolved in #156


student-bios mdfile added

Checklists
General Checks

[x] the branch is up to date with main/master
[x] the code works when pulled and run locally
[x] All CI checks pass
[x] all conflicts are resolved (if any)
[x] PR has a descriptive title
[x] PR has appropriate labels and milestones for easy identification
[x] PR it is assigned to the owner
[x] reviewers are assigned
[x] the PR contributes only one focused change
[x] It is in the appropriate column in the project board (if necessary)
[x] has short and clear description
[x] is linked to an issue (if it is related)
[x] feedback is addressed (if any and if it is appropriate feedback.)

Markdown

[x] the markdown source is formatted
[x] spelling and grammar is correct in all text
[x] The markdown looks correct when you preview the file
[x] all links and images work
[x] any embedded code snippets are formatted

Hello @Neha-2012, you have changed README.md file which you shouldn't  and why did you add your img to assets , I told you one of you can create a folder img inside students-bio


ReAct agent creating own "User Input" and ending up stopping agent with iteration limit

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
Agent and Executor setup
agent = create_react_agent(llm, tools, full_prompt)
agent_executor = AgentExecutor(agent=agent, tools=tools, verbose=True, handle_parsing_errors=True)
langchain.debug = True```

### Error Message and Stack Trace (if applicable)

Agent stopped due to iteration limit exceeded.

### Description

I was using langchain.agents AgentExecutor, create_react_agent. I got the output for the user input in my chain but it is creating its own user input and keep answering it with the given available tools.
<img width="1512" alt="Screenshot 2024-08-23 at 4 08 40 PM" src="https://github.com/user-attachments/assets/1b9b8537-8ab2-49de-806f-0f85f438b688">

### System Info

langchain==0.2.11
langchain-community==0.2.7
langchain-core==0.2.24
langchain-experimental==0.0.62
langchain-huggingface==0.0.3
langchain-openai==0.1.16
langchain-text-splitters==0.2.1

platform mac

dnspython==2.6.1
opencv-python==<IP_ADDRESS>
python-dateutil==2.9.0.post0
python-dotenv==1.0.1
python-multipart==0.0.9

Hello, I’m interested in working on this issue as part of a project for my computer science course at the University of Toronto. Could you please let me know if it’s available and if there are any specific considerations I should be aware of? Thanks in advance!

Hi @Rohannain ,
We are interested in working on the issue you’ve reported where the agent creates its own user input and exceeds the iteration limit. We were able to reproduce the error using a different prompt, which suggests that the issue might be related to how the agent handles prompts in general.
To help us investigate further, could you please provide some additional information?

Are there any custom configurations or parameters you’ve applied that might affect the agent’s behavior?
Could you share the specific code snippets you used to set up the AgentExecutor and create_react_agent?

Hey @Rohannain @jacoblee93 and anyone else reading this thread, I'm part of the team working on this issue, and I wanted to share our proposed solution.
The problem arises when the ReAct agent starts generating its own 'User Input' prompts, leading it into an infinite loop where it keeps requesting input instead of progressing toward a solution. This causes the agent to hit the iteration limit and stop with the error message: 'Agent stopped due to iteration limit.'
To resolve this, we plan to add an iteration check within the AgentExecutorIterator class. By modifying the _should_continue() method, we aim to implement a condition that ensures the agent doesn’t enter an endless reasoning loop. Additionally, we’ll update the agent’s prompt instructions and output parsing logic to prevent the agent from creating its own 'User Input' prompts.
We'll make changes to several files, including:
The prompt.py file to refine agent instructions,
The agent.py file to integrate the iteration check,
And finally, the tools and test files to expand the agent’s resources and ensure stability across cases.
We’d love any feedback on this approach or suggestions to make it more robust. Let us know what you think and we can start implementing it!

Just adding on, this is the code ran to reproduce the error:
from langchain.prompts import PromptTemplate
from langchain.tools import Tool
from langchain_openai import OpenAI
import langchain
import os
os.environ["OPENAI_API_KEY"] = "..."
def search_tool(input_text):
    return f"Searching for: {input_text}"
def calculator_tool(input_text):
    try:
        return str(eval(input_text))
    except:
        return "Invalid input"
tools = [
    Tool(name="search", func=search_tool, description="Searches for information."),
    Tool(name="calculator", func=calculator_tool, description="Performs calculations.")
]
def make_openai_request(prompt, temperature=0.7, retries=3):
    retry_count = 0
    while retry_count < retries:
        try:
            llm = OpenAI(temperature=temperature)
            return llm.generate(prompt)
        except openai.error.RateLimitError:
            retry_count += 1
            # wait_time = 2 ** retry_count
            wait_time = 0
            print(f"Rate limit exceeded. Retrying in {wait_time} seconds...")
            # time.sleep(wait_time)
    raise Exception("Max retries exceeded.")
prompt_template = PromptTemplate(
    input_variables=["input", "tools", "tool_names", "agent_scratchpad"],
    template=(
        "You are a helpful assistant. "
        "Use the following tools to answer the question: {input}.\n"
        "Available tools: {tool_names}\n"
        "You can use these tools: {tools}\n"
        "Please follow this format: "
        "Thought: [your thought process]\n"
        "Action: [tool name](input_text)\n"
        "Agent thoughts and progress: {agent_scratchpad}\n"
    ),
)
llm = OpenAI(temperature=0.7)  # You can add retry logic here as needed
agent = create_react_agent(llm=llm, tools=tools, prompt=prompt_template)
agent_executor = AgentExecutor(agent=agent, tools=tools, verbose=True, handle_parsing_errors=True)
# Enable debugging
langchain.debug = True
def invoke_agent(input_text):
    try:
        input_data = {"input": input_text}
        response = agent_executor.invoke(input_data)
        return response
    except Exception as e:
        print(f"Error occurred: {str(e)}")
        return None
 t5
user_input = "What is 5 + 3?"
response = invoke_agent(user_input)
print(response)

and the corresponding output:


LGPL is not compatible with many app stores

LGPL is not compatible with online app stores,
but, EasyHook is the only choice in .net hooking...
So, I have no choice but ask the original author of EASYHOOK.
I am linking easyhook with dynamic dlls(compiled from a modified copy of easyhook sources)
How to resolve these conficts between LGPL and app stores?
Or could you grant me a license compatiple with app stores?
Thanks.

As I understand it, as long as you are linking dynamically and provide a way for the app to be linked to a new/different version of EasyHook (i.e. have a link to your website where they could repackage the app if desired - but completely fine to be unrelated to the store), then you are complying with the licence. Here is a link that might be helpful (although Sparrow me is now owned by Google and the example that was linked is unavailable): http://roadfiresoftware.com/2013/08/the-problem-with-using-lgpl-v2-1-code-in-an-ios-app/
I'll investigate dual-licencing under certain circumstances, or to include an option to allow static linking under certain circumstances.

Thanks for your reply.
As I understand it, the approuch your describled is the best way to deal with LGPL license in a app store out there.
But, it's not very perfect or very 'legal‘.
Yes, it's legal for ourselfs, but not very 'legal' for 'app store holder'(eg. apple ios store).
Because the end user just can't link/repackage the app with a new/different version of EasyHook without a iOS $99 idp key.
So, if the store accept our app(licensed with LGPL), they deprive end user of the repackge rights.
It's not very 'legal' for these stores.
Even more, the store will just reject any app licensed with LGPL in any way to avoid any legal risk, though we have did our best to deal with the 'repackage rights' of LGPL(eg, host a web site for src/obj/o, etcs).
The store don't want pay their time($) on deal with huge number of apps licensed with LGPL or its varies.
If we submit a app licensed with LGPL, it will may be accepted or just be rejected simply without reasons.
IT'S TOTALLY A GREY AREA.
I am very excited when hearing you are invesigating dual-licencing things, but why not re-license EasyHook with a diffrent easy one simply?
Best regards.

I am not the original licence holder so I can't make these decisions without some further discussion with Chris, I'll see how I go.
Re: iOS app store, you will not be able to use EasyHook there anyway as it relies on Win32 APIs, but I understand the point you are making re LGPL (I do licence all my own original work as MIT).

Thanks for your reply.

I am waiting for further good news. ^_^
Wish you have a nice day.

Chris agrees with changing to the MIT licence. Keep an eye on the repository for the update.

BIG NEWS!!
THANKS!!


Demo using different themes

First of all, thank you for this great work. I like the project quite a bit. So, if the maintainer don't mind, I would like to showcase a short demo. Just in case, anyone would like to see within a few seconds at least one feature, that is, the theming feature.
https://github.com/expressive-code/expressive-code/assets/47569896/efc42247-ad10-44f0-8f2d-d0a4c1e46884

Hey @jav-ed, welcome! Thank you very much the praise and your idea of showcasing features. I love it, thanks for investing time into this!
If it fits your plans with these videos (and only then; no pressure!) I could even imagine linking to such videos from my docs if they are concise and fit the topic, allowing users to quickly see what is possible with a particular feature.

@hippotastic Thank you for the fast reply. Also, a bonus is that the response is so positive.
At the moment, I had no plans to do demos or tutorials on Expressive Code. However, I will, inshallah, use this tool quite a bit.
My current plan is to, inshallah, finish my webpage. On this webpage, I would like, among other things, to teach how to code in Python. After this experience, I might be even somewhat qualified to give tutorials or demos on Expressive Code.
To wrap it up, I would love to tell people about this great repo. However, to be very clear, I can give no guarantees at the moment if I will be able to do it. Also, I think I did not fully understand your requirements.
Do you want to see demos or tutorials?

Thank you for your response! I think I just misunderstood the purpose of your initial post and thought you were asking me if I'd be interested in having some kind of video showcase. I didn't want to cause you any extra efforts, so please ignore my questions. :)
It's perfectly fine to include EC in any videos you create, and there is no need to ask beforehand. Happy coding and good luck with your website!


feat: Add 'gitlab:repo:push' scaffolder action

Hey, I just made a Pull Request!

This PR adds new action to make a push to a branch in gitlab repository. The action requires branchName as an input. If that branch exists, the commit will be made into it, if branch doesn't exist - the action will create new branch using default branch as a base ref.

[!NOTE]
I could've used the default repository branch, but I thought it's better to be explicit here. Let me know if you prefer that

In addition to unit tests I've tried it on my playground repository

Commit to an existing branch main
Commit into a new branch
Commit into a branch for which PR has been already opened

This partially solves problems described in https://github.com/backstage/backstage/issues/16662 as it's possible to make additional commits to an already openned Merge Request, so that one could mix commitAction: create with commitAction: update or commitAction: delete using different commits.
Using this new action is different from the other solutions proposed in that issue (using isomorphic git) or the one I suggested with using multiple actions per path, but I thought that this action might be useful not only when you need to mix different actions, but for simply committing to a custom branch without opening an MR.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Can this be reopened?

Sure @gavlyukovskiy, this just needs to be reviewed right?

@awanlin yes, please!

@benjdlambert thank you for the review! The only thing is that integration tests are failing, but it doesn't seem related to my changes

@gavlyukovskiy no it's nothing to do with this PR, we've hit a bit of a rough patch with our e2es failing because of upstream deps. https://github.com/mui/material-ui/issues/40427