Adding description.

Adding description to setup.py

:+1: Apparently I still receive notifications for this repo since I committed to it nearly three years ago. :P

@zacharytamas haha


pyglet-1.5-maintenance crash with python 3.13 on Windows

Scripts that work with python 3.12 now crash early on python 3.13
This is Windows specific.
This can be seen with the pyglet demos hello_world.py, astraea.py or noisy.py by example, wich gives
D:\dev\pyglet\examples>py -3.13 hello_world.py
Traceback (most recent call last):
  File "D:\dev\pyglet\pyglet\__init__.py", line 305, in __getattr__
    return getattr(self._module, name)
AttributeError: 'NoneType' object has no attribute 'Window'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\dev\pyglet\examples\hello_world.py", line 3, in <module>
    window = pyglet.window.Window()
             ^^^^^^^^^^^^^^^^^^^^
  File "D:\dev\pyglet\pyglet\__init__.py", line 311, in __getattr__
    __import__(import_name)
    ~~~~~~~~~~^^^^^^^^^^^^^
  File "D:\dev\pyglet\pyglet\window\__init__.py", line 1912, in <module>
    from pyglet.window.win32 import Win32Window as Window
  File "D:\dev\pyglet\pyglet\window\win32\__init__.py", line 50, in <module>
    from pyglet.canvas.win32 import Win32Canvas
  File "D:\dev\pyglet\pyglet\canvas\__init__.py", line 110, in <module>
    from pyglet.canvas.win32 import Win32Display as Display
  File "D:\dev\pyglet\pyglet\canvas\win32.py", line 3, in <module>
    from pyglet.libs.win32 import _user32
  File "D:\dev\pyglet\pyglet\libs\win32\__init__.py", line 41, in <module>
    from . import com
  File "D:\dev\pyglet\pyglet\libs\win32\com.py", line 240, in <module>
    class COMPointer(ctypes.c_void_p, metaclass=COMPointerMeta):
    ...<18 lines>...
                    raise TypeError("Interface {} doesn't have a pointer in this class.".format(cls.__name__))
  File "D:\dev\pyglet\pyglet\libs\win32\com.py", line 214, in __new__
    _pointer_type_cache[cls] = type(COMPointer)("POINTER({})".format(cls.__name__),
                                    ^^^^^^^^^^
NameError: name 'COMPointer' is not defined. Did you mean: 'COMPointerMeta'?

or in astraea.py
D:\dev\pyglet\examples\astraea>py -3.13 astraea.py
Traceback (most recent call last):
  File "D:\dev\pyglet\examples\astraea\astraea.py", line 49, in <module>
    from pyglet.gl import *
  File "D:\dev\pyglet\pyglet\gl\__init__.py", line 219, in <module>
    from .win32 import Win32Config as Config
  File "D:\dev\pyglet\pyglet\gl\win32.py", line 36, in <module>
    from pyglet.canvas.win32 import Win32Canvas
  File "D:\dev\pyglet\pyglet\canvas\__init__.py", line 110, in <module>
    from pyglet.canvas.win32 import Win32Display as Display
  File "D:\dev\pyglet\pyglet\canvas\win32.py", line 3, in <module>
    from pyglet.libs.win32 import _user32
  File "D:\dev\pyglet\pyglet\libs\win32\__init__.py", line 41, in <module>
    from . import com
  File "D:\dev\pyglet\pyglet\libs\win32\com.py", line 240, in <module>
    class COMPointer(ctypes.c_void_p, metaclass=COMPointerMeta):
    ...<18 lines>...
                    raise TypeError("Interface {} doesn't have a pointer in this class.".format(cls.__name__))
  File "D:\dev\pyglet\pyglet\libs\win32\com.py", line 214, in __new__
    _pointer_type_cache[cls] = type(COMPointer)("POINTER({})".format(cls.__name__),
                                    ^^^^^^^^^^
NameError: name 'COMPointer' is not defined. Did you mean: 'COMPointerMeta'?

Windows  11   23H2, 10.0.22631
The demos work normal with python 3.12 in the same machine

pyglet version at
D:\dev\pyglet\examples>git log
commit 7387e594bee7e84664f931c2d9486636e4c28f8c (HEAD -> pyglet-1.5-maintenance, tag: v1.5.29, origin/pyglet-1.5-maintenance)

Date:   Tue May 14 08:56:24 2024 +0900

    ready v1.5.29 release

@Square789 Sorry to bother you, but if you have time could you have a look at this?

This is the bug i was referring to with the first undirected paragraph of this reply.
I assume it would be possible to just backport all of the COM changes that happened since then, but i understand that the maintenance branch should probably change as little as possible.
I will try and figure out a fix with a small changeset

That took way too long, apologies. But #1243 should be able to fix it.

Thank you very much @Square789! This tests OK on my Windows 10 machine with the latest 3.13 build from Python.org.
I'll get a point release out soon.
@ccanepa Please give it a try on your end to confirm.

tests with 3.13, 3.12, 3.11, 3.10, 3.9
Scripts run normal, except sometimes one or more tracebacks are seen when quiting.
Not exactly repeteable, by example repeatdly running astraea:
D:\dev\pyglet\examples\astraea>py -3.11 astraea.py
Exception ignored in: <function XA2SourceVoice.__del__ at 0x0000023292824860>
Traceback (most recent call last):
  File "D:\dev\pyglet\pyglet\media\drivers\xaudio2\interface.py", line 404, in __del__
  File "D:\dev\pyglet\pyglet\media\drivers\xaudio2\interface.py", line 414, in destroy
  File "D:\dev\pyglet\pyglet\libs\win32\com.py", line 150, in _call
  File "_ctypes/callproc.c", line 1000, in GetResult
OSError: [WinError -1781712576] Windows Error 0x95cd3940
Exception ignored in: <function XA2SourceVoice.__del__ at 0x0000023292824860>
Traceback (most recent call last):
  File "D:\dev\pyglet\pyglet\media\drivers\xaudio2\interface.py", line 404, in __del__
  File "D:\dev\pyglet\pyglet\media\drivers\xaudio2\interface.py", line 414, in destroy
  File "D:\dev\pyglet\pyglet\libs\win32\com.py", line 150, in _call
  File "_ctypes/callproc.c", line 1000, in GetResult
OSError: [WinError -1781808032] Windows Error 0x95cbc460
Exception ignored in: <function XA2SourceVoice.__del__ at 0x0000023292824860>
Traceback (most recent call last):
  File "D:\dev\pyglet\pyglet\media\drivers\xaudio2\interface.py", line 404, in __del__
  File "D:\dev\pyglet\pyglet\media\drivers\xaudio2\interface.py", line 414, in destroy
  File "D:\dev\pyglet\pyglet\libs\win32\com.py", line 150, in _call
  File "_ctypes/callproc.c", line 1000, in GetResult
OSError: [WinError -1781809056] Windows Error 0x95cbc060

D:\dev\pyglet\examples\astraea>py -3.11 astraea.py

D:\dev\pyglet\examples\astraea>py -3.11 astraea.py

D:\dev\pyglet\examples\astraea>py -3.11 astraea.py

D:\dev\pyglet\examples\astraea>py -3.11 astraea.py

D:\dev\pyglet\examples\astraea>py -3.11 astraea.py

D:\dev\pyglet\examples\astraea>py -3.11 astraea.py

D:\dev\pyglet\examples\astraea>py -3.11 astraea.py

D:\dev\pyglet\examples\astraea>py -3.11 astraea.py
Exception ignored in: <function XA2SourceVoice.__del__ at 0x00000189CB724860>
Traceback (most recent call last):
  File "D:\dev\pyglet\pyglet\media\drivers\xaudio2\interface.py", line 404, in __del__
  File "D:\dev\pyglet\pyglet\media\drivers\xaudio2\interface.py", line 414, in destroy
  File "D:\dev\pyglet\pyglet\libs\win32\com.py", line 150, in _call
  File "_ctypes/callproc.c", line 1000, in GetResult
OSError: [WinError -880033696] Windows Error 0xcb8bc060

Notice that the tracebacks only shown when quiting, and the ones with tracebacks repeat one or more times the same traceback,
Seen tracebacks with 3.12 , 3.11, 3.10, 3.9
I guess if the tracebacks can only manifest while quiting then it's enought good fix.
@Square789 , @benmoran56 thanks for still support 1.5

Does the issue also appear on 3.11 without the PR applied?
I believe this might be #669, but - just like caffeinepills - i am unable to replicate it.

Does the issue also appear on 3.11 without the PR applied?

Yes, for all of 3.12 to 3.9
Windows 11 23H2, 10.0.22631
pyglet at
D:\dev\pyglet\examples\astraea>git log
commit 7387e594bee7e84664f931c2d9486636e4c28f8c (HEAD, tag: v1.5.29)
Date:   Tue May 14 08:56:24 2024 +0900

    ready v1.5.29 release

and also with python 3.13.0

This PR is not the issue then, but it's interesting that you also happen to run into the __del__-related shutdown problems for XAudio2.
I think the best option for that is applying the hack Benjamin suggested. I'm not sure there will be any larger changes/backports to 1.5 from 2.x, where __del__ is not used anymore in the backend-specific audio players.

We could add that hack into the main 1.5 codebase. It's harmless enough, and will suppress the messages.
@ccanepa there have been a lot of improvements/cleanups/etc. to the platform specific code over the years, in order to keep up with OS changes. It's not really practical to backport large changes to 1.5 anymore, so unfortunately it may cease to work on modern OSes unless someone steps up to manually merge the fixes.  These old released will remain available, because
Question:  is your reliance on 1.5 due to API changes, or due to hardware support?
If because of API changes:
Perhaps we can help to migrate?
If due to hardware support:
It's still a long ways away, but for pyglet 3.0 we are trying to fully abstract the platform code from the rendering backend. This is mainly to add a Vulkan backend, but actually will allow us to add back a legacy GL backend as well. In fact, we have successfully tested a GL 2.0 backend (I was able to run it on an old Raspberry Pi).  The API however, will be based on the modern changes.

We could add that hack into the main 1.5 codebase. It's harmless enough, and will suppress the messages.

Seems to work, at least for 3.13 , 3.12 ,  3.11, 3.10
tested by:

checkout 1.5.30
aply

D:\dev\pyglet\examples\astraea>git diff
diff --git a/pyglet/media/drivers/xaudio2/interface.py b/pyglet/media/drivers/xaudio2/interface.py
index daf0923e..b02fd522 100644
--- a/pyglet/media/drivers/xaudio2/interface.py
+++ b/pyglet/media/drivers/xaudio2/interface.py
@@ -412,7 +412,7 @@ class XA2SourceVoice:
                 self._voice.Stop(0, 0)
                 self._voice.FlushSourceBuffers()
                 self._voice.DestroyVoice()
-            except TypeError:
+            except (TypeError, OSError):
                 pass

             self._voice = None

run astraea 20 times in each python , no tracebacks seen

@ccanepa there have been a lot of improvements/cleanups/etc. to the platform specific code over the years, in order to keep up with OS changes. It's not really practical to backport large changes to 1.5 anymore, so unfortunately it may cease to work on modern OSes unless someone steps up to manually merge the fixes.

Understandable

Question: is your reliance on 1.5 due to API changes, or due to hardware support?

API changes, but not really. just missing the motivation to put xx hours of work.

If because of API changes:
Perhaps we can help to migrate?

Thats a very kind offer, but still no motivation.

I just pushed out a 1.5.31 release, that includes that small fix. I'll close this now. Thanks again @Square789 for taking time on this!
@ccanepa if you ever get the motivation to update, pop into the Discord server and i'm sure you'll be able to get any assistance you need.


Fixed default value for radio options builder if using resourceType displayName

Problem: Default values were not showing if fields used resourceType displayName in radio options fields.
Solution: Added ResourceTypeOptionValue as a type for radio options' defaultValue. When generating component, use the displayName as the defaultValue.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 6 (16.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 42.228%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/resource-deployment/src/ui/radioGroupLoadingComponentBuilder.ts
1
6
16.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.004%

Covered Lines:
28174

Relevant Lines:
62344

💛  - Coveralls


Blob: Remove branch from cache universe

The original intent was to match Azure Pipeline Caching which has a hierarchy of caches, where the current branch has a Read/Write cache, while parent branches like main would have a cache with read-only access. Details for the interested for how that works.
However, this simply added the branch name to the cache universe, which isolated but did not actually add any security. It also didn't add any of the hierarchy logic, meaning branches were completely isolated, which is not desirable.
This change just removes that logic.

which isolated but did not actually add any security

Could you elaborate on this? The isolation was the security.
Specifically, how do we reasonably ensure that (unmerged) PR builds don't affect CI builds? Perhaps instead of completely removing the branch we can:

Base the salt/namespace on the build type: PR vs CI e.g. GITHUB_EVENT_NAME
"Flatten" the branch name to main/master vs not.

If the intent is to make it so we remove the isolation between CI and PR, I would be open to making that an opt-in option, but I think the default should be secure.

@johnterickson : this logic blocks using cache for developers on a topic branch.  For security PR build should not merge cache with CI builds. Actually, based on your isolation logic, PR build should not have cache turned on at all.  Put straight, if you have an isolated cache store for each PR branch, it would only benefit the PR build from same branch, if it happens to run multiple times. In all the other time, it will only create cache blobs which would never be used again in the future, once the PR is merged.  Basically, it means the owner will pay for the cost to store them without any benefit. Overall, it might not make sense to have PR build to store cache in the same binary storage at all.

On the other word, if changes within a PR can modify the build logic to a degree, then allowing the PR build to have permission to access/update the same storage account would be unsafe, which cannot be blocked by the additional branch isolation logic inside the plug-in, but should not give the PR build machine the SAS token to do any update.
Or, if the PR cannot touch the build logic, but can only provide code, then the bad code will only yield to some result files, which would never be used by any CI, as long as the code has never been merged in. Those results are only referenced by fingerprints which would not exist in the CI build.


The cut of 3D Slicers

Hi, @JuliaWolleb
I have met a problem with the cut of 3D Slicers. What does "the lowest 80 slices and the uppermost 26 slices" mean? Maybe from 80 to 129 or from 26 to 75 in axial slicers. I look forward to your reply. Thank you!

Hi
It means the axial slices 80 to 129, if you count from bottom to top.


Provide 32 and 64-bit windows binaries

I would like to package lsd for scoop.sh (windows package manager) for easy installation by end users, but in order to do that I would like to request that you start providing 32-bit and 64-bit windows binaries with future releases.

Hello @martinlindhe ,
We already provide some 64bits windows packages inside the release page. I will look to add the 32bits if it's possible

@Peltoche That is good news. It was not the case when I reported this.


[Question] How do we trigger a route change component to render using react-router and redux-saga-router

Should the saga router live next to the react-router ?
I don't see any way to define my previous router in sagas :

export default function createRoutes(store) {
  // Create reusable async injectors using getAsyncInjectors factory
  const { injectReducer, injectSagas } = getAsyncInjectors(store);

  injectSagas(appSagas);
  injectSagas([routeSagas]);

  return [
    {
      path: pages.pageLogin.path,
      name: pages.pageLogin.name,
      onEnter: checkAuth(store),
      getComponent(nextState, cb) {
        const importModules = Promise.all([
          import('containers/LoginPage/reducer'),
          import('containers/LoginPage/sagas'),
          import('containers/LoginPage'),
        ]);

        const renderRoute = loadModule(cb);
        importModules.then(([reducer, saga, component]) => {
          // here we load asynchronously one saga and one reducer
          injectReducer(STORE_LOGIN_MAIN, reducer.default);
          injectSagas(saga.default);
          renderRoute(component);
        });
      },
    },
    {
      path: pages.pageDashboard.path,
      name: pages.pageDashboard.name,
      onEnter: checkAuth(store),
      getComponent(nextState, cb) {
        const importModules = Promise.all([
          import('containers/DashboardPage/reducers/index'),
          import('containers/DashboardPage/sagas/index'),
          import('containers/DashboardPage'),
        ]);

        const renderRoute = loadModule(cb);
        importModules.then(([reducers, sagas, component]) => {
          // here we load asynchronously an array of sagas and reducers
          reducers.default.forEach((reducer) => injectReducer(reducer.name, reducer.reducer));
          sagas.default.forEach((saga) => injectSagas(saga));
          renderRoute(component);
        });

        importModules.catch(errorLoading);
      },
    },
    {
      path: pages.pageTesting.path,
      name: pages.pageTesting.name,
      onEnter: checkAuth(store),
      getComponent(nextState, cb) {
        import('containers/TestingPage')
          .then(loadModule(cb))
          .catch(errorLoading);
      },
    },
    {
      path: pages.pageTestingagd.path,
      name: pages.pageTestingagd.name,
      getComponent(location, cb) {
        import('containers/TestingagdPage')
          .then(loadModule(cb))
          .catch(errorLoading);
      },
    },
    {
      path: '*',
      name: 'notfound',
      onEnter: checkAuth(store),
      getComponent(nextState, cb) {
        import('containers/NotFoundPage')
          .then(loadModule(cb))
          .catch(errorLoading);
      },
    },
  ];
}

I need to call a services when arriving on /dashboard, this is my sagas.js, this work but break my previous route :
import { router, } from 'redux-saga-router';
import { browserHistory } from 'react-router';

import { call, put } from 'redux-saga/effects';

import auth from 'services/auth';

const routes = {
  // Method syntax
  *'/dashboard'() {
    const services = yield call(auth.services);
    console.log(services);
    // yield put(setUsers(users));
  },
  //
  // // Or long form with function expression
  // '/users/:id': function* userSaga({ id }) {
  //   const user = yield call(fetchUser, id);
  //   yield put(setCurrentUser(user));
  // },
};

function* fetchInitialData(){

}

export default function* mainSaga() {
  // const data = yield call(fetchInitialData);
  //
  // yield put(ready(data));
  const start = new Date();
  console.log("timeout start", start.toISOString());
  console.log("start", new Date().getTime() - start.getTime());
  const toto = yield (call(setTimeout, 1000, () => new String('toto')));
  console.log("timeout end", new Date().getTime() - start.getTime());
  yield* router(browserHistory, routes);
}

I don't see any code example online, would be nice to get some help here. :)

According to this documentation : https://github.com/ReactTraining/react-router/blob/master/docs/guides/DynamicRouting.md , we should be able ton configure a getComponent function.
Is this plugin even working ?

Hi, @kopax!
Apologies, but I'm not sure what your issue is. Are you asking only for a way to define routes once, or are you claiming there is a bug too? I tweaked an uncommitted example I have of redux-saga-router with react-router and had no issue with dynamic routes and saga routes working together.
Can you please clarify your issue? If you found a bug, can you provide a minimal JSFiddle or JSBin to reproduce it please? Thanks!
Please note that redux-saga-router was never built to deeply integrate with react-router; it was mainly built to conveniently take the history object you might use from react-router, so the react-router <Link> component works with redux-saga-router. You could always add an additional saga key or something like that to your routes in your first example. Then you could iterate over the routes to create a new object to use with redux-saga-router. That way, you're only defining the routes once technically.

Hi @jfairbank ,

Apologies,  but I'm not sure what your issue is.

I am trying to call a saga within my router in order to fetch async data, this would be the same issue as him

. Are you asking only for a way to define routes once, or are you claiming there is a bug too?

I am, in fact, I am using [mxstbr/react-boilerplate(https://github.com/mxstbr/react-boilerplate/issues) for coding my application, they also use, redux-saga for asynchronous operation and redux-router for route transition. This is where you plugin could be useful.

I tweaked an uncommitted example I have of redux-saga-router with react-router and had no issue with dynamic routes and saga routes working together.

Would you mind sharing the work ? I am not very use to react-router as the one from the boilerplate is the first one I am using, do you recognize my boilerplate router and would you be able to implement your router on top of it ?

Can you please clarify your issue? If you found a bug, can you provide a minimal JSFiddle or JSBin to reproduce it please? Thanks!

I have injected the sagas I have printed during the router-creation in the boilerplate.
To be more precise, I have written import routeSagas from 'routes/sagas'; injectSagas([routeSagas]); excatly here
My route /dashboard handled in the return of this function is ignored when I inject the same route in the redux-saga-router saga :
const routes = {
  // Method syntax
  '/dashboard': function* () {
    const services = yield call(auth.services);
    console.log(services);
  },
};

this break my routes, and query the data, I would rather keep my route, and add a way to call to this function.
Is it possible to wait until the call is finish before triggering the route change?
I am not sure if it's a bug or just lake of documentation. Thanks for replying!

Thanks for the clarification, @kopax!
I cloned the boilerplate repo and created a minimal example that uses redux-saga-router here.
Relevant files:

https://github.com/jfairbank/_redux-saga-router_5/blob/master/app/containers/Dashboard/index.js
https://github.com/jfairbank/_redux-saga-router_5/blob/master/app/containers/Dashboard/sagas.js
https://github.com/jfairbank/_redux-saga-router_5/blob/master/app/containers/Dashboard/reducer.js
https://github.com/jfairbank/_redux-saga-router_5/blob/master/app/routes/sagas.js
https://github.com/jfairbank/_redux-saga-router_5/blob/master/app/routes.js

This example seems to work fine. redux-saga-router responds to the route, faking fetching data, and then dispatching an action to update the fictitious services object. react-router displays the Dashboard component. The Dashboard reducer uses a loading property for the Dashboard component to display a loading message until the services are ready from the saga.
Notice, I consolidate the routes by pulling in the servicesSaga from the Dasboard module and creating a custom saga property on my route. Downside to this is having to import the saga up front. Then, custom code below the routes creates a sagaRoutes object along with the routesSaga to use redux-saga-router.
If your code still isn't working, then I'll need to be able to look at a reproducible example of it not working via a repo or a fiddle in order to offer suggestions.
However, I will reiterate that redux-saga-router is mostly a standalone project that doesn't offer deep react-router integration besides reusing the history object. There is no way for redux-saga-router to fetch data in response to a route before react-router displays a component for the same route. In fact, I would call that behavior an anti-pattern. If your user clicks on a link, they need some type of immediate feedback, whether that's a loading message or a spinner. Waiting for data to be fetched with no UI change will create a bad user experience.
One other thing with this boilerplate I thought I should mention. If you only need to fetch your data once, then you really don't need redux-saga-router in this case. The lazily injected sagas and components will ensure that your dashboard saga is only run once the /dashboard route is loaded anyway.
Finally, if you're really looking for a way to fetch data before rendering a component, you could look at redux-tower, but I believe that it requires you to only use it with redux-saga and not use react-router at all. Still, I would recommend ensuring you display some sort of spinner or loading message while waiting on data to come back from an API.

@jfairbank
https://github.com/jfairbank/_redux-saga-router_5/blob/master/app/routes.js#L57
i see you had to comment the async saga loading in your example.
Can I use redux-saga-router with async sagas? I want to keep async loading for code splitting.

Hi, @dziamid. At the moment, there isn't a way to load a route saga asynchronously, but that would be a useful feature, especially for code splitting. Can you open a new issue for that feature please?

Closing old issue.


Geo Feature Resource creation issues

When creating this resource on beta, if I select one file for upload and then click the Create Resource button, I see a spinning cursor that goes on for ever. I think it would be better to show a message if the use has selected one ore more files but has missed to select one of the 3 required files.

@mauriel133 See this can be addressed as a hotfix the current release candidate.

@pkdash, it is not clear from the UI which ones are the required files. I think this specification should appear as a hint below the file browser. Also, the solution you propose is very specific for this resource type. Should we implement business logic for handling required files before a resource can be created?

@Maurier I think this problem of spinning wheel we experienced in many different scenarios. @hyi recently noticed the same issue when testing quota. I think she tried to fix that in the PR (https://github.com/hydroshare/hydroshare/pull/2184) that she currently has for quota feature.

@pkdash @Maurier We may be able to close this after 1.14 goes out

@pkdash and @Maurier - is this still an issue? If not close it. If it is, I'm not sure we want to spend time on it now that geographic feature content can be added to composite resources and we should soon discourage the creation of geographic feature resources.

This issue was fixed with the implementation of filer requirements in the Create Resource page. Closing.


added gym website template

Description
I have created An interactive gym website using HTML , CSS and javascript
Fixes:  #682
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK
https://nouraan-ahmed.github.io/Fitness-Time/

@nouraan-ahmed how did u make ir

Also, improve Navbar UI and add the project in style_links.json

@astha2412 Done

https://github.com/surajm-333/Ace-The-FrontEnd/pull/410
Not allowed to add the same project in multiple repos

Yes, you cannot add same project in 2 repos


zephyr: coap: fix keepalive behavior

ensure keepalive timer is reset after callback
reset keepalive timer whenever a response is received
remove ping timer logic and Kconfig symbol

The ping timer was duplicating the keepalive timer functionality. The keepalive is used by the libcoap platforms so this change brings better parity.
resolves https://github.com/golioth/firmware-issue-tracker/issues/592

I verified that the keepalive is being sent through the mbox so we should be good in terms of thread-safeness. Moving this out of draft.


Without Jquery?

Hi!,
There no way to use this awesome plugin , without jQuery dependency?.
I was looking fast,  the code in angular-tour.js, and, this not looks really jQuery dependant?
Thanks in advance.

I've done some work on this and got smooth vertical scrolling added. Should I initiate a pull request?


Commands output format consistent

A PR to make output node information format consistent across ockam node create | show | list commands. (#3042)
Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

Merged in https://github.com/build-trust/ockam/pull/3091


GH-35492 [MATLAB]: Add arrow.array.Float32Array MATLAB Class

Rationale for this change
Continuing to build the MATLAB interface to Arrow for numeric types. We're trying to keep the scope of these pull requests small to make them easier to review.
What changes are included in this PR?

Added arrow.array.Float32Array MATLAB class
Added new test class tFloat32Array.m

Are these changes tested?

Yes, added a new test class called tFloat32Array.m.
Qualified locally on macOS.

Are there any user-facing changes?
Yes, users can now create a array of float32 values.
Future Directions

Continue building out support for numeric arrays.
Add shared validation functions.
Make a shared test class for Numeric Arrays.

Closes: #35492

Marking this as ready for review.

I'm not sure why there was a linker error in the macOS build. The MATLAB action passed in the mathworks/arrow fork. I noticed a couple of the other MATLAB runs in mathworks/arrow have failed with the same linker error, but it the issue appears to be sporadic. I'll try re-running the action to see if it the same issue appears again.

Hi @kou,
The CI passed on the latest try. It looks like the CI sporadic and not related to this pull request because we've seen a couple of times now.

OK.
I'll merge this.

Thanks for merging this @kou! We're going to look into this failure in the background.

We've captured this sporadic build failure as an issue in mathworks/libmexclass.


Listing Div Margin

Hello,
I'm currently doing an Ember Tutorial Guide and on page named Installing Addons, I have to install Your npm. Unfortunatelly It has weird margin on one of div's as You can see on photo from link under this. From developer settings on Chrome there isn't any margin, but on every browser It renders like it have. I also restarted my mac but it doens't change anything
here is an uploaded photo with problem : https://ibb.co/zbN9711 ( Grand old mansion has margin on right side )

Thanks for reporting ❤.  Will take a look


openvdb: 7.0.0 -> 9.1.0

Description of changes
this update seems to be required to build prusa-slicer 2.5.0-alpha2
(of which the appimage doesn't run with appimage-run, hence my attempt to build it)
the currently packaged version is from 2019 while the project is being actively developed and released
(automatic updates seem to have stopped working due to a build system change which i appear to have corrected for)
https://www.openvdb.org/documentation/doxygen/changes.html#v9_1_0_changes
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

minus blender, that's a bit of a big build

[x] Tested basic functionality of all binary files (usually in ./result/bin/)

prusa-slicer 2.5.0-alpha2 builds and runs using this dependency

22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

courtesy ping of possibly affected maintainers for:
this package, @guibou
blender, @cillianderoiste @veprbl
prusa-slicer, @moredread @thorstenweber83
super-slicer, @cab404
bpycv, @lucasew

@GrahamcOfBorg build blender python3Packages.bpycv

Thanks!


Tool Leprechauns highlighted as Hunter NPCs

For some reason with my current task of Razor-backed Kebbits all Tool Leprechauns are now highlighted. Turning off that option un-highlights them.

Thanks for the heads up, I'll look into this today.

I'm working on the plugin all day tomorrow and will make this a priority.

@geel9 1.0.1 did not fix this for me. Does 1.1.0?


The context references in resource responses are not resolvable

I think this is caused by https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors/CORSExternalRedirectNotAllowed

you mean to change the contexts to https://bluebrainnexus.io/contexts/...?

Yes I've fixed the comment

What do you think about the schemas?

I don't know. It is not necessary to change those, but we could too. However, we have to verify that it does not break anything on clients. If someone is using the constrainedBy value to decide what to do with a resource, they'll have to make changes there (usually they should be using types instead, but who knows...)

I think this problem only affects the json-ld playground... any other (non-browser) clients should follow the redirect.

Agree on your comment about the schema.

It will affect any browser based implementation.
Event it were just the playground, it would be extremely useful to be able to use the playground directly with our payloads in order to quickly debug things

The decision was that for now we keep the same domain, since we would rather change the domain for all our vocabulary of for none. And changing it for all the vocabulary would lead to different triples on our metadata.


IllegalStateException: Files must be organized like src/main/sqldelight/...

I have an permanently exception in Android Studio event log:
IllegalStateException: Files must be organized like src/main/sqldelight/...
But my .sq files alredy in src/main/sqldelight/bla/bla/bla =)
Gradle plugin working without errors and makes Model interfaces from my .sq files.
OS: Windows 10 x64
Android Studio: 2.0.0 beta6
Gradle 2.11
Android gradle plugin: 2.0.0-beta6
SQLDelight: 0.1.2
SQLDelight Android Studio plugin: 0.1.2
Android Studio used jre form latest IDEA 16 Preview
Gradle used Oracle JDK 1.8.0_73 x86
Files must be organized like src/main/sqldelight/...
java.lang.IllegalStateException: Files must be organized like src/main/sqldelight/...
	at com.squareup.sqldelight.TableGeneratorKt.relativePath(TableGenerator.kt:129)
	at com.squareup.sqldelight.generating.TableGenerator$Companion.create(TableGenerator.kt:112)
	at com.squareup.sqldelight.generating.SqlDocumentAnnotator.collectInformation(SqlDocumentAnnotator.kt:34)
	at com.squareup.sqldelight.generating.SqlDocumentAnnotator.collectInformation(SqlDocumentAnnotator.kt:30)
	at com.intellij.lang.annotation.ExternalAnnotator.collectInformation(ExternalAnnotator.java:57)
	at com.intellij.codeInsight.daemon.impl.ExternalToolPass.collectInformationWithProgress(ExternalToolPass.java:115)
	at com.intellij.codeInsight.daemon.impl.ProgressableTextEditorHighlightingPass.doCollectInformation(ProgressableTextEditorHighlightingPass.java:82)
	at com.intellij.codeHighlighting.TextEditorHighlightingPass.collectInformation(TextEditorHighlightingPass.java:67)
	at com.intellij.codeInsight.daemon.impl.PassExecutorService$ScheduledPass$1$1.run(PassExecutorService.java:444)
	at com.intellij.openapi.application.impl.ApplicationImpl.tryRunReadAction(ApplicationImpl.java:1180)
	at com.intellij.codeInsight.daemon.impl.PassExecutorService$ScheduledPass$1.run(PassExecutorService.java:435)
	at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:446)
	at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:392)
	at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:54)
	at com.intellij.codeInsight.daemon.impl.PassExecutorService$ScheduledPass.doRun(PassExecutorService.java:432)
	at com.intellij.codeInsight.daemon.impl.PassExecutorService$ScheduledPass.run(PassExecutorService.java:408)
	at com.intellij.concurrency.JobLauncherImpl$VoidForkJoinTask$1.exec(JobLauncherImpl.java:206)
	at jsr166e.ForkJoinTask.doExec(ForkJoinTask.java:260)
	at jsr166e.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:858)
	at jsr166e.ForkJoinPool.scan(ForkJoinPool.java:1687)
	at jsr166e.ForkJoinPool.runWorker(ForkJoinPool.java:1642)
	at jsr166e.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:108)

Thanks for the well put together report. This is a dupe of #149 though and was recently fixed on master. We'll put out a new release early next week to unblock Windows users.

Sorry for the duplicate, the next time I will look into the closed issues too =)

Hmm, I got the same exception (on Linux), but with different reproduction steps:

Put .sq file in a wrong directory
Observe error reported by plugin ("Files should be organized...")
Move file to the correct path
Error still present. Compilation is OK. Creating new .sq files in a same folder works fine, no errors

Should this be reported separately or is this a known issue?
Using all the current versions as of today (0.2.2 of gradle plugin, intellij plugin)


Mouse jumping around when using steam input

When I set in games that need steam input, the mouse keeps jumping around even if I move very minimally,
It happens in both steam and flatpak games, but not when using actual mouse and keyboard,

This is in Gamepad UI or the old BPM?

Is this issue still relevant? Does it still happens in current testing image?

This issue is still happening


About  the reproducibility

Thank you for open-sourcing this interesting work, I am trying to reproduce the results mentioned in the paper, specifically, I am using a 4090 gpu to train the model, I set the batchsize to 256, and all other parameters are used by default. My results from running BLEEP_inference.ipynb with the trained model are as follows, the hvg and mg obtained are even negative, why is this the case and can the author open source the checkpoints?
`Building loaders
Finished loading all files
Finished loading all files
Finished loading all files
Finished loading all files
Finished building loaders
Finished loading model
100%|██████████| 290/290 [00:08<00:00, 34.78it/s]
Building loaders
Finished loading all files
Finished loading all files
Finished loading all files
Finished loading all files
Finished building loaders
0%|          | 0/290 [00:00<?, ?it/s]Finished loading model
100%|██████████| 290/290 [00:07<00:00, 38.64it/s]
(9269, 256)
(9269, 256)
(2378, 256)
(2378, 256)
(2349, 256)
(2349, 256)
(2277, 256)
(2277, 256)
(2265, 256)
(2265, 256)
image query shape:  (2277, 256)
expression_gt shape:  (2277, 3467)
spot_key shape:  (6992, 256)
expression_key shape:  (6992, 3467)
finding matches, using average of top 50 expressions
torch.Size([2277, 6992])
matched spot embeddings pred shape:  (2277, 256)
matched spot expression pred shape:  (2277, 3467)
(2277, 3467)
(2277, 3467)
Mean correlation across cells:  0.7978978720733318
number of non-zero genes:  3467
max correlation:  0.23411531692744628
mean correlation highly expressed genes:  0.005858165903247573
mean correlation highly variable genes:  -0.012843590028633467
mean correlation marker genes:  -0.04743001734357476
(3467, 2277)
(3467, 2277)`

I have the same issue.
Mean correlation across cells:  0.8019596690894127
number of non-zero genes:  3467
max correlation:  0.5790064845037544
mean correlation highly expressed genes:  -0.008542352918207631
mean correlation highly variable genes:  0.007238810597933147
mean correlation marker genes:  -0.013030684962897124

I have fixed it. Just change the bs and lr.

Correct, the issue has been resolved.


Launch Binder - service unavailable

The binder.pangeo.io service has been shut down due to crypto mining

Works again, but fails intermittently.  Added a note to the documentation.


Add button media query, center volume

#97

Added media query to devices with max-width 650px to address button styling issues.

Do I understand correctly that you would like both the volume icon and volume control to be centered at the bottom as one unit? Wanted to confirm with you before addressing.

*Let me know if any additional changes are needed to this PR, I would be happy to address them immediately.

Thank you for your help! However I cannot see any update in the story that you mention requirements

were you trying to fix something else adjusting padding and font size?
As suggestion, try to center the volume for any width size using techniques like display: flex or margin: auto. Let me know if I can help/ you have any question!

I've drawn a simple mock of how it should be looking like:

the two words "Stop All" should be in the same line, not breaking and the volume line/icon centered dynamically with the content. Hope it helps :)

#99 Fixes this issue, so I'm closing this PR.


Outlets are searched in view controller doing the layout node loading

Version: 0.48
Xcode: 9b5
iOS Sim: 11.0
I am duplicating the approach to loading layouts provided by SampleApp. I have a MainViewController that loads Main.xml which provides UITabBarViewController with a couple of tabs.
The tabs though contain subclasses of UIViewController and LayoutViewController and the view that is nested under them contain elements with outlet attributes. I would expect the outlets  to be connected to the instances of the tabbed view controllers, however I get an error that the outlet could not be found in MainViewController.
Is this intended behaviour or a bug?

This looks like a bug, although there are some known limitations of the existing binding system, which are that it can't bind some outlets to the main controller and some to intermediate controllers, it has to bind all properties to the same owner, so is it possible that's the cause?

Sadly I can't tell since I don't know much about bindings.

No. It just loads Main.xml

Can you paste in your XML? I'll look into it.

Main.xml
<UITabBarController>

    <UIViewController
        xml="MyTableViewController.xml" />

    <UIViewController
        tabBarItem.title="Scroll"
        xml="ScrollViewController.xml" />
</UITabBarController>

ScrollViewController.xml
<UINavigationController>
    <ScrollViewController>
        <UIView>
        <UIScrollView
            width="100%"
            height="100%"
            backgroundColor="#fff">
            <UIView
                outlet="imageContainer"
                top="0"
                left="0"
                height="236"
                width="100%"
                backgroundColor="#0f0a">
                <UIImageView
                    width="100%"
                    height="100%"/>
            </UIView>
            <UIView
                outlet="firstRow"
                top="previous.bottom"
                left="0"
                height="75"
                width="100%"
                backgroundColor="#ff0a">
                <UILabel
                    top="8"
                    left="8"
                    text="Title" />
                <UILabel
                    top="previous.bottom + 8"
                    left="8"
                    text="Subtitle" />
            </UIView>
            <UIView
                top="previous.bottom"
                width="100%"
                height="75">
                <UILabel
                top="8"
                left="8"
                text="Title" />
                <UILabel
                top="previous.bottom + 8"
                left="8"
                text="Subtitle" />
            </UIView>
        </UIScrollView>
        </UIView>
    </ScrollViewController>
</UINavigationController>

ScrollViewController.swift
import UIKit

import Layout

class ScrollViewController: LayoutViewController {

    var imageContainer: UIView?
    var firstRow: UIView?

    override func viewDidLoad() {
        super.viewDidLoad()
    }
}

@eimantas sorry it's taken a while to get back to you.
I tried your sample code and I'm not seeing any errors. I thought perhaps I'd fixed the bug by accident, but I tried with 0.4.8 and I'm still not seeing the issue.
I also tried it on both Xcode 8.33 and Xcode 9b5, and it made no difference. If I delete one of the outlets, such as imageContainer, then I get an error saying that it doesn't exist on MainViewController, but no error otherwise.
The only thing I could think might be causing it is that imageContainer and firstRow are not marked with @objc or @IBOutlet, and Swift 4 is stricter about implicit Obj-C runtime compliance than 3 was, but if you're using Swift 3.2 that shouldn't matter.
Anyway, if you can update the sample, or provide a complete project that repros the issue I'm happy to investigate further.

Here's the project for this issue: https://github.com/eimantas/LayoutAppSandbox
I've bundled it with Layout 0.4.12  version and now instead of receiving error about missing outlets I see the error about missing MyTableViewController.xml file.

@eimantas OK this is very weird because I just checked out that project you gave me and it runs fine.
I wonder if the issue has something to do with the location on your hard drive. Maybe the path contains spaces or something that's confusing the live reloading?
Another possibility is you may have some junk in your build folder, and a clean build or deleting the app from the simulator might fix it?

Weird. I deleted ModuleCache and project directories in DerivedData and even reset the content and settings for the simulator. Still same error...

Another thing, if I rearrange the <UIViewController> tags in Main.xml like this:
<UITabBarController>

    <UIViewController
        tabBarItem.title="Scroll"
        xml="ScrollViewController.xml"
        />

    <UIViewController
        tabBarItem.title="Table"
        xml="MyTableViewController.xml"
        />
</UITabBarController>

The app starts complaining about missing ScrollViewController.xml file. 🤔

Here it is running on my machine, with the Main XML configured as above, and no other changes:

I removed the precompiled framework and added a reference to Layout.xcodeproj file and linked against the framework built from source code. Issue is the same. Here is the file/project structure:
Layout.framework: /Users/eimantas/Development/layout/
LayoutApp: /Users/eimantas/Desktop/LayoutApp/
So no spaces, no fancy text, just plain ASCII characters. Here's another thing, I've added some print statements around the troubling lines and here's what I got: https://gist.github.com/eimantas/6bb8a779ec9b8106557b9ec52b272931
The separator denotes the call to LayoutLoader.findSourceURL. Notice that after finding Main.xml it continues searching in framework's directory and never comes back to the application bundle.

I wasn't ever able to reproduce the issue, but hopefully the changes in 0.4.13 will have fixed this. Let me know if not.


JGRP-2359 Route list can be empty

https://issues.jboss.org/browse/JGRP-2359
See JIRA for details.
I decided to do a copy to perform the changes from the view change. However, I'm open to suggestions.
Also, the Relay2Test is failing (for me) in master and I was unable to test if this breaks anything :)

ps. needs backport to 4.0.x :)

Why the need for the copy? We use a ConcurrentHashMap for routes; if you want to do a route and the list is empty, can't you handle it (= an empty list)? This means a route was removed in viewAccepted() while a route() was going on...

Oops, I see this is for the value (List<Route>)! OK...

@belaban Thanks!


Is apex a must have or not?

In your README file apex seems to be an optinal requirement.
However, during import time an annoying message warning me that I don't have this module installed keeps poluting my code log.
I tried to reinstall the package using the recommended command and nothing changed at all. I also tried to use warning library to ignore the warning but the way it is implemented is using the Python logging library and I can't remove it this way.

@gosiqueira apex is an optional requirement. But I'm sorry about that annoying message, it's supposed to be silenced with the following config (see also #PR9):
# set logging level to ERROR to silence the warning message
import logging
logging.getLogger("torch_lr_finder.lr_finder").setLevel(logging.ERROR)

# warning message "To enable mixed precision training..." won't be shown if apex is not installed
from torch_lr_finder import LRFinder

But I didn't notice that current implementation of that warning message might mess up existing logging system, it seems it deserves a better alternative.
I'll make a fix for it later, and thanks for bring it up.

Thank you, very much for your fast response. I really appreciate the good job you're doing here.
I'll use your alternative to silence the warning message.

Tahnk you very much for answering me in such a short time. I really appreciate the good job you're doing here.
I used the snippet you send here and it worked perfectly. Once again, thank you

@NaleRaphael has removed the warning and a new release has been deployed with the fix. Closing the issue


Do not support single namespace install mode

What does this PR do?
DevWorkspace operator which is a dependency for WTO, is going to be All namespaces mode.
So, it forces WTO to be all namespaces mode, even though WTO does not need to watch all namespaces ATM.
It's agreed with OLM team and they told all operators are moving to all-namespace mode, so it won't be possible to install the same operator twice.
Also, this PR has a dedicated commit to change channel from alpha to fast, it's done due:

this way we force users to manually uninstall WTO from a new channel;
fast is name recommended by OLM https://olm.operatorframework.io/docs/best-practices/channel-naming/#naming for

Released, supported operators which are still being monitored to assess stability/quality prior to promoting them as stable. Generally used by early adopters or for testing in pre-production environments.

What issues does this PR fix or reference?
It's for https://issues.redhat.com/browse/WTO-101
Is it tested? How?

Should we also remove main/manifests/web-terminal.clusterserviceversion.yaml#L54 since I don't think it's relevant unless singlenamespace is supported

Actually, OpenShift docs say nothing that it's not supported with AllNamespace mode https://docs.openshift.com/container-platform/4.7/operators/operator_sdk/osdk-generating-csvs.html#osdk-suggested-namespace_osdk-generating-csvs.
So, I checked and it works for AllNamespace mode as well, although in a strange way:

After a few seconds:

But if I manage to click install on the first phase, a namespace with a subscription are created. But nothing happens (0 install plans active), probably due to missing OperatorGroup.
But it works fine with openshift-operators, so I'm returning it back.


Fix e2e test RejectServiceTraffic

createAgnhostServiceAndBackendPods should create the service with the
selector that can only selects the Pod created together with it.
Previous selector selected all Pods using agnhost image, causing
traffic destined for service to be forwarded to unexpected Pod.
This patch also changed to use same Pod selector for Service and
ClusterNetworkPolicy to avoid redundancy and inconsistency.
Signed-off-by: Quan Tian<EMAIL_ADDRESS>

Codecov Report

Merging #3892 (6c93ac0) into main (b8279c9) will decrease coverage by 10.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #3892       +/-   ##
===========================================
- Coverage   64.41%   54.21%   -10.21%
===========================================
  Files         291      287        -4
  Lines       42795    42605      -190
===========================================
- Hits        27568    23098     -4470
- Misses      13003    17633     +4630
+ Partials     2224     1874      -350

Flag
Coverage Δ

kind-e2e-tests
32.51% <ø> (-18.24%)
:arrow_down:

unit-tests
44.74% <ø> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


same path problem

This is a case of similar looking paths
observabilitytypes/faire/common/collection.proto
observabilityapi/faire/common/collection2.proto
third/faire/common/some.proto

and add the following imports in some.proto
import "faire.common/collection.proto"
import "faire.common/collection2.proto"

and buf.work.yaml inlcudes
version: v1
directories:
  - observabilityapi
  - observabilitytypes
  - third

buf breaking --against .git#subdir=workspace
third/faire/common/some.proto:5:8:faire.common.collection2.proto: does not exist
My problem is that our protos are set up like and I am wondering how I can make this work.
repo/protos/<moduleA>/src/main/proto/faire/common/protofileA.proto
repo/protos/<moduleB>/src/main/proto/faire/common/protofileB.proto
repo/protos/<moduleC>/src/main/proto/faire/common/protofileC.proto
repo/protos/<moduleD>/src/main/proto/indigofair/common/protofileD.proto
repo/protos/<moduleE>/src/main/proto/indigofair/common/protofileE.proto

And imports look like
import "faire/common/protofileA.proto"
import "faire/common/protofileB.proto"
import "indigofair/common/protofile"

And I have a file Repo/buf.work.yaml
Containing
directories:
- protos/<moduleA>/src/main/proto
- protos/<moduleB>/src/main/proto
- protos/<moduleC>/src/main/proto
- protos/<moduleD>/src/main/proto
- protos/<moduleE>/src/main/proto

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update grpc/INSTALL to drop references to OpenSSL and make correct references to hurried installs

https://github.com/grpc/grpc/blob/release-0_13/INSTALL is out of date.
There are references to apt-get install libgrpc, openssl and zlibg we can remove.
This doc needs to be updated for the 0.13 release.
/cc @ctiller @nicolasnoble

Yes, and lets clean it up so this clearly says that this file has instructions to build from source and organize the rest of the file by OS. (linux, windows and mac). "If you are in a hurry" can point back to grpc.io or replicate the same instructions (clearly stating them for installation and use)


Kafka-for-Cherami integration test

Coverage increased (+0.1%) to 68.815% when pulling f7514e80584b3d3a5a37011e03178fe1689db98b on kfc-integration-test into 7579e0b0b3e1a8a9a7238d1b0708e671fb54c92d on master.


CI's job succeeded even there is an PHP error inside

Q
A

Issue Type
Bug

Deployer Version
5.0.1

Local Machine OS
Ubuntu 14.04.5 LTS

Remote Machine OS
-

Description
When I've accidentally made typo in function name, CI job has succeeded even there was an error inside the job. I guess there is some bad exit code.
Steps to reproduce
Set up a deploy with bad function name (I typed host() instead of hostname()) and make a deploy in GitLab CI.
Content of deploy.php
<?php

namespace Deployer;

/** @noinspection PhpIncludeInspection recipe comes from Deployer tool */
require 'recipe/common.php';

// CONFIGURATION

set('ssh_type', 'native');
set('ssh_multiplexing', TRUE);

set('shared_files', [
	'...',
]);
set('shared_dirs', [
	'...',
]);
set('writable_dirs', [
	'...',
]);

// SERVERS

host('mysite')
	->stage('mysite')
	->host('<IP_ADDRESS>') // typo in here
	->port(22)
	->user('someuser')
	->identityFile('/root/.ssh/id_rsa')
	->set('deploy_path', '/var/www/web');

// TASKS

task('deploy:copy_application', function () {
	upload('..', '{{release_path}}');
});

// For definitions of tasks bellow:
// @see https://github.com/deployphp/deployer/tree/master/recipe/deploy
desc('Deploy your project');
task('deploy', [
	'deploy:prepare',
	'deploy:lock',
	'deploy:release',

	'deploy:copy_application',

	'deploy:copy_dirs',

	'deploy:shared',
	'deploy:writable',

	'deploy:symlink',

	'deploy:unlock',
	'cleanup',
	'success',
]);

after('deploy:failed', 'deploy:unlock');

Output log
 dep deploy mysite --ansi -vvv

 [Error] Call to undefined method Deployer\Host\Host::host()

 #0 /root/.composer/vendor/deployer/deployer/src/Deployer.php(309): require()
 #1 [internal function]: Deployer\Deployer::Deployer\{closure}()
 #2 /root/.composer/vendor/deployer/deployer/src/Deployer.php(310):
 call_user_func(Object(Closure))
 #3 /root/.composer/vendor/deployer/deployer/bin/dep(120):
 Deployer\Deployer::run('master', '/builds/nakloub...')
 #4 {main}

Job succeeded

Fixed.


Improve API structure

Is your feature request related to a problem? Please describe.
The API structure is inconsistent, across the calls.
Describe the solution you'd like
A clearer API structure and more consistent approach to different protocol/network. Send, receive, get address is different to read status and resolve address/name
Describe alternatives you've considered
N/A
Additional context
Add any other context or screenshots about the feature request here.

Current Endpoint
Notes
New Endpoint

/addresses

/ethereum/{network}/address/{address}/messages
Wrong way around? Should not be protocol specific?
address/{address}/messages/?protocol={protocol}&network={network}

/ethereum/{network}/address/{address}/public-key
Wrong way around? Should not be protocol specific?
?protocol={protocol}&network={network}

/ethereum/{network}/messages/send
Wrong way around? Should not be protocol specific?
?protocol={protocol}&network={network}

/messages/{message_id}/read

/nameservice/address/{address}/resolve?protocol={protocol}&network={network}

/nameservice/name/{domain-name}/resolve?protocol={protocol}&network={network}

/protocols

Proposed solution is:

Replace /ethereum/{network}/address/{address}/messages with /messages/?protocol={protocol}&network={network}&address={address}
Replace /ethereum/{network}/address/{address}/public-key with /public-key?protocol={protocol}&network={network}&address={address}
Replace /ethereum/{network}/messages/send /messages
Maintain all other endpoints


Links in the footer have to be changed.

Describe the bug
Links in the footer are not working
To Reproduce
Steps to reproduce the behavior:

Go to the footer.
Click on links there in the subjects section.
See 404 page.

Expected behavior
Pages with actual course should have been pushed into the url.
Screenshots

Additional context
Please assign this issue to me! I am a GSSoC '24 contributor.

can you assign me this issue


When the server does not return JSON, a more sensible error message should be generated

Is your feature request related to a problem? Please describe.
When I create the client with the wrong URL, there can be cryptic error messages like:
__request(self, method, endpoint, **kwargs)
    520         raw_response = self._run_request(method, endpoint, **kwargs)
    521
--> 522         response = raw_response.json()
    523         self.__handle_error(response)
    524         return response

These indicate that the server responds but does not provide JSON.
Describe the solution you'd like
When the server does not return JSON, a more sensible error message should be generated
Additional context
Was part of https://github.com/averbis/averbis-python-api/issues/53

Should be treated in #60 .


Comments Count include blocked users' comments

As the title says :)
See the following line for the method.
https://github.com/OkunaOrg/okuna-api/blob/f51dcfdce729223e3ec32708a56845ad07067e61/openbook_posts/models.py#L222-L237
And also check the following lines in the same files for adapting the query:
https://github.com/OkunaOrg/okuna-api/blob/f51dcfdce729223e3ec32708a56845ad07067e61/openbook_posts/models.py#L157-L158
Other places?
Maybe there are other places where blocked user doesn't get filtered out?

Also going to fix that comment counts dont include replies yet, many users also found it odd, and showing the full count is more representative of the activity than just top level comments.


Documentation website?

Hey, I noticed that the website with the documentation is offline. Any ideas on when we'll be able to access it?
Thank you!

Yes would be very nice if someone has some documation....
I try to get Filters working and looking for a tutorial.....


Update kex and macs

Use the latest kex and macs according to https://infosec.mozilla.org/guidelines/openssh.

Check out this post to find out why ecdh-*-nistp* are disabled. I'd suggest to only enable those, if you have clients that do not offer better algorithms.
<EMAIL_ADDRESS>should be tolerable as least preferred MAC, IMHO.

I agree with @lpirl . @atomic111 whats your view on this?

Okay, after further reading, I got to this: https://tools.ietf.org/id/draft-ietf-curdle-ssh-kex-sha2-09.html

However, given [CNSA-SUITE] and [safe-curves], this curve may not be as useful and strong as desired for handling TOP SECRET information for some applications. The SSH development community is divided on this and many implementations do exist.

So I agree, this should not be implemented.

Thanks for sharing @rndmh3ro, interesting.
Maybe we should tell the authors of https://infosec.mozilla.org/guidelines/openssh to update their post?


Cannot insert empty buffer (it becomes NULL)

Similar to https://github.com/JoshuaWise/better-sqlite3/issues/11
My NOT NULL constraint is failing for empty BLOB.
<EMAIL_ADDRESS>Node v14.17.0

const Database = require('better-sqlite3');
const db = new Database(':memory:');

db.exec('CREATE TABLE data (contents BLOB)');
db.prepare('INSERT INTO data (contents) VALUES (?)').run(new Uint8Array(0));
console.log(db.prepare('SELECT * FROM data').all());

[ { contents: null } ]

Related
https://github.com/ericsink/SQLitePCL.raw/commit/e324598161b6941e1e79ccfa7088ca281f47294b
https://github.com/dotnet/efcore/issues/17494#issuecomment-526253452
https://github.com/aspnet/Microsoft.Data.Sqlite/pull/208/files
https://sqlite.org/forum/forumpost/5bae43cbd77fc654?t=h
<EMAIL_ADDRESS>Also what is it with SQLite forums and "The author has deleted this message."....

For now I'm working around it by binding an empty string when the buffer is empty
stmt.run({
    content: content.length === 0 ? '' : content,
});

This is fixed in v7.4.3

Thanks!


Fix bug in curl command to fetch official CVE feed

Without the -L flag curl will only report there's a redirect. L will follow redirects all the way to the destination.

/retitle Fix bug in curl command to fetch official CVE feed
/sig docs
/sig security
/lgtm

Thank you for the fix
/approve


deps(v7)!: bump IBC-Go v7.6.0

Will tag as packet-forward-middleware v7.2.0

i think something with the golangci-lint server is down. Works for me locally, not remote (404) on download.

i think something with the golangci-lint server is down. Works for me locally, not remote (404) on download.

so weird it looks like it is still returning some errors. i didn't deep dive this but it almost looks like the things it is complaining about aren't even issues in this repo though but rather one of the dependencies?

@jtieri yep exactly! It may be due to some go1.XX version thing or linter version based on one of the deps.

@jtieri yep exactly! It may be due to some go1.XX version thing or linter version based on one of the deps.

what should we do with this, just approve and merge?

closing, do in the new v7 backport PR


Update installer.sh

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
#42
fixes missing dev packages for python 3.9
What is the current behavior? (You can also link to an open issue here)
Deprecated
What is the new behavior (if this is a feature change)? If possible add a screenshot.
able to compile again
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
YES version requires new installation
OR running sudo apt install python3.9-dev


multipart form validation

I'm trying to ensure only certain types of files are accepted. When validating a file upload you just get the raw the bytes.
local validator = fm.makeValidator({
  { "file", msg = "...", test = function (file)
    -- file is the raw bytes; i.e. r.params.file.data
    -- it'd be nice to have file.data, file.headers, etc.
  end},
})

As a work around I'm using multi-file inputs everywhere and just processing the first file. This works because you get access to the full multipart table:
local validator = fm.makeValidator({
  { "files", msg = "...", test = function (files)
    local file = files[1]
    -- file.headers, filename, data etc. are there as expected
  end},
})

It got me thinking maybe the validators for single and multi file uploads could be more similar:
-- single file upload
local validator = fm.makeValidator({
  { "file", msg = "...", test = function (file)
    -- file.headers, filename, data etc.
  end},
})
-- multiple file upload
-- test function is called for each file instead of once as it is now
local validator = fm.makeValidator({
  { "files", msg = "...", test = function (file)
    -- file.headers, filename, data etc.
  end},
})

I could live without calling the test function for each of a multi-file upload but it seemed like a nice convenience. Having the full multipart table in the single file case would be most welcome.

I thought about that, but I think the consistency of being able to extract parameter values in exactly the same way whether they are passed using multipart/form-data or application/x-www-form-urlencoded. If you do know that it's a multipart parameter, then you have two main options: extract them like you do using files[] syntax or extract them using { "multipart", test = function(multipart) end }. This makes it more explicit and still gives you access to everything you need (but only when the multipart parameters are indeed present).
I also thought about always returning a table, but making it behave as a string to handle these cases, but it's not possible to do it properly in many cases and requires overwriting __len, __concat, __tostring and some other metamethods and still leaves some wholes (for example, you can's use the comparison: file == "123" when file is a table and there is nothing I can do about it). To work properly it would require always using tostring on those parameters, which in my opinion is too much for the developer to do.

Thanks for the explaination.

{ "multipart", test = function(multipart) end }

This is the part I was missing. I didn't see that you can use "multipart" that way.

Thanks @johnmuhl; it's good to hear that this option works for you. Would you expect it to be covered in the validation section? I do describe multipart pseudo-parameter in the section on multipart parameters, but I think it may benefit from adding a sentence or two about validation there.

After you mentioned it I went back to the form validation section to see if I had missed it so a note there would have helped me.


[Feature request] Clarify switch to Vite bundler instructions

Feature request
Description
In Guide > Bundler > Vite, it says:

If you want to use Vite instead, you can switch to vuepress-vite package:

yarn add -D vuepress-vite@next

From this text, it is not clear that unless you uninstall the vuepress package, you will still have the default webpack bundler and all its dependencies installed, unnecessarily. However, if you remove the vuepress package, then the scripts suggested in Getting Started > Manual Installation > Step 4 stop working, unless they are changed to vuepress-vite.
Proposed Solution
The current documentation describes changing the bundler via the bundlerConfig option, which is technically true but probably the least likely scenario. It seems more likely that a new user installed VuePress following standard instructions and then later wanted to switch from the default bundler to the webpack bundler.
General recommendations for documentation:

Consolidate and move the paragraphs about setting the bundler and bundlerConfig to the end of Guide > Bundler, as that is advanced information.
Change the Vite section to instead describe the steps of switching from the default bundler to Vite, including uninstalling vuepress.

More long-term, please consider one or more of the following:

Rename the existing vuepress package to vuepress-webpack, makes the bundler choice explicit.
Change the vuepress package to not include a bundler by default and instead make installing either @vuepress/webpack or @vuepress/vite similar to how Vue 3 install instructions recommend installing @vue/compiler-sfc.
VuePress could automatically detect whether a suitable bundler is installed and just use it as if it had been configured manually with bundler in config.

If just the documentation recommendations were applied, the Guide > Bundler page content might look something like this (there is some slight copyediting also).

Bundler
VuePress has been using [webpack] as the default bundler to develop and build sites. Since VuePress v2, other tools like [Vite] are also supported. Although it is possible to use other bundler packages made by community users, currently we only suggest to use the bundlers provided by VuePress team.
Webpack
When using the vuepress package, the webpack bundler is installed and used automatically. There's nothing further for you to do. [Read more about installing and configuring the webpack bundler here.] link to reference/bundler/webpack
Vite
If you want to use the Vite bundler, the easiest way is to uninstall the vuepress package and switch to the vuepress-vite package instead:
yarn add -D vuepress-vite@next
yarn remove vuepress

If you switch, you may have to replace scripts in your package.json with with vuepress-vite, like this:
{
  "scripts": {
    "docs:dev": "vuepress-vite dev docs",
    "docs:build": "vuepress-vite build docs"
  }
}

[Read more about installing and configuring the Vite bundler here.] link to reference/bundler/vite
Advanced Configuration
You can specify the name of the bundler and set bundler configuration options in the config file:
module.exports = {
  bundler: '@vuepress/vite', // or '@vuepress/webpack'
  bundlerConfig: {
    // bundler options
  },
}

Good point.
We also provide vuepress bin command in vuepress-vite package, it should take effect if users only install that package.
https://github.com/vuepress/vuepress-next/blob/05246d1001a3728205d018c8b1dc647670bd258d/packages/vuepress-vite/package.json#L23-L26

You are correct about the bin alias. I wondered why it didn't work for me before, then made a new branch to test. I have updated the issue accordingly, thanks.


⚠ Secret Website 3 has degraded performance

In 359048e, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2909 ms

Resolved: Secret Website 3 performance has improved in 5ce50c8.


{Monitor} fix az monitor metrics alert create

close: https://github.com/Azure/azure-cli/issues/16590
close: https://github.com/Azure/azure-cli/issues/16513
Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Monitor

Monitor

Need to add a note in "History Notes" of descriptions?

Need to add a note in "History Notes" of descriptions?

PR with {} in title will not be included in History Notes when CLI release.


fix: update validation status and message when files exceed size limit

#3451

Reviewers
Functional:
@Bento007
Readability:
@nayib-jose-gloria
Changes
Populate the dataset_processing_status.validation_status and dataset_processing_status.validation_message when a file is encountered that is too large for processing.
QA steps (optional)
Notes for Reviewer

@jahilton @brianraymor this fix will ensure that the curator can see that validation was invalid AND a descriptive message that it was due to file size if they retrieve the Collection using the API.
It does not include any sort of change to indicate the file size error on the UX, which would be more involved. I am assuming this is not needed, anyways.

It does not include any sort of change to indicate the file size error on the UI for that Collection, which would be more involved. I am assuming this is not needed, anyways.

I think that's a good compromise. What is the UX experience? Silence? Validation failure with no details?


Access log: Support log rotation, backups and compression for access log

Fixes Issue #1994
Access log rotation support with backup compression and automatic deletion support.

This change implements access log rotation.
We need to support log rotation for production readiness.
A couple of things to keep in mind:
a. At what file size do we rotate?
Currently this is 100 MB by default.
b. How many backups do we keep?
We are taking 3 backups and compressing these backup files for better space utilization.
How often do we cleanup the backup files?
Currently this is set to 28 days.
This change also supports access logging by default on vagrant setups.
Signed-off by: Manali Bhutiyani<EMAIL_ADDRESS>

Has the rotation itself been tested? We should be sure that no data is lost when the logs are rotated.

Could you explain the environment where we expect this to be used? I'm not sure I have enough context but I have two general concerns:
1- If we add rotation to the access-log, do we also need to add it to the normal agent logs? We currently emit to standard out, syslog and fluentd (from what I can tell) so perhaps it isn't relevant. If we say that the agent logs are ok to go to those systems, why aren't the access logs treated the same way? Should we wire them to go to the same system (but not file) as the default?
2- The PR hardcodes our behaviour. If we have a single fixed use-case, then it's fine. It does break some other use-cases I can imagine, like logging to a socket file or /dev/null, or relying on something else to rotate the logs. This seems like a user policy choice but I might be missing something.

@ianvernon I have tested these changes. Before writing to the file, the code checks what the current file size is and if it exceeds the configured file size, we close that file, rename it and then write to a new file. The OS should take care of flushing the writes correctly. I will double check again.
If the user fails to specify any backup, and if the max size is reached, we don't have an option but to overwrite the existing access log, but that's the whole point of access log rotation.
Regarding configurable options, I agree with you, but I will do it as a separate PR, if that's ok.

@raybejjani : My understanding is that access-log is our own implementation and is not plugged into the log-rotate system of other logs like syslog, fluentd.. (These already have log-rotation limits).
Hence in a real-world environment, we can easily run out of disk space, because there is no log rotation.
Regarding your second concern, I will be making these values configurable, but not as part of this PR. This is the first step to support log rotation for access log.

@raybejjani : We might end up not using access log at all eventually and plug in the whole thing via unix sockets, but until we are there, we need to handle the access log which cilium is creating and make sure we are not using up the disk space just because of large access logs we create.

@raybejjani : We might end up not using access log at all eventually and plug in the whole thing via unix sockets, but until we are there, we need to handle the access log which cilium is creating and make sure we are not using up the disk space just because of large access logs we create.

@raybejjani : My understanding is that access-log is our own implementation and is not plugged into the log-rotate system of other logs like syslog, fluentd.. (These already have log-rotation limits).
Hence in a real-world environment, we can easily run out of disk space, because there is no log rotation.

My vote is on adding an option to enable logrotate which defaults to disabled. The user has to explicitly enable this and opt-in by providing a maxDays or maxSize.
Some users will want to use standard logrotate or have no rotation at all.

@tgraf my opinion would still be to have a log rotation system  in place as a first step and then improvise on it as we all see fit

Addressed review comments by @tgraf . Choosing to add configurable options as a separate PR.

1- If we add rotation to the access-log, do we also need to add it to the normal agent logs? We currently emit to standard out, syslog and fluentd (from what I can tell) so perhaps it isn't relevant. If we say that the agent logs are ok to go to those systems, why aren't the access logs treated the same way? Should we wire them to go to the same system (but not file) as the default?

This is an interesting point. I don't know enough about logging best practices here. How is this typically done if multiple different streams need to be logged through systems like fluentd?

@tgraf :fluentd uses an agent that collects logs locally and forwards to a centralized log collector, e.g. ElasticSearch. This is relevant in a distributed system environment.
In cilium /access log case however, cilium will be the only one writing to the access log, so I don't think this applies to access log?

I'm fine with a configurable setup. I also noticed we don't turn on the access log by default, making this an opt-in. I'm far less concerned about unexpected behaviour in that case. Carry on!
I am still surprised how this comes about, though, since I would put any logs somewhere I have a rotation policy or, if I don't have that (say I'm using systemd for everything), I would then put in a rotation policy for that file/path. To support this scheme, though, we'd need a way to trigger a re-open on the target log filename and I don't think we have that now.

@raybejjani
To support this scheme, though, we'd need a way to trigger a re-open on the target log filename and I don't think we have that now.  , If you see the Write routine in lumberjack.go
		if err = l.openExistingOrNew(len(p)); err != nil {
			return 0, err
		}
	}``` if the existing log file is more than the configured value, we rename it and create a new one and direct the writes to that one. If the file is already existing and less than the configured size we simply open that. Do I understand your question correctly?

I'm fine with having the configurable options for log rotation done in a separate PR. Having this on by default for now is fine IMO.

@ianvernon : Raised Issue #2004

@manalibhutiyani Ready to merge, needs a rebase.

@tgraf I think its already rebased.

@raybejjani I never thought cilium log rotation could be done in the agent. I always assumed it would be systemd or docker's job to deal with cilium's output. If what you say it's possible possible then we definitely need that!

@manalibhutiyani @aanm Perhaps we should move this discussion to the log rotation issue?
@manalibhutiyani  That last set of things I said was more thinking out loud. It was for the scenario of:

configure cilium agent to log to a file somewhere (this is currently possible with access-log but I don't think we have an option to do it for the agent logs).
setup an external log rotation scheme for these files.

It is the second point that has a missing link: when the logfile needs to be rotated, how does the agent know to stop writing to that file handle (recall, just renaming a file will not change the open FDs to it). One approach is to respond to a signal (like USR1, see the nginx links below) but I think many schemes are configurable so we can make this a CLI command. I think apache recommends just restarting httpd so that's another approach. The lumberjack logic manalibhutiyani doesn't quite handle this because it assumes that it knows the rotation policy (the size to rotate at).
In any case, this situation will not happen too often, I think, since we deploy into systems that just handle our stdout logs (like into k8s or under systemd). If we do pursue it, though, we should also look into whether we need to make it part of packages we bundle.
nginx log rotation scheme:
https://www.nginx.com/resources/wiki/start/topics/examples/logrotation/
https://www.digitalocean.com/community/tutorials/how-to-configure-logging-and-log-rotation-in-nginx-on-an-ubuntu-vps#log-rotation


Replace inline javascript for retire api key form

Description
Replace the "onsubmit" inline javascript for the "retire key" button on the admin API keys page with static javascript. The message requires the key name, which is now plumbed in a data attribute on the form.
This is necessary to enforce a content security policy (https://github.com/civiform/civiform/issues/7574), which disallows inline javascript.
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
[x] Assigned to a specific person, civiform/developers, or a more specific round-robin list
[x] Added an additional reviewer from outside your organization as FYI (if the primary reviewer is in the same organization as you)
[x] Performed manual testing (Chrome and Firefox if it includes front-end changes)

lgtm! are there any existing tests for this? if not, do you think it needs one? it would probably just be a screenshot of the dialog popup.

Thanks - admin_api_keys.test.ts is the test for this, but it doesn't actually test that the dialog appears. I was being lazy, but given how easy it is to break this functionality by not executing the javascript, I agree the test should cover it. I've updated it to do so.


ExpansionTile border

Expected results:  I am Using ExpansionTile inside a Card With a shape of RoundedRectangleBorder and elevation
Here is an Example of the widget:
Card(
shape: RoundedRectangleBorder(
borderRadius: BorderRadius.circular(20),
),
elevation: 5,
)
Actual results: on expanded, the ExpasnsionTile's borders look bad on the top of the Card Widget.
I managed to solve the problem by commenting out the lines of _ExpansionTileState > _buildChildren > Container > decoration > border property
flutter doctor
[✓] Flutter (Channel stable, 1.22.3, on Mac OS X 10.15.7 19H2, locale en)
    • Flutter version 1.22.3 at /Users/adnanfahed/flutter
    • Framework revision 8874f21e79 (2 weeks ago), 2020-10-29 14:14:35 -0700
    • Engine revision a1440ca392
    • Dart version 2.10.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/adnanfahed/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.10.0

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin installed
    • Dart plugin version 201.9245
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (1 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86 • Android 11 (API 30) (emulator)

• No issues found!

here are screenshots of the difference after commenting out _ExpansionTileState > _buildChildren > Container > decoration > border property

Hi @adnanjpg
Can you please provide your flutter doctor -v, a minimal complete reproducible code sample?
Also is is a bit unclear what is the actual vs expected behavior, please elaborate more.
Thank you

Hi @pedromassangocode
Thank you for your response. I've already provided my flutter doctor -v output in the issue. I'm sorry for not providing enough example code to reproduce. here is an example piece of code:
Card(
shape: RoundedRectangleBorder(
borderRadius: BorderRadius.circular(20),
),
elevation: 5,
child: ExpansionTile(
title: Text('The Title'),
children: [
Column(
children: List.generate(3, (idx) => Text(idx.toString())),
)
],
),
),
this is the output without commenting out the _ExpansionTileState > _buildChildren > Container > decoration > border property:

and this is the output after commenting out:

Thank you

Apparently the border is not removed with parameters. I found a package you can use instead. I recommend that you check out the Expandable package.

The problem was solved by adding any clipBehaviour property to Card other than the default which is Clip.none.
resulting in a code piece like this:

Card(
  clipBehavior: Clip.antiAlias,
      shape: RoundedRectangleBorder(
      borderRadius: BorderRadius.circular(20),
  ),
  elevation: 5,
  child: ExpansionTile(
    title: Text('The Title'),
    children: [
      Column(
        children: List.generate(3, (idx) => Text(idx.toString())),
      )
    ],
  ),
),


Cap reorganization part 2

Part 2 of moving stuff out of the cap. Now the logging and profiler stuff has been moved to a support module. Now mkiau, gsi, and other programs can use these. I could not think of something better than ApplicationSupport for the name. Other things like ProfilerAndLoggerSupport seemed too long.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[X] I have tested this change with a run of GEOSgcm (if non-trivial)
[X] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[ ] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

I make a a MAPL_Initialize and MAPL_Finalize and updated. Now both the logger and profiler get initialized when the cap is created. I did not see any reason why the global profiling singleton could not be initialized there and it ran without problem. It seems like it should be there anyway as that is the place to start it if you want the full application time.


[SPARK-47081][CONNECT][FOLLOW-UP] Add the shell module into PyPI package

What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/45150 that adds the new shell module into PyPI package.
Why are the changes needed?
So PyPI package contains shell module.
Does this PR introduce any user-facing change?
No, the main change has not been released yet.
How was this patch tested?
The test case will be added at https://github.com/apache/spark/pull/45870. It was found out during working on that PR.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @grundprinzip @zhengruifeng

Merged to master.


test: weaviate tests

related #26 -> if this fixed it the whole thing might now also work with python 12


Use asyncio instead of threading in Processor

Threading is not intended to be used with asyncio.
Processor class' async processing can be implemented with asyncio as Mixer class can be a reference.

If this is done, #365 may be resolved.


Large cohort

I tried running X-shift by command line on 112 samples (>100K cells each) using 50 threads and 100G of RAM. It ran for 16 hours and then had an out of memory error. I can keep tweaking the submission parameters for the cluster computer, but I was wondering what the maximum number of cells this has been successfully run on. Besides sub-sampling, is there a parameter I should use to decrease the computation? My cohort will soon increase in 350 samples and I need a method capable of handling 40 million cells.
Thanks!
Sara

Hi Sara,
Sorry to hear that. What operating system are you on? Can you please open
your terminal and type “java -version” and tell me what response you are
seeing?
Nikolay
On Mon, Jun 4, 2018 at 6:46 AM Sara Selitsky<EMAIL_ADDRESS>wrote:

I tried running X-shift by command line on 112 samples (>100K cells each)
using 50 threads and 100G of RAM. It ran for 16 hours and then had an out
of memory error. I can keep tweaking the submission parameters for the
cluster computer, but I was wondering what the maximum number of cells this
has been successfully run on. Besides sub-sampling, is there a parameter I
should use to decrease the computation? My cohort will soon increase in 350
samples and I need a method capable of handling 40 million cells.
Thanks!
Sara
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nolanlab/vortex/issues/15, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADacLwnSuneCILKbMVDnCViy98yJMtvbks5t5To4gaJpZM4UZHlL
.

--
Nikolay

This message is intended for the named addressee(s) only. It may contain
privileged and confidential information and protected by a copyright. Any
disclosure, copying or distribution of this message is prohibited and may
be unlawful. If you are not the intended recipient, please destroy this
message and notify me immediately. Thank you for your cooperation.

Sure! See below:
CentOS Linux release 7.3.1611 (Core)
openjdk version "1.8.0_102"
OpenJDK Runtime Environment (build 1.8.0_102-b14)
OpenJDK 64-Bit Server VM (build 25.102-b14, mixed mode)

I wanted to let you know that X-shift has been running 112 samples with around 100K cells per FCS file, for 3 days and 19 hours. It is running on 80 threads, 200G of RAM. Have you tested a cohort of a comparable size? If so, did you see these types of times? Thanks!

Yes, that makes sense that it's taking that long. I think it's too much for
your system to handle. I suggest that you change the "limit of rows per
file" in the data import config and set it to a maximum of 10000, you will
end up then with 1.12M cells, which should get clustered in about a day. It
will compute the clustering based on that 'core' set of cells and then
impute the cluster assignments for the rest of the cells using nearest
neighbour classification while writing the output FCS files.
On Fri, Jun 8, 2018 at 9:18 AM Sara Selitsky<EMAIL_ADDRESS>wrote:

I wanted to let you know that X-shift has been running 112 samples with
around 100K cells per FCS file, for 3 days and 19 hours. It is running on
80 threads, 200G of RAM. Have you tested a cohort of a comparable size? If
so, did you see these types of times? Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nolanlab/vortex/issues/15#issuecomment-395812238, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADacL-ovG7J27GRTslHd1Kjg0t83oGQKks5t6qPagaJpZM4UZHlL
.

--
Nikolay

This message is intended for the named addressee(s) only. It may contain
privileged and confidential information and protected by a copyright. Any
disclosure, copying or distribution of this message is prohibited and may
be unlawful. If you are not the intended recipient, please destroy this
message and notify me immediately. Thank you for your cooperation.


Avoid doc-ception and doc-ception encouraging test

Add an emoji (and indicate that the Doctor command has initiated)

looks good. appreciate the fix and the infusion of cultural references :)


Fatal error: Failed opening required "dompdf_config.inc.php" in Bootstrap.php on line 178

Hi
I've installed phpDocumnetor2 using pearl I a got a success message "install ok: channel://pear.phpdoc.org/phpDocumentor-2.9.0" but when I put in the console phpdoc I got the following error:
PHP Warning:  require_once(C:\xampp\htdocs\siselc-thomas\vendor/dompdf/dompdf/dompdf_config.inc.php): failed to open stream: No such file or directory in C:\xampp\php\pear\phpDocumentor\src\phpDocumentor\Bootstrap.php on line 178
Warning: require_once(C:\xampp\htdocs\siselc-thomas\vendor/dompdf/dompdf/dompdf_config.inc.php): failed to open stream: No such file or directory in C:\xampp\php\pear\phpDocumentor\src\phpDocumentor\Bootstrap.php on line 178
PHP Fatal error:  require_once(): Failed opening required 'C:\xampp\htdocs\siselc-thomas\vendor/dompdf/dompdf/dompdf_config.inc.php' (include_path='C:\xampp\php\PEAR') in C:\xampp\php\pear\phpDocumentor\src\phpDocumentor\Bootstrap.php on line 178
Fatal error: require_once(): Failed opening required 'C:\xampp\htdocs\siselc-thomas\vendor/dompdf/dompdf/dompdf_config.inc.php' (include_path='C:\xampp\php\PEAR') in C:\xampp\php\pear\phpDocumentor\src\phpDocumentor\Bootstrap.php on line 178
I am not an expert in this son I tried to install DOMPDF, but I am still getting the same error.
Thanks a lot

@mvriel is this some historic dependency? I cannot find dompdf in the composer.json anymore.

Hi, well, I am using the last version of Laravel (5.4) And the composer that comes whit it, didn't have dompdf, I just added just to check if that would solve the problem but it didn't. (Hope that was what you are asking, I am just a beginner)
Thanks a lot

@oscarmunoz20 you could try to download the phar file from our website and run phpdoc that way. I think this is an issue in our pear package.

@jaapio Yes, DOMPDF used to be used to generate PDFs with but caused too many conflicts and we never fully implemented PDF rendering. As such it was removed but this line in the bootstrap was too IIRC

Thanks a lot, right now I am not able to try that out, but once I can, I will let you know if ti works.

Hi, the phar file works great, thanks a Lot.

How did it work, i mean where id you place the phar file? in the project root or else please.

@oscarmunoz20 where did you place the phar file please? in the project root or else.
I am very new to use that...

A phar file is basically an binary, it doesn't matter where you install it. Just like you install composer for example. Can be anywhere on your system.

Thanks @jaapio , i already been sucessful, before i read your message by keeping the phar in th eproject root, its nicely working. Thanks for your message.

This item was badly closed, because the version 2.9.0 on PEAR is corrupted. A new issue was open: https://github.com/phpDocumentor/phpDocumentor2/issues/1859

Still an issue with the latest package on pear

Also an issue with composer install

Can confirm too, I get the same error when I installed the phpDocumentor using
pear channel-discover pear.phpdoc.org
pear install phpdoc/phpDocumentor

What's the workaround for this? Removing the addDomPdfConfig method?

@dingo-d if you download the .phar from their site and run it that way (instead of with composer) it works (for me, anyway).

Yup, I ended up doing it that way and it works. I've had to modify things a bit for it to work on mac, but it's all ok now.

Workaround to install with PEAR but using the archive on GitHub:
download https://github.com/phpDocumentor/phpDocumentor2/releases/download/v2.9.0/phpDocumentor-2.9.0.tgz
launch PEAR from the command line with the downloaded package:
pear install phpDocumentor-2.9.0.tgz
(Thanks to the comment of miken32 on this issue: #1764). See #1887.

I still have this issue though I have installed the package via PEAR. Installing the dompdf package doesn't make a difference because the dompdf_config.inc.php doesn't exist


[AppContainers] Fix for issue #42663

Modify the deserialization method of ContainerAppVnetConfiguration to prompt that infrastructureSubnetId cannot be empty or null.

This is a fix PR for issue: #42663


add types

Hello! :octocat:
Thanks for your package!
I added typescript types-definition for it

Coverage remained the same at 100.0% when pulling b0dd352d37c71f378f26a32c4b175f3a4daf03cd on breadhead:master into f28597ee0d010d4142d0077c911868de69535efd on wrakky:master.

Coverage remained the same at 100.0% when pulling b0dd352d37c71f378f26a32c4b175f3a4daf03cd on breadhead:master into f28597ee0d010d4142d0077c911868de69535efd on wrakky:master.