npm start failing at ng serve after updating to beta.30

Please provide us with the following information:

OS?
Windows 10
Versions.
@angular/cli: 1.0.0-beta.30
node: 6.9.5
os: win32 x64
@angular/common: 2.4.6
@angular/compiler: 2.4.6
@angular/core: 2.4.6
@angular/material: 2.0.0-beta.1
@angular/flex-layout: 2.0.0-beta.4
@angular/forms: 2.4.6
@angular/http: 2.4.6
@angular/platform-browser: 2.4.6
@angular/platform-browser-dynamic: 2.4.6
@angular/router: 3.4.6
@angular/cli: 1.0.0-beta.30
@angular/compiler-cli: 2.4.6
Repro steps.
The app was working fine in beta.26. Then I decided to upgrade to beta.30.
npm start fails at ng serve, but ng serve works when I type it directly at the command line.
The log given by the failure.
0 info it worked if it ends with ok
1 verbose cli [ 'C:\\Program Files\\nodejs\\node.exe',
1 verbose cli   'C:\\Users\\XXXXXXX\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js',
1 verbose cli   'start',
1 verbose cli   '--verbose' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 silly lifecycle<EMAIL_ADDRESS>no script for prestart, continuing
7 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>8 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
9 verbose lifecycle<EMAIL_ADDRESS>PATH: xxxxxxxxx
10 verbose lifecycle<EMAIL_ADDRESS>CWD: E:\Users\XXXXXXX\Documents\Projetos\tutoria\Bitbucket\frontend
11 silly lifecycle<EMAIL_ADDRESS>Args: [ '/d /s /c', 'ng serve' ]
12 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
13 info lifecycle<EMAIL_ADDRESS>Failed to exec start script
14 verbose stack Error<EMAIL_ADDRESS>start: `ng serve`
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter.<anonymous> (C:\Users\XXXXXXX\AppData\Roaming\npm\node_modules\npm\lib\utils\lifecycle.js:279:16)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at EventEmitter.emit (events.js:191:7)
14 verbose stack     at ChildProcess.<anonymous> (C:\Users\XXXXXXX\AppData\Roaming\npm\node_modules\npm\lib\utils\spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at ChildProcess.emit (events.js:191:7)
14 verbose stack     at maybeClose (internal/child_process.js:877:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
15 verbose pkgid<EMAIL_ADDRESS>16 verbose cwd E:\XXXXXX\XXXXXXX
17 error Windows_NT 10.0.14393
18 error argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\XXXXXXX\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "start" "--verbose"
19 error node v6.9.5
20 error npm  v4.1.2
21 error code ELIFECYCLE
22 error<EMAIL_ADDRESS>start: `ng serve`
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>start script 'ng serve'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the frontend package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     ng serve
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs frontend
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls frontend
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

@julianobrasil you probably have a local version of angular-cli installed.
Make sure you remove the references to angular-cli from the devDependencies section in you package.json, then remove node_modules and npm install.

@beeman, thanks. You're right, I had missed one reference to angular-cli.


Fix for #862

Quick fix to apply row.docs left margin if sidebar is present.
https://github.com/elementary/mvp/issues/862

test this please


WMS and Modest Maps+Wax?

Hi,
Is it possible to use ModestMaps+Wax and WMS?
Cheers, Jelmer

There are no plans to support WMS. Leaflet recently gained WMS support, though.

One other question, is it possible to use Modest Maps and Leaflet within one map DIV using Wax? There are a couple of Modest Maps features (like the autozoompan) I like and I need WMS too. Another option would be to make translation in PHP from X/Y/Z to WMS...

No the WMS is WGS84, so I guess the WMS first has to be in spherical mercator yes...
Anyway, I'm just experimenting here, too see what is possible. Thanks for your comments.

Heads up, Leaflet might not support projections other than 900913/EPSG:3857 either, but I can't tell you that for sure.

I will find out :D
I just like Wax and need to work with WMS so am trying to combine.
Installing tilecache.org is something I'm considering.
2011/12/14 Konstantin Kfer <
<EMAIL_ADDRESS>

Heads up, Leaflet might not support projections other than
900913/EPSG:3857 either, but I can't tell you that for sure.

Reply to this email directly or view it on GitHub:
https://github.com/mapbox/wax/issues/147#issuecomment-3140865


cel shader only receives one light source

First of all, thanks for this awesome shader!
There is one thing I noticed dough while using it, the shader only receives one light source.
You may want to change:
https://github.com/EXPWorlds/Godot-Cel-Shader/blob/master/Shaders/cel.shader#L83
to:
DIFFUSE_LIGHT += diffuse;

Source: https://godotengine.org/qa/48323/my-custom-light-shader-received-only-a-single-light

Yep, it's certainly an issue, however, the shader was designed to be used with only one light source. This is due to the current limitations of Godot, and also because using one light provides maximum control over the light/shade areas of the model. As covered in the ReadMe under "Additional Notes".
As for adding the diffuse to DIFFUSE_LIGHT: because of the way Godot shaders handle lights, this will create an extra "bands" or levels of shade to an object. This might be an interesting effect in it's own right, but the goal here is to have areas of shade or no shade only.
Yet, I would like to have more control over lighting in the future, so I'll keep this issue open in case someone can find an effective solution, and/or to remind myself to check if Godot has updated the light shader fuction every once and awhile.
The input is much appreciated.

Thanks for the explanation!


raft: Make flow control more aggressive

We allow multiple in-flight append messages, but prior to this change
the only way we'd ever send them is if there is a steady stream of new
proposals. Catching up a follower that is far behind would be
unnecessarily slow (this is exacerbated by a quirk of CockroachDB's
use of raft which limits our ability to catch up via snapshot in some
cases).
See cockroachdb/cockroach#27983
Please read https://github.com/coreos/etcd/blob/master/CONTRIBUTING.md#contribution-flow.

Codecov Report

Merging #9985 into master will decrease coverage by 0.22%.
The diff coverage is 92.3%.

@@            Coverage Diff             @@
##           master    #9985      +/-   ##
==========================================
- Coverage   69.34%   69.11%   -0.23%
==========================================
  Files         386      386
  Lines       35914    35918       +4
==========================================
- Hits        24905    24826      -79
- Misses       9212     9297      +85
+ Partials     1797     1795       -2

Impacted Files
Coverage Δ

raft/raft.go
92.01% <92.3%> (+0.73%)
:arrow_up:

client/client.go
58.82% <0%> (-25.82%)
:arrow_down:

pkg/transport/timeout_conn.go
80% <0%> (-20%)
:arrow_down:

proxy/grpcproxy/register.go
69.44% <0%> (-11.12%)
:arrow_down:

clientv3/namespace/watch.go
72.72% <0%> (-6.07%)
:arrow_down:

pkg/logutil/zap_grpc.go
47.61% <0%> (-4.77%)
:arrow_down:

pkg/transport/listener.go
58.67% <0%> (-4.09%)
:arrow_down:

lease/leasehttp/http.go
58.08% <0%> (-1.48%)
:arrow_down:

etcdctl/ctlv3/command/printer_simple.go
72.48% <0%> (-1.35%)
:arrow_down:

etcdserver/raft.go
80.09% <0%> (-0.72%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93be31d...a5ea496. Read the comment docs.

@bdarnell Have you tried this in CockroachDB setup?

LGTM after fixing the nit.

Yes, we've tested it. We had a node that had accumulated a multi-gigabyte raft log. Without this change it was going to take weeks to catch up, and with this it caught up in hours.

Hi @benbjohnson
Why don't you use snapshot here? seem your Range size is 64 MB, the total log size has exceeded this threshold too much.


modified damped LS for m < n

Modifies the damped least squares update to the case when $m < n$ for a matrix of size $m \times n$. For the Franka-Emika Panda, $m = 6$ and $n = 7$.

Thanks @hpoonawala! Indeed I've fixed these in a commit I've forgotten to upload, thanks for spotting and submitting a PR :)


add image via visual editor fails

I have selected an image using the visual editor. It is also displayed in the preview, but saving does not work.
The section is empty after that. It will not show any errors either
Drag and Drop does not work either.
I use version <IP_ADDRESS>

I downloaded <IP_ADDRESS> and tested again but cannot reproduce the behavior that you reported.
Are you sure that the folders content, media and so on with all the files inside have the rights described in the documentation?

It is described here and you have to set permissions recursively for the folders and all the content inside: https://typemill.net/getting-started/installation
If that is not the problem, then I need more information, maybe attach the image that you try to upload.

i use the php server under windows. There should no issue with the rights because the php webserver runs under the the same account as the current user (batch).

I tested it with XAMPP under windows and recent Firefox locally and it worked fine so I need more information to reproduce or fix it.
Do you see any error in the browser-console or in the network-tab when you add an image or drag an element?
You can also activate the php-error-reporting of the slim-framework by adding the following line to the settings.yaml-file:
displayErrorDetails: true

just in case. i did not use xampp. i use the webserver provided by php.
php -S localhost:8000
this the error i got.
`
c:\htdocs>c:\php\php.exe -S localhost:8000
[....]
[Wed May 13 07:05:32 2020] [::1]:50451 Accepted
[Wed May 13 07:05:32 2020] Slim Application Error:
Type: Error
Message: Call to undefined function Typemill\Models\imagecreatefromstring()
File: C:\htdocs\system\Models\ProcessImage.php
Line: 28
Trace: #0 C:\htdocs\system\Controllers\MediaApiController.php(109): Typemill\Models\ProcessImage->createImage()
#1 [internal function]: Typemill\Controllers\MediaApiController->createImage()
#2 C:\htdocs\system\vendor\slim\slim\Slim\Handlers\Strategies\RequestResponse.php(40): call_user_func()
#3 C:\htdocs\system\vendor\slim\slim\Slim\Route.php(281): Slim\Handlers\Strategies\RequestResponse->__invoke()
#4 C:\htdocs\system\Middleware\RestrictApiAccess.php(24): Slim\Route->__invoke()
#5 [internal function]: Typemill\Middleware\RestrictApiAccess->__invoke()
#6 C:\htdocs\system\vendor\slim\slim\Slim\DeferredCallable.php(57): call_user_func_array()
#7 [internal function]: Slim\DeferredCallable->__invoke()
#8 C:\htdocs\system\vendor\slim\slim\Slim\MiddlewareAwareTrait.php(70): call_user_func()
#9 C:\htdocs\system\vendor\slim\slim\Slim\MiddlewareAwareTrait.php(117): Slim\Route->Slim{closure}()
#10 C:\htdocs\system\vendor\slim\slim\Slim\Route.php(268): Slim\Route->callMiddlewareStack()
#11 C:\htdocs\system\vendor\slim\slim\Slim\App.php(503): Slim\Route->run()
#12 C:\htdocs\system\Middleware\ValidationErrorsMiddleware.php(27): Slim\App->__invoke()
#13 [internal function]: Typemill\Middleware\ValidationErrorsMiddleware->__invoke()
#14 C:\htdocs\system\vendor\slim\slim\Slim\DeferredCallable.php(57): call_user_func_array()
#15 [internal function]: Slim\DeferredCallable->__invoke()
#16 C:\htdocs\system\vendor\slim\slim\Slim\MiddlewareAwareTrait.php(70): call_user_func()
#17 C:\htdocs\system\Middleware\OldInputMiddleware.php(29): Slim\App->Slim{closure}()
#18 [internal function]: Typemill\Middleware\OldInputMiddleware->__invoke()
#19 C:\htdocs\system\vendor\slim\slim\Slim\DeferredCallable.php(57): call_user_func_array()
#20 [internal function]: Slim\DeferredCallable->__invoke()
#21 C:\htdocs\system\vendor\slim\slim\Slim\MiddlewareAwareTrait.php(70): call_user_func()
#22 C:\htdocs\system\vendor\slim\csrf\src\Guard.php(171): Slim\App->Slim{closure}()
#23 [internal function]: Slim\Csrf\Guard->__invoke()
#24 C:\htdocs\system\vendor\slim\slim\Slim\DeferredCallable.php(57): call_user_func_array()
#25 [internal function]: Slim\DeferredCallable->__invoke()
#26 C:\htdocs\system\vendor\slim\slim\Slim\MiddlewareAwareTrait.php(70): call_user_func()
#27 C:\htdocs\system\vendor\slim\slim\Slim\MiddlewareAwareTrait.php(117): Slim\App->Slim{closure}()
#28 C:\htdocs\system\vendor\slim\slim\Slim\App.php(392): Slim\App->callMiddlewareStack()
#29 C:\htdocs\system\vendor\slim\slim\Slim\App.php(297): Slim\App->process()
#30 C:\htdocs\index.php(7): Slim\App->run()
#31 {main}
View in rendered output by enabling the "displayErrorDetails" setting.
[Wed May 13 07:05:33 2020] [::1]:50451 [500]: POST /api/v1/image
[Wed May 13 07:05:33 2020] [::1]:50451 Closing
`

Typemill needs some extensions, for example the GD-extension for images, so you have to install them first. I don't have a list of extensions, because all the extensions are usually part of standard webservers.

Yeah. I don't know why GD Extension wasn't active. It was a normal default PHP version.
Now it works...


search for nonprofits FE

rename path/url/route and component AssetsView to something like SearchResults
can use react-router hooks or useParams to consume url data and then conditionally make fetch request to /orgs?searchText=blah
also use same url data to conditionally render new card components or list component with nonprofit card components (also new np card needed)
if non profit is selected in search dropdown

send get req to /organizations?name=searchInput
when we get response takes us to nonprofit list page or something (new component?)
this endpoint still WIP (so potentially don't do and move to new ticket)

needs to handle:

Changes:

AssetsView changed to SearchResults throughout
Using location.state.category to pass state from Search component to SearchResults. TBD on filtering results
If a nonprofit is selected, SearchResult will render a specific filtered view of all Nonprofits as cards on Grid

Opinion/Question:

Search component currently only handles any text box input as a Search for "assets" of any kind.

Option 1 [implementing in this ticket]: If we are looking to make four different Search components to be rendered for each category search, then we would need to handle each Category case and create four diff components to be rendered.
Option 2 [preferred]: If not, we can just implement a single Search view (which we already have) and build in filters that would be auto-selected when we render the 'SearchResults' into view. When the 'Search All' Category is selected, the options for 'Nonprofits, Needs, Offers, Volunteer Openings' are automatically preselected. This 'everything under one roof' approach could work as long as this doesn't add to the complexity of rendering cards into view with different data.

10/24 - Review if this implementation is correct and proceeds or refactor.

10/24 - @jd2rogers2 Please review if this implementation is on the right path. Confirm to proceed or refactor.

let's keep this part simple for now. here's what i envision:
const [donations, setDonations] = useState();
const [orgs, setOrgs] = useState();
// ... other fetch result states

useEffect(() => {
if (searchCategory === 'donations') {
  await fetch('api/orgs?category=donations&search=${searchText}')
  setDonations(fetchResults);
  setOrgs([]); // clear prev
}
// repeated for each searchCategory (donations, requests, volunteerOpenings, nonprofits)

}, [searchText, searchCategory]);

return (
  <>
    {searchCategory === 'donations' && donations.length ? donations.map(donation => (
      <AssetCard asset={donation} />
    )) : null}
    {searchCategory === 'organizations' && orgs.length ? orgs.map(org => (
      <OrgCard org={org} />
    )) : null}
    {/** etc. **/}
  </>
);

Changes:

Updated Search Result Component for input logic and slightly cleaner UI
Removed link when SearchIcon was pressed as this logic did not make sense
Added dropdown for easier searching based on the category selected
fetch API working for all orgs being pulled

Opinion/Question:

I copied the AssersList component and created an OrgsList and VolunteerList component. These components can all live under one roof - AssetsList - there needs to be some uniformity in handling data in that component. This will allow for much less code and easier maintenance in the future if any additions are required. I've left it open-ended so that anyone can change this in future iterations.

Issue closed


bug: Error in parsing commitmsg with dirty submodule

Description
The current parser doesn't support dirty submodules. It errors out. See example below.
Steps to Reproduce

Run the following command to generate a test file

$ cat << EOF > a.COMMIT_EDITMSG
feat(vim): some title text

This commit_editmsg comes from a real life example, in a repository containing a
dirty submodule.
#
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# On branch master
# Your branch is ahead of 'origin/master' by 8 commits.
#   (use "git push" to publish your local commits)
#
# Changes to be committed:
#	modified:   ../../../.config/nvim/after/ftplugin/markdown.vim
#
# Changes not staged for commit:
#	modified:   ../../../.config/nvim/lua/xkcd/plugins/nvim-tree.lua
#	modified:   ../../../.config/setup-scripts-submodule (modified content)

# vim: ft=gitcommit:noexpandtab
EOF

The offending line is the final modified line, above the vim modeline.

Then tree-sitter parse a.COMMIT_EDITMSG to run the query or via neovim treesitter Playground, you can see the errors highlighted in red.

Expected output
No error when parsing.

Good catch, I try to fix it soon !

Fixed

Thanks. I'll check it after merging into nvim-treesitter.

Works!


Changing reference from Netbox custom MultipleChoiceField subclass and adding currency.

Related to pull request #90
currency list
Currency should be added using the FIELD_CHOICES setting in Netbox optional settings in the configuration.py file.
Readme file was updated to reflect the possibilities.
MultipleChoiceFields
Thanks @sulik76

Change will be available in version 2.0.8


Installer not working

Hello, Installer not working...

Please help me.

Looks like the installer had some issues accessing the file, probably because of insufficient read permissions.
Did you click "Yes" or something like that on the UAC message that poped up?
Try moving the file to your desktop and running from there.

@xmha97 Do you still have this issue?

No, Thanks.


Feature/notebook

This notebook was used to check connections with the Reddit, 846, and News APIs as well as explore data and experiment with a k-nearest neighbors algorithm

Great work!


Update dependencies, use new openai API functions

Change from openai.ChatCompletions (old) to openai.chat.completions (new as of v1.1.0)

LGTM!


[PROPOSAL] Firebase Folders Refactoring

Propose a minor refactoring in the folders structure:

Removes package.json from src/core, moving all dependencies to an unique package.json in the project root.
Moves functions/ folder to root, including only index.ts as it sub-file.
Moves dist/ output to root => <ROOT>/dist/

Could you please elaborate on each refactor and why these are an improvement to the current architecture?

Could you please elaborate on each refactor and why these are an improvement to the current architecture?

You mentioned previously that you couldn't make functions/ be outside the src/ folder, since it relates to firebase-functions and not with the codebase source code itself, this is the first issue addressed by the changes above.
The second benefit is to don't have multiple package.json files in the project, in which some dependencies like firebase-functions was replicated. This could cause problems when updating such dependencies in the root package.json but not in the onde present in src/core.
The dist/ change is more a personal preference than anything, it could be placed in src/dist as well, this one is a w/e for me.
Basically these are the improvements that are addressed by this refactoring. Now we separate which are firebase functions dependencies (in this case we have only index.ts but we can easily add some firestore-seed as we have in other projects) from the project source files. Let me know your thoughts about them.

You mentioned previously that you couldn't make functions/ be outside the src/ folder, since it relates to firebase-functions and not with the codebase source code itself, this is the first issue addressed by the changes above.

I don't quite remember that well, but I guess that was before the new structure, which makes sense, IMO, as it is. Having it all under src/ makes sure that any sub-project that wants to use core/ is placed under there, such as ec2 or aws-lambda. If we'd move functions to the root project, I think src/ strategy becomes invalidated, as the same rationale that is used for functions/ is the same of scripts/ and other future projects, like mentioned before. I don't see benefits why moving functions/ is positive for us, given that how we planned on src/ being our "code" entry-point.

The second benefit is to don't have multiple package.json files in the project, in which some dependencies like firebase-functions was replicated. This could cause problems when updating such dependencies in the root package.json but not in the onde present in src/core.

The problem with this is that you don't know where each dependency depends on what. Having smaller package.json with specific dependencies of each project (like /functions having only the necessary firebase dependencies to interface all of our core stuff and serve it through the Firebase services).

The dist/ change is more a personal preference than anything, it could be placed in src/dist as well, this one is a w/e for me.

I'm not against it, just wanting to know exactly the why, as I see no difference from what was before.

I don't quite remember that well, but I guess that was before the new structure, which makes sense, IMO, as it is.

I don't remember exactly when you changed your mind about it, but I remember that you said to me that we faced so many issues trying to move the functions/ folder outside that you gave up.

Having it all under src/ makes sure that any sub-project that wants to use core/ is placed under there, such as ec2 or aws-lambda. If we'd move functions to the root project, I think src/ strategy becomes invalidated, as the same rationale that is used for functions/ is the same of scripts/ and other future projects, like mentioned before. I don't see benefits why moving functions/ is positive for us, given that how we planned on src/ being our "code" entry-point.

Honestly, in my personal opinion both structures doesn't bring any kind of benefit, they're just different styles. I could argue that functions/ is not code, it's only a necessary structure to expose to Firebase Functions environment the entry point to the actual code, such as we would do with aws-lambda or any other third party provider, but this is a completely w/e to me honestly, I can move functions to src folder again as it was before, I just focused on trying to move it because I remember that you tried and couldn't made it. I thought it was still a problem in the structure.

The problem with this is that you don't know where each dependency depends on what.

But this honestly doesn't matter. We can infer that if a dependency is placed under dependencies in package.json, it's obviously used by the "main" project, since it must be deployed to the Firebase Functions env, but if a devDependency is being used by a script or test, it actually matter to us? In my opinion it doesn't. And making a bridge if the next comment that you made:

Having smaller package.json with specific dependencies of each project (like /functions having only the necessary firebase dependencies to interface all of our core stuff and serve it through the Firebase services)

And connecting with the point that I made in the PR description: splitting package.json may cause inconsistencies around the project. Imagine if we had a package.json under scripts/ folder and another one under core/ foder. If scripts uses any dependency from core, it would require to import the same dependencies as core does. If we eventually upgrade some core/ dependency, we would have to upgrade scripts as well. Why having such headache if we can center all dependencies into a single source of truth in the root folder? Again, I see no benefits in splitting multiple package.json inside the same project, I even see problems on doing that.

I don't remember exactly when you changed your mind about it, but I remember that you said to me that we faced so many issues trying to move the functions/ folder outside that you gave up.

That was before deciding to go with /src.

Honestly, in my personal opinion both structures doesn't bring any kind of benefit, they're just different styles

I get that, after all, there are some things that are simply similar and give no clear benefit when comparing two different approaches, at least not now. The only "benefit" that I see here is that everything that is related to the server (the CODE) is inside /src, and we will keep the root of the project completely independent from code, other than toolkit-related files.
I don't see why we should change that.

Imagine if we had a package.json under scripts/ folder and another one under core/ foder. If scripts uses any dependency from core, it would require to import the same dependencies as core does

But the problem is about bundling. If we'd have dependencies specific in scripts and in functions, why would scripts need this same dependency? If we had other "bundle-able" code, such as another application that should be hosted somewhere, would it make sense to bundle it with firebase as well?

But the problem is about bundling. If we'd have dependencies specific in scripts and in functions, why would scripts need this same dependency? If we had other "bundle-able" code, such as another application that should be hosted somewhere, would it make sense to bundle it with firebase as well?

See tests as an example. scripts will in most of the cases use use-cases, so the dependencies that scripts have functions will also have, but if you take a look at tests, it may be the case that we need to install the same dependency that we have in src/core in tests as well. See this example. There we need to install joi dependency in the root package.json so the tests under test/ can use it to validate schemas. This is an example of the problem that I'm saying we'll have: If joi versions mismatch between src/core/package.json and the root package.json, the tests will break.
About the bundling, I'm not sure what is your concern. All the dependencies that relate to test/ or script/ will certainly be under devDependency, which are not bundled. The only dependencies that we'll need to specify in dependencies section are those that are certainly used under src/core. sinon and mocha are examples that are used in tests only and will not be bundled when uploading src/core

@matuella Updated based on the discussion we had in Discord


RENO-1881: Update Pagination component (in progress)

Fixes #437
This PR does the following:
I took a first pass (rough draft) at this based on the Figma design. There seems to be some inferred logic that the component would need to handle, such as navigating between items, applying an active state, and passing back the selected item to the consuming application to apply to its own app.
I came up with a component that takes in a page count and a callback function as props.
Props

Name
Type
Description

pageCount
Number
The total number of items.

onPageChange
Function
The method to call when an item is selected.Exposes the selected page as an argument.

Example Usage
<DS.Pagination
  pageCount={10}
  onPageChange={pageUpdate}
/>

Result

To-Do
Truncation
Based on the Figma designs, there is also some logic needed to truncate long lists, using ellipses as placeholders, and showing just the first, last, active page + 2 siblings at a time on each side (?).

This looks like it changes a bit if you are at the beginning or the end of the list, in which it only shows one set of ellipses (either just after the first item, or just before the last item).
I couldn't quite work out the logic in the first pass. After a little investigation, it seems like maybe we want something similar to how the Pagination works in the material-ui project.
Does the logic here look like it would meet the Figma requirements?
https://material-ui.com/components/pagination/#pagination-ranges
I can try to implement something similar in this component (though it looks tricky).
Previous / Next
Based on the Figma designs, the Previous button should not display if at the first item, and the Next button should not display if at the last item.
I have this working, but adding/removing the buttons makes the pager "jump." As a page selection most likely will not trigger a page refresh in a React app, maybe it would be better to just have the Previous/Next buttons just become disabled as needed, rather than removing completely?
Note
I have not touched the Storybook/Tests for this component yet. They are outdated in this branch at the moment.
Pagination in Storybook

[x] Added a Storybook entry

To Do

[ ] Add truncation logic and display
[ ] Write a test file

@misselbeck, I've updated your PR description to add the multidev preview. You can grab that link in the future by scrolling in the checks area to netlify/stoic-murdock...etc and hitting the 'Details' link.

Does the logic here look like it would meet the Figma requirements?
https://material-ui.com/components/pagination/#pagination-ranges
I can try to implement something similar in this component (though it looks tricky).

We styled our designs off of Google's pagination (since they're so good at handling large search result sets like this), so yes! I would go even further and say that if our designs are missing something, this is the component we'll be looking to for guidance. Best of luck, I think we're all aware this component is going to be pretty tricky. ☹

Previous / Next
Based on the Figma designs, the Previous button should not display if at the first item, and the Next button should not display if at the last item.
I have this working, but adding/removing the buttons makes the pager "jump." As a page selection most likely will not trigger a page refresh in a React app, maybe it would be better to just have the Previous/Next buttons just become disabled as needed, rather than removing completely?

That's a good suggestion, so I've created UX-162 to make this update.

An odd thing happening on the multidev is that the knobs for this component are appearing across of the other components on the multidev... super weird

An odd thing happening on the multidev is that the knobs for this component are appearing across of the other components on the multidev... super weird

I can't replicate this. Let me know if this is ongoing. I can revisit my story file for any anomalies.

Added the truncation logic.
To Do:

[ ] Write a test file
[ ] Get linting to work!

I noticed that the .prettierrc settings are adding semicolons to my code (as well as 4 tab indentation, etc). But then when running npm run lint, it complains about the semicolons. This also fails during the CI/Lint (push).
Just me? Any tricks to getting this setup properly with VS Code?

@misselbeck Whenever you get a chance, can you also create a PR off the location finder repo that uses this branch and updates the pagination on location finder? You see how I did similar here: https://github.com/NYPL/dxp-react-search/pull/81/files
In your package.json you can point the DS to use this github branch, so something like:
"@nypl/design-system-react-components": "git+https://git@github.com:NYPL/nypl-design-system.git#RENO-1881-update-pagination-component"
And you'd have to update this component:
https://github.com/NYPL/dxp-react-search/blob/development/src/components/location-finder/Locations/LocationsPagination.js
We can probs track the work in another ticket, but just doing a basic sanity check that this component will work in LF would be helpful.

I noticed that the .prettierrc settings are adding semicolons to my code (as well as 4 tab indentation, etc). But then when running npm run lint, it complains about the semicolons. This also fails during the CI/Lint (push).
Just me? Any tricks to getting this setup properly with VS Code?

Grrr, this is mysterious. You might need to crowd-source solutions in #designs-system, I've never seen something like this :/

I noticed that the .prettierrc settings are adding semicolons to my code (as well as 4 tab indentation, etc). But then when running npm run lint, it complains about the semicolons. This also fails during the CI/Lint (push).
Just me? Any tricks to getting this setup properly with VS Code?

Grrr, this is mysterious. You might need to crowd-source solutions in #designs-system, I've never seen something like this :/

Did some research and stumbled across this thread. I think we might need to update our tslint.json L14 to "semicolon": [true, "always", "strict-bound-class-methods"],. @misselbeck, wanna make that change and see if it fixes npm test for you?

I noticed that the .prettierrc settings are adding semicolons to my code (as well as 4 tab indentation, etc). But then when running npm run lint, it complains about the semicolons. This also fails during the CI/Lint (push).
Just me? Any tricks to getting this setup properly with VS Code?

Grrr, this is mysterious. You might need to crowd-source solutions in #designs-system, I've never seen something like this :/

Did some research and stumbled across this thread. I think we might need to update our tslint.json L14 to "semicolon": [true, "always", "strict-bound-class-methods"],. @misselbeck, wanna make that change and see if it fixes npm test for you?

This looks like it fixes the issue. Thanks for tracking that down! Should I commit it? Here or in another branch?

This looks like it fixes the issue. Thanks for tracking that down! Should I commit it? Here or in another branch?

 You see how I did similar here: https://github.com/NYPL/dxp-react-search/pull/81/files
In your package.json you can point the DS to use this github branch, so something like:
"@nypl/design-system-react-components": "git+https://git@github.com:NYPL/nypl-design-system.git#RENO-1881-update-pagination-component"
And you'd have to update this component:
https://github.com/NYPL/dxp-react-search/blob/development/src/components/location-finder/Locations/LocationsPagination.js
We can probs track the work in another ticket, but just doing a basic sanity check that this component will work in LF would be helpful.

This is a good idea. I'll start on that.

@misselbeck based on our conversation in this thread I've updated the Pagination designs to not shift the next/previous buttons and adhere more closely to Google Material Design's component. The designs for that are here.

After wiring up the Pagination in the Location Finder app, I think it's best to go with what @hokei suggested on Slack, and not rely on state and let the consuming app pass the currentPage. All the previous functionality works just as well doing this way, and it avoids potential  issues with keeping the state in sync after re-renders, etc.

Re-worked the component to remove state and added a new prop for the currentPage
Updated the Pagination Story
Wrote some tests

Let me know if there any further changes needed.


[DFT] Synced mklcpu backend + Real_Real tests

Description
This PR enables the mkl_cpu backend for the FFT domain to be introduced in https://github.com/oneapi-src/oneMKL/pull/259. This enables the DFT domain to support CPU device conforming to the Spec OneAPI.
Supports COMPLEX_STORAGE=COMPLEX_COMPLEX, REAL_REAL for COMPLEX transforms;
REAL STORAGE is not used anymore and instead CONJUGATE_EVEN_STORAGE is used for REAL transforms,
Tested with:

[x] 1D {complex/real} {sp/dp} {split complex} https://github.com/oneapi-src/oneMKL/pull/261
[ ] mD, many-batched (WIP) https://github.com/oneapi-src/oneMKL/pull/275

Checklist
All Submissions

[x] Do all unit tests pass locally? Attach a log.
[x] Have you formatted the code using clang-format?

New interfaces

[ ] Have you provided motivation for adding a new feature as part of RFC and
it was accepted? # (RFC)
[ ] What version of oneAPI spec the interface is targeted?
[ ] Complete New features checklist

New features

[ ] Have you provided motivation for adding a new feature?
[ ] Have you added relevant tests?

Bug fixes

[ ] Have you added relevant regression tests?
[ ] Have you included information on how to reproduce the issue (either in a
GitHub issue or in this PR)?

CPU descriptor and compute tests :
CPUTest.log

You're missing something similar to compute_signatures.cpp in the MKLGPU backend.

You're missing something similar to compute_signatures.cpp in the MKLGPU backend.

so compute signature is alreday a part of this work and was introduced in the previous PR's that have been merged.

Can you also make sure everything is formatted please, git clang-format-10 --binary=clang-format-10 develop returned this list of files that need to be formatted:

examples/dft/compile_time_dispatching/complex_fwd_buffer_mklcpu.cpp
src/dft/backends/mklcpu/backward.cpp
src/dft/backends/mklcpu/commit.cpp
src/dft/backends/mklcpu/mklcpu_helpers.hpp
tests/unit_tests/dft/include/compute_inplace.hpp
tests/unit_tests/dft/include/compute_inplace_real_real.hpp
tests/unit_tests/dft/include/compute_out_of_place_real_real.hpp
tests/unit_tests/dft/source/compute_tests.cpp

cpu_test.log

@mkrainiuk can you review this : examples/dft/compile_time_dispatching/CMakeLists.txt
it is modified to compile two different CT examples for different backends, and ensure that each one gets the appropriate shared obj in the linkline.

@anantsrivastava30 can you address the merge conflict please.


fix: Use correct name when getting sumoclient logger

Solves Komodo bleeding build fail: https://equinor.slack.com/archives/CKC3H3W74/p1733985023644679?thread_ts=1733965770.042389&cid=CKC3H3W74

Closing.
Reverting the rename by https://github.com/equinor/sumo-wrapper-python/pull/217 instead to keep consistent with the getLogger name used by Python. Revert PR https://github.com/equinor/sumo-wrapper-python/pull/218


DICCS not compatible with VAGINA

Please advise DICCS is not compatible with my VAGINA (Virtual Asynchronous Graphic Accelerator Infrastructure Agent)

Please proceed as in this instructional video: https://youtu.be/AYjCXjIeNJk?t=3m29s.


[Merged by Bors] - feat: API around Small

@fpvandoorn, could you help me with the to_additive problem here?

The issue is https://github.com/leanprover/lean4/issues/2077 (which was fixed a day ago!)


Fix reference in jtag debugging section (IDFGH-1328)

Signed-off-by: Stefan Venz<EMAIL_ADDRESS>

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @ikstream, I have added this PR to internal review queue, thanks!

Merged in 82ba58d, thanks @ikstream!


castling rights on rook capture. closes nvzqz/Sage#8

This does not restore rook castling rights if the capture is undone.
Also, the if let _ = capture?.kind.isRook { part passes for any capture. Instead do:
if let capture = capture, capture.kind.isRook {
    ...
}

Made the change with if let ... _undoMove seems to already restore the castling rights. What do you mean by undoing the capture?

Sorry, I should've specified. It's been a while since I looked through the code for the project. You're right. I forgot that castling rights were retained in history.

Done, build passing now!


Antivirus detected

Mobile anti Virus and play protect detected like  fake app

download apk signer and based on victim android version sign it and publish


Why XLA need new kernels about op?

In TensorFlow code about XLA, I see kernels about many OPs like [compiler/tf2xla/kernels/concat_op](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/tf2xla/kernels/concat_op.cc).  It seems like a repetition of [core/kernels/concat_op](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/kernels/concat_op.cc).
Why Ops like compiler/tf2xla/kernels/concat_op are needed? And why not just replace it with core/kernels/concat_op to save code?

hi

These kernels are very different.  The XLA kernel generates HLO that represents the TF operation while the non-XLA kernel implements the behavior for TF concat.


How to adjust mesh opacity

I’m using NiiVue to render multiple meshes (PLY format) based on the mesh example.
Everything works well except for controlling the opacity of individual meshes.
Here’s what I’ve tried:

Setting the opacity property when loading meshes using URL options.
Modifying the opacity later with the following code:

nv1.setMeshProperty(nv1.meshes[0].id, "opacity", 0.2)

However, neither approach seems to have any effect.
The only method that works is enabling meshXRay on the nv1 instance, but this affects all meshes globally, which isn’t what I need.
Is there a way to control the opacity of individual meshes, similar to how the mesh layers opacity example demonstrates?

Our primary focus is to keep NiiVue fast even on low power phones and old hardware. Specifically, we try to have good performance on 1.1GHz thermally constrained MacBook  which is very imbalanced by combining a poor GPU with a high-DPI display (2560×1600). For this reason, have not focused on mesh translucency. In general, graphics shaders are designed to run in massively in parallel, with only the nearest vertex creating a pixel color. In other words, when looking at millions of triangles, the depth buffer is used to find the one that is closest to the camera for every pixel, and only that fragment influences the final color. A strength and weakness of WebGL2 is that it is designed to be the lowest common denominator for modern graphics languages - the advantage is that a single code base targets Vulkan, Metal and DirectX. However, it does mean that you do not have access to some very powerful but energy inefficient stages such as the geometry shader.
For this reason, NiiVue does not provide true mesh translucency. It does provide a feature called meshXRay that you can interactively try out with the sliders in this live demo as well as this live demo. The concept is similar to what is described here. Be aware that setting a meshXray great than 0 typically halves the speed of rendering. Also, as you can see by using a high level in this live demo you can see artifacts relating to the ordering of the parallel fragment shaders (which can be hardware specific).
Another option is the outline shader which you can selectively apply to a subset of your meshes - you can see this by pressing the outline button in this live demo.

@neurolabusc Thank you for your response. The reason I would like to control individual mesh opacity is because the meshes are overlapping. I would like to render something below (screenshot from 3D Slicer)

The bones are 0.5 opacity to display the teeth roots anatomy. Using meshXRay would make everything translucent.
Is there anyway that I could construct my meshes to be able to load as layers just like the mesh layers example?
Or meshes are generated from NIFTI label file using vtk so even changing output format is doable.
Thanks.

Yoou can load multiple meshes - view the source code of the  mesh layers live demo to see how you can load multiple independent meshes and give them each unique properties including color, shader (e.g. the outline button only influences the cortex, not other properties:
await nv1.loadMeshes([
	{
		url: "../images/BrainMesh_ICBM152.lh.mz3",
		rgba255: [255, 255, 255, 255],
	},
	{
		url: "../images/CIT168.mz3",
		rgba255: [0, 0, 255, 255]
	},
]);

You can apply XRay to this scene below you see none, light and heavy. With the heavy you can see a lot of artifacts from the fragment shader:

I do think to replicate the behavior of Slicer3D you will want to develop your own shader: presumably you render both images as well as their depth buffers to offscreen textures, and then run a shader the blends the multiple images. NiiVue is open source, so feel free to develop this.

Understood. Thank you for your detailed answer.


Clarify payload transformation behavior

The W3C VC data model defines some rules that need to be applied when encoding and decoding Verifiable Credentials and Presentations to and from the JWT payload format.
These rules do not cover several edge cases, like what if the payload contains both entries before a transformation is attempted, what if these entries convert to different values, or what to do with the original fields (delete them or not?).
This library provides the methods:

transformCredentialInput(credential) - encode to JWT payload format
transformPresentationInput(presentation) - encode to JWT payload format
normalizeCredential(JWT) - decode from JWT payload format
 normalizePresentation(JWT) - decode from JWT payload format

The default behavior of these methods is to delete the transformed entries from the output during conversion.
This is behavior differs from other implementations, such as the one from vc.js which prefers to duplicate the entries.
Also, there are some examples of JWT credentials that circulate in the community that also display this duplication.
While this duplication is inefficient and unfortunate, it leads to incompatibilities when trying to use this library to generate similar examples.
(see https://github.com/uport-project/veramo/issues/394)
To accommodate these differences the default behavior should be adjusted here as well to keep the originals when performing encode/decode.
This would be a breaking change, but if required, the existing behavior could be reenabled with a flag passed to the encoding methods.

Hey @mirceanis, can you point me to an example for

This is behavior differs from other implementations, such as the one from vc.js which prefers to duplicate the entries.

because I felt this property conversion was unique to the JWT conversion we are doing in this library. Where does vc.js need to convert/duplicate properties of an input VC?

Sure, here is some JWT issuance code from transmute-industries/vc.js
The relevant properties of the credentialTemplate are used to generate the corresponding properties of the JWT payload but are not removed from the original template.
Also, the JWT examples in the well known did config spec follow the same pattern.
This means that this library can't be used to generate similar JWTs for domain linkage credentials because it is removing the entries during the transformation.

Thanks! I'll reach out to Orie I think the community would generally settle on a duplication. Then the optional parameter could be removed again. But until then we can keep it in there.

IMO duplication is not only inefficient but also opens up a lot of edge cases.
What do you do if the values of the duplicate properties are different?
I would go the opposite way and define an unambiguous transformation.


Export to .csv Firefox & Safari

Hello to everyone,
Thanks a lot for this wonderful soft - it is pretty awesome in all ways.
I actually use the master-branch of ng-admin and noticed that the export button on listView is only working on google Chrome - not on Firefox & Safari (I also don't get any errors on clicking, so I was wondering if this is really a bug or just me...).
Thanks again for all the hard work you did on ng-admin.
Regards,
Felix.

Export button is not working for me either on Chrome (42.0.2311.152 m)

To be more specific, this is what happening to me in the console after clicking the export Button on the listView - using the three browsers on MacOs Yosemite:

I am using the latest branch of ng-admin.
Chrome is saving a .csv with entity name (it's all good); Safari is displaying an error; Firefox launches a GET Request with no error but isn't dowloading any .csv.
Hope this helps.

Hello guys,
Thanks for your report.
I've fixed a download issue with the export button.
Can you try with the new version of the master branch ?
Regards

Brilliant,
works fine on Firefox now.
(But i guess you removed the standalone version of ng-admin).
For your information, on Safari, it is not really downloading the .csv, but it's displaying its content directly in the browser.
Indeed, thanks a lot!

(The standalone version was just renamed in 1fce094fd1a27a18d1efe814e98771134cbb9cd6)

In fact, we just changed naming. Standalone version is now in ng-admin.min.js file, and the light one is in ng-admin-only.min.js. It was renamed for backward compatibility issues.


Khan Academy - Geometry/Trigonometry Review

Khan Academy

Moved to https://github.com/Mootook/independent-studies/issues/28


Predictable output plugin idea

Hi y'all! I'd like to make a plugin that hashes the input and stores it in a lock file, to prevent generating a new file when the input is the same.
Are y'all cool if I go for something like this?

Hi @vladinator1000 ,
I'm not sure I fully understood this. Are you referring to a new plugin suggestion? If so, can you please share an example for input/output?
Or are you referring to an optimization on codegen core to prevent re-generating unchanged files?

@dotansimha I'm not sure if it should be a plugin or core but I'm trying to do this, yeah:

prevent re-generating unchanged files?

@vladinator1000 I see, thank you. it's a core feature in this case.
We do prevent fs operations when output file changes, but TBH, so far we didn't see projects that has performance issues with codegen. Is there a use case that requires this kind of feature?

I'm mostly doing it cause I commit my generated file to source control and I'd like to avoid it appearing in the diff if it hasn't meaningfully changed.

@vladinator1000 I've been looking for a solution for this - our issue is that the order of enums is not deterministic. Meaning - even if no backend GraphQL changes were added, the order of the enums will rearrange, and those changes will then need to be added to source control.
@dotansimha is there a reason that the order of enums is constantly rearranging, even though no backend changes were introduced?
I'd be interested in collaborating on this - is your issue tied to a specific part of the GraphQL schema?

I think eventually our best solution it to port this piece of code: https://github.com/dotansimha/graphql-code-generator/blob/master/packages/plugins/other/schema-ast/src/index.ts#L57 into graphql-tools.
I think it should be pretty simple.
@ardatan can you please take a look?

Tracking in: https://github.com/dotansimha/graphql-code-generator/issues/5106#issuecomment-741689595


⚠ ClamAV has degraded performance

In 32ac7ef, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 207 ms

Resolved: ClamAV performance has improved in a0dbad4.


DOCS: ui-sref may be cancelled by calling event.preventDefault() in other handlers

This is very useful feature that I love to use sometimes, but I found it by browsing source code. :)

want to submit a pull request to fix that?

any updates on this?

@ctysingh Do you want to write a PR for the docs?

sure I can give a try.


Duplicate replyTo when running render() prior to send

Laravel Version: 9.40.1
PHP Version: 8.1.10
Database Driver & Version: not relevant

Description:
If you run render() prior to sending the email, it will double replyTo.
A bit related to #30857
Steps To Reproduce:

The below example will add<EMAIL_ADDRESS>2 times to the reply_to field.
use App\Mail\Question;

$mailTemplate = new Question( 'Hello, I have a question' );
$mail = $mailTemplate->render();
// ...store $mail in the database

Mail::to( config( 'mail.from.address' ) )
    ->locale( 'nl' )
    ->send( $mailTemplate );

<?php
namespace App\Mail\Patient;

use App\Models\Patient;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Mail\Mailable;
use Illuminate\Queue\SerializesModels;

class Question extends Mailable implements shouldQueue
{
    use Queueable, SerializesModels;

    /**
     * Create a new message instance.
     *
     * @param Patient $patient
     * @param string  $question
     */
    public function __construct( public string $question )
    {
        $this->queue = config( 'config.queue-email' );
    }

    /**
     * Build the message.
     *
     * @return $this
     */
    public function build()
    {
        return $this->from( [
            'address' => config( 'mail.from.address' ),
            'name'    => config( 'mail.from.name' ),
        ] )
                    ->replyTo<EMAIL_ADDRESS>)
                    ->subject( 'someone has a question' )
                    ->view( 'mail.question' );
    }
}

Hey everyone, this is my first attempt at contributing to the Laravel Framework so I wanted to check things with you before I submit anything.
I worked on a change that's updating the setAddress method like this:
 protected function setAddress($address, $name = null, $property = 'to')
    {
        if (empty($address)) {
            return $this;
        }

        foreach ($this->addressesToArray($address, $name) as $recipient) {
            $recipient = $this->normalizeRecipient($recipient);

            $this->{$property}[] = [
                'name' => $recipient->name ?? null,
                'address' => $recipient->email,
            ];
        }

        $this->{$property} = collect($this->{$property})
            ->unique('address')
            ->values()
            ->all();

        return $this;
    }

This would prevent any recipient from being duplicated, but I'm not sure if this is the expected behaviour because after this change some tests are failing and this is the asserts failing:
$mailable = new WelcomeMailableStub;
$mailable->replyTo(collect([new MailableTestUserStub, new MailableTestUserStub]));
$this->assertEquals([
    ['name' => 'Taylor Otwell', 'address' =><EMAIL_ADDRESS>    ['name' => 'Taylor Otwell', 'address' =><EMAIL_ADDRESS>], $mailable->replyTo);
$this->assertTrue($mailable->hasReplyTo(new MailableTestUserStub));
$this->assertTrue($mailable->hasReplyTo('taylor@laravel.com'));
$mailable->assertHasReplyTo('taylor@laravel.com');

Since with this change, the expected result would be a single item in the array.

Hello @JBtje @driesvints
I pushed the change I mentioned above to my fork since IDK if this is the expected behaviour because it's making some test cases fail. I'm not going to create the PR but can you help me check if these changes are ok? Because if so I can work on updating the test cases and create the PR after that.


feat: rebuild search modal

Great work!
Can we do the following:

add the icon for tags
reduce vertical spacing to 6px instead of 10px on the anchor
change gap from 4px -> 3px between the path and title?

@marclave LGTM

@cameronrohani

add the icon for tags - Done! Needed a hand from @marclave
reduce vertical spacing to 6px instead of 10px on the anchor - Done
change gap from 4px -> 3px between the path and title? - Done

@marclave LGTM!


Make it possible to disable writing to the execution history

First: This is a niche request, and it may not impact a lot of other users. Nonetheless, it would have a significant impact on the performance of our CI builds, as explained below, so we’re hoping you’ll consider merging some version of our PR.
Background: For our pre-merge CI builds, we run a very large number of tests in parallel by checking out VMs from a cloud service, making several containers per VM using Docker, and running tests in each of those containers. Before this happens, we run compilation (and some other tasks) using Gradle, and include the resulting files in the docker image we send to VMs. Each container process then runs a certain set of tests using Gradle.
One issue we’ve run into is that executionHistory.bin becomes huge in our builds -- currently 5.9 GB after running compilation tasks plus a second set of tasks with similar classpath inputs. This is an issue because of the copy-on-write behavior from using Docker and overlayfs. When Gradle runs, it writes to this file, which prompts Docker to make a copy of the entire file. Even though we’re using an in-memory filesystem, which reduces the runtime impact of this copy, the 6 GB added to memory usage from each container is large enough to significantly reduce the amount of parallelism we can do -- it’s about 25% of our memory used.
(Why is it 5.9 GB? I’ve poked around in the related code. This is mostly an issue of how it scales with both number of projects and number of source files. For a single task, the stored information includes an entry for each .class file elsewhere in the repo that is included in the task’s dependencies. There’s no sharing of this information among tasks. Our largest tasks store 14MB each, with 11000 tasks run from 770 projects.)
The request: We’d like to be able to disable writing to the executionHistory.bin file during a given Gradle invocation. I expect this would happen via a system property or other suitably obscure method, and it would be undocumented and clearly unstable/unsafe (“this will void your warranty”). We aren’t asking for future support, beyond “please don’t remove this for no reason”.
We have tested this approach, and it works for us (with one caveat: we also have to set the file to read-only in the filesystem, or else it will get copied when it is opened anyway).
If the executionHistory.bin could be made smaller, that would also serve our needs, but I expect that would be a much more difficult undertaking.

Duplicates #19978

Could you pls. let us know the Gradle version you are using?

This is with Gradle 7.3.3.

IIUC, there are some tasks in your build that work with a large number of inputs that result in this behavior. One thing you can try is to disable up-to-date checks for just those tasks: https://docs.gradle.org/current/userguide/more_about_tasks.html#sec:disable-state-tracking

Are you asking me to disable up-to-date checks for all my compileJava/compileTestJava tasks in my downstream projects? 😕

I'm not sure about the "downstream projects" part, but I believe yes. I also don't understand the disappointed face. If you disabled writing to the execution history, you'd get no up-to-date checks or incremental execution for any of your tasks. How is my recommendation worse than that?

We write to the execution history in a build that compiles everything and runs other preparatory work. Then we run a second build (in the containers) that runs some tests, but reuses the compilation, etc. from the first run. Only the second run would use a read-only execution history.

I'm lacking some serious context here, but you could also use the local cache to keep your downstream builds from repeating compilation. Less efficient, but avoids writing to the execution history, which was the stated goal.
To take a step back, I don't see us implementing this functionality in this way as the resulting complexity would not be worth it. If we invested here, it would be more useful to de-dupe the execution history. It would decrease the size of the history file, and would increase performance for other builds, too. We have some plans to do that, but unfortunately it's not high on the priority list at the moment.

@AlexLandau One more question: Which executionHistory.bin is using 6GB? Is it the one in the Gradle user home or the one in the project directory?

@wolfs: This is the one in the project directory.
@lptr: I agree that read-only execution history shouldn't be a supported feature or an area that Gradle devs put time into. The most I'm hoping for is if https://github.com/gradle/gradle/pull/20006 could be considered, to spare us the pain of maintaining a fork or equivalent hacks.

With #20006 we'd need to add a lot more testing, make sure it's properly documented and available as a public feature. I once again don't think it's something we'll have bandwidth for, and even if we had it, there are better ways to invest here. Sorry about that.
We have decreased memory consumption in Gradle in #20002. Maybe this will help your use case already; we've seen it save a lot of heap for one of our customers with a large build.


pyupgrade --py36-plus **/*.py

Upgrade syntax for newer versions of Python.  https://github.com/asottile/pyupgrade

Thanks for the PR @cclauss, sadly we still support MicroK8s on 16.04, which comes with Py3.5, meaning we must remain backwards compatible.  We are looking at bundling a fixed version of Python with MicroK8s, at which point, we can use this PR.

pyupgrade --py3-plus should work for that scenario.


Add skeleton for test_workload_with_fsgroup test

longhorn/longhorn#2964

@PhanLe1010 Can you please help backport this to v1.2.x so that I can backport https://github.com/longhorn/longhorn-tests/pull/710 too?

I pushed the back port https://github.com/longhorn/longhorn-tests/pull/713


Correct for Time Zones in date search parameters

Currently, if the user specifies a search filter such as ['date', 'ge2023-06-01T00:00:00.000-07:00'], we will not correct for the timezone offset.
This feature would have the server convert the query into UTC time before executing the search in the DB

Entered in error


Support Key/Token authentication in Azure Storage Service.

#63 #16  are the current blockers for this feature support.

@JinmingHu-MSFT  is currently working on this in Storage's repo.


The effort documentation is outdated

Encode_effort.md is not accurate anymore with the release of libjxl 0.10.x. Outside of the "brute force" effort now being 11, does VarDCT e10 do anything special? Or does it simply do more Butteraugli iterations? What about e9 vs e10 lossless? I think it should also mention which efforts use the new streaming mode by default in 0.10.x. Jon Sneyers in the JXL discord mentioned that e10 disables streaming by default.
I should also mention that for benchmarking.md, "glacier" is equivalent to e10, so what is e11? Edit: Apparently e11 is called "tectonic plate".

Discord seems to require login for read access now.
    Would you transcript the relevant info?

Here's a snippet, Jon Sneyers is _wb_, the topic is about lossless encoding. I recommend joining the sever, lots of good information in there.
afed — 3/6/2024 11:22 AM
because streaming sometimes gets better results than non-streaming

JendaLinda — 3/6/2024 11:24 AM
I kept the default streaming settings.

_wb_ — 3/6/2024 11:25 AM
It's basically greedy local optimization vs greedy global optimization. Cannot say which will be best.

_wb_ — 3/6/2024 11:25 AM
Default is to use streaming up to e9, no streaming at e10

JendaLinda — 3/6/2024 11:26 AM
So that explains it. -e 9 also seems to better utilize CPU threads.

Orum — 3/6/2024 11:38 AM
yeah, but you can force streaming with e 10 (which is the only way it's remotely practical IMHO)

JendaLinda — 3/6/2024 11:52 AM
What is the actual difference between streaming and not streaming?
Is that the streaming mode better uses the available resources?

afed — 3/6/2024 11:55 AM
streaming is encoding in independent blocks, non-streaming is the whole image

JendaLinda — 3/6/2024 11:57 AM
So in non-streaming mode, the encoder has access to more information to work with, right?

afed — 3/6/2024 11:59 AM
yeah

Thanks for suggestion.
    But somewhat troublesome for me. (the access management trouble)
"afed - 3/6/2024 11:22 AM"
    Is it CE 2024-03-06 11:22 -07:00? (or -03:00?)
    (I'll add refactored content later)

Is it?
    “"--streaming_output"
    Enable incremental writing of the output file.”
I tried but appears no-op with "-e 11 -d 0"?

"afed - 3/6/2024 11:22 AM". Is it CE 2024-03-06 11:22 -07:00? (or -03:00?)

The format is MM/DD/YYYY, UTC -8.

“--streaming_output Enable incremental writing of the output file.” I tried but appears no-op with "-e 11 -d 0"?

First of all, you should be using --streaming_input not --streaming_output.
Streamed encoding can only be used on images larger than 2048x2048. So if your images are under these dimensions it will ignore --streaming_input.

“"--streaming_input"
    Enable streaming processing of the input file (works only for PPM and PGM input files).”
"only for PPM and PGM input files"?

That's what it says, but according to my testing it seems to work with non-interlaced PNGs as well.

So my `ffmpeg` pipe [  https://github.com/libjxl/libjxl/issues/3921#issue-2639083059 ] there shall also work..?
    May try later.
What about JXL (lossless) input?

Lossless JXL input also seems to work. Maybe the documentation is old.


Disallow empty cost model for create update proposal

$ cardano-cli governance create-update-proposal --epoch 50 --max-block-execution-units '(20000000000,62000000)' --cost-model-file ~/Downloads/cost-model-secp-preprod-mainnet.json --protocol-major-version 8 --protocol-minor-version 0 --genesis-verification-key-file example/genesis-keys/genesis1.vkey --out-file update.proposal
Command failed: governance create-update-proposal  Error: The decoded cost model was empty at: /Users/jky/Downloads/cost-model-secp-preprod-mainnet.json

Resolves https://github.com/input-output-hk/cardano-node/issues/4867

bors r+


Public descriptions of lot6d.

Signed-off-by: Kurt Garloff<EMAIL_ADDRESS>

I added the missing page to _pages which was missing in this PR. Sorry, Jekyll is kind of burdensome in regards of internalization.. :disappointed:


Typo in the ObservableList's method name

Originally opened as dart-lang/sdk#18260
This issue was originally filed by<EMAIL_ADDRESS>
There is a typo in the package observe, ObservableList's method name.
Expected: discardListChanges()
Actual: discardListChages()

 Comment by sigmundch

https://codereview.chromium.org/368883004/

Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-Low, Started labels.

 Comment by sethladd

Added Area-Pkg, Pkg-Observe, Triaged labels.

 Comment by sigmundch

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

 Comment by sigmundch

Removed Polymer-Milestone-Next label.

 Comment by jakemac53

Added Fixed label.

 Comment by srawlins

This has been committed. This issue can be closed.

 Comment by sigmundch

Added PolymerMilestone-Next label.

 Comment by sigmundch

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.


Quay.io: TOO_MANY_TAGS_REQUESTED requested limit 1000 is too high, max is 100

Hello, so we have run into an issue that makes us unable to use Image Automation with some Docker Registries which limit PageSize on the v2/.../.../tags/list endpoint.
scan failed: GET https://quay.io/v2/pganalyze/collector/tags/list?n=1000: TOO_MANY_TAGS_REQUESTED: Too many tags requested; requested limit 1000 is too high, max is 100

In order to resume using Image Automation with Quay.io, we'd need some way of setting pageSize on the ImageRepository.
The underlying go-containerregistry.remote already has a withPageSize function.
https://github.com/google/go-containerregistry/blob/main/pkg/v1/remote/options.go#L292

just tried reaching Quay on X https://x.com/gionn/status/1804162576382664972

Major breaking change shipped on a Friday 😱  This also breaks source-controller for HelmCharts and OCIRepositories with semver ranges.

This also breaks source-controller for HelmCharts and OCIRepositories with semver ranges.

This is also quay.io images limited, right? Not others.

This also breaks source-controller for HelmCharts and OCIRepositories with semver ranges.

This is also quay.io images limited, right? Not others.

yes

In order to resume using Image Automation with Quay.io, we'd need some way of setting pageSize on the ImageRepository.

This shouldn't be needed. Quay should return a page with 100 tags (their max page size) along with a link header for the next page. This is how all the other registries behave.

Is there any way (except recompiling IRC) to get the maximum to 100 in the interim?

We're not the only ones downstream that are affected by this change.

Is there any way (except recompiling IRC) to get the maximum to 100 in the interim?

No, the limit parameter is hard-coded to 1000 and current IRC has no way to change that.

We (quay.io) have deployed a fix where you'll get the max tags instead of a 417. Sorry for the Friday disruption 😅

Thanks @syed
Due to exponential backoff in Flux, the ImageRepository reconcilers will take a long time to recover. For a faster recovery, restar image-reflector-controller by deleting its pod.


Cilium-agent fails to start on nodes without default gateway

This PR fixes the problem by checking for the default gateway
in the existing routes and if gateway is absent the 'autoDetect'
fails.
When autoDetect fails we set the default 'Ethernetmtu' and will
also raise a warning message.
Fixes: #11588
Signed-off-by: Swaminathan Vasudevan<EMAIL_ADDRESS>

Coverage decreased (-0.006%) to 37.075% when pulling 2cac76cc3fb5735f9ef86e29db35bea8759d993a on soumynathan:cilium-agent-fails-without-node-gateway-set into 2d4cc760b4b8b845ac136a06c28d229f466845cc on cilium:master.

test-me-please

This also a candidate for backport.

Runtime-4.9 hit only known flake #10278; other required builds are passing.


[dubbo 4458] doRefer in RestProtocol may cause OOM

What is the purpose of the change
https://github.com/apache/dubbo/issues/4458#issue-463641024

clear resouces when invoker(AbstructProxyInvoker) is not in use:

protected <T> Invoker<T> protocolBindingRefer(final Class<T> type, final URL url) throws RpcException {
        final Invoker<T> target = proxyFactory.getInvoker(doRefer(type, url), type, url);
        Invoker<T> invoker = new AbstractInvoker<T>(type, url) {
            @Override
            protected Result doInvoke(Invocation invocation) throws Throwable {
                // do invoke...
            }

            // invokers need clear unused invoker
            @Override
            public void destroy() {
                super.destroy();
                target.destroy();
                invokers.remove(this);
            }
        };
        invokers.add(invoker);
        return invoker;
    }

clear RestProtocol.cliens by using map(key is url, value is client)

Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #4629 into master will increase coverage by 0.43%.
The diff coverage is 76.74%.

@@             Coverage Diff              @@
##             master    #4629      +/-   ##
============================================
+ Coverage     63.48%   63.92%   +0.43%
+ Complexity      451      450       -1
============================================
  Files           789      769      -20
  Lines         34721    33146    -1575
  Branches       5422     5225     -197
============================================
- Hits          22044    21188     -856
+ Misses        10151     9528     -623
+ Partials       2526     2430      -96

Impacted Files
Coverage Δ
Complexity Δ

...ache/dubbo/rpc/protocol/AbstractProxyProtocol.java
80% <100%> (+1.42%)
0 <0> (ø)
:arrow_down:

...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java
71.11% <74.35%> (+2.89%)
0 <0> (ø)
:arrow_down:

...che/dubbo/remoting/transport/mina/MinaChannel.java
43.42% <0%> (-10.53%)
16% <0%> (-1%)

.../remoting/transport/netty4/NettyServerHandler.java
61.9% <0%> (-9.53%)
0% <0%> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
51.42% <0%> (-5.72%)
0% <0%> (ø)

...ng/exchange/support/header/HeartbeatTimerTask.java
73.68% <0%> (-5.27%)
0% <0%> (ø)

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0%> (-5.27%)
0% <0%> (ø)

...org/apache/dubbo/rpc/protocol/AbstractInvoker.java
60.65% <0%> (-3.28%)
0% <0%> (ø)

...exchange/support/header/HeaderExchangeHandler.java
64.75% <0%> (-2.46%)
0% <0%> (ø)

...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java
57.28% <0%> (-1.14%)
0% <0%> (ø)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443b6ff...88e2696. Read the comment docs.

@finalcola I am not persuaded that the current solution is better than the original. The reason is, I believe 'connection manager' plus 'connection monitor' will reuse and recycle the client. The potential OOM issue may caused by 'connection manager' is not used when the client is created, which has in fact been fixed by you with another pull request: #4614

#4614 will clear HTTPConnection, but RestProtocol will keep too much client(ResteasyClient) reference which makes these ResteasyClient instance can't be GC.

@beiwei30

I see. In your solution, when will ResteasyClient be recycled?

#4614 will clear HTTPConnection, but RestProtocol will keep too much client(ResteasyClient) reference which makes these ResteasyClient instance can't be GC.

a second thought: If I don't misunderstand, there's no way to recycle the clients, even if they are now saved in a map. This may lead to a potential problem, which is, the underlaying connection can be closed by connection manager (see connection monitor). If this happens, this will lead to invocation failure since the resteasy client maintained in the map doesn't have lifcecycle management.
Should we simply create Resteasy client every time and then drop it? I think it is not expensive since the connection will be reused, what do you think?
Or should we maintain the client in weak hash map instead?

The previous implementation was to use a List to collect clients, but add client only, never remove. Now clients are saved in map which means they are in use, and old client will be remove and close.    When doRefer happens,  will create a new client for this url.   @beiwei30

The previous implementation was to use a List to collect clients, but add client only, never remove. Now clients are saved in map which means they are in use, and old client will be remove and close. When doRefer happens, will create a new client for this url. @beiwei30

could you pls. point out when the client will be removed from the map?

it will not remove. My original idea was that each existing url would generate only one client（previous implementation using Sync List will add client everytime）, because It is not clear whether the client corresponding to the url is still in use.
maybe sync WeakHashMap can solve it, but it dose not pass the  travis-ci in JDK 11.
https://travis-ci.org/apache/dubbo/builds/563891937
@beiwei30

now, i use WeakRefence to hold client

@beiwei30 could you please have a look, if there are any problems

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@finalcola Hi, thanks for your contribution.
Please merge the latest master branch to resolve confilcts.

Close for long time no response.
Please feel free to reopen if you have any question.
If you think these changes still useful in the latest master branch, please submit a new pull request.

Codecov Report
Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.99%. Comparing base (443b6ff) to head (821a9d5).

Files
Patch %
Lines

...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java
80.95%
2 Missing and 2 partials :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4629      +/-   ##
============================================
+ Coverage     63.48%   63.99%   +0.50%
- Complexity      451      452       +1
============================================
  Files           789      769      -20
  Lines         34721    33186    -1535
  Branches       5422     5231     -191
============================================
- Hits          22044    21238     -806
+ Misses        10151     9525     -626
+ Partials       2526     2423     -103

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Configuration installing to (prefix)/etc/ when prefix is used

When an install prefix is used (which is typical for installation on Linux), the configuration files wind up in (prefix)/etc . So in the typical case of CMAKE_INSTALL_PREFIX being  /usr , we wind up with:
/usr/etc/modulefiles
/usr/etc/modulefiles/vpl
/usr/etc/vpl
/usr/etc/vpl/vars.sh

I don't think this is correct or intended, but I don't know what the 'right' way to fix it would be.
CMake's documented special handling here only covers "(dir) equal to SYSCONFDIR, LOCALSTATEDIR or RUNSTATEDIR". What we do is this:
if(NOT ONEAPI_INSTALL_ENVDIR)
  set(ONEAPI_INSTALL_ENVDIR ${CMAKE_INSTALL_SYSCONFDIR}/${PROJECT_NAME})
endif()

if(NOT ONEAPI_INSTALL_MODFILEDIR)
  set(ONEAPI_INSTALL_MODFILEDIR ${CMAKE_INSTALL_SYSCONFDIR}/modulefiles)
endif()

and then we install things to those directories, e.g.:
  install(
    PROGRAMS vpl
    DESTINATION ${ONEAPI_INSTALL_MODFILEDIR}
    COMPONENT dev)

which, I think, results in cmake expanding ONEAPI_INSTALL_MODFILEDIR , since it's a relative path, and including the prefix, so we wind up with /usr/etc/modulefiles.
I did come up with a bit of an ugly hack, which is to explicitly set ONEAPI_INSTALL_FULL_ENVDIR and ONEAPI_INSTALL_FULL_MODFILEDIR in oneAPIInstallDirs.cmake and then install the files to the _FULL_ paths not the relative ones. But that also requires adding extra stuff in the if(USE_ONEAPI_INSTALL_LAYOUT) branch and just generally feels kinda ugly. This seems like the kind of thing where you'd expect it to be something that's commonly encountered and a solved problem already, but I couldn't find anything for it, weirdly.

Well, that workaround was silly, so here's another. This "fixes" it, but still feels icky, so I'm not sending it as a PR...
From 89068d21b5a24bd160b3487b8d8c8f05482ee1f9 Mon Sep 17 00:00:00 2001
From: Adam Williamson<EMAIL_ADDRESS>Date: Mon, 13 Mar 2023 16:32:31 -0700
Subject: [PATCH] Fix config install destinations when prefix is /usr (#94)

When CMAKE_INSTALL_PREFIX is /usr , we wind up installing config
files to /usr/etc , which is wrong (and breaks ostree composes).
This hacks around that.

Signed-off-by: Adam Williamson<EMAIL_ADDRESS>---
 cmake/oneAPIInstallDirs.cmake | 7 +++++++
 env/CMakeLists.txt            | 2 +-
 modulefiles/CMakeLists.txt    | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/cmake/oneAPIInstallDirs.cmake b/cmake/oneAPIInstallDirs.cmake
index c6ab7d7..1a04675 100644
--- a/cmake/oneAPIInstallDirs.cmake
+++ b/cmake/oneAPIInstallDirs.cmake
@@ -95,6 +95,13 @@ foreach(
                                           ONEAPI_INSTALL_${dir} ${dir})
 endforeach()

+# GNUInstallDirs_get_absolute_install_dir gets this case wrong
+# https://github.com/oneapi-src/oneVPL/issues/94
+if(CMAKE_INSTALL_PREFIX STREQUAL "/usr")
+  set(ONEAPI_INSTALL_FULL_ENVDIR /${ONEAPI_INSTALL_ENVDIR})
+  set(ONEAPI_INSTALL_FULL_MODFILEDIR /${ONEAPI_INSTALL_MODFILEDIR})
+endif()
+
 if(WIN32)
   set(CMAKE_INSTALL_SYSTEM_RUNTIME_DESTINATION ${CMAKE_INSTALL_BINDIR})
 else()
diff --git a/env/CMakeLists.txt b/env/CMakeLists.txt
index 4ea8ab2..cc75873 100644
--- a/env/CMakeLists.txt
+++ b/env/CMakeLists.txt
@@ -44,6 +44,6 @@ else()
   configure_file("sh/vars.sh.in" "${ENV_SCRIPT_NAME}" @ONLY)
   install(
     PROGRAMS "${CMAKE_CURRENT_BINARY_DIR}/${ENV_SCRIPT_NAME}"
-    DESTINATION "${ONEAPI_INSTALL_ENVDIR}"
+    DESTINATION "${ONEAPI_INSTALL_FULL_ENVDIR}"
     COMPONENT dev)
 endif()
diff --git a/modulefiles/CMakeLists.txt b/modulefiles/CMakeLists.txt
index 4094662..e9b5076 100644
--- a/modulefiles/CMakeLists.txt
+++ b/modulefiles/CMakeLists.txt
@@ -8,6 +8,6 @@ cmake_minimum_required(VERSION 3.10.2)
 if(UNIX)
   install(
     PROGRAMS vpl
-    DESTINATION ${ONEAPI_INSTALL_MODFILEDIR}
+    DESTINATION ${ONEAPI_INSTALL_FULL_MODFILEDIR}
     COMPONENT dev)
 endif()
--
2.39.2

This patch looks reasonably correct, since this project has its own derivative module that doesn't correctly handle the /etc exception.

Fixed in 69d6b59bbdfc092d02f45b1ee550d703e85e4b6e

I think that commit is not enough, it's missing an adjustments on the paths in env/modulfiles:
diff -Naur oneVPL-2023.3.0.old/env/CMakeLists.txt oneVPL-2023.3.0/env/CMakeLists.txt
--- oneVPL-2023.3.0.old/env/CMakeLists.txt	2023-07-14 16:43:05.607855171 +0200
+++ oneVPL-2023.3.0/env/CMakeLists.txt	2023-07-14 16:44:32.808448799 +0200
@@ -44,6 +44,6 @@
   configure_file("sh/vars.sh.in" "${ENV_SCRIPT_NAME}" @ONLY)
   install(
     PROGRAMS "${CMAKE_CURRENT_BINARY_DIR}/${ENV_SCRIPT_NAME}"
-    DESTINATION "${VPL_INSTALL_ENVDIR}"
+    DESTINATION "${VPL_INSTALL_FULL_ENVDIR}"
     COMPONENT dev)
 endif()
diff -Naur oneVPL-2023.3.0.old/modulefiles/CMakeLists.txt oneVPL-2023.3.0/modulefiles/CMakeLists.txt
--- oneVPL-2023.3.0.old/modulefiles/CMakeLists.txt	2023-07-14 16:43:05.617855354 +0200
+++ oneVPL-2023.3.0/modulefiles/CMakeLists.txt	2023-07-14 16:43:47.542621545 +0200
@@ -8,6 +8,6 @@
 if(UNIX)
   install(
     PROGRAMS vpl
-    DESTINATION ${VPL_INSTALL_MODFILEDIR}
+    DESTINATION ${VPL_INSTALL_FULL_MODFILEDIR}
     COMPONENT dev)
 endif()


Christmas Crepes

https://itdoesnttastelikechicken.com/quick-easy-mushroom-bacon/
https://www.mightymrs.com/berry-compote-crepes-lemon-neat/

Velveeta
Nutella

Place berries, lemon juice and 1 tablespoon sugar in a small pot over medium/high heat and cook for about 10 minutes or until berries turn into a chunky syrup. Stir as needed to prevent sticking.

In a medium bowl, mix together the olive oil, soy sauce, maple syrup, and liquid smoke. Add the sliced mushrooms to the bowl and gently toss to evenly coat the mushrooms. Bake at 375 for 18-25 minutes.

Make as much velveeta as desired:

If using the "fresh packs", use 1tbsp butter + 1tbsp flour + 1/4 cup cream for each pack
If using the full block, multiply quantities by 5

Be generous with the nutella! Add bananas as needed

Top with whipped cream!

Crepes

No brandy
Medium heat
If using a large griddle, use 1/3 cup measure
Pour, then spread like dosa batter
Cook for 45 seconds on each side

Prep Order:

Mushroom Bacon
Compote
Crepes
Velveeta
Nutella


feat: Expose routes #1649

I saw this issue (https://github.com/denoland/fresh/issues/1649) here and thought, 'Hmm, why not just give it a go?' I am not sure if my approach to it was good, but I kinda like the idea.

While playing around with this i saw that it would be possible too add all Middlewares that apply to this Route or all handlers that exist in the fresh project

@marvinhagemeister review :) ?

Hey @RoeHH, can you please merge main and deal with the conflicts? A lot has changed in context.ts since you created this a few weeks ago. It's probably best to make sure the PR is ready to go before trying to convince Marvin to take a look.
Two logistical points:

what about some documentation? As a user, how would I even discover this exists?
I could also imagine the test being a bit more "functional" in the sense that your handler could create a "site map" or something similar. Then you could verify that your favorite route (perhaps your new "info-ctx" route) is included in the map. Of course the only way such a test could pass is if your code is working correctly.

For the actual code:

could you please clarify the name FreshInfo? I'm not sure we need a new type here, unless you have some ideas on other stuff that belongs inside this "info". It seems like you could just add routes: Route<any>[] to the context types and be done with it.
what about UnknownHandlerContext and ErrorHandlerContext? Right now they're feeling a bit left out. I guess there should at least be an explanation for why we don't want to pass the routes to these.


Unable to run newer versions of Elementum add-on past version 0.1.87

For reason unknown, my device can only work with version 0.1.87.android_arm or lower.
Expected Behavior
Updated Elementum add-on should run normally.

Current Behavior

Immediately after installing version 0.1.89.android_arm or higher, the message "Downloading required binary file for 'android_arm64' appears.
Note: My platform is not android_arm64
Possible Solution

Steps to Reproduce (for bugs)

Update Elementum add-on to any version newer than 0.1.87.android_arm

Context

Your Environment

Version used: 0.1.89.android_arm && 0.1.106.android_arm

Environment name and version: kodi 19.4 for Android (language PT-BR)

Operating System and version: Android 5.1.1

Link to Kodi debug log:
1 - Error Screenshot

2 - kodi log
kodi.log

Set platform to android-arm in Elementum settings, instead of Auto. Somehow it is detected as android-arm64 and your system cannot run it.

Set platform to android-arm in Elementum settings, instead of Auto. Somehow it is detected as android-arm64 and your system cannot run it.

I changed the "Application platform type" parameter from auto to android_arm and it worked.
I'm now using the latest version 0.1.106.android_arm
Thank you man

I don't get this thing:
2024-10-11 12:54:48.337 T:1571    DEBUG <general>: [plugin.video.elementum] Automatically detected platform: android-arm. Returning: {'auto_arch': '32-bit', 'arch': 'arm', 'os': 'android', 'version': '', 'kodi': 19, 'build': '19.4 (19.4.0) Git:20220302-e12e66e019', 'fork': True, 'machine': '', 'system': '', 'platform': ''}
2024-10-11 12:54:57.359 T:1823    DEBUG <general>: [plugin.video.elementum] Automatically detected platform: android-arm64. Returning: {'auto_arch': '32-bit', 'arch': 'arm64', 'os': 'android', 'version': '', 'kodi': 19, 'build': '19.4 (19.4.0) Git:20220302-e12e66e019', 'fork': True, 'machine': '', 'system': '', 'platform': ''}

There is auto-detect that tries to load shared library, and first run properly detected it, but first one failed with it.

@elgatito so i guess https://github.com/elgatito/plugin.video.elementum/commit/28eb32fb97634f14ee3ed16c96ea7bba6f1490b5 is the fix for this autodetect issue?

@elgatito so i guess 28eb32f is the fix for this autodetect issue?

@antonsoroko It is not clear what is the cause of the issue, so it just a possible workaround to avoid loading shared library more than once.