Category art not showing up

Hi. There may be an issue about category art not showing up in the play mode but being present in the editor mode.

Hmmm.. can you send me the feed to check out?
Thanks!
On Thu, Feb 10, 2022 at 2:12 PM Emreler1 @.***> wrote:

Hi. There may be an issue about category art not showing up in the play
mode but being present in the editor mode.
—
Reply to this email directly, view it on GitHub
https://github.com/webrcade/webrcade-docs/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKG7CW53AGX7QQBJWHQWOLU2QZ3JANCNFSM5OCG4SOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi Chris,
Please see the link of the json file from my Dropbox account.
https://tiny.cc/emreler1 https://tiny.cc/emreler1
Best,
Emre

On 11 Feb 2022, at 02:19, Chris Smith @.***> wrote:
Hmmm.. can you send me the feed to check out?
Thanks!
On Thu, Feb 10, 2022 at 2:12 PM Emreler1 @.***> wrote:

Hi. There may be an issue about category art not showing up in the play
mode but being present in the editor mode.
—
Reply to this email directly, view it on GitHub
https://github.com/webrcade/webrcade-docs/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKG7CW53AGX7QQBJWHQWOLU2QZ3JANCNFSM5OCG4SOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub https://github.com/webrcade/webrcade-docs/issues/3#issuecomment-1035632434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVEPCTV6R43UCC25RM7WRDU2RBXPANCNFSM5OCG4SOQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Hi-
I tried it, and everything seems to look correct, what is supposed to be broken?
Thanks,
Chris

On Feb 10, 2022, at 9:32 PM, Emreler1 @.***> wrote:

Hi Chris,
Please see the link of the json file from my Dropbox account.
https://tiny.cc/emreler1 https://tiny.cc/emreler1
Best,
Emre

On 11 Feb 2022, at 02:19, Chris Smith @.***> wrote:
Hmmm.. can you send me the feed to check out?
Thanks!
On Thu, Feb 10, 2022 at 2:12 PM Emreler1 @.***> wrote:

Hi. There may be an issue about category art not showing up in the play
mode but being present in the editor mode.
—
Reply to this email directly, view it on GitHub
https://github.com/webrcade/webrcade-docs/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKG7CW53AGX7QQBJWHQWOLU2QZ3JANCNFSM5OCG4SOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub https://github.com/webrcade/webrcade-docs/issues/3#issuecomment-1035632434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVEPCTV6R43UCC25RM7WRDU2RBXPANCNFSM5OCG4SOQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.

Some of your categories are not appearing in the player because they don’t contain any items. Is that what you are referring to?

On Feb 10, 2022, at 9:49 PM, raz0red @.***> wrote:

Hi-
I tried it, and everything seems to look correct, what is supposed to be broken?
Thanks,
Chris

On Feb 10, 2022, at 9:32 PM, Emreler1 @.***> wrote:

Hi Chris,
Please see the link of the json file from my Dropbox account.
https://tiny.cc/emreler1 https://tiny.cc/emreler1
Best,
Emre

On 11 Feb 2022, at 02:19, Chris Smith @.***> wrote:
Hmmm.. can you send me the feed to check out?
Thanks!
On Thu, Feb 10, 2022 at 2:12 PM Emreler1 @.***> wrote:

Hi. There may be an issue about category art not showing up in the play
mode but being present in the editor mode.
—
Reply to this email directly, view it on GitHub
https://github.com/webrcade/webrcade-docs/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKG7CW53AGX7QQBJWHQWOLU2QZ3JANCNFSM5OCG4SOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub https://github.com/webrcade/webrcade-docs/issues/3#issuecomment-1035632434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVEPCTV6R43UCC25RM7WRDU2RBXPANCNFSM5OCG4SOQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.

Sorry I wasn’t clear enough. The issue is that most of the artwork I linked does not seem to be working. Please see the screenshot attached. Only Atar 7800 and Game Boy have thumbnails showing up. But I linked all the platforms’ thumbnails. Sometimes none of them show up, sometimes just a few.

On 11 Feb 2022, at 08:49, Chris Smith @.***>wrote:
Hi-
I tried it, and everything seems to look correct, what is supposed to be broken?
Thanks,
Chris

On Feb 10, 2022, at 9:32 PM, Emreler1 @.***> wrote:

Hi Chris,
Please see the link of the json file from my Dropbox account.
https://tiny.cc/emreler1 https://tiny.cc/emreler1
Best,
Emre

On 11 Feb 2022, at 02:19, Chris Smith @.***> wrote:
Hmmm.. can you send me the feed to check out?
Thanks!
On Thu, Feb 10, 2022 at 2:12 PM Emreler1 @.***> wrote:

Hi. There may be an issue about category art not showing up in the play
mode but being present in the editor mode.
—
Reply to this email directly, view it on GitHub
https://github.com/webrcade/webrcade-docs/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKG7CW53AGX7QQBJWHQWOLU2QZ3JANCNFSM5OCG4SOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub https://github.com/webrcade/webrcade-docs/issues/3#issuecomment-1035632434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVEPCTV6R43UCC25RM7WRDU2RBXPANCNFSM5OCG4SOQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
—
Reply to this email directly, view it on GitHub https://github.com/webrcade/webrcade-docs/issues/3#issuecomment-1035901966, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVEPCQPENQ62DOEJQWESLDU2SPODANCNFSM5OCG4SOQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Nope. Even the ones that I added roms to are not showing up with a thumbnail. That’s what I meant.

On 11 Feb 2022, at 08:52, Chris Smith @.***> wrote:
Some of your categories are not appearing in the player because they don’t contain any items. Is that what you are referring to?

On Feb 10, 2022, at 9:49 PM, raz0red @.***> wrote:

Hi-
I tried it, and everything seems to look correct, what is supposed to be broken?
Thanks,
Chris

On Feb 10, 2022, at 9:32 PM, Emreler1 @.***> wrote:

Hi Chris,
Please see the link of the json file from my Dropbox account.
https://tiny.cc/emreler1 https://tiny.cc/emreler1
Best,
Emre

On 11 Feb 2022, at 02:19, Chris Smith @.***> wrote:
Hmmm.. can you send me the feed to check out?
Thanks!
On Thu, Feb 10, 2022 at 2:12 PM Emreler1 @.***> wrote:

Hi. There may be an issue about category art not showing up in the play
mode but being present in the editor mode.
—
Reply to this email directly, view it on GitHub
https://github.com/webrcade/webrcade-docs/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKG7CW53AGX7QQBJWHQWOLU2QZ3JANCNFSM5OCG4SOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub https://github.com/webrcade/webrcade-docs/issues/3#issuecomment-1035632434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVEPCTV6R43UCC25RM7WRDU2RBXPANCNFSM5OCG4SOQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
—
Reply to this email directly, view it on GitHub https://github.com/webrcade/webrcade-docs/issues/3#issuecomment-1035903027, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVEPCVJ5VTQ5EOPBWY2DPTU2SPYJANCNFSM5OCG4SOQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Unfortunately, I can't see the screenshot.
But, when I view your feed, all of the thumbnails are always showing
up.Very odd. Are you using a VPN or any other type of network filter?
Thanks,
Chris
On Thu, Feb 10, 2022 at 9:54 PM Emreler1 @.***> wrote:

Sorry I wasn’t clear enough. The issue is that most of the artwork I
linked does not seem to be working. Please see the screenshot attached.
Only Atar 7800 and Game Boy have thumbnails showing up. But I linked all
the platforms’ thumbnails. Sometimes none of them show up, sometimes just a
few.

On 11 Feb 2022, at 08:49, Chris Smith @.***>wrote:
Hi-
I tried it, and everything seems to look correct, what is supposed to be
broken?
Thanks,
Chris

On Feb 10, 2022, at 9:32 PM, Emreler1 @.***> wrote:

Hi Chris,
Please see the link of the json file from my Dropbox account.
https://tiny.cc/emreler1 https://tiny.cc/emreler1
Best,
Emre

On 11 Feb 2022, at 02:19, Chris Smith @.***> wrote:
Hmmm.. can you send me the feed to check out?
Thanks!
On Thu, Feb 10, 2022 at 2:12 PM Emreler1 @.***> wrote:

Hi. There may be an issue about category art not showing up in the
play
mode but being present in the editor mode.
—
Reply to this email directly, view it on GitHub
https://github.com/webrcade/webrcade-docs/issues/3, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABKG7CW53AGX7QQBJWHQWOLU2QZ3JANCNFSM5OCG4SOQ

.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.
You are receiving this because you are subscribed to this
thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub <
https://github.com/webrcade/webrcade-docs/issues/3#issuecomment-1035632434>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AXVEPCTV6R43UCC25RM7WRDU2RBXPANCNFSM5OCG4SOQ
.
Triage notifications on the go with GitHub Mobile for iOS <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

You are receiving this because you authored the thread.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
—
Reply to this email directly, view it on GitHub <
https://github.com/webrcade/webrcade-docs/issues/3#issuecomment-1035901966>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AXVEPCQPENQ62DOEJQWESLDU2SPODANCNFSM5OCG4SOQ
.
Triage notifications on the go with GitHub Mobile for iOS <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

You are receiving this because you authored the thread.

—
Reply to this email directly, view it on GitHub
https://github.com/webrcade/webrcade-docs/issues/3#issuecomment-1035903702,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKG7CSFZ4HLL22I3MTYG4LU2SP7RANCNFSM5OCG4SOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

I experienced the same issue on old ipad, animations on slider causes the issue, removing it solves it. I think it is webkit version issue
if (sliderHidden) {       sliderStyle = {         transform: 'translateY(150%)',         opacity: 0       }     } else {       sliderStyle = {         transform: 'translateY(0%)',         transition: '.8s ease-in-out', <-- this          animation: 'fadein .3s',  <--- and this lines         opacity: 1       }

I experienced the same issue on old ipad, animations on slider causes the issue, removing it solves it. I think it is webkit version issue
if (sliderHidden) { sliderStyle = { transform: 'translateY(150%)', opacity: 0 } } else { sliderStyle = { transform: 'translateY(0%)', transition: '.8s ease-in-out', <-- this animation: 'fadein .3s', <--- and this lines opacity: 1 }
Ofcourse this removes animation on the slider

My issue is gone after I switched from dropbox links for the image files to imgur links. But I always got the impression that when WebRcade is loading the feed it does not tolerate any latency. Anyway, how did you remove the slider animations?

If you are using webrcade locally, you have to rebuild with these two lines commented out
transition: '.8s ease-in-out', animation: 'fadein .3s'
in slider component: src/react/components/slider/index.js

If you are using webrcade locally, you have to rebuild with these two lines commented out
transition: '.8s ease-in-out', animation: 'fadein .3s'
in slider component: src/react/components/slider/index.js

I am completely lost at this. I have no idea how to change any code. I have no coder bone in me :) Thanks any way.


”Rogova”, ”Poroinița” are listed in the drop-down menu

Description:
When user writes ”Rogova”, ”Poroinița” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Rogova"

Expected results
The location appears in the drop-down menu as "Sat Rogova, MEHEDINȚI (Rogova)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Poroinița"

Expected results
The location appears in the drop-down menu as "Sat Poroinița, MEHEDINȚI (Rogova)".


Double click on the single parenthesis to select all content including spaces,instead of just selecting the first content separated by blank space

Type: Feature Request
To select all contents within parentheses by double click on the single parenthesis or click on the position which is before or after the single parenthesis.  In addition to ( ),the same feature should also be applied to ' ' , " " , [ ] , { } etc
VS Code version: Code 1.88.1 (e170252f762678dec6ca2cc69aba1570769a5d39, 2024-04-10T17:41:02.734Z)
OS version: Windows_NT x64 10.0.19045
Modes:

Same as #9123, which remains open and in Backlog but maybe overlooked.


899 updated MembershipInferenceBlackBox#infer to have CUDA support

Signed-off-by: Evan Sakmar<EMAIL_ADDRESS>Description
Added two helper methods to_cuda and from_cuda to assist in moving the tensors to and from CUDA.  Updated the logic to move those tensors when appropriate.
Fixes #899
Type of change
Please check all relevant options.

[ ] Improvement (non-breaking)
[x] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
I ran through each of these steps

Ran through the notebooks/attack_membership_inference.ipynb notebook in a CUDA enable instance and compared it to the results of the notebook run on a CPU only instance.
Ran  the membership inference tests on a CUDA enabled instance and CPU only instance and ensured that all tests passed.

Test Configuration:

OS: Ubuntu 18.04
CUDA: 10.1
Python version: 3.6.9
TensorFlow / Keras / PyTorch / MXNet version: TensorFlow 2.4, Keras 2.4.3 torch 1.6.0+cu92, MXNet 1.6.0

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
#- [ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
#- [ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

I wasn't sure if the to_cuda and from_cuda methods should live in a helper class somewhere else but kept them in the file for now since I didn't see to_cuda used anywhere else in the code base.  I am open to feedback on that.
Also if there is anything else I could improve in it let me know
Thanks
Evan

Codecov Report

Merging #900 (f6d619e) into main (ad42a79) will decrease coverage by 43.86%.
The diff coverage is 14.28%.

@@             Coverage Diff             @@
##             main     #900       +/-   ##
===========================================
- Coverage   64.64%   20.77%   -43.87%
===========================================
  Files         176      176
  Lines       17099    17108        +9
  Branches     3156     3157        +1
===========================================
- Hits        11053     3554     -7499
- Misses       4806    13340     +8534
+ Partials     1240      214     -1026

Impacted Files
Coverage Δ

...ttacks/inference/membership_inference/black_box.py
12.79% <14.28%> (-73.72%)
:arrow_down:

...rt/defences/detector/poison/clustering_analyzer.py
8.22% <0.00%> (-86.71%)
:arrow_down:

...ces/detector/evasion/subsetscanning/scanningops.py
11.59% <0.00%> (-85.51%)
:arrow_down:

art/attacks/evasion/carlini.py
8.40% <0.00%> (-80.87%)
:arrow_down:

...defences/detector/poison/ground_truth_evaluator.py
17.80% <0.00%> (-79.46%)
:arrow_down:

...ient_descent/projected_gradient_descent_pytorch.py
16.93% <0.00%> (-78.23%)
:arrow_down:

...escent/projected_gradient_descent_tensorflow_v2.py
18.33% <0.00%> (-76.67%)
:arrow_down:

art/attacks/evasion/hop_skip_jump.py
13.17% <0.00%> (-75.61%)
:arrow_down:

art/metrics/verification_decisions_trees.py
13.75% <0.00%> (-73.02%)
:arrow_down:

...defences/preprocessor/spatial_smoothing_pytorch.py
13.41% <0.00%> (-70.74%)
:arrow_down:

... and 118 more

Hi @evansakmar Thank you very much for finding bugs and especially for following up with pull requests to fix them, this is very much appreciated. I have changed the target branch from main to dev_1.5.2 to include your updates in this week's 1.5.2 release. Could you please rebase your branch to dev_1.5.2?
Could you please try moving the to_cuda and from_cuda methods to art.utils which is currently the main place for utility methods in ART. This utils file is getting long, so we'll split it soon into specific modules.
I have asked @abigailgold for a review of the changes.

@beat-buesser Yes, I agree with this change, and I agree with your comment that the to_cuda and from_cuda methods should move to art.utils. @evansakmar Please make sure to import them only within: if self.default_model (where the rest of the torch imports are located). Thanks!

Will do
Thank You!

@abigailgold @beat-buesser
I moved those methods to art.utils.  I added the Tensor type to the methods to follow what the other methods do.  Let me know if you want to keep it generic and avoid the from torch import Tensor.
Thanks
Evan

@evansakmar @abigailgold Thank you very much!


[Tabs] Using fragments in Tabs child node breaks functionality

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Functional component child nodes of Tabs wrapped in fragments break functionality. For example, if I have a custom functional component <DynamicTabs /> that returns multiple Tab elements with a fragment root and use <DynamicTabs /> as a child of Tabs, it seems to break the functionality. If I don't use fragments here then I get a TS error for returning an array of elements, and replacing the fragment root with a div or span also does not work:
function DynamicTabs() {
  const arr = [0, 1, 2];
  return (
    <>
      {arr.map((n) => (
        <Tab label={`${n}`} {...a11yProps(n)} />
      ))}
    </>
  );
}

        <Tabs
          value={value}
          onChange={handleChange}
          aria-label="basic tabs example"
        >
          <DynamicTabs /> // can't do this :[
        </Tabs>

Expected behavior 🤔
The expected behavior is that functional components that return an element with a fragment root don't break Tabs functionality when transcluded into <Tabs>.
For a workaround, I could just avoid using a custom functional component and instead do something inline, but I would ideally like to avoid the code below:
<Tabs
  value={value}
  onChange={handleChange}
  aria-label="basic tabs example"
>
    {arr.map((n) => (
       <Tab label={`${n}`} {...a11yProps(n)} />
    ))}
</Tabs>

Steps to reproduce 🕹
codesandbox: https://codesandbox.io/s/basictabs-material-demo-forked-cbze4?file=/demo.tsx:1310-1475
Steps:

Click on the tabs in the codebox browser and you should see that it doesn't work as expected.
Replace the DynamicTabs component with the inline approach above and you should see it working.

Context 🔦
Using fragments should not break the Tab functionality. Using functional components wrapped in fragments works for TabPanel, but not for children of Tabs. This forces me to use the inline method which hurts readability and consistency. This may or may not be related to: https://github.com/mui-org/material-ui/issues/27947
Your environment 🌎

`npx @mui/envinfo`
 Broswer: Chrome Version 96.0.4664.93 (Official Build) (x86_64)
  System:
    OS: macOS 11.3.1
  Binaries:
    Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node
    Yarn: 1.22.5 - ~/.yarn/bin/yarn
    npm: 6.14.12 - ~/.nvm/versions/node/v14.16.1/bin/npm
  Browsers:
    Chrome: 96.0.4664.93
    Edge: Not Found
    Firefox: Not Found
    Safari: 14.1
  npmPackages:
    @emotion/react: ^11.5.0 => 11.5.0
    @emotion/styled: ^11.3.0 => 11.3.0
    @mui/core:  5.0.0-alpha.54
    @mui/icons-material: ^5.1.0 => 5.1.0
    @mui/material: ^5.1.0 => 5.1.0
    @mui/private-theming:  5.1.0
    @mui/styled-engine:  5.1.0
    @mui/system: ^5.1.0 => 5.1.0
    @mui/types:  7.1.0
    @mui/utils:  5.1.0
    @types/react: ^17.0.0 => 17.0.34
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    typescript: ^4.1.2 => 4.4.4

The Tabs component requires Tab components as direct children.
If you'd like to extract the logic of rendering individual tabs, you can create a function (not a functional component) that returns the array: https://codesandbox.io/s/basictabs-material-demo-forked-pi4p3?file=/demo.tsx

@michaldudak this is not working if I want to render some more things in the tab, like icon+text using the component property of Tab. It still makes it a single tab if I use a map to render the data in tabs.

@michaldudak Can you please open this issue again?

Please create a codesandbox showing the issue you're facing.

On stack overflow, I saw to use the component property to add custom text to tabs. But it is not working.
https://codesandbox.io/s/basictabs-material-demo-forked-jewk6u?file=/demo.tsx:951-990

@Nyctophiliac1918 I found that forwarding the ref if you want to use the component property works here's the sandbox.
https://codesandbox.io/s/basictabs-material-demo-forked-0gktsy?file=/demo.tsx

Thank you so much @JacobSickels!

Hi @jacobsickels, I have a slightly similar problem, in this case I would like to create a custom element that returns the tab to remove some of the boilerplate, but I cannot use the custom element, it only works if I call it as a function:
// This works
{CustomTab2()}
// This does not
<CustomTab3 />

https://codesandbox.io/s/basictabs-material-demo-forked-ym2g53?file=/demo.tsx
Do I need to pass the ref in some way?

@manulera I think what you want works if you spread in the props for your CustomTab3
https://codesandbox.io/s/basictabs-material-demo-forked-wg97pd?file=/demo.tsx

@manulera I think what you want works if you spread in the props for your CustomTab3
https://codesandbox.io/s/basictabs-material-demo-forked-wg97pd?file=/demo.tsx

Well that was fast! Thank you so much, it works!


feat: simplify usage using wrapper

#88

Codecov Report

Merging #113 (5e022c4) into main (0952659) will decrease coverage by 2.92%.
The diff coverage is 14.28%.

@@             Coverage Diff             @@
##              main     #113      +/-   ##
===========================================
- Coverage   100.00%   97.07%   -2.93%
===========================================
  Files           15       15
  Lines          200      205       +5
  Branches        46       46
===========================================
- Hits           200      199       -1
- Misses           0        6       +6

Impacted Files
Coverage Δ

packages/graphql-armor/src/apollo/armor.ts
100.00% <ø> (ø)

packages/graphql-armor/src/envelop/armor.ts
62.50% <14.28%> (-37.50%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Bug] Not able to install and run the Purity Ui Dashboard

Version
current
Reproduction link
https://jsfiddle.net/z51snw4u/2/
Operating System
MacOS
Device
iMac 5K
Browser & Version
NoBrowser
Steps to reproduce

git clone https://github.com/creativetimofficial/purity-ui-dashboard.git
npm install
error

What is expected?
installation of Purity UI Dashboard and then starting it by npm start
What is actually happening?
the npm install returns thousands of errors.

Solution
I wish I knew.. The link on jsfiddle leads to my log of the errors. I have clean installation of Homebrew, NVM, Node, everything is brand new. Could you please help point me in the right direction to get this functional? Thank you.
Additional comments

It's probably a problem with NPM. I tried reinstalling the project using the same steps and it seems to work fine. Check for any unnecessary package.json files located inside the folder in which you ran the command. Maybe try downloading the .zip of the project and see if the same thing happens.

Hello, thanks for the info. I did try a few more things but in the end I typed "APM install" instead of "NPM install" by pure accident, it created some node modules directory and it started working.. :D

22. 11. 2021 v 10:25, Simmmple @.***>:
It's probably a problem with NPM. I tried reinstalling the project using the same steps and it seems to work fine. Check for any unnecessary package.json files located inside the folder in which you ran the command. Maybe try downloading the .zip of the project and see if the same thing happens.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/creativetimofficial/purity-ui-dashboard/issues/40#issuecomment-975320710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWTJ74Q43T4U4X2R6R2LWETUNID7HANCNFSM5IPSWLGA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Update inspec-core and win32-taskscheduler to latest

InSpec ships with some nice bugfixes
win32-taskscheduler supports priorities and running on battery
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

This actually breaks win32-taskscheduler so we're going to have to hold off on this


Remove duplicate of DevCouch podcast

Unfortunately there was a duplicate of the DevCouch Podcast in the README.md file. That seemed to have slipped through review.

Hey @mariusbuescher,
thanks for this fix.
I fixed it in https://github.com/EngineeringKiosk/GermanTechPodcasts/pull/101
The way how this repository works is like:

We have the data in yaml files (see /podcasts)
An automation triggers (see GitHub Actions)
The README gets generated with up-to-date data

This is (partially) described in https://github.com/EngineeringKiosk/GermanTechPodcasts/blob/main/CONTRIBUTING.md#format
That is why modifying the README won't work as expected, as it will be overwritten very soon.
I will move on and close this PR - Thanks again for pointing us towards this bug!

Thx for the explanation. I am currently listening to the Engineering Kiosk episode.

@mariusbuescher Awesome. Let us know what you think or if you have any corrections on topics we have said.
Also, if you want to know more, feel free to reach out (e.g., via Email). Happy to answer additional questions.


webpack build breaks aio-lib-ims in runtime actions

Relates to https://github.com/adobe/aio-lib-ims/issues/33
Description
When invoking an action that use the lateset aio-lib-ims and was deployed via aio app deloy (built with webpack) we get the following error:
    "result": {
      "error": "Initialization has failed due to: Error: Cannot find module '/package.json'\n    at webpackEmptyContext (/nodejsAction/ov9Ltpr6/index.js:126097:10)\n    at checkNodeVersion (/nodejsAction/ov9Ltpr6/index.js:52777:43)\n    at Object.<anonymous> (/nodejsAction/ov9Ltpr6/index.js:52783:1)\n    at Object.module.exports.Object.defineProperty.value (/nodejsAction/ov9Ltpr6/index.js:52793:30)\n    at __webpack_require__ (/nodejsAction/ov9Ltpr6/index.js:21:30)\n    at Object.module.exports.webpackEmptyContext.keys (/nodejsAction/ov9Ltpr6/index.js:125795:19)\n    at __webpack_require__ (/nodejsAction/ov9Ltpr6/index.js:21:30)\n    at Object.module.exports.Object.defineProperty.value (/nodejsAction/ov9Ltpr6/index.js:51875:36)\n    at __webpack_require__ (/nodejsAction/ov9Ltpr6/index.js:21:30)\n    at Object.<anonymous> (/nodejsAction/ov9Ltpr6/index.js:49883:17)"
    },

The same error appears if we unzip dist/myaction.zip and import the index.js in a node REPL
Reproduce

aio app init -> select  only actions
npm install @adobe/aio-lib-ims
require the lib in the action
aio app deploy
invoke the action => ERROR

Workaround (partial)
use aio-lib-ims 4.0.1 to access the Ims object, getToken won't work because of https://github.com/adobe/aio-lib-ims/issues/33
What causes the error
In https://github.com/adobe/aio-lib-ims/compare/4.0.1...4.1.0#diff-d8c50dc3673a2b383c6c1a0a0c19799fR17-R19, removing the import to const imsCliPlugin = require('@adobe/aio-lib-ims-oauth/src/ims-cli') and const imsOAuthPlugin = require('@adobe/aio-lib-ims-oauth') fixes the problem

cc @shazron

Is there an ETA on when this will be released?

@davidjgonzalez , we are currently prioritizing the issues and enhancement requests that are open.
Could you provide more input about your use case? Thanks!

Update: After an offline conversation with @meryllblanchet (thank you for explaining!)  -- So, no ETA required for me anymore :)
It is against Adobe Firefly (which is my use-case) best practices to have the runtime action obtain the Adobe IO Access Token.
Instead, I need to have the service that INVOKES my Firefly app (Runtime action) to obtain/keep-fresh the Adobe IO access token, and PASS it to my Firefly app, for use within my action!
You can read on this pattern at: https://github.com/AdobeDocs/project-firefly/blob/master/guides/security_overview.md

Thanks for the great summary and discussion @davidjgonzalez ! On our side we are evaluating options to fix this issue and will provide an update soon.
cc @sandeep-paliwal @shazron

We should be able to address this issue by having a different webpack builds (one for CLI and one for deployed action).
Refer to https://webpack.js.org/plugins/define-plugin/#root for more details.
Right now aio-app-scripts and aio-cli-plugin-app repos which will get impacted by the fix are going through refactoring. So will wait for these changes to be made before implementing the suggested fix.

Update: After an offline conversation with @meryllblanchet (thank you for explaining!) -- So, no ETA required for me anymore :)
It is against Adobe Firefly (which is my use-case) best practices to have the runtime action obtain the Adobe IO Access Token.
Instead, I need to have the service that INVOKES my Firefly app (Runtime action) to obtain/keep-fresh the Adobe IO access token, and PASS it to my Firefly app, for use within my action!
You can read on this pattern at: https://github.com/AdobeDocs/project-firefly/blob/master/guides/security_overview.md

@davidjgonzalez our use case where we need the action to generate the access token is triggered by whisk/alarms package. as far as I know I can't pass any access token to the action - means I need some solution to generate the access token on tuntime.
since the action is not exposed to web/UI I think there should not be any security risks.

@UrsBoller thanks for the feedback about your use-case! In both SPA and headless scenarios, the application should not bake the token for its own usage, as documented in the guidelines above.
We'll follow-up to give you the most appropriate recommendation in order to enable your use-case.
cc @sarahxxu

@meryllblanchet the problem is that my headless action get's triggered only by whisk/alarms. I just need a way to access adobe products (especially adobe analytics) somehow - sontrying to figure out a way to get a valid token ... happy to hear any possible solution apart from using auo-lib-ims...

@UrsBoller we will sync-up with @duynguyen to review the app solution design and provide the appropriate recommendations.
About this issue itself: we are wrapping up the preliminary Runtime / App plugins refactoring this week (to follow here: https://github.com/adobe/aio-cli-plugin-runtime/issues/191).
We will then be able to work towards a resolution.

Added PR to fix this - https://github.com/adobe/aio-lib-ims/pull/56

Same issue here. (And yes I know it should not be used that way, but I have a temporary special case.)
Workaround: use patch-package with this patch file in<EMAIL_ADDRESS>diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 2206a58..12b0019 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -14,9 +14,9 @@ const { Ims, ACCESS_TOKEN, REFRESH_TOKEN } = require('./ims')
 const debug = require('debug')('@adobe/aio-lib-ims/token-helper')
 const { getContext } = require('./context')

-const imsCliPlugin = require('@adobe/aio-lib-ims-oauth/src/ims-cli')
+const imsCliPlugin = undefined
 const imsJwtPlugin = require('@adobe/aio-lib-ims-jwt')
-const imsOAuthPlugin = require('@adobe/aio-lib-ims-oauth')
+const imsOAuthPlugin = undefined

 /**
  * This is the default list of NPM packages used as plugins to create tokens

Thanks @moritzraho's hint in the OP.

We expect to release the fix within the next two weeks - see #56.


Version 2.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

63 of 64 (98.44%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.2%) to 98.701%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/LarabankerServiceProvider.php
48
49
97.96%

Totals

Change from base Build 757328804:
1.2%

Covered Lines:
76

Relevant Lines:
77

💛  - Coveralls


[Bug] Nightly test failed: RuntimeError: Cannot import pyspark unwrap_udt function

Detailed log as below:
spark-rapids-ml_nightly/312;  spark-rapids-ml_nightly/313
 WARNING: Spark Param 'family' is not used by cuML.
 stopping spark session
 Traceback (most recent call last):
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/src/spark_rapids_ml/utils.py", line 478, in _get_unwrap_udt_fn
     from pyspark.databricks.sql.functions import unwrap_udt as databricks_unwrap_udt
 ModuleNotFoundError: No module named 'pyspark.databricks'

 The above exception was the direct cause of the following exception:

 Traceback (most recent call last):
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/./benchmark/benchmark_runner.py", line 83, in <module>
     BenchmarkRunner().run()
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/./benchmark/benchmark_runner.py", line 67, in run
     self._runner.run()
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/benchmark/benchmark/base.py", line 241, in run
     benchmark_results, benchmark_time = with_benchmark(
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/benchmark/benchmark/utils.py", line 44, in with_benchmark
     result = action()
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/benchmark/benchmark/base.py", line 243, in <lambda>
     lambda: self.run_once(
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/benchmark/benchmark/bench_logistic_regression.py", line 81, in run_once
     model, fit_time = with_benchmark(benchmark_string, lambda: lr.fit(train_df))
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/benchmark/benchmark/utils.py", line 44, in with_benchmark
     result = action()
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/benchmark/benchmark/bench_logistic_regression.py", line 81, in <lambda>
     model, fit_time = with_benchmark(benchmark_string, lambda: lr.fit(train_df))
   File "/root/miniconda3/lib/python3.9/site-packages/pyspark/ml/base.py", line 205, in fit
     return self._fit(dataset)
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/src/spark_rapids_ml/core.py", line 1036, in _fit
     return self._fit_internal(dataset, None)[0]
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/src/spark_rapids_ml/core.py", line 1000, in _fit_internal
     pipelined_rdd = self._call_cuml_fit_func(
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/src/spark_rapids_ml/core.py", line 638, in _call_cuml_fit_func
     select_cols, multi_col_names, dimension, _ = self._pre_process_data(dataset)
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/src/spark_rapids_ml/classification.py", line 1131, in _pre_process_data
     ) = super()._pre_process_data(dataset)
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/src/spark_rapids_ml/core.py", line 1088, in _pre_process_data
     ) = super()._pre_process_data(dataset)
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/src/spark_rapids_ml/core.py", line 501, in _pre_process_data
     select_cols += _get_unwrapped_vec_cols(col(input_col))
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/src/spark_rapids_ml/core.py", line 161, in _get_unwrapped_vec_cols
     unwrap_udt = _get_unwrap_udt_fn()
   File "/home/jenkins/agent/workspace/jenkins-spark-rapids-ml_nightly-313/python/src/spark_rapids_ml/utils.py", line 482, in _get_unwrap_udt_fn
     raise RuntimeError(
 RuntimeError: Cannot import pyspark `unwrap_udt` function. Please install pyspark>=3.4 or run on Databricks Runtime.
script returned exit code 1

Looks like this issue was reported among the recent commits: from bd7676a  to    a969849

This has been fixed. Please check. @NvTimLiu


Add support to include ingest delay to pulled metrics

While debugging this issue https://github.com/prometheus-community/stackdriver_exporter/issues/123 I found out that GCP Cloud Monitoring metrics might suffer from ingestion delay.
This PR adds support to include the ingest delay for each metric before pull it from Cloud Monitoring.

@SuperQ can you review this PR please ?

How can we progress this PR?

@SuperQ did you get a chance to look at this PR?

@SuperQ all green now.


Cannot convert value of type '(CMDeviceMotion!, NSError!) -> Void' to expected argument type 'CMDeviceMotionHandler' (aka '(Optional, Optional) -> ()')

Hi,
When I run the project in Swift 2.1, I get this error. Can you help me on this matter?

Cannot convert value of type '(CMDeviceMotion!, NSError!) -> Void' to expected argument type 'CMDeviceMotionHandler' (aka '(Optional, Optional) -> ()')

self.motionManager.startDeviceMotionUpdatesToQueue(NSOperationQueue.mainQueue(),
    withHandler: { (motion: CMDeviceMotion!, error: NSError!) -> Void in  // Error here
        self.calculateRotationBasedOnDeviceMotionRotationRate(motion)
    })

Hi @melihkeskin,
Thanks for bringing this to my attention. Could you please try again with the latest commit to master?

Hi again,
Thanks for your help.It worked well.
But :)
if the device orientation is lansdscape,
there is disturbance in the image size.it is not cover the screen.
this state is enough for me.
I wanted to just warn you about it.
Thanks for sharing

@melihkeskin Thanks for the heads up. I'll open an issue to look into it when I get a chance.

See #3


change join -> login handlers for slack link

as a side effect, if you are banned, without a slack account linked, it now shows the slack link message instead of the ban message

all good!


Resource for a11y color contrast validation

https://webaim.org/resources/contrastchecker/

### Tasks
- [ ] Bring proposal to Paragon Working Group.
- [ ] Either link to existing tool as shown above from new "Accessibility" foundation page, and/or implement custom similar tool as docs site page.
- [ ] Refer to prior PWG meeting agenda notes from Jeff/Matthew about the content for standalone "Accessibility" foundation page.

PR: https://github.com/openedx/paragon/pull/2726

UPD:

from the PWG there is a decision to put Contrast checker under the Tools item and make the link for the https://webaim.org/resources/contrastchecker


[BugFix] median filter the right pose

Line 17, 18 seems to be wrong. after the correction:
 p[:, m, n] = medfilt(p[:, m, n], 3)
 p_new[:, m, n] = inter.zoom(p[:, m, n], target_l / l)[:target_l]

we are doing median filtering them zoom it to processed pose p_new

hello YLTsai0609, thanks very much for your help!


Failed to load stable.art when not connected to the internet

I want to use my own, local instance of stable-diffusion with AUTOMATIC1111's webui as the backend, I've already set the --api parameter, but the plugin fails to load if I'm not connected to the internet. Why?
I'm assuming this is a bug since it wouldn't make sense to need to be online if I'm going to connect to a local instance (<IP_ADDRESS>:7860 being the default for AUTOMATIC1111's webui). Otherwise the plugin works as expected.

Duplicate #12
I plan to add an offline mod after fixing the major bugs and adding outpainting.


Smooth scroll

Smooth scrolling transition when clicked on the data items of the nav bar

Assign me the task

Check issue .no 16 there is already one same there


[HOLD for payment 2023-08-28] [$1000]  Triple clicking text and copying to clipboard results in text copied containing button text

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

From user A, go to the chat with user B
From user B, send a message
From user A, Flag the message as violating
Click triple to the hidden message
Click the right pointer to open the context menu > Choose Copy to clipboard
Past this into the composer and notice the message copied

Expected Result:
The message copied shouldn't contain reveal button text
Actual Result:
The message copied contains reveal button text
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.50-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/54971522-664f-40db-be33-a69d8cf23621
https://github.com/Expensify/App/assets/43996225/d98c3e3f-c589-4442-85d6-9454babcf279
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690886867471159
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012ab20f2847f765d5
Upwork Job ID:<PHONE_NUMBER>431098368
Last Price Increase: 2023-08-07
Automatic offers:

bernhardoj | Contributor | 26116127
dukenv0307 | Reporter | 26116129

Proposal
Please re-state the problem that we are trying to solve in this issue.
The issue is that when triple-clicking a hidden message and copying it to the clipboard, the copied text includes parts of the message that are not intended to be copied.
What is the root cause of that problem?
The issue occurs because of how the text selection is currently handled in the code. It's set to copy the selected portion of the HTML content, which may include unwanted text, such as part of a button label or other UI elements.
What changes do you think we should make in order to solve the problem?
To fix this, we need to modify how the selection is handled. Specifically, we should ensure that only the user-generated message text can be selected, not any additional UI text or elements. Based on preference, candition can be modified like
const content = messageHtml;

Proposal
Please re-state the problem that we are trying to solve in this issue.
Triple click to text and copy to clipborad the text copied contains button text
What is the root cause of that problem?

The <Text /> element is missing the selectable prop.
The SelectionScraper returns a new string from the DOM. In this case we could remove the unwanted elements i.e. 'Hide messages' < Text/>

What changes do you think we should make in order to solve the problem?

Add selectable prop to <Text />
// Text.js
const propTypes = {
    // ...

    /** Should we make this selectable */
    selectable: PropTypes.boolean,
};

const defaultProps = {
    // ...
    selectable: true,
};

// ReportActionItem.js
<Text
  style={styles.buttonSmallText}
  selectable={false}
>
  {isHidden ? props.translate('moderation.revealMessage') : props.translate('moderation.hideMessage')}
</Text>

The getCurrentSelection method in SelectionScraper could receive an option to ignore the selectable===false elements.
In the replaceNodes we can remove these nodes
https://github.com/Expensify/App/blob/28f4fc2637d788b96d85cffb02ac4e9fc1b06071/src/libs/SelectionScraper/index.js#L103
What alternative solutions did you explore? (Optional)
/-

Proposal
Please re-state the problem that we are trying to solve in this issue.
When selecting a reported message that has been hidden, the "Reveal Message" text and any emoji reactions are also getting copied.
What is the root cause of that problem?
Since the error is also reproducible when using Ctrl + C, I was able to rule out anything to do with the Copy action inside the Context Menu.
This code overloads the Ctrl + C shortcut and uses the SelectionScraper to fill the clipboard.
https://github.com/Expensify/App/blob/aa5483daf23483b024f108f31764a1acef106dd2/src/hooks/useCopySelectionHelper.js#L9
And after extensive digging into the code, I believe this line is the problem:
https://github.com/Expensify/App/blob/aa5483daf23483b024f108f31764a1acef106dd2/src/libs/SelectionScraper/index.js#L86
The SelectionScraper eliminates the data-selection-scrapper-hidden-element="true" items, but this is true only on hover. I still need to find where else is the true and false being manipulated. In the React code, it is manipulated by the following code, but I need to follow the chain to see where it is initially set and why:
https://github.com/Expensify/App/blob/09f6b6b00ecbee279f8988b92dd81abeb56416d1/src/pages/home/report/ContextMenu/MiniReportActionContextMenu/index.js#L27
The initial implementation of UnreadMessageAction is probably the root cause of where this problem first showed up.
What changes do you think we should make in order to solve the problem?
A simple and quick bug fix will be to remove data-selection-scrapper-hidden-element elements irrespective of whether it is true or false. But that will lead to unnecessary side effects, as happened with #17838 and #18343.
A long-term solution is to identify where the selection-scrapper-hidden-element is being added, why and what all code is manipulating it. A catch-all removal is not a sufficient solution.
What alternative solutions did you explore? (Optional)
I looked at all the Context Menu code, the ExpensiMark code and the parsing code. Since the error was exactly reproducible when using the keyboard shortcut, it meant the context menu code was not the issue.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/swakeertjain

Proposal from @bernhardoj looks good to me https://github.com/Expensify/App/issues/24156#issuecomment-1665566147 - we already have the same fixes for other situations which are closely to this one. Let's fix it in the same manner
🎀 👀 🎀 C+ reviewed

Proposal from @bernhardoj looks good to me #24156 (comment) - we already have the same fixes for other situations which are closely to this one. Let's fix it in the same manner 🎀 👀 🎀 C+ reviewed

@narefyev91 Pardon me if this seems naive or if I'm asking something obvious. The issue arises when you select text and then copy it by right-clicking; it copies the selection instead of the original hidden message. The expected result is that it should copy the user's message. Hence, I suggested we prioritize copying the user's message, or if preferred, only do so in flagged cases. If I understand correctly, @bernhardoj suggests that users shouldn't be able to select text at all. So, is that what you're proposing: to prevent users from selecting text in the first place?

@bernhardoj did you try using ctrl+C to copy? It is still copying the same text. I have checked everything and am convinced this is not a browser bug nor an issue with user-select. It happens even when my mouse goes nowhere near the reveal message button.
It is an issue with the selection function and what it decided to omit.
dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}} This is a good fix, but we can keep applying it to every component, every time there is a select, non select disparity and we should respect the user-select CSS in the selection function.

bump @jasperhuangg

@bernhardoj I see. It does make sense. I tried console.log(window.getSelection().toString()) and it is indeed selecting the "Reveal message" and "Hide message" text and emojis. The "Hide message" is being deleted by getCurrentSelection method.
But I am not sure if setting a "data-selection-scrapper... =true" attribute and then reading it is the best solution. Shouldn't we respect the CSS? For a more future-proof solution, inside the SelectionScraper.getCurrentSelection function, we should remove all the elements where the CSS property user-select: "none"?
This way anybody using user-select: none in the future can be sure to assume it is not copied.

Oh sorry. I’ll have a look.
On Fri, 11 Aug 2023 at 19:51, Bernhard Owen Josephus <
@.***> wrote:

@swakeert https://github.com/swakeert we did that initially, but gets
reverted. You can read the discussion on the PR that I linked in my
previous comment to understand why.
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/24156#issuecomment-1674873828,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCJXZTBCEYC3HBPROHF3HLXUY5XDANCNFSM6AAAAAA3EDTWFA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@bernhardoj After giving more thought to it, I feel your approach does make sense. Let me know if you want me to raise a PR for it? Seems like this is long overdue.

friendly bump @jasperhuangg

Apologies for the delay! I agree that we should go with @bernhardoj's solution, it seems like it closely mirrors solutions we have implemented for this problem in other places.

The PR that introduced the bug has been identified. Link to the PR: No PR caused regression. This issue always existed as this is the default behavior of browser selection & copy to clipboard.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug - no needs any tests in case it's not a regression

Thanks @narefyev91 - today is payment date so working through that now.

Issue Participants:
Issue reported by: @dukenv0307
Contributor: @bernhardoj
C+: @narefyev91
Was this issue merged in time to be eligible for the speed bonus? Yes
Were their any regressions? No
Payment summary:
Reporter: $250
Contributor: $1500
C+: $1500

Payments made, checklist complete. Closing.


Does not start on cronjob

Hello,
I've created an automatic rule in order to change the color of a task with nightly cronjob once it's expired.
Previously I tested the plugin using a different event (move column),  then when I was confident it worked, I changed the event to CRON and created the automatic action in my project configuration.
When I lauch the cronjob, I get:
Automatic Action Not Found: \Kanboard\Plugin\AutomaticAction\Action\TaskAssignColorOnDueDate
I think I maybe did not initialize it properly ?
Please advice, plugin attached, thank you
Julien
AutomaticAction[1].zip

HI Julien,
I seem to get the same error when executing the cronjob on a windows + apache setup.
I have moved the automatic action and included it in the app (app/actions and related updates) but now the error moves to the next custom Plugin I have installed.
Did you find out what was wrong with this error?
Thanks
Bruno

Sorry I was not able to solve it, so I decided to migrate the code to make an action


[WebSocket] Fix Web write mode, debugger.

In this PR:

Fix Web write mode. (was incorrectly using text for binary and binary for text).
Fix debugger implementation (now also registers itself without the need for the platform to do it),

Thanks!


Question: ArkUI related API support

Are ArkUI related bindings within the scope of this repo? Or an isolated repo is needed (maybe sth like ohos-arkui )?

In principle all native components from the OH SDK are in scope of this repository.
To keep the crate-size of ohos-sys on crates.io reasonable, I think arkui should also be an inidividual crate (similar to drawing, which is also it's own crate in this repository, and additionally re-exported by ohos-sys)

Make sense.


Make sure that results are corrects

At the moment they're not. The test test_synthetic_4d_easy_non_gaussian for example works fine in KK1 but not in KK2.
From extensive testing, I'm pretty confident that the following are correct (there are slight differences to KK1 but that's because of switching to a sparse algorithm):

Loading data
Mask starts
M-step (weights, cluster means, covariance matrices)
Cholesky (verified with several tests)
TriSolve (verified with tests)
InvCovDiag (verified to be the diagonal of the inverse of the covariance matrix)

We should have unit tests for simple cases where the results are well-known
(or test that they are similar enough to a known good clustering...)
On Tue, May 5, 2015 at 1:00 AM, Dan Goodman<EMAIL_ADDRESS>wrote:

At the moment they're not. The test test_synthetic_4d_easy_non_gaussian
for example works fine in KK1 but not in KK2.
From extensive testing, I'm pretty confident that the following are
correct (there are slight differences to KK1 but that's because of
switching to a sparse algorithm):

Loading data
Mask starts
M-step (weights, cluster means, covariance matrices)
Cholesky (verified with several tests)
TriSolve (verified with tests)
InvCovDiag (verified to be the diagonal of the inverse of the
covariance matrix)

—
Reply to this email directly or view it on GitHub
https://github.com/klusta-team/klustakwik2/issues/17.

Yep, that's the idea of tests/test_synthetic_data.py. I'm using the one that doesn't pass to debug.

I'm just linking to the test in question to make things easier to find:
https://github.com/klusta-team/klustakwik2/blob/master/klustakwik2/tests/test_synthetic_data.py#L130-L149

Clearly this is not an early morning lab...

Almost not
Le mardi 5 mai 2015, Dan Goodman<EMAIL_ADDRESS>a écrit :

Clearly this is not an early morning lab...
—
Reply to this email directly or view it on GitHub
https://github.com/klusta-team/klustakwik2/issues/17#issuecomment-98894126
.

OK found a fairly major bug and fixed it. The results were being returned in a somewhat random order. It's still not behaving the same as KK1 but this is a big step in sorting out the problem!
So far, it seems as though the E-step is giving more or less the same results as KK1. Some slight differences are to be expected, but it seems pretty much consistent (e.g. chol matrix is within 0.1% of the value in KK1, etc.).
It could be the case that splitting is not working correctly.

OK with the latest changes it seems as though the problems might be solved. Needs to be run on some real data now.

From the data we've looked at so far, it seems as though KK2 is performing as well if not better than KK1, and so I'm going to close this issue now and we can open new issues for specific bugs.


Cannot find module artificat from remote maven repository

I am trying to resolve dependencies from the vaadin prerelases maven repositories with:
./ceylonb  compile --rep https://maven.vaadin.com/vaadin-prereleases --verbose test

I always receive the following error:
source/test/module.ceylon:3: error: cannot find module artifact 'maven:com.vaadin:vaadin-core-10.0.0.beta8(.car|.jar)'
	import maven:com.vaadin:"vaadin-core" "10.0.0.beta8";
	^
  	- dependency tree: 'test/1.0.0' -> 'com.vaadin:vaadin-core/10.0.0.beta8'

I tried adding the repo to the m2 settings.xml, but that does not work either. The attachment is a simple project (exported from eclipse) with one module that only contains a single dependency on the vaadin repository. Running the above command should reproduce the error.
cannot_find_module_artifact.zip

@fvclaus You can't just supply a Maven repo using --rep. You have to specify it in a Maven settings.xml file.
You can find more information here.

P.S. If you have further questions, please try gitter or stackoverflow. Thanks.


Use GitHub actions for test and release

As now the repo is public, we can use GitHub actions (https://github.com/features/actions) for

Test (Pre-commit check, unit-test, integration-test)
Documentation build (RTD)
Release to pip
Release to docker hub

Done : Test (Pre-commit check, unit-test, integration-test) >> the test need to be improved
Documentation build (RTD)
Done : Release to pip
Release to docker hub


cmd/go: 'go test' with --list flag does not respect --tags

What version of Go are you using (go version)?

$ go version
go version go1.12 darwin/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/evanlinjin/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/evanlinjin/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.12/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.12/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/evanlinjin/GolandProjects/skywire/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/by/x6wf0dg96xjg067sk903rnjw0000gn/T/go-build639156632=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
$ git clone `https://github.com/evanlinjin/gotestlisttags.git`
$ go test --tags="not_ignored" --list="Test" .

What did you expect to see?
➜  gotestlisttags git:(master) ✗ go test --tags="not_ignored" --list="Test" .
TestShouldNotBeIgnored
ok      gotestlisttags  0.006s

What did you see instead?
➜  gotestlisttags git:(master) ✗ go test --tags="not_ignored" --list="Test" .
TestShouldBeIgnored
TestShouldNotBeIgnored
ok      gotestlisttags  0.006s

CC @jayconrod

For small examples like this one, please include the code listing directly in the issue, not just a link to a repo. Our first-level triage is done by reading the issue, not running things on the command line. Thanks.


Adding yaml converter to nlu convert

Proposed changes:

fix bug where a nlu schema couldn't be converted to yaml format when using the flag --format
closes #10675

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @SamuelNoB and thanks for your contribution 🙏🏻  It appears that the issue you tried to solve is now closed, and the developer didn't realise that you had a fix ready (here is their PR). I'll close your PR now as it is no longer needed. Apologies for the misunderstanding


build: add py39, py310, py311

general open source advice: don't touch infrastructure in projects you don't own

general open source advice: don't touch infrastructure in projects you don't own

okay?? that sounds weird, is it?


Remove research environment

What does this pull request do?
Remove deployment to research environment
A separate delete PR will be needed for cloud-platform-environments (does not block):

https://github.com/ministryofjustice/cloud-platform-environments/pull/6256

Related:

https://github.com/ministryofjustice/hmpps-interventions-service/pull/713

What is the intent behind these changes?
The team decided we no longer need it
https://mojdt.slack.com/archives/C02GXCWF23H/p1637758824252400
User researcher:
voted yes with emoji to delete the env

I don’t find it so useful anymore, now that we use mostly prototypes
or the live service with probation practitioners and service
providers.

Product manager:
voted yes with emoji to delete the env

 ❗Need to migrate dev/research env to EKS cluster in Cloud Platform


Make TLS verification configurable

As reported in Matrix:
Dec 31 13:03:11 furby ovos-dinkum-listener[2623]: 2023-12-31 13:03:11.961 - voice - ovos_stt_plugin_server:execute:32 - ERROR - HTTPSConnectionPool(host='ovos-stt-server.dc', port=443): Max retries exceeded with url: /stt?lang=en-us (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:992)')))

The verification process (basically setting requests verify=true) should default to true, but be exposed as a configuration option, with a warning to users that setting it to false is insecure. A second iteration might include links to how to fix this issue in a more secure way.

https://github.com/OpenVoiceOS/ovos-tts-server-plugin/blob/ae866d7264a5794e6adc664504b58655ddcda7fb/ovos_tts_plugin_server/__init__.py#L45


Provide a way to debug explicit CPU fallback

@fengyuan14 - The commit https://github.com/intel/torch-xpu-ops/commit/5bf9e0cc768f7a3b13d829118683275f324399f1 muted debug logs of "explicit" CPU fallbacks. This complicated debug for 3d party contributors trying to evaluate XPU backend capabilities - now I am forced to revert noted commit to understand which operations are not currently implemented by XPU. Please:

Explain what "explicit CPU fallback" means - this seems to be internal to xpu team classification which is unclear and confusing
Extend PYTORCH_DEBUG_XPU_FALLBACK=1 to track any CPU fallback happening in XPU backend. Note: I am fine if "explicit" fallback will be muted by default, but I really need a way to be able to track it.

commit 5bf9e0cc768f7a3b13d829118683275f324399f1 (origin/meng_max_2d)
Author: Feng Yuan<EMAIL_ADDRESS>Date:   Mon Apr 29 13:05:51 2024 +0800

    Register operator's implementation lazily. (#177)

    1. Avoid dangling operator's implementation (m.impl(torchvision::nms) is
    ahead of `import torchvision` sometime)
    2. Mute debug log of explicit CPU fallback.
    3. Add torchvision.roi_align/_roi_align_backward example case

CC: @jgong5 @mingfeima @XiaobingSuper @ashokei @jingxu10 @gujinghui @EikanWang @fengyuan14 @guangyey

Also filed https://github.com/pytorch/pytorch/issues/126488 for visibility at pytorch level.

Thanks for your feedback. Replied in https://github.com/pytorch/pytorch/issues/126488.


[Feature request] Upgrade to full cli version

Would it be possible to upgrade to a full cli version? This would also have the advantage of having a dummy app  where you could run the examples as in the simple-auth examples.

see simplabs/ember-simple-auth#522

Ah nice:)

Closing as is in pipeline from original lib.

@marcoow so currently we have to include the script like this before we can use the mixins and authenticators in a cli-app?
<script src="bower_components/ember-simple-auth/simple-auth.js"></script>

No, you install this Ember CLI Addon as described here.

thanks, thats what I done before, but didn't realise it was merged in to vendor.


handle QC of sera

This is a more long-term issue discussion, @anloes @ckikawa.
Right now this pipeline has QC filters, and all exclusions are entered manually in config.yml. You can see a mini-example in the config for testing for the pipeline here and a real example in the config.yml of  https://github.com/jbloomlab/flu_seqneut_DRIVE_2021-22_repeat_vax (or will be able to, once @anloes has merged this pull request).
We should start evaluating the causes of the failures and how to handle them. Perhaps we want to eventually automate some of the exclusions, but we do not want to do this prematurely because we want to really be forced to look at failures and understand the causes. Also, we want a clear record of anything excluded and why. Briefly, there are three main causes of failures:

Experimental issues themselves: the experiments are imperfect and we always expect some failures. But looking at the real analysis in https://github.com/jbloomlab/flu_seqneut_DRIVE_2021-22_repeat_vax, most of the failures seem to be in a few plates (eg, 3, 5, 12) that probably have some sort of experimental issues. Hopefully iterative analyses of these can gradually help improve experiments so we just have fewer QC failures. We could also imagine eventually just having a criteria to entirely reject problematic plates.
Problems with neutcurve fitting. In my examination of the data, there are a few examples where the data seemed fine but neutcurve just didn't fit it correctly. As you identify examples of those, please open issues on neutcurve with the exact data to reproduce the issues and I can try to improve the underlying fitting algorithm.
Other issues: even when the plates mostly work, some replicates might have occasional QC issues. For now we can exclude those in config manually, but if we get to point of having a good understanding we could automate this, although hopefully they will be rare enough that we can keep the manual approach.

Anyway, let's use this issue to track conversation of these, and open new issues if we identify specific things to fix.

I have made a new version of the pipeline (2.0.0) that substantially changes how the filtering is done based on the comments from @anloes. This new version is not backward incompatible, as I changed many things. The configuration file is substantially different, as explained in the README. Key changes are:

Uses newer version of neutcurve that has some improvements. Ths most important of these are:

Fitting is now done by first fitting with fixed slope and then optimizing slope along with other parameters. This basically avoids the spurious looking curve fits we would sometimes get before at least so far as I have seen on real data so far.
For the curve fits, the coefficient of determination ($R^2$) is reported. This provides a measure of how well the curve fits the data. A perfect is 1.0. Based on some limited manual examination of curves, I think as long as the coefficient of determination is in the 0.6 to 0.7 range, it probably tends to indicate decent fits. When it gets worse than that, there tends to be something wrong. This can help automate QC.
Makes it easier to use the midpoint in place of the IC50 by reporting bounds on that.

Mostly automates the QC. You now set filters and the pipeline automatically removes data that fails the filter. You can then change the filters, add manual drops, or override the filter. But whereas before everything was manual, now the pipeline at least tries to do reasonable QC on its own.

Filtering at a more fine-grained level. Whereas before barcodes were dropped for the whole plate, now when appropriate they may be dropped for just one well, or just one serum-replicate, etc.

Better reporting of QC drops. For all data dropped automatically by the pipeline, that data point is shown along with explanation of why it is dropped before the pipeline removes it.

A new notebook added to docs that summarizes the QC drops.

The pipeline now should run to completion with default QC, and then you can adjust it. This is easier than old process of pipeline failing until you had fixed all QC.

I have made a new version of the pipeline (2.0.0) that substantially changes how the filtering is done based on the comments from @anloes. This new version is not backward incompatible, as I changed many things. The configuration file is substantially different, as explained in the README. Key changes are:

Uses newer version of neutcurve that has some improvements. Ths most important of these are:

Fitting is now done by first fitting with fixed slope and then optimizing slope along with other parameters. This basically avoids the spurious looking curve fits we would sometimes get before at least so far as I have seen on real data so far.
For the curve fits, the coefficient of determination ($R^2$) is reported. This provides a measure of how well the curve fits the data. A perfect is 1.0. Based on some limited manual examination of curves, I think as long as the coefficient of determination is in the 0.6 to 0.7 range, it probably tends to indicate decent fits. When it gets worse than that, there tends to be something wrong. This can help automate QC.
Makes it easier to use the midpoint in place of the IC50 by reporting bounds on that.

Mostly automates the QC. You now set filters and the pipeline automatically removes data that fails the filter. You can then change the filters, add manual drops, or override the filter. But whereas before everything was manual, now the pipeline at least tries to do reasonable QC on its own.

Filtering at a more fine-grained level. Whereas before barcodes were dropped for the whole plate, now when appropriate they may be dropped for just one well, or just one serum-replicate, etc.

Better reporting of QC drops. For all data dropped automatically by the pipeline, that data point is shown along with explanation of why it is dropped before the pipeline removes it.

A new notebook added to docs that summarizes the QC drops.

The pipeline now should run to completion with default QC, and then you can adjust it. This is easier than old process of pipeline failing until you had fixed all QC.

I'm closing this for now as I think it is addressed?


[WFLY-14846] Integration test and documentation for automatic registration of client side / JVM wide default SSLContext

https://issues.redhat.com/browse/WFLY-14846
Add integration test for Elytron client default SSLContext provider.
Requires: ELY-2112 : https://github.com/wildfly-security/wildfly-elytron/pull/1509

Hi @Skyllarr - I've dropped some comments about this integration test. Let me know what you think.
BTW I can see that most of the CI checks are failing. Is this due to some environment issue?

CI is failing because the elytron changes that add the ElytronClientDefaultSSLContextProvider were not merged and tagged yet. This is written in the PR description that ELY-2112 is required.

@fabiobrz Thank you for review. I updated this PR based on your feedback.

Hi @Skyllarr - I've dropped some comments about this integration test. Let me know what you think.
BTW I can see that most of the CI checks are failing. Is this due to some environment issue?

CI is failing because the elytron changes that add the ElytronClientDefaultSSLContextProvider were not merged and tagged yet. This is written in the PR description that ELY-2112 is required.

Oh yes, you're right, sorry for the noise.

@fjuma @fabiobrz I added usage of SSLContext. But as @fjuma pointed out, if there is any issue with this test I can update after pre-check as well.

HI @Skyllarr - left a couple of comments on this new test.
The most important one is about the way the server is implemented.
Let me know what you think.

@fabiobrz Thanks for review! I changed this to use Arquillian container

@Skyllarr I think it would be good to include the documentation commit from https://github.com/wildfly/wildfly/pull/14335 as a separate commit in this PR and then we can close https://github.com/wildfly/wildfly/pull/14335 so that all the WildFly related changes are in one PR.

/retest


Remove CVMFS fix

Removes the  template.  Ensure it is no longer needed before mergin.  Mutually exlusive with #440.  Closes #439

Closing this since #440 was merged.

I didn't realize this was made in parallel, but we will need to verify that things work without the fix, and then close or not?

Yeah, it was meant to be one or the other, but we can leave this open until we determine if the fix is still needed.

No longer needed because it was fixed upstream.


Documentation update: relevant account display and custom editor

Adding these because these are not easy to "discover" simply by looking at the web
interface.

Thanks!


[0.9.3] panic, above high water mark

Hi I am trying to start up influx on top of an existing data directory, but I am consistently getting this error.
 8888888           .d888<PHONE_NUMBER>b.  888888b.
   888            d88P"  888                   888  "Y88b 888  "88b
   888            888    888                   888    888 888  .88P
   888   88888b.  888888 888 888  888 888  888<PHONE_NUMBER>888K.
   888   888 "88b 888    888 888  888  Y8bd8P' 888    888 888  "Y88b
   888   888  888 888    888 888  888   X88K   888    888 888    888
   888   888  888 888    888 Y88b 888 .d8""8b. 888  .d88P 888   d88P
 8888888 888  888 888    888  "Y88888<PHONE_NUMBER>888P"  8888888P"

Using configuration at: /etc/opt/influxdb/influxdb.conf
[metastore] 2015/09/21 23:01:00 Using data dir: /srv/meta
[metastore] 2015/09/21 23:01:00 Skipping cluster join: already member of cluster: nodeId=1 raftEnabled=true peers=[localhost:8088]
[store] 2015/09/21 23:01:00 Using data dir: /srv/db
[metastore] 2015/09/21 23:01:00 Node at localhost:8088 [Follower]
[metastore] 2015/09/21 23:01:01 Node at localhost:8088 [Leader]. peers=[localhost:8088]
[metastore] 2015/09/21 23:01:01 Node at localhost:8088 [Follower]. peers=[localhost:8088]
[metastore] 2015/09/21 23:01:01 No leader
[metastore] 2015/09/21 23:01:02 Node at localhost:8088 [Leader]. peers=[localhost:8088]
panic: pgid<PHONE_NUMBER>0) above high water mark (218360)

goroutine 1 [running]:
github.com/boltdb/bolt.(*node).spill(0xc21ca10150, 0x0, 0x0)
	/root/go/src/github.com/boltdb/bolt/node.go:370 +0x4c6
github.com/boltdb/bolt.(*Bucket).spill(0xc21afab948, 0x0, 0x0)
	/root/go/src/github.com/boltdb/bolt/bucket.go:536 +0x1c4
github.com/boltdb/bolt.(*Tx).Commit(0xc21afab930, 0x0, 0x0)
	/root/go/src/github.com/boltdb/bolt/tx.go:151 +0x1ee
github.com/boltdb/bolt.(*DB).Update(0xc20825a4e0, 0xc2080faef0, 0x0, 0x0)
	/root/go/src/github.com/boltdb/bolt/db.go:554 +0x169

[truncated...]

@esecules, could you send me your config file? Thank you!

Closing this since it pertains to 0.9.3 and bz1 storage engine.  0.9.3 is very old at this point and won't be fixed.  bz1 engine is deprecated and replaced by the tsm1 engine.  You can upgrade to 0.10 and convert your old shards to tsm1 format using the conversion tool


Not indexing in test mode.

Hey,
So I've installed thinkingsphinx, and it's working for me perfectly in development. However, as I tried writing and running tests, I realized I'm having huge problems with getting it to collect docs.
My index in the Article model:
  define_index do
    indexes :title
    indexes :excerpt
    indexes :body
    where "articles.visible = 1"
  end

I'm using this in my Gemfile:
gem 'thinking-sphinx', '2.0.0', :require => 'thinking_sphinx'

So I run
ThinkingSphinx::Test.init

in my test_helper.rb file and then my test looks like this
def setup
  super
  ThinkingSphinx::Test.start
end

def teardown
  ThinkingSphinx::Test.stop
  super
end

And when I run a test, it fails, and debugger provides me with the following info:
article_1 = Article.make(:title => "john is a god")
article_2 = Article.make(:excerpt => "john is not a god")
ThinkingSphinx::Test.index
using config file '/Users/tph/Work/gup-mag/config/test.sphinx.conf'...
indexing index 'article_core'...
collected 0 docs, 0.0 MB
total 0 docs, 0 bytes
total 0.006 sec, 0 bytes/sec, 0.00 docs/sec
distributed index 'article' can not be directly indexed; skipping.
total 3 writes, 0.000 sec, 0.0 kb/call avg, 0.0 msec/call avg
rotating indices: succesfully sent SIGHUP to searchd (pid=4563).

ThinkingSphinx.search('john')
=> []

Any ideas on why this is not working? Did I forget something ?

Any solution found? @antekpiechnik

@harshad26: this ticket's pretty old - indeed, it's referencing TS v2, and the v3 releases are much different. If you're having problems with TS tests, perhaps it's worth opening a new ticket :)


Re-implement Authors package from zero in the workspaces

Current authors package require a complete rewrite (from zero).
That's what I was trying to do in: https://github.com/NodeSecure/authors/pull/52 (but kinda failed because it was more complicated that I imaginated).
The domain-check package should also be merged here (I don't think we need a dedicated workspace for it however).
One of the main goal is to simplify the integration with Scanner. But it will also drastically reduce the maintenance required.
@Kawacrepe

I'm gonna give it a look this weekend in order to make a first draft according our previous discussion


build a sysroot for the new built-in thumb targets

@homunkulus r+

:pushpin: Commit 66fe1d5 has been approved by japaric

:hourglass: Testing commit 66fe1d5 with merge 66fe1d5...

:sunny: Test successful - status-appveyor
Approved by: japaric
Pushing 66fe1d5d6614fec26f77e176916cb90d76212cf3 to master...


Custom 404 not working when _app has getInitialProps

correct me if I am wrong, all static files should be served from functions directly anything else should go through my _app, right?
I deployed a serverless NEXTJS application that implements SSR ( server-side rendering ), and it has some dynamic routes.
It works fine until I press on a link that links to a page that had a dynamic route… for example branches/[id]
It sends a request to get the static js file or the chunk js file needed to serve the page … but instead of getting the file directly because it’s a static js file, it goes through my _app! which makes a redirection to the default locale.
static file URL example
https://example.app/_next/static/chunks/pages/branches/%5Bid%5D-91768ff65c2a79ad38ee.js when it goes through _app it get redirected to https://example.app/en/_next/static/chunks/pages/branches/%5Bid%5D-91768ff65c2a79ad38ee.js   which doesn't exist so, it sends a 404 page.
environment:
node version: 14.15.1
next version: 10.0.9
and I am using new “@netlify/plugin-nextjs” plugin to deploy
PLEASE HELPPPPP

@Doaa-Ismael hey! are you able to give us a repo that reproduces this issue? otherwise we'll close the issue until we have a direct way to help!

@lindsaylevine Thank you for your help. I am trying to reproduce it but so far no luck.
You can close it until I can reproduce it.

ok! let us know!!

@lindsaylevine Hi,
I have the same issue it actually happens after adding a custom 404 page and add it to the redirects in netlify.toml
So adding the following lines cause that problem and removing them fixes it but I can't use my 404 page
[[redirects]]   from = "/*"   to = "/.netlify/functions/next_404"   status = 404

hey! same thing i told doaa - if you want us to help please provide a repo that reproduces your issue 🙏🏼🙏🏼
Sent from my iPhone

On May 17, 2021, at 5:51 AM, Ahmed Medhat Habib @.***> wrote:

@lindsaylevine Hi,
I have the same issue it actually happens after adding a custom 404 page and add it to the redirects in netlify.toml
So adding the following lines cause that problem and removing them fixes it but I can't use my 404 page
[[redirects]] from = "/*" to = "/.netlify/functions/next_404" status = 404
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@lindsaylevine Hey, Thanks for your help.
Here is a repo that produces the issue,
And this is a deployed link
The problem is that when you add a redirection rule specifically for 404 serverless function, all static js files with a dynamic route either served from the 404 function or return 200 status with no response, and after that application reloads.
and if you tried to access the static js file from URL directly it will respond correctly with the right js file.
here is an example of a static chunk file:
https://nervous-wright-bd2aea.netlify.app/_next/static/chunks/pages/numbers/[id]-ab60cba0bf0a845a1df0.js
and this is the log of the 404 function

Note: please try it from incognito browser, and if you tried to access the URL directly everything will work correctly as it get cached I think.

@Doaa-Ismael hello! i forked and deployed and went directly to my site in an incognito window. then i went to /numbers. then i clicked on multiple different /numbers/:id. here's my network tab. i see no issues here so i'm confused D:. what am i missing?

@lindsaylevine Hi,
I as I told you when you try to access any number/90 for example, the application should get a js file for this route ... say js file is located at app/_next/static/chunks/pages/numbers/%5Bid%5D-ab60cba0bf0a845a1df0.js
the response either 200 status with no actual response,

or the custom 404 page (HTML)

if it return HTML, you will find an error in the console Uncaught SyntaxError: Unexpected token '<'
after either response .. the application reloads and renders the correct page .. you see it get _builManifest file and _ssgManifest again every time you click on any number!

ok i think i mostly understand what's going on now. thanks for your patience and explaining it thoroughly!!! 🙏  i think i got mixed up because in the original post the issue seemed to be primarily that the chunk req url had a [default] locale in it, but now the primary issue seems to just be this /* redirect to the 404 func. i'm not sure what the solution is at the moment but obv i'll dig into it deeper when i can and let you know!

@lindsaylevine Thank you, you are right, the issue discreption is misleading so I was thinking of updating it 🙏.

no worries! i think i may know what's going on.. it just occurred to me randomly lol. but wanna check for both of you - is the real/underlying issue really that you need the redirect to be able to use your custom 404?

Yes! We need the redirect to be able to use our custom 404 and, without misbehaviours in the other files.

@Doaa-Ismael - hey! i think this is a bug with using getInitialProps on your _app component. this causes your otherwise static 404.js to not get prerendered as html. not sure why the framework does this, but this is the root of the issue i believe. i can play around with trying to support this use case, but in the meantime, can you try working that out of your site? my understanding is that getInitialProps is no longer recommended as of next 9.3.

relevant comment i think: https://github.com/vercel/next.js/discussions/10874#discussioncomment-1085

hey @Doaa-Ismael - we'll close this since we haven't heard from you but let us know if you're still having an issue!

@lindsaylevine  sorry for not being active.
The problem happens whenever I add an error page ( not html ), so I guess getInitalProps has nothing to do with this issue. Currently, my application use getInitalProps in _app, and I opted out of static site generation and I can't use getSeverSideProps in _app as it not supported by Next currently.
So could you please help me figure out how to solve this?

hey @Doaa-Ismael i got an email that you left a new comment but i don't see it here. perhaps you deleted?

@lindsaylevine Yes I wrote a comment and I deleted it and sorry for not being active.
The problem happens whenever I add an error page ( not html ), so I guess getInitalProps has nothing to do with this issue.
When I try to access a dynamic route page like numbers/12 it should fetch the javascaript static file needed to show this page, so in the network tap I see the request to https://numbers-next-app.netlify.app/_next/static/chunks/pages/numbers/%5Bid%5D-ab60cba0bf0a845a1df0.js
the response is nothing "Faild to load response" and the application reload.
If you tired to access this route directly https://numbers-next-app.netlify.app/_next/static/chunks/pages/numbers/%5Bid%5D-ab60cba0bf0a845a1df0.js sometime the response is the correct javascript file  and most of the other times  it responds with the not found page.
I don't know if the problem that the route should be https://numbers-next-app.netlify.app/_next/static/chunks/pages/numbers/[id]-ab60cba0bf0a845a1df0.js with right brackets symbols "[]" between the "id"
So could you please help me figure out how to solve this?

Hi @Doaa-Ismael ,
I can't reproduce the problem. Could you talk us through the exact steps. When I visit your site and navigate to the numbers page I get no errors. Do you have any extensions enabled?

Hi @ascorbic
the steps are:

go to https://numbers-next-app.netlify.app/
click on "go to numbers"
click on "go to any number"
You will see that the application reloads! it should get a js file and render the page without reloading.

This is fascinating. The problem is that the page is requesting https://numbers-next-app.netlify.app/_next/static/chunks/pages/numbers/%5Bid%5D-ab60cba0bf0a845a1df0.js, which is failing, but when the page reloads it loads https://numbers-next-app.netlify.app/_next/static/chunks/pages/numbers/%5Bid%5D-ab60cba0bf0a845a1df0.js instead, which works. I think this is a bug in our server, but I'll have to talk to our backend team.

Hey @ascorbic.
actually this url  https://numbers-next-app.netlify.app/_next/static/chunks/pages/numbers/%5Bid%5D-ab60cba0bf0a845a1df0.j
don't work the first time and after that, it works fine and the js file gets returned!

Hi @Doaa-Ismael,
This was indeed a bug in our server with the handling of URL-encoded paths, which has now been fixed. Your repro seems to work now. Thanks for the detailed report!


[SPARK-42083][K8S] Make ExecutorPodsAllocator extendable

What changes were proposed in this pull request?
This PR aims to make ExecutorPodsAllocator by switching private to protected.
Why are the changes needed?
This will help the users to use ExternalClusterManager interface in K8s environment by reusing more.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.

Could you review this please, @viirya ?

Thank you. Sure, let me open it too.

Thank you, @viirya and @huaxingao !

All K8s tests passed. Merged to master for Apache Spark 3.4.0.


OmniSR Support

Is it possible to add OmniSR support to the converter? I'd like to be able to convert this model
4x_MangaJaNai_V1_RC16_OmniSR_100k.pth

Unfortunately it's not currently possible to convert OmniSR to Core ML:
ValueError: Core ML only supports tensors with rank <= 5. Layer "x.9", with type "reshape", outputs a rank 6 tensor.


Autorotate issue

Was experimenting with using SloppySwiper but came across one issue when using an iPad.
If i'm on a child view controller and I change the orientation of my device then swipe back, the parent view controller does not properly readjust its layout. If I use the standard interactive popgesture though it works fine.
Let me know if I'm missing something.

@chapaid Thanks for reporting this. Would you be able to attach a sample project?

I'm having the same issue as well.
The bug can be reproduced with the following steps using the sample project.
Push -> rotate screen -> swipe back -> You'll see a black part meaning the auto layout is not working
Screenshots are attached for your reference.
Thanks!


WIP mod-survey: initial translation and make file adjustment

Linked to: https://github.com/getcouragenow/sys/issues/57
Obviously it's not done yet.

Notes so i don't forget:
To ignore BuildContext dependency for localizations and its delegate, all i did is these:

As the LocalizationsDelegate usually only called once (and that's from maintemplate v2)

like this:
https://github.com/getcouragenow/main/blob/e72a577c30a8f3615258e4228b4469ec2037f785/deploy/templates/maintemplatev2/client/lib/main.dart#L65
I simply add a new static instance of ModSurveyLocalizations to the delegate.
https://github.com/gutterbacon/mod/blob/fd2d005c9aa1b2520255574137179ba3dadde50a/mod-survey/service/flu/lib/pkg/i18n/mod_survey_localizations.dart#L55
then, added a global (mod-survey level) function as a helper for translation (called surveyTranslate)
https://github.com/gutterbacon/mod/blob/fd2d005c9aa1b2520255574137179ba3dadde50a/mod-survey/service/flu/lib/pkg/i18n/mod_survey_localizations.dart#L11
since the RPUITask also returns a callback, we can directly call surveyTranslate from the model itself:
https://github.com/gutterbacon/mod/blob/fd2d005c9aa1b2520255574137179ba3dadde50a/mod-survey/service/flu/lib/pkg/model/navigable_survey_objects.dart#L117
while the translation is defined in translations.dart:
https://github.com/gutterbacon/mod/blob/fd2d005c9aa1b2520255574137179ba3dadde50a/mod-survey/service/flu/lib/pkg/i18n/translations.dart#L331
and generated via bs-lang as arb, here's that line translation in spanish for instance:
https://github.com/gutterbacon/mod/blob/fd2d005c9aa1b2520255574137179ba3dadde50a/mod-survey/service/flu/i18n/lang_es.arb#L201
The result (once it is called from main)


Make Single Line output option for Text Extractor a toggle

Description of the new feature / enhancement
The single line output button for the Text Extractor currently resets it's value on each use.
The desired functionality is that on triggering a new text capture the single line output option will recall and use it's last state rather than resetting.
Scenario when this would be used?
Text extracting multiple things one after another that are similar in format and require single line output.
For those users that always want multiline output nothing will change.
Supporting information
Use cases:

Someone has 9 single-line captures to work through, for each capture they have to click the single line button

9 clicks, improved to 1 with new behavior

Someone has 9 multi-line captures to work through

0 clicks, unchanged

Someone has 5 single line and 5 multi-line captures to work through in alternating order

9 clicks, up from 5, but realistically just do half one way and then half the other way resulting in 1 click down from 5

Just realised that #28864 is effectively asking for the same thing

yeah this is a duplicate of that issue.


WIP: only handle configStore from config cluster to prevent duplicate workload from remote clusters

Please provide a description of this PR:

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
fb5863c4d096675a0db500eaac253193fb486968
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
fb5863c4d096675a0db500eaac253193fb486968
link
true
/test unit-tests-arm64

unit-tests_istio
fb5863c4d096675a0db500eaac253193fb486968
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Still need to add limitations to select workloadEntry every where


bezier tessellation via adaptive forward differencing (4x speedup)

I implemented an alternative to nvg__tesselateBezier using the adaptive forward differencing approach described in this paper:
Lien, Sheue-Ling, Michael Shantz, and Vaughan Pratt. "Adaptive forward differencing for rendering curves and surfaces." ACM SIGGRAPH Computer Graphics. Vol. 21. No. 4. ACM, 1987.
http://www.eecs.umich.edu/courses/eecs598-1/lien87.pdf
This seems to achieve a 4x speedup over the De Casteljau subdivision (nvg__tesselateBezier).
nvg__tesselateBezier (no AFD):

With AFD:

The original paper deals with rasterization, not tessellation, so I guessed at a flatness measure, and made some guesses about thresholding. The 4x is even with the AFD code generating double the points. Some more thorough testing is needed.
Change is here:
https://github.com/wtholliday/nanovg/commit/6d08c306904344c06a0e63e386ae9090fa2bb73e
Thoughts welcome!

4x is an impressive speedup! Is there a difference in final vertex count with AFD vs. the De Casteljau algorithm? How about the visual result? I'd be curious to see a comparison of the two. Hadn't heard of AFD before.

@notlion In my app the AFD is generating double the vertices, though I could tweak the flatness tolerance further. I guessed at the flatness test. The visual result was identical as far as I could tell.

I've made a PR for this #420.

@wtholliday in my use case it's more than 4x speed-up.  thanks