Per-Thread Default Stream Not Working

The per-thread default stream environment variable is currently unusable. Running something simple like:
import os
os.environ["CUPY_CUDA_PER_THREAD_DEFAULT_STREAM"] = "1"
import cupy
a = cp.array([1.])

results in the error:
File "<stdin>", line 1, in <module>
  File ".../miniconda3/envs/patched_numba/lib/python3.8/site-packages/cupy/_creation/from_data.py", line 41, in array
    return core.array(obj, dtype, copy, order, subok, ndmin)
  File "cupy/core/core.pyx", line 2016, in cupy.core.core.array
  File "cupy/core/core.pyx", line 2095, in cupy.core.core.array
  File "cupy/core/core.pyx", line 2169, in cupy.core.core._send_object_to_gpu
  File "cupy/core/core.pyx", line 138, in cupy.core.core.ndarray.__init__
  File "cupy/cuda/memory.pyx", line 578, in cupy.cuda.memory.alloc
  File "cupy/cuda/memory.pyx", line 1250, in cupy.cuda.memory.MemoryPool.malloc
  File "cupy/cuda/memory.pyx", line 1271, in cupy.cuda.memory.MemoryPool.malloc
  File "cupy/cuda/memory.pyx", line 939, in cupy.cuda.memory.SingleDeviceMemoryPool.malloc
  File "cupy/cuda/memory.pyx", line 959, in cupy.cuda.memory.SingleDeviceMemoryPool._malloc
  File "cupy/cuda/memory.pyx", line 1190, in cupy.cuda.memory.SingleDeviceMemoryPool._try_malloc
  File "cupy/cuda/memory.pyx", line 1187, in cupy.cuda.memory.SingleDeviceMemoryPool._try_malloc
  File "cupy/cuda/memory.pyx", line 910, in cupy.cuda.memory.SingleDeviceMemoryPool._alloc
  File "cupy/cuda/memory.pyx", line 520, in cupy.cuda.memory._malloc
  File "cupy/cuda/memory.pyx", line 521, in cupy.cuda.memory._malloc
  File "cupy/cuda/memory.pyx", line 100, in cupy.cuda.memory.Memory.__init__
  File "cupy_backends/cuda/api/runtime.pyx", line 550, in cupy_backends.cuda.api.runtime.malloc
  File "cupy_backends/cuda/api/runtime.pyx", line 247, in cupy_backends.cuda.api.runtime.check_status
cupy_backends.cuda.api.runtime.CUDARuntimeError: cudaErrorUnsupportedPtxVersion: the provided PTX was compiled with an unsupported toolchain.

This is on Ubuntu 18.04 with Python 3.8, cupy 8.6.0, and cuda 11.2 obtained via conda-forge.

Can you try this with v9.0.0rc1?

This is on Ubuntu 18.04 with Python 3.8, cupy 8.6.0, and cuda 11.2 obtained via conda-forge.

I cannot reproduce the error with exactly the same env. Any chance you're doing this in the source directory?

Thanks for the suggestions! I just confirmed that this is fixed in master (that or I'm getting a bad binary?). When I build master from source this works now. Closing.

I think it's simply because your test env is somehow scrambled. It works even in v8.6.0 as I said. You may want to create a fresh env and redo the test.

cupy_backends.cuda.api.runtime.CUDARuntimeError: cudaErrorUnsupportedPtxVersion: the provided PTX was compiled with an unsupported toolchain.

We recently observed this error message when running CuPy on CUDA 11.3 with an outdated CUDA driver version. If you encounter this issue again please report with the cupy.show_config() output.

We have this issue with below Nvidia driver in AWS EKS with GPU node.
Nvidia Driver Version: 460.73.01    CUDA Version: 11.2

According to Nvidia website, this is the most up to date driver for datacenter gpu. (https://www.nvidia.com/Download/Find.aspx)

Is there any work around for this issue?
Thanks!

Output from cupy.show_config():
OS                           : Linux-5.4.117-58.216.amzn2.x86_64-x86_64-with-glibc2.29
Python Version               : 3.8.5
CuPy Version                 : 9.2.0
CuPy Platform                : NVIDIA CUDA
NumPy Version                : 1.21.0
SciPy Version                : 1.7.0
Cython Build Version         : 0.29.22
Cython Runtime Version       : None
CUDA Root                    : /usr/local/cuda-11.3
nvcc PATH                    : /usr/local/cuda-11.3/bin/nvcc
CUDA Build Version           : 11020
CUDA Driver Version          : 11020
CUDA Runtime Version         : 11030
cuBLAS Version               : (available)
cuFFT Version                : 10402
cuRAND Version               : 10204
cuSOLVER Version             : (11, 1, 2)
cuSPARSE Version             : (available)
NVRTC Version                : (11, 3)
Thrust Version               : 101000
CUB Build Version            : 101000
Jitify Build Version         : 60e9e72
cuDNN Build Version          : None
cuDNN Version                : None
NCCL Build Version           : 2804
NCCL Runtime Version         : 20906
cuTENSOR Version             : None
cuSPARSELt Build Version     : None
Device 0 Name                : Tesla K80
Device 0 Compute Capability  : 37
Device 0 PCI Bus ID          : 0000:00:1E.0

CUDA Root : /usr/local/cuda-11.3
nvcc PATH : /usr/local/cuda-11.3/bin/nvcc
CUDA Build Version : 11020
CUDA Driver Version : 11020
CUDA Runtime Version : 11030

It seems that you are using CUDA 11.3 against CUDA driver 11.2, but this is known to cause this error (c.f. https://github.com/cupy/cupy/issues/5095#issuecomment-833003035, #5097) (although I think NVIDIA docs says it is a compatible configuration).
Could you try using CUDA 11.2 + cupy-cuda112 instead of 11.3?


Update terminology

Update terminology to new lingo.

the agreed mapping on the ERA meeting 8.6.2022 is:
•	OSDM-Allocator is kept but the description will be extended to say that this corresponds to the TAP-TSI distributor and issuer roles
•	OSDM-Ticket Vendor --> Retailer           (ERA plans to use the term Ticket vendor in a more generic term similar to railway undertakng and not as a role name)
•	OSDM-Distributor --> Retailer
•	The following roles keep their names but we need to copy the TAP-TSI definitions (which are almost identical to ours):
o	Carrier
o	Passenger
o	Customer
o	TCO
•	Fare Provider and Local Transport Authority are kept
Stefan Jugelt from ERA will do the changes in the provided version 1.5 for TAP-TSI himself until the final ERA meeting on 28.6..
The alignment with CIT is ongoing, but there is not enough time to change the TAP-TSI role definition in the current TAP-TSI revision.

Terminology updated with OSDM 2.0.


chore: remove codefund badge, update license badge

Removes broken code fund badge and updates the license badge to point at this repository.

Sorry for commenting on an old PR, but I just wanted to follow up here and let you know that we've launched EthicalAds which is a spiritual successor to CodeFund. I'm not sure if you're still looking for an ethical ad network, but we're all open source and are working to support the community here.


Filed to download finished record, available on demand

Finished record, files are available on demand, without pin.
Getting error message:
Traceback (most recent call last):
File "./boomstream.py", line 271, in
sys.exit(app.run())
File "./boomstream.py", line 245, in run
if len(self.config['mediaData']['records']) == 0:
KeyError: 'records'
boomstream.config.zip

I think I've fixed this in my fork. You can try it here: https://github.com/asiunov/boomstream-downloader

I think I've fixed this in my fork. You can try it here: https://github.com/asiunov/boomstream-downloader

Thank you Andrey! I tried your fork, got different error.
Traceback (most recent call last):
File "./boomstream.py", line 306, in
sys.exit(app.run())
File "./boomstream.py", line 272, in run
cookies = self.get_access_cookies()
File "./boomstream.py", line 266, in get_access_cookies
cookie = json.loads(r.text)["data"]["cookie"]
KeyError: 'data'

Will post issue under your fork.
Thank you for reply!

Oh, seems like issues page was disabled in my fork. Fixed.
I think something is broken with the authorization step. I've added better handling for this, try now and you will see an error. I expect this to be "Password is invalid" - which is given when the provided pin code does not work.

Oh, seems like the issues page was disabled in my fork. Fixed.
I think something is broken with the authorization step. I've added better handling for this, try now and you will see an error. I expect this to be "Password is invalid" - which is given when the provided pin code does not work.

Yes, authorization indeed,
Traceback (most recent call last):
File "./boomstream.py", line 312, in
sys.exit(app.run())
File "./boomstream.py", line 278, in run
cookies = self.get_access_cookies()
File "./boomstream.py", line 269, in get_access_cookies
raise ValueError(f"unexpected response on authorization: {r.text}")
ValueError: unexpected response on authorization: {"code":500,"message":"Internal Server Error"}
Current content does not require PIN. For example and test please use: el4Eh2sj

Alright, I've pushed a fix. It works now for your video, just remove pin code from the command.

@asiunov Confirm latest commit c6b9b02 worked perfect. Thank you so much!


429 Error and proxy enabling

I am using getAccountById method in loop. After few times I get this message
Exception: Response code is 429. Body:  message => Please wait a few minutes before you try again.;
And code stoping. I want continue runing, using another proxy when I get this error. Can somebody make code example for that?

try {
  $instagram->getAccountById(...);
} catch(InstagramException $e) {
  if ($e->getCode() == 429) {
    // ...
  }
}


Fix build and tests using the most recent stable version of Rust compiler and libs/deps

can you add a quick githubCI lane to run the build and tests please

I said GithubCI, not travis :( Travis is not cross-platform.

I said GithubCI, not travis :( Travis is not cross-platform.

Oh, sorry, my mistake.

I have added a GithubCI workflow:
https://github.com/ekutt/p2p/runs/484681414?check_suite_focus=true


Automate methods can access categories and entries

https://bugzilla.redhat.com/show_bug.cgi?id=1254953
Added a new method $evm.categories to return an array of
MiqAeService::MiqAeClassification objects.
Exposed the entries method in the MiqAeService::MiqAeClassification
to access the entries in a category.

@gmcculloug @tinaafitz
Please review

@gmcculloug @kbrock
Do we have to worry about tenancy when doing categories and tags are they going to separated by tenants. This PR doesn't do any filtering based on tenants.

@mkanoor Tags are not separated by tenants at this time but likely will be in the future.


Add support for execution strategies as an array of named subconfigurations

This would allow us to have multiple kinds of local execution with unique IDs.
Allow frontmatter to specify execution strategy e.g. per page.
Allow CLI to override strategy if not defined.

Also: move execute flag to config? Default on.


Fixes for TaskKillService

Please don't squash merge
Cherry picking 2 commits from master to releases/1.3:
Introducing UnknownTaskTerminated event
Until now, no event was dispatched on the event stream when the related task was terminal and unknown, thus making the TaskKillService unable to track the progress of these kill requests. Promises created by TaskKillProgressActors were never completed, leading to a memory leak. With this change, an UnknownTaskTerminated event will be dispatched on the event bus when a terminal status update for an unknown task is received. This event is also visible for subscribers to the event stream. The TaskKillService handles this event and correctly recognizes it as a kill success.
Cherry-picked from feature/pods (was: Adjust the KillService to handle instances instead of tasks (#4414))
Fix KillService behavior: retry forever and don't spawn progress actors for unknown tasks

killUnknownTask now has a unit return type (no one is interested in the result)
Do not create KillProgressActors for unknown tasks
remove maxRetries; if no terminal task status is received, the killService will retry until the task is confirmed to be terminal

Thanks!


Create lexer

Creating lexer for my custom language WLang

TODO:

[x] Create lexer sketch
[x] Create lexer handling each token
[x] Manually test
[ ] Write example code
[ ] Write tests for example code

Latest commit should be linked to #3


Paid state assigned twice?

Expected behavior
Once a payment is set as payed the same state should not occur again.
Actual behavior
The order state change to payed twice:

Steps to reproduce the behavior
Change the state to a not payed state. This isn't always happening. As you can see the order is registered once as payed:

Environment

PrestaShop version: <IP_ADDRESS>
Mollie module version: 4.2.2
PHP version: 7.4

Hello @jacob-v-dam,
Thank you for the message, I will pass this to our team for further investigation, and will get back to you as soon as possible!
--
Best regards,
Invertus Support team

Hello @jacob-v-dam ,
Could you also clarify if this happens only when the status is changed manually?
Looking forward to your reply!
--
Best regards,
Invertus Support team

Hello @jacob-v-dam ,
Would you be able to clarify if the issue persists only when changing the status manually?
Let me know!
--
Best regards,
Invertus Support team

At the moment this only happens on the Klarna orders. Customer now receives two e-mails.

Thank you for your message @jacob-v-dam ,
Could you also clarify what are those 2 emails that the customer received? And could you give us more information on this issue please?
Looking forward to your reply!
--
Best regards,
Invertus Support team

Hello @jacob-v-dam ,
Would you be able to clarify the 2 emails that the customer has received? And provide us with further information regarding this case?
Looking forward to your reply!
--
Best regards,
Invertus Support team

Hello @jacob-v-dam ,
Did you have the time to install the latest version, and check if everything is okay, and if our further help is needed?
Let us know!
--
Best regards,
Invertus Support team

@jacob-v-dam ,
As this issue was resolved and the fix was merged in to the 4.2.3 release which you can download and install here - https://github.com/mollie/Prestashop/releases
We are going to close this issue for now. Let us know if you notice any misbehaviour or if you  need assistance with it and we will reopen the issue!
Have a nice day,
--
Best regards,
Invertus Support team


ruby 2.3 is quite outdated

This (https://docs.microsoft.com/en-us/azure/app-service/containers/quickstart-ruby) looks like a main document describing Ruby app setup for Azure Apps.
The current stable version of ruby is 2.6. The 2.3 of ruby was released in Q4 2015 and it does not allow running recent versions of most web-frameworks. It would be really surprising for me if anyone is still using it in production environment.
In my opinion, you should either:

make it clear in this document, 2.3 is the only supported version of Ruby on azure platform, and there is no supported way of updating it.
or advise from the start to base the setup on Docker images with more recent version of Ruby and link to docs which describe the process.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 872e5aa0-cda4-295d-08f8-4db6e488e32f
Version Independent ID: 2b6b32d6-e501-6cb4-bb3b-c3c46851d24e
Content: Create Ruby web app on Linux - Azure App Service
Content Source: articles/app-service/containers/quickstart-ruby.md
Service: app-service
GitHub Login: @SyntaxC4
Microsoft Alias: cfowler

@xiazek Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

Thank you guys for resolving this ! I'm looking forward to try out your platform with ruby 2.6 when have a spare moment.


Issues in new UI

This issue is intended to gather any bugs or other issues people spot in the new UI, now deployed to dev.clearlydefined.io. Please mention them as comments on this issue :)

The dropdown arrow does not work for selecting the package type, but works correctly for "Fix Something".

In the window to edit the license, the clicking "x" does not close the window. It doesn't do anything.

When I try to edit the source information, clicking the edit pencil only shows me a white screen.

White page after clicking:

In the current UI, clicking on the version or commit ID, would usually take me to the component/version. If it is a GitHub repo, it would go to github at that commit. Same for pypi, it would go to that package and version on pypi.org.
However, in this UI, it just goes back to the page.

Will this change once in production?

Hi @capfei - are you referring to clicking on the version or commit ID in the browse UI (what you see here , or on the component page itself such as this one?
Feel free to ping me on Teams if it would be easier to show me what you are seeing.

@nellshamrell I'm referring to the component page. >_<

@capfei aha! I see what you mean. @andrewrmn is it possible to make this workflow happen?
At the top of this page, could clicking on the commit hash under "dusk" open a new tab that navigates to this commit.
And at the top of this page, clicking on the version number under google-auth open a new tab that navigates to this pypi version page.
Looking up how this is done in the current UI - I suspect it is using the definition.urls.definition, but I will confirm.

@andrewrmn I believe this is where we generate the link in the current UI.

@ariel11 Yep! We're definitely adding that back in!

Noting this here as another UI change: https://github.com/clearlydefined/website/issues/937.  Thanks!

#937 won't be included in the initial launch of the new UI/UX, but it's something that can be looked into after.

Hi @capfei and @ariel11
@andrewrmn has fixed the package version link at the top of the component page and the edit license window not closing. Those changes are now deployed to dev.clearlydefined.io as well. He's working on the remaining issues :)

There is another bug to report (I can create separate issue if need be).
If you go to the https://dev.clearlydefined.io/workspace page and click on the search bar, the page will go blank white.
The issue repeats itself even if you refresh the page and try again.

Hi @bduranc! Thanks for the report. That won't block deploying the new UI/UX, but it is absolutely something we should track. Can you add a separate issue for it?
Thank you so much!

Adding to @nellshamrell 's point:
The workspace page can be useful for those who want to quickly look-up components and create/share work lists with others (especially useful when working with multiple components, including curation).
It also appears to provide the ability to generate and export notice files. I'm not too sure how one would access that functionality without this page (aside from by using the API).

I consider these two issues blocking to deploy:

[ ] When trying to edit the source information, clicking the edit pencil shows a white screen.
[ ] Going to https://dev.clearlydefined.io/workspace and clicking on the search bar, the page goes to white

And this one not blocking, but something that I will add in immediately when @andrewrmn's work is complete.

[ ] Add "Workspaces" back to navbar

@nellshamrell Just put in a PR to fix the three above items.

Thank you! I plan on merging and deploying this to production on Mon!

@bduranc - could you move that to another issue? Going to close this one now that the UI has been deployed.


Excalidraw as an npm package

Hello. We're already publishing an npm package: @excalidraw/excalidraw.


Store required data statistics for discovering what adapters are in each index

Map<Index,Adapter[]> basically needs to be around to make decisions on which index to query if multiple indices exist.  This required metadata should be stored and used in place of of RowRangeHistogram which is causing this issue currently: #655

actually the method that would likely be used more often than not is getIndices(ByteArrayId adapterId) or something like a Map<AdapterId, IndexIds[]> structure

Should apply this in the delete case as 'check' do not want to have the case where a feature is deleted in one index and not another.


[Map] Leaflet vector layers

Is it possible to use vector layers like https://github.com/Esri/esri-leaflet-vector? What is the best way to implement this?

Hi, I think yes, see https://symfony.com/bundles/ux-map/current/index.html#interact-with-the-map

create your own Stimulus Controller and use-it to render the map (configure data-controller)
in this controller, import esri-leaflet
in this controller, listen to the event ux:map:connect, access L and map instances from event.details

Hi @Kocal!
I tried what you explained with another leaflet plugin (Leaflet.Editable) and I ended up retrieving L var using window.L because event.details.L is not the same variable and does not have the plugin instantiated.
import {Controller} from "@hotwired/stimulus";
import 'leaflet-editable';

//  listen to the event ux:map:connect and pre-connect to set editable: true

_onConnect(event) {
        const { map, L } = event.detail;

        // L.Editable does not exist
        ...

import {Controller} from "@hotwired/stimulus";
import 'leaflet-editable';

//  listen to the event ux:map:connect and pre-connect to set editable: true

_onConnect(event) {
        const { map } = event.detail;
        const L = window.L;

        // L.Editable exists
        ...

Do you see why it's not the same variable ?


Fixed #26281 - Improved error handling and message on datetime format

Added function for checking if time format specifiers are used with date object. If so function returns TypeError with a better error message.

buildbot, add to whitelist.

merged in 45c7acdc507d26451f3c3f22b5d60bdd6d572cfc, thanks!


Fix Email Based Logins

:construction_worker: Purpose
Closes https://github.com/RTradeLtd/Temporal/issues/405
:rocket: Changes
Always return the username when processing login attempts
:warning: Breaking Changes
None

Build failure is due to an unrelated CI issue with looking up prices on CMC


terra-props-table doesn't render always correctly render 'Type' column value correctly for props

Issue Description

In the case that we're using an object  (alphaPropsObj) to store key-value pairs of valid prop options for prop alpha, and we attempt to use PropTypes.oneOf(Object.values(alphaPropsObj), the resulting value for the Type field in the props-table generated by terra-props-table is undefined.
Issue Type

[ ] New Feature
[ ] Enhancement
[x] Bug
[ ] Other

Expected Behavior

I would expect the table to still be able to interpret the type of the array items and yield the following props table

NOTE: This can be achieved by wrapping Object.values(...) in a set of array brackets, and spreading the returned value into said array. Example included below.

Current Behavior

Using

produces

Steps to Reproduce

Define an object of key-value pairs, with values you'd expect to be type-checked using PropTypes.oneOf()
Call Object.values(<your object) as the argument to PropTypes.oneOf.
Observe the terra-props-table's Type field doesn't properly reflect the expected type.

Environment

Component Version: 2.5.0
Browser Name and Version: Chrome (66.0.3359.139)
Operating System and version (desktop or mobile): Desktop

We're open to a PR for this @dylan-sftwr


New Crowdin updates

You own the repo right? Can't you just push these changes to the project instead of opening a PR?

This is manged automatically by crowdin, but I could try

Oh right ok. Thank you for explaining it to me!

@phoebe-leong I found some reasons to stay with the pull requests

I can verify the translations before includig them in the dev branch, so I could avoid spam going live in the Beta bot

I would reduce any CI overload since this is commited every 10 minutes if there are any changes in the translation proyect

I can squash all the commits and then merge it easily


separate statefulset name and statefulset service name in downscaling

I found that the rollout-operator was not calling the right pod endpoint with our mimir installation but was calling mimir-ingester-zone-c-1.mimir-ingester-zone-c.mimir.svc.cluster.local when it should be using the headless service at mimir-ingester-zone-c-1.mimir-ingester-headless.mimir.svc.cluster.local
This led me to issue #125 so checked on our statefulsets and found the serviceName was correctly set to serviceName: mimir-ingester-headless
so I dug around a bit and found that the operator was using the an arg named serviceName in createPrepareDownscaleEndpoints but passing it the statefulset name.
So I've split them to use both the statefulsets name and it's serviceName so that hopefully these requests go to the correct pods
Let me know if this needs changing or if there is another approach that I've missed?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


contentInset of scrollview should be taken into account when calculating contentOffset?

Description
If the embedded scrollView has a top contentInset say x, then the min contentOffset at which the scrollview anchors etc, should be -x. Currently this is always set to 0 which causes a glitch.

Should I set contentOffset somewhere to fix a glitch?

I have this same bug. I will sort that in my fork.

This bug is fixed in my master branch: https://github.com/ppamorim/PanModal


Allow users to pass a filter function to argv.

It's sometimes desirable to explicitly ignore some arguments that might
be supplied, but which the implementation doesn't care about.  Allow
users to provide a function with which to filter key-value pairs parsed
by to_argv after they've been parsed, but before they're put in order.

Seems good to me, but now I wonder how you intend it to expose it in mirage/functoria (I guess that's the goal ?).

https://github.com/yomimono/mirage/commit/370e7bf5090a475c4ae2455d0a78c6cb2a0907c4 is what I'm up to.  There it's separately implemented as argv_qubes, but it would solve EC2 booting problems too, and it should probably be added to argv_xen.

I'm curious whether bootvar handling, apart from the bare minimum (retrieving from xenstore on xen, getting them in unix, solo5-*), should be handled in another library (platform independent, purely functional) since we also have a solo5-bootvars library -- and we should avoid to have copy and paste code (or have some features only available on one platform)

I've opened an issue for @hannesm's comment, as I think it's a good point but not relevant to this PR in particular.
@drup, has seeing the use case clarified what's going on here?  If there's an approximately-equally expedient way to solve the problem that's more elegant, I'd be happy to work it out given a few hints.

I mentioned it here because this is the first commit/PR after the split.  Delaying a new package will be more expensive for each commit done here and in mirage-bootvar-solo5, thus better to do sooner than later.

@yomimono Yes it does. I can't think of a clean way to expose this elegantly, and in any cases, this can be done later, so I think your solution is good.


bug - admin.py does not have Template model

Add Template model in admin.py, so it will be visible in admin ui

done


domain is not optional, repo is optional

Fixes #347

/retest

/assign @sttts

/assign @damemi

/lgtm

Looks like I still need an approval for this pull request.

/approve


Bookmarks failing to save

After bookmarking multiple talks, I noticed that many did not get save. I did not identify a pattern on why it is happening: it may be related with the quantity of bookmarks and/or a connection issue (with bad syncing, maybe?).
If the later, it would be great to receive a message if connection fails.

Thanks for reporting this! Did they appeared as set but disappeared after a restart of the app? If you can find a way to reproduce, would be great.

If the later, it would be great to receive a message if connection fails.

Agreed. Any suggestion what to do in terms of UI? SnackBar, something else?

Did they appeared as set but disappeared after a restart of the app? If you can find a way to reproduce, would be great.

Never mind, I'm almost sure this is a backeng caching issue. I'll look into this.

If the later, it would be great to receive a message if connection fails.

We should still do this though. Let me know if you have any idea

Did they appeared as set but disappeared after a restart of the app?

Yes, exactly. Sometimes just navigating to another screen and come back would make it disappear.

If you can find a way to reproduce, would be great.
Never mind, I'm almost sure this is a backeng caching issue. I'll look into this.

I suspect it to be a caching problem too.

Any suggestion what to do in terms of UI? SnackBar, something else?

A SnackBar should be fine IMO.
Thank you for looking into it! 😀

Thanks for the details! I'm pretty sure this was fixed with this. Before that, the CDN would cache older benchmarks for 10min. This line disables caching for bookmarks. Let's wait a bit (not sure what version is on the Google play) to see if it's still happening

I published version to production a few days ago but hasn't been approved yet.  @marcellogalhardo I can add you to internal testing channel if you want to DM me your google email address. (I believe fix should be in that but I'll publish version to that later as well just to be sure)

Now that I think about it, the fix was server side so no need to even wait for Google here. @marcellogalhardo let us know if you see this bug again! Testing with latest internal channel would be interesting too nonetheless

@martinbonnin the problem is still happening on current published version. @joreilly added me to the internal, and the problem doesn't seem to happen on the new version!

I have tried further on the internal version, and it seems it keep happening.
I have recorded a video showing the problem: (Confetti-Bookmark-Issues.mp4)[https://drive.google.com/file/d/143cTuqe_FEeM13xmjH91d4sRYim85esq/view?usp=drivesdk]

Many thanks for the video 🙏 . Gave it a quick try here and couldn't reproduce unfortunately :(. I'll add error messages when the call fails, hopefully that'll give us more info.

Should be good with better backend-side cache control


DOCS-1385: Adds banner link to Open Source adoption survey

Product Version(s):

N/A
Issue:

https://tigera.atlassian.net/browse/DOCS-1385
Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

@HugoJLFerreira This is just a small config change. But could use your input on color, in particular. Does this look right to you?


Support machine-specific settings that can be set (overridden) in workspace/folder

When trying out the remote/container support in Insiders, I noticed some issues caused by my SDK paths being synced from Windows into the container. I saw in 1.24 there's a new machine scope for settings that seems like it's designed to fix this.
However, many of my paths (SDKs, log files) are window-scoped, so that they can be set both global or per-project (for example, you might set an SDK path in user settings, but want to override it for a specific folder).
In order to prevent the global user SDK path being synced to the container, we need to change the scope from window to machine, however that prevents a (non-remote/container) user from being able to set the SDK at the workspace level (they'll get warnings "This setting can be applied only in user Settings").
This doesn't seem very flexible - it seems like we should be able to have settings that can be set both at the user-level (and considered machine-specific) and also at the workspace/folder level (where it's up to the user to manage).
Note: I am not asking for machine-specific workspace settings. If a user chooses to set these settings in the workspace level, it's on them to make sure they work on whatever machine/container they open the settings on. What I think is required is:

Can be overridden at a folder level for a non-remote user
Can be set at a machine level but is not synced into containers/remotes

I guess it's similar to the typescript.tsdk setting, however by coincidence that's usually set to a relative path (node_modules) so the issue isn't as obvious there. If people set absolute paths there, then they'd hit this same issue (if they set it in user settings, it would sync into containers and potentially be wrong, and if it was marked as machine, it would no longer be settable at the folder level).

@DanTup Here is how different scopes work in a remote window

scope ↓ / target →
user
remote
workspace
folder

application
✔
✖
✖
✖

machine
✖
✔
✖
✖

window
✔
✔
✔
✖

resource
✔
✔
✔
✔

Machine scoped settings are prevented at workspace/folder level because of the reason that machine scoped settings are mostly with paths and having such settings shareable does not makes sense.

However, many of my paths (SDKs, log files) are window-scoped, so that they can be set both global or per-project (for example, you might set an SDK path in user settings, but want to override it for a specific folder).

How does such settings work when the project is shared as all users might not have same common paths. May I know more about such settings to understand and see what is the right approach to take?

Machine scoped settings are prevented at workspace/folder level because of the reason that machine scoped settings are mostly with paths and having such settings shareable does not makes sense.

I think it makes perfect sense, if it wasn't for VS Code not making it easy to not commit them :-)
For example, in my global settings I have:

dart.sdkPath: ~/Dev/dart-sdk/stable

Then I open a project I'm working on that uses new features that I want to use a bleeding-edge SDK for. I override the sdk path in the workspace settings:

dart.sdkPath: ~/Dev/dart-sdk/bleeding-edge

This all works fine today (and my extension provides a quick-pick list to quickly switch between SDKs for the current project, which is writes into workspace settings).
This is good functionality - the only thing that makes it weird is that VS Code doesn't separate workspace settings that we do and don't want to commit (that's what https://github.com/microsoft/vscode/issues/40233 is asking for).
TypeScript has exactly this setup (typescript.tsdk) however it's fortunate that it's always a relative path so they're not hit by this issue. If you wanted to set typescript.tsdk to an absolute path, you'd have the same problem.

How does such settings work when the project is shared as all users might not have same common paths.

Right now, my assumption is that if people put SDK paths in their workspace settings, they would not commit them (or they would be the only people working on their project). This isn't a perfect solution, but until we have something like https://github.com/microsoft/vscode/issues/40233 it's unavoidable.
I actually think https://github.com/microsoft/vscode/issues/40233 is a better fox for this, if you consider them "machine-specific workspace settings". Eg. put them in settings.machine.json and then people can gitignore them, and you can also ignore them when remoting.

Good that we share same thinking for solving this. I too agree that the right fix for this is to support local workspace settings. Remote set up adds more weightage for this requirement.
Making this dup of #40233
/duplicate

Potentially :) I'm sure there are some users that also want local workspace settings that will apply in remotes (for ex. some have extensions that change colours of VS Code to make each workspace distinctive - they probably do want them to apply remotely).
I still sorta think that putting machine into scope may be the wrong call, and settings should probably be able to be flagged as machine-specific (eg. they're paths) in addition to being set as application/window/resource 🤔

Is there any example do you think of?

I was thinking of https://github.com/johnpapa/vscode-peacock, though now I think about it, that's a UI extension that runs in the client, so presumably it would still see the "local workspace" settings even though they're not synced to the server? Or do the same rules apply for which settings are seen for both ends?

Non shareable workspace settings would be associated to the workspace/folder and they will have same rules as of now except that machine scoped settings will be respected in non shareable workspace settings.

I'm not sure I understand. Let's say the linked issue above is implemented, and we end up with .vscode/settings.json and .vscode/settings.local.json (the idea being the user commits .vscode/settings.json but gitignores .vscode/settings.local.json).
If I add "foo.bar": true to .vscode/settings.local.json, would it be seen by:
a) remote running extensions (eg. like my debugger)
b) local UI extensions (eg. like Peacock)
If the answers are a) No and b) Yes, then I think that satisfies both the needs above. However if they're both the same answer, I think either it won't handle my use case, or won't handle Peacocks :(

true value for foo.bar is seen by all (both remote and local) extensions. May I know why it wont handle your usecase or other's?

I have a setting that is an SDK path. It needs to be:

Settable in User Settings (so the user can set the SDK once and it works for all projects)
Overridable in Workspace Settings (so the user can switch to a dev SDK - or even an older SDK - for a specific project)
If set in User Settings, not applied to a remote session (which may be a different platform)

This is not possible today, and based on your last comment seems it won't be possible even if "local workspace settings" are implemented.
In order to do 3 I have to mark the setting as "machine scope", but then 2 doesn't work because VS Code complains if you try to set a machine-scope setting at a workspace level (the validation tells you not to set a machine-scope setting here).
I don't understand why a setting can't be machine-scoped if set globally, yet still overridable at a workspace level.

I think we agreed that non shareable folder settings is the solution for your usecase:
A path setting which is recommended to be machine scope:

If set in User settings applied to all local folders
If set in User Settings, not applied to a remote folder
If set in Non Shareable Folder Settings applies to the associated folder
Not allowed to be set in shareable folder settings

A common SDK path can be set for all local folders using User settings
A common SDK path can be set for all remote folders using Remote settings
A specific SDK path can be set for a specific folder (local/remote) using Non sharable folder settings
Even the Peacock extension can configure window specific settings like themes, colors in non sharable folder settings which are associated to the given folder.

I don't understand why a setting can't be machine-scoped if set globally, yet still overridable at a workspace level.
It makes sense to be overridable only if the setting is not shared. Sharing a machine scoped setting does not makes sense.

Sorry, if I am missing or not understanding some thing which you think that does not work with non shareable folder settings.

Even the Peacock extension can configure window specific settings like themes, colors in non sharable folder settings which are associated to the given folder.

But wouldn't Peacock want those settings to apply when when in a remote session? Eg. I set my color to "red" in the non shareable folder setting for my project, then I open it in a container - I still want it to be read, so the setting still needs to apply (at least in the client)?
(My understanding from this comment was that the client and server would always see the same settings, which sounds like Peacocks non shareable color settings would not have any effect when connected to a container?)

But wouldn't Peacock want those settings to apply when when in a remote session? Eg. I set my color to "red" in the non shareable folder setting for my project, then I open it in a container - I still want it to be read, so the setting still needs to apply (at least in the client)?

Right, opening a folder on disk locally or in container will have different non shareable settings as they are two different folders with different URIs. I think this limitation is ok and if needed we can think of letting dev container extension syncing these settings (but as said I would not go to that unless really needed).

Ok, then it sounds like the non-shared settings will work for me if the local/remote won't share them by default. When can we have it? 😆

Reopening to bring it up for discussion to allow a machine scope setting to be overridable and sharable.

I still sorta think that putting machine into scope may be the wrong call, and settings should probably be able to be flagged as machine-specific (eg. they're paths) in addition to being set as application/window/resource 🤔

I agree that it would be useful to separate the concepts.
In microsoft/vscode-go#2576 several settings for Go were changed to be machine scope. However, this broke our company's shared workspace settings. We use the workspace settings to configure workspace-relative paths where we have the Go SDK and Go libraries installed.
Our current config is mostly turn-key where a dev can check out the repo and get started with VSCode with very few manual steps. Configuring those paths in the User Settings would not only make our developer setup less convenient, but also means that developers can't easily work on multiple Go projects with different configurations.
This is a different use-case than #40233 since these are shared settings committed to our repo, rather than being able to provide user-specific overrides (though I would love to see that implemented as well).

Introducing a new scope machine-overridable to enable machine settings to be overridable. Here is the summary of the scopes

window -> that can be configured till window level and cannot be overridden further
resource -> that can be configured till resource (folder) level
machine -> that can be configured at machine level and cannot be overridden further
machine-overridable -> that can be configured at machine level and can be overridden further

Calling it machine-overridable but if there is a better name that apts, open to it.

Sounds good to me :-)

Verify that a configuration contributed with scope machine-overridable can be overridden as follows

In Local Window, it can be overridden at all levels (User, Workspace, Folder)
In Remote Window, it can be overridden at following levels (Remote, Workspace, Folder). It cannot be overridden in User Settings.

In Remote Window, it can be overridden at following levels (Remote, Workspace, Folder). It cannot be overridden in User Settings.

Doesn't seem to work for me. Created https://github.com/microsoft/vscode/issues/79983.
I suggest the issue is tracked there, marking as verified.


2.3.1 is broken

Describe the bug
Seems the 2.3.1 publication is broken
When building with it, I get the error
contains a reference to the file "codemirror-editor-vue3". This file can not be found, please check it for typos or update it if the file got moved.
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

I also encountered this problem. The dist directory of this version on npm is empty. I guess the author forgot the project packaging when publishing, so I returned 2.3.0 to use

@rennzhang
Consider adding a "prepublishOnly": "npm run build", script in the package.json to avoid this issue in the future

I am very sorry for this low-level problem, which has been fixed.

For version 2.4.0, only README.md and some code formatting have been updated, and no other code has been updated, please feel free to use (or continue to use 2.3.0)

@rennzhang 考虑在中添加"prepublishOnly": "npm run build",脚本以package.json避免将来出现此问题

Thank you very much for your suggestion, I have added this command to package.json


Disable search box until it works

From: https://github.com/metanorma/metanorma.org/issues/439
We should disable the search box to prevent people trying it since it does not work.

Done. The intended way of disabling Algolia integration is by removing the relevant setting hash in YAML configuration.


branch-1.2-lts change memtable flush error code

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

BE UT failed

@morningman The clang ut is error, is this in line with expectations？


unable to switch to 2.2.x branch

have to use full path instead of only "swiftenv install swift-2.2.1-SNAPSHOT-2016-03-28-a"

Same issue here. Problem is the first part of the path it's searching for:
https://swift.org/builds/swift-2.2.1-branch <- doesn't exist (yet).
This is the actual url: https://swift.org/builds/swift-2.2-branch/xcode/swift-2.2.1-SNAPSHOT-2016-04-12-a/swift-2.2.1-SNAPSHOT-2016-04-12-a-osx.pkg


Failed to run post-create hook with systemdboot

Hi,
I'm running Arch installed on zfs on root that I install it using the ALEZ script (systemd-boot as bootloader). I'm trying to use zectl with systemdboot plugin. I enabled it as zectl set bootloader=systemdboot.
When I try to create an snapshot with for example zectl create snapshot1 an error occurs:
zectl: Failed to run 'zectl create'.
Failed to run post-create hook

After that, if I do zectl list I get:
Name       Active  Mountpoint                Creation
snapshot1          /tmp/ze.snapshot1.tivoaW2021-05-25 22:25
default    NR      /                 2021-05-25 18:58

The output of zfs list is:
zroot                 7.76G   891G      176K  none
zroot/ROOT            7.52G   891G      176K  none
zroot/ROOT/default    7.52G   891G     7.50G  /
zroot/ROOT/snapshot1     8K   891G     7.50G  /tmp/ze.snapshot1.tivoaW
zroot/data             245M   891G      176K  none
zroot/data/home        245M   891G      245M  legacy

But I can't see any logs or output of the error anywhere, so I'm a bit lost on what is the problem.

Are you setup according to docs/plugins/systemdboot.md ?
What does zectl get output?

Sorry but at the end and after several formats I just went with grub and zedenv and now is working fine. Next time I format maybe I try again.


Installing FZF for all users (existing and future) in Linux Ubuntu 18.04

Category

[x] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

While it is very easy to install FZF for a given user under Linux server, I am wondering if there is a way to install it such that it automatically becomes available for all users - existing or new. Having that clearly laid out would help wonder to make FZF the standard server feature that it has long deserved to be. Thanks!

I don't understand. What's wrong with sudo apt-get install fzf?

sudo apt-get install fzf is not given as an option in the install instructions at https://github.com/junegunn/fzf/blob/master/README.md? Also for me at least it simply doesn't work (Ubuntu 18.04), so if it's supposed to be possible to install it this way, we need information on which repository to add.

I see, https://packages.ubuntu.com/search?keywords=fzf it is just for more recent distributions. Couldn't you install from Debian repos (https://packages.debian.org/search?keywords=fzf)? I really don't know, I don't use any Debian-base distro.

Would be nice as either an apt or snap package

Maybe you could make use of the /etc/skel and /etc/bash.bashrc skeleton files used in ubuntu to create home environments for new users. You could just manually install from git and prepare the files for it. As fzf install just sources some files, this should be doable but I did not try it myself.

Yeah the problem is for anyone that is using the lts version as the fzf package only exists in 19.04... So yeah I'd say it's git for now.

Sad... 😞  My distribution is ubuntu 18.04...

Isn’t there some PPA? Didn’t anybody create the one?

Sad...  My distribution is ubuntu 18.04...

There is fzf ppa for ubuntu 18.04
https://launchpad.net/~fmarier/+archive/ubuntu/ppa
sudo add-apt-repository ppa:fmarier/ppa
sudo apt-get update
sudo apt install fzf

+1 for installation of fzf on Ubuntu 18.04. Provifing fzf via snap would possbile as well, right?

@mcepl @fkromer It is also possible to download the deb manually via https://packages.ubuntu.com/eoan/fzf
and then perform the install
sudo dpkg -i ./fzf_0.18.0-2_amd64.deb

Disadvantage of this workaround is you won't get any updates.

@JurrianFahner Thanks a lot for the hint!

@mcepl @fkromer It is also possible to download the deb manually via https://packages.ubuntu.com/eoan/fzf

Or if there is some altruism in you, you can create your own PPA and just rebuild (and then follow) the package from the modern distro.

Why is this closed? Ubuntu is the most used Linux distro and there is support of pretty much everything else but Ubuntu.

Because I'm not a maintainer of any of the Linux packages.

if somebody is using debian 9, you need to add the backports package repository:
echo "deb http://ftp.debian.org/debian stretch-backports main" | sudo tee /etc/apt/sources.list.d/backports.list
sudo apt update

then, you can install fzf with:
sudo apt-get install fzf


Add MustCreate and MustCreateMany methods to Templates

I think it would be useful to have these methods as extra methods for testing.
I could try to do a PR for this if you agree this is a good idea

These would be nice.
Another set of methods I want to add is CreateOrFail(tb *testing.TB) and CreateManyOrFail(tb *testing.TB).
These should call tb.Fatalf() if there is an error. This is likely better than a panic.
Also, if you do send in a PR, kindly add some documentation for it 🙏🏾

Implemented in #230


Added moss cat

Added moss cat command to uqcsbot.
No surprise, it prints the moss cat.

You call that a moss cat?

I feel like this is a war that no one can win

Unfortunately the cat looks a bit worse than back in 2014 😢


Execution error in Windows 7

Execution error in Windows 7.
Steps: (after installing https://www.microsoft.com/net/download/dotnet-core/sdk-2.1.300-preview1)

dotnet new -i Microsoft.AspNetCore.Blazor.Templates
dotnet new blazor -o BlazorApp1
cd BlazorApp1
dotnet run

Result:
Using launch settings from D:\projects\blazor\BlazorApp1\Properties\launchSettings.json...
Application startup exception: System.InvalidOperationException: Cannot find bin directory for Blazor app. Neither 'D:\projects\blazor\BlazorApp1\bin\Debug' nor 'D:\projects\blazor\BlazorApp1\bin\Release' exists on disk. Make sure the project has been built.
at Microsoft.AspNetCore.Blazor.Cli.Server.Startup.FindClientBinDir(String clientAppSourceRoot)
at Microsoft.AspNetCore.Blazor.Cli.Server.Startup.FindClientAssemblyPath(IApplicationBuilder app)
at Microsoft.AspNetCore.Blazor.Cli.Server.Startup.Configure(IApplicationBuilder app, IConfiguration configuration)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
crit: Microsoft.AspNetCore.Hosting.Internal.WebHost[6]
Application startup exception
System.InvalidOperationException: Cannot find bin directory for Blazor app. Neither 'D:\projects\blazor\BlazorApp1\bin\Debug' nor 'D:\projects\blazor\BlazorApp1\bin\Release' exists on disk. Make sure the project has been built.
at Microsoft.AspNetCore.Blazor.Cli.Server.Startup.FindClientBinDir(String clientAppSourceRoot)
at Microsoft.AspNetCore.Blazor.Cli.Server.Startup.FindClientAssemblyPath(IApplicationBuilder app)
at Microsoft.AspNetCore.Blazor.Cli.Server.Startup.Configure(IApplicationBuilder app, IConfiguration configuration)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()

Still exists even using .NET Core 2.1 SDK (v2.1.300).

It doesn't look like this affects anybody except the original poster, and even then only on one PC. It's quite possible that some unrelated software running on that PC is interfering.
Since we're not realistically going to be able to do anything about this without a repro or at least multiple independent reports, I'll close this.
@Bitexirtz If you have found any further info in the meantime that would give us clues about how to repro it, please let us know!

I'm using our office PC in producing this error. Even using docker on the same PC, I can produce the same error.
Maybe this error is due to Windows policy implemented by our Admin besides we are behind a proxy. At home, using Windows 10, I don't encounter this error. I will try using other office PC and if I determined the cause, I will just inform again here.
Thank you for you support. Nice work! (Waiting for 1.0)


Linear Search [JavaScript]

This issue is about Linear Search.

[x] Issue Title is in form Algo/DS Name [Language].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).
[x] I will send my PR only after I'm assigned to this issue by any maintainer.

@Anshuman-Verma if you are working on #293 currently, can I work on this if its okay with you?

#293 is done.


MINOR: Remove redundant forwarding integration tests

We have a few integration tests for the forwarding logic which were added prior to kraft being ready for integration testing. Now that we have enabled kraft in integration tests, these tests are redundant and can be removed.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

cc @dengziming Minor follow-up after your patch.

Thanks for this nice cleanup.


Change profile validation to enforce case insensitive unique rule names

Previously, minder required rule names to be unique within an entity type, but did so in a case-sensitive manner. Minder's API expects rule names to be unique in a case-insensitive manner. This changes the validation logic to prevent new rule instances from being created if they are not unique in a case insensitive manner.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[x] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 54.364% (-0.005%) from 54.369%
when pulling 234372a2aadd1a39ef40484730eb2ad6fa61bf1c on validate-case-insensitive-names
into 66f213cfee40924720bfae376b2a0559b82831ca on main.


Add additional Branch support to the Travis CI pipeline

Describe the Task
This is a parent Task and is broken into  Sub-issues.
Add additional multi-branch support to the METplus Dockerfile and the Travis yml file.
Currently the Travis CI build runs on the develop branch, feature_ branches
and all pull_requests ..., ADD and define additional branches that you
would like to be able to support, ie. master_v3.0, master_vx.x, bugfix) etc ...
The pipeline should be able to support adding branches as needed.
This issue also addresses the potential 'timing' concern, (when Travis
may pull a image from DockerHub before it has been built, from the
commit trigger).

For immediate consideration
Address/confirm and possibly change the current METplus dtcenter/metplus:develop image being built on Docker Hub and used by Travis.
Should the MET image referenced in the METplus Dockerfile be changed
to use a different version of the MET Docker Image ?
Currently it is using MET 9.0 image.
FROM dtcenter/met:9.0
maybe instead use one of these ?
FROM dtcenter/met:master_v9.0
FROM dtcenter/met:develop

Add support to the METplus Dockerfile to build images based on specific branches.
see: Sub-issues

Add Multi branch Support to the Travis yml file.
see: Sub-issues

Address Travis CI Build and Docker Hub MET/METplus image build timing.
see: Sub-issues
Consider:  A fix to the timing concern would be to  have
travis build the image file instead of pulling it from DockerHub.

Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the task down into sub-issues.

[ ] #479  Docker Images
[ ] #480  Travis workflow
[ ] #467  Travis-Docker Hub timing

Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[x] Select component(s)
[x] Select priority
[x] Select requestor(s)

Projects and Milestone

[ ] Review projects and select relevant Repository and Organization ones
[ ] Select milestone

Define Related Issue(s)
Consider the impact to the other METplus components.

[ ] METplus, MET, METdb, METviewer, METexpress, METcalcpy, METplotpy

Task Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above.
[ ] Fork this repository or create a branch of develop.
Branch name:  feature_<Issue Number>_<Description>
[ ] Complete the task and verify your changes.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

taking over travis from jimfrimel

Travis currently supports develop, feature_*, master_*, and bugfix_*. That should cover the branches we want to trigger a build. Other branch regex can be added to the .travis.yml file.
The timing concern was address when we changed Travis to build the docker image instead of pulling it from DockerHub (#479)
Sub-issues #479 and #480 were completed in final preparation of the 3.1 release.


Feature request: RSS feed

Please add RSS feed(s) for:

New additions
Updated versions

Hey @moltar,
Have you looked at atom? This is how i've set up my RSS feeds https://vilcins.medium.com/rss-feeds-for-your-github-releases-tags-and-activity-cbda2c51373

@allyman17 yeah, I use feeds for repo changes too. But I think an official RSS (or Atom) would be better, as it could provide more context, like marking new and updated constructs. Then adding CHANGELOG as the body.

Please re-open!

Not stale
https://drewdevault.com/2021/10/26/stalebot.html


Individual privacy notice page

Closes https://github.com/ethyca/fidesplus/issues/749
Code Changes

[x] New <FormSection /> component to help out with the UI of the new forms
[x] Formik form for privacy notice form, was mostly able to reuse our existing form components
[x] Page for a new privacy notice form, which reuses the same component
[x] Form can handle both edit and create
[x] Pulled some cypress helper commands into their own file. This was previously a TODO, and it helped a lot to write the tests here, so I did in this PR, though it's not directly related. It's all in its own commit here: https://github.com/ethyca/fides/pull/3058/commits/128d168b70f0b03a4bc607f979719bb17f707285
[x] Cypress tests

Steps to Confirm

Run with fidesplus and dev server for admin-ui
Follow the steps here for populating your db with privacy notices
Once you have notices populating in your table, you should be able to click into one to edit the form

You should be able to save changes, refresh the page, and see your changes persist
If you change a consent mechanism to "notice only", the "GPC Enabled" toggle and the "Enforcement Level" should become disabled, with "GPC Enabled" toggling off, and "Enforcement Level" becoming "Not applicable"

You should also be able to add an entirely new privacy notice

Note that you'll see a success toast after creation, but you likely won't see it show up in the table. to make it show up in the table, you'll need to add the data use the notice you just created uses to an existing system. This is under further design/product consideration but we decided to PR this first

Pre-Merge Checklist

[x] All CI Pipelines Succeeded
Documentation:

[x] documentation complete, PR opened in fidesdocs
[x] documentation issue created in fidesdocs

[x] Issue Requirements are Met
[x] Relevant Follow-Up Issues Created

[x] Tracking a few things that'll need to be addressed here in this confluence doc which we can make tickets for once decisions are made

[x] Update CHANGELOG.md
[x] For API changes, the Postman collection has been updated

Description Of Changes
https://www.loom.com/share/dbcbaca1e7194c26bb91bf52e184fe4a

Ah @TheAndrewJackson I think you may need to restart your fidesplus backend—the change from necessary --> notice_only was fairly recent

I tried pulling in main and rebuilding and I still saw the same issue. Was it released in 2.11.0? It's possible that branch hasn't been merged into main yet


Add list of contributos to Readme

Refer this link https://contributors-img.web.app/

Hey @ankiiitraj, I can do this can you assign it to me?

Thankyou @abhishekpatel946, I've merged the PR!


Display Column chart in percentage but not Stacked

The above image is taken from an example I want the chart should not be stacked .
I want like this but it is not showing percentage when stacked=false

Please help me how to achieve it. I explored the documentation but couldn't find something

You have to change the data-labels formatter.
dataLabels: {
  formatter: function(val) {
    return val + '%'
  }
}

You have to change the data-labels formatter.
dataLabels: {
  formatter: function(val) {
    return val + '%'
  }
}

This is only appending the percentage.
My requirement is percentage should be calculated like above 1st chart calculates 65% and so on  hence  display like the second chart

Sorry, that is not available in a normal bar chart.
You will have to find the percentages and create the series in percent values.
and then apply data labels with percentage formatter.

Thanks :)


What's the difference between this and Twin.macro? What are the pros and cons of using each?

This library looks amazing, and seems like it does exactly what I need - enabling me to use Tailwind with React without turning my JSX into an unreadable mess.
Since I'm new to Tailwind, I'm still trying to find the best way to use it. Can you help me figure out the difference between this library and Twin.macro? What are the pros and cons of using each?

Would like to know more about this too. My initial reaction is that Twin.Macro is a more complete package (supports more and more complex use cases), but also has more boilerplate when writing code. Then again, I am no expert.

Honnestly the main difference was the syntax of Twin.Macro that was different before and the inheritance that seems to be supported now. I didn't test the last version yet but Twin.Macro seems better maintained too...

@MathiasGilson I would like to add another question. :thinking:
I have been using tailwind-styled-components on Next 12 with SWR compiler without custom .babelrc without issue; However, I assume you did not make a port to work with Rust. So how is this working? :sweat_smile:

It runs at runtime which is less than ideal

twin.macro doesn't allow you to use variables well AFAIK. This package is very simple, doesn't run in the browser and is much lighter.

Yes, I am also having lots of trouble using twin.macro, been trying to migrate for a week now and I am hitting all kinds of roadblocks. From unclear setup documentation to being forced to use babel instead of swc.
Sure, performance gains may be nice, if most things are done at compile-time, but I find myself not knowing how to do some things with ease... readability is already being hurt and there is a use-case, in particular, I am not being able to implement. Might be due to inexperience with the package... Do not want to be unfair to twin.macro since many people do vouch for its powerful nature.
So from my limited experience, if readability and maintainability is more important than performance, I would definitely stick with tailwind-styled-components. I wonder if the run-time overhead of tailwind-styled-components is that critical either way. Can you comment on this @MathiasGilson?
Finally, one thing I now value a lot with tailwind-styled-components is that it does not force you to be on tailwind-styled-components all the way. You can still go with regular className="things", whereas twin.macro forces you into the ecosystem all the way. Since regular className="things" will generate zero styling, because we import base styles, utilities and components from twin instead of tailwind.

@FranciscoKloganB @MathiasGilson Hello! Can you explain again what twin.macro does in compile time and why it has better performance?
Also as I understand twin.macro generates absolutely new classes, it just takes rules from tailwind's classes. So It generates much more css code. tailwind-styled-components uses classes generated by tailwind so it's more more effective for big projects.

What I can tell is tailwind-styled-components is just an easy (and different) way to write your tailwind classes, but with the same results as you would expect when writing them in the className tag.
Example:

tailwind-styled-components
tailwindcss

Output HTML in both cases:

Whilst with twin.macro you (a) need a styled-components library (styled-components, emotion, stitches) and (b) it transforms your tailwind classes into actual CSS with new CSS classes.
So, for the example above:
import tw from 'twin.macro';

export const Section = tw.section`
  flex
  flex-col
  px-14
  tablet-md:px-0
`;

CSS output
.Section-abc-123 {
  display: flex;
  flex-direction: column;
  padding-left: 14px;
  padding-right: 14px;
}

@media (min-width: 768px) {
  .Section-abc-123 {
    padding-left: 0;
    padding-right: 0;
  }
}

HTML output

Disclaimer: the properties above will depend on your tailwind configuration


Fix SwiftLint errors and warnings

:pushpin: References

Issue: None
Related pull-requests: None

:tophat: What is the goal?
Fixing the errors and warnings reported by latest (0.17.0) version of SwiftLint. The project does not compile with the latest version of SwitLint :
~/Desktop
git clone git@github.com:ReSwift/ReSwift.git
Cloning into 'ReSwift'...
remote: Counting objects: 2309, done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 2309 (delta 0), reused 0 (delta 0), pack-reused 2301
Receiving objects: 100% (2309/2309), 4.18 MiB | 825.00 KiB/s, done.
Resolving deltas: 100% (1204/1204), done.

~/Desktop 7s
cd ReSwift

~/Desktop/ReSwift master
xcodebuild -project ReSwift.xcodeproj | xcpretty
▸ Building ReSwift/ReSwift-iOS [(Release)]
▸ Check Dependencies
▸ Processing Info.plist
▸ Compiling ReSwift_vers.c
▸ Compiling ReSwift_vers.c
▸ Linking ReSwift
▸ Linking ReSwift
▸ Copying ReSwift.h
▸ Running script 'SwiftLint'
** BUILD FAILED **

The following build commands failed:
	PhaseScriptExecution SwiftLint build/ReSwift.build/Release-iphoneos/ReSwift-iOS.build/Script-621C06541C277459008029AE.sh
(1 failure)

How is it being implemented?

Ignore identifier_name rule for methods beginning with underscore
Fix warnings and errors for all the other rules

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   94.43%   94.43%
=======================================
  Files          16       16
  Lines         755      755
=======================================
  Hits          713      713
  Misses         42       42

Impacted Files
Coverage Δ

ReSwift/CoreTypes/Store.swift
90.9% <ø> (ø)
:arrow_up:

ReSwift/CoreTypes/StoreSubscriber.swift
100% <ø> (ø)
:arrow_up:

ReSwiftTests/StoreTests.swift
100% <100%> (ø)
:arrow_up:

ReSwift/CoreTypes/Subscription.swift
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8744665...2c766e7. Read the comment docs.


It's hard to understand how to implement a custom protocol

I've read the documentation about custom protocols but I still don't understand what the data flows are. Plural because there seem to be two, one when the custom protocol server is bootstrapped and the other one when an actual test request comes in.
A visual add like a sequence diagram would help, I think.

Figured it out and created really basic an LDAP protocol: https://gitlab.com/dAnjou/mountebank-ldap
Feel free to steal the diagram.

Thank you! I'll take a deeper look this weekend, but at first glance it
looks awesome!
-Brandon
On Mon, Aug 26, 2019 at 10:00 AM Max Ludwig<EMAIL_ADDRESS>wrote:

Figured it out and created really basic an LDAP protocol:
https://gitlab.com/dAnjou/mountebank-ldap
Feel free to steal the diagram.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bbyars/mountebank/issues/453?email_source=notifications&email_token=AAARFP4S4PJNHZQ24LC2TY3QGPVZRA5CNFSM4IPGK7C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EUMEA#issuecomment-524895760,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAARFP2TBA5G56ODG32QHS3QGPVZRANCNFSM4IPGK7CQ
.

Added the diagram, thanks so much.
On Wed, Aug 28, 2019 at 11:12 AM Brandon Byars<EMAIL_ADDRESS>wrote:

Thank you! I'll take a deeper look this weekend, but at first glance it
looks awesome!
-Brandon
On Mon, Aug 26, 2019 at 10:00 AM Max Ludwig<EMAIL_ADDRESS>wrote:

Figured it out and created really basic an LDAP protocol:
https://gitlab.com/dAnjou/mountebank-ldap
Feel free to steal the diagram.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bbyars/mountebank/issues/453?email_source=notifications&email_token=AAARFP4S4PJNHZQ24LC2TY3QGPVZRA5CNFSM4IPGK7C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EUMEA#issuecomment-524895760,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAARFP2TBA5G56ODG32QHS3QGPVZRANCNFSM4IPGK7CQ
.

Oh cool, thanks! I hope to find some time for polishing the repo.


Remove uncessary type parameter and constraints from Upgrade service

Motivation and Context
The type parameter B was not only redundant but also removed a degree of freedom from the API.
Description

Remove type parameter B from Upgrade and related code.
Remove repeated constraint on the upgraded service.

Note
This is part of a series of breaking changes that target the long running harryb/long/type-simplification branch.

Why was this type variable there in the first place?

Just a mistake - I'm guessing I was mucking around with types and it was required in a previous iteration.

Will we be removing any of the other phantom type variables in Upgrade later?

It's a possibility, this PR was motivated by a specific excess constraint. A more general investigation can be performed and might reveal some extra redundancy.

You might want to update these docs (they seem to have an outdated version of Upgrade with only 3 tyvars).

This was intentional to simplify the documentation. There do seems to be some references to B here that can be removed though - I'll update it.


Cannot host external http service via container

Describe the bug
mongo-express is a container that is a UI for interacting with mongodb. Internal port is 8081, should load via http://localhost:8081. Cannot hit endpoint.
- name: mongo-express
  image: mongo-express
  env:
  - name: ME_CONFIG_MONGODB_ADMINUSERNAME
    value: root
  - name: ME_CONFIG_MONGODB_ADMINPASSWORD
    value: example
  bindings:
  - port: 8081
    protocol: http

Our logic tries to make the container based http port by default but maybe that's too aggressive. You can do 2 things to work around this for now:

Change port to containerPort - containerPort: 8081 - This will generate a random non-conflicting public port fix the containerPort to 8081.
Set both the port and containerPort to control both the exposed port and containerPort.

Setting both port and containerPort does not appear to be a solution in this scenario. The dashboard shows.
http://localhost:8081 (does not resolve) http://localhost:58257 (good!)
Used only the containerPort and http://localhost:58257 is presented and works.
- name: mongo-express
  image: mongo-express
  env:
  - name: ME_CONFIG_MONGODB_ADMINUSERNAME
    value: root
  - name: ME_CONFIG_MONGODB_ADMINPASSWORD
    value: example
  bindings:
  - containerPort: 8081
    protocol: http

here are the relevant logs:

Tell us what you think!
About
Logs for mongo-express
[mongo-express_742c31de-6]: docker run -d -v C:\Users\shboyer\AppData\Roaming\Microsoft\UserSecrets:/root/.microsoft/usersecrets:ro -e "DOTNET_ENVIRONMENT=Development" -e "ASPNETCORE_ENVIRONMENT=Development" -e "DOTNET_LOGGING__CONSOLE__DISABLECOLORS=true" -e "ASPNETCORE_LOGGING__CONSOLE__DISABLECOLORS=true" -e "ASPNETCORE_URLS=http://*:8081;http://*:8081" -e "PORT=8081;8081" -e "PROXY_PORT=8081:50357;8081:8081" -e "ME_CONFIG_MONGODB_ADMINUSERNAME=root" -e "ME_CONFIG_MONGODB_ADMINPASSWORD=example" -e "SERVICE__API__PROTOCOL=http" -e "API_SERVICE_PROTOCOL=http" -e "SERVICE__API__PORT=80" -e "API_SERVICE_PORT=80" -e "SERVICE__API__HOST=api" -e "API_SERVICE_HOST=api" -e "SERVICE__API__HTTPS__PROTOCOL=https" -e "API_HTTPS_SERVICE_PROTOCOL=https" -e "SERVICE__API__HTTPS__PORT=443" -e "API_HTTPS_SERVICE_PORT=443" -e "SERVICE__API__HTTPS__HOST=api" -e "API_HTTPS_SERVICE_HOST=api" -e "CONNECTIONSTRINGS__MONGO=root:example@mongo:27017" -e "SERVICE__MONGO-EXPRESS__CONTAINERPORT__PROTOCOL=http" -e "MONGO-EXPRESS_CONTAINERPORT_SERVICE_PROTOCOL=http" -e "SERVICE__MONGO-EXPRESS__CONTAINERPORT__PORT=8081" -e "MONGO-EXPRESS_CONTAINERPORT_SERVICE_PORT=8081" -e "SERVICE__MONGO-EXPRESS__CONTAINERPORT__HOST=mongo-express" -e "MONGO-EXPRESS_CONTAINERPORT_SERVICE_HOST=mongo-express" -e "SERVICE__MONGO-EXPRESS__PORT__PROTOCOL=http" -e "MONGO-EXPRESS_PORT_SERVICE_PROTOCOL=http" -e "SERVICE__MONGO-EXPRESS__PORT__PORT=8081" -e "MONGO-EXPRESS_PORT_SERVICE_PORT=8081" -e "SERVICE__MONGO-EXPRESS__PORT__HOST=mongo-express" -e "MONGO-EXPRESS_PORT_SERVICE_HOST=mongo-express" -e "APP_INSTANCE=mongo-express_742c31de-6" -e "CONTAINER_HOST=host.docker.internal" -p 50357:8081 -p 8081:8081 --name mongo-express_742c31de-6 --restart=unless-stopped mongo-express
[mongo-express_742c31de-6]: 31023363b66377b1b795d4b97d23671ff788d10749bd940d2ba50b65a5c76b6e
[mongo-express_742c31de-6]: docker network connect tye_network_4bd89e29-6 mongo-express_742c31de-6 --alias mongo-express

Both looks like this:
- name: mongo-express
  image: mongo-express
  env:
  - name: ME_CONFIG_MONGODB_ADMINUSERNAME
    value: root
  - name: ME_CONFIG_MONGODB_ADMINPASSWORD
    value: example
  bindings:
  - port: 8081
    containerPort: 8081
    protocol: http

Closing as I believed this is resolved.


Fix matrix attributes not sliced

In the R package, the user can provide additional information for the custom objective function by adding attributes to the DMatrix . xgb.cv relies on slice.xgb.DMatrix for slicing the folds.
However, those attributes are sliced only if they are vectors of same length as the DMatrix. In a multiclass problem, it makes sense to use a matrix instead of a vector for additional information about the classes.
MWE:
library(xgboost)

data(agaricus.train, package = "xgboost")

dtrain <- xgb.DMatrix(agaricus.train$data, label = agaricus.train$label)
attr(dtrain, "vec") <- getinfo(dtrain, "label")
nrow(dtrain)
#> [1] 6513
train_len <- length(attr(dtrain, "vec"))
attr(dtrain, "mat") <- matrix(runif(train_len * 2), nrow = train_len, ncol = 2)
length(attr(dtrain, "mat")) # != nrow(dtrain), will not be sliced
#> [1] 13026
dim(attr(dtrain, "mat"))
#> [1] 6513    2

dtrain <- slice(dtrain, 1:20)
length(attr(dtrain, "vec"))
#> [1] 20
attr(dtrain, "mat")
#> NULL

Created on 2019-03-29 by the reprex package (v0.2.1)
This PR fixes the issue by testing NROW instead of length and slices tabular attributes by row, similarly to what is done for the DMatrix itself.

Codecov Report

Merging #4311 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4311      +/-   ##
==========================================
+ Coverage   67.82%   67.82%   +<.01%
==========================================
  Files         132      132
  Lines       12201    12202       +1
==========================================
+ Hits         8275     8276       +1
  Misses       3926     3926

Impacted Files
Coverage Δ

src/tree/updater_colmaker.cc
39.68% <0%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea5b77...3ef8f1f. Read the comment docs.

Hi @hetong007 ,  could you help review this?

LGTM.


bazel: Add credential helper

Uses Bearer token in header auth.
Bug: NSL-3913

FOLLOWUP https://github.com/namespacelabs/foundation/pull/1318/files https://github.com/namespacelabs/foundation/pull/1319/files


[Parsing error] HASHES does not allow function call for now.

The following piece of code is not supported:
abc {
  content => template('toto')
}

In the grammar, HASHES does not allow function call for now.

@iwarapter: You can review PR https://github.com/iwarapter/sonar-puppet/pull/52

Merged. Many thanks.


feat: Add bytes serializer

Add new serde methods for aux param and downstream objects.
These are needed by the wasm runtime, which is very inefficient when using other forms of serialization like bincode/json, primarily due to the ck_primary object which is >100mb.
Related work in web-prover PR.

did you cmd + f and make every struct, enum, and field ever pub?
If not, we're ngmi
jk, onto reviewing


How to reference to an imported package-version (vanilla-cookieconsent)

I've found this in the documentation.

Can you explain more in detail, how does the path to JS and CSS file looks like, if you installed vanilla-cookieconsent as package (e.g npm or yarn) ?

Got it,
you need to use those imports:
import 'vanilla-cookieconsent/dist/cookieconsent';
import 'vanilla-cookieconsent/dist/cookieconsent.css';


quickcheck bounds

@nhibberd
this worth doing?

I think so :+1: /cc @jystic

Yep :triangular_flag_on_post:

I think we should merge this (after rebase) or I can do something similar in the other PR I have up for widen bounds, up to you @domdere ?
Having extra topic/ branches up on mismi makes jenkins sad is all

Closing, I'm including this in my version bounds PR


Constraint name uniqueness

At least on postgres, constraint names need to be globally unique.

Two constraints in different tables will result in one overwriting the other
If two constraints have long names, they will be truncated to 63 characters and one will overwrite the other

For reference, here is code we are using internally to generate unique constraint names. Using django.db.connection.schema_editor()._create_index_name() seems to be the most correct way of generating an index name, but it leaves a connection open (even though postgresql.operations.DatabaseOperations.max_name_length() is hardcoded to return 63 so there should be no reason it has to actually connect to the DB).
    """
    Generate a unique constraint name

    django_db_constraints simply truncates long constraint names which causes collisions.

    Ideally we would use django.db.connection.schema_editor()._create_index_name() but that seems to leave a dangling
    DB connections hanging around every time you call it(!) which causes dbreset to fail

    Instead we reimplement this using truncate_name. The output isn't as nice but we avoid the dangling DB connection
    issue.

    Note that postgres constraint names are global so we do need the db_table qualifier
    """

    # default postgres identifier length
    NAMEDATALEN = 64
    constraint_name = '__'.join([model._meta.db_table, identifier] + fields)
    constraint_name = truncate_name(constraint_name, NAMEDATALEN - 1, 4)
    return constraint_name

I'm not sure that it should necessarily be the responsibility of django-db-constraints to generate non-conflicting names (it is after all reasonably low-level) but it should at least warn/error out when it encounters colliding constraint names.


Update homepage layout

Implement the changes made in https://github.com/ZencashOfficial/myzenwallet/pull/41 in the source instead of in the generated static website.
This depends on the CI pull requests being merged and deployed.

Will assign @tuanhvdev once work can be started.


Change Background Color For Better Readabilty

Problem?
The background Color is black which reduces the readability.

How to solve this?
We can change the background color to white for better readability.
Example:

Hey @DivyanshuSonwal, I moved the issue to the right repository!
Sure think, I am assigning it to you! Thanks a lot 🙌

Thank you😄.

@DivyanshuSonwal can you post a link to where you found the issue please?

@DivyanshuSonwal can you post a link to where you found the issue please?
Yes, sure. Here are two examples, and there are many more. I am working on it, and as soon I update all the pages, I will create a PR for that.
https://keptn.sh/docs/concepts/automated_operations/
https://keptn.sh/docs/concepts/automated_operations/


jest v16.0.2 exit code is 0 (success) when coverage threshold is not met

Do you want to request a feature or report a bug?
bug
What is the current behavior?
jest ends with a 0 exit code when tests pass but coverage does not meet the threshold
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal repository on GitHub that we can npm install and npm test.
package.json excerpt:
{
  "jest": {
    "collectCoverage": true,
    "coverageThreshold": {
      "global": {
        "lines": 90
      }
    }
  }
}

Running jest, I see in red text:

Jest: Coverage for lines (7.69%) does not meet global threshold (90%)

But, echo $? still returns 0.
What is the expected behavior?
The exit code should not be 0.
Run Jest again with --debug and provide the full configuration it prints. Please mention your node and npm version and operating system.
jest version = 16.0.2
test framework = jasmine2
config = {
  "collectCoverage": true,
  "coverageThreshold": {
    "global": {
      "lines": 90
    }
  },
  "rootDir": "/Users/ron/GitHub/jokeyrhyme/boxen-notify.js",
  "name": "-Users-ron-GitHub-jokeyrhyme-boxen-notify.js",
  "setupFiles": [],
  "testRunner": "/Users/ron/GitHub/jokeyrhyme/boxen-notify.js/node_modules/jest-jasmine2/build/index.js",
  "scriptPreprocessor": "/Users/ron/GitHub/jokeyrhyme/boxen-notify.js/node_modules/babel-jest/build/index.js",
  "usesBabelJest": true,
  "automock": false,
  "bail": false,
  "browser": false,
  "cacheDirectory": "/var/folders/mx/_pq4c8yx2nl1h05ht_w2m1y40000gn/T/jest",
  "clearMocks": false,
  "coveragePathIgnorePatterns": [
    "/node_modules/"
  ],
  "coverageReporters": [
    "json",
    "text",
    "lcov",
    "clover"
  ],
  "globals": {},
  "haste": {
    "providesModuleNodeModules": []
  },
  "mocksPattern": "__mocks__",
  "moduleDirectories": [
    "node_modules"
  ],
  "moduleFileExtensions": [
    "js",
    "json",
    "jsx",
    "node"
  ],
  "moduleNameMapper": {},
  "modulePathIgnorePatterns": [],
  "noStackTrace": false,
  "notify": false,
  "preset": null,
  "preprocessorIgnorePatterns": [
    "/node_modules/"
  ],
  "resetModules": false,
  "testEnvironment": "jest-environment-jsdom",
  "testPathDirs": [
    "/Users/ron/GitHub/jokeyrhyme/boxen-notify.js"
  ],
  "testPathIgnorePatterns": [
    "/node_modules/"
  ],
  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.jsx?$",
  "testURL": "about:blank",
  "timers": "real",
  "useStderr": false,
  "verbose": null,
  "watch": false,
  "cache": true,
  "watchman": true,
  "testcheckOptions": {
    "times": 100,
    "maxSize": 200
  }
}

Node.js 6.9.1
npm 3.10.8
macOS Sierra

I've had a look at this and had a go at a possible solution: https://github.com/facebook/jest/pull/1974

This will be fixed in #1974.

Yay, thanks!


[FEATURE] Add Anthropic LLM support via Anthropic Python SDK

📥 Pull Request
📘 Description
This PR adds functions in the llm_tracker.py file for the asynchronous and synchronous Anthropic SDK support. An example notebook anthropic_example under examples/anthropic is also added to demo the integration.
🎯 Goal
To extend the AgentOps capability to the Anthropic LLMs.
🔍 Additional Context
Tool Calling in Anthropic Python SDK seems flaky and might not result in correct responses,
🧪 Testing
Tested using the provided example notebook.
Thank you for your contribution to Agentops!

@bboynton97 can you please help me test this?

@bboynton97 @areibman This is ready for review!

Unfortunate timing for this PR. @bboynton97 is currently splitting llm_tracker.py into multiple files for readability. When that merge goes through, we'll make some changes to make this one work

Unfortunate timing for this PR. @bboynton97 is currently splitting llm_tracker.py into multiple files for readability. When that merge goes through, we'll make some changes to make this one work

I'd like to help, would be good for me to understand the working of the software in detail and I can use that information to draft a contributing guidelines document and/or observe where tests are needed.

Unfortunate timing for this PR. @bboynton97 is currently splitting llm_tracker.py into multiple files for readability. When that merge goes through, we'll make some changes to make this one work

I'd like to help, would be good for me to understand the working of the software in detail and I can use that information to draft a contributing guidelines document and/or observe where tests are needed.

This is the PR in question: https://github.com/AgentOps-AI/agentops/pull/346
From your end, this would just mean splitting the Anthropic handlers into its own file. The tricky part is just merging those changes from that branch into yours.

@HowieG Can you add the Anthropic notebook to the smoke test suite?

Unfortunate timing for this PR. @bboynton97 is currently splitting llm_tracker.py into multiple files for readability. When that merge goes through, we'll make some changes to make this one work

I'd like to help, would be good for me to understand the working of the software in detail and I can use that information to draft a contributing guidelines document and/or observe where tests are needed.

This is the PR in question: #346
From your end, this would just mean splitting the Anthropic handlers into its own file. The tricky part is just merging those changes from that branch into yours.

Cool, I will look into it and find a solution.

Unfortunate timing for this PR. @bboynton97 is currently splitting llm_tracker.py into multiple files for readability. When that merge goes through, we'll make some changes to make this one work

I'd like to help, would be good for me to understand the working of the software in detail and I can use that information to draft a contributing guidelines document and/or observe where tests are needed.

This is the PR in question: #346
From your end, this would just mean splitting the Anthropic handlers into its own file. The tricky part is just merging those changes from that branch into yours.

Cool, I will look into it and find a solution.

I rebased and refactored the code. I believe that this PR should merge to llm-handler-refactor if that's where the changes are right now.

hey @the-praxs! thank you for reworking this, it looks fantastic! i'm going to go ahead and merge this into the llm-handler-refactor like you set it up to do and make sure you get credit on the subsequent PR as well :)
thank you for your work here! its very appreciated


Add warning for variant effect prediction when ref base does not match reference genome

We currently do not have error handling for the case where the ref base in a VCF file does not match the base at the specified position in the reference genome.
A user should be notified when this situation is observed. Selene should output a warning when at least 1 such case is detected. Furthermore, Selene should output predictions/scores for those variants into separate file(s) so that a user has the option of using those predictions if they wish but are also made aware that mismatches were observed for these variants.
Currently, Selene uses the ref base specified in the VCF file without checking against the reference sequence. When we implement the warning mentioned above, Selene will continue to use the ref base when outputting predictions but will specify in the warning message what the reference genome base was so that users can choose to correct their VCF and re-run Selene for those variants if it seems appropriate.

Addressed in #65


Update HTML CSS in free-programming-books-id

Add HTML CSS E-book in Free Programming Books
What does this PR do?
Add Resource(s)
For resources
Description
Fundamental of HTML and CSS
Why is this valuable (or not)
It's helping beginners to learn HTML and CSS from scratch.
How do we know it's really free?
It's free for real based on their description and download link.
For book lists, is it a book?
It's a book, actually e-book
Checklist:

[x] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[x] Needed indications added (PDF, access notes, under construction)

welcome to free-programming-books!

thank you! 😄


Ship v0.3.0

[Enhancement] Introduce cache_provider option.

https://github.com/civitaspo/embulk-filter-expand_json/pull/41

Coverage remained the same at 95.984% when pulling 05b530019b19331aeafae4f2af696b65e08b70f9 on 0.3.0 into 2351f7b4a0fe2f0284a4ece0b95172eefba88839 on master.


Implement texture padding in TileSetAtlasSources

This PR adds an opt-out setting to atlases, making them generate an internal texture with padding between each tile (extending each tile with a 1px margin around). This avoids the common artifact we have with visible seems between the tiles.
We have lot of issues opened about this problem, though they are for 3.x:
https://github.com/godotengine/godot/issues/47932
https://github.com/godotengine/godot/issues/45047
https://github.com/godotengine/godot/issues/41900
https://github.com/godotengine/godot/issues/39720

I'm not sure if we need to expose an option to allow using a larger margin than 1 pixel. This may be needed if you have mipmaps enabled and the camera can zoom out by a 2× factor or more.

Hmm, I don't think it's needed. Mipmaps are worth when you have a lot of textures, but I don't think it makes sense in a lot of 2D games, and I am not sure they would work well with tilemaps anyway.
Also, in that case, I am not even sure the float precision error could lead to a 2 pixel error within the source texture. In the current situation, the error happen because the rect to draw if very close to the next one, so precision errors are in a sub-pixel magnitude. To have an error of one pixel seems really unlikely to me.
I think the better approach is to merge things with a boolean first, and, if some user end up with situations where this is not enough, we could replace it by an integer.

Tested here, it's working great. I tested with different camera zooms too.
I also tested the mipmaps for completion's sake, with the corresponding texture filter options on the tilemap node: no seams.

Thanks!


Cannot rekey private folder, fails silently ...

[write something useful and descriptive here]
my log id: 7f01c8860f7f1b95384fdf1c

@ericbechet looks like the rekey happened successfully shortly after you sent this.  Everything look ok now?

Thanks for your reply --- but no. Indeed, my own private folder is and was fine, but I've shared a private folder with someone else, and that particular folder asks for a rekey, which I am unable to perform...

In fact I just saw the following thread, I think it is the same issue :
https://github.com/keybase/client/issues/14896#issue-386528069
I revoked a bunch of keys because of device changes/reinstall, same thing...


BuildSystemManager fileBuildSettingsChanged fixes for dropped notifications

Fix two bugs that caused dropped notifications

If we registered a header, but not its main file then called fileBuildSettingsChanged([]) (where empty means assume everything changed) it would not propagate the notification.
If we unregistered the last user of a given main file and then received a fileBuildSettingsChanged that explicitly mentioned that main file we would drop all other settings changes from the same notification.

@swift-ci please test


Hiera.new(:config => 'path/to/my/test/hiera.yml') throws ArgumentError

Followed the README.md and got this:
`initialize': wrong number of arguments (1 for 0) (ArgumentError)

Tried various things in various combinations and couldn't succeed in loading test hiera data. I have two yaml files in spec/ (didn't want to drop to spec/fixtures/ because of .gitignore rules):
spec/hiera.yaml
---
:backends:
  - yaml
:hierarchy:
  - users
:yaml:
  :datadir: '.'

spec/test.yaml
user_accounts:
  ubuntu:
    ensure: absent
  fakeuser:
    ensure: present
    gid:  testgroup
    groups: [mygroup1, mygroup2]
group_accounts:
  testgroup:
    ensure: present

spec/spec_helper.rb
require 'puppetlabs_spec_helper/module_spec_helper'

RSpec.configure do |c|
  c.add_setting :hiera_config, :default => 'spec/hiera.yaml'
end

spec/classes/myclass_spec.rb
require 'spec_helper'

describe 'users' do
  context 'supported operating systems' do
    ['Debian', 'RedHat'].each do |osfamily|
      describe "users class without any parameters on #{osfamily}" do
        hiera = Hiera.new(:config => 'spec/hiera.yaml') ## <--- errors out on this line
        user_accounts = hiera.lookup('user_accounts', nil, nil)
        group_accounts = hiera.lookup('group_accounts', nil, nil)
        let(:params) {{
          :user_accounts => user_accounts,
          :group_accounts => group_accounts,
        }}
        let(:facts) {{
          :osfamily => osfamily,
        }}

        it { should compile.with_all_deps }

        it { should contain_class('users') }
        it { should contain_class('users::params') }
        it { should contain_class('users::config').that_notifies('users') }

      end
    end
  end
end

I'm probably doing something wrong, so please let me know what if anything. Thank you!

For the record, the add_setting in spec_helper was just a shot in the dark. I had hoped to get everything just in the class spec so I could isolate to unit testing versus acceptance testing

I ran into the same issue. Adding:
require 'hiera'

to the top of my spec_helper.rb fixed it for me.

Try:
:hierarchy:
  - test

or rename test.yaml into users.yaml.

Re-reading the hiera section in the README, this still needs a overhaul.

I can't get this to work in any possible way.
require 'spec_helper'
require 'hiera'

describe 'profile::pupa::users' do
  let(:hiera_config) { 'spec/fixtures/hiera/hiera.yaml' }
  hiera = Hiera.new(:options => :hiera_config)
  [..]
end

hiera-3.0.1/lib/hiera/config.rb:31:in `load': Config file /etc/puppetlabs/code/hiera.yaml not found (RuntimeError)

What? Where does that file suddenly come from?
Without require 'hiera you get this on the Hiera.new call
`initialize': wrong number of arguments (1 for 0) (ArgumentError)

Alright, lets not pass :hiera_config to it then
     Failure/Error: :humans => hiera.lookup('s_key_str')
     NoMethodError:
       undefined method `lookup' for #<Hiera:0x007f8ecfac4148>

So what? Now we have a hiera thing without the lookup method, WTF is going on? Lets add puts hiera.methods and see what that gives us:
!
!=
!~
<=>
==
===
=~
__id__
__is_a__
__metaclass__
__send__
_method
class
class_def
clone
daemonize
define_singleton_method
display
dup
enum_for
eql?
equal?
expects
extend
freeze
frozen?
gem
hash
inspect
instance_eval
instance_exec
instance_of?
instance_variable_defined?
instance_variable_get
instance_variable_set
instance_variables
is_a?
kind_of?
meta_def
meta_eval
meta_undef
method
method_exists?
methods
mocha
mocha_inspect
nil?
object_id
private_methods
protected_methods
psych_to_yaml
public_method
public_methods
public_send
remove_instance_variable
reset_mocha
respond_to?
send
should
should_not
singleton_class
singleton_method
singleton_methods
stubba_method
stubba_object
stubs
taint
tainted?
tap
to_enum
to_json
to_matcher
to_pson
to_s
to_yaml
to_yaml_properties
trust
unstub
untaint
untrust
untrusted?

hiera::lookup instead of hiera.lookup did the trick for me