[ISSUE #7396] Fix wrong word in BrokerController#doResterBrokerAll

Which Issue(s) This PR Fixes

Fixes #issue_id
Brief Description

How Did You Test This Change?

Codecov Report

Merging #7397 (a9b3bd5) into develop (d7e5c4d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #7397      +/-   ##
=============================================
- Coverage      42.53%   42.53%   -0.01%
+ Complexity      9441     9439       -2
=============================================
  Files           1150     1150
  Lines          82746    82746
  Branches       10778    10778
=============================================
- Hits           35196    35193       -3
- Misses         43139    43141       +2
- Partials        4411     4412       +1

Files
Coverage Δ

...a/org/apache/rocketmq/broker/BrokerController.java
44.22% <0.00%> (ø)

... and 12 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Trying to instantiate multiple copies of good-file for logging. Tons of files generated and then app crashes

I have a complex web app where I'm trying to generate multiple log files for the various modules included. When I try to run the webapp, my log directory fills up with ~4000 files within a few seconds of starting and crashes. I'm expecting 3.
Running on Node v0.12.4 on a Mac.  I use Confidence and Glue to put my server together. Attached is the logging part of my manifest.js:
        'good': {
            opsInterval: 60000, // how often to report mem/cpu/load stats
            reporters: [
                {
                    // console logging
                    reporter: require('good-console'),
                    events: { log: '*', error: '*', request: '*', response: '*' /*, ops: '*' */ }
                },
                {
                    // file logging
                    reporter: require('good-file'),
                    events: { log: '*', error: '*' },
                    config: {
                        path: Config.get('/logging/path'),
                        prefix: 'app-log',
                        rotate: 'weekly'
                    }
                },
                {
                    // file logging - incoming requests
                    reporter: require('good-file'),
                    events: { log: ['collector', 'incoming'], error: ['collector', 'incoming'] },
                    config: {
                        path: Config.get('/logging/path'),
                        prefix: 'incoming-log',
                        rotate: 'monthly'
                    }
                },
                {
                    // file logging - mail
                    reporter: require('good-file'),
                    events: { log: 'mailer', error: 'mailer' },
                    config: {
                        path: Config.get('/logging/path'),
                        prefix: 'mailer-log',
                        rotate: 'monthly'
                    }
                }
            ]
        }

The error message that I get is this repeated over and over again for all of my log files:
{ [Error: EMFILE, open 'logs/mailer-log-2015-05-28-79eac3dfee.log']
  errno: -24,
  code: 'EMFILE',
  path: 'logs/mailer-log-2015-05-28-79eac3dfee.log' }

This problem also occurs when I have 2 good-file reporters enabled, but not when I have 1 enabled.

timeMap was missing 'monthly' causing my app to crash. Submitted pull request #60 as a fix.


Nav bottom bar would be very good

At the moment there exist topbar but it is quite difficult to get it to stick to the bottom of the page.
I think this is a common requirement, so having this component (or similar component that sticks to the bottom) out of the box would be very beneficial.
This is how bootstrap handles this usecase:
http://getbootstrap.com/components/#navbar-fixed-bottom

While I don't disagree with you that a footer nav bar is useful, it won't be a feature add for Foundation 5. If you would like to see something like this for Foundation 6, please take a look at it, I think you should be able to do it without much difficulty.


feat: add tag display to Segment

A little background: At the moment, I am developing Homepage/Dashboard and of course there was a need for time tracking. Your plugin has come in handy, but based on our needs, need to somehow synchronize the data in the tracker with other analytics and tasks. The easiest way was to use tags. Adding them to Segment was not a problem, but visually it was terrible.
This PR is aimed precisely at adding a visual display of tags in the Segment field (since we work with code block, there are some implementation nuances). I tried to minimally interfere with the standard functionality of the plugin, so the code turned out to be practically independent.
I doubt that the functionality is very interesting, but maybe it will be useful to someone, and for the development of the plugin.

Yes, everything is correct. This PR adds a visual part just for regular Obsidian tags.  If there is a need and you like my implementation, I can add the link formatting as requested in #25.

Yes, also supporting links in the segment display would be lovely!
Does this implementation also support having multiple tags in a segment name, or having a segment name that consists of text and a tag together?

Unfortunately, I did not even think about this functionality.
Currently, the tag is checked only at the beginning of Segment and only in the amount of one.
In this case, I suggest closing this PR.
I will add all the necessary functionality and let you know.
List of functionality:

Obsidian hashtag - #tag
Link - [link](link)
Multiple hashtag and links in Segment field
Combining text and link/tag = #tag1 text1 #tag2 [link1](link) text2

Did I forget anything?

In addition, if I find a way, I will add support for Markdown in general

Yes, I think those features would be necessary for me to be comfortable merging this PR, as otherwise, a lot of users might be confused as to why their tags only work sometimes - I think in a case like this, it's better not to have this feature at all, than to have it only work some of the time.
The list you sent sounds great, and it's pretty much what I had in mind for #25.
I also think it would be nice if the tags were discoverable through search, and through the tag list core plugin thing, but I think that's automatically taken care of due to the fact that the tag will be displayed #withTagSyntax in the underlying JSON data, as well. I'm not sure if tags in code blocks get picked up, though.

In addition, if I find a way, I will add support for Markdown in general

I was thinking that it might just be possible to enable CodeMirror support and/or use a special CodeMirror box for the segment name, but I've yet to check if Obsidian's API has builtin functionality for that (something like a "CodeMirrorTextBox", or whatever).
Thanks so much for your work on this pull request! If you're interested in implementing the feature list you mentioned, feel free to do it as a part of this pull request and just convert it to a draft in the meantime :)

After reading a lot of documentation and code of other plugins, the solution turned out to be quite simple - to add to Segment column a work with all the possibilities of Obsidian markdown (but only those that work on one line). Also added a test file with Markdown formatting.
The only nuance that I noticed (regarding tags), when clicking on a tag inside the tracker, there is a transition to the search, and there it does not find this tag in our tracker codeblock, only those outside it (outside codenlock). Of course this is treated by replacing tag:#tag with #tag in search input. From what I learned, this is most likely the specifics of work in codenlock. I still don't know how to fix it...

I think I'm okay with the codeblock thing for now, this is still a very useful addition to the project. Given tags didn't work at all before, this is a good compromise, I think! Thanks so much for your hard work on this :)


Fix model unpatching process when running on CPU

Summary
The model patching/unpatching optimization introduced in #6439 does not work when image generation is executing on the CPU, leading to scrambled images on subsequent generations. This PR disables the optimization when running on CPU.

Related Issues / Discussions
See #6559 and a PR that solves the problem with a config option #6628

QA Instructions
Using CPU rendering, apply a LoRA and run the generation twice. On the second run, the image should not be scrambled looking.

Merge Plan
Merge when approved.

Checklist

[X] The PR has a short but descriptive title, suitable for a changelog
[ ] Tests added / updated (if applicable)
[ ] Documentation added / updated (if applicable)

Thanks, prefer this to a config option.


Update usage example for PRs originating in forks

GitHub severely limits what access the default GITHUB_TOKEN for a PR originating from a fork has, which prevents the default configuration of this action from successfully posting the report as a PR comment. You can see an example failure here.
The README should be updated so that the example also works for this scenario.

Closed by 44e3c0573ccb249bc6cebae0593bcc8d054fc5d5


is JS tree available in angular2

is JS tree available in angular2

There is no built in directive provider, there are a few third party providers, like this one: https://github.com/ezraroi/ngJsTree


Address mTLS support across Steeltoe core components

This is an epic to follow the work involved in properly handling mTLS needs in our core components.

Hello,
mtls for discovery service was implemented in PR: https://github.com/SteeltoeOSS/Discovery/pull/43

3.0.0 milestone 2 contained - #205, #208


Single server LiveKit deploying fails

Hello, we followed this documentation: https://docs.livekit.io/deploy/vm/
We are trying to deploy a single node LiveKit on DigitalOcean by using Docker but not success. Do we miss something?

Create Ubuntu Docker droplet
Run docker run --rm -it -v$PWD:/output livekit/generate
Enter domain info, choose internal redis, and latest version of LiveKit (it gives API key and access token at this point)
DNS configurations for main domain and subdomain are correct
Open ports in firewall config
Restart server

No success. When we run “systemctl start livekit-docker” it gives “Failed to start livekit-docker.service: Unit livekit-docker.service not found.” error. And it looks like /opt/livekit folder is missing.
Any ideas?

@oarsoy, the generator is meant to be ran on your dev machine. it'll generate a shell script (or cloud-init) that can be passed to the VM during bootup. Digital Ocean supports cloud-init, so you'll want to: (from docs):
When starting a VM, paste the contents of the file cloud-init.xxxx.yaml into the User data field.

That's it! When the machine starts up, it'll execute the cloud-init protocol and install LiveKit.


Example for trace gen

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#666  👈
#665
#663
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shaharsamocha7 and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 60.52632% with 75 lines in your changes missing coverage. Please review.

Project coverage is 91.94%. Comparing base (f142cba) to head (07cee49).

Files
Patch %
Lines

crates/prover/src/trace_generation/example.rs
60.52%
75 Missing :warning:

Additional details and impacted files
@@                     Coverage Diff                     @@
##           06-16-ComponentRegistry     #666      +/-   ##
===========================================================
- Coverage                    92.52%   91.94%   -0.58%
===========================================================
  Files                           72       73       +1
  Lines                         9213     9403     +190
  Branches                      9213     9403     +190
===========================================================
+ Hits                          8524     8646     +122
- Misses                         611      679      +68
  Partials                        78       78

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


completed the tasks

Checklist
Required changes:

[x] Center the description (Line 17 in HTML file) using a single change in CSS
[ ] Fix JS so that when the search is executed, the search engine is not present in query
[x] Add Google Drive, Google Slides and Google Sheets as a provider

Optional changes:

[x] Add other search providers (GitHub, Spotify, etc)
[x] Additional CSS styling (as you like)

Want to see hosted version


Passing an object with a custom toString() as a 'class' attribute

I am writing a library using objects with a custom toString() method to render class names. Simplified example:
const object = {
  toString() {
    return computeClassNames();
  },
  //  ... other data
};

element.className = object;

It works great on plain DOM and React, but can't work with Preact because if a class attribute is an object, it will use the object enumerable keys associated with a truthy value to format the classname.
I understand why you chose to do this, and I find it quite useful. But would you consider changing the condition to format the class objects to something like:
if (lastSimple && lastSimple.toString === Object.prototype.toString) {
    attributes.class = hashToClassName(lastSimple);
}

or (might be more robust)
if (lastSimple && String(lastSimple) === '[object Object]') {
    attributes.class = hashToClassName(lastSimple);
}

or (not the cleanest but might be more efficient)
if (lastSimple && Object.prototype.toString.call(lastSimple) === '[object Object]') {
    attributes.class = hashToClassName(lastSimple);
}

I could change my library to return an object with keys as class names, but I'd prefer not to add code specific to preact.
Thank you

@BenoitZugmeyer I'm actually toying with the idea of dropping support for Object class values.  If I did, would this method begin to work?  It would simply be removing these three lines:
https://github.com/developit/preact/blob/master/src/dom/index.js#L27-L29

Just tried commenting those lines, and yes it works as I expect. (Sorry my fix suggestions were on an older version of preact)

heh yeah things are moving quickly around here 😅
I'll add this to my list of nails in the coffin of built-in object class support. Removing it saves some bytes (~150) and speeds things up a tad.

@developit the change @BenoitZugmeyer is proposing should also allow glamor to be used with preact. https://github.com/threepointone/glamor/blob/master/src/index.js#L235-L237

Oooh that's huge, I am actually looking into glamor right now haha. We might need to have a 7.1 and then immediately an 8.x release though, dropping object class prop support is definitely a breaking change.

Came here looking for this since I am using glamor on my personal site. If this change lands, it would be great to get this over on preact-render-to-string also to support SSR.

Absolutely, should be seeing this land very soon. Cheers!

So, I tested Preact 8 in a small project of mine, and I found a single issue, related to this ticket. The class attribute is ignored if its value is an object and the element is SVG.
Test case:
  <svg class={{ toString() { return "pwet" } }} />

This is because of this test. I tried to search the history the reason of this condition, it has been introduced in 8ff9e325912251628d17a45fa827e60ad2abdea3 without any explaination. Would it be possible to remove the typeof value!=='object' &&  part?

I'm not even sure why function test is there. Just do toString() (variable + '') to everything and pass to attribute (unless void/null/false of course).

setAttribute is doing it anyway

I guess some IE or older Android or whatever webkit may reject such direct objects passing and that's why there is a check. Assuming browser does everything right could be a wrong path :-)

We can definitely remove the object check, that'll save bytes and it's actually totally superficial - it was added to avoid setting <div foo="[object Object]">, but doing so isn't really an issue.
The function check is to prevent this, so we'll likely want to keep it:

@developit makes sense :-)

Here we go: https://github.com/developit/preact/pull/626


Current Combinations considered invalids in TW

Why current combinations are displayed twice? One as the valid name, and the other as a combination (considered invalid when it is not an invalid name, with the orange background).

In this example, this is the object Zoniopoda tarsata
https://sandcastle.taxonworks.org/tasks/nomenclature/browse?taxon_name_id=17371
And this other object is the combination for this Taxon Name
https://sandcastle.taxonworks.org/tasks/nomenclature/browse?taxon_name_id=162021
This is confusing and mostly when displayed in Taxon Pages.

It is not that we don't have info. It is that in Taxon Pages the current combinations appear as invalids. But they are not. That is not correct.

It is not very clear the display. Mostly so in TaxonPages. i really doubt that the public will understand why there are two identical Combination names, one invalid:
https://jlpereira.github.io/taxonpages_osf/#/otus/124675/overview
the other valid:
https://jlpereira.github.io/taxonpages_osf/#/otus/17336/overview
Is there any way that we can only show the current valid combination in TaxonPages

I already asked to make an automatic redirect to the valid page for any search in TaxonPages.

Closing for: https://github.com/SpeciesFileGroup/taxonpages/issues/11


Deprecate callbacks in field types

Deprecate following field definition form:
[
    'name' => 'Foo',
    'fields' => [
        'bar'  => ['type' => function()  use(&$barType) { return $barType;}],
        'baz'  => ['type' => function()  use(&$bazType) { return $bazType;}],
    ]
]

in favor of:
[
    'name' => 'Foo',
    'fields' => function() use (&$barType, &$bazType) {
        return [
            'bar' => ['type' => $barType],
            'baz' => ['type' => $bazType],
        ];
    }
]

Is there any reason why? What's the motivation behind this change?

This seems redundant. Also first notation adds some performance overhead because every field type has to be checked with is_callable and then validated against base Type class.
Pretty much everything you can do with first notation can be done with second as well. Also that's how reference js implementation works. It turns out that maintaining this library is way easier when there is little deviation from reference implementation (at least until things settle down with GraphQL itself).
But if you have any use-cases which require this feature - please describe them. That's pretty much the reason why I created these issues - to start a discussion if somebody needs them %)

:+1: for this change! it will be much more easier to implements dynamics fields without having to used hacks.

Done in https://github.com/webonyx/graphql-php/commit/c11f25794a16863ad727c844ca9083bf1cb3c3d1

must compliment you guys for referincing this issue in the actual error message! :1st_place_medal:

Is there any chance the first notation could be permitted once again ?
We have a library that uses this and json models in order to build a loopback-like php graphql api factory.
Having to move the callback to the fields rather than the type of each field would greatly complicate things since the field is linked to the middleware-connector pipeline during field construction. Here's a link to the concerned code : https://github.com/ampize/alambic/blob/master/src/Alambic/Alambic.php

@Alexandru-Dobre We can discuss it, but first I would like to figure out why it is impossible to change the code of your library for this notation (as it is also the only way reference js implementation allows you to define fields). I am pretty sure there should be a way to do this.
What will happen if you change these lines to:
$typeArray = [
    'name' => $type['name'],
    'fields' => function() use ($type) {
        $fields = [];
        foreach ($type['fields'] as $fieldKey => $fieldValue) {
            $fields[$fieldKey] = $this->buildField($fieldKey, $fieldValue);
        }
        return $fields;
    }
];
if (!empty($type['description'])) {
    $typeArray['description'] = $type['description'];
}
$this->alambicTypes[$typeName] = new ObjectType($typeArray);

Obviously you will have to remove closure for type option in buildField (it is also quite possible that you will have to wrap remaining code of this method to same closure as well).
Why this will not work?

@vladar Thank you for the suggestion! It worked perfectly with minimum changes to our library code. The rest of the method doesn't need closures as only the "fields" part was exposed to a cyclic dependency issue (models for SQL databases had foreign keys pointing to each other) since we automatically exclude non-scalar fields as query args.

Nice!

I don't think this is a good idea, you can add lazy loading with all fields, but please don't deprecate callbacks in field types. Some time I need to build a object class like this, and make it extendable, you can modify the field you need and add some other field. But with the closure for fields, you must copy all the fields code.
namespace demo;

class Types
{
    // Types register
}

class BasicMsg extends ObjectType
{

    public function __construct(array $_config = [], $type = null)
    {
        if (is_null($type)) {
            /** @var Types $type */
            $type = Types::class;
        }
        $config = [
            'description' => "base msg extendable",
            'fields' => []
        ];

        $config['fields']['msg_id'] = [
            'type' => $type::nonNull($type::ID()),
            'description' => "msg id",
        ];

        $config['fields']['msgContent'] = function() use ($type) {
            return [
                'type' => $type::MsgContentUnion([], $type),  // type MsgContentUnion have circular types of BasicMsg
                'description' => "msg content",
            ];
        };

        if (!empty($_config['fields'])) {
            $config['fields'] = array_merge($config['fields'], $_config['fields']);
        }
        parent::__construct($config);
    }
}

namespace app;

class Types extends \demo\Types
{
    // rewrite types if you need
}

class BasicMsg extends \demo\BasicMsg   // class extends BasicMsg  and register in Types
{

    public function __construct(array $_config = [], $type = null)
    {
        if (is_null($type)) {
            /** @var Types $type */
            $type = Types::class;
        }
        $config = ['fields' => []];

        $config['fields']['msgContent'] = function() use ($type) {
            return [
                'type' => $type::MsgContentUnion([], $type),  // this MsgContentUnion maybe another Type register in Types whit the same name
                'description' => "msg content",
            ];
        };

        // you can add more fields
        $config['fields']['room_id'] = [
            'type' => $type::nonNull($type::Int()),
            'description' => "room id",
        ];

        if (!empty($_config['fields'])) {
            $config['fields'] = array_merge($config['fields'], $_config['fields']);
        }
        parent::__construct($config);
    }
}


Short event life option

This adds a variable in .env, SCHEDULER_EXPIRATION_CHECK. The default value of normal runs expiration checks as they currently exist. Setting the value to frequent adds an option for each agent to keep events for "A minute" and does expiration checks every 3 minutes.
This is useful for running high-volume agents on something like Heroku where the free database is limited.

I see your use case, however I have the feeling that this adds a lot of conditionals for a very special case.
How about we change the interval for cleanup_expired_events! to once an hour and add an hourly retention schedule? That would still allow about 150 events per second to be created on the free Heroku plan. You could then convert EVENT_RETENTION_SCHEDULES to minutes and avoid the conditionals.
@cantino What do you think about this?

@stvnrlly, what's the smallest cleanup period that would meet your needs?  Would every 6 hours work, or every 3?  Is the problem that you have a small database?

One of the major reasons that I like frequent cleanup here is that it allows me to still see other events on the events page. With less frequent cleanup, nearly every event is from this one high-volume agent, making it difficult to check the output of other agents at a glance.
As for the actual limitations of the system, 6 hours is probably sufficient to keep under the limit, but it depends on how many of these types of agents I'm running and what the agents it feeds do. I can imagine having several of these real-time agent flows generating events, which decreases the total storage available to each. I've also added a peak detector to my setup, which also takes up a fair amount of memory even without generating events.
Perhaps a better approach is to have the .env option be the interval for cleanup rather than a preset. That way, I could set it to 3, while somebody with lower volume could set it to 360 or just leave it as the default.

Here's the scenario if you want to see what I'm actually doing here. (You might notice that the peak detector has a new option to set the initial wait period, which I haven't opened a PR about yet.)
{
  "name": "USA Analytics",
  "description": "No description provided",
  "source_url": false,
  "guid": "76ba563751b9fe13bd71122cdc015b7e",
  "tag_fg_color": "#ffffff",
  "tag_bg_color": "#5bc0de",
  "exported_at": "2015-04-29T14:06:53Z",
  "agents": [
    {
      "type": "Agents::PeakDetectorAgent",
      "name": "USA Analytics - Visitor Peak",
      "disabled": false,
      "guid": "92c225c63a3b7ba0aeddf59b3be09e4b",
      "options": {
        "expected_receive_period_in_days": "5",
        "group_by_path": "site.page",
        "value_path": "site.active_visitors",
        "message": "Hey! More people than usual ({{site.active_visitors}}) are on {{site.page}}",
        "window_duration_in_days": "30",
        "min_peak_spacing_in_days": "2",
        "std_multiple": "4",
        "wait_period": {
          "type": "days",
          "value": "7"
        }
      },
      "keep_events_for": 0,
      "propagate_immediately": true
    },
    {
      "type": "Agents::DataOutputAgent",
      "name": "USA Analytics - RSS Feed",
      "disabled": false,
      "guid": "d3ee1ddbe8c75d98c579fa5b324b25c8",
      "options": {
        "secrets": [
          "topfederalsites"
        ],
        "expected_receive_period_in_days": 2,
        "template": {
          "title": "Top Federal Sites",
          "description": "This is a feed of new entries to the Top 20 sites on analytics.usa.gov",
          "item": {
            "title": "{{ site.page }}",
            "description": "New site: {{ site.page_title }} with {{ site.active_visitors }} visitors",
            "link": "http://{{ site.page }}"
          },
          "link": "https://twitter.com/topfederalsites"
        }
      },
      "keep_events_for": 7,
      "propagate_immediately": true
    },
    {
      "type": "Agents::DeDuplicationAgent",
      "name": "USA Analytics - Deduplicator",
      "disabled": false,
      "guid": "1232d55c7ff619715dff4e44d56a5e7e",
      "options": {
        "property": "{{site.page}}",
        "lookback": "1000",
        "expected_update_period_in_days": "10"
      },
      "keep_events_for": 0,
      "propagate_immediately": true
    },
    {
      "type": "Agents::WebsiteAgent",
      "name": "USA Analytics - Live Feed",
      "disabled": false,
      "guid": "62c65edbaf04ef0d3be448fe633135b2",
      "options": {
        "expected_update_period_in_days": "2",
        "url": "https://analytics.usa.gov/data/live/top-pages-realtime.json",
        "type": "json",
        "mode": "all",
        "extract": {
          "site": {
            "path": "data[*]"
          }
        },
        "unzip": "gzip"
      },
      "schedule": "every_1m",
      "keep_events_for": 60,
      "propagate_immediately": true
    },
    {
      "type": "Agents::TwitterPublishAgent",
      "name": "USA Analytics - Tweet events",
      "disabled": false,
      "guid": "f790fd83d0bf3d8d19a9678644f2028d",
      "options": {
        "expected_update_period_in_days": "10",
        "message": "{{ message }}"
      },
      "keep_events_for": 0,
      "propagate_immediately": true
    },
    {
      "type": "Agents::EventFormattingAgent",
      "name": "USA Analytics - New Site Tweet Formatter",
      "disabled": false,
      "guid": "c36924f21b8c813734ce4140db6f6140",
      "options": {
        "instructions": {
          "message": "New site in the Top 20! Welcome to {{ site.page }} ({{ site.page_title | truncate: 60, 'â€¦' }}) with {{ site.active_visitors }} visitors"
        },
        "matchers": [

        ],
        "mode": "clean"
      },
      "keep_events_for": 0,
      "propagate_immediately": true
    }
  ],
  "links": [
    {
      "source": 0,
      "receiver": 4
    },
    {
      "source": 2,
      "receiver": 1
    },
    {
      "source": 2,
      "receiver": 5
    },
    {
      "source": 3,
      "receiver": 2
    },
    {
      "source": 3,
      "receiver": 0
    },
    {
      "source": 5,
      "receiver": 4
    }
  ]
}

I think it would be reasonable to just change the cleanup period to 3 hours for Huginn, and perhaps to add filtering options to the events page?

Sure, that's fine. I'd just ask that the interval be set via a configurable .env option, to allow people to scale it in either direction.

That works for me.  Want to make that change?

:+1:

@stvnrlly Just to clarify, are you making a PR that lowers the period on cleanup_expired_events! in huginn_scheduler.rb to a default of 3 hours, settable in .env, or would you like me to?  I wasn't sure if you were expecting me to or not, and I'm certainly happy to.

Okay, I think that the last commit is what's needed to make it happen. I thought about adding some more options to EVENT_RETENTION_SCHEDULES in agent.rb when the cleanup schedule is set to lower values, but that seemed trickier as the current options don't differentiate between hours or days. If you want to take a crack at that (if you want to add those options), that would be helpful.

Hmm, I just checked Travis's spec failure locally and can't reproduce it, so hopefully that's just a false positive.

Coverage decreased (-3.83%) to 84.8% when pulling 38a5dbfd879d7ab9b9aaa204d96bb6f05e5c8339 on stvnrlly:master into db63908c915982c40b80a88b07772405a45d3cc2 on cantino:master.

This looks close @stvnrlly.  What's left to do?

Unfortunately, it looks like the change to the cleanup time is causing a bunch of spec script failures. I fixed a few of the more obvious ones, but I wasn't able to tell why the others are failing.

Here are some of the files that look like they still need updating:

spec/fixtures/agents.yml
spec/models/agent_spec.rb
spec/models/scenario_import_spec.rb

I'm not sure which keep_events_for need to be updated to x.days and which ones should stay as-is, and changing them all doesn't seem to resolve the spec failures. So, I'd appreciate if somebody else could take a look.

Okay, I'll take a look at this soon and see if I can see what else needs to be changed.

Sent you this PR that gets the specs green.
https://github.com/stvnrlly/huginn/pull/2
Once merged, we can do some manual QA.  This ended up complicated!

How did that look @stvnrlly?

@cantino it looks good, as far as a I can tell, but I haven't had the opportunity to give it a test run yet :disappointed:. I'll be able to do that by this Sunday.

Sounds good.  You can merge it into your branch so that the final PR is
testable.
On Thursday, June 4, 2015, stvnrlly<EMAIL_ADDRESS>wrote:

@cantino https://github.com/cantino it looks good, as far as a I can
tell, but I haven't had the opportunity to give it a test run yet [image:
:disappointed:]. I'll be able to do that by this Sunday.
—
Reply to this email directly or view it on GitHub
https://github.com/cantino/huginn/pull/808#issuecomment-108940685.

Oh, yeah. I was thinking that I should test it myself, but it makes a lot more sense to let Travis take care of that.

Coverage increased (+0.18%) to 88.82% when pulling 6bf6d0d6672000b9ca0b89e3c32700ef7b2e1e9a on stvnrlly:master into db63908c915982c40b80a88b07772405a45d3cc2 on cantino:master.

@dsander Would you mind giving this a once-over?

Apart from the minor inconsistency it looks good to me.

I haven't been using that branch in production, but I can switch over and give it a shot.

I still need to manually test the Scenario code before this is mergable, but having you test the event handling would be good.

@cantino I've been running this branch for a couple of days now. At first, I had to manually update a bunch of the Keep events for options, but that may be because I had previously been using my own hack to provide shorter times and therefore had non-standard values. I still have one agent giving me a Validation failed: Keep events for is not included in the list error and am having a hard time figuring out which one it is, but otherwise everything appears to be running normally.

Replaced by #923.


track current Revel version

Along with git tagging, we should add a VERSION file in the root of the revel package and expose it to Revel apps.

Also #474

Having it in a version.txt file file solved a lot of porblem with flightgear... compiling docs, cmake et all...
In the meantime, one possibility for the docs is to use a data file..
like
https://github.com/pedromorgan/revel.github.io/blob/pedro/_data/version.yaml
and appears on the homepage
http://revel-docs.daffodil.uk.com/

@pedromorgan I really like that YAML file idea. Is that a jekyll feature? Can it read from remote domains?

yes the _data directory is a jekyll feature..
http://jekyllrb.com/docs/datafiles/
Dont think it will work on remote domain, but could be scripted I suppose
On 5 January 2015 at 22:17, Brenden Soares<EMAIL_ADDRESS>wrote:

@pedromorgan https://github.com/pedromorgan I really like that YAML
file idea. Is that a jekyll feature? Can it read from remote domains?
—
Reply to this email directly or view it on GitHub
https://github.com/revel/revel/issues/418#issuecomment-68792171.

The PR#858 may not be perfect, but it's present. Closing.


Asking chat to translate a python program to C++ generates infinite, repeating #include lines

VS Code Version: 1.83.1
OS Version: Win 10 Pro 22H2
Logs: How do I get these?

Steps to Reproduce:

Edit: Easier reproduction:
Use this as a prompt to trigger the infinite repeating #include lines:
Can you help me use mediapipe in C++ to build a simple pose estimation program that reads from the webcam, puts the image through mediapipe pose estimation, overlays the result onto the image, and then display the augmented image?

Ask Copilot Chat to translate the python program below to C++ (optionally tell it not to repeat #include lines, only use minimal ones
Stop the answer before it kills your RAM and completely stalls vscode

The program in question:
import cv2
import mediapipe as mp

# Create a pose object
mp_pose = mp.solutions.pose
pose = mp_pose.Pose()

# Create a video capture object
cap = cv2.VideoCapture(1)

# Define a callback function for mouse events
def mouse_callback(event, x, y, flags, param):
    if event == cv2.EVENT_LBUTTONDOWN:
        # Save the image and mediapipe output
        cv2.imwrite('image.png', img)
        with open('output.txt', 'w') as f:
            f.write(str(results.pose_landmarks))
        print('Image and output saved successfully!')
        # Exit the program
        cv2.destroyAllWindows()
        cap.release()

# Create a window to display the image
cv2.namedWindow('MediaPipe Pose')
# Set the mouse callback function for the window
cv2.setMouseCallback('MediaPipe Pose', mouse_callback)

# Loop over each frame from the camera
while True:
  # Read a frame from the camera
  ret, img = cap.read()
  # Check if the frame is valid
  if not ret:
    break
  # Convert to RGB
  img_rgb = cv2.cvtColor(img, cv2.COLOR_BGR2RGB)
  # Process the image and get the pose landmarks
  results = pose.process(img_rgb)
  # Draw the landmarks on the image
  mp_draw = mp.solutions.drawing_utils
  mp_draw.draw_landmarks(img, results.pose_landmarks, mp_pose.POSE_CONNECTIONS)
  # Show the image
  cv2.imshow('MediaPipe Pose', img)
  # Wait for a key press or exit if 'q' is pressed
  if cv2.waitKey(1) & 0xFF == ord('q'):
    cap.release()
    cv2.destroyAllWindows()
    break

Ok it's even easier, just put in this prompt:
Can you help me use mediapipe in C++ to build a simple pose estimation program that reads from the webcam, puts the image through mediapipe pose estimation, overlays the result onto the image, and then display the augmented image?

This should be fixed, please let me know if you still encounter the bug!

Works fine now, thanks!


Fix TestAPIDockerAPIVersion on windows

Fixing my own mistake 😅.
PS: this causes all windowsRS1 build to fail (master, PRs) so, should be merged quick 👼 🙏
/cc @thaJeztah @AkihiroSuda @johnstep
🦁
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

windowsRS1 is green 💚

Janky failed on 09:16:10 FAIL: docker_cli_push_test.go:608: DockerRegistryAuthTokenSuite.TestPushMisconfiguredTokenServiceResponseError, which is identified and being worked on 😉

haha, you fix one, but got bitten by the other one

Let's merge are the failures are being worked on 👼


Connecting the python code to microsoft teams bot

Hello,
I am using this python code - https://docs.microsoft.com/en-us/azure/bot-service/python/bot-builder-python-quickstart?view=azure-bot-service-4.0 to make a basic bot. It uses the botbuilder libraries.
I have created a bot on microsoft teams. I got the app id and app password. I have used it in the above python code. Do I need to do anything else to connect this python code to the MS Teams bot?
Thanks!

@aniztar, no that should just about cover it. I'm going to close this issue as it's a "How-to" question and therefore belongs on Stack Overflow (where you already posted it, so thanks!). You're also already getting a lot of support from the community there, which is why we recommend "How-to" questions to be posted there!
For actual bugs, feature requests or enhancements with the SDK please feel free to file them here.
Cross linking Stack Overflow question.


Jalextowle/audit 06 10 2024/spearbit 10

Resolved Issues
Fixes: https://github.com/spearbit-audits/delv-week-review/issues/10
Description
Used openzeppelin's abs function. This addresses the concern from the issue without resorting to returning an invalid value.
Review Checklists
Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity, the corresponding checklist can
be removed.
[[Reviewer Name]]

[ ] Tokens

[ ] Do all approve calls use forceApprove?
[ ] Do all transfer calls use safeTransfer?
[ ] Do all transferFrom calls use msg.sender as the from address?

[ ] If not, is the function access restricted to prevent unauthorized
token spend?

[ ] Low-level calls (call, delegatecall, staticcall, transfer, send)

[ ] Is the returned success boolean checked to handle failed calls?
[ ] If using delegatecall, are there strict access controls on the
addresses that can be called? It shouldn't be possible to delegatecall
arbitrary addresses, so the list of possible targets should either be
immutable or tightly controlled by an admin.

[ ] Reentrancy

[ ] Are functions that make external calls or transfer ether marked as nonReentrant?

[ ] If not, is there documentation that explains why reentrancy is
not a concern or how it's mitigated?

[ ] Gas Optimizations

[ ] Is the logic as simple as possible?
[ ] Are the storage values that are used repeatedly cached in stack or
memory variables?
[ ] If loops are used, are there guards in place to avoid out-of-gas
issues?

[ ] Visibility

[ ] Are all payable functions restricted to avoid stuck ether?

[ ] Math

[ ] Is all of the arithmetic checked or guarded by if-statements that will
catch underflows?
[ ] If Safe functions are altered, are potential underflows and
overflows caught so that a failure flag can be thrown?
[ ] Are all of the rounding directions clearly documented?

[ ] Testing

[ ] Are there new or updated unit or integration tests?
[ ] Do the tests cover the happy paths?
[ ] Do the tests cover the unhappy paths?
[ ] Are there an adequate number of fuzz tests to ensure that we are
covering the full input space?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 92.139%

Files with Coverage Reduction
New Missed Lines
%

contracts/src/libraries/LPMath.sol
1
83.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
1969

Relevant Lines:
2137

💛  - Coveralls


Redo the upper-right hand corner UI - should have color of current token. Current token should be topmost visibility

Potentially look into different set of positions for different tokens


WinAppDriver not supporting to switch to Alert

==========================================
GET /session/D083E1CC-017A-4D84-A8A6-77F3D36DC5C1/alert_text HTTP/1.1
Accept: application/json
Accept-Encoding: identity
Content-Type: application/json;charset=UTF-8
Host: <IP_ADDRESS>:4723
User-Agent: selenium/3.141.0 (python windows)
WinAppDriver::CommandHandler::Session::HandleCommandAsMidPoint - Command alert_text is not recognized
HTTP/1.1 404 Not Found
Content-Length: 146
Content-Type: application/json
{"status":9,"value":{"error":"unknown command","message":"Command not recognized: GET: /session/D083E1CC-017A-4D84-A8A6-77F3D36DC5C1/alert_text"}}
On trying to switch to Alert in a WPF application above error is thorwn.
Please provide fix for it.
Thanks in Advance.

can you post the code how you are trying to switch to the Alert prompt?

I have used below packages:
from selenium.webdriver.common.alert import Alert
from selenium.webdriver.remote.switch_to import SwitchTo
Usuage:
alert =self.winAppdriver.switch_to.alert
alert.accept()
I am trying to switch to alert in my WPF application.
Please let me know if this is correct.
Thanks,
Uma

Any update on this help.
Thanks


oneko: 1.2.sakura.5 -> 1.2.hanami.6, and change upstream

Motivation for this change
As of approximately a year ago, I am the upstream maintainer of Oneko. The previous version was released in 1999. Per the README, every version has been by a different maintainer. I did attempt to contact the previous one, but since there was no response, I think it's entirely in the spirit of the project to consider my version the latest. I like to think of it as similar to those piles of stones, where each hiker who passes adds one more.
Things done
Update Oneko to version 1.2.hanami.6. Add myself as a second nixpkgs maintainer for it.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[X] Fits CONTRIBUTING.md.

So while I very much appreciate the work, the license part makes this pr somewhat questionable.
I think some people might not want unfree (even if it is redistributable) software on their systems, so I think that we will want to either

keep both the original and the new one, so ppl can choose
or you may want to change the license of the new version to something like [gpl,mit,bsd,..] (not sure what your stance on this is)

Yeah, so I added that not because I've changed anything but because I think it was incorrectly classified to begin with. It's one of those strange copyright scenarios that were common in the 90s, before everyone got used to digital rights stuff. My code additions are released into the public domain, but unfortunately the software has always contained various trademarked and copyrighted characters. The README documents that the owners of the art have given permission to use it, but I don't think it's properly described as free.
If I'm being too nitpicky, I'm happy to drop the unfreeRedistributable and let things to back to the status quo of not being examined too closely... I think this program is culturally significant and I don't want to cause trouble for it by asking inconvenient questions.

Ah, thanks for explaining the reasoning!
debian classifies it as public domain (https://metadata.ftp-master.debian.org/changelogs//main/o/oneko/oneko_1.2.sakura.6-14_copyright) and they are usually very careful with these kind of things, so it should be fine I think.

I appreciate your diligence. I put this together a while ago and had forgotten I added that part. Sorry about the confusion. Anyway, I set it back to just publicDomain; please take a look. :)

@ofborg eval


How to do getText() with MAC native application?

We want to fetch some string from path , but it is returning null


Added fallback to filename when font name couldn't be parsed

Just added a simple fallback in case the font name could not be parsed properly (we have such font here, homemade).
Haven't been able to debug the lime code directly, so meanwhile I though that fallback could be helpful

The same thing is required on HxProject !
I just discovered that later today...


Add React v16.6.0 blog post

Why we don't introduce the maxDuration option and nested Suspense, and ...., is it intentional?

maxDuration is only relevant in concurrent mode (which isn't stable yet).
Not sure what you mean about nesting here but we're open to PRs.


Need Cube Trained Tessdata for tesseract 3.04.

Hi,
Please help me out to get the lang.cube.* files for other language. right now we have cube for French, Eng hindi. Please give you valuable suggestion to get cub.* file for portugese, spain, etc.,

Please use tesseract user forum for asking support.


Override one field of list in --set

Output of helm version: 2.13.1
Output of kubectl version: 1.14.6
Cloud Provider/Platform (AKS, GKE, Minikube etc.): 1.14.7-eks
I've seen some other issues sort of relating to this but nothing that really gives me hope this is possible. Any help would be great.
We have about ~100 deployments/cronjobs we're managing in our clusters via helm that we've built. We're now trying to bring up new environments by using a "super" chart that has all of our apps in it to deploy it all at once.
However our cronjobs can be multi instance so we decided to have each helm chart be a list of jobs to setup on cron. Here's a subset of the top level values.yaml:
myapp-v1:
  targetcluster: "cluster"
  configBranch: "testBranch"
  jobs:
  - name: mycron
    image:
      repository: gcr.io/myapp
      tag: develop
      pullPolicy: IfNotPresent
    #schedule is in UTC time
    schedule: "00 16 * * *"
    command: '["/bin/sh", "-c"]'
    args:
      - |
        trap 'exit_status="$?" ; touch /app/myapp/logs/term ; exit "$exit_status"' EXIT
        java -Duser.timezone=America/New_York -jar -Xmx1024m *.jar
    restartPolicy: Never
    failedJobsHistoryLimit: 1
    successfulJobsHistoryLimit: 3
    startingDeadlineSeconds: 600
    activeDeadlineSeconds:
    concurrencyPolicy: Forbid
    backoffLimit: 0
    resources:
      requests:
        memory: "1024Mi"
        cpu: "1"
      limits:
        memory: "2048Mi"
        cpu: "1.5"

We want to be able to deploy this chart and just change the version being deployed / upgraded but it seems this isn't possible without putting all of this list in the --set command. I've tried to template this and use --set myapp-v1.jobs[0].image.tag=testing123
It renders but it overwrites the entire list to only have the image.tag and nothing else and it won't deploy successfully. Is there any option to get this working? Is this supposed to work already?

Arrays are one of those corner cases where it cannot be modified. Consider the following case:

I have an array [1,2,3,4]
I want to merge it with [4,5,6]

The request is ambiguous; do you want to completely replace 1234 with 456? A join (1234456)? Or a boolean addition (123456)?
If we did a join, there would be no way to remove values from the list. A boolean addition would also result in the same limitation.
In order to remove objects from the list, the only merge strategy is to perform a full replacement. It's unfortunate but no other merge strategy allows you to remove objects from the list.

Closing as answered. Please feel free to request this issue to be re-opened if you have further questions. Thanks!

Hello @bacongobbler ,
I'm having the same problem and I tried to use a dictionary instead but the dictionary doesn't keep the order of the items.
So is there any way to loop over items in their original appearance in values.yaml and at the same time have the ability to override them ?


MAX_UDP

Hi !
I have a question: why do you limit max udp message size in nksip_connection module ?
-define(MAX_UDP, 1500).
When we send SIP INVITE with big sdp nksip force to use tcp connection. Why?
We've removed the limitation and the udp message was fragmented , which was expected situation due tu Ethernet MTU. It worked.

Hi,
From RFC3261 18.1.1:
"If a request is within 200 bytes of the path MTU, or if it is larger than 1300 bytes and the path MTU is unknown, the request MUST be sent using an RFC 2914 [36] congestion controlled transport protocol, such as TCP. If this causes a change in the transport protocol from the one indicated in the top Via, the value in the top Via MUST be changed. This prevents fragmentation of messages over UDP and provides congestion control for larger messages. However, implementations MUST be able to handle messages up to the maximum datagram packet size. For UDP, this size is 65,535 bytes, including IP and UDP headers."
What do you mean with "fragmented"? NkSIP should not be able to accept "fragmented" messages, if a incoming UDP does not have all the SIP first line and headers it will be rejected... It worked?


Can't lpad OpenCV library which is required by SimpleCV

[#7#wangx@wangxiang-PC:~]$sudo apt-get install python-scipy python-numpy python-pygame python-setuptools python-pip python-opencv
Reading package lists... Done
Building dependency tree
Reading state information... Done
python-opencv is already the newest version.
python-pygame is already the newest version.
python-scipy is already the newest version.
python-numpy is already the newest version.
python-setuptools is already the newest version.
python-pip is already the newest version.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
[#8#wangx@wangxiang-PC:~]$simplecv
Traceback (most recent call last):
File "/usr/local/bin/simplecv", line 9, in
load_entry_point('SimpleCV==1.3', 'console_scripts', 'simplecv')()
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 558, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 2682, in load_entry_point
return ep.load()
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 2355, in load
return self.resolve()
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 2361, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/usr/local/lib/python2.7/dist-packages/SimpleCV-1.3-py2.7.egg/SimpleCV/init.py", line 3, in
from SimpleCV.base import *
File "/usr/local/lib/python2.7/dist-packages/SimpleCV-1.3-py2.7.egg/SimpleCV/base.py", line 59, in
raise ImportError("Cannot load OpenCV library which is required by SimpleCV")
ImportError: Cannot load OpenCV library which is required by SimpleCV
ubuntu:14.04
python:2.7.6

I create a new virtual machine. And do the same thing, I can import cv2.cv in the virtual machine, but I can't import cv2.cv on my self computer. I tried to uninstall python-opencv and reinstall python-opencv, but it didn't work ethier.

My cv2's version is 3.1.0, and the cv2 in the virtual machine is 2.4.8. It seems that we can't import cv2.cv in the latest Opencv version. But the SimpleCV is using the cv. Is there any thins I miss or just because the SimpleCV can't support the latest python-opencv?  I'm using SimpleCV 1.3.0

I am also facing same issue .
I installed simpleCV from the superpack and get the same error after installation .
Platform : Windows
Python : 2.7.6

Here too! :/
Traceback (most recent call last):
  File "background.py", line 10, in <module>
    from SimpleCV import *
  File "/Library/Python/2.7/site-packages/SimpleCV-1.3-py2.7.egg/SimpleCV/__init__.py", line 3, in <module>
    from SimpleCV.base import *
  File "/Library/Python/2.7/site-packages/SimpleCV-1.3-py2.7.egg/SimpleCV/base.py", line 59, in <module>
    raise ImportError("Cannot load OpenCV library which is required by SimpleCV")
ImportError: Cannot load OpenCV library which is required by SimpleCV

Please try installing opencv 2.4.


No Internet on iPhone after setting the Proxy

After I set the proxy in my iPhone (having already installed the certificate in the iphone correctly) and having both the mitm proxy server and frontend server running. I can't log in to the Pokemon Go application using Wi-Fi, if I use LTE I can connect normally.
*Having done more tests, when I have the proxy on the phone active, I don't have internet via Wi-Fi at all.
Any ideas of what is going on?

Are you positive that you entered the correct ip address for the proxy?

Yes I am pretty sure I did. It is really weird, any ideas of what could be happening?

I had the exact same issue. Apparently IOS has problems when it comes to quite a bit of network code (I've encountered issues like it in other scenarios). Some random combination of hard reboots and entering the proxy address finally got it to work for me. After it worked once, it's worked constantly since.
Sadly I have no step by step solution, since I really didn't do anything aside from reboots and entering the proxy again and again. :/

It's not just iOS- I now have the same issue on Android. When I first installed Optimizer (I'm pretty sure it was 1.0.0) and got it all set up, all my traffic from my phone went through the proxy with no issues except being a bit slow. I could see all the server requests in the Terminal, though.
When I was trying to figure out how to pull 1.1.0 earlier today, I broke some things and wound up uninstalling a number of things and doing them over from scratch. I generated and installed a new CA certificate as part of that process, just like in the initial install. While Optimizer 1.1.0 is now running as written, I no longer see ANY server/traffic requests in the Terminal, and PoGo is the only application that manages to connect to the internet. All other apps on my phone show that they have no connection.
I'm not going to mess with it because it's only a slight inconvenience for me right now, but I wanted to mention that this is not limited to iOS devices.
I'm on Android 6.0.1, June security patch, running stock on a Nexus 5.

Not being able to use other apps is pretty annoying, but it's probably just a side-effect of the proxy. I'm not sure how we'd remedy that.
As of a couple versions ago, the pokemon-go-mitm library no longer logs traffic, so that's not a particularly good indicator of a problem.

It's working for me now. I installed from the latest commit and it works.

Im getting the same problem now, i can access hostip:3000 on my phone, and i have downloaded the certificate. But after setting up the proxy with the IP (I even check on my router what it was) and entered 8081 on port. I dont have any access to the internett, besides hostip:3000.


[FEAT]: Publish moc/studies on arneis.readthedocs.io

Description
The MOC studies for ARNEIS are not yet published on https://arneis.readthedocs.io
Please configure docs/index.rst to show them.
Additional Information
No response

Please see:
LEGO® MOC studies


cssEase not working

The cssEase from the docs does not work.
I've tried it with this piece of code on the latest build:
$(document).ready(function() {
    $('.fade').slick({
        dots: true,
        infinite: true,
        speed: 800,
        fade: false,
        slide: 'div',
        cssEase: 'cubic-bezier(0.950, 0.050, 0.795, 0.035)'
    });
});

It's exactly the same as using it without the cssEase.

Hello !
I had the same issue so I came back to v1.8.5 and it's working well.
I think it's related to last commits involving cssTransform property

The latest version is 1.5.9, how are you on 1.8.5?

Oops! I meant 1.5.8

I tried it with 1.5.8 and it still didn't work.

I use bower to get slick : "slick-carousel": "1.5.8"
And then, I call slick by this lines :
var slider = $('#slider'),
params = {};
params.cssEase = 'cubic-bezier(0.18, 0.89, 0.32, 1.28)';
slider.slick(params);
Be sure you have the right version !

I got it working with 1.5.8, hopefully they'll update the plugin so it will work in the latest stable version.

Cool ! You can stay at this version until they fix that issue ;)

Related to #1950
might be fixed with useTransform defaulting to true now

Just to let you know that on your website download package, this bug remains - no css3 transitions by default: https://github.com/kenwheeler/slick/archive/1.5.9.zip

Same issue with bower, I had 1.5.9. though transitions weren't working using this fix above.
Downloading straight from the master branch here worked for me.

Hello!
I've found, that on the 1885 line, there is this block:
if (bodyStyle.WebkitTransition !== undefined ||
bodyStyle.MozTransition !== undefined ||
bodyStyle.msTransition !== undefined) {
if (_.options.useCSS === true) {
_.cssTransitions = true;
}
}
But chrome has dropped the prefix, so it is Transition now without Webkit.

@Hozeee somewhat commonly used older versions of android mobile still need the prefix:
http://caniuse.com/#search=transform
@GijsGoudzwaard @Michkkael did you check the useTransform: true  fix? I'm going to close this for the time being, since it seems like it's a dup, but if that still doesn't work after that fix it'd be great to get it recreated in a fiddle.Thanks!


[rlgl] Expose rlglData RLGL

I am currently writing a little extension for rlgl (support for texture arrays).
For this is need to query ExtSupported texture formats.
Would it be possible to make rlglData RLGL accessible from the outside?
In order to prohibit external manipulation, just pass a copy?
Something like:
rlglData GetCurrentConfiguration() {
    rlglData copy;
    copy = RLGL;
    return copy;
}

Maybe just return RLGL.ExtSupported ?

@Crydsch No plans to expose the full RLGL data but maybe ExtSupported in some way.

Sound fine to me. That would be great!

@Crydsch In any case, do not expect it for next release. Maybe for the following ones. No priority to review that part, neither to add textures arrays support.

No worries. I just came across this trying to write a little extension to make texture arrays work.
Would be great to be able to query supported formats like the rlLoadTexture(..) function.

My immediate reaction, would be yeah great for advanced user, but exposing what amounts to internal global variables is probably not a great idea!
For the future, it might be nice if an end user could (somehow?) request access to specific GL extensions, obviously this would be for advanced users....

The problem is, when you want to program on a framework like OpenGL, you need to know what you are doing...  So you can't just hide stuff from developers in the hopes they never ask about it, because they will...  Or they spent the time to do it themselves, or they quit altogether...

Just redesigned rlLoadExtensions() to expose supported OpenGL extensions if SUPPORT_GL_DETAILS_INFO is enabled on config.h. If an advance user requires to check for specific extensions to implement specific OpenGL functionality, it can be done using GLAD directly.


Added a lookup method that uses an identifier to create an icon

Issue was discussed in #53, the idea is to be able to create icons using the string identifiers associated with the icons. I added an error to fit the Swift structure. The error is set when identifier is not found in allIcons.
I updated the generator scripts to automatically be able to generate the methods.

The readme file might need some modification based on PR #65

looks like there are conflicts with master?

What are the conflicts?
How can I help?

Gabriel, thanks for you work.
Below comments, there is 'branch has conflicts' badge

You should make pull from PrideChung:master, resolve conflicts and push to GabrielCartier:master. Then, PR can be merged.

Just pushed an update. I did the merge request with the latest version, everything is now merge-able.
Let me know if there is anything.


VRT dependencies out of ISCE interferogram stack?

Hi,
I am enjoying testing this.
Following https://github.com/isce-framework/fringe/blob/master/docs/workflows.md I am having some issues with tops2vrt.py
number of SLCs discovered:  0
we assume that the SLCs and the vrt files are sorted in the same order
creating directory: slcs
write vrt file for each SLC ...

Which I think relates to https://github.com/isce-framework/fringe/blob/5db5d7cb6f7915fab529df53b9068301794008ae/python/tops2vrt.py#L100
The SLC folder in my stack contains
20201007/20201007.slc.full.vrt
20201007/20201007.slc.full.xml
20201019/20201019.slc.full.vrt
20201019/20201019.slc.full.xml
20201031/20201031.slc.full.vrt
20201031/20201031.slc.full.xml

And so the .slc.full search doesn't find anything.
Is there perhaps a mismatch with my ISCE versions? Or my interferogram workflow?
I did hack it to try and fix it but I am not convinced everything was working in the later steps.
Advice invited.

You actually have to create a .slc.full with gdal_translate out of the .vrts. We build VRTs of the stack for use within FRINGE to organize images as bands of a stack and ministacks. If we point to the .slc.full.vrt files - these themselves point to individual burst VRTs - leading to a large number of files being left open when working with a stack - often exceeding os limits.
The ideal workflow is stack is generated and you preserve full res outputs for geometry, and coregistered SLCs (merged) - and then you can clean up the stack folder and all intermediate products. You then proceed onto fringe with just these products.

Thanks.
I was able to stackSentinel.py ... -W slc -c all to generate these missing files. I expect there was probably a quicker way to use my existing stack.
Then I found http://earthdef.caltech.edu/boards/4/topics/3735?r=3736#message-3736
Now the last step of Fringe is catching me
integratePS.py -s coreg_stack/slcs_base.vrt -d adjusted_wrapped_DS/ -t Sequential/Datum_connection/EVD/tcorr.bin -p ampDispersion/ps_pixels -o PS_DS --unwrap_method snaphu

And running the shell script
snaphu v1.4.2
Reading wrapped phase from file PS_DS/20201218_20210123.int
No weight file specified.  Assuming uniform weights
Reading correlation data from file PS_DS/tcorr_ds_ps.bin
NaN or infinity found in correlation data
Abort

I wonder if I need to handle NoDataValue somewhere in the process?
Thanks.

Hi @piyushrpt as a side note I am unable to register for http://earthdef.caltech.edu/projects/isce_forum I think something is broken.
I tried a gmail and then another email address. When I click on the activation link in the email:
_Internal error
An error occurred on the page you were trying to access.
If you continue to experience problems please contact your Redmine administrator for assistance.
If you are the Redmine administrator, check your log files for details about the error._
I mention it as it looks like you are listed as a Manager of the forum, and I could not find any forum help contacts on the page.
Cheers.

No clue. Must be something simple like preprocessing and filtering our nan values in the temporal correlation file used for unwrapping.

Many thanks. I will spend some time inspecting the output along the processing pipeline.


⚠ Spryr has degraded performance

In ad735e1, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 6112 ms

Resolved: Spryr performance has improved in c29c432 after 7 minutes.


mapper: add mmc1 unit test

Codecov Report

Merging #145 (8560097) into main (86ebb78) will increase coverage by 0.82%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   49.96%   50.78%   +0.82%
==========================================
  Files         125      125
  Lines        9009     9015       +6
==========================================
+ Hits         4501     4578      +77
+ Misses       4273     4201      -72
- Partials      235      236       +1


Team #2 Review (VnV Report): Insufficient Usability Testing Data

@samm82
Summary
The usability testing data only shows the averaged answers of the questions, and no further reports. The VnVPlan specifies that there should be at least 20 people who tested, but it is unclear if this was fulfilled. In addition, it is unclear if these tests found satisfactory results or required more user input besides the 3/5 outlined for Test-UH8.

Deadline
April 4th
Estimated Work Hours
2hr

Resolved in commit id: 568eaf36bff32562880f71833df3a7b0f09f68a8


Model Cold Storage and user manual management possibility

model management
its nearly impossible to manage models by manual method, and it generates hash values,
what i was trying to do was to move some models to cold storage, ie HDD, and some to SSD. but couldnt find a way rather than full repo movement , and im faced with this

its take lot of time to do this type of management due to sheer volume of transfer, and why does one model generate 100s of blobs? cant it be stored to a folder per model rather than littering everywhere? my best bet is to check date modified time and perform the job.
proposed
 ollama archive <model_name> <Disk_or_path>
ollama pull <Disk_or_path> will show options which models to revive to cache.
urgent request
observations
some users reported that ollama pull takes long time #2850 #5361 etc, i suspect the nature of SSDs to avoid creation of huge reserved space, as first few seconds in task manager it shown 1GB/s , then fall to 200, the pathetic 5MB/s. it could be the write protection mechanism. maybe chunked download and merge? or use huggingface like loader like _part001 _part002 for layers loading?
@bmizerany @drnic @anaisbetts @sqs @lstep

@nikhil-swamix Please do not CC random people in GitHub issues.

A model shouldn't generate 100s of blobs.  Do the files have a suffix?  That might indicate a failed download, re-pulling the model might help.
All of the blobs that make up a model are listed in the model manifest, a simple shell script would be able to use that information to manage the blobs (eg, copy to a new location and symlink back to to the blob store).
I have noticed the transfer slow down you mention, it looks to me like that traffic is being rate limited at the source.  I find that if I stop and restart the pull, the download rate saturates my link.

@nikhil-swamix Please do not CC random people in GitHub issues. I am not a maintainer on this project.

sorry about it, your name showed as default @ which usually active users come in that list. any inconvenience is regretted.

A model shouldn't generate 100s of blobs. Do the files have a suffix? That might indicate a failed download, re-pulling the model might help.
All of the blobs that make up a model are listed in the model manifest, a simple shell script would be able to use that information to manage the blobs (eg, copy to a new location and symlink back to to the blob store).
I have noticed the transfer slow down you mention, it looks to me like that traffic is being rate limited at the source. I find that if I stop and restart the pull, the download rate saturates my link.

yes, after re pull they vanish.
currently i do the Hot Cache to fastest storage available via this command
Move-Item "F:\Models\ollama\blobs\sha256-5ff0abeeac1d2dbdd5455c0b49ba3b29a9ce3c1fb181b2eef2e948689d55d046" "D:\Models\ollama\blobs\"

New-Item -ItemType SymbolicLink -Path "F:\Models\ollama\blobs\sha256-5ff0abeeac1d2dbdd5455c0b49ba3b29a9ce3c1fb181b2eef2e948689d55d046" -Target "D:\Models\ollama\blobs\sha256-5ff0abeeac1d2dbdd5455c0b49ba3b29a9ce3c1fb181b2eef2e948689d55d046"

D drive is M2 SSD.
Im on powershell windows, and the reason being the M2 is 2GBPS, which loads in few seconds, but hdd is 200MBps, which takes about a minute, and ollama having default timeout of 5 mins does no justice to continue extensions, where i have to manually curl "keep_alive:-1" or set env variables for timeout. regardless it will be a great QOL improvement to have managable storage locations. i can do the above commands per model basis, but identifying the hash is difficult, and have to check model manifests if multiple 7B models with similar sizes are present... is identifying models blobs using sizes is not feasible in file explorer.

as i understand you are active here and have greater understanding of this project,
@mxyng @dhiltgen , if this is not planned please closed the issue, i will try to accomplish using some tkinter python script to manage model storage.


feat(v2): Provide type definitions for remaining theme-classic components

Motivation
Continue the work from #3348 to provide type definitions for all remaining theme-classic components. After this PR, theme-classic is now fully typed and we can start recommending users to also include /// <reference types="@docusaurus/theme-classic" /> in their website's types.d.ts, which I will do in another PR.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Everything type checks.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

👍


bugfix: webpage theme is now consistent across page reloads

Description
Fixed the issue at #1131, where the current theme of the website is lost when you reload the page. So, if I change my theme to dark mode, it won't persist across the page reload.
Related Issues
#1131
Changes Proposed

properly implemented the useTheme hook in the sideBar component
removed the redundant and insufficient state management in the sidebar component for the theme.
fixed spelling errors
changed default theme from dark to light
moved the updating of the localStorage from toggleTheme function to the useEffect

Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[ ] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@dylan-dot-c make dark as default

@shyamtawli will do

@shyamtawli is there something wrong? Why haven't this pr been merged yet?


Wraps string values in quotes when using a string array

This PR is related to PR #39. But, now string values in an array are wrapped in quotes.
What was generated before:
static let arrayOfHashes: [String] = [abcdefg] // Won't compile

Generated after fix:
static let arrayOfHashes: [String] = ["abcdefg"]

Actually, I'm not sure I've got that quite right. Going to close it for now.

This is now fixed by #42. You can grab the latest release from https://github.com/theappbusiness/ConfigGenerator/releases


Fixed typographical error, changed accomodate to accommodate in README.

asciidoctor, I've corrected a typographical error in the documentation of the asciidoctor-pdf project. You should be able to merge this pull request automatically. However, if this was intentional or you enjoy living in linguistic squalor please let me know and create an issue on my home repository.

That is indeed a unintentional misspelling. Thanks for the fix!


Styled-components example

Great work, moving conversation to here: https://mirrorful.slack.com/archives/C04RR2D7C65/p1681325509066199?thread_ts=1681325080.850689&cid=C04RR2D7C65
Are you also able to add the example:

here in our docs? https://github.com/Mirrorful/mirrorful/blob/main/docs/home/examples.mdx

to the list here, so it shows up in the app? https://github.com/Mirrorful/mirrorful/blob/main/packages/core/src/components/ExportSuccessModal.tsx#L421-L444

I have fixed it.

Nice work on this, I made a few minor tweaks. For example, changing the styled components icon to be an emoji instead of that black and white icon. GREAT WORK! 🎊


AppRole auth against Vault - mechanism to rotate secretID that expires after a period of time

Is your feature request related to a problem? Please describe.
ArgoCD vault Plugin supports approle Auth against Vault.  However, the secretID once expires, currently there is no clear way of process to rotate the secretID as per below that is stored as kube secret
https://www.vaultproject.io/docs/auth/approle#secretid
SecretID has a TTL or expiry

VAULT_ADDR: Your HashiCorp Vault Address
AVP_TYPE: vault
AVP_AUTH_TYPE: approle
AVP_ROLE_ID: Your AppRole Role ID
AVP_SECRET_ID: Your AppRole Secret ID

Describe the solution you'd like
have a mechanism to refresh SecretID against vault
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@clcchai currently the way is to just update the secret with the new secret id. We are open to hearing any proposals and we can ideate on this ourself. But we don’t have anything in the backlog for this at the moment

Hi Team,
I'm also facing this issue, how to rotate secret id for given roleid
Regards,
Arun

@arunbagul as stated above, that is not something we plan to build into the plugin and expect you to rotate your secret id outside of the plugin. If you have a proposal we are open to listening! 🙂


Implemented text selection to engine.client.gui.textbox

Added text selection with mouse and keyboard, copying, pasting and cutting to engine.client.gui.textbox
It doesn't work with multiple lines, I'm pretty sure that .multiline is broken as I couldn't find a way to actually make multiple lines. (I'll implement multi line support as soon as I find out)
This addresses #34

Dang this is legit, yo!

Queued for upstream merge to vertex-adventure tonight.

Merged upstream to vertex-adventure. Downstream code drop of build 908 pushed to e2a9495. Pending code review.


zurawiki.gptcommit version 0.5.7

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

This package is expecting arguments:
A git prepare-commit-msg hook for summarizing commits with LLMs.

Usage: gptcommit.exe [OPTIONS] <COMMAND>

Commands:
  install             Install the git hook
  uninstall           Uninstall the git hook
  config              Read and modify settings
  prepare-commit-msg  Run on the prepare-commit-msg hook
  help                Print this message or the help of the given subcommand(s)

...

I'm not able to find the cause for the error, nor why the waiver is removed.

This package is expecting arguments:
A git prepare-commit-msg hook for summarizing commits with LLMs.

Usage: gptcommit.exe [OPTIONS] <COMMAND>

Commands:
  install             Install the git hook
  uninstall           Uninstall the git hook
  config              Read and modify settings
  prepare-commit-msg  Run on the prepare-commit-msg hook
  help                Print this message or the help of the given subcommand(s)

...

If gptcommit install success, print gptcommit in console, it will show those arguments.


Support transferring data via data Upload server

PeakInvestigator v2.1 supports a new data upload server (i.e. returned from API call). There should be a simple method (similar to current SFTP transfers) for transferring data using this new server.

uploader copy.py.txt


Remove Primary Key Index Building in Main and Move the PKI build into a separate branch

Revert the main to have no pki building
Move pki related code into a separate branch for post optimization

Separate branch for PKI support was forked from main: https://github.com/ray-project/deltacat/tree/pki

Sub-Issues: #82 #83


[sk] Added default impute value

Summary
Default imputation strategy is to now fill missing entries with some non-null marker that represents the missing value. By type, these markers are:

Category/String: 'missing'
Datetime: pd.Timestamp.min (1677-09-21 00:12:43.145224193)
Number: 0

Along with these changes relevant bug fixes were made to other parts of the program.
Tests
Changes were tested locally against unit tests alongside more rigorous testing on sample testing datasets.
cc:
@wangxiaoyou1993

did you make many changes to code styles?


Fix a bug that functionAddress returns wrong value on Xcode 12

Fixes #9

Thank you for creating this PR!
I imported this change, but I couldn't get it to work in my environment.
It doesn't work well when more than one method is registered.
When two or more methods are registered, they all point to the same address, resulting in the next expression being nil.
Am I the only one experiencing this problem?
https://github.com/devxoul/Stubber/blob/master/Sources/Stubber/Stubber.swift#L35


Add Support for traceresponse Header in OpenTelemetry Tracing

Title: Add Support for traceresponse Header in OpenTelemetry Tracing
Description:
I propose adding traceresponse headers, as defined by the Trace Response Header Specification, when OpenTelemetry tracing is enabled.
I didn't find any references to this header in the documentation: Tracing and OpenTelemetry tracer (proto).
I'm interested to know if there is an existing mechanism that automatically adds this header, or if there is any ongoing development for this feature. If not, I would like to suggest its implementation.
The benefit of this feature would be to pass the trace information to the calling client, even if the client did not originally set up the trace, allowing the client to use the trace ID for troubleshooting purposes.

add @alexanderellis @yanavlasov based on CODEOWNER
Also, add @joaopgrassi and @wbpcode as you worked on opentelemetry tracer in the past (e.g., https://github.com/envoyproxy/envoy/pull/29207)

I believe this needs to be first defined in the OTel specification, before implementations start adding it. There's already an issue open in the OTel spec repo: https://github.com/open-telemetry/opentelemetry-specification/issues/1355

Remove stale

Remove stale


Make raw data block parsing public

neurom.io.unpack_raw_data(filename) parses input and produces a 2D
array with internal representation of neuron morphology. This
functionality used to be an implementation detail of
neurom.io.load_data, but it can be useful to external clients of NeuroM.
Implements #262.

Current coverage is 100.00%

Merging #263 into master will not affect coverage as of f928b5c

@@            master    #263   diff @@
======================================
  Files           42      42
  Stmts         1744    1744
  Branches         0       0
  Methods
======================================
  Hit           1744    1744
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of f928b5c

Powered by Codecov. Updated on successful CI builds.

@jdcourcol This could be of interest for the morphology viewer.

@eleftherioszisis @mgeplf Any objections to this?

If it's made accessible then it's basically something that can't be changed very easily.  I wonder a couple things:

TYPE, ID, P are currently stored as floats, but they really should be ints
is ID needed, as it usually is implicitly the row number (not sure if this is true in all cases, if not, could you point me to an example where it's not?)

@mgeplf Yes, that is a good point. I'll have to re-thing this. About the other issues,

If there was an easy, cost free way to have mixed type rows, then I could use appropriate types
ID is kind-of needed because SWC starts at an arbitrary positive value and there can be gaps in ID. I thought it would be easier to preserve this structure, especially because initially we spoke about this "round-trip" business. Of course, it can be changed, but it would require some work.

Have you looked at Structured Arrays: http://docs.scipy.org/doc/numpy-1.10.1/user/basics.rec.html

I know of their existence. I'd have to evaluate any impact on performance.

Closing this for now. The internal data block shouldn't be public until we have a spec.

@mgeplf I made it "private" but kept it out of load_data because it might be useful for debugging. It would be nice to have a standardized internal representation at some point in the future.


Fix recommendation query

277701310e52c6c18da00942dec5a08543414395: applied https://github.com/syuilo/misskey/pull/1336#pullrequestreview-108033887, which is shorter and nicer.

ありがとうございます👍


Implementing proxy.

i believe we can. i'm going to try right now. and then i'm also going to open a PR to try to get it merged into their code.


FakeTransaction does not set ._from

Expected Behavior
Ganache should allow you to set the ._from property on FakeTransactions so that signatures can be ignored.
Current Behavior
You cannot currently set ._from on a FakeTransaction. This is because FakeTransaction expects data.from to be defined in order to successfully set ._from. At the moment Ganache passes in a Buffer to FakeTransaction and data.from is undefined.

Closing, as ethereumjs-vm doesn't support fake transactions anymore.


Running postgres on different host

Hello, Is it possible to configure CartoDB to work with a remote postgres host?
I have tried to modify ./config/database.yml, and the following Ruby variable was effected ::Rails::sequel::configuration. environment_for(Rails.env)['host']
However in some places the scripts still search postgres on localhost.

Yep, it should run fine. That should change the database configuration for the metadata database, and for new users. For existing users, check the database_host column in the users table.


[boost-cobalt] Build error on arm64-windows-static-md

Copy issue body from D:/workspace/vcpkg/installed/vcpkg/issue_body.md

Embarrassing!


Docker image

Hi there,
I'm one of the contributors to https://github.com/swiftdocker/docker-swift. If there's any interest in vendoring a docker image containing the suite of Perfect libraries and possibly the server (though I wonder if long term a server isn't really in your interest, given that nginx etc exist) for easy development and deployment, please let me know if I can be of any assistance!

@swizzlr that would be great!

:+1:

There have been a number of Docker images that I can see for Perfect (I starred all the ones I could find);
https://hub.docker.com/u/seanstephens/starred/
We've also started a PerfectlySoft repo for images, just to make sure there are clean and up-to-date ones moving forward.
https://hub.docker.com/u/perfectlysoft/
Thanks for all the help!


code refactoring

Summary
Checklist

[ ] Added changelog entry
[x] Ran unit tests (rake test:unit)
[x] I understand that unless this is a Draft PR or has a DO NOT MERGE label, this PR is considered to be in a deploy ready state and can be deployed if merged to main

I have used brain tree in the past for the company I was working with and I am really interested in contributing to this repo. To get myself better with the code base and also to learn more about refactoring techniques, I made some small refactoring changes, which I believe might improve the code readability and management. It was huge learning for me to go through this repo 😁.
I am adding all the details of the refactoring done by and small description of why I think this refactoring is required. Please let me know if you think something is wrong or need more changes, I will do the changes, it will help me get better with the code base.
Refactorings:

Extract Method: (https://refactoring.guru/extract-method)
a.	Location
i.	Package: src/main/java/com/braintreegateway
ii.	Class: Customer.java
iii.	Method: Customer(NodeWrapper node)
iv.	Link of files of previous commit (before refactoring): https://github.com/braintree/braintree_java/blob/5927f1f212eb41d5aabf2b5889f882042573ad8f/src/main/java/com/braintreegateway/Customer.java
v.	Link of file of the commit with refactoring changes (after refactoring): https://github.com/braintree/braintree_java/blob/7c55b6e1f5cda5402387c3475acd8464de147bda/src/main/java/com/braintreegateway/Customer.java
vi.	Link to commit: https://github.com/braintree/braintree_java/commit/7c55b6e1f5cda5402387c3475acd8464de147bda
b.	Description: The contents of Customer was too big and was doing two different things: assigning node variables and creating lists of nodeWrapper. These two things can be divided into two different methods to perform “Extract method refactoring”. I’ve extracted the code into two methods: setCustomerNodeWrapperStrings(node); and setCustomerNodeWrapperResponses(node).

Decompose Conditional: (https://refactoring.guru/decompose-conditional)
a.	Location:
i.	Package: src/main/java/com/braintreegateway/util/Crypto.java
ii.	Class: Crypto.java
iii.	Method: secureCompare(String left, String right)
iv.	Link of files of previous commit (before refactoring): https://github.com/braintree/braintree_java/blob/449703fa7f1a54067e4a3a93cd9b5adba67bf694/src/main/java/com/braintreegateway/util/Crypto.java
v.	Link of file of the commit with refactoring changes (after refactoring): https://github.com/braintree/braintree_java/blob/5927f1f212eb41d5aabf2b5889f882042573ad8f/src/main/java/com/braintreegateway/util/Crypto.java
vi.	Link to commit: https://github.com/braintree/braintree_java/commit/5927f1f212eb41d5aabf2b5889f882042573ad8f
b.	Description: The method secureCompare had a complex conditional statement. To make it simple I transferred the condition to another method called: checkSecureCompareDirections(), which just returns a Boolean value hence performing Decompose conditional refactoring.

Introduce Explaining Variable: (https://blog.thepete.net/blog/2021/06/24/explaining-variable/#:~:text=An Explaining Variable is a,a little more self-documenting.)
a.	Location:
i.	Package: src/main/java/com/braintreegateway
ii.	Class: MerchantAccountGateway.java
iii.	Method: update(String id, MerchantAccountRequest request)
iv.	Link of files of previous commit (before refactoring): [https://github.com/braintree/braintree_java/blob/7c55b6e1f5cda5402387c3475acd8464de147bda/src/main/java/com/braintreegateway/MerchantAccountGateway.java](https://github.com/braintree/braintree_java/blob/7c55b6e1f5cda5402387c3475acd8464de147bda/src/main/java/com/braintreegateway/MerchantAccountGateway.java/)
v.	Link of file of the commit with refactoring changes (after refactoring): https://github.com/braintree/braintree_java/blob/741e351ff48b8af9ff3fa068351e0206b594be07/src/main/java/com/braintreegateway/MerchantAccountGateway.java
vi.	Link to commit: https://github.com/braintree/braintree_java/commit/741e351ff48b8af9ff3fa068351e0206b594be07
b.	Description: The method update makes a put API call using http. For creating the url to make http call there it was directly writing url in the put method. I have made an explaining variable: updateUrl,  and uses in put method, instead of directly adding string, now its clear what is the purpose to that String, Hence performing Explaining variable refactoring.

Move method: (https://refactoring.guru/move-method)
a.	Location:
i.	Package: src/main/java/com/braintreegateway
b. Description: The method connectUrl of clas oAuthGateway.java was mostly just using the objects of Configuration class. So it made more sense to just add it in the Configuration.java class. Since the method was moved from one class to another ( oAuthGateway -> Configuration.java) this is a move method refactoring.

Push-down method: (https://refactoring.guru/push-down-method)
a.	Location:
i.	Package: src/main/java/com/braintreegateway
b.	Description: Request is extended by multiple classes but the method buildXMLElement is being used by just one child class which is: SearchCriteria.java, so instead of having the method in parent we can just push it down to child class, hence making it push down refactoring. The method moved from Request.java (parent) -> SearchCriteria.java (child).

Pull-up method: (https://refactoring.guru/pull-up-method)
a.	Location:
i.	Package: src/main/java/com/braintreegateway/util
b.	Description: There are two methods in classes (Sha1Hasher and Sha256Hasher) hmacHash and sha1Bytes, sha256Bytes, also these two classes implement interface: Hasher. The code in these methods is almost same, it just hardcodes the value of sha algorithm in each individual class. I made changes to pull-up these methods to a parent class called ShaTypeHasher and implement these two methods in this parent class, the SHA algorithm value will be passed as a parameter to the methods. Hence performing pull-up refactoring, since the methods moved from child classes (Sha1Hasher, Sha256Hasher) -> parent (ShaTypeHasher) class. It also resulted in removing duplicate code and making it more readable.

👋 @sksaifuddin thanks so much for the PR! We'll take a look and provide any feedback. It might be a minute until we formally review, but we will take a look!
For internal tracking, ticket 2568


Providing Dashboard Access to a group

I can see support for users and different roles in superset. But What I need is, Consider, I have a set of dashboards for finance department. Only that department's members can view the dashboards and for any other departments, it should be restricted.
I know we can restrict the dashboard access very easily, But One solution I need is to create a group with all the members I have and to add that group as a single user, while creating Rules and Users in Apache Superset.
One alternate solution is to create a Role as we want and add one or more users easily.
But adding multiple number of users to multiple number of Roles is pretty difficult (Based on which department they belong to). So that the idea is to create a group for each group of Users and sharing dashboard to that group.

duplicate https://github.com/apache/superset/issues/12910


Make htslib for linking

Apparently this was not being made, and the instructions as given would
prevent a build from occurring.

For review by @nlhepler and/or @armintoepfer .  Presumably the cmake build should have been running make but when I downloaded and installed fresh based on the instructions that didn't work.  I didn't root cause at present as I just wanted to enable a quick work around, but if anyones familiar with pbbam's cmake file we could probably fix it further upstream.

I think we'll need more changes than this. unanimity is different between github and internal bitbucket:

https://github.com/PacificBiosciences/unanimity/commits
http://bitbucket.nanofluidics.com:7990/projects/SAT/repos/unanimity/commits

GitHub has not been updated since Aug. 12. Maybe we need to start mirroring them? Internally for now, I use pitchfork, which does work when you use the bitbucket repos.

We'll discuss this internally, as the gitmodules can be mirrored 1:1. Htslib is being built automatically, see circleci. If it doesn't for you, make htslibSrc.

I meant, CANNOT be mirrored 1:1.