URL share option - doesn't produce expected image

Expected Behavior

Copy and Paste the Code that I want to download as a image on carbon
In 'Export' > URL get the url of the image
Use it on web  to reproduce the same image that I expected

Actual Behavior

The URL gives image with a string adding %s and other characters in place of spaces.

Browser:
Please see my complete Browser information here.
Screen Recording
Please find screen recording of the issue here.
Code Snippet (If Applicable):
Here is the URL

Hi @Saif-Shines this is actually intended. Blog sites like Medium.com actually require you to encode the URL since they decode it before using it to create an iFrame.
Therefore, if you want to use the URL on Medium, use the Export > URL button. If you just want to share it, copy it from the Browser URL input 👍

I want to add it Google Docs: Add Image by URL option
Google docs don't recognize this as an Image URL. Is there any way to overcome this?

Neither of this are image URLs! I would recommend just saving the image and then pasting it directly to Google Docs.


[AutoPR recoveryservices/resource-manager] typo: recoveryservices/resource-manager/Microsoft.RecoveryServices

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4730

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3975


Document System.Net.Cookie path related breaking changes

Described changes introduced by PR dotnet/runtime#39250
Fixes #20363

Preview links
https://review.docs.microsoft.com/en-us/dotnet/core/compatibility/3.1-5.0?branch=pr-en-us-20416#cookie-path-handling-now-conforms-to-rfc-6265
https://review.docs.microsoft.com/en-us/dotnet/core/compatibility/fx-core?branch=pr-en-us-20416#cookie-path-handling-now-conforms-to-rfc-6265


Add preallocated buffer version of sendmsg

closes #2457

For the CI failure, you can allow the lint if necessary:
error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
    --> src/sys/socket/mod.rs:1650:64
     |
1650 |                flags: MsgFlags, addr: Option<&S>, cmsg_buffer: &mut Vec<u8>) -> Result<usize>
     |                                                                ^^^^^^^^^^^^ help: change this to: `&mut [u8]`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
     = note: `-D clippy::ptr-arg` implied by `-D warnings`


Suggestion: Don't say suggest an API when doing webscraping

When there is no solution (no api to call from lego), every effort is great towards having one. So thank you!
Since Strato is a hoster for people with a spectrum from no to deep knowledge, would it bother you to change the wording for
41: "username": "Username for Strato API.", 42: "password": "Password for Strato API."
and so on ...
to something diffrent than API? Because there is none, code/dialog should not suggest there is. APIs change rarely and usually with information beforehand, websites do change at random sometimes and without annoucement.
Again, this does not lessen the greatness of this script. Thanks!

Sure thing, would you like create a pull request or should I just change it?

Hey, thanks for the kind reply. I'm just getting warm (again) using github, so let me try.


Trait Usage issue,

i get:
ErrorException in Model.php line 3093: Argument 1 passed to Illuminate\Database\Eloquent\Model::is() must be an instance of Illuminate\Database\Eloquent\Model, string given,
when using:
$user = User::first(); return $user->is('administrator');
I added the use ShinobiTrait; to the User.php Model

i have the same problem within my app. I tried to check is a user has a role with $user->is('admin')
and get the same error as above

fixes this by using $user->isRole() instead of $user->is()

Correct - with the recent addition of authorization policies to Laravel, we can no longer use the is method - it has been updated to isRole. The documentation has been updated to reflect this.


Windows release crashing likely because C.CString deallocated with C.SDL_free

Go version: go version go1.21.2 linux/amd64
Go-SDL2 version: master (today's latest commit)
SDL2 version: 2.0.20
OS: Windows 10 (cross-compiling from Linux)
Architecture: 64bit
Hi,
I have been working on a game for a while now and on Linux it's been working great.
More recently, I have been trying to make a Windows build. I cross compile from Linux to Windows following the instructions provided on the README.md. Unfortunately, the Windows version of the game crashes on startup very frequently.
Here is a screenshot with the stack trace of the crash:

The stack trace shows that the crash occurs in the call to SDL_free of the sdl.SetHint function.
What is interesting about this code location is that there is a C.CString allocation being deallocated by a C.SDL_free.
The cgo documentation states that C.CString should be deallocated with C.free.
In this project, sometimes a C.CString is deallocated by C.SDL_free and sometimes by C.free. Perhaps on Linux the C.SDL_free is actually the same as C.free and therefore programs are not crashing, but it's possible that on Windows this is not the case.
I patched the sdl.SetHint function in my program to use C.free instead of C.SDL_free, made a new Windows build, and so far I haven not been able to reproduce the crash.
Based on the above, I suspect that on Windows the SDL_free is corrupting the program by trying to deallocate memory that was allocated by C.CString.
Even if my suspicion is wrong it might be safer to just stick to the documentation of C.CString and use C.free to deallocate the strings in all circumstances just to be sure there is no memory corruption.
If y'all agree with that assessment, then the fix would be review all calls to C.CString and make sure that they are being deallocated with C.free instead of C.SDL_free.
Any thoughts?
Thank you,
Jose

Hi @jabolopes, thanks for the reporting this issue! I think you are right that we should replace C.SDL_free() with C.free() in the C.CString() cases which I have done so in a new commit in the master branch. Could you please try again?

Hi @veeableful, now that the fixes were submitted I am no longer able to reproduce the crash, so I think we can mark this issue as fixed.
Thanks,
Jose

Hi @veeableful, now that the fixes were submitted I am no longer able to reproduce the crash, so I think we can mark this issue as fixed.
Thanks,
Jose


Add support for OpenShift's SCC

Feature Request
Describe the problem you need a feature to resolve.
as could be seen from GitLab issue - it is unnecessary hard to distribute operator as OLM bundle when one cannot include SCC (unlike Roles, RoleBindings, ClusterRoles and ClusterRoleBindings and ServiceAccounts that comprise RBAC stack in generic k8s cluster).
Having additional steps negates simplicity that OLM has to offer in terms of distribution and management as now packaged operators depend on unpackaged features that require their own lifecycle management applied.
Describe the solution you'd like.
Allow SecurityContextConstraints to be part of CSV and distributed with OLM bundles.

OLM currently supports only specific types in which Openshift's SCC is not supported afaik. The new OLM bundle API (Rukpak) is working towards solving this. Probably @asmacdo @theishshah can provide more light on its adoption?

yes, RukPak will assist with this. a "plain bundle" does not care what the object types are.
I'm closing this issue-- could you please reopen against the operator-lifecycle-manager repo?

Hi @droopy4096,
In OCP you just need additional SCC permissions if your workloads cannot run as restricted and require raising permissions, as described in: https://github.com/redhat-openshift-ecosystem/community-operators-prod/discussions/1417
Note: You may can define this into the operator metadata bundle via the RBAC specified into the CSV which is used for the ServiceAccount managing the workloads. To know what is more appropriate SCC check its documentation Also, for the purpose of the related changes on 4.12 see the item "If your solutions require escalated permissions" in the detailed information provided below.
Example:
 install:
    spec:
      clusterPermissions:
      - rules:
        - apiGroups:
          - security.openshift.io
          resourceNames:
          - privileged
          resources:
          - securitycontextconstraints
          verbs:
          - use
        serviceAccountName: default

c/c @asmacdo @varshaprasad96


Helm configured differently within microk8s vs outside

Helm configured differently within microk8s vs outside
TL:DR I'd like to understand better what context/cluster helm is talking to.
I am trying to use helm within microk8s. I went through the macos install instructions and added the observability add on and manually added the vector helm repo:
microk8s helm repo add vector https://helm.vector.dev
microk8s helm repo update

Then when I run microk8s helm repo list I see:
$ microk8s helm repo list
NAME                    URL
prometheus-community    https://prometheus-community.github.io/helm-charts
grafana                 https://grafana.github.io/helm-charts
vector                  https://helm.vector.dev

However, when I use a brew installed helm directly (without microk8s) I see different repos:
$ helm repo list
NAME    URL
bitnami https://charts.bitnami.com/bitnami

This confused me, so I tried setting my ~/.kube/config as their docs suggest for kubectl:
microk8s config > ~/.kube/config

However this doesn't change the repo list. I thought helm is supposed to respect that config?
Is there a way to learn more about what kubernetes cluster helm is connecting to or what contexts it is aware of/choosing? Using --debug didn't provide any more information. I didn't even know I had another cluster running!

Output of helm version:
$ helm version
version.BuildInfo{Version:"v3.10.0", GitCommit:"ce66412a723e4d89555dc67217607c6579ffcb21", GitTreeState:"clean", GoVersion:"go1.19.1"}
$ microk8s helm version
version.BuildInfo{Version:"v3.9.1+unreleased", GitCommit:"e5ad1e2252aafb988fb68910e317e34ac9489fe0", GitTreeState:"clean", GoVersion:"go1.19"}

Output of kubectl version:
$ kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.0", GitCommit:"a866cbe2e5bbaa01cfd5e969aa3e033f3282a8a2", GitTreeState:"clean", BuildDate:"2022-08-23T17:44:59Z", GoVersion:"go1.19", Compiler:"gc", Platform:"darwin/amd64"}
Kustomize Version: v4.5.7
The connection to the server localhost:8080 was refused - did you specify the right host or port?

 $ microk8s kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.0", GitCommit:"a866cbe2e5bbaa01cfd5e969aa3e033f3282a8a2", GitTreeState:"clean", BuildDate:"2022-08-23T17:44:59Z", GoVersion:"go1.19", Compiler:"gc", Platform:"darwin/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.2", GitCommit:"5835544ca568b757a8ecae5c153f317e5736700e", GitTreeState:"clean", BuildDate:"2022-09-29T07:03:08Z", GoVersion:"go1.19", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):  microk8s

@mjperrone please show the content of $HOME/.config/helm/repositories.yaml

$ cat $HOME/.config/helm/repositories.yaml
cat: /Users/mperrone/.config/helm/repositories.yaml: No such file or directory

The default home directory for helm is the one asked for above. There's nothing in brew that changes that. Do you have $HELM_HOME defined, or are you running as root or does the microk8s command create some chroot?
The repositories.yaml is the source of that list, though. It works even without a kubernetes cluster so it has nothing to do with which kubeconfig you're using, if that helps.

Thanks for the info!
Turns out my use case doesn't actually require kubernetes so I'm going to solve the problem with docker-compose and avoid helm entirely. So I'm not going to invest more time to understand my issues here


learned coverage stat doesn't match my intuition

Hi,
(following as a example cell 21 in the intro tutorial, In [21]: gen_model.learned_lf_stats() since I face a similar situation in my dataset)

Should I understand that accuracy and coverage correspond to alpha and beta in equation 1 of the NIPS paper?
If so, why are coverages so high compared to the coverage of the labeling function, and so similar across LFs? my intuition is that beta should be close to the coverage of the labeling functions, and should be quite easy to fit (since the maximum likelihood estimate only depends on the proportion of labeled samples, doesn't need golden labels or anything else). I would guess that if the GM doesn't have enough samples or epochs or is too regularized, then the values will deviate only slightly around mean value, but that's also not what I see (the final values are around a value higher than any of the original values).

Maybe I just need to play more with the hyper parameters of the GM, but until now they are all around a value which is far to high for any of the LFs (same for the intro tutorial, only one LF has coverage of 0.6, while all learned coverages gravitate around 0.66). Or am I misunderstanding the meaning of coverage on the learned_stats?

A clearer example on this. In this notebook I generated synthetic labels with known coverage and accuracy, and tried to recover those parameters using snorkel generative model. For accuracy it does a decent job (mostly fails for LFs with very low coverage). But for recovering coverage, it mostly ends up with all LFs having a similar coverage around 0.66, no relation with the original one. This shouldn't affect the rest of the workflow (since AFAIK you only need the accuracies to calculate the marginals), but still. Is it me misunderstanding the parameter? or maybe I need to use different settings on the generative model training?

@eloriundo sorry for the delayed response on this, and thanks for the detailed issue!  This looks like a bug- computing the coverage can be done empirically (counting!) and is thus trivial, and so I think there's some small issue here.  Ultimately this parameter is not used during prediction in the basic generative model configuration... so it's probably not getting updated for this gen_model.learned_lf_stats() print out... will try to look into soon.
As for accuracies- that it would have lower quality on LFs with lower coverage roughly makes sense- you can think of the number of overlaps with other LFs as the number of samples the model as to learn from, so lower coverage = fewer overlaps = fewer samples to estimate the accuracy from


Upgrade MongoDB.app to v3.2.0 (Build:<PHONE_NUMBER>)

Merged as f1fbfb10526995addcb1e5c7126292769b7e2164.


Optional object is not working

optional object is not working for example
@dataclass
class TestSubData(JsonSchemaMixin):
  a: int = 0

@dataclass
class TestData(JsonSchemaMixin):
  subData: Optional[TestSubData] = None

the schema i got is
$schema: http://json-schema.org/draft-06/schema#
definitions:
  TestSubData:
    description: 'TestSubData(a: int = 0)'
    properties:
      a:
        default: 0
        type: integer
    type: object
description: 'TestData(subData: Union[__main__.TestSubData, NoneType] = None)'
properties:
  subData:
    $ref: '#/definitions/TestSubData'
type: object

you can see that {'subData':None} will be rejected eventhough it is a valid data according to the dataclass

the correct output would be
$schema: http://json-schema.org/draft-06/schema#
definitions:
  TestSubData:
    description: 'TestSubData(a: int = 0)'
    properties:
      a:
        default: 0
        type: integer
    type:
      - object
      - "nil"
description: 'TestData(subData: Union[__main__.TestSubData, NoneType] = None)'
properties:
  subData:
    $ref: '#/definitions/TestSubData'
type: object

thank you

You can use Nullable[TestSubData] to allow nulls. It should give you something like:
$schema: http://json-schema.org/draft-06/schema#
definitions:
  TestSubData:
    description: 'TestSubData(a: int = 0)'
    properties:
      a:
        default: 0
        type: integer
    type: object
description: 'TestData(subData: Union[__main__.TestSubData, dataclasses_jsonschema.type_defs._NULL_TYPE]
  = None)'
properties:
  subData:
    oneOf:
    - $ref: '#/definitions/TestSubData'
    - type: 'null'
type: object


Escape strings before creation of NSURL

Ran into this issue when converting a legacy project from SwiftyJSON to Gloss.
SwiftyJSON has a line of code that escaped strings before creating NSURLs.Thus, URLs that used to be parsed properly were not read properly after conversion. Adding this extra step solved the problem for me.

to play devil's advocate - is this not something a client could create a custom transformation for? the question being - is it really the library's responsibility to do this? i'm open to hearing yes, i'd just don't want the library making unnecessary assumptions on the client's behalf

I definitely see your point, though we would then lose the convenience of the glorious Gloss custom operators.
I agree that you don't want to make too many assumptions on the client's behalf, but on the other hand, I don't see many clients objecting to a straightforward sanitization of their strings. In our case, all we want is to simply get an NSURL object from a URL string -- we're not really doing anything custom as such, it's just that our data is unusual in some cases.
(But I may be blind to cases where this could break client code, or examples where you might not want this level of "magicalness" to the library.)

point taken - thanks for the care :+1:

@ejmartin504 heads up, this is creating issues: https://github.com/hkellaway/Gloss/issues/238
i'm inclined to go with my original thought of the library is making unnecessary assumptions about the URLs and remove this escaping. as of the soon-to-be release 1.1.2, you'll have to escape your own URLs


Kernel overall local size

Good afternoon.
When I use the NVIDIA GeForce RTX 3060 Ti graphics card in java-code, I get an error:
Kernel overall local size: 1000 exceeds maximum kernel allowed local size of: 256 failed
Running the same code on an Intel HD Graphics 630 or AMD RadeonT R7 450 graphics card, everything works fine.
If in this part of the code I put a number less than 256, then the code with the NVIDIA GeForce RTX 3060 Ti graphics card works fine:
Range range = needDevice.createRange(255);
kernel.execute(range)

The NVIDIA GeForce RTX 3060 Ti video card is more modern than the Intel HD Graphics 630 or AMD RadeonT R7 450, but for some reason the parameter for createRange is less than for older video cards.
What could be the problem?

Hey @forreg16 I have the same problem. My card is RTX 3070 and I run it on Linux.
The problem happens because the max group size is hardcoded to be 256:
public static final int MAX_OPENCL_GROUP_SIZE = **256**;
I don't know why this is the max, I don't have experience with OpenCL.
I hope the maintainers of the project will answer here.
Maybe our option is to change the value and recompile the library but I don't know is there any instructions how to do that?

Hey @trayanmomkov.
Try this version of the code. In this case, my parameter size can be set to more than 256.
Range range = needDevice.createRange2D(size, 1);
kernel.execute(range);

you can see more details here
https://stackoverflow.com/questions/75365328/error-exceeds-maximum-kernel-allowed-local-size

But @forreg16 you can achieve that with create(size, localSize) where localSize <= 256 and size % localSize == 0.
The real problem is that localSize cannot be greater than 256.
On my card which has 5888 cores I want to have greater localSize to achieve better performance.
And actually Aparapi automatically choose the localSize of 640 but when tries to set it I get the error:

!!!!!!! Kernel overall local size: 640 exceeds maximum kernel allowed local size of: 256 failed (null)


What is likelihood-difference in CrowS-Pairs? Is a lower value better for this indicator?

Hi! This refers to the difference in loglikelihood between the stereotyped and non-stereotyped sentences.
A theoretically "unbiased" model (one that assigns equal probability to the stereotyped and non-stereotyped sentences) would have this value closer or equal to 0.

Got it! Really thank you :)

For further reference, this implementation is sourced from: https://arxiv.org/pdf/2304.01373.pdf


Possible to remove Django from install_requires?

Django being in install_requires makes it hard for a project using django_coverage_plugin and pip-compile to specify their own version of Django.

This library specifies "Django>=1.8". If your app specifies "Django==1.9.3", everything should be fine, or so I thought.  Can you show the details of how you are specifying Django, and what happens with pip-compile?

OK, I think this is probably an issue limited to my specific setup, I split dev requirements out to a dev-requirements.in; because django_coverage_plugin adds a dependency on Django I end up with it in both my requirements.txt and my dev-requirements.txt. I'm thinking I can just combine both files since I install both sets of requirements anyway.
I still don't know how I feel about the dependency conceptually, but at least I've solved the issue at hand. :)

Same problem here.  I have a runtime.txt file (generated by pip-compile) with django, pysycopg2 and all run-time dependencies; my tests.txt file (generated too) only contains additional requirements like coverage, django-webtest, etc., without duplicating the django/etc dependencies.  In my tox config I run pip-sync runtime.txt tests.txt to install both sets of packages (pip-sync is equivalent to pip install -r but will also remove installed deps that are not in the requirement files).
If django ends up in both requirement files, pip-sync gives an error.
I think pip-tools is right here.  It’s straightforward and clear to have disjoint sets in requirement files, and not include base run-time deps in the test requirements.  Even before pip-tools existed, in the pyramid world extensions don’t depend on Pyramid, to give full control to the app assembler.

Thanks @merwok.  That's a well supported point.
I think the plugin is depending on the setup.py install_requires to ensure that only supported versions of Django are installed.  One could add a manual check to the plugin and run-time error if the Django version is unsupported.

Yes, that would work well with a tox config that documents the supported versions.

If django ends up in both requirement files, pip-sync gives an error.

The behaviour is more subtle: an identical requirement may be present in runtime.txt and tests.txt, if it’s the same version (happens for six for instance).
I think the exact problem is that the *.in files are compiled separately, so pip-tools doesn’t have a chance to resolve the version constraints from django-coverage-plugin and my app.

I think this one is resolved by PR #48 ?

Indeed

👍


Docs are out of date or contain errors

There is no type NumericalField, it is NumericField
Client doesn't accept username as an parameter
client = Client("my-index", username="user", password="my-password")
The following example that you show doesn't work - you can't set a Python datetime object in Redis

import datetime

from redisearch import Client

START_TIME = datetime.datetime.now()

client = Client("my-index")

client.redis.set("start-time", START_TIME)

This example is missing a colon

try:
    client.info()
except ResponseError
    # Index does not exist. We need to create it!
    client.create_index(SCHEMA, definition=definition)

Thanks @rankam! I issued a pull request to update the documents.


Add a 'Container Project Discovered' event

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1469138
Completed by:
https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/226
https://github.com/ManageIQ/manageiq-ui-classic/pull/3360
This is the exact same implementation as 'Container Image Discovered'
If we like this type Discovered events then ill refactor this and the code for ContainerImage into a DiscoveredEventMixin.
@cben @moolitayer @Ladas PTAL
cc @oourfali
@miq-bot add_label providers/containers, bug

@miq-bot remove_label wip

If we like this type Discovered events then ill refactor this and the code for ContainerImage into a DiscoveredEventMixin.

I tested this out and it looks fine (with the other PRs from other repos).
Do we want the mixin?

Also available in alerts.

@agrare @Ladas  Please review

LGTM :+1:

(Should this become gaprindashvili/yes, please mark https://github.com/ManageIQ/manageiq-ui-classic/pull/3382 accordingly.)


Angular-cli + angular universal

Could you please consider option about adding angular universal to angular cli?
Problem is that we can build angular app now but that apps cannot be crawled by google bots.

Dupe of https://github.com/angular/angular-cli/issues/1050, and related to https://github.com/angular/angular-cli/issues/3013


Issues with Converting GIFs with Alpha Channels to AVIF Format

I apologize in advance as I am not fluent in English and have to rely on a translation tool to communicate.
I've encountered an issue where the alpha channel is not preserved when converting GIFs with alpha channels to the AVIF format using the following code:
image.save(image_path_out + '.avif', 'AVIF', save_all=True, speed=0, subsampling="4:2:0", quality=75)

To address this, I tried the following approach:
if "transparency" in image.info:
    frames = []
    for frame in ImageSequence.Iterator(image):
        frame = frame.convert('RGBA')
        frames.append(frame)
    frames[0].save(image_path_out + '.avif', save_all=True, append_images=frames[1:], speed=0, subsampling="4:2:0", quality=75)
else:
    image.save(image_path_out + '.avif', 'AVIF', save_all=True, speed=0, subsampling="4:2:0", quality=75)

This method successfully preserved the alpha channel, but the playback was much faster than expected.
When I tried saving the frames with the duration specified as below, the playback speed appeared normal:
def animation_frame(image):
    frames = []
    durations = []
    last_duration = 100

    for frame in ImageSequence.Iterator(image):
        if "transparency" in image.info:
            frame = frame.convert('RGBA')
        frames.append(frame.copy())

        current_duration = frame.info.get('duration', last_duration)
        durations.append(current_duration)

        last_duration = current_duration

    return frames, durations

    frames[0].save(image_path_out + '.avif', save_all=True, append_images=frames[1:], duration=durations, speed=0, subsampling="4:2:0", quality=75)

I am unsure if this is the correct approach. According to an issue thread (https://github.com/fdintino/pillow-avif-plugin/issues/14), playback issues might arise from viewers or players that do not support the image sequence mode correctly. When I directly convert and view the result in Chrome using HTML, the playback is significantly slower. In contrast, other viewers play it much faster. Including duration=image.info['duration'] seems to smooth out playback in both Chrome and other viewers.
I am unclear whether I am doing something wrong. It would be ideal if a straightforward conversion could yield a proper result without specifying additional options. For converting JPG to AVIF, chroma subsampling wasn't automatically handled, so I utilized ExifTool to read the original specifications. Based on those, the automatically adjusts the subsampling to match the original, whether it's 4:4:4 or 4:2:0. Additionally, for JPGs and PNGs in grayscale mode, the code also needed to include a conversion to chroma subsampling YUV400.
Interestingly, converting PNGs with alpha channels automatically optimizes and converts without these issues. Why does converting GIFs with alpha channels not automatically preserve these channels, and why doesn't it play back correctly? Additionally, I'm curious why, when converting JPG to AVIF, the chroma subsampling isn't automatically adjusted to match the original's specifications, such as maintaining 4:4:4 if that's what the source uses. Is there something I am missing, or is this an issue with the current implementation?

I think the alpha transparency issue should have been fixed with the merge of #56, which is in the 1.4.4 release. I'm going to close this as fixed, but if I am mistaken please reopen.
I think your comments about chroma subsampling are a bit confused. JPEG uses chroma subsampling in its compression, but the image it encodes is RGB, which cannot have chroma subsampling. When the channels are R, G, and B, the sampling is 4:4:4.


Bug: The index function does not have the @query_params decorator.

The change broke the index function. In scope of this change, the @query_params decorator was reassigned to the new create function instead of adding a new one to the create function itself.

This fix is published to pypi


spark-sql: make AS optional in cte

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

as can't be ignored in the first statement

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
Robiathin, @benqian, @sharifm-informatica, @wolflegend99, @flyingalex, @rahuliyer95, @abuzaid666, @sirakoff, @zmunro, @iuriguilherme, @zetbaitsu, @rrichards, @dileep-kishore, @igor-sadchenko, @UnKnoWn-Consortium, @hDn24, @kshtj24, @FoxxMD, @karthik-cbe, @isgulkov


(In Code Review) Add get customer filters endpoint

https://jira.desk.technology/browse/APIJ-38

:+1:


Added intel laptop.

A couple of Intel Ultrabook users AND people DJ'in for the Intel DJ Battle have an Intel laptop on stage.
https://s3.amazonaws.com/static.turntable.fm/roommanager_assets/props/laptop_intel.png

I tried it, and we cannot set our laptop to "intel". At least, not in the average rooms.

Never mind, then...


Compatibility with pandas 2.0.0

~- [ ] Closes #xxxx~

[x] I am familiar with the contributing guidelines
~- [ ] Tests added~
~- [ ] Updates entries in docs/sphinx/source/reference for API changes.~
~- [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).~
~- [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.~
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The first release candidate for pandas 2.0.0 was released yesterday: https://github.com/pandas-dev/pandas/releases/tag/v2.0.0rc0.  It's available on PyPI with pip install --pre pandas==2.0.0rc0.
The list of changes is pretty extensive, but it seems like we escape nearly unscathed: it doesn't seem to break anything in pvlib itself and only causes one small issue in our tests.  This PR fixes that test issue.
Since pvlib itself seems to be compatible, I suggest we wait to merge this PR until pandas 2.0.0 is officially released (anticipated in "a couple weeks") in case there are any other breaking changes made between now and then.

The first release candidate for pandas 2.0.0 was released yesterday

This PR fixes that test issue.

I'm impressed!

This branch has no failures on the just-released 2.0.0rc1 as well.  Their ETA for the actual release of pandas 2.0.0 is still "about two weeks".

This is ready for review now that pandas 2.0.0 has been released.
Note that wheels are available on PyPI, but the new version isn't yet available on conda, so the CI isn't currently using it for the remote-data tests. In lieu of that I ran pytest pvlib/tests/iotools/ --remote-data locally with pandas 2.0.0 installed and all looks good.


Fixes #57 - Password inputs should not re-render contents provided to them.

Link: #57

Coverage remained the same at 72.39% when pulling 99c6807bfea9bcde4a0a2685ec70203f28e455ce on kezabelle:master into aeb7efe58ff532209d935836054bfdb78d9678cd on funkybob:master.

I suspect there are other places overlooked when raw_input was introduced


complex polygons are rendered onto renderTextures with flipped y coordinates in webGL

jsFiddle with minimal repro here: http://jsfiddle.net/fb4vrnzb/

The first thing PIXI.RenderTexture.prototype.renderWebGL does is to flip the display object, because they come in upside down. Evidently Graphics objects don't suffer from this - so instead of renderXY use render instead and provide your own matrix that counters the automatic flip.

That isn't a valid solution because whether or not the poly is complex (ie drawn upside down) can vary from frame to frame (according to which method is used to build the polygon in the graphics renderer, as determined by WebGLGraphics.updateGraphics).
Here's a fiddle where all I've done is removed the second vertex, thereby making the polygon renderable as simple, and the Y flip is now gone: http://jsfiddle.net/v3qdxhq0/

No idea then, it's a Pixi anomaly and likely to remain one given they don't update v2 any more.

this also happens on your Pixi Render Texture demo at http://phaser.io/examples/v2/display/pixi-render-texture
if you switch the render type to WEBGL and put a bit of code in the update to just let it run once, you'll notice the display actually starts off upside down
thanks
j

actually.. I can now confirm that switching game.stage to game.world as suggested here
http://www.html5gamedevs.com/topic/10015-phaser-213-and-state-transition-plugin/
renderTexture2.renderXY(this.game.world, 0,0,true);
instead of
renderTexture2.renderXY(this.game.stage, 0,0,true);
I've only just started with Phaser so I don't know if this will cause any other side-effects

Hi,
i've put another example here:
http://phaser.io/sandbox/rQJpJZNi/play
you can see that some of my graphics object is rendered upside down and some isn't
thanks
J

it's any polygon with more than 4 points. I've checked with multiple examples. convex, concave, intersecting etc. the outlines draw ok, the fills don't
    var graphics = this.game.add.graphics(0, 0);

    // poly with 4 points
    var points = [new Phaser.Point(38,21), new Phaser.Point(83,10), new Phaser.Point(108,48), new Phaser.Point(100,100)]

    // a poly with more than 4 points breaks the rendering of the shape
    // comment out the line bewlow line and issue disappears
    points.push(new Phaser.Point(20,50))

    // fills break
    graphics.beginFill(0x00FF00)

    // outline seems to be ok
    graphics.lineStyle(1,0xFF0000)

    graphics.drawPolygon(points)
    graphics.endFill()

    // create our render texture to the size of the game
    var renderTexture = new Phaser.RenderTexture(this.game, this.game.width, this.game.height)

    // we could use graphics width/height but it reports wrong
    //var renderTexture = new Phaser.RenderTexture(this.game, graphics.width, graphics.height)

    // render graphic to the texture
    // neither of these methods work
    renderTexture.renderXY(graphics, 0,0,true)
    //this.renderTexture.render(graphics, null, true);

    // add the texture to a sprite
    var myRenderedSprite = this.game.add.sprite(0,0,renderTexture)
    myRenderedSprite.x=400;

my workaround for the issue has been to raise the number of points a polygon can have before the rendered assumes it's complex (and uses the stencil rendering function), and to swap out the PolyK triangulation for Earcut (which was hella easy), a more robust implementation that will return more valid triangulations (again resulting in less use of the stencil buffer).

I've swapped to using EarCut internally.
It doesn't solve this problem (with the fills being reversed), but if you cache the Graphics as a Bitmap first it works fine:
    graphics.cacheAsBitmap = true;

And then the RenderTexture appears as it should do.


Failed to pull catalog with exit status 128

Server version - v0.44.0-rc1
I had the catalog.url set to https://github.com//alena1108/rancher-catalog.git.
Cloning of catalog was successful and I was able to create stack with template from catalog.
There was a change in version for "Route53 DNS" template from v0.1.2 ->  v0.1.3.
I was not able to get the latest version of "Route53 DNS" template to show up in my catalog even after I refreshed the UI few times.
git pull encountered error - exit status 128.
When I forced the clone of catalog again (by changing the catalog.url ) , I was able to see the new version of  "Route53 DNS" template.
time="2015-11-03T00:21:36Z" level=info msg="Cloning the catalog from github url https://github.com/rancher/rancher-catalog.git"
time="2015-11-03T01:18:17Z" level=info msg="Cloning the catalog from github url https://github.com/alena1108/rancher-catalog.git"
time="2015-11-03T18:38:18Z" level=error msg="Failed to pull the catalog from github repo https://github.com/alena1108/rancher-catalog.git, error: exit status 128"
time="2015-11-03T18:43:18Z" level=error msg="Failed to pull the catalog from github repo https://github.com/alena1108/rancher-catalog.git, error: exit status 128"
time="2015-11-03T18:48:18Z" level=error msg="Failed to pull the catalog from github repo https://github.com/alena1108/rancher-catalog.git, error: exit status 128"
time="2015-11-03T18:49:10Z" level=info msg="Cloning the catalog from github url https://github.com/rancher/rancher-catalog.git"
time="2015-11-03T18:50:42Z" level=info msg="Cloning the catalog from github url https://github.com/alena1108/rancher-catalog.git"

This issue was caused because the catalog owner @alena1108 used git push -f to forcefully rewrite the git branch. So git pull against the original branch started erroring out due to the re-write.
This error will not happen in case of updates on an existing branch.

so, how are we gonna fix this?


tracking issue for error recovery

this issue tracks the implementation of error recovery and is intended for discussion of potential ideas, strategies etc.
keep in mind this is paused until full feature parity with chumsky (#1)
below is the todo list for making error recovery as a feature:

[ ] implement sensible infrastructure for error recovery

[ ] something like a .recover method on ParserExtras that could either call a builtin strategy or do its own thing

[ ] implement builtin strategies:

[ ] the noop strategy - just dont do anything
[ ] slow and steady - rewind. parse. rewind again. parse.
[ ] custom - a way to do error recovery youself (VERY IMPORTANT!!)

[ ] test the builtin strategies to hell to be sure they work fr and dont explode on an edgecase
[ ] make internal documentation for implementing builtin strategies
[ ] document the user facing api and how to even do error recovery

I'll add some more strategies to error recovering in the issue later and I'm probably gonna start closing it in 2 days.

I'll add some more strategies to error recovering in the issue later and I'm probably gonna start closing it in 2 days.

like implementing?
and also could you please write out your ideas on the strategies?

added to v0.3.0
this should be added before 0.3 is tagged;
if it happens to exist and be stable enough that you could just add a feature flag before 0.2 it will be moved to the 0.2 milestone and included in 0.2

moved to 0.4, because 0.3 will be for the redesign and other major stuffs


(maint) Add handler for /environment/:environment route

This route is used for retrieving information about an environment
catalog. This just passes through handling of the route to puppet, as
with all the similar routes.

:see_no_evil:

From the Travis CI build ...
lein test :only puppetlabs.services.jruby.jruby-pool-int-test/admin-api-flush-jruby-pool-test
FAIL in (admin-api-flush-jruby-pool-test) (jruby_pool_int_test.clj:142)
Flushing the pool results in all new JRuby instances
expected: (true? (verify-no-constants pool-context 4))
  actual: (not (true? false))

@cprice404 - Any thoughts?

I think I saw that once, too, but wasn't able to reproduce it later.

@camlow325 did you see that on your box?  Or in Travis?
@KevinCorcoran seems like we should probably file a separate ticket for that failure and deal with it in triage, and consider this PR independently.
@nicklewis I have some reservations about this (just in terms of timing) but would be willing to discuss; seems like it might be more appropriate to do that in Jira for posterity, do you have a ticket number?

@camlow325 did you see that on your box? Or in Travis?

Pretty sure I saw that on my local box but I can't remember now.  I had some other local changes in place at the time I'd run the tests so I chalked up my lack of an ability to reproduce it to some of that at the time but it sounds now like there might be a real problem here.

@cprice404 The placeholder is APPMGMT-94.

@nicklewis thanks, will add some comments over there.

After some discussion and clarification on the Jira ticket, I'm +1 on this.  @camlow325 can you merge this today unless you have any other concerns?

I don't want to hold up the app management team and this seems pretty straightforward to me, so I'm going to merge it.  If anyone has any concerns we can deal with them retroactively.

FWIW now that it's already been merged, :+1: from me.


tagging function should handle promises

In my app, tags have identity, so on search we do an async call to the backend. Conversely adding a tag means inserting it into the db. It is therefore a necessity to be able to add tags asynchronously.

When using taggingLabel !== false the taggingFunction is actually run to create the item that is added to the start of the item list, so the user can select it if they wish. Therefore this wouldn't be a workable solution for your use case.
This can be managed externally, using an onSelect callback to check if the new item is part of your existing list and saving to the db if not.
It would be unnecessarily complicated to introduce I think, so I'm closing.

@user378230 What if the DB insert fails? In that case I don't want to add (and display) the value in ui-select component.
Sorry for bumping an old issue, I don't think the question above deserves a new one to be opened.


Problems generating SVG and SVG icons

When I put a .svg file in thesrc/svg folder the gulp task until it finds, however, it creates a folder inside the src/svg/svg folder and also in build/svg and both empty.

Uhmmmmmmm, I'll check it

Can you check @ribeiroevandro?

Sorry for the delay, working hard... Now it works o/

Nice @ribeiroevandro !


Error while compiling in Android Studio

I'm new to flutter, can't figure out why I'm getting this:
lib/UI/pages/Profiles/GuardianProfile.dart:82:7: Error: The getter 'ScaffoldMessenger' isn't defined for the class '_GuardianProfilePageState'.
 - '_GuardianProfilePageState' is from 'package:ourESchool/UI/pages/Profiles/GuardianProfile.dart' ('lib/UI/pages/Profiles/GuardianProfile.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'ScaffoldMessenger'.
      ScaffoldMessenger.of(context).showSnackBar(ksnackBar(
      ^^^^^^^^^^^^^^^^^

Is it because I did not create a firebase connection to this yet?

Also getting this warning not sure if this is even needed...
WARNING: The option setting 'android.enableR8=true' is deprecated.
It will be removed in version 5.0 of the Android Gradle plugin.
You will no longer be able to disable R8

OK so now I get the following error:
No matching client found for package name 'com.ketanchoyal.our_e_school'
I believe com.ketanchoyal.our_e_school is your firebase but where did you initialize this, what file?

you need to setup your firebase project and deploy the firebase functions.

OK so now I get the following error:
No matching client found for package name 'com.ketanchoyal.our_e_school'
I believe com.ketanchoyal.our_e_school is your firebase but where did you initialize this, what file?

can you provide some more detail on this?

Sorry i gave up on your code, couldn't make it work. I'm working on another flutter code,  it uses mysql. Once i get more into it I'll try to mimic your GUI since i really like it. I'm also integrating rfid login into it. Love how simple flutter is and it all started after seeing your code, did not know of flutter before so thanks for that :)


Allow bulk_publishing parameter for Publishing API payloads

Loosely related to: https://trello.com/c/3GT17tkH/211-associate-content-with-ministers-l
Despite this field having been available in Publishing API for 2 years
it's not actually accepted at a schema level. Presumably, in the case of
PutContent, this means it's not been used in the last couple of years as
it would have returned a 422 response.
As it's quite a useful option to have I felt it was better to add it
into the schemas rather than remove the feature from Publishing API.

Whitehall passes against this branch: https://github.com/alphagov/whitehall/pull/4370


Hosting under LVGL

Introduce the problem
I think Lua is very good language for embedded systems, however LVGL doesn't have an officially supported Lua binding yet.

Proposal
I would be happy to promote your Lua binding (similar to MicroPython), so I wonder if you would be interested migrating this repository under the LVGL organization. Of course you (and anyone you name) would receive maintainer/write permission.

Hi Gabor,
I'm more than happy to host luavgl under the LVGL organization. I had planned to donate to LVGL, so thank you for the invitation :)
luavgl with lvgl version 8 has been successfully used in real project. It eases situations of install/remove applications which's nearly impossible for pure C code.
Migrating to lvgl v9, I have made several major changes.
The current ongoing work is to add property API to make binding easier. I'm currently not confident with the solution and need more time to investigate.
Let's setup a timeline for the migration, shall we?

Fantastic! There is no rush, so feel to tell a time when the v9 part can be finalized conveniently.
I'm not sure if you have followed it: to make sure that the bindings work well we run this test with CI: C, MicroPython, Reference image It is used only for MicroPython now, that's why only MicroPython is shown on our website:

It would be amazing if the same test could be added for Lua too, so we could promote it similarly to MicroPython.

I'm making progress now. Hopefully I can get this done in one or two months. I'll prepare the binding test for lua too.

Amazing, thank you Neo!
cc @coevin


SPManagedMetadataServiceAppDefault: Update resource to allow the configuration of the defaults per Service App Proxy Group

Details of the scenario you tried and the problem that is occurring
A support case for a customer revealed that the default MMS service app setting actually can be configured for one default per Service Application Proxy Group. The current version of the SPManagedMetadataServiceAppDefault resource only allows one default per farm. This resources needs updating to allow the configuration of one per proxy group. This would mean a Breaking Change, so can only be released with v4.0.
Suggested solution to the issue
Update resources to allow the configuration of one default per proxy group
The DSC configuration that is used to reproduce the issue (as detailed as possible)
SPManagedMetaDataServiceAppDefault ManagedMetadataServiceAppDefault
{
    ServiceAppProxyGroup           = "ProxyGroupName"
    DefaultSiteCollectionProxyName = "Managed Metadata Service Application Proxy"
    DefaultKeywordProxyName        = "Managed Metadata Service Application Proxy"
    PsDscRunAsCredential           = $SetupAccount
}

The operating system the target node is running
Any
Version of SharePoint that is used (e.g. SharePoint 2016)
Any
Version and build of PowerShell the target node is running
v5.1
Version of the DSC module that was used ('dev' if using current dev branch)
dev

Good catch. Totally missed this scenario in the initial implementation of the resource.

Closed via PR #1137


Wrong type narrowing when types are compatibles

TypeScript Version:  2.0.3
Code
class Result1 {
    readonly value1: number;

    constructor(value1: number) {
        this.value1 = value1;
    }
}

class Result2 {
    readonly value1: number;
    readonly value2: number;

    constructor(value1: number, value2: number) {
        this.value1 = value1;
        this.value2 = value2;
    }
}

function someFunction(result: Result1 | Result2) {
    if (result instanceof Result1) {
        // result is still Result1 | Result2
        console.log("1");
    }
    else {
        // result is never ! this is wrong !
        console.log("2");
    }
}

// this will output 2 !
someFunction(new Result2(9,9))

Expected behavior:
instance of type guard should not care about type compatibility
Actual behavior:
Wrong assertion by the compiler.

Essentially a duplicate of #10934. See also design notes about instanceof in #8503.

Indeed, this is a duplicate :(
From #7271, the issue will be fixed in 2.1.

@akarzazi note that the fix for #7271 only affects narrowing structurally identical types, but your issue here is with narrowing structural subtype/supertypes. This hasn't been solved yet and is on the roadmap for future investigation at an unspecified time.

@yortus I thought the fix will cover type compatibly as well.
Since mhegady said : As noted in #8503, classes should be treated definitely for instanceof checks.

FYI- This still reproduces with TypeScript 2.3.2

Really simplistic example of what's wrong with instanceof:
const model = this.opts.resources.model.store.get(id);
if (!model || model instanceof Placeholder)
    return null;
const data: any = model.get();

TSC gives the following error:
Property 'get' does not exist on type 'never'.
A workaround was proposed in #13325 but I can't see an equivalent in imperative code sections.

Fixed in #19671


Missing documentation on TLS settings from ATS to origin

Noted by motherclangercs on the IRC.  The proxy.config.ssl.server.cipher_suite is documented, but not the proxy.config.ssl.client.cipher_suite.  Similarly the ATS to origin settings for the TLS protocols allowed are not documented.  Possibly other ATS to origin TLS settings are also missing.

PR for documentation of origin side cipher_suite.
https://github.com/apache/trafficserver/pull/3370
The protocol versions are already documented in the doc of records.config


Bump dcos-ui to 1.10.9-rc.1

High-level description
Updated to DC/OS UI 1.10.9-rc.1
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-3800 Support docker parameters
DCOS-39282 Show allocated resources
DCOS-39661 Refactor ServiceDebugContainer: check instance type

Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot bump-ee


11437 dependent visualization calculation

Fix for #11437
This rewrites a good chunk of the code to check dependencies between user tables and visualizations. The old code assumed that a layer could only depend on a single user table, which is terribly false with join/merge analyses (it was also false before for custom join queries).
The new logic is that a visualization depends on a user table, if all of its layers depend on it. It can also be "partially dependent" (or non_dependent) if some of its layers do (this is used for deletign only some layers when deleting a dataset).
Acceptance

[x] STR for this ticket
[x] Create a map with two layers: A, B, based on two different datasets, a and b. Add a join column analysis on A, joining B sampling. Now delete dataset b. The warning modal about the map should appear. The full map should be deleted afterwards.
[x] Repeat previous steps, but this time delete dataset a. The warning modal about the map should appear. Only layer A should be deleted.

It looks like test went kaput! Slid this back to dev

Pushed a stub fix that should fix tests 👍

Refactored as per CR comments and things seem remarkably non-broken :)

like a charm, this is still happening https://github.com/CartoDB/cartodb/issues/11441#issuecomment-278263448, but out of the scope of the issue 🚀


Updates link in Production deployment of readme

I think I found a typo.  Hope this fix matches the author's intended meaning.

Thanks! 👌


Fix old Kerballoons releases KSP versions

Ref KSP-CKAN/NetKAN#4517
KSP-CKAN/NetKAN#4520 must be merged before this PR

I'll send a PM to the author and say this is done. Thanks :shipit:


⚠ ClamAV has degraded performance

In 1cd0076, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 187 ms

Resolved: ClamAV performance has improved in ea8d378.


Remove AppengineEnvPostProcessor

Remove AppengineEnvPostProcessor. See deprecation note in there. Also remove the SPI that specifies this.
Basically, encrypted values should not be decrypted at server startup, but should instead be decrypted on an as-needed basis, and then discarded.

Fixed via #122


Create a function which finds prime numbers not greater than the passed number N

Implement a function which takes a number N and returnes a list of primes which are not greater than it.
Prototype:
def find_primes(n: int) -> List[int]:
    ...

Put it inside the 0-python-basics/find_primes folder.

Cover it with tests :)


Worktree support

What they are
Git has a neat feature of worktrees where separate branches can co-exist in different subdiretories of the .git folder. All the editing then happens inside each of the relevant subdirectories, rather than at the root.
Benefits
Worktrees allow you to have multiple branches "checked out" at the same time rather than just the one, with stashing, popping and forgetting to move between them during mid-development. This allows you to quickly switch what you are working on or checkout a piece of code in another branch.
Additionally, the build folder and other artifacts will be per-subdirectory and branch, which means that there is no recompilation or pollution of untracked files or missing node modules when switching between branches
Plans
Neogit currently has very poor support for worktrees and bare repos, and is also lacking a popup and configuration view for adding and removing subtrees.
This feature (along with the bare repo) support has been half-requested for some time, though now after The Merge and all the improvements in our library and ui we are in a much better state to support this feature with a lot less complexity required to do so.
Feel free to comment below what you would like to have added and how your workflow for worktrees to look like such that we can make them possible 😊

Heh, The Merge.
I looked into this yesterday - it didn't look crazy complex, compared to, say, stashing. The Magit (https://github.com/magit/magit/blob/main/lisp/magit-worktree.el) functions are mostly just wrappers around the git CLI.
The biggest challenge we'll have is that Magit opens a file-drawer (dired) like https://github.com/nvim-telescope/telescope-file-browser.nvim, which I don't feel like vendoring. But if we stick to vim.fn.input() with nice autocompletion for filepaths I think that would suffice for a first draft.

ThePrimeagen made a video on this. Hoping to have neogit work in similar fashion.
https://www.youtube.com/watch?v=2uEqYw-N8uE&t=187s&pp=ygUMZ2l0IHdvcmt0cmVl

Thanks for considering better worktree/bare repo support.
It'd be amazing to have this feature! It's currently the only feature that's stopping me from fully switching to Neogit.

https://github.com/NeogitOrg/neogit/pull/1066


Remove/Modify final installer message.

We have this message on the final step
"Anaconda is the most popular Python data science platform.
Share your notebooks and packages on Anaconda Cloud!
Sign up for free"
per @scopatz, this is an active issue in the upstream repo. This is for tracking, Anthony, can you link to the appropriate upstream issue.

There is https://github.com/conda/constructor/issues/309 and https://github.com/conda/constructor/issues/331

it seems that conda/constructor#309 is still open and PR conda/constructor#309 was closed because its author didn't agree to sign the CLA


rename script/get  to improve readability

There are existing CI systems/external documentation that relies on scripts/get to install helm. If we rename it to get.sh, we break existing install paths for those systems.
On the other hand, I really like this change. Shell scripts should have their .sh extension.
Given that this is only a vanity change rather than a valuable feature for the install script, I would personally lean towards not merging this change.

I'm against changing it since it is preferred to have no extension according to Google's bash style guide. https://google.github.io/styleguide/shell.xml?showone=File_Extensions#File_Extensions
We don't have to follow that to the letter but its better than nothing imo.

@carlory Thank you for the submission but two core maintainers have decided to keep the file without adding the .sh extension.


[5.1] Add docblock to toIlluminateResponse

Added docblock to src/Illuminate/Foundation/Exceptions/Handler.php::toIlluminateResponse()
Imported the response object
Type hinted the exception parameter

:+1:


Updated Samples to work with Windows SDK version 10.0.10586.0

Updated Samples to work with Windows SDK version 10.0.10586.0 that is installed with Visual Studio 2015 Update 1

SDK versions updated in v2.0.3.


Fix typo in comment "eit" to "emit"

@swift-ci please smoke test and merge

The issue that caused this particular Linux CI failure was fixed a couple hours ago.

@swift-ci please smoke test and merge