gflags: fix build on case-insensitive filesystems

Motivation for this change
Darwin machines come with a case-insensitive filesystem by default. The
gflags package's source contains a file 'BUILD' and the build process
attempts to create a directory called 'build', which fails on
case-insensitive filesystems.
Things done
Add a prePatch hook to rename the BUILD file (which is for use with an unrelated build tool).

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)

Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] I did not test compilation of all pkgs that depend on this change because this should not produce a change to any machine code

[x] Tested execution of the bash completion script in bin

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build gflags

Success on x86_64-darwin (full log)
Attempted: gflags
Partial log (click to expand)
-- Installing: /nix/store/ycgmwjyysv01a0lg9livxdjvrc7j237s-gflags-2.2.1/lib/cmake/gflags/gflags-targets.cmake
-- Installing: /nix/store/ycgmwjyysv01a0lg9livxdjvrc7j237s-gflags-2.2.1/lib/cmake/gflags/gflags-targets-release.cmake
-- Installing: /nix/store/ycgmwjyysv01a0lg9livxdjvrc7j237s-gflags-2.2.1/bin/gflags_completions.sh
-- Installing: /nix/store/ycgmwjyysv01a0lg9livxdjvrc7j237s-gflags-2.2.1/lib/pkgconfig/gflags.pc
post-installation fixup
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ycgmwjyysv01a0lg9livxdjvrc7j237s-gflags-2.2.1/lib  /nix/store/ycgmwjyysv01a0lg9livxdjvrc7j237s-gflags-2.2.1/bin
patching script interpreter paths in /nix/store/ycgmwjyysv01a0lg9livxdjvrc7j237s-gflags-2.2.1
/nix/store/ycgmwjyysv01a0lg9livxdjvrc7j237s-gflags-2.2.1/bin/gflags_completions.sh: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/ycgmwjyysv01a0lg9livxdjvrc7j237s-gflags-2.2.1

Success on aarch64-linux (full log)
Attempted: gflags
Partial log (click to expand)
-- Installing: /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1/bin/gflags_completions.sh
-- Installing: /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1/lib/pkgconfig/gflags.pc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1/lib  /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1/bin
patching script interpreter paths in /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1
/nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1/bin/gflags_completions.sh: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1...
/nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1

Success on x86_64-linux (full log)
Attempted: gflags
Partial log (click to expand)
-- Installing: /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1/bin/gflags_completions.sh
-- Installing: /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1/lib/pkgconfig/gflags.pc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1/lib  /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1/bin
patching script interpreter paths in /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1
/nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1/bin/gflags_completions.sh: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1...
/nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1

@LnL7 Added platforms along with some other metadata.

looks like you forgot a semicolon after one of the attributes.

@GrahamcOfBorg build gflags

Success on x86_64-darwin (full log)
Attempted: gflags
Partial log (click to expand)
/nix/store/ycgmwjyysv01a0lg9livxdjvrc7j237s-gflags-2.2.1

Success on x86_64-linux (full log)
Attempted: gflags
Partial log (click to expand)
-- Installing: /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1/bin/gflags_completions.sh
-- Installing: /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1/lib/pkgconfig/gflags.pc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1/lib  /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1/bin
patching script interpreter paths in /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1
/nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1/bin/gflags_completions.sh: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
checking for references to /tmp/nix-build-gflags-2.2.1.drv-0 in /nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1...
/nix/store/kbs71v6py5155axxx6d9wc02gvgfa4z7-gflags-2.2.1

Success on aarch64-linux (full log)
Attempted: gflags
Partial log (click to expand)
-- Installing: /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1/bin/gflags_completions.sh
-- Installing: /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1/lib/pkgconfig/gflags.pc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1/lib  /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1/bin
patching script interpreter paths in /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1
/nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1/bin/gflags_completions.sh: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1...
/nix/store/rkxs7y2qs4nb7bk277whsg5zg345mnlc-gflags-2.2.1

Also ported to release in 021ee7d93be.


[C++][Parquet] TypedColumnReaderImpl::Skip should reuse scratch space

TypedColumnReaderImpl::Skip allocates scratch space on every call. The scratch space is used to read rep/def levels and values and throw them away. The memory allocation slows down the skip based on microbenchmarks. The scratch space can be allocated once and re-used.
Reporter: fatemah / @fatemehp
Assignee: fatemah](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=panahi) / @fatemehp
PRs and other links:

GitHub Pull Request #14509

Note: This issue was originally created as PARQUET-2204. Please see the migration documentation for further details.

Antoine Pitrou / @pitrou:
Issue resolved by pull request 14509
https://github.com/apache/arrow/pull/14509


Browser navigation and node rebuilds

I have a store with a list of elements that I am building out using Bind.eachi.
I implemented a manual push state into browser navigation history and moved to add a new item to the list.

After adding the new element clicking on the back button is not triggering a rebuild of the nodes. i.e new element is not displayed. I still see the old list although the store value is updated.

Also my understanding is that unMount should be invoked every time a SutilElement is moved out of the node tree.
Appears this is also not happening

How do I work around (1) ?

Sample repo to reproduce the problem
https://github.com/kaashyapan/sutil-bindlist-error.git

Click edit a user and in the user page change email.

See from console that the master store value has been updated. Click on back arrow to push history state.

Again click on edit user and note the following error in the console
[Log] error: Disposing #2=null: Error: The given key '#2=null' was not present in the dictionary. from #2 "Users" (Logging.fs.js, line 68)

Click edit a user and in the user page change email.

See from console that the master store value has been updated. Click on browser back button.

Note the following error in the console
[Log] error: Disposing #4=null: Error: The given key '#4=null' was not present in the dictionary. from #2 "" (Logging.fs.js, line 68)

[Log] error: Disposing #3=null: Error: The given key '#3=null' was not present in the dictionary. from #2 "" (Logging.fs.js, line 68)

Thanks for the repo. I'll take a look and get back to you.

Here's what I think the main problem is:
User.fs:
            disposeOnUnmount [ user; loading ]

and
Users.fs
            disposeOnUnmount  [ loading ]

The stores loading and user are globals stores, and so only 1 instance of each exists. Yet, each time we leave the User or Users page, we have asked Sutil to dispose those stores. The first time this will work of course, but the second time ,we are are attempting to dispose stores that have already been disposed.
You either need to have a new instance of these stores belonging to the respective view() functions, or just don't dispose them until the application quits (which you don't really need to do)

Thanks for your response.
My first code had the stores inside the module. Which apparently doesn't work because of the way Fable translates the code.
Moving the stores inside the view function works.


metabase: 0.32.10 -> 0.33.2

Motivation for this change
https://github.com/metabase/metabase/releases/tag/v0.33.2
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg test metabase

Ofborg being mean, but running the test locally works fine.


Tabs vs spaces in the vim editor

Some languages (at least Haskell) do not like tabs, but the editor (at least in vim mode) seems to insert tabs by default. Could we perhaps have either spaces by default (which would probably be safer than tabs), or allow tabs vs spaces to be chosen in the account preferences menu?

+1

This was fixed a while ago. Vim mode should always insert spaces now.


try to use this view to show only one month data

In my project , i need to use this view to show a year data , can i do something to let the viewpager doesn't work ? or just don 't use viewpager?

Why you couldn't use the SimpleDateFormat?

i'm sorry , maybe i don't show my question clearly, i find the view we used is alaways contains in viewpager , but i want to use recyclerview to contains that , but it takes a few seconds to load , so i want to find a solution .
thks.

If you have calendar in each ViewHolder, i think that few seconds it's good. When onMeasure tries to calculate size of block, your device has a huge performance problems.

yep , so i try to custom a view that suitable my projece , and learn more from this.
finally thanks a lot.


Collapse/Expand Component Tree Panel Groups Add Extra Entries

Describe the bug
When assigning a variable to a category group, the variable entries get duplicated:

Removing the categories fixes the issue, or simply never collapsing/expanding the category causes the problem.
Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Godot full version
No response
Orchestrator version
No response
Additional information
No response

This also appear to be problematic in the Graph panel too.


macOS support

$ kubectl krew install windows-debug
Updated the local copy of plugin index.
Installing plugin: windows-debug
W1201 08:56:08.545576   36364 install.go:164] failed to install plugin "windows-debug": plugin "windows-debug" does not offer installation for this platform
failed to install some plugins: [windows-debug]: plugin "windows-debug" does not offer installation for this platform

Would be great to add macOS support. As far as I can see this is only a bash script so might be just adding darwin arm64 and amd64 to some supported platform list?
Thanks for the plugin, looking forward to trying it! :)

added a PR to remove the arch from darwin. I'm not quite sure if that is all it needs. Didn't write krew plugins yet :)

Thanks!  https://github.com/kubernetes-sigs/krew-index/pull/2828/ will need to be merged then it should be avaliable!


Duplicate "New Modules" in email digest

When following multiple authors of the same module, the email digest will generate a duplicate entry for "New modules".
Address this by deduplicating the new modules array before sending it to the mailer.
Example screenshot

Still happening


Dynamic Scraper maintain session across requests

It seems like the dynamic scraper works by using the 'request' library to load content and then loads it in phantom with the setContent command.
https://github.com/ariya/phantomjs/wiki/API-Reference-WebPage#webpage-setContent
It seems to do navigation based scraping that depends on sessions we would have to manually parse out the appropriate data from the response object and pass it along in subsequent requests.
It would be nice to have a persistent session mode where the dynamic scraper would work at the level of a phantom WebPage instance (like a browser tab) and load/navigate across pages using js actions (like clicks). This is important for scraping ajax based pages. Tools like CasperJs work well for this, and the use cases for the Dynamic scraper seem a little limited without it.

+1 to the issue/suggestion.
It will be really great if we can have a persistent mode as CasperJS does.
Also, as a first time user, I didn't know that the DynamicScraper doesn't support sessions until I tried and failed. May be, it would be useful to people if we put that explicitly on the README.

Is this now covered by the scraper factory functionality? Maybe this issue could be closed if so...

This is not covered by scraperjs in any way.


csu commands not terminating on completion

They're left hanging rather than returning to the prompt. Seems to only be an issue on osx.

Does this occur with all commands?

nope, just some.

Can you let me know the results of:

start
end
help


AUI-2104 Users should not be able to interact to some features of the form builder while it is moving a row or a column

Just started reviewing :) :octocat: Sent from GH.

@thiago-rocha. I sent the missing documentation. Could you review again, please?

Just started reviewing :) :octocat: Sent from GH.

Just started reviewing :) :octocat: Sent from GH.

Pull request submitted to https://github.com/mairatma/alloy-ui/pull/325. :octocat: Sent from GH.


Return authorization URL response on authorize call, return BadReques…

Forward errors from authorization URL to caller, and return BadRequest error on missing params
Description
Updated authorize route in proxy to return the result from the redirect.  For other errors with missing params, return a BadRequest result.
Related issues
Addresses [issue AB#68689].
Testing
Unit test created and run

I am not convinced that we need to add src/Microsoft.Health.Fhir.Api.UnitTests/Controllers/openid-configuration.json, could we not just in the test provide the https://login.microsoftonline.com/common endpoint as authority and the controller would pull the openid-configuration as normal?

I am not convinced that we need to add src/Microsoft.Health.Fhir.Api.UnitTests/Controllers/openid-configuration.json, could we not just in the test provide the https://login.microsoftonline.com/common endpoint as authority and the controller would pull the openid-configuration as normal?

I think that would make it more of an integration test. We may be able to just mock out the returned configuration instead of adding it.

I am not convinced that we need to add src/Microsoft.Health.Fhir.Api.UnitTests/Controllers/openid-configuration.json, could we not just in the test provide the https://login.microsoftonline.com/common endpoint as authority and the controller would pull the openid-configuration as normal?

I think that would make it more of an integration test. We may be able to just mock out the returned configuration instead of adding it.

As Brandon said, I was trying to avoid having the test call out to any external resources by adding the file.  As it is now, the file is used as the mock response which the HttpClient sends back.  It was just a long enough string it seemed easier to place it in a separate file rather than embed it as a string in the C# file.


ppx disappears on external

Repro:
external debounce : int => ((unit =><EMAIL_ADDRESS>= "" [@@bs.module];

Turns into:
external debounce : int => unit => unit = "" [@@bs.module];

cc @bsansouci

I thought this was fixed. Did we not merge a PR?

There are more than one of these issues.

Attributes are very easy to be dropped by ppx (not yours maybe others). I would suggest using extension points (but you can design a better syntax).


Deployment issues?

Wasti, you weren't super clear in your email what links were problematic. Can you be a little more specific?
Your latest push caused the website to update successfully, so maybe it was all resolved?
@KhanWasti @julioveracruz

Yeah it looks like it got fixed


Adding profile for Jing (SWE intern on Spatial Advocacy)

Docs Build status updates of commit 7ee0967:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/jing-low.yml
:white_check_mark:Succeeded
View

advocates/media/profiles/jing-low.jpg
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Export dataset as csv files

Description of the problem
Currently calling Dataset.save() will save your preprocessed gaze and event dataframes to heather files mirroring the directory structure of the raw directory.
Although the feather/ipc fileformat is very space efficient and fast to load it has a major downside as it is a binary file format.
The user could prefer to save the dataset as human readable files, and for this CSV files would be perfect.
Description of a solution

the save() method should get an optional string argument extension: str = 'feather
the load() method will then also need this optional argument

Minimum acceptance criteria

[ ] add additional argument to save() and load() method
[ ] 100% coverage for the patch

Sample Code
It would be nice to call it like this:
dataset.save(extension='csv')
and then to be able to load it with
dataset.load(extension='csv')
Context
Internally, the Dataset.save() class calls Dataset.save_events() and Dataset.save_preprocessed().
Load is doing something similar with the particular load methods.
I think in the first iteration it should be sufficient to pass the extension argument just the called methods.
An alternative would be to have something like extension_events and extension_preprocessing but I think it's too much.
If the user decides to use CSVs instead of feather files, then they probably want to do it for both.
If they only want to, for example, save events as csvs and preprocessed as feather, then they still can use the explicit functions to do that.
More Context
The Dataset.save_events() and Dataset.save_preprocessed() methods call Dataset._raw_to_preprocessed_filepath() and Dataset._raw_to_event_filepath() respectively.
It will be easy to the extension argument there.
How to Test This
Currently the Dataset.save() method is only tested with test_save() from tests/dataset/dataset_test.py.
This checks only if a correct directory is created, not even if files where created.
It would be best to have an additional test method that checks that all created files in the directory have the correct extensions.
For this create a new function called test_save_files_have_correct_extension().
Also rename test_save() to test_save_creates_correct_directory()

fixed by #273


Allow parameters to be send with tap menu items

Request from thebogeyman (Marc Schermann) at https://community.home-assistant.io/t/home-assistant-app-for-garmin/637348/107:

Is it somehow possible to add parameters to a script when calling it via the tap_action?
I have something like this:

service: script.send_message
data:
  message: This is a message
  volume: 0.7

This would suggest a JSON format along the lines of:
{
  "$schema": "https://raw.githubusercontent.com/house-of-abbey/GarminHomeAssistant/main/config.schema.json",
  "title": "Home",
  "items": [
    {
      "entity": "script.configurable_item",
      "name": "Set Volume",
      "type": "tap",
      "tap_action": {
        "service": "script.send_message",
        "data": {
          "message": "This is a message",
          "volume": 0.7
        }
      }
    }
  ]
}

So the changes required are to store the parameters in the local menu item to be included in the makeWebRequest() call. This might be best done as keeping the data part of the JSON object as a Lang.Dictionary Monkey C object in order to include just one additional item into the HTTP call.

Example API call that I have working locally on a light bulb. Actually 3 LEDs @JosephAbbey put on a RP2040 to provide brightness levels 0-3 via a Home Assistant template that does some translation.
#!/bin/bash
#
#                      brightness%
# ./service_param.bash 19
#

API_KEY="<Your API Key>"
URL="<Your API URL>"

level=${1:-50}

echo "Brightness level: ${level}"

json='{
  "entity_id":      "light.<your light>",
  "brightness_pct": '${level}'
}'

curl -s -X POST \
  -H "Authorization: Bearer ${API_KEY}" \
  -H "Content-Type: application/json" \
  -d "${json}" \
  ${URL}/services/light/turn_on

echo ""

As can be seen from the JSON, it is actually just a case of extracting the proposed tap_action's data field to augment the JSON in the API request as siblings of entity_id. So this change is relatively simple.
Awaiting the code churn from #26 as the changes will collide.

Within the data parts of the JSON we are unable to provide schema checking. This means the application can crash if the parameters are wrong. For instance I mistakenly added "confirm": true inside data and on the 4th tap we application crashed.
{
  "$schema": "https://raw.githubusercontent.com/house-of-abbey/GarminHomeAssistant/main/config.schema.json",
  "title": "Home",
  "items": [
    {
      "entity": "script.configurable_item",
      "name": "Set Volume",
      "type": "tap",
      "tap_action": {
        "service": "script.send_message",
        "data": {
          "message": "This is a message",
          "volume": 0.7
        }
      }
    }
  ]
}


ML Support

I only see several ml algorithms in the example. May I know do you support other tree base algorithms such as XGBoost?

Yes, you can use Boosting algorithms in trees but the chances of overfitting increase you must need to keep in mind that these types of algorithms very easily go towards Overfitting specially XGBOOST RandonForestClassifier, etc.

Yes, you can use Boosting algorithms in trees but the chances of overfitting increase you must need to keep in mind that these types of algorithms very easily go towards Overfitting specially XGBOOST RandonForestClassifier, etc.

But I cannot find xgboost in the model directory. How should I use XGBoost and your method

?

Hi, we currently don't have support for XGBoost with DP. It may be something we will consider adding in the future. The best place to learn about current functionality is in our documentation: https://diffprivlib.readthedocs.io/


Provide setting for hiding chat margin

I would like a setting like editor.glyphMargin, except for hiding the "inline chat" feature buttons (the + buttons).
Alternatively, editor.glyphMargin should also control that.

Hi thanks for filing the issue. When you mention the inline chat feature buttons, what exactly are you referring to?

My bad, I guess it is something created by an extension and not just something built-in that was just "turned on" by an extension. Was talking about this plus sign which exists in the "Cody AI" extension, the button does open a chat.

/causedByExtension


[WIP][Clang][SR-1052] Imported C decls w/o warn_unused_result get @discardableResult

What's in this pull request?
Part 3 for SR-1052: Add @discardableResult attr to imported C declarations without the Clang warn_unused_result attribute.
Resolved bug number: Part 3 of SR-1052

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci please test and merge

I missed some OS X-specific tests. I'll get those updated later tonight.

I rebased and hopefully fixed the OS X-specific tests.

Wait. Found a few more.

@lattner, I believe this is ready for another test-and-merge cycle.

Thanks!

@swift-ci please test and merge

I rebased again and fixed more tests. There was a new OS X-only test introduced in the rebase.
I also found a test that was previously broken. There was a line:
FOUNDATION-NEXT  func objectAtIndex(_ index: Int) -> AnyObject!

Note the missing colon before the expected signature. This was causing the check to be skipped. I added the colon in my previous commit, and that made it fail as the objectAtIndex is now imported as a subscript. Hopefully I fixed that problem as well.

Cool.  Thank you for staying on top of this, sadly there are new merge conflicts.  If you have a chance to resolve those, I'll merge this and address any fallout, thanks!

I just finished a local rebase. I'm running the Linux tests now. Once those pass, I'll push it up.

Sounds good, thanks!

I pushed my rebased branch.

Thanks, I'll take it from here!

Thanks!

066f285 should do it, please let me know if you see something that looks wrong


set thousand separator sign

i want to change the default thousand separator (which is comma) to dot or space
but not using the locale, is it possible?

not currently.
It could be added though

also interested in this feature

Interested . I want to use FR format ( 1 500 instead of 1,500 )

Interested, we want to use FR format


nirvana parseAcceptTypes error

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:
debug to here:
func parseAcceptTypes(v string) ([]string, error) {
	fmt.Println("parseAcceptTypes", v)
	types := []string{}
	factors := []float64{}
	strs := strings.Split(v, ",")
	for _, str := range strs {
		str := strings.Trim(str, " ")
		tf := strings.Split(str, ";")
		types = append(types, tf[0])
		factor := 1.0
		if len(tf) == 2 {
			qp := strings.Split(tf[1], "=")
			q, err := strconv.ParseFloat(qp[1], 32)
			if err != nil {
				fmt.Println("strconv.ParseFloat(qp[1], 32)", err)
				return nil, err
			}
			factor = q
		}
		factors = append(factors, factor)
	}
	if len(types) <= 1 {
		return types, nil
	}
	// In most cases, bubble sort is enough.
	// Can optimize here.
	exchanged := true
	for exchanged {
		exchanged = false
		for i := 1; i < len(factors); i++ {
			if factors[i] > factors[i-1] {
				types[i-1], types[i] = types[i], types[i-1]
				factors[i-1], factors[i] = factors[i], factors[i-1]
				exchanged = true
			}
		}
	}
	return types, nil
}

this is log
parseAcceptTypes text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3
strconv.ParseFloat(qp[1], 32) strconv.ParseFloat: parsing "b3": invalid syntax
s.root.Match strconv.ParseFloat: parsing "b3": invalid syntax

use chrome will get this error, use safari will success. chrome will pass Accept Header v=b3
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

already fixed in master branch
/close


SpliceLogData - Ensure indexCurve is first in logCurveInfo

When splicing log data, there are some logs that does not return the indexCurve as the first element in the logCurveInfo list. This can lead to errors when creating the new spliced log.
Make sure to move the element that corresponds to indexCurve as the first element in the logCurveInfo that is used internally in SpliceLogDataWorker.

I suggest implementing a new method in WorkerTools.cs and making necessary changes in CompareLogDataWorker.cs as well.


Update action/core to 1.10.0 to fix deprecation warnings

I've been looking to the deprecation warnings described in https://github.com/pnpm/action-setup/issues/57.
Seems the source of the warnings is fixed in latest @action/core. See https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md#1100
I'm not sure how to test this... It's better to have a review before merging.
PS: for the doc part: https://github.com/pnpm/action-setup/pull/58

You have not updated the lockfile.


Issue #735 Basic integration tests check for bundle embeddedness

Introduce cases when validating the output of crc setup in integration tests: embedded bundle, not embedded bundle.

retest this please

retest this please

@jsliacan looks like your test is not accurate with embedded/non-embedded bundle message, you need to update it.

Closing in favour of #724 where I added the changes from this PR. This PR anyway needed #724 as a prerequisite.


[Bug]:

Prerequisites

[X] You read the guidelines for contributing.
[X] You are able to reproduce the problem in the latest version of Quirks.
[X] You checked that the problem has not yet been reported (also through closed issues).

Describe the exact steps to reproduce the problem in as many details as possible
I have a web app using Vue, Vite, and Quirks.
In my package.json, I have the below:
    "@quirks/core": "^0.19.0",
    "@quirks/store": "^0.27.0",
    "@quirks/vue": "^0.12.5",
    "@quirks/wallets": "^0.19.0",

And it all works fine.
When I change to latest version of @quirks/wallets:
    "@quirks/core": "^0.19.0",
    "@quirks/store": "^0.27.0",
    "@quirks/vue": "^0.12.5",
+   "@quirks/wallets": "^0.20.0",
-   "@quirks/wallets": "^0.19.0",

Describe the issue behavior
Then, if I run npm install, and npm run dev, I can still access my web app as usual.
However, after building it (npm run build) and deploying in production, loading the web app will result in a blank page, and the below error showing in console:
Uncaught ReferenceError: Buffer is not defined
    at index-BHeQET0V.js:329:129287

The error points to the below code:
var bnExports = bn.exports;
const createHmac = browser$1
  , ONE1 = Buffer.alloc(1, 1)
  , ZERO1 = Buffer.alloc(1, 0);
function deterministicGenerateK$1(g, A, v, _, b) {
    let B = Buffer.alloc(32, 0)

Hello @arlai-mk , thank you for reporting this issue. I'll check it in a few hours and I'll get back to you with a response, I think it's due to vite setup, in the meantime can you try this to add polyfills inside your vite.config.js?
import { defineConfig } from 'vite'
import { nodePolyfills } from 'vite-plugin-node-polyfills'

export default defineConfig({
  plugins: [nodePolyfills()]
})

Hi @DavideSegullo,
Thanks for the prompt answer.
I just tested it and confirm that it is working with the polyfills inside my vite.config.js.
You can close this bug, but maybe it can be worth it mentioning somewhere in the documentation for others who may be facing the same issue :)
Thank you again.
arlai

Ye thank you, I'll try to find a fix no one will need to polyfill it, for now I'll leave this issue open. Otherwise I'll add some details inside the doc, thank you!!

@arlai-mk Fixed, now you don't need to add polyfills

No problem! If you have other issues, feel free to ping me!


keyof interface that extends dynamic key interface does not return keys

TypeScript Version:  Nightly

Search Terms:
keyof dynamic keys, keyof extended dynamic interface, keyof generic interface
Expected behavior:
bKey should have "a" as type.
Actual behavior:
bKey has string | number as type.

Related Issues:
14359
Code
interface A {
    [key: string]: number;
}

interface B extends A {
    a: number;
}

const bKey: keyof B = 'foo';

Output
"use strict";
const bKey = 'foo';

Compiler Options
{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "useDefineForClassFields": false,
    "alwaysStrict": true,
    "allowUnreachableCode": false,
    "allowUnusedLabels": false,
    "downlevelIteration": false,
    "noEmitHelpers": false,
    "noLib": false,
    "noStrictGenericChecks": false,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "esModuleInterop": true,
    "preserveConstEnums": false,
    "removeComments": false,
    "skipLibCheck": false,
    "checkJs": false,
    "allowJs": false,
    "declaration": true,
    "experimentalDecorators": false,
    "emitDecoratorMetadata": false,
    "target": "ES2017",
    "module": "ESNext"
  }
}

Playground Link: Provided

This is working as intended.  B extends A, so all keys of A are also keys of B.  That means keyof B is string | number | "a", which reduces to string | number.

Ok, I understand.
Is there a way to only access keyof B? Using Exclude<keyof B, string | number> resolves as expected to never.

I found a comment in another issue that solves my problem. Thank you! I really appreciate your support!
https://github.com/Microsoft/TypeScript/issues/25987#issuecomment-408339599

I guess you're asking for something like "the keys of B which are not explicitly declared keys of A", since keyof B and keyof A are the same.
Teasing apart the keys of an object type with an index signature is possible but of dubious usefulness.  You could. for example, use this method to get the literal/"known" keys of an object site:
type KnownKeys<T> = {
    [K in keyof T]: string extends K ? never : number extends K ? never : K
} extends { [_ in keyof T]: infer U } ? U : never;

And then KnownKeys<A> is never and KnownKeys<B> is "a":
const bKey: KnownKeys<B> = "foo"; // error!

But what is the goal here?  If you really need to keep track of "the part of B not mentioned in A", you should probably start with that and then build B out of it:
interface A {
  [key: string]: number;
}

interface BminusA {
    a: number;
}

interface B extends A, BminusA { }

Playground link

I implement a module system where I modules have dependencies. I need the types of the dependencies but I also need to check if all dependencies are passed in runtime. Therefore I need an array of the dependency keys. The following is a pseudo code explanation of what I need.
interface Module<
  ConcreteModuleDependencies extends ModuleDependencies = ModuleDependencies
> {
  dependencies: KnownKeys<ConcreteModuleDependencies>;
  defaultDependencies: Partial<ConcreteModuleDependencies>;
}

interface ModuleDependencies {
  [key: string]: Module
}

interface FooModuleDependencies extends ModuleDependencies {
  bar: BarModule
}

type FooModule = Module<FooModuleDependencies>;

const fooModule: FooModule = {
  dependencies: ['bar'],
  defaultDependencies: {
    bar: BarModule
  }
}

What's  BarModule?  If your make your code into a minimal reproducible example suitable for dropping in a standalone IDE like the Playground I might be able to help guide you.  Of course GitHub issues aren't the right place for this; it should happen in Stack Overflow or a forum, etc.

You already answered my question. Thank you!


Migrate azure/notebooks/HPO-SKLearn.ipynb to deployment docs

Migrate azure/notebooks/HPO-SKLearn.ipynb to deployment docs.
See https://github.com/rapidsai/cloud-ml-examples/issues/203#issuecomment-1410349915 for detailed migration instructions.
### Tasks
- [ ] Decide if notebook should be migrated and add "migrate: X" label (if no also close this issue)
- [ ] Test if notebook works
- [ ] Fix up anything that needs changing
- [ ] Ensure notebook has good title, description and metadata tags in the first cell
- [ ] Replace deployment instructions with links to docs pages
- [ ] Copy notebook into a new folder into deployment docs examples
- [ ] Copy any supporting files to the folder
- [ ] Add notebook to examples toctree
- [ ] Make PR to deployment docs repo

@jacobtomlinson
I don't think we should migrate  sklearn_train_notebook, sklearn_hpo_notebook , and rapids_train_notebook,  seeing as there is MAJOR overlap with the rapids_hpo_notebook (covers training + hyperparameters tuning  in AzureML)
I am working on consolidating them in https://github.com/rapidsai/deployment/pull/192
Lmk your thoughts?

Fine with me, thanks @skirui-source


The website for this repo points to wrong URL

The description and website for the project are displayed near the top of Github's page for this project; they show "integrate Google Maps into Aldryn and django CMS sites via Google's API http://www.aldryn.com/en/marketplace/aldryn-google-analytics/"

The URL is incorrect.

thanks a lot for the report, I changed the url to a correct one


Blank Screen

It stopped working for me this week. I just get a blank screen. I tested it on a couple computers/networks and I get the same result. I also tried a collection rather than the featured.
I looked in the system console and I see this repeated error for Irvue:
Error Domain=NSCocoaErrorDomain Code=3840 "Invalid value around character 0." UserInfo={NSDebugDescription=Invalid value around character 0.}

Same here. Any way I can help pinpointing it? Irvue, which I also have installed, works fine.

Same here. High Sierra 10.13.4. Just a black screen.

Irvue Screensaver stopped working because its Unsplash API keys were deleted. I updated keys and uploaded new build for v1.0.7.


zenity-3.14.0 from build from source

1 error generated.
make[2]: *** [zenity-entry.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
After building every package possible from source

Please read the troubleshooting guide and post all of the requested diagnostics, thanks!

Closing as stale.


Re-implement ClusterCheckerTask

Inspect response body in case of success and failure
Treat empty response as a failuregit
Change metrics

Publish counter for each indicator, unless UP or ignored, tagged with target node name
Publish counter for each failure to talk to a node, tagged with target node name

Coverage increased (+0.005%) to 91.646% when pulling 1cd49469b832a426c8349de24989827886becda7 on mprimi:master into 2258f0c33c978ca6f31db4e060751cd5f4763458 on Netflix:master.


Show nn per page change and Apply to ALL tables doesn't work in Global Search

In Global Search, search for TB-ARC Mali, Click on Genomes (99), scroll to the bottom and change Show 20 to Show 99 click Apply to ALL tables (and 99 search results show up).
Nexst Global Search for TB-ARC KRITH, Click on Genomes (399) and only 20 genomes are displayed

Global Search results are NOT A TABLE...you didn't get the memo?!! ;)

It seems to be working for me, if I use Apply All Tables on mac/chrome. Let me know if you still have the problem.

still a problem for me.   I just tried it as described above, using Mac / Safari, cache cleared.   It works the same for me on Production and Beta.   I suspect that this happened when we switched from old workspace to new workspace.   I also suspect that it's working for Maulik because he's logged in.... just a guess.   Since the behavior is the same on beta and production, I don't think this is a required for release.

this is specific to outdated website.


Reformat "How we can help you text" to be tablet friendly

Currently, it looks like this:

Remove line breaks <br> to make it look like this:

That will make desktop look too wide, so you can constrain the width to
@media (min-width: 62em) {
.heresHowWeCanHelpParagraph {
max-width: 1000px;
margin-left: calc( ( 100vw - 1000px ) / 2 );
}
}

Looking good on tablet and desktop.

Thanks


Remove 2 backslashes in shell call

To avoid make failure on openSUSE and Fedora
for openSUSE: start failing in OBS hardware project
between 2020-04-05 and 2020-04-08
for Fedora: start to fail with Rawhide (F33)

This patch do not cover the use case where /usr/include/misc/cxl.h is not present.
use case failure identified by @fbarrat  on Ubuntu, but also present on Fedora or openSUSE.
ubuntu@zaiuslp14:~/michel/libcxl.mno$ make clean; rm -rf include; make
rm -f *.o *.d libcxl.so* libcxl.a include/misc/cxl.h
        [CC]     libcxl.o
In file included from libcxl.c:42:
libcxl.h:22:10: fatal error: misc/cxl.h: No such file or directory
   22 | #include <misc/cxl.h>
      |          ^~~~~~~~~~~~
compilation terminated.
make: *** [Makefile.rules:22: libcxl.o] Error 1

Even if correction still valid for distro builds that has this header before build start
I need to find another correction for general purpose; so close this PR in the meantime.


SSH Agent Forwarding With MacOS and Docker Desktop

ISSUE TYPE

Bug Report

SUMMARY
The SSH agent is not correctly mounted when using MacOS and Docker Desktop with Ansible Navigator.
ANSIBLE-NAVIGATOR VERSION
% ansible-navigator --version
ansible-navigator 3.4.0

CONFIGURATION
In one of the cases you can try to configure ansible-navigator.yml to mount the volume and configure the ENV variable as described in the Docker Desktop documentation.
---
ansible-navigator:
  execution-environment:
    environment-variables:
      set:
        SSH_AUTH_SOCK: /run/host-services/ssh-auth.sock
    volume-mounts:
      - src: /run/host-services/ssh-auth.sock
        dest: /run/host-services/ssh-auth.sock

LOG FILE
Warning: Issues were found while applying the settings.
   Hint: Command provided: '--mode stdout run playbook.yml --inventory hosts'

  Error: The following execution-environment.volume-mounts entry could not be parsed:  {'src': '/run/host-services/ssh-auth.sock',
         'dest': '/run/host-services/ssh-auth.sock'} (Settings file). Errors were found: Source: '/run/host-services/ssh-auth.sock'
         does not exist.
   Hint: The value of execution-environment.volume-mounts should be a list of dictionaries and valid keys are 'src', 'dest' and
         'options'.

   Note: Configuration failed, using default log file location. (/Users/abcd/efgh/ansible-navigator.log)
         Log level set to debug
   Hint: Review the hints and log file to see what went wrong.

STEPS TO REPRODUCE

Using MacOS, Python provided by MacOS, Ansible Navigator installed
Configure a target machine with SSH key based authentication using a key with a passphrase
Add the SSH key to the agent
Try to use ansible-navigator

EXPECTED RESULTS
Ideally, it detects the container runtime and automatically mounts the SSH agent into the container correctly.
ACTUAL RESULTS

With no configuration it runs the playbook but is missing the credentials provided by the SSH agent
With configuration in the ansible-navigator.yml to add the volume for /run/host-services/ssh-auth.sock it fails because the volume does not exist on the host running ansible-navigator

Should ansible-navigator be validating the bind mount paths or should we leave that up to the container runtime?

ADDITIONAL INFORMATION
https://docs.docker.com/desktop/networking/#ssh-agent-forwarding

https://github.com/ansible/ansible-runner/pull/1293 is the PR in ansible-runner. A similar fix will be needed for the volume check in ansible-navigator. Alternatively, should the volume check be removed for ansible-navigator all together?

Hi @timway. I've posted a question here https://github.com/ansible/ansible-navigator/discussions/1621 which seems to be highly related with this issue. Could you please take a look and let me know if you have any idea?
Thank you!

Also running into this issue and want to add my support for this issue getting attention.


'Color Coded Tilemap' doc fixup

Move the related legacy tilemap reference pages into the color-coded-tilempap doc space. Include a top-level page to satisfy the extension's "Learn More" destination link.
Closes https://github.com/microsoft/pxt-arcade/issues/5581

Wow, these were typos from more than two years ago.


[Analytics] Events around new onboarding

Tracks

[x] Tapped get started: Fired when tapping the "Get Started" button, one of two options on the start screen splash

properties: {}

[x] Tapped onboarding search: Fired when tapping the onboarding search field in categories or artists context

properties: {context_type: [artists, categories]}

[x] Follow artist: An artist can be followed from artist page, from fair artist pages, or during onboarding

properties: {artist_slug, artist_id, source_screen:[artist page, artist fair page, onboarding top artists, onboarding search, onboarding recommended]}

[x] Follow category: A category can be followed from a gene page or during onboarding

properties: {gene_id, source_screen: [gene page, onboarding top categories, onboarding search, onboarding recommended]}

[x] Budget selected: Fired when user selects a budget option during onboarding

properties: {budget: [under 500, etc.]}

[x] Tapped sign up: Fired when tapping "Join" or "Connect with facebook" on the sign up screen (last step of onboarding)

properties: {context_type: [email, facebook]}

[x] Created account: Fired when acocunt was successfully created

properties: {context_type: [email, facebook]}

[x] Sign up failed: Fired when a user tapped "Join" or "Connect with facebook" on the sign up screen but an account was not created for some reason (passowrd too short, invalid email, etc.)

properties: {context_type: [email, facebook], errors: ["invalid email, invalid password"]}

[x] Tapped log in on start screen: Fired when tapping the "Log in" button, one of two options on the start screen splash

properties: {}

[x] Tapped log in on log in screen: Fired when tapping "Login", "Connect with facebook", or "Connect with twitter" on the login screen

properties: {context_type: [email, facebook, twitter]}

[x] Successfully logged in: Fired when user log in successfully

properties: {context_type: [email, facebook, twitter]}

[x] Log in failed: Fired when a user tapped "Login", "Connect with twitter", or "Connect with facebook" on the login screen but the login was not successful for some reason (wrong password, a user with that email does not exist, etc.

properties: {context_type: [email, facebook, twitter],errors: ["wrong password, inexistent user, etc"]}

[ ] Artsy notification prompt response: Fired when user responds to Artsy notification prompt

properties: {outcome: [yes, cancel], context_type: [onboarding, artist follow]}

[ ] Apple notification prompt response: Fired when user responds to Apple notification prompt

properties: {outcome: [yes, cancel], context_type: [onboarding, artist follow]}

Screens

[x] Onboarding start: screenshot
[x] Onboarding follow artists: screenshot
[x] Onboarding follow categories: screenshot
[x] Onboarding select budget: screenshot
[x] Onboarding signup: screenshot
[x] Onboarding login: screenshot

Questions

Do we need a search_keyboard_dismissed event as indication of search completion or is the current eventing enough?

Do we need a property on the onboarding_follow_artists and onboarding_follow_categories screen views to indicate which version of the screen the user is seeing: top, searched, you may also like

Do we need unfollow_artist and unfollow_category events?

Do we need an artsy_notification_propmpt_viewed event?
cc @mennenia @katarinabatina

Do we need a search_keyboard_dismissed event as indication of search completion or is the current eventing enough?

Unless there is something learnt from the behaviour of dismissing ("can a user dismiss the keyboard?"), I don't believe so.. cc/ @katarinabatina

Do we need a property on the onboarding_follow_artists and onboarding_follow_categories screen views to indicate which version of the screen the user is seeing: top, searched, you may also like

By default, the screen will always start with "Top Artists / Popular Categories". The only way to get to searches and recommendations is by actually searching, and tapping artists / categories, which are events we're already tracking. So I would assume we don't need this additional event.

Do we need unfollow_artist and unfollow_category events?

This behaviour isn't currently supported anyway, as when I discussed with @katarinabatina, the onboarding flow isn't really designed to follow/unfollow, rather to get you started with populating some of your favourites.

Do we need an artsy_notification_propmpt_viewed event?

We can add that, if you'd like. There is no way to dismiss the popup without pressing either OK or Cancel so, in some ways, if you add those two events up together you'd get the total amount of times the popup had been shown. Up to you.

Questions:
@anipetrov

On our current Follow Artist event (from other source pages), we only send the Artist ID and under the artist_slug property for you. In Eigen artist_slug and artist_id are the same. Can I keep this behaviour in the onboarding source screens also?

This means you get: artist_slug : "artist_ID" and source_screen : onboarding top artists for instance.

For the follow category event:

Seeing as this is event is also triggered when you follow a category in the app, I didn't change the naming. The event is currently called gene favorite for you, so I've kept it that way rather than naming it follow category. That ok or would you like it all to change to follow category?
Current implementation notes and FYIs:
There won't be specific "sign up failed because invalid email" event, because we disable the sign up button if you don't have:

at least 6 characters in your password
the email field has an @ in it

There is still a possibility of sign up failing, where we do show an alert to the user saying that they should check their email / password. This error is: possible email or password issue for you.
Errors added:
Sign up:

could not get facebook credentials
possible email or password issue
account already exists

Log in:

could not get twitter credentials
could not get facebook credentials
 no artsy account associated with facebook profile
invalid email and or password (we can't distinguish which)

Do we need a search_keyboard_dismissed event as indication of search completion or is the current eventing enough?

Unless there is something learnt from the behaviour of dismissing ("can a user dismiss the keyboard?"), I don't believe so.. cc/ @katarinabatina

Theoretically there’s also the option for people to use physical keyboards with iPad, in which case there’s no dismissing of keyboards at all.

Questions:
@anipetrov

On our current Follow Artist event (from other source pages), we only send the Artist ID and under the artist_slug property for you. In Eigen artist_slug and artist_id are the same. Can I keep this behaviour in the onboarding source screens also?

This means you get: artist_slug : "artist_ID" and source_screen : onboarding top artists for instance.
Sounds good @mennenia!
2) For the follow category event:
Seeing as this is event is also triggered when you follow a category in the app, I didn't change the naming. The event is currently called gene favorite for you, so I've kept it that way rather than naming it follow category. That ok or would you like it all to change to follow category?

Let's keep the current naming convention! I will amend the spreadsheet

@anipetrov
I've added the analytics for the notification prompt. Bear in mind there is an additional context that I have named "launch".
When the app starts / launches, there is also the possibility of the popup showing up! :)
If you like it renamed to something else, let me know.

Closing. Can be reopened for QA.


How to run this?

i have intslled by downoading package and then just pip install -r requirments.txt ... after packages were installed i run this command:
python fetch_funding_rate_all_exchanges.py - from examples folder but got error :
\examples\fetch_funding_rate_all_exchanges.py", line 4, in
from funding_rate_arbitrage.frarb import FundingRateArbitrage
ModuleNotFoundError: No module named 'funding_rate_arbitrage'
What i am doing wrong?

I apologise for any inconvenience caused.
I'm quite busy and will reply over the weekend.

@switchy7
There was a problem with setup.py, which caused pip installs to not work.
This problem has been resolved in the following commit. https://github.com/aoki-h-jp/funding-rate-arbitrage/commit/ddc35b14238fa733bc62e4337ffcdb6a2b94a9e9
Please try the following method on top of that.
~$ pip install git+https://github.com/aoki-h-jp/funding-rate-arbitrage
~$ vi example.py
~$ python3 example.py

The following code is saved as example.py in vi. (Exactly the same as fetch_funding_rate_all_exchanges.py)
"""
An example of fetching funding rate
"""
from funding_rate_arbitrage.frarb import FundingRateArbitrage

if __name__ == "__main__":
    # fetch from all exchanges
    fr = FundingRateArbitrage()
    for ex in fr.get_exchanges():
        print(ex)
        print(fr.fetch_all_funding_rate(exchange=ex))

Hello, os have you time?

@switchy7
I'm busy these days, is there anything you would like me to develop additionally?

sorry i have not seen your preveous answer, and is there a way to make auto trade for it/

@switchy7
I have plans to implement automatic funding rate arbitrage, but actually doing this trade by ourselves is surprisingly difficult due to the following points.

I would like to take a position of generally more than $10,000 to make a large profit, but if I take such a position on the market, the order volume tends to be so large that it penetrates the board, and I end up losing money.
Even if the same amount of orders are submitted to both Exchanges A and B at the limit price, they will not necessarily be executed, and if only one of them is executed, or if they are executed in a biased manner, funding rate arbitrage will fail.
The same problem occurs when closing a position (but it is easier than when opening a position).

Therefore, we believe that full automation is more difficult than expected. If you have any ideas to improve the above, we would like to hear them.

i am so sorry i have been bussy thise days, can you please leave contact to talk about automation?

@switchy7
tg: @grandezooey


[DNM] fit for go-hbase refactor

I extract function signature which be modified from https://github.com/pingcap/go-hbase/pull/5. All of them just need add a error value to receive, but don't handle the error.
We make it pass first.
PR from tidb pingcap/tidb#703
@c4pt0r @qiuyesuifeng PTAL

@c4pt0r @qiuyesuifeng PTAL

@c4pt0r  PTAL

LGTM


Unable to save model with optional fake fields

I'm trying to save a model where (some of) the fake fields are optional, unfortunately this results in an sql exception (Column not found) for the fake field if it is not filled.
The reason (I suspect after looking through the code) for this is that the isset($request[$fields[$k]['name']]) (starting from php 5.4) also returns false if the field inside equals null.
I think the compactFakeFields should be updated to always pull the field from the request array and to either allow null/empty values or at least move the isset($request[$fields[$k]['name']]) inside the "if a field is defined as fake" check (because the way it is build now, a field basically get's unfaked when the request variable is undefined/null).

Hi @chancezeus ,
Fake fields should be allowed to be optional, I completely agree. But I just tested it and it worked fine for me.
Do you have your fake field mentioned in the $fillable property on your model? If so, please remove it and leave only the actual db column (extras or whatever), along with real fields. That should be the problem.
Hope it helps. Cheers!

@tabacitu : I had the same issue above and adding the extras field to the model's $fillable property did the trick. In my situation, however, I was previously using the $guarded property; shouldn't they both work?
Before (failed w/ optional fake columns):
protected $guarded = [
    'id',
    'created_at',
    'updated_at',
    'deleted_at'
];
// protected $fillable = [];

And after (works as expected):
// protected $guarded = [];
protected $fillable = [
    'fillable',
    'columns',
    'including',
    'extras'
];

I was having this issue, just solved it and created a pull request #787.
The variable was arriving at compactFakeFields as null, so it won't be treated as a fake field, backpack would try to store it on its own column.
By replacing isset by array_key_exists, the key exists as null, so it's treated as a fake field.

Just merged @promatik 's PR into dev. Will be available to everyone on master shortly. Thanks!


Refinement from 'mixed' to 'object' is lost after call to hasOwnProperty()

In the following, I'd expect both uses of hasOwnProperty to type check successfully, but the latter produces "call of method hasOwnProperty. Method cannot be called on mixed".
function f(input: mixed) {
  if (typeof input === 'object' && input !== null) {
    input.hasOwnProperty('foo');
    for (const key in input) {
      if (!input.hasOwnProperty(key)) continue;
    }
  }
}

https://flow.org/try/#0GYVwdgxgLglg9mABMAFDMAHEUBciC2MAHgKYAmAlIgN4BQiiMwiKUAnhiXM+llIgF4hiAORwARgCsS0EYgBk8xpmyIAhMLAgANtqp0GDXtgB0ACwCGAZwDyAdzAAFAE5xOz9ihHA4cERQBuekMfZxYIBCt+AGsSNmVlPn1gw0ZmFDVjKHNreydXd09YtgoqCLBYLRIg1IBfYPraoA

This version has no errors, although I did not really change anything, just some reformatting:
function f (input: mixed) {
    if (typeof input === 'object' && input !== null) {
        input.hasOwnProperty('foo');

        for (const key in input) {
            if (!input.hasOwnProperty(key)) {
                //...
            }
        }
    }
}

Flow Try link

input (and all function parameters) are not constants. Flow is afraid that these variables will change value at some point in the function, because they could. If input was type number, it could change to another number, and that's fine. The type is still number, so you can do number things with it. However, if input can have multiple times (as mixed, it can), then changing it from an object to a number or string or etc. means you can no longer do Object things with it.
To get around this, you set temporary constant variables:
function f(input: mixed) {
  if (typeof input === 'object' && input !== null) {
    const i: Object = input;
    i.hasOwnProperty('foo');
    for (const key in i) {
      if (!i.hasOwnProperty(key)) continue;
    }
  }
}

If input changes, that's fine -- the temporary variable here still points to the Object that input was, allowing you to use Object methods on it.

That should ONLY be a concern if a function is called, which Flow does not interpret further and therefore treats as "possibly mutating". I don't think this is a valid explanation in this case, without any inner function. I've had that conversation numerous times previously, and it always was about inner functions.

That should ONLY be a concern if a function is called,

You'd think so. Unfortunately (or fortunately for the original poster), the code I posted validated with no errors.
hasOwnProperty probably is a refinement invalidation. I don't believe Flow distinguishes between whether or not a called function is an innate, non-mutating JavaScript function or a possibly-mutating, user-made function. Perhaps it should.

hasOwnProperty probably is a refinement invalidation. I don't believe Flow distinguishes between whether or not a called function is an innate, non-mutating JavaScript function or a possibly-mutating, user-made function. Perhaps it should.

Ah, interesting.  Yeah, I think you're right about this; I assumed (for not good reason) that hasOwnProperty would have special semantics.  Thanks for the workaround, @CharlesStover.

expected since function call invalidates refinements


Auto deployment to the UAT environment is broken

There was a disk space issue on the server (due to the automatic downloads maybe?), I rebooted the server to cleanup tmp unfortunately I cannot connect to it via SSH anymore. Will ask help from someone who has control over the infrastructure.

Ok, server finally came back online and auto-deployment has been confirmed to work.


mIoU on validation sets during training, i.e., 61 class mIoU

Hi, thanks for your good work. I guess the performance of the pre-trained model is vital for the later few-shot task. So, can you provide the mIoU of validation sets during training? Should have four values for four splits of each dataset.

Hey,
Thanks for your interest. Here are the validation curves for Pascal-5i folds (i.e on the 15+1 training classes ) for 100 epochs with a PsPNet-Resnet50), and the same hyperparameters as described in the paper. I will also post the curves for Coco-20i soon.

Interestingly, the few-shot results seem to be inversely correlated to those validation results (for instance, split 1 has the worst validation mIoU, but the best mIoU with few-shot tasks). Intuitively, that's understandable, as a high validation performance can mean that the model has well specialized to the 16 (or 61) classes seen during training (in a sense has overfitted those classes) , while the few-shot tasks are sampled from the unseen classes.
Ps: By setting the option episodic_val to False in the .yaml files, the validation will be made on the 16 (or 61) classes used for training and you should now be able to reproduce those curves.
Malik

Thanks for your reply. It seems non-overfitting on base classes is vital for generalized few-shot tasks.


typescript: add base model typing

Summary
Add explicit typing to BaseModel to aide development.

[x] Tell us about the problem your pull request is solving.
Currently, the BaseModel has type any which makes intellisense nearly useless. I am adding interfaces with jsdoc strings to further improve the already great experience of developing with FeathersVuex.
[x] Are there any open issues that are related to this?
no
[x] Is this PR dependent on PRs in other repos?
no

Other Information
Because the BaseModel class is constructed inside a function, it's type cannot be used outside of that function. My solution is to define multiple interfaces: one for the static side ModelStatic, and one for the instance side ModelInstance. Both of these interfaces are generic and take a type parameter that describes the service's data structure. There is also a ModelInstanceClone interface for clones.
Ideally, we would just make the BaseModel returned from the FeathersVuex setup function generic, but I could not find a way to cast the non-generic BaseModel of type any to a generic interface. So my solution is to return BaseModel casted to a ModelStatic<{}> and an additional method castBaseModel from the setup function which can be used to add typing for each service's data interface.
Notes

Model<D> is of type ModelInstance<D> & Readonly<D>

This enforces clone & commit pattern because the model data is readonly so TS will error when trying to directly alter model data.

ModelClone<D> is of type ModelInstanceClone<D> & D

I hide commit() and reset() methods in ModelInstanceClone since they just error on non-clones.
Clone model data is not readonly so you can directly assign to it

Examples
If you want to check out how this works with intellisense, take a look at the following. Or even better, clone this branch, paste it in index.ts and play with it :-)
const { BaseModel, castBaseModel } = feathersVuex({}, { serverAlias: 'api' })

// Old way of doing things
class OldFashionedNote extends BaseModel {
  static readonly servicePath: 'old-fashioned-note'
}
const ofn = new OldFashionedNote()

// New way with types
interface NoteRecord {
  id: number
  text: string
  userId: number
  color: string
  isItBetter?: true
}

class FancyTypedNote extends castBaseModel<NoteRecord>() {
  static readonly servicePath = 'fancy-typed-note'

  static setupInstance(data: Partial<NoteRecord>, ctx: SetupContext) {
    const typedStoreAccess = ctx.store['fancy-typed-note'].isFindPending
    return data
  }
}
const ftn = new FancyTypedNote()
ftn.text = 'TS shows error because data is readonly!'

const ftnClone = ftn.clone()
ftnClone.text = 'Direct assignment to clones is fine!'

Screenshots
Autocomplete for OldFashionedNote instance

No commit() or reset()
also no typing for actual model

Autocomplete for OldFashionedNote class

includes EventEmitter methods for Model events

Autocomplete for FancyTypedNote instance

includes NoteRecord fields!

Augmentable interfaces
Users can also augment interfaces defined for feathers-vuex to add more helpful typing
interface MyApiModels {
  FancyTypedNote: typeof FancyTypedNote
  OldFashionedNote: typeof OldFashionedNote
}

// This example is pasted in `index.ts` but a user would actually use
// declare module 'feathers-vuex' {...
declare module '.' {
  interface FeathersVuexStoreState {
    'old-fashioned-note': ServiceState
    'fancy-typed-note': ServiceState
  }
  interface FeathersVuexGlobalModels {
    api: MyApiModels
  }
}

And then they can get autocomplete on Model.models, Model.store, Vue.$FeathersVuex, setupInstance's store and models params, etc.

I have intentionally left out some methods and fields from the BaseModel class but if I am mistaken and those should be publicly visible, please let me know! (Or if other should be hidden)

hydrateAll() - I've never used SSR but wasn't sure if this was called internally or by clients
keepCopiesInStore - this is going to be deprecated
merge() - under the impression this is internal use only

I'm probably forgetting a few...

This is awesome! Thank you for your contribution.
It seems that there is a extra brace at the last line of the index.ts file and it makes the CI build fail.

@J3m5 ah thank you! That's what I get for making my playground in index.ts 😛

There are a lot of Typescript errors that came up in the CI build, can you take a look at it ?
Can they be caused by by the changes in the tsconfig.json file ?

@J3m5 yeah they definitely are. I think stricter null checking is good but enabling that is outside the scope of this PR so I'll revert that.

So the next issue I want some opinions on is whether or not Model data should be readonly. This will a decent amount of test updates which I'm willing to do, but don't want to do if we decide to not make it readonly :-)
Pros of making it readonly:

enforces clone and commit pattern during development
enforces Vuex strict mode compliance

Cons:

will be a breaking change for everyone not using clone & commit
adhering to vuex strict mode remains in the user's cognitive load instead of TS reminding them "hey you shouldn't directly edit this without cloning first"

Thoughts?

Will this only impact typescript users ?
And could this be manually changed by overriding the types ?
( I'm not very familiar with Typescript. )

Correct, only TS users will be affected by this. You can always cast away the readonly if you want
const n = new Note()
n.text = 'this throws an error' // <-- TS error: NoteRecord props are readonly

const casted = n as ModelClone<NoteRecord>
casted.text = 'this is fine' // no error

I will have to think about whether we could make this something the user can augment so they could globally disable it if they don't want it and don't want to cast everywhere.

If this can be globally disabled, I think we can enforce it by default and add some info in the docs.
And maybe add those info as JSDocs directly, no ?

There is now an exported interface FeathersVuexTypeOptions which users can augment. Specifically, users can now do the following to disable readonly model data
declare module 'feathers-vuex' {
  interface FeathersVuexTypeOptions {
    'model-readonly': false
  }
}

if model-readonly is anything other than false, model data will be readonly.

It looks good !
It seems that some tests like this one needs to be changed in order to follow the readonly constraint of the modelName on the BaseModel.
And here the FeathersVuexGlobalModels need to be augmented, like mentionned here, if I understand correctly.
And I've noticed that the globalModels object is casted as FeathersVuexGlobalModels in some place but not in others, is this intended ?

And here the FeathersVuexGlobalModels need to be augmented, like mentionned here, if I understand correctly.

I am just casting models any in the tests because you can't augment for each test individually. And the classes in each test are private (local to that test) so they can't be augmented to the shared global interface.

And I've noticed that the globalModels object is casted as FeathersVuexGlobalModels in some place but not in others, is this intended ?

My goal is to make the user-facing models interface show what models they have defined (and augmented into the global interface). However, if I make the internal models of the same type, then when classes extend from BaseModel, they end up circularly referencing themselves through the FeathersVuexGlobalModels interface.

6c73939 makes it so that

if a user doesn't augment FeathersVuexStoreState, the store has type any
if a user doesn't augment FeathersVuexGlobalModels, the models has type any

This should make it easier to transition (less breaking changes) since those values have type any currently. It makes explicit typing of store and global models opt-in instead of required.

Damn, guys!  Sweet update.  Let me know when it's ready.  It looks like it will really improve DX.  <3

@hamiltoes will it improve DX if I merge this as is?

@marshallswain no, sorry. I haven't found time to finish up this PR.
I've ran into some issues that make this not work when you have a custom base class. You can't use a class type argument in a base class expression.
class MyBaseClass<T> extends castBaseModel<T>() {} // <--TS Error

So unfortunately I think this will be a case of over-promise, under-deliver. :-(
My plan is to pare this down to just non-generic Model and ModelStatic interfaces so we at least get typing for all the built-in methods and props.

This is ready to merge pending feedback on readonly static props. Any thoughts @marshallswain, @J3m5 ?

I think we should let them as they are now, at least for now. What do you think @marshallswain ?

If static props are still mutable, then I'll go ahead and merge this.

@marshallswain I've made all static props mutable except for store, models, and copiesById.

This would address #519

Brought up to date with latest master. I believe this is ready to merge if there is still interest.

Merged!  Thanks @hamiltoes!  This is a huge update. Thanks for your input, as always, @J3m5!


When using Subscribables compositionally, types are lost

Bug Report
Current Behavior
When using a subscribable compositionally inside a TypeScript class, type information is lost.
In the snippet below, TypeScript should be able to infer the type for Consumer.subscribe
class Consumer {
    get subscribe() {
        return this.thing.subscribe.bind(this.thing)
    }

    constructor(
        private thing: Observable<string>
    ){}
}

Reproduction

REPL or Repo link:
http://www.typescriptlang.org/play/#code/JYWwDg9gTgLgBAbzgeQEYGcCmUBuBDVAG0zgF84AzKCEOAcigA8ArdOgKHYGNC9104AYQgA7dAFcQ2ROzhy4Ac0zwJGLlGCpMACgCUM+YbhRl4qCLgwAFsHQA6a8BEK7q9Os2Y7qJwBNtjvaOzrqy8qSchlyi6DBQ4lww0NphRnBgGvgwJMEKAFwoGNj4RJgAPLEazgB8qXC6CBER3DHwEHAAvHAimADuhVi4BMQVcU4K1XotYvBcnd19QjGS2NoQoewA9JtwAKKMYJiJcABEOCeW7VpwEBSWAJ6Hp5XjJ9yu4moaWto4ndUGeTRMQQYh2QgQBS-UKkDZAA

Expected behavior
The subscribe method on the parent class should have properly inferred type information.
Environment

Runtime: TypeScript playground
RxJS version: Lastest (I think)
(If bug is related) Loader, build configuration: No

Possible Solution

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

In addition, composition the old way doesn't work either
import { Observable } from 'rxjs'

const o = new Observable<string>()
const c = {
    ...o
}

// Expect "v" to be of type "string"
c.subscribe(v => {
    console.log(v)
})

http://www.typescriptlang.org/play/#code/JYWwDg9gTgLgBAbzgeQEYGcCmUBuBDVAG0zgF84AzKCEOAcigA8ArdOgKE4GMIA7deBDgBeOL0wB3FBmz4imADwCowXgHMAfAAoAlOx794XEYjjs4FuADobEdqU4B6R3ACijMJi7wARDh9wMEKoJBAUgQCennA+yqpqPvpW6ACuGFwqIVo4IhqI5pYG6BDEVoQQatl6pHrsQA

Unlikely to be an RxjS issue. Check out the TypeScript strictBindCallApply compiler option.

Nice one, thanks for that.
https://codesandbox.io/s/sweet-mirzakhani-ebr7q


Presets for Maya2glTF

I have a series of instructions for export to Godot Engine.
https://gist.github.com/fire/cc1a497b0e75da1576a0366d30a0c038
Is it reasonable to make a preset?
Any design suggestions?

Will get back to this, next two days I'm presenting my first educational web-game on a trade fair, exciting times...

List of Quality of Life changes (QOL):
Add maya2glTF_UI to a shelf?
Keep a list of recent copyright tags.
Default the scene name to the name of the export file.
Have a button for Select menu in maya → All by Type → Geometry.
If a clip name does not exist default to the scene name.
Add a Godot default.

Update the scale factor from 1.0 to 0.01.
Add "-bsf -isc" to the extra flags entry field.
Add a checkbox for "-mts" if normal maps are from Blender or are in mikktspace
Update animation to the proper type. Defaulting to time slider

Hope your trade show went well.
Is there an icon for a shelf?

Yes, still recovering from it ;-)
No actually we have no icon yet.
For now, we are just using the WonderMedia logo (since this is the company that employs me and allows this exporter the be open source).
But yes, a dedicated logo should be better ;-)
https://avatars2.githubusercontent.com/u/40519170?s=110&v=4

This is my current wireframe.

It would save two clicks if the Godot preset is default, however that's two clicks more for Wonder Media.
Any suggestions on solving the problem of reducing two clicks?

Here's another wireframe.

Special thanks to someone helping me UX design.

It should be possible to have two shelf icons. One for the default maya2glTF and another for Godot Engine presets.

It's starting to take shape.

Here's a preset for Godot Engine:

Closing because I've completely forgotten the context and design for the work.


docs page flickering

Reproduction
Using latest chrome on a mac, open 2 tabs to https://pinia.esm.dev/  and the page starts flickering weirdly.
I can see it's caused by the dark mode flipping on and off rapidly.
I assume it has something to do with how dark mode selection is being saved in localstorage.

This is happening for me from time to time. Firefox, windows 10.

It seemed like a weird bug related to SSG + the dark mode from vueuse but I will soon migrate to a different theme that shouldn't have this issue

No, it's not related to pinia which are not needed in the docs. Opening devtools and changing the local storage property that sets the theme should allow fixing this. Other strategies are reloading the page after closing the other ones.
This will be fixed in the next migration of the docs anyway.

The flickering bug has been fixed upstream

Is the fix it still not live? As soon as I open the second tab with https://pinia.esm.dev/ it starts flickering.

Is the fix it still not live? As soon as I open the second tab with https://pinia.esm.dev/ it starts flickering.

the same thing happens to me

As a temporary workaround, while having only one tab opened with the docs, run this js in the console:
localStorage.setItem('pinia-color-scheme', 'dark') // or 'light' if you prefer light theme

Still happening, see video:
https://user-images.githubusercontent.com/30939926/148706994-71f2c2c4-a436-4b2f-97fc-bfbc1d828ab7.mov

I'm still getting this too. Was wondering how this feature was enabled anyway since it looks like it's vitepress. I know that Evan mentioned new docs were coming soon, so I assume we're waiting for that release? I see there's a pull request on vitepress to fix: export default theme type & properly type vitepress/theme.
[The New Vue by Evan You](https://youtu.be/2KBHvaAWJOA?t=1365

)

Still getting this on Chrome 97 (M1 Mac) even after using the temporary localStorage workaround.

https://streamable.com/zf57tl you can see the switch back and forth when you do inspect... A little bit surprised that this is still happening.

Please expedite addressing this if possible as it does not meet the W3C WCAG 2.0 specifications to not allow Three Flashes or Below Threshold. This is a potential health concern for those with epilepsy or a neurological condition that can easily trigger seizures.
https://www.w3.org/TR/UNDERSTANDING-WCAG20/seizure-does-not-violate.html

Ill give it a go today. Don’t expect it’s too tough to track down.

 I had to disable JavaScript globally for this to settle down (why do doc sites even need JS??)


LookupError: <ContextVar name='gettext' at 0x0000016824CC2B30>

Hi!
First of all, thank you for this amazing library! I'd like to reopen this issue because I have a similar problem and I wasn't able to solve it. I'm using Version: 0.0.9.
In my application I use the _() inside a worker function using ThreadPoolExecutor. The error I'm receiving is the same as this issue:
\fastapi_babel\core.py", line 123, in _
    gettext = _context_var.get()
LookupError: <ContextVar name='gettext' at 0x0000016824CC2B30>

Here's a simplified version of my issue, which still illustrates the problem
from fastapi_babel import Babel, BabelConfigs, BabelMiddleware
from fastapi_babel.core import _
from fastapi import FastAPI, Header
from typing_extensions import Annotated
from typing import Union, Callable

from concurrent.futures import ThreadPoolExecutor, as_completed

app = FastAPI()
babel_configs = BabelConfigs(
    ROOT_DIR=__file__,
    BABEL_DEFAULT_LOCALE="en",
    BABEL_TRANSLATION_DIRECTORY="lang",
)

app.add_middleware(
    BabelMiddleware, babel_configs=babel_configs
)

# Passes, no problemo
@app.get("/test0")
async def func_0(accept_language: Annotated[Union[str, None], Header()] = None):
    return {"text": _("Hello, World!")}

def getHW():
    return _("Hello, World!")

# Still passes, no problemo
@app.get("/test1")
async def func_1(accept_language: Annotated[Union[str, None], Header()] = None):
    return {"text": getHW()}

# LookupError: <ContextVar name='gettext' at 0x0000016824CC2B30> :(
@app.get("/test2")
async def func_2(accept_language: Annotated[Union[str, None], Header()] = None
    ):
    future_to_index = {}
    index_to_result = {}
    with ThreadPoolExecutor() as executor:
        future_to_index = {executor.submit(getHW): i for i in range(10)}
        for future in as_completed(future_to_index):
            index = future_to_index[future]
            res = future.result()
            index_to_result[index] = res
    return {"text": index_to_result}

Do you have any suggestions on how to resolve this issue @Legopapurida ? I read your comment mentioning lazy_gettext, but I was not able to apply it to my case...

I have answered your problem here 36#

@levente-murgas
I have been many issues and please upgrade your babel


Reauthenticate from stored token when app is reloaded

@thomchop: Storing the token and re-authenticating from stored token is working:
https://github.com/mattermost/mattermost-mobile/pull/78
Things that I think are missing but could go on a different tasks:

SplashScreen that would be the actual initial screen
Flag in config to jump the choose server screen
Remove navbar and custom navbar, so that back button does not cause a conflict going back to the server screen
When user clicks back (top left button) to Channels or Teams Screen. Click doesn't work.


Error handling

Currently, if the lexer finds an error, it returns a single ERRORTOKEN containing the whole of the rest of the buffer. This is suboptimal:

The name ERRORTOKEN is hard-coded (taken from Python). We probably want it user-customisable.
It returns many lines, making the resulting message hard to read.
It leaks the entire buffer (thanks to V8's implementation of slice() using SlicedStrings).

Other considerations:

Is an error token preferable to throwing an exception? (Probably—exceptions should be exceptional, and syntax errors in a parser aren't.)
If/when we have a Stream wrapper, we can only return an ERRORTOKEN if we know we've seen the end of the stream. Otherwise, it's possible seeing more data might complete a valid token.

If/when we have a Stream wrapper

In its current state, the API is too generic to allow a useful stream wrapper. Consider the following language:
moo.compile({
  even: /(ab)+(?!a)/,
  odd: /(ab)*a/,
})

Suppose the stream emits aba, ba, bab. The correct tokenization of abababab is a single even token, but the lexer cannot determine that until it reaches the end of the stream; emitting any earlier will result in an incorrect token.

Wow, good point; I'd missed that.
@hardmath123 It sounds like we can't seamlessly integrate moo into nearley; at least not with proper feed() / Stream support. :(

In its current state

Am I to read you don't like the API? You helped design it! :-)

It sounds like we can't seamlessly integrate moo into nearley; at least not with proper feed() / Stream support. :(

My understanding is that

Am I to read you don't like the API? You helped design it! :-)

No, I do like the API! I was simply pointing out that it's incompatible with a stream API that doesn't re-lex the stream when it gets new data.
If you leave the task of pushing data only at token boundaries up to the user, then we can certainly integrate it into nearley.
It's also possible, I guess, to re-lex the last token when we get new data, but it's still possible to break this if you have two tokens which, when concatenated, are a different token; and this makes the API weird because you need to sometimes return a token twice.

Fixed by #25


last4 added

@all-contributors add @lukebrandonfarrell for code and infra and project management

@all-contributors add @ChesterSim for docs and code and debugging

@all-contributors add @ChesterSim and @amogh-jrules for docs and code and debugging

@all-contributors add @amogh-jrules for docs and code and debugging

@all-contributors add @ChesterSim for debug

@all-contributors add @ChesterSim for bug


Add web interface instead of cli so android users will be benefited.

you can use a usb otg cable and a usb terminal app with and android phone

you can use a usb otg cable and a usb terminal app with and android phone

But that's not cool🤡

yes web interface would be cool!


[8.x] Add nested relationships to whereRelation function

This PR added the possibility to use nested relationships when using 'whereRelation' Eloquent's function, using dot notation.
Also still works with not nested relationships, so it's not a breaking change.
How it works
// Before
Company::whereHas('teams', function($query) {
  $query->whereHas('users', function($query) {
      $query->whereHas('roles', function($query) {
          $query->where('name', 'admin');
      });
  });
})->get();

// After 💅🏻
Company::whereRelation('teams.users.roles', 'name', 'admin')->get();

// Also can be used as orWhereRelation
Company::where('public', true)->orWhereRelation('teams.users', 'id', auth()->id())->get();

// Still can use this function for not nested relationships
Company::whereRelation('teams', 'id', '1')->get();

Why was this merged?

It was already possible to used nested relations before these code changes.
This PR contains no tests...


the token could also be in config

https://github.com/dxomg/vpsbot/blob/5bdbc14474aead5d2ed06f0a5277ad961f2d0ba0/lxcbot/main.py#L1205
The token could also be in config for ease of use

Done


fix/test: swap over contiguously initialized ticks with spacing of one

Closes: #5558
What is the purpose of the change
Adding swap test vectors for out given in  where contiguous ticks are initialized with spacing of one. Both zero for one and one for zero are covered
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

Closing in favor of: https://github.com/osmosis-labs/osmosis/pull/5582


Error: while detecting compiler information:

Please create a discussion in https://github.com/microsoft/vcpkg/discussions/new instead.
when i run command : vcpkg install xxx , i get error like below:

➜  vcpkg git:(master) vcpkg install libpng
Computing installation plan...
The following packages will be built and installed:
    libpng[core]:x64-osx -> 1.6.37#15
  * vcpkg-cmake[core]:x64-osx -> 2021-09-13
  * vcpkg-cmake-config[core]:x64-osx -> 2021-09-27
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-osx...
Error: while detecting compiler information:
The log content at /Users/chendongsheng/github/vcpkg/buildtrees/detect_compiler/stdout-x64-osx.log is:
-- Configuring x64-osx-rel
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: /usr/local/Cellar/cmake/3.21.4/bin/cmake /Users/chendongsheng/github/vcpkg/scripts/detect_compiler -DCMAKE_MAKE_PROGRAM=/Users/chendongsheng/github/vcpkg/downloads/tools/ninja-1.10.2-osx/ninja -DCMAKE_SYSTEM_NAME=Darwin -DBUILD_SHARED_LIBS=OFF -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/Users/chendongsheng/github/vcpkg/scripts/toolchains/osx.cmake -DVCPKG_TARGET_TRIPLET=x64-osx -DVCPKG_SET_CHARSET_FLAG=ON -DVCPKG_PLATFORM_TOOLSET=external -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DVCPKG_APPLOCAL_DEPS=OFF -DCMAKE_TOOLCHAIN_FILE=/Users/chendongsheng/github/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -DVCPKG_CXX_FLAGS= -DVCPKG_CXX_FLAGS_RELEASE= -DVCPKG_CXX_FLAGS_DEBUG= -DVCPKG_C_FLAGS= -DVCPKG_C_FLAGS_RELEASE= -DVCPKG_C_FLAGS_DEBUG= -DVCPKG_CRT_LINKAGE=dynamic -DVCPKG_LINKER_FLAGS= -DVCPKG_LINKER_FLAGS_RELEASE= -DVCPKG_LINKER_FLAGS_DEBUG= -DVCPKG_TARGET_ARCHITECTURE=x64 -DCMAKE_INSTALL_LIBDIR:STRING=lib -DCMAKE_INSTALL_BINDIR:STRING=bin -D_VCPKG_ROOT_DIR=/Users/chendongsheng/github/vcpkg -D_VCPKG_INSTALLED_DIR=/Users/chendongsheng/github/vcpkg/installed -DVCPKG_MANIFEST_INSTALL=OFF -DCMAKE_OSX_ARCHITECTURES=x86_64 -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/Users/chendongsheng/github/vcpkg/packages/detect_compiler_x64-osx
    Working Directory: /Users/chendongsheng/github/vcpkg/buildtrees/detect_compiler/x64-osx-rel
    Error code: 1
    See logs for more information:
      /Users/chendongsheng/github/vcpkg/buildtrees/detect_compiler/config-x64-osx-rel-out.log
      /Users/chendongsheng/github/vcpkg/buildtrees/detect_compiler/config-x64-osx-rel-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:394 (vcpkg_execute_required_process)
  scripts/detect_compiler/portfile.cmake:18 (vcpkg_configure_cmake)
  scripts/ports.cmake:142 (include)

See logs for more information:
    /Users/chendongsheng/github/vcpkg/buildtrees/detect_compiler/config-x64-osx-rel-out.log
    /Users/chendongsheng/github/vcpkg/buildtrees/detect_compiler/config-x64-osx-rel-err.log

@sexjun ,Thanks for posting this issue, please provide the error log:
      /Users/chendongsheng/github/vcpkg/buildtrees/detect_compiler/config-x64-osx-rel-out.log
      /Users/chendongsheng/github/vcpkg/buildtrees/detect_compiler/config-x64-osx-rel-err.log

@sexjun ,Thanks for posting this issue, please provide the error log:
      /Users/chendongsheng/github/vcpkg/buildtrees/detect_compiler/config-x64-osx-rel-out.log
      /Users/chendongsheng/github/vcpkg/buildtrees/detect_compiler/config-x64-osx-rel-err.log

I reInstall vcpkg for sloving this question, and the log lost, the question was sloved by reinstall.
I was run git pull --rebase on the folder of vcpkg . I suspect it was the order that caused it.
tks for tring help me.


Not all objects need to be Disposed

Some objects like the HttpClient and HttpWebRequest do not need to be disposed even though they implement IDisposable. In fact the advice is not to dispose HttpClient. Please add exceptions for these types. I'm sure there are others.

@code-cracker/owners What do you think about this ?

HttpClient has to be disposed, it would not make sense to implement IDisposable if it was not disposable. When it opens a connection it holds unmanaged resource until it is disposed. You might reuse it on your app, so you don't open unnecessary local ports, and might dispose it only when your app closes, but if you try to create 10000 HttpClients and not close any you might end up exausting your machine resources.
So, I vote that, for this cases, the user should disable it with #pragma.

@giggio It's make sense for me too.


create meta.json

close pr. reason: later update https://github.com/ordinals-wallet/ordinals-collections/pull/2228 was already merged.


Error loading page: ValidationError: page.click: selector: expected string, got undefined

Hi,
I am getting this error when running the command
node cwv input=example/input.csv output=example/output.csv
Testing with chromium 93.0.4530.0
example/input.csv - file successfully read
Testing 1 URLs
Error loading page: ValidationError: page.click: selector: expected string, got undefined
    at tString (/Users/dwt/Downloads/cww/massWebVitals/node_modules/playwright/lib/protocol/validatorPrimitives.js:44:11)
    at /Users/dwt/Downloads/cww/massWebVitals/node_modules/playwright/lib/protocol/validatorPrimitives.js:89:27
    at Proxy.<anonymous> (/Users/dwt/Downloads/cww/massWebVitals/node_modules/playwright/lib/client/channelOwner.js:64:99)
    at /Users/dwt/Downloads/cww/massWebVitals/node_modules/playwright/lib/client/frame.js:270:34
    at Frame._wrapApiCall (/Users/dwt/Downloads/cww/massWebVitals/node_modules/playwright/lib/client/channelOwner.js:77:34)
    at Frame.click (/Users/dwt/Downloads/cww/massWebVitals/node_modules/playwright/lib/client/frame.js:269:21)
    at /Users/dwt/Downloads/cww/massWebVitals/node_modules/playwright/lib/client/page.js:422:60
    at Page._attributeToPage (/Users/dwt/Downloads/cww/massWebVitals/node_modules/playwright/lib/client/page.js:202:20)
    at Page.click (/Users/dwt/Downloads/cww/massWebVitals/node_modules/playwright/lib/client/page.js:422:21)
    at getMetric (/Users/dwt/Downloads/cww/massWebVitals/cwv.js:107:28)
1 of 1  https://www.amazon.co.uk/ Error
creating example/output.csv
example/output.csv saved - done!

Yes , was removed. Thanks a lot for kind help.
On Fri, 11 Jun 2021 at 5:27 pm, Dave Smart @.***> wrote:

Hey @aznain https://github.com/aznain
Looks like perhaps you have edited the input file & it is a bit malformed,
is the , missing after https://www.amazon.co.uk/ ?
Does it look like this?
url,cookie_closehttps://www.amazon.co.uk/
Even if you don't want to specify a click target to close a pop up or
anything, there still needs to be a field for it,
url,cookie_closehttps://www.amazon.co.uk/,
Would work, but leave the cookie banner up
url,cookie_closehttps://www.amazon.co.uk/,[data-cel-widget=sp-cc-accept]
Would close the banner.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dwsmart/massWebVitals/issues/6#issuecomment-859347990,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG3DH5QW66H2MQ7GHAQ5ETTSG3HBANCNFSM46P4DJQQ
.

Glad we got it fixed @aznain!


Treat "(cid:%d)" as a possible char to reduce "Out of order" warnings

Description of the problems or issues
Is your pull request related to a problem? Please describe.
Related to #33, currently pdftotree produces CID characters like (cid:176).
This is now totally expected behaviour of pdftotree, so "Out of order warning" should not be raised.
Does your pull request fix any issue.
N/A
Description of the proposed changes
Treat "(cid:%d)" as a possible char
Test plan
Test with paleo.pdf that produces "Out of order" warnings
Checklist

[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I have updated the CHANGELOG.md accordingly.

Codecov Report

Merging #102 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   66.83%   66.83%   -0.01%
==========================================
  Files          24       24
  Lines        2593     2596       +3
==========================================
+ Hits         1733     1735       +2
- Misses        860      861       +1

Flag
Coverage Δ

#unittests
66.83% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pdftotree/TreeExtract.py
89.26% <100.00%> (-0.28%)
:arrow_down:

tests/test_basic.py
96.10% <100.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e38be...36bc8a5. Read the comment docs.


Provide output path

Can we provide output path for generated document? It generates the document in "doc" folder. Can we customized it?

I believe that this is a YARD configuration setting:
$ yardoc --help
...
   -o, --output-dir PATH            The output directory. (defaults to ./doc)
...


Fix typescript issues

What

Fix TypeScript issues
Updates @sentry/react to v8
Updates connected-react-router to v6

How to test

Run git checkout develop.
Follow the build instructions to run the project.
Run npx yarn tsc --noEmit
Verify that there are currently two TypeScript errors (Sentry and ConnectedRouter).
Checkout this branch / this PR.
Run yarn install and optionally follow the build instructions again to run the project.
Run npx yarn tsc --noEmit again.
Verify that the TypeScript errors are gone.
Make sure the project runs as expected.

Notes
I followed the official migration guides:

https://github.com/supasate/connected-react-router/blob/master/FAQ.md#how-to-migrate-from-v4-to-v5v6
https://docs.sentry.io/platforms/javascript/guides/react/migration/

Closes https://github.com/GTBitsOfGood/MapScout/issues/278

@thanasis457, do you still want to take a look at this? #278


Long texts making getMarkdown to freeze the app

Describe the bug
When using tiptap-markdown and a long text (example: https://tiptap.dev/examples/book) the 200k word text here, it freezes the editor, and any update made is also extremely slow.
To Reproduce
Steps to reproduce the behavior:

Tiptap Editor with StarterKit and tiptap-markdown extension
Paste the above book text
Takes around 3-4 seconds to render
Scrolling and typing is too slow

Expected behavior
However when you use editor.getText() its almost instantaneous.
Screenshots
See Video
https://github.com/aguingand/tiptap-markdown/assets/57321156/83ac1695-8ace-4e76-a22b-9af447888a87

Prosemirror markdown seems to cause this. You can try to insert the large content in the example page.
For your information I've fixed parse perfomance in the latest release (v0.8.2), so it should be significantly faster at first load.

Thanks! I'll give it a try. I feel the issue with slowness is it tries to reserialise the entire 200k word for every onUpdate that causes it.
Tried debouncing it to every 10 secs, but then the sudden lag would come post 10 secs, and would carry on since the next debounces would stagger.
Will check v0.8.2

I think performances improvements can be done to prosemirror-markdown. I'll keep this open for now but it's not in the scope of this package.


Fix NspAnalyzer

Fixes Issue #835
Root Cause
NspAnalyzer fails to parse package.json files that contain the following keys:

{
  // Should be parsed as a JsonArray but was parsed as JsonObject
  "bundledDependencies": [
    "node-pre-gyp"
  ],

  // Older libraries use license objects rather than JsonString
  {
  "license": {
    "type": "MIT",
    "url": "https://github.com/twbs/bootstrap/blob/master/LICENSE"
  }
}

Changes

NspAnalyzer: parse "bundleDependencies" as JsonArray
NspAnalyzer: parse "bundledDependencies" as JsonArray
NspAnalyzer: parse "license" as JsonObject and subelement "type" as JsonString in cases where older libraries used a license object

Can one of the admins verify this patch?

@ktham Thanks for the excellent PR - especially the additional (and much needed) tests. I've verified in my environment the changes. Are these the only changes necessary to fix #835?

@stevespringett no problem, I started to use this library and needed this issue fixed 😄  It may not be exhaustive, but those are the only changes that is needed to fix #835 for the set of libraries that was scanned in my project

@ktham Thank you for the PR! I'm trying to solve one more, non-related, issue and then I plan on pushing a new release (hopefully this weekend).

@jeremylong Just wondering if you're close to cutting a release or if there are more thing you're trying to squeeze in?

Recently discovered a threading issue that needs to be dealt with - which is what was causing the delay. We will likely release a version this week and then spend the next dev cycle re-working some code to resolve the threading issues.