Red Agent Making Illegal Moves

Hi,
Just double checking - there may be a small bug with the red agent choosing invalid actions from the action space. Repro can be found here - second_bug_branch - with an example case shown in 'notebooks/Random_Network_Invalid_Move.ipynb'.
Additional nodes are set up with create_node_data_two, such that the firewall conf is set to block all and there are no SMB / RDP vulns present. Only one edge is made for each new node, between the local machine that has the "knows_on_capture" exploit and the target node it pivots to. The idea is that once the knows_on_capture exploit is launched, essentially its like finding handwritten credentials, auto granting access to the remote machine.
From the ipynb file we can see that there are many attempted remote connections between these additional nodes and the original nodes in the network. Edges are added with the EdgeAnnotation.REMOTE as it tries to exploit RDP / SMB connections which shouldn't be possible. The local vulnerability library of the new nodes are empty { }, firewall rules are set to block all and no edges were formed when generating the nx graph in edges_labels dict.
The agent doesn't appear successful with its attacks, and if it helps I'm fairly confident that these attacks are only attempted at the very end of all its other potential attack routes, but I find it strange that it can try make these moves in the first place. This would add a +1 move which could skew results if the agent shouldn't be able to select from these moves to begin with.
Not sure if related but could be due to the way we are calling __mark_node_as_owned directly?
Thanks in advanced!

@Dawn-RL As you suggested I think it's due to the fact that you are calling __mark_node_as_owner. If I understand correctly the intent of the LeakyGuyId you are implementing it should only leak the existence of the node. If that's what you want to do then you can implement this by calling instead: __mark_node_as_discovered.

Hi Blumu,
Ideally we would like it to own the node automatically, so I think mark_node_as_owned should work. It just seems to me like the action mask is missing some verification when selecting from a pool of valid moves.
Cheers

I see, so the vulnerability name knows_on_capture might have misled me due to the terminology used in our simulation (known for us means discovered as opposed to owned).
I looked at the notebook (Thanks for putting this together by the way!) and I notice that nodes 4, 6 and 14 all have the knows_on_capture vulnerability set to grant access to respectively nodes 15, 16, 17.

Therefore, if the agent owns 4, 6 and 14 then it can exploits the knows_on_capture vulnerability to gain ownership of 15, 16 and 17 via the LeakedGuyId outcome of the vulnerability exploit.
The index for this local vulnerability appears to be 3 and you can see in the trace that it's indeed being used to get access to nodes id 16 and 17:

From node id 14 (with index 8) the agent exploits the vulnerability with index 3 to get ownership of node id 17:

+ rewarded action: {'local_vulnerability': array([8, 3], dtype=int32)} total_reward=359.0 reward=2.0 @t=617

Further down, from node id 6 (with index 12) the agent exploits the same knows_on_capture vulnerability (index 3) to own node id 16:

+ rewarded action: {'local_vulnerability': array([12,  3], dtype=int32)} total_reward=511.0 reward=2.0 @t=862

So, it's expected to see some activity from node id 16 and 17.
Now according to the final table in your simulation, node 15 is never owned so I cannot explain why we see some activity from this node. There might indeed be a bug somewhere, I need to investigate further.

@Dawn-RL The main branch has some changes to avoid confusion between the node internal IDs and the node indices used by the agent. In particular when pretty printing the rewarded actions it now shows the actual node ID from the environment graph. It also prints the vulnerability name. I've rebased your branch on it and rerun your notebook: https://github.com/microsoft/CyberBattleSim/blob/wiblum/dawnrl/second_bug_branch/notebooks/Random_Network_Invalid_Move.ipynb
It's now easier to see steps where the agent exploits the Knows_on_capture vulnerability to access nodes with ID > 15. E.g., here node with ID 2 exploits the vulnerability to gain ownership of 15:

I was not able to reproduce the situation you described where you could see activity from a node that's not owned by the agent. Take a look and let me know if you still think there is a bug.


Remove unneeded zindex from input labels

Description

Removing https://github.com/adobe/spectrum-css/blob/master/components/checkbox/index.css#L65 and from radio and switch as well.
These can cause interference with components that use isolation: isolate to create a new stacking context
Why do you need this feature or component?

Our Modal positioned at z-index 10000+ was having mouse events intercepted by radios that were visually behind the modal
Additional context

So this is still needed, however, we need to contain the stacking context, so the top level class for the component needs to have isolation: isolate;
we should consider putting this at the top level of every component that has a z-index specified in it


bypass linting

Codecov Report
Patch and project coverage have no change.

Comparison is base (519ec93) 84.86% compared to head (0987798) 84.86%.
Report is 11 commits behind head on master.

:exclamation: Current head 0987798 differs from pull request most recent head ad5ef0c. Consider uploading reports for the commit ad5ef0c to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   84.86%   84.86%
=======================================
  Files          12       12
  Lines         185      185
=======================================
  Hits          157      157
  Misses         24       24
  Partials        4        4

Files Changed
Coverage Δ

pkg/rtp/eastern.go
71.42% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unable to Complete User Delegation to a Service/App Account

Type of Connector
Custom Connector
Name of Connector
microsoft / PowerPlatformConnectors
Describe the bug
I have been working with the Snowflake vendor and also our Azure & Power Apps/Automate admin to be able to connect to the Snowflake REST API using a Service/App account from PowerApps.
Has the application account level been tested using this connector via powerapps? This is the feature that is not working for us and we cant implement in PROD at individual level.
After several troubleshooting sessions (and parallel testing), the Snowflake vendor recommended us to open issue on this project due to issues we are both seeing in our testing.
Both the Snowflake vendor and my company tested this individually and ran into the same issues below. Refer to notes and screenshots.

We are UNABLE to get PowerApps custom connector to allow us to delegate an individual user to a service/app account executing the Snowflake REST API (we dont want the same single user to be passed to Snowflake so dont have to add every individual user in our organization on the Snowflake side in order to use the Snowflake REST API)

ERROR: Need admin approval - needs permission to access resources in your organization that only an admin can grant. Please ask the admin to grant permission  to this app before you can use it.
Completed admin consent
** looked in azure client console and NO admin consent pending - same error
** had the azure admin complete the consent directly in the power apps prompts (using his azure admin account and provided ) - same error
Refer to attached screenshots showing the issue
asks for admin consent but there is nothing pending admin consent in Azure when look at the client

Also, it seems like the "security" items added into the "security" tab seem to get cleared out and PowerApps DOES NOT honor them.  This may be part of the issue.

Is this a security bug?
Yes, this is a security bug
What is the severity of this bug?
Severity 2 - One or more important connector features are down
To Reproduce
Follow the existing documentation here in the custom connector BUT when it comes to setting up the permissions in Azure follow this Snowflake document linked. It uses app roles (added via manifest). https://community.snowflake.com/s/article/Create-External-OAuth-Token-Using-Azure-AD-For-The-OAuth-Client-Itself
In this projects custom connector documentation, within step 1 of the linked prereqs documentation (https://github.com/microsoft/PowerPlatformConnectors/tree/dev/custom-connectors/Snowflake#pre-requisites-for-using-the-connector) it has us stop at step 10 .. where step 11 is the step to setup an application account level.
Has the application account level been tested using this connector via powerapps? This is the feature that is not working for us and we cant implement in PROD at individual level.
Expected behavior
Be able to use an application account from PowerApps to Snowflake REST API instead of individual account
Environment summary
Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build)
CLI version (paconn --version)
OS version
Shell Type (e.g. bash, cmd.exe, Bash on Windows)
Additional context
Contact me if need any additional details

This would be very useful!

This would be great in order to access Snowflake through Power Apps.

This will be a great fix to ensure secure connectivity and to better utilize the Snowflake REST API feature.

This is needed to ensure appropriate connectivity with non-standard instances of Snowflake.

We are also looking to leverage connecting to Snowflake via their new REST API from the Power Platform utilizing an app account and would use this solution.


Teku does not import slots on startup if EL is offline

Description
Teku does not import any slots if started when EL is stopped. I don't think Teku should just completely stop importing slot data and fall further and further behind just because the EL is currently stopped?
I believe that in the case of Lighthouse they still import slots they just change it to "Optimistic"
The reason this is a problem for my particular setup is that I have tasks that during the upgrade process ensure that the CL and EL are importing slots/blocks after upgrade. In the case of the EL, it will not import new blocks without a CL, so I have to start the CL first. In the case of Teku it hangs/fails because Teku appears "stuck"
Steps to Reproduce (Bug)
Stop EL and Teku
Start Teku
Expected behavior: [What you expect to happen]
Teku should import slots regardless of the EL status
Actual behavior: [What actually happens]
Teku just stops importing slots
16:39:21.295 ERROR - Execution Client request failed. Make sure the Execution Client is online and can respond to requests.
16:39:24.001 INFO  - Syncing     *** Target slot: 3478397, Head slot: 3478320, Remaining slots: 77, Connected peers: 64
16:39:36.001 INFO  - Syncing     *** Target slot: 3478398, Head slot: 3478320, Remaining slots: 78, Connected peers: 65
16:39:48.001 INFO  - Syncing     *** Target slot: 3478399, Head slot: 3478320, Remaining slots: 79, Connected peers: 65
16:39:51.336 ERROR - Execution Client request failed. Make sure the Execution Client is online and can respond to requests.
16:40:00.001 INFO  - Syncing     *** Target slot: 3478400, Head slot: 3478320, Remaining slots: 80, Connected peers: 65
16:40:12.001 INFO  - Syncing     *** Target slot: 3478401, Head slot: 3478320, Remaining slots: 81, Connected peers: 66
16:40:21.381 ERROR - Execution Client request failed. Make sure the Execution Client is online and can respond to requests.
16:40:24.001 INFO  - Syncing     *** Target slot: 3478402, Head slot: 3478320, Remaining slots: 82, Connected peers: 66
16:40:36.001 INFO  - Syncing     *** Target slot: 3478403, Head slot: 3478320, Remaining slots: 83, Connected peers: 65
16:40:39.100 INFO  - Loading deposits up to Eth1 block 4499840
16:40:41.622 INFO  - Execution Client is responding to requests again after a previous failure
16:40:41.644 INFO  - Execution Client syncing complete. Continuing to sync beacon chain blocks
16:40:48.006 INFO  - Syncing     *** Target slot: 3478404, Head slot: 3478369, Remaining slots: 35, Connected peers: 65
16:40:49.931 INFO  - Syncing completed
16:40:55.676 WARN  - Request for eth1 deposit logs from 10000 blocks failed. Retrying with a smaller block range.
16:41:04.007 INFO  - Slot Event  *** Slot: 3478405, Block: a546514e17d0e3a1a4099a36d701d78f93d25961527c58da928841db3fbafab3, Justified: 108699, Finalized: 108698, Peers: 67

As you can see from the above, Head slot is stuck, until I start the EL then it starts importing slots.
Frequency: [How regularly does it occur?]
Always
Versions (Add all that apply)

Software version: 23.10.0
Java version: [openjdk <IP_ADDRESS> 2023-08-24]
OS Name & Version: [Ubuntu 22.04.3 LTS]

Hi @quickchase, thanks for opening the issue.
This is the intended behaviour. Optimistic sync can be activated only if EL is online and actively responding SYNCING to the consensus client forkchoice calls. The reason why this is the case is that, even if the EL is syncing it will do some basic validation to the execution payloads and returning ACCEPTED (instead of VALID) during its syncing process.
So I think you should adapt your deployment assuming this behaviour.


Add Anna to the team page #236

fix #236
depends on https://github.com/src-d/landing/pull/235
I did the following assumptions that should be validated by @marnovo and/or @eiso

added to Operations team,
assigned the "Operations Coordinator" role (that I read somewhere :roll_eyes:)

I thought about "coordinator", but I don't want to seem that I coordinate also Esther's work.

That's how it would look like following @tsolakoua alternative suggestion:


fix: Hydration mismatch

What's the purpose of this pull request?
This PR fixes a hydration mismatch at https://gatsby.vtex.app/office?page=1
How does it work?
By visiting the aforementioned page we receive a hydration mismatch error. To address this problem, we need to lazy render prev/next links.
How to test it?
Open the preview at /office?page=1 and make sure no error is thrown. Also, make sure other urls work fine.
Checklist

[x] CHANGELOG entry added

@tlgimenes just a curiosity, Could the SSR solve this problem instead of moving the pagination to the client?

LGTM!
Out of curiosity: Is there a way to find out the Hydration mismatch instead of looking at the console?

Not that I'm aware of

@tlgimenes just a curiosity, Could the SSR solve this problem instead of moving the pagination to the client?

Yeah, but them we would need to include the pagination info to the path. The way it's coded today requires doing things on the client

The hydration mismatch error count went from 3 to 1. Do you happen to know what's causing the remaining one?

I can't reproduce this last one. For some reason it doesn't happen on my browser.

The hydration mismatch error count went from 3 to 1. Do you happen to know what's causing the remaining one?

I can't reproduce this last one. For some reason it doesn't happen on my browser.

Just re-checked now and it seems something only on my Chrome. I tested on FF and Safari and the errors aren't there.


[WIP] Auto initializeApp when hosted on Firebase

This is a work in progress. It is not quite working yet. This is also probably not the best way to do this so I'm open to any and all constructive feedback.
@mbleigh Please take a look.
Also, sorry I couldn't get the commits to squash.
https://github.com/firebase/polymerfire/issues/221

I think the issue I'm having is with async. I think I just need to implement an await somewhere. Just trying to understand it to find out where to implement it.

So I've been thinking about this a little more, and I actually think there's probably a different solution that would be better. There could be a separate file, firebase-app-auto.html that, when imported, basically just has:
<link rel="import" href="firebase-app-script.html">
<script src="/__/firebase/init.js"></script>

This would perform the same function that the firebase-app element does today, but it would eliminate the need to have a <firebase-app> element at all for folks who use Firebase Hosting. Instead, they could just do:
<link rel="import" href="polymerfire/firebase-app-auto.html">

For this to actually be useful, however, it's going to require lazy loading of Firebase modules to work (as mentioned in the other issue). Because right now you'd have to do something like:
<link rel="import" href="polymerfire/firebase-auth.html">
<link rel="import" href="polymerfire/firebase-database.html">
<link rel="import" href="polymerfire/firebase-app-auto.html">

Specifically importing them in that order would be necessary, because once firebase-app-auto is imported it will initialize the app and subsequent loads won't affect the existing app.

It looked like the lazy loading was almost ready. Do you think these both can be in the next incremental?

Do storage and messaging need to be called before init.js?

There is one other potential issue with calling init.js. The polymer-cli throws an error when building. I reported it here: https://github.com/Polymer/polymer-cli/issues/758

@mbleigh instead of creating another element for auto couldn't we just lazy load with something like this?
https://github.com/justweb1/polymerfire/tree/auto

I'm going to just close this. But I'll leave the issue open.

@justweb1 Thanks for your efforts. Did you find a solution to auto-initialize polymerfire yet?

No. I was waiting for an update on the firebase-js SDK to fix lazy loading. It was merged into the main repo and it is probably in polymerfire now. I haven't gone back and checked. Now, just need to test of the domain exists and auto initiate it in firebase-app component.

@justweb1 thanks for your fast reply! I got it running with manual adjustment to your proposed code! I hope this commit will be merged soon.

@arcodebonte what is the PR # for this?

@arcodebonte What changes did you make to get it to work? I'm putting together a new PR.

I messed your code to let the solution work in my situation. As you can see in the attachment it isn't a neat solution ready for a PR. Hopefully you're able to put together a neat PR.


Online version

Hi!
Thanks for the example!
Since the the now deployments are free you could put the example online:
https://zeit.co/now
Would be faster to test!
😄

Deployed to Now. Updated the demo url on readme.

Thanks 😃


Internal Server Error(500) - TF400856: The following service is not registered in the database: InstalledExtensions.

I am trying tot install an extension, but i am getting the below error. please provide suggestions
tfx extension install --extension-id "cloud-foundry-build-extension" --publisher "ms-vsts" --service-url [URL] --auth-type basic --username [username] --password [password] --accounts [accountname]
TFS Cross Platform Command Line Interface v0.3.38
Copyright Microsoft Corporation
tfx : error: Error: Failed Request: Internal Server Error(500) - TF400856: The following service is not registered in the database: InstalledExtensions.
At line:1 char:1

tfx extension install --extension-id "cloud-foundry-build-extension"  ...

  + CategoryInfo          : NotSpecified: (error: Error: F...lledExtensions.:String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

What version of TFS are you targeting?

TFS2015 - Team_foundation_server_2015_update_3.
i am trying this install in on-premise setup

https://blogs.msdn.microsoft.com/softwaresimian/2014/08/28/tf400856-the-following-service-is-not-registered-in-the-database-filecontent/

Same error using:
TFS 2017 Update 1
TFS Cross Platform Command Line Interface v0.4.11
Any updates?

I'm suddenly getting this too.  TFS 2017 Update 3.  This was working before, and I don't know what changed.

I figured out my problem, it's because I was passing the server url for ServiceUrl instead of the collection url.
Usually the ServiceUrl is of the form http://server:8080/tfs, but in the case of tfx extension install it must be in the form http://server:8080/tfs/COLLECTION.  This is not at all clear in the help files.


ModHeader makes Selenium detected by Cloudflare

I run my code without mod Header and it passed Cloudflare https://nowsecure.nl, but when I add modHeader extension to Chrome (with/without changing header), it makes Cloudeflare detect Selenium immediately.
I've tested many times and many case, and I guess because of Mod Header changes navigator.plugins so it make Cloudflare detects Selenium
Before adding ModHeader to Chrome
https://i.imgur.com/ZdVgMNH.png
After adding ModHeader to Chrome
https://i.imgur.com/vJoZFFJ.png

@anhhung4u - there are 3 blackboxes here - CloudFlare, Selenium, and Chrome. I am not sure what you are trying to do, or how to help you with this, but here is what I would suggest:
1, Try using Selenium with Firefox. See if this issue is specific to the Chrome browser.
2, Try to install other extensions in Chrome selenium. See if other extensions also cause CloudFlare to detect it
3, Rebuild ModHeader selenium (https://github.com/modheader/modheader_selenium/tree/main/modheader) by stripping out everything, then slowly add things back until it gets detected by CloudFlare. Then you will know which line/configuration causes CloudFlare to detect it.

@anhhung4u - there are 3 blackboxes here - CloudFlare, Selenium, and Chrome. I am not sure what you are trying to do, or how to help you with this, but here is what I would suggest: 1, Try using Selenium with Firefox. See if this issue is specific to the Chrome browser. 2, Try to install other extensions in Chrome selenium. See if other extensions also cause CloudFlare to detect it 3, Rebuild ModHeader selenium (https://github.com/modheader/modheader_selenium/tree/main/modheader) by stripping out everything, then slowly add things back until it gets detected by CloudFlare. Then you will know which line/configuration causes CloudFlare to detect it.

Thank you for fast response,
I've tested case 2: try to install other extensions in Chrome Selenium, everything is good, not detected by Cloudflare, so I think it's caused by Mod Header.
I will try to test case 1 and case 3 then update in this post later

Closing since there is no activities.


changed transform to transform_column in docstring to match func name

Old docstring name for transform_column remained after function name was apparently changed.
@ericmjl

LGTM, thanks @zbarry!


vgo2nix fails on darwin: cannot connect to daemon at '/nix/var/nix/daemon-socket/socket'

$ mkdir vgo2nix.test && cd vgo2nix.test && go mod init github.com/$USER/vgo2nix.test && go get github.com/nix-community/vgo2nix && $(go env GOPATH)/bin/vgo2nix
go: creating new go.mod: module github.com/$USER/vgo2nix.test
go: github.com/nix-community/vgo2nix upgrade => v0.0.0-20201107053101-4546d8056ab0
goPackagePath github.com/alecthomas/assert has rev: 405dbfeb8e38, module:
goPackagePath github.com/alecthomas/colour has rev: 60882d9e2721, module:
goPackagePath github.com/alecthomas/kingpin has rev: v2.2.6, module:
goPackagePath github.com/alecthomas/repr has rev: 117648cd9897, module:
goPackagePath github.com/alecthomas/template has rev: a0175ee3bccc, module:
goPackagePath github.com/alecthomas/units has rev: 2efee857e7cf, module:
goPackagePath github.com/davecgh/go-spew has rev: v1.1.1, module:
goPackagePath github.com/mattn/go-isatty has rev: v0.0.3, module:
goPackagePath github.com/nix-community/vgo2nix has rev: 4546d8056ab0, module:
goPackagePath github.com/orivej/e has rev: ac3492690fda, module:
goPackagePath github.com/orivej/go-nix has rev: dae45d921a44, module:
goPackagePath github.com/pkg/profile has rev: v1.2.1, module:
goPackagePath github.com/pmezard/go-difflib has rev: v1.0.0, module:
goPackagePath github.com/sergi/go-diff has rev: v1.0.0, module:
goPackagePath github.com/stretchr/testify has rev: v1.2.2, module:
goPackagePath github.com/yuin/goldmark has rev: v1.2.1, module:
goPackagePath golang.org/x/crypto has rev: 75b288015ac9, module:
goPackagePath golang.org/x/mod has rev: v0.3.0, module:
goPackagePath golang.org/x/net has rev: c89045814202, module:
goPackagePath golang.org/x/sync has rev: 6e8e738ad208, module:
goPackagePath golang.org/x/sys has rev: 85ca7c5b95cd, module:
goPackagePath golang.org/x/text has rev: v0.3.0, module:
goPackagePath golang.org/x/tools has rev: 39188db58858, module:
goPackagePath golang.org/x/xerrors has rev: 5ec99f83aff1, module:
Fetching github.com/pkg/profile https://github.com/pkg/profile
Fetching github.com/pmezard/go-difflib https://github.com/pmezard/go-difflib
Fetching github.com/alecthomas/units https://github.com/alecthomas/units
Fetching github.com/sergi/go-diff https://github.com/sergi/go-diff
Fetching github.com/alecthomas/colour https://github.com/alecthomas/colour
Fetching github.com/alecthomas/kingpin https://github.com/alecthomas/kingpin
Fetching github.com/mattn/go-isatty https://github.com/mattn/go-isatty
Fetching golang.org/x/crypto https://go.googlesource.com/crypto
Fetching github.com/alecthomas/repr https://github.com/alecthomas/repr
Fetching github.com/stretchr/testify https://github.com/stretchr/testify
Fetching golang.org/x/net https://go.googlesource.com/net
Fetching github.com/yuin/goldmark https://github.com/yuin/goldmark
Fetching golang.org/x/mod https://go.googlesource.com/mod
Fetching github.com/davecgh/go-spew https://github.com/davecgh/go-spew
Fetching github.com/alecthomas/template https://github.com/alecthomas/template
Fetching github.com/orivej/e https://github.com/orivej/e
Fetching github.com/nix-community/vgo2nix https://github.com/nix-community/vgo2nix
Fetching golang.org/x/sync https://go.googlesource.com/sync
Fetching github.com/orivej/go-nix https://github.com/orivej/go-nix
Fetching github.com/alecthomas/assert https://github.com/alecthomas/assert
Fetching golang.org/x/sys https://go.googlesource.com/sys
panic: Error processing import path "github.com/pkg/profile": nix-prefetch-git --fetch-submodules --no-deepClone --url https://github.com/pkg/profile --rev v1.2.1 failed:
Initialized empty Git repository in /private/var/folders/hw/c8yk4yy52jl7hj646r_dt44m0000gn/T/git-checkout-tmp-r1qCi9Km/profile/.git/
From https://github.com/pkg/profile
 * tag               v1.2.1     -> FETCH_HEAD
Switched to a new branch 'fetchgit'
removing `.git'...
error: cannot connect to daemon at '/nix/var/nix/daemon-socket/socket': Connection refused

goroutine 1 [running]:
main.main()
	/Users/$USER/go/pkg/mod/github.com/nix-community/vgo2nix@v0.0.0-20201107053101-4546d8056ab0/main.go:291 +0x712

I was able to work around this running the same command on Linux.

Make sure nix-build works on your machine. This is likely unrelated to vgo2nix.


[PICO-PI-IMX7]  Splash screen not showing on LCD when u-boot start

Description
This issue is derived from https://github.com/TechNexion/u-boot-tn-imx/issues/4
Power on PICO-PI-IMX7,  Splash screen not showing on LCD when u-boot start.
Steps to reproduce the issue:
$ repo init -u https://github.com/TechNexion/tn-imx-yocto-manifest.git -b zeus_5.4.y-next -m imx-5.4.70-2.3.0.xml
$ DISTRO=fsl-imx-x11 MACHINE=pico-imx7 BASEBOARD=pi source tn-setup-release.sh -b build-x11-pico-imx7
$ bitbake core-image-base

And flash it on the board and power on.

Describe the results you received:
Splash screen showing on LCD with TechNexion's logo image when u-boot start.
**Additional information you deem important
Additional details

Target : PICO-PI-IMX7
LCD : TDP0500T800480PCAP

Attach the video with power on to boot up finish
https://user-images.githubusercontent.com/29390119/133881879-6f17d7aa-73da-4c7e-851e-01c935d810b2.mp4

Hi Pino,
Our lastest u-boot can support splash screen with pico-imx7d.
Here is the commit hash:
d1db4ce46f2088bfe72b84d5337cb18f339f2905
pico-imx7d: add splash screen support
06baed80d210b61ca710072af672dc22bc007ae4
pico-imx7d: add u-boot logo support
7f584b866290da1f4d677f0c57e0f0d209f15fbe
driver: commom: remove the static attribute of show_default_logo api
You can try repo sync to your yocto project.
Please copy the boot log if the issue remains.
THANKS~~~~
Joe

@yoooh8668
Thanks for the comment.
Check your git hash id and start the rebuild.
I hope you have a great weekend ^^


Severe display issues on iOS 12

I'm pretty sure you have noticed by now, but when using cards (at least CardArticle) on iOS 12, several things go horribly wrong, beginning with text that's displayed darker than it should be to severe bounds and animation issues.
I really don't know where to start honestly, so I took a short screen capture to show what exactly I mean (https://youtu.be/SHeDv5e89C8)
I hope you can resolve the issue soon, looking forward to a response :)

Hey Medwe!
I have problems playing your video on YouTube so I couldn't compare with my own problems. I took the liberty to create my own video to add support to probably the same problems!
https://youtu.be/1sPYonohBxU

Same bug

same

@PaoloCuscela

@PaoloCuscela @Medwe @Varmoes @Michele404 @federico2390 @jgregmccormick
Hey Guys ,
I am facing same issue on iOS 12.0 on production. Kindly let me know if anybody has resolved this issue.

The problem is that originalFrame value changes (Don't not why yet)
Just because I had several headaches and i needed to find a solution. Here is a rudimentary and temporal fix.
Using a singleton you can persist the value of originalFrame
For example: using AppDelegate (Not recommended but same result)
Declare on AppDelegate.swift:
var originalFrameValue: CGRect?
Modify Animator.swift (from Cards classes):
1.- Create an instance of our singleton:
func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
        ...
        container.addSubview(from.view)
        let appDelegate     = UIApplication.shared.delegate as! AppDelegate // Instance of Singleton
        ...

2.- Set value on presenting (Just After guard presenting else { ... }):
        ...
        // Detail View Controller Present Animations
        card.isPresenting  = true
        appDelegate.originalFrameValue =  card.originalFrame  // Set value on Singleton
        ...

2.- Use that value for animation (Inside guard presenting else { ... } ):
      ...
      guard presenting else {
           ...
           // Layout with bounce effect
            let originalFrame   = appDelegate.originalFrameValue // Return and set value from Singleton
            UIView.animate(withDuration: velocity/2, delay: 0, options: .curveEaseOut, animations: {

                detailVC.layout(originalFrame!, isPresenting: false, transform: bounce)  // Use originalFrame
                self.card.delegate?.cardIsHidingDetail?(card: self.card)

            }) { _ in UIView.animate(withDuration: self.velocity/2, delay: 0, options: .curveEaseOut, animations: {

                detailVC.layout(originalFrame!, isPresenting: false)  // Use originalFrame
                self.card.delegate?.cardIsHidingDetail?(card: self.card)
                })
            }
            return
       }
        ...

Hope it helps !!! Works on ios12

Its not fixing the open issue, only the close issue @EDMODJ

Hi @ Michele404, I have no problems opening. Maybe you are using full screen mode, it does not work as it is originally but it is not as bad as the closing problem.
without full screen mode works fine

and how can I fix the full screen?

Hi @Michele404 , it seems the problem is on the first animation when the card is opening.
The animation just ignores (don't know why) the width and height transformation
I fixed it commenting the lines of first animation and leave the second one does the job
On Animator.swift
        ...
        // Layout with bounce effect
        UIView.animate(withDuration: velocity/2, delay: 0, options: .curveEaseOut, animations: {
            //Comment this two lines
            //detailVC.layout(detailVC.view.frame, isPresenting: true, transform: bounce)
            //self.card.delegate?.cardIsShowingDetail?(card: self.card)

        }) { _ in UIView.animate(withDuration: self.velocity/2, delay: 0, options: .curveEaseOut, animations:
        {
        ...

I am not talking about this, I am talking about this bug: https://streamable.com/u8pga

@EDMODJ but when dismiss the problem is the same. how we can I solve the problem ? do you know a method ?

hi @federico2390, for Dismiss here a basic solution:

The problem is that originalFrame value changes (Don't know why yet)
Just because I had several headaches and i needed to find a solution. Here is a rudimentary and temporal fix.
Using a singleton you can persist the value of originalFrame
For example: using AppDelegate (Not recommended but same result)
Declare on AppDelegate.swift:
var originalFrameValue: CGRect?
Modify Animator.swift (from Cards classes):
1.- Create an instance of our singleton:
func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
        ...
        container.addSubview(from.view)
        let appDelegate     = UIApplication.shared.delegate as! AppDelegate // Instance of Singleton
        ...

2.- Set value on presenting (Just After guard presenting else { ... }):
        ...
        // Detail View Controller Present Animations
        card.isPresenting  = true
        appDelegate.originalFrameValue =  card.originalFrame  // Set value on Singleton
        ...

2.- Use that value for animation (Inside guard presenting else { ... } ):
      ...
      guard presenting else {
           ...
           // Layout with bounce effect
            let originalFrame   = appDelegate.originalFrameValue // Return and set value from Singleton
            UIView.animate(withDuration: velocity/2, delay: 0, options: .curveEaseOut, animations: {

                detailVC.layout(originalFrame!, isPresenting: false, transform: bounce)  // Use originalFrame
                self.card.delegate?.cardIsHidingDetail?(card: self.card)

            }) { _ in UIView.animate(withDuration: self.velocity/2, delay: 0, options: .curveEaseOut, animations: {

                detailVC.layout(originalFrame!, isPresenting: false)  // Use originalFrame
                self.card.delegate?.cardIsHidingDetail?(card: self.card)
                })
            }
            return
       }
        ...

Hope it helps !!! Works on ios12

@EDMODJ  I followed your code step by step but still its not working for me. Here is,

created singleton instance in appdelegate
stored value of originalFrame as well
used in Inside guard presenting else { ... }
Help me.

@MayankAgarwal04 could you post your animateTransition function code?

@MayankAgarwal04 could you post your animateTransition function code?

I'm curious

@EDMODJ do you know why the image when you open the card is rounded on iOS12?

Try now with the changes of @robin850.
( Install manually not from cocoapods )

@PaoloCuscela I don't see how @robin850's changes have anything to do with the issue.As far as I see, all that was done is renaming method calls to deprecated versions. (bringSubview(toFront: detailVC.view) -> bringSubviewToFront(detailVC.view)
I'm pretty confused as to how any of this makes sense?

Yep. You're right.

i have ever this problem guys please how can I fix it @PaoloCuscela @EDMODJ

Same @federico2390

So, problem is not solved, it's just been closed 😹

The other two Issues have been closed, not because the issue was solved but because there already is this Issue. Having all three of them open would be redundant and confusing.

The key appears to be the card.originalFrame is changed due to the override open func draw(_ rect: CGRect) {), I just logged the value of the originalFrame:
(lldb) po originalFrame
▿ (20.0, 136.0, 335.0, 150.0)
  ▿ origin : (20.0, 136.0)
    - x : 20.0
    - y : 136.0
  ▿ size : (335.0, 150.0)
    - width : 335.0
    - height : 150.0

(lldb) po self.card.originalFrame
▿ (0.0, 0.0, 335.0, 150.0)
  ▿ origin : (0.0, 0.0)
    - x : 0.0
    - y : 0.0
  ▿ size : (335.0, 150.0)
    - width : 335.0
    - height : 150.0

The self.card.originalFrame's origin is reseted to (0,0), which might cause the card view bounce up to the top-left of the view, and spread later.

how we can resolve that?

Here's a very "hack" way

Modify the Cards.swift in line 166:

override open func draw(_ rect: CGRect) {
        super.draw(rect)

        if originalFrame == CGRect.zero {
            originalFrame = rect
        }

...
}

This would fix the bug when you try to dismiss the card.

Modify Animator.swift line 101 :

UIView.animate(withDuration: velocity/2, delay: 0, options: .curveEaseOut, animations: {

//            detailVC.layout(detailVC.view.frame, isPresenting: true, transform: bounce)
//            self.card.delegate?.cardIsShowingDetail?(card: self.card)

...
}

Comment these lines will fix the bug when you present the card. However, as you can see, the bounce animation will be disabled.
This is just a nasty workaround so I won't make it as a pull request, there should be a better solution.

Hey Guyyyysssss I have found a solution fully work:
In Cards.swift in line 165:
Delete:
originalFrame = rect
Copy and paste this:
if originalFrame == CGRect.zero {
originalFrame = rect
}
Thank u @akring
And in the Animator.swift comment this line: 66, 67, 94 and 95.
Stay tuned! 🎉
so... this for me work perfectly.

None of the above solutions worked for me.
I've solved it myself by commenting one line in Card.swift
override open func draw(_ rect: CGRect) {
super.draw(rect)
LINE TO COMMENT
//originalFrame = rect

Just a quick heads up if you are fixing this issue and you are editing a file installed by cocoapod, make sure you clean your build and then re build to make sure the changes apply!

Anyone got a definite fix?

Would be great if we have a oficial fix with a PR, @PaoloCuscela can you help us with this?

Maybe his have other works ☺
Il giorno 26 nov 2018, alle ore 23:45, Erick Gonzales <notifications<EMAIL_ADDRESS>ha scritto:
Would be great if we have a oficial fix with a PR, @PaoloCuscelahttps://github.com/PaoloCuscela can you help us with this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/PaoloCuscela/Cards/issues/80#issuecomment-441829590, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ao_xuSDzraH48JgjElInzMq9W-mbRQyCks5uzG77gaJpZM4W1Rvh.

Hi guys,
I'm sorry for the delay, I' ve been quite busy these days...
Apparently (idk if it's an iOS12 glitch or some code flaws) the first animation block of the chain in the Animator.swift was executed as a normal code block ignoring the duration property...
So the 2nd animation was executed in the wrong time and everything screwed up.
I've solved in a very hacky way:
I' ve set up a first 'fake' animation and executed inside some code that should be executed synchronously...
// This code should actually be executed outside the animation but idk why this first animation is executed and skipped ( even with 'duration' setted up )
        UIView.animate(withDuration: 0, delay: 0, options: .curveEaseIn, animations: {
            // Setting detail VC in dismissed mode (VC frame = card frame)
            detailVC.layout(self.card.originalFrame, isPresenting: false)

        }, completion: { finished in UIView.animate(withDuration: self.velocity/2, delay: 0, options: .curveEaseIn, animations: {
                detailVC.blurView.alpha = 1
                detailVC.snap.alpha = 1
                detailVC.layout(detailVC.view.frame, isPresenting: true, transform: bounceOffset)

            }, completion: { (_) in UIView.animate(withDuration: self.velocity/2, delay: 0, options: .curveEaseIn, animations: {
                    detailVC.layout(detailVC.view.frame, isPresenting: true)

                }, completion: { (_) in
                    detailVC.layout(detailVC.view.frame, isPresenting: true)
                    transitionContext.completeTransition(true)

                })
            })
        })

If you guys know why is that happening could you let me know ?
Anyway, I didn't had enough time to test it properly,  could you please test it out and let me know about any bugs ?
Thanks!   ❤

Thx
Il giorno 2 dic 2018, alle ore 17:47, Paolo Cuscela <notifications<EMAIL_ADDRESS>ha scritto:
Hi guys,
I'm sorry for the delay, I' ve been quite busy these days...
Apparently (idk if it's an iOS12 glitch or some code flaws) the first animation block of the chain in the Animator.swift was executed as a normal code block ignoring the duration property...
So the 2nd animation was executed in the wrong time and everything screwed up.
I've solved in a very hacky way:
I' ve set up a first 'fake' animation and executed inside some code that should be executed synchronously...
// This code should actually be executed outside the animation but idk why this first animation is executed and skipped ( even with 'duration' setted up )
UIView.animate(withDuration: 0, delay: 0, options: .curveEaseIn, animations: {
// Setting detail VC in dismissed mode (VC frame = card frame)
detailVC.layout(self.card.originalFrame, isPresenting: false)
    }, completion: { finished in UIView.animate(withDuration: self.velocity/2, delay: 0, options: .curveEaseIn, animations: {
            detailVC.blurView.alpha = 1
            detailVC.snap.alpha = 1
            detailVC.layout(detailVC.view.frame, isPresenting: true, transform: bounceOffset)

        }, completion: { (_) in UIView.animate(withDuration: self.velocity/2, delay: 0, options: .curveEaseIn, animations: {
                detailVC.layout(detailVC.view.frame, isPresenting: true)

            }, completion: { (_) in
                detailVC.layout(detailVC.view.frame, isPresenting: true)
                transitionContext.completeTransition(true)

            })
        })
    })

If you guys know why is that happening could you let me know ?
Anyway, I didn't had enough time to test it properly, could you please test it out and let me know about any bugs ?
Thanks! ❤
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/PaoloCuscela/Cards/issues/80#issuecomment-443521923, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ao_xuWgCD4rGcar4t6Bs04SbSRHEZ83Eks5u1AQMgaJpZM4W1Rvh.

Thanks a lot, @PaoloCuscela ! Working flawlessly again!


[Feat]- Student Tech Resources and Footer Fix

This PR implements the "Resources" feature for students, which I believe includes high-quality, free resources that will help students get started in tech.
Fixes #308
This PR includes:

Added resources for various tech domains.
Each resource includes the language and its corresponding link.
Mentioned the instructor's name for each resource.
Cleaned up the UI, added a hover effect for better UX on the resource links.
Included only top-rated resources to ensure quality.

Additional Fix:
In a previous PR, I worked on the footer section. However, while resolving merge conflicts, some code was accidentally deleted. This PR also restores and corrects the footer code.
screenshot

@SaurabhS55 @pulkitpathak99 @Rizwan102003  Please check out this PR.


Add comparison plugins for bool / Guid objects

This would be useful for completion

This has been added and released to nuget


[Web Security] HPKP, Fx 72 tasks

Trello
https://trello.com/c/PoSdJAUO/78-web-crypto-api-fx-72
Acceptance criteria

[ ] consider removal of HTTP Public Key Pinning (HPKP)

As far as I can tell the only update needed here is for Firefox compat, and @bershanskiy already updated that, and it's showing up on the pages: https://developer.mozilla.org/en-US/docs/Web/HTTP/Public_Key_Pinning#Browser_compatibility.
So thanks to @bershanskiy , I think this can be closed :).


Openldap stack ha v4.1.1

PR Description
Adds a new OpenLDAP chart based on bitnami's OpenLDAP docker image.
It's based on https://github.com/jp-gouin/helm-openldap/tree/v4.1.1, with some additions:

Allow adding a CA Certificate to use along side to the Custom TLS  certificate

This is useful when certmanager is in use, since it doesn't adds the CA Cert as part of the secret holding the managed cert and key;

To workaround an issue with helm downloading dependencies, we have included the bitnami's common helm as part of this helm.

Checklist

[ ] Have you reviewed and updated the chart default values if necessary?
[ ] Have you reviewed and updated the chart documentation if necessary?
[ ] Does your branch follow the naming convention of {chartNameWithDashes}-v{versionString}-{optionalPatchVersion}?
[ ] Have you bumped the version in the chart's Chart.yaml?

Tagged Releases
Please remember to make a tagged release after merging your PR that:

Has a tag name that matches your PR branch name (see above)
Has a description that summarizes the changes made

This makes it possible to use previous versions of the charts maintained here as new releases are published. Please see the release history of this repository for examples.

Here goes the diff:
diff --color -NurbBw -x charts -x .git -x .github ./Chart.lock /Users/fffialho/src/power/helm-charts/charts/openldap-stack-ha/Chart.lock
--- ./Chart.lock	2023-06-22 16:16:04
+++ /Users/fffialho/src/power/helm-charts/charts/openldap-stack-ha/Chart.lock	2023-06-19 19:47:08
@@ -1,12 +1,12 @@
 dependencies:
 - name: ltb-passwd
-  repository: ""
-  version: 0.1.x
+  repository: file://charts/ltb-passwd
+  version: 0.1.0
 - name: phpldapadmin
-  repository: ""
-  version: 0.1.x
+  repository: file://charts/phpldapadmin
+  version: 0.1.2
 - name: common
-  repository: https://charts.bitnami.com/bitnami
-  version: 1.10.0
-digest: sha256:ffce1e1b35fc49ce33dbf5c063be307964ca75ba6f13d325d32b474ba34c7ea3
-generated: "2021-10-24T14:53:55.640745+02:00"
+  repository: file://charts/common
+  version: 1.10.4
+digest: sha256:cae79bcb5a3899fdbadc55f000ed685a471460af28f65161ad2971bb5e047780
+generated: "2023-06-19T19:47:08.701015-03:00"
diff --color -NurbBw -x charts -x .git -x .github ./Chart.yaml /Users/fffialho/src/power/helm-charts/charts/openldap-stack-ha/Chart.yaml
--- ./Chart.yaml	2023-06-22 16:16:04
+++ /Users/fffialho/src/power/helm-charts/charts/openldap-stack-ha/Chart.yaml	2023-06-19 19:45:17
@@ -2,16 +2,16 @@
 name: openldap-stack-ha
 dependencies:
   - name: ltb-passwd
+    repository: "file://charts/ltb-passwd"
     version: 0.1.x
     condition: ltb-passwd.enabled
   - name: phpldapadmin
+    repository: "file://charts/phpldapadmin"
     version: 0.1.x
     condition: phpldapadmin.enabled
   - name: common
-    repository: https://charts.bitnami.com/bitnami
-    tags:
-      - bitnami-common
-    version: 1.x.x
+    repository: "file://charts/common"
+    version: 1.10.x
 home: https://www.openldap.org
 version: 4.1.1
 appVersion: 2.6.3
diff --color -NurbBw -x charts -x .git -x .github ./templates/secret-customTLS-ca.yaml /Users/fffialho/src/power/helm-charts/charts/openldap-stack-ha/templates/secret-customTLS-ca.yaml
--- ./templates/secret-customTLS-ca.yaml	1969-12-31 21:00:00
+++ /Users/fffialho/src/power/helm-charts/charts/openldap-stack-ha/templates/secret-customTLS-ca.yaml	2023-05-26 08:48:23
@@ -0,0 +1,18 @@
+{{ if and .Values.customTLS.enabled .Values.customTLS.caPEMContent  }}
+apiVersion: v1
+kind: Secret
+metadata:
+  name: {{ template "openldap.fullname" . }}-customtls-ca
+  labels:
+    app: {{ template "openldap.name" . }}
+    chart: {{ template "openldap.chart" . }}
+    release: {{ .Release.Name }}
+    heritage: {{ .Release.Service }}
+{{- if .Values.extraLabels }}
+{{ toYaml .Values.extraLabels | indent 4 }}
+{{- end }}
+type: Opaque
+data:
+  ca.crt: |-
+{{ .Values.customTLS.caPEMContent | b64enc | indent 4 }}
+{{ end }}
diff --color -NurbBw -x charts -x .git -x .github ./templates/statefulset.yaml /Users/fffialho/src/power/helm-charts/charts/openldap-stack-ha/templates/statefulset.yaml
--- ./templates/statefulset.yaml	2023-06-22 16:16:04
+++ /Users/fffialho/src/power/helm-charts/charts/openldap-stack-ha/templates/statefulset.yaml	2023-05-26 08:45:15
@@ -53,12 +53,22 @@
               cp /tmp-certs/tls.crt /tmp-certs/ca.crt
               chmod 777  /tmp-certs/*
               {{- end }}
-              cp -Lr /tmp-certs/* /certs
+              cp -vLr /tmp-certs/* /certs
+              {{- if .Values.customTLS.caPEMContent }}
+              cp -vLr /tmp-certs-ca/* /certs
+              {{- end }}
+          {{- if .Values.customTLS.resources }}
+          resources: {{- toYaml .Values.customTLS.resources | nindent 12 }}
+          {{- end }}
           volumeMounts:
             - name: certs
               mountPath: "/certs"
             - name: secret-certs
               mountPath: "/tmp-certs"
+            {{- if .Values.customTLS.caPEMContent }}
+            - name: secret-certs-ca
+              mountPath: "/tmp-certs-ca"
+            {{- end }}
       {{- if .Values.volumePermissions.enabled }}
         - name: volume-permissions
           image: {{ include "openldap.initContainerImage" . }}
@@ -275,6 +285,11 @@
         - name: secret-certs
           secret:
             secretName: {{ .Values.customTLS.secret }}
+{{- if .Values.customTLS.caPEMContent }}
+        - name: secret-certs-ca
+          secret:
+            secretName: {{ template "openldap.fullname" . }}-customtls-ca
+{{- end }}
 {{- else }}
         - name: secret-certs
           emptyDir:
diff --color -NurbBw -x charts -x .git -x .github ./values.yaml /Users/fffialho/src/power/helm-charts/charts/openldap-stack-ha/values.yaml
--- ./values.yaml	2023-06-22 16:16:04
+++ /Users/fffialho/src/power/helm-charts/charts/openldap-stack-ha/values.yaml	2023-05-26 09:12:39
@@ -69,6 +69,12 @@
     repository: alpine/openssl
     tag: latest
   secret: ""  # The name of a kubernetes.io/tls type secret to use for TLS
+  # Sometimes it can be useful to inject a custom CA file. When using certmanager is one situation.
+  caPEMContent: ""
+    # |-
+    # -----BEGIN CERTIFICATE-----
+    # PEM data
+    # -----END CERTIFICATE-----
 ## Add additional labels to all resources
 extraLabels: {}

If this is a fork, why don't we put this in a repo of it's own which is actually a fork of the upstream?

https://github.com/powerhome/helm-openldap

If this is a fork, why don't we put this in a repo of its own which is actually a fork of the upstream?

Fair enough. Closing this PR and working on applying the changes in the forked repo.

Fair enough. Closing this PR and working on applying the changes in the forked repo:  https://github.com/powerhome/helm-openldap


Add 23- Find the Town Judge(Abdullah Momen).cpp

Name your file with the same pattern and spaces to be accepted, if the checkers are failed, so the PR will not accept @AbdullaNassar


Subnets still created when configuration scope set to enabled = false

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform: 1.1.2
azure provider: 3.0.2
module: 2.3.1
Description
Describe the bug
During a recent customer deployment there was some confusion created when the VNG and AF config was set to enabled = false, but the module still attempted to deploy these subnets, i.e. The CIDR ranges that were left within the VNG and AF address prefix still showed up within a terraform plan. Only when the address prefix was removed did the module stop trying to create these subnets.
Steps to Reproduce
Within the advanced configuration of a Virtual network using the settings.connectivity.tf (as per guide here), the hub network is configured with the required address space.
Example hub network config

If virtual network gateway or azure firewall config is set to enabled = false, but has address prefix configured, the module will try to create this subnet within the hub virtual network.

If the address prefix is a valid address range within the virtual network address space the subnet will be created, even though enabled = false. This has been confirmed for both the VNG and AF subnets.

If the Address prefix is NOT a valid address range within the virtual network address space, then it will show on the terraform plan, but will error upon terraform apply (as expected as this is not a valid prefix).

Screenshots
Screenshots added above.
Additional context

This may not be a bug, and is potentially expected behaviour, but this issue caused issues during a customer deployment using the advanced deployment guidance.
This has only been tested within the first hub network, but assumption is that the second hub network will use the same logic.

Thank you for logging this @ATuckwell... as discussed online, this should be a relatively simple fix and the outcome you describe was the original intent of the logic.
I also don't feel this should have a negative impact on existing customers once implemented so we should be able to add this under a minor release.
Will speak to the team to get this appropriately prioritised on our backlog.

@JamJarchitect , FYI as per proposal of updating logic within module.

Trigger ADO Sync


Can't delete custom breakpoint

Can't delete custom breakpoint
Can't delete empty breakpoint fields
Can't proceed next step with empty breakpoint fields

osx64.zip v1.1

We need a help,  could you open pull request?


Searching by tag always says '0 maps found'

On dashboard, when I search for a specific tag that I know exists, won't show the map with that tag:

Search by tag currently requires a colon before. If you type :lol instead it will show up. @xavijam , bug or feature?

An image should explain it :)


cowboy_http_req:peer_addr/1 refactored

I've refactored cowboy_http_req:peer_addr/1 and reorganized code.

Thanks! I'll check it out in the train later today.

This is in, I'll push in a few minutes. Thanks!


Question: How to use dynamic query params?

I have a question regarding  query params
Currently working with a feature that requires dynamic query params, something like:
navigate(`/dashboard/transaction/:transactionId${queryParams}`);

This understandably goes against generouted typesafe routing, but is there a work around for this? am i missing something?

@arifluthfi16 If you're using the React Router integration, you could use the object syntax for the path:
navigate({ pathname: '/users/:id', search: '...', hash: '...' }, { params: { id: 'xyz' } })

Hope that helps!

Helps tremendously, thanks!


Adding Channel acquire time metric for netty HTTP client.

Fixes #XXXX.

Description

We need the "channel acquire time" metric to help diagnose high latency incidents in Druid.
Recently, we experienced high latency issues and struggled to pinpoint the exact bottleneck.
After analyzing the query lifecycle within Druid, we identified that one potential contributor to latency is the time taken by the NettyHTTP client at the broker to acquire a channel.
During this process, threads can be blocked while waiting for a connection to become available.
By exposing a metric for channel acquire time, we can gain better visibility into this part of the query lifecycle and more effectively identify and address latency bottlenecks.
Additionally, we observed at the router that we get log lines indicating it hits the limit of 1024 at the Jetty HTTP client queue. We suspect the same can happen at the broker, so we want to add this metric for the broker.

Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...

Release note

Key changed/added classes in this PR

MyFoo
OurBar
TheirBaz

This PR has:

[ ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

@Pankaj260100  , can you please update the PR description to explain the problem you are facing and what you have tried so far? I am not sure what you trying to capture with the metric here and in what cases it would be useful.
In general, for bugs and perf issues, it is advisable to first create a GitHub issue to start a discussion and understand the underlying problem.
Once there is some consensus, you can proceed with a solution, even if it amounts to simply adding a new metric.
Having an issue also helps future devs/users/contributors to easily find if a certain problem is known and has workarounds/resolutions.

@kfaraz, I have updated the description.

Thanks, @Pankaj260100 !
With this metric added, were you able to identify the bottleneck?
What do you expect the value of this metric to be under normal and abnormal operation?

@kfaraz I plan to test this once the first round of review is done.

@Pankaj260100 , could you maybe still create a GitHub issue with all the logs and symptoms that you have encountered? It might give us a better understanding of the problem and perhaps someone else in the community has already seen a similar problem.
I ask for this since it is not yet clear whether this metric will be useful in debugging the problem.
As for trying out the patch on your system, you may proceed with it even before a review is done. In fact, sharing your results would only help with the review.

@kfaraz/ @LakshSingla  created an issue for this: https://github.com/apache/druid/issues/17138

@LakshSingla

Can you please pinpoint the exact call where this is happening?
https://github.com/apache/druid/blob/3d45f9829c7b80e3b5289aaf5710b3932639349e/processing/src/main/java/org/apache/druid/java/util/http/client/pool/ResourcePool.java#L246

By adding a log line whenever threads block waiting for the channel, I observed that the number of waiting threads increases during periods of high latency.
After adding this metric to track the channel wait time, I found it typically stays within 2-3ms. However, during high latency periods, this wait time increases to as much as 9 seconds.
The number of open connections at the data nodes remains stable, likely due to the default 4-minute unusedConnectionTimeout.
One possible solution is increasing druid.broker.http.numConnections.
Alternatively, there might be an issue at the data nodes delaying query processing and causing requests to wait for connections at the broker.
cc: @kfaraz @LakshSingla @abhishekagarwal87


How to run this program

I am very interested in your paper at KDD2018, but I don't know how to run this program :(
Is it implemented in C++ or R?

Please see the README file for instructions. Thanks


[Task]  manager/controller/I18nControllerTest.java

Description
Help us impl unit test For manager/controller/I18nControllerTest.java.
You can learn and refer to the previous test cases impl.

controller example unit case:  https://github.com/dromara/hertzbeat/blob/master/manager/src/test/java/com/usthe/manager/controller/AccountControllerTest.java
service example unit case:  https://github.com/dromara/hertzbeat/blob/master/manager/src/test/java/com/usthe/manager/service/TagServiceTest.java
jpa sql dao example unit case: https://github.com/dromara/hertzbeat/blob/master/manager/src/test/java/com/usthe/manager/dao/MonitorDaoTest.java

Task List

[ ] Impl Unit Test For manager/controller/I18nControllerTest.java.

Let me have a try

👍 has published at version v1.2.1


The pie chart does not display proper categorization

Issue Description:
I encountered a problem with the generation of pie charts in the reporting functionality. Specifically, when attempting to represent the number and percentage of male and female loan recipients, the pie chart does not display proper categorization.
Steps to Reproduce:
Navigate to the reporting section.
Ask：Represent the number and percentage of male and female loan recipients with a pie chart
Generate a pie chart.
Expected Behavior:
The pie chart should accurately represent the number and percentage of male and female loan recipients, providing a clear and distinct categorization.
Actual Behavior:
The generated pie chart lacks proper classification, making it challenging to discern the distribution of male and female loan recipients.

Reason for Closure: [Data field value is Chinese]
Solution Implemented: [Correct after modifying comment
Gender of respondents, including 'male' and 'female']

If you have any further questions or concerns, please feel free to reopen the issue or open a new one. Your feedback is valuable to us, and we encourage continued collaboration.
Thank you,
[leonliuzx]
[DeepBI]


fix: paying expense and canceling payment don't scroll down to comments

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/53077
PROPOSAL: https://github.com/Expensify/App/issues/53077#issuecomment-2498505395
Tests

Submit expense > Complete the flow
Pay the request
Go to transaction thread > Click on header > Cancel payment
Verify that: After paying expense and canceling payment scroll down to the comments

[x] Verify that no errors appear in the JS console

Offline tests

same as above
QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/2ff8527a-858e-47e9-bc70-48cc9a32cfd6

Android: mWeb Chrome

https://github.com/user-attachments/assets/93150ac1-4162-43a1-b9ef-9ecc38943981

iOS: Native

https://github.com/user-attachments/assets/0f74c5f3-c4b3-420d-998a-c00b4b9f930e

iOS: mWeb Safari

https://github.com/user-attachments/assets/fadc58ab-6858-4ce6-a6a4-17125512cb64

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/8da384ef-1453-4612-ae12-299596a0b3d8

MacOS: Desktop

https://github.com/user-attachments/assets/363d279d-cb5d-48f2-b47a-bec91d229332

I'm investigating, will give an update soon

https://github.com/user-attachments/assets/a4de6fc2-4ac1-4bca-b47e-732335e4dadc
@dukenv0307  can't reproduce this bug

I'll investigate and update soon

still investigating, will give an update tommorrow

@dukenv0307 i fixed and i added dismissModal when we cancel payment as we did with hold and unhold action

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Anchor Texture (Bug???)

Not entirely sure if this would be considered an issue but when you blow up the anchor during the fade out the original anchor texture shows. This happened while around 60-80ms I have no idea if it happens on any lower ping yet.
This isn't a major problem but can look a bit odd when using packs that change the way anchors look.
A bit difficult to see but i tried to get a screenshot and video (video & screenshot taken on east.uspvp.org)

https://github.com/user-attachments/assets/60a1ca8e-0323-422e-9fd3-c11f29687013

Yes that's intended as a placeholder to be visible. I do have plans on making it work with packs but currently it'll keep looking that way. If you don't like it you can change the textures in assets/herosanchoroptimizer/textures or change the model of fake_anchor to be of a respawn anchor


Framework error when attempting mixed precision training

I am attempting to use mixed precision (float16) training with transformer as described in #1362 using tensor2tensor 1.13.4. The problem is observed with tensorflow 1.13.1 and 1.14.0. Debian host with a Tesla V100 GPU.
Mixed precision is enabled by passing either  --hparams_set=transformer_fairseq_fp16_activation_big or explicitly --hparams weight_dtype=bfloat16,optimizer=Adafactor.
In either case, I get a wall of warnings:

<...> common_layers.py:3494] Cast for training/gradients/AddN_77:0 may induce copy from '/device:GPU:0' to ''
<...>  common_layers.py:3494] Cast for training/gradients/AddN_78:0 may induce copy from '/device:GPU:0' to ''
<...>  common_layers.py:3494] Cast for training/gradients/AddN_79:0 may induce copy from '/device:GPU:0' to ''
<...>  common_layers.py:3494] Cast for training/gradients/AddN_80:0 may induce copy from '/device:GPU:0' to ''
<...>  common_layers.py:3494] Cast for training/gradients/AddN_81:0 may induce copy from '/device:GPU:0' to ''
<...>  common_layers.py:3494] Cast for training/gradients/AddN_82:0 may induce copy from '/device:GPU:0' to ''
<...>  common_layers.py:3494] Cast for training/gradients/AddN_83:0 may induce copy from '/device:GPU:0' to ''

The call trace for these goes to compute_gradients() in optimize.py
, which attempts to cast e.g.
Tensor("training/gradients/AddN_77:0", shape=(2048, 512), dtype=float32, device=/device:GPU:0)
to type
 tf.Variable 'transformer/symbol_modality_32755_512/shared/weights_0:0' shape=(2048, 512) dtype=bfloat16
I'm unclear as to whether this signifies a genuine problem or just a warning that some tensors are going to be sent onto the CPU to be cast to float16.
However, a bit later, I get this:
tensorflow.python.framework.errors_impl.InvalidArgumentError: Multiple OpKernel registrations match NodeDef 'node transformer/parallel_0_5/transformer/transformer/body/encoder/attention_bias_to_padding/Less (defined at /home/aidev/.local/lib/python2.7/site-packages/tensor2tensor/layers/common_attention.py:965) ': 'op: "Less" device_type: "CPU" constraint { name: "T" allowed_values { list { type: DT_BFLOAT16 } } }' and 'op: "Less" device_type: "CPU" constraint { name: "T" allowed_values { list { type: DT_BFLOAT16 } } }'
[[node transformer/parallel_0_5/transformer/transformer/body/encoder/attention_bias_to_padding/Less (defined at /home/aidev/.local/lib/python2.7/site-packages/tensor2tensor/layers/common_attention.py:965) ]]
Caused by op u'transformer/parallel_0_5/transformer/transformer/body/encoder/attention_bias_to_padding/Less', defined at:
(snip)
File "/home/aidev/.local/lib/python2.7/site-packages/tensor2tensor/utils/expert_utils.py", line 60, in decorated
return f(*args, **kwargs)
File "/home/aidev/.local/lib/python2.7/site-packages/tensor2tensor/layers/common_attention.py", line 965, in attention_bias_to_padding
return tf.squeeze(cast_fn(tf.less(attention_bias, -1)), axis=[1, 2])
File "/home/aidev/.local/lib/python2.7/site-packages/tensorflow/python/ops/gen_math_ops.py", line 4622, in less
"Less", x=x, y=y, name=name)
File "/home/aidev/.local/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 788, in _apply_op_helper
op_def=op_def)
File "/home/aidev/.local/lib/python2.7/site-packages/tensorflow/python/util/deprecation.py", line 507, in new_func
return func(*args, **kwargs)
File "/home/aidev/.local/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 3300, in create_op
op_def=op_def)
File "/home/aidev/.local/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1801, in init
self._traceback = tf_stack.extract_stack()
InvalidArgumentError (see above for traceback): Multiple OpKernel registrations match NodeDef 'node transformer/parallel_0_5/transformer/transformer/body/encoder/attention_bias_to_padding/Less (defined at /home/aidev/.local/lib/python2.7/site-packages/tensor2tensor/layers/common_attention.py:965) ': 'op: "Less" device_type: "CPU" constraint { name: "T" allowed_values { list { type: DT_BFLOAT16 } } }' and 'op: "Less" device_type: "CPU" constraint { name: "T" allowed_values { list { type: DT_BFLOAT16 } } }'
[[node transformer/parallel_0_5/transformer/transformer/body/encoder/attention_bias_to_padding/Less (defined at /home/aidev/.local/lib/python2.7/site-packages/tensor2tensor/layers/common_attention.py:965) ]]
This was with tensorflow 1.13.1. With 1.14.0, the error is less verbose, though equally fatal:
tensorflow.python.framework.errors_impl.InvalidArgumentError: Multiple OpKernel registrations match NodeDef 'node transformer/parallel_0_5/transformer/transformer/body/encoder/attention_bias_to_padding/Less (defined at usr/local/lib/python2.7/dist-packages/tensor2tensor/layers/common_attention.py:965) ': 'op: "Less" device_type: "CPU" constraint { name: "T" allowed_values { list { type: DT_BFLOAT16 } } }' and 'op: "Less" device_type: "CPU" constraint { name: "T" allowed_values { list { type: DT_BFLOAT16 } } }'
[[transformer/parallel_0_5/transformer/transformer/body/encoder/attention_bias_to_padding/Less]]
Errors may have originated from an input operation.
Input Source operations connected to node transformer/parallel_0_5/transformer/transformer/body/encoder/attention_bias_to_padding/Less:
transformer/parallel_0_5/transformer/transformer/body/Cast (defined at usr/local/lib/python2.7/dist-packages/tensor2tensor/layers/common_layers.py:3486)

I've tracked it down to a bug in TensorFlow. I'll open an issue report there.

Looks like one of the reasons is that tensorflow does not implement several GPU ops for bfloat16, starting with multiplication.

Hey @ekuznetsov139, unfortunately the code written in #1362 has only been tested on v100s with the activation_dtype set to float16 as seen here: https://github.com/tensorflow/tensor2tensor/pull/1362/files#diff-2afdeb32501f7525a17f09ded21120afR2163

I think that bfloats are only supported on tpus and cpu at the moment, which might explain the copy that you're seeing

Yes, I somehow misread #1362 to mean activation_dtype=bfloat16.

My training with transformer_fairseq_fp16_activation_big is smooth without any errors. However, the loss starts to increase after several thousand of steps, and stops to decrease afterwards. I am using V100. Any suggestion?


could the value in model is not mapped directly

The Problem
I have a requirements like this.
const initialState = {
  host:{
    'type': 1
  }
}
const map = {1: 'apple', 2: 'orange'}
<Control.text
     model="host.type"
 />

then I want "apple" is shown in the input component not "1" is shown
Could it be? Tks

Sure! You can use the parser prop:
<Control.text
  model="host.type"
  parser={(val) => map[val]}
/>


Finishing second release

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

179 of 179 (100.0%)  changed or added relevant lines in 9 files are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.1%) to 98.868%

Files with Coverage Reduction
New Missed Lines
%

repository/IngSoft2-Model/BoardGame.class.st
8
91.3%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
699

Relevant Lines:
707

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

179 of 179 (100.0%)  changed or added relevant lines in 9 files are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.1%) to 98.868%

Files with Coverage Reduction
New Missed Lines
%

repository/IngSoft2-Model/BoardGame.class.st
8
91.3%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
699

Relevant Lines:
707

💛  - Coveralls


max_tries is configurable

Keep up the good work.. And your program works on a Raspberry Pi4 Running Bullseye 64bit OS.
Tu and 73
Karl.


slick-track transform translate3d, and width CSS property are insanely high

Every now and then sometimes when I slide rapidly or too quickly before the previous swipe animation is complete, I am finding that the translate3d css property is becoming too high. So high in fact that none of my slides are visible and it just completely dissappears.

I had a very similar issue with width becoming so high to require the "e notation" as well.
The container element was a flex item with flex-basis: 100% but without max-width: 100%. Adding
max-width fixed the issue as of now.
Don't know if this might apply to your problem as well, hope it can help!

Im also having the same problem while using 100% of the container width. Im using Bootstrap 3.3.1

I had the same problem with flex items containing carrousels.  My original solution was to put overflow: hidden on all my flex elements (but I had no control on child elements that could inserted like text, image or carrousel elements). As my clients could use tooltips that spiled out of their container, the overflow: hidden was not acceptable.  The max-width was the solution for my project! Thanks to you!!!!

I had a very similar issue with width becoming so high to require the "e notation" as well.
The container element was a flex item with flex-basis: 100% but without max-width: 100%. Adding
max-width fixed the issue as of now.
Don't know if this might apply to your problem as well, hope it can help!

Where do you insert the max-width: fixed; ?

@bulkerke I've added max-width to the container element of the carousel, the one that has display:flex

Hi,
Please check the script and styles below. It's Working
$('.slider-for').slick({
slidesToShow: 1,
slidesToScroll: 1,
arrows: false,
fade: true,
asNavFor: '.slider-nav'
});
$('.slider-nav').slick({
slidesToShow: 4,
slidesToScroll: 1,
asNavFor: '.slider-for',
dots: true,
vertical:true,
focusOnSelect: true
});
// transform issue
var numSlides = $('.slider-nav li').length;
//you can set the value here
if (numSlides == 2 || numSlides == 3) {
// Add a CSS class to the slider-nav
$('.slider-nav').addClass('small-slides');
}

Please check my answer on stack overflow https://stackoverflow.com/questions/66170709/slick-slider-transform-issue-on-nav-slider/76211151#76211151


Dropdown list for date uuid, user id, store code and product code based on previous entries in the table


power runner summon time determined during flag placement

Rather than simply summon runners when the bank is below an arbitrary number of hits (600k atm), power mining flag memory should include number of hits at which to summon runners for that bank.
Ex: bank is ~200 steps from spawn, and has enough power for 4 runners. It is determined that runners should start spawning 500+ ticks before the bank breaks (runners will need 2 waves + 200 ticks to walk). Use normal mining rate (2 miners => 1.2k/t) to determine that miner should request runners when bank is below 600k. Extra check: if the first batch of runners will be getting home with less than 100ttl, don't place the mining flag.

if saving the info is too problematic. pminers can recalculate as needed using map.findRoute (negligible cpu)

saving info in the flag should be no problem


actual fix for issue #43

reverted slashJoin function, the faulty logic was outside the function, I added a new case check for req.url URLs that contain '/?query=param' as well as '?query=param', tests pass.  Closes #43 after merge, bump, and publish.

can you add a test to make sure it works?

Yeah good call. Will get one written up.

@andrewrk so I spent a couple more hours on this and I have to apologize. The error I was tracking down was due to an improper invocation of your library in a downstream module.  It was causing the proxy to append a trailing slash on mounted routes.  My initial PR doesn't change the functionality, so you can either leave the code as-is or revert my changes.  Sorry again for the confusion.

Ok, so I think I'm inadvertently trying to set a new record for the amount of times I can stick my foot in my mouth.  Here's the next, and hopefully final, double back.  I'm about to push up a new code change to slashJoin - this should resolve the issue I was experiencing.  I'll do my best to explain what was happening, this is a bit confusing.
I was indirectly leveraging node-proxy-middleware from hiddentao/gulp-server-livereload.  When I did this, I was using the following settings:
proxies: [{ source: '/search', target: 'http://localhost:3001/search' }]

which in node-proxy-middleware was being applied in gulp-server-livereload's  src/index.js on line 99 like so:
app.use(config.proxies[i].source, proxy(proxyoptions));

When invoked in this way, without specifying a route via the options.route proxyOptions.route = '/api'; , the mount path is stripped out of req.url (which is caused by connect conventions to strictly enforce having trailing slashes).
// without options.route
req.url = /?query=param

// with options.route
req.url = ?query=param

The effect of this is, when you have a route without a trailing slash, the path gets removed, but the mount point gets a slash added in by connect.  So when the path p1 and p2 get put through slashJoin() a slash is added in and gives me the following incorrect path: (from the request object I was debugging):
path: '/search/?....'

On the destination server it is expecting /search, /search/ does not exist (these are different resources).
To fix this first part, we need to adjust the way we call into the proxy, by setting the route parameter on the options object in src/index.js instead
proxyoptions.route = config.proxies[i].source;
app.use(proxy(proxyoptions));

This will now give us a properly mounted route.  The final step is to make sure we don't automatically add an unnecessary slash in via the slashJoin() function automatically.  We should only add the slash in if p1 has a trailing slash, and p2 has a leading slash (basically we collapse it into one)
 function slashJoin(p1, p2) {
   if (p1.length && p1[p1.length - 1] === '/' && p2.length && p2[0] === '/') {p2 = p2.substring(1); }
   return p1 + p2;
}

This way, if there is no trailing slash, we don't add one.  I was going to write a test up for this, but the test suite already has a test covering this use case.
✓ Can proxy just the given route with query.

If this made any sense and you feel comfortable merging my pending changes, I would really appreciate it.  I'm going to go bug @hiddentao to alter the invocation of your module and hopefully be on my way to using your two great libraries.
TL;DR - slashJoin always adds a slash between p1 and p2, even if there is no trailing slash on the p1 path route, or leading slash on the p2 route.  This is incorrect.  I fixed this automatic URL rewrite, ensured tests pass, and ensured the overall use case works.

@jlank I've updated gulp-server-livereload to use the latest version of this library and have made the change you've suggested. Hope that helps.

@hiddentao that is great thank you, I'll test it out now!

@hiddentao works for me, which is great, thank you.  @andrewrk the version at master works for my use case and passes the existing tests so we may be able to ignore this PR, because I think the logic is the same as before.


chat disappeared

Description

What is the problem: I found a bug, yesterday the chat I created was available, today it's not, on my phone it's available, but when I try to leave it, it says that my user is not a member of this chat.
Is there any way to exit the chat through the API?

Who is affected: N/A

How is this bug manifesting: N/A

When did this first appear: Today

I should say right away that I don't know why this chat disappeared, there's nothing strange in the logs.


How To Disable Render value in some chart

Sir, how to disable render value in some chart ? i want another my chart not display render value, what must i do ? in documentation value render property not have value disable, or false

Hi @zeraferrari , do you have the solution for this?
I show all the renders in my graphics but i want show only in one piechart.
I added the code only in the config of my piechart but its shown in all my graphics. How could you solved it?
Thanks!

The solution is:
plugins: {
 labels: false,
},

:)


Increase CloudStack concurrent tests to 70

Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm


currently having problems with retrieving matolab onotogies

trying to download ontology from  https://purl.matolab.org/mseo/mid causes timeout errors.
Full error message:
File "C:\Users\richard\anaconda3\envs\csv2csvw\lib\site-packages\owlready2\namespace.py", line 903, in load
except:  raise OwlReadyOntologyParsingError("Cannot download '%s'!" % f)
owlready2.base.OwlReadyOntologyParsingError: Cannot download 'https://purl.matolab.org/mseo/mid'!
no code was altered, code was working fine last week, did some filedestinations change?

Problem was fixed by now.


Proposals tab at Democracy component, sometimes has trouble to showing the proposal's deposited amount!

At this line, Because the proposal's image prop can be undefined, It's better to check before passing to a function!

Did you applied the latest updates?

Ahh, you fixed it, I was a little late in submitting the issue!
Great👍🏻


[iOS, 3.x] Fix build with warnings=extra.

Replaces deprecated sprintf with vfromat based get_datetime_string_from_system.
Suppresses warnings from Bullet headers.

Thanks!

Cherry-picked for 3.5.2.