Trades not working - insufficient funds for gas * price + value

Hello.
I'm trying to use simple-uniswap-sdk to execute trades on Uniswap.
The library seems to be awesome, but I'm facing some issues using it.
Here is the code:
import simpleUniswapSdk from 'simple-uniswap-sdk';

const {ChainId, UniswapPair} = simpleUniswapSdk;

import Web3 from 'web3';

const PRIVATE_KEY = "XXXXXXXXXXX";
const ADDRESS = "XXXXXXXXXXX";
const FROM_TOKEN = "0xdac17f958d2ee523a2206206994597c13d831ec7";
const TO_TOKEN = "0x85eee30c52b0b379b046fb0f85f4f3dc3009afec";
const AMOUNT = '10';
const PROVIDER_URL = "https://mainnet.infura.io/v3/XXXXXXXXXXX";

const web3TradeExample = async () => {
  const uniswapPair = new UniswapPair({
    // the contract address of the token you want to convert FROM
    fromTokenContractAddress: FROM_TOKEN,
    // the contract address of the token you want to convert TO
    toTokenContractAddress: TO_TOKEN,
    // the ethereum address of the user using this part of the dApp
    ethereumAddress: ADDRESS,
    // you can pass in the provider url as well if you want
    providerUrl: PROVIDER_URL,
    chainId: ChainId.MAINNET,
  });

  // now to create the factory you just do
  const uniswapPairFactory = await uniswapPair.createFactory();
  const web3 = new Web3(uniswapPairFactory.providerUrl);

  // the amount is the proper entered amount
  const trade = await uniswapPairFactory.trade(AMOUNT);
  trade.transaction.gas = 30000;
    console.log(trade);

  if (!trade.fromBalance.hasEnough) {
    throw new Error('You do not have enough from balance to execute this swap');
  }
  trade.quoteChanged$.subscribe((value) => {
    // value will hold the same info as below but obviously with
    // the new trade info.
  });

  if (trade.approvalTransaction) {
    trade.approvalTransaction.gas = 30000;
console.log(trade.approvalTransaction);
    const signedTransaction = await web3.eth.accounts.signTransaction(
      trade.approvalTransaction,
      PRIVATE_KEY
    );

    console.log('signedTransaction');
    console.log(signedTransaction);
    if (!signedTransaction.rawTransaction) {
      throw new Error('Could not find tx');
    }

    web3.eth
      .sendSignedTransaction(signedTransaction.rawTransaction)
      .once('transactionHash', (transactionHash) => {
        console.log('approved txHash', transactionHash);
      })
      .once('receipt', async (receipt) => {
        console.log('approved receipt', receipt);
        await executeTrade(web3, trade);
      })
      .on('error', async (error) => {
        console.log(`ERROR ${error.message}`);
      });
  } else {
    console.log(
      'already has approved uniswap to move tokens on your behalf or its eth > erc20 token swap'
    );
    await executeTrade(web3, trade);
  }
};

const executeTrade = async (web3, trade) => {
  const signedTransaction = await web3.eth.accounts.signTransaction(
    trade.transaction,
    PRIVATE_KEY
  );
console.log('executeTrade signedTransaction')
console.log(signedTransaction)

  if (!signedTransaction.rawTransaction) {
    throw new Error('Could not find tx');
  }

  web3.eth
    .sendSignedTransaction(signedTransaction.rawTransaction)
    .once('transactionHash', (transactionHash) => {
      console.log('trade txHash', transactionHash);
    })
    .once('receipt', (receipt) => {
      console.log('trade receipt', receipt);
      // once done with trade aka they have sent it and you don't need it anymore call
      trade.destroy();
    })
    .on('error', async (error) => {
      console.log(`ERROR ${error.message}`);
    });
};

web3TradeExample();

And the output:
...
fromBalance: { hasEnough: true, balance: '91.085433' },
...
ERROR Returned error: insufficient funds for gas * price + value

Could you please explain what I'm doing wrong?  Thanks in advance.

Hey thanks for this issue. Your code is fine but at the moment the library does not handle gas costs within the context it brings back. This means that you have to handle if you don’t have enough eth to send the transaction. That error is coming from web3 on line when calling sendSignedTransaction >
   .on('error', async (error) => {       console.log(ERROR ${error.message});     });
It’s basically saying you don’t have eth on your address to cover the cost to send this transaction.
for now the gas handling has to be done your side as stated, later on the library will had gas estimated and added context to tell you the user doesn’t have enough eth to send the transaction.
Will close this let me know if you have anymore questions.

Hello @joshstevens19
Thanks for explanation.
So, to pay for the gas I need to have ETH on my wallet, right?
Even if I'm sending USDT?

Yes that’s how ethereum works. You pay a fee to send a transaction this is given to the miners to mine the transaction into the blockchain. Gas is always paid with ETH. You can’t send a transaction without ETH. 👍

Yes that’s how ethereum works. You pay a fee to send a transaction this is given to the miners to mine the transaction into the blockchain. Gas is always paid with ETH. You can’t send a transaction without ETH. 👍

Amazing! Thanks for the explanation!
And again, the library is really awesome, thanks!


UI is opening the wrong entry modal

When there are nested entries and you want to add a new entry within a nested entry, it's opening the modal of the parent entry when it's selected. Difficult to explain, but maybe the following video will make the problem clear:

(+) next to Estimates should open a modal with the possibility to add an EstimateFolder.
(+) next to 2023 should open a modal with the possibility to add a new Extimate.
Buth when Estimates is selected, clicking the (+) next to 2023 is triggering the (+) of the selected Estimates entry.
This error also occures in the opposit direction, when 2023 is selected and you click the (+) next to the Estimates entry.

This is fixed in 0.4.0. There's a single button to create new entries which picks the parent you're currently in


sanitycheck: group case selection options in the help message

$ sanitycheck --help # is re-ordered like this:
 < ... all other options ... >

 -C, --coverage        Generate coverage reports. Implies
                       --enable_coverage

 --coverage-platform   COVERAGE_PLATFORM
                       Plarforms to run coverage reports on. This
                       option may be used multiple times.

Test case selection:

 -f, --only-failed     Run only those tests that failed the previous
                       sanity check invocation.

 -s TEST, --test TEST  Run only the specified test cases. These are
                       named by <path to test project relative to
                       --testcase-root>/<testcase.yaml section name>

 --sub-test SUB_TEST   Run only the specified sub-test cases and its
                       parent. These are named by test case name
                       appended by test function, i.e.
                       kernel.mutex.mutex_lock_unlock.
 --list-tests          list all tests.
 -F FILENAME, --load-tests FILENAME
                       Load list of tests to be run from file.
 -E FILENAME, --save-tests FILENAME
                       Save list of tests to be run to file.
 -T TESTCASE_ROOT, --testcase-root TESTCASE_ROOT
                       Base directory to recursively search for test
                       cases. All testcase.yaml files under here will
                       be processed. May be called multiple times.
                       Defaults to the 'samples' and 'tests' directories
                       in the Zephyr tree.

Codecov Report

Merging #14284 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14284   +/-   ##
=======================================
  Coverage   51.98%   51.98%
=======================================
  Files         308      308
  Lines       45490    45490
  Branches    10536    10536
=======================================
  Hits        23649    23649
  Misses      17044    17044
  Partials     4797     4797

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aa8443...ac537ab. Read the comment docs.


add computation tutorial

So my notebook has a deliberate error, which is causing the CI to fail:
https://github.com/xarray-contrib/xarray-tutorial/pull/13/checks?check_run_id=762122971#step:6:256
How should I handle this? try / except?
My feeling is that it's useful to see an error message that arises from a common situation.

I think we'd probably need a way to somehow mark cells (using a cell magic?) such that the exception is caught but the stacktrace is still visible

you could try expectexception

Good suggestion. expectexception worked. But travis-ci is still failing. Why do we need both?

not sure, but the travis failure is a network connection issue (rerunning should fix that)

Yes, doctr doesn't support github actions (yet).

Yes, doctr doesn't support github actions (yet).

We don't need doctr. You can deploy directly to github pages without doctr using github actions.
Example: https://github.com/pangeo-gallery/pangeo-gallery/blob/master/.github/workflows/build-and-deploy.yml

@rabernat - totally open to dropping doctr. You have a more experience in this area so I'm happy to let you take the lead here.

I can't merge this myself. Could someone else please do it?

Thanks ryan


provide option to keep month selection on startDate select

We have a use case where we do not want to change active months selection when selecting a date from the second month panel.  To avoid any breaking changes a new option was introduced changeActiveMonthOnSelect.
Please have a look at this small chang @tresko

@tresko Thanks for approving 🙏
Any idea when you are planning to release a new version?

Thank you for PR. New version 2.8.0 is on npm ;)


Mutation cargo edge missing cursor field

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] question

PostGraphQL version:
4.0.0-alpha2.28
Minimal SQL file that can be loaded into a clean database:
CREATE TABLE foo (
  id  integer PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY,
  bar text NOT NULL
);

Steps to reproduce:
Config: classicIds: true
Mutation
mutation updateFooMutation($input: UpdateFooInput!) {
  updateFoo(input: $input) {
    clientMutationId
    fooEdge {
      cursor
      node {
        id
        bar
      }
    }
  }
}

Query Variables
{
  "input": {
    "clientMutationId": "base-64-encoded-identifier",
    "id": "base-64-encoded-tuple",
    "fooPatch": {
      "bar": "baz"
    }
  }
}

Current behavior:
The cursor field returns null.
{
  "data": {
    "updateFoo": {
      "clientMutationId": "base-64-encoded-identifier",
      "fooEdge": {
        "cursor": null,
        "node": {
          "id": "base-64-encoded-tuple",
          "bar": "baz"
        }
      }
    }
  }
}

Expected behavior:
The cursor field should return a valid cursor.
{
  "data": {
    "updateFoo": {
      "clientMutationId": "base-64-encoded-identifier",
      "fooEdge": {
-       "cursor": null,
+       "cursor": "base-64-encoded-cursor",
        "node": {
          "id": "base-64-encoded-tuple",
          "bar": "baz"
        }
      }
    }
  }
}

Looking into this now.

So turns out this was an issue in v3 also; so while trying to adhere to the v3 test suite I didn't notice the omission.

4 hours of coding later I've fixed it; that was a lot harder than I anticipated! 😅


Remove extra application of EXTRAFLAGS and KDEFINE at the arch-level

Summary
EXTRAFLAGS is already applied to *FLAGS in board's Make.defs (and
it applies to whole build, not just arch-code). EXTRAFLAGS is passed
around each make call to the complete build.
KDEFINE is already added to EXTRAFLAGS in main Makefile so no need
to add it again in arch-level Makefile
Impact
Build
Testing
Built locally, verified KDEFINEs appear where expected and only once. Also,
tested by doing make EXTRAFLAGS=<flag> and verify it also appears everywhere
and only once.

@v01d - Thank you for the detailed PR info, the context is so helpful.


Auth addon

Need a cohesive story for auth. Should be simple out of the box, and could serve as a good test case / example addon

@davewasmer Do you have additional thoughts / guidance here?  This would be the next piece I'd need for the ember-help-wanted-backend after I get the webhook piece built ...

This is my first stab at it so far, but it's pretty outdated. I was planning on looking at Passport.js and Devise for inspiration.

Closing in favor of the org-wide project tracking the 0.1.0-beta.1 release.
Also, denali-auth now has a fleshed out first-pass implementation!


Compatibility Error

hi dud
its not working with Laravel v8 plz fix it

up +1

#237 @abbasfisal @cephee

up +1


AAE-10135: turn build-and-tag-maven GH reusable workflow into an acti…

…on

Will rework the PR as some of the changes were already handled with #114

force pushed to handle conflict after merge of #126

force pushed to handle conflict after latest release

Keeping the work branch for now as there are currently running workflows that are still running on it


patch: update text in Creating teams

@thgreasi would you like to have a look at the proposed changes?


Enable prometheus admin api on rancher monitoring

What kind of request is this (question/bug/enhancement/feature request):
bug?
Steps to reproduce (least amount of steps as possible):
Fresh new RKE cluster deployed with the UI. Enabled cluster monitoring.
Result:
I have no way to activate the admin api of prometheus monitoring.
(https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis)
I tried the following arguments (Rancher -> Monitoring -> Advanced Options):
server.enableAdminApi
prometheus.enableAdminApi
Thanks in advance for any help.
Other details that may be helpful:
The attempt to enter it directly into the deployment “prometheus-cluster-monitoring” as a start parameter (Command) has also failed. The changes are not accepted.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
v2.4.5
Installation option (single install/HA):
single install

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Infrastructure Provider: DigitalOcean
Machine type (cloud/VM/metal) and specifications (CPU/memory):
cloud: Shared CPU, 2 vCPUs, 4 GB RAM, 80 GB SSD
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.6", GitCommit:"d32e40e20d167e103faf894261614c5b45c44198", GitTreeState:"clean", BuildDate:"2020-05-20T13:16:24Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.6", GitCommit:"dff82dc0de47299ab66c83c626e08b245ab19037", GitTreeState:"clean", BuildDate:"2020-07-15T16:51:04Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Is it possible to provide API-access for PromQL queries?

Yes, https://prometheus.io/docs/prometheus/latest/querying/api/


Relaxing test_models precision (Reverting #6380)

From investigation (see https://github.com/pytorch/vision/pull/7114#issuecomment-1400861739), it seems that our model test is sensitive to machine type. And after testing on AWS cluster, it seems to start failing since the PR #6380 in AWS cluster machine. To fix this, we should revert the PR and relax the precision criteria.
cc @pmeier

Would it make sense to go with a middle ground here? I see we had 1e-3 and are reverting to 1e-1. I agree with the premise of #6380 that 1e-1 is pretty loose tolerance. Maybe we can use 1e-2 or the like? If the internal workflow, GHA, and the AWS cluster is happy, we have a little more confidence in the the CI signal without hopefully getting flakiness.

Would it make sense to go with a middle ground here? I see we had 1e-3 and are reverting to 1e-1. I agree with the premise of #6380 that 1e-1 is pretty loose tolerance. Maybe we can use 1e-2 or the like? If the internal workflow, GHA, and the AWS cluster is happy, we have a little more confidence in the the CI signal without hopefully getting flakiness.

Would it make sense to go with a middle ground here? I see we had 1e-3 and are reverting to 1e-1. I agree with the premise of #6380 that 1e-1 is pretty loose tolerance. Maybe we can use 1e-2 or the like? If the internal workflow, GHA, and the AWS cluster is happy, we have a little more confidence in the the CI signal without hopefully getting flakiness.

Looking at the errors, seems like 1e-2 will still have a lot of model that failed. Also, even 0.1 still have resnet101 failed (which currently I am not too sure what to do on this).

@NicolasHug @pmeier This PR resolve most problem on the model test. From what I see the remaining problem is on vit_h_14 which strangely got the following tracing
___________________ test_classification_model[cuda-vit_h_14] ___________________
Traceback (most recent call last):
  File "/work/test/test_models.py", line 732, in test_classification_model
    _check_input_backprop(model, x)
  File "/work/test/test_models.py", line 226, in _check_input_backprop
    out[0].sum().backward()
  File "/work/ci_env/lib/python3.8/site-packages/torch/_tensor.py", line 488, in backward
    torch.autograd.backward(
  File "/work/ci_env/lib/python3.8/site-packages/torch/autograd/__init__.py", line 197, in backward
    Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
RuntimeError: CUDA error: invalid argument
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

I think this is a core issue that should be reported (I can't reproduce this error on AWS cluster, and setting CUDA_LAUNCH_BLOCKING=1 didn't really give a better error trace as well).


Please explain useage in more detail

Hi,
Can you please explain how to use the command line arguments and pass the image and detect text in form ?

Hi ,
Thank you for the response .
Can you please help me how to extract single lines from the form and detect
handwritten text in this link :-
https://github.com/doxakis/form-segmentation
Actually am new to this field and am running out of the time to analyse and
implement with the help of reference notes.
Please help me in this to get the result
Thank you
Nishant Bhat
+91-7829709236
On Fri 12 Oct, 2018, 9:54 AM Philip Doxakis<EMAIL_ADDRESS>wrote:

Hi,
I just want to tell you that I saw your message. I will answer you with a
complete answer in the next few days.
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenFieldReader/OpenFieldReader/issues/1#issuecomment-429200194,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdJY0f31u9oQnAQlMxbhyUuRnOFqM8DEks5ukBmFgaJpZM4XWyTw
.

Thank you so much. I will be waiting for the next solution of the usage

Hi,
you may want to use the python wrapper (https://github.com/OpenFieldReader/OpenFieldReaderWrapper) since it should be easier and preprocessing will be done for you with opencv.
For convenient, I created a pypi project (pip install openfieldreaderwrapper)
If you use linux, simply follow the step here: https://github.com/OpenFieldReader/OpenFieldReader to install the package openfieldreader
On Windows, you may want to do the following:

On Visual Studio 2017, publish with Release configuration, target framework netcoreapp2.0, deployment mode: self-contained, target runtime: win-x64
Add the folder containing the OpenFieldReader.exe to the PATH variable of Windows.

I added a new repo: https://github.com/OpenFieldReader/OpenFieldReader-datasets
It shows you how to use it: generate-dataset.py
(I'm using opencv. Make sure to install it: pip install opencv-python)
In the folder dataset1 and dataset2, you will find the dataset I will use. For obvious reasons, I had to find out a public dataset and I end up using sudoku grids.. feel limited because it's only letter from 1-9. But, it should be fine to demonstrate what you can do. If you think about it, you can see it as 9 fields with 9 characters each.
In the folder dataset1-cells and dataset2-cells. you will find the result of the extraction. One picture per cell. (letter from 1-9, empty cell and random image sometime)
The algorithm only resolve the segmentation issue (find where are the cells)

Then, you may want to prepare a dataset for training.
Here, I'm considering the letter 1-9, empty cell and random image not relevant to improve the quality of predictions.

Then, implements a CNN (convolutional neural network) and predict the letter if the confident is high enough.
I hope it help you understand what is the purpose of this project and what you can do with it right now.
Thanks and good luck!

Hi, I will close the issue for now. Feel free to open it again.


sql: check hydration options of relations (lazy / preload / ...)

@Knorrke could you check if the performance improves when changing the following lines in this file from
     * @ORM\OneToMany(targetEntity="TaxonomyTerm", mappedBy="parent", cascade={"remove"}, orphanRemoval=true)

to
     * @ORM\OneToMany(targetEntity="TaxonomyTerm", mappedBy="parent", cascade={"remove"}, orphanRemoval=true, fetch="EAGER")

The same (adding , FETCH="EAGER") could also be tried here, here.
This could also be tested in the entity module.
This option tells doctrine that we want to immediately JOIN those relations, instead of lazy-loading them when required. This makes sense where we either know that we need to fetch the whole collection anyways (typically we fetch the whole taxonomy tree, we also always fetch the taxonomy term (the "title" of the node)) or where the collection is very small (e.g. taxonomy_type).

Nevermind, this is a really bad idea. SQL Queries skyrocket from 150 to ~2500 on regular content pages...


[Bug]-[188]:Datepicker when inside the form widget does not give formatted date

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When the Datepicker widget is inside a Form widget, the date when accessed using FormName.data.DataPickerName gives the selected date in ISO format instead of the formatted date.
You can access the formatted date inside the form directly like DatepickerName.formattedDate but users expect the date to be in the formatted version when accessed from within the form instead of having to reformat it manually.
https://community.appsmith.com/t/how-do-i-work-with-datepicker-in-forms/1632
https://discord.com/channels/725602949748752515/760761686549463060/1014444088390582283
Steps To Reproduce

Add a datepicker inside the form widget
Format the date using the Date Format property on the datepicker
Try to access this date outside the form for eg, in a JSObject or in another widget using FormName.data.DataPickerName. You will notice that you get the date in the ISO format and not in the format specified.

Public Sample App
No response
Issue video log
No response
Version
v1.8.7
 Front conversations

Assuming 30% datepicker users need this
Stats

Stat
Values

Reach
188

Effort (months)
0.5

Change
Add a new field in the datepicker widget to let users define the form behavior


ADVZ allow large polynomial degree

Premise: low polynomial degree is suboptimal. Performance might improve if we allow polynomials with larger degree. Thus, we need to send multiple evaluations (instead of only one evaluation) from each polynomial to each storage node.

My (unreliable) guess is that we can achieve the best performance when we set poly degree ~1000 and add parallelism (for doing k RS encoding/poly committing in parallel, where k is the number of polys).

As a bonus, a fix for this issue also fixes #356 . ie. it reduces the size of Common.


fails on golang 1.16 code

i'm getting errors like WriteFile not declared by package os. staticcheck seems to work fine locally.

Maybe, it is same as https://github.com/reviewdog/action-golangci-lint/issues/73#issuecomment-813386935

that seemed to fix it, thank you!


Users not migrated after upgrade 1.x --> 2.1

Have performed an upgrade from v1.8.10 to 2.1.1 using influxd with those parameters
# Environment defaults
INFLUXD_CONFIG_PATH=/etc/influxdb/config.toml
INFLUXD_BOLT_PATH=/var/lib/influxdb/influxd.bolt
INFLUXD_ENGINE_PATH=/var/lib/influxdb/engine

export INFLUXD_CONFIG_PATH INFLUXD_BOLT_PATH INFLUXD_ENGINE_PATH

/usr/bin/influxd upgrade \
  --config-file=/etc/influxdb/influxdb.conf \
  --log-path=/var/log/influxdb/upgrade.log \
  --v2-config-path=${INFLUXD_CONFIG_PATH} \
  -m $INFLUXD_BOLT_PATH -e $INFLUXD_ENGINE_PATH

after successfully upgrade there is printed only one user (that was created during upgrade process)
[root@dev-environment ~]# influx user ls
ID			Name
08b53f3c19025000	admin

even on v1.8.10 influxdb store lots of not admin users with grants, for example:
[root@ops-influx01 ~]# influx -username root -password required_passwd -port 8003
Connected to http://localhost:8003 version 1.8.10
InfluxDB shell version: 1.8.10
> show grants for "ab_dev"
database privilege
-------- ---------
ab_dev   WRITE
>
> show grants for "ab_test"
database privilege
-------- ---------
ab_test  ALL PRIVILEGES

and no any messages to /var/log/influxdb/upgrade.log about user creation or etc...
seems like i should get some info about "Upgrading 1.x users" during this code
https://github.com/influxdata/influxdb/blob/8aa3a8f7e5908d544b649c60c9271c23c76305c5/cmd/influxd/upgrade/security.go#L44
Documentation says --> https://docs.influxdata.com/influxdb/v2.1/upgrade/v1-to-v2/automatic-upgrade/
influxd upgrade migrates existing 1.x users and their permissions except the following users:

1.x admin users
1.x non-admin users that have not been granted any privileges

Any suggestions what could be wrong during upgrade ?

Hi @eliteaz, thank you for creating an issue. I am looking into this and seeing if I can reproduce the problem. I will let you know if I need additional information or have suggestions that may work.

Thanks @mcfarlm3 for Your attention.
I have started migrate using manual upgrade procedure --> https://docs.influxdata.com/influxdb/v2.1/upgrade/v1-to-v2/manual-upgrade/
create dbrp mapping and users for each bucket separately.
Also use influx_inspect export tool for v1 dbs dumps and import to v2 with influx write command
If needed please be free to ask for additional information

@eliteaz I was able to reproduce your issue and am still looking into how to solve now. In the meantime, did the manual upgrade process work for you?

@mcfarlm3 yes, manual upgrade works
following this documentation --> https://docs.influxdata.com/influxdb/v2.1/upgrade/v1-to-v2/manual-upgrade/

@eliteaz You mentioned that there was nothing in the log messages indicating successful  user migration - was there a log message stating "There are no users in 1.x, nothing to upgrade" or something similar? If you are able to share that upgrade log I should be able to narrow down the issue.

Sure, that's full upgrade log
{"level":"info","ts":1641298142.229478,"caller":"upgrade/upgrade.go:402","msg":"Starting InfluxDB 1.x upgrade"} {"level":"info","ts":1641298142.2295694,"caller":"upgrade/upgrade.go:405","msg":"Upgrading config file","file":"/etc/influxdb/influxdb.conf"} {"level":"info","ts":1641298142.2296972,"caller":"upgrade/upgrade.go:409","msg":"Config file upgraded.","1.x config":"/etc/influxdb/influxdb.conf","2.x config":"/etc/influxdb/config.toml"} {"level":"info","ts":1641298142.2297063,"caller":"upgrade/upgrade.go:419","msg":"Upgrade source paths","meta":"/var/lib/influxdb/meta","data":"/var/lib/influxdb/data"} {"level":"info","ts":1641298142.2297118,"caller":"upgrade/upgrade.go:420","msg":"Upgrade target paths","bolt":"/var/lib/influxdb/influxd.bolt","engine":"/var/lib/influxdb/engine"} {"level":"info","ts":1641298142.2383795,"caller":"bolt/bbolt.go:83","msg":"Resources opened","service":"bolt","path":"/var/lib/influxdb/influxd.bolt"} {"level":"info","ts":1641298142.2385068,"caller":"migration/migration.go:175","msg":"Bringing up metadata migrations","service":"migrations","migration_count":18} {"level":"info","ts":1641298234.5185318,"caller":"upgrade/setup.go:73","msg":"CLI config has been stored.","path":"/root/.influxdbv2/configs"} {"level":"info","ts":1641298234.5185575,"caller":"upgrade/database.go:202","msg":"Checking available disk space"} {"level":"info","ts":1641298234.62074,"caller":"upgrade/database.go:223","msg":"Computed disk space","free":"2.0 TB","required":"191 GB"} {"level":"info","ts":1641298283.4051616,"caller":"upgrade/database.go:51","msg":"Upgrading databases"} {"level":"warn","ts":1641298286.4254034,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.3441832,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.347063,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.3499446,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.3540404,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.3569815,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.3600404,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.3629725,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.367319,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.3707302,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.3739069,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.3768883,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298293.37989,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298397.898143,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298405.2575326,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298413.1858366,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298414.5285697,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298415.919371,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298441.5684798,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298443.0985787,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298444.6363811,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298446.4190679,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298522.383827,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298524.0290833,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298525.6568651,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298525.983842,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298527.6078806,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298527.939632,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298529.9631162,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298531.6198454,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298531.964609,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"warn","ts":1641298531.9732027,"caller":"upgrade/database.go:158","msg":"Empty retention policy"} {"level":"info","ts":1641298531.9732466,"caller":"upgrade/database.go:195","msg":"Database upgrade complete","upgraded_count":55} {"level":"warn","ts":1641298531.9732757,"caller":"upgrade/security.go:141","msg":"No buckets for database [amber_dev] exist in 2.x."} {"level":"warn","ts":1641298531.9732828,"caller":"upgrade/security.go:141","msg":"No buckets for database [] exist in 2.x."} {"level":"warn","ts":1641298531.973289,"caller":"upgrade/security.go:141","msg":"No buckets for database [ab_dev] exist in 2.x."}

@eliteaz So it seems as though, because some of the databases did not have data in them (see "Empty retention policy" log messages), that any non-admin users with grants on only those empty databases were not migrated. Does this match with what you know about your 1.x databases and grants, or would you expect there to be data present in those databases and it is not being found?

yes, there is databases with 3 separate retention policies, for example i use named "month" with 90days long time
> show retention policies on "dev-web-backend.example.org"
name     duration  shardGroupDuration replicaN default
----     --------  ------------------ -------- -------
month    2160h0m0s 24h0m0s            1        true
3-months 2160h0m0s 24h0m0s            1        false
default  2160h0m0s 24h0m0s            1        false

and also a list of users for each separate database without admin permissions
InfluxDB shell version: 1.8.10
> show users
user                                             admin
----                                             -----
root                                             true
ab_prod                                          false
ab_dev                                           false
ab_test                                          false
mirror.example.org                                false
jenkins                                          false
dev-live-backend.example.org                      false
....
dev-web-backend.example.org                       false
.....
.....

I see - thank you for providing more information about the database retention policies. So it seems as though it is checking those retention policy directories, and finding that quite a few of them are empty (no shards present), resulting in the "Empty retention policy" log messages, and then those databases are not being migrated (as well as users who only have grants on them).
This seems unusual that there are no shards being found, unless these are newly created databases which have never had data written to them. I am assuming that is not the case here, and these are databases which have had data written to them at some point? If so, I'll do a bit more testing to see if there's another issue that needs addressing here.
At the least, I'm going to make some improvements to upgrade logging, and make sure that newly created empty databases are being migrated as well.

Also - if you still have your 1.x database, you could run the upgrade command again with --log-level=debug and that would give us more detailed information about which specific retention policy directories are coming up empty.


ENH: Terminate process group on timeout under Windows.

Consider a subsubprocess created within a benchmark that times out. The current behavior is:

POSIX: the benchmark subprocess group is terminated (including the subsubprocess);
Windows: just the benchmark subprocess is terminated.

Under Windows this can lead to the main process hanging on stderr_reader.join() (as the subsubprocess may inherit file descriptors).
This change should ensure that subsubprocesses are terminated on timeout also under Windows. The implementation uses console events as that seems to be more reliable than taskkill or psutil.children() based solutions. This is a bit specific, so some additional testing under Windows would be appreciated.
Some references:

a nice write-up on Python and signals in Windows;
MSDN on CREATE_NEW_PROCESS_GROUP and CTRL_BREAK_EVENT;
the commit in which the POSIX counterpart was introduced;
the AppVeyor failure in #487 is most likely due to this issue.

Coverage decreased (-0.02%) to 58.244% when pulling cf75d1cd4157d4be82e3efeab692710e079593d8 on wrwrwr:process-group-windows into a14d8dc70442faef6e8b4eacb60ffc9c3d488fa6 on spacetelescope:master.

Coverage decreased (-0.02%) to 58.244% when pulling 73115614fd1545bf90b0b144a22be523ef3e2355 on wrwrwr:process-group-windows into a14d8dc70442faef6e8b4eacb60ffc9c3d488fa6 on spacetelescope:master.

Thanks, merged!
I think it's best to not worry too much about the edge case here (processes ignoring signals), which is probably going to be rare.


Discord notifications missing "card"

Discord notifications used to look like this:

Now looking like this:

Try adding ?thumbnail=Yes to your URL.

Same.
I have this in my compose file:
- NOTIFIERS="discord://538xxxxxxxxxxxxx/a7Fp-j3Lxxxxxxxxxxxxxxxxxxxplu5LtwOdER?thumbnail=Yes"

hmm...
Could you next try adding ?thumbnail=Yes&format=markdown to your URL and let me know?

hey caronc. i chalked it up to the enhancements you have made and just hadnt had a chance to fix it downstream here.

Works!

@DirtyCajunRice That's okay :slightly_smiling_face:. You honestly can't be that many commits behind.
@sjabby Awesome!
FYI: The problem (well... if it is), is actually upstream:

The thumbnail issue is tied to this commit.  The description of the commit was to reflect the documentation (the irony is that now it doesn't). Personally though, i find the images included in every post (to Discord) seemed kind of overkill, big, and really ugly IMO.  I'm on the fence on updating the docs to reflect this or rolling back.
The markdown was removed as the being default because it really breaks the use of Discord from the command line (piping shell commands etc; the hashtag that appears as comments in just about every file looks really busted up when markdown is automatically applied to something that isn't).  A format of text is the new default going forward, but you can optionally set the ?markdown=True flag in the future to work around this.  Unfortunately I don't really have any good standards in place yet for what certain default settings per notification service should be.

Ill close this and reference it if anyone else has this issue. Thanks @caronc


Adds addReader/removeReader.

Hmm, the build doesn't seem to be working for this PR

Hmm, the build doesn't seem to be working for this PR

It's set to run on any push to any branch other than docs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-ignoring-branches-and-tags
Is it possible you are pushing in a way that it treats as a different (webhook) event? https://docs.github.com/en/actions/reference/events-that-trigger-workflows#webhook-events


Encoding / Decoding Issues

Hi,
Some issues with decoding, cause I see this: I'm happy in post body.
I'm using snippet after markdown step.

Sorry. Works as expected by using {{{ this.snippet }}}


@warrenseen on DelayedJob

It's important that open source projects are kept up to date

Thanks for your contribution @johnsyweb!


Use apiVersion declarative naming in pipelineRef and taskRef test for…

Changes
This commit adds apiVersion to the unsigned Tasks and Pipelines ie. unsignedV1beta1Task so as to be declarative when we are swapping to v1 storage version. No function change.
/kind misc

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[n/a] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/hold
as https://github.com/tektoncd/pipeline/pull/6444#discussion_r1226607300 suggested, we could accept an apiVersion in the helper.

opened https://github.com/tektoncd/pipeline/pull/6815

@JeromeJu wondering why this is closed now, the corresponding PR is still open.

@JeromeJu wondering why this is closed now, the corresponding PR is still open.

Thanks @afrittoli , https://github.com/tektoncd/pipeline/pull/6815 is now opened to be a better alternative for this:) instead of renaming the structs, it allows us to accept apiVersions to the trustedResources helper functions.
I will update the reference in the parental PR.


feat(examples): cursor can be moved left/right and character at cursor position can be deleted/inserted

Changes
Added cursor navigation to the user input example. User can now move cursor left and right. In addition user can also insert/delete characters at the cursor position.
Demo

Note
Could also put this demonstration into a new  example file if you prefer it this way.

Let's not get too much more complicated with this example. An example that uses the tui-textarea or tui-input libraries might be worth considering.

Let's not get too much more complicated with this example. An example that uses the tui-textarea or tui-input libraries might be worth considering.

This example in it's current state also has a couple bugs with unicode characters width, so might be interesting to look into how those crates handle unicode char width and if their solution might be better.
I'm unsure though about including examples using external crate widgets. Would you add another example alongside this one or would it take it's place ?

Agree. Examples should be as simple as possible, and not deviate from demonstrating its primary use case.
Related/unrelated, we should probably have unicode handling built-in. I believe this falls under this crate's primary objectives.

I realize now that the previously mentioned crates, tui-input and tui-textarea, are meant for that purpose xD
In my application I often end up needing some kind of input field.
In my opinion an input field example with a non-adjustable cursor seems not particular useful to me and the lack of Unicode width support appears like trap which bites me back later.
As a new user of ratatui I would appreciate 2 kind of examples in the area of input boxes.

A simple one line input field.
A multi-line input field.

Both example should include input with unicode width support and the ability to move the cursor around.
if this is out of the scope for this crate, then I find examples for user input more useful if they at least show that you use these external crates for input boxes.
That said, I would also not mind if my solution is replaced by such an example with the usage of an external crate.

I think eventually we should combine the two crates and bring them into ratatui as a core widget (or perhaps as a separate widgets crate?)

@mindoodoo wrote:

I'm unsure though about including examples using external crate widgets. Would you add another example alongside this one or would it take it's place ?

My intent was to communicate that we don't need to try to re-implement those crates in this example. Perhaps it would be a good idea to add a small comment in the current example pointing readers in the correct direction of the crates.

Ah I see what you mean now. I think it might be interesting to provide examples for those external crates in the meantime, but bringing one or a combination of the two into ratatui would be interesting I think.

force push has the comment update, a rebase on main and a cargo fmt of the new comment


Add optional argument original_output to vLLM's generate function

This pull request fixes #1199. An optional argument original_output is added to the vLLM's generate function: https://github.com/dottxt-ai/outlines/blob/a2fd35cfa58b9a9fb87e885a851af40019c10b62/outlines/models/vllm.py#L44-L53
original_output is a boolean. If True then the function returns the original (full) output of the vLLM API call.

Any updates on this thread? It would be a highly desirable feature


FR: Support Hot Reload for JVM Desktop

I'm not sure if this is a duplicate, but it'd be great if we could get hot reload support for JVM Desktop for Desktop Compose. Hot Reload is an important part of the dev flow.

You mean hot reload for preview?

 Almost all my UI is in the common layer though. I filed a request to get previews working on the common layer. Without them, I've actually never used Preview before - https://github.com/JetBrains/compose-jb/issues/1603
This was more around being able to hot reload the code for UI changes so that I don't have to restart the entire app and navigate back to where I was, similar to what Android, and Flutter provide.

We'd also like to see hot reload in action! ie: when the code changes, reload the app automatically while preserving as much of the state as possible, to speed up the development workflow. This is provided in many Web frameworks such as Angular and React.js.
There are relevant pages suggesting that Jetpack Compose for Android already supports this:

https://betterprogramming.pub/exploring-jetpack-composes-hot-reload-feature-3fdb5fa43ba1
https://stackoverflow.com/questions/70567310/is-there-hot-reload-in-jetpack-like-flutter

Some jvm based desktop projects feature similar app refresh behaviors:
Libgdx hot swapping

Hot swapping code is a feature that allows one to compile and swap code during runtime debugging

OpenRNDR live reload video demo

By using Kotlin’s ability to run script files we can build a live coding environment.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Add texlive 2022 as version

https://www.tug.org/texlive/
Plan for TeX Live 2022:
15feb: candidate/final sources committed, test builds begin.
25feb: tlpretest starts, CTAN updates continue there and in tlnet.
10mar: code freeze for final build, major bug fixes only.
22mar: final updates from CTAN, final doc tweaks.
23mar: deliver TL image for TeX Collection packaging/testing.
1apr: deliver TeX Collection DVD image for manufacturing.
1apr: public release (also of MacTeX).
June?: delivery of DVDs to members.

[x] Add 2022 version
[x] Add new version to CI build
[x] Chagne default (latest) to 2022

All done.


Use jackson API to decode json (un-marshalling)

[ ] InternetIdentifierMetadataEvent.setContent()
[ ] Nip05Validator.getPublicKey()
[ ] Connection.updateRelayMetadata()
[ ] Move the Nip05Validator functionality to nostr-util module, either as a class or as a static method within the NostrUtil class
[ ] more ?...

@guilhermegps
I have put my changes (#29) in guilhermegps-feature/types_marshall_jackson. I will push them to github, so that you can add yours (#30) on top.
I have tried to make it easier for you and marked the relevant places with
TODO #30
Thanks.

Awesome, thanks. I wasn't sure which branch to check. I'll have a look, cheers
Sent with Tutanota, enjoy secure & ad-free emails.
8 May 2023, 14:31 by @.***:

Hey Man...
Sorry but I didn't understand what you need. I have the branch "feature/types_marshall_jackson" with my all changes about the "removing types marshallers".
What do you need that I do?
—
Reply to this email directly, > view it on GitHub https://github.com/tcheeric/nostr-java/issues/30#issuecomment-1538367459> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/ABQMG7FC3Y5GSGU7XVXOA4TXFDYRHANCNFSM6AAAAAAXM2K4RQ> .
You are receiving this because you authored the thread.> Message ID: > <tcheeric/nostr-java/issues/30/1538367459> @> github> .> com>

Hi @guilhermegps, I'm not seeing your changes on the branch. So, I think there's been some misunderstandings, and we've been talking past each other. :-)
I've listed in the description above, all the places in the code where we're still using the nostr-json for un-marshaling, and I was hoping you would re-implement it to use the jackson library instead...
Let me know what you think. Thanks.

Hi @tcheeric, well we had some misunderstandings. Actually we have 2 kinds of work to do, the firts is what is discribed on #29, we need to remove all unncessary classes like "types" and etc. Secundly we need to re-implement all necessary unmarshellers using jackson.
I don't know what changes you did, so, if you prefer I can do this ignoring your modification on code.
Or... You can get my changes (just what was discribed on #24) and merge with your changes and then open an PR to develop. In this case we will have all changes before to start other works.

Hi Guilherme, I did the first part and pushed it to this branch: guilhermegps-feature/types_marshall_jackson.
I was hoping for you to do the un-marshaling bit.
Once completed, we can fully remove the unnecessary maven modules
Maybe you can just use the same branch?
Thanks.
Sent with Tutanota, enjoy secure & ad-free emails.
14 May 2023, 14:34 by @.***:

Hi > @tcheeric https://github.com/tcheeric> , well we had some misunderstandings. Actually we have 2 kinds of work to do, the firts is what is discribed on > #29 https://github.com/tcheeric/nostr-java/issues/29> , we need to remove all unncessary classes like "types" and etc. Secundly we need to re-implement all necessary unmarshellers using jackson.
I don't know what changes you did, so, if you prefer I can do this ignoring your modification on code.
Or... You can get my changes (just what was discribed on > #24 https://github.com/tcheeric/nostr-java/pull/24> ) and merge with your changes and then open an PR to develop. In this case we will have all changes before to start other works.
—
Reply to this email directly, > view it on GitHub https://github.com/tcheeric/nostr-java/issues/30#issuecomment-1546901979> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/ABQMG7EGLGHKLLXMKKKOQ6TXGDNMXANCNFSM6AAAAAAXM2K4RQ> .
You are receiving this because you were mentioned.> Message ID: > <tcheeric/nostr-java/issues/30/1546901979> @> github> .> com>

This is done.


Fix typos in README.md and init.lua

README.md: Two characters were transposed, preventing initialisation.
init.lua: Fix typo visible in the menu bar item.

Thanks for patch!


Ability to ignore js script in html

I have following js snippet for Google Analytics at the end of my html file:
<script>
    (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
    (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
    m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
    })(window,document,'script','//www.google-analytics.com/analytics.js','ga');
    ga('create', 'UA-XXXXX-X', 'auto');
    ga('send', 'pageview');
</script>

and uncss tries to load that js file, which it couldn't as you can see there is no protocol specified there, and even if there's protocol there, I don't see a reason to parse Google Analytics JS for uncss. So the question: is there a way (some uncss specific comment) to ignore that js script.
The stack trace is:
Error: Could not load script: "file://www.google-analytics.com/analytics.js"
    at *\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:44:23
    at Object.check (*\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:89:11)
    at Object.check (*\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:92:23)
    at Object.check (*\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:92:23)
    at Object.check (*\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:92:23)
    at *\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:108:12
    at wrappedEnqueued (*\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:255:16)
    at ReadStream.readableStream.on (*\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:76:7)
    at emitNone (events.js:110:20)
    at ReadStream.emit (events.js:207:7)
    at endReadableNT (_stream_readable.js:1047:12)
    at _combinedTickCallback (internal/process/next_tick.js:102:11)
    at process._tickCallback (internal/process/next_tick.js:161:9) Error: Invalid protocol: file:
    at Request.init (*\node_modules\jsdom\node_modules\request\request.js:460:31)
    at new Request (*\node_modules\jsdom\node_modules\request\request.js:130:8)
    at request (*\node_modules\jsdom\node_modules\request\index.js:54:10)
    at Object.exports.download (*\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:185:15)
    at fetch (*\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:136:20)
    at Object.exports.load (*\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:270:11)
    at HTMLScriptElementImpl._attach (*\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:35:22)
    at HTMLBodyElementImpl.insertBefore (*\node_modules\jsdom\lib\jsdom\living\nodes\Node-impl.js:227:22)
    at HTMLBodyElement.insertBefore (*\node_modules\jsdom\lib\jsdom\living\generated\Node.js:118:58)
    at file:///D:/web/html/frontend-boilerplate/src/index.html:5:67
    at file:///D:/web/html/frontend-boilerplate/src/index.html:6:7
    at ContextifyScript.Script.runInContext (vm.js:53:29)
    at Object.runInContext (vm.js:108:6)
    at processJavaScript (*\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:128:10)
    at HTMLScriptElementImpl._eval (*\node_modules\jsdom\lib\jsdom\living\nodes\HTMLScriptElement-impl.js:65:7)
    at *\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:31:22

There's no way to ignore it, other than commenting it out AFAIK. Personally, I'd just switch to https://; // isn't really needed anymore.

@RyanZim I agree that nowadays it is safe to switch to https://, but anyways I don't see the need for it to parse Google Analytics. It would be better performance wise if we could just specify (with some begin and end comment) that it is unnecessary to parse it.

@armpogart We're using jsdom under the hood, so I'm not sure how this would be possible.

@RyanZim Does uncss give a way to configure jsdom as it had skipExternalResources property in old api which is still supported (as stated in their main documentation). If so we could give it regex and document the ability to ignore unneeded resources.

Why not delete it in the source html file, before you pass it to uncss?
Most people have to do some kind of template production to pass valid full
html files to uncss, so just extend that process...? (Post process deletion
via awk/whatever, or configure templates to omit analytics in the html
production, etc)
2017年7月14日(金) 11:25 Arman Poghosyan<EMAIL_ADDRESS>
@RyanZim https://github.com/ryanzim Does uncss give a way to configure
jsdom as it had skipExternalResources
https://github.com/tmpvar/jsdom/blob/master/lib/old-api.md#external-resources
property in old api which is still supported (as stated in their main
documentation). If so we could give it regex and document the ability to
ignore unneeded resources.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/giakki/uncss/issues/321#issuecomment-315388625, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHlba0iKu5SRjkXzDhOhyPxzWLfOJSxUks5sN4iAgaJpZM4OYVTH
.

This will break many projects that still use protocol relative URLs. Isn't there any way to ignore specific HTML from being parsed?

Isn't there any way to ignore specific HTML from being parsed?

<!-- ignore me -->
IIRC, uncss continues despite this error, the script just isn't loaded. PhantomJS had the same issue, it just was too opaque to report the error. You're going to have the exact same problem if you open a local html file with a normal web browser. One possible workaround is to run a small http server, and run uncss on localhost.

I still think the problem is not only on loading relative url. Why to load it in the first place, there can be many scripts that are there for other purposes and we don't need to load them (parse them) during uncss. So I still think it would be valid feature to have a way to ignore it.
Yeah, I agree that that we could simply delete it during uncss, but we don't do html preprocessing usually during css stage, for example when running gulp task and browserify, we may do css stage (which can compile sass, uncss, ...) but we don't preprocess html during serving dev, we usually process html only during build.

Thinking a bit more about this, perhaps we could have a script blacklist implemented in the resource loader.

Why not delete it in the source html file, before you pass it to uncss?

The most prominent issue with that — it isn't always possible. A lot of 3rd-party scripts will load their own dependencies and additional files. You might need part of them, but the other half will yield those errors, or load something you didn't want to, at least affecting badly performance.
Besides, with large amount of pages there is an issue with loading remote resources that you don't want — they start to fail (for instance, not all servers like 300 requests in a row), and this might lead to erroring in resources that you really wanted. But because my statement above, simple deletion of remote resources would not always solve the problem.
Here said that skipExternalResources will continue to work, and for now it should be enough to fulfill current issue.
Also, here https://github.com/tmpvar/jsdom/issues/1567 said that another way is to use custom resource loader, though, I'm not aware how more difficult it is.

We're already using a custom resource loader; we just need to add this feature to our custom loader.

That would be really great

I use a templating system and I have this line in my HTML template
<script src="{applicationPath}/assets/scripts.2.5.0.js"></script>

I was using UnCSS 0.14.1 before, and it had no problems.  Now on 0.15.0 is produces this error:
Which then produces this error
Error: Could not load script: "file:///C:/my-project/templates/%7BapplicationPath%7D/assets/scripts.2.5.0.js"
    at C:\my-project\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:44:23
    at Object.check (C:\my-project\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:89:11)
    at ReadStream.<anonymous> (C:\my-project\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:108:12)
    at ReadStream.wrappedEnqueued (C:\my-project\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:255:16)
    at emitOne (events.js:115:13)
    at ReadStream.emit (events.js:210:7)
    at fs.js:1940:12
    at FSReqWrap.oncomplete (fs.js:135:15) { Error: ENOENT: no such file or directory, open 'C:\my-project\templates\%7BapplicationPath%7D\assets\scripts.2.5.0.js'
  errno: -4058,
  code: 'ENOENT',
  syscall: 'open',
  path: 'C:\\my-project\\templates\\%7BapplicationPath%7D\\assets\\scripts.2.5.0.js' }```

Previously, the failure-to-load-js error was hidden. Now the error is shown.
Note that the previous version did not load the js-at-all, and so any CSS classes, or HTML elements, that were constructed by that JS would not have been seen by UnCSS.
My recommendation (what I do in my own project), is to generate fully-formed HTML pages from your server/code, and then run those through UnCSS, where you can verify they are proper HTML and not just "templates".

That's not possible with my project, so I guess I'm either stuck waiting on the ability to blacklist certain scripts , disable all scripts, suppress errors, or just stick with the older version.

I tried to use the '-t 0' flag to get uncss NOT to try to load any JS.
I don't touch any CSS in my JS, and almost all my JS is AdSense which I'd prefer that uncss didn't even try to run.  Indeed I get errors from the protocol-relative code recommended by Google, and which one is not meant to edit.
Rgds
Damon

I do have the same problem as chrismbarr. I have a template directory, path to js-scripts look like this (NEOS CMS):
<script src="{f:uri.resource(path: 'js/libs/superfish.js', package: 'jobe.drsch')}"></script>
Alternatively, I tried to provide the test page, which has proper HTML. However, looks like I use some script that is understood by modern browsers but not by jsdom, resulting in this error:
Error: Uncaught [TypeError: window.matchMedia is not a function]

jsdom doesn't support window.matchMedia yet, unfortunately.

Alternatively, I tried to provide the test page, which has proper HTML. However, looks like I use some script that is understood by modern browsers but not by jsdom, resulting in this error:

That error is easy to bypass by doing something like
if (window.matchMedia) {
   // your code goes here
}

Then it will be simply ignored by jsdom.

I've put the code before the variable is declared and uncss successfully passed my scripts.
window.matchMedia = window.matchMedia || function() {
    return {
        matches : false,
        addListener : function() {},
        removeListener: function() {}
    };
  };

var mq  = window.matchMedia("(min-width: 960px)");
// Rest of my code

+1 for a script blacklist option. That would be really useful.

Any updates to this?

Hey,
Have a similar problem with a third-party widget, it is synchronous and seems like everything below it is removed by uncss.
Wanted to clarify, as of today, is there a way to turn it off with ProcessExternalResources: false ?

Confirming that minification still occurs despite the error. But would be nice to somehow suppress it.


Memory issues

Hello, that's me again :-)
I've played with mysql driver for a little, and there is some behavior that I am not sure how to interpret.
Same thing happen on PHP 8.1 and 8.2 and also with 0.5 version of package as well as 0.6-dev.
$connection = (new Factory())->createLazyConnection(
    'devuser:devpass@<IP_ADDRESS>:3307/devdb'
);

for ($i = 0; $i <= 30000; $i++) {
    $connection->query('SELECT 2')->then(
        fn(QueryResult $result) => 5,
        fn(Exception $ex) => 1
    );
}

Loop::addPeriodicTimer(3, async(static function () use ($connection) {
    var_dump(getMemory(), $connection->pending);
}));

Loop::addPeriodicTimer(10, async(static function () {
    var_dump([
        'gc_collect_cycles' => gc_collect_cycles(),
        'gc_mem_caches' => gc_mem_caches()
    ]);
}));

In the code above, I simply created a DB connection and tried to spawn many queries in "fire and forget" style. Every 3 seconds, I'm checking memory consumption alongside with pending queries counter.
Memory dump as soon as queries finish:
string(22) "Used Memory : 57.33 MB"
string(25) "Used Real Memory : 706 MB"
string(30) "Used Real Peak Memory : 706 MB"

Memory dump after gc_collect_cycles and gc_mem_caches are fired:
string(22) "Used Memory : 9.06 MB"
string(25) "Used Real Memory : 604 MB"
string(30) "Used Real Peak Memory : 706 MB"

Used memory is fine, but reserved memory (used real memory) won't be freed. I can fire another 30k queries, and it will work within already reserved memory, but running i.e. 40k queries will increase reserved memory infinitely and so on. I've a feeling that there is some pointer on the loop which keep references to fibers, but I've no idea how to validate that idea.
I even tried to unset whole connection variable and set it to null, but it didn't change a thing :(
In simple words, I don't really understand why, would be very grateful for an explanation.

Hey @maciejfikus, thanks for bringing this up :+1:
Based on my knowledge, PHP requires a certain amount of memory from your system and the amount depends on how quickly the used memory increases. Your system tries to be clever by predicting how much memory you'll need, depending on how aggressively you're using it. Even after an operation finishes, the reserved memory doesn't immediately drop in case it's needed again at a later time. It's beneficial to avoid constant communication between PHP and your system to determine the required memory, as this saves time and improves overall performance. It's difficult for me to estimate the specific amount of memory your system would need, so I can't confirm if these numbers are accurate or not.

[…] but running i.e. 40k queries will increase reserved memory infinitely and so on.

Using 40k queries might make the system allocate even more memory to PHP as your operations might surpass the reserved memory. I can't really see the memory growing infinite in your examples above, but I could understand the behavior of giving out more memory for more operations.
We're currently not aware of any memory leaks in this project and taken from your input above, I'm not quite convinced that this could be a memory issue related to ReactPHP.  I'll go ahead and close this ticket for now, but we can reopen this if you can proof that ReactPHP or the friends-of-reactphp/mysql project is causing memory issues. If you do need to reopen the ticket, please provide some information about the steps you've taken so far, what worked and what didn't.


--tmpfs defaults are not compatible with docker

/kind bug
The --tmpfs option (and probably --mount too) defaults to 64MB of space, vs docker's default size is unlimited according to this documentation of tmpfs-size.
In addition, Docker's --tmpfs doesn't allow any options, but podman's has several. I'm not too concerned about this one though since the tmpfs syntax for podman is a superset of Docker's.
Output of podman version:
podman version 1.4.4

@ashley-cui PTAL, just change the --tmpfs to not be confined to 64k.

Or @computator if you want to take a stab at fixing it.  PRs welcome...

@ashley-cui PTAL, just change the --tmpfs to not be confined to 64k.

@rhatdan should I just remove the default value for --tmpfs? How would I test this?

@rhatdan When the --tmpfs flag is used in docker, no defaults are set. However, in podman, it automatically sets various defaults:
$docker create --name test --tmpfs /a alpine
docker inspect test
...
"Tmpfs": {
    "/a": ""
}

$podman create --name test --tmpfs /a alpine
podman inspect test
...
"Tmpfs": {
                "/a": "noexec,nosuid,nodev,rw,size=65536k,rprivate,tmpcopyup"
            }

Should this also be fixed? I'm not really sure where the size and other defaults are used later, so I'm wary of how to manipulate it.

Related: #3803
We set these defaults largely for security. I think that 65MB is a safe default that can be increased if required.

I would remove the 65mb, since this is still controlled by the cgroup.  The tmpfs space is < 50% of all available Memory for all tmpfs in the contianer (Memory cgroup).
The other flags should stay.  I don't see a problem with nodev, nosuid.  Perhaps we should eliminate noexec.


Review subheading search regularExpression & debug as necessary in buildTOC.js

        (/^\([^/(\([^]{4,}\)/.test(paraText)) {  // TODO: Uh, this doesn't seem like it should work, now that I'm looking at it again. Maybe I'm wrong?

https://github.com/mOrsExtension/mOrs/blob/0101a4009008436a0b82b87a12a48a04f58e5a49/content/buildTOC.js#L52

Closing as reviewed & tested successfully.


[API] Add "before" query to ListIssueComments and ListRepoIssueComments

as title

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e4dc647). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #9685   +/-   ##
=========================================
  Coverage          ?   42.27%
=========================================
  Files             ?      587
  Lines             ?    78006
  Branches          ?        0
=========================================
  Hits              ?    32975
  Misses            ?    40990
  Partials          ?     4041

Impacted Files
Coverage Δ

modules/context/context.go
55.45% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4dc647...80df43c. Read the comment docs.

It's betterto add some tests.

@lunny done

@gary-kim are you ok with this PR now ;)


Add guidance on error message visually hidden text

Do not merge until the Design System has been updated to GOV.UK Frontend 2.8.0.

You can preview this change here:
Built with commit 71d86c76cb5be6eec2c8386efda45219b670d569
https://deploy-preview-814--govuk-design-system-preview.netlify.com

@amyhupe I've updated the PR based on your suggestions. When you get a mo, can you re-review? Thanks!

@amyhupe I'm going to resolve your comments as Ollie has updated the content with your suggested changes. This looks great.

@nickcolley I think this is good to go now.


Allow to resize preview sidebar

The preview area is currently always ~300px wide, which is not a lot of space. It should be possible to make this  bigger while still keeping the graph/code in view.

We have the "maximize" button for this.


Add support for dictionary and list types in cmd line params

There's no need to write scripts just because of these anymore, command line examples (note the escaping of quotes):
aiopylgtvcommand <IP_ADDRESS> set_current_picture_settings "{\"backlight\": 0, \"contrast\": 65}"
aiopylgtvcommand <IP_ADDRESS> launch_app_with_params com.webos.app.softwareupdate "{\"mode\": \"user\", \"flagUpdate\": true}"
aiopylgtvcommand <IP_ADDRESS> get_picture_settings "[\"contrast\", \"backlight\"]"
# Launch In-Start Service Menu (code: 0413) (using JSON)
aiopylgtvcommand <IP_ADDRESS> launch_app_with_params com.webos.app.factorywin "{\"id\": \"executeFactory\", \"irKey\": \"inStart\"}"
# Launch Ez-Adjust Service Menu (code: 0413) (using JSON)
aiopylgtvcommand <IP_ADDRESS> launch_app_with_params com.webos.app.factorywin "{\"id\": \"executeFactory\", \"irKey\": \"ezAdjust\"}"

This can work in bash on Linux (but not in cmd on Windows):
aiopylgtvcommand <IP_ADDRESS> set_current_picture_settings '{"backlight": 0, "contrast": 65}'
aiopylgtvcommand <IP_ADDRESS> launch_app_with_params com.webos.app.softwareupdate '{"mode": "user", "flagUpdate": true}'
aiopylgtvcommand <IP_ADDRESS> get_picture_settings '["contrast", "backlight"]'
aiopylgtvcommand <IP_ADDRESS> launch_app_with_params com.webos.app.factorywin '{"id": "executeFactory", "irKey": "inStart"}'
aiopylgtvcommand <IP_ADDRESS> launch_app_with_params com.webos.app.factorywin '{"id": "executeFactory", "irKey": "ezAdjust"}'

Relates to: https://github.com/bendavid/aiopylgtv/issues/30#issuecomment-870477410

I also figured it out (after decompiling a C8 and CX firmwares with epk2extract) how to launch In-Start and EZAdjust Service Menus, I added to the examples above.


Update WaveTensor delegates.json

Verified True
Validator information: {"5DCc5oHA6c1Lpt9R6T1xU8jJGTMvvwBqD1yGX67sL8dHUcga": {"name": "WaveTensor", "url": "https://twitter.com/wavetensor", "description": "A new Wave is coming, join the AI revolution on top of Bittensor by staking with us."}} Validator signature: 5e072b4752ccbdd4ca3298f336284dfdab347dd133850f4d2f9873e7ea59bd2a8f201732842ec79d2bab3abaf133a06b6bd992940389e42d57802c9b8f855889

Verified
Validator information: {"5DCc5oHA6c1Lpt9R6T1xU8jJGTMvvwBqD1yGX67sL8dHUcga": {"name": "WaveTensor", "url": "https://twitter.com/wavetensor", "description": "A new Wave is coming, join the AI revolution on top of Bittensor by staking with us."}}
Validator signature: 5e072b4752ccbdd4ca3298f336284dfdab347dd133850f4d2f9873e7ea59bd2a8f201732842ec79d2bab3abaf133a06b6bd992940389e42d57802c9b8f855889
5DCc5oHA6c1Lpt9R6T1xU8jJGTMvvwBqD1yGX67sL8dHUcga
Verified True


Villager House Placement

Moving villager houses causes the game to crash on load.

In which game?

@Theohhno Does this still happen?

Closing this due to no reply. If you have any info, make a new issue @Theohhno


_gdfnetcdf.py - NetCDF - Set dimension issue

Dear Team,
I found an issue in the 'set_dimension' function in _gdfnetcdf.py:
I replaced
            dimension_index_vector = np.around(np.arange(dimension_min, dimension_max, element_size), self.decimal_places)

by
            dimension_index_vector = np.around(np.linspace(dimension_min, dimension_max, dimension_config['dimension_elements']), self.decimal_places)

because when using a non-integer step, such as 0.25, the results is often not be consistent. (the number of elements doesn't match the expected one, e.g. 1001 instead 1000).
It is better to use linspace for these cases.
Kind regards,
Didier

Closing. GDF has been deprecated.


Add Real Estate website

#148

I make it using js html and css
On Sun, 28 Jan 2024, 10:40 pm Kritika Gupta, @.***>
wrote:

is it in mern?
If yes show its working through video
—
Reply to this email directly, view it on GitHub
https://github.com/Kritika30032002/ReactCreations/pull/222#issuecomment-1913663629,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZAZIZVE6OTRB5Y7XGB6SRLYQ2A73AVCNFSM6AAAAABCOHG5QCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGY3DGNRSHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

update readme


Multiple Tables Expand Issue

Hi
I have an issue with the expand icon for multiple tables. I followed your multiple tables examples and both tables work just fine.. Except one table The row expands then contracts quickly. You can see the problem here:
http://petenstein.com/fitbiz247/fitbiz.php
Click on the Transactions Tab, use a mobile, tablet or contract the screen. Click the expand icon and the row expands then contracts really quickly.
I'm sure I'm missing something really obvious but can't see it. Any help or advice would be greatly appreciated.
The other table is in the Tests tab btw.
Thanks.

Seems like I have figured out my problem. Bit hasty to post. Please disregard.


Cow: Watch probaltistani.com

Cow requests the watch of the watch_keyword probaltistani\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

probaltistani\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


feat: return iterable on @ selector

Do not merge
This PR is only for testing purposes

close due to #239


Improve grammar and wording in 'Mapping Symbol' section

@asb @topperc @kito-cheng
Could you review this PR?

@jrtc27 could you help on review this?


Implement suggestion from Nico Roeser to press@

full text of the suggestion
The text version <https://www.apache.org/licenses/LICENSE-2.0.txt> and the HTML presentation <https://www.apache.org/licenses/LICENSE-2.0> of the Apache License, Version 2.0 have a difference in markup which I feel should be remedied. (I am aware that it’s the _text_ what counts, not indentation and such – still there is room for improvement.)

Section “4. Redistribution.” contains a list with four items/paragraphs, followed by a further paragraph, which says “You may add Your own copyright statement […]”. This text about the copyright statement is not part of the list in the text version of the license; instead, it follows the list. In the HTML document, the text has been made part of the fourth list item. This is semantically incorrect: it talks about redistribution (i.e., belongs to section 4. of course), but is not a condition for redistribution – and particularly is not related to the “NOTICE” text file.

My suggestion: remove the br elements separating the “NOTICE” text from the text about adding copyright statements, move the latter out of the ol element, and put the text in a p element after the closing ol tag. Do you agree?

This will improve the HTML presentation of the license, and make it more closely resemble the text version (which developers and many users consider canonical, even though it maybe does not matter).

cc @nicoroeser

Thanks, @dims and Nico


look forward to the modified ImmortalTracker

look forward to the modified ImmortalTracker，thanks！

+1

Thanks for your attention, we release the tailored ImmortalTracker here: https://github.com/Abyssaledge/ImmortalTracker-for-CTRL
@dof-pikes @20210726

@Abyssaledge  Thanks！！


Test and improve Back-propagation convergence.

This pertains to the Backpropagation class used by the FeedForwardNetwork[D] to learn its network weights. A good reference is pages 10-12 of Andrew Ng's notes on autoencoders. What we require is iterative calculation of the derivative checking procedure outlined in those pages. The required changes must be made to the Backpropagation class.

Made improvements in commit 3b9fc1ff31f1cbe7d8535fcc3806dd8683c260a2


Add method to cleanup entries that'll never run

When this package is used in a service, it's useful to be able to remove
jobs that are not required anymore.
Since the package does not provide a way to remove a specific entry,
this change adds a method to remove entries that'll never get run in
future.  With this change Schedule implementations can return a
zero-time from Next(), and such entries can be removed from Cron.

Very nice!
@robfig Are-you alive? 🍺

Any news on this thread?
@robfig

Hi, sorry for the long silence -- master/v3 does have the ability to Remove jobs, so I think it handles that use case. Regardless, rather than having a Cleanup function that the user has to call, I can't think of a reason that it can't just always remove any jobs that return a zero time, since they will never be scheduled again. That would be ok, but I imagine that the moment has passed.


go get

go version 1.12.7
OS macOS  10.14
error: can't load  github.com/google/tink/go/keyset
build github.com/tsingson/vk/test-example/tinktest: cannot load github.com/google/tink/go/keyset: cannot find module providing package github.com/google/tink/go/keyset

@tl0gic could you please take a look? This is similar to https://github.com/google/tink/issues/215#issuecomment-514360901.

Can you give me an example repository and the commands you typed so I can reproduce it?
When I try locally to fetch all the go modules I can't get the error you mentioned above.

Also which version of tink are you using? master or one of the releases?

When you go build in a project using modules, it's writing github.com/google/tink v1.2.2 into go.mod. That fails with the error above. If you modify go.mod to reference github.com/google/tink v1.3.0-rc1 it'll build.

@ericbock  cool, it's work.  great job.


asgi and improve multi db

Changes:

add asgi, async contextmanager integration which connects/disconnects all databases of a registry (they are refcounting so there is no issue)
allow creating, dropping multiple dbs
unified using
update docs

Just spelling, basically and formatting. The rest, good job 👍🏼


fix: add monitoring namespace and resources for gke metrics

Closes #328  (take 3)
Since we are using GKE Workload Identity we must complete the following steps outlined in
Implementing Policy Controller Metrics to implement Policy Controller Metrics and avoid numerous IAM errors on the Config Controller instance.
Includes:
Monitoring namespace
Service account for the Metric Writer permission (roles/monitoring.metricWriter)
Binding for workload identity (serviceAccount:management-project-id.svc.id.goog[gatekeeper-system/gatekeeper-admin])
The gatekeeper-admin service account will need to be annotated post-deployment using the following command:
kubectl annotate serviceaccount gatekeeper-admin
--namespace gatekeeper-system
<EMAIL_ADDRESS>

I am not sure why it added a file when I renamed it.


Support . (dots) in filenames

My naming convention uses dots in filenames, e.g. layout.module.ts or admin.controller.ts. When attempting to import such files using ES6 imports, the browser ends up requesting layout.module (without the .ts extension), which obviously ends up with a 404.
This seems like a bug in plugin-typescript, as the correct URLs are requested if using regular .js-files instead of typescript files.
You can verify this issue by renaming the example-controller.ts and example-service.ts to example.controller.ts and example.service.ts in your example.

Unfortunately this is a limitation in SystemJS, see https://github.com/frankwallis/plugin-typescript/issues/33.
You can use import "layout.module.ts" but then TypeScript throws an error when type-checking the code (the code will still run ok though). Once https://github.com/Microsoft/TypeScript/issues/2338 has been addressed in TypeScript 1.6, I can change the CompilerHost to use the same resolution logic as SystemJS and this error will go away.


Facebook provider access_token parse error

Facebook 2.3 API response with JSON, not url encoded params.

Thanks for pointing that out. Some notes for me:
https://developers.facebook.com/docs/apps/versions
https://developers.facebook.com/docs/facebook-login/access-tokens


[Bug] Tooltip Formatter - Map chart - data parameter is undefined....

Version
5.5.0
Link to Minimal Reproduction
https://echarts.apache.org/examples/en/editor.html?c=map-usa
Steps to Reproduce
1- i'm trying to display a map chart based on this example https://echarts.apache.org/examples/en/editor.html?c=map-usa
2- i created a valid  GeoJSON file from this link  https://geojson-maps.kyd.au/
3- my chart Options Object is related file in attachment mapOptions.js
4- The problem is very simple.  for tooltip , i choosed formatter function because i want a customized tooltip. formatter function has "params" as parameter. but "params.data" return UNDEFINED.. i don t understand what is wrong in my mapOptions structure.  can you help me to understand. if series data is not well structured??
mapOptions.txt
Current Behavior
params.data = undefined

Expected Behavior
i expected to have params.data = [{value: ..., flagStatus:..., code:....}, {value: ..., flagStatus:..., code:....}]
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

series-map.data supports two main attributes - name and value. See the official example you referenced.
Just by renaming each country's "data" attribute to "value", you'll get what you want in tooltip formatter Demo.


chore: Update from _rust/main template

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.05%) to 29.428%

Files with Coverage Reduction
New Missed Lines
%

src/graph/branch.rs
1
61.09%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
1645

Relevant Lines:
5590

💛  - Coveralls


chore: vulnerability fix

Signed-off-by: nitish<EMAIL_ADDRESS>PR summary
updating ibm core SDK to latest and readme update
Fixes:

https://github.ibm.com/Notification-Hub/planning/issues/11939
https://github.ibm.com/Notification-Hub/planning/issues/12129

PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Go Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[x] Documentation content changes
[ ] Other (please describe)

What is the current behavior?
As part of OSS, it was found that IBM Core SDK, version 5.13.1 has a dependency on a GPL licensed package.
The latest version of IBM Core SDK does not have this dependency.
What is the new behavior?
updating core SDK to the latest and updated readme
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 0.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Integration gateway route not showing correct filters

Version
22.9.6
Issue

Expected behaviour
Show the correct filters for the selected method

Fixed:

How: By adding a spinner to the integration gateway filter table, so that it is properly refreshed when fetched

Tested and confirming that this is now resolved. Also CL entry has been added so moving the card to Done.


tests: subsys: settings: functional: fcb: system.settings.functional.fcb fails

Describe the bug
The tests/subsys/settings/functional/fcb/system.settings.functional.fcb fails
Observed for

nrf52840dk_nrf52840
nrf52dk_nrf52832

To Reproduce
Steps to reproduce the behavior:

have nrf52840dk_nrf52840 connected
go to your zephyr dir
call ./scripts/twister -T tests/subsys/settings/functional/fcb -p nrf52840dk_nrf52840 --device-testing --device-serial /dev/ttyACM0 -v --inline-logs
See console output with error

Expected behavior
Valid console output
Impact
Not clear
Logs and console output
[2022-08-11T22:11:39.153Z] PROJEng Zephyr OS build zephyr-v3.1.0-3361-gb076aa373a63  ***
[2022-08-11T22:11:39.153Z] Running TESTSUITE settings_test_suite
[2022-08-11T22:11:39.153Z] ===================================================================
[2022-08-11T22:11:39.153Z] START - test_clear_settings
[2022-08-11T22:11:39.153Z] PASS - test_clear_settings in 1.350 seconds
[2022-08-11T22:11:39.153Z] ===================================================================
[2022-08-11T22:11:39.153Z] START - test_support_rtn
[2022-08-11T22:11:39.153Z] PASS - test_support_rtn in 0.1 seconds
[2022-08-11T22:11:39.154Z] ===================================================================
[2022-08-11T22:11:39.154Z] START - test_register_and_loading
[2022-08-11T22:11:39.154Z] PASS - test_register_and_loading in 0.5 seconds
[2022-08-11T22:11:39.154Z] ===================================================================
[2022-08-11T22:11:39.154Z] START - test_direct_loading
[2022-08-11T22:11:39.154Z] PASS - test_direct_loading in 0.6 seconds
[2022-08-11T22:11:39.154Z] ===================================================================
[2022-08-11T22:11:39.154Z] START - test_direct_loading_filter
[2022-08-11T22:11:39.154Z] -- Called: val/1
[2022-08-11T22:11:39.154Z] -- Called: val/2
[2022-08-11T22:11:39.154Z] -- Called: val/3
[2022-08-11T22:11:39.154Z] -- Called: val/4
[2022-08-11T22:11:39.154Z] -- Called: val/1
[2022-08-11T22:11:39.154Z] -- Called: val/2
[2022-08-11T22:11:39.154Z] -- Called: val/3
[2022-08-11T22:11:39.154Z] -- Called: val/4
[2022-08-11T22:11:39.154Z] PASS - test_direct_loading_filter in 0.67 seconds
[2022-08-11T22:11:39.154Z] ===================================================================
[2022-08-11T22:11:39.154Z] START - test_setting_storage_get
[2022-08-11T22:11:39.154Z] Assertion failed at ../../../../../../../../../../zephyr/zephyr/tests/subsys/settings/functional/fcb/settings_test_fcb.c:24: test_setting_storage_get: (rc not equal to 0)
[2022-08-11T22:11:39.154Z] Can't read fcb (err=-134)
[2022-08-11T22:11:39.154Z] FAIL - test_setting_storage_get in 0.18 seconds
[2022-08-11T22:11:39.154Z] ===================================================================
[2022-08-11T22:11:39.154Z] TESTSUITE settings_test_suite failed.
[2022-08-11T22:11:39.154Z] ===================================================================
[2022-08-11T22:11:39.154Z] RunID: 42a03f6fdba8863acccdd0a2dec76168
[2022-08-11T22:11:39.154Z] PROJECT EXECUTION FAILED

Environment (please complete the following information):

OS: Ubuntu 20.04.1 LTS
Toolchain Zephyr SDK 0.14.1
Commit SHA or Version used: v3.1.0-3361-gb076aa373a63

These tests are passing currently (zephyr-v3.1.0-5182-g85445474f29e)


Issue with Scrolling while the item is selected for dragging.

Id just like to say that this package is awesome! It has saved me a load of time.
When i click an item and move it as it to reorder the list, i cannot scroll. This is a issue if you have a very long list and need to move an element from the top to the bottom and vice versa!
do you know of a way to fix this?
Thanks!

Thank you!
Perhaps, you can try the dragover callback.

@hejianxian Can you provide an example?

Hello,
Is there any updated on this @hejianxian ?
Thanks!

@hejianxian do you have a update on this?


Support for Webpack 3

Updated to Webpack 3 and got this:
warning<EMAIL_ADDRESS>has incorrect peer dependency "webpack@^2 || ^2.2.0-rc.0 || ^2.1.0-beta.0 || ^1.13.2".

@alexilyaev thanks for pointing this out, I need to publish a patch. Will try to do so tonight!

+<EMAIL_ADDRESS>published! 👍


Less of an issue... more of a how can I...

Is there an official DigitialOcean Firewall API doc?
Instead of whitelisting an IP, I would like to be able to blacklist an ip and remove a blacklisted ip.
Is that documented anywhere?

jack

They do have firewall api documentation, but they don't support blacklisting ips.
If you have to blacklist bots or things like that from your website I suggest using Cloudflare, which has both whitelist and blacklist capabilities.

Ok, thanks. I don't think I need cloudflare level stuff.. just thought it would be nice to use an api to block a few ip addresses. I can use firewall-cmd with linux but was hoping to offload that to DO.
Thanks for the info.

jackl


How can we change the video buffering color / style?

As shown in the image below

this is your theme's default progress indicator color.

use bufferingBuilder


Add the target branch 8.0.0-rc

Questions
Answers

Description?
Add the target branch 8.0.0-rc

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
no

How to test?
/

Possible impacts?
no

Thanks @khouloudbelguith


Update kubectl version

Running with kubectl v1.4.0 failed to delete pods.
The problem was solved by updating to v1.8.0 and rebuilding the image.

Thanks!


add_X.txt

@eva-toledano you should not send pull requests from your main branch (this lets ME push on YOUR main branch, which you do not want) but in the interest of time I'll merge this anyways


scripts: add script to generate release notes

It creates a release note with the following format:
Release
Description (need to be manually edited)
Closed issues (count):
issue 1
issue 2
Open issues (count):
issue 1
issue 2
Commits (count):
commit 1
commit 2
For now, it requires my fork of git-hub (some new options):
https://github.com/bdilly/git-hub
Signed-off-by: Bruno Dilly<EMAIL_ADDRESS>

merged


Change logging during e2e tests

There are a lot of log lines coming from Kafka clients, that
are unnecessary. This PR sets the logging level for our
loggers to DEBUG and keep all others to INFO.
Proposed Changes

Change logging during e2e tests

Waaaay better :smile:

/lgtm


Fishing Timer incorrect bait detection

During Ocean Fishing, especially on zone changes, sometimes the change bait detection fails to work. I propose to use a similar solution as in: https://github.com/quisquous/cactbot/pull/1106
This means: Updating currently used bait on every cast instead of when the user changes bait.

I'm going to mark this fixed, as per #1106.

This issue should not be closed as #1106 only addresses the fishing spot/place. It does not solve the issue that is described here, namely the incorrect bait.

Not planning to make any more fishing changes.


Add LGTM code quality badges

Hi there!
I thought you might be interested in adding these code quality badges to your project. They will indicate a good code quality to potential users and contributors.
To get an idea of the analyses reflected by these grades, check the alerts discovered by LGTM.
N.B.: I am on the team behind LGTM.com, I'd appreciate your feedback on this initiative, whether you're interested or not, if you find time to drop me a line. Thanks.

Here's my feedback:

What is the purpose on integrating such service in GitHub? I don't use GitHub to write code, I use IntelliJ IDEA instead and want code quality inspections there.
Is there any way to suppress inspections in places where I'm sure on what I'm doing?
'Implicit cast of source type long to narrower destination type int.' reported. But this was my intention to get 'int' and widen it to 'long' type, according to Java spec.
MetaprogrammingClassLoader.java:46 is wrongly reported. BufferedInputStream wraps actual native stream, which may hold native resources and which is correctly closed by try-with-resources block.

Hi @konsoletyper
Thank a lot for the feedback!

What is the purpose on integrating such service in GitHub? I don't use GitHub to write code, I use IntelliJ IDEA instead and want code quality inspections there

Most code inspections are pretty fast and should then happen at the earliest time possible, when writing code, in your IDE, I agree. But most analysis done by LGTM are quite deeper than these simple code linters. They use control flow and tainting mechanisms that require time and memory, and these analysis cannot happen in your IDE, it would slow you down instead of helping you. We think that given the time taken by these analysis, the pull request / code review is the most appropriate place to run them. Look at examples of such queries on the blog, for example this one. Our queries are open sourced at https://github.com/Semmle/ql

Is there any way to suppress inspections in places where I'm sure on what I'm doing?

Sure. By putting a //lgtm in your code, as explained here. You will have also this information by clicking on the icon with the crossed eye at the right of the alert (red rectangle).

'Implicit cast of source type long to narrower destination type int.' reported. But this was my intention to get 'int' and widen it to 'long' type, according to Java spec.

hmmm ... the alert here just says that pos += amount will implicitly narrow long amount to int, possibly losing information. But in your case,  you know that amount will always be an int. So right, you might want to either suppress this alert (severity = warning, btw) because you know what you're doing here, or you can widen pos and count to long, to be consistent with what you did with amount.

MetaprogrammingClassLoader.java:46 is wrongly reported. BufferedInputStream wraps actual native stream, which may hold native resources and which is correctly closed by try-with-resources block

With a quick look, the InputStream input will be indeed closed in case of error thanks to the try-with-resources, but the BufferedInputStream will not, don't you agree? I will ask my Java experts to have a closer look.
Cheers, thanks again for the feedback.

@xcorail , can your tool's analyses be performed offline, from the IDE or as part of a local build, or can they only be run via your service remotely against a public repo?  Tools that can't be run locally aren't very developer-friendly since the build can break unexpectedly after a commit.

Hi @ScraM-Team
As I said in my previous answer, the analysis we perform are very expensive in terms of time and memory, and do not easily fit at commit time in a developer workflow. It would slow down instead of helping. You can make an analogy with unit tests, fast enough so that you can run them at build time, and more expensive integration or end to end tests, that you will launch only nightly or at pull request time: You are launching simple syntactic analysis in your IDE, simple linters at build or commit time, but you will launch the LGTM deep analysis at a later stage.
However, technically yes, the tool can be launched offline, with our QL for eclipse plugin. But the intended usage is rather when you are working on one particular problem and you want to explore variants of this problem in your code, but not launching all the queries set, as this would consume all your resources and take too much time.
Hope this makes sense.


Add annotation summary to MorphService

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #664   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          43     43
  Lines        2197   2191    -6
=====================================
- Hits         2197   2191    -6


nsc-events-nextjs_sprint14_#584_updating-minor-dependencies

I made some fixes and minor dependency updates. This will include the most recent patch dependencies changes with minor dependencies updates

carets in package.json has been deleted. Thank you for the suggestion guys.


Organization for Tables/Views/Pages

Is your feature request related to a problem? Please describe.
I have a TON of tables, views, and pages in my instance.
Describe the solution you'd like
It would be great if there was some way to create a hierarchical view of these tables/views/pages so that Instead of constantly scrolling through a long list of tables/views/pages, I could group related tables together to deal with fewer at a time.
Describe alternatives you've considered
I'm not sure of any alternative available except to scroll through the list each time.

The plan here is to use tags. You can already set them but it is not exposed in the tables/views/pages lists and not easy to use. This is definitely on the roadmap for soon.

I would put in my vote for this feature. Also, why not move the 'create new' button to the top of the page, so the user doesn't have to scroll down through the whole list?

#2275 brings some of this, please let me know if this improves the situation and if you have any suggestions to build on top of this. You now have tags in the lists of tables, views, pages and triggers, with a quick link to manage tags in the dropdown opened by clicking the "tags" header in the lists. This is also where you filter.
This is not yet in an npm release but is deployed on saltcorn.com so you can test there.

I was able to download it to my Docker instance and it looks good. Very intuitive, once I get past figuring out that I need to click "Tags" in order to click "Manage Tags" in order to get it going. (My fault, I only partially read your comment)
One thing I would request, if possible, would be the ability to expand the scroll box for adding tables/etc to a tag. 4.5 lines feels very narrow.