905 - Provide index offence

Adds convictionId, eventNumber and offenceId properties to the create application endpoint.
The FE can retrieve these from the get active offences endpoint then pass back the correct one when creating the application.

 Select index offence (if there is > 1 active conviction)


JavaKit: Rework @ImplementsJava to be more like @implements language feature

The @ImplementsJava macro had an odd formulation where it was used similarly to @JavaMethod, but was actually interpreted by the outer @JavaClass macro. Completely rework the way @ImplementsJava is used to make it more like the @implements feature introduced in SE-0436, and rename it to @JavaImplementation to more closely match the canonical spelling for @implementation with a language and make use of the @Java... as a common prefix.
In this new design, one places @JavaImplementation on an extension of the Swift type, conforms to the corresponding protocol, and marks the implementing methods with @JavaMethod. For example:
@JavaImplementation("org.swift.javakit.HelloSwift")
extension Hello: HelloNativeMethods {
  @JavaMethod
  func reportStatistics(_ meaning: String, _ numbers: [Double]) -> String {
    let average = numbers.isEmpty ? 0.0 : numbers.reduce(0.0) { $0 + $1 } / Double(numbers.count)
    return "Average of \(meaning) is \(average)"
  }
}

This also means that we can generate most of the @JavaClass definition for a given Java class, and leave the native methods to be implemented by an @JavaImplementation extension. The NativeMethods protocol provides declarations for all of the native methods that are expected to be implemented in Swift, making it easier to get all of
the signatures right.
Update the JavaKitSampleApp to use the Java compilation plugin to compile the Java files in the target. Automatically feed those into the Java2Swift plugin to generate the Swift representations of the Java classes, skipping the native methods (since they'll be implemented here).
The user guide / tutorial is a bit behind the implementation here as I smooth out more corners.

We can figure out what the problem with necessitating public was here, it should not be a requirement for native AFAIR

Yeah, I think I know the problem here. See https://github.com/swiftlang/swift-java/issues/106

https://github.com/swiftlang/swift-java/pull/105/commits/e87c3bf56e81850cdb6b312812924fd84deac7e3 addressed the crash in the tests that were causing me trouble on Linux. I suspect the development toolchain might be miscompiling closure captures of parameter packs in some cases.


Pasting in "Rename Tab" also pastes in the shell

Windows Terminal version
1.15.2875.0
Windows build number
10.0.22621.0
Other Software
No response
Steps to reproduce

put some text on the clipboard
do Rename Tab and paste the text from the clipboard

Expected Behavior
The tab is renamed and the state of the shell is unaffected.
Actual Behavior
The tab is renamed, but the text is also pasted in the shell.

HA! HAHAH! Sorry, knowing how our event handlers are structured I am not surprised at all. Sorry about the bug. :smile:

I would like to work on that issue.

You're more than welcome to! THanks!


[FEATURE] required vars

Just like with Terraform it would be nice to be able to set required vars:
variable foo {}

In yaml that would be an empty key:
---
foo:

This would make it easier to force a user setting a dynamic var like version

So in this case it would mean a user would need to input the variable by typing on the CLI?

Yeah either prompt or (in my case better) fail with a log message. We run Levant from CI so failing instead of waiting for user input would be nice.
Terraform has:
-input=true - Ask for input for variables if not directly set.


[1pt] - Create Item class - Group Task

Create an Item class in a separate .rb file.
Set up all Item class properties visible in the diagram in the constructor method:

id
publish_date
archived

Add setter methods for the relationship properties: genre, author, label, and source.

Hi @HFG43 I kindly ask you to review my PR: https://github.com/NitBravoA92/catalog-of-my-things/pull/38


I am getting the below error  I have connect my laravel script with mongodb  (1/1) ErrorException Trying to get property 'headers' of non-object  in VerifyCsrfToken.php line 158 at HandleExceptions->handleError(8, 'Trying to get property 'headers' of non-object',

I am getting the below error
I have connect my laravel script with mongodb
(1/1) ErrorException Trying to get property 'headers' of non-object
in VerifyCsrfToken.php line 158 at HandleExceptions->handleError(8, 'Trying to get property 'headers' of non-object',

Duplicate of #1514


"Library e_sqlite3 not found" on net472, but works on netcoreapp3.1

Given the most trivial netstandard2.0 library that consumes SQLitePCLRaw.bundle_green 2.0.4, that is then brought in by a unit test project that targets both netcoreapp3.1 and net472, we see the net472 one uniquely fails with this error:

Library e_sqlite3 not found

Yet looking at the bin directory for each target, we see both net472 and netcoreapp3.1 has e_sqlite3 in the directory alongside the test assembly.
What do I need to do so that net472 can find the native binary?
Minimal repro: SqliteTest.zip

Unit test projects with .NET framework are always troublesome.
If you're talking about xunit, try adding an xunit.runner.json file that contains:
{
   "shadowCopy": false
}

That's a good idea, but that didn't solve the problem. I checked the debugger to confirm the managed dll was loaded from its original location and that looked good.
Since you mentioned thinking it was test project related, I added a console app to my solution. It has exactly the same problem.
Here is my updated solution:
SqliteTest.zip

Every release of SQLitePCLRaw is tested on net472 as part of the build process.
For example, here is one of the test programs I use.  It should work for you as well:
csproj:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net472</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="sqlitepclraw.bundle_e_sqlite3" Version="2.0.4" />
    <PackageReference Include="sqlitepclraw.ugly" Version="2.0.4" />
  </ItemGroup>

</Project>

cs:
using System;
using SQLitePCL.Ugly;

namespace smoke
{
    class Program
    {
        static void Main(string[] args)
        {
            SQLitePCL.Batteries_V2.Init();
            using (var db = ugly.open(":memory:"))
            {
                var s = db.query_scalar<string>("SELECT sqlite_version()");
                Console.WriteLine("{0}", s);
            }
        }
    }
}

I took a glance at your zip file.  I'm not 100% sure what is different, but it might be the need to add the SQLitePCLRaw bundle package to the top-level console app instead of to the library.

Ok, I see what's going on. Your sqlitepclraw.lib.e_sqlite3 package includes an msbuild import file that copies the e_sqlite3.dll file in several architectures a few directory levels deep into the output directory. So a top-level package reference in the console project or (preferably) a PrivateAssets="none" attribute added to the netstandard2.0 projects existing PackageReference fixes the problem, for both the console and test projects.
Now here's a potential opportunity to improve the packages though, because nuget is supposed to solve this for us, and this is why in my test and console projects I had these two extra properties:
    <RuntimeIdentifiers>win-x86;win-x64</RuntimeIdentifiers>
    <RuntimeIdentifier>win-x86</RuntimeIdentifier>

This allows my project to target either of two architectures, and because your nuget package correctly follows the runtimes folder pattern, the build would automatically place the appropriate native dll based on the architecture I am targeting at the time.
But the odd thing (which led to me filing this bug) was that although the native binary was placed, your managed code couldn't find it. Do you have managed code that explicitly looks for the binary in that runtimes folder structure that your SQLitePCLRaw.lib.e_sqlite3.targets file copies them into? If so, would you also consider finding the dll in the same folder as the managed dll, since that is how .NET Framework, .NET Core, and nuget/msbuild are designed to work by default?

"since that is how .NET Framework, .NET Core, and nuget/msbuild are designed to work by default"
Are they?  Where is that explained?  That doesn't seem to be the way that .NET Core is designed to work by default.  In fact, the current approach is an attempt to have .NET Framework emulate the way I understood things to work for .NET Core.
I have also had use cases where people needed both native libs to be present so they could switch back and forth between 32 and 64 bit builds.  But that is a vague recollection from quite some time ago.  This may not be currently relevant.
Bottom line:  Your explanation sounds good, but this code has been in place for quite a few years, and I have learned to be very cautious of making an improvement which actually turns out to be a regression, especially in this particular area.

Sure! Here are some docs for your review:
This one talks about the nuget runtimes folder pattern which you are already conforming to.
But one point to glean from it is this paragraph:

Please note, NuGet always picks these compile or runtime assets from one folder so if there are some compatible assets from /ref then /lib will be ignored to add compile-time assemblies. Similarly, if there are some compatible assets from /runtimes then also /lib will be ignored for runtime.

Note that it talks about how NuGet picks files from one runtimes folder. You can see this in action by building the projects in my sample .zip.
Then if you look at dotnet build -r|--runtime parameter, you'll see how the build of even an "Any CPU" project can be built with either x86 or x64 binaries.
Folks building "any cpu" libraries will not need to specify a runtime architecture, and will not deploy your native binary. But an application (or test) project that references that library (by project or package reference) will need to choose an architecture (as they always must unless they are a .NET Core FDD in which case they have a runtime config file which also tells .NET where to find all native binaries.
You'll also notice that .NET Framework and .NET Core automatically load native binaries from p/invoke signatures, and that Windows itself (via LoadLibrary) will automatically find the native binary when it is directly in the app directory and/or side-by-side the requesting assembly. And the runtime deps json file created for .NET Core apps further even allows finding the right native binary in other locations.
All this is to say Microsoft has up and down the runtime and build tools stack endeavored to make it easy. Your specialized library loading code defeats this. Downsides include:

Extra msbuild imports are required, so in the simplest case of writing a library that consumes yours, the app that uses it will be broken till the lib author adds the missing attribute or the app adds an extra explicit dependency on yours.
Larger payload for an app that gets 3 copies of the native binary when each app only needs one.
Your msbuild import deploys native binaries based on the OS used to build the app instead of the OS that the app actually targets. This is probably the most serious defect. MSBuild and dotnet build are designed to allow targeting any OS from any OS.

I have also had use cases where people needed both native libs to be present so they could switch back and forth between 32 and 64 bit builds.

TBH, that actually works well for me too, since in fact I am building an (all dependencies included) extension for an app that may load my extension in either a 32-bit or 64-bit process. So I like that your library allows packing and loading multiple architectures. I just do not think that it should come at a cost of breaking the more common and Microsoft build chain-supported scenario.
At minimum, I think you should allow your native loader to find the native binary next to the managed assembly. That would un-break the intended scenario.
Next, if you modify your .targets file to only copy the native binary around under the condition '$(RuntimeIdentifier)' == '' then you can continue supporting your existing scenarios but will avoid all the downsides listed above when folks are trying to use the Microsoft-offered happy path.
Thoughts?

(Mostly content-free update)
So far I haven't actually taken the time to think hard about this issue.  That targets file (and pretty much anything else that applies to .NET Framework but not .NET Core) is an area of the code I try to avoid thinking about.
That said, here is what has been going through my brain:
Since I don't like thinking about this targets file, I usually rely on advice from people at Microsoft to tell me if I got it right.
The current approach was designed with lots of input from people at Microsoft who seemed awfully smart.  When that conversation ended, those people seemed happy with the result, so I haven't touched the targets file since then.
Now you have arrived, and you are also a person at Microsoft who seems awfully smart, and you're not happy.
Spock in Star Trek IV might wonder if this is a good time for a colorful metaphor.
That conversation with the previous round of awfully smart Microsofties was a long time ago.  Maybe something changed?
It looks like I'm going to have to turn my brain on and actually think about this issue.  But that's not happening until 2021.  ;-)

Maybe something changed?

I'd say that's likely, depending on how long ago we're talking about here. I can also ask a few MS folks to chime in here as well who are more direct area owners of the build toolset and runtimes so they can weigh in on my suggestions. Maybe some that I am thinking of are even among the set that helped you before.
Happy new year! 🥂

I also have experienced this dreaded Library e_sqlite3 not found exception in several occasions. Eric merged #364 recently which will at least ease diagnosing this error since all the searched paths will be included in the exception message.
I'm not sure if this applies to your scenario but I have figured out a way to never get this error by embedding the e_sqlite3.dll file into an executable with the help of Costura that I have documented on Stack Overflow: How to package a single-file executable using the SQLite EF Core Database Provider on .NET Framework?
That's a lot of work on the developer side but you can be 100% sure that the library will always load properly.
But all of this doesn't help with the issue at hand which is about not having ton of work to do. I'm not sure what's the best/correct way to fix this issue, but I'll just remind you of #252 which might be related.

I also have experienced this dreaded Library e_sqlite3 not found exception in several occasions. Eric merged #364 recently which will at least ease diagnosing this error since all the searched paths will be included in the exception message.
I'm not sure if this applies to your scenario but I have figured out a way to never get this error by embedding the e_sqlite3.dll file into an executable with the help of Costura that I have documented on Stack Overflow: How to package a single-file executable using the SQLite EF Core Database Provider on .NET Framework?
That's a lot of work on the developer side but you can be 100% sure that the library will always load properly.
But all of this doesn't help with the issue at hand which is about not having ton of work to do. I'm not sure what's the best/correct way to fix this issue, but I'll just remind you of #252 which might be related.

I finally got back to digging into this issue.  This involved re-learning some of my own code which I hadn't looked at in a while.
The suggestion above from @AArnott was to "allow your native loader to find the native binary next to the managed assembly" and add a condition to the targets file.
But I started wondering what benefit my native loader is actually providing.  See #419
So, as part of my exploration, I have implemented a more heavy-handed approach wherein (for .NET Framework) I eliminate my native loader (going back to dllimport) and remove the targets file.  After that, adding the RuntimeIdentifiers and RuntimeIdentifier props gets my test suite running again.

pre-release 2.0.5-pre20210521085756 has been pushed up to nuget, including the change described in #419 to default to use dllimport on .NET Framework.

Unit test projects with .NET framework are always troublesome.
If you're talking about xunit, try adding an xunit.runner.json file that contains:
{
   "shadowCopy": false
}

This worked for me. I was targetting net461 and various netcoreapp and net5/6

Same issue here with 4.7.2.
I fixed it by manually adding "e_sqlite3.dll" to the project and set to always copy this file.
Copied from:
packages\SQLitePCLRaw.lib.e_sqlite<IP_ADDRESS>\runtimes\win-x86\native\e_sqlite3.dll


<IP_ADDRESS> does not correctly apply to apps

Describe the bug
Version <IP_ADDRESS> worked fine and immediately applied the mica/acrylic/tabbed design to title bars of apps.
Version <IP_ADDRESS> does not apply anything to starting apps. Only after altering settings does the effect apply to currentl title bars.
To Reproduce

Start <IP_ADDRESS>.
Save settings.
Start any app and see the setting not being applied.
Keep current active windows and alter Mica settings.
Now the settings actually apply (any new window will be ignored again).

Expected behavior
Correctly apply Mica settings on starting apps.
Screenshots
Window with <IP_ADDRESS> (incorrect)

Window with <IP_ADDRESS> (correct)

Windows Version
Windows 11 22H2 (Build 22621. 1928)
Additional context
Worked perfectly with <IP_ADDRESS>.

<IP_ADDRESS> it not working for me at all at least with build 23493 from Dev chanel revert back to <IP_ADDRESS> works fine again :)
I think latest version is broken

I'm also facing same issue.
But thing is, I uninstalled <IP_ADDRESS> and installed <IP_ADDRESS> and issue is still there

Same issue! Worked perfectly with v<IP_ADDRESS>

Yes 100% sure <IP_ADDRESS> it's broken at least on latest Dev Preview Build 23934 I never had any problem with MFE on any insider build ever

same issue. win ver 22H2 22621.1928

I've been trying to investigate this - and seems like it is due to the event hook not triggering. The P/Invoke enum declaration is wrong, but it was still not working when I changed it for some reason.

Same here, it's completely broken and only triggers when changing settings for that class. After system restart it seems to work for a while, but not for long.

I'm guessing that this is a threading issue, since you need an active message pool (GetMessage and stuff) in order for SetWinEventHook to work.

Can anyone test the latest build in Actions and see if the bug is fixed?

Can anyone test the latest build in Actions and see if the bug is fixed?

Yes, that fixed it for me.

Can anyone test the latest build in Actions and see if the bug is fixed?

Awesome! Are you planning to release this as a hotfix or something soon?

<IP_ADDRESS> has been released on GitHub for this issue. It will be published on Winget soon (I have to manually PR it due to the action failing).


How can I Draw Line from point to x axis on Point Hover ?

here is the reference Image

This would best be implemented as a plugin.
It seems similar to https://github.com/abelheinsbroek/chartjs-plugin-crosshair


Build and test with conda

Codecov Report
Base: 98.87% // Head: 98.87% // No change to project coverage :thumbsup:

Coverage data is based on head (7c1d8c3) compared to base (31054fb).
 Consider uploading reports for the commit 903242f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   98.87%   98.87%
=======================================
  Files          93       93
  Lines        3025     3025
=======================================
  Hits         2991     2991
  Misses         34       34

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fixed Bugs and NPE's after #519

@the-dagger @mariobehling please review and merge. This fixes some bugs and crashes after #519.

Looks good, merging


Improve README (Screenshots)

Show the functionality in screenshots / gif / mp4.
Tasks:

Decide on image asset type
Create image assets and folder structures (.github-directory?)
Update README

Chapter Installation: Distinguish between assets and files to copy for installation
Chapter Example: Create.

Added link to live-demo using github-pages.


InvalidOperationException: Build() or Update() can only be called once on a ContainerBuilder.

When calling Auth.SetApplicationOnlyCredentials(appKey, appSecret, true) I started getting the error: InvalidOperationException: Build() or Update() can only be called once on a ContainerBuilder.  when running my app locally in Visual Studio.   The call stack shows:
System.TypeInitializationException
HResult=0x80131534
Message=The type initializer for 'Tweetinvi.Auth' threw an exception.
Source=Tweetinvi
StackTrace:
at Tweetinvi.Auth.SetApplicationOnlyCredentials(String consumerKey, String consumerSecret, Boolean initializeBearerToken)
at ArchobotCore.Services.Twitter.TwitterClient..ctor(MainViewModel mainView) in D:\Source\Repos\ArchobotCore\ArchobotCore\ArchoBotCore\Services\Twitter\TwitterClient.cs:line 49
This exception was originally thrown at this call stack:
Autofac.ContainerBuilder.Build(Autofac.Core.IComponentRegistry, bool)
Autofac.ContainerBuilder.Build(Autofac.Builder.ContainerBuildOptions)
Tweetinvi.Injectinvi.AutofacContainer.Initialize()
Tweetinvi.TweetinviContainer.Resolve()
Tweetinvi.Auth.Initialize()
Tweetinvi.Auth.Auth()
Inner Exception 1:
InvalidOperationException: Build() or Update() can only be called once on a ContainerBuilder.
This is a .NET Core 3.1 App.   I haven't changed any code related to Twitter in my app and this just started happening today when I went to run my app in Visual Studio 2019.

Strange thing is it seems to only happen when running in debug mode in  Visual Studio 2019 v16.4.6.  If I publish the app and run it I don't hit this issue.

Workaround.  Compile app for debug.  Launch app and then attach VS Debugger.

Seems like the issue is occurring when I have code that tries to change the credentials using Auth.SetApplicationOnlyCredentials(appKey, appSecret, true);  After it has already been set.   I am doing this when my configuration for the key / secret changes.

Seems like I might have another NuGet package that is using Autofac and they are conflicting.  Trying to track it down.  If I move my auth call up sooner in my code it works fine.

Hello,
Thanks, for the feedback and sorry for the late reply.
Tweetinvi 5.0 container initialisation lifecycle has been drastically changed and should avoid this issue.
Thanks for getting back and explaining how you fixed your problem.
Cheers,
Linvi


Feature/release docker images for macs #234

Description
The current digiwf docker images do not run on arm processors. Therefore, I changed the docker base images to amazoncorretto and added the arm architecture to the release pipeline.
Reference
Issues #234

https://github.com/it-at-m/digiwf-core/issues/234#issuecomment-1603894793


Subpath/Relative path redirected to absolute path before logging in

Web Browser: Safari/Chrome
Local OS: MacOS
Remote OS: CentOS 7
Remote Architecture: code-server running as a service , nginx as reverse proxy
code-server --version: 3.5.0

Issue description:
Intended to run code-server behind a subpath/relative path of the host domain like example.com/code, however when visiting that url, browser got redirected to example.com/login?to=%2F instead of example.com/code/login?to=%2F.
In reality, Nginx can be set thus /login?to=%2F is also mapped to code-server, which however defeats the purpose of setting a subpath in terms of the separation of services.
Nginx config:
server {
    listen 80;
    listen [::]:80;
    server_name <example.com>;

    location /code {
      proxy_pass http://localhost:8080/;
      proxy_set_header Host $host;
      proxy_set_header Upgrade $http_upgrade;
      proxy_set_header Connection upgrade;
      proxy_set_header Accept-Encoding gzip;
    }
}

code-server config.yaml
bind-addr: <IP_ADDRESS>:8080
auth: password
password:<some password>
cert: false

Failed attempts
Tried to set base-url in config.yaml however that option seems to have been removed ever since earlier releases and would result in an error when restarting code-server.
Any suggestion would be appreciated and thanks so much for your time.

I think this is because there's no trailing slash on /code. code-server tries to redirect to a relative path (./login) which with /code ends up being /login.
One solution would be to use nginx to redirect /code to /code/ and then proxy the latter to code-server.


Runtime error

Describe the bug
I tried to install the plugin in Napari and got the following runtime error thrown:
File ~\Anaconda3\envs\napari-clusters\lib\site-packages\napari_nd_annotator\__init__.py:4, in <module>
      2 __version__ = "0.0.5"
----> 4 from ._widgets import AnnotatorWidget, InterpolationWidget, ListWidgetBB

File ~\Anaconda3\envs\napari-clusters\lib\site-packages\napari_nd_annotator\_widgets\__init__.py:1, in <module>
----> 1 from .interpolation_widget import InterpolationWidget
      2 from .object_list import ListWidgetBB

File ~\Anaconda3\envs\napari-clusters\lib\site-packages\napari_nd_annotator\_widgets\interpolation_widget.py:2, in <module>
      1 import numpy as np
----> 2 from cv2 import cv2
      3 from napari import Viewer

ImportError: Bindings generation error. Submodule name should always start with a parent module name. Parent name: cv2.cv2. Submodule name: cv2

RuntimeError: Failed to import command at 'napari_nd_annotator:AnnotatorWidget': Bindings generation error. Submodule name should always start with a parent module name. Parent name: cv2.cv2. Submodule name: cv2

To Reproduce
Install the nd-annotator through pip and open the plugin from Napari
Screenshots
If applicable, add screenshots to help explain your problem.
Versions(please complete the following information):

OS: Windows 10
Napari: Tried 0.4.15 and 0.4.16
napari-nd-annotator: 0.0.5
opencv: 4.6.0

resolved in #19

Can confirm, works


WIP: Improve selecting multiple rights shells when creating grouping

Addresses issue #130
Initially, I've implemented CheckboxSelectMultiple for the rights_shells in forms.py. However, by default this doesn't include the <fieldset> and <legend> elements that should form a set of checkboxes (this is a useful reference for that pattern, and why it's important).
I'm looking into how to include that markup.

@HaSistrunk easiest thing may be to tweak the existing /templates/forms/custom_field.html template.

@HaSistrunk you can catch these linting errors before commit/push by doing pre-commit install locally, which will install the pre-commit hooks (which do the same linting as these checks in Travis CI).

This is ready for a look, but I think it can be improved. I couldn't figure out how to cleanly implement the <fieldset> from the /templates/forms/custom_field.html template, but I've edited /templates/groupings/manage.html instead, removing the label for the rights_shells field from forms.py. This leaves the html a little messy with an extra <div>.
I've also added some Bootstrap styles that allow for scrolling to view a long set of rights shells (past 10), but the current max-height cut-off is coded in the html, which is probably not the ideal way to implement this?

I don't have any specific comments on the code placement/implementation.
However, I did notice that there's more padding underneath the last check item as opposed to above. I'm not sure if that's intended or not, but it looks slightly off to me. This may just be matter of preference though.

Yeah I see what you mean. This comes from the extra div (with id=div_id_rights_shells) that has a margin-bottom value. Hmm, let me look at options.


Filter by IEDs

We're interested in using this plugin to visualize communications.
Recently we've been exploring having our Protection 1 and Protection 2 system in the same SCD file.
It would be great to have say our standard IED button and a filtered list where the user could choose which IEDs they wanted to include.

You mean filter not only connection but complete IEDs?

Yes, for instance typically our Protection 1 IEDs and MUs finish with a "1" and have few connections to our Protection 2 IEDs and MUs which finish with a "2".
We usually do autoreclose initiate and block between line protection from Protection 1 to Protection 2 but otherwise they are not connected.
I suspect the display will be too cluttered to view both Protection 1 and Protection 2 IEDs on the same diagram at the same time.

Would it be enough then to filter on the connections - not show connections of specific IED, or do you think it would be better to not show IED in the SLD. Until now I though that we can always leave those in and only filter on connection.

Yes, I think we can try that to begin with in which case we want to filter connections associated with particular IEDs.

Is implemented


ci(codeql): setup code vulnerability scanning

This PR enables CodeQL to scan the codebase for any user introduced security vulnerabilities.

Squash


Question: Material dimlets with metadata?

I'm working on a modpack now and want to add ore dimlets. That works fine for some mods, but some mods have their different ore separated by metadata, so I can't differentiate them with different power values. I guess specifying a block with metadata is possible, but I don't know the syntax. I tried adding for example @4 or .4 but both didn't work.

You can use "meta": 3 or "meta": [3,4,5] in the filter

Thanks a lot for the help. It worked.


The action 'Edit Tags...' is disabled for one blob/blob snapshot/blob version

Storage Explorer Version: 1.31.0-dev
Build Number: 20230727.4
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.4.1 (Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: From running test cases
Regression From: Previous release (1.30.2)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Right click it -> Click 'Open in React'.
Upload a blob -> Right click the blob.
Check whether the action 'Edit Tags...' is enabled.

Expected Experience
The action 'Edit Tags...' is enabled.
Actual Experience
The action 'Edit Tags...' is disabled.

Verified this issue on the build 20230728.3. Fixed.


Create Dockerfile and update tracker API

Hi @koko1123 ! Thanks for your interest in the project and for your work on this PR.
Since this PR changes all imports from optakt/flow-dps to onflow/flow-dps, I assume you meant to open the PR against onflow/flow-dps and not optakt/flow-dps?
As it is, this PR cannot be accepted into this repository since it would create a dependency from this repository to its fork on onflow.
Have a great day!

PR was confirmed to have been opened by mistake, should be reopened against onflow/flow-dps. Closing.


Build webnn external delegate in native

@huningxin, this is an initial PR to build webnn external delegate in native, I can now build and run models use webnn external delegate with some manual configurations.
Build steps:

Change path to webnn-native repo in WORKSPACE file.
Copy required webnn_cpp.cpp to tensorflow/lite/delegates/webnn/.
Export webnn-native libraries to LD_LIBRARY_PATH. e.g. $ export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$pathToWebnnLibarires
Build webnn external delegate .so file from tensorflow root directory: $ bazel build -c opt tensorflow/lite/delegates/webnn:webnn_external_delegate.so --verbose_failures
Copy built webnn_external_delegate.so to /tmp: $ sudo cp bazel-bin/tensorflow/lite/delegates/webnn/webnn_external_delegate.so /tmp/
Build benchmark tool: $ bazel build -c opt tensorflow/lite/tools/benchmark:benchmark_model
Run: $ bazel-bin/tensorflow/lite/tools/benchmark/benchmark_model   --graph=/tmp/mobilenet-v2.tflite   --external_delegate_path=/tmp/webnn_external_delegate.so --external_delegate_options='webnn_device:2'

@huningxin please check latest commit, I've addressed your comments.


llvmPackages_git: 19.0.0-git-2024-07-08 -> 19.0.0-git-2024-07-14

Description of changes
Weekly LLVM git update

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build llvmPackages_git.clang


Options order wrong?

I am running the task:
const youtubedl = require('youtube-dl')
const url = 'http://www.youtube.com/watch?v=YE7VzlLtp-4'
const options = ['skip_download=true']

youtubedl.getInfo(url, options, (err, info) => {
   console.log(info)
})

Which according to the logs converts to:
youtube-dl --dump-json -f best skip_download=true http://www.youtube.com/watch?v=YE7VzlLtp-4
This throws an error:
ERROR: u'skip_download=true' is not a valid URL. Set --default-search "ytsearch" (or run  youtube-dl "ytsearch:skip_download=true" ) to search YouTube
Is putting the options in the wrong order? It works with just
youtubedl.getInfo(url, (err, info) => {...})

Am i wrong or does the option skip_download doesnt make sense at all in case of youtubedl.getInfo?
The option makes sense for actual download tasks but not for retrieving informations about an url - at least that's how i understand it.
@Kikobeats any idea on this?

I think flags need to be passed following this way:
https://github.com/microlinkhq/metascraper/blob/master/packages/metascraper-media-provider/src/get-media/provider/generic.js#L15
and of course, skip_download is a not necessary thing using .getInfo


Fix Node regression

I introduced a bug in #7514 where Resource was broken from inside of Node.js because the built version of cesium was using a different globally defined require than Node's require. One of these days we'll have full Node testing, but this is one of the fuzzy parts of the API that we don't normally ever use via Node.
To test this, first run minifyRelease then run NODE_ENV=production node and paste the below code into the interpreter:
const Cesium = require('./index.js');
Cesium.IonResource.fromAssetId(1);

You should see { then: [Function: e] } as output.  Previously it would crash with a No url error and callstack.

Thanks for the pull request @mramato!

:heavy_check_mark: Signed CLA found.
:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Thanks @mramato


remove Pass rom token

do you think we can remove pass from token?

You are right, we don't need it. Nice!


INFRA-12291 first attempt at configuring gump's httpd

I see you removed ant and tomcat also by overriding in the yaml the base packages. That is fine, but that should have been a different commit (same push is fine) with a commit message that explains this change. iow, it has nothing to do with the setting up of httpd.

I've split it (and rebased the branch again), thought you'd prefer a squashed commit, sorry. :-)

merged, looks to be working well

Yes, looks good, I may need to take core of https in a way (HTTPS everywhere sends me there and it looks broken). I'll need a few more steps but hope to finish the migration within the next week or so.
Thanks.


Feedback on copy from @stephbwills/@yourfrienderin

Hey y'all, apologies for weird format but figured this was the best way to do it.
@stephbwills @yourfrienderin We did a first pass at copy on https://open-source-friday.githubapp.com/. Can you review?
Comments on here are fine, or you can start a PR.
NOTE:

CTAs will change (we'll ask ppl to sign up for emails or connect GitHub acct)
Images of the Guides are mostly placeholders for now
We're gonna make the homepage point to contributors, not companies (https://github.com/ossfriday/ossfriday/issues/33), so think of the pages as standalone

(For others following along: meet @stephbwills, who does brand editorial, and @yourfrienderin, who does business marketing, at GitHub! I've asked them to provide feedback as they're both editorial super-:star:s.)

A few qs for @yourfrienderin (as I think the company page needs the most :heart:):

[ ] How do you feel about the corporate benefits we've listed? Are any of them more or less useful?
[ ] What should the CTA be for companies? Ideally, their job is to encourage/not actively block employees from participating in OSS Fridays.

Hi! I added some suggestions in this google doc: https://docs.google.com/a/github.com/document/d/14zPDhTTm27HA7vbeNzB4FuCCchckIRiCZXA8r3oAqaM/edit?usp=sharing
Not ideal, but I hope it's an OK way to give you feedback?

@stephbwills thank you! GDoc is fine. Could you also take a look at the other two pages?

https://open-source-friday.githubapp.com/contributors
https://open-source-friday.githubapp.com/maintainers

(They're both equally light on copy, so hopefully it's not too much to ask :innocent:)

More edits right here! https://docs.google.com/a/github.com/document/d/1OtFqlBIimtRv63XxZ0_HhZD6s9doc8Vt_0I1au6UH4U/edit?usp=sharing
For some reason, suggestions only worked for, like, half of the doc. I highlighted my changes in green. I think the Maintainer copy needed the most work. There was a lot of repetition in the language. I didn't make a note of it, but that's what most of my changes were attempting to fix. If you don't feel like accepting a change, that's fine! Just watch out to make sure you're not using "time" or "project" too frequently!

@stephbwills thank you so much, this is super helpful! I'll start a PR for changes.

I made comments directly in @stephbwills 's doc. Hopping on a ✈  but hopefully all makes sense?

Closed, tracking here: https://github.com/ossfriday/ossfriday/pull/41


Fix broken Rally link

*Issue #, if available: #219
Description of changes:
Add h in https
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

:thumbsup: thanks!


Added 2 projects - a personal blog on engineering management and an Agile Team check application

Added 2 projects - a personal blog on engineering management and an Agile Team check application, both using Svelte and SvelteKit.

Thanks for the submission! 👍
I think this largely overlaps with existing resources already in awesome-sveltekit. The entry requirements have gotten stricter over time. We're now looking for new ideas, use cases and designs not covered by existing items in this collection.

Thanks for the feedback. May I know what the entry requirements may be? It would be good to have them listed in the contribution guidelines. At a cursory glance, none of the projects listed on awesome-sveltekit seems to have any implementation with Pocketbase as a backend and UI with picoCSS.

May I know what the entry requirements may be? It would be good to have them listed in the contribution guidelines.

Excellent suggestion. See c653722.

At a cursory glance, none of the projects listed on awesome-sveltekit seems to have any implementation with Pocketbase as a backend and UI with picoCSS.

Oh, I missed Pocketbase. That's interesting. Happy to take "Team Health Check".

May I know what the entry requirements may be? It would be good to have them listed in the contribution guidelines.

Excellent suggestion. See c653722.

Nice!

At a cursory glance, none of the projects listed on awesome-sveltekit seems to have any implementation with Pocketbase as a backend and UI with picoCSS.

Oh, I missed Pocketbase. That's interesting. Happy to take "Team Health Check".

That's great! Updated the PR. 👍

Thanks. 👍


Project: .NET-Graph-Tutrial

Project name
.NET-Graph-Tutrial
Description

This Program enhanced from 'Tutorial - Build .NET apps with Microsoft Graph'.
These functions [Get User], [List inbox], [Send mail] work under my M365 Account as same as tutrial sample.
I added function of [Make a Graph call].

Read my TodoTaskList

Repo URL
https://github.com/yohjishady/.NET-Graph-Tutrial
Team members
yohjishady

Awesome! Thank you for your submission @yohjishady!


Add src/dependencies/ to .gitignore

Add the src/dependencies/ directory to .gitignore.

@lpinca I have given you access to the repo. You may push, merge code as you see fit.
I will be happy to continue reviewing/merging PRs if you'd like, but you can also proceed.

Thank you.

@lpinca Thank you.


Wrong syntax highlight for .cfg files with quotes

Type: Bug
VS Code version: Code 1.70.1 (6d9b74a70ca9c7733b29f0456fd8195364076dda, 2022-08-10T06:09:15.055Z)
OS version: Linux x64 5.18.17-lqx1.0.fc36.x86_64
Modes:
For a python setup.cfg file, when defining inline-quotes as string, the highlighted text is broken after the settings
Expected:

Actual result:

Notice that everything else from line 5 is now at the same color
File content:
[flake8]
exclude = .git, __pycache__, docs, build, dist, .idea, .pytest_cache, .vscode

# due to black quoting everything with "
inline-quotes = "

# from black documentation
extend-ignore = E203

System Info

Item
Value

CPUs
AMD Ryzen 7 PRO 4750U with Radeon Graphics (16 x 1700)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
30.59GB (2.68GB free)

Process Argv
--unity-launch --crash-reporter-id ecae8924-a6bf-48d7-8694-1e966cffbe1d

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
wayland

Extensions (16)

Extension
Author (truncated)
Version

arepl
alm
2.0.3

python-environment-manager
don
1.0.4

python-ultiextension-pack
eli
1.6.0

python-ultisnippets
eli
2.7.0

code-runner
for
0.11.8

restructuredtext
lex
189.1.0

vscode-docker
ms-
1.22.1

python
ms-
2022.12.0

vscode-pylance
ms-
2022.8.20

jupyter
ms-
2022.7.1102252217

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.9

remote-containers
ms-
0.245.1

makefile-tools
ms-
0.5.0

autodocstring
njp
0.6.1

vscodeintellicode
Vis
1.2.22

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30542924
vsaa593cf:30376535
pythonvs932:30410667
wslgetstarted:30449410
cppdebug:30492333
pylanb8912:30545647
vsclangdf:30486550
c4g48928:30535728
d7fjc500:30543455
dsvsc012cf:30540253
azure-dev_surveyone:30548225

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Done. :) Persists on 1.70.2

Hi @luminoso
make the quote on line 5 a pair of single quotes.
'' not "
what you currently have if one of double quotes

Thank you for your reply @moses-20
That syntax also seemed odd to me, but after some testing, it looks like to be correct. So I was in doubt if it was a syntax error or a syntax highlight parsing error :-)
For example, any of:

inline-quotes = '"'
inline-quotes = """
inline-quotes = "\""
inline-quotes = \0x22

It makes flake8 to crash. Also documentation has that explicit example.
In Pycharm, syntax highlight is rendered correctly.
So it seems to be a vs code bug.

@luminoso the syntax highlighting grammar that we use for .cfg files is the ini grammar that we get from https://github.com/textmate/ini.tmbundle. I've copied the issue over there: https://github.com/textmate/ini.tmbundle/issues/11


Added nice screenshots

Awesome, thank you so much for the screenshots! :)

Awesome, thank you so much for the screenshots! :)

You're welcome, thanks for the update


Round number to 1 decimal

Is there a reason for the 6 int?
https://github.com/al-one/hass-xiaomi-miot/blob/89df652ca856ab6453b895325ab3572e939c0a8b/custom_components/xiaomi_miot/number.py#L98

Show me the entity attributes.

# customize.yaml
sensor.zhimi_mb5_19f5_temperature:
  value_ratio: 1

Thank you.
The value_ratio config fixed the same decimal issue with my sensor.zhimi_mb3_xxxx_temperature sensor

Yes, but I'm more concerned with why 6 decimal places are used when the device supports 1?

The value comes from the device, and the component tries to keep the original value.


Ecto.Multi.insert_all fails with uuidv7

So this is a bit of a weird failure, but if you have not set the id when inserting multiple records the id will not be generated and the insert will fail.
Something like this is broken with UUIDv7
Ecto.Multi.new(
|> Ecto.Multi.insert_all(:users, User, user_records(data), placeholders: %{now: DateTime.utc_now()})

defp user_records(data) do
  Enum.map(data, fn user ->
    %{
      name: user["name"],
      inserted_at: {:placeholder, :now},
      updated_at: {:placeholder, :now}
    }
  end)
end

The fix is this:
Ecto.Multi.new(
|> Ecto.Multi.insert_all(:users, User, user_records(data), placeholders: %{now: DateTime.utc_now()})

defp user_records(data) do
  Enum.map(data, fn user ->
    %{
      id: UUIDv7.generate(),
      name: user["name"],
      inserted_at: {:placeholder, :now},
      updated_at: {:placeholder, :now}
    }
  end)
end

But I'm unsure if this is something that is broken in uuidv7 or I was relying on some behavior that I do not understand.

Hi @tomciopp,
If I remember correctly it works like that with Ecto.UUID as well. The issue would be that bigserial from Postgres / other database generates the primary key in the database rather than in the application.
Let me know if it's not the case.


feat: allow overwritting ui listenning port of fedimintd container

Codecov Report
Base: 64.49% // Head: 64.46% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (5b8a88a) compared to base (d894924).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1694      +/-   ##
==========================================
- Coverage   64.49%   64.46%   -0.04%
==========================================
  Files         132      132
  Lines       24100    24111      +11
==========================================
- Hits        15544    15543       -1
- Misses       8556     8568      +12

Impacted Files
Coverage Δ

fedimint-server/src/consensus/mod.rs
80.44% <0.00%> (-1.05%)
:arrow_down:

fedimint-core/src/api.rs
82.30% <0.00%> (-0.56%)
:arrow_down:

fedimint-server/src/net/peers.rs
91.61% <0.00%> (-0.30%)
:arrow_down:

fedimint-server/src/net/connect.rs
94.40% <0.00%> (-0.25%)
:arrow_down:

fedimint-core/src/core.rs
91.66% <0.00%> (+0.23%)
:arrow_up:

fedimint-server/src/db.rs
55.55% <0.00%> (+8.88%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Design first mile

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA


added ngrx sample

@alexeagle Added a simple ngrx sample
Simple write up: http://www.syntaxsuccess.com/viewarticle/integrating-ngrx-with-the-closure-compiler

Thanks!
FYI @robwormald


How to connect

Hi,
How do you connect to a specific bluetooth magtek e-dynamo device.

At the moment the plugin is not complete and is unusable. I'll try to push a working version in the next weeks.


Hub could inform user of upstream convention in errors

For features like pr checkout Hub relies on you having an upstream remote setup. This is often the case but if you set up a repo locally using hub you might end up (as I did) with your "upstream" named after the org due to a hub fetch <org-name>. Of course then when you got to do a hub pr checkout you'll get hit with a 404.
This is definitely a mistake on the user's part but Hub could help with an additional line in the resulting error message with something like "is your upstream remote pointed at the correct repository?".

Thank you for the feedback! I agree it's currently a mess how hub handles remotes, the detection of upstream repo, and related context. At least when it fails, it could give people some pointers about what went wrong. 👍


Feature/refresh entire model

A couple of options that we found handy when working with postgres. Bookshelf by default just does returning id to run the same codepath as mysql, I'm guessing?
But postgres supports returning *, and it's often very useful to refresh the entire model on updates and inserts.
Similarly, you can't override the returning option set in sync.js, if you need to do any other transformations on the row, because it sets the returning option again just before running the query. So the second option is there to avoid setting that, on the assumption that the user will specify the appropriate returning in the fetching and saving hooks.
I get the sense that these two options are not at all the Bookshelf Way of implementing these features, so I'm happy to work with you guys here to make them into something that fits in Bookshelf proper.
(Also, I would appreciate advice on what tests where would be desirable.)
Thanks!

Hey @tgriesser, do you know why this never ended up getting merged? It seems like a good idea. I'm happy to reapply these changes to the new file structure if you believe the behaviour should be default.

ultimately we're going to want to do a select for newly inserted and non-fetched objects where we need to anyway

I can also add a call to Model#refresh after insertion for databases other than Postgres. I'd be hesitant to make that default though due to number of extra queries that would silently cause non-pg users.

This affects mysql as well, for columns that have database defaults, so I think it should be the default for everything.   In mysql:
User.forge({ name: "jgr3go" }).save().then(user => {
    console.log(user.toJSON()); // {id: 1, name: "jgr3go" }
    return user.refresh();
}).then(user => {
    console.log(user.toJSON()); // {id: 1, name: "jgr3go", is_admin: 0 }
});

I actually had to override the save method to call refresh in my models, so this pull would be useful for non postgres people also.
bookshelf.Model.extend({
    save () {
        return bookshelf.Model.prototype.save.apply(this, arguments)
            .then(model => {
                return model.refresh();
            });
   ,
   ...

@rhys-vdw Did this lose steam?  I'd personally love to see this in place, and I think everyone agrees it is universally a great idea.

No, I implemented it ages ago. Not sure why I didn't close the PR.
On Tue, Jul 26, 2016, 8:19 AM ricka<EMAIL_ADDRESS>wrote:

@rhys-vdw https://github.com/rhys-vdw Did this lose steam? I'd
personally love to see this in place, and I think everyone agrees it is
universally a great idea.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tgriesser/bookshelf/pull/425#issuecomment-235103791,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyLWeRAeP2mgbfWnNE2w4sMZ8p8aLAmks5qZTZmgaJpZM4CO2N8
.

I'm trying to implement this with the following:
initialize: function () {
  this.on('creating', (model, attrs, options) => {
    options.query.returning('*');
  });
  this.on('created', (model, resp, options) => {
    model.set(model.parse(head(resp)));
  });
}

However, I only ever get back one element in resp, which is the id of the record created.  Is there some other way I should be doing this to make sure I get all fields for the newly created record?

@ricka Sorry I didn't look at the full thread. What I added was refresh(). If you don't care about performance you can do this:
initialize: function () {
  this.on('updated craeted', (model, resp, options) => {
    return this.refresh();
  });
}

Otherwise I did at one stage try to get support for this added. It's pretty hard dealing with the different dialects. I'm sure it's possible, but I had some trouble (to do with Bookshelf architecture). The main reason you're not able to override returning is that it's specified explicitly within fetch somewhere. So you'll probably need to fork.
If you can get it working I'm open to merging it into master, but it would need to be tested thoroughly of course. You might be able to monkey patch it in for your own purposes though.

@rhys-vdw I believe that @pignatenko found the area of concern in #507 in this comment.
It looks like the code referenced is currently here.  Does that look right, and if so, would the fix be checking for this.query._single.returning there and using it instead of syncing.idAttribute if it exists?

Hello, when do you think this issue will be done ?
Thanks

@JBustin I may consider merging it. But it doesn't have an tests.
Are you willing to contribute?

Closing until re-implementation. All issues related to refresh and returning collected under #1665


YouTube PostMessage errors

It seems like mediaelement isn't setting the host, or it's not detecting the host properly.
Getting the error "Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://www.youtube.com') does not match the recipient window's origin ('https://www.mediaelementjs.com')." when initializing YT videos.
That message is right from the sample on mediaelementjs.com of course, but getting the same for my site as well.

I have also seen this problem

The problem can be solved by settings the origin (youtube.js:451) to window.location.href instead of window.location.host.

Please fix it.


Contact Merge: If Primary Affiliation on non-master Contact, clean up is removing Primary Affiliation from Contact record

Steps to repeat:

Contact1 w/Primary Affiliation to organization
Contact2 with no Primary Affiliation
Contact Merge, selecting the Primary Affiliation value from the non-master record

When the clean up runs to delete the duplicate Affiliation record, the correct Affiliation record checked as Primary remains, the duplicate is deleted, however the Primary Affiliation value is cleared from the Contact record incorrectly.

**lurch: add

Tracking W-020499

My guess as to what's happening is that by the time the delete of the dupe Affiliation is happening, it's been checked as 'Primary' because of the Primary Affiliation to the same Organization on the Contact. Then it's being deleted and that's firing the code to remove the Primary Affiliation from the Contact, even though there is still another Affiliation record that remains.

I wonder if this is a side affect of the static flags work - allowing the trigger to run a second time when it probably shouldn't.

Another thread.

Another thread.
In this case there is a Primary Affiliation to the same account on both contacts being merged. Result is that affiliation is removed from master contact once merged.
During Merge:

Master after Merge:

Another thread.

Another thread.

Included in beta release 3.157 (Beta 7)

Included in production release 3.157


Model model.cfg.generation is overwritten in hub_utils.py

https://github.com/pytorch/fairseq/blob/feb5f07ff4220b7908ff12c6692685784c7c9a71/fairseq/hub_utils.py#L160
It seems that when running gen_args = copy.copy(self.cfg.generation), the copy operation does not actually copy omegaconf.dictconfig.DictConfig objects causing them to be modified inplace afterwards in the code.
I noticed this by running model.score("Hello world") and then model.sample("Hello"). The second call to sample() returns nothing because model.cfg.generation["score_reference"] is was modified to True inplace in the call to score().
Repro
Simple repro of the behaviour of omegaconf DictConfigs:
import copy
from omegaconf import OmegaConf
a = OmegaConf.create({"a": 1, "b": 2})
b = copy.copy(a)
b["a"] = 42
print(b)
print(a)

Outputs:
{'a': 42, 'b': 2}
{'a': 42, 'b': 2}

Simple fix
A simple fix would be to first cast the object to a dict with gen_args = dict(self.cfg.generation).copy() (and not use open_dict() afterwards).
For example with a simple omegaconf DictConfig:
from omegaconf import OmegaConf
a = OmegaConf.create({"a": 1, "b": 2})
b = dict(a).copy()
b["a"] = 42
print(b)
print(a)

Outputs:
{'a': 42, 'b': 2}
{'a': 1, 'b': 2}

This however only works for first level attributes, nested DictConfigs won't be casted to dict and will therefore be modified inplace.
For instance:
from omegaconf import OmegaConf
a = OmegaConf.create({"a": {"aa": 1}, "b": 2})
b = dict(a).copy()
b["a"]["aa"] = 42
print(b)
print(a)

Outputs:
{'a': {'aa': 42}, 'b': 2}
{'a': {'aa': 42}, 'b': 2}

@alexeib I am not sure if this is intended in omegaconf, I will open an issue there as well.

should be easy to fix by just using deepcopy:
b = copy.deepcopy(a)

Yes perfect deepcopy works like a charm! And actually casting to a dict caused downstream bugs because other functions called getattr(args, "foo") which does not work on a dict.
I'll submit a PR.


Deleting a file while a command is running crashes Rome

Steps To Reproduce

Create an empty file dummy.ts
Start a long running command such as rome lint
Delete dummy.ts while the command is running

Doing this would cause Rome to crash:
rome master % ./scripts/dev-rome lint --save
 Building trunk
ℹ Bundling<EMAIL_ADDRESS>✔ Saved to /var/folders/gp/z7cw34td69v0qlsytclcm9600000gn/T/rome-dev
 Executing trunk
⚠ Disk caching has been disabled due to the ROME_CACHE=0 environment variable
 Linting<EMAIL_ADDRESS>                               elapsed 1s eta 14s 153/1_336[Error: Expected file stats for<EMAIL_ADDRESS>  at ___R$project$rome$$romejs$core$master$fs$MemoryFileSystem_ts$default.getFileStatsAssert (/private/var/folders/gp/z7cw34td69v0qlsytclcm9600000gn/T/rome-dev/index.js:100500:14) generated source location
  at ___R$project$rome$$romejs$core$master$fs$FileAllocator_ts$default.handleDeleted (/private/var/folders/gp/z7cw34td69v0qlsytclcm9600000gn/T/rome-dev/index.js:98708:41) generated source location
  at process.processTicksAndRejections (internal/process/task_queues.js:97:4)]
✖ Fatal error occurred: Error: Expected file stats for<EMAIL_ADDRESS>    at ___R$project$rome$$romejs$core$master$fs$MemoryFileSystem_ts$default.getFileStatsAssert
  (/private/var/folders/gp/z7cw34td69v0qlsytclcm9600000gn/T/rome-dev/index.js:100500:14) generated source location
    at ___R$project$rome$$romejs$core$master$fs$FileAllocator_ts$default.handleDeleted
  (/private/var/folders/gp/z7cw34td69v0qlsytclcm9600000gn/T/rome-dev/index.js:98708:41) generated source location
    at process.processTicksAndRejections (internal/process/task_queues.js:97:4)

Expected Results
Rome should not crash.

Looks like a race condition.

MemoryFileSystem#handleDeletion calls deletedFileEvent.send(path) after it calls files.delete(path)
In response to the deletedFileEvent, FileAllocator#handleDeleted calls memoryFs.getFileStatsAssert(path) which checks the files Map for the path entry which was just deleted, and then throws an error when it can't find it.
I think you can solve this particular problem by changing MemoryFileSystem#handleDeletion to an async function then awaiting this.deletedFileEvent.call(path) before deleting the files entry.
But I don't know if that would cause other problems, and rome still crashes on file deletion for other reasons that I haven't dug into yet.

LintRunner populates worker queues with all the paths that were passed to LintRunner#run at the start of the run.
There doesn't appear to be any handling of file deletion while those queues spin down, and when Cache#get is called for a nonexistent path, rome crashes because Cache#createEmptyEntry needs the mtime.

Hopefully resolved #604. Let's reopen this if there's more issues.


eslint-plugin-jest(expect-expect): Test has no assertions doesn't detect await expect

Example/repro: https://web-infra-dev.github.io/oxc/playground/?code=3YCAAIBbgICAgICAgICymcpMQXaQyDS16nxFlbtxtP%2BMSKVFtAtOuK0KxOd5yZZIDZ6aPffpelHMF6bQ%2B7gY252lRXrzFB%2B%2BRGTXX5q1pS348zzLEWhdwzIMz65QtMB1YvkivIIUlO0RZpATrjDPvCu9aonwQyafh2Y6L0CVdoNxPNccyq2jEG%2Bn2OWPKuKv3dTpTQCiLjlPqHRYZCP2nDJZf95vAIA%3D
Removing the await makes the warning go away.

Thanks for using the Jest rule plugin, it will be fixed soon. If you have any rules want to have, just let us know!

That was fast, thanks! 🚀

As to rules wanted: https://typescript-eslint.io/rules/no-floating-promises/ and https://typescript-eslint.io/rules/no-misused-promises mainly, not sure if this is planned already

As to rules wanted: https://typescript-eslint.io/rules/no-floating-promises/ and https://typescript-eslint.io/rules/no-misused-promises mainly, not sure if this is planned already

We are handcuffed with type information for these two rules :-(

As to rules wanted: typescript-eslint.io/rules/no-floating-promises and typescript-eslint.io/rules/no-misused-promises mainly, not sure if this is planned already

We are handcuffed with type information for these two rules :-(

As in, these will never be possible in oxc?


Translate into Chinese: docs/examples/multicluster/icp/index.md

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: fishead
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rootsongjc
If they are not already assigned, you can assign the PR to them by writing /assign @rootsongjc in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content_zh/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @fishead. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I signed it!

/ok-to-test
@gyliu513

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fishead, gyliu513
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content_zh/OWNERS [gyliu513]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


refactor: remove builders

Landed in https://github.com/metarhia/metasql/commit/05a0b12a784d1dcc215eb201ce2cfdfa2f8fbebb


[Authorization Logic // Rust] Fix frontend for constants vs symbolic IDs

The grammar for authorization logic currently has just one rule for identifiers that is meant to cover: parameter names, variable argument names, and constant argument names. This rule looks like ID : ('"')? [_a-zA-Z0-9/.#:]* ('"')?;.
Because all of these are lumped together, this places unneeded syntactic restrictions such as requiring an extra space in type declarations for predicates. It also likely allows more code to parse than should be allowed.
It would be better to more cleanly separate parameter/symbolic names from constants. This might instead look like:
id
    : '"' PARAM_NAME (NAME_EXTRA_CHARS PARAM_NAME)* '"'
    | PARAM_NAME
    ;
...
PARAM_NAME: [_a-zA-Z][_a-zA-Z0-9]*;
NAME_EXTRA_CHARS: [/.#:];

or something similar. However, antlr is pretty finicky about lexer rules that might overlap, so pushing this through is a bit more work than it sounds. We can get by with the syntax as it is for now, so this is an issue instead of a PR :)

This is fixed for the C++ version. Rust version is no longer relevant.


Atomic Swap - Display QRcode

It would be great for the sender of the coin like BTC, BCH ect to get a QR Code in the notification page when he's sending the coin to the lock address.

@vek-kal ,  what exactly do you want in QT code?  Just an address where to send the funds?
We can show qr code at the message box dialog.

Yes, that would exactly make it 👍 showing the lock address in string and next to it, a QR code button to show. If possible as well a copy button.
This gif shows a possible copy and QR Code button disposal in the box dialog, would be great to make something similar.
https://user-images.githubusercontent.com/80525364/111248904-bdf5ef00-8602-11eb-8d76-b99f21ad3e36.mp4

Yes, make sense. Currently user need to select the the locking address and  then copy it.


[FE]: Auto-click "Show All" in editable fields

Description:
(details of what and how should work)
As title.
Use a toggable flag but make it on by default.
Additional Context & Ad Hoc Info:
(Add any other context about the problem here.)

Duplicate of #66


saltpack bug fixes

This covers
https://keybase.atlassian.net/browse/CORE-2305
https://keybase.atlassian.net/browse/CORE-3404
https://keybase.atlassian.net/browse/CORE-3455
https://keybase.atlassian.net/browse/CORE-4112
https://keybase.atlassian.net/browse/CORE-8496
https://keybase.atlassian.net/browse/CORE-8498

@maxtaco fixed! Waiting for CI / your final approval.


Note that check_vmware_datastore plugin name is changing

Give advance notice of the changes coming in v0.28.0 for GH-510.

From https://github.com/atc0005/check-vmware/issues/510#issuecomment-980644780:

Perhaps using a space suffix is the better approach?

I'm leaning this direction.

usage could reasonably be interpreted to mean that activity is occurring

size could potentially be interpreted to mean that the total size is within some threshold

e.g., making sure that its capacity isn't resized past a certain point

space seems to be the more explicit of the naming suffixes available.


Persistent frame mode

Text Grab could open a persistent frame which can be positioned around the screen and has a capture button. When pressing the capture button the frame does not go away, but text is grabbed and added to clipboard.
Maybe the frame could do more interesting things like display bounding boxes around recognized words.

This mode could also relate to #13 with a search box to find a particular sting within the Frame window.

Preview of the new frame feature.


[nrf fromtree] nrfconnect: Fixed bug with not handling CHIPoBLE disco…

…nnect (#9160)
Current implementation of Zephyr BLEMgr has a bug that BLEMgr
handles BLE disconnect event only if CHIPoBLE advertising
is enabled to determine whether this disconnect event is related
to CHIPoBLE or some other service. That condition is wrong as
advertising is not working when connection with commissioner
is being closed.

Changed condition checking if advertising is enabled to check
if CHIPoBLE GATT service is registered (that one persists during
connection).
Refactored DFUoverSMP module to implement ChipEventHandler
and not force handling advertisments restart in the AppTask.cpp.
Aligned lock-app and lighting-app examples to those changes.
Created new platform event kCHIPoBLEConnectionClosed to inform
about closing CHIPoBLE connection and let perform some actions
related to this in the application (e.g. turn on some other
advertising).

(cherry picked from commit 9f6465556e0a372ded46c7f0f7133d4ab951ec5d)

Do not merge for now, need to cherry-pick one commit more.


CM-609: Fix error saving advisories

Jira Ticket:
CM-609
Jira Ticket URL:
https://bcparksdigital.atlassian.net/browse/CM-609
Description:
Fixed another error that happens periodically when updating public advisories from the staff portal.

Maybe a.obj.attributes.protectedArea.data.id?

It doesn't look like it needs data this time...
https://test-cms.bcparks.ca/api/public-advisories?filters[id]=1244&populate[protectedAreas][fields][0]=orcs&populate[protectedAreas][fields][1]=protectedAreaName


AJAX Handler onLogout() not found

Like the title says, the onLogout() does not working and displays a message that the ajax handler was not found. I followed what is said on the documentation but still doesn't work.
Is there any solid solution or temporary fix for this? Thanks in advance.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30598893-ajax-handler-onlogout-not-found?utm_campaign=plugin&utm_content=tracker%2F784048&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F784048&utm_medium=issues&utm_source=github).

up

Can you provide more information, what does your layout / page structure look like?
Are you including [session] inside a partial? If so, AJAX handlers will not work here, try adding to the layout instead.

Nevermind I forgot to put [session] into my layout and it is now working.


Fix some incorrect line endings

For some reason these weren't fixed when .gitattributes was added, so these changes now pollute the local work tree.

Merging because this is just line endings, and I have other changes in the pipeline (rebasing is silly atm).


Update 11_probabilistic-pca.jmd

Expanded version.

@YongchaoHuang you might want to incorporate changes from https://github.com/TuringLang/TuringTutorials/pull/305 so that we can close that one.

@YongchaoHuang you might want to incorporate changes from #305 so that we can close that one.

Thanks, I am looking at #305 now.

thanks @storopoli and @YongchaoHuang!


Derive header from data processed in storage

Description
Twin to #183
These branches:

Define and return a full set of data structures for the data in the header (so far).
Change the header so that it is being driven by those data structures in the data store.
Only import and store the article body from encoda (without the header, but with an id added to abstract for jump-to). This moves the JSDOM dependancy from during page generation to import.
Where appropriate, return content that could be complex as a JS structure, and we have the start of a complex content transformation tool for that structure. Currently only emphasis and strong is supported, but that is enough for the titles so far.

The branches differ by the way they select data for above header:

In storage (this branch): offloads these aspects to the storage adapters
During import: ensures it is done during import and the stores remain relatively dumb to the structure.

Pros of In storage (this branch):

We can evolve the schema and data store overtime to extract more data (for example to pull out MSA) without reimporting. In other words, importing is idempotent.
Cons of In storage (this branch):
Each storage adapter is more complex (as the logic for selection is here).
We have to write the logic for each adapter
It's not as nice as just doing it in JS.

Pros of During import:

There is only one set of logic for selecting data
stores remain dumb and simple
Cons of During import:
All articles need a reimport if we change schema/ingestion logic. We do not currently have this, except by removing and reimporting.

There is a third possibility that we shift the selection of data to render time, which I hadn't considered. It would be fairly trivial to implement on top of the other branch (remove extra columns, and move the extraction logic to the adapters instead of data-loader). This would avoid the need to reimport, at a cost of doing it every time we render. It would, overall be quite simple though.

Using the other approach, process and only store the processed document


npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prepare script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2020-09-15T11_39_57_611Z-debug.log
2020-09-15 04:39:57,654 synthtool [ERROR] > Failed executing npm install:

None
ERROR:synthtool:Failed executing npm install:

None
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/kbuilder/.cache/synthtool/nodejs-logging-winston/synth.py", line 27, in <module>
    node.install()
  File "/tmpfs/src/github/synthtool/synthtool/languages/node.py", line 167, in install
    shell.run(["npm", "install"], hide_output=hide_output)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['npm', 'install']' returned non-zero exit status 1.
2020-09-15 04:39:57,802 autosynth [ERROR] > Synthesis failed
2020-09-15 04:39:57,803 autosynth [DEBUG] > Running: git reset --hard HEAD
HEAD is now at 4abe705 chore: add dev dependencies for cloud-rad ref docs (#527)
2020-09-15 04:39:57,810 autosynth [DEBUG] > Running: git checkout autosynth
Switched to branch 'autosynth'
2020-09-15 04:39:57,816 autosynth [DEBUG] > Running: git clean -fdx
Removing .kokoro/continuous/node12/lint.cfg
Removing .kokoro/continuous/node12/samples-test.cfg
Removing .kokoro/continuous/node12/system-test.cfg
Removing .kokoro/presubmit/node12/samples-test.cfg
Removing .kokoro/presubmit/node12/system-test.cfg
Removing .kokoro/release/docs-devsite.cfg
Removing .kokoro/release/docs-devsite.sh
Removing __pycache__/
Removing api-extractor.json
Removing node_modules/
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 692, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 541, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 672, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 375, in synthesize_loop
    has_changes = toolbox.synthesize_version_in_new_branch(synthesizer, youngest)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 273, in synthesize_version_in_new_branch
    synthesizer.synthesize(synth_log_path, self.environ)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 120, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth is still having trouble generating nodejs-logging-winston. :sob:
Here's the output from running synth.py:
github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
> https://opencollective.com/core-js
> https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

><EMAIL_ADDRESS>postinstall /home/kbuilder/.cache/synthtool/nodejs-logging-winston/node_modules/protobufjs
> node scripts/postinstall

><EMAIL_ADDRESS>postinstall /home/kbuilder/.cache/synthtool/nodejs-logging-winston/node_modules/@compodoc/compodoc
> opencollective-postinstall || exit 0

Thank you for using @compodoc/compodoc!
If you rely on this package, please consider supporting our open collective:
> https://opencollective.com/compodoc/donate

><EMAIL_ADDRESS>prepare /home/kbuilder/.cache/synthtool/nodejs-logging-winston
> npm run compile

><EMAIL_ADDRESS>precompile /home/kbuilder/.cache/synthtool/nodejs-logging-winston
> gts clean

version: 12
Removing build ...

><EMAIL_ADDRESS>compile /home/kbuilder/.cache/synthtool/nodejs-logging-winston
> tsc -p .

node_modules/google-gax/build/src/fallback.d.ts:119:10 - error TS1005: 'from' expected.

119 export * as protobufMinimal from 'protobufjs/minimal';
             ~~

node_modules/google-gax/build/src/fallback.d.ts:119:10 - error TS1141: String literal expected.

119 export * as protobufMinimal from 'protobufjs/minimal';
             ~~

node_modules/google-gax/build/src/fallback.d.ts:119:13 - error TS1005: ';' expected.

119 export * as protobufMinimal from 'protobufjs/minimal';
                ~~~~~~~~~~~~~~~

node_modules/google-gax/build/src/fallback.d.ts:119:13 - error TS2304: Cannot find name 'protobufMinimal'.

119 export * as protobufMinimal from 'protobufjs/minimal';
                ~~~~~~~~~~~~~~~

node_modules/google-gax/build/src/fallback.d.ts:119:29 - error TS1005: ';' expected.

119 export * as protobufMinimal from 'protobufjs/minimal';
                                ~~~~

node_modules/google-gax/build/src/fallback.d.ts:119:29 - error TS2304: Cannot find name 'from'.

119 export * as protobufMinimal from 'protobufjs/minimal';
                                ~~~~

node_modules/google-gax/build/src/fallback.d.ts:119:34 - error TS1005: ';' expected.

119 export * as protobufMinimal from 'protobufjs/minimal';
                                     ~~~~~~~~~~~~~~~~~~~~

node_modules/google-gax/build/src/index.d.ts:47:10 - error TS1005: 'from' expected.

47 export * as protobufMinimal from 'protobufjs/minimal';
            ~~

node_modules/google-gax/build/src/index.d.ts:47:10 - error TS1141: String literal expected.

47 export * as protobufMinimal from 'protobufjs/minimal';
            ~~

node_modules/google-gax/build/src/index.d.ts:47:13 - error TS1005: ';' expected.

47 export * as protobufMinimal from 'protobufjs/minimal';
               ~~~~~~~~~~~~~~~

node_modules/google-gax/build/src/index.d.ts:47:13 - error TS2304: Cannot find name 'protobufMinimal'.

47 export * as protobufMinimal from 'protobufjs/minimal';
               ~~~~~~~~~~~~~~~

node_modules/google-gax/build/src/index.d.ts:47:29 - error TS1005: ';' expected.

47 export * as protobufMinimal from 'protobufjs/minimal';
                               ~~~~

node_modules/google-gax/build/src/index.d.ts:47:29 - error TS2304: Cannot find name 'from'.

47 export * as protobufMinimal from 'protobufjs/minimal';
                               ~~~~

node_modules/google-gax/build/src/index.d.ts:47:34 - error TS1005: ';' expected.

47 export * as protobufMinimal from 'protobufjs/minimal';
                                    ~~~~~~~~~~~~~~~~~~~~

Found 22 errors.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>compile: `tsc -p .`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prepare script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2020-09-16T11_39_21_779Z-debug.log
2020-09-16 04:39:21,811 synthtool [ERROR] > Failed executing npm install:

None
ERROR:synthtool:Failed executing npm install:

None
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/kbuilder/.cache/synthtool/nodejs-logging-winston/synth.py", line 27, in <module>
    node.install()
  File "/tmpfs/src/github/synthtool/synthtool/languages/node.py", line 167, in install
    shell.run(["npm", "install"], hide_output=hide_output)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['npm', 'install']' returned non-zero exit status 1.
2020-09-16 04:39:21,963 autosynth [ERROR] > Synthesis failed
2020-09-16 04:39:21,964 autosynth [DEBUG] > Running: git reset --hard HEAD
HEAD is now at 4abe705 chore: add dev dependencies for cloud-rad ref docs (#527)
2020-09-16 04:39:21,975 autosynth [DEBUG] > Running: git checkout autosynth
Switched to branch 'autosynth'
2020-09-16 04:39:21,980 autosynth [DEBUG] > Running: git clean -fdx
Removing .kokoro/continuous/node12/lint.cfg
Removing .kokoro/continuous/node12/samples-test.cfg
Removing .kokoro/continuous/node12/system-test.cfg
Removing .kokoro/presubmit/node12/samples-test.cfg
Removing .kokoro/presubmit/node12/system-test.cfg
Removing .kokoro/release/docs-devsite.cfg
Removing .kokoro/release/docs-devsite.sh
Removing __pycache__/
Removing api-extractor.json
Removing node_modules/
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 692, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 541, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 672, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 375, in synthesize_loop
    has_changes = toolbox.synthesize_version_in_new_branch(synthesizer, youngest)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 273, in synthesize_version_in_new_branch
    synthesizer.synthesize(synth_log_path, self.environ)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 120, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth is still having trouble generating nodejs-logging-winston. :sob:
Here's the output from running synth.py:
github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
> https://opencollective.com/core-js
> https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

><EMAIL_ADDRESS>postinstall /home/kbuilder/.cache/synthtool/nodejs-logging-winston/node_modules/protobufjs
> node scripts/postinstall

><EMAIL_ADDRESS>postinstall /home/kbuilder/.cache/synthtool/nodejs-logging-winston/node_modules/@compodoc/compodoc
> opencollective-postinstall || exit 0

Thank you for using @compodoc/compodoc!
If you rely on this package, please consider supporting our open collective:
> https://opencollective.com/compodoc/donate

><EMAIL_ADDRESS>prepare /home/kbuilder/.cache/synthtool/nodejs-logging-winston
> npm run compile

><EMAIL_ADDRESS>precompile /home/kbuilder/.cache/synthtool/nodejs-logging-winston
> gts clean

version: 12
Removing build ...

><EMAIL_ADDRESS>compile /home/kbuilder/.cache/synthtool/nodejs-logging-winston
> tsc -p .

node_modules/google-gax/build/src/fallback.d.ts:119:10 - error TS1005: 'from' expected.

119 export * as protobufMinimal from 'protobufjs/minimal';
             ~~

node_modules/google-gax/build/src/fallback.d.ts:119:10 - error TS1141: String literal expected.

119 export * as protobufMinimal from 'protobufjs/minimal';
             ~~

node_modules/google-gax/build/src/fallback.d.ts:119:13 - error TS1005: ';' expected.

119 export * as protobufMinimal from 'protobufjs/minimal';
                ~~~~~~~~~~~~~~~

node_modules/google-gax/build/src/fallback.d.ts:119:13 - error TS2304: Cannot find name 'protobufMinimal'.

119 export * as protobufMinimal from 'protobufjs/minimal';
                ~~~~~~~~~~~~~~~

node_modules/google-gax/build/src/fallback.d.ts:119:29 - error TS1005: ';' expected.

119 export * as protobufMinimal from 'protobufjs/minimal';
                                ~~~~

node_modules/google-gax/build/src/fallback.d.ts:119:29 - error TS2304: Cannot find name 'from'.

119 export * as protobufMinimal from 'protobufjs/minimal';
                                ~~~~

node_modules/google-gax/build/src/fallback.d.ts:119:34 - error TS1005: ';' expected.

119 export * as protobufMinimal from 'protobufjs/minimal';
                                     ~~~~~~~~~~~~~~~~~~~~

node_modules/google-gax/build/src/index.d.ts:47:10 - error TS1005: 'from' expected.

47 export * as protobufMinimal from 'protobufjs/minimal';
            ~~

node_modules/google-gax/build/src/index.d.ts:47:10 - error TS1141: String literal expected.

47 export * as protobufMinimal from 'protobufjs/minimal';
            ~~

node_modules/google-gax/build/src/index.d.ts:47:13 - error TS1005: ';' expected.

47 export * as protobufMinimal from 'protobufjs/minimal';
               ~~~~~~~~~~~~~~~

node_modules/google-gax/build/src/index.d.ts:47:13 - error TS2304: Cannot find name 'protobufMinimal'.

47 export * as protobufMinimal from 'protobufjs/minimal';
               ~~~~~~~~~~~~~~~

node_modules/google-gax/build/src/index.d.ts:47:29 - error TS1005: ';' expected.

47 export * as protobufMinimal from 'protobufjs/minimal';
                               ~~~~

node_modules/google-gax/build/src/index.d.ts:47:29 - error TS2304: Cannot find name 'from'.

47 export * as protobufMinimal from 'protobufjs/minimal';
                               ~~~~

node_modules/google-gax/build/src/index.d.ts:47:34 - error TS1005: ';' expected.

47 export * as protobufMinimal from 'protobufjs/minimal';
                                    ~~~~~~~~~~~~~~~~~~~~

Found 22 errors.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>compile: `tsc -p .`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prepare script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2020-09-17T11_39_35_919Z-debug.log
2020-09-17 04:39:35,958 synthtool [ERROR] > Failed executing npm install:

None
ERROR:synthtool:Failed executing npm install:

None
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/kbuilder/.cache/synthtool/nodejs-logging-winston/synth.py", line 27, in <module>
    node.install()
  File "/tmpfs/src/github/synthtool/synthtool/languages/node.py", line 167, in install
    shell.run(["npm", "install"], hide_output=hide_output)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['npm', 'install']' returned non-zero exit status 1.
2020-09-17 04:39:36,060 autosynth [ERROR] > Synthesis failed
2020-09-17 04:39:36,061 autosynth [DEBUG] > Running: git reset --hard HEAD
HEAD is now at 4abe705 chore: add dev dependencies for cloud-rad ref docs (#527)
2020-09-17 04:39:36,068 autosynth [DEBUG] > Running: git checkout autosynth
Switched to branch 'autosynth'
2020-09-17 04:39:36,074 autosynth [DEBUG] > Running: git clean -fdx
Removing .kokoro/continuous/node12/lint.cfg
Removing .kokoro/continuous/node12/samples-test.cfg
Removing .kokoro/continuous/node12/system-test.cfg
Removing .kokoro/presubmit/node12/samples-test.cfg
Removing .kokoro/presubmit/node12/system-test.cfg
Removing .kokoro/release/docs-devsite.cfg
Removing .kokoro/release/docs-devsite.sh
Removing __pycache__/
Removing api-extractor.json
Removing node_modules/
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 692, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 541, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 672, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 375, in synthesize_loop
    has_changes = toolbox.synthesize_version_in_new_branch(synthesizer, youngest)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 273, in synthesize_version_in_new_branch
    synthesizer.synthesize(synth_log_path, self.environ)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 120, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.


Issue in GitHub Actions building with make

https://github.com/siconos/siconos/runs/1687455252

141
-- Found SuiteSparse_LDL: /usr/include/suitesparse
142
-- Could NOT find PathFerris (missing: PathFerris_LIBRARIES)
143
-- Could NOT find PathVI (missing: PathVI_LIBRARIES)
144
CMake Error at /usr/local/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:281 (message):
145
  find_package_check_version(): Cannot be used outside a 'Find Module'
146
Call Stack (most recent call first):
147
  /usr/local/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:530 (find_package_check_version)
148
  cmake/FindPythonModule.cmake:63 (find_package_handle_standard_args)
149
  numerics/swig/CMakeLists.txt:40 (find_python_module)
150

151

152
-- Configuring incomplete, errors occurred!
153
See also "/home/runner/work/siconos/build/CMakeFiles/CMakeOutput.log".
154
See also "/home/runner/work/siconos/build/CMakeFiles/CMakeError.log".
155
Error: Process completed with exit code 1.

Fixed in 6b8d3fa801d7626d9c8bdf064eec4b54e0ea2673

Fixed in 6b8d3fa801d7626d9c8bdf064eec4b54e0ea2673