interactive training issue

Rasa Core version: master
Python version: 3.6
Operating system (windows, osx, ...): osx
Issue:
When I am running interactive learning and when i am on the slot part, after utter_ask_thesis, it should come with a requested_slot right?
But it went to ask user input (action_listen), then the next action I pick is the slot action I define in actions.py, which is action_topic.
The stories generated by the interactive learning is like this:
...
* confirm_completion
    - utter_ask_thesis
* thesis1
    - action_thesis
    - slot{"requested_slot": "slot_thesis"}
...

This resulted in showing the slot_thesis has no value when I run the bot
The stories should look like this right? First, after utter_ask_thesis comes with a requested_slot, then after action_listen and user input followed by action_thesis and slot_thesis to store the slot.
...
...
* confirm_completion
    - utter_ask_thesis
    - slot{"requested_slot": "slot_thesis"}
* thesis1
    - action_thesis
    - slot{"slot_thesis": "my thesis statement is xxxxxxxxxxxx"}
...

actions.py
from __future__ import absolute_import
from __future__ import division
from __future__ import print_function
from __future__ import unicode_literals

import os

from bot import RestaurantAPI
from rasa_core_sdk import Action
from rasa_core_sdk.events import SlotSet
"""
from rasa_core import utils
from rasa_core.agent import Agent
from rasa_core_sdk.events import *
from rasa_core.featurizers import (
    MaxHistoryTrackerFeaturizer,
    BinarySingleStateFeaturizer)
from rasa_core.interpreter import RasaNLUInterpreter
from rasa_core.policies.memoization import MemoizationPolicy

"""
from rasa_core_sdk.forms import (
    BooleanFormField,
    EntityFormField,
    FormAction,
    FreeTextFormField
)
import logging

logger = logging.getLogger(__name__)

class BookingInfo(object):
    def save(self, slot_topic):
        logger.debug("-------slot_topic---------")
        logger.debug(format(slot_topic))
        logger.debug("-------slot_topic---------")

        return
class ThesisInfo(object):
    def save(self, slot_thesis):

        logger.debug("-------slot_thesis---------")
        logger.debug(format(slot_thesis))
        logger.debug("-------slot_thesis---------")
        return
class ThesisUpdateInfo(object):
    def save(self, slot_ThesisUpdate):

        logger.debug("-------slot_ThesisUpdate---------")
        logger.debug(format(slot_ThesisUpdate))
        logger.debug("-------slot_ThesisUpdate---------")
        return

class ActionTopic(FormAction):

    RANDOMIZE = False

    @staticmethod
    def required_fields():
        return [
            EntityFormField("slot_topic", "slot_topic")

        ]

    def name(self):
        return 'action_topic'

    def submit(self, dispatcher, tracker, domain):

        Bookinginfo = BookingInfo()
        booking = Bookinginfo.save(tracker.get_slot("slot_topic"))
        #indexFile_topic = open('C:/Users/e8180/Documents/sfu/py_rasabot/dd0628/dd/' + 'testextract.txt', 'a+')
        #indexFile_topic.write(tracker.get_slot("essay_topic") + str('\n\n'))
        #indexFile_topic.close()
        #return[SlotSet("matches", booking)]
        return[]

class ActionThesis(FormAction):

    RANDOMIZE = False

    @staticmethod
    def required_fields():
        return [
            FreeTextFormField("slot_thesis")

        ]

    def name(self):
        return 'action_thesis'

    def submit(self, dispatcher, tracker, domain):

        Thesis_Info = ThesisInfo()
        booking = Thesis_Info.save(tracker.get_slot("slot_thesis"))

        return[]

class ActionThesisUpdate(FormAction):

    RANDOMIZE = False

    @staticmethod
    def required_fields():
        return [
            FreeTextFormField("slot_ThesisUpdate")

        ]

    def name(self):
        return 'action_ThesisUpdate'

    def submit(self, dispatcher, tracker, domain):

        ThesisUpdate_info = ThesisUpdateInfo()
        booking = ThesisUpdate_info.save(tracker.get_slot("slot_ThesisUpdate"))

        return[]

Content of domain file (if used & relevant):
intents:
  - greet
  - request_essay_help
  - choose_argument
  - choose_no
  - confirm_completion
  - topic
  - thesis1
  - thesis2
  - goodbye
  - out_of_scope
  - thesis_help
  - topic_help
  - modify_thesis
  - reading
  - argumentation
  - counterargument
  - start
  - evaluatethesis
  - out_of_scope

actions:
- utter_greet
- utter_show_reading_list
- utter_need_other_help
- utter_tell_me_more
- utter_modify_thesis
- utter_focused_info
- utter_arguable_info
- utter_type_of_help
- utter_refer_TA
- utter_ending_print_conv
- utter_confirm_thesis_arguable
- utter_confirm_thesis_focused
- utter_thesis_define
- utter_try_reading_stra
- utter_reading_stra
- utter_open_reading
- utter_have_reading
- utter_not_related_ed
- utter_have_topic
- utter_knowing_thesis
- utter_have_thesis
- utter_ask_topic
- utter_ask_thesis
- utter_ask_ThesisUpdate
- action_topic
- action_thesis
- action_ThesisUpdate
- utter_default

entities:
  - slot_topic
  - slot_thesis
  - slot_ThesisUpdate

slots:
  slot_topic:
    type: text
  slot_thesis:
    type: text
  slot_ThesisUpdate:
    type: text
  requested_slot:
    type: unfeaturized

templates:
  utter_default :
  - text: "Sorry, I didn’t understand that"
  utter_greet:
  - text: "Hi, welcome to nStudy Bot"
    buttons:
    - title: "Get me started"
      payload: "Get me started"
  utter_show_reading_list:
  - text: "Here's the link to the reading resources for EDUC 220 final essay. Please open the link below. Click Done when you finished."
    buttons:
    - title: "Done"
      payload: "Done"
  utter_tell_me_more:
  - text: "Sorry. I am not smart enough to help you with this. Could you tell me more about your issues?"
    buttons:
    - title: "OK"
      payload: "OK"
  utter_ask_ThesisUpdate:
  - text: "What is your new thesis statement?"
  utter_modify_thesis:
  - text: "Do you want to modify your thesis statement?"
    buttons:
    - title: "Yes"
      payload: "Yes"
    - title: "No"
      payload: "No"
  utter_focused_info:
  - text: "A focused thesis statement means that your thesis statement should not be too broad. For example, bullying can affect children's cognitive development. The example thesis statement is too broad. You must say something like this: Bullying can affect children's cognitive development because A, B, and C. Referring to the handout here for more information. "
    buttons:
    - title: "Okay"
      payload: "Okay"
    - title: "Okay. Go to handout...develop in the future"
      payload: "Okay. Go to handout"
  utter_arguable_info:
  - text: "A thesis statement should not be a fact, which means that somebody can disargee with your thesis statement. This is what an arguable thesis should be. Check out the handout here for more information. "
    buttons:
    - title: "Okay. Take me back"
      payload: "Okay. Take me back"
    - title: "Okay. Go to handout"
      payload: "Okay. Go to handout"
  utter_type_of_help:
  - text: "Which of the following help do you need?"
    buttons:
    - title: "Help me come up with a topic for essay"
      payload: "Help me come up with a topic for essay"
    - title: "Plan my essay outline"
      payload: "Plan my essay outline"
    - title: "Thesis statement"
      payload: "Thesis statement"
    - title: "Argumentation"
      payload: "Argumentation"
    - title: "Counterarguments"
      payload: "Counterarguments"
    - title: "Reading strategies"
      payload: "Reading strategies"
    - title: "Strategies for polishing my essay"
      payload: "Strategies for polishing my essay"
    - title: "Evaluating my essay's thesis statement"
      payload: "Evaluating my essay's thesis statement"
    - title: "Goal Setting for studying"
      payload: "Goal Setting for studying"
  utter_refer_TA:
  - text: "At this point, I recommend you go for TA or your instructor for help. Ok?"
    buttons:
    - title: "Okay"
      payload: "Okay"
  utter_ending_print_conv:
  - text: "Thank you for using nStudy Bot. Do you want to print our conversation?"
    buttons:
    - title: "Yes"
      payload: "Yes"
    - title: "No"
      payload: "No"
  utter_need_other_help:
  - text: "Do you need any other help?"
    buttons:
    - title: "Yes"
      payload: "Yes"
    - title: "No"
      payload: "No"
  utter_confirm_thesis_focused:
  - text: "Is your thesis statement focused?"
    buttons:
    - title: "Yes"
      payload: "yes"
    - title: "No"
      payload: "no"
  utter_confirm_thesis_arguable:
  - text: "Is your thesis statement arguable/contestable?"
    buttons:
    - title: "Yes"
      payload: "yes"
    - title: "No"
      payload: "no"
  utter_thesis_define:
  - text: "In university writing, a thesis statement is typically a sentence or two which establishes your argument and forecasts the main points your paper will argue. It is the backbone of your paper, because everything that follows should support this central argument. A thesis has to be arguable/contestable and cannot be a statement of fact. Do you understand? "
    buttons:
    - title: "Yes"
      payload: "yes"
    - title: "No"
      payload: "no"
  utter_ask_thesis:
  - text: "What is your thesis statement?"
  utter_try_reading_stra:
  - text: "Would you like to try one of the following reading strategies? "
    buttons:
    - title: "Highlighting"
      payload: "Highlighting"
    - title: "Note-taking"
      payload: "Note-taking"
    - title: "Summarizing"
      payload: "Summarizing"
    - title: "Outlining"
      payload: "Outlining"
    - title: "Show me termnet"
      payload: "Show me termnet"
    - title: "I do not want to try any of these"
      payload: "I do not want to try any of these"
  utter_reading_stra:
  - text: "Did you do any of the followings when you consulted your reading resources? For example, highlighting, notetaking, summarizing, outlining, or mindmapping? "
  utter_open_reading:
  - text: "Open and review the reading resources.  Let me know when you are done. "
    buttons:
    - title: "Done"
      payload: "Done"
  utter_have_reading:
  - text: "Do you have any reading resources? "
    buttons:
    - title: "Yes"
      payload: "yes"
    - title: "No"
      payload: "no"
  utter_not_related_ed:
  - text: "Could you find a topic in educaitonal psychology that is related to {slot_topic}? "
    buttons:
    - title: "Yes"
      payload: "yes"
    - title: "No"
      payload: "no"
  utter_show_topic:
  - text: "What kind of topics in educational psychology that you know about?"
  utter_ask_topic:
  - text: "What is your topic?"
  utter_have_topic:
  - text: "Do you have a topic in mind?"
    buttons:
    - title: "Yes"
      payload: "yes"
    - title: "No"
      payload: "no"
  utter_knowing_thesis:
  - text: "Do you know what a thesis statement is?"
    buttons:
    - title: "Yes"
      payload: "yes"
    - title: "No"
      payload: "no"
  utter_have_thesis:
  - text: "Do you have a thesis statement?"
    buttons:
    - title: "Yes"
      payload: "yes"
    - title: "No"
      payload: "no"

Thanks for raising this issue, @Ghostvv  will get back to you about it soon.

It is hard to understand where exactly is the issue. Could you please restructure your question, indicating where is an error, what is returned by rasa, and what is expected by you

any update?

action_thesis being the form, emits utter_ask_thesis automatically, so you should call action_thesis instead. There story would look something like:
...
* confirm_completion
    - action_thesis
    - slot{"requested_slot": "slot_thesis"}
* thesis1
    - action_thesis
...

action_thesis being the form, emits utter_ask_thesis automatically, so you should call action_thesis instead. There story would look something like:
...
* confirm_completion
    - action_thesis
    - slot{"requested_slot": "slot_thesis"}
* thesis1
    - action_thesis
...

But if I am manually adding the stories, should I use the format below (like the one shown as an example on Rasa docs) or same as the one you just said?
* confirm_completion
    - utter_ask_thesis
    - slot{"requested_slot": "slot_thesis"}
* thesis1
    - action_thesis
    - slot{"slot_thesis": "my thesis statement is xxxxxxxxxxxx"}

for FormAction, please take a look at the docs here: https://www.rasa.com/docs/core/slotfilling/#slot-filling-with-a-formaction
there is an example of the story for restaurant form
Since there is no bug, and this is a discussion on how to use the FormAction, please go to our forum: https://forum.rasa.com


You good bro?

Imagine banning someone just for saying this https://github.com/dgtlmoon/changedetection.io/pull/1909#issuecomment-1783883745
yikes

We don't need this here. They are a very attentive and diligent developer. They were working with you on it and offered some solutions and needed some more testing done. All you had to do was adjust the tag to what was suggested and reopen it, but instead you did this? They resolved it here https://github.com/dgtlmoon/changedetection.io/pull/1912
Perhaps it would have been polite to offer you a chance to adjust it yourself, but I think @dgtlmoon is accustomed to working as a solo dev without many thanks.

All you had to do was adjust the tag to what was suggested and reopen it,

All I did was open the PR, respond to his suggestion that the documentation was not consistent with his suggestion, and I was banned. Nothing else. What part of that justifies banning me?

I created this account after I was banned. How is that a relevant reason?


Logging of EyeGaze data to csv file is culture-specific

https://github.com/microsoft/MixedRealityToolkit-Unity/issues/5184
On certain locales, the CSV delimiter isn't the comma, but the semicolon instead.
Previously, we assumed that the delimiter would always be the comma, but this would cause problems in cases like de-DE where numbers are written with commas (instead of decimals) to represent the decimal digits.
So for example, en_US:
123.123, ABCABC, XYZXYZ
Without this change, it would look like this on de_DE
123,123, ABCABC, XYZXYZ
This is obviously totally wrong - now we have four cells, it doesn't make sense!
The solution is to use the real delimiter for the current locale:
123,123; ABCABC; XYZXYZ

/azp run mrtk_pr

Ehm, doesn't CSV stand for Comma Separated Values? 🤨 I'm not sure what you mean with "Without this change, it would look like this on de_DE: 123,123, ABCABC, XYZXYZ". On what do you mean?

Yeah it's actually SCSV.
The leading s is silent though

But actually:
https://stackoverflow.com/questions/8092718/how-do-i-detect-the-users-locale-to-get-the-correct-csv-separator
https://superuser.com/questions/606272/how-to-get-excel-to-interpret-the-comma-as-a-default-delimiter-in-csv-files

But actually:
https://stackoverflow.com/questions/8092718/how-do-i-detect-the-users-locale-to-get-the-correct-csv-separator
https://superuser.com/questions/606272/how-to-get-excel-to-interpret-the-comma-as-a-default-delimiter-in-csv-files

Interesting! Thanks for addressing it, Will!

to avoid this issue is double-quote the relevant decimal numbers within the CSV file as such: "10,20", "1,50", "This is another column"

Was there a reason you went with semicolon over wrapping in "?


Javascript Library and other suggestions

First off, love the framework! Really great, clean design, implements many common components flawlessly, yet is incredibly tiny.  (filesize-wise)
Do you have any plans for writing a JS library for interactions with various components, eg .menu, .modal, and .toast? If you haven't or have but have not implemented it yet, I have a few files for said components that could provide a jumping-off point for writing these JS interactions; they're simple, curt, and use vanilla JS.
Other suggestions:

Include Sass port (this may be able to be done by simply changing all @variable instances to $variable, but I may be mistaken)
I resized my window after happily sketching a site in Spectre for a few hours, and I noticed that it's not very responsive relative to the numerical value of column sizes. (ie column widths do not scale consistently with screen size adjustments) This image shows that the .col-8 class, along with apparently all other .col-x classes simply default to 50% between 481px and 840px. There may have been a reason for this, but I am not picking up on it.
Design an adorable/menacing spectre logo for the framework!

I am more than willing to help with any of the above, and will likely be throwing some PRs your way.

Thank you. I haven't any plan on JS library for .menu, .modal or .toast.

I will see if more people need Sass version.
Updated this week. Now Spectre provides .col-xs-, col-sm-, col-md-.
Sure.

Thank you. 😄

@picturepan2 I cleaned up and updated the javascript that I previously wrote. Still could use some work, but this will give you some idea of what I was shooting for. Here is the link.
I have 3 files so far, one for menus, modals, and toasts each; technically there could be 4, as I added support for an arrow pseudo element that could switch orientation on click, but I don't know if you wanted that in the project.

menu.spectre.js handles toggling menus, and works best when .hide is applied in the menu's html. Currently, only clicking the toggling element will open/close the menu.
modal.spectre.js handles opening modals using a button/link, and closing the modal via either .btn-clear button, a link that has data-target=#idOfModal/data-close="modal", or clicking the modal overlay.
toast.spectre.js handles closing toasts; this obviously only works on the frontend, and perhaps I will write in a function or method that will allow a callback on closing toasts, so developers can write an API-handling event when a modal closes.

Like I said, these are kind of rough, and only use ES6/vanilla JS. If you like the idea, I can optimize these and write more .js files.

Thank you. I think I will wait and see if other people need JS example codes, maybe just jQuery or Angular examples. Firstly, I need to perfect basic CSS codes.

First, thanks for this amazing project. So simple, clean and powerful! Second, would be great to have a Sass variant (scss).

@victorwpbastos May I know why you want Sass variant?

@picturepan2 The reason I suggested it originally is because not every one uses LESS, which is fine, and some people would like to compile it during development with custom variable settings.

Sass is just a personal preference. Many CSS frameworks are using Sass instead Less. But I repeat: is just a personal preference.

Thank you both. Do you know tools to keep Less and Sass coexist and synced?

Maybe maintain the two flavors (Less and Sass) won't be a good idea. If you like Less keep Less. No problem.

OK. I will keep Less. I will read more about Sass to see if Spectre.css needs.

@picturepan2 sass would be an important port! any reason for less implementation?

SASS version would be great.

SASS version  +1

Generally i use Foundation or Bootstrap, and there is a Foundation feature that nobody offers, it's list-block-grid support. In few words if you have a list you can specify how many elements display per each row without breaking the list.

No. I dont think SASS version make situation more better. It make things worse! Support two versions is harder. And its make more time to review pull requests and and test everything

I have seen a lot of projects move from less to sass, but never from sass to less.

Moved from Less to Sass. Bootstrap now compiles faster than ever thanks to Libsass, and we join an increasingly large community of Sass developers.

To me it's a bit like underscore vs lodash.

@IgnisFire I don't think anyone is suggesting @picturepan2 should support 2 different versions, at least not concurrently. If he were to offer a Sass port and did not want to maintain both, he could release stable Sass versions at major framework versions.
I see the benefit from moving away from LESS to Sass, as @jakobrosenberg pointed out, Sass is faster, and offers (AFAIK) more options for compiling in a variety of languages, including node.js, ruby, python, and more.
On top of this is that a majority of development blogs/articles/developers I'm aware of use Sass to compile their styles into CSS. All these benefits point to Sass being a better pre-compiled language to use for customizing Spectre.css.

@All, I plan to switch to Sass and release a stable version of Less. Thank you.

I like the idea of @geoffdavis92 to add JavaScript and I even more like the idea of not using dependencies. However, I looked at the code I'd really recommend not to touch prototypes as it is considered to be (very) bad practice.
Adding some kind of simple bundler (e.g. Rollup) could be useful to provide some kind of internal structuring without the hassle of using a sophisticated build chain.

Sass!! Sounds good!!

@dak0rn Yeah I only added that because I somehow forgot about Array.forEach, and was too lazy to look it up.
Sometime soon I'm going to generally clean up the scripts and I'll remove my prototype edit.

@geoffdavis92 just wanted to mention it.
I hope a possible JavaScript part is not going to target non-ES5.1 environments like the Internet Explorer 8, because that would introduce quite a nasty limitation.

I think it's best to leave Javascript out of the picture and for Spectre to remain a focused CSS / Design library while encouraging JS component libraries to be built on top of the framework. Salesforce's design system is a good example of how to go about this. https://www.lightningdesignsystem.com/

Spectre is really simple and I support the idea of keeping Sectre CSS only as well because it is easy to add any existing JS plugin on top of the layout. And supporting SASS would be "just what doctor ordered".

@imanhodjaev That's what I'm feeling is the consensus.
I'll likely release my library as a "plugin", after cleaning it up and building it out a bit. Not sure how I could brand it, but that's a topic for another time 😄

I confess that I just did not begin to use the Spectre because it is not in Sass. It would be great to work with Spetre in Sass.

Converting the less-code to sass cost me 5 minutes. You only need to replace the @-sign for variables with the $-sign and add mixins+imports instead of the classes which are used for global usage of styleheets. It can't be easier...

what about the js modules idea?
I think it would be a nice benefit if you can add optional "official" spectre js modules to the page to extend the css functionality of individual elements/components.

Please don't make JS an integral part of this framework: I choose it over bootstrap/foundation specifically because it was pure CSS only.
I thinks it is ok to make optional scripts for simple interactions (like a jquery plugin or some vanilla code) and like a reference for implementation but, since Js is so opinionated, writing any kind of code will probably lead to a dozen of variants (react, angular, angular2, kendo,....) with many build systems integrations and feature requests.
I think that this is out of scope for a lightweight library like this and, if forced to reference a Js to use the components, I will just stop updating it and fork it locally.
Just my two cents.

@IlBaffo I agree.
I'm currently writing a standalone Javascript library using vanilla js to interact with various spectre.css components.
I finished writing a preliminary version of handling .tab.tab-group last night, will push up in a few hours.
I like spectre for the same reasons you do, but if I can write a simple js library to interact with spectre, I think that'd be helpful to a lot of folks. Not everyone has the time/patience/skill to roll their own. Again, this will be completely optional and unofficial. (I've extended an offer to @picturepan2 to house everything under an org like #50 suggests, but it's entirely up to him. Even still this would just be a completely optional library)

@geoffdavis92 I have to +1 the notion of keeping JS out of the equation. Keeping it CSS only means that it can be integrated with any framework you want without much issue. At the minute, I'm demoing dropping it into Angular 2 and it works a treat (tabs handled via bindings)

For me one of the reasons to choose spectre was that it is CSS only. I use bootstrap in another project. The javascript part modifies the HTML elements so that customizing the boostrap elements is not fun.
Please don't add JS support.

There's already several different javascript implementations that I know of. (vue, can, etc) Would it be helpful for anyone to have a page in the docs or somewhere called "JS implementations" with links to the projects?

I'd contribute to that

spectre css logo for attribution link? and where I can find a collaboration partner(who used to be a spectre css hobbyist  for a open source project)?

@faststare what's the project?

@aaron-bond an accounting web app that have philippine government features(taxation handling and gocc handling).

I think it'll be a great idea to create a react.spectre much like how a react.semantic-ui exists.
@geoffdavis92 the library you're creating, does that provide any sort of react components, or is it to be used outside react.

@faststare You need a Spectre.css logo in which sizes?

Is there a logo? I'd put one on my project site also.

@zusamann React is future.. Or better.. Is Present.. Maybe a good moving idea in this regard.

@zusamann @AdsonCicilioti me, probably like @IlBaffo and many others have chosen this framework because of 2 main great features:

It is Lightweight (~10KB gzipped)
It has no integral JS

Those 2 facts make it unique, special and different from most of what you can find out there. It is not one more framework trying to do all the work or providing whatever feature you may need like if it was some kind of software a browser need to download on each visit. It is fast because it is simple. Please if you need a Javascript Library for it consider making a fork and adding that to a different repo.

Again, this will be completely optional and unofficial.

Oh sorry I didn't see that. In that case I 100% agree :)

Could I also suggest a sticker board, or something like sketchapp.com for designers.

@flyboarder What is a sticker board?

Usually a collection of the components for prototyping.
https://material.io/guidelines/resources/sticker-sheets-icons.html

@geoffdavis92 v0.4.0 is in SASS/SCSS now.


IncludeOS website domain

Feel free to delete this, but in case it might be considered helpful:
I read on HN there is an unfortunate issue with the present "includeos.org" domain ownership.
As I have some experience in this area, out of curiosity I had a look at other TLD's presently available for the term. There was one that struck me as potentially quite suitable: ".io". This TLD, despite commonly being associated with development projects, is also the acronym for "IncludeOS". Further, it's also sort of currently in use - via the very similar to "includeos.github.io".
Alternatives I could see available too were .net and .com, while .dev seemed another potential. These are all generally cheaper than ".io", though could also be considered a little bland. I believe the value of having strong URL branding shouldn't be underestimated - just like a name itself, it can dramatically affect the ability to attract developers and users.
Given IncludeOS has such a strong brand already, it seemed a shame the situation with the current URL. By acquiring a new replacement domain, any squatter would suffer the ultimate loss with regard to their "investment", while IncludeOS would conversely expends minimal cost and resolve the matter in the shortest timeframe, versus any potentially protracted litigation scenario.
As I mention - of course, feel free to discard this (unsolicted!) advice - and regardless, I wish you all the best with the project.

That's very helpful. We'll have a chat about it and see if that's something we'd like to do. Thank you!


Feature proposal: replacing the image cropping with fitting.

The idea behind this feature is to take the pros of cropping and of making
thumbnails without the cons of each.
Cropping:

Doesn't mess with the design (alignment);
Issue: may require the usage of external software to ensure the pictures are squared, otherwise they may render in an ugly way.

Thumbnail:

Fix the above cropping's con;
Issue: may mess with the design (different heights).

So, what this feature does, is:

Makes a thumbnail of the given pictures;
Fill the void with a white background (by default);
Then, just relax with the time you saved. :)

Before

After

Edit: can't do much about codeclimate being angry, sadly.

Codecov Report

Merging #1772 into master will increase coverage by 0.05%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master    #1772      +/-   ##
==========================================
+ Coverage   83.16%   83.21%   +0.05%
==========================================
  Files         141      141
  Lines        6119     6138      +19
  Branches      665      664       -1
==========================================
+ Hits         5089     5108      +19
  Misses        859      859
  Partials      171      171

Impacted Files
Coverage Δ

saleor/product/templatetags/product_images.py
95.58% <95.65%> (+1.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad47e9f...c560c79. Read the comment docs.

I like this change. I think in most cases cropping product images is not a good idea.

Question: could we achieve the same using CSS combined with disabling crop?

Question: could we achieve the same using CSS combined with disabling crop (without introducing a new thumbnail filter)?

My current best solution is using a fixed height on the image container and using object-fit: contain on img. Which achieves the same results as this pull request. (See: https://github.com/NyanKiyoshi/saleor/commit/fae206ebf136eb71c3d715fe4eea03e0b35bd196 for the changes.)

My first solution was to use flexboxes (see https://github.com/NyanKiyoshi/saleor/commit/0715d3c46a59075de9d2ef12dcb34a3fcf9c2207), it works. It's just great... But if the text is too long, it messes with the design.
When just right:

When bad:

I'll be waiting to hear back from you. Also, we should probably apply this (the CSS) in the order details and in the dashboard as well.


Communication Identity | Idempotency implementation

Packages impacted by this PR
communication/communication-identity
Describe the problem that is addressed by this PR

Regenerated the REST client from the latest Swagger file

Repeatability headers (Repeatability-Request-Id & Repeatability-First-Sent) are generated, added and sent to the API when using this library.

Added a new API version CommunicationIdentityServiceVersion.V2023_08_01 that is now the default API version.
Updated recordings for tests (pending)
Updated CHANGELOG & README

Swagger : Communication Identity Swagger
Swagger Spec PR : https://github.com/Azure/azure-rest-api-specs/pull/22306
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.

This is blocked for now. Will work on it once service changes are deployed.

Hi @mjafferi-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

This is blocked for now. Will work on it once service changes are deployed.

Hi @mjafferi-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

This is blocked for now. Will work on it once service changes are deployed.

Hi @mjafferi-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

This is blocked for now. Will work on it once service changes are deployed.


Issues detected during MEF testing

@iluxonchik, I am adding here the issues we detected and discussed in our previous meeting:

[ ] Consideration vote was still available for a little while after the consideration phase ends

[ ] Cancelling a proposal from admin does not delete it

[ ] If the proposal thread is deleted manually from the forum, then editing the proposal does not work (or some similar functionality)

[ ] Add/force associate proposal to the new forum channel thread. This essentially force created a new forumThreadId for the user

[ ] Vote counting: The deliberation phase is showing proposals in all statuses (including consideration), not just deliberation

[ ] In proposal details, if the reviewer is changing their vote, they should be able to see their previous rationale in the embed

[ ] Community deliberation: we need a DB or a button to gather community sentiment from the deliberation phase. This should be sorted by using the GPT summarizer in the future. - this point is for product increment.

[ ] Writhing on a thread affects the Proposal status, need to solve the status issue.

@iluxonchik Please mark the Items that are finished for the MVP and inform wich ones will be moved to improvements. tks!
Cc: @remigiusz-antczak


after 12-15h of running nothing happend

I'm not sure why but after like 12h - 15h of running, then whatever i do next isn't reported to the code anymore.....
any Idea?
Thanks

How to install it in termux
Will you please indify it more easy
I'll appreciate you
Ty

How to install it in termux
Will you please indify it more easy
I'll appreciate you
Ty

what do you mean? identify my problem or identify how to run line-py?

Yes Basher bro

Yes Basher bro

which one..... it's a question with a choice.... you can't answer yes......

Aslam o Alekum
Bro I was thinking it's kicker bot , or group protect bot
Will you please suggest me any script
I'll appreciate and thanks full to u


Add Indonesia translations with my original translate.

I'm from Indonesia, and i work for this issue with my original grammer not google translate. hope i can contribute for this issue. thank's.

@hnifmaghfur - Definitely like this one. But I do want to check with @sharur7 to see if  WIP PR https://github.com/openebs/openebs/pull/3224 can be closed in favor of this new PR.

sure, i'll be waiting for review.

Thank you @hnifmaghfur You can sign up for Hacktoberfest swag from MayaData by entering details here: https://github.com/mayadata-io/swag/issues/new/choose.
Also, can you follow up with another PR that just removes this line [id](translations/README.id.md) from README.id.md


Sarah's dialogue misspells doppelganger.

In the New Game Plus variant universe where you encounter your non-starborn self when you arrive at the Lodge, Sarah's dialogue contains a misspelling for doppelganger. It is spelled doppleganger instead.

Game Version
1.7.36
Language
English (EN)
New Game
Yes
Reproduction Steps
Go to the Lodge on a New Game Plus where you encounter the non-starborn version of yourself and listen to Sarah's dialogue.

Fixed on Issue #730


codes not being recognized

unimplemented gcode command: M117
unimplemented gcode command: M300

M series codes are machine specific.
If I had to guess, you are using Marlin firmware, where M117 corresponds to setting a message on an LCD panel, and M300 is for playing a tone. Neither of these codes affects the visualization of the code you are trying to send. If your machine responds normally, the presence should also not affect sending the file.
The warnings are intended to be rendered because it was as an unrecognized code, and without knowing your exact machine/firmware; it's safer to alert you to the issue.
Side note: Chrome is dropping support for chrome apps in a few months. I don't expect there will be any further updates to chrome-gcode-sender.

Thank you, I am using an Ender 5 Pro, it is my first machine and I just got it. I like your gcode-sender, will it continue to work even if no longer supported?

https://blog.chromium.org/2020/01/moving-forward-from-chrome-apps.html outlines the schedule when chrome apps will stop  working.
gcode-sender utilizes a special serial API, for which the alternative is not yet generally available.


Video source loading before replaced with value

Related to #470

<video controls preload="auto">
    <source src="{{VideoUrl}}" class="video-sd" type='video/mp4'>
</video>

Edge will try to resolve the src. (It will not show in network tab, but I intercepted the network traffic using fiddler, and I found this because my server tells me many NotFound exceptions with mustache variables in request).
This is already in <script> or <template> tag.
Is there a way to prevent this from happening?

Not really too valuable, but just to give you some feedback at least: I don't know of any other way. Haven't played too much with Edge so far.

Would it be feasible to cut attributes or tags apart?
<vid{{! -}}eo controls preload="auto">
    <sou{{! -}}rce sr{{! -}}c="{{VideoUrl}}" class="video-sd" ty{{! -}}pe='video/mp4'>
</vid{{! -}}eo>

I tried to recreate this using edge and this following src and wasn't getting any attempted load:
<!DOCTYPE html>
<head>
  <template id="#video-row">
    <video controls preload="auto">
      <source src="{{VideoUrl}}" class="video-sd" type='video/mp4'>
    </video>
  </template>
</head>

<body>
</body>
</html>

When I attempted to use the script tag I got an error but the template tag seems fine.

@Romanx How did you track the requests? As stated in the original post, network tab will not show the request attempt. It still does attempt, just like loading sourcemaps and similar requests, this will not be shown in network tab.

@max-buecker I'm sorry to say i didn't notice that in the original post, I was looking at the network tab. It looks like an edge bug to me as it really shouldn't be trying to load it when it's in a template/script tag.

Ok, I can confirm, that banging the src attribute with a comment will resolve this exact issue:
<vid{{! -}}eo controls preload="auto">
    <sou{{! -}}rce sr{{! -}}c="{{VideoUrl}}" class="video-sd" ty{{! -}}pe='video/mp4'>
</vid{{! -}}eo>

It's not beautiful, but it works


Rename health check URL parameter to path.

Also improve documentation.
@emilevauge @dtomcej as discussed on Slack.

CI green, this is ready for review: @containous/traefik

@vdemeester the feature wasn't available in the previous release yet. We kind of agreed on Slack that changing in the v1.2 branch is still acceptable and doesn't count as a "breaking API change".
WDYT?

@timoreimann ohhh 👼 right, nevermind.. didn't see that it was the branch, etc…

@timoreimann great job, thanks :)
LGTM


Improve add_requires and find_package to integrate the 3rd package manager

Roadmap

[x] add_requires("XXX::pkgname") -> package.manager.install_package("XXX::pkgname")

[x] conan::zlib/1.2.11@conan/stable
[x] vcpkg::zlib
[x] brew::pcre2/libpcre2-8

[x] lib.detect.find_package("XXX::pkgname")

[x] conan::zlib/1.2.11@conan/stable
[x] vcpkg::zlib
[x] brew::pcre2/libpcre2-8
[x] pkg_config::zlib

[x] Add builtin api find_packages("XXX:pkgname", "zlib") to find multiple packages
[x] Custom integration with the other package manager

Conan

[x] pass platform settings
[x] pass architecture settings
[x] pass build mode settings
[x] pass compiler settings

[x] gcc
[x] clang
[x] msvc

[x] cross-platform test verification

[x] macOS x86_64
[x] linux/ubuntu x86_64
[x] windows x86/x86_64

[x] install_package("conan::xxx", config = {})

[x] settings, e.g. settings = {"compiler=gcc", "compiler.version=4.9"}
[x] build_requires, e.g. build_requires = "xmake_generator/0.1.0@bincrafters/testing"
[x] build, e.g. build = "all"
[x] options, e.g. options = {"OpenSSL:shared=True"}
[x] imports
[x] remote, e.g. remote = "https://api.bintray.com/conan/bincrafters/public-conan"

conan-xmake_generator
conan-xmake_installer
https://github.com/tboox/xmake/tree/dev/xmake/modules/package/manager/conan

Related issues
#327 Integrate with Conan package manager
#184 Improve lib.detect.find_package to support vcpkg
#69 Remote package management
#331 Creating xmake_generator for Conan
#330 Creating xmake_installer conan package
#332 Creating xmake "Build Helper" for Conan

Add clib support https://github.com/xmake-io/xmake/issues/397


AthenaLoader profile type hinting is incorrect

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
        athena_loader = AthenaLoader(
            query=f"SELECT 1",
            database="default",
            s3_output_uri="s3://fake-bucket/fake-prefix",
            profile_name=None,
        )

This code works but the type hinting is incorrect which results in error warnings from type checkers.
Error Message and Stack Trace (if applicable)

Description
The Athena loader has code to handle a non-profile. I think should be an optional kwarg like this:
profile_name: Optional[str] = None,

System Info
System Information

OS:  Darwin
OS Version:  Darwin Kernel Version 23.5.0: Wed May  1 20:12:58 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T6000
Python Version:  3.11.4 (main, Mar 26 2024, 16:28:52) [Clang 15.0.0 (clang-15<IP_ADDRESS>)]

Package Information

langchain_core: 0.2.25
langchain: 0.2.11
langchain_community: 0.2.10
langsmith: 0.1.94
langchain_openai: 0.1.19
langchain_postgres: 0.0.9
langchain_text_splitters: 0.2.2
langgraph: 0.1.17

Packages not installed (Not Necessarily a Problem)
The following packages were not found:

langserve

I'm happy to raise a PR for this. Just raising the issue before I do that.


VSC instructions for creating and running a new project

You’re missing a step after this – required assets
From Scott’s earlier email I gathered that’s not needed if you use dotnet run, is that incorrect?

You need to explain the dialog. Seem's easier to click yes than dismiss it.
cc @tdykstra

@scottaddie Can this be closed as a dup of (included in) #9488 ?


Incorrect routing when using generateStaticParams

Hi,
We have had an issue relating to generateStaticParams, and have managed to narrow it down to being an OpenNext issue. The project consists of dynamic route segments and folder based routing, like this:

app/[locale]/[...slug]/page.tsx
app/en-gb/examples/example/page.tsx

The pages are fetched from our CMS and looped through to return the locale and slug for the dynamic route segments. To achieve the required URL structure, we have had to create empty pages within our CMS, which makes the folder based routing as seen above.
When developing locally with the production configuration, we can see that folder based routing is being served, as expected. Once deployed, the empty pages from the CMS is served instead, causing us to find workarounds to exclude these from generateStaticParams.
Happy to provide more information if required.
Versions
Next: 14.0.4 (app router)
SST: 2.38.4
OpenNext: 2.3.1

Hey can you try 2.3.3? If that fails, can you try the v3 rc? If both fail, we need to properly handle i18n... last I checked nextjs has issues with that too.

I have just tried 2.3.3, but it has not resolved the issue. Is it possible to target the RC using openNextVersion? If so, how? Thank you!

You need to use a custom SST  to test V3 https://open-next.js.org/v3.
From what i understand, this will likely not solve your issue.
But i'm not sure i completely understand your issue though. Could you give an example of one of the empty return from generateStaticParams and what url you use to access this specific route.

Hi,
In the dynamic route, we have a generateStaticParams that does a fetch call to get all the pages from the CMS. This is then mapped through to populate the locale and slug segments:
export async function generateStaticParams() {
  const pages = await exampleCMSCall();

  return pages.map((page) => {
    // Logic to exclude duplicated pages

    return {
      locale: page.locale,
      slug: page.slug,
    };
  });
}

In the CMS, we have slugs like example/placeholder/test-page. The placeholder page is empty, but is required to create the page hierarchy in the CMS. We then have a static route for example/placeholder, which is supposed to render something custom. It is the static route that renders locally when visiting example/placeholder, which is what we expect. When deployed, it is the dynamic route (placeholder page) that renders, which is not what we want.
I hope that makes more sense.

Ok i think i got it.
Just a couple more precision, when you say it renders locally, you're talking about next start not next dev right ?
Also when you talk about the example/placeholder static page, you mean you have a [locale]/example/placeholder/page.tsx page or just a  example/placeholder/page.tsx ?
Last thing page.slug is an array right ?

Yes, it works with next start.
This is the two paths:

app/[locale]/[...slug]/page.tsx
app/en-gb/example/placeholder/page.tsx

For the first one of these, the route segments could be populated with "en-gb" and "example/placeholder", meaning that the URLs would be identical. With next start, it uses the static route, but not once deployed.
Finally, yes, page.slug is an array.

I've tried to replicate this issue locally quickly, but it doesn't even work with next start unless i set my en-gb/example/page.tsx as SSR, and then it also works deployed. Could you provide a minimum repro
I've created a [locale]/[...slug]/page.tsx
export function generateStaticParams() {
  return [
    {
      locale: 'en-gb',
      slug: ['example'],
    },
    {
      locale: 'fr-FR',
      slug: ['page'],
    },
    {
      locale: 'en-gb',
      slug: ['example', 'page'],
    }
  ]
}

export default function Page({ params: { slug }}: { params: { slug: string[] }}) {
  return (

Page

Dynamic

{slug.join('/')}

  )
}

My en-gb/example/page.tsx
export const dynamic = "force-dynamic"

export default function Page() {
  return (

Page

Static

  )
}

We should add another e2e (or update app-router) to use localization to catch these issues.

The repo here: https://github.com/leanderiversen/open-next-331. The structure matches the real repo, including all layout.tsx and page.tsx, although simplified.
I have not had time to deploy this, but I can see that the /en-gb/first/second/ uses the static path when running next start, which is the expected result.

I found the issue it's a next one, you should create an issue in next repo.
I cloned your repo run next build then next start and it worked as you've tested, but we need  output: "standalone" (we set this automatically via an env variable), as soon as i've rebuild and run either next start or node .next/standalone/server.js i get the dynamic route.
I let the issue open in case someone has the same issue, if you could update the issue with the issue you open in next repo that would be great

Thank you very much for investigating!

I will be closing this issue, as it appears to be fixed in one of the latest Next.js canaries.


How to create a directory link under /mnt that works in both bash and windows

Is there anyway to make a directory link that can be followed on both sides?
My use case is developing a npm package (actually typescript) and I want to use it from another package without publish/install for every change as I develop. The easiest way is to create as ln -s / Junction from the consuming packages node_module folder to the package.
I'm compiling etc in WSL and using @code on the windows side as by dev env
I can't get it to work. I ether tried creating a Junction AND and ln but get errors.
Thanks

@SteveALee - Thanks for the feedback. We are currently looking at ways to improve our symlink support to light up this exact scenario.  The changes are in progress so not firm ETA currently.

FYI @code language engines don't work with junction links - see https://github.com/Microsoft/vscode/issues/25312


Fix outdated code in text-moderation sample

Currently the code in the text-moderation sample throws an error as snap.val doesn't exist, since onWrite now receives a change object instead of a snapshot.

CLA signed.

Thanks @krawaller !


Clear out file input before click to allow user to select same file again

Inputs with a type of file store the file path in their value and if you select the same file again, you need to clear out the value so that the correct drop events can retrigger. Ran into this issue when a user was adding a file, deleting it via our file manager and then re-adding that file afterwards. This simply clears the input value before attempting to click it.

Thanks! Published to npm as v1.2.2.


Feature: add a subcommand to upgrade the CLI

Codecov Report

Merging #169 (4cbc51d) into main (c258d64) will decrease coverage by 5.78%.
The diff coverage is 34.95%.

:exclamation: Current head 4cbc51d differs from pull request most recent head 5c23f04. Consider uploading reports for the commit 5c23f04 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   67.65%   61.86%   -5.79%
==========================================
  Files          29       31       +2
  Lines        1280     1382     +102
  Branches      286      304      +18
==========================================
- Hits          866      855      -11
- Misses        345      463     +118
+ Partials       69       64       -5

Impacted Files
Coverage Δ

qgis_deployment_toolbelt/utils/file_downloader.py
32.43% <32.43%> (ø)

qgis_deployment_toolbelt/commands/cli_upgrade.py
34.37% <34.37%> (ø)

qgis_deployment_toolbelt/cli.py
83.56% <100.00%> (+0.22%)
:arrow_up:

qgis_deployment_toolbelt/utils/win32utils.py
44.00% <0.00%> (-36.00%)
:arrow_down:

qgis_deployment_toolbelt/profiles/shortcuts.py
44.92% <0.00%> (-23.92%)
:arrow_down:

...loyment_toolbelt/jobs/job_environment_variables.py
93.10% <0.00%> (-6.90%)
:arrow_down:


"used in model" NPE with white orbits

In some circumstances, showing "used in model" orbits will throw repeated NPEs if there are several unknown orbits used in the model.
I was applying some odd linear maps (6 strut form).
java.lang.NullPointerException
at org.vorthmann.zome.ui.LengthDialog.(LengthDialog.java:42)
at org.vorthmann.zome.ui.NewLengthPanel.setController(NewLengthPanel.java:84)
at org.vorthmann.zome.ui.StrutBuilderPanel.changeOrbit(StrutBuilderPanel.java:142)
at org.vorthmann.zome.ui.StrutBuilderPanel.access$0(StrutBuilderPanel.java:135)
at org.vorthmann.zome.ui.StrutBuilderPanel$3.propertyChange(StrutBuilderPanel.java:108)
at java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:335)
at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:327)
at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:263)
at org.vorthmann.zome.app.impl.OrbitSetController.recalculateDots(OrbitSetController.java:121)
at org.vorthmann.zome.app.impl.OrbitSetController.doAction(OrbitSetController.java:128)

Git commit for that stack trace is d2b1e2b49ad0dfd155980911402b9e0a25402f60, though not pushed to origin yet.  Prior commit, which is pushed, is e1b1e520e918c1d0854c667c61c407f6383fa18f

This issue was moved to vZome/vzome#2


image block effect

When I trained on other datasets, the block effect occurred in the results. Have you ever been in a similar situation? How did you solve it?
Looking forward to your reply. Thank you

Hello, I also met the same problem. Have you solved it?

Would you mind sharing more details about how you created that sample?


Add "How to Use" section to sidebar menu

Add a link to how to use section in the sidebar menu

Can I work on this issue?

Yes!


Option to not have to port forward for external access?

@AlexxIT
I have come to realize even if my expectation is to embed these streams withing HA dashboards and let HA "proxy" these camera feeds to outside my network, go2rtc still needs a connection made on the external port configured for webrtc such as the default 8555
I have tried other solutions you have built such as https://github.com/AlexxIT/WebRTC and the streams are viewable without having to open additional ports than HA itself.
I personally don't feel as comfortable opening my firewall as such, especially when I can establish connection directly to the running service from the outside. Cameras contain sensitive information so all the more reason to be as paranoid as I am
Is there plans or an option to revisit this in the future?

If you can see stream with WebRTC Camera and can't see stream with go2rtc - you watching MSE technology. Not WebRTC technology. Go2rtc also support it.
No one can connect to WebRTC TCP port (8555) any get your streams because this port only for excepted SRTP data.

Bringing up WebRTC was simply an example of something you created that can do WebRTC without opening a firewall. I can see my stream now with go2rtc, but recently found out I cannot view the stream outside my network, leading me to re-read the doc and find even if I am embedding these streams into HA, go2rtc is still needing that extra connection on 8555 to be open in my firewall if i want to view the streams in HA from outside my network
And, while the chance is low, there is still a security risk for exposing this service on 8555, both the webrtc module and websocket have CVEs within the last few years, to be expected of any popular module, but it doesn't mean that just because your app is expecting certain payload through that socket that it cannot be exploited.
This is just one more application I have to keep a closer eye on than usual being so easily accessible to the rest of the internet.

Well. I agree with you that there may be vulnerabilities in the library I use. I cannot guarantee that they are not there.
But what you want from me? If you are afraid to open WebRTC TCP port - do not open it. Sometimes you will be able to see the stream thanks to UDP hole punching. Sometimes you can't because of symmetric NAT.
This is how modern networking technology works.

Instead of exposing this directly, you could use cloudflare+access with origin certs to control the origin/authentication or similar technology.  To be fair, you really shouldn't be exposing HA itself directly to the internet without a layer of controls anyway...

I understand there is always a risk, and i dont expect you to do anything about the vulnerabilities in your dependencies except keep them up to date as possible.
I think where I do however have questions about could this be better. WebRTC Camera did not require a port to be opened to operate, is that not possible to do the same with go2rtc?  If all the connections could be "proxied" through HA then the secuirity mechanisms I have on HA like TLS and a reverse proxy improve my security posture on my network.

Instead of exposing this directly, you could use cloudflare+access with origin certs to control the origin/authentication or similar technology. To be fair, you really shouldn't be exposing HA itself directly to the internet without a layer of controls anyway...

@calisro can you explain how TLS is possible on the SRTP port?

I see now what I am missing. Both this project and WebRTC camera use same Pion/webrtc library. In fact your implementation in that project looks very similar to this one.
From your earlier remark:

If you can see stream with WebRTC Camera and can't see stream with go2rtc - you watching MSE technology. Not WebRTC technology. Go2rtc also support it.

And finding this gem in your documentation. The configuration for webrtc external access is the same in both WebRTC Camera and here in go2rtc. I think i was being fooled with WebRTC Camera the entire time into thinking it was WebRTC even though it was MSE. I had the WebRTC icon even a few times on my streams in the top right.
I still think it we be cool to not need more networking to get WebRTC working, but i realize your are limited by the functionality of Pion/webrtc. I sincerely appreciate your work on this and thanks for entertaining my question.

Yes this is off-topic somewhat but I was just offering some potential options.  Since SRTP is configurable and only by default it runs on 8554, I was thinking you can just run it on a cloudflare proxy-able port.
https://developers.cloudflare.com/fundamentals/get-started/reference/network-ports/
I have not tested this specifically (maybe it can't work) but I do use alternative ports through cloudflare proxy for other services just fine.

Yes this is off-topic somewhat but I was just offering some potential options. Since SRTP is configurable and only by default it runs on 8554, I was thinking you can just run it on a cloudflare proxy-able port.
https://developers.cloudflare.com/fundamentals/get-started/reference/network-ports/
I have not tested this specifically (maybe it can't work) but I do use alternative ports through cloudflare proxy for other services just fine.

An interesting idea however isnt the webrtc port the one in question? That is the one we are punching through the firewall

That was a typo.  I corrected it.  Its configurable.

Appreciate it, I will give that a read

I have been thinking more on this, does go2rtc not fallback to MSE like WebRTC does?
The only case where I really run into issues is through mobile access to my WebRTC cameras embedded in HA. If that were to fall back to MSE that might be a desireable feature like it was in WebRTC Camera.
I have noticed mobile tends to struggle with high resolution and bitrate streams anyways adding to the latency of laoding the stream regardless. So the trade off of more latency for MSE might be worth it for accessing on mobile.

go2rtc support both WebRTC and MSE. But without automatic fallback. It is in early development stage. And I don't know if I'll be alive to see the release.

Sure hope that is a joke. Thanks again for this project. I really appreciate the work you put into it @AlexxIT

Unfortunately, after february 2022, this is not a joke.

Yeah..  That is no joke for sure.


code-gen: split output in $outputDirectory/$group/$generator

For easier discoverability of the functionality.
To solve things like the anonymous validators that are used over the different groups, we reserve common as a group name and use that directory for specific shared output

@rodymolenaar  @tjonger any prefs on generating index.js files?

@rodymolenaar @tjonger any prefs on generating index.js files?

Can you be more specific about what kind of preferences?


Dhcp dns offload feature code changes

Added dhcp dns offload feature code changes in this patch.
The changes added in this patch are for only xenserver.
While this pull request is in review process,  I will work on adding  the changes for kvm and vmware and the vm scripts.
User can test the below functionality

Create shared network offering without any services.
Create shared network with the above offering.
Deploy VM in this shared network.
VM will get deployed and config drive iso get attached to VM.

@ydder Looks Good. Good to see you added a unit test as well. In your description of how to do a test of the overall feature I am missing what the 'config drive iso' is. Do you have an fs-page or mail-link?

@DaanHoogland  FS link is there in ticket. Please find the it below
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=53740797

Looks good. i cannot judge the functionality (even after reading the FS) use case makes sense and asfbot and travis seem to agree nothing else is going to suffer so let's merge.


add headset icon for support cases widget

Description

add headset icon for support cases widget
needed for RHCLOUD-31203

Screenshots

Before:
After:

Checklist ☑

[ ] PR only fixes one issue or story
[ ] Change reviewed for extraneous code
[ ] UI best practices adhered to
[ ] Commits squashed and meaningfully named
[ ] All PR checks pass locally (build, lint, test, E2E)

[ ] (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
[ ] (Optional) QE: Has been mentioned
[ ] (Optional) UX: Needs UX attention (end user UX modified, missing designs)
[ ] (Optional) UX: Has been mentioned

Just a note. If it already is not, don't forget to add it the icon to the chrome service.


Add lander

WIP.

Woohoo 🎉 This is VERY exciting! I'll give this a go and a closer look next week :)

This looks really nice, however we need to put a lot of effort in reducing the amount of configuration needed.
@craig-mulligan do you mind explaining how the current implementation works? As far as I can see, you're using Webpack, and the project maintainer needs to do a build step (landr deploy) which builds the website and puts it into gh-pages, right?
If so, any reason why you ditched Jekyll templates instead, which wouldn't require the build step?

cc @pimterry
--
Alexandros Marinos
Founder & CEO, Resin.io
+1<PHONE_NUMBER>
@alexandrosm
On Wed, Jan 4, 2017 at 7:55 PM, Juan Cruz Viotti<EMAIL_ADDRESS>wrote:

This looks really nice, however we need to put a lot of effort in reducing
the amount of configuration needed.
@craig-mulligan https://github.com/craig-mulligan do you mind
explaining how the current implementation works? As far as I can see,
you're using Webpack, and the project maintainer needs to do a build step (landr
deploy) which builds the website and puts it into gh-pages, right?
If so, any reason why you ditched Jekyll templates instead, which wouldn't
require the build step?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/resin-io/etcher/pull/992#issuecomment-270470035, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABLUCFpCx0XDzcE31wyYWFimXs0dQs7Lks5rO_lOgaJpZM4LX10C
.

@jviotti true, there is alot of configuration. I hope to hide that and then only show it if you run smthing like landr eject or add the possibility of merging in only things you change (still experimenting)
Yes, landr deploy will build everything + push to gh-pages.
I moved away from jekyll templates because it means we'd have to commit the templates/js/scss to the users repo, this would mean updates to landr wouldn't update any of that source (like it does now).
I started off thinking webpack could load files using webpack and then spit out a directory like we have here: https://github.com/craig-mulligan/jek-test but then as I mentioned where do you edit the templates?  In the directory we just created or by passing landr some new templates? It essentially creates a double build step which I thought was confusing. But very open to idea's that could make it less so.

Based on today's landr meeting, I'll close this one for now. We'll adopt landr in landr first (which will likely change various things), and then adopt it in Etcher.


Allow setting service account via --service-account

Close #32
Needs testing, I haven't done the local setup for this so it might be nice if someone else can give it a go.

I've confirmed that this works by doing:
julia_pod --service-account="nope" and observing that the job never gets allocated pod, whereas setting the service account to a permissible value results in a pod being stood up.
Merging.


In app subscriptions

In the step-by-step documents, you say that the plugin does not support subscription products, yet the readme shows the "subscription period" as one of the product variables.  Does this plugin support subs?

@PeterStaev , is the tutorial already out there? Thank you!

No tutorial yet. And dont think there will be - there are already lots of articles how to validate subscriptions on both platforms. And those wont differ much from the NS way. Since all the backend code that will reside on your server will be the same as in the native tutorials.


PAPP-30531 : code style - Update variable to make it consistent

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[x] Testing of all the changes has been performed (for bug fixes / features)
[ ] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[ ] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[x] Verify all checks are passing.
[x] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[x] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[ ] New App
[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[ ] If you are exposing any endpoints using a REST handler,
please document them in the readme.html.
[ ] If this is a new connector or you are adding new actions

[ ] Please document in the readme.html all methods (eg, OAuth) used to authenticate
with the service that the connector is integrating with.
[ ] If any actions are unable to run on SOAR Cloud, please document this in the readme.html.

[ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[ ] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
the Vault API.
[ ] Are you are marking code to be ignored by Semgrep with nosemgrep?
If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

How come we are going back to MSONEDRIVE_JSON_MSG ?
Also, why this change MSONEDRIVE_UNABLE_TO_RETREIVE_VAULT_ITEM_ERROR_MSG?
The 2nd one has a typo (should be retrieve, not retreive) and shouldnt 'MSG' be `MESSAGE'?
I'm confused

How come we are going back to MSONEDRIVE_JSON_MSG ? Also, why this change MSONEDRIVE_UNABLE_TO_RETREIVE_VAULT_ITEM_ERROR_MSG? The 2nd one has a typo (should be retrieve, not retreive) and shouldnt 'MSG' be `MESSAGE'? I'm confused

Typo of constant variable has been fixed.
For consistent variable, if a variable contains 'MSG', then all variables should use 'MSG'. If a variable contains 'MESSAGE', then all variables should use 'MESSAGE' for variable consistency. In this case, one variable contains 'MESSAGE', many other variables contain 'MSG', so I changed to 'MSG' to minimize the code change.


Managing disruptive comments is overly prescriptive

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://github.com/github/docs/blob/main/content/communities/moderating-comments-and-conversations/managing-disruptive-comments.md
What part(s) of the article would you like to see updated?
This content:
https://github.com/github/docs/blob/ed48eab88d1cbbe2a99aa02885140155029910d1/content/communities/moderating-comments-and-conversations/managing-disruptive-comments.md?plain=1#L53
... feels more like instructions for how a specific project should operate, as opposed to the world at large. If it's the world at large, then it should be integrated into the tooling.
This should really have its own anchor, for redacting information:
https://github.com/github/docs/blob/ed48eab88d1cbbe2a99aa02885140155029910d1/content/communities/moderating-comments-and-conversations/managing-disruptive-comments.md?plain=1#L59
https://github.com/github/docs/blob/ed48eab88d1cbbe2a99aa02885140155029910d1/content/communities/moderating-comments-and-conversations/managing-disruptive-comments.md?plain=1#L64-L65
The content should also include a note that it's merely a suggestion.
https://github.com/github/docs/blob/ed48eab88d1cbbe2a99aa02885140155029910d1/content/communities/moderating-comments-and-conversations/managing-disruptive-comments.md?plain=1#L80
It's a bit late in the chronology to make this suggestion. I'd suggest it precede the information about deleting a comment (i.e. before Deleting a comment is your last resort as a moderator.). But, I want to be careful to not be too prescriptive (the current content suffers from this...).
There should be an anchor for the steps:
https://github.com/github/docs/blob/ed48eab88d1cbbe2a99aa02885140155029910d1/content/communities/moderating-comments-and-conversations/managing-disruptive-comments.md?plain=1#L88
Additional information
Fwiw, while this information is interesting, it is definitely not complete.
I found this page because I was researching a behavior I noticed today which does not appear to be documented.

@jsoref
Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

I've mentioned this in an internal channel to get some expert 👀 on these suggestions.

good

Hi @jsoref - Thanks again for raising this issue. Apologies it's taken a while to get back to you about this.
I've now heard back from an SME who has taken a look at this issue. They've said that your suggestions seem potentially valid, but they'd like to have a pull request with docs changes to review.
If you could open a PR with your suggested changes to the docs that would be great. Please check out the contributing guidelines.


Jump to line+column in terminal links (format <path> l:c)

It is possible with VSCode to follow a path printed in the terminal.
When that path also contains the line and column number in the format <path> l:c (l ≙ line number; c ≙ column number),
VSCode currently doesn't interpret it completely and therefore doesn't also jump to the line/column in the opened file.
Example:
resources/styles/blocks/cover/rhombus.scss 49:46

This path format indicates the path to the file but also the line (49) and column (46) number.
Ctrl + clicking this path currently in VSCode will open the file but not jump to the line or the column.
As this format is used by many linters and compilers (e.g. SASS), it would be a very useful and time-saving feature.

Code link:
https://github.com/microsoft/vscode/blob/95a0e2b859aff1f5f3e6300a8d70aa813608da64/src/vs/workbench/contrib/terminal/browser/links/terminalValidatedLocalLinkProvider.ts#L35-L44
I think here we'd want to require the exact (num)(colon)(num) to prevent problems with (link) (number) (text)

nice feature for many front end build tools.

I added PR #153957 for this.


Master

Cleaned up the Dispose methods to implement the pattern correctly.  Updated the write process to ensure that connections are open and can be written too.  Included a delegate event to pass in EventArgs to help with monitoring.

@paul-turner-github release/1.0 has been merged, can you please rebase your changes on top of the latest master and fix the merge conflicts?

@paul-turner-github bump, please let me know if you're still interested in working on this PR.

No comment from user who opened PR since 1/21. Closing PR.  Reviewed changes and not relevant on new branch due to significant refactoring but would appreciate any contribution to cleanup that you'd like to do in the future.


Can we upgrade C# (.NET >= 4.5;  Mono >= 4.4) ?

Motivation : want to use some new feature
At least features like "nameof" and "String Interpolation" are very useful.
Take "String Interpolation" as an example:
The old fashion usage :
String.Format("***{0} *** {1} *** {2} ***", v1, a2, p3);
The above usage is quite clumsy comparing to new usage and vulnerable to changes :
$"{v1} *** {a2} *** {p3}"
What to do for upgrade
Only update the scripts (.bat/.cmd) on Windows only : (other platforms not specified version)
SET VisualStudioVersion=12.0
Change it to :
SET VisualStudioVersion=14.0
Current compiler
Windows : Visual Studio 2013 / 12.0 : Specified in compilation script (build.cmd), need upgrade.
Mono : 4.4.1 : Not specified version in scripts AND higher enough needless to upgrade.
And I noticed that we already have higher version compilers in fact (but downgrade using):
Daily build on Linux : Mono
Mono JIT compiler version 4.4.1 (Nightly <IP_ADDRESS>/4747417 Wed Jun 22 11:14:49 UTC 2016)
Daily build on Windows: Visual Studio
VSSDK140Install=C:\Program Files (x86)\Microsoft Visual Studio 14.0\VSSDK\
Validation for upgrade : ALL Passed on 3 Platforms
Test code snip
var exe = Path.GetFileName(System.Reflection.Assembly.GetExecutingAssembly().CodeBase);
New fashion :
Console.WriteLine($"Usage    : {exe}  input-arguments, type = {nameof(testArgsQuotes)}");

Old fashion :
Console.WriteLine("Usage    : {0}  input-arguments, type = {1}", exe, "testArgsQuotes");

1. Windows
Visual Studio 2015 / Microsoft Visual Studio 14.0
No doubt passed.
2. CentOS 7
[alone@cent71 ~]$ mono --version
Mono JIT compiler version 4.4.0 (Stable <IP_ADDRESS>/81f38a9 Thu Apr 28 09:14:25 EDT 2016)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
[alone@cent71 ~]$ cat /etc/centos-release
CentOS Linux release 7.2.1511 (Core)
[alone@cent71 ~]$ uname -a
Linux cent71 3.10.0-327.18.2.el7.x86_64 #1 SMP Thu May 12 11:03:55 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

3. Ubuntu 16.04 LTS
ling@ku16:~$ mono --version
Mono JIT compiler version 4.4.0 (tarball Tue Jun 14 13:41:51 UTC 2016)
ling@ku16:~$ uname -a
Linux ku16 4.4.0-24-generic #43-Ubuntu SMP Wed Jun 8 19:27:37 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
ling@ku16:~$ cat /etc/os-release
NAME="Ubuntu"
VERSION="16.04 LTS (Xenial Xerus)

What to do for upgrading C# version (.NET >= 4.5; Mono >= 4.4)
Only update the scripts (.bat/.cmd) on Windows only :
SET VisualStudioVersion=12.0
Change it to :
SET VisualStudioVersion=14.0

For Windows, .Net 4.5 is required. Good enough for Windows?
https://github.com/Microsoft/Mobius/blob/master/notes/windows-instructions.md#building-mobius
•Developer Command Prompt for Visual Studio 2013 or above, which comes with .NET Framework 4.5 or above. Note: Visual Studio 2015 Community Edition is FREE.

Improvements in .NET 4.5 : https://msdn.microsoft.com/en-us/library/ms171868(v=vs.110).aspx#core
At least on related to us : (item 3)
Better performance through background garbage collection.

Mobius C# code is already built for .NET 4.5. See https://github.com/Microsoft/Mobius/blob/master/csharp/Adapter/Microsoft.Spark.CSharp/Adapter.csproj#L12

@skaarthik I probably post wrong requirement for the upgrade. Let me describe what happens first :
On Windows (already fine on Linux : CentOS / Ubuntu)
If I use the following code :
Console.WriteLine($"Usage    : {exe}  input-arguments, type = {nameof(testArgsQuotes)}");
And call {Mobius}\csharp\Build.cmd  will get compilation error as following:
testArgsQuotes.cs(30,35): error CS1056: Unexpected character '$' [d:\msgit\lqmMobius\test\csharp\testArgsQuotes\testArgsQuotes.csproj]
ParseKeyValuePair.cs(16,60): error CS1519: Invalid token '=' in class, struct, or interface member declaration [d:\msgit\lqmMobius\test\csharp\commonTestUtils\CommonTestUtils.csproj]

But if I update the script {Mobius}\csharp\Build.cmd will work fine:
SET VisualStudioVersion=12.0
Change it to :
SET VisualStudioVersion=14.0
So, What to do is not upgrade the .NET but ToolVersion/VisualStudioVersion?
like : https://github.com/Microsoft/Mobius/blob/master/csharp/Build.cmd#L9

(And I did not change following file, compilation passed)
https://github.com/Microsoft/Mobius/blob/master/csharp/Adapter/Microsoft.Spark.CSharp/Adapter.csproj#L2

C# 6.0 comes with VS14 (Visual Studio 15) - https://msdn.microsoft.com/en-us/library/hh156499.aspx
•	String Interpolation
You can use string interpolation expressions to construct strings. An interpolated string expression looks like a template string that contains expressions. C# creates a string by replacing the expressions with the ToString represenations of the expressions’ results. An interpolated string is easier to understand with respect to arguments than Composite Formatting.
@qualiu - I think you are asking to upgrade compiler to VS 14 (Visual Studio 2015) for C# 6.0 feature of String Interpolation.
Mobius Project requires VS 12 (Visual Studio 2013) and above.
Two questions then - (1) what is the impact of requiring VS 14 (Visual Studio 2015) to compile Mobius Project?  (2) what is the impact of staying with VS 12 (Visual Studio 2013) and not benefiting from latest C# 6.0 features, such as String Interpolation?

Thanks @danielli90 ! Probably it's a topic about the "build tool version" and "target framework version" as @skaarthik  said.
The phenomenon in brief : (and both of following compilation passed)

Nothing to change compile OK in VS2015 (compile within IDE) , Target framework = 4.5.
Change Build.cmd :SET VisualStudioVersion=14.0 then call Build.cmd OK.
In addition : my local machine has only one version : Visual Studio 2015.

@qualiu, just make sure we are on the same page regarding your ask here -
"String interploation" and "nameof" are new C# 6.0 features; C# 6.0 is supported only in VS2015 (and above). When VS 2013 is used, "String interploation" and "nameof" trigger compiler error, as you observed.
If you remove "String interpolation" and "nameof" in your code, VS 2013 should be able to compile. For example change the following -
Console.WriteLine($"Usage : {exe} input-arguments, type = {nameof(testArgsQuotes)}");
to:
Console.WriteLine("Usage : {0} input-arguments, type = testArgsQuotes", exe);
C# 6.0 introduces a good list of useful features - https://msdn.microsoft.com/en-us/library/hh156499.aspx. But let's understand the pros and cons first.
@jthelin, any comments? has Orleans embrace C# 6.0 yet?

@danielli90 : yes, but from phenomenon seems we don't need to upgrade to C# 6.0, just need to upgrade the build tool to VS2015, and on Windows only. (Linux are already well)

@danielli90 - Orleans has switched to using VS2015 for build/test, but is trying to still be able to run code on .NET 4.5.x for now.
This generally means avoiding the C# 6.0 changes that require updated NET 4.6 runtime, but there are  some C# 6.0 features like string interpolation that are done at compile time and remain compatible on old 4.5.x runtime. Given that most of those compile-time 6.0 extras are mostly syntactic-sugar, i find in my other projects it is easier to just avoid the borderline cases too.
Thankfully ReSharper has a way of turning off prompts for 6.0 features, which i do on my machines.
https://resharper-support.jetbrains.com/hc/en-us/community/posts/207462505-Disable-new-C-6-0-features-in-ReSharper-
The longer-term goal for Orleans is to support .NET Core 1.0 [cross-platform server runtime], but that will be a bigger step and not quite ready yet.
HTH.

Thanks @jthelin.
@qualiu, given Mobius needs to support .Net 4.5.x as well, we can avoid those C# 6.0 syntactic-sugar and configure ReSharper accordingly. Does that make sense to you?

@danielli90 : OK, thanks!   And thanks @jthelin for your expert comment.


Add support for user specified histogram interval in API calls

e.g. https://viewhost/spigraph.json?interval=3600

Thanks, but already implemented similar but different.


358 use of 'instance of' in definitions for four object properties

Fixes #358

@cameronmore: Please review this pull request, which addresses my #358, if possible.

Fixes #358

@gregfowlerphd your branch is 78 commits behind the HEAD of develop.  Please update and resolve any conflicts. If you need help, please reach out to one of us.

@gregfowlerphd Appreciate the quick response. Hold any attempt to fix until we sort this out across the repo since all PRs are showing conflicts.

@gregfowlerphd Please open a new request with the same changes; that'll be the easiest way to align.


Error loading main sequence embeddings

Hi everyone,
Im trying to train a new model with my own data. Step 1 (computing embeddings) and 2 (zero-shot) are running perfectly, but step 3 is complaining about missing embeddings:
Error loading main sequence embeddings: At least one embedding was missing
Any suggestions? many thanks!

Hi @dc2211 - could you please confirm that an .h5 file for your new assay was properly created and saved on disk at the following location: $DATA_PATH/data/embeddings/MSA_Transformer, where $DATA_PATH is the location where you downloaded and unzipped the ProteinNPT_data as per step 1 of the setup process?

Hi @pascalnotin - yes, the embeddings (.h5 file) are there.
####################################################################################################
Step3: Training the ProteinNPT model on the protdms assay
####################################################################################################
Location used for target fitness if /home/ProteinNPT
Embeddings folder: /home/ProteinNPT/ProteinNPT_data/ESM/MSA_Transformer/esm_msa1b_t12_100M_UR50S.pt
We want to predict 1 target(s): fitness
Training model for assay: protdms, where the test_fold index is: 0
Effective batch size is 425
Model name: ProteinNPT_protdms_fitness_fold_random_5_embed_MSA_Transformer_head_CNN_aug_none_froz_True_drop_0.0_val_False_base_pipeline_fold-0
Sequence embeddings: /home/ProteinNPT/ProteinNPT_data/data/embeddings/MSA_Transformer/protdms.h5
Target processing train set: {'fitness': {'mean': 0.5739534883720929, 'std': 0.7322810476315698, 'P95': 2.07}}
Number of sequences in MSA (before preprocessing): 98
Calculating proportion of gaps
Proportion of sequences dropped due to fraction of gaps: 0.0%
Proportion of non-focus columns removed: 0.0%
Number of sequences after preprocessing: 95
One-hot encoding sequences
Data Shape = (95, 305, 20)
Loading sequence weights from disk
Neff = 82.33333333333333
Number of sequences:  95
Neff: 82.33333333333333
Name of focus_seq: >5980390
Check sum weights MSA: 81.83333333333333
tmp: Starting training
Model device: cuda:0
  0%|                                                                                | 0/10000 [00:00<?, ?it/s]
Error loading main sequence embeddings: At least one embedding was missing
  0%|

Hi @dc2211 -- is your assay a substitution assay (ie., all mutated sequences of same length) or does it contain also indels? Is there any gaps ('-') in the assay sequences? Could you print a few lines from it?

Hi @pascalnotin,
all sequences are the same length. Actually this error is coming after I did all the rebase from #11 .
I tried with an old local install of the repo that I have, and it run just fine with the same data. Is there anything in particular that I can print here for you to help on tracking the source of the error? Also I tried an old training that was working, and not is not. Thanks!

also, no gaps, no indels. Just substitutions.

The rebase did not change anything to the code that would trigger an issue there. Have you tried deleting the current version of the embedding file (protdms.h5) and recreating it from scratch (or replacing it with the version that worked without issue in your experiment with the older local copy of the repo)?

I tried:

removing and recomputing embeddings
copying embeddings from the old local installation (which I believe is version 1.2)

and the problem still persists, with Error loading main sequence embeddings: At least one embedding was missing. I made sure I was using the correct sequence, with the right length, linked with the correct MSA and DMS data. Many thanks.

I will close this issue because I ended up combining scripts from both local installations, which now works completely (that is, from getting the embeddings, computing zero shots, training and evaluating). Thanks for all the help.

Hi @dc2211 -- just pushed an updated version which may have resolved the issue you were encountering earlier (assuming I properly guessed what the issue was). Please update package to v1.5 beforehand. Let me know if that works for you!

Hi @pascalnotin -- thanks for the updated version. It seems is working fine for training, but I'm still confused in terms of the needs to do new predictions using the eval.sh process, and the error I'm getting. I tried the following:

Train with dataset X, and get embeddings for X and checkpoints X (sequence length 400)
Train with dataset Y, and get embeddings for Y and checkpoints Y (sequence length 400)
Take checkpoint Y, and infer from embeddings X (zero shot location set to None in eval.sh). This one does not works and I get Error loading main sequence embeddings.
Haven't tried adding the zero_shot predictions, but don't think it should make a difference.
The problem is fixed if I use checkpoint Y on embeddings Y.

Both datasets correspond to similar proteins, trained using different MSAs. Also, I understand there is a check for the lengths of indices_retrieved_embedding and batch["mutant_mutated_seq_pairs"] in data_processing.py, but I do not get why does this changes if I tried cross dataset X and Y.
Should it be possible to mix both X and Y,  if both set have the same sequence length? Please correct me if I'm wrong. I hope it makes sense! Thanks!
PD: I notice there is a problem as well with the zero_shot predictions that if I do a first run without them, I get an edited DMS file with the new mutant column, and the dummies mutant_x. If I try to start again, now asking for zero_shot predictions, and the DMS files already has the mutant column, I get the error ValueError: invalid literal for int() with base 10: 'utant_'. Maybe if the column is overwritten (if is there) when zero_shots are True, this error might be avoided.

Hi @dc2211 -- you only need to train your model once (e.g.,  dataset X), but if you want to predict things on a new dataset (e.g., dataset Y) then you need to embed sequences for dataset X and Y in the same file. This is because the training sequences (in X) are used at inference to predict sequences in Y (via attention across rows). Since you use two different MSAs for dataset X and Y to get embeddings, this is a bit of an edge case not currently supported. The way to resolve is to concatenate the embeddings for both datasets in a single file and then use the eval script. Hope that helps!

Hi @dc2211 -- closing this issue as I believe the above addressed the concerns. Feel free to re-open as needed.
Kind regards,
Pascal


Multiple run.py support

Hi again!  :)
I was working with a project with a few submodules with their own run.py and noticed that this plugin only handles a single one.
Would it be possible to allow wildcard (* and **) patterns in run.py path option and support for multiple run.py.
I realize that full regression of the project might not be wanted within this scope.
But not having acces to Test Explorer: run the rest at current cursor position & Test Explorer: run tests in current file steping in to a submodules was quite anoying.

It's on the roadmap. The idea is if multiple run.py files are found that they are placed at the first level of hierarchy e.g.:

test1/run.py

tb_1
tb_2
...

test2/run.py

tb_1
tb_2
...

Right now I'm working getting some proper tests in place, bu I think that this would be the next step.

It's on the roadmap. The idea is if multiple run.py files are found that they are placed at the first level of hierarchy e.g.:
test1/run.py
tb_1
tb_2
...
test2/run.py
tb_1
tb_2
...
Right now I'm working getting some proper tests in place, bu I think that this would be the next step.

Awsome!
Can you elaborate on proper tests, I might be able to help with something :)

+1 to this issue!

Hi, I am struggling with the same issue. Any plans / workarounds yet?


Potential issue with reading large files

There might be an issue where loading a large file crashes spyder.

This is non-issue. The feature works but takes long time to load in.


Error caught in Sync Tab Groups

Since some update on either sync tab groups or Firefox i keep getting an annoying pop-up in the bottom left corner flashing "Error caught in Sync Tab Groups".

+1
In inport/export settings, the pop-up says "The group list is corrupted... It is impossible to load it". ¿?

Have you already reported the log
so that I can correct it ?
What is your Firefox version ?
After that can you downgrade to version v0.6.7 (previous), the time the fix
lands ?
Le ven. 11 mai 2018 à 08:30, jram<EMAIL_ADDRESS>a écrit :

+1
In inport/export settings, the pop-up says "The group list is corrupted...
It is impossible to load it". ¿?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Morikko/sync-tab-groups/issues/116#issuecomment-388273653,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHeAFLhnwEj1Vcg6ocWjL3k84wXc_zT9ks5txTAVgaJpZM4T66eb
.

Firefox version 60.0, and the log file is posted.
How do you downgrade without losing the current tab groups?

After downgrading to v0.6.7, the pop-up not appears, it seems to be a bug introduced in the last version

Same problem here on version 0.6.8 and Firefox 59.0.3 and 60.0

edit No need to downgrade, I just turned off the "Enable the extension to log errors." to get rid of the error popup for now.

Just be careful, the error might block the save on the disk.
I will fix it tomorrow asap.

How do you downgrade without losing the current tab groups?
I don't know :disappointed:  @jramaex


Abort method needs more content in payment request primer

The abort() method could use a little more context. The first way of using it I tried turned out not to be possible. You can find an example of how to use it in Rouslan's example.

@agektmr - can you please take a look and either update or close.

I'll work on it and reflect to the integration guide.

This is sorted. Can you close if it looks good to you? @jpmedley


Use time-machine instead of sleep for timing-based tests

This fixes flaky test behavior like this: https://github.com/requests-cache/requests-cache/actions/runs/4516275647/jobs/7954969801
It seems that the slow performance when running many CI jobs in parallel is enough to cause some expiration-related tests to occasionally fail if they depend on timing.

It seems time-machine doesn't work on PyPy, so I'm just going to skip those tests when running under PyPy.


specs fail when hspec < 2.11.7 is installed

hspec v2.11.7 added "Include --seed in the note on how to rurun a failing item".
TriggerSpec.hs always expects the seed note to be outputted.
The tests should be changed to account for any hspec version that could be installed.
Can the tests be updated such that the seed note is optional?
Or does hspec expose a version number that we can leverage in a conditional, similar to how we use __GLASGOW_HASKELL__?

@libjared thanks for reporting this. Can you please give more context on how this affects you, or what your use case is?
This will put me into a better position to resolve this in a way that both, solves your issue, and values my time.

I help maintain some packages on NixOS, including sensei.
Recently, we updated the stackage to current LTS, which puts hspec at v2.10.10. Also, sensei was updated to v0.8.0.
The automated build of sensei fails, because the specs expect the kind of output that hspec>=v2.11.7 would print.
Removed from the context of NixOS, the issue is that sensei does not build with the packageset from current stackage LTS.
We can make the changes to the two specs on our end, so this is not a showstopper at all, but I thought the issue was still worth mentioning here. Up to you.

Just wanted to chime in to show what the failing tests look like for sensei when trying to build in Nixpkgs, since I think that makes it easy to see what is going wrong:
https://hydra.nixos.org/build/240435221/nixlog/2
Running 1 test suites...
Test suite spec: RUNNING...

Client
  client
...
  gitCheckIgnoreFeedback
    when git reports no repository
      returns gitless warning [✔]
    when git stops at a filesystem boundary
      returns gitless warning [✔]
    when git reports no error
      returns Nothing [✔]
    when git reports any other error
      returns the error [✔]
  isWritableByOthers
    returns False [✔]
    when writable by group
      returns True [✔]
    when writable by others
      returns True [✔]
    when directory is writable by group
      returns True [✔]
    when .ghci does not exist
      returns False [✔]
  writableByOthers
    returns False for owner [✔]
    returns True for group [✔]
    returns True for others [✔]

Failures:

  test/TriggerSpec.hs:113:51:
  1) Trigger.triggerAll runs all specs
       expected: (Failure, ["Ok, one module loaded.", "\ESC[32mRELOADING SUCCEEDED\ESC[m", "", "foo [✔]", "bar [✘]", "", "Failures:", "", "  Spec.hs:8:3: ", "  1) bar", "", "  To rerun use: --match \"/bar/\" --seed 0", "", "Randomized with seed 0", "", "Finished in ...", "2 examples, 1 failure", "Summary {summaryExamples = 2, summaryFailures = 1}"])
        but got: (Failure, ["Ok, one module loaded.", "\ESC[32mRELOADING SUCCEEDED\ESC[m", "", "foo [✔]", "bar [✘]", "", "Failures:", "", "  Spec.hs:8:3: ", "  1) bar", "", "  To rerun use: --match \"/bar/\"", "", "Randomized with seed 0", "", "Finished in ...", "2 examples, 1 failure", "Summary {summaryExamples = 2, summaryFailures = 1}"])

  To rerun use: --match "/Trigger/triggerAll/runs all specs/"

  test/TriggerSpec.hs:213:48:
  2) Trigger.trigger, with a failing spec, only reruns failing specs
       expected: (Failure, ["Ok, one module loaded.", "\ESC[32mRELOADING SUCCEEDED\ESC[m", "", "bar [✘]", "", "Failures:", "", "  Spec.hs:8:3: ", "  1) bar", "", "  To rerun use: --match \"/bar/\" --seed 0", "", "Randomized with seed 0", "", "Finished in ...", "1 example, 1 failure", "Summary {summaryExamples = 1, summaryFailures = 1}"])
        but got: (Failure, ["Ok, one module loaded.", "\ESC[32mRELOADING SUCCEEDED\ESC[m", "", "bar [✘]", "", "Failures:", "", "  Spec.hs:8:3: ", "  1) bar", "", "  To rerun use: --match \"/bar/\"", "", "Randomized with seed 0", "", "Finished in ...", "1 example, 1 failure", "Summary {summaryExamples = 1, summaryFailures = 1}"])

  To rerun use: --match "/Trigger/trigger/with a failing spec/only reruns failing specs/"

Randomized with seed 320782394

Finished in 0.9756 seconds
124 examples, 2 failures
Test suite spec: FAIL
Test suite logged to: dist/test/sensei-0.8.0-spec.log
0 of 1 test suites (0 of 1 test cases) passed.

Thank you very much for the quick commit. I apologize if my explanations were too opaque.


Fix OEmbed endpoints

Fixes #3842

Thanks @mixxorz! Merged in 83e6a551febb9aa55ba074a5f14a4928264f4172 (master) and bdeb104804acf57861c54bbf23553d45cbb741a1 (stable/1.12.x), with a rewrite to the test (so that it's checking the end-to-end behaviour rather than just the internal property).


Feature/templatestudies Template studies support

This PR adds support to create template studies with sub-studies.

[x] Update database
[x] Expandable studies table with grouping
[x] Create button with overlay to create standalone study or template
[x] Design template with locking feature
[x] Design sub-study with locking feature and inheritance
[x] Adapt publish dialog for templates
[x] Adapt app for template studies

During review:

[ ] Finalize database and study model
[ ] Finalize design of study creation overlay

This PR depends on #555, so I suggest to merge that first before reviewing this.

Is this ready for a review?

Is this ready for a review?

Yes, but I would recommend to review and merge #555 first.

Can you update the branch @hig-dev so I can review?

Can you update the branch please @hig-dev?

https://github.com/hpi-studyu/studyu/pull/601 needs to be integrated before merging


Filter by User and Tag

Hello,
We are trying to filter our feed by image and user but having challenges because some of the images tagged by the user were posted hundreds of images ago and consequently, we have to load the whole feed (but it seems to stop at some arbitrary limit of images?) to filter out the few we want to show.  Have others reported a similar issue / experience?
It would be awesome if we could filter by writing:

get: 'user',
tagName:  'RealTimeChile',
userId: <>,
accessToken: <>,

Thank you in advance for any insights!!

+1 for this, I want to display the most recent 8 images from a user, tagged with a specific hashtag; currently only 1 will show if I set the limit to 8, because the rest of them were posted > 9 images ago on the Instagram account

yes this would be nice

I'm getting the same issue as @JRKyte using the following code
var brianFeed = new Instafeed({
	get: 'user',
	userId: USER_ID,
	clientId: 'CLIENT_ID',
	limit: '1',
	resolution: 'standard_resolution',
	filter: function(image) {
		console.log(image);
		return image.tags.indexOf('wip') >= 0;
	}

});

brianFeed.run();

+1

@stevenschobert - is there any plans to implement this? Users need to click the 'load more' button a couple of times to get to the first images (filtered: from user, with tag) on my site.

@JRKyte if by "implement" you mean, make Instafeed.js keep fetching images until the limit has been hit, then no.
Currently you can do this yourself, by setting the limit to 60, and then tracking your own count inside your filter function.
See this answer on Stack Overflow for an example.