Fix accept mechanism in tests

This PR addresses https://github.com/pytorch/vision/pull/3697#discussion_r619304022
I removed the --accept option which doesn't seem to play out really well with pytest, and it's redundant with the already-supported env variable anyway.
Test case below where I delete the pkl file for alexnet, get an expected error, then use the suggested fix in the error message and re-run the test, which passes (sorry it doesn't render super well):
(pt) ➜  vision git:(mungedid) ✗ mv test/expect/ModelTester.test_alexnet_expect.pkl ~
(pt) ➜  vision git:(mungedid) ✗ pytest test/test_models.py -x -k alex --tb=short
============================================================================== test session starts ===============================================================================
platform darwin -- Python 3.8.8, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /Users/nicolashug/dev/vision
plugins: cov-2.11.1
collected 67 items / 66 deselected / 1 selected

test/test_models.py F                                                                                [100%]

==================================================================================== FAILURES ====================================================================================
____________________________________________________________________ test_classification_model[dev0-alexnet] _____________________________________________________________________
test/test_models.py:438: in test_classification_model
    ModelTester()._test_classification_model(model_name, input_shape, dev)
test/test_models.py:84: in _test_classification_model
    self.assertExpected(out.cpu(), name, prec=0.1)
test/common_utils.py:126: in assertExpected
    expected_file = self._get_expected_file(name)
test/common_utils.py:109: in _get_expected_file
    raise RuntimeError(
E   RuntimeError: No expect file exists for ModelTester.test_alexnet_expect.pkl in /Users/nicolashug/dev/vision/test/expect/ModelTester.test_alexnet_expect.pkl; to accept the current output, re-run the failing test after setting the EXPECTTEST_ACCEPT env variable. For example: EXPECTTEST_ACCEPT=1 pytest test/test_models.py -k alexnet
============================================================================ short test summary info =============================================================================
FAILED test/test_models.py::test_classification_model[dev0-alexnet] - RuntimeError: No expect file exists for ModelTester.test_alexnet_expect.pkl in /Users/nicolashug/dev/visi...
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
======================================================================== 1 failed, 66 deselected in 1.06s ========================================================================

(pt) ➜  vision git:(mungedid) ✗ EXPECTTEST_ACCEPT=1 pytest test/test_models.py -k alexnet
============================================================================== test session starts ===============================================================================
platform darwin -- Python 3.8.8, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /Users/nicolashug/dev/vision
plugins: cov-2.11.1
collected 67 items / 66 deselected / 1 selected

test/test_models.py .                                                                                [100%]

================================================================================ warnings summary ================================================================================
test/test_models.py::test_classification_model[dev0-alexnet]
  /Users/nicolashug/dev/vision/test/common_utils.py:270: RuntimeWarning: The check_jit_scriptable test for AlexNet was skipped. This test checks if the module's results in TorchScript match eager and that it can be exported. To run these tests make sure you set the environment variable PYTORCH_TEST_WITH_SLOW=1 and that the test is not manually skipped.
    warnings.warn(msg, RuntimeWarning)

-- Docs: https://docs.pytest.org/en/stable/warnings.html
================================================================== 1 passed, 66 deselected, 1 warning in 0.93s ===================================================================

if the pytest does not play well with arguments I don't have issues removing it.

To be perfeclty honest there probably is a way, but since the env is working fine I didn't bother to try


Dependency download umbrella chart

Currently the charts/umbrella Helm chart requires download not only from its dependencies but also their dependency (recursive).
This can be solved with the following command:
find charts/umbrella -name Chart.yaml -print | \
  sed s/Chart.yaml//g | \
  awk -F"/" '{print NF $0}' | \
  sort -nr | \
  sed 's/^.//' | \
  xargs -n1 helm dependency update --skip-refresh

adapted from https://github.com/helm/helm/issues/2247#issuecomment-998636912
Can or should this be added as hack-script or in the chart`s README?
I am currently not sure where to place this.

Maybe here is a good location:
https://github.com/eclipse-tractusx/e2e-testing/blob/d996794946b089d2e365d48251d62f9f553e4143/charts/umbrella/README.md?plain=1#L14-L22


use '1' for '100%' in Col constants when using fractions

When using fractions in the Col component it is intuitive to use '1' to mean '100%'.

:+1: I agree, thanks @NogsMPLS


Support Android file uploads

For iOS, input[type=file] inputs are handled transparently by WKWebView, showing a native file picker or camera capture. This is not the case for Android, where we need to setup a onShowFileChooser method for the WebView in order to handle file inputs.
Turbo Android does this and has delegates setup to show a native file picker or capture from camera and return a file pointer to the WebView.
This is for some reason not working properly at the moment in this library.

Fixed by #51


.NET Publish  "The current .NET SDK does not support targeting .NET Core 3.1.0"

What happened?

What were you attempting to do?
I was trying to build the ASP.NET sample app and test out how the version roll-forward behavior works when I select a TargetFramework that isn't shipped in the buildpack (e.g. 3.1.0).

The .NET Runtime buildpack attempts version roll-forward and selects the latest 3.1.x runtime version and the build gets all the way to running dotnet publish at which point it fails with:
/layers/paketo-buildpacks_dotnet-core-sdk/dotnet-core-sdk/sdk/3.1.406/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(127,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.1.0.  Either target .NET Core 3.1 or lower, or use a version of the .NET SDK that supports .NET Core 3.1.0. [/workspace/aspnet.csproj]
failed to execute 'dotnet publish': exit status 1

What did you expect to happen?
I was not expecting it to fail, as the "version roll-forward" determined by the .NET Core Runtime buildpack should have resulted in a successful build.

What was the actual behavior? Please provide log output, if possible.

===> DETECTING
6 of 10 buildpacks participating
paketo-buildpacks/dotnet-core-runtime 0.1.7
paketo-buildpacks/dotnet-core-aspnet  0.1.6
paketo-buildpacks/dotnet-core-sdk     0.1.6
paketo-buildpacks/icu                 0.0.100
paketo-buildpacks/dotnet-publish      0.1.4
paketo-buildpacks/dotnet-execute      0.3.1
===> ANALYZING
Previous image with name "dotnet-aspnet-sample" not found
===> RESTORING
===> BUILDING
Paketo .NET Core Runtime Buildpack 0.1.7
  Resolving Dotnet Core Runtime version
    Candidate version sources (in priority order):
      aspnet.csproj -> "3.1.0"
      <unknown>     -> "*"
      <unknown>     -> "*"
      <unknown>     -> "*"

    No exact version match found; attempting version roll-forward

    Selected dotnet-runtime version (using aspnet.csproj): 3.1.12

  Executing build process
    Installing Dotnet Core Runtime 3.1.12
      Completed in 5.655s

  Configuring environment for build and launch
    DOTNET_ROOT -> "/workspace/.dotnet_root"

  Configuring environment for build
    RUNTIME_VERSION -> "3.1.12"

Paketo ASP.NET Core Buildpack 0.1.6
  Resolving Dotnet Core ASPNet version
    Candidate version sources (in priority order):
      RUNTIME_VERSION -> "3.1.12"
      aspnet.csproj   -> "3.1.0"
      <unknown>       -> "*"

    Selected dotnet-aspnetcore version (using RUNTIME_VERSION): 3.1.12

  Executing build process
    Installing Dotnet Core ASPNet 3.1.12
      Completed in 1.59s

  Configuring environment
    DOTNET_ROOT -> "/workspace/.dotnet_root"

Paketo .NET Core SDK Buildpack 0.1.6
  Resolving .NET Core SDK version
    Candidate version sources (in priority order):
      RUNTIME_VERSION -> "3.1.406"
      aspnet.csproj   -> "3.1.*"
      <unknown>       -> "*"

    Selected .NET Core SDK version (using RUNTIME_VERSION): 3.1.406

  Executing build process
    Installing .NET Core SDK 3.1.406
      Completed in 12.86s

  Configuring environment
    DOTNET_ROOT -> "/workspace/.dotnet_root"
    PATH        -> "/workspace/.dotnet_root:$PATH"

Paketo ICU Buildpack 0.0.100
  Executing build process
    Installing ICU
      Completed in 2.059s

Paketo .NET Publish Buildpack 0.1.4
  Executing build process
    Running 'dotnet publish /workspace --configuration Release --runtime ubuntu.18.04-x64 --self-contained false --output /tmp/dotnet-publish-output085416393'
      Failed after 1.2631765s

        Welcome to .NET Core 3.1!
        ---------------------
        SDK Version: 3.1.406

        Telemetry
        ---------
        The .NET Core tools collect usage data in order to help us improve your experience. It is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

        Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

        ----------------
        Explore documentation: https://aka.ms/dotnet-docs
        Report issues and find source on GitHub: https://github.com/dotnet/core
        Find out what's new: https://aka.ms/dotnet-whats-new
        Learn about the installed HTTPS developer cert: https://aka.ms/aspnet-core-https
        Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli-docs
        Write your first app: https://aka.ms/first-net-core-app
        --------------------------------------------------------------------------------------
        Microsoft (R) Build Engine version 16.7.2+b60ddb6f4 for .NET
        Copyright (C) Microsoft Corporation. All rights reserved.

          Determining projects to restore...
        /layers/paketo-buildpacks_dotnet-core-sdk/dotnet-core-sdk/sdk/3.1.406/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(127,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.1.0.  Either target .NET Core 3.1 or lower, or use a version of the .NET SDK that supports .NET Core 3.1.0. [/workspace/aspnet.csproj]
failed to execute 'dotnet publish': exit status 1
ERROR: failed to build: exit status 1
ERROR: failed to build: executing lifecycle: failed with status code: 145

Build Configuration

What platform (pack, kpack, tekton buildpacks plugin, etc.) are you
using? Please include a version.
pack 0.16.0+git-e0f6c50.build-1898

What buildpacks are you using? Please include versions.

6 of 10 buildpacks participating
paketo-buildpacks/dotnet-core-runtime 0.1.7
paketo-buildpacks/dotnet-core-aspnet  0.1.6
paketo-buildpacks/dotnet-core-sdk     0.1.6
paketo-buildpacks/icu                 0.0.100
paketo-buildpacks/dotnet-publish      0.1.4
paketo-buildpacks/dotnet-execute      0.3.1

What builder are you using? If custom, can you provide the output from pack inspect-builder <builder>?
Paketo buildpacks base

Can you provide a sample app or relevant configuration (buildpack.yml,
nginx.conf, etc.)?
aspnet.csproj:

<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>netcoreapp3.1.0</TargetFramework>
  </PropertyGroup>

</Project>

Checklist

[x] I have included log output.
[x] The log output includes an error message.
[x] I have included steps for reproduction.

Based on the Microsoft documentation about supported target frameworks, it looks like the root cause of your issue is that <TargetFramework>netcoreapp3.1.0</TargetFramework> is not a valid framework. Accepted target frameworks are in the form netcoreappX.Y or net5.*.
Using the official Microsoft distributed .NET SDK Docker image  to dotnet publish the same sample app as above with a projfile containing <TargetFramework>netcoreapp3.1.0</TargetFramework>, we see the same error:
docker run -it -v "$(pwd)":/workspace mcr.microsoft.com/dotnet/sdk:3.1

root@86922f52fa36:/workspace# dotnet publish /workspace --configuration Release --runtime ubuntu.18.04-x64 --self-contained false --output /tmp/dotnet-publish-output358968159
Microsoft (R) Build Engine version 16.7.2+b60ddb6f4 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
/usr/share/dotnet/sdk/3.1.406/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(127,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.1.0.  Either target .NET Core 3.1 or lower, or use a version of the .NET SDK that supports .NET Core 3.1.0. [/workspace/aspnet.csproj]

I think we need to update the regular expression that checks for a valid Target Framework version. Currently, something like netcoreapp3.1.0 passes when it shouldn't.
(The regex net(?:coreapp)?(?:(?:\d\.\d)(?:\-?\w+)?)$ might just do the trick.)


Add --no-install command to resolve command

Add the ability to resolve dependency trees and generate lock-files without installing dependencies. This is relevant because I already have all my dependencies installed in a private image that I'm using as a base to perform the Debricked scan in my CI, therefore I would just like to resolve my (pip) lock files and scan them, without installing stuff.

Shouldn't this be the default, or why would you want to install packages?


Adding Homebridge to Home fails after Removal

Initially, I was able to add Homebridge as a HomeKit accessory via Apple's HMCatalog sample code project, but as I added platforms & accessories to Homebridge & restarted the server they never appeared.  To resolve this, I removed Homebridge from my Home and attempted to re-add it.
Steps I took:

Change the homebridge username address
Change the HomeKit PIN number
Remove the ~/.homebridge/persist/ directory
Restarted homebridge

Now, when I add Homebridge via HMCatalog, I see this after I enter the PIN:

When I try to add Homebridge via Insteon+, I see this after I enter the PIN:

Any advice?

Related: https://github.com/nfarina/homebridge/issues/429

Update: I suspect the root cause is hidden in one of my installed plugins. If I remove homebridge-liftmaster and homebridge-nest from my .homebridge/config.json the device can be added successfully via the iOS apps. However, if I re-add either to my config.json and restart homebridge, the iOS apps will report they cannot connect to the Homebridge accessory.
Nothing is logged to STDOUT/STDERR in this case.
~ $ node -v
v4.3.1
 ~ $ npm -v
2.1.11

If you can isolate the problem to a specific plugin, I'd suggest you to contact plugin developer for further assistance.
Sent from my iPhone

On Mar 6, 2016, at 11:07 AM, Justin Searls<EMAIL_ADDRESS>wrote:
Update: I suspect the root cause is hidden in one of my installed plugins. If I remove homebridge-liftmaster and homebridge-nest from my .homebridge/config.json the device can be added successfully via the iOS apps. However, if I re-add either to my config.json and restart homebridge, the iOS apps will report they cannot connect to the Homebridge accessory.
Nothing is logged to STDOUT/STDERR in this case.
~ $ node -v
v4.3.1
~ $ npm -v
2.1.11
—
Reply to this email directly or view it on GitHub.

Huh. My guess is it Nest as Kraigm updated the plugin 9 days ago. Try
removing that one and adding the LiftMaster back into ur config and try
running.

If I add only LiftMaster or only Nest, I get the error.

On Mar 6, 2016, at 2:42 PM, AppleTechy<EMAIL_ADDRESS>wrote:
Huh. My guess is it Nest as Kraigm updated the plugin 9 days ago. Try
removing that one and adding the LiftMaster back into ur config and try
running.
—
Reply to this email directly or view it on GitHub.


Do not publish stale signature files

This commit fixes the publication of stale signature files:
prior to this change it was possible that a signature generated
in a previous build for a different artifact was uploaded even
if no signature was generated during the build, which would
lead to inconsistent publications.
In addition, it makes it an error to publish something which
doesn't have the main artifact created (or, at least up-to-date)
in this build. In other words, if the task which generates the
main artifact is disabled, it's an error to publish.
Other stale artifacts are going to be ignored.
Fixes #5136

The code is a bit convoluted because of a lot of background assumptions, like when errors should be thrown, or the fact that publications can be configured at any time...


merge data transfer accounts for relations between two merging refere…

…nces, in which case both are red for removing, and while transferring data it's removed from the losing reference list, it's the same connection so does not need to be removed from the winning reference side.  refactor toggle to use boolean.

Thanks @sweng66 !


Simplified load test - deployments and services bundled together

Ref. https://github.com/kubernetes/perf-tests/issues/413
This change is no-op for CI/CD tests.
The simplified load test is is added in a new file config2.yaml that will replace the old config.yaml once the new config is tested properly.
I run the tests on 100 node cluster and the results look promising:

/assign @wojtek-t

/lgtm


Updated README for obsolete NAT parameter. Added a sample parameters file.

The NAT parameter referenced in README.md was obsolete.
The parameters file makes it a little easier to manage all of the parameters.

Thanks for your contribution @griffint61 !!   I didn't even realize that there was a nicer and more sane way to pass in attributes (via the JSON file).   do you think we should start telling people to do that rather than the massive pile of CLI arguments?
If so, let's update the README to point entirely at the JSON file and maybe name it stack_parameters.json.example to prevent foot shootings?

Like that?

Perfect, thank you!


Renames REP v2 symbol to REPv2.

This got in through this commit: https://github.com/AugurProject/augur/commit/37006fedfd5ad8961eac5b9de7dec83de0158daf


Request for 1pm / 2pm support

Hello, I have 2 old SMA solar inverters that do not support modbus over udp/tcp. I bought shelly pro pm's in order to be able to make them communicate with my Cerbo GX. Unfortunately this does not work. The Shelly appear in the list on the Remote Console, without data. But they do not show up in the VRM device list.
Could you please add support for pro 1pm an 2pm via websockets,
Thanks,
Rob Meerwijk

I have created pull request #17 for this. It is fully operational, but no reaction from the Victron devs as to integrating it.

Is there also support for the Shelly PRO EM-50 single-phase energy meter? Shelly Pro 1PM is now obsolete and out of sale.

No reaction to my pull request, so I've gone through another solution here. I've contributed the direct support of Shelly Gen2+ devices.


Add routes for index pagination

The is dependent on this issue being implemented and released in meilisearch-python-async

The functionality was added in meilisearch-python-async. This is now dependent on #318.

This is ready to implement. There should be new get, post, and delete routes added to index_routes for pagination. There are corresponding get_pagination, update_pagination, and delete_pagination methods in meilisearch-python-async to use for this.


How can I find formal environment variables that match my own cloud hosting environment?

https://github.com/opea-project/GenAIExamples/blob/main/ChatQnA/docker_compose/intel/cpu/xeon/README.md
Where do the environment variables in the 'Set up the environment variables' step in this file come from? How can I find formal environment variables that match my own cloud hosting environment? Can you give an example?

those environment variables are used in docker-compose deployment methods, so I would suggest you to raise the issue in GenAIExamples repo instead of here


Feat: Add chat streaming

New feature:

Add streaming support (ready to code it, doing it in my fork, will make the PR if allowed)

Updates to make:

Use updated default values for text generation. I already have it coded in my fork, ready to make the PR when allowed

@PabloSanchi this would be a great feature - you are more than welcome to make a contribution. Thanks!


Investigate accuracy of United markers

According to @simonaho some of the United markers are in locations that don't quite make sense, suggesting their coordinates are not quite accurate.

I showeג a few samples (such as accidents in gardens) to @galraij yesterday and will talk to United.


Use the same license tokens/link as opensource.org

i.e. instead of  NewBSD one would use BSD-2-Clause, etc so linking to
http://opensource.org/licenses/BSD-2-Clause would be trivial.
(or add to the data structure, a Link field would contain the right link to opensource.org)
thoughts?  Im happy to do the work.
regards,
n

A few projects I know of persist the current license tags into serialized JSON, etc., so we wouldn't want to break those. I think what we can do though, is have like a Meta map[string]string in the License struct, which would let us add arbitrary key/value data to each one once we detect the type. Thanks for the suggestion!

hi again
I whipped up this, as a sample.  Im happy to port it any format you want (or just leave it as a separate item).
https://github.com/client9/gosupplychain/blob/master/license_meta.go
I love the new branch you are working on.
thanks!
nickg


Offset offsets posts on each page, not just first

Hi all! I'm fairly new to Jekyll but I can't seem to find a way to fix this bug. I have a featured section on my blog that always shows the most recent post. The other posts appear below, 10 per page using paginate-v2. I tried to simply show them using {% for post in paginator.posts offset:1 %}, but this is flawed in two ways:

it only shows 9 posts per page instead of 10
it offsets each page, so that the 1st, 10th, 20th, etc. posts are hidden, which is not what I want

Am I just using offset wrong, or is this a bug in paginate?
Right now I've "fixed" it by doing the following, but it's not ideal as the first page only shows 9 posts:

    {% assign featuredpost = site.posts.first %}
      {% for post in paginator.posts %}
      {% if post == featuredpost %}
      {% continue %}
      {% else %}

{{post.author}} | {{ post.date | date: '%B %d, %Y' }}

{{post.title}}

{{post.content}}

      {% endif %}
      {% endfor %}

Hello,
I also ran into this issue and after trying a dozen different things, nothing worked.
So I went with a pretty basic method. :)

Remove offset code.
Run Jekyll build.
In _site copy category and tag folder.
In the latest post, add hidden: true in the front matter.
Run jekyll build again.
in _site, delete category and tag folder and replace with copied folder from before.

It's a manual solution but it works, next thing for me will be automating this part.

@rvanhorn That's a good manual workaround, but not really feasible for me as our company blog is updated several times a week by different people. I really wish this could be fixed.

@bildungsroman Hi Anna, sorry that you've been having issues with this plugin. This should be resolved now.
I've just pushed a new gem version v2.0.0 that includes a new 'offset' feature (I actually dug this out of an old closed PR that I hadn't merged). Could you give it a spin?
The documentation for the feature is here:
https://github.com/sverrirs/jekyll-paginate-v2/blob/master/README-GENERATOR.md#offsetting-posts

@sverrirs Thank you! I'll implement it and let you know

That worked for me, thanks @sverrirs.

Alright, I'll close this issue for now then. :)


Improved automation settings

Have a table with all the automation options, with checkboxes to turn specific automations on/off.

My first pass at breaking out automation:


Go back when clicking on left half

Hi!
When I click on a story it goes ahead with the next one.
I would like to go ahead If I click on the right half and go back to previous story if I click on the left half, just like Instagram.
Thank you!

+1

🔝  Added on last version. thanks


Shadows to tiles casting issues

Coordinates : 4261, 661

I must have missed some edge case when tweaking terrain shadows recently, will take a look

Should be fixed in <IP_ADDRESS>

fixed


View cleanup

This is just a bit of tidying for View. Moving the rasterization functions into a separate file cleans up view.cpp nicely and also means we could use raster scanning in other contexts.

Looking good to me! @hjanetzek you can merge once you had a chance to give a look.


[test] Eiger system added to NAMD check

Hello @ChristopherBignamini, Thank you for submitting the Pull Request!

In the file cscs-checks/apps/namd/namd_check.py:

Line 32:80: E501 line too long (85 > 79 characters)

Do see the ReFrame Coding Style Guide

Hello @ChristopherBignamini, Thank you for submitting the Pull Request!

In the file cscs-checks/apps/namd/namd_check.py:

Line 32:80: E501 line too long (85 > 79 characters)

Do see the ReFrame Coding Style Guide

@jenkins-cscs retry eiger

@jenkins-cscs retry eiger

Codecov Report

Merging #1682 (21e3bde) into master (d56e435) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1682   +/-   ##
=======================================
  Coverage   87.21%   87.21%
=======================================
  Files          45       45
  Lines        7546     7546
=======================================
  Hits         6581     6581
  Misses        965      965

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56e435...21e3bde. Read the comment docs.

Codecov Report

Merging #1682 (21e3bde) into master (d56e435) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1682   +/-   ##
=======================================
  Coverage   87.21%   87.21%
=======================================
  Files          45       45
  Lines        7546     7546
=======================================
  Hits         6581     6581
  Misses        965      965

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56e435...21e3bde. Read the comment docs.

I agree with @lucamar. Performance numbers need to be updated and take care as well of the PEP8 complaints.

I agree with @lucamar. Performance numbers need to be updated and take care as well of the PEP8 complaints.

The reference numbers are best I have been able to obtain so far for the smp build (current module on Eiger). I have tried to use the cpuaffinity option of NAMD but I don't see any change in the performances. I will have a look to the slurm affinity options/job configuration on Eiger, hopefully I will get better results. In the meantime I will also try with a pure MPI build that, according to the performances reported in the jira issue SD-51014, is faster than the smp one.

The reference numbers are best I have been able to obtain so far for the smp build (current module on Eiger). I have tried to use the cpuaffinity option of NAMD but I don't see any change in the performances. I will have a look to the slurm affinity options/job configuration on Eiger, hopefully I will get better results. In the meantime I will also try with a pure MPI build that, according to the performances reported in the jira issue SD-51014, is faster than the smp one.

@jenkins-cscs retry all

@jenkins-cscs retry all


Configurable background for ItemView activation

ItemBackground for view activation should be configurable and loaded dynamically, no XML.

The Class Utils will be renamed to ColorUtils.
Method dpToPx will also be removed.


Coral will install in Python 3 environment, but then fails to import.

Coral does not appear to be Python 3 compatible, but setup.py and pip will allow it to install in a Python 3 environment, only to have it fail on initial import. It might make sense to have a check for this in setup.py.

Added trove classifiers and version check to setup.py as of commit 7f54a16785ff5b29906889b74d46422b91fddef8, so it should now fail to install in a Python 3 environment with a useful message (until a Python 3 version is ported).

Closing for now, let me know if the setup.py changes haven't resolved the issue (should be fixed as of release 0.3.4)


[Bug]: flaky test suite Webhook

What happened?
While runningmake test in the cf-k8s-api repository, we encountered this flake. Two tests failed in the controller integration tests. Here is the output:
2021-09-29T09:54:34.227Z        DEBUG   controller-runtime.webhook.webhooks     wrote response  {"webhook": "/validate-workloads-cloudfoundry-org-v1alpha1-cfapp", "code": 403, "reason": "CFApp with the sa
me spec.name exists", "UID": "2f076569-15c2-4301-a915-ce83d80a3bf5", "allowed": false}
2021-09-29T09:54:34.240Z        DEBUG   controller-runtime.certwatcher  certificate event       {"event": "\"/tmp/envtest-serving-certs-1884256285/tls.key\": REMOVE"}
2021-09-29T09:54:34.240Z        ERROR   controller-runtime.certwatcher  error re-watching file  {"error": "no such file or directory"}
github.com/go-logr/zapr.(*zapLogger).Error
        /home/danailster/go/pkg/mod/github.com/go-logr/zapr@v0.2.0/zapr.go:132
sigs.k8s.io/controller-runtime/pkg/log.(*DelegatingLogger).Error
        /home/danailster/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/log/deleg.go:144
sigs.k8s.io/controller-runtime/pkg/webhook/internal/certwatcher.(*CertWatcher).handleEvent
        /home/danailster/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/webhook/internal/certwatcher/certwatcher.go:144
sigs.k8s.io/controller-runtime/pkg/webhook/internal/certwatcher.(*CertWatcher).Watch
        /home/danailster/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/webhook/internal/certwatcher/certwatcher.go:102
2021-09-29T09:54:34.240Z        ERROR   controller-runtime.certwatcher  error re-reading certificate    {"error": "open /tmp/envtest-serving-certs-1884256285/tls.crt: no such file or directory"}
github.com/go-logr/zapr.(*zapLogger).Error
        /home/danailster/go/pkg/mod/github.com/go-logr/zapr@v0.2.0/zapr.go:132
sigs.k8s.io/controller-runtime/pkg/log.(*DelegatingLogger).Error
        /home/danailster/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/log/deleg.go:144
sigs.k8s.io/controller-runtime/pkg/webhook/internal/certwatcher.(*CertWatcher).handleEvent
        /home/danailster/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/webhook/internal/certwatcher/certwatcher.go:149
sigs.k8s.io/controller-runtime/pkg/webhook/internal/certwatcher.(*CertWatcher).Watch
        /home/danailster/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/webhook/internal/certwatcher/certwatcher.go:102
2021-09-29T09:54:34.240Z        INFO    controller-runtime.webhook      shutting down webhook server
--- FAIL: TestSuite (9.51s)
    --- FAIL: TestSuite/Webhook (0.18s)
        --- FAIL: TestSuite/Webhook/CFAppReconciler/creating_a_new_CFApp_record/another_CFApp_exists_with_a_same_name_in_the_same_namespace/should_fail (0.03s)
            cfapp_validation_integration_test.go:126:
                Expected failure, but got no error.
        --- FAIL: TestSuite/Webhook/CFAppReconciler/updating_an_existing_CFApp_record/modifing_desiredState/should_succeed (0.02s)
            cfapp_validation_integration_test.go:138:
                Expected success, but got an error:
                    <*errors.StatusError | 0xc0004cf180>: {
                        ErrStatus: {
                            TypeMeta: {Kind: "", APIVersion: ""},
                            ListMeta: {
                                SelfLink: "",
                                ResourceVersion: "",
                                Continue: "",
                                RemainingItemCount: nil,
                            },
                            Status: "Failure",
                            Message: "admission webhook \"vcfapp.kb.io\" denied the request: CFApp with the same spec.name exists",
                            Reason: "CFApp with the same spec.name exists",
                            Details: nil,
                            Code: 403,
                        },
                    }
                    admission webhook "vcfapp.kb.io" denied the request: CFApp with the same spec.name exists
FAIL
coverage: 97.1% of statements
FAIL    code.cloudfoundry.org/cf-k8s-controllers/webhooks/workloads     9.540s
?       code.cloudfoundry.org/cf-k8s-controllers/webhooks/workloads/webhooksfakes       [no test files]
FAIL

What you expected to happen
The tests should pass.
Acceptance Criteria
GIVEN
the api repo is checked out
WHEN I
run make test
THEN I
see no errors from the cf-k8s-controller tests
How to reproduce it (as minimally and precisely as possible)
run make test until it fails
Anything else we need to know?
It seems like other tests could fail as well, but it seems like the CFApp with the same spec.name exists error is always there. This could be an issue with not cleaning up properly after tests.
Environment
Revision of codebase: cf-k8s-api (69945ad), cf-k8s-controller (00f5f14)
Kubernetes version (use kubectl version):
❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.2", GitCommit:"092fbfbf53427de67cac1e9fa54aaa09a28371d7", GitTreeState:"clean", BuildDate:"2021-06-16T12:59:11Z", GoVersion:"go1.16.5"
, Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4"
, Compiler:"gc", Platform:"linux/amd64"}

Cloud provider or hardware configuration:
❯ uname -a
Linux danailster-eirini-station 5.8.0-1035-gcp #37~20.04.1-Ubuntu SMP Thu Jun 17 16:04:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Others: N/A

This one is too old and potentially fixed by the lease locking mechanism for avoiding duplicate names.


quasi88 0.6.4 (new formula)

QUASI88 is an emulator for NEC PC-8801 series computer.

Failing to build on Mountain Lion: http://bot.brew.sh/job/Homebrew Games Pull Requests/311/version=mountain_lion/testReport/junit/brew-test-bot/mountain_lion/install_Homebrew_games_quasi88/

The link issue on Mountain Lion due to -Wl,-s is now fixed with explicitly set LD macro.


Automate searching for environment & workspace by name

When making a change to an environment or a workspace I know the name of what I want to change, but I need to lookup the ID to pass into the CLI. If I could pass in the name then it would save manually looking this up.
I can do this with multiple commands at the moment, and pipe it together, but it feels like something which the CLI could handle for me.
Example of getting an environment ID from name, and then piping that back to the get-workspaces command, filtering just on the environment:
scalr list-environments | jq '.[] | select(.name=="demo-aa") | .id' | xargs -I {} scalr get-workspaces -filter[environment]={}

Great feedback. I will have to think about how to implement this in the best way. It would make most sense to implement some kind of id-search attribute to be able to search by more than name and also for all commands and not only workspaces. Any ideas?


Bundles not saved

I create a bundle in the "Home" screen and after a restart the bundle keeps disappearing.
Edition	Windows 11 Pro
Version	21H2
OS build	22000.556
Experience	Windows Feature Experience Pack 1000.22000.556.0

This is the repo for the website, not the app. Please open the issue again in https://github.com/files-community/files.


Efficient loading of a Cassandra CQL table as Spark DataFrame

Support for Spark 1.3 is resolved as indicated in #7 and #8.
However, the support for data frames is implemented rather naively. Data is loaded from Cassandra, into Spark on the JVM side, then loaded into the python worker process to be converted back to a org.apache.spark.sql.DataFrame. Clearly, this can be greatly improved.

Isn't this a fundamental issue with Spark in general?  Is it any different if you're pulling data back out of HDFS?

Off-topic:
Well, in general, Spark is dropping a lot of possible performance gain by introducing a collocated JVM instead of integrating with another JVM. Of course a) this is not always possible (not all sources are JVM based) and b) this is a much more difficult integration point. But obviously if Spark could e.g.  with Cassandra read and write directly from within the Cassandra JVM and possibly tap into or even serve as Cassandra's key / row cache this could - gut feeling here - substantially improve performance.
More on topic:
Data frames in Spark are things living primarily in the JVM. When converting an RDD to a DF with rdd.toDF(...) what happens is that in pyspark.sql.context the method _to_java_object_rdd is invoked on the RDD. This in turn calls pythonToJava on org.apache.spark.api.python.SerDeUtil. So the elements in the PythonRDD are unpickled into a JavaRDD.
Of course when using e.g. map(...)on a DataFrame things are going to get pickled at the JVM side, unpickled in the python worker process and then the map function gets applied yielding a RDD with python.sql.types.Row elements. If you do something like this as your first operation on a DF ... you shouldn't have converted to a DF in the first place. Maybe convert the mapped RDD into a DF, but not before, waste of CPU cycles.
Operations like filter(...) on the other hand aren't executed within the python worker process, but in the JVM. Consider df.filter(df.age > 3).collect(). In this example, the argument to filter is a pyspark.sql.dataframe.Column instance. df.age is such a column and comparing it with 3 yields a new column which can be used within the JVM (and by catalyst) to filter out rows from a DF without bothering the python worker process.
The same holds of course for cases where the DF is registered as a temporary table with DataFrame.registerTempTable(name) and you subsequently fire SQL statements at this table.
So given the above, what I plan to implement is something which allows operating on a Cassandra CQL table as a Spark DF without first converting it to python RDD and then converting it to a DF.

I hadn't realized that loading up a cassandra table into a dataframe would cause the table data to go from JVM to Python to JVM again.  If that's the case, I completely agree avoiding that would be a good thing :)
To the point of putting spark & cassandra in the same process, that's beyond my current knowledge, but I agree conceptually.  Happy to help test it out though.

What are your thoughts on something like sc.cassandraTableAsDataFrame(keyspace, table, sql_context...), with a Java helper that takes care of the mess under the hood?

I think there's no need to such a big method. Because cassandraTable is lazy I was thinking more along the lines of extending CassandraRDD. And indeed performing the messy part on the JVM.
But I think the guys at Spark Cassandra Connector are taking a different route: their implementing the generic load method of SQLContext. See https://github.com/datastax/spark-cassandra-connector/blob/master/doc/14_data_frames.md for more details.
I think following their approach in general is a good thing unless there are more pythonic ways of doing things. Which isn't the case here I guess.

Would it be a big method?  It's just creating a cassandra table, calling toDF() on it and returning the result.  My assumption was that it would only be 1 more line than creating a cassandraTable.

Sorry, fuzzy expression :) I meant big in the sense that it enlarges the API footprint. Currently the following combinations are possible for creating a DataFrame:

sc.cassandraTable(...).toDF(...)
sc.cassandraTable(...).select(...).toDF(...)
sc.cassandraTable(...).where(...).toDF(...)
sc.cassandraTable(...).select(...).where(...).toDF(...)

These 'paths' are already supported, so I'd refrain from making the API larger than is necessary.

I've spoken to the driver guys.  It seems that we're looking at this backwards.  There's a data frame api that's exposed that we can use instead of using RDDs.
This should work:
sql = SQLContext(sc)
options = sc._gateway.jvm.java.util.HashMap()
options["keyspace"] = "labor"
options["c_table"] = "average_price_data"
sql.load(source="org.apache.spark.sql.cassandra",
         options=options)

but unfortunately I get this error:
Py4JJavaError: An error occurred while calling o37.load.
: java.lang.RuntimeException: Failed to load class for data source: org.apache.spark.sql.cassandra
	at scala.sys.package$.error(package.scala:27)
	at org.apache.spark.sql.sources.ResolvedDataSource$.lookupDataSource(ddl.scala:194)
	at org.apache.spark.sql.sources.ResolvedDataSource$.apply(ddl.scala:205)
	at org.apache.spark.sql.SQLContext.load(SQLContext.scala:697)
	at org.apache.spark.sql.SQLContext.load(SQLContext.scala:685)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:231)
	at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:379)
	at py4j.Gateway.invoke(Gateway.java:259)
	at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:133)
	at py4j.commands.CallCommand.execute(CallCommand.java:79)
	at py4j.GatewayConnection.run(GatewayConnection.java:207)
	at java.lang.Thread.run(Thread.java:745)

Thoughts?

I was able to load this and print the output:
from pyspark import SparkConf
from pyspark.sql import SQLContext
import pyspark_cassandra
from pyspark_cassandra import CassandraSparkContext, RowFormat, Row, UDT, WriteConf
conf = SparkConf().set("spark.cassandra.connection.host", "<IP_ADDRESS>").set("spark.cassandra.connection.native.port","9042")
sc = CassandraSparkContext(conf = conf)
tabled = sc.cassandraTable("keyspace1", "table1")
print users
sql = SQLContext(sc)
#------------ Upto here  owrks
sql.registerDataFrameAsTable(tabled, "tabled")
The above line didnt work and throw the following error:
File "~/spark-1.3.1-bin-hadoop2.6/python/pyspark/sql/context.py", line 324, in registerDataFrameAsTable
raise ValueError("Can only register DataFrame as table")
ValueError: Can only register DataFrame as table
Would you please let me know what I am doing wring in the "registerDataFrameAsTable" line.
Thanks
Rajesh R


 add support for aarch64 _Float16 16-bit floating point type

Fixes #39759.

You need to add the following content to the vcpkg.json file: "port-version": 1. Then run the command ./vcpkg x-add-version {portname} and submit the modified content.

You need to add the following content to the vcpkg.json file: "port-version": 1. Then run the command ./vcpkg x-add-version {portname} and submit the modified content.
ok, I will modify it


[WIP]Setup storybook for react

Updated react storybook to latest version and started create stories for components from  shared/components

@Zapix - I'm so excited for this to get integrated. It looks like you're nearing completion. Simply tag me when done.

@kylemh I've finished with stories. Please check is everything is ok.Also if you want something more for this pr just let me know.

Beautiful work, beautiful commit history - A+
Looking through our storybook is very revealing... We need to be much better about our atomic design principles and be wary of how we style reusable items.
I supremely look forward to any and all contributions from you.


Remind users to initialize their systems before running them

Objective

Manually running systems is a somewhat obscure process: systems must be initialized before they are run
The unwrap is rather hard to debug.

Solution

Replace unwraps in FunctionSystem methods with expects (progress towards #3892).
Briefly document this requirement.

bors r+


Update error message to include filename

This change is

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a359d10) 86.82% compared to head (23501da) 86.79%.
Report is 5 commits behind head on main.

Files
Patch %
Lines

machine/corpora/usfm_file_text.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   86.82%   86.79%   -0.03%
==========================================
  Files         226      226
  Lines       13629    13629
==========================================
- Hits        11833    11829       -4
- Misses       1796     1800       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

machine/corpora/usfm_file_text.py line 39 at r1 (raw file):

                    id = id[:index]
                return id.strip().upper()
    raise RuntimeError("The USFM file '{filename}' does not contain an 'id' marker.")

Doesn't that need to be an f-string?  Does it render correctly?


fix migrations date conflict with laravel/oauth module

We need to make cortex/oauth migrations load after rinvex/laravel-oauth migrations

Thank you, this is now fixed in https://github.com/rinvex/cortex-oauth/commit/5d385edf5b14ad865ef71c316c39fe7327cee746


config.yml -- Redis - Environment Variable Setting?

in config.yml we set
redis:
  addr: localhost:6379

However if redis is in another container, it is not possible to determine the host:port ahead of time.
It also is not possible to set the environment variable REGISTRY_variable since that needs to be resolved "again" after launch (and the value is not available to docker run during initial execution).
What's a good way of associating redis from another container with the docker registry:2?

@pctj101 : for deploying sets of interacting containers, the recommended method is using docker compose

I use the docker-compose.yml to run a redis and a registry containers together :
cache:
  image: redis
  restart: always

backend:
  image: registry:2
  ports:
    - 127.0.0.l:5000:5000
  links:
    - cache
  volumes:
    - ./config.yml:/etc/docker/registry/config.yml
    - /srv/docker-registry:/var/lib/registry-cache
  restart: always

and I've changed registry config.yml :
redis:
  addr: cache:6379

where cache is the hostname of redis container from docker-compose.yml .

ooh cool :)


Problem met when trying to implement argmax in topi

@tqchen
When we do an argmax, we basically need to do:
T_idx, T_val = tvm.compute((m, ), lambda i: argmax((idx[i, k], val[i, k]), axis=k))

We can avoid using idx[i, k] by doing the following:
T_idx, T_val = tvm.compute((m, ), lambda i: argmax((k.var, val[i, k]), axis=k))

However, we cannot do this, which will appear when we want to calculate the idx w.r.t multiple reduce axes.
T_idx, T_val = tvm.compute((m, ), lambda i: argmax((k.var + k.var, val[i, k]), axis=k))

Is there a way to solve this problem?

I find it's not the cause


promql.ActiveQueryTracker: Unmap mmapped file when done

Fix promql.ActiveQueryTracker so that it unmaps any mmapped file in its Close method. Also fix TestMMapFile so it releases resources.
Related to https://github.com/prometheus/prometheus/pull/13948.

@machine424 I pushed a revision also to fix flakiness in TestQueryConcurrency, since non-deterministic goroutine behaviour in it would cause panics in combination with my changes in this PR.


aursync doesn't manage to install makedepends

Pretty much summed up in the title. Context is that I'm trying to migrate to aurutils. I execute pacman -Qqm | xargs aursync to try and add all the packages to the database (don't know if that's necessary, but this is still a bug report). What happens is after I clone all the package sources and exit vifm after checking the PKGBUILDs and stuff, pacman is called to install doxygen, which I assume is a makedepend of one of the packages i'm migrating. It seems to just fail though.
I can't reproduce it after installing doxygen to get the installation to proceed, even if I uninstall it again, so that's all the information I can provide in this report.

It seems to just fail though.
That's not a lot to go on without any information about the failure itself.  Maybe someone else who sees this issue can provide more detail.

I'll close this for now, if anyone has the same issue feel free to reopen.

Well that was quick. Pretty much as soon as I closed the issue, it happened again. I believe the issue is something to do with xargs stealing stdin or something? I know this isn't the place to ask about other tools, but how can I keep this from happening?
Log: https://ptpb.pw/D0TX.log

Oops, didn't mean to reopen >.<

A simple workaround is to use the ^--noconfirm` option.


Error ArrayIndexOutOfBoundsException while inserting array

Environment

OS version: Linux CentOS 7
JDK version: 8
ClickHouse Server version: N/A (latest)
ClickHouse Native JDBC version: 2.5.4
(Optional) Spark version: 2.4.3 (cluster cdh-6)
(Optional) Other components' version: N/A

Error logs
java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 1048576
	at com.github.housepower.repackaged.net.jpountz.util.SafeUtils.checkRange(SafeUtils.java:24)
	at com.github.housepower.repackaged.net.jpountz.util.SafeUtils.checkRange(SafeUtils.java:32)
	at com.github.housepower.repackaged.net.jpountz.lz4.LZ4JavaSafeCompressor.compress(LZ4JavaSafeCompressor.java:141)
	at com.github.housepower.repackaged.net.jpountz.lz4.LZ4Compressor.compress(LZ4Compressor.java:95)
	at com.github.housepower.jdbc.buffer.CompressedBuffedWriter.flushToTarget(CompressedBuffedWriter.java:75)
	at com.github.housepower.jdbc.serde.BinarySerializer.flushToTarget(BinarySerializer.java:112)
	at com.github.housepower.jdbc.connect.NativeClient.disconnect(NativeClient.java:153)
	at com.github.housepower.jdbc.ClickHouseConnection.close(ClickHouseConnection.java:141)
	at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$.savePartition(JdbcUtils.scala:710)
	at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$$anonfun$saveTable$1.apply(JdbcUtils.scala:834)
	at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$$anonfun$saveTable$1.apply(JdbcUtils.scala:834)
	at org.apache.spark.rdd.RDD$$anonfun$foreachPartition$1$$anonfun$apply$28.apply(RDD.scala:935)
	at org.apache.spark.rdd.RDD$$anonfun$foreachPartition$1$$anonfun$apply$28.apply(RDD.scala:935)
	at org.apache.spark.SparkContext$$anonfun$runJob$5.apply(SparkContext.scala:2121)
	at org.apache.spark.SparkContext$$anonfun$runJob$5.apply(SparkContext.scala:2121)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.run(Task.scala:121)
	at org.apache.spark.executor.Executor$TaskRunner$$anonfun$11.apply(Executor.scala:407)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1408)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:413)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Steps to reproduce
Insert Array of String into Clickhouse table using Yarn cluster.
Other descriptions
I've seen that that error "got" fixed, but as you can see it's not the case : I'm using shaded versions of plugin too.
Created simple UDF to parse string into Array and then insert it -
  val toArr = udf((value: String) =>
    Option(value) match {
      case None  => Array[String]()
      case Some(value) =>
        if (value.contains(",")) {
          val res = value.split(",", -1).map(_.trim)
          res
        }
        else Array(value)
    })

But i get this error eventually.

#155 Looks the same, but should be fixed.

Hello, do you have any small data to reproduce this bug?

Ok, I've worked around it.
The problem was not the data per se, but using arrays in big scoped migrations.

Cloned master with the latest lz4 library changed to Aircompressor @pan3793
Built it with spark-integration for scala 2.11 and spark 2.4.3 (had to change pom files and remove spark-3 version)
Got new problem broken pipe error. Changed batchsize from 500_000 to 10_000 and got it working!

The big question: was it only the change in batch size or does the lz4 library helped too? Maybe i'll have time to test it later.
Thanks for the cool plugin!

Thanks @ccellado dig out this issue, and hope we can find the root cause and get a reproducible test case finally.

Built it with spark-integration for scala 2.11 and spark 2.4.3 (had to change pom files and remove spark-3 version)

BTW, the master branch show works with scala 2.11 and spark 2.4.3, you just need to specify maven profiles in IDE or mvn command.

Built it with spark-integration for scala 2.11 and spark 2.4.3 (had to change pom files and remove spark-3 version)

BTW, the master branch should works with scala 2.11 and spark 2.4.3, you just need to use specific maven profiles in IDE or mvn command.

Well, I've dug your tests for batch insert and there was 10000 batchsize max if I am correct.

Well, I've dug your tests for batch insert and there was 10000 batch size max if I am correct.

We run integration test with spark in 10000 batch size with total 2^17 records. And it also passed with 100,0000 batch size and 2^20 records. And we run benchmark with 200,000 and 500,000 batch size.

Well, in my experience 500000 does not work unfortunately with Arrays.
Forgot to mention - when there were no complex types like Array, 500000 batch went fine/


Minor adjustments to payment icon alignment and margins

This changes this:

To this:

...by using flexbox, of course.

Pull Request Test Coverage Report for Build 659

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.427%

Totals

Change from base Build 658:
0.0%

Covered Lines:
746

Relevant Lines:
1195

💛  - Coveralls


feat(clerk-js,clerk-react,types): Add closeUserButton and openUserBut…

…ton methods
Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[x] @clerk/clerk-js
[x] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[x] @clerk/types
[ ] @clerk/clerk-expo
[ ] @clerk/backend-core
[ ] @clerk/clerk-sdk-node
[ ] @clerk/edge
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

Introduce closeUserButton and openUserButton methods to programmatically control visibility of the <UserButton /> component.
These methods can be used directly from the Clerk object or from the useClerk hook (This object was selected as we already have the openXModal methods there) .
https://www.notion.so/clerkdev/a853f869f69c414b85e6d5290a2c4172?v=7792dc836db24909bd1f89501b5b331f&p=3ec7be1aa49b4c179a6b925b86d3ecb9

Closing this one as we will implement this functionality for the v4 components directly
cc: @SokratisVidros


osmand device identifier

hi, when using your Android Traccar Client it shows me a 6 digit device identifier. I was wondering how this is generated or where it is picked up from? Thanks

It's a randomly generated number.

alright thanks :+1:

so would it be ok if I used any alphanumeric string instead?

Yes, it can be any string.

alright thanks :)


Change to new version of pngjs

They removed the node-zlib-backport dependency yesterday:
https://github.com/lukeapage/pngjs/commit/b914ab4d80add0844cfaec663a9f4f7cbaaca860
It should be possible to depend on the latest version again.

Thank you! I'll release this ASAP.


fix(runtime-core/transition): support the transition of a Fragment with a single element

close: #2415

Tested with rebasing on latest master and it doesn't really fix #2415 - there's also an easier workaround in vue-router (https://github.com/vuejs/vue-next/issues/2415#issuecomment-737357541)


Fix some TypeScript typings

Will add tests soon.

Coverage remained the same at 100.0% when pulling fedacb6f5433d9b1ca6e2a4aedfeccbb80c57592 on bcherny:master into 2205c0f65d9595df1b1fddd7b09c79102ae34401 on developit:master.


Fix "desciription" typo and automatically load agent tool name and description from language file.

Modify formatDescription.ts so that when new tools are created and the name and description are defined in the language file it will automatically use the specified name and description
Issue #, if available:
No issue #
Description of changes:
Fix the "desciription" typo
Automatically load name and description of tool from i18next lanhguage file rather than needing to edit formatDescription.ts
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LGTM! Thank you for your contribution!

LGTM! thank you for your contribution!!


Admin page

basically the server controller on the ux

Tablet -> display match/team information to ensure no duplicates or errors

Tablet Connectivity

Tablet Connectivity

Instead of always having 6 tablets, show all online. Good for remote scouting/rescouting/prescouting to identify ALL users

Control username

Force tablet to change group/team/match

Event/match type

Cancel match button for tablet

Submit

"Takeover" concept

Tator Tot Status


openai[patch]: bump sdk version

Tests failing with TypeError: Completions.create() got an unexpected keyword argument 'parallel_tool_calls'

Confirmed failure here: https://github.com/langchain-ai/langchain/actions/runs/9699399945/job/26768264896


FR: Make VSCode's configuration more amenable to traditional build systems

In many IDE's supporting traditional build systems such as Make/CMake/Meson etc., the configuration, build and debug steps are often inextricably linked, such that for each configuration, there may be different debug steps.
Yet, currently VSCode does not support this mode of operation, and assumes that "build" is a simple step (or a series of interlinked simple steps) that has only one path to follow. My use case is working on an open-source project that supports two different build systems, which have two completely different configure/build/debug steps, as well as multiple architectures support.
With the above in mind, it is a hassle to use VSCode's build/debug tasks because all of them are visible at once. I cannot "select a configuration" and have predefined build/debug steps that i can run seamlessly; instead, i have to pick the correct "Configure" task, followed by picking the correct "Build" task every time, followed by picking the correct "Debug" task every time.
It would be nice if VSCode had an option to act more like a traditional IDE would, where it would be possible to bundle together Configure/Build/Debug tasks. I can't really think of a nice way to implement that on top of existing infrastructure, but one way to do that would've been to 1) have an actual "configure" step (as opposed to lumping it in with build tasks), and 2) have multiple tasks.json files (e.g. "tasks.config1.json", "tasks.config2.json", etc.), which the user could "switch" to and use only tasks defined in those files, and ignore the rest (aside from maybe the global one).

"Debug" already supports to have "preLaunchTasks" and "postLaunchTasks". In addition Debug allows to have multiple configurations that the user can "switch" to. So I do not see anything actionable for Debug.

@weinand I think for debug this mean the user selects exactly one "build + debug configuration" then starts it.
Could this be done in an extension? The extension could have configurations file, which associates "configuration labels" with tasks and launch configs. From the tasks side, this is possible with the existing API since you can enumerate all tasks with fetchTasks. Such an extension could provide UI to set the current configuration and provide a "run" button which kicks it all off.

There is specific debug API for contributing debug configurations dynamically if the "launch.json" is missing. But this does not easily support to swap-in/out debug contributions from an existing "launch.json" based on some other configuration.
However, since debug configurations are just "settings" (see Configuration API), it is possible to create an extension that swaps debug and tasks configurations based on a "select a configuration" action.

Ok, it sounds like this is doable in an extension, which I think is where it belongs as it is more of an IDE feature than an editor feature.


only size-1 arrays can be converted to Python scalars

it failed to process features model. could anyone give a suggestion?
Traceback (most recent call last):
File "inference.py", line 657, in
main(args)
File "inference.py", line 566, in main
is_multimer=global_is_multimer,
File "/data/xTrimoMultimer/xtrimomultimer/data/feature_pipeline.py", line 108, in process_features
mode=mode,
File "/data/xTrimoMultimer/xtrimomultimer/data/feature_pipeline.py", line 77, in np_example_to_features
num_res = int(np_example["seq_length"])
TypeError: only size-1 arrays can be converted to Python scalars

we use colabfold to generate feature pkl file to skip this step in xtrimomultimer, and it works. But find the result performance is lower than alphafold origin result.


Fix rmi -f removing multiple tags

When an image has multiple tags and docker rmi is called with -f on a tag, only the single tag should be removed. The current behavior is broken and removes all tags and the image.

LGTM

LGTM

LGTM. Waiting for those builds to merge.


Container build still crashes on apt-get issue

The crashed process:
ERROR:vagga::builder: Error building container "py": step Install(["ca-certificates", "python3.6=3.6.2-1~16.04.york0"]) failed: error running <Command "/usr/bin/apt-get" "install" "-y" "ca-certificates" "python3.6=3.6.2-1~16.04.york0"; environ[6]; chroot="/vagga/root"; work-dir="/work"> killed by signal SIGBUS[7]

The waiting process:
Get:15 http://ua.archive.ubuntu.com xenial-security/restricted Translation-en [2428 B]
Fetched 3653 kB in 0s (4937 kB/s)
Reading package lists... Done
WARN:vagga::file_util: Another build process is executing `apt-get install` command against the same apt cache. Waiting ...
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
  locales

Probably the problem is because the first one has PPAs enabled and they might be cleaned on clean install of the second container (as you might note, it's installing the locales package, which means it's the first Ubuntu step)
Probably our lock doesn't help with this :(
/cc @anti-social

Could we use overlayfs for apt cache? I have a patch and it works fine at first sight.
Structure of mounted cache:
lowerdir=/vagga/cache/apt-cache
upperdir=/vagga/container/apt-overlay/upper
workdir=/vagga/container/apt-overlay/work

Possibly it is worth to make the feature optional as it may require extended attributes for opaque directories (although in our case apt-get should not remove anything from its cache). For example the option could be named apt-cache-use-overlayfs.

Also maybe it would be better to place upperdir and workdir in /vagga/cache to guarantee they are at same mountpoint with lowerdir. That will give us opportunity to just rename new cache entries when copying them back.

Yes sounds good (I think overlayfs didn't work in unprivileged mode in 2017 when issue was created :) ). And I think it's fine to put upper dir in container's directory (somewhere below root). I think it's common enough to put cache and container directories into the same volume (and by default vagga puts everything into the project dir anyways).

Possibly it is worth to make the feature optional

Can we detect whether this works, rather than requiring user to set the option manually? We can probably try mount and write (delete?) file. So we check both: whether unprivileged unionfs works and extended attributes.


Receive Message without apriori knowledge of the message body type

Looking at the Message and Receiver structs, it appears that it is not possible to receive a message without the caller having apriori knowledge of the underlying message format.
The challenge here is that a message receiver has no way of knowing what type of message was sent from the sender, so an API surface which forces the receiver to know the type of message being received is going to be challenging.
Knowing the body type of message on Send is reasonable because the sender always knows what they're sending, but for a receiver it is challenging.
For reference, other AMQP implementation handle this differently - they typically define a Message type with 3 fields, one for each possible body type, and then fill in the appropriate fields (either one or zero of the fields).
Here's the definition of Message for Go AMQP
Here's the definition of Message for Python AMQP and where it's decoded
Here's the definition of Message for Java AMQP - note that Java doesn't yet support Sequence or Value.
Here's the definition of Message for uAMQP.
What is common among all of these is that the receiver (or creator) Message object doesn't know the underlying body type.
Would it be possible to enable receiving messages where the receiver doesn't know the type of message being received ahead of time?
Please note that I am not an expert Rust developer. If it is already possible to receive messages without knowing the incoming message type, I would love to be wrong.

I think this is already covered by using Body<Value> as the receiving type. It is kind of hard to find this in the documentation, which is my fault.
https://docs.rs/fe2o3-amqp/latest/fe2o3_amqp/link/receiver/struct.Receiver.html#method.recv

If the user is not certain the exact type (including the exact body section type) to receive, Body is probably the safest bet. Body covers all possible body section types, including an empty body, and Value covers all possible AMQP 1.0 types

The Body<T>type covers all possible body section defined in the spec (http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#section-message-format) including an empty body, which was an unintended mistake in the spec (https://issues.apache.org/jira/browse/PROTON-2574?filter=-2).
The documentation of Body<T> can be found here: https://docs.rs/fe2o3-amqp/latest/fe2o3_amqp/types/messaging/enum.Body.html

Here is a simple example showing receiving a message from Service Bus without knowing the type beforehand and then try to interpret the message as a Data section that contains a string. The unwrapping and next are there because the Body  could have one or more Data sections, and the example is only inspecting the first one.
https://github.com/minghuaw/fe2o3-amqp/blob/ddc8f3bf654ebbff5bed8133ce839f60c7ba20c9/examples/service_bus/src/bin/topic_receiver.rs#L39-L40
The Body type allows the user to inspect the body section type. If the body section is an AmqpValue, the user could then deserialize that Value using the method from_value

Ah, thank you, that answers my question. I had noticed the Body<Value> variant and was trying to use it, but I missed the try_as_data()/try_as_value()/try_as_sequence() functions on the Body<T> type.


backoffice: refactors extra fields of the documents

Adds vocabularies to accelerator, experiments and
standard_reviews

The other fields need discussion


?_facets_off=1 query string argument for disabling facets and suggested facets

This is needed as an internal option for #1349. datasette-graphql can benefit from this too - maybe can even use it so that if you pass ?_shape=array it gets automatically added, fixing #263.

I think ?_facets_off=1 is a good design for this.
I considered ?_facet= with an empty string but that's a bit weird, and it's not clear what that would do if used like ?_facet=state&_facet=.
So it definitely needs to be a separate named option.
Actually, since I have ?_nocol= I'm going to call this ?_nofacets=1 instead as that's a little more consistent.

I renamed this to ?_nofacet=1 in #1353.


Update README.md

Update README, so the link to the license page works, also I did commit this on the dev branch accidentally.

Not a major update.


isNaN check

Bug resolved

👍 on this!
Resolves bug when stepCount={1}

👍 on this!
Resolves bug when stepCount={1}

But what if stepCount is not needed 1, default is already stepCount={5}
I believe long term solution would be isNan check

I don't really understand what you are saying @rf1804
I'm saying that your solution helped me render the step-indicator when my stepCount prop was 1 (thanks!)

@24ark


Add missing cstring include

Otherwise you get an error undefined std::strlen on Linux.
I hope the style is correct. I need to add this to get it to compile.

Thanks, really appreciate the Linux testing.  If you find that the library is working fine now on Linux, feel free to update the readme to indicate your OS/compiler compatibility.


Typo in server.py

server.py, line 120:    a_action["announce_shot"]    should probably be    b_action["announce_shot"]

Indeed this looks like a typo.


#4424 style(stack-details): shift button position in stack details

Closes #4424

Thanks for the contribution @mrwhoknows55 ! Will review soon.

/azp run

@pull-dog up

/azp run


Fix inconsistent encoding

Ensures that the Airstory\Formatting\get_body_contents() UTF-8 fixing is also applied in Airstory\Formatting\sideload_all_images(), fixing #61.

Thanks to 7935273, this now also fixes #63.


[BUG] FF SignMultiChain iFrame isn't rendering transaction data

PR: https://github.com/near/near-fastauth-wallet/pull/27


First version of CI/CD.

@vkuznet
Please review. I created two build files: build.yml for pypi and build-test.yml for test pypi. build and upload to pypi will be triggered by a new tag with the format as x.y.z, such as 4.0.5. Build and upload to test pypi will be trigger by a new tag with the formate as x.y.z.k, such as <IP_ADDRESS>.  The test tag will be formed by adding the 4th number to the existing working tag. When we are done with the testing, then we can increase the tag in one of the first three digitals to form a release tag. BTW, Neil/summer student created bunch of 4.0.x release in test pypi. We may want to increase the new tag to 4.1.z in next tag.
This is an initial CI/CD for upload to pypyi. You may want to add unit tests for the go server . I don't see there is needs for the python server here.
Currently, I am using my personal token for the test pypi. @goughes , can you provide general tokens for both pypi and test pypi in DBSClient?

@vkuznet
Please review again. I applied your suggestions.  If passed your review, please commit.  I will have a pylint  check PR soon.

@yuyiguo changes are fine and I approved, but I don't know technical details of regexp used by GitHub system and I don't know if your choice of tags will not collide. For instance, you chose <IP_ADDRESS> for test releases, but I don't know if *.*.* will not match it. I suggest that you find it via trial on GitHub itself. If necessary, later, you may adjust  tags accordingly. Probably better naming convention can be test.1.1.1 instead of <IP_ADDRESS>. In this case you can choose production tag to start with number, while test release will use test prefix.

Thanks @vkuznet for the choices of tags. I will test it.


Test our content on writing inclusively about skin symptoms - once it's live

We expect to publish some new guidance on writing about skin symptoms in the content style guide soon. GitHub issue
We would normally test new guidance before publishing it, but we aren't aware of any other NHS Digital, PHE or DHSC teams working on skin content at the moment. I suggest that, once the new guidance live, we see if we can find any NHS trusts or charities that produce skin content, and ask them for feedback or test with them.
@amyj2110 for info.

Hi @amyj2110, Rhiannon said the following about testing the skin symptoms guidance when we publish it.

Do you tend to put any links to surveys in the service manual? Could we ask a few questions like if it's helpful, anything confusing, etc?
In the near future skin symptoms reviews will be going to all content designers, not just mission team 1 designers. So it could be good to do some UR sessions and get some CDs to review an MVR topic (or part of the topic) and ask them to use the guidance and observe and see what is helpful and what's confusing etc? But I'm sure URs will have some ideas about how to test it. Would a UR from the service manual team be able to do this or is this something I should talk to Michelle in mission team 1 about?

Some questions:

how do people find this page? site search, browsing, via the A to Z?
does this page contain the right amount of info about research insights?
does the page structure work?
do people use the left hand nav?

@amyj2110 It is unlikely now that NHS.UK content designers will apply the skin symptoms guidance soon, because they're too tied up in MVR work. So MT1 is likely to pick up more skin symptoms work.
Given that we won't be able to test the guidance internally in the near future, I'm wondering whether we might be able to find some external teams (charities or hospital trusts) that produce skin symptom content, that we could do a bit of UR with.
MT1 may be able to advise on organisations to contact. Some examples might be:

the British Association of Dermatologists (who're doing some good work in this area - we link to them from the guidance) and their Skin Support website
the Vitiligo Society
the Psoriasis Association
The Patient Information Forum may be able to put out a call for people to test our guidance.

Some of our skin conditions content and last reviewer:

Rubella - Mark R
Measles - Steven S
Vitiligo - Chloe
Atopic eczema - Laura

@Indu-Kaila, for info. I'll try and catch up with you later. This is the page in question: https://service-manual.nhs.uk/content/make-content-about-skin-symptoms-more-inclusive.

Met with @sarawilcox (30/0621) about the background as to the creation of this page and re this page needs ur testing: https://service-manual.nhs.uk/content/make-content-about-skin-symptoms-more-inclusive.

Meeting arranged to meet with the Mission team 1 Content designers on 06/07/21. Will be planning the user research. Please refer to issue #1269

Done
Skin Symptoms Guidance Analysis Summary Matrix_090821.docx


about the test performance on thumos14 dataset

Thanks a lot for sharing the code.
When i test your released  R-C3D model on THUMOS'14 dataset, the mAP is lower than yours.  The results are as follows:
Fixed threshold for tiou score: [ 0.1  0.2  0.3  0.4  0.5]
mean AP at different thresholds: [ 0.44844552  0.42947421  0.40517887  0.36456814  0.29133984]
The<EMAIL_ADDRESS>is simillar, but the others are bad. I don't know why. could you give me some suggestions?  I'm looking forward to your reply. Thank you very much!

The current prediction result is applied nms (0.4) for the evaluation threshold 0.5.
For other thresholds, you change nms threshold to be (evaluation threshold-0.1) as mentioned in some papers.
see the following line in the file activitynet_log_analysis.py
def select_top(segmentations, nms_thresh=0.4, num_cls=0, topk=0):
Huijuan
On Mar 13, 2018, at 23:02, jxiangli <notifications<EMAIL_ADDRESS>wrote:
Thanks a lot for sharing the code.
When i test your release R-C3D model on THUMOS'14 dataset, the mAP is lower than yours. The results are as follows:
Fixed threshold for tiou score: [ 0.1 0.2 0.3 0.4 0.5]
mean AP at different thresholds: [ 0.44844552 0.42947421 0.40517887 0.36456814 0.29133984]
The<EMAIL_ADDRESS>is simillar, but the others is bad. I don't know why.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/VisionLearningGroup/R-C3D/issues/13, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFOa_yJcas-T1uhWl1MZsOT4x1azpZTHks5teIhQgaJpZM4SpxCb.

Thanks for your reply!  I will try it.

I changed nms threshold to be lower than mAP evaluation threshold(evaluation thresholds - 0.1).
The detection  results:
IoU thresh : [ 0.1 0.2 0.3 0.4 0.5]
mean AP :  [ 0.53106971,   0.50220919,   0.45672874,  0.38260949,   0.2914133 ]
The<EMAIL_ADDRESS>and<EMAIL_ADDRESS>are still lower than the results in your paper.
Besides,  I trained the model for 60K iterations without changing the hyperparameters .  The buffer is 512 frames.
The detection  results:
IoU thresh : [ 0.1   0.2   0.3   0.4   0.5]
mean AP :  [ 0.45547029,   0.44375547,   0.40285578,  0.33335985,   0.26478926 ]
Then I changed the buffer to 768 frames,  and the model was trained for 56K iterations . The detection results are as follows.
The detection  results:
IoU thresh : [ 0.1   0.2   0.3   0.4   0.5]
mean AP :  [0.48046211,   0.46369506,   0.42404733,  0.35621547,   0.26572283 ]
As you can see, the results are both bad.  I am not sure whether I missed something.  Could you help me?
Looking forward to your reply!

The provided model is trained with the provided setting.
Try to download the new td_cnn_end2end.ymlhttps://github.com/VisionLearningGroup/R-C3D/blob/master/experiments/thumos14/td_cnn_end2end.yml file, and re-test to see the results. Don’t need to re-train, just re-test with the new file.
On Mar 19, 2018, at 05:51, jxiangli <notifications<EMAIL_ADDRESS>wrote:
I changed nms threshold to be lower than mAP evaluation threshold(evaluation thresholds - 0.1).
The detection results:
IoU thresh : [ 0.1 0.2 0.3 0.4 0.5]
mean AP : [ 0.53106971, 0.50220919, 0.45672874, 0.38260949, 0.2914133 ]
The<EMAIL_ADDRESS>and<EMAIL_ADDRESS>are still lower than the results in your paper.
Besides, I trained the model for 60K iterations without changing the hyperparameters . The buffer is 512 frames.
The detection results:
IoU thresh : [ 0.1 0.2 0.3 0.4 0.5]
mean AP : [ 0.45547029, 0.44375547, 0.40285578, 0.33335985, 0.26478926 ]
Then I changed the buffer to 768 frames, and the model was trained for 56K iterations . The detection results are as follows.
The detection results:
IoU thresh : [ 0.1 0.2 0.3 0.4 0.5]
mean AP : [0.48046211, 0.46369506, 0.42404733, 0.35621547, 0.26572283 ]
As you can see, the results are both bad. I am not sure whether I missed something. Could you help me?
Looking forward to your reply!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/VisionLearningGroup/R-C3D/issues/13#issuecomment-374156297, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFOa_4x7orR-Yiu_WtC-K85J4wrl536Jks5tf3-xgaJpZM4SpxCb.

Sorry for the late reply.
I re-test with the new file.
The detection results:
IoU thresh : [ 0.1  0.2  0.3 0.4 0.5]
mean AP : [ 52.4664, 49.5531, 45.5329, 38.4264, 29.8925 ]
The<EMAIL_ADDRESS>and<EMAIL_ADDRESS>improved, but the others decreased.
When the _C.TEST.NMS threshold is 0.4 or 0.2, the mAP<EMAIL_ADDRESS>and<EMAIL_ADDRESS>are similar.
_C.TEST.NMS=0.2
IoU thresh : [ 0.1 0.2 0.3 0.4 0.5]
mean AP : [ 52.0517, 49.5179, 45.6854, 39.1844, 29.8980 ]
_C.TEST.NMS=0.4
IoU thresh : [ 0.1 0.2 0.3 0.4 0.5]
mean AP : [ 52.7457, 50.0959, 45.7875, 37.9448, 29.1968 ]

I update the released model to another iteration. This is close or higher than my paper’s results. Before I just pay attention to<EMAIL_ADDRESS>On Mar 20, 2018, at 07:51, jxiangli <notifications<EMAIL_ADDRESS>wrote:
Sorry for the late reply.
I re-test with the new file.
The detection results:
IoU thresh : [ 0.1 0.2 0.3 0.4 0.5]
mean AP : [ 52.4664, 49.5531, 45.5329, 38.4264, 29.8925 ]
The<EMAIL_ADDRESS>and<EMAIL_ADDRESS>improved, but the others decreased.
When the _C.TEST.NMS threshold is 0.4 or 0.2, the mAP<EMAIL_ADDRESS>and<EMAIL_ADDRESS>are similar.
_C.TEST.NMS=0.2
IoU thresh : [ 0.1 0.2 0.3 0.4 0.5]
mean AP : [ 52.0517, 49.5179, 45.6854, 39.1844, 29.8980 ]
_C.TEST.NMS=0.4
IoU thresh : [ 0.1 0.2 0.3 0.4 0.5]
mean AP : [ 52.7457, 50.0959, 45.7875, 37.9448, 29.1968 ]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/VisionLearningGroup/R-C3D/issues/13#issuecomment-374570021, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFOa_9fI5GGI7BR75tRmgeAi0_MPLGe4ks5tgO1dgaJpZM4SpxCb.

Thanks for sharing the model.
I re-test with the new released model, and the detection results are the same as yours.
Besides, I trained  a new model  for 60K iterations with the provided setting and wanted to reproduce the results reported in your paper. But results are lower than yours and<EMAIL_ADDRESS>even is 10% lower than yours. I don't know where the problem is.  Do I need to pay attention to some things during training?
Sorry for many questions.
Looking forward to your reply!

Sorry to bother, I am wondering where is the released model or the ucf101.caffemodel? I cannot find it in the github repo. Could you share again?

You can find that in the fold R-C3D/experiments/thumos14/README.md  @JacobKong

Thanks a lot! I found it!

在 2018年4月1日，上午10:03，wangwen<EMAIL_ADDRESS><EMAIL_ADDRESS>写道：
You can find that in the fold R-C3D/experiments/thumos14/README.md @JacobKong https://github.com/JacobKong
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/VisionLearningGroup/R-C3D/issues/13#issuecomment-377737251, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ64ORcpTqjXnOJPDfw-n_ARoSiT47qVks5tkDVggaJpZM4SpxCb.

祝好
孔伟杰
———————————
硕士研究生
数字媒体研究中心
信息工程学院
北京大学深圳研究生院
地址：中国广东省深圳市南山区丽水路2199号西丽镇深圳大学城北大园区A327
邮政编码: 518055

Hi,I have tested the release model from thumos14,however,my test result is very strange.It is hard to recall any piece of video in the thumos14 test datasets when I use the original codes. I wonder if there are any tricks that need adjustment.Thank you!

If you can't load any frames, maybe you need to check the frame name format.
On Apr 12, 2018, at 22:54, willyangyang <notifications<EMAIL_ADDRESS>wrote:
Hi,I have tested the release model from thumos14,however,my test result is very strange.It is hard to recall any piece of video in the thumos14 test datasets when I use the original codes. I wonder if there are any tricks that need adjustment.Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/VisionLearningGroup/R-C3D/issues/13#issuecomment-381006112, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFOa_wrooZ-mg4Fs__40iB_DNVuFMaGmks5toBNggaJpZM4SpxCb.

I have loaded the frames successfully,but the test results are strange, all the box is classified to background(score of background is much higher than others), my bbox threshold is 0.05 for thumos14 test dataset, and the code is the original one

hello ,
I am trying to train the network on THUMOS14,but I can't find the text,
Class_Index_Detection.txt
could you give me some hint?? @willyangyang

It is there. Find the test folder.
On May 8, 2018, at 13:22, Eran <notifications<EMAIL_ADDRESS>wrote:
I'm working on scoring the R-C3D results that I have on the Thumos14 dataset and I don't see the json truth files that are needed for evaluating the test set. Is there another evaluation process that is different from what is in the instructions for the activityNet data or is there a script to create the json truth files?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/VisionLearningGroup/R-C3D/issues/13#issuecomment-387477771, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFOa_1yM7v7iw3OZvErkQy9Gx0Zjpkaaks5twdRKgaJpZM4SpxCb.

Hmm, the activityNet has the truth json files in ./experiments/activitynet/test/Evaluation/data the parallel folder for THUMOS14, ./experiments/thumos14/test/new_python_evaluation_code_follow_activityNet/Evaluation doesn't have the data folder or the json files.
I did find the matlab based evaluation code, that most likely does not require the json files. I'm in the process of verifying this. Are people using the same scoring code that was used for activityNet or the matlab scoring code to evaluate the THUMOS14 data?

If anyone is interested, I found the THUMOS14 test json file in test/new_python_evaluation_code_follow_activityNet, a couple directories up from where I was expecting it. It's called thumos14_gt_test.json.

hello,I have trained the network on THUMOS14 ,and then I evaluate the apperance at the tIoU=0.5,However,the mAP is 0,it makes me very surprise ,Could you give me some suggestions? Thanks
@jxiangli @wangwen39

I got the evaluation to work yesterday. I originally had a mAP of zero as well, which is caused by the hardcoded path structure assumption in activitynet_log_analysis.py around line 63 (vid = l.split('/')[4]). I changed the 4 to a -1 to grab the video file name and it started showing results similar to what is in the paper.

It's a good news for me ,and it sounds that you test it on ActivityNet,there exists any others modification? @eswears

thx, as you said,I have solved it. @eswears

I only tested it on THUMOS14, since the dataset is smaller and we just needed to verify that everything worked as expected before training and testing on our own data.  There will most likely be file path changes, some hard coded, that need to change for training/testing on ActivityNet.

You can use the class_index_detection.txt. But you need to change the index to 1 to 20.

@huijuan88 hello, thank you for sharing your code! there are some problems when I tested the thumos14 dataset, I could't find the "detclasslist.txt" file, it comes from the "META_FILE ='/scratch/detection/scnn/experiments/my_experiments/annotation/annotation_test/detclasslist.txt'" paragraph in the "experiments/thumos14/test/new_python_evaluation_code_follow_activityNet/activitynet_log_analysis.py" file.


remove @ from import

Hi there
I'd like to use you library, but the @ in one of the imports is causing the compile to fail in the component I'm writing

Thanks for the PR! Unfortunately, I can't merge this due to your second commit. I've gone ahead and made the change manually and it has been released in version v1.4.1.
FYI, you can disable error logging using the constructor options (I also fixed a bug in this release where some errors were still being logged):
cont surveyor: SQLSurveyorsurveyor = new SQLSurveyor(SQLDialect.MYSQL, {
    logErrors: false,
    throwErrors: false
  });

Thanks again for flagging this issue.

Thanks Matt!
That was quick :-)
Nick
Get Outlook for iOShttps://aka.ms/o0ukef

From: Matt Triff @.>
Sent: Sunday, June 20, 2021 3:03:48 AM
To: modeldba/sql-surveyor @.>
Cc: Nick Mann @.>; Author @.>
Subject: Re: [modeldba/sql-surveyor] remove @ from import (#5)
Thanks for the PR! Unfortunately, I can't merge this due to your second commit. I've gone ahead and made the change manually and it has been released in version v1.4.1https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmodeldba%2Fsql-surveyor%2Freleases%2Ftag%2F1.4.1&data=04|01||9a218f988c224a158f0c08d9338fa49f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637597514296531917|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=WuhKSUPa5SyMcQrZsklBCADXi0QhvebTiRv7tzy%2Fhp0%3D&reserved=0.
FYI, you can disable error logging using the constructor options (I also fixed a bug in this release where some errors were still being logged):
cont surveyor: SQLSurveyorsurveyor = new SQLSurveyor(SQLDialect.MYSQL, {
logErrors: false,
throwErrors: false
});
Thanks again for flagging this issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmodeldba%2Fsql-surveyor%2Fpull%2F5%23issuecomment-864488240&data=04|01||9a218f988c224a158f0c08d9338fa49f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637597514296541913|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=9H7dBBrLl6Weo8YUwYoCl2Vo7127R%2Fchwllk8d4ZVuE%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAI2IT7G7BKPY7PYFMI5ALRLTTVEAJANCNFSM467B3PPQ&data=04|01||9a218f988c224a158f0c08d9338fa49f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637597514296541913|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=P9zE0ousX2jIKKi96%2FNtgiER7QZ7FLjl1XySgeqdpk4%3D&reserved=0.


Add a Todo list for each user

Hey, can you describe more about this? I wanna help, but i need more info

So basically the aim is a new feature of adding a todo list for users.
Some points -

A table with user_id as foreign key of auth_user, problem_link, problem_name.
A page where a user can see all the problems added by the user.
An icon (use font awesome) near the problem name in pages like tag page. For UX ideas see this on codechef (https://www.codechef.com/problems/medium)
Basically the button should be both for add/remove problems from the todo list.
Please feel free to reply back in case of any problems or clarifications (I would have been more descriptive but I am on mobile - sorry)


Handlebars helper pass through

Related to #52, this PR adds a pass through, through the handlebars option, to not parse Handlebars helpers as attribute when they reside outside of an element attribute. When parsing an element attributes, it looks for the Handlebars template delimiter ({{) and if it finds it at the beginning of the attribute name, it returns unparsed attributes + key until it finds the closing delimiter (}}). If an "attributes" has a value, it parses it correctly.
What do you think ? Is this something that's too "hacky" ? I've tested with a bunch of different options enabled and with different attributes, before, after, in between and it seems to be pretty solid.  My main concern is that I'm not familiar with the way htmlparser2 splits elements attributes into it's tree, so I may well be forgetting test cases.

Thanks for your hard work on this. I really dig the idea of minifying at any point (e.g. before or after template parsing). But I'm afraid I can't merge this. First, the feature itself does not cover all handlebars integrations as handlebar code could be between elements and basically anywhere within the HTML. I'm curious how htmlparser2 would parse the code other cases, outside attributes that is.
Second I'd like to keep the core of minimize itself clean, e.g. it should just do HTML parsing. However I think this feature could work as plugin. And I'd like to suggest to move this logic to a plugin. Keeping this open for now to discuss the merits of this feature.

I'll see how I could move this to a plugin, however, in the README, it mentions to register plugins like so:
new Minimize({
  plugins: [
    element: function(node, next) { /* do something */ next(); }
  ]
});

However, that is not valid JS, I've tried replacing the plugins array by an object and while it did not throw any error this time, it also didn't run my code. How should I go about registering plugins ?
As for your concern about this not covering all handlebars integrations, we've been using minimize on our handlebars templates for quite some time without any issue. This seems to be the only case where the output get's tangled (not to say that there aren't others...). For example, the following piece of HTML

  {{#forEach widgets}}

{{this.name}}

  {{/forEach}}

is parsed to the following htmlparser2 tree:
[ { type: 'tag',
    name: 'div',
    attribs: { class: 'widgets' },
    children:
     [ { data: '   {{#forEach widgets}}     ',
         type: 'text',
         next:
          { type: 'tag',
            name: 'h2',
            attribs: { id: '{{this.id}}', class: 'widget' },
            children:
             [ { data: '{{this.name}}',
                 type: 'text',
                 next: null,
                 prev: null,
                 parent: [Circular] } ],
            next:
             { data: '   {{/forEach}} ',
               type: 'text',
               next: null,
               prev: [Circular],
               parent: [Circular] },
            prev: [Circular],
            parent: [Circular] },
         prev: null,
         parent: [Circular] },
       { type: 'tag',
         name: 'h2',
         attribs: { id: '{{this.id}}', class: 'widget' },
         children:
          [ { data: '{{this.name}}',
              type: 'text',
              next: null,
              prev: null,
              parent: [Circular] } ],
         next:
          { data: '   {{/forEach}} ',
            type: 'text',
            next: null,
            prev: [Circular],
            parent: [Circular] },
         prev:
          { data: '   {{#forEach widgets}}     ',
            type: 'text',
            next: [Circular],
            prev: null,
            parent: [Circular] },
         parent: [Circular] },
       { data: '   {{/forEach}} ',
         type: 'text',
         next: null,
         prev:
          { type: 'tag',
            name: 'h2',
            attribs: { id: '{{this.id}}', class: 'widget' },
            children:
             [ { data: '{{this.name}}',
                 type: 'text',
                 next: null,
                 prev: null,
                 parent: [Circular] } ],
            next: [Circular],
            prev:
             { data: '   {{#forEach widgets}}     ',
               type: 'text',
               next: [Circular],
               prev: null,
               parent: [Circular] },
            parent: [Circular] },
         parent: [Circular] } ],
    next: null,
    prev: null,
    parent: null } ]

which in turn is rendered by minimize as follow:

{{#forEach widgets}}
{{this.name}}
{{/forEach}}

Updated the docs, basically a plugin is just a module that should export an id (string) and element (function). The element function receives element, next. Should you encounter more problems let me know.

Oh! Yes, that make sense, for some reason I thought that the id and element items were 2 different plugins... THanks!

My understanding of plugins is that they can modify the tree structure created by htmlparser2 before minimize works it's magic, right ?
I've created a plugin that rewrite the attribs property of elements in the htmlparser2 tree before passing it to minimize. It is available here.

Yeah I was afraid htmlparser would be limiting, the only way around this would be a custom parser instance accompanied by a plugin perhaps. Plugin might not be needed anymore even with a custom parser.

I've updated the plugin to handle stuff like "../../object.property". It feels a bit hacky though. However, it seems to be working now and we're using it during development. So far no issues and we're minimizing hundreds of templates files. I'll be reassessing the need of a custom parser (which I do not have the technical capabilities to write) when problems arise again. Feel free to close this PR (and the associated issue).

Will do in a few, I'll link the plugin from the docs so other people can benefit from your work :)

Closing this as the functionality is available as plugin, does the plugin cover all edge cases btw? If so i'd like to add it to the docs still.

I've added tests to my plugin, a lot of them taken directly from your test suite (but adding my plugin to each test to see how it would interact with currently working code). All tests passes as of now.
As I've mentioned above, we are using Minimize with the plugin in development and soon production and haven't witness any issues (apart from the fact that the plugin output is all lowercase'd) yet.
There is a known issue with the spare option, which I haven't figured out.
I can't say that the plugin covers all edge cases for sure but as I've said, it seems to be working quite well for us so far.


trained_model_serialization_unittest.cc.py fails with python 35

Traceback (most recent call last):
  File "/cluster/home/galv/shogun/tests/unit/base/trained_model_serialization_unittest.cc.py", line 137, in <module>
    outputText = entry(TEMPLATE_FILE, input_file, config_file)
  File "/cluster/home/galv/shogun/tests/unit/base/trained_model_serialization_unittest.cc.py", line 116, in entry
    and not is_guarded(header, guards)\
  File "/cluster/home/galv/shogun/tests/unit/base/trained_model_serialization_unittest.cc.py", line 45, in is_guarded
    guards = re.findall('#ifdef (\w+)', header.read().lower())
  File "/cluster/home/galv/anaconda2/envs/shogun-mkl-35/lib/python3.5/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 290: ordinal not in range(128)
tests/unit/CMakeFiles/shogun-serialization-unit-test.dir/build.make:82: recipe for target 'tests/unit/trained_model_serialization_unittest.cc' failed
make[2]: *** [tests/unit/trained_model_serialization_unittest.cc] Error 1

Hi @vigsterkr !
I've tried a few things but couldn't reproduce this issue. I'm using Python 3.5.2 on Ubuntu 16.04.
I've built shogun using the following cmake options:
cmake -DPYTHON_INCLUDE_DIR=/usr/include/python3.5m -DPYTHON_EXECUTABLE:FILEPATH=/usr/bin/python3 -DPYTHON_PACKAGES_PATH=/usr/local/lib/python3.5/dist-packages -DINTERFACE_PYTHON=ON -DCMAKE_BUILD_TYPE=Debug -DENABLE_TESTING=ON -DBUILD_DASHBOARD_REPORTS=ON -DBUILD_META_EXAMPLES=ON ..
and ran the tests, which passed.
Then, at ./shogun/build/tests/unit , I've ran the following command shown in tests/unit/CMakeFiles/shogun-serialization-unit-test.dir/build.make :
python3 ./shogun/tests/unit/base/trained_model_serialization_unittest.cc.py ./shogun/tests/unit/base/trained_model_serialization_unittest.cc.jinja2 ./shogun/build/src/shogun/tags trained_model_serialization_unittest.cc ./shogun/build/src/shogun/lib/config.h
which ran successfully.  Do you know what else could I do in order to reproduce it?
Thanks!