Not all dates are of Date class. At least one is ActiveSupport::TimeW…

…ithZone. Check that whatever the date's class is, that it can respond to the strftime method.
@erose whoops. a bug snuck in with that last PR merge. could we merge the fix please?

Ya! btw, no need to get approval before merging small stuff like this.


Homebridge TypeError on macOS 10.12 (16A254g)

homebridge restart
[7/30/2016, 9:29:38 PM] Loaded plugin: homebridge-suncalc
[7/30/2016, 9:29:38 PM] Registering accessory 'homebridge-suncalc.Suncalc'
[7/30/2016, 9:29:38 PM] ---
[7/30/2016, 9:29:38 PM] Loaded plugin: homebridge-wunderground
[7/30/2016, 9:29:38 PM] Registering accessory 'homebridge-wunderground.WUNDERGROUND'
[7/30/2016, 9:29:38 PM] ---
[7/30/2016, 9:29:38 PM] Loaded config.json with 2 accessories and 1 platforms.
[7/30/2016, 9:29:38 PM] ---
[7/30/2016, 9:29:38 PM] Loading 1 platforms...
/usr/local/lib/node_modules/homebridge/lib/api.js:92
  if (name.indexOf('.') == -1) {
          ^

TypeError: Cannot read property 'indexOf' of undefined
    at API.platform (/usr/local/lib/node_modules/homebridge/lib/api.js:92:11)
    at Server._loadPlatforms (/usr/local/lib/node_modules/homebridge/lib/server.js:263:45)
    at Server.run (/usr/local/lib/node_modules/homebridge/lib/server.js:71:36)
    at module.exports (/usr/local/lib/node_modules/homebridge/lib/cli.js:40:10)
    at Object.<anonymous> (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)

I just installed Homebridge onto my iMac and have had this problem since the start. I can add Homebridge in the iOS 10 Home app but none of my accessories will show up. I've already validated my config.json file but I'll post it below for the sake of being thorough.
{
    "bridge": {
        "name": "Homebridge",
        "username": "CC:22:3D:E3:CE:30",
        "port": 51826,
        "pin": "031-45-154",
        "expected_accessories": "2"
    },

    "description": "Keeton's homebridge",

    "accessories": [
        {
          "accessory": "WUWeatherStation",
          "name": "Weather",
          "key": "3420b96e2217c3b5",
          "location": "47591"
        },
        {
          "accessory": "Suncalc",
          "location": {
              "lat": 38.677269,
              "lng": 87.528633
            },
            "offset": {
              "sunriseEnd" : 30,
              "sunsetStart" : -30
            },
            "name": "Suncalc"
          }
    ],

    "platforms": [
        {

        }
    ]
}

Any ideas?  (Let's hope not.)

"platforms": [
        {

        }
    ]

This part, since you're not using any platform, please remove this section.

Getting different errors not but I'm working on those. Shouldn't a check be implemented for empty fields like in my case since I simply followed the guideline in the example json provided in the repo?

Yeah, I feel like a settings check would solve most issues here.

Having a settings check should be a given for any application in my opinion. I understand the reason for simply having the wiki but I didn't find my specific issue in the wiki until after I filed this issue. At the very least a human understandable error system should be implemented instead of giving the node.js errors (unless Homebridge is run in verbose mode or something similar).

I am not a contributor yet, but...
This is an open source application hosted on github, all are welcome to submit pr's.


checkcast: Provide information as to why a type is not "assignable"

Ive been using trycast for a while for runtime type checking (mostly yaml/json -> TypedDict) and its working great (thanks)
Mostly i use a pattern of checking if something is assignable and raising a TypeCastingError with the failing value to allow handling further up the stack
What would be really helpful is to be able to expose why the object is not assignable (eg "incorrect key", "incorrect type for key", "missing key" etc)
i guess there is some complexity around issues with different types of Type
implementing this might also add some complexity around continuing after the first failure and collecting the errors etc

Right now trycast() returns:

(A) [original value if successful] | [None if failure]

In order to return additional information about the failure, it would need to return instead something like:

(B) [original value if successful] | [exception with details if failure]

I have been thinking about adding a new checkcast() function to the API that would effectively return (B).
With a checkcast() function available, you could replace code like:
if (movie := trycast(Movie, request_json)) is not None:
    ...  # expects a movie
else:
    raise ValueError("Expected a Movie")

with shorter code like:
movie = checkcast(Movie, request_json)
...  # expects a movie

If there was a type-checking error, checkcast() would raise a custom subclass of ValueError. Information about the type-checking failure could be provided in the message of that exception.

Do you think a new API like checkcast() (as described above) would help with your issue here?

Do you think a new API like checkcast() (as described above) would help with your issue here?

yep definitely, the main thing i want to be able to do is raise a message to the end user giving a hint on how to fix, so i think that would work
the slightly more complex solution would be rather than raising a single error on a match-fail, collecting the errors and providing a fuller analysis, but i think that adds quite a bit of complexity and just having an error which indicates the first failure would be great

so my direct use case is in CI - so it is developers, but not developers of the python app (for ref Envoy CI https://github.com/envoyproxy/envoy)
eg it might open a extensions.yaml file to parse extensions metadata
what im doing now is depending on the type of fail either raising/handling immediately, or logging a warning and hoping for the best
currently the log/error dumps the parsed contents of the file which is a python dict so not that helpful
it would be good to give an indication to the end users (who happen to be devs) - "the format of the yaml file you edited is wrong - try fixing fixing this"
as this is kinda specific to the format being consumed and its schema, i was expecting/hoping to catch some type of error/info and dump a message based on that, but exposing any info as to what was wrong would be better than just dumping the data as i do now

Thanks for taking the time to explain your scenario. I've got a much better understanding of what you're trying to do.
For now I'll file this issue as a post-1.0 feature request.

just a user report, to say I'd have been interested in this feature as well. Thanks for the lib.

checkcast will be released in v1.2.0

nice, thanks!

trycast v1.2.0 (and checkcast) have been released 🥳


deis on kubernetes

Hi,
I wanted to try kubernetes and deis and installed the great kube-cluster app. My small test cluster is up and running and I installed deis.
The installer completes with the following messages:
Deis PaaS install is completed ...
It can be accessed via http://deis.<IP_ADDRESS>.xip.io

Please read how to:
Deploy Applications - https://github.com/deis/workflow/blob/node1/docs/src/using-deis/deploying-an-application.md
To manage Applications - https://github.com/deis/workflow/blob/node1/docs/src/using-deis/managing-an-application.md
Using Deis PaaS - https://github.com/deis/workflow/tree/node1/docs/src/using-deis

But unfortunately NONE of the URLs works. Github results in a 404 and http://deis.<IP_ADDRESS>.xip.io results in a timeout.

@geoHeil I have released the new kube-cluster v0.1.9 with the correct URLs to Deis documentation.
Accessing directly Deis router IP (in your case http://deis.<IP_ADDRESS>.xip.io) will not show anything as we do  to have any Deis UI yet. That url is used  to register and login a user to Deis and install/configure/etc your Apps.

Great Thank you. In case you are the maintainer for the homebrew cask formula for kube-cluster it would be great if you could upgrade it as well

@geoHeil no, I do not maintain the homebrew cask formula for kube-cluster, maybe somebody just volunteered to do it by himself :)

:) I will try to update the cask

It looks like it runs automatically to update casks :)

They have a cask repair script cask-repair --pull origin --push geoheil kube-cluster but I seem to lack permissions for a pull request there ;(


A problem about Multi train

Hi, this problem occurs when I use multi_train.py.
Could you give me some advices? Thank you.

Hi, it seems that you have passed wrong type of image to self.jitter(). Perhaps you might look at the image preparation procedure.

Hi, this problem occurs when I use multi_train.py. Could you give me some advices? Thank you.

I meet same problem.


Decouple system timer and drivers: SoC Initialization

During our work in timer area, we found that system clock frequency is used incorrectly in several places.
For example, it is used to obtain CPU frequency needed for SoC initialization.
If we select different system timer device, all these calculations become invalid.
This PR fixes the problem by obtaining all needed information directly from the DTS.
Brings us closer to: #15363

@andrewboie: The CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC  is still set manually in defconfig. However all these changes are preparation for removal of of this define. I noticed, that it is widely used in wrong context as well as in many places we are assuming that system clock frequency is known at compile time which is not always true.


LoginOptions.state are different for Login and showSimplifiedLoginWidget, but are typed the same

showSimplifiedLoginWidget "loginOptions" parameter is allowed to have state as a function, but the type does not allow this. I'm assuming that is due to sharing loginOptions-type with the regular Login-function, where state is only allowed to be a string.
The javadoc is "saying" that it is allowed, but the type doesn't allow it.

Can we get this fixed?
To reproduce:
Try calling the function with state as a function:

You will get

Resolved by
https://github.com/schibsted/account-sdk-browser/pull/208


Streaming

Target browser could be able to begin downloading, before source mobile has finished uploading.

See also issue #56 [Thumbnails]

Closely related to #94 [Download encrypted chunks early]

This is NOT the same as  #113 Live video streaming from camera

WebRTC can do this (see #132) but only after scanning the QR-code


Fire token

Project team background:
Each NFT in Alchemy World has its own characteristics and scarcity. Relying on double token ecology formed by Alchemy World NFT. Fire, Fe tokens, including NFT Staking, liquidity mining, NFT, FOMO, are all inseparable from NFT in Alchemy World.
Project basic information:
Alchemy World has introduced a number of innovations in blockchain game, including DeFi tokens mortgage rights, dynamic rarity, algorithmic stablecoin, and smart contract interoperability. It also introduced the playable NFT with digital value to the blockchain world.
Media publications:

offical website : https://alc.cash/#/

blog: https://litentry.medium.com/,

twitter: https://twitter.com/alchemy_world,

telegram: https://t.me/AlchemyWorldNews,

github: https://github.com/FIREDEFI,

medium: https://medium.com/@alchemyworld,
Facebook: https://www.facebook.com/Alchemy_World-101557395167230
Recommended,
Gas Limit (For ERC-20 project teams) for transaction: 60,000

添加了FireToken，麻烦请及时处理，谢谢～

Logo需背景透明。

https://github.com/consenlabs/token-profile/pull/6765

https://github.com/consenlabs/token-profile/pull/6765

可否尽快处理下哈
https://github.com/consenlabs/token-profile/pull/6765


Update svg-icons.html

Added SSL to fix broken links for W3C validation and preempt redirection.

Thank you, @sunnankar!
That was lazy of me. Nice find and fix.
Appreciated :sparkling_heart:

Glad to help. Thanks for putting together Jekyll Now. Great work.


Awareness of the Spanish Plan version via MP Twitter

Tweet Text:
El Plan Anual MicroProfile 2021 disponible en Español: https://drive.google.com/file/d/1_zLvW57P6sKMknI5fHFj0lyPD4qRoIwT/view?usp=sharing incluye Objetivos Estratégicos, Técnicos, y para Extensión de la Comunidad, Actividades de Marketing, Proceso de Especificación, Compatibilidad y Marca
This relates to:
https://github.com/eclipse/microprofile-marketing/issues/399
https://github.com/microprofile/microprofile-wg/issues/44

@rstjames,
can you please help us shorter the link above?
@emecas, so fantastic.  I am happy to run a final review in twitter once we have the link from Ryan.
Ryan, do you think we could run this media push 1 per month or what timeline do you recommend. It goes from April to Dec 31st to match the year?
The goal is to bring awareness of the work being done and hopefully increase onboarding MicroProfile from Spanish speaking countries.
With that in mind, the same will happen with Russia translation which is being worked on this week!  :)

@emecas you can share Spanish Plan version highlighting that you are the contributor of this Spanish MP content with the card below:

@emecas,
Thank you for creating this ticket that enables the brainstorming for the message to share the 3 documents.
Using your draft:
_The MicroProfile 2021 Project Plan lists the MicroProfilers' strategic trajectory of their work on marketing activities, growth with the community, infrastructure, technical objectives, specification process & compatibility brand management. [LINK]
#ByCommunityForCommunity_
Things to note:

removed the language b/c the write up makes the language clear enough and also efficient! :)
included the people doing the work, MicroProfilers
using the presentation, the order of the tasks is listed
added hashtag

What else is missing? There will be only 1 message translated into thus far, Spanish & Russian.
Thanks for looking into this.

@TetianaFTV if you could check the suggested English version for grammatical errors and impact on the message that would be great! thanks

some edits as the version above is a bit too long if we add the link:
The @MicroProfile 2021 Project Plan lists the strategic trajectory of MicroProfilers' work on marketing, community growth, infrastructure enhancements, technical objectives, specification process & compatibility brand management
#ByCommunityForCommunity

reads good, Tetiana!
@rstjames can you please help us create a special short-link for the Program Plan in English? Thank you!
1 link houses 3 translations:

 2021

For design I recommend:

2021 large using the title of each Translation
#ByCommunityForCommunity
Open Souce

@emecas can you  please help translate to Spanish the version's revised on this thread? I can review to make it final for media push :)
@TetianaFTV do you wish to help create the design that will be adjusted for the 3 different translations? Or do you prefer that Ryan takes that task?
Lets do this,

here is the design for the tweet

if it's ok we can later make Russian and Spanish versions

@TetianaFTV,
Thank you for getting stuff forward. Feedback as follows:

[ ] I like the people in the room collaborating!

[ ] It is hard to read the focus-listed items in the plan.  how about their re-distrubition as done with the Charter template?

twitter link

the template is in the drive, you could use that template to include a background image and change the borders and done.

@emecas can you please help translate to Spanish the version's revised on this thread? I can review to make it final for media push :)

Sure, want about this? @aeiras
English Version:
_The MicroProfile 2021 Project Plan lists the MicroProfilers' strategic trajectory of their work on marketing activities, growth with the community, infrastructure, technical objectives, specification process & compatibility brand management. [LINK]
#ByCommunityForCommunity_
Spanish Version
_El Plan Anual MicroProfile 2021 incluye las estrategias de trabajo para los MicroProfilers dentro de las actividades de marketing, extensión de la comunidad, infraestructura, objetivos técnicos, proceso de especificación y  programa de marca y compatibilidad. [LINK]
#ByCommunityForCommunity_

there is only change recommended.  How about replacing the "extension de la Comunidad" con bienestar y crecimiento de la comunidad.
Spanish Version
_El Plan Anual MicroProfile 2021 incluye las estrategias de trabajo para los MicroProfilers dentro de las actividades de marketing, bienestar y crecimiento de la comunidad, infraestructura, objetivos técnicos, proceso de especificación y programa de marca y compatibilidad. [LINK]
#ByCommunityForCommunity_

@TetianaFTV, it is a go from me. :)
Can you also help with the design in Spanish
Spanish Version
_El Plan Anual MicroProfile 2021 incluye las estrategias de trabajo para los MicroProfilers dentro de las actividades de mercadeo, bienestar y crecimiento de la comunidad, infraestructura, objetivos técnicos, proceso de especificación y programa de marca y compatibilidad. [add the LINK- shortern customized URL in spanish/Rusian/English respectively. ]
#ByCommunityForCommunity_

@aeiras please provide Spanish translation for the texts on the image, so I can prepare its Spanish version

Here you go and thanks Tetiana!
Title
Plan Anual MicroProfile 2021
tasks:
mercadeo, bienestar y crecimiento de la comunidad, infraestructura, objetivos técnicos, proceso de especificación y programa de marca y compatibilidad

@aeiras why don't we have a Spanish version of the presentation in the folder with others?
https://drive.google.com/drive/folders/1hj-o5s2-LXBpuw0h_xKkJVQ-iz265K6C
I know for sure that it was uploaded there but now I don't see it

Spanish image

the twitter text is too long if pasting together with the link, so I shortened it a bit:
Plan Anual MicroProfile 2021 incluye las estrategias para los MicroProfilers dentro de las actividades de mercadeo, bienestar y crecimiento de la comunidad, infraestructura, objetivos técnicos, proceso de especificación, programa de marca y compatibilidad
@aeiras please check if it's ok from Spanish point of view
Also, we need to figure out where is the final version of the Spanish presentation and upload it again to the folder for Ryan to be able to use a proper link while scheduling the tweet

Spanish image

the twitter text is too long if pasting together with the link, so I shortened it a bit:
Plan Anual MicroProfile 2021 incluye las estrategias para los MicroProfilers dentro de las actividades de mercadeo, bienestar y crecimiento de la comunidad, infraestructura, objetivos técnicos, proceso de especificación, programa de marca y compatibilidad
@aeiras please check if it's ok from Spanish point of view
Also, we need to figure out where is the final version of the Spanish presentation and upload it again to the folder for Ryan to be able to use a proper link while scheduling the tweet

@rstjames,
Same as the other ticket about the Russian message.  1 per month. And Prospectus goes until the end of the year as well. Gracias! :)

@aeiras @TetianaFTV

Can someone confirm these are the final messages?
Can we make it a habit at the end of a very long thread we recap the "final" agreed content? That way there are no mistakes.
Please let me know when we have final LINKS for these tweets

English Version:
The MicroProfile 2021 Project Plan lists the MicroProfilers' strategic trajectory of their work on marketing activities, growth with the community, infrastructure, technical objectives, specification process & compatibility brand management. [LINK]
#ByCommunityForCommunity

Spanish Version
Plan Anual MicroProfile 2021 incluye las estrategias para los MicroProfilers dentro de las actividades de mercadeo, bienestar y crecimiento de la comunidad, infraestructura, objetivos técnicos, proceso de especificación, programa de marca y compatibilidad [LINK]
#ByCommunityForCommunity

each are set to go out once a month for the year


ToLookup method and tests

#72
Have implemented Lookup as a Dictionary with key and a List of Elements. Do you want a separate Lookup type to be created for ShittyLINQ?

I have implemented GroupBy. A couple of the methods return a LINQ type IGrouping. I instead return a Dictionary with a key and list. #45


Add APIs for LEF macro ANTENNADIFFAREA and ANTENNAGATEAREA

Add dbTechAntennaPinModel.hasGateArea
Add dbMTerm.hasDiffArea

The incentive behind this PR is to access the antenna information using python APIs. Currently, I was unable to call getDiffArea and getGateArea using the python APIs as they require passing a specific object which I was unable to create.

It would be better to just fix the python API.  This still doesn't get you access to the data.

@maliberty I tried to do something like
bool dbTechAntennaPinModel::hasGateArea()
{
  vector<std::pair<double, dbTechLayer*>> gate_areas;
  gate_areas = getGateArea();
  return !gate_areas.empty();
}

but I would get warnings:
swig/python detected a memory leak of type 'std::vector< std::pair< double,odb::dbTechLayer * >,std::allocator< std::pair< double,odb::dbTechLayer * > > > *', no destructor found.

Furthermore, the returned object is still inaccessible <Swig Object of type 'std::vector< std::pair< double,odb::dbTechLayer * >,std::allocator< std::pair< double,odb::dbTechLayer * > > > *' at 0x7f815092aa30>.
In addition, I am not really after the data itself. I am only checking for it's existence. Having said that, I wouldn't mind fixing the APIs that returns the data for Python but it is not something I am good with so it would be nice if you can give me some pointers on doing that or I can leave it up to the OpenROAD team to handle it and close this PR.

You would need to add a swig typemap to handle the collection. in odb/src/swig you can see how we have handled other such.  In general messing with swig is headache but great when it finally works.


Filter tasks by owner / creator

Hi,
i'm looking for the way to filter tasks by creator / owner (is it same ?)
I tried using filter syntax like created:me or owner:me or created_by... but nothing appears to work.
what am i doing wrong ?
thanks

This feature is not yet implemented.

This feature is available with the last development version.


Issue 37 standard parameters

Description
Add a few geometric parameters to a module standard_parameters. More parameters should be added to this as they appear in models, if they are standard battery parameters. This file could later be split into different files for different chemistries.

Not sure whether/how to document a module that doesn't contain any classes?
Could now rename BaseParameterValues to ParameterValues as that function won't need to be overloaed?

Fixes #37
Type of change

[x] New feature (non-breaking change which adds functionality)

Key checklist:

[x] No style issues: $ flake8
[x] All tests pass: $ python run-tests.py --unit
[x] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works
[x] Any dependent changes have been merged and published in downstream modules

Codecov Report

Merging #47 into master will increase coverage by 2.44%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   71.23%   73.67%   +2.44%
==========================================
  Files          27       28       +1
  Lines         744      870     +126
==========================================
+ Hits          530      641     +111
- Misses        214      229      +15

Impacted Files
Coverage Δ

pybamm/parameters/standard_parameters.py
100% <100%> (ø)

pybamm/models/core.py
66.66% <0%> (-33.34%)
:arrow_down:

pybamm/expression_tree/binary_operators.py
100% <0%> (ø)
:arrow_up:

pybamm/discretisations/base_discretisation.py
96.55% <0%> (+0.89%)
:arrow_up:

pybamm/expression_tree/symbol.py
96.42% <0%> (+1.19%)
:arrow_up:

pybamm/expression_tree/unary_operators.py
100% <0%> (+2.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c657fa5...438489b. Read the comment docs.

This should now be ready to merge


Kafka log rename and deletion Patch for Windows (KAFKA-1194)

Incorporated suggested changes that handle renaming of files on Windows without affecting
intended behavior on Linux.
I performed tests on core build (with gradle core:test) and everything passed
Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage
[x] Verify accurate topic renaming and deletion on windows with node crashes

why merge changes into the 2.3 branch?
the 2,3 branch should stay as-is to match the original one. We should only commit-changes/merge-PRs into the 2.3-esri branch.


"Attempted to change read-only message" even though message is not frozen/read-only

Proto:
syntax = "proto3";

message M1 {
  M2 nested = 1;
}

message M2 {
  M3 nested = 1;
}

message M3 {
  int32 i = 1;
}

Dart:
import '../test.pb.dart';

void main() {
  M1 m1 = M1.create();
  m1.nested.nested.i = 123;
  print(m1);
}

Output:
Unhandled exception:
Unsupported operation: Attempted to change a read-only message (M3)
#0      defaultFrozenMessageModificationHandler (package:protobuf/src/protobuf/field_set.dart:16:3)
#1      _FieldSet._ensureWritable (package:protobuf/src/protobuf/field_set.dart:207:54)
#2      _FieldSet._$set (package:protobuf/src/protobuf/field_set.dart:545:5)
#3      GeneratedMessage.$_setSignedInt32 (package:protobuf/src/protobuf/generated_message.dart:492:15)
#4      M3.i= (file:///Users/omersa/dart/protobuf_test/test.pb.dart:150:24)
#5      main (file:///Users/omersa/dart/protobuf_test/bin/main.dart:7:20)
#6      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297:19)
#7      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192:12)

This is a duplicate of #309.
When we create an empty M1 the message fields should be null. When we return a read-only empty message, code like m1.nested.nested in the repro above works even though it shouldn't. And because the messages we generate on-the-fly with getters nested are read-only the assignment m1.nested.nested.i = ....
@sigurdm points out that it doesn't make sense to initialize the uninitialized message fields with mutable default messages because it changes presence checks just by accessing the fields. So if we create a mutable default message with m1.nested in the repro above, m1.hasNested() returns false before the access and returns true after it, even if we don't update the nested message.
So the right thing to do here (as also discussed in #309) is to return null for uninitialized message fields. Returning read-only empty message is confusing at best, and probably also not compliant to the spec (see https://github.com/google/protobuf.dart/issues/309#issuecomment-1085024825 and the next comment).


Variable undefined check should goes through functions in front of them.

Search Terms
variable, check, undefined

Suggestion
While checking whether a variable is undefined or null, checker should go through all the code including the function runned before the variable is used.

Use Cases
I have a function that required a non-undefined argument. I do the required field check in a separate function and if the required variable is undefined or null, it should throw an error and the variable is not really used.
However, the checker now is still showing me the error that this variable might be undefined.

Examples
class example {
  private property: string

  public assignVariable (variable: string | undefined) {
    this.checkRequiredVariable(variable)
    this.property = variable // This is throwing the "Type 'undefined' is not assignable to type 'string'." error.
  }

  private checkRequiredVariable (variable: string | undefined) {
    if (variable == undefined)
      throw new Error('Variable is undefined or null')
  }
}

PS: This code is just for the example, I know that this will throw a "No initialization" error as well.

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. new expression-level syntax)

Sounds like you want #17760; is that accurate?

@DanielRosenwasser He does mention this kind of thing but mine is not that complicated. If you think it's a duplication I'll accept that. Sorry for the duplicated issue.

To get type-checking currently, we use a pattern like this:
public assignVariable(variable: string | undefined) {
	this.property = this.checkRequiredVariable(variable)
}

private checkRequiredVariable(variable: string | undefined): string {
	if (variable == undefined)
		throw new Error('Variable is undefined or null')
	return variable
}

You can also make this generic:
function assertDefined<T>(x: T | null | undefined): T {
	if (x == undefined)
		throw new Error("Variable is undefined or null")
	return x
}


Robustify handling of improperly formatted data

Catch missing features in CSV of pre-featurized data and raise relevant exception

My next PR is going to remove this function...

@bnaul, perhaps just make sure whatever you implement in its stead sufficiently checks that the data is properly formatted, and I'll delete this PR

Will do.
On Wed, Nov 4, 2015 at 10:40 AM acrellin<EMAIL_ADDRESS>wrote:

@bnaul https://github.com/bnaul, perhaps just make sure whatever you
implement in its stead sufficiently checks that the data is properly
formatted, and I'll delete this PR
—
Reply to this email directly or view it on GitHub
https://github.com/mltsp/mltsp/pull/100#issuecomment-153824162.


Filter test files using "includes" instead of "equals"

use lodash's intersectionWith

Proposed changes
Testing a single file currently requires you to specify the entire file name, including the file extension. E.g.
adonis test -f 'UserService.spec.js'

With this fix in place, simpy UserService or even User would be enough.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ x I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)

Further comments
I also refactored to use lodash's intersectionWith.
Couldn't find any existing tests for this, so left them out for now...

Coverage increased (+0.3%) to 81.445% when pulling deff1977c0aad0484aa812e68b5c24060ea5f31f on MZanggl:feature/filter-files-contains into 4a461e2144c4ea8bf9b7a5477916cb81c029dc63 on adonisjs:develop.

Hey @MZanggl!
Thanks for your contribution!
Could  you please add some tests that cover your change.
@thetutlage Do you believe we should consider this has breaking change?

@RomainLanz I just added tests. I moved the filter part to the cli so now all the filtering is together in one place and became easy to test.


snap: allow to send a snapshot to many receivers

Signed-off-by: qupeng<EMAIL_ADDRESS>What is changed and how it works?
Simplify snapshot code by removing useless trait generics.
And, call SnapManager::delete_snapshot instead of Snapshot::delete to delete a snapshot after it's sent out. So that if the snapshot is still used by others, they won't be influenced.
Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List
Tests

No code

Release note
None

/run-tests

/run-integration-tests

/run-integration-common-test

Why it's deleted directly in the past?

Seems it's a bug.

/rebuild

/merge

/run-tests

/run-tests

/tests

/merge

/run-integration-tests

/tests

/run-integration-common-test

/run-integration-common-test

/run-integration-copr-test


Proposal for error when there are duplicate IDs

Hi,
you have created a really great job with v1.0 and the environment is really friendly for learning.
So back to the topic, I've a proposal for a feature - add check for duplicate ID attributes . The reason for the proposal is for better project maintenance.
Today when I was playing with some elements, I've copied the paper-input component several times, and forgot to change one of the ID attributes. When it was time to get the values of the inputs I've realized that one of them was wrong. After 20min. wandering, I've realized that two components have identical ID. Imagine to have some big application with a bunch of people working on it. It is quite possible for the same mistake to appear. For this reason some kind of a warning will be great!
I hope that this proposal is reasonable enough to be a new feature in Polymer.
Best regards,
Krasimir

We'll add this to our Polymer linter backlog.  Thanks for the idea.

Great and thanks for the fast response.

@rictic Something for the linter I guess?

This issue was moved to Polymer/polymer-linter#171


Presentation Server: SSL configuration

In #3389 we are removing the default behaviour to skip SSL validation within the core egeria code (server, clients, samples)
Once this is merged...
The Presentation Server code currently also skips ssl verification
This should

default to performing full ssl verification
Provide configuration to disable verification if needed
Ensure the relevant docs for deployment explain how to do this, as well as configure TLS similar to https://egeria-project.org/open-metadata-implementation/admin-services/docs/user/omag-server-platform-transport-level-security.html
Ensure any samples (like the egeria tutorial environment) appropriately configures a certificate or skips the check

Note: will likely need to transfer to the egeria-presentation-server repo once code migrates

@davidradl transferring this to the new repo - as I presume we still need to do this work over there.

@davidradl transferring this to the new repo - as I presume we still need to do this work over there.


Pull all the Keys instead of few?

How can I make sure that i am pulling all the parameters.  i would like to include change and percentchange in the result as well

for getQuotes it returns the information but it filters it with replaceKeys method that only outputs the keys that are defined by googleFinanceKeyToFullName, if you return  content in getQuotes method you will get what i assume all the keys. you can also add the key and definitions to make a more readable output.


[FEATURE REQUEST] Show location of SQL query

Hey!
I don't know if it is possible, but it'd be great to show location of executed SQL query.
For example, I execute UserModel.objects.all(), and I see in __request_tracker__ SQL that was executed as well as location of execution. Or maybe just model name or +- code executed?
It'd really help with debugging 🤔

Yeah I'm blind, it's there already...
Sorry!


[FEATURE REQUEST] CLI interface for update-all

Before submitting the issue

[x] I have checked that the requested feature is not a duplicate or, if it is, it needs to be reopened
[x] I have checked that I am running the latest version of WingetUI
[x] I have checked the FAQ section

Is your feature request related to a problem? Please describe.
https://github.com/microsoft/winget-cli/issues/476
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I currently use https://gist.github.com/Bluscream/c1b14be52a20b54433ba46a4c26aed41#file-update-all-ps1-L54 but that also updates packages that have broken updaters so they will "re-update" everytime the command is run (Unity is an example) or straight up want to update to outdated version.
Describe the solution you'd like
something like wingetui.exe --update-all --auto-accept --uac to be able to update all packages and excluding the blacklisted ones
A clear and concise description of what you want to happen.

You can do that:

It will update both scoop and winget packages

was this your request right?

was this your request right?

Kind of. I need exactly that but in command line, so i can start the update from a batch script and with admin access so i dont need to accept any admin requests from installers

You can also run wingetui as admin.
But I see what you want. Gonna add a button to update all with admin rights

I think this isn't exactly what OP is asking for, but IMO shortcut arguments would be a nice feature.
More info at https://www.digitalcitizen.life/shortcut-arguments-parameters-windows/
For example a shortcut to -"C:Program Files\WingetUI.exe" -update-all would update all apps upon launching WingetUI (without the need to click on update all). What do you think? Maybe I should open another issue... if this is indeed possible

For example a shortcut to -"C:\Program Files\WingetUI.exe" -update-all would update all apps upon launching WingetUI (without the need to click on update all). What do you think? Maybe I should open another issue...

Yes, exactly that it what i was asking for. I hoped including the exact line of the update script im using made that clear in my initial post.

@Bluscream, are you looking for a script like this https://github.com/Romanitho/Winget-AutoUpdate?

That does indeed what i was asking for, im a little hesitant though because i dont want auto upfates happening in the background. I just want to be able to update everything without user interaction by executing one script. Im already using WingetUI to workaround a missing feature in Winget (the missing UI) and now im supposed to use a third software to workaround this missing feature in Winget and WingetUI. Also im using wingetui for most winget stuff except the full update so using it's blacklist that i already filled instead of yet another one that only accepts software IDs (what are those anyway, i dont see any id in wingetui) manually by changing a textfile just seems like a workaround for a workaround for a workaround.
Ideally winget itself would support blacklisting/pinning apps but microsoft made it clear in the issue i linked that theyre not interested so this is the currently best place for it.
If this feature doesnt get implemented i will just make a AutoHotkey script that starts wingetUI for me and simulates a click on update all. Thats gonna get messy af

i dont want auto updates happening in the background

I think this discussion about Winget-AutoUpdate is a little bit off topic and you could probably get better support there. I am not sure, but I believe you can set the update frequency to "never". It looks like there are a bunch of install options that might be helpful to you.
About the ID, you can see and even copy them if you open the info menu in WingetUI:

If this feature doesnt get implemented i will just make a AutoHotkey script that starts wingetUI for me and simulates a click on update all. Thats gonna get messy af

I believe shortcut arguments would be a good solution

I believe shortcut arguments would be a good solution

Thats exactly what i was asking for in the first  post

This feature will come with WingetUI 1.6.1

Would this by any chance allow unattended package updates?

Yes, this is a feature that will come in the next release.
This setting can be enabled from the settings, and will allow WingetUI to start the update process after all the packages have been loaded

P.D. The command-line parameter will be --updateapps


php_beautifier error (or bad installation?)

hi there
when trying to beautify php i get
Command failed: /bin/sh -c [ -f ~/.bash_profile ] && source ~/.bash_profile > /dev/null 2>&1;[ -f ~/.bashrc ] && source ~/.bashrc > /dev/null 2>&1;php "/users/bronze/pear/bin/php_beautifier" --input "/var/folders/y7/2xqg1601455cq89gjdy7t5qh0000gn/T/input115217-312-339wa0" --output "/var/folders/y7/2xqg1601455cq89gjdy7t5qh0000gn/T/115217-312-zovrpv"

checked and saw it was really similar to issue #148 (which is closed).
dont know if this is a new one in the wild or i just went full retard on installing beautifier.

Try php "/users/bronze/pear/bin/php_beautifier" --help in your Terminal and see if php_beautifier is installed and working.

right on point. it returned an error:
Warning: require_once(PEAR.php): failed to open stream: No such file or directory in /users/bronze/pear/bin/php_beautifier on line 37

so i went google-fu'ing and found the best way was to enable my php.ini (copy /private/etc/php.ini.dafault into /private/etc/php.in) and adding a line with PEAR's path to it.
Right at the bottom of the new php.ini i added include_path=".://Users/bronze/pear/share/pear/"
lo and behold, no more errors.
thanks for the help Glavin! cheers!

Glad to hear it worked out!


Check carnivore data re. Lars Werdelin's list

Palaogale ias feminine, so minuta and parvula are correct.
However…
It took me a long time to track down P. parvula. It was originally described by Matthew and Granger (1924) as Bunaelurus parvulus. It has reappeared occasionally in analyses by Meng & McKenna (1998) and Tsubamoto et al. (2004). But, it was in fact synonymized (I think correctly) with Palaeogale sectoria by Lange-Badre & Dashzeveg (1989). So that should be noted in NOW.
To further your work I am attaching an Excel file with the names of 1723 carnivore taxa. This was generated for a database project (submitted to Global Ecology and Biogeography). The names should be correct (although there may remain typos). So these can be checked against the names in NOW.

Activity
Show details
Write a comment…
indre.zliobaite Nov 20, 2023 3:34 PM
ask Yanell to take this over
Reply • Delete
Kari Lintulaakso Mar 17, 2023 3:36 PM
The latest list should have all info about found/not found taxa.
Edit • Delete
indre.zliobaite Mar 1, 2023 2:11 PM
Does Lars list occurrences for those that are NOT FOUND in NOW?
Reply • Delete
Kari Lintulaakso Feb 27, 2023 1:44 PM
The Excel file attached contains the findings.
Edit • Delete
indre.zliobaite Feb 27, 2023 11:50 AM
In Excel or NOW?
Reply • Delete
Kari Lintulaakso Feb 21, 2023 4:15 PM
There are 68 updates that could be found quite easily (status=UPDATE).
In addition, there are over 400 taxa which were not found from the carnivore taxa list (status=NOT FOUND, the accepted taxa from Lars have no species_id).
Rest are taxa with sp. or indet. or are OK.
Also, depending on which is right, Hyaenidae or Hyanidae, additional updates need to be done.

carnivore names (1).xlsx
Carnivora_updates (2).xlsx

Was assigned to me, have not been able to spend time on it so far


Create proper div for laps

Currently the laps overflows the div and destroys the counter.
Can I create a scrollable container for laps ?
Something like this:

don't forget to add screen shot  on pr :)
and add issue number to pr


ORC-1537: Unpin and upgrade spotless to 2.41.0

What changes were proposed in this pull request?
This PR aims to unpin and upgrade spotless to 2.41.0.
Why are the changes needed?
To renable spotless in Apache ORC 2.
How was this patch tested?
Pass the CIs.

Merged to main for Apache ORC 2.


Expose the ability to take screenshots

I understand Karma is primarily designed for unit tests, however the ability to screenshot during a test would be very useful for visual regression testing (both automated and manual).
End-to-end frameworks like Protractor or raw WebDriver scripts generally require you handle building the frontend and spinning up a server. Karma already does almost exactly what I need for this use case, except the ability to take a screenshot.
It's currently possible via the PhantomJS launcher, but it would be great if more launchers supported it, especially in a cross-browser way.

PhantomJS has a way to take screenshots natively. Other browsers like Chrome or Firefox does not have this natively. I'm pretty sure there's no easy way to do this (or maybe not at all).

@MLefebvreICO seems like Chrome does (https://developer.chrome.com/extensions/desktopCapture)

Any update on this issue? I am using ChromeHeadless and have been searching for almost half a day now for a way to take screenshot. Any pointers?

After 3 years, anything new on this?

Something like karma-puppeteer-launcher should do (see here).
Given that it is already doable and that this feature requires a very specific browser and a very specific browser launcher to work, it is best to be developed as a separate plugin. If you're interested in this feature I would suggest to use/contribute to karma-puppetteer-launcher or a similar plugin.

Thanks, I'll give it a try.

Just want to comment that this framework works well for me.
I am using karma + jasmine on an Angular project
https://github.com/prantlf/karma-failure-snapshots


⚠ Mobitopup has degraded performance

In fe4b695, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 6531 ms

Resolved: Mobitopup performance has improved in e405cd5.


Fixes ticket #4471 - stf tunnel interface is not destroyed when 6rd or 6to4 tunnel is disabled

Destroy stf tunnel when 6rd or 6to4 tunnel is being disabled or type switches between 6rd <-> 6to4

merged, thanks!


Update allow-or-prevent-custom-script.md

Fix for #1388

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@kaarins PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


[Bug]: Document pages rendered as black and white instead of colored

Attach (recommended) or Link to PDF file
example-b:w-page.pdf
Web browser and its version
Chrome 131
Operating system and its version
MacOS
PDF.js version
v4.9.155
Is the bug present in the latest PDF.js version?
Yes
Is a browser extension
No
Steps to reproduce the problem

Open pdf in viewer https://mozilla.github.io/pdf.js/web/viewer.html

What is the expected behavior?
Images on page are colored
What went wrong?
Images on page are black and white
Link to a viewer
No response
Additional context
Release version v4.4.168 renders document correctly.
All release versions above (including latest v4.9.155) renders document incorrectly.
Interesting that all of them logs in browser console such warning message.
// v4.4.168
Warning: parseColorSpace - ignoring ColorSpace: "FormatError: Unrecognized ColorSpace: C1".

// v4.9.155
Warning: Unrecognized ColorSpace: C1

I've read release notes for v4.5.136 and found this

Fallback on DeviceGray when a colorspace cannot be parsed by @calixteman in https://github.com/mozilla/pdf.js/pull/18468

Seems that current behavior is fallback, but something wrong with colorspace C1 (according to warning logs).

This is clearly a corrupt PDF document, since it doesn't render in Adobe Reader (i.e. the PDF reference implementation) and there's even a warning message displayed.

@Snuffleupagus Thanks for your help. I will try to figure out how this corrupted document was created.

In the form XObject Root/Pages/Kids/[0]/Resources/XObject/X1 the colorspace C1 is missing. It is defined in the parent resources but that's not enough.


feat: ability to import TLS configuration component into plugin config pages

I wanted the ability to use the "TLS settings" form portion in my plugin config editor.

Initially, I tried doing so with the <Auth> component, but found it had too many additional non-optional datasource-related materials (and text) that I did not want to appear on my page, such as the "Authentication" heading, and the "Authentication types" section.

Since the <TLSSettings> component is not being exported, this PR aims to make it importable directly.
Changes in this PR

Made TLSSettings component exportable
Made the getTLSProps util function exportable under the name convertLegacyTLSProps to match convertLegacyAuthProps
Added a  CommonConfig type which combines the data source settings and the plugin settings to be more inclusive toward the possibility of changing plugin settings instead of just data source settings

So far, this is used exclusively by the TLSSettings
Some code needed to be modified to accommodate the possibility that certain fields might be undefined.

Current workaround, using <Auth/>
In my plugin, I am using...
  const authProps: ReturnType<typeof convertLegacyAuthProps> = useMemo(() => {
    const props = convertLegacyAuthProps({
      config: (commonConnectionConfig || {}) as any, onChange: (config: CommonConfig) => {
        setCommonConnectionConfig({
          ...config,
          jsonData: { ...config.jsonData }
        })
      }
    });
    // Hide the custom headers section
    props.customHeaders = undefined
    // Reduce the authentication section
    props.visibleMethods = [AuthMethod.NoAuth];
    return props;
  }, [commonConnectionConfig])

type CommonConfig = {
  secureJsonData?: Record<string, string>;
  secureJsonFields: Record<string, boolean>;
  jsonData: Record<string, any>;
}

And some css tricks to hide the panels I don't want to see:
        <div className={
          css`
              margin-bottom: 16px;

              &>:first-child>:first-child {

                &>:nth-child(2) {
                  &>:nth-child(2) {
                    // This is the "TLS settings" panel, adjust its margin
                    margin-top: 0px;
                  }

                  &>:not(:nth-child(2)) {
                    // Hide all other panels (the auth method panel)
                    display: none;
                  }

                }
                &>:not(:nth-child(2)) {
                  // Hide "Authentication" header
                  display: none;
                }
              }
            `}
        >
          <Auth
            {...authProps}
          />
        </div>

Alternative approach to consider

Augment properties to hide unwanted sections

update visibleMethods prop to accept an empty list so as to hide it completely
add a hideHeader prop
consider a boolean to use terms "app plugin" vs. "data source" in some of the panels

Update "Options" type to only include what is really required (vs. the entirety of datasource settings)

I think I may be able to use "CustomMethod" to get the effect I want.


add insturctions to download nltk

I added this feature in the initDocker branch already.
Also check your git user settings. It's still not linked to your account. I think you can add a second email to your existing account to merge them.


[circuit-construction] deprecating the implementation

We're going to sunset this implementation and go with another approach. Sorry for anyone who has contributed to this.
cc @katat

postponing this so @rot256 is not slowed down by the change of API


Integration Test - Release - 2018/09/04 09:55:40

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest3 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


feat: support descriptor wallets for RPC governance votemany, votealias

Issue being fixed or feature implemented
RPCs governance votemany and governance votealias use forcely LegacyScriptPubKeyMan instead using CWallet's interface.
It causes a failures such as
test_framework.authproxy.JSONRPCException: This type of wallet does not support this command (-4)

See https://github.com/dashpay/dash-issues/issues/59 to track progress
What was done?
Use CWallet's interfaces instead LegacyScriptPubKeyMan
How Has This Been Tested?
Functional tests feature_governance.py and feature_governance_cl.py to run by both ways - legacy and descriptor wallets.
Run unit and functional tests.
Extra test done locally:
--- a/test/functional/test_framework/test_framework.py
+++ b/test/functional/test_framework/test_framework.py
@@ -242,10 +242,10 @@ class BitcoinTestFramework(metaclass=BitcoinTestMetaClass):

         if self.options.descriptors is None:
             # Prefer BDB unless it isn't available
-            if self.is_bdb_compiled():
-                self.options.descriptors = False
-            elif self.is_sqlite_compiled():
+            if self.is_sqlite_compiled():
                 self.options.descriptors = True
+            elif self.is_bdb_compiled():
+                self.options.descriptors = False

to flip flag descriptor wallets/legacy wallets for all functional tests.
Breaking Changes
N/A
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

Any reason this should be in v21 instead of 21.1?


Feature to add links to running containers

I would be very happy to add links to running containers.
For example to cross link mysql containers for master to master replication.
Thank you for all your hard work!

A lot of activity is going on for a complete revised networking model (including links) in Docker. Have a look here; https://github.com/docker/docker/issues/9983
There are some existing feature requests for better links but they have been closed or depend on the new networking proposal (https://github.com/docker/docker/issues/2588, https://github.com/docker/docker/issues/7468, https://github.com/docker/docker/pull/8138)
I think it's best to watch progress on https://github.com/docker/docker/issues/9983.

Thank you Sebastiaan. I will watch that Bug.

 Looking forward to dynamic links myself :smile:

@sspreitzer as stated in @2588, I have added this feature here:
https://github.com/gdm85/docker-fw#two-ways-linking


Esbuild options plugins not working (esbuild-plugin-tsc for supporting decorator)

I am having a problem with esbuild when build source with decorator of ORM.
In SSTv2, I faced this problem too. After I added esbuild plugin esbuild-plugin-tsc into nodejs options of lambda function then It worked well.
When I try to migrate from v2 to v3, I also used this plugin again when setup function esbuild options but seem that doesn't work.
I still got errors when call API.
Is there any change at esbuild setup in v3 from v2 or v3 cannot load plugin of esbuild?

My sst.config.ts
....
 ....
  async run() {
    const { lambdaRole } = await import('./infra/iam');
    $transform(sst.aws.Function, (args, opts) => {
      // Set the default if it's not set by the component
      if (args.role === undefined) args.role = lambdaRole.arn;
      if (args.runtime === undefined) args.runtime = LambdaConfig.RUNTIME;
      if (args.timeout === undefined) args.timeout = LambdaConfig.TIMEOUT;
      if (args.memory === undefined) args.memory = LambdaConfig.MEMORY_SIZE;
      if (args.vpc === undefined) args.vpc = LambdaConfig.VPC;
      args.logging = {
        ...args.logging,
        retention: LambdaConfig.LOG_RETENTION,
      };
      args.environment = {
        STAGE: $app.stage,
        ...args.environment,
        ...LambdaEnvironments,
      };

      // set default config for nodejs build
      // support decorators by using esbuild-plugin-tsc
      args.nodejs = {
        sourcemap: true,
        format: 'esm',
        esbuild: {
          external: ['pg-native'],
          target: 'node20',
          plugins: [
            esbuildPluginTsc({
              tsconfigPath: 'tsconfig.json',
              force: true,
            }),
          ],
          logLevel: 'info',
        },
        // ...args.nodejs,
      };
    });

    // Import the API URL from the API component
    const api = await import('./infra/api');
    const cron = await import('./infra/cron');
   ......
    ....

Yeah we need to look into this. Tracking it in #4514. Closing this.


GraphQL Transform keyField in @connection directive is broken.

Describe the bug
When using the keyField in @connection, the relationship does not work and the query returns an error.
I have tested this locally and in the service..
Steps to reproduce the behavior:

Create an AppSync API from the Amplify CLI
Add the following shema:

type Talk @model {
  id: ID!
  name: String!
  description: String!
  comments: [Comment] @connection(name: "TalkComments")
}

type Comment @model {
  id: ID!
  message: String
  createdAt: String
  talk: Talk @connection(sortField: "createdAt", name: "TalkComments", keyField: "talkId")
}

Run the following operations in this order:
mutation createTalk {
  createTalk(input: {
    name: "Talk 1"
    description: "Cool talk"
  }) {
    id name description
  }
}

mutation createComment {
  createComment(input: {
    talkId: "<TALK_ID>
    message: "Great talk"
  }) {
    id message
  }
}

query listTalks {
  listTalks {
    items {
      id
      name
      description
      comments {
        items {
          message
        }
      }
    }
  }
}

Expected behavior
The comments array is populated with the comment.
Screenshots

Desktop (please complete the following information):

OS: MacOS

Additional context
CLI Version: 1.12.0 & the latest from Yathi's release

You are using a Many to One connection, and the keyField on the Many side directive is used to find the hash key on the One side. In this case your many side @connection does not include keyField, so  the default ID is used, commentTalkId, not talkId.
However, when the cli sets up the One side, it uses the specified keyField to set the GSI hash key.
Result is wrong key is used in lookup.
At a code level, graphql-connection-transformer/src/ModelConnectionTransformer.ts 'field' method part 2 is the problem. Specifically, validateKeyField does not throw an error when the keyField passed in is undefined. If passing in undefined threw an error, this issue would not be deployed and a user could correct the schema.
From a code architecture standpoint, tsconfig.json does not have strict null checks enabled. The validateKeyField definition is not correct if you turn on strict null checks, and I can't see a good reason why this is not enabled.
Documentation on this is not clear, and DX does not seem good. The need to match keyFields on both connections could be eliminated by replicating the use of 'associatedSortFieldName' for the keyField name as well.

@mikeparisstuff currently having trouble adding the sortField to my schema. It's quite similar to the fix you posted but I get this error.
Attempting to edit the global secondary index gsi-UserOrder on the OrderTable table in the Order stack.
An error occured during the push operation: Attempting to edit the global secondary index gsi-UserOrder on the OrderTable table in the Order stack.


Builtin tests and some builtin implementations

This PR includes:

Add new builtin test case that tests them against single arguments of all data types

Except set, frozenset and dict as those are unordered and the assertEqual() barfs on them occasionally

Generate the builtin tests for the builtin functions
Fix a nasty logic bug that wasn't exiting testdaemon, causing the process to run out of file descriptors once the new tests are added
Implement some builtins' functionality: abs(), bool(), all()

Mark some unary-not tests as passing due to implementation of bool() on some data types.

Fixed a missing optional args on the round() builtin

Outstanding issues:

Object.typeName() seems to return names like test.Widget, but the expected TypeError message is supposed to be Widget. Not sure what is the best way to deal with this, the test is marked as expected failure now.

Re-merged master in to resolve the merge conflict, and resolve the non-conflicting (but not valid Java) double definition of Tuple.__bool__() that arose from the merge.
Added NoneType to all the lists of non-implemented tests for builtins.
Fix issues with the TypeError message generated in org.Python for non-iterable objects, and objects with no len().

In particular, relying on the implicit toString() -> __str__() -> __repr__() on the org.python.types.Type class when doing org.python.types.Type.pythonType(iterable.getClass()) doesn't work properly as it becomes <class 'NoneType'> instead of the expected NoneType. Switched to iterable.typeName() instead.

This is awesome - thanks!

Oops, forgot to mention the issue: ref #76.


Coding

This is an audit sample- hence the output file should be audit.json instead of signin.json

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee022017-8f87-7f2a-0569-7989dfc9359f
Version Independent ID: 0dc5d542-1167-7645-4b9f-a80ea8e29c95
Content: Azure Active Directory reporting audit API samples
Content Source: articles/active-directory/active-directory-reporting-api-audit-samples.md
Service: active-directory
Product: unspecified
GitHub Login: @rolyon
Microsoft Alias: dhanyahk;rolyon

@limjianan Thanks for your feedback! We will investigate and update as appropriate.

@limjianan I have assigned this issue with the content author to validate and update the documentation.
@rolyon Can you please validate and help updating the document.  Also, we need to update Azure Active Directory sign-in activity report API samples with the correct file name. Currently filename in the script is "SignIns$i.json" whereas documentation says "SigninActivities.json" as file name.

Hi @SaurabhSharma-MSFT,
Thanks for the info. I'll have a look. Is there someone that should review the code updates?
Robert

#in-progress

Made updates to files names
https://docs.microsoft.com/en-us/azure/active-directory/active-directory-reporting-api-audit-samples
https://docs.microsoft.com/en-us/azure/active-directory/active-directory-reporting-api-sign-in-activity-samples

#please-close

just on the sign in activities sample the below still says audit logs.
Once you finish editing the script, run it and verify that the expected
data from the <<<>> report is returned.
On 31 May 2018 at 10:13, Robert Lyon<EMAIL_ADDRESS>wrote:

#please-close
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/9259#issuecomment-393359702,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT9Os-GiqZmEvvgXbOKEyTQ_-_1BVKC_ks5t3zWugaJpZM4UPfRP
.

@limjianan We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

Hi @limjianan, On the sign-in activity report API samples article, I changed "Audit logs" to "sign-in logs"
https://docs.microsoft.com/en-us/azure/active-directory/active-directory-reporting-api-sign-in-activity-samples


[Bug] MediaElement will crash when page popup

Description
The App will crash when leaving the page which has MediaElement.
Steps to Reproduce

Use the MediaElement demo https://docs.microsoft.com/en-us/samples/xamarin/xamarin-forms-samples/userinterface-mediaelementdemos/
Launch the App goto Custom Transport page
Click Play and pause a few times and then click stop, then go back the front page

Expected Behavior
The App still running
Actual Behavior
The App is froze
Basic Information

Version with issue:
Last known good version: <IP_ADDRESS>8
IDE:VS for Mac 8.6.5
Platform Target Frameworks:

iOS:  13.5
Android:
UWP:

Android Support Library Version:
Nuget Packages:
Affected Devices:

Screenshots

Reproduction Link

Workaround

Hi Jessie! Thanks for reporting this. There has been shuffling with the MediaElement and it now lives in the Toolkit with us.
Would you be able to check if the bug still happens in our code? I know there have been some bugfixes in the meantime. Thanks!

I presume this bug is fixed (at least because now we don't override Dispose method for iOS MediaElement renderer)


⚠ GG2RDF Service has degraded performance

In 34612c1, GG2RDF Service (https://gg2rdf.ld.plazi.org/status) experienced degraded performance:

HTTP code: 200
Response time: 519 ms

Resolved: GG2RDF Service performance has improved in 1a6dcd5 after 18 minutes.


Rename Collection::lists or Query::lists to ::pluck

In gitlab by @A-Lawrence on Aug 24, 2016, 01:09
The lists method on the Collection, query builder and Eloquent query builder objects has been renamed to pluck. The method signature remains the same.

In gitlab by @NFarrington on Sep 3, 2016, 00:10
Completed by 6dac7f01c786c8047226612acdf2098cae0c6666


Revert "feat: add rolling window support to 'Big Number with Trendline' viz"

Reverts apache/incubator-superset#9107
This change broke rendering of NULL values in the Big Number with Trendline viz. NULL values now render as 0, which is misleading. I'm reverting as this is a data accuracy bug and is fairly high priority.
Repro steps:

Run a query like this in SQL Lab:

SELECT *
   FROM (
         VALUES ('2020-02-29',
                 4), ('2020-03-01',
                 1), ('2020-03-02',
                      NULL), ('2020-03-03',
                              2), ('2020-03-04',
                              3)) AS t (ds, value)

Explore it and select the big number with trend line viz
See 0 instead of NULL in the trendline

to: @john-bodley @mistercrunch @kristw

@etr2460 was an effort made to reach out to @mistercrunch or anyone else at Preset to come up with a solution to this bug before issuing a revert?

As per the revert guidelines, I've informed the original PR author on the revert, provided concise repro steps, and gotten the revert reviewed.
As this is a regression caused by a new feature and not a bug fix, and because this is a pretty severe data accuracy issue, I moved towards reverting the PR vs attempting a fix. A fix can be added to the original commit, unit test added, PR-ed out, and reviewed pretty quickly

Preset has been discussing this internally, and we believe this is a one-line fix. We think that counter-indicates a revert, and are happy to provide a PR so that we can roll forward here instead of roll back.

A couple questions (note that regardless of fix difficulty/complexity I'm still strongly in favor of reverting first, then re PR-ing with both the original commit and the fix):

What is the ETA on the fix?
Does the fix include a unit test?
How confident are we that the fix will completely resolve the issue?

Sorry about the inconvenience, how about: https://github.com/apache/incubator-superset/pull/9314 ?

Pausing this pending #9314

Personally I think we should revert per the guidelines as the pending PR doesn’t have a unit test. We should strive to keep master as stable as possible.

I'm working on a unit test for the related PR now. I do not think waiting a small period of time for the fix to become stable is unreasonable. I do think pushing through a revert when engineers responsible for the relevant code are available and responding is a questionable choice. It creates unnecessary friction in the community for only momentary gain.

closing as the fix was merged


Service doesn't go up cause of lack of /run/jmx_exporter directory

Prerequisites
[x]  Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
[x] Checked that there is not already provided the described functionality
Description
Service doesn't go up.
Steps to Reproduce

deploy the role
systemctl status jmx_exporter:

$ sudo systemctl status jmx_exporter
● jmx_exporter.service - prometheus jmx exporter
   Loaded: loaded (/etc/systemd/system/jmx_exporter.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Mon 2019-07-15 12:01:26 UTC; 2min 34s ago
  Process: 13059 ExecStartPost=/bin/sh -c echo $MAINPID > /run/jmx_exporter/jmx_exporter.pid (code=exited, status=0/SUCCESS)
  Process: 13058 ExecStart=/bin/sh -c /usr/bin/java $JAVA_OPTS $JAVA_MEM                        -cp /opt/jmx_exporter/jmx_exporter.jar io.prometheus.jmx.WebServ
 Main PID: 13058 (code=exited, status=127)

Jul 15 12:01:26 mymachine systemd[1]: Starting prometheus jmx exporter...
Jul 15 12:01:26 mymachine systemd[1]: jmx_exporter.service: Main process exited, code=exited, status=127/n/a
Jul 15 12:01:26 mymachine systemd[1]: jmx_exporter.service: PID 13058 read from file /run/jmx_exporter/jmx_exporter.pid does not exist or...
Jul 15 12:01:26 mymachine systemd[1]: Failed to start prometheus jmx exporter.
Jul 15 12:01:26 mymachine systemd[1]: jmx_exporter.service: Unit entered failed state.
Jul 15 12:01:26 mymachine systemd[1]: jmx_exporter.service: Failed with result 'exit-code'.

Expected behavior:
Service is up
Actual behavior:
Fails with error read from file /run/jmx_exporter/jmx_exporter.pid does not exist
Versions
master: https://github.com/idealista/prometheus_jmx_exporter-role/commit/5d0cdf74816e010db05fcd34a5aedd0d8d667f76

Java should be installed.


New Document for VNET to enable private link for Event hub and storage account

@gunjandesai - thanks for your contribution. Please create the PR in the private repo dataexplorer-docs-pr. Follow the instructions found here: https://kusto.azurewebsites.net/internaldocs/engineering/publishing_to_msdocs.html and in pages linked from that page.

We'll close the PR based on guidance from @orspod to the contributor.


resolve com.esotericsoftware.kryo.KryoException

What changes were proposed in this pull request?
Explicitly setting "spark.serializer" to "org.apache.spark.serializer.KryoSerializer" could resolve "com.esotericsoftware.kryo.KryoException: Encountered unregistered class ID" for this example code.
How was this patch tested?
This example code always report "com.esotericsoftware.kryo.KryoException: Encountered unregistered class ID" after launching. With this patch the code could run normally.

Can one of the admins verify this patch?

I don't think this can be correct. Kryo is already active if you see that exception. You need to register an additional class or change to disable kryo registration


Add LICENSE

DeferredCallable.php is missing LICENSE text.

Coverage remained the same at 96.603% when pulling fa9b968cfd1a354fed6a0b0bde0f5879d431355d on rnamiki:patch-1 into 30cfe3c07dac28ec1129c0577e64b90ba11a54c4 on slimphp:3.x.

Thanks.


Steps to notarize

It will be good to have the steps to get an application notarize

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab295263-1911-add9-0388-4d43a2ffcf3f
Version Independent ID: cff6c791-597a-ab01-6c91-3c8d24cccdaf
Content: Working with macOS Catalina Notarization
Content Source: docs/core/install/macos-notarization-issues.md
Product: dotnet-core
GitHub Login: @Thraka
Microsoft Alias: adegeo

Thank you for the suggestion. I'll add a link to Apple's documentation.


Adding generic require, require_concept, and query properties

adding is_applicable_property and static_query traits
renaming property.hpp to prefer.hpp
adding support for is_tag_invoke_applicable trait

Essentially, this implements P1393 (wg21.link/p1393) with the change that it uses tag_invoke CPOs.

Would you mind changing the properties for the executors (make_with_hint etc.) to use require instead?

@msimberg Yes, that's the plan. This may require changes to your implementation of prefer, which I wanted to discuss first.


Make the GCP PubSub container work

Accidentally closed the PR under review https://github.com/testcontainers/testcontainers-python/pull/183 and cannot reopen it. Recreated this one.
Changes

Replace with_exposed_ports with with_bind_ports
Modify the context manager to set and unset environment variable as mentioned in https://cloud.google.com/pubsub/docs/emulator#env
Update the test
Update the pubsub gcp lib versions

It looks like this PR is reverting a number of changes introduced in previous work, e.g the docker version from #203. This may be the result of copying code from an outdated branch.

Yeah, I think you are right. I will take a look.


migrate to using FFI and consolidate under the Guard/Listen banner

It's somewhat awkward to completely outline a plan for your own library in a comment under somebody else's, but apparently that's how I roll. :man_shrugging:
My stream of consciousness for this is outlined in guard/rb-inotify#66 at https://github.com/guard/rb-inotify/issues/66#issuecomment-303563777

special ping to @thibaudgg as I would like your feedback to that comment specifically before proceeding.

I'm also a mac developer with C/C++ experience so let me know if I can help.
Also, I think initially, FFI was only a suggestion, not a hard requirement. In the end - it's really what makes it easier and better - the internal design is up to you.
If it makes sense (and less breaking) to just keep using the binary approach, I'm okay with that.
Is it possible to use FFI to access the appropriate APIs without needing a compiled library?

rb-fsevent has been plagued on and off with tricky bugs involving the passing of signals to the fsevent_watch subprocess. At one point a change in the behavior of guard itself necessitated rewriting signal handling in rb-fsevent to not break things.
There is also a bug where sometimes, for no sane reason, the fsevent_watch process is hanging around after the parent process is long gone. For people who experience this bug and also never turn off their machines (instead putting them to sleep)... eventually the lower level fsevents service will start rejecting requests to watch the filesystem. And I don't mean just from rb-fsevent. I am unable to reproduce this bug and thus have little motivation to dig deeper.
The communication format between parent and child process isn't nearly as well thought out as I thought it was at first. I had a plan at one point to move to otnetstring (an optimized variant of tagged netstrings that makes much more sense to me and is very easy to work with), but then I got distracted by other life events. Anyways, there is also a bug where if your file path looks sufficiently similar to the syntax I use for passing messages, then those events never make it to the library user.
All of the above bugs go away if I'm not using a subprocess. The biggest concern for me is the horrible horrible things we have to do to work around an HFS+ caching bug in 10.7-10.11 and having that occur in the main ruby process rather than isolated in the subprocess.
It is not, however, possible to use FFI to access the appropriate APIs without needing a compiled library. It is also not possible to perform the necessary workarounds without a compiled library. I don't see why this is an issue because I've been compiling (and signing with my personal Developer ID certificate) fsevent_watch for users ahead of time for the entirety of my contribution to this library and provide rake tasks to recompile if you're running an older system than i'm able to target (the underlying code still supports 10.6 if I was too lazy to clean it out and let me tell you...

Before offering assistance, you should look at the depth of the cthulu insanity level BS happening here: https://github.com/thibaudgg/rb-fsevent/blob/master/ext/fsevent_watch/FSEventsFix.c ;)
Ignore the initial comment block, it's from an earlier attempt and not in any way accurate. The custom realpath uses CoreFoundation.
...actually, you might want to read that code anyways just out of perverse curiosity.

Uh, is this for real?
Like, how does apple even use their own API if it's that broken?

It's a VERY tricky bug, and sometimes just looking at it the wrong way makes it disappear. Describing it as an HFS+ caching bug is actually a bit simplistic as it's a series of bugs at multiple levels that have to happen at the same time for the issue to occur. I wouldn't go so far as to say it results in filesystem corruption... but it does result in completely faulty metadata in the filesystem so it's pretty close.
The bug does not exist in 10.6, and was fixed in 10.12 after years of back and forth with Apple. It took that long to devise a way to reliably reproduce it and test for it... and the tech was absolutely horrified to discover that the problem existed somewhere on the filesystem of almost every machine they tested.

lol @thibaudgg... I need more than a thumbs up emoji man. 😆

Another thing to think about, regarding that wiki page... There are details we were very politely asked not to disclose. There's no gag order or NDA, but you most certainly don't bite the hand that feeds you. I believe that describing it as a metadata issue is probably sufficient... with a footnote that the kernel, realpath(), and various other APIs (both POSIX and Apple) would all disagree about the name of a path and that this is the root of the problem. The kernel would report an event using a path that the userspace was not looking for, so the event wouldn't propagate unless the software was explicitly watching all paths (like Apple's Time Machine backup software, which miraculously continued to work despite the bug, but would result in backups that disagree with the original regarding the case/name of any number of files and directories).

I'm also thinking --my-filesystem-is-broken is probably sufficient vinegar for enabling those hacks.

So you are saying that Time Machine is basically broken for 10.6 .. 10.11?

Calling it broken is a bit of an exaggeration considering that the
filesystem is case preserving but case insensitive. No, instead the backup
would preserve an incorrect form of the path... and restoring from backup
wouldn't cause any problems because, again, the filesystem is case
insensitive. Nothing would stop working or work differently outside of
filesystem monitoring. It was, essentially, an invisible bug that broke
nothing... another reason why nobody ever noticed.
The issue existed between 10.7 and 10.11. 10.6 and 10.12 function as
intended.
The bug also doesn't exist in any way whatsoever if you're using the
(non-default) case sensitive version of HFS+. This is why I use case
sensitive HFS+ even now... (though I have to have Steam, Photoshop, and
other braindead software installed to a case insensitive disk image since
they break completely if your filesystem is case sensitive... it'll be
hilarious to see how they react to APFS, which is ONLY case sensitive right
now, with plans to potentially add case insensitivity later)

I use case sensitive HFS+ on all my machines :D I refuse to install crap which doesn't work on case sensitive machines :D

lol @thibaudgg... I need more than a thumbs up emoji man. 😆

Yeah, sure, sorry about that, yesterday was a bit packed for me.
I completely agree with your comment about leaving rb-fsevent untouched. My initial idea was also just to increase the gem version and add a simple post_install_message explaining the move to listen-fsevents. As you said a lot of people depends on the current state of the gem, and I see no reason either to change it. That move also gives us (essentially you!) more liberty to take drastic choices around listen-fsevents. I would personally rather have a simpler gem that only works on 10.12, uses FFI, supports only latest Ruby version (if useful for some technical reasons), and drops hackish pieces of baggage (even if you worked hard on them 💪).
If rb-fsevent and listen-fsevents gems co-exist, listen could easily use one or the other based on the macOS version and notify the user about his/her broken file systems. The new "untouched" rb-fsevent version would also inform the user about the same thing and encourage the upgrade to 10.12 and listen-fsevents.
On the technical decisions (using FFI or not, ...) around listen-fsevents it's really up to you, @ttilley, to decide. This gem is definitely yours since version ~0.4. Thank you a lot for all your hard work, it's really really appreciated 💟.

@thibaudgg ok. I'll start out without hacks, at least... especially since the latest xcode appears to only include the 10.12 SDK anyways!
Aya:~ ttilley$ ls -l /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/
total 4
drwxr-xr-x 4 root wheel 170 May  3 18:36 MacOSX.sdk
lrwxr-xr-x 1 root wheel  10 Apr 14 20:46 MacOSX10.12.sdk -> MacOSX.sdk

...so unless I'm missing something, I'm currently unable to target older versions of MacOS if I go the pre-compiled route for the dylib files (even though the "deployment" option still exists and goes back to 10.6, this is misleading without an older SDK available).
10.12 only it is I guess.

@ttilley Replying specifically to your comment about SDK versions.
I ran into the same problem when compiling things using Teapot.
I settled on using the "MacOSX.sdk" rather than a versioned one.
That SDK supports older versions of Mac OS X, you just need to run clang++ -mmacosx-version-min=10.6 ... and it will ensure that you don't use parts of the SDK that are not available to you.

...which gives me even more reason to maintain rb-fsevent, as at least one of the two should contain warning about filesystem metadata corruption. I'll just have to use TravisCI or something to build those binaries. Right now we silently work around the issue without ever informing the user there might be a problem. That's not at all the right approach, in hindsight, and the decision to do so was made hastily in the excitement of finally finding a solution.
I'll get properly started on friday evening or over the weekend and build from scratch to get rid of the cruft not necessary on 10.12. It'll be liberating not to care about compatibility since 10.12 works beautifully and the API has been stable for more than one major OS release at this point. Improvements have also been made to event coalescing as well so as to avoid overloading an app using file level events (initially, just renaming a file with file level events could fire as many as 10 or more separate events). I have already states my reasons for wanting to defer to @thibaudgg on this decision and stick by them no matter what he says about my contribution to the project. 😝
I do have a lady friend I'm hoping to have over friday afternoon for my famous homemade calzones with my own personal potato dough recipe, glorious bacon, and a mixture of bell and banana peppers fried in the bacon grease. So absolutely nothing before late evening... I hope. Wish me luck! :wink:

@ioquatix it'll ensure you don't use parts of the SDK not available to you, but if you pre-compile (which has been my strategy thus far) it still won't run on older releases.

I was under the impression if you specify that flag, it will run on older releases of mac os x. But, perhaps there is another flag you need to specify. I'd need to look it up. In any case, we can test this.

@ioquatix - I'm thankful to have you on the job, and truly look forward to working together. #brofist

https://www.youtube.com/watch?v=5pEPpNpbnCI

So cheesy 🧀

-_-

I don't mean #brofist is cheesy - the lyrics of the video are cheesy - but I'm totally down with #brofists :D

I've sent some casual thoughts to @ioquatix. This ticket will be updated if they become more than just fun ideas.

...is there a sane way for FFI to handle C blocks as callbacks rather than function pointers?

@ttilley no idea I never used FFI, sorry that I cannot help you more.

If you decide to install 10.13 to play with APFS properly... don't. Older machines can't boot from an APFS root even though there's an EFI driver for it embedded into the filesystem (slightly overkill?) and if you repartition to have an HFS+ root and APFS /Users and etc (you can have multiple volumes on the same filesystem) it completely breaks both migration assistant and time machine.
Oh yeah, and 10.13 doesn't wake up from sleep.

@ttilley thanks for the info, I'll wait a little bit longer then. 👍

I have no idea what I'm doing and providing a C callback via FFI to swift code is painful as fuck. Even if it was ObjC or C code, it's still kinda painful.
SO I'm going to procrastinate further and install the 10.13 beta2 to play with because that's how I roll.
At least I fixed most of the existing rb-fsevent bugs and released v0.10.2. It has most of the benefits of an FFI release, except for ignoring (or marking) events caused by the current process and properly handling when the watched folder has its name (or a parent directory's name) changed. And it seems that the issue with processes lasting longer than they should has gone away after the rebuild... and the change of communication format fixed the edge cases with file names with unexpected characters being ignored (as well as some other issues). Pretty much everything I'm aware of is fixed, and the API has been enriched to allow for additional possibilities previously not possible (like being aware of a file's type ahead of time via metadata without having to check the filesystem).
@ioquatix - with the 10.12 SDK what I thought of previously regarding compatibility is completely false. You CAN build against the 10.12 SDK and have it loosely link or use new APIs. This wasn't the case originally. I don't know exactly when the binary compatibility change was made. It HAD to be after garbage collection support was dropped completely though, not just when it was deprecated. :shrug:

aside: it might be easier to rewrite and extend the existing fsevent_watch C code to be usable as a library, and thus from FFI, rather than writing anything new.

Hi all, thanks!!! for all the fantastic work here.
I found my way over here from [https://github.com/codekitchen/dinghy/issues/269#issuecomment-386986207], since rb-fsevent is used by dinghy to proxy file event change events into the VirtualBox VM in which Docker is running.
And since we have a candidate fix already for unfs3 to use nanosecond timestamps on 10.13 APFS, I was wondering if you thought that rb-fsevent will also need an update for nanosecond timestamps there?
Thanks again!

this is a very old thread but regarding the discussion around dropping historic support on older (read: broken) versions of macOS,
it seems like the M1 transition is a very good/easy place to make the jump.
All M1/arm versions of the code require at least version 11, so that seems like a fairly easy safe way to make the drastic changes and not worry about historic compatibility since you will be sure anyone using an M1 won't be an older version.
even if you decide to leave legacy Intel support in, you could make a fairly drastic change to the binary on the M1 version and just lipo the two together such that what gets distributed works consistently on historic Intel systems but the new M1 stuff would not be bound by the same constraints.  (see this PR for how I lipo two binaries together https://github.com/thibaudgg/rb-fsevent/pull/88)

Thanks!


⚠ Bofrost.de has degraded performance

In 93db8f6, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 854 ms

Resolved: Bofrost.de performance has improved in b6c0bad after 6 minutes.


Typo

Hi. Fantastic plugin, thank you!
I just noticed a small typo:

The button should say 'Get Selection'.

+1
FYI @canisminor1990


Discussion: SELECT * EXCEPT syntax

This is an interesting feature supported by BigQuery. https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax

Why do we need that?
The feature is very useful to us since we don't support output rank in the common pattern Group TopN, see https://www.risingwave.dev/docs/current/sql-pattern-topn/
It can be very frustrating if we use the existing syntax and the table has a large number of columns (We've seen about 30-100 columns in user queries).
SELECT c1, c2, c3, c4, c5, c6
  FROM (
    SELECT c1, c2, c3, c4, c5, c6,
      row_number() OVER (PARTITION BY grp
        ORDER BY sk) AS rank
    FROM t1)
WHERE rank <= N;

If we use * in the outer query, then the query will fail by:
fail to transform overAgg to groupTopN: the rank cannot be included in the outer select_list, see https://www.risingwave.dev/docs/current/sql-pattern-topn/ for more information

If we support the * EXCEPT [column_list] syntax, we can simply write the following query:
SELECT * EXCEPT rank
  FROM (
    SELECT c1, c2, c3, c4, c5, c6,
      row_number() OVER (PARTITION BY grp
        ORDER BY sk) AS rank
    FROM t1)
WHERE rank <= N;

#9092

#9092

In all well-known database, only BigQuery supports that, but they use EXCEPT keyword :(

#9092

In all well-known database, only BigQuery supports that, but they use EXCEPT keyword :(

Sorry it is my typo :hot_face: :crying_cat_face:

Let's discuss in https://github.com/risingwavelabs/risingwave/issues/9092


2020-04-04 tc1515 M3SD VSSPW parameter does not match reference value.

VSSPW Parameter: Does not match. Calculation and unit conversion for the reference values in the qualification test script appear to be consistent with what was done for VSSPO, which does match between test and reference. No obvious reason for why the values for VSSPW do not.
Refer to 2020-03-30_tc1515_M3SD.html

Retested with commit c49a1b4 with tc1515_M3SD
Testcase fails.
Scaling factor for ML/HR/LB to ML/HR/KG incorrect
unit_conversion : Unit Class 15: (Volume/Time/Body Weight) clw_col:  CLOW CLPW  parameters are scaled from  ML/HR/LB  to  ML/HR/KG  via scaling factor:  2.204624
See #217 for related issues

This test now runs successfully with VSSO and VSSP matching reference values. @TomTensfeldt I'm not certain why conversion from ML/HR/LB to ML/HR/KG is incorrect?
LB to KG is divide by ~2.205, so wouldn't /LB to /KG be multiple by ~2.205?


Support ESLint v6

The main issues are:

[x] Use require.resolve when passing the parser option to RuleTester (https://eslint.org/docs/user-guide/migrating-to-6.0.0#rule-tester-parser)
[x] Add ecmaVersion when sourceType is module (https://eslint.org/docs/user-guide/migrating-to-6.0.0#-the-default-parser-now-validates-options-more-strictly)
[x] Transform output of the FileEnumerator into what the import/no-unused-modules rule expects
[ ] @typescript-eslint/parser is using an internal module (eslint/lib/util/traverser) which has been removed in ESLint@6 and therefore causing an error. It's been fixed in https://github.com/typescript-eslint/typescript-eslint/pull/628 but not been released yet
[ ] Same as above for typescript-eslint-parser but this is an archived package. As I write this I realise I should probably use the testVersion function so that tests for this are skipped on eslint>=6

To test:
npm i eslint@6
npm test

The only failing tests should be related to the TypeScript issue above.
Related to https://github.com/airbnb/javascript/issues/2036.
Fixes #1362.

It's also having some sort of whitespace issue with a couple of tests as you can see here - https://ci.appveyor.com/project/benmosher/eslint-plugin-import/builds/25480510/job/i7a5k9x6j6s1hg8a#L3072. I think I've fixed it and then it comes back again haha

Coverage remained the same at 97.803% when pulling c61fad0f6e5e41e887382ab8b0eb7ca0cfd1384f on sheepsteak:eslint-6 into fc65509216dca4bb5a6a6d41c23348ba8cbb62c2 on benmosher:master.

Coverage remained the same at 97.803% when pulling c61fad0f6e5e41e887382ab8b0eb7ca0cfd1384f on sheepsteak:eslint-6 into fc65509216dca4bb5a6a6d41c23348ba8cbb62c2 on benmosher:master.

Coverage remained the same at 97.803% when pulling c61fad0f6e5e41e887382ab8b0eb7ca0cfd1384f on sheepsteak:eslint-6 into fc65509216dca4bb5a6a6d41c23348ba8cbb62c2 on benmosher:master.

Coverage remained the same at 97.803% when pulling c61fad0f6e5e41e887382ab8b0eb7ca0cfd1384f on sheepsteak:eslint-6 into fc65509216dca4bb5a6a6d41c23348ba8cbb62c2 on benmosher:master.

Coverage remained the same at 97.803% when pulling c61fad0f6e5e41e887382ab8b0eb7ca0cfd1384f on sheepsteak:eslint-6 into fc65509216dca4bb5a6a6d41c23348ba8cbb62c2 on benmosher:master.

Coverage remained the same at 97.803% when pulling c61fad0f6e5e41e887382ab8b0eb7ca0cfd1384f on sheepsteak:eslint-6 into fc65509216dca4bb5a6a6d41c23348ba8cbb62c2 on benmosher:master.

Are you perhaps running prettier on autosave in your editor or something? If so, disable that - prettier should only be run via eslint autofix, and only on repos that use it.

Sorry, about the double quote changes. I've reverted all of them. I have Prettier set to only work when there is a .prettierrc present so it not sure what's causing that 🤷♂

I suppose it is eslint in your editor doing that changes. The ci does not lint over ./tests, so there are many lines in ./tests not passing eslint.

Added one last commit to only run tests for typescript-eslint-parser when ESLint is <6 where appropriate given that it's archived and will probably never get the required fix.
Would you like me to update Travis CI config to use 6.0.0 instead of 6.0.0-alpha?

Yes, please.

@ljharb OK I had to one more thing and make testVersion take a function instead of an object so that require.resolve didn't get run and throw an error. This happens when trying to resolve the TypeScript parsers on test runs where they've been removed in dep-time-travel.sh. All tests pass on Travis now 🎉

Please @ljharb can you merge and release this. This is urgent now with eslint 6 in production everywhere (unfortunately).
"eslint": "2.x - 6.x"

@frederikhors If npm ls exits nonzero, your dep graph is invalid, so eslint 6 shouldn't be in production when you have peer dep conflicts with it. If it's urgent for you, it's a problem of your own making.

@ljharb the problem is not mine but it is here: https://github.com/prettier/prettier-vscode/issues/672

Their problem is the same; upgrading to eslint v6 prior to peer deps upgrading is invalid.

@ljharb still same problem today.


Implement CallTrackingMock.

See the discussion over on https://github.com/python/cpython/pull/10555 that was triggered by https://bugs.python.org/issue35226, which was in turn triggered by https://github.com/Simplistix/testfixtures/issues/90.
Plan is to subclass MagicMock and have return_value return a new mock each time it's called that tracks the parameters used to create it with.

The plan won't fly. This would really require a far too invasive mang.ing of Mock, so I'm going to leave it as a facade with the _Call fixes and some cautionary examples. I think that should suffice, MockPopen can just use call, which has been fixed, so should be okay.


Need test vectors and test suite

#250 and others point to the need for a test suite and robust set of test vectors
Questions:

Who do we think has the most “conformant” implementation that would be a good starting point to test against?
Sphereon has a lot of great test cases. Do others? Can we use these as starting points?
Do we have any nice patterns to follow for existing/similar test suites we can model it on?

References:

https://www.npmjs.com/package/@sphereon/pe-js
https://github.com/hellobloom/ssi-sdk/tree/feat/presentation-exchange-functionality/dev/packages/presentation-exchange

Dupe of #65. moving additional comments there


feat: Better support errors on the forgot password page

Hi everyone,
Here is a fix for the forgot password page, with:

A correct message if the email/username is invalid
If there is an error on the server

⚠ However, for now, there is still an issue (and I don't know why) because the server doesn't return the correct message.

Please DO NOT merge this PR.
We need a new version of the Dart package, as there is an important issue: https://github.com/openfoodfacts/openfoodfacts-dart/pull/779


Show Popup Menu with left click

Hi,
Currently, the tray icon shows the menu only when right-clicked. How can we change this behavior so that it does the same with a left click.
Thanks

@hrzafer - Which operating system are you using? If you're using a mac, try clicking with left and right buttons at the same time.

I'm using Windows 11. FxTrayIcon works as expected. My question is can I make it show the menu with a left-click instead of a right-click.

No, I believe it is a limitation in AWT ... well... you COULD get it to work with the jeft button, but you would need to running MacOS.  ;-)

Closing due to the further discussion and explanation on this subject on Issue #30. Any updates will be provided on that issue.


Add a way in both the Gradle and Maven plugins to run the test resource service as a non-daemon process

Feature description
Currently running mvn mn:start-testresources-service exits and the service is left running as a background process. What I want is for this to behave like mvn mn:run where exiting the test resource service is a matter of hitting CTRL+C

There's already the foreground property in Gradle to do this.

does it work in Maven?

I don't think it has been implemented in the Maven plugin


Fix disabled style on StreamField add button

Fixes #9512
An opacity: 0.2 style is defined for the disabled button state, but the opacity: 1 hover style takes precedence over it. As a result, the only time it kicks in - on media with hover support - is when the StreamField does NOT have hover / focus, which would ordinarily be the time when the button is hidden entirely.
Fix this by adding hover states to the &[disabled] case, to match the order of precedence for the normal button state.

Merged in 5703bc11337c723dfb313a60516704e885b1559e (main) / 74bbcbc767ef88638439ff2228751a6eb4ce00f4 (stable/4.1.x).


Bug 1891898: Set default, min, and max values on Webhook ports

Problem: Operator Authors can create CSVs that define Webhooks with
containerPorts set outside the range of 1-65535, which prevents the
ValidatingWebhookConfiguration or MutatingWebhookConfiguration from
being created due to failed validation.
Solution: Update the CSV's CRD Validation to include the proper min and
max values for webhookDescription ContainerPort field. If the
containerPort is not defined, default to 443.

/cherry-pick release-4.6

/lgtm