[Feature Request] On-disk files compression

It'd be nice to store files on-disk in compressed form to save some disk space/cost. I guess compression support is already there as Kafka can do few compression methods on topics. So may be just need to expose few config options (or maybe it's already there just undocumented).

I am not sure if this should be part of Kafka Backup. There are so many ways to do this (wrong) and it depends heavily on your use case 🤔
This is basically the same as with Kafka: should we really do the encryption ourselves or should we better relying on the underlying systems (OS level encryption, encryption provided by S3 et al)

Oh, sorry, commented on the wrong issue. Will comment on this one later ;)

I See this as a very useful feature. We need to think about a way to implement this nicely. Therefore I have opened a general architecte discussion issue in #31


RecyclerView dataset change, the Placeholder should not show all

Hi,florent,
I have RecyclerView in one pager
and the viewpager behaves sticky toolbar
I scroll the recyclerview to some position but not the start, so the placeholder is hide,
then I change the dataset and call the adapter notifyDataSetChanged().
the PlaceHolder in recycerview shows all its size,not part.
It should hide itself, and let the item under it adjust to the pagerstriptab.
thanks!

you have to call notifyDataSetChanged on the MaterialRecyclerAdapter and your Adapter.
I can't override the notifyDataSetChanged() of the MaterialRecyclerAdapter because it's declared as final...

thank you! this works~


adapt swift 5

Hi, thank You for your contribution, I will merge these changes to develop branch and these will in into the master with other changes)


[Improve] [Hadoop] Fix Hadoop shade jar not build in binary package.

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

I will fix this bug. Can you close this pr?


Fix #2439 by Updating deregister_cmd.go

This PR is a

[ ] Feature Implementation
[x] Bug Fix
[ ] Documentation

What this PR does / why we need it:
Solve the Issue 2439
Which issue(s) this PR fixes

Fixes #2439

/assign @carolynvs

@AdamDang The PR title and description don't match the code fix provided by this PR. The help text is incorrect using --cluster instead of --scope=cluster, however that doesn't have anything to do with the linked issue.
Are you okay with me cleaning up the title and description of your PR to match the fix, or did you intend to fix that bug mentioned in the linked issue?
/hold

Hi @carolynvs , I think that this issue #2439 is not a bug.
svcat deregister email-worlds-simplest-service-broker

because this command can not deregister a cluster broker.

Thanks @carolynvs
It's my fault, I confirmed that the change in this PR could not solve the mentioned issue.
So can I close it now?

No worries!


Showing "[!div class="mx-imgBorder"]"

en-us: "https://docs.microsoft.com/en-us/dynamics365/customer-insights/audience-insights/sample-guide-predict-transactional-churn"

#PingMSFTDocs

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e2065c4-2352-9798-26bb-f1e3577bcb98
Version Independent ID: ecaf414a-0916-389e-8347-ab053ceaea86
Content: Transactional churn prediction sample guide - Dynamics 365 Customer Insights
Content Source: ci-docs/audience-insights/sample-guide-predict-transactional-churn.md
Service: customer-insights
Sub-service: audience-insights
GitHub Login: @diegogranados117
Microsoft Alias: digranad

Thank you for reporting the issue @hyoshioka0128. It's fixed now and the div tag is no longer showing.
Please keep your feedback coming. I'll close this issue and look forward to hearing from you again.


Fix WebviewElement::streamToBuffer

This PR fixes loading webview resources when running vscode server
Related https://github.com/microsoft/vscode/commit/256cc1d63ac28fd0b0e8af0e96a19a5fa1f8b366
cc @mjbvz

@mjbvz vscode web is not affected as this code path is not executed, resources are loaded from hosting server directly http://localhost:8080/static/sources/extensions/simple-browser/media/codicon.css
For vscode server resources are loaded from code server itself https://vscode-remote+localhost-003a9888.vscode-resource.vscode-webview.net/home/jeanpierre/gitrepos/vscode/extensions/simple-browser/media/codicon.css

Using a web client, the current code works on both serverless and when connected to a server
Using a desktop client, it work with local files and connected over ssh to a workspace
What am I missing?

@mjbvz it's not working when connected to a server, I tested using chrome and firefox in Ubuntu. Here's a gif showing the error (which is silently ignored in the catch clause):

Ok thanks, yes I see this on Chrome. Not sure why it seems fine on safari in my testing


We don't want to have <<~ style multi-line everywhere since it breaks up logging

rubocop:disable Metrics/LineLength some of the lines, and rewrite others to work with our new line length requirements.

cc @AndrewMcBurney

so bold


clang: add clang to the set of builders.

Signed-off-by: Ronald G. Minnich<EMAIL_ADDRESS>

I can not BELIEVE that worked.

-2

Ok for me.
HARVEYCC
HARVEYLD
etc.


unable to create a new index on property after drop of previous

OrientDB 3.0.0-SNAPSHOT

start the server
download the movies rating db
drop the index on title for class movie
try to create a lucene index on title
got:

com.orientechnologies.orient.core.index.OIndexException: Cannot create the index 'Movies.title'
 DB name="MovieRatings"
 --> com.orientechnologies.orient.core.exception.OStorageException: File with given name already exists but has different id 73 vs. proposed<PHONE_NUMBER>526775893
 DB name="MovieRatings"

Retested with latest snapshot of the distribution, works fine


1.19 support

Hi, I've been using this mod for a while and I want to use it on 1.19 so yeah any chance that it will be updated soon?
I'm aware that now you cant change the gamma above the limit so if it affects the mod I would understand if it will take longer but Im curious how much lo?

1.19 version should be out by Tuesday!

Updated to 1.19!


[DX] Lead Ammit to be dependency free - Scalar I

Rebund of https://github.com/imediafrance/ammit/issues/38
TODO

[ ] Validate Array without beberlei/assert

Refactor Pure\ArrayValidatorTrait
Like Imedia\Ammit\DomainUuidValidation

[ ] Validate Boolean without beberlei/assert

Refactor Pure\BooleanValidatorTrait
Like Imedia\Ammit\DomainUuidValidation

I'm a little confused... Your link lead to MailMxValidation, which is not dependency free...

So true indeed..
In a 1st step we could remove the Assert assertions usage. But still throw Assert\InvalidArgumentException.
And then in #38 replace all Assert\InvalidArgumentException usages by our own exception.
What do you think ?

@Tartare2240 Good catch https://github.com/imediafrance/ammit/pull/53


Transaction or Address description

It would be helpful to be able attach a small comment or description to a transaction or an address. Note this is different (and likely faster to implement) than labeling, see #59 for this.
Some open questions:

In #59 i mention that Jimmy and @kloaec think it makes more sense to label by address instead of transaction. @edouardparis mentioned to me today he was thinking we should support both. Should we support attaching a description to a transaction? (As in a Bitcoin transaction, not as in a payment / financial transaction)
Should we attach a description to our addresses? External addresses? Both? If so should we separate them somehow?

I think it makes sense to have a coin-oriented UI on the wallet. In this spirit it makes sense to be able to attach a small description to a coin. Alex pointed out it is useful to be able to effectively choose coins during the spend tx creation process.

@darosior I really like this "coin-orientated" framing and i think it makes sense for Liana, more than any other wallet.
But let's say I labeled a coin as "Salary from January" and then I spend half of it, this will create a new change-coin.
Should this change coin still be labeled Salary from January?
Should it inherit this label, but with a greyed-out color?
Should the wallet add a change tag in front of it to know its change from "Salary from January"?

No i don't think labels should ever be arbitrarily transferred from a spent coin to a created coin in a transaction.
This does make me think perhaps we should label coins and not addresses. So you can attach a label to a coin in the coins list.

xref https://github.com/wizardsardine/liana/pull/605

We are going to have what we call "labelling" support in v3, but that's essentially what the OP describes: a small sentence describing an output, a transaction or an address. I'm going to close this, if we want to improve over the current situation let's revisit this in a new, updated, issue.


Supporting netcoreapp2.0 again

Hi,
At one time this library used multi-targetting to support both .Net standard 2.1 as 2.0
I see that this has been changed so supposedly add support to .Net 5.
I'm no expert on the matter but if I understand correctly there is no reason this codebase can't be compiled against multiple target frameworks.
<TargetFrameworks>netstandard2.0;netstandard2.1;net6.0</TargetFrameworks>
This seems to build just fine.
For the project i'm currently working on we are stuck on .Net 4.7 so targetting netstandard2.0 would mean we could use the lastest version.

I second this! Would be great to have it available for netstandard2.0


Add option to send position in update_state during simulation

Waiting for #39

As stated in #39
the position is appended to the odor observations and sent to the agent in the update_state function


Add PHP 7.1 support

I've added some kind of mix of official PHP 7.1 Alpine FPM Dockerfile and Wodby's 7.0 configuration.
You can test prebuilt image with https://hub.docker.com/r/mastersland/php-fpm.

@id-tarzanych thank you very much, I'll review it.


C88703: Changing codeblock style to avoid issues on Localized pages

Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.

Docs Build status updates of commit 530744c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

project-rome-docs/objectivec-api/remotesystems/MCDRemoteSystemWatcher.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

#sign-off


feature: Better coloring as eyelilner.nvim

Did you check the docs?

[X] I have read all the flash.nvim docs

Is your feature request related to a problem? Please describe.
no, but kinda of for autism
Describe the solution you'd like
use eyeliner IDEA of making things POP more , by adding RAINBOW 🌈  colors
having Plain colors isn't that good and its boring :(
Describe alternatives you've considered
no
Additional context
thx for the plugin tho

I don't use eyeliner myself, but this seems to be a very different plugin than flash. It highlights unique letters in for the ftFT motions.
I also don't really see anything mentioned regarding rainbow colors?

@folke i understand the thing ,
but i just said, getting rainbow color🌈  would be making stuff eASY to fucos on some expectes


Add logic to trigger deployment on each terraform apply

Add the logic to the resource "terraform_data" "trigger_code_deploy_deployment" {} to be triggered each time the resource local_file.code_deploy_sh is updated.
This is done by adding the below code block:
  lifecycle {
    replace_triggered_by = [ local_file.code_deploy_sh ]
  }

More info at https://developer.hashicorp.com/terraform/language/meta-arguments/lifecycle#replace_triggered_by

adding the replace_triggered_by did not redeploy this resource on a subsequent terraform apply after the first terraform apply was run. I believe that is because of the property triggers_replace = local.script in resource "terraform_data" "trigger_code_deploy_deployment" {}. Hence re-opening the issue.

In the resource "terraform_data" "trigger_code_deploy_deployment" {} commenting out the triggers_replace property to force the replace_triggered_by property to take effect did not work. Hence, the final attempt is to enable triggers_replace = local_file.code_deploy_sh


ERRO Failed to submit a solution

Dec 11 23:37:39.074 ERRO Failed to submit a solution: Object({"code": Number(-32502), "message": String("Failed to validate solution")})
when i run grin-miner, i got this error, and i don't know how to fix it , help me !!!
and i have other question:

how to run the grin wallet listen in backgrounder?
run the grin-miner backgrounder?

shouldn't happen anymore using default plugin configuration


StateNotifierProvider.family.autoDispose causes grey screen on Flutter Web (Release build)

Describe the bug
I am not sure this is a Flutter bug or Riverpod bug.
When using StateNotifierProvider.family.autoDispose, it causes a grey screen on Flutter Web. Only happens on Release build, Debug is fine. If I don't use autoDispose it is also fine. I think I didn't experience this before the family.autoDispose style new syntax. My current work-around is not to use autoDispose.
I get this on the web console:
Another exception was thrown: Instance of 'minified:iu<void>'
Possibly related:

flutter web : Another exception was thrown: Instance of 'minified:aM'
How to fix the “minified:aq” flutter web error

In my case, it was an static method uninitialized unexpectedly that triggered this issue. Seems like a webdev bug , only failed on web release build.

To Reproduce

use StateNotifierProvider.family.autoDispose
build with flutter web release mode

Regards
Using:
Flutter 1.21.0-1.0.pre • channel dev • https://github.com/flutter/flutter.git
Framework • revision f25bd9c55c (3 weeks ago) • 2020-07-14 20:26:01 -0400
Engine • revision 99c2b3a245
Tools • Dart 2.9.0 (build 2.9.0-21.0.dev 20bf2fcf56)

This is a bug in  dart2js https://github.com/dart-lang/sdk/issues/41449
Try upgrading your sdk to the latest version possible

I will close this as it isn't an issue with Riverpod but the Dart SDK. If the issue persists, ping the Dart team on https://github.com/dart-lang/sdk/issues/41449

Has anyone found a workaround? I'm on a pretty recent version (1.22.0-1.0.pre) but I am still having the exception on web.
I saw a comment here https://github.com/dart-lang/sdk/issues/41449#issuecomment-655654274 but was unable to get my build working properly. I may not be understanding their exact recommendation though.

There's a workaround here: https://github.com/rrousselGit/river_pod/blob/master/examples/marvel/lib/src/screens/character_detail.dart#L36

Great, thanks!

when we use useListenable in release mode it seems to drop some type also.

when we use useListenable in release mode it seems to drop some type also.

Currently facing the same issue. I only get this issue when trying to run it in production. Any update on this?

Instead do AutoDisposeStateNotifierFamily for now.
The bug is in Dart. I can't do anything

Instead do AutoDisposeStateNotifierFamily for now.
The bug is in Dart. I can't do anything

This doesn't work in:
Flutter 3.3.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision eb6d86ee27 (9 days ago) • 2022-10-04 22:31:45 -0700
Engine • revision c08d7d5efc
Tools • Dart 2.18.2 • DevTools 2.15.0

The only thing that appears to work is removing the autoDispose entirely.


feat(Box): Temporary Box component

Overview
Temp Box component made for new curriculum cards.
Supports 3 variants and 2 hover states.   This is a hold over until https://github.com/Codecademy/client-modules/pull/953 is in alpha.
import { Box } from '@codecademy/gamut-labs';

<Box>Boxing Day</Box>

PR Checklist

[ ] Related to Abstract designs:
[ ] Related to JIRA ticket: ABC-123
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

Description

📬Published Alpha Packages<EMAIL_ADDRESS>
📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f63cfb23c135a4b09c060f9--gamut-preview.netlify.appDeploy Logs


fix: bumped up version for release

Codecov Report

Merging #26 (7dd8884) into main (abace4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   91.64%   91.64%
=======================================
  Files           7        7
  Lines        1376     1376
  Branches      198      198
=======================================
  Hits         1261     1261
  Misses        114      114
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abace4e...7dd8884. Read the comment docs.


Update profile photo

Related Issue https://github.com/WildAid/o-fish-ios/issues/400
https://user-images.githubusercontent.com/52383559/163564615-843fc003-79d0-41df-882e-f3ee08bf6404.mp4
Checklist:

[x] I have read the contributor's guide.
[x] I linked an issue in the previous section
[x] I have commented on the linked issue
[x] I was assigned the linked issue (not required)
[x] I have tested the change to the best of my ability against the sandbox or a local build.

If a picture exists, this works great!

Hi @Dmitriy-Holovnia - can you look into the case when there's no existing picture?

Hi @Dmitriy-Holovnia - can you look into the case when there's no existing picture?
Hi @Sheeri!
Fixed.


remove express version from Hello World example

can the version in the hello world example be eliminated
in the docs show like this
const express = require('express'  4.16.4)
and only works like this
const express = require('express')

This is about copy and paste from Runkit. cc @boucher

Or maybe not. When I copy and paste, the version number is not included. @geocodinglife are you just typing it as you see it displayed? I agree it is confusing for users who don't know that's not actually part of the source code.

As far as I can tell, there is no option to turn off this version display in RunKit.

We can certainly add an option to disable the version if you guys don't want it, I do however want to point out that you can alternatively currently modify the style of it I believe (I think our theming lets you change the color, etc). Most everyone that uses this really likes that feature so we'd only be adding it for this use case as far as I know, so want to make sure this is something you all for sure want before going through with it (but again, its certainly not hard for us to add if you deem it absolutely necessary, just coming from an over-configuration API perspective, and also from the angle of the alternative styling options). We're also open to anything else that would make it even more obvious that it is not a part of the source text.

Hi @tolmasky thanks for weighing in :) So there are a lot of users who enter in to Node.js through Express.js, so it isn't surprising to see this as a confusion point. I just was searching through the history of our Gitter and I see it's been mentioned several times since the RunKit has landed.
I was not aware of the custom styling option. I looked at the docs for the embed and didn't see it mentioned anywhere (https://runkit.com/docs/embed) and since it's within a iframe, the styling can't just be added to our site's stylesheet, right?
Really, I think from this report, and from the stuff I'm seeing on Gitter, I think it would be best for this very early on in the experience example to work when someone types it out from what they see on the display.
I thought of three possibilities here, but there could be others:

Just remove the version number (option, custom style, however, as long as someone can point us to the how to for that)
Just wrap the verion number in a block comment (i.e. the line would read var express = require('express' /* 4.16.4 */);
Move the version to the end of the line as a line comment (seems more complicated to implement that (2) perahps (i.e. the line would read var express = require('express'); // 4.16.4).

Thoughts?

Just discussed this with the team -- we mocked out the comment version but I think it might still be confusing since you wouldn't be able to select it (and if you could select it, then we wouldn't let you edit it, etc.), so just having a way of removing it seems best here.
Just for a sense of our timeline, we're currently close to rolling out a big performance change for embeds in the upcoming weeks. Separately, we were already planning on unrelated customization options for the version pill which this might be able to be rolled into, so I think I safe estimate for when you can turn this off would be December. We figure that worst case scenario if we haven't found an "elegant" place to put this customization option by December, we can just quickly throw it into its own custom bool and ship it out quickly for you all then. We can go ahead and issue the PR at that point to so we can keep tracking this bug.
Let me know if all that sounds reasonable!

Hello all,
While I know the version number still appears in the RunKit embed window, there still is no way to change this from the expressjs.com end in the embed. I'm going to close this as there just isn't any action we can take on our side for this issue. If there ever becomes an option to toggle this behavior, we can revisit the issue.


Deprecate usage of built-in cucumber wire protocol

Description
This is related to https://github.com/cucumber/cucumber-ruby/pull/1562
It is planned to remove the built-in support for cucumber-ruby-wire. It will still be available but as an optional plugin.
Before removing the support for it - which is done in #1562 - we need to deprecate it. A deprecation process should last for 2 major releases at least: the once which announce the deprecation, and the one which drops the deprecation.
So that deprecation should be part of an incoming cucumber-ruby 8.0.0, for #1562 being part of 9.0.0
Type of change
Please delete options that are not relevant.

Breaking change (will cause existing functionality to not
work as expected)

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

[x] Tests have been added for any changes to behaviour of the code
[x] New and existing tests are passing locally and on CI
[x] bundle exec rubocop reports no offenses
[x] CHANGELOG.md has been updated
[x] Update cucumber-ruby-wire readme to explain how to migrate from built-in to plugin
[x] https://github.com/cucumber/cucumber-ruby-wire/pull/46 is merged

Once https://github.com/cucumber/cucumber-ruby-wire/pull/46 is merged, this one will be ready too I guess

I think we can release the deprecation notice in a minor release, so 7.1 rather than 8.0. See the advice here from the semver docs:

Before you completely remove the functionality in a new major release there should be at least one minor release that contains the deprecation so that users can smoothly transition to the new API.

(emphasis mine)

I think we can release the deprecation notice in a minor release, so 7.1 rather than 8.0. See the advice here from the semver docs:

Before you completely remove the functionality in a new major release there should be at least one minor release that contains the deprecation so that users can smoothly transition to the new API.

(emphasis mine)

The change of the "AfterConfiguration" hook: is it a breaking change? If so, that mean we should release it as 8.0.0?

The change of the "AfterConfiguration" hook: is it a breaking change? If so, that mean we should release it as 8.0.0?

OK I understand now. Yes, if we're changing the AfterConfiguration hook's parameter signature that's a breaking change so we'd need a major release.
I have some concerns about exposing that whole Cucumber::Glue::RegistryAndMore object. The reason it has that silly name is to make it clear that it has too many responsibilties. Many of the methods on that class are really internal Cucumber stuff, so I suggest we wrap it with a Facade to limit the surface area we're exposing to users.

The change of the "AfterConfiguration" hook: is it a breaking change? If so, that mean we should release it as 8.0.0?

OK I understand now. Yes, if we're changing the AfterConfiguration hook's parameter signature that's a breaking change so we'd need a major release.
I have some concerns about exposing that whole Cucumber::Glue::RegistryAndMore object. The reason it has that silly name is to make it clear that it has too many responsibilties. Many of the methods on that class are really internal Cucumber stuff, so I suggest we wrap it with a Facade to limit the surface area we're exposing to users.

Done
Deprecation planned for v8.0
Removal for v9.0
I've also added a new RegistryWrapper which exposes only what was needed by the wire plugin: create_expression and current_world

On a side-note, probably not for here. We also should look into creating an alias for this for v8 - BeforeAll, and removing the name, because it's such a confusing and non-standard name.

On a side-note, probably not for here. We also should look into creating an alias for this for v8 - BeforeAll, and removing the name, because it's such a confusing and non-standard name.

You mean, renaming the BeforeAll hook? (deprecated in v8, removed in v9?)

Renaming it "to" BeforeAll yes.
Duplicate them in v8, in v9 remove AfterConfiguration

Ok got it, thanks

I've also added a new RegistryWrapper which exposes only what was needed by the wire plugin: create_expression and current_world

Great. Even those two methods look like very different responsibilities, and I'm very curious why we need to be passing around a reference to the current_world but I think that's a rabbit hole we don't want to go down right now. Limiting this API surface seem good enough for now to me.

I've also added a new RegistryWrapper which exposes only what was needed by the wire plugin: create_expression and current_world

Great. Even those two methods look like very different responsibilities, and I'm very curious why we need to be passing around a reference to the current_world but I think that's a rabbit hole we don't want to go down right now. Limiting this API surface seem good enough for now to me.

This is because wire instantiate a Cucumber::StepMatch object: https://github.com/cucumber/cucumber-ruby-wire/blob/c3b537064a73db67c8ad9e9dab905e4cfdf700bf/lib/cucumber/wire/protocol/requests.rb#L37
That object requires the current_world which it retrieves from the registry: https://github.com/cucumber/cucumber-ruby/blob/3b0385233284815e720aec4abc030fa4f96d8423/lib/cucumber/step_match.rb#L18

I've also added a new RegistryWrapper which exposes only what was needed by the wire plugin: create_expression and current_world

Great. Even those two methods look like very different responsibilities, and I'm very curious why we need to be passing around a reference to the current_world but I think that's a rabbit hole we don't want to go down right now. Limiting this API surface seem good enough for now to me.

This is because wire instantiate a Cucumber::StepMatch object: cucumber/cucumber-ruby-wire/blob/main/lib/cucumber/wire/protocol/requests.rb#L37
That object requires the current_world which it retrieves from the registry: ./lib/cucumber/step_match.rb#L18

Aye, I see that.
It just feels wrong for me for the StepMatch to be carrying around a (mutable) reference to the current world. It would make more sense to have whoever calls args pass in the current_world instance at the time it calls that method. But as I say, this is a rabbit hole I don't think we want to go down right now.


Delete a Mark

Currently, there is no way to delete a Mark/Chord in the Song editor. We should add a delete button in the popup menu for editing a marking. Maybe just right at the bottom a button that says "🗑 Remove" or something small.

Solved


Make error messages more generic

You're disclosing a lot of information currently when a user tries to do log in, reset, etc.
Example: https://github.com/cheeseytoastie/UmbMembersFullTutorial/blob/master/Controllers/Account/MemberRegisterSurfaceController.cs#L36
Great, now I know that a certain email address has an account on this site, now I can start sending them phising mails. Or maybe they might be embarrassed to be a member on that particular site. This is all described here: https://www.troyhunt.com/everything-you-ever-wanted-to-know/

I've added a comment for now that this is NOT best practice.. I think you're right and when I get time I'll update the blog post so we can send a different "You're already registered you banana" style email.

Fixed and checked in.


update english readme，change style in phone and add zoom demo

well done

But you commit  .DS_Store file, that is no need


Secured params and Added additional TVM API call.

Required items, please complete
Change(s):

Secured the Logic Apps parameters so the secret is not exposed in clear text after deployment.
Removed "UserName" ARM parameter and hardcoded generic display name for Log Analytics connector to remove confusion.
Added additional TVM API call to get additional information into Log Analytics.

Reason for Change(s):

Secrets in clear text is not a good idea.
Critical TVM information was missing from the solution.

Version Updated:

N/A

Testing Completed:

Yes, deployed in test environment and confirmed data was getting ingested into Log Analytics.

Checked that the validations are passing and have addressed any issues that are present:

No KQL or YAML.

@microsoft-github-policy-service agree

Additional requirements being worked on. Will submit when complete.


Unable to install ungoogled Chromium

I am using the official supported opensuse repository and I am getting the following installation error
:: Synchronizing package databases...
 core is up to date
 extra is up to date
 community is up to date
 multilib is up to date
 home_ungoogled_chromium_Arch is up to date
:: Starting full system upgrade...
resolving dependencies...
looking for conflicting packages...

Packages (1) ungoogled-chromium-93.0.4577.82-2

Total Installed Size:  231.17 MiB

:: Proceed with installation? [Y/n]
(1/1) checking keys in keyring                          [#############################] 100%
error: ungoogled-chromium: unsupported signature format
(1/1) checking package integrity                        [#############################] 100%
(1/1) loading package files                             [#############################] 100%
(1/1) checking for file conflicts                       [#############################] 100%
(1/1) checking available disk space                     [#############################] 100%
:: Processing package changes...
(1/1) installing ungoogled-chromium                     [#############################] 100%
Optional dependencies for ungoogled-chromium
    pipewire: WebRTC desktop sharing under Wayland [installed]
    kdialog: support for native dialogs in Plasma
    org.freedesktop.secrets: password storage backend on GNOME / Xfce [installed]
    kwallet: support for storing passwords in KWallet on Plasma [installed]
:: Running post-transaction hooks...
(1/3) Arming ConditionNeedsUpdate...
(2/3) Updating icon theme caches...
(3/3) Updating the desktop file MIME type cache...```

The installation itself should still work regardless of the error. See #148


Add support for Image element

There is currently no Image element meaning is an image isn't within a UIView or other container, it can't be found on the screen.
I have some code ready for this issue

Fixed in 1.6.0


Add documentation

Actually, I'm not sure we need additional docs after #27

Might be worth updating the README with a basic example under the Usage section. The specs are pretty comprehensive too, so maybe not as needed.


Fixed #21734 -- Handled ProtectedError on POST to admin's delete_selected action

https://code.djangoproject.com/ticket/21734
Approach is similar to that used to solve #26235 in https://github.com/django/django/commit/49ac10b4de03279da9d67aeac5cb8561fc055085.

Done.

merged in a7c813ba045044ec23bb656ef9a23a0e38e36514, thanks!


Array.map typechecking issues, doesn't typecheck what the .map callback returns

TypeScript Version:  reproducible in at least 3.3.3333 and above
Search Terms: Array map generic extra property
Code
type Token = {
    value: string
}

const things = ['one', 'two'];

// using .map generic — doesn't fail typechecking
function getTokens1() {
    return things.map<Token>(thing => ({
        value: thing,
        // should say `somethingElse` does not exist on type `Token`
        somethingElse: true
    }));
}

// using return type — doesn't fail typechecking
function getTokens2(): Token[] {
    const tokens = things.map(thing => ({
        value: thing,
        // should say `somethingElse` does not exist on type `Token`
        somethingElse: true
    }));

    // type of tokens is reported as `{ value: string; somethingElse: boolean; }[]`
    // so how could it be compatible with `Token[]`?
    return tokens;
}

// following use cases as working proofs and potential workarounds

// fails typechecking correctly
const token: Token = {
    value: 'one',
    somethingElse: true // `somethingElse` does not exist on type `Token`
};

// fails typechecking correctly — potential workaround
function getTokens3() {
    // note the `Token` inline return type
    return things.map((thing): Token => ({
        value: thing,
        somethingElse: true // `somethingElse` does not exist on type `Token`
    }));
}

Expected behavior:
I would expect in getTokens1 using the .map<U> generic form that it would typecheck what .map returns. Similarly, I would expect in getTokens2 that it would complain as I am precising the return type of the function and the inference itself seems to show an incompatible type.
Actual behavior:
It doesn't seem to typecheck properly when using Array.map.
Playground Link: See above example in playground
Related Issues:

<EMAIL_ADDRESS>Not a bug then?

I’m not sure why the first case isn’t an error (it seems like it should be, you’ve explicitly provided the result type for map and the object literal is still fresh when returned), but the second case is expected.  See my comment here re: structural typing: https://github.com/microsoft/TypeScript/issues/31412#issuecomment-493094951

Duplicate #241


add URL typing to webworker

URL is also available in worker. (URL IDL spec). Fix https://github.com/Microsoft/TypeScript/issues/14878.

WIP:

URL tying is already defined in inputfiles/browser.webidl.xml#L11367-L11395, so it is only need to added to worker. So I added "flavor": "Worker", but it seems doesn't work.(same as "flavor": "All" for URLSearchParams) 😅
I'm not sure whether the URL and URLSearchParams should be added to WorkerGlobalScope.  It is signed as Exposed=(Window,Worker) in the spec IDL
The spec IDL use USVString, but I use string here (keep it same as previous added URLSearchParams typing). Doesn't it matters?

@VincentBel,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@VincentBel, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

@mhegazy updated. But ci is still failing. I have see some other PRs, and they seems failed with the same error.

thanks!


Need to add in some Logging

As simplistic as the application is, I should add in some logging for when things fail.

Logging was added in Commit b8241b4


add scalar load support for advanced path

Do you think is worth adding a lit test or modifying an existing lit test to cover this case?

too trivial to add a lit IMO


Confusion between “submitter input” and “justification”

from discussion with @maccraymer

Agree to just use "justification". Thanks!


Fix issue with GCC and c++11 features

GCC 4.6 (used by Travis CI) does not recognize c++11. Instead
it uses c++0x, which does not support the "override" keyword.
As a result, the following patches remove c++11 to support
Travis CI, as well as the override command.
Note: These changes are only needed for the native compiler.
Cross-compiled code will use GCC 5.2 and above which has
support for c++14.
Signed-off-by: Rian Quinn<EMAIL_ADDRESS>

LGTM


Clicking above headline scrolls to headline

While reading documentation I sometimes mark important words for me with the cursor.
If I try to mark some words in the last line before a headline I always click on the invisible anchor of that headline.
Why does the anchor of the headlines overlap the last line of previous text?
Is this the intended behaviour?
The problem is here

It's intended that those anchors overlap, so that hash scrolling still works with the sticky header. The previous text should be the top layer though. Can you share more about the OS and browser you're seeing this on?

Ok. I see. OS is macOS Sierra and browser Chrome 54.0.2840.98.
But I saw this issue on Firefox and Safari as well.
Maybe it's just me. But I think marking text while reading it is a common behavior.
It's somehow like reading with the finger under the current line.
As you said the text is indeed the top layer. But if I start marking from below (e.g. here from under the link "Comparison with Other Frameworks" in the last line) I click on the link and intentionally the content jumps.
I really wouldn't bother, but it happens to me all the time.
I have a similar issue while reading articles on medium.com where I mark the text and click on the share popup sometimes. But the click area for the share links there is compared to the text anchors in the docs very small so a not intended click doesn't happen so often.

@dpschen OK, I've kept this in the back of my mind and just deployed a tiny hack that should add a bottom margin to paragraphs and lists, making them easier to select. Would love to hear how it helps!

Awesome works! =) thx


documentation

Any good library needs documentation. We got a readme in #70, but that's rarely enough.

For the API, how about using sphinx-autoapi?
We can then add installation instructions and a tutorial. How does that sound?

@keewis I started a draft PR for the doc. Happy to get feedback on the organisation, content, etc. https://github.com/xarray-contrib/xdggs/pull/80

thanks, I was about to open a PR for the API documentation. I'll try to get that in first, and we can then adapt whatever you have already.

Ok. I added autoapi. Maybe it is not good enough. It works locally.
On Wed, 23 Oct 2024 at 11:38, Justus Magin @.***> wrote:

thanks, I was about to open a PR for the API documentation. I'll try to
get that in first, and we can then adapt whatever you have already.
—
Reply to this email directly, view it on GitHub
https://github.com/xarray-contrib/xdggs/issues/76#issuecomment-2431507341,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6KIPB7IO6KEHQUDRWON4TZ45VCVAVCNFSM6AAAAABQBRKTIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRGUYDOMZUGE
.
You are receiving this because you commented.Message ID:
@.***>


annotatevariants table bug

hail: warning: `ESP_counts2.txt' refers to no files
hail: annotatevariants table: caught exception: next on empty iterator

Resolved.


netlify preset: [nuxt] [request error] [unhandled] [500] Cannot find module '@vue/devtools-api'

Environment
Nitro v2.10.3
Nuxt v3.14.159
Reproduction

Deploy nuxt project using netlify preset
Access non pre-rendered route

Describe the bug
Deployed nitro server using netlify preset fails on first request with
Nov 11, 11:07:42 PM: 7182da0a ERROR  [nuxt] [request error] [unhandled] [500] Cannot find module '@vue/devtools-api'
Require stack:
- /var/task/.netlify/functions-internal/server/server.mjs

Error changes on second request to:
Nov 11, 11:08:02 PM: c36ce405 ERROR  [nuxt] [request error] [unhandled] [500] _createApp is not a function

Additional context
See https://answers.netlify.com/t/functions-cannot-find-module-vue-devtools-api/129081/2 -- they solved the issue by downgrading nitro.
Installing @vue/devtools-api package does not fix the issue.
Error does not happen using netlify-legacy preset.
Error does not happen when using nuxt dev, only when built and deploying in production. Building for production (nuxt build) and running function server locally (netlify functions:serve -f .netlify/functions-internal) works.
Logs
No response

I managed to solve the issue by explicitly adding the vue and vue-router as dependencies to my nuxt project (https://github.com/nuxt/nuxt/commit/e473aff58f88e881adeea9a58bf3f136866c29d7 made me check).

@danielroe Any suggestions? :)


DBZ-7016 id and type of a CloudEvent can be retrieved from headers

https://issues.redhat.com/browse/DBZ-7016

@rkudryashov Thanks for the PR. I've slightly different proposal for configuration so please let me know it is something you'd consider

MetadataLocation will become three-state, adding generate
the value of metadata.location will change. It will support global setting - only HEADER/VALUE supported and then there will be the name of field to be taken followd by the source, so example of the config would be metadata.location=value,id:header,type:generate. WDYT?

@jpechane LGTM

Please squash the commits when the PR will be ready for merging

@jpechane this is ready

@rkudryashov I think it i good. I like the solution. My only last comment is if there is a way how to get rid of all of those if (metadataLocation.global() == MetadataLocationValue.HEADER)?

@jpechane done
On Tue, Oct 17, 2023, 14:37 Jiri Pechanec @.***> wrote:

@rkudryashov https://github.com/rkudryashov I think it i good. I like
the solution. My only last comment is if there is a way how to get rid of
all of those if (metadataLocation.global() ==
MetadataLocationValue.HEADER)?
—
Reply to this email directly, view it on GitHub
https://github.com/debezium/debezium/pull/4921#issuecomment-1766233446,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJBRVYAVFWZ4ZIZMRLERLVTX7ZUXLAVCNFSM6AAAAAA5XSGSM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGIZTGNBUGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@jpechane thanks! Moved common code to separate method
On Tue, Oct 17, 2023, 19:36 Roman Kudryashov @.***> wrote:

@jpechane done
On Tue, Oct 17, 2023, 14:37 Jiri Pechanec @.***>
wrote:

@rkudryashov https://github.com/rkudryashov I think it i good. I like
the solution. My only last comment is if there is a way how to get rid of
all of those if (metadataLocation.global() ==
MetadataLocationValue.HEADER)?
—
Reply to this email directly, view it on GitHub
https://github.com/debezium/debezium/pull/4921#issuecomment-1766233446,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJBRVYAVFWZ4ZIZMRLERLVTX7ZUXLAVCNFSM6AAAAAA5XSGSM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGIZTGNBUGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@rkudryashov Applied, thanks a lot! Could you please prepare the docs PR?

@jpechane sure, just want to make one pr to rename metadata.location ->
metadata.source to make it more semantically correct after adding third
option, "generate", and using id and type inside the property
Also, is it too late to ask you to squash the commits?
On Thu, Oct 19, 2023, 12:35 Jiri Pechanec @.***> wrote:

@rkudryashov https://github.com/rkudryashov Applied, thanks a lot!
Could you please prepare the docs PR?
—
Reply to this email directly, view it on GitHub
https://github.com/debezium/debezium/pull/4921#issuecomment-1770435929,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJBRVYANQH4BKAJ6SEDH3MDYADX75AVCNFSM6AAAAAA5XSGSM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZQGQZTKOJSHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


.NET 7.0 or later requirement incorrect.

The documentation mentions a requirement of .NET 7.0 or later. I had 8.0 installed on my computer but the application specifically asks for 7.0.
and the .NET 7.x releases have reached end of life and are no longer supported. The 8.0 branch is currently the LTS version. any chance to upgrade the application to this?

Sorry. I thought NET has backward compatibility.
The FFBitrateViewer is a bit outdated and I will need to update its dependencies as well as fix some issues. Will try to do this in nearest future.


skin changer bug?

When I used the default knife and gloves, the skin changer worked without any issues. But when I have my own knife and glove skin, even without using a skin changer. The animation of switching between weapons is abnormal and stuttered, and my own glove skin sometimes does not display

Please provide short video or gif demonstrating the issue.

Please provide short video or gif demonstrating the issue.

OK, my friend's account has gloves, he raised the issue with me, but he's sleeping now. I will let him wake up and record a video showing the problem. According to his response, his glove skin became the default skin after he died once.

It happens with me too but when i have default knife and use skinchanger for other knives like survival knife. Normal draw animation works fine but the " tossing in air and catching one" gets messed up in animation.


Bump rich from 12.6.0 to 13.0.1

Codecov Report
Base: 99.70% // Head: 99.70% // No change to project coverage :thumbsup:

Coverage data is based on head (be11e10) compared to base (76fea55).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   99.70%   99.70%
=======================================
  Files           9        9
  Lines         682      682
=======================================
  Hits          680      680
  Misses          2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Arrow elements should support arrows in any direction

Currently Arrow elements can only point along the cardinal directions.

This won't be implemented in time  1.1 but it is worth mentioning this is already possible by defining a finalize_hook:
def add_arrow(plot, element):
axis = plot.handles['axis']
   axis.annotate("", xy=(1.2, 1.2), xycoords='data',
      xytext=(1.8, 1.8), textcoords='data',
      arrowprops=dict(arrowstyle="->", color='k',
      connectionstyle="arc3"))

This code gets the axis from the plot.handles and then adds the custom Arrow annotation. You can then apply this function as follows:
%%opts Curve [finalize_hooks=[add_arrow]]
Curve(zip([0,1,2], [1,2,3]))

Or of course via the call method:
Curve(zip([0,1,2], [1,2,3]))(style={'finalize_hooks': [add_arrow]})

It should be noted that:

We need to document finalize_hooks.
The matplotlib figure is now plot.state

Looking at the current Arrow implementation it seems to be pretty closely tied to the matplotlib backend. While the bokeh backend does not currently support arrow annotations they will be adding it in the near future. I propose that in addition to allowing arbitrary directions on arrows we should remove parameters like the arrowstyle and expose style options like head_length and head_width`` instead.

I agree that Arrow is based on how matplotlib supports arrow annotations but I don't agree with deprecating arrowstyle. This is a general concept (e.g Inkscape supports different arrow heads for both single-headed and double-headed arrows) and the name arrowstyle seems perfectly appropriate.
Adding head_length and head_width sounds fine to me if we think it will be supported across backends. I am also in favor of improving the API to make it generalize better across backends but to me, arrowstyle isn't one of the things that really needs changing.
Perhaps you are suggesting making arrowstyle into a style option instead? In which case, I agree because then we can support different arrowstyles according to whatever the backend supports.

Yes at the very least it should be a style option. If we are keeping it as a style or plot option I'd at least want there to be a rough equivalence between the accepted arrowstyles across backends. It definitely should not be on the Element itself however.

It definitely should not be on the Element itself however

I'm not entirely convinced. As an annotation, what the thing looks like is part of the definition (unlike our other elements). Repeating an arrowstyle over and over again for a particular arrow seems like it would be a giant pain to me.

So then you're arguing that all backends need to support all the arrowstyles that are defined on the Element? I don't think that's practical.

No. I am arguing they should support whatever arrowstyles they can. If they have to fall back to a single arrow style (or a similar, but not quite identical) arrow style then so be it.

Okay, not a huge fan because we're letting matplotlib determine what's a valid arrowstyle but I'm happy to leave it. Just have to decide what to do about direction now, the only general solution is letting you define the start and end point of your arrow. So perhaps add a parameter that defines the starting position, which is None by default and overrides the direction if set.

Sounds reasonable to me.

Okay, not a huge fan because we're letting matplotlib determine what's a valid arrowstyle but I'm happy to leave it.

This is true for many things already. Matplotlib is what people will be familiar with and we already have utilities for Bokeh that convert from existing matplotlib concepts. We want to keep the API as consistent across backend and matplotlib is our basic, best supported (and first!) backend. As such it acts a bit like a reference backend.
Obviously, we shouldn't copy the bad bits of the matplotlib API but if a matplotlib parameter (and its values) are sensible, I don't see the problem with mirroring a convention that will be familiar to many people (with documentation online).
I also have no issue with extending the possible values beyond what matplotlib supports (say Bokeh supported more arrow styles than matplotlib did). This would be similar to the situation described in #245.

I agree with that overall assessment, Jean-Luc.

I've used this issue to create the first notebook in the holoviews-contrib repository (see ioam/holoviews-contrib#2). This notebook encourages PRs to fix this issue properly (as well as to add the missing Bokeh support).

Bokeh support is mostly waiting on standardizing on a general API that supports arrows in any direction.

http://bokeh.pydata.org/en/latest/docs/user_guide/annotations.html
bokeh has arrows in any direction
from bokeh.plotting import figure
p = figure(plot_width=600, plot_height=600)
p.add_layout(Arrow(end=VeeHead(size=35), line_color="red",
                   x_start=0.5, y_start=0.7, x_end=0, y_end=0))


WIP: feat(providers): Implement wasi:keyvalue/watch handler and provider

WIP
Feature or Problem

Related Issues
#1868
Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

@thomastaylor312 -- wasi:keyvalue/watch should have a Provider -> Component connection that will be invoked when the specific link of wasi:keyvalue/watcher interface is made, for this I am trying to implement receive_link_config_as_source for each individual provider (redis,natskv,vault), which would setup a watcher process that will wait for any changes that happens in a bucket (set and delete operations) which would trigger the on_set and on_delete calls to notify the respective component. Am I going in the right direction ?


Unable to add accessibility labels to react-native-material-ui components  for E2E testing

The appium testing framework uses accessibility labels to identify and interact with elements. The current react-native-material-ui components however do not support these labels which makes automates E2E testing difficult and sometimes impossible.

This would really help, I've also been struggling with assigning accessibility labels on the components as my e2e tests entirely depend on them. It would really be nice if I could be able to add accessibility labels

+1

+1
Has anybody figured out a workaround for this bug?  Or any ideas what a contributor needs to do to fix it?

+1
Any workaround for the e2e testing labels?

It is extremely unpleasant this problem even after 2 years ticket run still occurs.


HTTP Error 404.2 - Not Found

I am getting the following error

All of the tutorials I found say to make sure the ISAPI and CGI Restrictions are allowed. I have done that, but I still get the error.

What am I missing?

I figured it out eventually.


Settings don't work in Firefox

When clicking on 'Save & restart' on the /settings page in Firefox, the settings in the background are not changed. This at least affects changing the port and generating certificates.

The issue with "Save & Restart" on the /settings page in Firefox not updating settings is fixed. The redirect now waits for the save to complete.
The fix will be included in version 1.0.4.


support for control plane highly available

Dear folks,
Im reading through garm codebase and already spotted there’s support for MySQL. Is it enough to  configure garm as highly available control plane? my use case is on top of k8s.

It used to have MySQL, but it became somewhat difficult to maintain, so we kind of dropped MySQL support.
But if you're trying to use it in k8s, I encourage you to use the garm-operator. The operator pretty much treats GARM as stateless and syncs the sqlite DB using the info it has stored in etcd.

Great! thanks for the quick reply. I tried the k8s operator but I understood it would also require a garm instance outside of the cluster or being reachable. Is this correct?

You can have GARM run inside k8s without a problem. Have a look here:
https://github.com/mercedes-benz/garm-provider-k8s/blob/main/DEVELOPMENT.md
The  instructions use tilt to bootstrap a local development environment along with garm, the operator and the k8s provider. You can use that as a starting point and expand to other providers you may need.
We need to add some proper docs in one place that gives a nice walk-through for the various cases.

You can have GARM run inside k8s without a problem. Have a look here:
https://github.com/mercedes-benz/garm-provider-k8s/blob/main/DEVELOPMENT.md
The instructions use tilt to bootstrap a local development environment along with garm, the operator and the k8s provider. You can use that as a starting point and expand to other providers you may need.
We need to add some proper docs in one place that gives a nice walk-through for the various cases.

thanks for sharing that! would you say is the only thing and enough to start? I can improve docs once I get familiar with it

That should bring up up and running with a fully functional GARM on k8s + operator. I usually run it as stand-alone, but I did manage to get it running using that guide.
@bavarianbidi may be able to chime in with more details. His wonderful team develops the k8s integration (operator and provider)

That should bring up up and running with a fully functional GARM on k8s + operator. I usually run it as stand-alone, but I did manage to get it running using that guide.
@bavarianbidi may be able to chime in with more details. His wonderful team develops the k8s integration (operator and provider)

Are you using any specific commit? I can't get garm deployed.
garm-provider-k8s $ make tilt-up
hack/scripts/kind-with-registry.sh
No kind clusters found.
Creating cluster "garm" ...
 ✓ Ensuring node image (kindest/node:v1.28.7) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
Set kubectl context to "kind-garm"
You can now use your cluster with:

kubectl cluster-info --context kind-garm

Thanks for using kind! 😊
configmap/local-registry-hosting created
tilt up
Tilt started on http://localhost:10350/
v0.33.16, built 2024-06-07

(space) to open the browser
(s) to stream logs (--stream=true)
(t) to open legacy terminal mode (--legacy=true)
(ctrl-c) to exit

garm-provider-k8s $ git remote -v
origin	git@github.com:mercedes-benz/garm-provider-k8s (fetch)
origin	git@github.com:mercedes-benz/garm-provider-k8s (push)

garm-provider-k8s $ git rev-parse HEAD
b45a9889943b80d5d6e8222ab6c22a5f59e02157

garm-provider-k8s $ kubectl get pods -A
NAMESPACE            NAME                                         READY   STATUS    RESTARTS   AGE
kube-system          coredns-5dd5756b68-72csd                     1/1     Running   0          10s
kube-system          coredns-5dd5756b68-mmlqp                     1/1     Running   0          10s
kube-system          etcd-garm-control-plane                      1/1     Running   0          25s
kube-system          kindnet-5m6t5                                1/1     Running   0          11s
kube-system          kube-apiserver-garm-control-plane            1/1     Running   0          27s
kube-system          kube-controller-manager-garm-control-plane   1/1     Running   0          25s
kube-system          kube-proxy-r5ffl                             1/1     Running   0          11s
kube-system          kube-scheduler-garm-control-plane            1/1     Running   0          25s
local-path-storage   local-path-provisioner-7577fdbbfb-9q9ks      1/1     Running   0          10s

Garm should be deployed according to step 3) in https://github.com/mercedes-benz/garm-provider-k8s/blob/main/DEVELOPMENT.md#getting-started 🤔

I used main but you may need to add description = "garm credentials" here:
https://github.com/mercedes-benz/garm-provider-k8s/blob/main/hack/local-development/kubernetes/configmap-envsubst.yaml#L47
But other than that, I just installed, docker, kubectl, tilt, go and went through the steps.

you can also edit the existing config map:
kubectl -n garm-server edit configmap garm-configuration

and add it. Then remove the failing containers.

you can also edit the existing config map:
kubectl -n garm-server edit configmap garm-configuration

and add it. Then remove the failing containers.
At the end you should have something like:
root@garm-deleteme:~# kubectl get pods -A
NAMESPACE              NAME                                                READY   STATUS    RESTARTS   AGE
cert-manager           cert-manager-5bd57786d4-jmwdj                       1/1     Running   0          58m
cert-manager           cert-manager-cainjector-57657d5754-89fwt            1/1     Running   0          58m
cert-manager           cert-manager-webhook-7d9f8748d4-npk9b               1/1     Running   0          58m
garm-operator-system   garm-operator-controller-manager-69fbd5c478-ctlqt   1/1     Running   0          47m
garm-server            garm-server-5b84b7f66-r7mxp                         1/1     Running   0          48m
kube-system            coredns-5dd5756b68-g8k87                            1/1     Running   0          58m
kube-system            coredns-5dd5756b68-wzxwj                            1/1     Running   0          58m
kube-system            etcd-garm-control-plane                             1/1     Running   0          59m
kube-system            kindnet-7r7mh                                       1/1     Running   0          58m
kube-system            kube-apiserver-garm-control-plane                   1/1     Running   0          59m
kube-system            kube-controller-manager-garm-control-plane          1/1     Running   0          59m
kube-system            kube-proxy-jz67s                                    1/1     Running   0          58m
kube-system            kube-scheduler-garm-control-plane                   1/1     Running   0          59m
local-path-storage     local-path-provisioner-7577fdbbfb-9bpx4             1/1     Running   0          58m

Thanks for the tip about configmap. I was able to fix that part. But now Im getting a different error:
$ kubectl get pool -n garm-operator-system -o yaml

  status:
    id: ""
    lastSyncError: referenced GitHubScopeRef Organization/my-org-here not ready yet
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

I created a PAT (classical token) but not sure what's going on. I followed this: https://github.com/mercedes-benz/garm-operator/blob/main/DEVELOPMENT.md#-bootstrap-garm-server-with-garm-provider-k8s-for-local-development. Did you use a Github App for authentication?

I used PAT auth. Make sure that the PAT you're using has access to the org/repo/enterprise you're creating and that you enabled the required scopes when creating the PAT. See:
https://github.com/cloudbase/garm/blob/main/doc/github_credentials.md

ahh. I think I know what's happening. The operator is not yet updated to take into account the recent changes to GARM regarding the URLs. Try adding:
webhook_url = "http://garm-server.garm-server.svc:9997/webhooks"

here:
https://github.com/mercedes-benz/garm-provider-k8s/blob/b45a9889943b80d5d6e8222ab6c22a5f59e02157/hack/local-development/kubernetes/configmap-envsubst.yaml#L12
If you can connect using garm-cli to the garm server, you can also update using garm-cli controller update.

I think it would be best if you switch garm to v0.1.4. The main branch has a bunch of updates and the operator has not caught up yet.
You can set v0.1.4 here:
https://github.com/mercedes-benz/garm-provider-k8s/blob/b45a9889943b80d5d6e8222ab6c22a5f59e02157/hack/Dockerfile#L6

also, to get webhooks from GitHub, you'll most likely need an ingress controller and a cluster IP set on the GARM server. Then you'll need to add your webhook in GitHub to point to your GARM webhook URL.

also, to get webhooks from GitHub, you'll most likely need an ingress controller and a cluster IP set on the GARM server. Then you'll need to add your webhook in GitHub to point to your GARM webhook URL.

that's right but would I need a webhook to have a pool of runners working? I'm not sure.
BTW thanks to your help it worked! Im noticing these are configured as ephemeral runners by default:
garm-provider-k8s $ kubectl get pods -n runner
NAME                READY   STATUS      RESTARTS   AGE
garm-d7appm3tvuks   0/1     Completed   0          5m28s
garm-evctriwqbovn   0/1     Completed   0          5m28s

Do you think we could have Github Apps supported? it looks like it's already from garm-server side there but we're missing some bits between the release of v0.1.5 and garm-provider-k8s

You don't need webhooks for pools to work, but you do need them to know when to spin up a runner and when to delete it. Otherwise you'll have huge delays between when a job is started and when a runner is spun up.
Github app support will probably be added once 0.1.5 is released, depending on how much time the nice folks from mercedes-benz have.

GARM only spins up ephemeral runners. No persistent runners.

GARM only spins up ephemeral runners. No persistent runners.

in any case those runners spawn didn't run anything. Log:
An error occurred: Not configured. Run config.(sh/cmd) to configure the runner.
Runner listener exit with terminated error, stop the service, no retry needed.
Exiting runner...

They did registered to github.com but they were not able to run any workflow 😢

I thinknthe summerwind image used by default can't handle JIT configs. You need to either disable JIT or build and use the "upstream" image.
The upstream image:
https://github.com/mercedes-benz/garm-provider-k8s/tree/main/runner/upstream
To disable JIT, add:
disable_jit_config = true

In the provider section of the config:
https://github.com/mercedes-benz/garm-provider-k8s/blob/b45a9889943b80d5d6e8222ab6c22a5f59e02157/hack/local-development/kubernetes/configmap-envsubst.yaml#L39

Context for the image:
https://github.com/mercedes-benz/garm-provider-k8s/pull/8

@pathcl you will most likely need to apply this patch as well:
https://github.com/mercedes-benz/garm-provider-k8s/pull/52
to build:
cd garm-provider-k8s/runner/upstream
docker build -t localhost:5000/runner-default:latest .
docker push localhost:5000/runner-default:latest

Then just apply the new image:
kubectl -n garm-operator-system patch image runner-default --type=merge --patch '{"spec": { "tag": "localhost:5000/runner-default:latest"}}'

And you should be fine with both JIT and registration token.

@pathcl you will most likely need to apply this patch as well:
mercedes-benz/garm-provider-k8s#52
to build:
cd garm-provider-k8s/runner/upstream
docker build -t localhost:5000/runner-default:latest .
docker push localhost:5000/runner-default:latest

Then just apply the new image:
kubectl -n garm-operator-system patch image runner-default --type=merge --patch '{"spec": { "tag": "localhost:5000/runner-default:latest"}}'

And you should be fine with both JIT and registration token.

Thanks! it worked now I can see idle runners. However I don't see jobs being picked up. I used runs-on: [self-hosted, Linux, kubernetes] for labels. This is my pool def:
apiVersion: garm-operator.mercedes-benz.com/v1alpha1
kind: Pool
metadata:
  labels:
    app.kubernetes.io/instance: pool-sample
    app.kubernetes.io/name: pool
    app.kubernetes.io/part-of: garm-operator
  name: k8s-pool
  namespace: garm-operator-system
spec:
  githubScopeRef:
    apiGroup: garm-operator.mercedes-benz.com
    kind: Organization
    name: labs
  enabled: true
  extraSpecs: "{}"
  flavor: medium
  githubRunnerGroup: ""
  imageName: runner-default
  maxRunners: 4
  minIdleRunners: 2
  osArch: amd64
  osType: linux
  providerName: kubernetes_external # this is the name defined in your garm server
  runnerBootstrapTimeout: 20
  runnerPrefix: ""
  tags:
    - linux
    - kubernetes
---

Did you have to change anything else?

try targeting just: linux or kubernetes (or both)  as tags in your workflows. Don't target self-hosted and Linux (capital letter)

FYI, until you set up the webhook endpoint, GARM won't be able to autoscale. You'll still get some cleanup/min-idle-runners. But it will be only when GARM consolidates instead of reacting right away.

FYI, until you set up the webhook endpoint, GARM won't be able to autoscale. You'll still get some cleanup/min-idle-runners. But it will be only when GARM consolidates instead of reacting right away.

I was finally able to run a workflow! thanks so much. Do we have docs for configuring webhook endpoint? at this point I only see two things in my setup

support autoscaling
github app authentication

FYI, until you set up the webhook endpoint, GARM won't be able to autoscale. You'll still get some cleanup/min-idle-runners. But it will be only when GARM consolidates instead of reacting right away.

I'm expecting these runners to be ephemeral but it seems idle runners are not being recreated once they've been used. Shouldn't we have always some runners waiting for jobs?

GARM doesn't know that the runner has finished running a job if webhooks don't work. They will eventually be reaped by the consolidation loop that looks in github and locally and kills used runners. Then the same consolidation loop will create missing runners based on min-idle-runners.
If you set up your webhooks, this will happen automatically, right away.

There are 2 ways to set up webhooks:

manually
let GARM do it

in both cases, your webhook endpoint must be accessible by GitHub.

You can access the GARM API directly by running the following steps:
Get the GARM admin password:
grep 'garm-password=' ~/garm-provider-k8s/hack/local-development/kubernetes/garm-operator-all.yaml | sed 's/.*=//g'

Exec into the garm-server pod
kubectl -n garm-server exec -it garm-server-5b84b7f66-rxxxp sh

Replace the pod name with your own. Then, log into the GARM server using the GARM CLI:
garm-cli profile add --name garm --password <your_garm_password> --url http://garm-server.garm-server.svc:9997/ --username admin

then you can view info about your controller, install webhooks, etc:
garm-cli controller-info show

Make sure that the Controller Webhook URL is accessible by GitHub. If you're on v0.1.4, you will need to edit the config map to set the webhook_url. You will most likely need an ingress controller and to expose that URL to the internet via a reverse proxy or port forwarding.

There is an explanation about the URLs here: https://github.com/cloudbase/garm/blob/main/doc/using_garm.md#controller-operations

If you're using kind, you'll most likely want to expose the service using a NodePort or LoadBalancer type. Then set up something like ngrok to create a tunnel to the node IP/port. If you're using a production k8s with a proper load balancer, once you expose the deployment, you'll most likely want to use the external IP/port as a base URL for all 3:

callback_url - needs to be accessible by runners (regardless of provider)
metadata_url - needs to be accessible by runners (regardless of provider)
webhook_url - needs to be accessible by GitHub

This will allow you to use the same GARM instance with multiple providers like Azure, GCP, OpenStack, OCI, etc.

If you're using kind, you'll most likely want to expose the service using a NodePort or LoadBalancer type. Then set up something like ngrok to create a tunnel to the node IP/port. If you're using a production k8s with a proper load balancer, once you expose the deployment, you'll most likely want to use the external IP/port as a base URL for all 3:
* callback_url - needs to be accessible by runners (regardless of provider)

* metadata_url - needs to be accessible by runners (regardless of provider)

* webhook_url - needs to be accessible by GitHub

This will allow you to use the same GARM instance with multiple providers like Azure, GCP, OpenStack, OCI, etc.

Thanks for the detailed explanation! . By any chance have you tried garm k8s operator using runner image in a private registry? Im trying to figure if the Image crd needs imagePullSecrets

sorry, didn't follow the entire conversation here :see_no_evil:

for the webhook thing, i've created issue https://github.com/mercedes-benz/garm-operator/issues/144 - at least to document how it could work. Gabriel is already using ngrok for integration tests in garm repo
the operator-issue was due the fact of recent garm-changes where a fresh installation didn't start. we've "fixed" this as we point to garm in v0.1.4 for now (https://github.com/mercedes-benz/garm-provider-k8s/pull/57)

@pathcl are there any other questions open regarding the garm-operator in combination with garm?


Problem on Importing third party module for adding image resize functionality

hi, im using latest version as to date and cant use
quill-image-resize-module
module with this in react native
can someone help me how to figure this out?

@itsnyx
Have you found a solution?


Performance and benchmarks with others

Hi
I saw this test results and it actually came after I had already looked into a issue with slow code where I discovered that zod was taking up 600 ms to parse 1000 json elements.
https://github.com/moltar/typescript-runtime-type-benchmarks
Zod is one of the slowest in the overview.
Normally speed is not a problem since I use zod on user input, but if you run a busy api endpoint this could be something important.
Did something experience something like it?

Sorry, closing in favor of https://github.com/colinhacks/zod/issues/205


Add collaborators to this repo

Comment below to be added as a collaborator
We will all be using this repository today. Even though it's public right now, you will not be able to make changes until you're given the correct permissions. We've automated this process via the GitHub API. Once you comment, we will add you as a collaborator.
You'll start to receive a lot of emails. (❗) You can slow these down immediately by clicking the Unwatch button at the top of the page and selecting either the Participating and @mentions or Ignore option.

adding a comment

Danny Lamb Comment

hello

Pingting Zhu Comment

Comment

Hello

Hello

i'm finally here

comment

comment

Hello Matt Cantrell test. Thank you


fix(category-geo): Two new map styles were add

Description of changes

Two new map styles were added.

"VectorHereExplore"
"VectorHereExploreTruck"

One existing map style was added.

"RasterEsriImagery"

I turned off lint as there were many changes to the existing code.

Issue #, if available
https://github.com/aws-amplify/amplify-cli/issues/10290
Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #10115 (972033d) into master (dfcfa52) will increase coverage by 0.00%.
The diff coverage is 93.33%.

@@           Coverage Diff           @@
##           master   #10115   +/-   ##
=======================================
  Coverage   54.08%   54.09%
=======================================
  Files         837      837
  Lines       46376    46382    +6
  Branches     9891     9892    +1
=======================================
+ Hits        25084    25090    +6
  Misses      19296    19296
  Partials     1996     1996

Impacted Files
Coverage Δ

...ory-geo/src/service-walkthroughs/mapWalkthrough.ts
83.52% <80.00%> (ø)

...mplify-category-geo/src/service-utils/mapParams.ts
88.23% <100.00%> (+1.56%)
:arrow_up:

...y-category-geo/src/service-utils/resourceParams.ts
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@siegerts : Hi, When will this pull request be merged?

@atierian
@thaddmt
@edwardfoyle
Hi, When will this pull request be checked?

Just opened an issue to ask for this as well: #10290

@dreamorosi
Thank you for creating the issue.

@AaronZyLee , @thaddmt , @phani-srikar
The following corrections have been made. Please check them out.

The default map style has been restored.
The existing style "RasterEsriImagery" has been added.

I also sent a pull request to "docs".
https://github.com/aws-amplify/docs/pull/4287

@phani-srikar , @AaronZyLee
Could you please check your pull request?

When will this pull request be merged?
I would like to create a map application with this new style.

@edwardfoyle
I think it used to clear the automated test, but now there is a problem?


lifecycle-policy file

Is it or would it be possible to point to a file in another repo for the lifecycle-policy.json? Our situation is such that we have a repo with our workflow. This workflow is used by multiple other repos by way of workflow_call. Our lifecycle-policy.json file is in the repo that contains our shared workflow and thus we need to point to that file.
Thoughts or ideas are more than welcomed.

@Bryan-Meier I believe this issue stems more from a limitation with GitHub rather than the action itself. We've encountered a similar situation with our reusable workflows. To address this, we utilize curl to fetch the policy file and then configure it across all repositories that implement these workflows. This method ensures consistency and compliance throughout our projects.
      - name: Download ECR Policy
        run: |
          curl -s -o lifecycle-policy.json https://pastebin.com/raw/YQxpnEKe

      - uses: int128/create-ecr-repository-action@v1
        with:
          repository: ${{ inputs.ECR_REPO_NAME }}
          lifecycle-policy: lifecycle-policy.json

I hope it helps you!


[iOS] Don't assume that the absolute uri returned will persist

On iOS images was stored in Documents folder. The Document folder was stored into an folder with an hexadecimal name. This folder is regenerated and renamed for each build. For this reason if you store the absolute URL of image you loose the reference from it.
For this reason I propose to return the name of the image and the path declared on storageOptions.
I know is simple to get this information from absolute URL (simple JS String manipulation) but for me is important to inform programmer of the possibility to lose their references from love pictures.
Thank's.

I'm not sure I follow...
The Documents folder should always persist for an app on the same device. Are you using the iOS simulator?

yep I'm using iOS simulator, but i have tested it into app in production

Gotcha, so the path TO the Documents directory could change, but once inside your Documents directory, everything remains the same.
I think this falls a little outside the responsibility of this image picker component. We are returning the absolute path where the photo is at that current moment, AND since the photos are being saved to the Documents directory, we've guaranteed that they will be persisted forever on the device as long as the app is installed. It should be up to the developer to then know to never rely on the absolute path and maybe use something like react-native-fs to find the path to the Documents directory.
This is definitely valuable information to know though, so thank you!

you are right ... it is outside the the responsibility of this image picker component. But the picker return an absolute path and it's good to inform the coder about the possibility to loose their (only the reference) photo.

I added a note to the README referencing this issue. Thanks for bringing it my attention!

Hello,
Wouldn't it be good then if the plugin also returned only the filename?

Just letting you know that I found an alternative to using react-native-fs.
A path prepended with ~ expands to the app Documents directory.
See https://github.com/facebook/react-native/commit/23909cd6f62056de0cd0f7c06e3997dd967c139a

@i-tu This solution works if you prefix with ~/Documents/images e.g. ~/Documents/images/myimage.png

@Max93 could you give me some hint how could I get the uri when I'm taking the photo on IOS?

@i-tu could you please give me more description?
how could I get the image absolute uri on code below?
gePicker.showImagePicker(options, (data) => {})

@xhw1993 this is all what I've done
 selectPhotoTapped = () => {
    const options = {
      title: 'عکس پروفایل خود را انتخاب کنید',
      quality: 1.0,
      maxWidth: 500,
      maxHeight: 500,
      storageOptions: {
        skipBackup: true,
        // waitUntilSaved: true,
        // cameraRoll: true,
      },
      cancelButtonTitle: 'خروج',
      takePhotoButtonTitle: 'عکس گرفتن...',
      chooseFromLibraryButtonTitle: 'انتخاب از گالری...',
    };
    ImagePicker.showImagePicker(options, (response) => {
      if (response.didCancel) {
        console.log('User cancelled image picker');
      } else if (response.error) {
        console.log('ImagePicker Error: ', response.error);
      } else if (response.customButton) {
        console.log('User tapped custom button: ', response.customButton);
      } else {
        this.resetErrorState();
        this.props.dispatch(uploadProfilePic(response));
      }
    });
  };

@jsina use this for ios
(Platform.OS==='android') ? response.uri : response.uri.replace('file://', '')
and in options
storageOptions: {         skipBackup: true,         path: 'images',         cameraRoll: true,         waitUntilSaved: true       }

@jsina use this for ios
(Platform.OS==='android') ? response.uri : response.uri.replace('file://', '')
and in options
storageOptions: { skipBackup: true, path: 'images', cameraRoll: true, waitUntilSaved: true }

Is this working? @jsina

I run into this issue as well, but my source was RNCamera. in some phone the "~" fix the problem to recover images but there was phone where only react-native-fs worked to get the correct path (which works for ios and android):
var RNFS = require('react-native-fs'); RNFS.DocumentDirectoryPath

@jsina use this for ios
(Platform.OS==='android') ? response.uri : response.uri.replace('file://', '')
and in options
storageOptions: { skipBackup: true, path: 'images', cameraRoll: true, waitUntilSaved: true }

Yes that works for me...Thanks for sharing.

Updated the title to make it easier to understand the problem while pinned.

https://github.com/react-native-community/react-native-image-picker/issues/107#issuecomment-450341021

@jsina use this for ios
(Platform.OS==='android') ? response.uri : response.uri.replace('file://', '')
and in options
storageOptions: { skipBackup: true, path: 'images', cameraRoll: true, waitUntilSaved: true }

This is not working for me. After closing metro server and restarting the app i cant open the file

Solution based on the discussion: (tks for the hints guys)
const options = {
     title: 'Select Avatar',
     storageOptions: { skipBackup: true, path: 'images', cameraRoll: true, waitUntilSaved: true },
};

ImagePicker.showImagePicker(options, (response) => {
   var path = response.uri;
   if (Platform.OS === 'ios') {
      path = '~' + path.substring(path.indexOf('/Documents'));
   }

   if (response.didCancel) {
      console.log('User cancelled image picker');
   } else if (response.error) {
      console.log('ImagePicker Error: ', response.error);
   } else {
      this.changeAvatar(path);
   }
});

FYI this is the path before transforming it, and after it's just ~/Documents.....


Dockerized the project

Added Docker files

I merged it and reduced the amount of work user needs to do in order to use this. Thanks for the PR!


[REQUEST] a working example download included with the git ;)

Ah, good idea!

awesome ;)

Forgot to close - fixed.


Setting up PR template for new commits

This is in reference https://github.com/LTKills/heroes_build_scrapper/issues/44#issue-374588569 to setup more prominent template for PR

You see, this is the best example of why I need a more proheminent list of instructions. I want a way of people to understand that they should comment on an issue, wait for them to be assigned to that issue and then start making it. I'm closing this PR because there is already someone interested in the issue.


Error [ERR_UNKNOWN_BUILTIN_MODULE]: No such built-in module: node:readline/promises

after installing the new version iam getting this error, sorry but i got no time to trace it down.
youtube-videos-uploader version is ^1.3.78

i think it something related to the node version so here is my node version :16.10.0

Duplicates https://github.com/fawazahmed0/youtube-uploader/issues/153


Support for Angular 16

Hi!
Angular 16 was released yesterday, please update to give support to this new version.
Thanks

#215

Thanks to @gerd-siebert for his pull request!

@igorosabel Please let us know if it works for you, and if so, feel free to close the issue.

I just tried and it works perfectly, thank you very much for the quick response.


Feature Request: Support http instead of https

First of all, great project.
I, and some other Smart Home guys would like to include the Corona statistics in our Smart Home, so we can see every day what are the latests stats. Unfortunatly the Smart Home Server only supports http, not https. Maybe you could also allow requests via http to the https://api.corona-zahlen.org/ endpoints? As the data is published by RKI for all, https isn't mandatory.
Best wishes, Hannes

Yes, please add http access.

Hey @Maruu23
What Smart Home Server are you using?
I don't want to give up the redirect to https.
Maybe you can try running the server at your local machine. See this guide: https://github.com/marlon360/rki-covid-api#host-it-yourself
If your Smart Home Sever uses docker it is very easy to integrate it in the docker-compose.

We are using Loxone, a very common Smart Home System. Loxone is a SPS based system and is unfortunately not running in a docker container. A local server could be a solution, but setting up a local server only for running the API is too much effort. There are even more loxone users, that are interested in using your API (I asked in the forum) and all of them do then need to setup their own API. Maybe you could rethink your decision or provide an extra endpoint or parameter (GET or Header) to accept http connections.
Thank you in advance!


feat(Accordion): Accordion alignment: 'large' size; no outline in plain

Overview
PR Checklist

~[ ] Related to Abstract designs:~
[x] Related to JIRA ticket: WEB-908
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

Description
A few scattered additions / improvements to <Accordion>:

We don't use the "plain" theme yet anywhere in the monolith, but its primary consumer in /about/careers doesn't set outline. Removed it here.

Added font size adjustments to match what's in the careers page too...

Added a size prop that defaults to "normal" but can be set to "large" to make the thing increase font and icon size.

Large accordions use the heading font with different line-height than body - hence the padding-top...

Marked onChange as optional, since it is.

📬Published Alpha Packages:@codecademy/gamut-labs@1.7.38-alpha.256386.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f0c79d282c143574d83b9ae--codecademy-styleguide.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@1.7.38-alpha.456017.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f0c9a525b768e5aa160cae6--codecademy-styleguide.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@1.7.38-alpha.189a33.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f0c9eff65a5b2f01f59cf9d--codecademy-styleguide.netlify.appDeploy Logs

Grr Codecov - ignoring...

📬Published Alpha Packages:@codecademy/gamut-labs@1.7.39-alpha.61d3e6.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f0cbe578619935acd709d35--codecademy-styleguide.netlify.appDeploy Logs


no way to prevent state_set from removes existing attributes

Hi,
using state.set("domain.entity", "new state") removes existing attributes. It is possible to supply an attribute dict, but there was no way of collecting all existing attributes from a state. state.get() only supported pulling a single attribute by name.
Also state_get() would not return the full State object, but only the state as string or the attribute value.
As a possible way to fix this, I did some changes:

Add states object, known from template extensions to be the new way of simple state retrievals
Add new method get_new that returns the actual State object and remapped state.get() to it
Add new method set_new that preserves existing attributes by default, but also allowes them to be updated or removed

The PR will follow soon.

Good suggestions- it would be good to have a clean way of providing those features.  This is related to issues #11 and #12.

I just made a commit 712692f that makes state setting preserve the attributes.  state.set() can optionally update or replace attributes.  I also added state.get_attr() to get a dict of all attributes for a state variable.

This is released in 0.21.
If you can suggest additional features or changes, please re-open this issue or create a new one.

@craigbarratt
In my PR I also fancied the idea to have access to the full Stateobject, maybe to access any of the other available properties like last_changedor context.
And I suggested using the statesobjects from HAs template engine. Even though the way I implemented it, was quite ugly, still it lets you iterate over all states or thos from a specific domain and gives access to the full State object.
I liked it, because it works the same way as in templates, making it easier for people to adopt pyscript.
What do you think?


128 bit mode should be default

Describe the bug
128 bit mode is not default
To Reproduce

Follow the examples in a high traffic service
Get wrecked with duplicate span IDs

Expected behavior
Not have duplicate traces. By default things should work, not break. Having a "set this or have a problem" flag is bad.
Additional context
While it's now possible to specify 128 bit span ID generation, it requires a different way to initialize from explicit transport initialization, and the documentation on how to translate from one to the other is not very clear.

Changing the default would be a breaking change, requiring a major release, which we're not planning to do since the library is being retired (see README).
The 128bit mode can be set via env var JAEGER_TRACEID_128BIT or programmatically via config. Feel free to suggest improvements to the docs on how to make this more clear.

How would it be a breaking change? Are there receivers it would break? It certainly wouldn't break the compiles.
As for configuration, we weren't using that, but making the tracer directly and then installing it as the global tracer. At this point there are ~two different ways to configure a tracer, and they don't seem to be equivalent. Clearly indicating which is depreciated and provide equivalents for each setting in the one that is for the one that is not would be helpful.
With depreciation will there be a migration guide?

How would it be a breaking change?

There are existing deployments that rely on the default to be 64bit. Changing that default may break those deployments.

there are ~two different ways to configure a tracer, and they don't seem to be equivalent.

if you're talking about programmatic configuration, please provide specific references to code where you see the duplication.

https://pkg.go.dev/github.com/uber/jaeger-client-go#NewTracer and<EMAIL_ADDRESS>both create tracers. What's not obvious is the list of available TracerOptions in the documentation, because they are public methods on a private type (but public variable). That's what threw me for a loop.

Right. So the Configuration type is meant for declarative tracer initialization, e.g. you could populate that struct from a YAML/JSON configuration. The NewTracer() constructor is lower-level initialization that gives you more control over which components to instantiate (although Config has some of that too, for convenience).
I agree, the functional options on private type were unfortunate choice - that could be improved as a non-breaking change, if you wish to propose a PR.


Develop Branch

Create a develop branch for development testing.
Will not be merged until tested and stable.

Got this done, and have begun making changes into develop branch first before comparing and merging😊