BREAKING: remove Fresh plugin

closes #191.
this is the pendant to https://github.com/denoland/fresh/pull/1774.

Not to self: merge this one the Fresh plugin is in the latest Fresh release.

Actually, I'll merge this now and instead cut a release after Fresh.

Should the fresh plugin be added again after being removed in<EMAIL_ADDRESS>by https://github.com/denoland/fresh/pull/1910 ?

Should the fresh plugin be added again after being removed in<EMAIL_ADDRESS>by denoland/fresh#1910 ?

We added a Get Started with Fresh README section in #265. PTAL and let me know if you have any questions 🙂


ImportExportBeforeExportRecordEvent has no context object, why?

PHP Version: 8.3.12   | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Platform(Default)

Expected behaviour:
I had assumed that ImportExportBeforeExportRecordEvent has the same context as the other events, e.g. ImportExportBeforeImportRecordEvent... etc.
But we need it to export some stuff from the DB.
Actual behaviour:
ImportExportBeforeExportRecordEvent doesn't have a context object.
How to reproduce:
Try to export something an use the mportExportBeforeExportRecordEvent to enrich the export with some data
from the DB, which is not possible without the context object.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-39217
[created from NEXT-39217, comment 506126]


adding new dinos?

HI Coldino.   Love the larkator, so helpful on my single player game. Thanks so much for taking the time to make this. This is the only dino locator i know of that doesn't require you to "prevent hibernation" to work.
i was wondering if you will be doing any updates to add some of the new dinos.
IE, alpha tuso, gachas, wyverns, rock drakes, etc.
Thanks again

Thank you!
Larkator should already support everything supported by Ark, and it'll even have a go at listing modded creatures (just without nice names).
The catch is that the species must exist on your map before Larkator can see it and list it!

Additional info: hibernation prevents that mods can see more than the loaded areas, because hibernated areas are inaccessible for the normal game mechanics. So no mod is able to find all creatures if hibernation is not prevented. Larkator can find them all, because it reads the save file. To save the whole map the current area as well as the hibernated parts have to be written into the file, so a save file reader can read all.

Ok. thanks for the reply. Is <IP_ADDRESS> the latest build?
I was just confused because on the island and rag, alpha tuso isn't even in the list as an option.
And when i first loaded up the extinction map, I didn't see gachas in the list. But, now i just loaded into rag, and i can see wyverns in the list.  Thanks for taking the time to reply though, i really appreciate it.
Thanks for the explanation Flachdachs. Exactly the reason i love larkator. preventing hibernation can really slow down your game due to the shear amount of information the game will then require trying to process all the "out of render" areas.

Things out of render area are "in stasis" if you prevent hibernation. So in neither case are they processed. The only difference I can see is a freeze when the game is saving and has to consider all creatures. In hibernation mode it doesn't freeze. Then the creatures apparently need to be just written without a noticeable processing time.


configure timeout

I think that's an easy merge if there's an environment variable and docs for it.

sounds good, I'll add a variable with docs and reopen!

@uchouhan there are significant changes in this PR now. More than I expected for exposing a single parameter through an environment variable. Were the commits from yesterday intentional?

@uchouhan there are significant changes in this PR now. More than I expected for exposing a single parameter through an environment variable. Were the commits from yesterday intentional?

hmm not sure how that happened, our repos have diverged quite a bit so may not make sense to merge unless you have the same use case and functionally its compatible, I'll close this PR otherwise

At this time I don't have the availability to merge some of those changes upstream because I'd have to pull them out. I appreciate the thought though!


Flutter v3.22 deprecation build Issues - .Thumbnail and .WEBP have been deprecated in Java

Lack of Width and Height Dimensions for some images, mostly .png images

Ok.


Better is element present plus 'Select Element From Menu'

Coverage decreased (-3.5%) to 96.472% when pulling 58afb54a5772b34801c9783c23e8d024b8105010 on better_is_element_present into c13437b59b79df437b759eac099f29744c2bfadb on master.

Coverage decreased (-3.5%) to 96.472% when pulling 58afb54a5772b34801c9783c23e8d024b8105010 on better_is_element_present into c13437b59b79df437b759eac099f29744c2bfadb on master.


New Grinder Jenkins job missing systemtest repo parameters

The old Grinder job (https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Old/build?delay=0sec) had parameters to override the systemtest and STF repositories.
ADOPTOPENJDK_SYSTEMTEST_OWNER_BRANCH
OPENJ9_SYSTEMTEST_OWNER_BRANCH
STF_OWNER_BRANCH

Those parameters are missing from the new Grinder job (https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/build?delay=0sec), but are required when testing changes to those repository in a fork / branch.

Strange, I thought @Mesbah-Alam manually added them and then they were also added to the testJobTemplate via https://github.com/adoptium/aqa-tests/pull/2521.
I have added them to the Grinder job now.


comfyui manager enough?

Is updating your new update via manager enough? or do i have to do manually?

also, noticed this on my comfyui startup, so wondering if there is something broken

Is updating your new update via manager enough? or do i have to do manually?

cd ComfyUI/custom_nodes/comfyui-mixlab-nodes
install.bat


Remove the popout badge formats?

I think the popout badge formats look cool, and that it is possible to arrange them side-by-side in readmes in a way that looks good, and that they could even be used to convey useful information like distinguishing one platform for another (you could argue that logo + text does this better than text).
However, I don't think they are used very often. We've also gotten a complaint about them from one of the founders of shields, on the basis that consistency is a goal of the project, and offering lots of formats works against that. (#1478)
I certainly don't feel very strongly about them, one way or another.
However, I was in the process of working on #2428 (which I lost steam on a couple months ago) and wasn't personally feeling it was necessarily worth the effort to maintain these formats. So I thought I would raise the question. Would anyone be upset if we dropped these formats?
I don't think we have stats on the badge formats, though perhaps we should turn that on for a few days to inform this question.

Would anyone be upset if we dropped these formats

I assume this question is directed to everyone (Shields end users, contributors, maintainers, etc.) correct? I don't feel strongly either. I don't use the popout format myself.

Shields end users, contributors, maintainers, etc.

Yes, to everyone. 😁
I mean, if there's one person who wants to use it that probably is not enough to justify keeping it. It's not terribly hard to put something like RunKit in front of the Shields JSON badge, for a small number of people who are really passionate. But if I'm wrong and it's actually really popular, or really important to a significant group of maintainers or contributors, that could be reason to keep it.

I don't have any strong opinions on this myself. Do we have any precise usage statistics? I've pinned the issue in an attempt to gather more feedback from our users.

I agree it would be helpful to collect usage statistics.

One thing to consider when you collect stats:
For some reason (copy+pasteing, I guess), quite a lot of READMEs have badges that are using the popout or popout-square styles are using them without a logo. For example all these READMEs are using a shields badge with style=popout-square and no logo:

https://github.com/daniu310/python/blob/a10aafe24787978ec3a676bd6d460655db424958/themes/theme-ad-master/README.md
https://github.com/Nuglif/NGLoggerKit/blob/12dd5acbe8b78b2afd38c24b6eca379246846be4/README.md
https://github.com/maxkrasnov/react-multilevel-select/blob/babfe26af46893113f1911893b9ab0e10c06cb42/README.md

(no special reason I've picked these - just searched GitHub to see what came up)
If we just look at requests for badges using the popout styles, we're going to overestimate the impact of removing the feature, so we want to look at requests using the popout style and also using a logo.

Wow, I just had a look through some too, and there is a ton of repos using the popout style without a logo.
One of the more common ones (of what i've seen) is:

@RedSparr0w your search returns even less results at this point, and some of them aren't actually popout badges. There may be places outside GitHub using these, but I wouldn't expect massive usage there either.
Shall we make popout and popout-square fall back to flat and flat-square respectively, and if no one complains with a good use case after a few weeks delete all related code?

your search returns even less results at this point

Yeah the search doesn't seem to show the most accurate numbers,
These are all taken with the same link, refreshing the page a few times:

Shall we make popout and popout-square fall back to flat and flat-square respectively, and if no one complains with a good use case after a few weeks delete all related code?

:+1: Probably the best option

hey, return this feature :(

Hi @0xF6,
Sorry to hear you're unhappy about this removal. We were leaning towards getting rid of the popout style as it was not widely used and was somewhat breaking consistency, which is one of the goals of the project. However, this decision is not set in stone yet.
Could you tell us more about where you were using these badges and what additional value they brought compared to the standard logo ones?

Popout badge very cute, used them to display the VSCode market and telegram badge link. (it would be possible to use a popout style on external services (azure pipelines, codacy, etc) - it would be very cool, but life is a pain)
I have long been using the service shields, but I found out about popout style quite recently, to which I was very happy.
#return_popout_style! :c

I was using popouts in every single one of my README files, as they provided some more spice to a large logo, which by default looks quite silly... It now looks quite silly...
I don't think you should be removing a format that users rely on from this service without a very long deprecation period and plenty of notice so that everyone using this style has time to make their own decision and changes...
Eg. https://github.com/MattIPv4/Avatar/blob/master/README.md

I wonder if a better solution here would to be to make this an undocumented style so that existing users aren't affected, but new users are far less likely to make use of this style.

In general, backwards compatibility and responsible deprecation is a big concern for us.

For the NPM package, SemVer + release notes gives us an established mechanism to communicate deprecations and breaking changes.
For self-hosting users, there is some work in flight to publish tagged releases to docker hub to try and improve this.
For our SaaS users ( https://shields.io/ itself), we don't really have a good way to communicate changes to users. We don't know who our users are (because we're not tracking you).
While some enthusiasts may check this repo, discord, https://twitter.com/shields_io , https://shields.io/ , etc I'd wager the vast majority of our users interact with us exclusively via images in their README (often copy-pasted from someone else's README). This means we have no back-channel to communicate changes.

The upshot of this is we try to avoid making breaking changes to the SaaS. For example, if we change a route, we'll maintain a legacy redirect for the old one. Sometimes its unavoidable. For example, if an upstream API disappears, we just have to replace the badge for that service with an error message. No more data, no more badge..
In this case, I wouldn't say we've made a breaking change. The result of this is not that your badges all throw a 404 error or don't render. A fallback style has been provided - its a visual change.
A few questions for you @MattIPv4 :

What might a good deprecation process look like for a badge, a style or a route on shields.io? (excluding package and self-hosting users)
Where could we have posted a deprecation notice that all of our users would see it?
If you had known "In X weeks/months, the popout style will be removed. After date Y, badges using the popout style will render as flat" (or whatever), what would you have done differently?

Cheers

What might a good deprecation process look like for a badge, a style or a route on shields.io? (excluding package and self-hosting users)

We briefly discussed this in the Discord server and I absolutely agree that it is very hard to create a good deprecation process here. As you've stated many users (such as myself) only really interact with the service through the badges in files.
This is why I'm more of the opinion that this should've been left in the API but removed from the front-end so that legacy users still had the bad style they'd intended to use but new users wouldn't make use of the style that you don't see fit for the service any longer.

Where could we have posted a deprecation notice that all of our users would see it?

It looks like the only place this change was communicated in advance of it happening or after was this issue. Whilst I don't think there will ever be a good way to communicate such changes due to the nature of the service as above, with many users only using the images, I think to make it known on Twitter and maybe even reach out in repositories of the users who are using this style (the searches above would indicate a low number, do-able with a bot or a dedicated human) would have been good steps to help communicate this change better.

If you had known "In X weeks/months, the popout style will be removed. After date Y, badges using the popout style will render as flat" (or whatever), what would you have done differently?

For me personally, I could've made the small change to the README files at my own leisure as part of other changes. Now, all the READMEs have odd-looking badges and I need to go through every repository using my template README and update the badges to make them look nice again.

I used them in BizHawk's readme, but only because the icons are too damn small with flat or plastic.

Hmm, I'm in favor of bringing this style back,
It doesn't really add any extra overhead (other than moving templates type).
And it seems there are a few users who have noticed and are disappointed with the change. (here and on the discord)

And it seems there are a few users who have noticed and are disappointed with the change. (here and on the discord)

Indeed, however, given that this feature was available for many months and that we've got less than half a dozen complaints in total, one could argue that the impact is low. Maybe we should set up a Twitter poll or something regarding the feature's return? Users did complain about our lack of communication, I'm keen on improving that.

we've got less than half a dozen complaints in total, one could argue that the impact is low.

Instead of justifying why we need to bring it back, rather, we should look at why exactly it was removed in the first place. To me, I don't see a need for it to have ever been removed from the service. As @RedSparr0w pointed out, "It doesn't really add any extra overhead (other than moving templates type)."
The main two justifications for removing it are 1. "I don't think they are used very often." and 2. "a complaint about them from one of the founders of shields, on the basis that consistency is a goal of the project, and offering lots of formats works against that."
I don't think either of those really justifies removing a shield type from the service. If consistency is an issue, as mentioned before, it would be fine to simply remove this type from the main site to reduce awareness, but leave it available in the actual service for those that wish to continue using this inconsistent style.

@MattIPv4 - thanks for the feedback. There's another important aspect that @paulmelnikow mentioned in the original thread relative to the work required in #2428/#3637 to move all of the badge templates to template literals.
So IMHO, it was really about the tradeoffs for that work required for the popout template, in conjunction with the other concerns described in the OP, bandwidth of the maintainer team, etc.
If someone was willing to provide/assist with the template literal for the popout format then FWIW, I'd be a 👍 on bringing it back too.

It's fair to say that we won't be bringing the popout style at this point in time, so I'm going to go ahead and close this issue.
As a summary, the reasons that have pushed us to drop this feature:

consistency is one of the goals of the Shields project and this format worked against that.
its usage was very low.
it caused some maintenance overhead and additional work would have been needed in #4459/#3637. No one stepped up to assist us despite our call for help (https://github.com/badges/shields/issues/3635#issuecomment-526934603).

However, this issue did highlight that we didn't do enough on the communication side and lacked a good process for deprecating features. We've taken this feedback into account, in particular in #4564:

we've communicated more widely about the change, using a variety of different mediums (GitHub, Discord, Twitter).
we've asked for users' opinions through polls and discussion threads.
we've allowed for a longer notice period (~2.5 months rather than ~2.5 weeks here) and have defined clearer timelines.

If you have ideas to improve things even further, please do let us know. We've been slowly increasing our social media presence, consider following our Twitter as it's a good way to keep track of where the project is headed!


Release skydoc as python package on PyPi

As skydoc is pure python code, it would be great to release it on PyPI.
I'm currently developing a sphinx-bazel  extension, which automatically parses Bazel files and make its content and especially the docstrings available inside a sphinx based documentation.
As skydoc provides already awesome functions to parse .bzl-files for rules, macros and loads, it would be great if there is an easy way to reuse this work.
The "normal" way would be to define "skydoc" as dependency in my setup.py file and use the needed code via import statements like from skydoc.rule_extractor import RuleDocExtractor
However, this is currently not possible as there is no official release available (in terms of the python ecosystem). Other options like copy/fork code-parts to my repo, force the user to clone needed code, are also not so nice.
So is it possible to

Create a setup.py file
Set a version
Release it on PyPI?

skydoc (the python tool) is deprecated and will be removed soon. We're pushing for users to migrate to Stardoc (which is written in Java, with source code living under bazelbuild/bazel).
See the current doc page for details.


Warn when limit of simulations is reached

Once you submit ten times and have ten scenarios in the queue, submitting further scenarios just brings up the existing ten, with #10 highlighted, but not changed (and it's not obvious that's what's happening). You have to reload the page (and re-enter you data) in order to get scenarios to generate again.

Ideally allow the deletion of old simulations and adding more than 10. At minimum, warn when reaching the 10th simulation.
from reddit

It would be great if this could be fixed. It's always confusing me when I hit "run" and it looks like my changes had no effect on the outcome. At a minimum, it should display an error. The current behavior is very misleading.


Publish all artifacts on mavenCentral

Right now we're hosting artifacts on Google cloud in central US but we'll have potential users all over the world, so probably maven central is doing a better job at supporting everyone than my setup is

This is something required to use Kobweb in enterprise setup where maven central / it's proxy is the only approved artifacts repo. Any plans to publish it before it reaches 1.0?  I think Kobweb is stable enough to use for internal tools

Yes, I will publish to the official gradle repository strong before or at 1.0.
Avoiding it for now because it's a pain (my other libraries Kotter and Truthish use maven and it's a bunch of extra steps)
Apologies for the inconvenience until then. Aiming to get to 1.0 sometime this year.

Sorry to bug you again..any update on this? Compose Multiplatform just become stable with 1.9.20

So apologies here. Gonna still be several months at least before Kobweb is 1.0.
Good news is it's finally a straight shot to 1.0 now (roadmap document for reference). I've been mainly filling in API gaps and adding the final collection of foundational Silk widgets recently. It just has been taking longer than I thought. (I thought each widget would take a few days but they take more like two weeks each, for example)
It's hard to express how frustrating MavenCentral can be to work with it you've never done it. It adds significant friction to the release schedule every time (and on more than one occasion I've had to delay a release of other artifacts I work by 24-48 hours because the servers just 403 at you constantly).
With my limited resources, I'm going to be putting this off for as long as possible... (Compose Multiplatform going stable is really nice! But not something I was taking into consideration around this issue)

jfyi: Things are much simpler now with new maven central publishing. You can use this new Gradle plugin for automatic publishing - https://github.com/GradleUp/nmcp

Thanks for the update! That will be helpful for sure.
Note for now the main issue isn't the publishing step, but just generally supporting two repositories, which increases the odds that something can go wrong. I wish I could say I felt more confident about maven central, but the nexus release process still occasionally causes me issues when working with my other project, Kotter.
For another example, maven central doesn't update for 30 minutes after you release, which will generally add a weird delay to my current release announcement process. Releases are stressful enough without dealing with that! :)

generally supporting two repositories (Google and Maven Central)

Since Central is the canonical one for kotlin/jvm ecosystem, do we even need google once we start publishing to Central? Also for 30 minutes delay, i think that got improved with new central publishing and i could able to see the new artifacts in few minutes.  Sorry, i am not pushing you to do this, but having thing s on central is much easier in enterprise environments.

Once we start publishing to Maven Central, Google won't be the main one anymore. With Kotter I now consider maven the main release blocker, although I still publish everything to Google as well.
For me personally Google is much more convenient -- I own all the bits there and in the past I have cleaned up artifacts that got uploaded there incorrectly.
Also note that for Kobweb 1.0 I'll also need to figure out how to host my gradle plugins in the Gradle repository, just to make things a little more confusing and add more moving parts.

Ha, so funnily enough, just today I tried publishing snapshots for my library Truthish, targeting both Google and Maven Central repositories.
Maven central rejected me with this message:
> * What went wrong:
Execution failed for task ':publishKotlinMultiplatformPublicationToSonatypeMavenRepository'.
> Failed to publish publication 'kotlinMultiplatform' to repository 'SonatypeMaven'
   > Could not GET 'https://s01.oss.sonatype.org/content/repositories/snapshots/com/varabyte/truthish/truthish/1.0.2-SNAPSHOT/maven-metadata.xml'. Received status code 401 from server: Content access is protected by token

Why did this break? The code hasn't changed for a long time. It's using the same auth setup that I use in Kotter. This code has working for over a year. Did something change? Was this a temporary fluke and I should just try again later? I don't know!
I don't enjoy working with maven central :P

Yeah, i think as a nexus user you might have this communication from Nexus

Dear Maven Central publisher,

We are making changes to the OSSRH authentication backend. For most users this should be a transparent process, and you should be able to continue to use your existing username and password to connect the Nexus UI. In case you need to update your password, please follow our documentation.

To configure a publisher’s plugin authentication you would need to update your plugin settings to use a user token instead of the Nexus UI username and password login.

You should use token now - https://support.sonatype.com/hc/en-us/articles/360049469534-401-Content-access-is-protected-by-token-when-accessing-repositories

@sureshg Yeah, I had seen that earlier and assumed it didn't apply to me. After all, it says that the process should be transparent and that username / password should still work. Worse, if you follow through with the instructions on setting up the token mention that this is a Sonatype Pro feature only:
https://help.sonatype.com/en/user-tokens.html
Ah well, I guess this is what I'll be doing today, figuring this stuff out. :)

As an additional use-case: creating libraries that build off of Kobweb is quite complex right now, because users of such libraries need to do additional setup before being able to consume them (as they can't download Kobweb artifacts in a default project).

"Good news"... I just started noticing I've been getting charged for hosting my own artifacts.
I guess enough people are using Kobweb at this point I've gone over a download limit I never originally thought possible. Yay success :)
I guess I am now financially motivated to move things over to maven central a bit sooner than I originally expected. I'll at least try to look closer into what is exactly happening and evaluating a move over the maven central it in the next few weeks.


Add mapkubeapis as a kind of scanner

https://github.com/helm/helm-mapkubeapis can be another source of best practices scanning.

We remove scanning completely from V2


ADA Compliance documentation

It would go a long way to help pitch Material UI as a solution if I could link to documentation covering the library's support for ADA compliance.
I know Material UI does have at least some support for ADA/WCAG compliance, for instance through the use of "aria-" and "role" html attributes throughout the codebase to assist screen readers and the support for keyboard navigation such as in the Select component.
Meanwhile, Material Design itself seems to lend itself nicely to following the WCAG guideline, for instance with regards to readability, navigation and high contrast text.
However, without being a core contributor myself, I cannot speak to the library's compliance overall. I searched the material-ui.com website as well as past/present GitHub tickets and could not find a page in the documentation whose sole purpose was to outline what it does and does not do to be ADA compliant. Therefore, I am opening this ticket as a feature request to please create said documentation.

Hello! I'm really glad to join this thread about ADA. I found great article about WCAG & ADA web compliance. If you want you can read it and share your thoughts after reading. Hope you like it! Because I found it really useful.

Does anyone know an audit accessibility company that could audit all our components for the ADA compliance? Bonus point if they can sponsor it for a popular OSS project.

We've been using https://www.powermapper.com/buy/all/sortsite/
On Wed, May 15, 2019, 6:12 AM Olivier Tassinari<EMAIL_ADDRESS>wrote:

Does anyone know an audit accessibility company that could audit all our
components for the ADA compliance? Bonus point if they can sponsor it for a
popular OSS project.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/14187?email_source=notifications&email_token=ABLMBUK5KMQILUUSVMKF3F3PVPVZ5A5CNFSM4GQFAB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOKMLQ#issuecomment-492611118,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLMBUJ6D3QHNW3G4UI34O3PVPVZ5ANCNFSM4GQFAB2Q
.

@bramick I'm looking for manual tests.

This might be a good one to reach out to: https://accessible360.com/
Michele Landis looks like a good member to reach out to.
--
R. Blake Ramick
Mobile:<PHONE_NUMBER>
www.LinkedIn.com/in/bramick
On Wed, May 15, 2019 at 9:13 PM Olivier Tassinari<EMAIL_ADDRESS>wrote:

@bramick https://github.com/bramick I'm looking for manual tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/14187?email_source=notifications&email_token=ABLMBUOHD2X4CB5P7XVO3MLPVS7LPA5CNFSM4GQFAB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQOLNQ#issuecomment-492889526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLMBUNOFFKIZLM2OQJ2723PVS7LPANCNFSM4GQFAB2Q
.

Or perhaps https://www.linkedin.com/in/connor-born-b8738328/
R. Blake Ramick
Mobile:<PHONE_NUMBER>
www.LinkedIn.com/in/bramick
On Thu, May 16, 2019 at 8:47 AM Blake Ramick<EMAIL_ADDRESS>wrote:

This might be a good one to reach out to: https://accessible360.com/
Michele Landis looks like a good member to reach out to.
--
R. Blake Ramick
Mobile:<PHONE_NUMBER>
www.LinkedIn.com/in/bramick
On Wed, May 15, 2019 at 9:13 PM Olivier Tassinari <
<EMAIL_ADDRESS>wrote:

@bramick https://github.com/bramick I'm looking for manual tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/14187?email_source=notifications&email_token=ABLMBUOHD2X4CB5P7XVO3MLPVS7LPA5CNFSM4GQFAB22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQOLNQ#issuecomment-492889526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLMBUNOFFKIZLM2OQJ2723PVS7LPANCNFSM4GQFAB2Q
.

Our components won't meet WCAG by default. The look&feel are more important (see #22541). It's not viable to document all possible techniques to makes the components meet WCAG 2.1. We'll revisit this in the future once we have the bandwidth for it.

oliviertassinari reopened this in 1 hour

@oliviertassinari Did you change your mind after #22541? Could you explain why you want to follow ADA but not WCAG?

@eps1lon From what I understand this issue is about providing a list of all the known issues around accessibility. With a comprehensive list, we could then prioritize work on the most important items. With such a list, developers can then evaluate each component and decide if they want to use it or not, individually. So I think this should stay open until we can provide a comprehensive list. I think it's where an a11y audit with severity for each failure would help a lot. I would be leaning toward doing both an internal and external audit.
Regarding the Rating, I believe that by using different shapes (in addition to the different existing colors) we can address 1.4.1: #22554.
Can somebody confirm that ADA compliance is reached with the AA level of WCAG?
Regarding the look & feel, I don't think that great looking application makes it impossible to have them accessible. However, it makes it harder, and I don't t think that it's something we should trade.
Why? Because it seems that most product teams make the same tradeoff. If Material-UI isn't used, whatever advancement we bring to the a11y won't have as much impact as it could have.

ADA recommends WCAG AA 2.0... (note 2.1 is now out)
On Thu, Sep 10, 2020, 1:22 PM Olivier Tassinari<EMAIL_ADDRESS>wrote:

@eps1lon https://github.com/eps1lon From what I understand this issue
is about providing a list of all the known issues around accessibility.
With a comprehensive list, we could then prioritize work on the most
important items. With such a list, developers can then evaluate each
component and decide if they want to use it or not, individually. So I
think this should stay open until we can provide a comprehensive list. I
think it's where an a11y audit with severity for each failure would help a
lot. I would be leaning toward doing both an internal and external audit.
Regarding the Rating, I believe that by using different shapes (in
addition to the different existing colors) we can address 1.4.1: #22554
https://github.com/mui-org/material-ui/pull/22554.
Can somebody confirm that ADA compliance is reached with the AA level of
WCAG?
Regarding the look & feel, I don't think that great looking application
makes it impossible to have them accessible. However, it makes it harder,
and I don't t think that it's something we should trade.
Why? Because it seems that most product teams make
https://material-ui.com/blog/2020-developer-survey-results/#6-what-are-your-key-criteria-when-choosing-a-ui-library
the same tradeoff. If Material-UI isn't used, whatever advancement we bring
to the a11y won't have as much impact as it could have.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/14187#issuecomment-690656196,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLMBUNF52J24S2VULIPPDDSFERN7ANCNFSM4GQFAB2Q
.

A benchmark of the type of outcome we can expect from this issue:

https://www.telerik.com/kendo-react-ui/components/accessibility/accessibility-compliance/
https://ej2.syncfusion.com/react/documentation/accessibility/
https://ag-grid.com/javascript-grid-accessibility/

Note that I could only find that on paid UI libraries, and considering we are pushing in this direction, it makes sense to move forward on this issue too. In the public roadmap, we have an item on this matter.
Out of this benchmark, I would propose the following plan:

We add a new https://material-ui.com/discover-more/accessibility/ page.
This page starts with an overview, e.g. https://www.telerik.com/kendo-react-ui/components/accessibility/
The page continues with a compliance section: e.g. https://www.telerik.com/kendo-react-ui/components/accessibility/accessibility-compliance/.
We run an internal and/or an external audit. Maybe could continue on the initial idea of @chaance in https://github.com/reach/reach-ui/issues/439#issuecomment-581536853.
In the compliance section, we link each ## Accessibility section component have, for instance, the DataGrid or #20600.

I will look into it and report back here what (if anything) has evolved from a MUI centric effort.  Soon after my post here the focus shifted to feature based compliance which makes more sense and closing gaps with middleware (internal api library) which can also be faulted for being too opaque and breaking a11y features supported by MUI.  Another downside to the middleware approach is the massive version gap (major versions behind).  The biggest issues we found in our own features where the following

keyboard navigation and tab focus indicator (sliders, tabs, menus, floating menus, drawers, modals, clickable toasts, popover focus, chip adornments)
color contrast ratio (purely design issue) 5:1 is pretty stark
high contrast mode (partially blind)
lots of grid keyboard navigation issues particularly around headers, grouped headers, footer and embedded footer components (not MUI)
label targeting (example label-for must be an id and thusly global)
mostly lots of issues with screen reader but without a JAWS license you can't even test this as it is the de-facto standard for blind users on desktop, don't even bother with NVDA
since then MUI has come a very long way indeed supporting most (if not all the issues mentioned) but now you have a grid so welcome to that world of pain

Just seeing this because I was tagged, but:

mostly lots of issues with screen reader but without a JAWS license you can't even test this as it is the de-facto standard for blind users on desktop, don't even bother with NVDA

I believe this is a mistake. NVDA has gained significant market adoption in the past several years. This survey by WebAIM was in 2019 and showed NVDA actually overtaking JAWS for the #1 spot. https://webaim.org/projects/screenreadersurvey8/
NVDA is available for free. It is very much worth getting a JAWS license if possible and testing on both platforms if at all possible, given their large user base.

It is very much worth getting a JAWS license and testing on both platforms

It really does need to be tested by someone who uses these tools on a daily basis though. Getting a license isn't necessarily the issue, it's having the experience to know whether the output "makes sense" to a regular screen reader user.

Would a11y audits be performed for both styled and unstyled components (something to consider as v5 is being planned)?

It is very much worth getting a JAWS license and testing on both platforms if at all possible, given their large user base.

My problem is that this is a one-year license that I still don't even know how to get in Germany. After that you're stuck with an older version. I don't know how upgrades are handled by actual users. Do they upgrade every year? Every 5 years? If almost everybody is on the latest version then how useful is testing for 1-2 year old versions?

It really does need to be tested by someone who uses these tools on a daily basis though.

While I agree with that generally I don't think you need it for component testing. Most of SR related bugs are components flat out not working.
For testing UI itself app devs are responsible. We're also not testing usability of our components with actual users.

Would a11y audits be performed for both styled and unstyled components

Styled for now. For unstyled we first would need to determine what kind of properties we want to audit. For example, it wouldn't make much sense to audit "use of color" for the unstyled variant since the color is most certainly changed when people use the unstyled variant.

FWIW I think unstyled components are likely more a11y compliant than styled because the contrast ratio doesn't come into play (just user defaults) and fewer edge cases to worry about wrt specificity for user defined styles

FWIW I think unstyled components are likely more a11y compliant than styled because the contrast ratio doesn't come into play (just user defaults)

Sure but what is an audited component worth if it's never used in its default state? Styled components are much more likely to be used as-is or with little changes.
We're not choosing the version that is more likely to pass but the version where an audit is useful to the end-user.


(WIP) (FM-2564) Update Generated Types

Merged in #43, I take it this is next on the list?

@ferventcoder / @jpogran - a couple of notes here on what I need to do to close this out.

I want to add a rake task to clone down the types / refresh the vendor dir - should be pretty easy
I think anything that looks wrong in b8df8a9 we want to look at fixing the upstream repos.
As part of 0d3e5eb I found that MSFT_xDSCWebService.Schema.mof still had a BOM, which killed MOF generation - we'll want to fix the upstream repo.

We could also get up through 6e54f96 merged, and do the remaining updates in a subsequent PR to at least move some of this forward for the sake of @zreichert / @cowofevil testing.

FYI rolled back in time to 6-22 modules so that @cowofevil can merge up through 6e54f96 so that we can do the ticket around moving vendored modules.
Then I can get us up a later drop of what's on GitHub


Loosen chai-spies version requirement

This changes the version requirement for chai-spies to * - as karma-chai is already * it seems pretty fitting to do this.

@keithamus Thanks! I fixed it to 0.6.0 because I didn't know if the path change in different versions of Chai-spies, but looks like it's always the same. Merging this.

@frankdiox just for you I'll make sure we never change it :wink:

@keithamus I just updated NPM package. Thanks ;)

:+1:


When generating a library, cbuild output is misleading

The Problem To Be Solved
When generating a library, there is no link step.
Suggest A Solution
Therefore change cbuild output:
Linking C static library C:\w\MDK-Middleware\.ci\out\Network\CM4\Debug\Network.lib
To:
Generate static library C:\w\MDK-Middleware\.ci\out\Network\CM4\Debug\Network.lib
Reproducer:
https://github.com/ARM-software/MDK-Middleware/tree/main/.ci
cbuild library.csolution.yml --toolchain AC6

Tool
CMSIS-Toolbox 2.5.0 on Windows

The message originates from CMake that historically uses this terminology even for archiver calls, as it can be seen in its source code for Ninja and Unix Makefiles generators:
https://gitlab.kitware.com/cmake/cmake/-/blob/v3.30.2/Source/cmNinjaNormalTargetGenerator.cxx?ref_type=tags#L592
https://gitlab.kitware.com/cmake/cmake/-/blob/v3.30.2/Source/cmMakefileLibraryTargetGenerator.cxx?ref_type=tags#L556
I wouldn't recommend any action in cbuild.

Reject, as this is standard CMake terminology.


Made the fib benchmark a bit faster

This way fib.wren was consistently about 6% faster for me.
Feel free to close this pull request if the alternative notation deviates too much from the other languages. I found it mainly interesting that apparently free functions are slower to work with than classes, at least in this case. It's probably because of the recursive calls saving one lookup?
Note that the static did not matter much in the benchmark at all, I only wrote that to simplify things. The same speed advantages was present when leaving it out and doing var fib = new Fib instead.

I think the goal is to compare functions across languages, thus even if Fn is slower, that's what should be benchmarked.

I found it mainly interesting that apparently free functions are slower to work with than classes, at least in this case. It's probably because of the recursive calls saving one lookup?

My guess is that it's because functions have to handle checking the arity at runtime where method calls rely on the static signature to handle that. I'd have to profile to see.

I think the goal is to compare functions across languages, thus even if Fn is slower, that's what should be benchmarked.

Yeah, I agree with you in general. But I think this patch is OK. Methods are the natural way to define something callable in Wren. For example, a C# or Java benchmark would likely use method calls for this too even though they both also have more direct first-class function-like things.


Fixing acceptance tests

Fixes the failing tests that have been plaguing us for a week
Additions

All the NPM packages that aren't getting installed currently

Changes

Temporarily disabled a test due to macro flux with the change to Wagtail. Will see about updating for it in another PR.

Testing

run ./setup.sh && gulp test:acceptance:browser --sauce=false

Review

@anselmbradford
@kave
@kurtw
@sebworks

Todos

Fix the related links in the blog sidebar

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

:+1:

:+1:

It appears I'm the only one having the dependency installation issue, so I've removed the changes to package.json and reduced the PR to silencing the related-posts test until that macro can be fixed.

:+1:  tested all pass

:+1:


More CouchPotato debugging...

Michael - after implementing your latest commits, I'm still having trouble with the script in CouchPotato:
11-05 00:02:43 INFO
[ PostProcess] MP4 Automator - Post processing script initialized
11-05 00:02:43 INFO
[ PostProcess] Executing post processing on file /volume1/DiskStation/Movies/Movie.mkv with IMDB ID tt2381249
11-05 00:02:45 INFO
[ PostProcess] 2015-11-05 00:02:44 - CouchPotatoPostConversion - INFO - MP4 Automator - Post processing script initialized 2015-11-05 00:02:44 - readSettings - WARNING - Audio bitrate was invalid, defaulting to 256 per channel. 2015-11-05 00:02:44 - readSettings - WARNING - Invalid external subtitle codec mov_text, defaulting to 'srt'. 2015-11-05 00:02:44 - CouchPotatoPostConversion - INFO - Processing file: /volume1/DiskStation/Movies/Movie.mkv 2015-11-05 00:02:44 - CouchPotatoPostConversion - INFO - File is valid 2015-11-05 00:02:44 - mkvtomp4 - INFO - Reading video stream. 2015-11-05 00:02:44 - mkvtomp4 - INFO - Video codec detected: h264. 2015-11-05 00:02:44 - mkvtomp4 - INFO - Pix Fmt: yuv420p. 2015-11-05 00:02:44 - mkvtomp4 - INFO - Reading audio streams. 2015-11-05 00:02:44 - mkvtomp4 - INFO - Audio detected for stream #1: ac3 [eng]. 2015-11-05 00:02:44 - mkvtomp4 - INFO - Creating audio stream 0 from source audio stream 1 [iOS-audio]. 2015-11-05 00:02:44 - mkvtomp4 - INFO - Creating audio stream 1 from source stream 1. 2015-11-05 00:02:44 - mkvtomp4 - INFO - Reading subtitle streams. 2015-11-05 00:02:44 - mkvtomp4 - INFO - Subtitle detected for stream #2: srt [dut]. 2015-11-05 00:02:44 - mkvtomp4 - INFO - Subtitle detected for stream #3: srt [eng]. 2015-11-05 00:02:44 - mkvtomp4 - INFO - Starting conversion. 2015-11-05 00:02:44 - CouchPotatoPostConversion - ERROR - File processing failed: /volume1/DiskStation/Movies/Movie.mkv Traceback (most recent call last): File "/usr/local/couchpotatoserver/scripts/sickbeard_mp4_automator/postCouchPotato.py", line 33, in  output = converter.process(inputfile, original=original) File<EMAIL_ADDRESS>line 149, in process outputfile, inputfile = self.convert(inputfile, options, reportProgress) File<EMAIL_ADDRESS>line 565, in convert for timecode in conv: File<EMAIL_ADDRESS>line 243, in convert timeout=timeout, preopts=preopts, postopts=postopts): File<EMAIL_ADDRESS>line 473, in convert p = self._spawn(cmds) File<EMAIL_ADDRESS>line 378, in _spawn close_fds=(os.name != 'nt'), startupinfo=startupinfo) File "/lib/python2.7/subprocess.py", line 710, in init errread, errwrite) File "/lib/python2.7/subprocess.py", line 1335, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings
11-05 00:02:45 INFO
[ PostProcess]
11-05 00:02:45 INFO
[ PostProcess] Return code: 0
I'll continue to help as I can!  :+1:

Hm something very odd is going on, the commit that I pushed only added a very small amount of debugging to the code, nothing that could have resolved your issue or fixed anything. Quite odd. Can't help but wonder if there's just something weird about your python environment that's causing these problems.
That being said, there are a couple things we can try with the new error.
I just pushed a new commit that modified ffmpeg.py and should run through all the command line parameters and ensure they are strings, which may help prevent the error you're getting, but I can't imagine why you would be getting it in the first place.
I'm actually wondering if for some reason python3 might be getting called for some reason on synology. Is python3 even installed on your box?

mdhiggins - I believe I have this sorted.  Attempting to alter code at 1AM after a full day of work is never healthy.  CouchPotato now functioning beautifully w/the latest commit.  I honestly don't know what the problem was - but I went ahead and wiped Python 2.7, CouchPotato, and SickRage and reinstalled anew.  Working flawlessly now - thank you for all your efforts w/this script - it's simply awesome and saves me countless hours.  Kudos.

Glad its all working, not quite sure what resulted in the fix but good news either way. Enjoy!


ci: update codecov action to v4, set verbose to true

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (ffbd55e) to head (357eba3).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          310       310
=========================================
  Hits           310       310

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Anopheles refactor part 1 - AnophelesBase

This PR begins the work of breaking up the AnophelesDataResource class into a number of smaller classes with related and self-contained functionality, as proposed in #366.
Here a new class AnophelesBase is created, which assumes responsibility for loading release configuration and accessing release manifests (sample sets).
Note also that some new tests are added which specifically test this new class. These new tests use locally-created data which mimics the organisation and format of data in Ag3 and Af1 but is local and smaller to allow for faster test runs.
Also resolves #368 along the way.

Keen to push ahead here so planning to merge soon if no objections, but please shout if you'd like more time to review.

Thanks @leehart :pray:

Sent from my iPhoneOn 31 Mar 2023, at 17:06, Alistair Miles @.***> wrote:
Keen to push ahead here so planning to merge soon if no objections, but please shout if you'd like more time to review.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

Sorry was at the pub Sent from my iPhoneOn 31 Mar 2023, at 17:06, Alistair Miles @.***> wrote:
Keen to push ahead here so planning to merge soon if no objections, but please shout if you'd like more time to review.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>


connection errors with loopback http2 upgrade

PR #100 fails in "a" -> "a" case:
kubectl exec -it a-3708111894-q8dx0 client http://a/a
-- error
kubectl exec -it a-3708111894-q8dx0 client http://b/a
-- works fine

Here the debug log from envoy:
[2017-02-08 18:06:58.109][17][info][main] [C16] new connection
[2017-02-08 18:06:58.110][17][info][client] [C17] connecting
[2017-02-08 18:06:58.111][17][info][client] [C17] protocol error: The user callback function failed
[2017-02-08T18:06:58.110Z] "GET /a HTTP/1.1" 503 UC 0 57 2 - "-" "Go-http-client/1.1" "06c8f613-0618-408f-9a62-230286b91d2c" "a" "tcp://<IP_ADDRESS>:8080"

@lizan @myidpt might be relevant to your issues with auto-upgrade to TLS


Tensorboard logger logdir is not consistent in DDP mode

🐛 Bug
When the tensorboard logger is created, loggers on all ranks will have different (inconsistent) log directories, even though directories are only created on rank 0.
To Reproduce
See: https://gist.github.com/DavidMChan/9c1fbc6e61031f2fe6014c01ddd5850b for reproducible code.
The above code produces:
LOCAL_RANK: 1 - CUDA_VISIBLE_DEVICES: [0,1]
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0,1]
.../data_loading.py:105: UserWarning: The dataloader, test dataloader 0, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 24 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  rank_zero_warn(
Testing: 0it [00:00, ?it/s]
.../lightning_logs/version_24
.../lightning_logs/version_24
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_24
.../lightning_logs/version_23
.../lightning_logs/version_23
.../lightning_logs/version_23
.../lightning_logs/version_23
--------------------------------------------------------------------------------
DATALOADER:0 TEST RESULTS
{'test_loss': -0.23455876111984253}
--------------------------------------------------------------------------------

Expected behavior
Logger variables should be consistent between ranks. Presumably, it's not only the log directory, but other variables as well.
Environment
* CUDA:
        - GPU:
                - GeForce RTX 3090
                - GeForce RTX 3090
        - available:         True
        - version:           11.1
* Packages:
        - numpy:             1.21.2
        - pyTorch_debug:     False
        - pyTorch_version:   1.10.0.dev20210815+cu111
        - pytorch-lightning: 1.4.2
        - tqdm:              4.62.1
* System:
        - OS:                Linux
        - architecture:
                - 64bit
                - ELF
        - processor:         x86_64
        - python:            3.8.11
        - version:           #71~20.04.1-Ubuntu SMP Thu Jul 15 17:46:08 UTC 2021

Additional context
At least having a globally consistent record of the log directory would be nice, since I am producing artifacts on the different ranks that I would like to save to disk. This gets a bit more confusing as you scale to multiple nodes, but right now, the folders returned on ranks that are not 0 don't even exist. An option when using DDP to sync the log directory, or a global option for writing pickleable objects to the rank-0 log directory would be great. Alternatively, making it so calling this property on a rank that is not 0 raises an error would be more user-friendly until there is a long-term solution is probably a good idea.

@DavidMChan I think that's because of this line in your code:
print(self.logger.log_dir)
The better option is to access self.trainer.log_dir which is synchronized and will return a consistent result.
We should communicate that better to users and not let them access self.logger.log_dir.

Ah, thanks! This is good to know. I followed the issue here: https://github.com/PyTorchLightning/pytorch-lightning/issues/2370, which is now outdated, I suppose.
Since this is already in the docs here (And I'm just blind), I don't know if this is really an issue.

Yes it's not a big issue, but we need to increase visibility in the docs in the logging section. Thanks

If we just need to update the docs to tell not to use logger.log_dir , I can do it.

What exactly should I add to the logger docs ?
Just a note saying, call the self.trainer.log_dir instead of self.logger.log_dir or something else ?
And are the logger docs a good page for this, Ig this would be better in the Trainer docs


change the cursour to pointer

it's not a huge issue but it would be awesome of the cursor changed to pointer while hovering (event.key, event.location....)

Hi, thanks for your filing this issue. Just wanted to mention that cursor: pointer css property mainly indicates a link, as mentioned in MDN docs also. But the four divs here for all main events are not actually links but a card container. Only text like (?) next to event.location and (deprecated) text next to event.which are links and they already have cursor: pointer styling, added by the browser as a default behaviour. I hope that makes sense.

Thanks a lot for the "feedback", that does make a lot of sense. Do you think letting users copy the key code by double clicking the numbers is a good idea?
Sent from my iPhone

On Jun 26, 2019, at 2:38 AM, Palash Mondal<EMAIL_ADDRESS>wrote:
Hi, thanks for your filing this issue. Just wanted to mention that cursor: pointer css property mainly indicates a link, as mentioned in MDN docs also. But the four divs here for all main events are not actually links but a card container. Only text like (?) next to event.location and (deprecated) text next to event.which are links and they already have cursor: pointer styling, added by the browser as a default behaviour. I hope that makes sense.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes, that can be a nice utility feature. I will try to look into this on weekend.

... onclick = 'copy()' / >

function copy(){
document.execCommand("copy");
}
On Thu, Jun 27, 2019 at 9:38 AM Palash Mondal<EMAIL_ADDRESS>wrote:

Yes, that can be a nice utility feature. I will try to look into this on
weekend.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wesbos/keycodes/issues/269?email_source=notifications&email_token=AKKKUIWQQ7QV4NDHZSUQW5LP4S7GVA5CNFSM4H3MYA42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXESIQ#issuecomment-506349858,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKKKUISIC3NAPPM6KPVWCWTP4S7GVANCNFSM4H3MYA4Q
.


Migrate org.wso2.transport.http.netty module into HTTP module

Purpose

Transform project management from maven into gradle
Migrate org.wso2.transport.http.netty into http module including git history
Refactor test cases
Remove unnecessary dependencies

Fixes #24548
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[x] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Changes will be added via ballerina-platform/module-ballerina-http#75, hence closing the PR


Generating a report of all bugs can run out of memory

Currently we write all the bug reports into a StringBuilder, but the very large stack traces can cause the JVM to run out of memory. Reports should be written directly to stdout.

Be sure to use the out field rather than System.out. So that we can redirect IO for testing.


Don't insert text blocks when Return is pressed if the Control or Command keys are held down

This fixes an issue in PencilCode where the shortcut to run the current program (Command-Return, or Control-Return on Linux/Windows) would also inadvertently add a new blank text block. Shift-Return was already excluded from inserting a new block.

LGTM


Added cluster-broadcast example + updated the cluster examples

Merge latest dev.
Connected with this PR
Can you have a look @rogeralsing ? :)

LGTM


fix model controller

Add InferenceService API to controller scheme
Update model controller module name

This PR should fix the following error
1.662477753609541e+09 ERROR setup unable to create controller {"controller": "InferenceService", "error": "no kind is registered for the type v1beta1.InferenceService in scheme \"go/pkg/mod/k8s.io/apimachinery@v0.24.2/pkg/runtime/scheme.go:100\""}

I'm in the process of testing out the newly built image now.

/lgtm


Hang when call remote

WSL2:
Output of helm version:  version.BuildInfo{Version:"v3.12.0", GitCommit:"c9f554d75773799f72ceef38c51210f1842a1dea", GitTreeState:"clean", GoVersion:"go1.20.3"}
Output of kubectl version: WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.2", GitCommit:"7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647", GitTreeState:"clean", BuildDate:"2023-05-17T14:20:07Z", GoVersion:"go1.20.4", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v5.0.1
SERVER:
Output of helm version:  version.BuildInfo{Version:"v3.12.0", GitCommit:"c9f554d75773799f72ceef38c51210f1842a1dea", GitTreeState:"clean", GoVersion:"go1.20.3"}
Output of kubectl version: WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.2", GitCommit:"7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647", GitTreeState:"clean", BuildDate:"2023-05-17T14:20:07Z", GoVersion:"go1.20.4", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v5.0.1
I have the problem that helm hangs in 90% of the time I use it from windows/wsl2:
$ HELM_DEBUG=1 helm install -f traefik.yaml traefik traefik/traefik --dry-run -v 999
I0529 17:31:23.123304   85348 loader.go:373] Config loaded from file:  /home/xxx/.kube/config
I0529 17:31:23.123528   85348 loader.go:373] Config loaded from file:  /home/xxx/.kube/config-test
install.go:200: [debug] Original chart version: ""

it will never get any further.
The remaining 10% it works just fine
$ HELM_DEBUG=1 helm install -f traefik.yaml traefik traefik/traefik --dry-run -v 999
I0529 17:51:48.042988   92279 loader.go:373] Config loaded from file:  /home/xxx/.kube/config
I0529 17:51:48.043484   92279 loader.go:373] Config loaded from file:  /home/xxx/.kube/config-test
install.go:200: [debug] Original chart version: ""
install.go:217: [debug] CHART PATH: /home/xxx/.cache/helm/repository/traefik-23.0.1.tgz

I0529 17:51:48.478543   92279 loader.go:373] Config loaded from file:  /home/xxx/.kube/config
I0529 17:51:48.479299   92279 loader.go:373] Config loaded from file:  /home/xxx/.kube/config-test
another 350000 lines

If I run it directly on the server, it works just fine.
It doesnt matter which chart I try to install

This seems like an issue with the environment (WSL). Can you identity the problematic syscall with e.g. strace?

Sorry, it took a while to figure out how to repro consistently.
I was able to consistently get it on a helm depencency update with 2+ remote subchart.
If i run strace with output to console, these are the last lines it shows:
[pid  1630] sched_yield( <unfinished ...>
[pid  1628] epoll_pwait(4,  <unfinished ...>
[pid  1630] <... sched_yield resumed>)  = 0
[pid  1628] <... epoll_pwait resumed>[], 128, 0, NULL, 0) = 0
[pid  1630] futex(0x3457660, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
[pid  1628] epoll_pwait(4,  <unfinished ...>
[pid  1630] <... futex resumed>)        = 0
[pid  1630] futex(0xc000100148, FUTEX_WAIT_PRIVATE, 0, NULL <unfinished ...>
[pid  1627] <... nanosleep resumed>NULL) = 0
[pid  1627] futex(0x3458c60, FUTEX_WAIT_PRIVATE, 0, {tv_sec=60, tv_nsec=0}

There seems to be some differences between running with output to file and output to console though, but I think the line matching is 13632 in hang.log.
If you leave it running, this happens:
) = -1 ETIMEDOUT (Connection timed out)
[pid  1627] nanosleep({tv_sec=0, tv_nsec=10000000}, NULL) = 0
[pid  1627] futex(0x3458c60, FUTEX_WAIT_PRIVATE, 0, {tv_sec=60, tv_nsec=0}

and then hang again... It will do this a couple of times. Sometimes making progress, other times not.
I attached another strace file for this. Where you can see that eventually it will finish, but I think this update took 90+min to complete (I started it 20 min before I went to a long lunch, but there is 745 futex timeouts) vs the 2 seconds it usually takes.
I also attached a stacktrace using kill -QUIT pid
hang.zip
hang-wait.zip
stacktrace.zip

@gjenkins8 had a chance to take a look at it?

poke

still an issue?


Flow >= 0.58 continuously crashes with SIGSEGV, does not start

I made some changes to my project in https://github.com/metabrainz/musicbrainz-server/pull/574 which cause flow to no longer start; the server monitor logs just show Flow server (pid ...) was killed with sigsegv signal repeatedly. This happens on OS X and Linux.
v0.57.3 is the last working version.
I haven't been able to isolate the issue other than this: if I remove ./node_modules/immutable/dist/immutable.js.flow from [libs] in my .flowconfig, it no longer crashes (but is missing those types).
How to reproduce:
git clone https://github.com/metabrainz/musicbrainz-server.git
cd musicbrainz-server
npm install
npm install -g<EMAIL_ADDRESS>flow

I've attached a crash report from v0.60.1.
flow_2017-12-05-124315_Michaels-MacBook-Pro-2.txt

This appears to have been fixed in 0.102.0 (0.101.1 and prior releases still being broken). Unclear how from the changelog.


IoM, Jersey, and Guernsey

Should be a simple country code expansion...but doesn't appear to be taking effect. See #333

Hmm it looks more like I'm probably using Country Coder wrong.
This is what I get when I ask it directly using aggregateFeature, which returns all of the members as a MultiPolygon:
let cc = require('@ideditor/country-coder');
let f = cc.aggregateFeature('gb');
JSON.stringify(f);

So I'm going to dig into what location-conflation is doing wrong.  Turf is supposed to union all of those  polygons together, but maybe it's not.

closing here, as the bug is upsteream - see #333


gen_swupdate.py: fix libconfig include path

There is no need to switch to temporary directory before parsing the template. There is also the possibility to use the (absolute) template directory in libconf.parse(), but moving the change of the working directory also works fine.

Thanks Holger!


Consider using WebGPU Bundles to improve performance

WebGPU Bundles can be used to record and very cheaply render static content, and we should explore the ways this can be used to limit the amount of gpu commands we need to submit each frame.

https://toji.dev/webgpu-best-practices/render-bundles.html


Fix application registration

Summary of the Pull Request
What is this about?
PR Checklist

[ ] Applies to work item: #xxx
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?

Isn't the microsoft.onmicrosoft.com going to be specific to the Microsoft tenant on Azure?

I believe this is OBE for #1243


Blocks [Some questions]

Hello again. I have some blocks options:
I was able to create this three blocks;
'blocks'   => [
            'title'     => [
                'title'     => 'Title',
                'icon'      => 'text',
                'component' => 'a17-block-title',
            ],
            'images'    => [
                'title'     => 'Image',
                'icon'      => 'image',
                'component' => 'a17-block-image',
            ],
            'contenido' => [
                'title'     => 'Content',
                'icon'      => 'text',
                'component' => 'a17-block-wysiwyg',
            ],
        ],

I create this views inside resources\views:

How I can render for example the title? What I should put in blocks and title views to show the title?
I just be able if I modify the BlocksController@preview method and override the last lines to:
$view = view(config('twill.block_editor.block_single_layout'))->with('content', $renderedBlocks);

return html_entity_decode($view);

So in the title.blade I can see the preview using:

{{ $block->translatedinput('text') }}

Also, if I attach some image to the Image block, when I save, no mediable is set. So when reload there isn't image.
Thanks!

Hi @Krato!
What's the content of your block.blade.php layout?
As long as you yield a content section, you shouldn't have to override the BlocksController@preview method.
@yield('content')

As you can see below, Twill injects rendered blocks into the content section of your block layout.
https://github.com/area17/twill/blob/4d58468db4c2aec3bcbb7ed8c8de3dfb78c5240b/src/Http/Controllers/Admin/BlocksController.php#L60-L64
As for the image not saving in a block, it could be that you are missing crop parameters into your blocks config. See the default configuration:
https://github.com/area17/twill/blob/4d58468db4c2aec3bcbb7ed8c8de3dfb78c5240b/config/blocks.php#L17-L62
Are you trying to use the default provided image block or did you create you own? The default one has a medias field called image, which is why you can see above that the crops array has an image key with 3 crops defined. You can of course change it in your project by removing or adding crops and options. If your block uses a medias field with a different name, you would need to reference it there.
I see that apart from being shown in the configuration section of our docs, this isn't explained in the dedicated block editor section. Adding to my list of docs improvements to do!

Hey @Krato, I'm closing this as it looked like it wasn't a bug but more of a configuration issue. Feel free to follow up here or create another issue if you're still running into any trouble.


[10.x] Additional string helpers for longerThan, shorterThan, and pregReplace

Additional string helpers and methods to the Stringable object to support

longerThan
shorterThan
pregReplace

I have found these useful where I want to keep everything very fluent without needing temporary variables or switching coding modalities.
I also ran into some testing issues when testing the Stringable object with a missing class.  This has been broken into a separate file to allow for independent testing of tests/Support/SupportStrTest.php and tests/Support/SupportStringableTest.php.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


nnUnet Training Crashes on Random Batches

Training crashes during the first epoch, validation, or second epoch with an unclear message - worker is no longer alive. Batch sampling is random, so this is tricky to reproduce. Further, data loading is parallelized, so a debug breakpoint cannot be used to see what is wrong with the data. The crash happens at this stage which could be either data loading or training itself:
nnunetv2/training/nnUNetTrainer/nnUNetTrainer.py
self.train_step(next(self.dataloader_train))

Resolve and add tools to debug this in the future.

The training is not gated by data loading - one epoch with one thread vs 8 threads takes just as long. Unfortunately, I am still experiencing the crash with the below error trace. Switching to non-parallel loading as it is a successful workaround without any observed slowdown. Changing number of processes to 0 (which actually means one) by default in
run_training.py
parser.add_argument('--num_proc', type=str, default=0,
                        help="Select the number of parallel data loading processors. Use 0 for non-parallel debug.")

Exception ignored in tp_clear of: <class 'memoryview'>
Traceback (most recent call last):
File "D:\Programs\anaconda3\envs\nnunet\Lib\threading.py", line 1483, in current_thread
def current_thread():
BufferError: memoryview has 1 exported buffer
Exception in thread Thread-12 (results_loop):
Traceback (most recent call last):
File "D:\Programs\anaconda3\envs\nnunet\Lib\threading.py", line 1073, in _bootstrap_inner
self.run()
File "D:\Programs\anaconda3\envs\nnunet\Lib\threading.py", line 1010, in run
self._target(*self._args, **self._kwargs)
File "D:\Programs\anaconda3\envs\nnunet\Lib\site-packages\batchgenerators\dataloading\nondet_multi_threaded_augmenter.py", line 125, in results_loop
raise e
File "D:\Programs\anaconda3\envs\nnunet\Lib\site-packages\batchgenerators\dataloading\nondet_multi_threaded_augmenter.py", line 103, in results_loop
raise RuntimeError("One or more background workers are no longer alive. Exiting. Please check the "
RuntimeError: One or more background workers are no longer alive. Exiting. Please check the print statements above for the actual error message
Exception ignored in tp_clear of: <class 'memoryview'>
BufferError: memoryview has 1 exported buffer
Traceback (most recent call last):
File "D:\Programs\PyCharm Community Edition 2023.3.4\plugins\python-ce\helpers\pydev\pydevd.py", line 1534, in _exec
pydev_imports.execfile(file, globals, locals)  # execute the script
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\Programs\PyCharm Community Edition 2023.3.4\plugins\python-ce\helpers\pydev_pydev_imps_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "D:\Source\torch-control\nnUNet\run_training.py", line 74, in
run_training_entry()
File "D:\Source\torch-control\nnUNet\run_training.py", line 67, in run_training_entry
run_training(args.dataset_name_or_id, args.configuration, args.fold, args.tr, args.p, args.pretrained_weights,
File "D:\Source\torch-control\nnUNet\nnunetv2\run\run_training_api.py", line 204, in run_training
nnunet_trainer.run_training()
File "D:\Source\torch-control\nnUNet\nnunetv2\training\nnUNetTrainer\nnUNetTrainer.py", line 1276, in run_training
train_outputs.append(self.train_step(next(self.dataloader_train)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\Programs\anaconda3\envs\nnunet\Lib\site-packages\batchgenerators\dataloading\nondet_multi_threaded_augmenter.py", line 196, in next
item = self.__get_next_item()
^^^^^^^^^^^^^^^^^^^^^^
File "D:\Programs\anaconda3\envs\nnunet\Lib\site-packages\batchgenerators\dataloading\nondet_multi_threaded_augmenter.py", line 181, in __get_next_item
raise RuntimeError("One or more background workers are no longer alive. Exiting. Please check the "
RuntimeError: One or more background workers are no longer alive. Exiting. Please check the print statements above for the actual error message


Change 'apply online' button

The "Apply Online" section doesn't apply for our version of the site:

We probably just want to remove it, and keep some version of what's beneath it (where to pick up / send a paper application)

I don't think we actually need to do work here: the "Apply Online" button is only present if the listing.applicationMethods includes either ApplicationMethodType.Internal or ApplicationMethodType.ExternalLink. We don't expect to ever import listing data that has either of those application methods, so the "Apply Online" button should never show up.
A related observation: since the ArcGIS data doesn't include anything that fits into the application methods that Bloom knows about, the ApplicationSection React component is not present at all. There is, however, a "Contact Leasing Agent" section that does appear and we could use:

I'll file a separate bug about this, and include this in the conversation about getting data from property managers.


Monthly and Yearly posts are not being regenerated when Daily posts are updated

The monthly and yearly posts should be regenerated when the daily post has been updated.  They are not.  It does not even look like watcher is noticing that the file has been modified.

Resolved in 52ae7a0c4460a570e26f6291c30c21474b250976 by adding in the missing code to the .on('change') event of Watcher.


The user should be able to login

Prerequisites

[x] I have written a descriptive issue title
[x] I have verified that I am running the latest version of the UI-DSM
[x] I have searched open and closed issues to ensure it has not already been reported

Description

The application should provide a way to login to a COMET WebServices
Steps to Reproduce

System Configuration

UI-DSM version:

[ ] UI-DSM:
[ ] Other:

Environment (Operating system, version and so on):
.NET Framework version:
Additional information:

After discussion, the UI-DSM has to get it own User Management. Need to refactor what has been done


Ember data store is undefined when injected into service tested with mirage

Not sure if this is a mirage issue or a more general problem with how I'm trying to do testing.  First, thank you for this fantastic library.
I have a service called validator that I inject the ember data store into.  The store is required because some of the validations provided by the validator service check against the server to see if for example a username already exists.
// /app/initializer/validator.js
export function initialize (container, app) {
  // Inject the Ember Data Store into our validator
  app.inject('service:validator', 'store', 'store:main');
}

export default {
  name: 'validator',
  initialize: initialize
};

The validator then has a snippet that looks like this:
// /app/services/validator.js
import Ember from "ember";

export default Ember.Service.extend({
     username: function(username, options){
          var self = this;
          return new Ember.RSVP.Promise(function(resolve, reject){
               self.store.filter('user', function(user){
                     return user.get('username') === username;
               }).then(function(users){
                     if(users.get('length') > 0){
                           resolve('Username already exists');
                     }else{
                       resolve(null);
                     }
              });
          });
     }
});

I've setup a factory to create user data and a config for the users REST API point.
The problem I've run into is that the store object in the validator is undefined when calling the validator service in a test.  Here's an example test:
test('[username] cannot be less than minimum length', function(assert){
  assert.expect(1);
  var validator = this.subject();
  var input = 'u';
  var expectedOutput = 'Username must be at least 2 characters';

  validator.username(input).then(function(validationMessage){
    assert.equal(validationMessage, expectedOutput);
  });
});

and the error:
TypeError: 'undefined' is not an object (evaluating 'self.store.filter') at http://localhost:7357/assets/my-project.js, line 2122

Could this be Mirage related or am I just setting up the test wrong in a more general sense?
Thank you!

I believe this is because the container isn't initialized in unit tests. I think they're working on integration tests but for now, I would just throw this in an acceptance test (you can call it /tests/integration or something), and import startApp and run it
import startApp from 'your-app/tests/helpers/start-app';

module('your service', {
  beforeEach: function() {
    application = startApp();
  },

  afterEach: function() {
    Ember.run(application, 'destroy');
  }
});

and see if that works.

Thank you very much for the additional info.  For anyone else trying to do this I booted the app as pointed out by samselikoff and imported the service like this:
var application;
var validator;
module('Service | Validator', {
  beforeEach: function() {
    application = startApp();
    validator = application.__container__.lookup('service:validator');
  },
  afterEach: function() {
    Ember.run(application, 'destroy');
  }
});

This seems to allow me to test the service and ensure the service has access to the ember data store which gets injected via an initializer.
I think I've run into an issue in that my usage of this.store.filter does not include a query (no query params) and as a result does not issue a request to the server, and therefore mirage does not get a chance to send back data from the factory I created.
Just to test I added in a query so that my call looks like:
self.store.filter('user', function(user){
    return user.get('username') === username;
})

This ensures a database request each time a validation is done.  Unfortunately, I'm now getting the following error:
Assertion Failed: The response from a findQuery must be an Array, not undefined

I believe this is caused by this error which I can see in the browser:
Mirage: Your custom function handler for the url /v1/users?limit=100 threw an error: db.users.all is not a function TypeError: db.users.all is not a function

I have a factory called /app/mirage/user.js (singular as in the examples) and my route looks like
  this.get('/users', function(db, request) {
    return db.users.all(); // <-- this is what is failing
  });

I populate the db using:
server.createList('user', 10);

I do see the users array in the db object but do not see an all method.  If I just return the db things work:
  this.get('/users', function(db, request) {
    return db; // <-- this works because the db object contains a users array which is what ember data is expecting
  });

The current API is just db.users to return the collection. .all is going to
be the future api but it hasn't landed yet - where did you see it?
On Mon, Jun 8, 2015 at 10:45 PM Ed Dorsey<EMAIL_ADDRESS>wrote:

Thank you very much for the additional info. For anyone else trying to do
this I booted the app as pointed out by samselikoff and imported the
service like this:
var application;var validator;module('Service | Validator', {
beforeEach: function() {
application = startApp();
validator = application.container.lookup('service:validator');
},
afterEach: function() {
Ember.run(application, 'destroy');
}
});
This seems to allow me to test the service and ensure the service has
access to the ember data store which gets injected via an initializer.
I think I've run into an issue in that my usage of this.store.filter does
not include a query (no query params) and as a result does not issue a
request to the server, and therefore mirage does not get a chance to send
back data from the factory I created.
Just to test I added in a query so that my call looks like:
self.store.filter('user', function(user){
return user.get('username') === username;
})
This ensures a database request each time a validation is done.
Unfortunately, I'm now getting the following error:
Assertion Failed: The response from a findQuery must be an Array, not undefined
I believe this is caused by this error which I can see in the browser:
Mirage: Your custom function handler for the url /v1/users?limit=100 threw an error: db.users.all is not a function TypeError: db.users.all is not a function
I have a factory called /app/mirage/user.js (singular as in the examples)
and my route looks like
this.get('/users', function(db, request) {
return db.users.all(); // <-- this is what is failing
});
I populate the db using:
server.createList('user', 10);
I do see the users array in the db object but do not see an all method.
If I just return the db things work:
this.get('/users', function(db, request) {
return db; // <-- this works because the db object contains a users array which is what ember data is expecting
});
—
Reply to this email directly or view it on GitHub
https://github.com/samselikoff/ember-cli-mirage/issues/164#issuecomment-110202709
.

@samselikoff Saw it on the quick start guide:
http://www.ember-cli-mirage.com/docs/latest/quickstart/
Dynamic data

In the examples above, we wrote the response data directly in the route. Instead of doing this, Mirage provides a simple in-memory database you can use to make your routes more versatile.

The database is injected into each route handler as the first parameter:

this.get('/api/users', function(db) {
  return db.users.all();
});
Route handlers can also create, update and delete database records.
Now, Mirage will respond to this route with all the user records in its database. To seed your database with data, you can use fixtures or factories.

As long as all your Mirage routes read from and write to the database, user interactions will persist during a single session. This lets users interact with your app as if it were wired up to a real server.

View the full database API to see how your routes can interact with your data.

Was I using this in the wrong context?

whoops, that's definitely not the current api. Sorry! that shouldn't be in there.
Right now it's just db.collection: http://www.ember-cli-mirage.com/docs/latest/database/#collection

should be fixed. oy, I can't believe that was wrong like, everywhere. I've been spending too much time in the new models branch (where this api has changed) - thanks so much for pointing this out!

No Problem!  Thanks for the great library =)  Got everything working now.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 10:18:29 on 2023.08.22
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 0, errors out: 0
Original problem ID: 86430
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=86430

Problem has been resolved in 3m 0s at 10:21:29 on 2023.08.22
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 86430


Updating from an old version to 1.0(22) causes a crash

Bug Description
If you have an old version of the mobile wallet installed, e.g. 1.0(6) and then update 1.0(22), the app will crash upon reopening it. On iOS 14.7 it will give a pop-up saying that the app has crashed and on iOS 15 the app will show for a split second, before just disappearing without any pop-ups.
This might be related to the iOS 15 SDK upgrade.
Steps to Reproduce

Install an old version of the app, e.g. 1.0(6), set it up and maybe populate it with a bit of data.
Update to 1.0(22) without uninstalling the old version first.
Try to open the app, and notice how it crashes.

Expected Result

The app opens after update without problems.

Actual Result

The app cannot be opened after an update to 1.0(22), because it crashes immediately.

Versions

Software Version: 1.0(22)
OS: iOS 14.7 and 15

Checked on iOS 14.7.1.
Fixed in 1.0.23.


URL of public group info doesn't work as external link

Example foodsharing UIO:
When accessing the public group info via the group overview page at https://karrot.world/#/groupInfo it successfully leads to the public info page and displays the URL https://karrot.world/#/groupInfo/31. When reloading the page, as well as trying to directly access above-mentioned link one gets to this page instead of the info one:

I tried another group and it was the same.

Tried it on my phone and it works… maybe it fails under mysterious circumstances?
@djahnie, can you look into your browser console and see if there is something suspicious? Thanks!

I can re-create it here on my desktop browser (firefox), it fails every time. No console errors.
If I press the "TAKE ME HOME" (to the plaaaaaaaaaaaaaaace where I beelooooong, wwwwwest virgiiiiiniiiaaaaaaaaaaaaa, mountain mooooooooomaaaa, taaaake me hooooooooome, couuuuuntry roads. ahem) button, it briefly shows me the correct group info landing page, before going home.
I think the route error data is being set erroneously. Perhaps timing sensitive to the group info data loading.

Interested how that can happen, don't we await the fetching of groups in main.js?
My laptop is over at the neighbour for charging (still no electricity here…), so I can't have a look myself.

I fixed it the easy way in master without understanding all the details - I think some of the errors come from unclean separation between currentGroup and groupInfo stuff because they live together in the groups module, but have not much in common. I think it would be good to split them up...


cleaning and remove displays withAcl

@jeff-zucker
I followed your conseil : I commented out the displays withAcl in index.html
Kept the code in solid-ide.js and changes in main.css
You can test it at https://bourgeoa.github.io/solid-ide/

Why does it default to showing .acl links?  It makes all folder reading
very slow.  My suggestion was that we not show any linked resources until
we have a way for users to create and edit those resources.
On Fri, Jan 10, 2020 at 11:20 AM Alain Bourgeois<EMAIL_ADDRESS>wrote:

@jeff-zucker https://github.com/jeff-zucker
I followed your conseil : I commented out the displays withAcl in
index.html
Kept the code in solid-ide.js and changes in main.css
You can test it at https://bourgeoa.github.io/solid-ide/
You can view, comment on, or merge this pull request online at:
https://github.com/jeff-zucker/solid-ide/pull/20
Commit Summary

cleaning and remove displays withAcl

File Changes

M assets/main.css
https://github.com/jeff-zucker/solid-ide/pull/20/files#diff-0 (11)
A assets/padlock-timbl.svg
https://github.com/jeff-zucker/solid-ide/pull/20/files#diff-1 (8)
M index.html
https://github.com/jeff-zucker/solid-ide/pull/20/files#diff-2 (108)
M solid-ide-solidHandler.js
https://github.com/jeff-zucker/solid-ide/pull/20/files#diff-3 (157)
A solid-ide-solidSession.js
https://github.com/jeff-zucker/solid-ide/pull/20/files#diff-4 (79)
M solid-ide.js
https://github.com/jeff-zucker/solid-ide/pull/20/files#diff-5 (406)

Patch Links:

https://github.com/jeff-zucker/solid-ide/pull/20.patch
https://github.com/jeff-zucker/solid-ide/pull/20.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jeff-zucker/solid-ide/pull/20?email_source=notifications&email_token=AKVJCJD65NUQCDVULHL5CRTQ5DC6NA5CNFSM4KFME5T2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IFNSWNQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKVJCJDUOFXYU44VYR7VY4LQ5DC6NANCNFSM4KFME5TQ
.

Sorry it's an error

No problem.  And thanks for keeping the old code, we will hopefully put it
back into production sometime.  I wonder if it would be easy to have a
super-user mode (e.g. through an extra flag on the query string) such that
you and I could still use those features for testing but it wouldn't be a
part of the public interface.  I wouldn't waste a lot of time on it, but
it's an idea.
On Fri, Jan 10, 2020 at 1:43 PM Alain Bourgeois<EMAIL_ADDRESS>wrote:

Sorry it's an error
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jeff-zucker/solid-ide/pull/20?email_source=notifications&email_token=AKVJCJBGL62QFFVXLTGOC3DQ5DTYBA5CNFSM4KFME5T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVJREI#issuecomment-573216913,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKVJCJBNWBTTBMACHBC4MX3Q5DTYBANCNFSM4KFME5TQ
.

No I check and it does not. may be you should reload or clear the browser

Ah, I'll have to be more careful about that, had to clear all the site data
and reload.
On Fri, Jan 10, 2020 at 1:49 PM Alain Bourgeois<EMAIL_ADDRESS>wrote:

No I check and it does not. may be you should reload or clear the browser
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jeff-zucker/solid-ide/pull/20?email_source=notifications&email_token=AKVJCJAKXDSOQLMF2M5RPL3Q5DUP7A5CNFSM4KFME5T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVJ7AQ#issuecomment-573218690,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKVJCJGXN5PXYSFIKIZXNBTQ5DUP7ANCNFSM4KFME5TQ
.

Something appears to be wrong.  I am logged in as me on my own pod and when
I try to delete something a "no access" message flashes over my console and
then disappears - no error popup, the delete fails.
On Fri, Jan 10, 2020 at 1:58 PM Jeff Zucker<EMAIL_ADDRESS>wrote:

Ah, I'll have to be more careful about that, had to clear all the site
data and reload.
On Fri, Jan 10, 2020 at 1:49 PM Alain Bourgeois<EMAIL_ADDRESS>wrote:

No I check and it does not. may be you should reload or clear the browser
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jeff-zucker/solid-ide/pull/20?email_source=notifications&email_token=AKVJCJAKXDSOQLMF2M5RPL3Q5DUP7A5CNFSM4KFME5T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVJ7AQ#issuecomment-573218690,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKVJCJGXN5PXYSFIKIZXNBTQ5DUP7ANCNFSM4KFME5TQ
.

Hmm, I re-logged in, and now it works.  So the problem isn't deleting, it's
that the options show  me as logged in when apparently I'm not.
On Fri, Jan 10, 2020 at 2:18 PM Jeff Zucker<EMAIL_ADDRESS>wrote:

Something appears to be wrong.  I am logged in as me on my own pod and
when I try to delete something a "no access" message flashes over my
console and then disappears - no error popup, the delete fails.
On Fri, Jan 10, 2020 at 1:58 PM Jeff Zucker<EMAIL_ADDRESS>wrote:

Ah, I'll have to be more careful about that, had to clear all the site
data and reload.
On Fri, Jan 10, 2020 at 1:49 PM Alain Bourgeois<EMAIL_ADDRESS>wrote:

No I check and it does not. may be you should reload or clear the browser
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jeff-zucker/solid-ide/pull/20?email_source=notifications&email_token=AKVJCJAKXDSOQLMF2M5RPL3Q5DUP7A5CNFSM4KFME5T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVJ7AQ#issuecomment-573218690,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKVJCJGXN5PXYSFIKIZXNBTQ5DUP7ANCNFSM4KFME5TQ
.


Link not working in Codebase Overview

On the Codebase Overview page, in the Fiber Reconciler section, this link is not working.

Hey @iAziz786 i did this PR to solve this => https://github.com/reactjs/reactjs.org/pull/1673

Thanks @Lukyhenson, once your PR get merged you can close this issue.

Fixed by #1673


added the warning modal

Added Warning Modal to ask for confirmation before clearing the board completely.
Fixes #11

Sorry for late response @vedant-jain03, I am busy with my exams now days, but I will try to implement changes as you have suggested.


Skip flaky vscode test suites

These suites are intermittently being impacted by the xterm glyph issue.  The actual upstream product functionality seems to be working fine, so it seems safe to disable in our test runs since we don't routinely modify these product areas.

The unit test failure appears related to https://github.com/xtermjs/xterm.js/issues/4560.  It's still not clear to me if there is a limited subset of suites that are hitting this issue, or if it can show up somewhat randomly across the suites.

Let's take this for now and I'll keep the tracking issue open.  If the canary builds don't get stabilized I'll revert and try a different approach.


#75 refactored all vars of scan model

PR for #75

Job #82 is now in scope, role is REV

This pull request #82 is assigned to @bahaaib/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @ammaratef45/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; @bahaaib/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @ammaratef45/z

@rultor merge

@rultor merge

@bahaaib Thanks for your request. @ammaratef45 Please confirm this.

@rultor merge

@rultor merge

@ammaratef45 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@ammaratef45 Done! FYI, the full log is here (took me 7min)

Job was finished in 26 hours, bonus for fast delivery is possible (see §36)

Quality is low, no payment, see §31:

The job #82 is now out of scope

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @ammaratef45/z


vnstat: 2.6 -> 2.7

Motivation for this change
i use it, the monthly figure stopped updating, i tried out the latest release, this didn't help
but now i have an update around...
and there seems to be some new features someone may want to use
https://github.com/vergoh/vnstat/releases/tag/v2.7
Things done
change to fetchFromGitHub
use latest version
and set myself as a maintainer

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)

/nix/store/8bp2c0pan8wx39d8pvja4c2ihmy04dk1-vnstat-2.6	   51285536
/nix/store/xfm3c7gnhiinjjysvw6dirw9gl0fxys3-vnstat-2.7	   51313800

[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123655 at 6fdacb10 run on x86_64-linux 1

2 packages built successfully:

tests.trivial
vnstat


refactor: api/types/*.go code review, modify functions with return va…

…lues
Signed-off-by: Wu Peng<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Thanks a lot for your work. While actually all the files in folder apis/types are auto-generated via swagger. see doc https://github.com/dragonflyoss/Dragonfly/blob/master/apis/README.md.
So I do not think we can accept this PR. While feel free to contact us if you have any questions. @songshuone


Whether the CSS source mapping can be configured in the document supplement

Clear and concise description of the problem
As a developer using Vite, I would like to configure CSS source mapping to enhance the CSS development experience in the development environment, but there is no documentation to do so
Suggested solution
If CSS source mapping is not currently supported or is supported, you want to document this
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Work on CSS sourcemap is tracked at https://github.com/vitejs/vite/issues/2830. Some improvements has been done at https://github.com/vitejs/vite/pull/7173