add taskKillGracePeriodSeconds

Available since marathon 1.3.0
Docs https://github.com/mesosphere/marathon/blob/master/docs/docs/rest-api/public/api/v2/types/app.raml#L237
ref to #171

Cheers for the PR @kulikov  ... If this is a configurable option, perhaps we can add getters and setters? ... similar to https://github.com/gambol99/go-marathon/blob/master/application.go#L164-L259 ...

done

Only 3 methods has Set prefix: SetApplicationVersion, SetDiscovery and SetIPAddressPerTask.
But yes, we can ^)

I should have said Set or Add. The newer methods normally have it.

ok, thanks

Sorry, I only realize now that we have extended the JSON methods by the new field but don't use it anywhere for testing. IMHO, we should either remove them from the yaml file or add a deserialization test assertion.

done. at first i just add field everywhere, like maxLaunchDelaySeconds

LGTM -- thanks a lot!


[New Port Request]

Library name:Open3D
Library description:A Modern Library for 3D Data Processing
Source repository URL: https://github.com/intel-isl/Open3D
Project homepage (if different from the source repository):
Anything else that is useful to know when adding (such as optional features the library may have that should be included):

Hi @wenduof
Thanks for posting this issue. It's duplicated to #15980.
So let's track this issue there.


Add loop unrolling threshhold to static memory tagging

In case the static size (meaning we know it at compile-time) of the memory region we want to tag is very large, continueing to unroll the entire loop into a very large number of st2g instructions may cause unwanted inefficiencies (e.g. cache misses). Therefore, we should introduce a threshhold (some integer value, which we can adapt from clang in the future) with the following behaviour: Unroll at most this amount of st2g instructions directly, otherwise unroll st2g loops in runtime loops.

I've added some test-cases to check whether our generation of stg, st2g and st2g-loops are correct. If you see some test-cases or expected behaviour that I missed please let me know.

I used llvm-objdump to check that the correct combinations of stg and st2g are generated, and have now also tested that compiling and running the demo.c files works as expected as well.

I've squashed everything into one commit now.


new notes of chapter 3/4/5?

Hi there,
thanks for this great notes about linear algebra chapter in deep learning book with vivid python code. will you think about writing notes of chapter 3/4/5 to help us get better understanding of math behind AI?
Thanks.

Hi, thanks for your message! I started Chapter 3 (first article here). Stay tuned for the next articles.


[WIP] transformers kpi traning notebook

Related tasks: #223
Signed-off-by: Shreyanand<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign durandom for approval by writing /assign @durandom in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Merge schemas?

I noticed that the deployment scripts for shopping cart were moved up a level, outside of the Java/Scala specific projects.
Should we do the same for the "schemas" directory?
https://github.com/lagom/lagom-samples/blob/1.5.x/shopping-cart/shopping-cart-java/schemas/shopping-cart.sql
https://github.com/lagom/lagom-samples/blob/1.5.x/shopping-cart/shopping-cart-scala/schemas/shopping-cart.sql
(They're identical)

Yes, sure.

I think the best location is shopping-cart/deploy/scripts/sql/ (or ddl/). I'd also split and rename into write-side.sql and read-side.sql (or something like that).
Then, there's also some SQL for schema creation embedded in the .sh scripts.

@ignasi35 why do you think it's better to split into two files?

@ignasi35 why do you think it's better to split into two files?

I like having smaller, more clear pieces: a sql file for the journal and snapshots and another one for the offset store and, finally, the third one for user-provided tables. Then, if we think it's useful, a fourth one (preceding them all) to create the database schema(s).
This will be a pattern easy to reproduce in, for example, the mixed-persistence samples where read-side and write-side use different technologies.

Works for me. Any objections?
(I'm doing a revision of the deployment guide, so I'll sync that up with this.)

I'm fine with it.


[Template] Create a DFD Level 1 template

Current Behavior
Currently for new users we do not have enough starter templates that they can use as introductory material.
Desired Behavior
We want to create a DFD Level 1 architecture template to allow new users to understand how they can create a DFD Level 1 architecture diagram with Kanvas. So we'd want contributors to not just create a design template but also add tips or notes they think a new user would need if they are starting out with little to no context of the capabilities Kanvas offers.
Implementation
Make sure you use Kanvas to create this template and keep the template private.

[ ] Provide a brief overview of what this template does and can help with, maybe highlight a usecase
[ ] Add a template that can be directly copied and used instantaneously
[ ]  Add a step by step process to create this template
[ ]  Once the design is completed, publish it and share the private link with our team, or tag us in the comment component to receive feedback.

Acceptance Tests

Template has been submitted for publishing to the catalog and accepted; is published and available in the Meshery Catalog.
We are in need of well annotated and described templates like this one.

Mockups
This FigJam template can be used for recreating the DFD Level 1 architecture Template
Perks
By contributing to this task, your efforts will have a lasting impact! Once published, your design will be cloned and used by countless users as a go-to starting point for creating DFD Level 1 architecture in Kanvas. You'll not only help newcomers understand the platform but also see your work adopted widely by the community. Plus, as a token of appreciation, you'll receive a special shoutout, recognising your valuable contribution. Your effort won’t go unnoticed—you're directly helping shape the experience for future users!

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

can I contribute this issue?

Hey sure @Deathnote45. Do let me know if you have any queries.
Once you feel the design template is ready for review, do add a comment in the design by pressing a Ctrl/Cmd + M and tagging @Ankita Sahu in the comments. I can review it and we can go ahead with publishing your design!

ok sure @SAHU-01

@Deathnote45 how close are you to completing this design template? If you intend ot drop this issue do let me know @sonalgaud12 might be interested to take this up.


Implement print/println

Closes https://github.com/Viatorus/emio/issues/11

Codecov Report
Patch coverage: 89.74% and project coverage change: -0.16 :warning:

Comparison is base (80b7e14) 98.71% compared to head (8e2dd17) 98.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   98.71%   98.56%   -0.16%
==========================================
  Files          43       43
  Lines        4373     4451      +78
==========================================
+ Hits         4317     4387      +70
- Misses         56       64       +8

Impacted Files
Coverage Δ

test/unit_test/test_format.cpp
98.29% <89.74%> (-1.32%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Failed to load links with parameters

Not working for this type of links https://www.youtube.com/watch?v=Jzv3G5iDLvw


Inaccurate Camera Positioning with UAV Data

Hi development team,
I've been testing your glomap software with UAV imagery, focusing on vegetated scenes. I've noticed that the software isn't performing as well as I'd hoped with these types of images. The original image layout should be nearly coplanar, and colmap has been able to achieve the slightly better results. However, with glomap, the final calculated positions of the images form a curved arc surface, which is not the expected outcome. I've tested this with several similar datasets, and they all seem to produce similar incorrect results.
These are results.
dataset sample

glomap result

colmap result

colmap result(with gps constrained)

The results above are from tests I conducted using a public dataset with scenes similar to my own data. The dataset can be accessed at this link: https://cloud.pix4d.com/site/48774/dataset/390556/files/inputs?shareToken=82c66f66-6d88-41a8-9dfa-98c70ce934bf. In addition to the abnormal camera positioning in the reconstruction, there's also a peculiar issue with point cloud coloring failure, which didn't occur in my own data tests. However, a similar issue with the curvature of the positions was present. I'm not sure if this is related to glomap's use of ray angle as an error term during the global positioning process instead of reprojection error. Or rather, for UAV data, should we adopt a GPS-constrained approach for SfM? Have you considered integrating this feature into the glomap library?
Additionally, the cmake install command does not seem to correctly install the glomap.lib static library to the specified directory.

Regarding the test results that I obtained when I initially opened the issue, I used the COLMAP GUI to set up some parameters:

All steps use the CPU instead of the GPU, with three threads employed. (I believe these parameters do not affect the results.)
Camera intrinsics are shared.
The spatial matcher is used with a 150m constraint.
The principal point is adjusted.

After considering your comments, I tried using the command interface you suggested. I was glad to see that GLOMAP produced the expected results :)
GLOMAP result:

However, I have a few more questions; I might need to open another issue in COLMAP.

I'm not getting the desired results when using the GUI interface for the reconstruction process, even though I don't believe I've changed many parameters. Why is that?
The model generated by COLMAP seems to stick together with the camera positions. Is this related to reconstruction normalization?
When I attempted to import the sparse point cloud models generated by COLMAP or GLOMAP into the GUI interface of version 3.11 for display, I encountered an error: Check failed: images_.emplace(image_id, std::move(image)).second. As a result, I switched to version 3.10 for visualization.

COLMAP result:

All steps use the CPU instead of the GPU, with three threads employed. (I believe these parameters do not affect the results.)

In my test, feature_extractor and exhausive_matcher uses GPU. colmap mapper & glomap mapper uses CPU.

I'm not getting the desired results when using the GUI interface(3.11) for the reconstruction process, even though I don't believe I've changed many parameters. Why is that?

I never use GUI interface for reconstruction. But, colmap 3.11dev0 still got worse result than glomap.
What I expect : colmap & glomap gives similar good result, but glomap is a bit faster.

When I attempted to import the sparse point cloud models generated by COLMAP or GLOMAP into the GUI interface of version 3.11 for display, I encountered an error: Check failed: images_.emplace(image_id, std::move(image)).second.

It didn't happen to me. Maybe something wrong when it compiled? I use colmap 3.11dev0 commit c238aec0 and it can import the sparse data for display.

I used git pull to to update my colmap from 3.11.0.dev0 commit a7a0db7d to the latest 3.11.0.dev0 commit 63b2cc00, and now I can import sparse data for display correctly. However, there is still this issue (I re-ran the reconstruction with the new version):

The model generated by colmap seems to stick together with the camera positions. Is this related to reconstruction normalization

This really seems like some kind of normalization has been applied to the camera's pose.

The type of data you are dealing with poses challenges for SfM in general, please refer for more details to: "Critical Configurations For Radial Distortion Self-Calibration", http://ccwu.me/file/radial.pdf
Apart from that, colmap is likely still the better choice for data with significant unknown distortion. glomap can deal quite robustly with unknown focal length but significant unknown distortion is still often a challenge. In glomap, you may want to try running additional rounds of retriangulation and bundle adjustment. It may (or may not) help with the issue.

@ahojnnes Thanks for your comment!
I will further study and understand the effects of radial distortion based on the paper you provided. In addition to performing additional rounds of triangulation and bundle adjustment, I might attempt to mitigate the bending of camera positions using GPS constraints.

Colmap has a new pose prior mapper that can take advantage of GPS priors. GLOMAP currently doesn't have a built in way to take advantage of them but could be relatively easily modified to do so.


Create a performance test in circleci with wrk or similar

Is your feature request related to a problem? Please describe.
It isn't currently possible to analyse the impact of commits on performance. Jabba can slow down dramatically during development without you noticing unless you keep running "wrk" every time
Describe the solution you'd like
Use wrk or a similar tool like ab to run an automated performance tests on circleci. Use these numbers to compare  the performance over time, even if the numbers are unlike the mac dev environment

done: https://app.circleci.com/pipelines/github/simonmittag/jabba?branch=master


clean up meta content

[x] Adjust the meta content to fit our hack more

cleaned up the content


Add updates from running pre-commit autoupdate

They just use your mind and they never give you credit
It's enough to drive you crazy if you let it

I have an encyclopedic knowledge of 60s-80s country lyrics, including crossover tunes such as this one.  Yet another useless skill in my arsenal.


ARROW-5883: [Java] Support dictionary encoding for List and Struct type

As described in http://arrow.apache.org/docs/format/Layout.html#dictionary-encoding, List type encoding should be supported.
Now ListVector getObject returns a ArrayList implementation, and its equals and hashCode are already overwritten, so it could be directly supported to be hashMap key in DictionaryEncoder. Since we won't change Dictionary data during encoding/decoding process, use mutable key seems dose't matter.
StructVector is similar to ListVector.

Codecov Report

Merging #4830 into master will increase coverage by 2.15%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4830      +/-   ##
=========================================
+ Coverage   87.44%   89.6%   +2.15%
=========================================
  Files         997     662     -335
  Lines      139804   96427   -43377
  Branches     1418       0    -1418
=========================================
- Hits       122246   86399   -35847
+ Misses      17196   10028    -7168
+ Partials      362       0     -362

Impacted Files
Coverage Δ

cpp/src/arrow/json/converter.cc
90.53% <0%> (-1.78%)
:arrow_down:

cpp/src/arrow/json/chunked-builder.cc
79.91% <0%> (-1.68%)
:arrow_down:

cpp/src/arrow/io/readahead.cc
95.91% <0%> (-1.03%)
:arrow_down:

r/src/recordbatch.cpp

r/R/Table.R

js/src/util/fn.ts

go/arrow/array/bufferbuilder.go

r/src/symbols.cpp

rust/datafusion/src/execution/projection.rs

rust/datafusion/src/execution/filter.rs

... and 329 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f767ce...4977531. Read the comment docs.

+1, LGTM.  Conda is unrelated.


Add support for double type

@stephanvd Sorry for the slow response to these PRs.  Can you rebase this branch from master?

Thanks @stephanvd . I'm good with this now.  I'm not sure if Double will remain under the Metadata namespace long term but I like the added support.


A little imperfection with interface on Windows with DPI=125%

Extra horizontal scroll bar which is actually unnecessary (see screenshot)
To reproduce: set windows dpi=125%
Client: 1.7.1
OS: windows 10 21H2

I noticed that after the latest update the problem is gone! Thanks to devs!!
I believe that the issue may be closed if anyone other not having any problems with that.


chore(main): release 1.232.1

When this PR is merged, a new tagged release will be created with the notes below.
1.232.1 (2023-05-17)
Bug Fixes

Add X-NewRelic-ID header only if defined (#531) (36ceedf)
Identify inline stack trace URLs more precisely (#522) (1aba92d)

This PR was generated with Release Please. See documentation.

Codecov Report

Merging #530 (c1dffd5) into main (1aba92d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #530   +/-   ##
=======================================
  Coverage   19.62%   19.62%
=======================================
  Files         127      127
  Lines        4169     4169
  Branches     1035     1035
=======================================
  Hits          818      818
  Misses       2628     2628
  Partials      723      723

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Would be nice if this automation also updated the package.json files in the tools/test-builds projects.
This might be possible although it would need to be tried to see if release-please can parse out the version number in a file path or if it only replaces whole strings.


Example 3 Syntax

Should the identity not be enclosed in double quotes as follows:
Get-PnPUser -Identity<EMAIL_ADDRESS>
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 57ec7ac7-3858-172e-ec9c-ab7c948ae2cf
Version Independent ID: 3a171d0d-f00d-36fd-44c3-c6bb08222b14
Content: Get-PnPUser (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Get-PnPUser.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

Hello @RossMcLean77 thanks for your feedback!
I created a pull request, you can take a look as it is referenced here, to propose correcting the example.
Thank you!

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @erwinvanhunen Thanks for your support. @RossMcLean77 hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


✨ Implement Uvicorn HTTParse

@adriangb @florimondmanca

Is there any plan for benchmarks? I can add some but wondering if you have a preference on how they’re structured


Examples use incorrect slash character for -Identity

The examples on the docs page use the wrong slash character in the -Identity parameters. Should have forward slashes.
Currently: Set-PnPFolderPermission -List 'Shared Documents' -Identity 'Shared Documents\Folder' -User<EMAIL_ADDRESS>-AddRole 'Contribute'
Should be: Set-PnPFolderPermission -List 'Shared Documents' -Identity 'Shared Documents/Folder' -User<EMAIL_ADDRESS>-AddRole 'Contribute'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 852744c0-227a-a258-2206-7ac0ae744f20
Version Independent ID: 8421d321-6408-d97a-6618-6fd0be96d31d
Content: Set-PnPFolderPermission (PnP.Powershell)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Set-PnPFolderPermission.md
Service: sharepoint-powershell
GitHub Login: @pamgreen-msft
Microsoft Alias: pamgreen

Hello @crzelak
how are you?
Even though the PnP documentation articles are on this repository, I need to kindly redirect you to open PnP cmdlets issues/pull requests here, in that repository, where a member of the PnP community will be able to correct the article/review your PR with your feedback.
The documentation for PnP cmdlets is then synced from that repo into this one.
Thank you!

@get-itips Thank you very much for the contribution and sharing this explanation. @crzelak Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also


Don't override preprovisioningNetworkDataName

If already set in the BMH and not provided in baremetalSpec don't override preprovisioningNetworkDataName.

/test openstack-baremetal-operator-build-deploy

/test precommit-check


Score equation visualization

Find the best parameters range, use Matlab or python

Use a new folder to store the results and scripts.
Equation:
$Score = 100* F_\beta + 20 * L_n+ 20* M_n$
$F_\beta = {(1+\beta^2) \times {{Precision \times Recall} \over {(\beta^2 \times Precision)+Recall}}}$, where $\beta = 2$
$L_n = {1 - {{L - Min_L} \over {Max_L - Min_L}}}$, where $Min_L = 1ms, Max_L = 200ms$
$M_n = {1 - {{M - Min_M} \over {Max_M - Min_M}}}$, where $Min_M = 5KiB, Max_M = 256 KiB$
Parameters are: $Precision, Recall, L, M$

add those into the validation and test process


there is no example for guidance

I made a simple button in my app named "Open Whatsapp". On press of this button i want to open whatsapp if installed it will directly open it in my phone else it will redirect me to Playstore. But i am not able to implement this. Kindly help.
What will be the url in below code and where shoid i get all these details.
AppLink.maybeOpenURL(url, { appName, appStoreId, appStoreLocale, playStoreId }).then(() => {
  // do stuff
})
.catch((err) => {
  // handle error
});

Any update on this issue or can anyone have a sample for this?

I made a simple button in my app named "Open Whatsapp". On press of this button i want to open whatsapp if installed it will directly open it in my phone else it will redirect me to Playstore. But i am not able to implement this. Kindly help.
What will be the url in below code and where shoid i get all these details.
AppLink.maybeOpenURL(url, { appName, appStoreId, appStoreLocale, playStoreId }).then(() => {
  // do stuff
})
.catch((err) => {
  // handle error
});

any update on this I am facing the same issue

The url would be the whatsapp://... url linking to whatever content you want within the WhatsApp app. https://faq.whatsapp.com/en/iphone/23559013

I am implementing react-native-app-link  in my project but I am facing issue in the implementation I have a list of applications on the press of a specific button it should either open the app or redirect to play store or app store.
I do not have any deep-link URL for this app is there any way to achieve this?
Example for my app: IOS and Android
Package name: com.medlife.customerApp
name:  MedlifePlay
iOS: package name: medlife-all-things-healthapp
id:<PHONE_NUMBER>
App store name :Medlifeapp
If possible please provide demo example for this library


Increase prominence of doc links in readme

Fixes #2475

yeah that would be better

@vtomole I did as suggested but also included another link to the documentation with the url (worth saying!) The final count is four links to pretty much the same place :p PTAL and let me know if this looks good

I think the bullet will appeal to people skimming it


Schedule Pre-event notifications job 📆

This issue is dependent on #477.
(However, the logic is entirely separate from that issue, so it is possible to work on the PR for this issue before #477 is ready. We just need to make sure #477 is merged first!)
Description
#477 implements a function that sends pre-event notifications to members. However the function isn't being utilized anywhere, so we need to schedule this job. Additionally, we need to ensure that when an event is deleted, this job is also removed from the queue.
Acceptance Criteria
When an event is created, we should schedule a Bull job that calls the function from #477. We want to add to the createEvents function. Specifically, after creating the event, we want to call the job to send an email notification, and then save the job ID within a database field.
Currently, there is no field in the events table for storing this job ID, so that new field needs to be created using a database migration (see docs).

Can I take on this? @tomas-salgado

I can take this too!

@imnotrafa just assigned you to #477, so I’m going to leave this one for @gpolite0

Can I take this? Following up from the oyster channel on Slack


Data fields to track

What data fields should we include in an index of these types of projects?

Institution name
Project name
Funder(s)
Funding amount(s)
Funding date(s)
Project team members
Embargo period (start - end)

These are just to get us started. How should the data be modeled?

I'd say almost all fields should be optional just to try to get as much info as possible.
Embargo length
Digitization Start Date
Digitization Expected End Date

MUST have:

Institution name
Institution ID
Project name
Project ID

OPTIONAL:

Everything else

here's a sample list that NARA publishes, these are all out of embargo but not yet in catalog (they have a huge backlog and one possible funded project idea would help convert 3rd party digitization outputs to the current catalog ingest workflow).
[http://www.archives.gov/digitization/digitized-by-partners.html](NARA digitized by partners)

Great! I'm also thinking about how deep we should go in tracking the digitization. Meaning: is it just award/funding level or down to the collection/item level? For instance, the NARA list is at a collection level.

I think collection level is ideal/optional.


Enable the Bridge client to connect to Inet6 MQTT endpoints

Doc:
Introduces new vmq_bridge config settings:
vmq_bridge.tcp.default.inet_version = inet|inet6
vmq_bridge.ssl.default.inet_version = inet|inet6
with default being an arbitrary bridge name, informing default that the other bridge endpoint to contact is an IPv4 or IPv6 endpoint.

Hi @ioolkos , many thanks for this PR. Are you planning to make any pre-release or RC including this changes? It would be great to have.

One more question: if a new release will take time, do you think we can cherry-pick this commit to a release 1.12.4 ( or 1.13) without having any issue?

@mrceyhun this will be part of the final release of 2.0, yes. It'd be great if someone can test the feature with their use case.

Thanks @ioolkos . Do you think it is ok to cherry-pick this commit to the 1.13(or 1.12.4) release? If so, we can test and report our use-case of this PR.

@mrceyhun Maybe, but I cannot review the commit history right now to guarantee it to you.

Got it, thank you!


lack of RAII in examples despite functionality being present?

Many of the examples include statements like ctx.destroy() or dev.close() while new is no where to be found, and destruction is being called at the end of scope.   Is there a particular reason for this pattern?  It appears as if all the objects actually have destructors any way.

Everything is destroyed when the DeviceManager goes out of scope, but the individual things don't before then (except for SharedPtrs and SharedFutures and such, since they're standard smart pointers). For instance, with that example if source.destroy() wasn't called and it looped to play multiple files, it would leak multiple sources prior to the end since there's no way to get back the previously allocated ones.
The more general reason for the lack of RAII is because it's possible for destruction to fail (or even crash) if done incorrectly since devices own contexts, and contexts own sources/buffers/etc. If they're destructed in the wrong order, it will crash since they're effectively pointers to those resources that have been deleted (and I'm not fond of the idea of resources keeping their owners alive after the app has gotten rid of the latter). There is an AutoObj wrapper container that adds RAII behavior for most resources, although the app has to promise it will scope them correctly when using it or else.

Thanks for the detailed reply!


Draft: Tags

Work in progress

Please file "work-in-progress" PRs as "draft"

Please rebase on latest main and target it.
You'll have to drop the namespacing commit

@rjzak I'm going to close this PR. Please open a new PR against the main branch.


jpgd::jpeg_decoder::check_sample_buf_ofs(int) const: Assertion `ofs >= 0' failed.

The attached file passed to basisu gets this assertion, only in the Debug configuration of course. The assertion is at line 275 in jpgd.h called from line 2020 in jpgd.cpp.

got it - I'll check it out

Hi there! Any update on this one?

Looking at it today - stand by.

Fix is incoming - very simple.

Fix is up. BTW - we don't really want to be maintaining our own fuzzed JPEG reader. We're going to try replacing it with something else, but the question is what.


Local_auth : user can dismiss the dialog without authenticating.

Hello,
Local_auth allows the app to use the phone's biometrics.
There is a parameter called stickyAuth but it only sticks the dialog if the user open another app on the top or if he gets a phone call. It does not prevent the user hiding the dialog when he taps outside.
I need to display the dialog no matter what until the user uses his biometrics. How can I do that?

Hi,
please add the output of flutter doctor also please tell us which version of local_auth you are using.
On which Platform does this happen?
Thanks

First of all, thanks for the answer !
I am using local_auth: 0.6.0. I also forgot to tell that I tried to use the  stickyAuth parameter in the basic project example flutter...\local_auth-0.6.0
Here is the doctor -v
`[√] Flutter (Channel stable, v1.9.1+hotfix.2, on Microsoft Windows [Version 10.0.17763.737], locale en-US)
• Flutter version 1.9.1+hotfix.2 at C:\flutter
• Framework revision 2d2a1ffec9 (13 days ago), 2019-09-06 18:39:49 -0700
• Engine revision b863200c37
• Dart version 2.5.0
[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at C:\Users\thr\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 28.0.3
• Java binary at: C:\Users\thr\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\191.5791312\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[√] Android Studio (version 3.4)
• Android Studio at C:\Users\thr\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\183.5522156
• Flutter plugin version 35.3.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[√] Android Studio (version 3.5)
• Android Studio at C:\Users\thr\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\191.5791312
• Flutter plugin version 39.0.3
• Dart plugin version 191.8423
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[√] IntelliJ IDEA Ultimate Edition (version 2019.2)
• IntelliJ at C:\Users\thr\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-1\192.6603.28
• Flutter plugin version 39.0.5
• Dart plugin version 192.6603.23
[√] Connected device (1 available)
• POCO F1 • 57b60ae4 • android-arm64 • Android 9 (API 28)
`

Does this only happen on Android?

Yes it happens on Android. The new title resume it perfectly.

Hi @Theo6890
Are you still experiencing this issue with latest stable?
If so, can you please provide your flutter doctor -v and flutter run --verbose?
Also, to better address the issue, would be helpful
if you could post a minimal code sample to reproduce the problem
Thank you

Hi @Theo6890
Without additional information, we are unfortunately not sure how to resolve this issue. We are
therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the
bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


IncompatibleClassChangeError

Hello, I run a custom modpack and I get this crash when connecting my Capacitor Back to anything using an Ender IO conduit.
http://pastebin.com/tMH8GBaZ

You have different version of the RF API in your mod pack.
Starting with build 301 EnderIO uses the new RF API. You need to find out which of your other mods is using the old API and update these.


Fix a few doc links

Seems that some of the penaltymodel unittest are consistently failing, but since that's unrelated to this PR I will go ahead and merge


sign up page

Establish a basic user interface with text fields, labels and buttons. Have sign up button link to a sign up page. Have on-click handler event of the "submit" button save user's entered new account information into a JSON.
100


Translate Docs to Thai - work in progress

Hello Everyone,
I would like to start translate vuejs.org site to Thai and forked vuejs.org to th.vuejs.org project in vuejs-th organisation.
https://github.com/vuejs-th/th.vuejs.org
Welcome to contribute this translation.
Thank you,
Phayao

@sdras How many % of translation that Vue team will be create sub-domain for translation?

@iphayao There's not a definitive rule, but we like people to be near completion when we publish, so that a clear commitment to keeping up the translation has been demonstrated. 🙂


relative_urls plugin has trouble with trailing slashes in URLs

Version
2.4.3
Platform
Linux (WSL), should also reproduce on other platforms
What steps will reproduce the bug?
In a directory with two files:

_config.ts:
import lume from "lume/mod.ts";
import relativeUrls from "lume/plugins/relative_urls.ts";

const site = lume();
site.use(relativeUrls());
export default site;

test.md:
---
url: /a.html
---

[Go to index](/)

Run lume.
How often does it reproduce? Is there a required condition?
Always reproducible.
What is the expected behavior?
The URL / should be translated to ., so that the link leads to index.html.
What do you see instead?
In _site/a.html, the URL / is translated to an empty string. The link leads to a.html itself.
<!DOCTYPE html>

Go to index

Additional information
There are many other cases where the plugin fails; the above is just an example.
It is problematic even if url is not set explicitly: Trailing slashes in URLs are removed, but prettyUrls (on by default) requires them. While Lume dev server handles missing trailing slashes by redirection, not all static hosting providers do.
The plugin uses jsr:@std/path/posix, a module intended for POSIX filesystems. In POSIX path operations, trailing slashes are ignored. But in URLs, they are significant.

Thank you for reporting this!
I just commited a fix that will be available in the next Lume version.
If you don't want to wait to the next version, run deno task lume upgrade --dev to use the latest development version.


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In fe5c593, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 7129 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 00840e6 after 20 minutes.


chore: move contract verifier logic to lib

What ❔
Move the contract verifier struct to the separate lib crate.
Why ❔
This logic can be used as a library. At lest, for example, now it's needed for some compiler analysis tool.
Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via zk fmt and zk lint.
[ ] Spellcheck has been run via zk spellcheck.

I didn't change the name of the bin crate(it's still zksync_contract_verifier) to be sure that build/run scripts will not be broken, so I named the lib crate - zksync_contract_verifier_lib for now.


Rename testdata dir names to convey how they work together

Rename testdata directories to convey how they work together
Rename directory test-1 to test-case-1a
Rename directory test-2 to test-case-1b
Rename directory migrate-1 to migrate-case-1a
Rename directory migrate-2 to migrate-case-1b
Rename directory migrate-3 to migrate-error

/lgtm
/approve


Support for Accessing SQLite DB Stored in Turso from Java

I need to access the SQLite database stored in Turso from a Java application. Are there any options available for this?
I didn't see any information about a JDBC driver or Java client support in the documentation. Can you please provide guidance on how to achieve this or if there are any plans to support JDBC or a Java client in the future?

You can try https://github.com/libsql/libsql-client-java

Still, many applications rely on JDBC drivers. Implementing JDBC would be crucial for serious Turso usage with Java applications (e.g. Jetbrains Datagrip IDE)

Try https://github.com/dbeaver/dbeaver-jdbc-libsql


New constants for server states in PlatformMonitoringConstants

Currently, there are:
STOPPED,
ACTIVE,
PASSIVE,

(https://github.com/Terracotta-OSS/terracotta-apis/tree/master/monitoring-support/src/main/java/org/terracotta/monitoring)
we also had before:
PASSIVE_UNINITIALIZED,
START_STATE,
RECOVERING,

@anthonydahanne, Gary: 2 questions:

do we still need the 3 others ?
do we rename them to SYNCING, STARTING, RECOVERING ?

I would assume that the other states of of value but we need to determine whether to just pass them through, verbatim (in which case you can't really rely on their meanings since they are just internal names and could change if the state machine is altered), or do we want to define a solid set of meaningful names and we will internally map our states to those (in which case you can make high-level decisions based on the values).

those first 3 (STOPPED, ACTIVE, PASSIVE) represent "stable" states, and the others (PASSIVE_UNINITIALIZED, START_STATE, RECOVERING) "transition" states.
I would second Jeff, saying we should keep such transitions states - we'll see if we rename them later

I would prefer we see know if we give them better name. I mean... if START_STATE means "starting", then is should be called STARTING, not START_STATE. Jeff already renamed existing states: ACTIVE_COORDONATOR, PASSIVE_STANDBY, etc to more readable names. So I suggest we do the same for transition states if we need them.
So I suggested: SYNCING, STARTING, RECOVERING. Does it work for you @anthonydahanne  and Gary ?

LGTM

At first glance, some of these states seem superfluous. Stopping and starting for example are probably not observable, particularly from the network. It probably makes sense to concentrate on network readiness (or lack thereof) states

Right... So perhaps we can just keep at the moment the 3 states @jd0-sag exposed, and see whether we need or not some other states after. As I understood we probably won't have the same things as before.
@jd0-sag, @myronkscott : do we keep this issue opened then, for future reference ? Or we close it ?

I will leave this open, for now, to see what happens once you actually meet this integration point since we have some amount of relevant conversation here, already.
I will mark it as low priority, though.

Assigning to @myronkscott as you have done work which probably encompasses the meaning of this issue.

Adding SYNCHRONIZING to the states that a server can be in.  This is when a server is going from UNINITIALIZED to PASSIVE.  Currently the possible transitions for a server are:
UNINITIALIZED->SYNCHRONIZING->PASSIVE->ACTIVE
UNINITIALIZED->ACTIVE

@myronkscott : is the STOPPED state removed ? If not, is it a state that M&M could observe ?
In the case for example when a passive server crashed, and the monitoring tree containing all the servers would then be updated to mark the passive STOPPED for example ? Could it be possible ?
Thanks!

If a passive server crashes, I would assume that we just remove it from the tree, as opposed to putting it into some different state (after all, it is NOT recoverable).
I don't know if STOPPED can be meaningfully observed by I will defer to Myron on that.

STOPPED is not really something observable.  We cannot put it in the tree as we do not have any node-id associated with it.  I can understand MandM wanting to display missing servers.  Can you do this by comparing config with nodes in the tree?

Yes we can!  I asked because STOPPED is still in PlatformMonitoringConstants .


"CORS is not supported by your browser", from Node.js

When using your library serverside, in Node.Js (no browser), I am running into this bug:
https://github.com/ReactiveX/rxjs/issues/3978

I ran into this myself and unfortunately had to make my own abstraction in a node environment as my work around.


Transaction (multi) for coroutine doesn't work

Bug Report
Current Behavior
Based on this connection pool : BoundedAsyncPool<StatefulRedisConnection<ByteArray, ByteArray>>
If we got a connection, use sync() method  and multi to make transaction, the transaction is performed as expected
val pool: BoundedAsyncPool<StatefulRedisConnection<ByteArray, ByteArray>> = ...
val connection: StatefulRedisConnection<ByteArray, ByteArray> = pool.acquire().await()
val result = connection.sync().multi {
   get(key1)
   get(key2)
   sismember(key3, "test".encodeToByteArray())
}

println("Executed multi: $result ") // executed
println("Result 0: ${result.get<ByteArray>(0)}") // executed

The prints display information as expected and the transaction is executed.
However, if we're using the coroutine, the transaction will just block and never be performed
val pool: BoundedAsyncPool<StatefulRedisConnection<ByteArray, ByteArray>> = ...
val connection: RedisCoroutinesCommands<ByteArray, ByteArray> = pool.acquire().await().coroutines()
val result = connection.multi {
   get(key1)
   get(key2)
   sismember(key3, "test".encodeToByteArray())
}

println("Executed multi: $result ") // never executed
println("Result 0: ${result.get<ByteArray>(0)}") // never executed

Stack trace
Nothing thrown.

Input Code
Repository

Expected behavior/code
The transaction should  be executed using coroutine extension
Environment

Lettuce version(s): [6.2.3.RELEASE]
Redis version: [7.0.8]
Kotlin: [1.8.0]
Coroutine: [1.6.4]

Possible Solution

Additional context

Looks like a duplicate of #1954.
We deprecated the multi extension because of that reason as Redis' transaction do not work well with an async API.

Ok thanks ! And sorry for the duplicate
So for the moment, we can't use transaction. I will just make several requests in this case while waiting for a possible fix.

Yes, sorry for the inconvenience. Let me reopen the ticket so we add proper deprecation annotations.


What's the best solution for sub-charts get access to overridden values applied to the parent charts using flags --values values.yaml

Output of helm version: version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"clean", GoVersion:"go1.13.12"}
Currently, my chart has a structure like this:
service-A/
    charts/
        service-B/
            templates/
                service-b-deployment.yaml
            service-b-values.yaml
    service-a-values.yaml
the command I am using to deploy service-A is:
helm3 upgrade --debug service-A --values values_overridden.yaml
service-b-deployment.yaml:
...
    containers:
      - name: {{ .Chart.Name }}
         image: {{  .Values.common.imageRepository }}/prometheus-adapter
...

values_overridden.yaml:
common:
  imageRepository: localhost

The problem is that subcharts cannot get access to any values defined in values_overridden.yaml.
I know I can set a section in service-a-values.yaml to push values to subcharts like:
service-a-values.yaml:
service-B:
  common:
    imageRepository: localhost

but how can I reference overridden values in service-a-values.yaml?
I have gone through many resources talking about the solutions for this problem, but none of them gives an accurate and functional way. Does anyone have any suggestions?

Did you see https://helm.sh/docs/chart_template_guide/subcharts_and_globals/#overriding-values-from-a-parent-chart in the documentation? Does that help?

No, it doesn't help.
Just as I said, I know I can set a section for a sub-chart in its parent's value.yaml to push these values to child charts. However, my problem is not overriding values from a parent chart, I am trying to override child chart values using --values flag while installing the parent chart.

Hi @Saewo0. I'm having a difficult time trying to understand what you are attempting to achieve. More specifically:

The problem is that subcharts cannot get access to any values defined in values_overridden.yaml.

I am trying to override child chart values using --values flag while installing the parent chart.

That sounds a lot like what @mattfarina mentioned. Perhaps there's some miscommunication occurring here and you're looking for some other answer?
With the following values_overridden.yaml:
service-B:
  common:
    imageRepository: localhost

That will override child chart values using the --values flag. It will not override values in the parent chart.

but how can I reference overridden values in service-a-values.yaml?

This is a separate, discrete, problem. There is no way to look up values set at different levels. You are just passing a set of values, which are all merged in a particular order, and the template engine is left to render the templates using the merged set of values. You cannot "look up" prior values set a few levels lower. Have a look at the reasoning provided in
Does https://helm.sh/docs/topics/charts/#importing-child-values-via-dependencies or the proposal in #7477 help at all? Those are in the opposite direction (from child to parent), but I thought I'd bring it up in case it helps.
Perhaps if you could re-iterate the issue you are trying to solve, that might help us better understand how we can help.

I'm going to close this ticket due to inactivity, but please re-open if this still needs to be addressed. Thanks!


Images is return twice when we take edited photo.

I am having the same issue. Really weird its returning two photos by selecting 1 edited photo in iPhone gallery.


Streamline histogram and stats generation

This PR does a few different things:

Returns the created dataset from doTiledShepherdSegmentation_finalize/doTiledShepherdSegmentation so it is all ready to use by the caller.
Writes the Histogram to the RAT by default (we have to calculate this anyway for the missing segments check)
Calculates overviews in AWS Batch

I think tiling.py line 688 now needs to pass outDs.

Good work with the tests @gillins
I can see that this is because the file is now left open, since we are now passing the outDs back. However, I can no longer remember why we felt this was necessary. What would happen if we just left it as it was, and you re-opened it to do the histogram and overviews?
We can see from the way it scrambled the tests script that we have made a fundamental change to the behaviour of the API, and I don't remember why.


[Bug] Sometimes alacritty doesn't fully render output

Quite often alacritty doesn't finish rendering the output, it is reproducible even after executing the same command over and over again. When it's stuck, if I hit Enter, this will cause it to refresh window, but until I do anything inside the window, it will remain like that.
It's best described with a gif:

It's not the same as #459, as here window is always focused.
System info: Arch, i3, https://github.com/jwilm/alacritty/commit/f298e0455ab549aac1835ba59467ce06111b9bc9 installed via AUR.

@maximbaz  thanks for the report!
This is a bummer; I thought we had squashed that issue last year before release. Did this start recently for you?

Well, to be honest I was waiting for glyph offset to be merged, so I only started using alacritty yesterday.
I wanted to do a git bisect, but I can't build almost any old commits, either rust language changes or something else.
I managed to build e0980df from 2 months ago, and there the issue exists.
I should also mention that I removed my custom config and the issue still persists, so it is not a config problem.

Affects me as well. As seen in the attached picture, the bottom row of neovim is about 25% cut off for me.
Installed from AUR:
local/alacritty-git <IP_ADDRESS>2.g6659810-1
    A cross-platform, GPU enhanced terminal emulator

Window manager is herbstluft if it makes any difference.

Would one of you mind trying to build from git, directly? I haven't been able to repro this, and you are both building from AUR.

I did that already, when I mentioned that I reproduced the issue on a 2 month old commit https://github.com/jwilm/alacritty/commit/e0980df48ef50ddb48021d9375ef005eac268b7e.
At that time I also built the master from git, and both times I could reproduce it.
And by "built" I mean I cloned the repo and ran cargo build --release. This is what AUR is doing anyway, it is cloning repo and running this one command.

@maximbaz ah, thanks for clarifying.
Since I'm unable to repro at this point, I'll try staring at the code for a bit for anything obviously wrong.
@iv597 I just realized you're commenting on a separate issue. We've got at least 1 ticket open for it: #279.

Thanks! Is there anything I could get for you? Running in debug mode, logs, anything that could help?
We could also arrange a screen sharing if you want 🙂

@maximbaz thanks for the offer, but nothing has come to mind. Last time the bug was "fixed", it was a race condition between the parser thread and render thread. Would need to add some logging to make such a thing show up in the first place.
I will probably ask you to try out a branch at some point with either logging like that or a candidate fix.

This issue is very annoying and happens quite often, I tried to investigate it. Found the old issue you were referring to (#29), the code in the referenced commits seems reasonable to me.
And then I found something curious. When I avoid the --release flag to cargo build, the bug does not reproduce! I usually can reproduce the issue within 1 minute on the release build, but not on the debug build.
@jwilm am I right to assume that there is no logic in alacritty itself that depends on whether it is debug or release build? So it must be some unfortunate compiler optimization?

@maximbaz that's right; no code dependent on build type. Which version of the Rust compiler are you using? rustc -V

rustc 1.17.0

Digging deeper, making changes below to [profile.release] section of Cargo.toml (one at a time) and observing the results of cargo build --release:

lto = false -- no effect
opt-level = 2 -- no effect (3 is the default value for release)
opt-level = 1 -- 🎉 bug is not reproducing

So, I guess this is a hard proof that compiler optimization is somehow influencing the behavior.
How can we go from here? It would be unfortunate to disable the optimizations for everyone, and yet I'm sure I am not (or will not) be the only one affected. This is also not an easy job to describe the bug for the compiler team 🙂
For now I'll be manually adding opt-level = 1 as the last line of Cargo.toml before every upgrade.

@maximbaz my guess is that the optimization level only affects this in the sense that it makes the code run faster, and therefore triggers a race condition more often (or at all).
I've seen this occasionally (using git build), though for me it's usually individual characters inside neovim. In particular, it seems to happen to non-ASCII characters like ø. Not sure if that is of any help at all.

I agree, it is more probable that the race condition is on alacritty's side than it is a bug in the compiler itself.

I have been having the same issue.  The oldest commit I can still build  (4e9a307bed50fc02f101eb6cbfa4d39283dd6b8c from December 12th 2016) still reproduces the issue so I don't think its a recent regression.  The issue reproduces consistently on both debug and release builds, but it's harder to reproduce on a debug build.  I've also tried both the stable (1.18) and nightly compiler, and the issue reproduces on both.
It appears to be a subtle race condition in alacritty based the various build configurations I've tested.

I've replaced my laptop and I cannot reproduce this issue anymore (don't have access to the old laptop). It still has an Intel GPU, although a different model.
The only software difference I can think of is that I do not have xf86-video-intel (X.org Intel video driver). It didn't work properly on the new laptop, and as I learned it is often not recommended to install.
@gslavin out of curiosity, what kind of hardware and OS do you use? If you happen to be on Arch, do you have xf86-video-intel installed and can you reproduce the issue after removing this driver and rebooting?

I'm running Ubuntu 16.04.2 LTS on a late 2011 MacBook Pro, so the issue isn't because of the mentioned driver.
For me, this issue only occurs if my terminal is maximized.  If I use a smaller window size (literally anything besides maximized), I cannot reproduce the issue.

I just started getting this for some reason (not sure, maybe a few weeks/months ago). I'm using Arch and i3-gaps. Never had this issue on Gnome for whatever reason...
$ alacritty --version
alacritty 0.2.0

$ rustc -V
rustc 1.29.1

I'm going to try opt-level = 1: https://github.com/jwilm/alacritty/issues/540#issuecomment-304479048
This is weird. I never noticed it before updating to 0.3.2. Now this issue bothers me multiple times a day.

While doing some refactoring for the event loop 2.0 rework, I found an interesting mismatch in constants which might be responsible for this.
The PTY reader buffer is defined with a size of 0x1_000 here:
https://github.com/jwilm/alacritty/blob/master/alacritty_terminal/src/event_loop.rs#L332
However, the maximum number of bytes which can be read into this buffer is defined as 0x10_000 a bit farther down:
https://github.com/jwilm/alacritty/blob/master/alacritty_terminal/src/event_loop.rs#L234
I personally can't reproduce this issue, however if anyone who can could recompile Alacritty in release mode, setting both of these values to 0x10_000, that would be a huge help. I'd imagine that could solve this problem.

@chrisduerr
            let mut state = state.unwrap_or_else(Default::default);
-            let mut buf = [0u8; 0x1000];
+            let mut buf = [0u8; 0x1_0000];

did not fix it, sadly.
After build I get this
root@localhost alacritty]# target/release/alacritty -V
alacritty 0.3.2 (f2b1bfd)

and my test is to repeatedly clone a repo:
[root@localhost alacritty]# cat /root/try
 while true; do rm -rf dotfiles_mac/; git clone git@gitlab.axiros.com:klessinger/dotfiles_mac.git; done
[root@localhost alacritty]# target/release/alacritty -e /root/try

fail mode is  it hangs after 2, 3 loops and continues including a dump of the complete buffer after any stdin event (keypress).
My setup is fedora30 in vmware fusion with 3D Graphics Accel. enabled (OpenGL3.3)
=> should be reproducable, with a VMWare Fusion Test License.
HW: MBPro 2015 13''.
And, for what it's wort: I can get rid of the error by switching 3D Graphics off and set iomem=relaxed in grub.

@AXGKl This sounds like you're talking about #2217, not this issue?
Are you aware that this is about Alacritty actually completely swallowing output, never rendering it? So instead of rendering 1 2 3 4 5, this bug means Alacritty sometimes renders 1 2 5.

I have the same issue happening, from time to time, not refreshing until I press a key.
alacritty 0.3.3 / OpenBSD 6.5

It might be interesting to see if this can be recorded as a ref test. So when starting Alacritty with alacritty --ref-test it should output an alacritty.recording file which should print exactly the same stuff that was received during recording.
I'm curious if cating that file would show the same issue or not. If it's broken in the ref test, chances are that there might be an issue in the parser, otherwise it's likely more torwards the rendering stage.

hey, I just did the test, the first 2-3 cat commands, just output the result and wait for next command, the 4th one just start scrolling indefinitely, recording even more etc...
is that what you are expecting?

on my own I did not find a way to reproduce the behaviour, it happens regularly, I can never spot on what exactly triggers it, often it's on running command where I am waiting for some output coming out during the process and the end of the command, like a tar and you believe the command stalls, but pressing enter, just refresh and display the missing part.. which was finished minutes ago, I'll try again to find

often it's on running command where I am waiting for some output coming out during the process and the end of the command, like a tar and you believe the command stalls, but pressing enter, just refresh and the missing part.

From this comment I think you're experiencing this #2217 bug, does mouse move fixes the issue? And you're on X11, are not you?

As far as i remember when it happens, moving the mouse does not change anything, I need to press a key in the focussed windows to make it "spit out" the remaining part.
I do not experience #2217 , there is no "lag" of one key appearing after a press a new or such as described in the #2217  issue.
As said previously, alacritty 0.3.3, OpenBSD 6.5 release / amd64, so yes X11.

Oh, sorry I've misread your comment. You've said that the issue only happens in the end of the output of the long running commands and not when you're have long running command (#2217 is about continues output to a terminal on X11). So the thing that you can't repro it with mouse move just proves, that it's a different issue.

I mainly say long running commands, because i ran a lot of those recently (while trying alacritty as a daily driver terminal) and i was waiting thinking that the command was stalled when it was just not refreshed, but I'll try to narrow or find a situation where it happens...

I encountered a similar behavior recently where a program using cursor movements to update a real-time display in the normal (non alt screen) would sometimes result in missing output until Enter (or perhaps others) was pressed.
I believe that was with alacritty 0.3.3 (a39459e).
I'll watch out for a recurrence but it's happened precisely once for me.

The same behavior happens often for me (Archlinux, Intel GPU and Alacritty 0.3.3). Pressing any key or moving the mouse the missing output appears. Furthermore the issue is more frequent when all my CPU cores are near 100% usage (almost certainly).
The following testing command always triggers the issue for me if all my CPU cores are at 100%:
for i in `seq 1 100`; do sleep 0.1 && echo -n a; done; echo

Usually the output stop refreshing after the first 3-5 'a', then pressing any key or moving the mouse output refreshes. When my CPU is not being used it almost never happens.

@edubart What you're describing is a different issue, see #2217. This is already fixed in #2438, though that's still waiting for some upstream changes.

I can reproduce this issue very reliably.
I just made an Arch VM with Virtualbox, installed lightdm, i3-gaps, xorg stuff etc ... and every single time I use pacman -S commands Alacritty will start displaying the loading bars and then suddenly stop, moving the mouse doesn't do anything for me but pressing enter appears to make Alacritty resume rendering. In a 1m install like firefox it happens ~20 times. Sometimes it even happens before the password prompt (for sudo pacman ... ).
alacritty 0.3.3-3

@K41eb That issue is fixed in the latest master.

When will a new release be put out that includes this fix?

I've encountered this issue consistently for a while. I usually rebuild alacritty from master every week or two to check if it's been resolved. When I went through that process right now, I thought of testing for the bug with the default config rather than my own custom config. During that process, I noticed that at least in my environment, the incomplete output rendering only happens when the decorations config value is set to none. I thought I would post my results here in case it helps in debugging the issue. I'm running the latest master (8abca441827788d48de49d3552735cdd0999379e) on Ubuntu 19.10 and kernel 5.3.0.
Ironically, being able to disable window decorations is (for me) the killer feature that kept me rebuilding and testing alacritty every week :sweat_smile:

Even with decorations disabled, I've never encountered this issue myself before.
It also seems very unlikely that it is the cause of this bug, so it's probably more of a coincidence I'd assume.

I had / still have the same issue. But this insight could be helpful:
Compositors for window managers
In my case, when running Compton, Alacritty will show exactly the behavior mentioned above. When Compton is not running, everything works smoothly.
As I've read, this and related issue are related to Xorg. So a compositor interfering would make sense.
Further investigation
Maybe other compositors will do fine - one could try Picom, but as a fork of Compton, there is a chance this happens too. If there are other compositors, one could / should give them a try. It'd be a shame not to be able to combine Alacritty and a compositor.
I will play with Compton's settings to figure out if there is a setting that interferes.
Tested on
This was tested on alacritty 0.4.1 and on alacritty 0.5.0-dev (13eb50d).

Closing as a duplicate of #824. I'm not sure why this has been kept around for so long since it seems very clearly to be the same issue. I believe I originally thought that the output was partially incorrect, but it seems like it's just freezing the redraw just like the other issue.


pre-request check version number

Fix internal issue #134
Use regexp and json.Unmarshal to convert version output to semver.Version for comparison of version.
Happy to change version number requirements if folks have better suggestions.

Move to https://github.com/Azure/azure-dev/pull/84


Update Setting-up-a-multi-tenant-Orchard-site.markdown

I need to run netsh on Windows 10 too.

thanks for the update


vox area sign has obvious parallels to real world discriminatory language and signage. Should consider change or removal.

Description
The wall mount sign "voxcrossing.png" labeled in game as "vox area sign" has several reasons to be changed or removed.
\SS14\Resources\Textures\Structures\Wallmounts\signs.rsi\voxcross.png
Most obviously, it parallels discriminatory treatment, language, and signage in the United States. In particular, the name, "vox area sign" is egregiously similar. The notion that signs need to be put up to indicate where certain species should or could go is an issue in itself. The stations, while not equally accessible to all, should at least avoid language and signage that organizes space by species. "voxcrossing.png" is a dehumanizing name as well, which could be interpreted to indicate that vox are animals or should be treated as animals.
Additionally, the sign is meant to indicate an area of exclusively N2 atmosphere, which is already easily accomplished with atmos_n2.png labeled in game as "N2 warning sign". The addition of a sign to indicate a space for vox is inferior at communicating, especially to new players, that the area has a different atmosphere composition.
There are no "area signs" equivalent for any other species, and they would be unnecessary in almost all cases. Singling the vox out as both different and to be treated different. Signs should indicate what is different about an area not who should go there.
Voxboxes as they've come to be called are also expected to be tacked on to the station as an afterthought, indicating NT did not plan for N2 breathing species. Having signage specifically for them changes the implication from "lacking in planning" to "intentionally inferior", at least to me.
Additional context
I could add example of signs that might better explain why I have created this issue, but I think most have seen them. If necessary, I will add them later at request.
I am no expert at communicating on such sensitive matters, but I felt this issue should be brought up immediately. If my wording or format is lacking in some way, please let me know and I apologize ahead of time.

what

Honestly, I have been interpreting it as "Vox are relatively new, so stations are not yet updated". Only relatively though. My Vox is still cranky about lack of facilities. (Not even the occasional pre distributed canister? Come on guys!)

slimepeople can live perfectly fine in vox boxes so a description-changed n2 sign will do

what

I can provide clarification. What's the unclear portion?

where even is "voxcrossing.png" i cant find it in the game files

where even is "voxcrossing.png" i cant find it in the game files

t\SS14\Resources\Textures\Structures\Wallmounts\signs.rsi\voxcross.png

Vox get poisoned by breathing in oxygen.

i didnt know this was even a thing, it should jsut be changed to a nitrogen saturated environment sign

What

What
Which part is unclear?

The sprite was apparently taken from /vg/station, where Vox are haha slur slur. Part of that means that it intentionally looks worn/damaged like other Vox-specific infrastructure. How this managed to pass by review of art directors is kind of baffling to me and I am going to light a fire under somebody's ass for this.
/vg/ does have a lot of useful "material" related to the Vox species, as they're actually uniquely developed there. But the 4chan humor can stay at the door.
Agree that it should probably be one of those blue sprites that is used to indicate rooms. I don't really care too much about whether the iconography should include a Vox or just be generic N2. To me having an actual icon of a Vox is no worse than a bathroom sign as long as it uses more neutral colors (look I know split gender bathrooms are cringe but you get the point).

I would like to argue in favor of using a "no oxygen" sign instead of a nitrogen sign. The station air is already nitrogen saturated, the issue vox have is the presence of oxygen. The issue most other species will have in the vox box is similarly, the absence of oxygen.

I would like to argue in favor of using a "no oxygen" sign instead of a nitrogen sign. The station air is already nitrogen saturated, the issue vox have is the presence of oxygen. The issue most other species will have in the vox box is similarly, the absence of oxygen.

the O2 sign with a big Red Circle with a slash through it might be worthwhile?

I would like to argue in favor of using a "no oxygen" sign instead of a nitrogen sign. The station air is already nitrogen saturated, the issue vox have is the presence of oxygen. The issue most other species will have in the vox box is similarly, the absence of oxygen.

Indicating "no oxygen" does indeed make sense from a hazard perspective, but if we want to do that I think it'd be better if we had both.

It feels like this issue fails to consider that the "Voxbox" and the accompanying Vox sign is implemented as an accessibility aid indicator for the species, and the comparison to real life race discrimination does not hold up in that context.
 Rather it's designed as an area to serve specific physiological needs for Vox since they can't perform some basic life functions without difficulty without it. No one is stopping a Vox from sitting down at the bar to order a drink, and no one is stopped from sitting with the Vox in the voxbox. But if the Vox is gonna take a sip from that drink then, yeah, they probably wanna do it in a nitrogen-rich environment or else they get poisoned.
To me this reads like complaining that an office has a dedicated accessibility toilet. "How dare you mark out the area designed to accommodate wheelchair users?"
Personally I think the sign should be made less scrappy and/or changed to N2, and the Vox area shouldn't be decorated in any poorer condition than the rest of the station, but I disagree with the thesis presented in the original post.

How's this for a quick version? will rough it up a bit if this is a good start. Then make a matching _no_o2 version as well.

It feels like this issue fails to consider that the "Voxbox" and the accompanying Vox sign is implemented as an accessibility aid indicator for the species, and the comparison to real life race discrimination does not hold up in that context.

According to PJB above, the intention of the original source was to emulate early USA treatment of racial discrimination and segregation. Also, Vox aren't disabled.

I see what you're thinking, but I am worried it isn't likely to be eye catching or clear without close inspection. Worse, it may not be easy to distinguish between the no-o2 sign without in game inspection.

That's a good point. is there a specific color pallet that should be used for this context? Red/Black is the easiest to catch the eye and notify the user "hey, this is different"

I see what you're thinking, but I am worried it isn't likely to be eye catching or clear without close inspection. Worse, it may not be easy to distinguish between the no-o2 sign without in game inspection.

That's a good point. is there a specific color pallet that should be used for this context? Red/Black is the easiest to catch the eye and notify the user "hey, this is different"

So not at a useful device for this so excuse the fidelity.
I would likely take inspiration from Hazard Diamonds in the overall design of the sign. Keep it simple, with minimal details.
This is for public areas rather than specialized areas, so deviation from the air sines in engineering should be fine. It is a different audience, after all.
I would then likely match the color associated with the gas to the gas label, to make it stand out.

I think it would make sense to make the "no oxygen" sign a hazard diamond the color of nitrogen, with a crossed out black O2 in it

All current hazard signs are triangle, not diamond. in fact, only diamond currently is voxcross.png should I use triangle instead?

It feels like this issue fails to consider that the "Voxbox" and the accompanying Vox sign is implemented as an accessibility aid indicator for the species, and the comparison to real life race discrimination does not hold up in that context.

According to PJB above, the intention of the original source was to emulate early USA treatment of racial discrimination and segregation.

Pending clarification I don't think that's what PJB said, other than indicating that Vox came from a community where Vox were mistreated as a species.
The sprite was apparently taken from /vg/station, where Vox are "haha slur slur". Part of that means that it intentionally looks worn/damaged like other Vox-specific infrastructure.
That does not say anything about them emulating USA racial discrimination in their design, and disregards that Vox went through its own design document for SS14, where the species was evaluated on its own.

Also, Vox aren't disabled.

I specifically worded my post to make sure I did not say that. They do however have a specific physiological need that is not shared with the majority of the population on the station, and it's one that requires specific accommodations for healthy living. While we do not have alien species in our human society, the closest comparison would be to an individual with a health condition, so the comparison is apt, much more than comparing it to forceful segregation.

All current hazard signs are triangle, not diamond. in fact, only diamond currently is voxcross.png should I use triangle instead?

No issue with that here. Based on my clumsy scribbles, I am not sure I can sketch that for now. I will need to wait a few hours for better tools.

I think it would make sense to make the "no oxygen" sign a hazard diamond the color of nitrogen, with a crossed out black O2 in it

I hear where you are going, but I have two concerns. First, it would limit use of the sign to nitrogen filled areas with no oxygen. (So no applying it to a burn chamber.) Not a deal breaker, but an odd choice.
The second: is that easily drawn and read at the relevant size? Especially with 02 being what is crossed out? That kind of sign would need more pixels to work well.

It feels like this issue fails to consider that the "Voxbox" and the accompanying Vox sign is implemented as an accessibility aid indicator for the species, and the comparison to real life race discrimination does not hold up in that context.

According to PJB above, the intention of the original source was to emulate early USA treatment of racial discrimination and segregation. Also, Vox aren't disabled.

This isn't really an important point to debate but implying that 4channers were thinking more specifically than "haha racism funny" is giving them too much credit tbh.

I think having the sign displaying the atmos type (i.e. N2) is much more neutral and has no unfortunate implications.

I'll post a couple versions to debate on soon. I have never done a PR tho, so once we decide I might need help.

Quick version of nitrogen-colored diamond signs

Now I see what you are thinking. If you sacrifice nitrogen colored for either neutral or yellow background, the red cross should pop more.

alternative sign idea:

alternative sign idea:

There are not enough pixels to write all of that in a readable way
The N2 diamond kinda grew on me becausse with the black border, it not only is an N2 sign - it literally depicts an enclosed area containing N2

This is what a real one looks like. And I like the enclosed diamond idea. My signs are turning out bad. so I'll leave it to better spriters. not the kind of thing I normally make.

workshopped design with art directors

 This is what a real one looks like. And I like the enclosed diamond idea. My signs are turning out bad. so I'll leave it to better spriters. not the kind of thing I normally make.

If you feel bad about it, I recommend looking at the rules for designing a flag. They may be helpful for designing sprites.

(alternate "n2 boxed in" with a blue trim, indicating the surrounding oxygen)

I wouldn't want to use the diamond if what you are describing is not a warning. The primary reason for this is that some people have done a lot of work to associate the yellow diamond with WARNING.
If it's being used as "boxed in" rather than "warning" (as it would be in the 02 and NO O2 case) can the diamond be a square or other shape?


Can't control log level in Node.js API or webpack-dev-middleware

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
CLI watch mode has a info-verbosity option. It also respects the stats config.
Node.js API and webpack-dev-middleware doesn't have the same control.
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
Node.js API and webpack-dev-middleware can control log level the same way as CLI, e.g. { stats: { all: false } }.
If this is a feature request, what is motivation or use case for changing the behavior?
Calling Node API in task runners, such as Gulp. It is not obvious file change is detected and webpack starts compilation (especially when compilation takes some time). Only when compilation is completed then the callback can be used to print some information.
Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.
Node.js 8.11.1
webpack 4.5.0
Windows 10 x64

Probably related to #1872

The node.js API doesn't print anything by default. You need to print it manually i. e. via console.log(stats.toString()). toString() can be passed options.
webpack-dev-middleware has a stats option, which allows to control the output.


i18n(de): translate badges

Description
Translation of badges.mdx into German language.
Participating in Hacktoberfest!

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

de
components/badges.mdx
Localization added, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Garvit Sonawala

@Garvit-Sonawala

Welcome to openAOD! I have sent an invite to join our organization. We also recommend joining our Discord server : https://discord.gg/wZ83xSJSsN. If you have any questions regarding contributing or anything else feel free to write here or ping me on Discord. Cheers. Have a great day ahead of you!


Add support for individual multicast address

@rhuss : PR for #421

btw, if you do a rebase to the latest Jolokia master, the CI run will be fixed.

I'm working on it but it will make the change more difficult and big.

@rhuss : Ready to merge? :-)

sorry, just back from a conference. will give it a review asap.


📃: Add DSA examples using String

:red_circle: ** String* :
:red_circle: 📃: Add DSA examples using String :
:red_circle: Brief Explanation :
Contributors are expected to add examples of common data structures and algorithm problems that involve string manipulation. Examples may include tasks like reversing a string, checking for a palindrome, finding the longest common prefix among a list of strings, determining if two strings are anagrams, and counting occurrences of a substring. Each example should include clear, concise code with a brief explanation of the approach used.
Screenshots 📷
NA

:white_check_mark: To be Mentioned while taking the issue :

Full name : Arpit Mishra
What is your participant role? (Mention the Open Source Program name. Eg. GSOC, GSSOC, SSOC, JWOC, etc.)
Mentor ,Gssoc 2024 Ext

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

@TheChaoticor please assign me

Ok

@TheChaoticor please review this.
Thanks

Can I work on this issue?


[EventRequest] Codeunit 7110 (Analysis Report Managment), Function SetItemRowFilters ==> OnAfterSetItemRowFilters

Hi,
we want to add additional filters on "Item Statistics Buffer" in function "SetItemRowFilters" and therefore we suggest the following Event (see line 620):

The Event should look like this:

Please define both parameter as var.
Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


add game loop

add the game loop that let's player to play the game

PR Reviewer Guide
After analyzing the pull request, here are my findings:
Overall Feedback:
The addition of the game loop is a significant step towards making the game functional. The code is generally well-structured, but there are some areas for improvement, particularly regarding error handling and performance considerations.
Score: 85/100
Labels: Enhancement
Code Suggestions:

File: main.py

Language: Python
Suggestion Content: Implement a mechanism to limit the frame rate of the game loop to improve performance and reduce CPU usage.
Relevant Line: +    while True:
Existing Code:while True:

Improved Code:clock = pygame.time.Clock()
while True:
    clock.tick(60)  # Limit to 60 frames per second

File: main.py

Language: Python
Suggestion Content: Add a way to gracefully exit the game loop and clean up resources when quitting.
Relevant Line: +                return  # Exit the game loop if the user closes the window
Existing Code:return  # Exit the game loop if the user closes the window

Improved Code:pygame.quit()  # Clean up Pygame resources
return

File: main.py

Language: Python
Suggestion Content: Consider adding a delay or a sleep mechanism to control the game loop's execution speed, which can help in managing CPU usage.
Relevant Line: +        # Update the display
Existing Code:pygame.display.flip()

Improved Code:pygame.display.flip()
pygame.time.delay(10)  # Add a small delay to reduce CPU usage

Great work on adding the game loop! Here are some suggestions:

Implement a mechanism to limit the frame rate of the game loop to improve performance.
Add a way to gracefully exit the game loop and clean up resources when quitting.
Consider adding a delay to control the game loop's execution speed, which can help manage CPU usage.

Persistent review updated to latest commit https://github.com/ngduyanhece/asteroids/commit/b9443251331f49f0df9196b84327077ee91982f3

PR Reviewer Guide
After analyzing the pull request, here are my findings:
Overall Feedback:
The addition of the game loop is a significant enhancement for the player experience. The code is structured well, but there are opportunities to improve error handling, performance, and code clarity.
Score: 85/100
Labels: Enhancement
Code Suggestions:

File: main.py

Language: Python
Suggestion Content: Implement error handling for Pygame initialization to ensure the game does not crash unexpectedly.
Relevant Line: +    pygame.init()  # Initialize Pygame
Existing Code:pygame.init()  # Initialize Pygame

Improved Code:try:
    pygame.init()  # Initialize Pygame
except Exception as e:
    print(f'Failed to initialize Pygame: {e}')
    return  # Exit if initialization fails

File: main.py

Language: Python
Suggestion Content: Remove the pygame.time.delay(10) to avoid unnecessary delays in the game loop, as clock.tick(60) already controls the frame rate.
Relevant Line: +        pygame.time.delay(10)  # Add a small delay to reduce CPU usage
Existing Code:pygame.time.delay(10)  # Add a small delay to reduce CPU usage

Improved Code:# Remove the delay to let clock.tick(60) manage the frame rate

File: main.py

Language: Python
Suggestion Content: Consider adding a mechanism to handle other events (like keyboard input) in the game loop for player interaction.
Relevant Line: +        # Event handling to check if the user wants to quit
Existing Code:for event in pygame.event.get():
    if event.type == pygame.QUIT:
        pygame.quit()
        return  # Exit the game loop if the user closes the window

Improved Code:for event in pygame.event.get():
    if event.type == pygame.QUIT:
        pygame.quit()
        return
    elif event.type == pygame.KEYDOWN:
        # Handle key presses for player movement or actions

Great addition with the game loop! Here are some suggestions:

Implement error handling for Pygame initialization to prevent crashes.
Remove the unnecessary delay in the game loop to improve performance.
Consider adding event handling for player interactions.

Incremental PR Reviewer Guide
After analyzing the pull request, here are my findings:
Overall Feedback:
The addition of the game loop is a crucial enhancement for player interaction. However, the current implementation lacks handling for player key events, which is essential for a responsive game experience. Additionally, the code could benefit from improved readability and structure.
Score: 75/100
Labels: Enhancement, Other
Code Suggestions:

File: main.py

Language: Python
Suggestion Content: Implement handling for player key events to enhance interactivity.
Relevant Line: +            elif event.type == pygame.KEYDOWN:
Existing Code:elif event.type == pygame.KEYDOWN:

Improved Code:elif event.type == pygame.KEYDOWN:
    if event.key == pygame.K_LEFT:
        # Move player left
    elif event.key == pygame.K_RIGHT:
        # Move player right

File: main.py

Language: Python
Suggestion Content: Consider adding a default case for unhandled events to improve robustness.
Relevant Line: +            elif event.type == pygame.KEYDOWN:
Existing Code:elif event.type == pygame.KEYDOWN:

Improved Code:else:
    # Handle other events or ignore

File: main.py

Language: Python
Suggestion Content: Ensure that the game loop has a consistent frame rate to improve gameplay experience.
Relevant Line: # Fill the screen with black color (RGB: 0, 0, 0)
Existing Code:screen.fill((0, 0, 0))

Improved Code:clock.tick(60)  # Limit to 60 frames per second
screen.fill((0, 0, 0))

The game loop addition is a great step forward! Here are some suggestions:

Implement handling for player key events to enhance interactivity.
Consider adding a default case for unhandled events to improve robustness.
Ensure that the game loop has a consistent frame rate to improve gameplay experience.


refactor: export type definitions from constants, runtime-call & storage

Hey guys, I'm building a library around PAPI, would be great if I can have access to these type definitions :D

Hey! Thanks for your contribution!
We'll rather not merge this. We're trying to be really careful about what we export and how, to avoid increasing the surface of the top-level client. Those types are not documented, and bound to change any time due to internal refactors.
In general, descriptors need to be thought as transparent to the user. Consumers should import the top-level client and stick it into getTypedApi directly. It has all the type information from the chain and descriptor checksum values, having the ability to reorganise without having to change the public API, makes it much easier to adapt to new changes that might in the future.


Leave GL_FRAMEBUFFER_SRGB disabled by default

Despite it is recommended to keep this enabled, it breaks integrations like imgui rendering to the default framebuffer.
Also it affects the glBlitFramebuffers in an odd way copying between non srgb and srgb images.
With the zengl examples it is more common to disable it for the blit than to actually use it while enabled.
Some drivers are not supporting GL_FRAMEBUFFER_SRGB according to the specs.
ZenGL should enable GL_FRAMEBUFFER_SRGB when needed and disable it afterwards.
This change should not affect existing users.

blit from an srgb image to an srgb screen

Moving this call to be enabled in the render command is expensive.
Also blit requires a more cumbersome logic to set this variable global parameter to the right value.
Having this flag enabled globally is indeed the right way to do it.


Add test for -nameout output

Using a cert with Cyrillic characters, kindly supplied by Dmitry Belyavsky

@beldmit fyi :)

Updated commit with spacing changes made.

thanks!


Combine collect and alert packages

Now we are have 2 similar packages for collecting performance metrics and generating performance alerts.
Both of them doing similar actions, and as result we are doing the same twice.
We need to prepare single package for this to reduce load and make work with it more comfortable.

This issue was solved by optimizing alert package. No need to combine it any more.


Presolve Platform-Dependency

What version of OR-tools and what language are you using?
Version: v7.6
Language: C++
Solver: CP-SAT
What operating system (Linux, Windows, ...) and version?
Win 10, Debian 10, macOS 10
What did you do?
On each platform: Loaded model.proto. Presolved. Saved presolved model.
What did you expect to see?
Platform-independent deterministic presolve.
What did you see instead?
Each presolved model differs in order of constraints.
Proto_files_after_presolve_comparison.zip
I suspect such dissimilarity (bug?) might affect subsequent solve.

It seems the max clique heuristics is platform dependent. We will investigate further.

Thank you. As it turns out, presolved models differ not only among platforms and not only in the order of constraints. Attached bellow, you can find model presolved on Mac by OR-Tools v7.6 compiled by Clang and by bazel. Number of constraints there is also different.
issue1918.zip

No plan to fix these. It is clearly in the clique max algo.
Note that search is also platform specific, so there is no point in fixing these.


Thank you! Not sure I am qualified 😅 but I'll give it a try!

@bnoordhuis Could you PTAL? LGTM in so far as I can read it and the tests pass 😅

I'll try to take a look over the weekend.

@bnoordhuis Could you PTAL? LGTM in so far as I can read it and the tests pass 😅

I shall take a look over the week-end too.  I have an alternate version on the back burner so let's see if @ErosZy approach is promissing...

@bnoordhuis @saghul I've made some changes to the code based on the review; could you please take another look? Thanks.

@ErosZy heads up, I'm doing some IC refactoring in #609 because I'm fairly sure I've identified some bugs. You may have to rework your changes a little.
(I wouldn't normally push such changes when I know they conflict with pull requests from contributors but bug fixes trump enhancements.)

Any chance in this one being finished and included in the forthcoming release? Any performance bump is always great to have 🙂

@saghul @bnoordhuis please check, thx.

Tests are 💚 ! @bnoordhuis can you PTAL?