Resources in table are not properly counted

When we do a scan we see that kubescape counts wrong scaned resources.
Based on attached screen example:
EXCLUDED RESOURCES are counted as 1 but should be 3
ALL RESURCES are counted as 2 but should be 24

@marioosh11 The number of resources you see in the resource summary (last row) is the number of UNIQUE resources. This means, if you scanned a single resource and that resource failed in all of the controls so each control will report that resource has failed but in the resource summary there was only a single resource scanned there for only one resource can fail.
This might be confusing as you can see the discussion we had here -> #246

Ok thanks for explanation.


Redoc never compiles locally

I have tried everything, switching node versions altering code. I can not get this to compile locally at all. I always get failed dependencies and if I edit either dist/redoc.js or dist/redoc.min.js the entire thing breaks. (All I am doing is removing the download button and trying to add some more functionality that is needed for my company internally. (I have tried every major version of node and npm from 4.0 & 3.0 upwards).
I am lost so any direction would be helpful.

@BafFlynN can you specify more details? Which error do you get? What is printed to console?
What OS you work on?

@BafFlynN check https://github.com/Rebilly/ReDoc/issues/168. Maybe you had the same issue

I was just gonna say, you fixed it :)


color_map function in the utils.py file

I didn't understand where does you utilize this function and for what purpose do you utilize it.

This is used for colorful visualization when saving the predicted semantic map. It is not used in this codebase.


Dry-run integration tests

To catch regressions on the benchmarking side use --dry-run option.

There aren't any current critical use cases that depend on --dry-run so we can close this for now. It was previously used for various request export / response import use cases.


[Perf] Support multiple test proxies

Some scenarios require multiple test proxies to bottleneck client
Proxies are assigned round-robin to parallel test instances
Ported from https://github.com/Azure/azure-sdk-for-net/pull/24265

@annatisch: ping

API changes have been detected in azure-storage-queue. You can review API changes here
API changes
-             permanent_delete: bool = ...,
-             set_immutability_policy: bool = ...,


Tutorial Page abap-environment-shell-plugin.md Issue. PROD

Tutorial issue found: https://github.com/sap-tutorials/abap-core-development/blob/master/tutorials/abap-environment-shell-plugin/abap-environment-shell-plugin.md contains invalid tags. Even though your tutorial was created, the invalid tags listed below were disregarded. Please double-check the following tags:

software-product-function>s-4hana-cloud-abap-environment

Affected server: PROD

I found the tag listed among the valid tags here: https://imsproddd27584c4.us2.hana.ondemand.com/ui/tags?search=S 4HANA cloud abap
Is this list not correct?
Thanks!
Arianna

Maybe software-product-function>sap-s-4hana-cloud--abap-environment is the correct tag see
https://github.com/sap-tutorials/abap-core-development/commit/d03aad89fdb376d2b8c2d1d104b72ca13c927d3b
https://developers.sap.com/tutorials/abap-s4hanacloud-login.html

I found the tag listed among the valid tags here: https://imsproddd27584c4.us2.hana.ondemand.com/ui/tags?search=S 4HANA cloud abap
Is this list not correct? Thanks! Arianna

Maybe software-product-function>sap-s-4hana-cloud--abap-environment is the correct tag see
https://github.com/sap-tutorials/abap-core-development/commit/d03aad89fdb376d2b8c2d1d104b72ca13c927d3b
https://developers.sap.com/tutorials/abap-s4hanacloud-login.html

Ok I adjusted the tags as requested.


Migrate new modules added to alpha export

catalogModuleGitlabOrgDiscoveryEntityProvider and catalogModuleGitlabDiscoveryProcessor now added in alpha export.
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Note that you will have to add DCO signatures to all commits as well as generating API reports. See the build details for more info.

i will go through all the comments and review in the coming weekend.
@pjungermann where can i find more information about processors being deprecated and superseded by providers?

That's specifically for ingestion of things. Processors still have a place, but specifically for ingestion they have some significant drawbacks.
https://backstage.io/docs/features/software-catalog/external-integrations


Custom components. error

I have using a custom component, based on:
https://fondant.ai/en/latest/components/components/#custom-components
dataset = dataset.apply(
    component_dir="components/biopython",
    arguments={
        "sequences": "Sequence"
    }
)

But this errors:

Thanks @picousse
This is outdated in the documentation. You can provide it as a positional argument instead:
dataset = dataset.apply(
    "components/biopython",
    arguments={
        "sequences": "Sequence"
    }
)

Just found it myself as well. thx for the swift response


Added dracut-netstart package for firecracker

The new package flake-pilot-firecracker-dracut-netstart supports users with building firecracker images that supports networking using systemd-networkd and systemd-resolved activated and persistent inside of the initrd.
This is related to Issue #76

@m-kat There are many ways to support networking. I think one of the straight forward ones to setup the network inside of the guest is to do it as part of the initrd and with systemd-networkd and systemd-resolved as it will be available on all distros. The proposed dracut module here is needed to persistently startup the network in the initrd and keep it alive even if there is no systemd after switch_root which is our use case when using firecracker with flake-pilot
The module code is therefore super easy and just starts the services
As it is provided as a package users can use this package for building their firecracker VMs. If they use kiwi it will be a simple:
<package name="flake-pilot-firecracker-dracut-netstart"/>

Thanks


gramps: add support for recommended packages, add joncojonathan to maintainers

Motivation for this change
Added maintainers data and populated with @joncojonathan.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[n/a] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[n/a] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

This makes #48008 unnecessary right?
As a nitpick: Please use imperative in your commit messages (e.g. gramps: add support for recommended packages). You can change that with an interactive rebase (git rebase --interactive HEAD~2, then mark the packages you want to edit with r).

This makes #48008 unnecessary right?

It does.  Sorry, I wasn't expecting that behaviour from the PR process.

As a nitpick: Please use imperative in your commit messages (e.g. gramps: add support for recommended packages). You can change that with an interactive rebase (git rebase --interactive HEAD~2, then mark the packages you want to edit with r).

Noted, thanks.

Yeah for small changes like these which depend on each other it makes sense to combine them in one PR.
Also please remove the dot at the end of the commit messages.

Understood, I'll make sure I don't submit with those in future.  Does the
full stop break a process somewhere?
I'm assuming you don't need me to edit these commit messages?
On Sun, 7 Oct 2018, 22:12 Timo Kaufmann<EMAIL_ADDRESS>wrote:

Yeah for small changes like these which depend on each other it makes
sense to combine them in one PR.
Also please remove the dot at the end of the commit messages.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/48010#issuecomment-427687474, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AK4rtn_YrPz1WNopmyM4a8qB_BbD2sxTks5uim44gaJpZM4XL7cr
.

Understood, I'll make sure I don't submit with those in future. Does the full stop break a process somewhere?

No, its just a matter of standardization.

I'm assuming you don't need me to edit these commit messages?

I did assume you'd do that, which is why I explained how to do it. Any reason not to?

@timokau I've recommitted without the ending full stop.  I appreciate the tuition in use of `git1, never done an interactive rebase before.
Only reason I wouldn't have done is because it seems like something I'd let slide once and just let them know.  There's nothing in the contributing guide that says to not have a closing period, only for meta.description.  I'll propose a clarification in that to help others.
Thanks again for the git tips.

I personally think my job as a reviewer is it to hold the people whose contributions I review to a high standard. I make plenty of mistakes when contributing myself and appreciate when the people reviewing my code do the same. Unfortunately there are no clear review guidelines for nixpkgs, so someone else may review differently. Fixing a commit message should not take very long. Maybe the first time it does, but aferwards you'll know your tooling better. I hope I don't sound antagonistic, I'm grateful for your contribution.
These rules aren't in the contribution guide, but they are general git convention. It couln't hurt to mention that in the contribution guidelines though.
Thanks for fixing the punctuation. The commit messages are still not in imperative ("add" instead of "added") and you added a merge conflict I don't understand though (you can also drop that with an interactive rebase).

Should be imperative now @timokau, I saw you'd renamed the PR so lost track and completely forgot to change the commit message, sorry.
No problem holding me to a high standard, I'd do the same, just with a different approach.  I'll read the general git convention link as I'm still very green when it comes to using git.
Everything look OK now?  I think I managed to drop the merge conflict.  Really like this interactive rebase thing!

@GrahamcOfBorg build gramps
Looks perfect, thank you for the contribution and your patience with the review :) Merge pending on the bots approval.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: gramps
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: gramps
Partial log (click to expand)
test_nodeathdate: 0.28

test_peopleprivate: 0.23

test_peoplepublic: 0.23

test_personwithincompleteevent: 0.39

test_relationshipbookmarks: 0.23

Success on x86_64-linux (full log)
Attempted: gramps
Partial log (click to expand)
test_nodeathdate: 0.53

test_peopleprivate: 0.45

test_peoplepublic: 0.44

test_personwithincompleteevent: 0.75

test_relationshipbookmarks: 0.46


LNURL-auth support

I think authentication could become a pretty cool feature.
We need to investigate how we can do it and how we can support lnurl-auth: https://⚡.bigsun.xyz/lnurl-auth.html

#147


Websocket Connection Termination during VMSS scaling (both auto or manual)

I have come across an interesting scenario -
Where customer is using a Single Page Application (SPA) that interacts with the user by dynamically rewriting the current web page, instead of the default method of the browser loading entire new pages
They are using WebSocket protocol here.
They have enabled auto scaling on VMSS.
When autoscaling rule triggers (both automatic or manual) and while the new VM is spinning up, the established WebSocket connection on running VM instance gets dropped and all persistent session gets lost.
Customer wanted to preserve the existing WebSocket connection on running VM during the entire process of autoscaling.
After deeply investigating the logs, it was suggested that we change the LB's probe from TCP to HTTP 80, so that ILB won't add new members of the VMSS into LB distribution too early.
And this actually resolved customer's issue and they would like to see this updated in our public documents for troubleshooting autoscale issues.
Please connect with me on Teams and I can share full details about this case.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61d114e9-410c-5fb7-7e2c-dcf55551ee87
Version Independent ID: 592f0709-cbab-43dc-8d40-3e1a33e40b62
Content: Troubleshoot autoscale with Virtual Machine Scale Sets - Azure Virtual Machine Scale Sets
Content Source: articles/virtual-machine-scale-sets/virtual-machine-scale-sets-troubleshoot.md
Service: virtual-machine-scale-sets
Sub-service: autoscale
GitHub Login: @avirishuv
Microsoft Alias: avverma

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

I don't believe we have any updates to make on this specific page based on the scenario. I will be closing this out but feel free to reach out to me offline if you have additional questions.
#please-close


Incorrect git clone?

Hi,
I think there might be a forgotten update when migrating patato. Currently the second and third options to install patato in the docs are directed to the archived version. Is this meant to be the case?
see docs/intro/01_gettingstarted.rst

Thanks for letting me know! Hadn't spotted that. I'll fix that right away :)
Let me know if you have any other issues!


Manually downloaded files are removed instead of being validated

I haven't managed to reproduce this issue; but @Julienraptor01 and @LithRakoon have reported it occurring.
This reportedly only occurs when you quit packwiz-installer before adding manually downloaded mods (instead of using the Continue button).

I haven't managed to reproduce this issue; but @Julienraptor01 and @LithRakoon have reported it occurring.
This reportedly only occurs when you quit packwiz-installer before adding manually downloaded mods (instead of using the Continue button).

I can try to reproduce it to give more info but I'm not sure i'll be able to do it.
Currently you can use the steps i gave to him if anyone else have the same problem as they seem to work
What i remember is that i launched my 3.8.1 FO instance all the mods were deleted and PW complained.
I then tried to put the problematic mod (entityculling) in the mods folder and launched FO but again PW deleted the mod.
So i had the idea to start FO then wait for the error, then put the mods in the folder, then retry and it didn't delete it and validated it instead.

Something i didn't think of
I used multimc dev
Idk if it change anything but...

Something i didn't think of I used multimc dev Idk if it change anything but...

i used polymc stable so i dont think thats a factor


[nightly] clicking a contact avatar widget when a chat is "selected" opens the chat

it shouldn't

My branch


browse catalog tabs jump around at certain resolutions

At about 1024px screen width my Python tab plays catch me if you can:

@rhamilto @sg00dwin  @jeff-phillips-18 @dtaylor113

This is the current design @benjaminapetersen .  if one of the subcategories in the first row is selected, the subsequent rows of subcategories will be shown below the shown services.

We should improve this part of the design. I got some feedback at Summit regarding interaction with these tabs @serenamarie125

Yeah, maybe if there was more than one item in the second row it would have felt intentional.
Throwing out a suggestion, perhaps a subtle/transparent block around the orphan, matching it up to the first row?  Not sure if that fixes the jump though.


Display memory bug when creating circuit

When creating a circuit, the memory display a memory of 0 length (empty object), even thought it is not true.

I forgot to say, only when playing. At the frame 2 the memory will always be displayed as null

I just discovered that this issue is linked to the issue #534


iphoneX adaptive

That's the result of using a safeareaview. You could do not using safeareaview for that screen or add some negative margin for the text box (with Platform.OS === 'ios' && (height === 812 || width === 812) ?). Position absolute might work too.

@giantss  seeing the same problem, have you found a solution?


Limit bandwidth between clickhouse-client and clickhouse server

Hi, we have some options for clickhouse-client for limit bandwidth inside of clickhouse cluster, between nodes:
    /** The maximum speed of data exchange over the network in bytes per second. 0 - not bounded. */ \
    M(SettingUInt64, max_network_bandwidth, 0, "") \
    /** The maximum number of bytes to receive or transmit over the network, as part of the query. */ \
    M(SettingUInt64, max_network_bytes, 0, "") \
    /** The maximum speed of data exchange over the network for the user in bytes per second. 0 - not bounded. */ \
    M(SettingUInt64, max_network_bandwidth_for_user, 0, "")

but no, an option to limit bandwidth between client and clickhouse server...
Is it possible to have it in future? :)

Would like to have this feature to make dumps from Clickhouse

Added in master.

Thanks a lot! :)


hide upgrade feature from help command and docs

Since the upgarade is meant for release 2.0+ versions, hiding the upgrade feature from help and docs for now.
Signed-off-by: sinhaashish<EMAIL_ADDRESS>

bors try

bors merge

bors merge


Mock object protocol should fail when mock is not under learning mode

It is easy to forget to put #stub message when defining expected behavior:
mock someMessage willReturn: #result

It does not fail right now because of automock behavior:

without #stub (mock stub someMessage) the #willReturn: message here is considered as a normal message to an object (what is verified during the test). So it is just recorded in the interaction history and the default action is executed which returns another mock representing the result.

So it does not fail while expectation is not defined. And test is that case can simply pass the default scenario (without simulated condition).
Here this behavior needs to be improved. "Mock expectation" protocol should fail when it is not under learning mode.

done in v6.0.1


add more tests

I added a couple more tests. In particular I wanted something to test larger buffers to exercise the case when the code is 0xFF.

Thanks!


In multi-sets mark unexpected joins as suspicious

One way to spot errors is constructing a multi-year chart and spotting when the finish order doesn't match the start order the next year.  There are some genuine results for this - clubs getting added, crews withdrawing, etc.  It should be possible to ignore these and spot potential errors such as transpositions between crews and warn of a potential error.

First go added with 77bb33dbc9d9be3d31877b650ff8bda711d1089c
I think a better approach would be to go down and mark how often the delta between finish & start positions changes.

Issues caught either by code above or by inspection:

Mays Women 1989 - 1990 is badly wrong
CRA Men & Women: 2022 start order is finish from 2019, 2021 results we have are ignored.  Did they actually happen or deliberately ignored?
Eights Women 1979-1980 - why do position 2 and 3 swap over? Are we missing a bump on the last day in 1979?  Or post race penality?
Eights Women 1982-1983 & 1983-1984 - the lower divisions look randomised, did both have to do the getting on race?

CRA 2022: The CRA website has no information but https://elyrowingclub.org.uk/cra-town-bumps-2022/ has the text:

The CRA Town Bumps returned in July this year for the first ‘proper’ series since Covid. After cancellation in 2020, bumps races in 2021 were held but results discounted. This year, over 100 eights from Cambridge and other CRA clubs picked up where 2019 left off, and raced each other to defend their positions on the Cam.
Races on Monday and Tuesday were cancelled due to the forecast of exceptionally high temperatures (a decision everyone was glad of as the reality of 40C hit home!), but fiercely fought each night Wednesday-Friday. Three Isle of Ely crews competed.

So the data we have looks to be correct, and is consistent with the data on https://crarowing.co.uk/town-bumps/about-the-cra-town-bumps/results/historic-bumps-results/
Change e71255dd636d2b29986d934d14eff29ee4a6e671 marks 2022 CRA bumps as 4 race events with the first day unraced, previously it was marked as a 3 race event.


Graticule labels are misplaced when the map is rotated 45 degrees

Describe the bug
It seems like the graticule labels are misplaced when the map is rotated exactly at 45 degrees -- see this example. Attached is a screenshot that shows how the graticule labels are drawn on my machine (macOS 12.1, Firefox 97). Changing the rotation to 44.9 or 45.1 degrees is okay. Other angles that are problematic: -45 degrees, -135 degrees and 135 degrees.

To Reproduce
Steps to reproduce the behavior:

Open this code sandbox
Note that the graticule labels are misplaced (they are in the middle of the map, not at the edges)

Expected behavior
The graticule labels should be placed at the edges, just like with 44.9 or 45.1 degrees or any other angle that is not 45, -45, 135 or -135 degrees.
Additional info
I tried to fix this myself but I haven't figured it out yet; one thing that I've noticed is that the extent argument passed into Graticule.getParallelPoint_ does not seem like a valid extent because extent[0] > extent[2]. This happens only for 45, -45, 135 or -135 degrees.

It seems like the issue also depends on the window size; making the browser window wider when looking at the CodeSandbox example will make the labels jump all around; sometimes they disappear entirely, sometimes they get rendered in the middle of the map, but never at their right positions.

There will be a zero divide at https://github.com/openlayers/openlayers/blob/main/src/ol/layer/Graticule.js#L681-L682  Substituting zeros with a suitably small number should ensure a meaningful result.

Seems like this is the right place to poke around, but I've tried the proposed fix and it does not seem to work. With a rotation of 45 degrees, the denominator is something around 2.2e-16; clamping it to 0.001 or -0.001 depending on its sign will place the labels in a more predictable manner but still very close to the center of the view. I guess that the problem is that the code is trying to recover the "unrotated" width and height from the rotated extents (if I understand the code correctly), but trying to recover the original width / height is numerically unstable when you are close to a rotation of 45 degrees. (E.g., rotating a rectangle of width 300 and height 1 by 45 degrees has almost the same bounding box after rotation as rotating a rectangle of width 1 and height 300).

Calculating the "unrotated" width and height from the frame size and resolution is simpler than trigonometry and avoids random values when results used in division are close to zero https://codesandbox.io/s/k89jiq?file=/main.js

You beat me to it :) I did not check my emails and worked out something more complicated during the night because I did not notice that the resolution is stored in the view state. Thanks for the quick response, it seems to work on my side as well. Looking forward to seeing this in an upcoming release.


Makefile windows support

Updating for latest Makefile changes

I see there's quite a bit of activity on this PR still, is it ready to merge?

@karpathy - yes, let's do it.

@karpathy - thanks - I have a window-readme.md for this Makefile and other Windows support in my fork. What would like to do with this readme?

depends on its length. if too long, i'd hide it into doc/ and link to it from main README. if very short, ok to include in main README

Right now it's long. Will link it here later today for you to take a look.

@karpathy - here's the link to the readme:
https://github.com/rosslwheeler/llm.c/blob/windows-readme/doc/windows/windows_README.md
Put in the doc/ directory? Don't really have a preference....


Can you add more detail to 'benchmark.md'? 能丰富一下benchmark.md的内容吗？

Hi there,
I am a student doing research on distributed systems.
And I am trying to inject some fail-slowness into your system and investigate the performance variance.
Can you add more details to benchmark.md?
I want to know your VM size that generates the 1600+ tps result and your PolarDB cluster and PG configurations, so that I can replicate that result.
Besides, can you run the test without "--unlogged-table"? I want to know how much performance is influenced by the consensus algorithm.
It will be the best if you can deploy the system in three different machines and test it such that the network latency is considered.

Hi Essoz,
benchmark.md is just providing a way that how to benchmark our service using other tools like pgbench. Different result you will get by running benchmark on different cluster or configure.
If you want to do more research, you could set up your own environment following the doc deployment.md or simply deploy it using docker. Hope everything goes well with your experiment. Feel free to ask us if you fall into some trouble doing deployment.


Clock sync HEAD requests marked as type shaka.net.NetworkingEngine.RequestType.MANIFEST

Have you read the FAQ and checked for duplicate open issues?:
yes
What version of Shaka Player are you using?:
2.4.2 latest master
Can you reproduce the issue with our latest release version?:
Yes
Can you reproduce the issue with the latest code from master?:
Yes
Are you using the demo app or your own custom app?:
Custom
If custom app, can you reproduce the issue using our demo app?:
What browser and OS are you using?:
Chrome 67.0.3396.99
What are the manifest and license server URIs?:
Any
What did you do?
configure clockSyncUri and register filter with networking engine that performs manifest-request specific logic
What did you expect to happen?
clockSyncUri HEAD request isn't marked as manifest request
What actually happened?
Clock sync request is tagged as either something descriptive of what it is, or something generic.
Currently the requests Shaka makes for clock sync purposes are marked as request type MANIFEST, which can be misleading and cause problems in networking filters that rely on request type identification to perform specific logic. These requests should either have a generic type or perhaps a new type such as shaka.net.NetworkingEngine.RequestType.TIMING for example.

Sounds reasonable.  I'll schedule it.

We would be happy to take a pull request for this, if you're interested.  It should be quick and easy.

Sounds good @joeyparrish I'll do that


Not capable of running example files in Habitat-Lab

Not capable of running example files in Habitat-Lab
Habitat-Lab: v0.2.1
Habitat-Sim: v0.2.0
Machine: OSX 12.0.1 (macOS Monterey)
I just installed both habitat-sim and -lab on my machine as described in the instructions. I was capable of running all tests described in the habitat-sim README, however, when it came to running the example files from habitat-lab I started running into issues. Each example throws the following error after calling it:
(habitat_env) (env) my_mac habitat-lab % python3 examples/example.py
2021-11-13 14:59:06,563 Initializing dataset RearrangeDataset-v0
2021-11-13 14:59:06,563 Rearrange task assets are not downloaded locally, downloading and extracting now...
error: unrecognized arguments: --no-replace
usage: example.py [-h] [--uids [UIDS [UIDS ...]] | --list] [--data-path DATA_PATH] [--clean | --replace]
                  [--username USERNAME] [--password PASSWORD]

optional arguments:
  -h, --help            show this help message and exit
  --uids [UIDS [UIDS ...]]
                        Unique ID of the data to download.
  --list                List available datasource uid options and exit.
  --data-path DATA_PATH
                        Optionally provide a path to the desired root data/ directory. Default is "habitat-
                        sim/data/".
  --clean               Remove nested child directories for the datasource.
  --replace             If set, existing equivalent versions of any dataset found during download will be deleted
                        automatically. Otherwise user will be prompted before overriding existing data.
  --username USERNAME   Username to use for downloads that require authentication
  --password PASSWORD   Password to use for downloads that require authentication

I'm assuming that some wrong command to download the config environment is being called in the background but I wouldn't know where and why.
I tried reinstalling the packages using a new environment but I keep getting the same issue. Any help is much appreciated!

Hello, thanks for reaching out. Your issue should now be fixed on the most recent version.
The hab_suite branch now contains most of the functionality from the paper and we are slowly merging this into main. We made this tutorial to help get started with Habitat 2.0.
Please let me know if you have any more questions!

@nicolaischneider Feel free to re-open the issue, if you still have questions.

I am new to here, can we use on Mac M1 ?


WIP: Using pg_ls_waldir instead of pg_ls_dir for dump_xlog_stat

Hello,
The pg_monitor role allows to use the pg_ls_waldir function introduced in PostgreSQL 10.
The pg_monitor role is available on many PostgreSQL PaaS services (like RDS).
1 - Modification of the dump_xlog_stat query to use pg_ls_waldir instead of pg_ls_dir for postgresql 10 and above to be compatible with a user belonging to pg_monitor.
Tested with :
	SELECT
	    date_trunc('seconds', now()),
	    count(*) AS num_file,
	    pg_walfile_name (pg_current_wal_lsn ()) AS current,
	    sum(is_recycled::int) AS is_recycled,
	    sum((NOT is_recycled)::int) AS written,
	    max_wal
	FROM (
	    SELECT
	        file.name > first_value(file.name) OVER w AS is_recycled, (
	                SELECT
	                    setting
	                FROM
	                    pg_settings
	                WHERE
	                    name = 'max_wal_size')::float4 AS max_wal
	            FROM
	                (select * from pg_ls_waldir()) AS file
	            WHERE
	                file.name ~ '^[0-9A-F]{24}\$'
	WINDOW w AS (ORDER BY file.modification DESC)) AS t
	GROUP BY
	    6;

2 - Add an additional control in "if (!&is_superuser($DBUSER)) {" to control if the user belongs to the role pg_monitor to ensure the recovery of wal info is not removed from metrics.
I am preparing a patch in this direction, if you have any comments ...

I think I have never received this PR, however commit 7d83483 fixes point 1 and commit 32abd8d fixes point 2.

Thanks for integrating my comments:)
I didn't have time to integrate them :D
It's perfect!
Thanks Gilles!


Improve Kubelet Log API

Add support for tailing logs (tailLines query param).
Add support for following logs (follow query param).
Async stream log lines to client using hyper::Body::channel.
Allows for multiple log clients.

Closes: #49
Issue #49 was already fixed on master.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kflansburg sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@thomastaylor312 I can give some of the changes that you brought up a crack tonight if you want to wait before merging.

Hey @kflansburg! Let us know when this is ready for another round of reviews. :)

@kflansburg This should be good to merge once it is rebased (had another PR get merged right as I finished reviewing). No need to address my nit unless you feel like it

Fixed the merge conflict.
@bacongobbler I'm ready for further review / merge.
@thomastaylor312 Fixed your nit.

Thanks again @kflansburg!


Map iterators

This PR adds keys(), values(), and pairs() iterators for the persistent map as well as tests for all three.

I understand the concern, but the problem is that all of my attempts to maintain the position of the next entry of the map have failed. The nodes of the data structure hold no data of where they exist in relation to everything else and adding that data would severely decrease performance. If you don't want this PR go through as it is currently that's fine, But it may be a while before the iterators are included.

I


Set up data persistence (BaaS? database?)

GraphQL BaaSes (Backends as a Service) are available, from most to least expensive:
https://graph.cool/
https://www.reindex.io/
https://scaphold.io/

Or non-GraphQL realtime BaaSes:
https://firebase.google.com/
https://horizon.io/
We probably don't need realtime though, and they are not as nicely integrated into the ecosystem.

GaaS scaphold looks real good for this purpose!

We'll use MongoDB for now and reconsider it once we've launched an MVP


xiwi select display not available in xrandr video is not usable

jammy and bookworm
xorg fails to start
xiwi has unusable unstable video
Chrome book mediatek arm64

xiwi is damaged somehow the res or clk is way off

move to chroot systemd project


proxy: Update to Rust 1.26.0

Rust 1.26.0 is now available.
Notably, this release adds support for impl Trait.

Yay! 🎉


Objection vs Knex

Hello,
Seems like a very cool library but I'm a bit confused about what knex provides and what objection adds...Is there somewhere I can read about it? thanks!
EDITED: nevermind. Thanks :)

Knex provides basic query builder, transactions, connection pooling.
On top of that Objection.js provides models, relations, schema for models attributes and some more advanced features to insert / fetch nested models and JSONB query support for postgresql... and probably much more that I forgot to mention.

@elhigu I'd be specific about the distinction between "schema" and "schema validation", but other than that, sums it up! 👍

Maybe this can be closed (original post edited, post enlightenment).

This stuff kind of relates to #11 if also knex vs. objection distinction is described there some day.


Add support for chunks(itr; size=...)

Left todo:

[x] docstrings (no modification yet)

Closes #18

Codecov Report
Attention: Patch coverage is 96.59091% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 94.24%. Comparing base (14e87f2) to head (17d2064).

Files
Patch %
Lines

src/ChunkSplitters.jl
96.59%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   93.86%   94.24%   +0.38%
==========================================
  Files           2        2
  Lines         163      226      +63
==========================================
+ Hits          153      213      +60
- Misses         10       13       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I have to leave now. I've updated the docstring so this should be ready to be merged. Feel free to push it over the line :)

Would be great if we could get a new release with this soon. I'll then add support for this to OhMyThreads.jl.

I'm fixing a test that was incompatible with Julia 1.6, and then I'll release it.

I've added some documentation into the docs page and released it now as version 2.3.0.


ECS with EC2 getting No space left on device

Hi, here's my situation:
We have black-box tests running "continuously", for stage and prod, and it's using this provider:
        ecs_runner_provider = EcsRunnerProvider(
            self,
            id="EcsRunnerProvider",
            docker_in_docker=False,
            instance_type=InstanceType("t3.medium"),
            max_instances=2,
            cpu=2048,
        )

At the end of our action, we have a repository dispatch step, which "chains" another workflow of the same type, so think of it as if we are running two actions continously.
This works fine, the provisioning times are great, and the instances can handle the workload cheaply, but after an hour or two I get this error in the runner's logs
Unhandled exception. System.IO.IOException: No space left on device : '/home/runner/_diag/Runner_20231012-152020-utc.log'

and here's the full screenshot of the logs.

is there anything I'm doing wrong? we are creating tasks, and the tasks pick up instances, I guess the instances don't change, and I'm not sure how we guarantee ephemerality. in normal runner logs, I can see that we remove .runner on succesful runs. one thing to note is that in the actions we get our dependencies from cache to run a script. should I add a step where I wipe off disk data? Thanks for any help in advance

Bottom line, increase storage on the instance with storageSize. The default is 30GB.
        ecs_runner_provider = EcsRunnerProvider(
            self,
            id="EcsRunnerProvider",
            docker_in_docker=False,
            instance_type=InstanceType("t3.medium"),
            max_instances=2,
            cpu=2048,
            storageSize=cdk.Size.gigabytes(200),
        )

There are a few things can contribute to data not being immediately cleaned up from previous runs:

ECS can take a very long time to clean-up old containers (and their storage). We try to control it by setting that timeout to 5 seconds.
Docker is technically shared with the runner containers. Images used by the jobs themselves may linger for up to 30 minutes according to ECS defaults. I am honestly not sure if it will clean up all images, or just images ECS itself downloaded.
There might something else I haven't considered.
Logs that ECS/Docker might keep could be a reason. Issues like this are frequently log related.

If you could use Session Manager to connect to the ECS host and see what takes up most space, that would help pinpoint your specific issue and may help others in the future. You can use df -h, du -sh /*, docker images, and similar commands.

@kichik thanks for the great detailed response, I'll try what you've said and report back. and thanks for explaining the inner workings of things I have little experience with 👏👌

@kichik I'm lingering on this, just switched to fargate for the sake of convenience, closing for now, if I ever need it I'll do more research before opening

@sercantor @kichik While running the fargate provider did you run into any issues using customImageBuilder, I added a component for docker but whenever I run a workflow with it on the Initialize containers step of my workflow. It is giving me Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running? the following error. Any Ideas ?

@sercantor @kichik While running the fargate provider did you run into any issues using customImageBuilder, I added a component for docker but whenever I run a workflow with it on the Initialize containers step of my workflow. It is giving me Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running? the following error. Any Ideas ?

Docker is not supported on Fargate. It's an AWS limitation.

customImageBuilder.addComponent(RunnerImageComponent.docker()); wouldn't this command install docker in the container image ?

Docker is not supported even when installed. It can't run.

Is there any other work around if I want to run workflows which requires docker installed ?

Use either CodeBuild or EC2. The top of the readme has a table showing which provider supports which features.
Please open a new discussion post for questions in the future.


[Bug]: Payment page keeps loading indefinitely

Describe the bug
when we try to pay a LNURL Channel, the payment page keeps loading indefinitely. However, the payment is received by the Blocktank widget and it also appears in the Bitkit transaction history.
it only happened with LNURL channel with Pav and I
Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording

Operating system
GrapheneOS
Bitkit version
v97
Log output
No response

#1546


Highlight When Spin is Finish

Hi @zarocknz ,
Can i highlight area of winner segment? Or does plugin have function / option to show where a winner segment?
Maybe like this picture :

I want WinWheel highlight winner segment to notify the user.
Thank you 😃

Hi @muhibbudins  yes this is possible.
Please see this tutorial http://dougtesting.net/winwheel/docs/tut13_prize_detection the last example on the page "Changing the colour of the winning segment" does this.
When the spinning stops you can change the colour of the segment and then re-draw the wheel to show the changes as seen on line 55 and 58 of the code listing on that tutorial page.
Kind regards,
DouG.

Sound good!
But wait, i use image for segment. So how to change it? Cz code from the tutorial not working for me 😄
This is my code :
            window.wheelCallback = function() {
                // Get the number of the winning segment.
                var winningSegmentNumber = theWheel.getIndicatedSegmentNumber();

                // Loop and set fillStyle of all segments to gray.
                for (var x = 1; x < theWheel.segments.length; x ++)
                {
                    theWheel.segments[x].fillStyle = 'https://orori-telin.akamaized.net/assets.orori.com/indonesia/img/promo/wheel-of-fortune/pie20.png';
                }

                // Make the winning one yellow.
                theWheel.segments[winningSegmentNumber].fillStyle = 'https://orori-telin.akamaized.net/assets.orori.com/indonesia/img/promo/wheel-of-fortune/pie25.png';

                // Call draw function to render changes.
                theWheel.draw();

                $('.spinning_voucher').addClass('active');
            }

Ah yes, sorry for segment images you will need to do slightly different. You can change the image used for the segment in the function called after the animation like this...
function alertPrize()
{
    // Change the image of the indicated segment so we can better inform the user of winning.
    var winningSegmentNumber = theWheel.getIndicatedSegmentNumber();
    theWheel.segments[winningSegmentNumber].changeImage("win.png");
}

Hope this helps.

Nice dude! Its work. Thanks @zarocknz 👍


Text characters rendered as black squares on OSX/Chrome

Example PDF: acwr-issue.pdf
Configuration:

Web browser: Chrome 79.0.3945.88 (Official Build)(64-bit)
Operating system: MAC OSX 10.15.2
PDF.js version: 2.2.228
Is a browser extension: No

Steps to reproduce the problem:

Open the attached PDF on OSX/Chrome using PDFJS (e.g. using the PDFJS Demo)
Observe incorrect text rendering (works correctly on OSX/Safari and Windows/Chrome etc).

What is the expected behavior?

What went wrong?

Thanks!

Web browser: Chrome 79.0.3945.88 (Official Build)(64-bit)
Operating system: MAC OSX 10.15.2
Observe incorrect text rendering (works correctly on OSX/Safari and Windows/Chrome etc).

Given that this appears to be specific to a particular platform and browser, there's a fairly good chance that it's not actually a bug in the PDF.js library itself since in that case you'd probably expect it to (more) consistently broken.
If I were to guess: This might be a (more general) bug in the Font Loading API, when used with Canvas, specific to some configurations. Unfortunately, the best advice here may be to report the problem to the browser developers instead.


ComponentWillUnmount is called after DOM change

Description
When linking between different components, the DOM is updated, before the componentWillUnmount event is called. This prevents the execution of scripts, depending on the DOM Elements of the component.
I created an example, based on the Jsfiddle example in the readme.md. When you change from the Home tab to another one,  you should get an alert, with the result of the shown query. Inside the console, I log the trace of the call.

Further debugging roots to preact itself, as the source for this bug. I will create a new issue there.


Fix shared_future_continuation_order regression test

Fixes occasional failure of shared_future_continuation_order regression test.
If my understanding is correct, continuations are executed on newly spawned threads by default, which would not guarantee their order of execution. Launching with hpx::launch::sync should guarantee that no new thread is spawned, thus they are executed in sequence.
(@hkaiser We had fixed this in some PR in the past, but it seems it didn't make it into master)

bors merge


What is an application?

You say, "Our recommendation is to use a vault per application per environment"
But how does Microsoft define an application? I'm having discussions where, we have many API's for a single application, should every API have it's own vault or should every piece of the solution share a vault?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 199fbc30-6751-5ee6-4fbb-f23f2f5137cc
Version Independent ID: 00bcc33c-c14b-fa5f-74ab-f1bd635dc043
Content: Best Practices to use Key Vault - Azure Key Vault
Content Source: articles/key-vault/general/best-practices.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@nezoic
Thanks for your Question! We are currently investigating and will get back on this.

@nezoic, By using a vault per application per environment, is what we mean is a single application should have access to the Vault containing the secrets. The reason for this is, suppose we create a vault and we add secrets lets say some password or some secret text in it. Now app1/api1 and app2/api2 are added to the vault's data plan (user access policies) with get, list, set etc, now both these apps/apis would have access to those secrets/passwords stored in the vault. There is no resource level restriction that can be done on the resources that are stored in the vault like secrets. Hence we recommend to add these apps/apis to different vaults if they are fetching different resources from the key vault. Now at the end of the day it all depends how you plan the security of your application based on the criticality of the data stored in the KeyVault.
Hope this helps. Do let us know if any more queries around this.

Closing this thread for now.


tegrademo-mender: Use cboot by default on TX2

Since uboot slot alignment issues are tricky, unless you know what
you are doing you probably want cboot as your bootloader for TX2/mender
See discussion at https://github.com/OE4T/meta-mender-community/pull/8#issuecomment-745564642
Signed-off-by: Dan Walkes<EMAIL_ADDRESS>

I've been tardy about getting this one in, will also backport this to dunfell with the mender changes in https://github.com/OE4T/meta-mender-community/pull/11 and https://github.com/OE4T/meta-mender-community/pull/12 after they are upstreamed.


proxy is not used on auth()

Proxy is not used here, bug?
    def _auth(self):
        url = self._create_url('/auth')
        headers = {
            'User-Agent': '{}'.format(self._user_agent),
            'Content-Type': 'application/json'
        }
        auth_request = req.AuthRequest(login=self.login, security_key=self.security_key)

        data = self.serialize_request(auth_request)

        auth_response = requests.post(url, headers=headers, data=data)
        # pylint: disable=no-member
        if auth_response.status_code == requests.codes.ok:
            response = auth_response.json()
            self.access_token = response['access_token']
        else:
            response = auth_response.json()
            self.access_token = None

        return response

Hello! Thank you for your contribution to improving the library. These changes were released in version 2.27.0


Git workflow guide

Hi, yesterday I received a great answer to my stackoverflow question about git workflow with the aurelia skeleton-navigation repository. It has gotten so long that it is more of a tutorial than a plain answer and I am really stunned by Jeff's effort. I thought that answer might help other newbies as well, as this is quite an advanced setup for a common usecase. Maybe it could be pinned somehow - for example linked in the skeleton's readme.

Could you please post a link to that question?

Of course. I Also posted it to gitter with a markdown link and only copied the text from the chat :D

http://stackoverflow.com/questions/38097157/how-to-pull-in-changes-from-skeleton-sub-repository-into-production-super-reposi
;)

There are a couple of things to be aware of:

We don't recommend working of the master branch of the skeletons repo.
The skeletons can change and even break while we are re-configuring or updating them.
We hope to eventually get rid of the skeletons entirely some time in the future when the CLI can handle all "new project" scenarios.

No problem. Maybe this just not the right place. I appreciate your plans for the CLI. I also understand that you can't recommend using the skeleton repository as the basis of a real-world project. Though, this setup is very useful for experimental projects to keep track of the updates.
I just wanted to share this setup and give Jeff the he credits he deserves

Absolutely. That is an awesome answer.
(We've had a lot of people with issues that were working on skeleton master lately, so I just wanted to mention that it was a bit risky though.)


Soften the 32-character restriction on branch names

Hi, thank for the tool, this is definitely something I was waiting for without knowing it :)
What is the ask?
I stumbled upon a feature today that I wasn't expecting: in 1.7, there is this constraint that branch names cannot have exactly 32 characters: https://github.com/pachyderm/pachyderm/pull/2014.  Now I understand that this is for ensuring that a branch name is not mistaken for a UUIDv4, but maybe the 32-length restriction is a bit too harsh.
What is the goal / desired outcome? Maybe, so as not to have a breaking change, it would be best to check whether a branch name is valid through:
not (is 32 character long) || contains only<PHONE_NUMBER>abcdef
If there is a way to accomplish this today via workaround, what does that require? Some of my branch names are automatically generated, so I worked around this by prefixing all generated branch names that are 32 character long by, e.g., "_pachfix". This feels a bit like the mother of all hacks.
If you then happen to have branch names generated from UUIDv4 ids without dash, it doesn't feel as hacky to prefix them with, e.g., "prefix-" and is something you would probably do anyway.

Hi @hchauvin, I actually wasn't aware of this restriction either, but I guess I can see both sides. I think there is probably a good compromise that we could figure out here, but I will defer that discussion to @jdoliner or @msteffen. Thanks again for the input!

I think we can definitely soften this a bit. Your suggestion would help quite a bit, and I'm guessing would make your autogenerated branch names pass the test. In addition we can check that the 13th character is a 4 since that's part of the UUID spec. I suspect at that point it'd be quite hard to run afoul of the restriction.


Ensure cache can be cleared by CiviForm admin in deployed instance

Description
We have been adding caching capabilities for question, program and version data behind a feature flag. Once these flags are removed, we want to make it easy to clear the cache if needed.
We should create an endpoint or button for admins to clear the cache, without needing to redeploy. This endpoint should check that the user is an admin and if so, allow for the cache to be cleared.
We created a method to do this for the version cache in dev in the DevDatabaseSeedController as part of https://github.com/civiform/civiform/pull/5776.
Related to: https://github.com/civiform/civiform/issues/5844

This gets quite a bit trickier (infeasible?) in an environment with multiple server nodes running.
Another options could be to leave the feature flag in place and make it admin-writeable, which would allow the admin to turn off caching for all nodes via the admin settings system.

Good point on this not being possible in an environment with multiple server nodes.
In terms of this case, yes - it would only be for debug / unforeseen circumstances.
I'm happy to keep the flag around, but in that case we may want to refactor a bit to use dependency injection (something we discussed in the eng meeting yesterday).
Also, we can clear the cache by re-deploying, so maybe in these one-off (hopefully nonexistent) cases that is an okay approach?

There are two options for how we'll handle this:

Keep a "cache enabled" flag and refactor the code to use dependency injection with a cache implementation of the repository classes
Removing the flag and just having re-deploying as the way of clearing the cache in production

We will wait until we enable the cache by default and have it enabled for a while before deciding which approach to move forward with.

Checked with @gwendolyngoetz and there isn't a need for this. The prod cache will be re-initiated each time there is a deployment and we enable cache clearing on dev environments.


Fix: Type number trivially inferred from a number literal, remove typ…

Changes
Fix: Type number trivially inferred from a number literal, remove type annotation. (eslint: @typescript-eslint/no-inferrable-types)

We want to do this to arbitrarily show that TypeScript is supported.


4 commandline terminal games

Please consider adding the following 4 games that run in a commandline terminal;
two are retro arcade games, and two are puzzle collections:
https://github.com/fastrgv/TermFrogger
description: retro arcade game that runs in a terminal
keywords: frogger, arcade, retro
https://github.com/fastrgv/MiniPacman
description: retro arcade game that runs in a terminal
keywords:  pacman, arcade, retro
https://github.com/fastrgv/TerminalApps
description:  Fun puzzle games that run in a terminal window.
keywords: puzzle, retro
https://github.com/fastrgv/CoTerminalApps
description:  Fun puzzle games that run in a color terminal.
keywords: puzzle, retro
All 4 are in a stable state of development and are written in Ada.
All use ascii characters for display so are thusly non graphical.
Thank You
Rod<EMAIL_ADDRESS>

Thanks for the suggestions. I will look into them and add them in the following days.

The games have been added in 9f945432934c873a93c18abc69efe5a60bc723cd.


Add functions for polarity set/get

Tested on a Raspberry Pi 4B.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @posborne (or someone else) soon.
Please see the contribution instructions for more information.

bors r+


Error in tensorflor_model_server

Hi,
I have a custom Tensorflow Model running in SageMaker (with my own input_fn and output_fn to handle pickled input-output). After a couple of working request/response from outside, at some point a new request can't be served, with error (in log):
Error in 'tensorflow_model_server': double free or corruption (fasttop): 0x00007ff740179300 ***
After that error, any posterior request won't be served, saying:
#011status = StatusCode.UNAVAILABLE
#011debug_error_string = "
{
    "created"<EMAIL_ADDRESS>    "description": "Failed to create subchannel",
    "file": "src/core/ext/filters/client_channel/client_channel.cc",
    "file_line": 2261,
    "referenced_errors": [
        {
            "created"<EMAIL_ADDRESS>            "description": "Pick Cancelled",
            "file": "src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc",
            "file_line": 245,
            "referenced_errors": [
                {
                    "created"<EMAIL_ADDRESS>                    "description": "Connect Failed",
                    "file": "src/core/ext/filters/client_channel/subchannel.cc",
                    "file_line": 867,
                    "grpc_status": 14,
                    "referenced_errors": [
                        {
                            "created"<EMAIL_ADDRESS>                            "description": "OS Error",
                            "errno": 97,
                            "file": "src/core/lib/iomgr/socket_utils_common_posix.cc",
                            "file_line": 379,
                            "os_error": "Address family not supported by protocol",
                            "syscall": "socket",
                            "target_address": "[::1]:14000"
                        }
                    ]
                }
            ]
        }
    ]
}

After that, the only way to get the model predicting again is by removing the endpoint and deploying the model with a new one.
I've seen that a possible workaround is doing:
sudo apt-get install libtcmalloc-minimal4
export LD_PRELOAD="/usr/lib/libtcmalloc_minimal.so.4"

but, of course, that actions are not possible in SageMaker.
Hope you can help.

Haven't heard back for a few days. Closing. Feel free to reopen if the work around doesn't fix the problem.


Expand test coverage; no longer featurize in Docker; use symlinks so Disco workers can run Docker

It's green!  I left some minor feedback

In it goes!


scope -> dataflow and deal with Notificator API changes

Also bumped the Timely package version.
Compiles and seems to run the Livejournal dataset correctly.

Looks good to me! Thanks for the PR, and sorry for having left it a mess. <3


Request: add a MessageManager fixture for testing plugins that need it.

AudioProcessor implementations may have a dependency on juce::MessageManager. As far as I can tell, the message manager is instantiated by the plugin editor, which we don't create (or want to create) when running tests. As such, testing a plugin that needs a message manager for the processor, such as when juce::AudioParameterValueTreeState is used to manage parameters, results in an assert.
This issue can be trivially resolved by getting a pointer to the message manager via it's static accessor before APVTS needs it—that's not every nice.
It would be great to have an fixture that, when added to the processor (probably behind some kind of #if TEST macro), will ensure that this message manager is properly instantiated and de instantiated

I finally took a deeper look here.
I do various different things to get around this issue in tests:
use a loose ScopedJuceInitialiser_GUI
This is probably easiest and most agile.
If I just want to do something that requires the message thread running (for example test against the UndoManager or have changeListeners fire), I'll add this code in the test:
auto gui = juce::ScopedJuceInitialiser_GUI {};

Use a MockProcessor
When I need to interact with the apvts in tests, I use a very stripped down mock AudioProcessor called MockProcessor.h/cpp.
This constructs an apvts and has a member juce::ScopedJuceInitialiser_GUI gui; (to start up the UI when the processor starts).
This has some additional benefit of encouraging your own processor to be as basic as possible (vs. stuffed with tons of app-specific stuff).
The version I use also has boots up some app-specific logic, so not totally sure how useful it is to stuff it in pamplejuce.
Wrapper around the whole UI
I also have a little helper that wraps the whole stack, "integration test" style... this is pretty cumbersome but needed in some cases, for example benchmarking startup time or doing screenshots.
In this case, again, just having a ScopedJuceInitialiser_GUI running alongside is enough to make things happy.
void runWithinPluginEditor (const std::function<void (YourPluginAudioProcessor& plugin)>& testCode)
{
    YourPluginAudioProcessor plugin;
    auto gui = juce::ScopedJuceInitialiser_GUI {};
    auto editor = plugin.createEditorIfNeeded();

    testCode (plugin);

    plugin.editorBeingDeleted (editor);
    delete editor;
}

runWithinPluginEditor ([&] (YourPluginAudioProcessor& plugin) {
            // your code
            REQUIRE (...);
        });

Ah. I didn't Juce had something for this! Honestly, I think Pamplejuce should at least use this juce initialiser you are talking about. Otherwise, the template doesn't really work for a lot of real projects.

Otherwise, the template doesn't really work for a lot of real projects.

Not really sure what you mean by this. This use case isn't relevant for like 95% of my Catch2 tests, and I assume others as well. It's only if you are testing some quite intensive things with apvts or async callbacks (which Pamplejuce remains agnostic about) that it becomes relevant. And ultimately, the difficulty is because JUCE didn't design these things with testability in mind.
I'm not totally sure what example would be appropriate for Pamplejuce (whose goal is to get you up and running with CMake, Catch, CI), but feel free to submit a PR if you have a good example test!

https://github.com/sudara/pamplejuce/blob/83891071a1f502e223ebbb5e5373017ce614e227/Tests/PluginBasics.cpp#L11
Instantiating a plugin processor here causes an assert if that processor uses APVTS. So I'm thinking that, if what's being shown in the template is that you can instantiate your Audio Processor and test it, that it should work when what I think is a common way of managing parameters for an Audio Processor.
A perfect use of this template, then, will not build if the audio processor uses APVTS. I think that sends the wrong message when the user is already absorbing a lot of new information.
This, however, is a problem that will probably only really bother people migrating older projects to Cmake. Also, it's not reasonable to anticipate every case—many projects don't use it. I guess I just mean that a cool extension of the tools on offer here would be something that helps you instantiate an audio processor for tests as shown in the template if your audio processor uses APVTS.
I'm also biased because this is very tied to my experience of using the template.

So as far as a pragmatic solution to resolve the issue (given that Pamplejuce doesn't use the apvts) what would you recommend? What would have helped you? A commented out line like this in the tests?
// uncomment if using the apvts, as the message manager needs to be running
// auto gui = juce::ScopedJuceInitialiser_GUI {};


v3.0.3 seems to be a breaking change

I wasn't getting a re-render on one of my components after doing an npm update. I finally reverted everything and tracked it down to the move from redux 3.0.2 to 3.0.3. Given semantic versioning, I assume it wasn't expected that this would break anything, so what might be going on here? What should I be looking for?

Duplicate of https://github.com/rackt/redux/issues/935. You were mutating state in the reducers, and that your code worked before was a coincidence. We can't enforce purity in JavaScript, so our best shot is to warn on every doc page that reducers must be pure, and cannot modify the state or the action. Indeed, 3.0.3 could break the apps that relied on the broken behavior, but it was never the support behavior in the first place, and you'd notice it was broken if you subscribed to a more specific state slice. This is why I don't consider this to be a breaking change.

To clarify: the pattern you used was just as broken before 3.0.3.
It's not like 3.0.3 added some new restrictions that would qualify for a breaking change.
You would see it is a bug if you subscribed one level deeper than you did in the view.
Then it wouldn't update either—whether in 3.0.3, 3.0.2, or earlier.
The implementation details changed in 3.0.3, and it so happens that the bug in your app surfaced.
However the docs explicitly warn that mutating the state is an unsupported way of using Redux.

You were mutating state in the reducers, and that your code worked before was a coincidence.

Yep. Just discovered that and came back to report and close. Thanks for confirming that as the problem. Sorry for the duplicate and any frustration it caused.

Indeed, 3.0.3 could break the apps that relied on the broken behavior, but it was never the supported behavior in the first place, and you'd notice it was broken if you subscribed to a more specific state slice. This is why I don't consider this to be a breaking change.

No need to justify it. That's perfectly reasonable and I went into the issue assuming the problem was on my end. I even said to my team that this is probably a case where we were getting by on the side-effect of some problem that 3.0.3 fixed. I just wasn't up to speed on where to start looking. I understand that reducers should be pure in redux; the mutation was unintentional. Now to wade through some ImmutableJS code and figure out why.

If you know which part of the app stopped updating, take a look at the state slice it was subscribed to. This state slice is apparently managed by combineReducers() in your app. In 3.0.2, combineReducers() changed the state identity any time an action fires, regardless of whether anything inside actually changed. In 3.0.3, it keeps the old reference if all the reducers returned referentially equal state values. This means the mistake can be in two places:

Maybe the subscriptions code (e.g. connect() call from React Redux) is actually reading an unchanged slice of state, and now that combineReducers() is optimized, it no longer updates on every action. The fix is to subscribe to the part of the state that changes, and that the component renders.

Maybe one of the reducers under combineReducers() mutates the state argument in some cases instead of returning the new state. Then, if the components are subscribed to the combineReducers() result, they won't see be redrawn on changes.

It was the latter. We have a reducer we were combining with the one returned from combineReducers using reduceReducers that was managing cross-domain actions. Since we had access to the whole state object, we failed to use the ...state approach with overrides and had set the value of one of the domain properties directly.

Thanks for your advice.


docs: replace our helm-remote tutorial with a reference to the extension

Hello @jazzdan,
Please review the following commits I made in branch nicks/helmremote:
812910048a79d9838e5454251d2a6a2747bcff77 (2020-06-05 15:01:48 -0400)
docs: replace our helm-remote tutorial with a reference to the extension
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

ya, sometimes there's a hiccup. The way we communicate with netlify...isn't great (since we have 3 different sites in one repo)


api: Enables the binding of APIs in protected groups

Summary
This PR enables the binding of APIs whose groups are protected, as defined in kubernetes/enhancements#1111.
The proposed solution delegates to the user the responsibility of adding the api-approved.kubernetes.io annotation to the APIResourceSchema resource, as for standard CRDs, so it makes it explicit, and prevents from accidentally declaring APIs in a protected group. With this PR, the APIBinding controller will simply propagate the annotation to the projected CRDs.
In the API import case, where CRDs are generated following the creation of APIResourceImport resources, the NegociatedAPIResource controller already adds the approval annotation, assuming the API have already been explicitly declared as approved in the downstream workload cluster.
TODO:

[x] Propagate annotations (and labels) from the APIResourceSchema resources to the generated CRDs
[x] Add admission to reject APIResouceSchema resources in protected groups without the approval annotation
[x] Improve APIBinding condition message when the generated CRD is invalid
[x] Add e2e test

Related issue(s)
Fixes #1083

One comment. Otherwise, looks very good.

Compare https://github.com/kcp-dev/kcp/pull/1084/commits/47d0d378f6e02624655efa5a443d7d60cd4564c4. Aren't those changes missing?

Compare 47d0d37 in #1084. Aren't those changes missing?

Unless I'm mistaken, the changes from 1ed69206724e27a0bf21d059ef5611b5228b0d8c aren't strictly required for the protected API use case. My understanding is that the protected annotation is set at the end of the import execution path, when the NegociatedAPIResource is projected into the published CRD:
https://github.com/kcp-dev/kcp/blob/5dd2f2a6cd35fdcafc8f2e9282403997fe137f15/pkg/reconciler/apis/apiresource/negotiation.go#L702-L707
That being said, it would be required if we were to propagated the set of annotations arbitrarily, then the set would have to be transported along the resources chain (APIResourceImport, NegotiatedAPIResource, ...).

That being said, it would be required if we were to propagated the set of annotations arbitrarily, then the set would have to be transported along the resources chain

But it does not hurt either. Bonus: we don't get this fake pull request number 4, but the real one in case of CRDs on the pcluster side.

That being said, it would be required if we were to propagated the set of annotations arbitrarily, then the set would have to be transported along the resources chain

But it does not hurt either. Bonus: we don't get this fake pull request number 4, but the real one in case of CRDs on the pcluster side.

Agreed, that's a good point about that fake approval PR 👍🏼.


Add Anchor (Font-Awesome) icon on Headers hover

It would be great if hovering a title it shows a hiperlink to refer it's specific page section for users with Font-Awesome enabled at the config, as GitHub does for README files:

Sorry but I don't have a plan to add that feature since sidebar toc shows the same list.

I see. No problem. I know that there's a link for the TOC at the Sidebar, but I believe that adding them at the title would be a small and useful feature too.


Bumped development RELEASE for 1.22-17

Bumped development RELEASE for 1.22-17
closes #1211

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Repair TTL

Set TTL is not being honored, forcing implementors to use the localStorage library directly.
Related:

#23

Never mind.


Autocomplete: Fix Autocomplete opening on Reset

Description

In some cases on Blazor server, an Autocomplete would reopen when Reset from its parent MudForm. I believe this only occurs on Blazor server and is a consequence of AndForget in MudBaseInput.
Going forward, Autocomplete needs to be updated to support OnlyValidateIfDirty.
How Has This Been Tested?

All existing tests pass. I needed to adjust two unit tests to assert that Value is null, and Text is String.Empty, respectively, when Reset or Cleared.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

@henon Hold off on this for now, please...

Thanks!


Python: Incorrect package version

Describe the bug
This  NB is using version semantic-kernel==0.9.6b1, which doesn't exist. Could you please validate, if this version is correct in given notebook?

The package is now live.

Thanks for fixing this


[v0.13.x] - Allow an AntiAffinty tolerant to help ensure even spread of DNS pods

Changes

Adds a preferred scheduling anti-affinity to try and target nodes in different AZs if enabled.

Useful in situations where we have autoscaling enabled or are deploying DNS pods to nodes.

Codecov Report

Merging #1672 into v0.13.x will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           v0.13.x   #1672      +/-   ##
==========================================
- Coverage    25.41%   25.4%   -0.01%
==========================================
  Files           98      98
  Lines         5064    5065       +1
==========================================
  Hits          1287    1287
- Misses        3634    3635       +1
  Partials       143     143

Impacted Files
Coverage Δ

pkg/api/types.go
0% <ø> (ø)
:arrow_up:

pkg/api/cluster.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d440d...125101f. Read the comment docs.


Ports tutorials to use Sphinx-Gallery

Description of the Change:

Uses Sphinx-Gallery to automatically parse all valid Python scripts matching doc/tutorials/tutorial_*.py, and create ReST and Jupyter notebooks from them.

All tutorials are now Python scripts, and must take the following form:

A module docstring that contains a ReST-style page title and .. _label:

Executable Python code

To have a section be rendered in the documentation or the Jupyter notebook, you
can create a ReST comment by starting the comment with a line of 79 #s:
##############################################################################
# To begin our optimization, let's choose the following small initial values of
# :math:`\theta` and :math:`\phi`:

init_params = np.array([0.01, 0.01])
print(cost(init_params))

There is a new page doc/gallery.rst, that allows us to create the tutorial grid and choose the correct thumbnail, using the following Sphinx role:
.. customgalleryitem::
    :tooltip: Use quantum machine learning to rotate a qubit!
    :figure: tutorials/figures/bloch.png
    :description: :ref:`qubit_rotation`

Benefits:

A plain Python file can be used as an executable example script, or autogenerate the documentation/Jupyter notebook for download. This reduces code duplication.

Since it is plain text, it is easier to version and code review

By default, Python scripts are run, and the output is automatically added to the rendered document. This is a Good Thing™, as it means (a) the tutorials will always display the correct output, and (b) if something in the tutorials is broken, we will be warned when building the docs.

If a tutorial is too long to run when building the docs, or depends on some external dependencies/an environment we can't support on Read the Docs, name it tutorial_skip_*.py, and Sphinx Gallery will still parse it, but won't run it. To have output cells displayed, you can add the following ReST comment:
print('Optimized rotation angles: {}'.format(params))

##############################################################################
# .. rst-class:: sphx-glr-script-out
#
#  Out:
#
#  .. code-block:: none
#
#     Optimized rotation angles: [ 1.20671364  0.01      ]

Possible Drawbacks:

The default HTML elements produced by Sphinx Gallery are ugly --- we will need javascript to replace them with better looking elements. This will need to be done in a new PR.

To do:

Port the contents of the examples/ folder (e.g., ising.py, and the Jupyter notebooks) to this format, so that we can include them in the tutorial gallery and make them more visible to users :slightly_smiling_face:

Related GitHub Issues: n/a

Looks great. For the first time, I could build a doc without any hassles. Although, I had to install sphinx_gallery. Should this be added to the `requirements.txt´?
I ran make htmlto get the docs and it build beautifully in one go after installing sphinx_gallery

Looks great. For the first time, I could build a doc without any hassles.

That's great to hear :slightly_smiling_face:

I ran make htmlto get the docs and it builds smoothly in one go after installing sphinx_gallery

Thanks for pointing this out, I'll add it to the doc/requirements.txt file

Why are the advanced tutorials skipped? They take too long to run?

No, mostly because of dependencies --- they require the plugins to be installed, which involves pulling in strawberry fields, tensorflow, pyquil, the QVM, etc. Too much (I feel) to have to set up on read the docs, and maintain every time there are updates to these external packages.

I like the quick rendering compared to the jupyter files. Moreover, text formatting is easier; when jupyter notebooks are rendered as html, the text formatting changes.

There is a bit of an issue with Sphinx-Gallery's python -> Jupyter notebook conversion. Primarily, it doesn't support converting the following:

Raw HTML

Admonitions apart from note and warning (and even then, it doesn't like converting formatting inside the note)

Images and figures

The .. figure:: role doesn't work, only .. image:: works

Local images cannot be converted to markdown, only absolute URLs

Image options, such as :width: and :align: do not work, and render as-is below the image in the notebook cell

Sphinx roles such as :func:, :class: etc. do not convert, and render as :func:function_name in the notebook. Similarly, there is no link generated to the function in the documentation.

.. code-block:: doesn't work

I propose the following, and if there is general agreement, I will implement this:

There are only 2-3 tutorials where the above elements matter, and make for a much better looking documentation. These are the tutorials such as qubit rotation, Gaussian transformation, etc.

In these tutorials, the actual optimization problem is not the main focus, and just serves as a vehicle for introducing PennyLane concepts, terminology, and code patterns.
Admonitions are important here to separate out the content, and we want to be able to link directly to function/class documentation, and use .. code-block:: (to show code patterns that shouldn't be used)

We should use Sphinx gallery to render these, but manually fix up the generated notebooks to look better.

All additional tutorials will be focused on showcasing what can be done with PennyLane through interesting examples.

In these tutorials, the above elements (complicated admonitions, code blocks, sphinx domains) will not be needed, and should not be used. This will allow us to use the autogenerated Jupyter notebooks, and will be a much more scalable solution.

There are only 2-3 tutorials where the above elements matter, and make for a much better looking documentation. These are the tutorials such as qubit rotation, Gaussian transformation, etc.

Admonitions are important here to separate out the content, and we want to be able to link directly to function/class documentation, and use .. code-block:: (to show code patterns that shouldn't be used)

We might not even need to use .. code-block:: in these basic tutorials. We definitely need to refer to classes and functions.

We should use Sphinx gallery to render these, but manually fix up the generated notebooks to look better.

Should we somehow give access to the existing notebooks rather than fixing the generated ones ?

All additional tutorials will be focused on showcasing what can be done with PennyLane through interesting examples.

In these tutorials, the above elements (complicated admonitions, code blocks, sphinx domains) will not be needed, and should not be used. This will allow us to use the autogenerated Jupyter notebooks, and will be a much more scalable solution.

Agreed! Admonitions were not really required in the current example tutorials. I put in some to make them look fancier but they are not necessary. I do refer to PennyLane functions though at times.

If images are embedded in the comments, they should be linked to a versioned URL on the PennyLane github or on a CDN server such as imgur. For example, https://raw.githubusercontent.com/XanaduAI/pennylane/master/doc/tutorials/figures/bloch.png. This will allow them to be displayed in both the docs and the resulting Jupyter notebook without modification.

So all images will have to be linked via URLs?

Works for me, but how would the pipeline for manually fixing up the basic tutorial jupyter notebooks look?

Would we just turn off the jupyter notebooks that are auto-generated for these pages, create the notebooks separately, and add links explicitly?
What about when we update those basic tutorials? We'd have to update the jupyter notebooks as well?
How would we manually render the admonitions, codeblocks, etc that don't render automatically? Would we manually insert html into the notebooks?

Very good question. I like @AroosaIjaz's suggestion above that we maintain separate notebooks (the ones we already have) for these pages, and add links explicitly. In this case, we would have to update the Jupyter notebooks as well as the tutorials, which is what we do now currently.
My thinking is, it is the latter category (where the focus is on the circuit/algorithm/implementation) that would be growing, while the number of basic tutorials stays pretty much the same. This provides a more scalable solution for growing this category.

Just for clarity, we can make some pages autobuild jupyter notebooks but not others?

Very good question. I like @AroosaIjaz's suggestion above that we maintain separate notebooks (the ones we already have) for these pages, and add links explicitly.

I have 5 jupyter notebooks for the basic tutorials :

making circuits and QNodes
operations
state preparation
gradients
optimization

Only the 2nd and 3rd will need to be changed if the basic PennyLane functions are updated dramatically.

@josh146 any outstanding issues here, or can we merge into doc-refactor branch?

merging this back into feature branch now. Any further issues that come up can be sorted out as PRs against that branch


show diff on address page when tx spends back into the same wallet

i did this without running the code at all, but I hope it works

@akinwale can this be merged?


hcm: move ownership over all headres into HCM

Refactor the ownership model of FM so that it can be composed
more easily: by moving all ownership of headers to the HCM, nested
FM can pass ownership all the way up. This simplifies ownership
transfer complexities that arise when the FM attempts to own the
headers.
Risk Level: Medium
Testing: Existing tests
Docs Changes: n/a
Release Notes: n/a
Part of #10455

I think this definitely ended up being cleaner than any kind of ownership transfer, lmk what you all think

The windows failure might be related, but not sure how best to debug it without access to a Windows box. Thoughts on how to proceed?


MM-27497 Patch localForage to fix logging out on old Edge

When logging out, we call a method of localForage that in turn attempts to call a browser method that's not supported on pre-Chromium versions of Edge. There's a PR submitted to fix that (https://github.com/localForage/localForage/pull/971), but it's waiting to be merged and released, so I'm taking a page from the mobile app's handbook and using patch-package to temporarily apply the patch at install time since it's easier than maintaining a fork until the next version of localForage is released.
Ticket Link
https://mattermost.atlassian.net/browse/MM-27497

Lines 5373 to 5394 of the patch are the actual changes to fix the issue. The rest of the changes are because the library checks in their compiled files as well.
This link works, but you have to click to load the patch for it to scroll you to the right place.
https://github.com/mattermost/mattermost-webapp/pull/6308/files#diff-4499b04d71f37353f7e77b7b0cef7e29R5373-R5394

The new file was actually a problem. I copied files into node_modules wrong when preparing the patch. That should be fixed now, and the patch is much easier to read now.

Locally, I'm getting:
HTTP401: DENIED - The requested resource requires user authentication.
(Fetch)POST - http://mattermost.localdev:8065/api/v4/channels/members/me/view

Unhandled promise rejection TypeError: Invalid calling object  main.b3747573886923126066.js (239,43173)

[object Error]: {description: "Invalid calling object", message: "Invalid calling object", number: -2147418113, stack: "TypeError: Invalid calling object at Anonymous function (http://mattermost.localdev:8065/static/main.b3747573886923126066.js:199:48914) at T (http://mattermost.localdev:8065/static/main.b3747573886923126066.js:199:44009) at Anonymous function (http://mattermost.localdev:8065/static/main.b3747573886923126066.js:199:48814) at Anonymous function (http://mattermost.localdev:8065/static/main.b3747573886923126066.js:187:387048) at n (http://mattermost.localdev:8065/static/main.b3747573886923126066.js:239:42727)"}

Yeah, I'm seeing that as well. I'll take a look since clearly this fix isn't working as well as I'd hoped

I did some more testing locally, and for some reason the fix was still causing Edge to throw errors. I've instead gone with just downgrading localforage for the time being. Hopefully they'll have addressed the issue (or we'll have dropped old Edge :p) by the time we have to upgrade again.


NuGet packages have incorrect cross-reference versions

The NuGet packages that come out of build.cmd -pack incorrectly specify dependencies between versions to a static, incorrect version number 15.1.0-dev:

Fortunately, this has already been fixed with https://github.com/NuGet/NuGet.Client/pull/1915 so we just need to update the version of the SDK we're using.

(I'm looking at the update)