keep hitting torch.cuda.FloatTensor vs torch.FloatTensor in auto_tune

Working on running  AutoOpt but I keep getting floatTensor vs cuda.FloatTensor mismatch when computing of the gradients starts.
This seems to be that the model and data are on Cuda but the optimizer itself is not?  Not sure how to resolve.  Regular Adam, etc. works.
Here's the error:

RuntimeError                              Traceback (most recent call last)
 in
1 for epoch in range(1, epochs + 1):
----> 2     train(epoch, model, train_loader, optimizer)
3     test(model, test_loader)
 in train(epoch, model, train_loader, optimizer)
18
19         loss.backward()
---> 20         optimizer.step()
21
22         if batch_idx % 1000 == 0:
~/AutoOpt/auto_adam.py in step(self, closure, verbose)
132                 hessian = denom / sqrt_bias_correction2
133                 # print(torch.norm(hessian))
--> 134                 self.auto_tune(parameter=param, hessian=hessian, verbose=verbose)
135                 group['lr'] = 1 - param.gamma[0]
136                 adaptive_beta1 = param.gamma[1] / (1 - param.gamma[0])
~/AutoOpt/auto_optimizer.py in auto_tune(self, parameter, hessian, with_momentum, verbose)
158         :param verbose: Be verbose and print computed values.
159         """
--> 160         G = torch.stack((parameter.grad, parameter.grad - parameter.gradient_est))
161         if hessian is None:
162             B = G
RuntimeError: expected type torch.cuda.FloatTensor but got torch.FloatTensor
Thanks for  any assistance!
Less

Sorry, I figured out I had an erroneous model.cuda() call after making the optimizer.
Removing that, there is still a conflict but in reverse:

RuntimeError                              Traceback (most recent call last)
 in
1 for epoch in range(1, epochs + 1):
----> 2     train(epoch, model, train_loader, optimizer)
3     test(model, test_loader)
 in train(epoch, model, train_loader, optimizer)
18
19         loss.backward()
---> 20         optimizer.step()
21
22         if batch_idx % 1000 == 0:
~/AutoOpt/auto_adam.py in step(self, closure, verbose)
132                 hessian = denom / sqrt_bias_correction2
133                 # print(torch.norm(hessian))
--> 134                 self.auto_tune(parameter=param, hessian=hessian, verbose=verbose)
135                 group['lr'] = 1 - param.gamma[0]
136                 adaptive_beta1 = param.gamma[1] / (1 - param.gamma[0])
~/AutoOpt/auto_optimizer.py in auto_tune(self, parameter, hessian, with_momentum, verbose)
169         A[1][1] = torch.sum((B[1] * G[1])).item()
170
--> 171         self.compute_var(parameter=parameter, hessian=hessian)
172         if verbose:
173             print('N: ', self.N)
~/AutoOpt/auto_optimizer.py in compute_var(self, parameter, hessian)
143                                 (self.N * (self.N - 1))
144         else:
--> 145             parameter.var_est = torch.div(torch.pow(torch.add(parameter.grad_all, -parameter.grad), 2),
146                                           hessian).sum().item() / (self.N * (self.N - 1))
147
RuntimeError: expected type torch.FloatTensor but got torch.cuda.FloatTensor

Looking into it. Meanwhile, you can run the example on CPU instead of GPU.

Thanks a bunch Selçuk!
I will run it on CPU for now and thanks again for checking into this :)

Hi Selçuk,
Possibly related but I can't train with it on the CPU, either with Auto_Adam nor regular Adam.
It's just spinning it's wheels and is always at 10% or 9% (i.e. completely random).  Not sure if that is related to the params being stored elswhere but they don't seem to be being updated.

Test set: Average loss: 0.3721, Accuracy: 980/10000 (9%)
Train Epoch: 11 [0/60000 (0%)]	Loss: 8.757422
Train Epoch: 11 [9000/60000 (15%)]	Loss: 7.236280
Train Epoch: 11 [18000/60000 (30%)]	Loss: 7.866436
Train Epoch: 11 [27000/60000 (45%)]	Loss: 10.472101
Train Epoch: 11 [36000/60000 (60%)]	Loss: 14.052526
Train Epoch: 11 [45000/60000 (75%)]	Loss: 12.578988
Train Epoch: 11 [54000/60000 (90%)]	Loss: 12.001129
Test set: Average loss: 0.3295, Accuracy: 982/10000 (9%)
Train Epoch: 12 [0/60000 (0%)]	Loss: 9.479150
Train Epoch: 12 [9000/60000 (15%)]	Loss: 12.103229
Train Epoch: 12 [18000/60000 (30%)]	Loss: 5.913055
Train Epoch: 12 [27000/60000 (45%)]	Loss: 11.299622
Train Epoch: 12 [36000/60000 (60%)]	Loss: 14.419320
Train Epoch: 12 [45000/60000 (75%)]	Loss: 16.773289
Train Epoch: 12 [54000/60000 (90%)]	Loss: 15.650626
Test set: Average loss: 0.4353, Accuracy: 974/10000 (9%)

Hi @lessw2020, commit d31b3fe should fix the GPU bug that you saw. The Adam optimizer problem is not related with this issue. So, I'll close the this one and move your comments regarding Adam/AutoAdam to a new issue.

@lessw2020, please reopen if this doesn't work for you.

Hi @skopru - that fix works great.  GPU  training is now up and running :)
Thanks for the fast fix and look forward to the other fix.
Have a good weekend!


Modify the ocw-studio event rule for sns notifications

Adds an additional filter to the event rule for ocw-studio MediaConvert SNS notifications.
Should not be merged/applied until after https://github.com/mitodl/ocw-studio/pull/1018 and https://github.com/mitodl/salt-ops/pull/1501

:+1:


dts: arm: st: add npgios to all stm32 gpio controllers

For almost all STM32 GPIO controllers, the number of supported GPIO pins managed by a single controller is 16 (with some exceptions for fewer). However, the default for ngpios in the device tree bindings for gpio-controllers is 32; leading to inaccuracies in handling GPIO for these controllers, such as presenting too many GPIOs in the GPIO shell. This patch adds the ngpios property for all currently supported STM32 GPIO controllers.

Wouldn't it be better to override the default value of 32 and set it to 16 for STM32? (If it's possible to override a default?)
We would avoid repeating the same line in practically all gpio nodes.

I agree but it didn't seem like it was possible to override defaults in the devicetree bindings and the default comes from gpio-controller.

could this be grouped in one change on st,stm32-gpio.yaml, like the following:
include:
  - name: base.yaml
  - name: gpio-controller.yaml
    property-blocklist:
      - ngpios

properties:
  ngpios:
    type: int
    default: 16

That's an interesting way of doing it I didn't think of; but it does have the down side that fields (like the help text) are either lost for this binding or have to kept in sync with gpio-controller.yaml, right?
I do also wonder why then we wouldn't do this with all properties that are common then (like gpio-controller just defaulted true or #gpip-cells defaulted to 2 since those are duplicated for all gpio nodes too). I think it gets back to the discussion on that issue I linked where it didn't seem like it was desired to use the bindings as a replacement for actually setting values in the device tree but more just documenting things; and I'm not sure if Zephyr in general has changed it's mind on that since that thread is rather old.

I do also wonder why then we wouldn't do this with all properties that are common then (like gpio-controller just defaulted true or #gpip-cells defaulted to 2 since those are duplicated for all gpio nodes too).

Because ngpio is already provided with a default value in gpio-controller.yaml which doesn't match STM32 value. Fixing it the same method feels as the reasonable approach.

@erwango @FRASTM @gautierg-st
Ive changed the PR to align to the review discussion. Further reviewing the discussion in some of the places I linked; its does seems like this is more the Zephyr method to handling devicetree defaults (I would say that alot more properties can be defaulted as a result but those can be handled as they arise/need updating).
I would say however that while I dont really might be while bindings as a source of values for properties, I think its the fact that Zephyr's build doesnt seem to produce a final DTS with all the defaulted properties in place is rather unfortunate -- part of the idea using devicetree I felt was to let other external tools possible use it and with defaults used as they are here, that information is lost as no dts file ever actually has them. Or I am missing it, but I didnt see it in zephyr/zephyr.dts as I hoped I would...

Thanks @mrrosen. Sorry for not reviewing this earlier but I preferred to avoid tree wide changes before v3.7.0
I'm fine with updating ngpios for stm32, but then what about fixing the number in the stm32 compatible as done here for instance:
https://github.com/zephyrproject-rtos/zephyr/blob/e79ae3833e7fcf48a9799f1bc8359c3ca7facc3c/dts/bindings/gpio/nxp%2Cpcal6416a.yaml#L10-L13

The const solution doesnt really work for a few reasons from my quick tests:

Its typically paired with required and if so, it must appear in the tree. If the goal is to not define it tree but rely on the value from the bindings, this doesnt work
Just defining const without required does not include the value in the tree, nor should it from the description of that key: https://docs.zephyrproject.org/latest/build/dts/bindings-syntax.html#const. Unlike default, const is more of just a constraint than a definition.
While very rare, there are STM32 GPIO controllers that do not implement all 16 IOs, at least as far as their documentation describes; so its better if for those exceptions, the value can be changed to the correct one for which defining by const does not allow

And I cannot define a default without blocking the property as it leads to an error processing the bindings (I did try just to see and it does not work). I think what was done here is the best use of a binding-defined value which avoids needing to define it in most trees as thats what everyone here was looking for.


Rewrite rbx_xml to use quick_xml instead of xml-rs

rbx-xml is slow and has trouble processing unicode, among other issues. This can and is solved by simply swapping to a new XML parser. Given the speed, I've decided to go with quick-xml.
Unfortunately, the current parser (xml-rs) is intertwined rather thoroughly with rbx-xml's implementation and swapping it out for quick-xml would be impossible without refactoring large segments of it. Given there's a few other design choices that I wanted to change, I decided to bite the bullet and go for a full rewrite. Initial testing is good and suggests we're looking at 15x the parsing speed in some cases. I have tried to prioritize not copying data when possible, so overall memory should also be low.
Update: This is mostly done now, I believe. Many many tests need to be written but the bulk of the code will not change. With that in mind, here are my thoughts beyond "reviewing this is a nightmare":

This rewrite fundamentally changes how the crate is laid out. Specifically, it's split serializer and deserializer into dedicated modules and the code for (de)serializing data types now lives under those modules. This differs dramatically from the current system we use that implements XmlType for each type and both deserialization and serialization in one place. In my opinion, this is easier to reason with but it is significantly different and may require us to point contributors in the right direction if they're used to the old system. Also, it means we have the potential for element name mismatches between serializing and deserializing. Testing will absolutely catch that, but it's something we didn't have to deal with before.

The deserializer now requires the referent attribute to be set on Item elements. I was very surprised to learn it was not before, but as a result this is also a breaking change. I don't think we should care though.

For posterity, here's a checklist of what needs to be done:

[x] Visit properties using the ReflectionDatabase
[x] Port data types
[x] Redo the serializer
[x] Run every test like a million times to ensure I didn't break anything

Rather than work out what work I'm missing since I started this rewrite, I'm going to close this and instead focus on a less invasive rewrite. I think it will result in a much faster turn around for the port, and in turn it should end up being easier to review. Sad to see my work go, but it will not die here.


Communicate with Private API to access digital touch and handwritten message media

Would it be possible for the server to convert digital touch messages to a normal image format like gif or apng to be viewed on android? I suppose it's just a matter of figuring out how to read it on the server side (it may be an embedded image, but it's probably some custom proprietary thing knowing Apple).

this has been figured out with the private api. I'm changing this ticket to focus on the server side communication aspect

I would recommend creating a new endpoint like /message//digital-touch-attachment and /message//handwritten-attachment, with validation to make sure the provided message is actually a digital touch or handwritten. Then send the event to private API (balloon-bundle-media-path which needs chatGuid and messageGuid), which will return the path of the cached attachment.

@tneotia what's the format of the transaction response object? or is it just a string to the file path?

@tneotia also, are the output files GIFs? Or Movs?

@zlshames yes string to file path, and for digital touch it is mov, for handwritten a png

Done.


Leave Org field blank if user has "No affiliation"

If possible leave the Org field blank on the Create plan page if the user has no Org affiliation (screenshot below).
This is also an issue when I create a plan and arrive at the Project details page. In screenshot 2 below there is an entry for "No affiliation" guidance ticked by default. It's also unclear to me why I got this crazy list of pre-selected guidance options. None of them is related to the template or any other affiliation.
The "No affiliation" templates may or may not be an issue, but I thought it was strange as well. My understanding is that a template has to be attached to an Org (screenshot 3)
1-

2 - No affiliation guidance

3 - No affiliation templates

"No affiliation" no longer appears in the create plan wizard or as a guidance selection. I still see "No affiliation" templates as a Super Admin but that shouldn't matter too much. Closing issue.


⚠ Samsung has degraded performance

In 87821b9, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2611 ms

Resolved: Samsung performance has improved in 98131f6.


Stripping of unicode/Emoji possible?

Some calendars that I share with friends/family tend to use Emoji characters (see http://www.unicode.org/charts/PDF/U1F300.pdf). These are correctly displayed (albeit with a light background on an otherwise dark terminal for non-standard emojis) but overlapping with the next character, rendering the beginning of calendar entries illegible (see http://cl.ly/1T0j2Z2v2i0t3J203E3Y)
Is it somehow possible to strip these characters from the text that gcalcli displays?

We now use the native encoding of the environment to output.  If the issue was actually due to glyph rendering with particular fonts, that's out of scope for us, I think---the user should change fonts to one that supports the characters that they use.


[Demo FE] AAUser, I can see the demo page on the navbar

Description:
Due to the original ticket #166 being dependent on another ticket, it was decided that the adding it to the navbar would be separate to speed up the flow
Validation steps:
Screenshot of a link to the demo page on the navbar
Tech steps:
Add the nav item for the demo page in the NavItems.tsx component


Add sentinel error for no servers left in the backend pool

Adds a sentinel error type so that https://github.com/vulcand/vulcand/pull/380/files#diff-92e6a9836e9c57cb6dae8e572bb8b457417775a6d1519b44ad55d86510399f7dR35 doesn't have to do a string comparison

Hello,
currently, vulcand uses oxy v1:
https://github.com/vulcand/vulcand/blob/7f3fa2ae998b3620b8f2d8cbd3410ee5f536a056/go.mod#L20
I recommend updating to oxy v2 before updating the PR.

👀 thanks for the note @ldez ! I'll bring that back to the team 🙏


FormInput value optional

Please make value property optional in the FormInput component to support the progressive enhancement apps like remix

linked PR: https://github.com/Capgemini/dcx-react-library/pull/290


fixed input screen bug and color bug

When doing computations such as 2.2 * 0.2 part of the answer would appear off the screen. Bug now fixed.  Also on light mode equals button was not visible as it was set to white. Changed the .yaml file to fix this bug.

Hello,
Thank you for your contribution, but the calculation of 2.2*0.2 seems it is not a bug, and you can horizontally scroll the input field to see the full result.
Also for the color correction, the equal button text color with the light mode it looks visible.
Therefore, I will close this PR.
Best rergards.

Hello,
I am running the app on a mac and I am not able to scroll the input field and the equal sign is not visible. Attached is a screenshot of what it looks like.


New version: TorProject.TorBrowser version 11.0.4

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

Installer https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-11.0.4_en-US.exe
Result: Download Failed

all downloads in the manifest work for me, can the automatic check be restarted?

The error is most likely caused by the Azure Pipeline getting blocked by visiting the website too much, one download will timeout every time

As you can see ¯\_(ツ)_/¯
-----------------------------------------------------
Installer https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-win64-11.0.4_en-US.exe
Result: Download Failed
-----------------------------------------------------
Installer https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-11.0.4_de.exe
Result: Download Failed
-----------------------------------------------------
1/20/2022 7:49:51 PM
Status: Completed
##[error] Installer https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-win64-11.0.4_en-US.exe
##[error] Result: Failed
##vso[task.logissue type=error] Error occurred while downloading installer from https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-win64-11.0.4_en-US.exe. 0x80072EE2.
Error information:
Http Response: OK
Http Reason Phrase: OK

1/20/2022 7:49:51 PM
Status: Completed
##[error] Installer https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-11.0.4_de.exe
##[error] Result: Failed
##vso[task.logissue type=error] Error occurred while downloading installer from https://dist.torproject.org/torbrowser/11.0.4/torbrowser-install-11.0.4_de.exe. 0x80072EE2.
Error information:
Http Response: OK
Http Reason Phrase: OK

hmmm, I can't imagine this is the only software affected, what would have to be changed to fix this, maybe update the pipeline to not download everything at the same time but stagger it a little? If the pipeline takes a few minutes longer for manifests with many links that would not be a big problem right?

Created a discussion here: https://github.com/microsoft/winget-pkgs/discussions/41662 maybe you have other ideas how to solve this :)

Created a discussion here: #41662 maybe you have other ideas how to solve this :)

Already saw it and upvoted it :)
Waiting for MS to reply since the bots are closed source, calibre might have a similar issue, however over multiple manifests

/azp run


Add git tags for the repo

Hi @icodeforlove,
Would you mind to add the git tags for the repo? :smiley:
After using the tags for the repo, it will be helpful for user to know the version and status of repository.
Furthermore, when Console.js release new versions, cdnjs could auto-update by the tags.
Thank you! :pray:

✨ @icodeforlove ✨
I'd like to add<EMAIL_ADDRESS>for the lib.
Which shown below are few latest log messages, and which one you think is better to be milestone.
(aa9bcc8 or f99584b ?)
aa9bcc8 Merge pull request #5 from acidghost/issue-4
3996c03 linted & built
085cc98 Function.prototype.bind not supported by iOS 5
f9c461c Merge pull request #3 from acidghost/pretty-print-objects
f99584b Release v0.0.2
5a0471e commit bumped version

aa9bcc8 is fine :)


Inject with non-scalar value?

I'm playing around with tomrf/htmx-message and to get a Request object, you need to do the following:
<?php
use Nyholm\Psr7\Factory\Psr17Factory;
use Nyholm\Psr7Server\ServerRequestCreator;
use Tomrf\HtmxMessage\HtmxServerRequest;

$psr17Factory = new Psr17Factory();
$creator = new ServerRequestCreator(
    $psr17Factory, // ServerRequestFactory
    $psr17Factory, // UriFactory
    $psr17Factory, // UploadedFileFactory
    $psr17Factory  // StreamFactory
);

// Wrap the request with HTMX proxy.
$request = new HtmxServerRequest($creator->fromGlobals());

How could I override the parameter with a function call? (Or any other to build this dependency)

Just in case anyone wants to see the ContainerConfig:
<?php
declare(strict_types=1);

namespace App\Container;

use Nyholm\Psr7\Factory\Psr17Factory;
use Nyholm\Psr7\Response;
use Nyholm\Psr7Server\ServerRequestCreator;
use Nyholm\Psr7Server\ServerRequestCreatorInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestFactoryInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\StreamFactoryInterface;
use Psr\Http\Message\UploadedFileFactoryInterface;
use Psr\Http\Message\UriFactoryInterface;
use Tomrf\HtmxMessage\HtmxResponse;
use Tomrf\HtmxMessage\HtmxServerRequest;
use WoohooLabs\Zen\Config\AbstractContainerConfig;
use WoohooLabs\Zen\Config\EntryPoint\EntryPointInterface;
use WoohooLabs\Zen\Config\EntryPoint\Psr4NamespaceEntryPoint;
use WoohooLabs\Zen\Config\Hint\DefinitionHint;
use WoohooLabs\Zen\Config\Hint\DefinitionHintInterface;
use WoohooLabs\Zen\Config\Hint\WildcardHintInterface;
use WoohooLabs\Zen\Exception\ContainerException;

class ContainerConfig extends AbstractContainerConfig
{
    /**
     * {@link https://github.com/woohoolabs/zen#entry-points}
     * Entry Points are such classes that are to be directly retrieved from the DI Container.
     * Controllers and Middleware usually fall in this category.
     * This means that you can only fetch Entry Points from the Container
     * with the $container->get() method and nothing else.
     *
     * @return array | string[] | EntryPointInterface[]
     */
    protected function getEntryPoints(): array
    {
        return [
            new Psr4NamespaceEntryPoint('App\\Controller')
        ];
    }

    /**
     * {@link https://github.com/woohoolabs/zen#hints}
     * Hints tell the compiler how to properly resolve a dependency.
     * This can be necessary when you depend on an interface or an abstract class
     * because they are obviously not instantiatable.
     * With hints, you are able to bind implementations to your interfaces or concretions to your abstract classes.
     *
     * @return array | string[] | DefinitionHintInterface[]
     * @throws ContainerException
     */
    protected function getDefinitionHints(): array
    {
        return [
            // ContainerInterface::class => Container::class,
            ServerRequestFactoryInterface::class => Psr17Factory::class,
            UriFactoryInterface::class => Psr17Factory::class,
            UploadedFileFactoryInterface::class => Psr17Factory::class,
            StreamFactoryInterface::class => Psr17Factory::class,
            ServerRequestCreatorInterface::class => ServerRequestCreator::class,
            ServerRequestInterface::class => '',
            // Bind the Request class to the RequestInterface (Prototype scope)
            RequestInterface::class => DefinitionHint::prototype(HtmxServerRequest::class),
            // Bind the Response class to the ResponseInterface (Singleton scope)
            ResponseInterface::class => DefinitionHint::singleton(HtmxResponse::class)
                                                      ->setParameter('message', Response::class),
        ];
    }

    /**
     * {@link https://github.com/woohoolabs/zen#hints}
     * Wildcard Hints can be used when you want to bind your classes in masses.
     * Basically, they recursively search for all your classes in a directory specified by the first parameter,
     * and bind those classes together which can be matched by the provided patterns.
     *
     * @return array | WildcardHintInterface[]
     */
    protected function getWildcardHints(): array
    {
        return [
            // new Psr4WildcardHint(
            //    'WoohooLabs\Zen\Examples\Domain\*RepositoryInterface',
            //    'WoohooLabs\Zen\Examples\Infrastructure\Mysql*Repository'
            // ),
        ];
    }
}

Hi @ellisgl ,
Passing non-scalar arguments to the container is not supported due to technical limitations when building the container: this process basically means that container definitions are serialized, and non-scalar values cannot be serialized without extra magic..
For the next major release of Zen, we could use https://github.com/opis/closure or something similar for the use-case, but I couldn't find the time to work on this feature yet.


Add -j8 make option to speed up build time

Description:
Adding -j8 reduces build time on the external dependencies by approximately 25%.
Discussed in https://github.com/home-assistant/home-assistant/pull/15897
Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

Hello @vrih,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:

6a7ace58d5a5ca17dba17c0177810de513f266c3 - This commit has something that looks like an email address (dan@danbowtell.co.uk). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

If you only made a single commit you should be able to rungit commit --amend --author="Author Name<EMAIL_ADDRESS>
(substituting Author Name and<EMAIL_ADDRESS>for your actual information) to set the authorship information.
If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:

You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.

Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! :heart:

This defines the number of threads to use. Making it faster on your machine because I assume that you have a lot of cores. However, we don't know the machines used by Docker hub. If you set threads used too high, it will actually make things slower.

https://unix.stackexchange.com/a/208569

Not sure if nproc is available in the container.
The amount of threads could also be detected like this:
NPROC=$(grep -c ^processor /proc/cpuinfo 2>/dev/null || 1)


Commit models to LFS

Commits some models to LFS which were accidentally committed as source code.

/merge

/merge


Misaligned number centering in Badge on Firefox

Description
The number in the Badge component appears slightly off-center when viewed in Firefox. This issue seems to be browser-specific, as the alignment looks correct in Edge.

Steps to Reproduce
Open the Badge component in Firefox.
Compare the centering of the number with how it appears in Edge.
Expected Behavior
The number should be perfectly centered in the Badge component across all supported browsers.
Actual Behavior
The number in the Badge component is misaligned in Firefox.
Suggested Solution
Investigate and adjust CSS properties to ensure consistent alignment across browsers.

Tested with version 1.0.0-next.41 and Badge number centering seemed to look fine.


Update viewer.js

Fixing error on authentication flow

Thanks for the contribution!
Can you explain what problem this is solving and why this fixes it? I've tried reproducing the issue in https://github.com/GoogleCloudPlatform/dicomweb-wsi-viewer/issues/6 but haven't been able to.

Thanks for the contribution!
Can you explain what problem this is solving and why this fixes it? I've tried reproducing the issue in #6 but haven't been able to.

In my case, I deployed your repo directly on google cloud shell (not my local machine). Once there, I followed all the required steps, and the deployment didn't work at all (directly on google cloud, I launched the app by using the integrated web preview).

Ok thank you for the explanation! Looks like the latest samples also use "client:", so this looks good to me.


Use signed_root For Block ID Purposes in Blocks/State - (Spec PR #816)

Description
As an implementor, I want to use the signed_root function instead of hash_tree_root when calculating block root, so that block signatures are the same when producing and processing a block.
Acceptance Criteria

get_temporary_block_header returns a block header with signature := EMPTY_SIGNATURE.
cache_state uses signed_root instead of hash_tree_root of latest block header when storing the latest block roots.
process_block_header uses signed_root instead of hash_tree_root of latest block header when verifying the previous block root.
build_empty_block_for_next_slot uses signed_root instead of hash_tree_root of previous block header when storing the previous block root.

Additional Information
See https://github.com/ethereum/eth2.0-specs/pull/816

Working on this.

Hey @vitorpy, it looks like this task is dependent on https://github.com/ethereum/eth2.0-specs/pull/711/, which is a task we chose not to track in Artemis. It's quite possible writing this one up was missed, because it's sandwiched between "contains no substantive changes" labels. Give me a few mins to chat with the team, and we'll get back to ya.

build_empty_block_for_next_slot is a function created in a test class which won't be implemented.


crooped image at top-left edge only

Expected Behavior
Get an image that corresponds whit  the viewport's size and position
Actual Behavior
The image returned always is cropped starting at the top-left edge whit viewport's width and height
when I use the following code.
var MyCroppie = $("#my-image");
$("#myCropImage").dialog("open");
if(!$("#my-image").data("croppie"))
{
MyCroppie.croppie(
{
viewport: {width: 150, height: 150},
boundary: {width: 300, height: 300}
}
);
}
MyCroppie.croppie("bind",
{
url: _URL.createObjectURL(file)
}
);
$('save_image').on('click', function (ev) {
MyCroppie.croppie('result', {
type: 'rawcanvas',
size: 'viewport',
format: 'png'
}).then(function (canvas) {
var dataimage= canvas.toDataURL();
.....
});

I'm experiencing the same issue. Is there a fix or work-around available?

@MarioCambas / @bascoder ,  there's a good chance that the fix for #591 will resolve this issue for you. Can you try this version of Croppie (from PR #592)?
https://raw.githack.com/zdennis/Croppie/63c34e165c53da1624784b611680eafdeec57c60/croppie.js


Credits

The names of credits displayed with animations that shows this names from the bottom of the screen to the top.
Closes related issue:  #78
:ballot_box_with_check: Definition of Done checklist

[ ] Meaningful title and valuable description in pull request
[ ] Code change tested manually if not covered by automated tests
[x] Pull request linked to one or more issues/stories
[x] Acceptance criteria of the linked stories satisfied
[x] Code change comprehended by those who approved it
[x] State of target branch maintained or improved after the code change
[ ] Go to MainActivityTest in the Android App and uncommit @Test  Run test manually. Add a picture of the test result in the comments.  Comment @Test again to avoid future problems with the CI

You should also add the issue here:

as the TA show us in the meeting.
click on developers and find the issue you need

i) Add an escape hash or go back to the main activity after the end of the animation. ii) Add an logo so that the screen doesn't look empty. iii) Fix the landscape mode of the activity. -->The last name is cut .

I think that the another option can be to that at the end of the animation it can go back to mainActivity like I wrote before.
Good catch with the landscape mode I forgot to test that !

i) Add an escape hash or go back to the main activity after the end of the animation. ii) Add an logo so that the screen doesn't look empty. iii) Fix the landscape mode of the activity. -->The last name is cut .

I think that the another option can be to that at the end of the animation it can go back to mainActivity like I wrote before. Good catch with the landscape mode I forgot to test that !

i have fix it

i) Add an escape hash or go back to the main activity after the end of the animation. ii) Add an logo so that the screen doesn't look too empty. iii) Fix the landscape mode of the activity. -->The last name is cut .

i have fix it

The layout has now an escape hash which goes to the main activity, I also pushed a commit fixing the mainactivity layout constraint. Now the UI looks good in both Nexus 6 and bigger devices.


.net 8 version

Hello,
When do you release .net 8 version or do we have to compile it ourselves? .net 8 released so it would be much appreciated.

I tried it myself with dev branch but maui can't find .UseMaterialComponents, so can't run it for some reason

please follow the sample with this release... it works...

Hi.. its the develop repository download ... create a new project and reference the Material.Components.Maui project/dll...
follow the MainPage.xaml as in the sample.. it does build and run in .net8...
Regards

If it helps, I had the same issue as it didn't find the Material.Components.Maui.Extensions namespace. However, quitting VS 17.8 and restarting it did find the namespace.

The dev branch has some breaking changes and their documentation is still waiting to be written.

Thank you @yiszza, waiting for the documentation update and new controls... Thank you for your time and efforts...
Regards

Hi...
The new samples project doesnt load for some reason...
Regards

Hi...
The new samples project doesnt load for some reason...
Regards

What new samples dude?

The new docs and sample project have been prepared.

@yiszza ... Thank you for the great efforts...
Regards and Wishes

@yiszza ... Thank you for the great efforts...
Regards and Wishes

Why the dots man.......?


object duplication

Describe the bug, issue or concern
When following the LoggingGalore example, it turns out that somewhere along the line the TLog "child" objects are duplicated.
I'm not clear as to why, but after adding a Serial.println("write() called on SyslogStream(%p)\n", this) it became quite clear that there ends up being multiple SyslogStream instances (the pointer values for %p differs).
The motivation was because some aspects I only wanted to log to syslog, not to Serial too, and I wanted to be able to switch on/off independent sub-loggers by invoking their begin() and stop() methods independently as configuration settings are updated, and/or network becomes available etc ...
Relevant code example:
#define SYSLOG_SERVER "your.servername.here"
#define SYSLOG_PORT 514

#define WIFI_SSID "your_ssid_here"
#define WIFI_PSK "and your PSK"

#include <WiFi.h>
#include <TLog.h>
#include <SyslogStream.h>

SyslogStream syslogger;

void setup()
{
    Serial.begin(115200);

    syslogger.setDestination(SYSLOG_SERVER);
    syslogger.setPort(SYSLOG_PORT);
    syslogger.setRaw(true);
    syslogger.setIdentifier(HOSTNAME);

    const std::shared_ptr<LOGBase> syslogStreamPtr = std::make_shared<SyslogStream>(syslogger);
    Log.addPrintStream(syslogStreamPtr);

    WiFi.mode(WIFI_STA);
    WiFi.disconnect();
    WiFi.setHostname(HOSTNAME);
    delay(100);
    WiFi.begin(WIFI_SSID, WIFI_PSK);
 }

static unsigned long last = 0
loop()
{
    if (WiFi.status() == WL_CONNECTED) {
        syslogger.begin(); // doesn't work - but if syslogger.println("this will");
        Log.begin(); // works
    } else {
        syslogger.stop(); // doesn't work.
        Log.stop(); // works
    }
    Log.loop();

    if (millis() - last >= 5000) {
        last = millis();
        Log.println("This line will repeat every 5 seconds");
    }
}

Ok - never really considered this use case.
So Log() is essentially a trampoline; so all it does is keep a list of the 'real loggers' and then for every method (e.g. print, stop, begin, etc) do a 'for( i over all loggers) i.method()' sort of thing.
So what should work is is to bypass it - and directly call its methods:
   SyslogStream syslogger;

   void setup()
   {
       Serial.begin(115200);

       syslogger.setDestination(SYSLOG_SERVER);
       ...
       WiFi.mode(WIFI_STA);
   ...
   }

loop()
{
    if (WiFi.status() == WL_CONNECTED) {
        syslogger.begin();
    } else {
        syslogger.stop();
    }
    syslogger.loop(); // <----- the important one !

    if (millis() - last >= 5000) {
        last = millis();
        syslogger.println("This line will repeat every 5 seconds");
    }
    }

Or if you ALSO add it to the main Log
const std::shared_ptr<LOGBase> syslogStreamPtr = std::make_shared<SyslogStream>(syslogger);
Log.addPrintStream(syslogStreamPtr);

then below should work:
loop()
{
    if (WiFi.status() == WL_CONNECTED) {
        Log.begin();
    } else {
        Log.stop();
    }
    Log.loop(); // <----- the important one !

    if (millis() - last >= 5000) {
        last = millis();
        syslogger.println("This line will repeat every 5 seconds only on syslog");
            Log.println("and this on boith");
    }
    }

Does that work for you ? If so - and I'll make an example of this type of use.

The problem is (I suspect) that this code:
    const std::shared_ptr<LOGBase> syslogStreamPtr = std::make_shared<SyslogStream>(syslogger);
    Log.addPrintStream(syslogStreamPtr);

Creates a copy of the syslogger object to which the pointer ends up pointing, so it ends up not referencing the original object.  Which makes sense since the idea (as I've got it) behind shared_ptr is that it's a reference-counted pointer such that when the ref-count reaches zero it issues a delete on the pointed-to object, which you can't do with the original object since it's a statically allocated object here.
So without testing, not I don't think your change suggested use-change would work, because the cloned object would have it's begin() called via the trampoline, but the original object would not.  One would have to do:
Log.begin();
syslogger.begin();

And:
Log.stop();
syslogger.stop():

Respectively to have that work.
I'm wondering whether the best idea wouldn't be to just outright create the shared_ptr at the global scope, something like:
static std::shared_ptr syslogStreamPtr;
And then in setup() do something like:
syslogStreamPtr = new SystemLogger();
before proceeding to the rest of the steps, obviously now using syslogStreamPtr->methods() as appropriate ... and with the understanding that I've not yet tested any of this.
Another idea would be to store raw pointers into Log ... but for obvious reasons that eliminates the benefits of having the shared_ptr to begin with.

Or perhaps something like:
std::shared_ptr< LOGBase> syslogStreamPtr (syslogger);
to avoid the implied 'new' in make shared ?

Or perhaps something like: std::shared_ptr< LOGBase> syslogStreamPtr (syslogger); to avoid the implied 'new' in make shared ?

Will try this one.  Not familiar enough with shared_ptr to answer that one off the top of my head.


Add two phase commit asset transfer sample

I'm thinking about using Fabric in a sample scenario which involves a coordinated unit of work. It seems likely that there would be other use cases, such as CBDC, that would require two phase commit support, and an asset transfer sample demonstrating how that would be possible with the latest version of Hyperledger Fabric would be really useful.

Closing as as not planned since there has been no community interest in developing this sample.


spec: draft for time-based mempool pruning

Closes #1639

Merging as approved and the development PR has been merged too:

https://github.com/vegaprotocol/vega/pull/8028


Nest arrays support

My Model:
export interface Model {
  foo: {
    bar: string,
    baz: string[],
  }[],
}

The form group type I want:
interface ... {
  foo: FormArray<{ bar: FormControl<string>, baz: FormArray<string> }>
}

This this possible with ngx-mf?

I think, yes, but it looks like a bug, because it don't work, i will fix it today, thank you for issue report.

Sure, you can, annotation should be { foo: [{ baz: 'array' }] } full example you can find here https://stackblitz.com/edit/angular-ngx-mf-gqrrau?file=src/app/app.component.ts

But i found 1 small bug, in line https://stackblitz.com/edit/angular-ngx-mf-gqrrau?file=src%2Fapp%2Fapp.component.ts%3AL34,src%2Fapp%2Fmodel.ts type should be nullable, but in that example it nonNullable

I fix it today

Awesome thank you, this is what I was looking for 👍


Release IPAM blocks if they have been empty for a certain time

Description

Remove the check for total free addresses on a node, and instead just
rely on the time-based heuristic for whether an IPAM block is OK to
delete.
By default, blocks will now be deleted if they are consistently empty
for 15m or more (the default leak grace period). But this can be
configured using KubeControllersConfiguration.
The previous check was meant to ensure we didn't allocate and delete
blocks rapidly, but the time-based grace period should do that just as
well.
Related issues/PRs

Fixes https://github.com/projectcalico/calico/issues/7987
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

Improve IPAM block garbage collection behavior for IP pools with small blocks.

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@fasaxc good catch - just pushed a commit that adds a markInUse call to the block update logic if it spots that there are allocations.

Would be good to have a test for the case that you fixed but don't want to block this going in today


Any plans to push this upstream?

Are there any plans to get these mappings included in upstream SDL_gamecontrollerdb.h?
While I appreciate collecting this information in a perhaps more accessible location than the SDL hg repo, I feel that a lot more people would benefit if these defaults were shipped with SDL. Have you already contacted the SDL developers about this?

Right.. so why can't SDL just include this file as part of it's distribution? On Linux this could just end up in /usr/share or something. For windows this is generally more tricky (as no common location exists), but one could probably just attempt to load the file from the cwd or some ENV path?
It feels kind of dumb to include the database with every game / application.

As stated before, these mappings should be verified.


[Bug]: Yaml in frontmatter parsing keep failing

Version
System:
    OS: macOS 14.2.1
    CPU: (12) arm64 Apple M2 Pro
    Memory: 90.42 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 126.0.6478.127
    Edge: 126.0.2592.81
    Safari: 17.2.1
  npmPackages:
    @rspress/mdx-rs: ^0.5.7 => 0.5.7
    @rspress/plugin-shiki: ^1.23.1 => 1.23.1
    rspress: ^1.18.1 => 1.18.1

Details
after I added metadata tag in frontmatter (tried several formats, spacing) and it keeps failing:
error below
npm run dev

<EMAIL_ADDRESS>dev
> rspress dev

🔥 Rspress v1.18.1

thread 'thread '<unnamed><unnamed>' panicked at ' panicked at crates/plugin_frontmatter/src/lib.rscrates/plugin_frontmatter/src/lib.rs::1414::3636:
:
Failed to parse yaml: title: DE20020 - Failed to get application hash list.
description: Error - DE20020 - Workaround and debug for error: Failed to get application hash list.
head:
  - - meta
    - name: og:title
      content: Error - DE20020 - Failed to get application hash list.
  - - meta
    - name: og:url
      content: https://docs.com/guide/error/de20020。: Error { kind: SCANNER, problem: "mapping values are not allowed in this context", problem_mark: Mark { line: 2, column: 69 } }Failed to parse yaml: title: DE20019 - Snapshot upload gave no results
description: Error - DE20019 - Workaround and debug for error: snapshot upload gave no results
head:
  - - meta
    - name: og:title
      content: Error - DE20019 - Snapshot upload gave no results
  - - meta
    - name: og:url
      content: https://docs.com/guide/error/de20019。: Error { kind: SCANNER, problem: "mapping values are not allowed in this context", problem_mark: Mark { line: 2, column: 69 } }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

fatal runtime error: failed to initiate panic, error 5
fatal runtime error: failed to initiate panic, error 5
zsh: abort      npm run dev

My frontmatter in each file looks like:
---
title: BU10013 - package.json must have a name and version
description: Error - BU10013 - Why does package.json needs to have a name and version? What happens when we don't have one?
head:
  - - meta
    - name: og:title
      content: Error - BU10013 - package.json must have a name and version
  - - meta
    - name: og:url
      content: https://docs.com/guide/error/bu10013
---

I have also tried this (check the spacing betwee - -
---
title: BU10013 - package.json must have a name and version
description: Error - BU10013 - Why does package.json needs to have a name and version? What happens when we don't have one?
head:
- - meta
   - name: og:title
      content: Error - BU10013 - package.json must have a name and version
- - meta
   - name: og:url
      content: https://docs.com/guide/error/bu10013
---

Not entirely sure what did I do wrong as i was following this guide here:
https://rspress.dev/api/config/config-frontmatter#head
Reproduce link
https://github.com/ZephyrCloudIO/zephyr-documentation/tree/get-started
Reproduce Steps
clone the repo and run npm i && npm run dev

I think there is an error in the writing of yaml, and the yaml parse of mdx-rs conforms to the specification.

You can try this below
title: DE20019 - Snapshot upload gave no results
- description: Zephyr Error - DE20019 - Workaround and debug for error: snapshot upload gave no results
+ description: "Zephyr Error - DE20019 - Workaround and debug for error: snapshot upload gave no results"
head:
  - - meta
    - name: og:title
      content: Zephyr Error - DE20019 - Snapshot upload gave no results
  - - meta
    - name: og:url
      content: https://docs.zephyr-cloud.io/guide/error/de20019

Can we improve the error message for yaml syntax errors

Can we improve the error message for yaml syntax errors

The current error messge of serde_yaml is complete and aligned with the specification of yaml, which can debug problems. We can try more on how to better show it.
Failed to parse yaml: <yaml-content>
Error { kind: SCANNER, problem: "mapping values are not allowed in this context", problem_mark: Mark { line: 2, column: 69 } }

But before that, mdx-rs should catch this panic in rust side to make it more friendly to users who doesn't know much about Rust.
https://github.com/web-infra-dev/mdx-rs/issues/49


gitignore *.log *.lock node_modules

This should decrease any git interaction overhead.
As these are generated from npm install or any build commands.
This would also help to keep track of specific changes for future iterations.

Added to .gitignore:
*.bin
*.lock
*.log
node_modules


Maintainers needed

I have been quite busy and not being able to maintain this package very actively. Also, I don't think I will have that much of a time to maintain it actively in the near future.
I believe that this library could be maintained better if there is another maintainer who is willing to maintain this project on their spare time. If anyone is interested to become a maintainer of this project, please let me know, I would really appreciate that.

Interested.

@rijumone Thanks for your interest!
Honestly, I don't know where to start, this is one of my first open-source projects. Should I just grant an access? If so, I have invited you as a collaborator.
If anyone else is also interested in becoming a maintainer, please let me know.

Thanks, accepted the same. Even I am new to this game. Hoping to learn loads.
Let's start by assigning a priority according to urgency and difficultly to implement to each open issue, yes?
Let's keep it simple for now with only HIGH, MEDIUM, LOW values for priority allowed for now.
You will be in a better position to complete this since you know the project best.

Nice to hear that.
I should just label them, right? Or, should make a dedicated issue for tracking all those other issues?

Looks good. We should start with the high ones. There are two. I motion that we should pick this first since it's more recent, it has more detail and I was able to reproduce this.

Agreed @rijumone. #19 is quite critical actually.

Hi, i'm interested to collaborate. I'm currently using the project i'm working to allow it send and receive messages. I'm also quite busy, but i will try to help with the project. I have make a fork of the project and will be uploading my updates to the package.

@reinier-millo Do you want to be a maintainer? Or, do you just want to contribute?
If you want to be a maintainer, I will consider inviting you as a collaborator as well.

@reinier-millo Do you want to be a maintainer? Or, do you just want to contribute?
If you want to be a maintainer, I will consider inviting you as a collaborator as well.

I would like to be maintainer and help with the package development.

@reinier-millo I have invited you as a collaborator.

I'm interested, altough I don't have much time to spent. I think I'll just see if I can help with something and create PRs from time to time.

I am so sorry for the late reply.
@reinier-millo @rijumone @kamuridesu
Because I don't have that much time to maintain the project actively, I am looking for someone to "take over" it. If anyone is interested, please let me know. Also, if you are interested, it would be better to show me the necessary administrative steps (e.g. moving the repository to an organization) because I am still new to the open-source world, and I don't know how certain things work.
However, if no one is interested, I will consider labelling the project as not being maintained anymore and is not usable (due to the lack of multi-device support).


Various updates to the servicenow pack

Pack ServiceNow
Status
A self enclosed barrel of awesome
Description
Replace this with the PR description.
Checklist (tick everything that applies)

[x] Metadata: pack.yaml, icon, structure (required for new packs)
[x] Version bump (required for changed packs)
[x] Code linting (required, can be done after the PR checks)
[x] Tests (not required but really recommended)

@emedvedev I made it go green!

Nice! Merging.

Nice, thanks :)


MS-FontVal/Check-037: Needs support for GDEF Header, Version 1.3

Observed behaviour
com.google.fonts/check/037 returns the following FAIL:
* FAIL: MS-FonVal: The version number is neither 0x00010000 nor 0x0001002 DETAILS: 0x00010003

Sometimes this is the only issue causing com.google.fonts/check/037 to fail, so it would be nice to have this fixed.
Expected behaviour
https://docs.microsoft.com/en-us/typography/opentype/spec/gdef Describes GDEF header version 1.3, which should be supported?
Resources and exact process needed to replicate
Run fontbakery on a new variable font, example: https://github.com/eliheuer/orbitron-vf

please add a corresponding issue on the FontVal issue trackerso that upstream is informed about it.

Ok: https://github.com/Microsoft/Font-Validator/issues/66


Add one step authentication method to Model class

This patch allows to do:
User.login({email<EMAIL_ADDRESS>'testing')
    .then((usr) => console.log(`Auth as ${usr.get('name').}`))
    .catch((err) => console.error(err.message) )

It is a simple contribution, however may be useful for most usecases.
I name it login, through you may prefer to name it signIn, if you want this change or some other, please, let me know.

Closing as this appears to be abandoned


Fix miss kind in docs

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

The two latest ones should be revised as well?

I'm curious about how we handle this kind of obvious mistake.

I'm curious about how we handle this kind of obvious mistake.

Well, I can say that, for the miss spell issue like this, we have to update all versions too 😅 let me update it manually, this PR is just to test the edit this document feature from our document site.

Nice
/approve


update xstream

https://github.com/caelum/vraptor4/pull/1119

closed by https://github.com/caelum/vraptor4/pull/1119


[protobuf] Update protobuf to 3.15.6

Starting from protobuf 3.15 optional message fields are not experimental anymore, which is quite important.

@nicolasnoble

@yashykt, assigning to you since you are the next release manager.

I'm upgrading protobuf to 3.15.8 in https://github.com/grpc/grpc/pull/26105, so this should not be needed anymore


[WIP] BC Break: NetworkParams in Wallet and Network in other places

A new inspection was created.

The inspection completed: 14 new issues, 16 updated code elements

A new inspection was created.

The inspection completed: 15 new issues, 14 updated code elements


Minimized packages included in Pipfile

Changes include:

Reduced the number of packages included in Pipfile
Cleaned up extraneous Pipfile files and requirements.txt

A rebuild of your pipenv virtual environment is needed to utilize these changes:
rm Pipfile.lock
pipenv --rm
pipenv lock
pipenv sync --dev

Re-tested using pipenv run flask and pipenv run tutorial
Signed-off-by: ccorley<EMAIL_ADDRESS>

This makes so much sense and helpfully cleans up a lot of detritus in the PipFile from project iterations.


Polish a bunch of small things

Broken link in "for users" page
"Kickback" => "refund"
More understandable intro paragraph describing the MEV-Share protocol
Reorder several sections for clarity (query param descriptions should go immediately in front of the tables describing the allowed values for those query params; etc)
Remove duplicate statements
Clean up language throughout the first few pages in "For searchers"

PSA vercel deployment seems to be failing for other open PRs.


Fix logo images

Summary
Currently only the header institution logo is configurable using the configuration option siteIcon.
Image and logo on the login page are hard coded. They can be changed by mounting the image to the correct path in the container.
This cause confusion as the configuration is not uniform and it is not well documented.
Same observation is true for background image in the login page
Steps to Reproduce
Check the following lines of code:

src/app/_layout/app-header/app-header.component.ts, line 27
src/app/_layout/app-header/app-header.component.html, line 63
src/app/users/login/login.component.html, line 3
src/app/users/login/login.component.html, line 12

Expected Behaviour
Uniquely name the three different images and clearly document them, so it is easy to over write them with the volume option in container.
Also add a configuration options for all three of them, so it can be configured easily when run locally.

Matching PR has been merged. Closing this issue


Tags, names, etc, may clash with the markdown format

Some niche project names, tags, etc may wrap using *, _, or other special characters, which would tamper the way they're rendered within the insights. Strings obtained from the subgraph should be sanitized and escaped

I'll use this https://www.npmjs.com/package/markdown-escape


download_all as an option, not command

Hey there,
It would be great to have download_all as an option so that it would be possible to use it within fastlane (current implementation is available from command-line command only)
Default behavior generates provisionning. However provisionning generation can be disabled on a per-profile basis in member center : only admin profiles can generate profiles, members cannot.
download_all option would therefore enable members-level to use fastlane with sigh.
Thanks
Bump #116

sigh doesn't generate any certificates, only provisioning profiles. I agree, handling different permissions is something the fastlane tools are not really good yet.

Indeed I meant provisionning profile. However an option to just "download_all" (no create / no renew) from fastlane would be immensely useful (I actually have to sigh provisionning one by one at the moment)
Thanks

@jeremiegirault Feel free to create the action that downloads all provisioning profiles. Use the fastlane new_action command and call the download_all process using
Sigh::Manager.download_all

Let me know if you need any help :+1:

Thanks but I'm not at all a ruby guy, I would like to contribute however and it seem not so hard.
I will try to submit a pull request asap

+1 for download_all as an option
will workaround with Sigh::Manager.download_all for now. Thanks!

I'm going to close this issue since it appears to have a workaround that works for most people. We're more than happy to review a PR that adds an action for this or you can use a local action to do this. 🎀


Global Tic-Tac-Toe state

The state of the TicTacToe game should be global so it is not lost when transitioning to and from the its scene.
Tasks include:

[x] Track the TicTacToe game's state in a singleton

Definition of done includes:

[x] Both players (user and AI) can claim squares on the TicTacToe board, depending on the RoundState
[x] When transitioning to an in-progress tic-tac-toe game, the previous marked squares are indicated

I don't anticipate that this task will be blocked by anything in particular.

Done, there are other debugging issues that I've noted and will list as separate issues


[Test] Test PR Github Action Trigger

This PR was for test purpose only. Branch has been merged in interuss upstream repository.


V0.13 jsonized

Hiya,
I'm proud to present the @AndroidJsonizer active annotation, as I described in issue #103.
Thanks!

Wow, awesome! Thanks :)

BTW, can you include the relevant GSON jars into the libs folder? Otherwise I can't compile in Eclipse. I know it's bad form, but it keeps things simple.


Initial implementation

Add input/output formats which source their data from a UFDL server.
This issue replaces https://github.com/waikato-ufdl/wai-annotations/issues/8

@fracpete can you please re-add this to the UFDL project?

Need to decide how to specify a target dataset from the command line when using a UFDL output format.

If it's a new dataset, need to provide create arguments (name, project, licence, description, etc.)
If it's an existing data-set, need to handle case where images already exist and/or already have annotations.

Ability to read from UFDL object detection datasets is implemented in commit fb2d8ae6bfb59a49a219f381979b930543c3777b

Ability to write to UFDL object detection datasets is implemented in commit 45104e47dcfdb2a561281d1b3c9bb420b0b06757

Read from image classification datasets: 8ea9819a1b6908d56ad9e678de8b699ec192d389
Write to image classification datasets: e20ed193accb2e1ae10160dffac4c5a1201d3dda

Closing this issue as now superceded by #2 and #3


The maven central repository doesn't support 1.0.1.BUILD-SNAPSHOT or later

When I pull the samples, I found that the maven central repository only has verison 1.0.0.RELEASE, but the samples now is version 1.0.1.BUILD-SNAPSHOT.
How can I convert to version 1.0.0.RELEASE and run the samples?

Just checkout the release tag - https://github.com/spring-cloud/spring-cloud-sleuth/tree/v1.0.0.RELEASE . Or just build the whole project with snapshots and then you'll be able to run the samples


Debug using preact

Hello,
I'm new with Deno, but not with Node.js. I started a small project using fresh framework and I'd like to know the best way to debug Preact.
In Preact documentation mention a google chrome extension and import("preact/debug") which I couldn't make it work.
Also try with --inspect-brk which works for code but doesn't provide information of states, components, etc, in Preact.
This is my dev.ts file:
#!/usr/bin/env -S deno run -A --watch=static/,routes/

import("dotenv");
if (Deno.env.get("ENV") === "DEV") {
  import("preact/debug");
}

import dev from "$fresh/dev.ts";

await dev(import.meta.url, "./main.ts");

But doesn't seem to work. Also added at the beginning of main.ts file with same result.
Any advice?

I'm having a similar issue.


Add a tool for a fix when renaming the namespace in the script

Could you please make a tool /extension that will go through the events on all scenes and fix all of the missings method invocation after the namespace on the target script was changed?  It is also occurring when you have two or more assembly definitions with the same class but in different assembly definitions.

https://assetstore.unity.com/packages/tools/utilities/maintainer-32199

nevermind made it myself https://github.com/studentutu/FixMissingUnityEvents


Debug: Console feels janky on high frequency output

Running our selfhost unit tests seems much slower than running it in a terminal. Hypothesis: tree isn't performing well enough for this scenario. We might need a specialized tree API for this.

Assignign to October so we look into this next milestone.

Actually forget about this.... it's actually as fast as on the terminal... it's the perceived performance which sucks since rendering is debounced and everything feels sluggish.

Maybe I can decrease the debounce time.
Or we can test the limits of the tree and I no longer de-bounce

I think you're gonna have to keep the debounce since the current approach is still refresh root, since we're basically O(n^3) right now. If we add some tree API for you to simply append children then we can reduce the whole thing to O(n).

I do not think we do not plan to do anything this milestone.
When we add new tree api we can look into simply adopting that api in the debug console.
Anyways pushing to backlog.

Closing as out of scope, and we can reopen if we ever get passionate about this


WORKFLOW:  Set up test IA document

Try out draw.io to show IA and link off to design documents.
Verification Criteria:

Set up high level IA
Set up example dig-down detail workflow
Check in with IT about access through google drive for internal users
Understand how we can publish and make accessible to external users

Set up document, will create another story to capture updating and linking as soon as we have some other assets in order.


Stage_one WARNING: Duplicated sequences

I generated a warning message while running ARGs OAP stage_one on the server. The metagenomic data is sourced from NCBI and has gone through the kneaddata process. However, when I used my own sequencing data, no warning message was generated. What is the reason and will it affect subsequent analysis? Thanks very much for your answer！
WARNING: Duplicated sequences in sequence extraction.
WARNING: Duplicated sequences in 16S copy number calculation.
WARNING: Duplicated sequences in cell number calculation.

This likely means some of your sequences have exactly identical sequence id. You can check the duplication using e.g. seqkit rmdup.

This likely means some of your sequences have exactly identical sequence id. You can check the duplication using e.g. seqkit rmdup.

We renamed the sequence after downloading the raw data from NCBI, and no duplicate sequence IDs were detected using seqkit rmdup.

 Does your _1 and _2 files have identical sequence id?
cat _1.fa _2.fa > seq.fa
seqkit rmdup seq.fa -D dup.fa

Hi,
do you mind sharing a minimal reproducible example? Does your _1 and _2 files have identical sequence id?
cat _1.fa _2.fa > seq.fa
seqkit rmdup seq.fa -D dup.fa

Thank you. Based on the command you provided, I did detect some duplicated sequences. I then extracted the previously retrieved duplicate IDs from the paired-end sequencing file. Duplicate IDs were found only in one of the pairwise sequence files. I wonder if this error will affect the final result output.

Only the first detected sequence will be counted. This will lead to an underestimation of either ARG/16S/genome copies.


566

gf yaml watch uses the same logging.logger

includes  gf.functions.rotate can recenter component PR
thank you Thomas!


Required support

It would be great if the required attribute would be supported 🐶

Currently the original select element is hidden with a display:none rule.
Here is a fix to implement so the native required attribute is supported:
First the original select element must be moved inside the select-mania container.
Then hide the original select element with these rules:
border: 0 !important; clip: rect(0 0 0 0) !important; height: 100% !important; margin: 0! important; overflow: hidden! important; padding: 0! important; position: absolute !important; width: 100% !important;
Make sure the select-mania container has position:relative

The required attribute is now supported! \o/


Bump GOV.UK Frontend to v2.2.0

What
The Design System team has released a lot of fixes and are now
providing version 2.2.0. We're few versions behind and the fixes
include some of the identified by us previously.
One of the changes the new Frontend version introduces is the lack of
the full size select boxes by default.
In order to keep up with the design as much as possible, we're adding
the extra class to force these expand as they use to.
This also reverts commit 6a007a7.
The issue in question has been beautifully handled by the Design System
Team and no longer needs to exist in our codebase.
Going back to the standard GOV.UK Frontend for consistency and easier
upgrades.
As a bonus, we're upgrading dependencies in order to prevent
vulnerabilities.
How to review

Code review - commit by commit recommended
Run the application and navigate around
Experience no immediate frontend/design issues that haven't been
already raised

Rebased this on top of master

2.10.0 is out :trollface:

2.10.0 is out :trollface:
😖D'oh, thanks. I'll get 2.2.0 merged, then raise a new PR for 2.10.0. It may well make a bunch of Dependobot's PRs irrelevant.


weird baseUrl when run generate

my nuxtent.config.js
module.exports = {
  content: [
    ['blog', {
      page: '/blog/_slug',
      permalink: "/:slug",
      generate: ['get', 'getAll'],
      isPost: false
    }]
  ],
  api: {
   	baseURL: process.env.NODE_ENV === 'production'
	    ? 'http://wi-cuckoo.io'
	    : 'http://localhost:3000'
 	}
}

my package.json scripts
"scripts": {
    "dev": "nuxt",
    "build": "nuxt build",
    "start": "nuxt start",
    "generate": "NODE_ENV=production nuxtent generate",
    "lint": "eslint --ext .js,.vue --ignore-path .gitignore .",
    "precommit": "npm run lint"
  }

So When I run npm run generate. Why OPEN http://localhost:3000 ?
><EMAIL_ADDRESS>generate /home/wi/bin/wi-cuckoo.gitpage
> NODE_ENV=production nuxtent generate

  nuxt:generate Generating... +0ms
[AXIOS] Base URL: http://wi-cuckoo.io/content-api , Browser: http://wi-cuckoo.io/_nuxt/content

 OPEN  http://localhost:3000

  nuxt:build App root: /home/wi/bin/wi-cuckoo.gitpage +0ms

This question is available on Nuxt.js community (#c52)

try it like that :
"generate": "NODE_ENV='production' nuxtent generate",

@STnetwork Oh, that doesn't matter.  I tried HOST=wi-cuckoo.io PORT=80 NODE_ENV=production nuxtent generate
although it can work, but should run as root to listen 80 port. No a good idea. Hope the developer can solve it

ok, it's strange because on the nuxtent-template, the behavior is different, there isn't OPEN  http://localhost:3000

What's the problem here exactly?
The OPEN  http://localhost:3000 part is the @nuxtjs/axios module which nuxtent configures so that the content can be easily fetched with the app.$content method.
You can change the url by configuring api.baseURL".

@alidcastano There is a bug in nuxtent when generate static files. In my config above, the *.json file requests in static page will go to http://localhost:3000. Maybe you could try generating static files by yourself and see what happened. If there is extra config to solve this bug, please update the doc. No any message in the project doc.

Hey @wi-cuckoo I coincidently stumbled upon this problem today too #56. I will make a fix for this soon. Thanks for opening up the issue

@alidcastano  Okay. It's not a problem to OPEN http://localhost:3000. The problem is if I set don't set NODE_NEV = production. The request of some file in generated static files will be on localhost:3000. Absolutely that's incorrect, it should be the domain of production.

I had the same problem, even if you remove NODE_NEV = production, when you want nuxtent generate, it uses http://localhost:3000 the [AXIOS] Base URL, so how it would be possible de put a domain instead the localhost:3000 ?

@alidcastano There is still many problems. I suggest that you could build a demo with nuxt+nuxtent. and generate static files, then deloy it on github as git page. You'll understand what we encountered. If the road is OK, you can post it to our users to help solving.

@STnetwork so the site builds, correct? are you experiencing problems when you deploy the site and try to fetch the content? I'll be fixing this either today or tomorrow so please let me know and be as specific as possible with the problem you are experiencing. And thanks again for using Nuxtent and helping get to the bottom of the early problems

@alidcastano  Thanks for you reply. May the former problems caused by the lack of document or my incorrect config. Now, I just encounter the problem #56 and #57. And maybe the #57 and #59 is just one problem. I encounter these both is generation.
The last, I hope the final correct example of how to deploy on GitHub

Why when you generate without NODE_ENV='production', it used the basic url axios to have access to the content-api like you said, and no the localhost:3000 automatically ?
Because when I generate with this nuxent.config :
const hljs = require('highlight.js')

module.exports = {
// content/HelloWorld.md --> posts/hello-world
 content: {
   page: '/_slug',
   permalink: ":slug",
    generate: [ // for static build
      'get', 'getAll'
    ],
   isPost: false
 },

  parsers: {
    md: {
      highlight: (code, lang) => {
        if (!(lang && hljs.getLanguage(lang))) return ''
        return hljs.highlight(lang, code, true).value
      }
    }
  },

  api: {
    baseURL: process.env.NODE_ENV === 'production'
      ? 'http://mydomain.com'
      : 'http://myipvps:3000'
  }
}

It cannot access to my BaseUrl for generate with the api-content

@alidcastano
Another thing you should see is when we re-actualize or go to a page static directly on a mardown file, it doesn't display the page it appears undefined.
You can see an example here : https://stnetworkbis.surge.sh/hello-world/

@alidcastano
Did you find a solution about why it connects to the BaseUrl to access to the content-api during the generating instead of something we can put in the package.json like "HOST=<IP_ADDRESS> PORT=3000 IS_STATIC=true nuxtent generate" ?

I found a temporary fix in the module.js of your module I changed :
browserBaseURL:a.baseURL+(process.env.STATIC?a.browserPrefix:a.serverPrefix)}]) by
browserBaseURL:(process.env.STATIC?a.browserPrefix:a.serverPrefix)}])

I am also experiencing the same issue, BarryPH's hacky solution did the trick, but it indeed is hacky.
To make the issue clear in a few words: when running nuxtent generate, axios baseURL is set (by default) to http://localhost:3000/, which is good, but the problem emerges when one loads generated content in the browser: there, axios baseURL is still set to http://localhost:3000 instead of e.g. https://nuxtent.now.sh even if you set baseURL: process.env.NODE_ENV === 'production' ? 'http://localhost:3000' : 'https://nuxtent.now.sh' nuxtent.config.js. This should not be so, because the generated content gets served on https://nuxtent.now.sh where localhost:3000 is not accessible, obviously.
May I ask why the baseURL is absolute? It seems to me that this problem wouldn't be present if you just left baseURL empty, making the whole path relative. I may be wrong bout that.

For me, it works (as predicted) if I put this into nuxtent.config.js:
module.exports = {
  ...
  api: {
    baseURL: ''
  }
}

@suhogrozdje
Thanks for this solution it works well for me, I felt alone with this problem !

It works with Github Pages for me. But there are other problems I am experiencing, such as when i navigate directly to a post (i.e. refreshing when on it) and then navigating away from it, the content doesn't change. When I try then to refresh, it works again, but when I try to go back, it emits an error:
GET http://localhost:3000/_nuxt/content/articles/mathematics.whats-this-about..json 404 (Not Found)

This plugin seems to be a bit laggy. I think those of us who feel up to the task should contribute to it by debugging their errors and making a pull request, as there seems to be too much work for the author, which is understandable.

So sorry for being unresponsive! Thanks for finding a solution @suhogrozdje. PR merged!

re up ?


Document the FFI bindgen behaviour

With the merge of https://github.com/hyperledger/iroha/pull/2314 we've added a complex infrastructure of FFI bindgen, that needs to be followed closely. @mversic has created an excellent graphic that should be included in our tutorials if possible.
TikZ or SVG fine. Prefer TikZ.

@6r1d transferred this to tex format, and I'm adding both the source and the output to the docs


Error messages while trying to bundle install

DYLD_FALLBACK_LIBRARY_PATH= "clang -o conftest -I/Users/jakanapes/.rubies/ruby-3.1.0/include/ruby-3.1.0/x86_64-darwin20 -I/Users/jakanapes/.rubies/ruby-3.1.0/include/ruby-3.1.0/ruby/backward -I/Users/jakanapes/.rubies/ruby-3.1.0/include/ruby-3.1.0 -I.   -I/Users/jakanapes/.gem/ruby/3.1.0/gems/zookeeper-1.5.5/ext/include  -L/Users/jakanapes/.gem/ruby/3.1.0/gems/zookeeper-1.5.5/ext/lib -L/Users/jakanapes/.rubies/ruby-3.1.0/lib   -pipe conftest.c  -L/Users/jakanapes/.gem/ruby/3.1.0/gems/zookeeper-1.5.5/ext/lib  -L/Users/jakanapes/.gem/ruby/3.1.0/gems/zookeeper-1.5.5/ext/lib -L/Users/jakanapes/.rubies/ruby-3.1.0/lib -L. -fstack-protector-strong -L/usr/local/lib -L/usr/local/opt/openssl@3/lib -L/usr/local/opt/readline/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/gdbm/lib     -lruby.3.1-static -framework CoreFoundation -lpthread -lgmp -ldl -lobjc    -lzookeeper_st_gem -lm"
In file included from conftest.c:1:
In file included from /Users/jakanapes/.rubies/ruby-3.1.0/include/ruby-3.1.0/ruby.h:38:
In file included from /Users/jakanapes/.rubies/ruby-3.1.0/include/ruby-3.1.0/ruby/ruby.h:25:
In file included from /Users/jakanapes/.rubies/ruby-3.1.0/include/ruby-3.1.0/ruby/defines.h:73:
In file included from /Users/jakanapes/.rubies/ruby-3.1.0/include/ruby-3.1.0/ruby/backward/2/attributes.h:42:
In file included from /Users/jakanapes/.rubies/ruby-3.1.0/include/ruby-3.1.0/ruby/internal/attr/pure.h:25:
/Users/jakanapes/.rubies/ruby-3.1.0/include/ruby-3.1.0/ruby/assert.h:132:1: error: '__declspec' attributes are not enabled; use '-fdeclspec' or '-fms-extensions' to enable support for __declspec attributes
RBIMPL_ATTR_NORETURN()
^
/Users/jakanapes/.rubies/ruby-3.1.0/include/ruby-3.1.0/ruby/internal/attr/noreturn.h:29:33: note: expanded from macro 'RBIMPL_ATTR_NORETURN'
# define RBIMPL_ATTR_NORETURN() __declspec(noreturn)

have tried install with both flags using with-cppflags, but no luck.  Am I missing a dependency lib?

Was able to get it to compile with
bundle config build.zookeeper --with-cflags=-fms-extensions


There is no docs about config plugins for the ingress way.

Ⅰ. Issue Description
I known it can config policy(plugin) for some route in web console, but web console not support complex usage, I need to use ingress. In the docs, there is only plugin paramters description, but how can I add plugin in ingress?
Ⅵ. Environment:

Higress version:  v1.4.1
OS : macOS
Others: Kubernetes v1.28

Checkout this: https://higress.io/zh-cn/docs/plugins/intro

Thanks！


Electrs only connecting over port 50001

I was previously able to connect Electrum to electrs by the following methods

electrum --oneserver --server <IP_ADDRESS>:50002:s

electrum --oneserver --server <IP_ADDRESS>:50001:t

electrum --oneserver --server [address].onion:50002:s --proxy socks5:<IP_ADDRESS>:9150

Now only the second one works. This is what the terminal shows using port 50002

This is using TOR

I have tried restarting nginx

sudo systemctl restart nginx

As well as removing nginx, rerunning the ssl cert script, and rebooting (this use to get it working again but now it doesnt)

sudo apt remove --purge nginx
./config.scripts/internet.selfsignedcert.sh

Version 1.6

If after a reinstall Electrum would not connect to Electrs delete the relevant old certificate on the desktop from:
* Linux: ~/.electrum/certs/
* Windows: User/appdata/roaming/electrum/certs/
More here: https://github.com/openoms/bitcoin-tutorials/blob/master/electrs/README.md#further-help
This is the last time you need to do this after an update. From 1.6 we preserve all the SSL certs on the disk.

That worked, thanks!


retrieve() throws error if a path is provided instead of filename

this works:
CDSAPI.retrieve(<some_name>, <some_params>, "<filename>.<extension>")

But this throws error:
CDSAPI.retrieve(<some_name>, <some_params>, "<path_to_file>/<filename>.<extension>")

Thank you @LakshyaKhatri for carefully checking it. Could you please address the issue? I'be happy to review.

Okay :D

The issue is causing due to the use of Julia's download(). I can resolve the error, but I think implementing a pure Julian download function will surely give us more control.
Something like this: Julia download function

Nice @LakshyaKhatri, thanks for the search.
@oxinabox did you have a chance to register that module you shared as a gist somewhere? We are encountering issues with Julia's built-in download as pointed above.

Yeah, that code now lives in HTTP.jl
As HTTP.download

@LakshyaKhatri that is good news :) Can you please try HTTP.download?


Werewolf portable V2

Key changes and improvements:

Upgraded all the dependencies to their newest versions, including ES2020
Massive code refactoring (I'm not done with that yet, but there are lots of improvements already)
New speech synthesis module instead of the old plugin, this works much better and doesn't require any API keys. It's still a bit problematic on mobile, but the old one was too. Still thinking on how to solve that.
Some UI improvements
Got rid of all warnings

I've performed multiple tests on desktop and mobile, should be working just fine

Need to fix some stuff


Add Color Map to Step Metadata for Object (Instance Segmentation) Mask Colors

From: Ben, Falk https://machinecommonsense.slack.com/archives/CTR31V12M/p1594750155073000
Priority: Backlog
Components: Python API
Blockers: None
Steps:

Remove “color” from ObjectMetadata
Add “color_map” to StepMetadata

A Dict with object ID string keys and color pixel array values
Use scene_event.metadata['colors'] but reformat it
Should only be used in Oracle Metadata Mode

Update the unit tests

TA2 internal JIRA ticket: https://nextcentury.atlassian.net/browse/MCS-318

The slack thread differs slightly from this ticket's description. I'm not sure I fully understand the index suggestion from @fplk's slack comment included below. Can I get some clarity on this idea from @fplk and @bzinberg?
https://machinecommonsense.slack.com/archives/CTR31V12M/p1594750434074000?thread_ts=1594750155.073000&cid=CTR31V12M

@deanwetherby Hope you don't mind me joining this conversation:
It's been a while, so I'm trying to remember how I got from that Slack thread to this Issue's description. I believe my logic flow was as follows:

Ben asked about the ObjectMetadata.color property
Falk explained its use
Ben commented about using "ids and a color map" instead
People made other comments

So I think I grabbed onto Ben's comment and translated it into this Issue. I won't speak to Falk's comment about tuples since I'm not exactly sure what he meant by it. It's also possible that this feature is coming too late and/or no longer of interest.

@ThomasSchellenbergNextCentury that was my understanding as well. I would like to understand the idea behind 0-based indexing over using an object ID key as well as the preferences on a data structure for the color value before I fully implement.

Thanks @deanwetherby and @ThomasSchellenbergNextCentury for looking into this.
99% of my concern on that thread was about the field name, actually.  Since that field has the semantics of "segment id"[^1], calling the field color seemed likely to cause confusion down the line, especially for new people coming onboard who haven't seen this conversation.  And especially since the objects also have actual colors, which this field does not have anything to do with.
Certainly no need for a color map.  In fact, AFAIK, the actual color indicated by these values has no significance at all, it's just an opaque identifier for the segment, right?  This might be an important point to clarify, because at present I don't know what the color map you are considering implementing would mean.
If we simply rename the field to something like segment_id, I'm happy.  Two possible bonuses:

Change the data type to something hashable/immutable/POD that has an obvious string equivalent (for example, a string), so it can be serialized/deserialized easily by foreign code.
Change the naming scheme to something that doesn't look like a different data type (in this case, like a color, when the semantics is not one of actual colors).  Otherwise, by Hyrum's Law, someone will later depend on having undocumented color semantics.

[^1] or "object id"? idk, so far we haven't had instances of a single object with two connected components

@flpk and @bzinberg, we are getting closer to merging this PR. Curious if this adequately addresses the request.

Thanks, chimed in there - https://github.com/NextCenturyCorporation/MCS/pull/413#issuecomment-929571442.

Thanks for this fix!  X-ref some extra comments I left in https://github.com/NextCenturyCorporation/MCS/pull/413#issuecomment-930625678 in case helpful.


adding piano player

Description 📜
A WEB APP BASED FULLY RESPONSIVE PIANO PLAYER FOR GROUND NOTES.
Fixes #841

Type of change 📝
Please delete options that are not relevant.And in order to tick the check box just but x inside them for example [x] like this

[x] Add a new project

Domain of Contribution 📊
Please delete options that are not relevant.And in order to tick the check box just but x inside them for example [x] like this

[x] Project using HTML, CSS & JS

Checklist ✅
Please delete options that are not relevant.And in order to tick the check box just but x inside them for example [x] like this

[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GSSoC'22 contributor

Screenshots / Gif (Optional) 📸

@khushi-purwar please review this PR, and merge it upon finding it correct, this is a responsive page with a fine UI, so please add a level label accordingly


CPUID.HWMonitor version 1.47

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

@microsoft-github-policy-service agree [company="default"]

@microsoft-github-policy-service agree


Implement API for admin job

The API is for harbor system admin to submit a job, and view job logs/status.
1, POST /api/admin/jobs
{
type=GC,
para={job_meta_data}
}
2, GET /api/admin/jobs/?type=gc

PR has already submitted https://github.com/vmware/harbor/pull/5313, close it now.


Revert "Indent continuation lines with 2 indentations"

Reverts dlang/dlang.org#2766
Motivation:
Changes to the DStyle guide can't be made solely based on one's preference. Only changes match the currently established practices can be "codified" via a lightly reviewed PR. Otherwise DStyle changes need the consensus of the majority of active contributors.
That said, such changes don't need a DIP, since this is not change that affects any users of the language, only the contributors.

That seemed like what we were doing anyway so I did not see any harm in having a written guideline of it. However, it folks prefer a different style, I'm fine with reverting this.

That seemed like what we were doing anyway so I did not see any harm in having a written guideline of it. However, it folks prefer a different style, I'm fine with reverting this.

As a policy, I think it's generally safe to merge reverts to controversial PRs. In the worst case, we can simply propose the change again.
@RazvanN7 I'd like to to have this topic clarified in the DStyle, but we need the approval of more people.

As a policy, I think it's generally safe to merge reverts to controversial PRs. In the worst case, we can simply propose the change again.
@RazvanN7 I'd like to to have this topic clarified in the DStyle, but we need the approval of more people.


Methods getUserS should always return a list

According to the comment in the users.js file, all method in a plural form should return a list — I don't think this is the case.

Was due to the cache...


Dc user test fixes round 3

This includes updates for the following:
-edit introduction and links now opens in edit mode (for the currently logged in user) #384
-edit name, introduction, roles and links now opens in a new tab #384
-fix for citations hidden label on expert page when looking at own profile or impersonating another profile (draft)
-hide search works/grants number of matches #390
-remove Roles website links #392
-pager fixes to show last page with ellipses #396
-if grant id number is in title, remove it from ui #394
-update grant download to use new grant types #398
-update grant download to use output CoPIs only for contributors #398

@Vensberg this should be ready for review on test.


logging, added tests, fixed code only flow.

still lots of additional testing to come.

yay for tests, only major thing worth considering is removing all of the log level guards for readability, as its really not needed given how straight forward your log message generation is.

This is just the beginning for tests. I was trying to figure out a pattern.
About the annoying external log level check, it's a perf thing, stops the context switch. I plan on lots and lots of logging.
Can you live with it?
Sent from my Windows Phone

From: Hao<EMAIL_ADDRESS>Sent: 3/31/2015 10:44 AM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS>Subject: Re: [Security] logging, added tests, fixed code only flow. (#202)
yay for tests, only major thing worth considering is removing all of the log level guards for readability, as its really not needed given how straight forward your log message generation is.

Reply to this email directly or view it on GitHub:
https://github.com/aspnet/Security/pull/202#issuecomment-88184547

@brentschmaltz honestly, these changes make the code far harder to read (it's really a PITA :smile:)
If you're particularly concerned about performance, why not using the logger extensions that take a format string and multiple arguments instead of manually calling string.Format?
https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Framework.Logging.Interfaces/LoggerExtensions.cs#L52
BTW, @GrabYourPitchforks has done great things with string interpolation in aspnet/DataProtection, and it really makes logging clearer: https://github.com/aspnet/DataProtection/commit/4365b531d8a4ec319ff26a1e661a6991efbd140f :smile:

@PinpointTownes Thanks for the kind words! Unfortunately one of the downsides to what I did in DataProtection is that logging messages are hardcoded literal strings and thus are non-localized. The code Brent submitted here is more future-proof once localization work is performed.
Calling the logger extensions that take format strings is certainly a good idea. Not only is performance improved, it also gives logging sinks a crack at the raw values without requiring them to parse the string manually.

re: logging - the state of the art is like this: https://github.com/aspnet/Routing/pull/172/files#diff-4997dfe8056272b794ccb3bcdfe214d9R117
Our logging framework understands the key-values - so that loggers that work with key-value-pairs can have them, and loggers that don't still get a new message. /cc @loudej in case he wants to comment.

@GrabYourPitchforks interesting, I didn't know that the ASP.NET team wanted to localize tracing messages :smile:
Do you know whether tracing components will have their own culture or simply use CultureInfo.CurrentCulture?
I wonder if an i18n + string interpolation mix wouldn't be the best of both worlds: you'd simply call logger.LogWarning($"Request did not match the route '{RouteName}' with template '{RouteTemplate}'.") and it would internally retrieve the localized format string corresponding to "Request did not match the route '{0}' with template '{1}'." and call FormattableString.ToString() if needed.

Actually we decided against localizing log messages at this time since we didn't want admins to potentially know all their users languages. Log Messages should always be in English at this time.

Just to clarify, the existing ASP.NET runtime and other .NET Framework components localize log messages using the system installed culture, not the invoking thread's culture. That way sysadmins always see log messages in their own language. Presumably this will be the behavior in the future, but it's just not ready at this time.

I always use CurrentCulture for the localization reason, just a habit. I actually like to use string.cat as it is much faster than string.format. If you are not convinced, run some numbers on loops of: string.Format vs.
str1 + str2.
About the 'loglevel' check, I favor that even though it's a bit messy, macros remember them made that style neater, because if you have logging I want to minimize the perf hit. Something I like to do.

BTW log level guidance is available here: https://github.com/aspnet/Logging/wiki/Guidelines#log-levels
Regarding string concatenation, that doesn't work with resource strings and so should never be used for anything that goes in a resx file (regardless of whether it's ultimately localized).
And regarding the culture, there's no matter of taste or style, it's a correctness issue, per what @GrabYourPitchforks mentioned.

clarifying commnet on what @GrabYourPitchforks said, using String.Format(CultureInfo.CurrentCulture, ...) is correct or NOT correct?

CurrentCulture is incorrect. I think you want InvariantCulture.

Yes, it is not a style thing but a correctness thing. I have always used InvariantCulture when the data was never presented to the user and CurrentCulture when the data will be displayed to the user, such as a log entry. Are you saying that is not correct and we should always use InvariantCulture?

The problem is that there are two users, the remote client and the local admin. CurrentCulture represents the remote client, correct?

Welcome back Tratcher :-)
I thought CurrentCulture represents the culture of the current thread. For logs, I am tailoring them for the dev who uses them for debugging. I know GrabYourPitchforks spoke about the system admin, but I was leaning towards the dev.
If we use InvariantCulture, we are essentially using English culture for all logs when they are localized.

Right, the CurrentCulture will be set to whatever the person using the site/service/API wanted. I.e. someone accessing an API in France could conceivably get French messages. But the developer should always get a single culture. Currently we've said that's the InvariantCulture, but in the future we might want a way for the developer to configure in which culture they want to see all their log messages.

OK, do you want to introduce extensibility for 'culture' now or just go with InvariantCulture.
If we go later, we can always set the default to InvariantCulture.

Right, the dev doing debugging certainly doesn't want to use the culture of the person visiting the site.
I wouldn't do anything special here: just use InvariantCulture.

I wouldn't do anything special here: just use InvariantCulture.

Or better, don't use string.Format at all and let aspnet/Logging handle it internally? :smile:

@PinpointTownes yep, I am going to investigate just that, let the logger do the string format.  Then we just need to modify the logger.

Oh right yeah that's best. Do as little work as possible here, let the logging system do it.

Ding Ding Ding, we have a winner :-)

Yeahhhh. What's the prize? :smile:
(I'll start flooding with feedback/questions when the bool checks are reverted :smiling_imp:)

A general remark: IMHO, you should avoid using named parameters for logging for at least two reasons:

It's really ugly and unnecessary :baby_chick:
You'll have to submit a new PR to use the new extensions offered by this PR: https://github.com/aspnet/Logging/pull/101/files

+1 to getting rid of named arguments in logging, it adds no value and just makes the logging calls look longer and weirder.
I share your pain about following shared coding/style guidelines (my personal pet peeve is the hated { living on its own line).  But given where this code lives, it needs to look/feel like all of repros.

Where is the code/style guideline published?

@brentschmaltz https://github.com/aspnet/Home/wiki/Engineering-guidelines

I don't see anything about these types of issues:
validatedToken?.GetType().ToString()
vs.
(validatedToken == null ? "null" : validatedToken.GetType().ToString()

As pinpoint already pointed out, everyone else is using the ? operator heavily, its just as clear and more compact.
validatedToken?.GetType().ToString()

The team overall has decided to embrace C# 6 features rather heavily. It tends to make code more terse and generally easier to read (once you get used to it :smile: ).

This is fine commentary, but the coding guidelines should reflect the required style.

@PinpointTownes @HaoK I missed how much you dislike the arg names I will change that.

@Eilon @HaoK @PinpointTownes We have spent a lot of time on style and related items but not bugs, I include a 'codestyle' project in Wilson so that developers can easily confirm to Wilsons style. Can we do the same here?

@brentschmaltz unfortunately StyleCop doesn't support C# 6. We worked on trying to add support for it but it was too complex.

@HaoK @Eilon @PinpointTownes I would like to merge this in, any pushback?

@brentschmaltz not particularly. I'll clone and play with the final bits in the next hours :video_game:

good, then I will merge it in.

@HaoK Is there anything blocking this pull request?

I don't think there's anything particularly blocking no

@HaoK Can you merge it? I don't think I have the ability to execute the merge.

You've checked in changes before, so you must have permission.  Just you will want to squash all your changes together before you push to dev (when you merge this branch, just do git merge --squash), and then it should just be one change that you push to dev

I till try, I had pushed to Katana, but never aspnet.

Merged 501bd4ff105ee3985219a01d772f737bffc3e563