Toggle button hover state is incorrect

Not supposed to have a background on hover:

In other material design UI web libraries they use the icon button as the type of button you see here too:

from: https://www.google.com/design/spec/layout/structure.html#structure-app-bar
You've probably seen it in tons of google apps too. These icon buttons are handy to use in other areas such as cards.

On the note of the other types of icon buttons. I bring it up because I realize now the toggle buttons look quite small in the cards... for example:

Now compare that to:

Would be good to be able to achieve the latter in terms of sizing, it looks a lot better.
Do you think the button is suitable for this or do you think there is a 2nd component needed? From what I see in other implementations, the hover and active (ripple) states are different from regular buttons.
Look here for a demo implementation of an icon button:
https://elements.polymer-project.org/elements/paper-icon-button?view=demo:demo/index.html&active=paper-icon-button

@javivelasco  Check out the spec page on my cards branch and play with the icon buttons, you'll see what I mean in how they compare to icon buttons in other material design user interfaces. They also seem a few pixels too small.

Agree. Let's split it into another component a review styling!


feat: Add MINIO_READ_URL_PREFIX env

I'm unsure what problem this is solving? People can add additional minio chart values themselves. Is it now a mandatory field?
If so, we also need the chart version updated, and the changelog.

MINIO_READ_URL_PREFIX helps configure browser <-> minio <-> director communication and it can be set in director component.
I'm not sure how can I pass this property to director without this MR
Docs: https://docs.sorry-cypress.dev/configuration/director-configuration/minio-configuration.

ah yup, that's fair. I didn't spot that.
Cool. If you can update the chart version and add the changelog, we can push this through. You'll need to merge in main too because I pushed an update a few mins ago.

Updated


Adding mission comments to achievement view

Description
Added new component AchievementCommentCard to AchievementView, to display the relevant comments from the corresponding assessment. So that students have a more useful achievement view card. AchievementCommentCardContainer also added to connect with the redux store.
Added

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

How to test

Checklist

[x] I have tested this code
[x] I have updated the documentation

Also, the card does not display multiline comments properly.
For example, the grader enters this:

However, it shows up as this:

Perhaps we can consider using:
white-space: pre-wrap;
word-break: break-word;
Would be great if you guys could do the same for the grading tab in the assessment workspace:


zoom in on current location forces zoom out sometimes

On app start up if you try zooming in the app will force you back to a higher zoom level. This is extremely annoying when you are trying to zoom in on an area with lots of stops. This video demonstrates me opening the app and then double taping to zoom in where you can then see the app automatically zooms me out and the process repeats.

i haven't seen this in forever. please reactivate if this is still occurring.


Problems panel doubles warnings and errors

VSCode Version: Code - Insiders 1.10.0-insider (0b27b528a7aac070bced1239310144d0763823bd, 2017-02-23T07:04:58.188Z)
OS Version: Darwin x64 15.6.0
Extensions:

Extension
Author
Version

path-intellisense
christian-kohler
1.2.0

vscode-eslint
dbaeumer
1.2.6

githistory
donjayamanne
0.1.5

docthis
joelday
0.4.0

debugger-for-chrome
msjsdiag
2.5.3

Problems panel doubles warnings and errors for file under git source control:

This is as designed. More info: #19627, #20859
cc @Microsoft/vscode


Use PEP 508 to make dev-requirements compatible with Python 2 & 3

Use PEP 508 to make dev-requirements compatible with Python 2 & 3
by specifying the appropriate versions of pylint and astroid
for Python2. pylint and astroid dropped Python2 compatibility
for their latest major revisions, so dev-requirements now pins
the latest compatible revision for Python2 if installing in a
Python2 environment.
Fixes issue #: No issue previously identified

Note that we don't test the use of dev-requirements.txt in any automated way.


Dashboard is not running

I've tried to launch cyclops and the cyclops-dashboard in my test enviroment but the dashboard doesn't start correctly (i think so..)
`Loading RCB Cyclops Dashboard micro service ......
  .   ____          _            __ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/

 :: Spring Boot ::        (v1.3.6.RELEASE)

2017-02-24 09:40:24.823  INFO 21298 --- [           main] ch.cyclops.Application                   : Starting Application v0.01 with PID 21298 (/root/cyclops-dashboard/bin/dashboard.jar started by root in /root/cyclops-dashboard)
2017-02-24 09:40:24.833  INFO 21298 --- [           main] ch.cyclops.Application                   : No active profile set, falling back to default profiles: default
2017-02-24 09:40:25.882  INFO 21298 --- [           main] ationConfigEmbeddedWebApplicationContext : Refreshing org.springframework.boot.context.embedded.AnnotationConfigEmbeddedWebApplicationContext@506c589e: startup date [Fri Feb 24 09:40:25 UTC 2017]; root of context hierarchy
2017-02-24 09:40:29.255  INFO 21298 --- [           main] f.a.AutowiredAnnotationBeanPostProcessor : JSR-330 'javax.inject.Inject' annotation found and supported for autowiring
2017-02-24 09:40:30.493  INFO 21298 --- [           main] s.b.c.e.t.TomcatEmbeddedServletContainer : Tomcat initialized with port(s): 8080 (http)
2017-02-24 09:40:30.545  INFO 21298 --- [           main] o.apache.catalina.core.StandardService   : Starting service Tomcat
2017-02-24 09:40:30.549  INFO 21298 --- [           main] org.apache.catalina.core.StandardEngine  : Starting Servlet Engine: Apache Tomcat/8.0.36
2017-02-24 09:40:30.775  INFO 21298 --- [ost-startStop-1] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring embedded WebApplicationContext
2017-02-24 09:40:30.776  INFO 21298 --- [ost-startStop-1] o.s.web.context.ContextLoader            : Root WebApplicationContext: initialization completed in 4899 ms
2017-02-24 09:40:31.112  INFO 21298 --- [ost-startStop-1] o.s.b.c.e.ServletRegistrationBean        : Mapping servlet: 'dispatcherServlet' to [/]
2017-02-24 09:40:31.125  INFO 21298 --- [ost-startStop-1] o.s.b.c.embedded.FilterRegistrationBean  : Mapping filter: 'characterEncodingFilter' to: [/*]
`

At this point the start process is stopping.. the java process is still running..
i cannot enter the dashboard on port 8080
what is the problem? is there an error log available?

Sometimes the startup process can take up-to 5-10 minutes. Have patience :)

Dr. Piyush Harsh, Ph.D.
Researcher, InIT Cloud Computing Lab
Zurich University of Applied Sciences (ZHAW)
[Site] http://piyush-harsh.info
[Google-Scholar] https://scholar.google.ch/citations?hl=en&user=kaSUIp8AAAAJ
[Research Lab] blog.zhaw.ch/icclab
Fax: +41(0)58.935.7403 GPG Keyid: 9C5A8838
On Fri, Feb 24, 2017 at 10:51 AM, schlussbilanz<EMAIL_ADDRESS>wrote:

I've tried to launch cyclops and the cyclops-dashboard in my test
enviroment but the dashboard doesn't start correctly (i think so..)
Loading RCB Cyclops Dashboard micro service ......   .   ____          _            __ _ _  /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \ ( ( )\___ | '_ | '_| | '_ \/ _ | \ \ \
\/  )| |)| | | | | || (| |  ) ) ) )
'  || .__|| ||| |_, | / / / /
=========||==============|/=///_/
:: Spring Boot ::        (v1.3.6.RELEASE)
2017-02-24 09:40:24.823  INFO 21298 --- [           main] ch.cyclops.Application                   : Starting Application v0.01 with PID 21298 (/root/cyclops-dashboard/bin/dashboard.jar started by root in /root/cyclops-dashboard)
2017-02-24 09:40:24.833  INFO 21298 --- [           main] ch.cyclops.Application                   : No active profile set, falling back to default profiles: default
2017-02-24 09:40:25.882  INFO 21298 --- [           main] ationConfigEmbeddedWebApplicationContext : Refreshing org.springframework.boot.context.embedded.AnnotationConfigEmbeddedWebApplicationContext@506c589e: startup date [Fri Feb 24 09:40:25 UTC 2017]; root of context hierarchy
2017-02-24 09:40:29.255  INFO 21298 --- [           main] f.a.AutowiredAnnotationBeanPostProcessor : JSR-330 'javax.inject.Inject' annotation found and supported for autowiring
2017-02-24 09:40:30.493  INFO 21298 --- [           main] s.b.c.e.t.TomcatEmbeddedServletContainer : Tomcat initialized with port(s): 8080 (http)
2017-02-24 09:40:30.545  INFO 21298 --- [           main] o.apache.catalina.core.StandardService   : Starting service Tomcat
2017-02-24 09:40:30.549  INFO 21298 --- [           main] org.apache.catalina.core.StandardEngine  : Starting Servlet Engine: Apache Tomcat/8.0.36
2017-02-24 09:40:30.775  INFO 21298 --- [ost-startStop-1] o.a.c.c.C.[Tomcat].[localhost].[/]       : Initializing Spring embedded WebApplicationContext
2017-02-24 09:40:30.776  INFO 21298 --- [ost-startStop-1] o.s.web.context.ContextLoader            : Root WebApplicationContext: initialization completed in 4899 ms
2017-02-24 09:40:31.112  INFO 21298 --- [ost-startStop-1] o.s.b.c.e.ServletRegistrationBean        : Mapping servlet: 'dispatcherServlet' to [/]
2017-02-24 09:40:31.125  INFO 21298 --- [ost-startStop-1] o.s.b.c.embedded.FilterRegistrationBean  : Mapping filter: 'characterEncodingFilter' to: [/*]
`
At this point the start process is stopping.. the java process is still
running..
i cannot enter the dashboard on port 8080
what is the problem? is there an error log available?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/icclab/cyclops-dashboard/issues/7, or mute the thread
https://github.com/notifications/unsubscribe-auth/AEhGR5cRw3mEhGBjDdUOf4XwoFqO34iyks5rfqgagaJpZM4MLA4e
.


Add support of WEBP format conversion

Add support of WEBP format conversion, add lossy flag for WEBP format, add image quality support for PNG format

I'm not sure). But I'll try to come up with a couple of tests. Thanks for guides provided!

@wcandillon Added e2e tests. Checked on android emulator. Some test can failed(marked) on CanvasKit.

Thank you for this great quality contribution. Canvaskit tests throw different result from this PR. Would it be possible to align the code to match the logic at https://github.com/google/skia/blob/main/modules/canvaskit/canvaskit_bindings.cpp#L947?
Looking forward for us to ship this.


add support for absolute sqlite db path in case of using tauri dialog…

Since tauri provide dialog api, we can use it to browse files on the computer and get the file's absolute path, it is more flexible to make the sqlite plugin adapt to that, so user can operate on any sqlite db file in their computer, no need to put db file to the app's path anymore.

Oh, sorry, didn't notice your PR, and yes you are right, I didn't cover enough scenarios, will look into your pr, and I think it is a frequency requirement for sqlite, it's better to support limited scenarios than no scenario.

you could use dunce crate which will remove the UNC on Windows and keep the path as is on other platforms.

Will try it, thanks.


Jodit doesn't keep table borders

What jodit looks like :

The result I'm getting :

Any idea how to force jodit to give me the exact same HTML I visually see with the borders and all ?

Another example is this :

With this result :

@elshobokshy You need append some styles what you use in your site in to editor

@xdan isn't there a way to be able to get the exact same look without writing any custom styles ? My use of Jodit is to have the client create a table and get the exact same look.

@xdan otherwise, how to add a class to every table created using jodit automatically ? Something like class="jodit-table"

You get a string from jodit editor.
let it be data
so you can manipulate data in onChange function of jodit editor as:
  if (data.includes("<td>")) {
    data = data.replaceAll("<td>", `<td style="border:1px solid black">`);
  }

and then using
dangerouslySetInnerHTML={{
__html: DOMPurify.sanitize(data),
}}
you will get borders

Hey @elshobokshy,
How did you address this issue?

@syedadil010 I gave up and used tinymce v5 as it was easier :) That's why I closed the issue, I'm reopening if @xdan wants to fix this

Based on the previos comment, I solved it like this:
If (content.includes("<table>")){
content = content.replaceAll("<table>", '"<table border="1" style="border-collapse:collapse;"')

I just added this line in CSS for jodit-react table.
it will work fine.
td {
border:solid 1px;
}

Another example is this :  With this result :

Table itself is not adding for me and im getting node element must be in the editor it is saying. How to resolve it

The generate html do not have border style, i fixed it by adding style to the defaultOptions when creating attributes.
Jodit.defaultOptions.createAttributes = {   table: {     style: 'border:1px solid;border-collapse:collapse;width: 100%;',   },   tr: {     style: ' border: 1px solid;',   },   td: {     style: ' border: 1px solid;',   }, };

as stated from @ckc2715 I added the createAttribute option into the config using jodit-react
const config =     {       theme: theme,       createAttributes: { table: { style: 'border:1px solid #C5C6C8FF;border-collapse:collapse;width: 100%;', }, tr: { style: ' border: 1px solid #C5C6C8FF;', }, td: { style: ' border: 1px solid #C5C6C8FF;'}}, ...}
this does indeed fix it. thanks @ckc2715
cheers 😸

table border must be a attribute to be applied for each cell. otherwise border-color will be useless without border.


feat:useNFTMetadata hook

adding hook useNFTMetadata

this hook is working in storybook
also changed:
  "engines": {     "node": ">=10"   },
to:
  "engines": {     "node": ">=14.0.0"   },
hopefully this will resolve errors with the CI action

@baomastr  :)


Fix from_base64 Presto function for inputs without padding

Fixes https://github.com/facebookincubator/velox/issues/8646

@Joe-Abraham This PR is marked as Draft. Is is still a work-in-progress or ready for review?

@mbasmanova It is WIP and I have a few reworks pending.
I will request for re-review, once I am done.
Hope that sounds good!

@Joe-Abraham Got it. Thank you for clarifying. Sounds good to me.

@mbasmanova, Can you please look into the reworks that were done?

@mbasmanova Can you please review?

@Joe-Abraham will review it next week.

@Joe-Abraham can you please address the final nits and update the velox documentation at velox/docs/functions/presto/binary.rst to clarify this behavior. Thanks!

@bikramSingh91 I am a bit confused about what needs to be added at velox/docs/functions/presto/binary. rst. Could you please help me understand the changes required in this file?

@Joe-Abraham The documentation for from_base64 function says "Decodes binary data from the base64 encoded string." It is not clear whether inputs are required to have padding or not. It would be nice to clarify and perhaps include a few examples.
https://facebookincubator.github.io/velox/functions/presto/binary.html#from_base64


ieee802154: random sequence number

Set the sequence number to a random value when building the interface (builds on #573).

bors r+


Use normal quotes for a pod import

Backticks are not valid syntax when dealing with CocoaPods. This fixes an instance where backticks where used instead of single quotes.

Thanks!


chore: add id token

Description
add id token which is necessary for aws creds to work now
Checklist before merging

[ ] Test, docs, adr added or updated as needed
[ ] Contributor Guide Steps followed

fixed by #2739


coqPackages.math-classes: init at 2016-06-08

Motivation for this change
math-classes is a very cool new approach to the algebraic hierarchy based on coq's new first-class typeclass mechanism!
@jwiegley I thought I'd take this time to ask you a question, somewhat related to this PR. In my shell.nix for coq projects, I define
  shellHook = ''
    COQPATH=${math-classes}/lib/coq/8.5/user-contrib/
  '';

Is there a better way? How can I check to see whether or not the library is accessible, e.g.\ for building other coq packages?
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Merged in d486fb053b3f148e5989d6cd3e07a69eaf75d0bf. Thanks.
I’ve done the following amendments to your commit: use coq as a variable name instead of coq_8_5 (they are aliased in the calling context), state the version in the package name (the same version string that you put in the commit message), clean the installPhase so that it relies on upstream makefile instead of custom commands, and consistently use math-classes for the directory, attribute, and package names.
Concerning your question, the COQPATH environment variable should be automatically set so long you have coq in your shell.nix buildInputs.

@vbgl Thanks so much for your help! I'll use your example next time I submit a Coq package.

Works like a charm :)

@vbgl I have a quick question about using this in my own projects. I set up the following shell.nix
let
  # Pin a nixpkgs version
  _nixpkgs = import <nixpkgs> { };
  pkgs = import (_nixpkgs.fetchFromGitHub {
    owner  = "NixOS";
    repo   = "nixpkgs";
    rev    = "d486fb053b3f148e5989d6cd3e07a69eaf75d0bf";
    sha256 = "14s283bwh77266zslc96gr7zqaijq5b9k4wp272ry27j5q8l3h4i";
  }) {};

in with pkgs; stdenv.mkDerivation {
  name = "name";
  src = null;
  shellHook = ''
    export COQPATH=$PWD/src
  '';
  buildInputs = [
    coq_8_5
    coqPackages_8_5.math-classes
  ];
}

But if I have the following Coq file:
Require Import MathClasses.interfaces.canonical_names.

and I try to compile it, I get this error:
$ coqc src/file.v
File "./src/file.v", line 3, characters 15-53:
Error: Cannot find a physical path bound to logical path matching suffix
MathClasses.interfaces

Do I need to do any other setup? This issue is why I had
mkdir -p $COQLIB/user-contrib/MathClasses
cp -pR . $COQLIB/user-contrib/MathClasses

in the default.nix in the first place.

export COQPATH=$PWD/src

You probably need to append your local path to the current list of coq
search paths, as in COQPATH=$PWD/src:$COQPATH. Otherwise, it means
that coq libraries are only searched in ./src.


Deep Mind off-chain ABI serializer & FC encoded hex output

Change Description
ABI serialization of binary data to JSON will be performed completely off-chain from now on. The output of heavy stuff (TransactionTrace, BlockState, Transaction) are now written as hexadecimal output using the EOSIO fc encoding binary protocol.
Moreover, on boot, nodeos will now dump all known ABIs of each account. Through standard deep mind data exchange protocol, we now dump all ABIs of all account on startup of nodeos. This is required now because the ABI serialization will be performed off-chain, and to achieve that correctly, we require existing ABI at startup time.
Not that I could remove some of the changes around ABI serialization made to support deep mind in the previous patch if you would like to (specialized maybe_to_variant_with_abi, getters to expose ABI serializer max time in apply_context, and other related stuff).
Note I just rebased our change against develop, I'm in the process of compiling it against develop now to check if everything compiles correctly.
Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

@maoueh Where are you at with @swatanabe-b1 's comment fixes?

@brianjohnson5972 @swatanabe-b1 Was not a proper review, more an answer to a general question I was asking. Unless I'm mistaken here.
So, this is still waiting for a review.


Circle selector addition

In this, there is an issue with the enclosing box. It's usually much bigger in size. Should only be merged once it's fixed

Pushed some changes to this PR. Now, the functionality looks fine. @seveibar, Please review once and suggest if any changes are required.
Also, what do you think of storing iw and ih from ImageCanvasIndex/index.js in the redux store?

looks solid at first glance, going to do deeper review tonight

I've started looking at this code more closely and interacting with the code myself. The big issue here is that the radius cannot be represented in the "percentage" unit or the resulting circle is not a circle, but rather an oval squashed at a ratio equal to the width:height ratio of the image.

so i'm going to close this and open a new PR from our project because i discovered new issues and made some progress towards our radius issue. @saichander17 you're welcome to push to the new PR (I given you permissions), there are only mostly minor issues remaining.

Thanks @seveibar.


kubectl delete ns nginx-ingress doesn't remove clusterroles

Following this tutorial using helm v3.1.1 and kubectl 1.17.2, I ran into an issue trying to replicate the example. The first time executing the commands was fine. I performed a teardown with kubectl delete ns ingress-basic. The issue I ran into was attempting execute a helm install a second time. The the following output was generated:
Error: rendered manifests contain a resource that already exists. Unable to continue with install: existing resource conflict: namespace: , name: nginx-ingress, existing_kind: rbac.authorization.k8s.io/v1, Kind=ClusterRole, new_kind: rbac.authorization.k8s.io/v1, Kind=ClusterRole

This was a bit confusing, but I was able to resolve this by deleting the two cluster roles:
kubectl delete clusterrole nginx-ingress;
kubectl delete clusterrolebindings.rbac.authorization.k8s.io nginx-ingress;

I would remove the section on using kubectl delete ns nginx-ingress as a way to tearing down all of the resources. There's this issue on GitHub where another user ran into this problem while following this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1bf9c2f3-caeb-0fb1-f089-3f7ca4fad729
Version Independent ID: 929253d7-c763-6429-561f-529d39b5284d
Content: Create an ingress controller for an internal network in Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/ingress-internal-ip.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@wfc-sfmjp Thank you for your feedback! We will review and provide an update as appropriate.

@wfc-sfmjp Thats true. Deleting a namespace wont delete the cluster role bindings.
We can add two more commands to delete the cluster role bindings.
I will assign the issue to the content author to investigate further and update the document as appropriate.

Thank you @wfc-sfmjp for the feedback!
I was able to verify this works with the latest release of Helm.
Closing for now but please follow up if you're continue to see this issue with the latest version of Helm.
#please-close


@craigspaeth => Adds tracking to footer markdown links & fixes font link

cc @anipetrov for naming
Closes https://github.com/artsy/publishing/issues/35

@owendodd we can search by destination_path for the url that was clicked

LGTM! Minor non-blocking comment, feel free to merge when 💚


Swarm

This replaces the Citadel / Shipyard integration with Swarm.  It works almost identically using the cluster event stream from Swarm.  This also adds TLS support and the ability to automatically re-connect / reload after a connection drop to Swarm / Docker.
This PR also uses Godeps as recommended - hence the larger changeset.

This uses an error channel for the Dockerclient (https://github.com/samalba/dockerclient/pull/68).  The Godeps should be updated once that is merged.

@ehazlett time to update the Godeps

@vieux thx!

Works great!, can you explain a bit more the INTERLOCK_DATA variable ?

@vieux sure.  the INTERLOCK_DATA allows for customization of the backend at container runtime.  For example, the following options are available:

hostname: override the container hostname -- this is the combined with the domain to create the endpoint
domain: override the container domain
alias_domains: specify a list of alias domains to add ({"alias_domains": ["foo.com", "bar.com"]})
port: specify which container port to use for backend ({"port": 8080})
warm: connect to the container before adding to the backend ({"warm": true})
check: specify a custom check for the backend ({"check": "httpchk GET /"})
backend_options: specify a list of additional options for the backend ({"backend_options": ["forceclose", "http-no-delay"]}) -- see http://cbonte.github.io/haproxy-dconv/configuration-1.5.html#4.1
check_interval: specify the interval (in ms) when to run the health check ({"check_interval": 10000})  default: 5000
ssl_only: configure redirect to SSL for backend ({"ssl_only": true})

You specify one ore more in JSON format in the INTERLOCK_DATA environment variable when running the container:
docker run -ti \
    -P \
    -d \
    --hostname www.example.com \
    -e INTERLOCK_DATA='{"alias_domains": ["foo.com"], "port": 8080, "warm": true, "ssl_only": true}' \
    ehazlett/go-demo

This would run the container ehazlett/go-demo.  Interlock would setup the backend www.example.com and and alias foo.com, interlock would use the exposed port that corresponded to the container port 8080, send a request to "warm" the container and setup a redirect to force https.
Make sense?

@ehazlett yes thanks

I tested and it works great.

awesome!  thanks for testing!
On Wed, Feb 4, 2015 at 1:15 PM, Victor Vieux<EMAIL_ADDRESS>wrote:

I tested and it works great.
—
Reply to this email directly or view it on GitHub
https://github.com/ehazlett/interlock/pull/19#issuecomment-72907520.


Include message about volume template being created/reused when services with volumes having external=false is deployed.

Rancher Version:Build form master
Steps to reproduce the problem:
Create a service with shared volume ( at stack level using external: false).
This results in new volume being created which gets mounted on every service container.
There is no indication in the messages presented to the user about this volume being created.
version: '2'
services:
  nginx3:
    image: nginx
    volumes:
    - foo3:/tmp

volumes:
  foo3:
    driver: convoy-nfs
    external: false

Sangeethas-MacBook-Pro:rancher-compose-v0.11.0-rc1 sangeethahariharan1$ ./rancher-compose -p yello  -f test-stack.yml up
INFO[0000] Creating stack yello
INFO[0000] [0/1] [nginx3]: Creating
INFO[0000] Creating service nginx3
INFO[0001] [0/1] [nginx3]: Created
INFO[0001] [0/1] [nginx3]: Starting
INFO[0009] [1/1] [nginx3]: Started

Also when created service ends up using the existing volume (in stack scope), present this information to the user.

Tested with rancher-compose-v0.11.0-rc4:
User is now presented with message about volume being created/reused:
./rancher-compose -p newstack  -f test-m-stack.yml up
INFO[0000] [0/2] [nginx4]: Creating
INFO[0000] [0/2] [nginx3]: Creating
INFO[0000] Creating service nginx4
INFO[0000] [0/2] [nginx3]: Created
INFO[0001] [0/2] [nginx4]: Created
INFO[0001] Existing volume template found for foo5
INFO[0001] [0/2] [nginx3]: Starting
INFO[0001] [0/2] [nginx4]: Starting
INFO[0001] [1/2] [nginx3]: Started
INFO[0005] [2/2] [nginx4]: Started

Sangeethas-MacBook-Pro:rancher-compose-v0.11.0-rc4 sangeethahariharan1$  ./rancher-compose -p newstack3  -f test-m-stack.yml up
INFO[0000] Creating stack newstack3
INFO[0000] [0/2] [nginx4]: Creating
INFO[0000] [0/2] [nginx3]: Creating
INFO[0000] Creating service nginx3
INFO[0000] Creating service nginx4
INFO[0001] [0/2] [nginx3]: Created
INFO[0001] [0/2] [nginx4]: Created
INFO[0001] Creating volume template foo4


Surprising behavior of Tuple causing bug in SimpleHash

Hello,
I am not sure this can be considerevole a bug, but it is a surprising behavior that might deserve documentation, ad it can cause subtle bugs.
This code compiles without errors:
Tuple(Int32, Int32).new("foo", "bar") # => {"foo", "bar"}

This is because of the way Tuple.new is implemented, that does not make use of type bounds:
def self.new(*args)
  args
end

Sometimes this can lead to buggy behavior, like in SimpleHash, where this code does not compile:
require " simple_hash"

h = SimpleHash(Symbol, Int32 | Book).new
h[:foo] = 42

# compilation error:
# no overload matches 'Array({Symbol, Int32 | Book})#[]=' with types Int32, {Symbol, Int32}

I can submit a pull request to fix SimpleHash by using a custom Entry(K, V) struct instead of a Tuple(K, V), but I also wanted to let you know and possibly decide on this behavior of tuple. If you consider it a bug and have a fix in mind to make Tuple.new respect its type bounds, then the change in SimpleHash is unnecessary.
As always, let me know if I can help with this issue. Crystal is an amazing project and I want to help making it rock-solid.

This is a combination of two bugs: #1828 and #357.
For now we can use an Entry struct instead of a tuple until we solve these issues, but it's better if SimpleHash is usable.


always get Invalid solution while running your example code

Not sure why, but when i run your basic example from readme, i always get Invalid solution.
Challenge created: {"algorithm":"SHA-256","challenge":"d8afaf9fd910d01c0ef6369b044cbb533071d204244ff9e4b96ce524c89d0a54","maxnumber":50000,"salt":"50cbc548da9f46b84083b67f","signature":"7ce8c30030426e900550db3d81448116673cf7796b94ba1d627364bd1c43a275"}
Invalid solution.

Tried with PHP 7.4 , 8.2 and 8.4

Looks like i fixed myself ( with a hint of ai)
seems like the number variable is not very optional (as the readme may suggest)
<?php
use AltchaOrg\Altcha\ChallengeOptions;
use AltchaOrg\Altcha\Altcha;

$hmacKey = 'secret hmac key';

// Generate a random number within the range
$number = rand(0, 50000);
echo "Generated number: " . $number . "\n";

// Create a new challenge with the generated number
$options = new ChallengeOptions([
    'hmacKey'   => $hmacKey,
    'maxNumber' => 50000, // the maximum random number
    'number'    => $number, // Pass the generated number
]);

$challenge = Altcha::createChallenge($options);
echo "Challenge created: " . json_encode($challenge) . "\n";

// Example payload to verify
$payload = [
    'algorithm' => $challenge->algorithm,
    'challenge' => $challenge->challenge,
    'number'    => $number, // Use the generated number
    'salt'      => $challenge->salt,
    'signature' => $challenge->signature,
];

echo "Payload: " . json_encode($payload) . "\n";

// Verify the solution
$ok = Altcha::verifySolution($payload, $hmacKey, true);

if ($ok) {
    echo "Solution verified!\n";
} else {
    echo "Invalid solution.\n";
}
?>

Hi, the number attribute is optional, if not provided, a random number will be generated for the challenge.
The function verifySolution verifies the solution (not the challenge), to find the solution (the random secret number), you need to solve the challenge with the widget of use the solveChallenge function.
The example includes only an example number, which you're supposed to get from the widget or the solveChallenge function. To make the example code work without solving the challenge, you can manually generate the number as you mentioned.
For more information, refer to the PoW docs.

thanks for clarification


Remove log_pdf_mask in favor of poutine.scale

Addresses #732
@eb8680 suggested removing the log_pdf_mask argument from Distributions since this can be accomplished via poutine.scale. This PR does that.
Note that @neerajprad had added some helpful log_pdf_mask broadcast checks to .log_prob(). This PR preserves that helpful check by introducing a safe scale_tensor() helper that is used in Trace.* methods to scale the log_prob value.

did you test the examples for correctness?

if it ain't automated i didn't test it

@martinjankowiak Are you now happy merging this?


Clarification on 'Square logo image'

I am looking for a bit of clarification on where exactly the 'Square logo image' will show up.
The tooltip in the Azure Portal says:
'The square logo is used to represent user accounts in your organization, on Azure AD web UI and in Windows 10'
This page here however says:
'This image appears during setup for new Enterprise Windows 10 PCs. It provides context to employees when they set up their new work PC. The image is displayed for tenants that use Windows AutoPilot to deploy their work devices, and on password entry pages in other Windows 10 experiences.'
The tooltip makes it sound like it is not exclusive to Windows 10 devices (Azure AD web UI), but the page here does. Can someone please clarify this and maybe provide some actual examples.
Also, this page does not mention the 'Square logo image, dark theme' at all.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7643fe82-32c0-619a-7a2e-97ef63db60cb
Version Independent ID: e9e16a23-77e5-0df4-2020-96e54fc00d2e
Content: Customize the sign-in page for your Azure Active Directory tenant
Content Source: articles/active-directory/customize-branding.md
Service: active-directory
Product: unspecified
GitHub Login: @curtand
Microsoft Alias: curtand

@gutjahr Thanks for your feedback! We will investigate and update as appropriate.

@curtand Can you please help adding or correcting details in the documentation.  I tried setting up the logo and still I am not able to see that image on my login or Azure AD page.

Hi @SaurabhSharma-MSFT
I received an update on our GitHub issues handling last week. Product questions should go to the PM, in this case Kelvin Xia.

@gutjahr - the square logo is used exclusively in Windows authentication flows (see attached images). The dark theme version is deprecated and is no longer used anywhere.

@kelvinxia-MSFT Thanks Kelvin.
@curtand Is it possible to get it added to the current documentation ?

I can do this. I'll take it on tomorrow.

@SaurabhSharma-MSFT

@curtand  thanks

It's checked in now: https://github.com/MicrosoftDocs/azure-docs-pr/pull/48239
@gutjahr
@SaurabhSharma-MSFT

#please-close

@gutjahr We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


All unlabeled clips unplayable in the Manage datasets interface for a freshly built dataset.

This is with VCA release 1.0.2 using the compiled executable on Windows 10.
The play option is simply grayed out for all listed clips. Have checked, and all the listed clips are playable from within file explorer, and in the case of this dataset, ranging in length from 1-6 seconds.

I have a new release coming soon that fixes an issue with the unlabelled clips. If this doesn't help please let me know

Just built a new dataset in 1.0.3 (using pre-built binary release under Windows 10) and still getting the same erroneous behavior - all listed unlabeled clips for the dataset in the dataset management page have their playback controls grayed out.

Have you tried force reloading the page to clear cache? It uses javascript to load the audio so you'll need to reload the javascript for that to work

@BenAAndrew tried force reloading to no avail. All listed Unlabeled clips in the dropdown still have playback abilities completely grayed out and no clip length shown.

Fwiw when navigating via File Explorer to the location of the unlabeled clips, all show up with their listed filenames in the app and they are playable via the system default app for wave files.
Although I did just notice that the subdirectory for unlabeled clips is named "unlabelled" the British way with two LL's. Which is something my U.S. spellchecker is wanting to correct. Wondering if there might be a spelling mismatch in the sourcecode somewhere...

Popped open Console in Chrome, and am immediately getting the following error readout as soon as a dataset generated with unlabeled clip support is selected:

This should be fixed in 1.0.4. Please reopen if this is not the case

@BenAAndrew
Can't reopen issue (don't have permissions for that) but erroneous behavior persists unchanged in release 1.0.4.


Allow more control on custom type formatting

Summary of the new feature/enhancement
A developer might have created some custom type that aims to behave like a primitive or built-in type, but PowerShell does not provide a way to let the developer precisely control formatting of custom types. In particular, the handling of string is very special --- it implements IEnumerable<char>, but will not be enumerated (into a stream of chars) when formatted. There is no way for a custom type to be handled like a string.
Another example. Currently, System.Text.Rune does not have special handling, and the default formatting is Format-List instead of ToString(). Arguably, ToString() is more appropriate. For a custom type, the only way to force ToString() formatting is to apply System.Management.Automation.HiddenAttribute to all instance fields and properties. However, this comes with the downside of referencing PowerShell in the assembly containing the type, but the assembly should be usable even in an environment without PowerShell (and you don't want to load PowerShell assemblies if you aren't using it anyway).
The closest we can get for Rune (or any other custom type not implementing IEnumerable nor IEnumerator) is to give it a Custom view, but it will add blank lines when outputting. Not ideal...

This issue aims to generate discussion on creating mechanisms to have fine-grained control over (default) formatting of a type. Related #9538.
Proposed technical implementation details (optional)
Here is a simple proposal.

Decouple Out-Default into Format-Default and Out-Host. Today's PowerShell handles Out-Default monolithically. It chooses Format-Table or Format-List or ToString()-formatting, depending on the number of non-hidden public fields and properties, and then applies Out-Host.
In Format.ps1xml, allow a new type of NativeControl. It specifies a type name, which, if found in loaded assemblies, is used to format the object.
Format-Default chooses the format as follows:

If there is a view defined for this type, use the first available view (which does not have to be NativeControl view). However, if NativeControl formatter was used to produce the object being formatted (formatting is recursive for NativeControl views), then NativeControl is skipped.
Otherwise, use today's default formatting choice. (Special handling for string; use ToString() if there is no non-hidden public fields or properties; use Format-Table if there are only a few; use Format-List if there are many.)

Make the types in Microsoft.PowerShell.Commands.Internal.Format public, so people can create custom format objects. Provide a new abstract class:
// or another namespace?
namespace System.Management.Automation
{
  // The derived class must be stateless, so that
  // only one instance is created per PowerShell runspace.
  public abstract class NativeFormatter
  {
    // The returned object is recursively formatted,
    // but cannot be sent to the same formatter again.
    public abstract object FormatObject(object obj);
  }
}

For example, suppose we have a custom string class AsciiString, then we can create
public sealed class AsciiStringFormatter : NativeFormatter
{
  public override object FormatObject(object obj) { return ((AsciiString)obj).ToString(); }
}

This will format an AsciiString into a string, which will then be handled by PowerShell natively.
It's also possible to return IEnumerable from FormatObject, which will be expanded by PowerShell, and each resulting object is formatted by their own formatter. Those expanded object could be what is Microsoft.PowerShell.Commands.Internal.Format.GroupEntryData today.
Why it is important that we implement formatting in another class.

First, we don't want the main assembly (e.g., the assembly containing AsciiString) to be tied to PowerShell. By allowing it to be implemented in another class, the author can implement the formatter in a separate assembly dedicated for scripting (a kind of add-on to the main assembly).
Second, users (non-developers of the main assembly) can develop their own native formatter if they so wish.

I may not have the full picture, but at least the System.Text.Rune example can be implemented by combining a CustomControl entry with the OutOfBand element, as follows:
@'
<Configuration>
<ViewDefinitions>
      <View>
          <Name>RuneFormat</Name>
          <OutOfBand />
          <ViewSelectedBy>
              <TypeName>System.Text.Rune</TypeName>
          </ViewSelectedBy>
          <CustomControl>
              <CustomEntries>
                  <CustomEntry>
                     <CustomItem>
                          <ExpressionBinding>
                              <ScriptBlock>
                              <![CDATA[
  $_.ToString()
                              ]]>
                              </ScriptBlock>
                          </ExpressionBinding>
                      </CustomItem>
                  </CustomEntry>
              </CustomEntries>
          </CustomControl>
      </View>
</ViewDefinitions>
</Configuration>
'@ > ($tmpFile = [IO.Path]::GetTempPath() + "$PID.ps1xml")

# Load the format data and remove the temp. file.
Update-FormatData -PrependPath $tmpFile; Remove-Item $tmpFile

Now you get the desired single-line representation with no surrounding blank lines:
PS> [System.Text.Rune]::new(123)
{

To get a standard view, use -Force:
PS> [System.Text.Rune]::new(123) | Format-List -Force

IsAscii             : True
IsBmp               : True
Plane               : 0
Utf16SequenceLength : 1
Utf8SequenceLength  : 1
Value               : 123

@mklement0 Thanks for the pointer! I didn't know OutOfBand (looks like this feature is little documented). This definitely solves the problem for non-enumerable types. Yet the issue for enumerable types still stand.
Currently, it's not possible to prevent enumeration unless the type is string or the enumeration depth is exhausted.
@'
<Configuration><ViewDefinitions><View>
<Name>MyHashTableFormat</Name>
<OutOfBand />
<ViewSelectedBy><TypeName>System.Collections.Hashtable</TypeName></ViewSelectedBy>
<CustomControl><CustomEntries><CustomEntry><CustomItem><ExpressionBinding><ScriptBlock>
ConvertTo-Json -InputObject $_ -Compress
</ScriptBlock></ExpressionBinding></CustomItem></CustomEntry></CustomEntries></CustomControl>
</View></ViewDefinitions></Configuration>
'@ > ($tmpFile = [IO.Path]::GetTempPath() + "$PID.ps1xml");
Set-ExecutionPolicy -ExecutionPolicy Unrestricted -Scope CurrentUser -Force;
Update-FormatData -PrependPath $tmpFile;
Remove-Item $tmpFile;

$ht = @{'a' = 1; 'b' = 'c'};
$array1 = [object[]]@(0);
$array2 = [object[]]@(0);
$array1[0] = $ht;
$array2[0] = $array1;

$array1; # $ht is enumerated
$array2; # uses the custom format

That's a good point, though I wonder if this should be considered a bug: why should a type's explicitly assigned format not be honored, just because it implements IEnumerable?

Most likely just because the pipeline enumerates before the formatter ever gets a look at it.

@vexx32, that's what seems to be happening de facto, but my point was that if you register formatting data for a type explicitly, it should arguably always be honored, whether the type is enumerable or not. As @GeeLaw's example shows, the fact that it is situationally honored - when no enumeration happens to be in the picture - suggests that this is more of a fallout from the implementation than by intentional design.

After a second thought, it really is about controlling whether a type should be perceived as enumerable, not just for formatting. Suppose someone implements AsciiString, then you want [AsciiString]$myAsciiString | foreach { <# blah #> } to not enumerate $myAsciiString.
By some reverse-engineering on how PowerShell handles string, I came up with this horrifying hack (not intended for production use): https://gist.github.com/GeeLaw/45d87803847195f9ba0f0155e00493e9
The snippet makes ArrayList mostly non-enumerable.

Inject a rule into PSEnumerableBinder to make the enumerator of ArrayList the dummy NonEnumerableObjectEnumerator.
Inject a rule into PSPipeWriterBinder to make ArrayList pass through the pipe without being enumerated.
Inject a rule into LanguagePrimitives.GetEnumerable to make it appear non-enumerable.

I'm not sure how to interpret the result of Write-Host. When passed by pipe, the result is ToString(). When passed via InputObject, the result is joined enumerated items (perhaps due to non-overridden ToString?). And certainly Windows PowerShell 5.1 has some weird behavior...
I think the issue should be changed to a feature request of controlling enumeration behavior of custom types.

I think these are two aspects to consider independently:

[This may be what you have in mind] Should there be a way to signal to PowerShell that a given type that implements IEnumerable should not be treated as such in the pipeline?

Currently, this decision is hard-coded, comprising exceptions that both exclude ([string], IDictionary, XmlNode) and include (DataTable)

Should formatting data associated with a given type always be honored, irrespective of whether it is enumerable or not?(I think so)

According to the docs, every line of command is equivalent when appended with | Out-Host, so if a type is enumerable, it will only be treated as enumerated items, not itself.
When scripting, there really isn't much difference between List<byte> and byte[] (and even object[] with all items being boxed bytes). I wouldn't expect a cmdlet/function that happens to use List as its intermediate storage and direct return value to be formatted differently. But there is a crucial difference between AsciiString : IEnumerable<byte> and byte[]. I would lean towards implementing the first aspect, and leaving the second as-is (an enumerable type cannot be formatted, unless the enumeration depth is exhausted).

leaving the second as-is (an enumerable type cannot be formatted, unless the enumeration depth is exhausted).

I find this situational inconsistency troubling - if someone wants to use custom-formatting for an enumerable, they should be able to do so, not just when PowerShell happens not to preempt it - but it's probably not much of a real-world concern.
Either way, to get the behavior you want it sounds like two things are needed:

Provide a way to tell PowerShell that a given IEnumerable type is not to be enumerated in the pipeline, as data.

Perhaps an attribute to decorate such types is the best solution, say [PSNoDefaultEnumeration] public class AsciiString : IEnumerable<byte> { ... }

Make PowerShell's output formatting system  respect this attribute too and then always apply any formatting data associated with such a type.

That the data and the formatting behaviors are already distinct is evidenced by the [hashtable] example: this type is not enumerated in the pipeline, but is enumerated for formatting.

We discussed this today in the Engine Working Group.
I think we agree with @mklement0's above summary here that there are fundamentally a couple of different issues converging here:

Whether IEnumerable/IEnumerable-implementing types are enumerated by default is currently baked in to the core engine logic and cannot be customized.
The formatting system also typically enumerates records on its own, historically so that it can display the contents of a dictionary (etc).

For preventing enumeration of additional types, we think allowing some method of annotating a type so that it's not enumerated in the pipeline may be of interest. We all agreed that we'd need to see some more concrete real-world examples of where the current behaviour is insufficient and how adding this kind of feature would improve things. Whether this should take the form of an attribute, or a cached list of types which can be updated via an Add/Remove method, or some other form, we're not entirely sure.
@rjmholt noted that he's raised a similar suggestion in the past, and it was at that point rejected, but we agree that it may still be worth considering. Given that this logic operates in LanguagePrimitives there may be performance concerns associated with modifying the logic, so we'd prefer to see some more real-world examples of how this is impacting users before we commit to adding functionality here.
For the formatting enumeration issue itself, the performance impact is less stringent, so I think perhaps implementing an attribute to disable enumeration when an object hits the formatter might be considered, but we'd need need to see a prototype or at least a suggested API surface before we can make a clear call on that side of things.
I think at this point it might make sense to split this issue into two more focused issues?

Apparently the formatting system already supports specifying a type as not enumerable.  This doesn't control pipeline enumeration, but still it's one part of the puzzle that already works:
Set-Content ./DontEnumerateHashtable.format.ps1xml -Value '
<Configuration>
    <DefaultSettings>
        <EnumerableExpansions>
            <EnumerableExpansion>
                <EntrySelectedBy>
                    <TypeName>System.Collections.Hashtable</TypeName>
                </EntrySelectedBy>
                <Expand>CoreOnly</Expand>
            </EnumerableExpansion>
        </EnumerableExpansions>
    </DefaultSettings>
</Configuration>'

Update-FormatData -PrependPath ./DontEnumerateHashtable.format.ps1xml
@{ test = 'test' }
# Returns:
# System.Collections.Hashtable


resetModel doesn't work for nested forms

http://angular-formly.com/#/example/other/nested-formly-forms
if you hit the reset model button it doesn't reset the field that is inside the nested form.  Can we get an update to get this working?

cc @benoror. Could you look into this? It may be something we need to work out in formly.

Calling vm.options.resetModel(); doesn't seem to propagate to nested formly-form's.
However stuff like vm.form seem to be correctly inherited.

http://docs.angular-formly.com/docs/formly-form#section-resetmodel-and-updateinitialvalue

If I bind the options variable to the template now resetModel() resets the nested fields, although ignoring the outer scope fields, see example: http://jsbin.com/zaqeke/18/edit?html,js,output

@kentcdodds Do you think this is can be fixed in gormly itself (maybe related to https://github.com/formly-js/angular-formly/issues/465) ?
Or it might be related to the way angular handles nested forms, something along the lines of
https://github.com/angular/angular.js/pull/11023

Ok I created a failing test for this issue:
expected { innerField: 'zab' } to deeply equal { innerField: 'bar' }

I suspect this is related to nested keys handling https://github.com/formly-js/angular-formly/issues/426, any hint where should I look at?

Not sure who you're asking but I think the issue is that in

function resetModel()

Your looping over all the $scope.fields

_angularFix2['default'].forEach($scope.fields, function (field)

The problem is that the "fields" object that your looping over isn't the same bound object that you bind here

It's just an arbitrary object that looks at "fields", whereas for this perticular wrapper it's in options.data.fields, not options.fields.

@MCKRUZ you're right! :smile_cat:
Therefore instead of messing up with data a cleaner solution would be to use a wrapper around a fieldGroup, which is something already planned to implement in https://github.com/formly-js/angular-formly/issues/486 :tada: (although support for templateOptions should be also considered, in order to customize panel's title)
JSBin example: http://jsbin.com/zaqeke/20/edit?html,js,output
@kentcdodds What do you think? Using something already proven (like fieldGroup) sounds better that reinventing the wheel IMHO

I definitely want to see #486 implemented. Happily accepting PRs :-)

I believe I managed to fix this along with #486
do you mind checking out a working example at  http://jsbin.com/zaqeke/21/edit?html,js,output

Closed via https://github.com/formly-js/angular-formly/pull/529


Determine what to use to build Zone

cli, game boy
library, vamos
sdk
framework, zone

http://libgdx.com/dev/setup/
https://adoptium.net/
https://developer.android.com/studio/releases/platform-tools
jdk-17.0.1+12_adopt
C:\Program Files\Eclipse Adoptium\jdk-<IP_ADDRESS>-hotspot\bin
JAVA_HOME

http://libgdx.com/dev/setup/


fix: updated deps

:tada: This PR is included in version 2.1.17 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


User owns their homedir group

Description
Instead of root, the users primary group will be the group owner of their generated .ssh/* files.
Allows a user to specify their home directory's file permissions.
Issues Resolved
None
Check List

[x] All tests pass. See TESTING.md for details.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable.

Specefically I am looking for input on who should own a users home directory, and if a user group should be created across all OSs where the no_user_group key is false, or limited to OSs where a user group is typically generated.
Should the user's username group/default group own their homedir except when no_user_group is true? Should the directory be owned by the users primary group? Should It stay as root? In the OSL's cookbooks, when they were created by the user cookbook, in some cases our home directorys had the group sticky bit set, this would be bad if the wrong group is specefied. I think this is a case where the primary group should be the owner over the username group but I could see alternate cases here as well.

Released as: 7.1.0


Use x-forwarded-host

[X-Forwarded-Hosthttps://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Host is used by reverse proxy servers to name the origibal host.


Tomorrow Night Eighties style

Any chance a tomorrow night eighties style could be added? I promise to be good all year!
https://github.com/MozMorris/tomorrow-pygments/blob/master/styles/tomorrownighteighties.py

HTTPie makes all the styles included in Pygments automatically available. So please talk to Pygments maintainers to have Tomorrow Night Eighties included there.

Okay.
https://bitbucket.org/birkenfeld/pygments-main/issues/1253/tomorrow-night-eighties-style


Post method on token request not pasing parameters correctly

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
azure/msal-browser 2.19
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
@azure/msal-react 1.1.1
Description
I trying to authorize the app throw PKCE using   useMsalAuthentication("popup",request) from msal-react wrapper
On the step of getting the token on post  (https://login.microsoftonline.com/{TenantID}/oauth2/v2.0/token)
I got an error (from chrome tools {"error":"invalid_request","error_description":"AADSTS9002326: Cross-origin token redemption is permitted only for the 'Single-Page Application'... )
Comparing with another method that works on postman, appears to me that the post call generated by the msal react wrapper the parameters aren't properly encode or something like that. The postman can't recognize properly the parameters on the Body part of the message.
Error Message
{"error":"invalid_request","error_description":"AADSTS9002326: Cross-origin token redemption is permitted only for the 'Single-Page Application'... )
Msal Logs
No response
MSAL Configuration
const configuration: Configuration = {
    auth: {
        clientId: "client id",
        authority: "https://login.microsoftonline.com/{tetanId}",
        redirectUri: 'https://mysite/oauth2-redirect'},
    cache: {
        cacheLocation: "localStorage", // This configures where your cache will be stored
        storeAuthStateInCookie: false, // Set this to "true" if you are having issues on IE11 or Edge
        }
};

Relevant Code Snippets
import './App.css';

import React from "react";
import Menu_ from "./components/menu";

//import { AuthenticatedTemplate, UnauthenticatedTemplate } from "@azure/msal-react";
import { useIsAuthenticated,useMsalAuthentication  } from "@azure/msal-react";

function App() {

  const request = {scopes: ["api://apiID/user_impersonation"],
                   prompt: 'select_account'};
   const isAuthenticated = useIsAuthenticated();
   const {login, result, error} = useMsalAuthentication("popup",request);
   //const { user, logout, getToken, token, loginError } = useMsal();

  return (

      <Menu_/>
      <React.Fragment>

Anyone can see this paragraph.

            {isAuthenticated && (
At least one account is signed in!
)}
            {!isAuthenticated && (
No users are signed in!
)}
        </React.Fragment>

  );
}

export default App;

Reproduction Steps
from the SPA try to make a basic login
Expected Behavior
Recibe the access token
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Chrome
Regression
No response
Source
External (Customer)

The error you are describing here is related to the way the application has been registered in the portal. Please make sure the redirect URI is of type "SPA". You can read more by following the pre-requisites for the library.


Account - Change email address modal - Requesting

What
When requesting to change email address via my account page, when I enter an incorrect password, the new email address I've entered has reverted back to my original email address. This isn't obvious to a user and because of the validation tick feels like it's the new email address (a user wouldn't necessary re-check)
Retain the newly entered email address if possible.
Where

Step 1: Enter new email address into 'New email address' field but enter an incorrect password

Step 2: Select update email address and wait for the error message about invalid password to load. The email address in the field has now reverted to the original email address of the account but shows a validated sign as though it's the new email address

Yeah, I agree the field doesn't feel like it should be pre-filled. Not sure about whether or not it should remain filled after an unsuccessful form submission. I think I'm leaning toward it remaining filled with whatever you'd entered so that e.g. if you'd made a one letter typo that made your email address invalid, you could see the problem and fix it with a minimum of keystrokes, rather than having to take our word for it that you'd entered an invalid email address and enter the whole thing again.

Current email visible (but not editable):

Old email entered & not updated:

New email entered, but password incorrect. The behaviour would be the same as entering the old email, i.e. user clicks the 'update email' button, but the error message shows rather than the loading icon:

The loading icon should only show when the email has been updated and the right password has been written.


FAQ - update 'risk_update_24' entry for #971

Changelog:

"Zero-Rating Verpflichtungen" needed additional dash

Do we want to link to https://www.coronawarn.app/de/faq/#mobile_data_costs from this entry?
I think this would be quite sensefull.
I can also open a new issue for that afterwards. (:

@Ein-Tim I think it's a good idea. We are still discussing internally how much interlinking between entries we want, but it would be no problem here, I think.
We will leave the batch of FAQ edits open for feedback anyway, so no need to create an issue for it yet.

@Ein-Tim Solved!

@Ein-Tim @heinezen Thanks.


⚠ Bofrost.be has degraded performance

In 0716f73, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1332 ms

Resolved: Bofrost.be performance has improved in 3fb52be after 17 minutes.


Wallet crash while trying to restore.

Note: Wallet is created.
Steps to reproduce behavior:

Open wallet.
On login screen tap the button "Restore wallet or create new one".
On main screen tap "Restore wallet"button.
Type 12 seed phrase.
Create password to access your wallet.
On the recovery selection screen, use the back arrows to return to the login screen.
On login screen enter the password of the previously created wallet.
Expected: when you enter the password from the previously created wallet, we get access to the wallet.
Actual: the password doesn't fit. After closing the application, a wallet crash occurs. In wallet more impossible enter.

checked


Seasonal Address Overlap

Receiving an error "Date ranges for Seasonal Addresses cannot overlap." when in fact no seasonal addresses overlap.  The process to re-create is to:

Create a new Contact and let HEDA create the Administrative Account.
Create a new Address on the Account that is seasonal
Create a second new Address on the account that is seasonal

At this point no matter what the dates are on the second address the seasonality will not work.  The failure seems to be when the second seasonal address is added to the account.  The start times and end times always are seen to overlap.  Attached is a quick video.
This is HEDA 1.5 Installed 3/2/2016 12:17am
2016-03-14_17-57-13.mp4.zip

Thanks Pat - good find.  FWIW, for your use-case demonstrated (identical dates, y-o-y) you can just leave out the year completely, that will cause the behavior to be enforced based on the dates only, agnostic to the year.  Its actually why we use the separate fields instead of a date field value for it.

**lurch: add

Tracking W-009595

Included in beta release version 1.6 (Beta 16) and higher

Included in production release version 1.6


I can usually figure it out but I'm exhausted by this one..

I've backtracked so many times and I still have no idea why it doesn't run. I didn't even want to ask for help but I think I've turned my brain into that drug commercial where the guy smashes an egg with a frying pan. Definitely my brain on termux... and probably drugs.


Proposed example doesn't work with proposed grammar

The proposal lists an example use of a throw expression in a logical operation as:
this._id = value || throw new Error("Invalid value");
This doesn't work because || has higher precedence than throw in the grammar, so you'd need to write it like this:
this._id = value || (throw new Error("Invalid value"));
Which one is correct? The example in the proposal or the grammar in the proposal?

Hmm. I intended it for it to have the same precedence as yield does today, so you are correct that the example is wrong. However, I may need to revise the precedence depending on what the operator precedence of ?? is as I'd definitely like to be able to parse this._id = value ?? throw new Error() without needing parens.

It may be that it needs to be UnaryExpression to support || (or ??, though that proposal does not specify precedence yet).
Given:
a ? throw b ? c : d : e

Under the current proposal the above means:
a ? (throw (b ? c : d)) : e

However, changing to UnaryExpression would result in the following interpretation:
a ? ((throw b) ? c : d) : e


Added a setExtras() setter which overwrites the instantiation extras

Added a setExtras() setter which overwrites the instantiation extras and triggers a calendar re-render. Also added an entry in the README.md to reflect the new interface.

@yasenslavov These are very minor changes but it honors the style guide :D

Haha, minor indeed. I needed it for a project, so I thought why not PR it, people may need it as I did.

Apologies, I will push the changes via my other account in a separate PR, I will be disabling this one, I really hope that's fine.


Fix /tmp bind mount in devcontainer config

minor fix, the previous mount (host ~/.ssh into contaner /tmp) had no sense at all...

it would be nice to fix mount sources for windows users, as well, but (un)fortunately i'm not... :)


Externalized RDS config to a new resource

@doktoric

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2917/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/411/


Add support for SPV AMD extensions

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The code looked ok to me, but the bots are failing.

I'm looking at this.  Seems like a missing dependency on the way to ${spirv-tools_BINARY_DIR}/enum_string_mapping.inc.

It turns out there are missing dependencies, but that's not the problem here.
The problem here is that the enum/string mappings for vendor and other non-standard extensions are generated from a table inside utils/generate_grammar_tables.py.
The following diff fixes the issue:
--- a/utils/generate_grammar_tables.py
+++ b/utils/generate_grammar_tables.py
@@ -27,7 +27,16 @@ PYGEN_VARIABLE_PREFIX = 'pygen_variable'

 # Extensions to recognize, but which don't come from the SPIRV-V core grammar.
 NONSTANDARD_EXTENSIONS = [
+    # TODO(dneto): Vendor extension names should really be derived from the
+    # content of .json files.
     'SPV_AMD_gcn_shader',
+    'SPV_AMD_shader_ballot',
+    'SPV_AMD_shader_explicit_vertex_parameter',
+    'SPV_AMD_shader_trinary_minmax',
+    # The following don't have an extended instruction set grammar file.
+    'SPV_AMD_gpu_shader_half_float',
+    'SPV_AMD_texture_gather_bias_lod',
+    'SPV_AMD_gpu_shader_int16',
     # Validator would ignore type declaration unique check. Should only be used
     # for legacy autogenerated test files containing multiple instances of the
     # same type declaration, if fixing the test by other methods is too

I'll make a new PR to combine my fix.  Then I'll let the bots verify.  If all is good, I'll approve that PR and close this.

@dneto0 Thanks very much for your kind help. I do forget to change this file, which leads to the test failures. I think you patch is fine. So please merge it with mine and integrate them into master branch.

Merged via https://github.com/KhronosGroup/SPIRV-Tools/pull/682


Add people to metadata

This includes the work from #178 which had the following description:
This PR cleans up some of the code around displaying metadata. Specially, it adds a helper to turn an array of links in a content item into an array of appropriate  tags. It also removes #primary_organisation and just uses the #organisations method.
It also adds in people into the metadata list.
Relies upon https://github.com/alphagov/govuk-content-schemas/pull/36 being merged for the tests to pass.

Gonna clean this up a little.

I've added lots of comments here, but they really all relate to Ruby style.
The substance of this change is great, and very easy to follow. :+1:

Many thanks for those suggestions @evilstreak, they were really clear and made a lot of sense. I have updated the commit accordingly.


Fix loading box fade

Fixes #524

Codecov Report

Merging #791 (0a2dfe0) into master (82a73de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #791   +/-   ##
=======================================
  Coverage   99.42%   99.42%
=======================================
  Files         121      121
  Lines         866      866
  Branches      248      248
=======================================
  Hits          861      861
  Misses          5        5

Impacted Files
Coverage Δ

components/loading-box/src/index.js
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a73de...0a2dfe0. Read the comment docs.


Update Native Module docs when returning complex types

The following feedback regards this specific section of the native modules docs, copied here for posterity:
-=-=-=-
Methods that return more complex types (like std::string) can be implemented by returning void and accepting a bool and a ReactPromise:
    REACT_METHOD(GetString, L"getString");
    void GetString(bool error, React::ReactPromise<React::JSValue>&& result) noexcept
    {
      if (error) {
        result.Reject("Failure");
      } else {
        std::string text = DoSomething();
        result.Resolve(React::JSValue{ text });
      }
    }

This can be also tied in with C++/WinRT event handlers or IAsyncOperation like so:
    REACT_METHOD(GetString, L"getString");
    void GetString(bool error, React::ReactPromise<React::JSValue>&& result) noexcept
    {
      if (error) {
        result.Reject("Failure");
      } else {
        something.Completed([result] (const auto& status, const auto& operation) {
          // do error checking, e.g. status should be Completed
          std::wstring wtext{operation.GetResults()};
          result.Resolve(React::JSValue{ ConvertWideStringToUtf8String(text) });
        });
      }
    }

-=-=-=-

This contradicts existing documentation and samples around ReactPromise and parameters
We have built-in modules using returning Promise to string that don't accept extra booleans
Following the instructions will cause a compile error when we enable spec checking
What does "complex type" mean?

@NickGerleman - I had a couple of questions for the bullets above:

This contradicts existing documentation and samples around ReactPromise and parameters

Can you please include a pointer to this docs and params to make sure the future doc updates align?

We have built-in modules using returning Promise to string that don't accept extra booleans

Is it required not to accept extra booleans? Is there a consequence for doing so? Maybe we can take a built-in module and use it as an example - can you point towards one?

Following the instructions will cause a compile error when we enable spec checking

Is spec checking currently enabled?

What does "complex type" mean?

Good question. I suspect this actually means "non-JSValue supported types" but we should clarify.

Sounds like there are expectations around how this should work that don't seem to work - @asklar can you work with @vmoroz to validate what the "golden path" is?


Fix #4914 patternize filter overrides

Adding some convenience methods to the context class and updating our
code to use them.

Turns out we had 5 implementations of this pattern


CI broken on master

See https://github.com/poliastro/poliastro/pull/1027, https://github.com/poliastro/poliastro/pull/1098.

Several mypy errors due to the latest NumPy version actually shipping types:

2021-02-09T22:43:02.2980955Z =================================== FAILURES ===================================
2021-02-09T22:43:02.2981458Z _________________________________ test session _________________________________
2021-02-09T22:43:02.2981817Z mypy exited with status 1.
2021-02-09T22:43:02.2992268Z ____________________________ src/poliastro/ephem.py ____________________________
2021-02-09T22:43:02.2992738Z 60: error: No overload variant of "linspace" matches argument types "Any", "int"
2021-02-09T22:43:02.2993204Z 60: note: Possible overload variants:
2021-02-09T22:43:02.2999138Z 60: note:     def linspace(start: Union[Union[int, float, complex, number[Any], bool_], Sequence[Union[int, float, complex, number[Any], bool_]], ndarray, _SupportsArray, Sequence[Sequence[Any]]], stop: Union[Union[int, float, complex, number[Any], bool_], Sequence[Union[int, float, complex, number[Any], bool_]], ndarray, _SupportsArray, Sequence[Sequence[Any]]], num: SupportsIndex = ..., endpoint: bool = ..., retstep: Literal[False] = ..., dtype: Union[dtype[Any], None, type, _SupportsDType, str, Union[Tuple[Any, int], Tuple[Any, Union[int, Sequence[int]]], List[Any], _DTypeDict, Tuple[Any, Any]]] = ..., axis: SupportsIndex = ...) -> ndarray
2021-02-09T22:43:02.3003008Z 60: note:     def linspace(start: Union[Union[int, float, complex, number[Any], bool_], Sequence[Union[int, float, complex, number[Any], bool_]], ndarray, _SupportsArray, Sequence[Sequence[Any]]], stop: Union[Union[int, float, complex, number[Any], bool_], Sequence[Union[int, float, complex, number[Any], bool_]], ndarray, _SupportsArray, Sequence[Sequence[Any]]], num: SupportsIndex = ..., endpoint: bool = ..., retstep: Literal[True] = ..., dtype: Union[dtype[Any], None, type, _SupportsDType, str, Union[Tuple[Any, int], Tuple[Any, Union[int, Sequence[int]]], List[Any], _DTypeDict, Tuple[Any, Any]]] = ..., axis: SupportsIndex = ...) -> Tuple[ndarray, inexact[Any]]
2021-02-09T22:43:02.3006497Z ________________________ src/poliastro/core/elements.py ________________________
2021-02-09T22:43:02.3007349Z 8: error: Module 'numpy.core.umath' has no attribute 'cos'
2021-02-09T22:43:02.3007926Z 8: error: Module 'numpy.core.umath' has no attribute 'sin'
2021-02-09T22:43:02.3008553Z 8: error: Module 'numpy.core.umath' has no attribute 'sqrt'
2021-02-09T22:43:02.3008974Z ______________________ src/poliastro/czml/extract_czml.py ______________________
2021-02-09T22:43:02.3009512Z 550: error: Module has no attribute "float"; maybe "float_", "cfloat", or "float64"?
2021-02-09T22:43:02.3013421Z ________________________ src/poliastro/twobody/orbit.py ________________________
2021-02-09T22:43:02.3014132Z 1370: error: No overload variant of "linspace" matches argument types "Any", "Any"
2021-02-09T22:43:02.3014545Z 1370: note: Possible overload variants:
2021-02-09T22:43:02.3017068Z 1370: note:     def linspace(start: Union[Union[int, float, complex, number[Any], bool_], Sequence[Union[int, float, complex, number[Any], bool_]], ndarray, _SupportsArray, Sequence[Sequence[Any]]], stop: Union[Union[int, float, complex, number[Any], bool_], Sequence[Union[int, float, complex, number[Any], bool_]], ndarray, _SupportsArray, Sequence[Sequence[Any]]], num: SupportsIndex = ..., endpoint: bool = ..., retstep: Literal[False] = ..., dtype: Union[dtype[Any], None, type, _SupportsDType, str, Union[Tuple[Any, int], Tuple[Any, Union[int, Sequence[int]]], List[Any], _DTypeDict, Tuple[Any, Any]]] = ..., axis: SupportsIndex = ...) -> ndarray
2021-02-09T22:43:02.3034390Z 1370: note:     def linspace(start: Union[Union[int, float, complex, number[Any], bool_], Sequence[Union[int, float, complex, number[Any], bool_]], ndarray, _SupportsArray, Sequence[Sequence[Any]]], stop: Union[Union[int, float, complex, number[Any], bool_], Sequence[Union[int, float, complex, number[Any], bool_]], ndarray, _SupportsArray, Sequence[Sequence[Any]]], num: SupportsIndex = ..., endpoint: bool = ..., retstep: Literal[True] = ..., dtype: Union[dtype[Any], None, type, _SupportsDType, str, Union[Tuple[Any, int], Tuple[Any, Union[int, Sequence[int]]], List[Any], _DTypeDict, Tuple[Any, Any]]] = ..., axis: SupportsIndex = ...) -> Tuple[ndarray, inexact[Any]]

A weird build error:

2021-02-09T22:42:25.5782954Z check run-test: commands[3] | python -m build .
2021-02-09T22:42:28.6022625Z Found existing installation: setuptools 49.2.1
2021-02-09T22:42:28.6436801Z Uninstalling setuptools-49.2.1:
2021-02-09T22:42:28.6526758Z   Successfully uninstalled setuptools-49.2.1
...
2021-02-09T22:42:35.0995738Z Collecting astroquery>=0.3.9
2021-02-09T22:42:35.1074040Z   Downloading astroquery-0.4.1.tar.gz (6.5 MB)
2021-02-09T22:42:35.6701112Z     ERROR: Command errored out with exit status 1:
2021-02-09T22:42:35.6703383Z      command: /tmp/build-env-260ocgnr/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-gcgcam16/astroquery/setup.py'"'"'; __file__='"'"'/tmp/pip-install-gcgcam16/astroquery/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-3h_ptp3t
2021-02-09T22:42:35.6705974Z          cwd: /tmp/pip-install-gcgcam16/astroquery/
2021-02-09T22:42:35.6706521Z     Complete output (3 lines):
2021-02-09T22:42:35.6707238Z     Traceback (most recent call last):
2021-02-09T22:42:35.6707664Z       File "<string>", line 1, in <module>
2021-02-09T22:42:35.6708402Z     ModuleNotFoundError: No module named 'setuptools'

Hello, According to my understanding ...

The latter issue is related to this command being run & removing the setuptools library

Found existing installation: setuptools 49.2.1
Uninstalling setuptools-49.2.1:
  Successfully uninstalled setuptools-49.2.1

I tried reproducing the errors locally but it doesn't seem to be the case :(

For the former bug, Found out that the version being installed is numpy==1.20.1 so this may be the case of deprecated methods & functions usage in numpy 1.20 as compared to numpy 1.19

For the mypy error, there are issues with numpy==1.20.* but runs successfully with numpy==1.19.5, for instance.
For the build error, it seems that
2021-02-09T22:42:28.6022625Z Found existing installation: setuptools 49.2.1
2021-02-09T22:42:28.6436801Z Uninstalling setuptools-49.2.1:
2021-02-09T22:42:28.6526758Z   Successfully uninstalled setuptools-49.2.1

does uninstall already existing setuptools but doesn't install it after uninstalling, isn't it?

Check my previous comment 🙄

The build failure seems to be an upstream bug: https://github.com/pypa/build/issues/231
The NumPy thing should be easy to fix I think, making some adjustments to our code or adding # type: ignore where necessary. But I am not sure if other things can appear.

Oh I see, as you have suggested, the numpy errors do get resolved by either using # type: ignore or by making changes to the code whenever necessary. But yes, it seems that two additional deprecation warnings pop up when using the recent numpy versions (1.20.*) but those deprecations also seem to be concerned with upstreams.

This was partly addressed in #1101

And the second part was fixed in #1102


Turn Health Zeebe indicator off by default

This PR added the Zeebe Health indicator:
https://github.com/zeebe-io/spring-zeebe/pull/87
But it is enabled by default, causing the entire Spring Boot application to be marked as DOWN if the Zeebe Cluster configured cannot be reached.
The PR introduced a flag to turn it off.. so I propose to set the default to false and ask users to turn it on, if they have that required behaviour.

+1 if we add documentation on how to turn it on in the readme (as all "pure" workers will probably use that)

I close this for now as it did not come up in any real-life context yet


input field validation

why does a default state of a require input text field have a red border?
input:required:invalid {
    border-color: #de2900;
}

Having a form display to a person, who has yet to input information, and several input fields have a red border is not the experience we want.
Is there a way to only display the red border after an invalid value has been entered?
@nikolaswise @paulcpederson
cc @bstifle @snelsonux @HeathMeyette @asangma

This also bothers @nikolaswise and I. We are trying to use html5 validation for the inputs, but I think we may need to move to a JavaScript solution where we add the required class once the user has interacted with the input. It's not possible to use straight pseudo classes and select for an input that is required but hasn't been interacted with yet from CSS, see http://stackoverflow.com/questions/3617020/matching-an-empty-input-box-using-css

This is gone in the current version of the framework.


#lintfix properties/methods with trailing underscore must have @private

E:0221: Member "this.actionFlow_" must have @private JsDoc.

This should only be true when the Google coding convention is enabled


Disabling submit button

Hello,
First, thank you for this library, I'm playing with it and like it so far.
I have one question though, is it possible to disable a button (like the submit button) if the form is not valid?
Thanks

Ok I just found one solution and would like to put it here for code review if you have the time.
I created a custom component ButtonWidgetComponentand it looks like this:
import { Component } from '@angular/core';
import { ControlWidget } from 'angular2-schema-form/dist/widget';
import { OnInit, AfterViewInit } from '@angular/core/src/metadata/lifecycle_hooks';

@Component({
  selector: 'app-button',
  template: '<button [disabled]="disabled">Hola</button>'
})
export class ButtonWidgetComponent extends ControlWidget implements OnInit, AfterViewInit {
  disabled = false;

  ngOnInit(): void {
    this.formProperty.errorsChanges.subscribe((errors) => {
      this.disabled = errors != null && errors.length !== 0;
    });
  }

  ngAfterViewInit() { }
}

I need to extend ControlWidget if I want to have the reference to the formProperty.
One thing I don't really like is that I have to implement the ngAfterViewInit method so that the ControlWidget one doesn't get called because it fails since there is no control really.
What do you think about my solution? Is there a better/cleaner way of doing this?
Chers

It looks pretty good to me, I have no better suggestion.

Ok no, sorry for the spam, you can just extend the ButtonWidget, it has the formProperty too.
The code:
import { Component } from '@angular/core';
import { OnInit } from '@angular/core/src/metadata/lifecycle_hooks';
import { ButtonWidget } from 'angular2-schema-form';

@Component({
  selector: 'app-button',
  template: '<button [disabled]="disabled" (click)="button.action($event)">{{button.label}}</button>'
})
export class ButtonWidgetComponent extends ButtonWidget implements OnInit {
  disabled = false;

  ngOnInit(): void {
    this.formProperty.errorsChanges.subscribe((errors) => {
      this.disabled = errors != null && errors.length !== 0;
    });
  }
}


Hard coded "/" looks funny in windows.

Use path.join for a "pretty print" path cross platform.
Tested on node 0.6.4 on windows7. prints correctly.
There are no more string literals like this in packages.js file but there may be more throughout the codebase.

Can you make changes in the complete codebase and then send a pull request please?

I can't actually get the unit tests for jitsu running. (windows is still rough around the edges).
I'd rather not make larger changes without being able to properly test them. jitsu won't run stably enough on windows to do that.

2dd77bae


MM-18796 - Add POST /plugins/marketplace API to redux

Summary
Add POST /plugins/marketplace API to redux
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-18796

@iomodo * poke *

oo so fast :P

too slow :D


Redisable AbortedStream_ResetsAndDrainsRequest_RefusesFramesAfterCooldownExpires

https://github.com/aspnet/AspNetCore-Internal/issues/1879. Will investigate ASAP.

@anurse and I agreed to disable kestrel inmemory tests on Helix too.


Trouble with building "no ctypes_cstubs_internals.h"

Hello,
When i tried to build the library with dune build got the following error :
3 | (rule
14 |  (enabled_if
15 |   (<> %{ocaml-config:system} macosx))
....
28 |    %{ocaml_where}
29 |    -o
30 |    %{targets})))
orx_ml_types_stubgen.c:6:10: fatal error: ctypes_cstubs_internals.h: Aucun fichier ou dossier de ce type
    6 | #include "ctypes_cstubs_internals.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Do you any clues to solve this issue ?
Thank you for your time.

Hey @herrlockskun! I'm not sure what would lead to that error. Do you have both the ctypes and ctypes-foreign packages installed with opam in your current switch?

Yes i have installed these with opam.

Hey I have edited line 26 of the file src/types/stubgen/dune. I changed  %{ocaml_where}/../ctypes by     %{ocaml_where}/ctypes.
Maybe ctypes changed and that's why it wasn't building.
Anyway this allow me to build.
I worked with ocaml  4.13.1 on ubuntu 22.04.
Thank you for you work


Error: Not Found: https://hackclub.com/workshops/that_was_easy/sounds

https://sentry.io/hack-club/Frontend/issues/336282098/
Error: Not Found: https://hackclub.com/workshops/that_was_easy/sounds
  at callbacks (containers/NotFound/NotFound.js:31:34)
  at this (../node_modules/react-dom/lib/CallbackQueue.js:76)
  at wrapper (../node_modules/react-dom/lib/ReactReconcileTransaction.js:80)
  at this (../node_modules/react-dom/lib/Transaction.js:209)
  at method (../node_modules/react-dom/lib/Transaction.js:156)
...
(12 additional frame(s) were not displayed)

https://sentry.io/hack-club/Frontend/issues/334300475/

Added a temporary fix with https://github.com/hackclub/hackclub/commit/af8eff829f4ca433d80342919ae7230bdbdf4bdf


Updated Example Project?

Hello 👋🏻
I'm building a project to use the Put.io API Sonix it would be great it we could get an updated Example project on how to tackle integration since it feels a little vague at the moment being an amateur.
Thanks

hey @jakeround!
we've just added an example auth flow to the example project: https://github.com/putdotio/putio.swift/blob/master/Example/PutioAPI/ViewController.swift
could you please check it out and let us know if you have any questions?
thanks!


Melos Version is broken

https://melos.invertase.dev/commands/version 500

PR made in melos docsto fix this, the issue was that the example for the manual version flag was being read as a component.

Should be fixed now, thanks!


Demo with gh-pages

Hi! It would be a nice idea to submit a demo to see the working demo

you can find a demo here http://marcosmoura.com/angular-material-sidemenu/


Is it possible to add more static pages to the generated web? And possibly improve the aesthetics?

After successfully configuring my TypeScript projects to automatically generate the documentation sites with TypeDoc, and resulting sites like https://xpack.github.io/logger-ts/, I further pursued the idea and did the same for one of my C/C++ project, with Doxygen.
The site is not yet 100% ready, there are still some small issues, but the preliminary result looks like this:

The actual project URL is https://micro-os-plus.github.io/utils-lists-xpack/.
Personally I liked the result, to the point of deciding to migrate the entire documentation from the existing READMEs to the web site, as the static pages listed in the left sidebar.
A later improvement was the addition of the cards, as a nice solution for quick access to the most frequent pages.
I was wandering if now, when I have more experience with these things, perhaps I can achieve something similar with TypeDoc, and do a second iteration for my TypeScript projects to bring them in line with the C/C++ projects.
Any thoughts on this?

I think you can achieve something similar by defining a custom README via the TypeDoc options. From that file you should be able to link to other pages. However you won't be able to add custom links in the left column.

I think you are right. This plugin seems to do that: https://www.npmjs.com/package/@knodes/typedoc-plugin-pages

This issue really highlights a difficult design decision for TypeDoc. There are two competing options, and I really haven't decided which one makes more sense in the long run.

TypeDoc should provide the means to generate an entire site for documentation (this is what #1870 is after)
TypeDoc should focus on generating API documentation that can be provided as input to another site generation tool.

These aren't necessarily mutually exclusive options (except for time -- I'd like to pick one, and focus on that, rather than spend time half supporting each), and both have advantages. The first is closer to what TypeDoc has historically done, and is really nice for quickly getting set up with a basic documentation site. The second explicitly focuses on enabling integration with other site generation tools, which is advantageous for sites which need longer form content that doesn't fit well in a comment, integration with a playground for experimenting with a library, and many other reasons...
@tgreyuk has done an incredible job with typedoc-plugin-markdown which better supports the second use case. It is no accident that roughly 25% of TypeDoc users don't use the HTML output, and integrate the markdown produced by typedoc-plugin-markdown into some other tool instead.
That percentage is high enough that it sometimes makes me think that TypeDoc should just be generating markdown, or even just output JSON along with maintaining plugins for other site generation tools built by people that actually know what they're doing for keeping track of multiple versions, documentation in different languages, etc. (Maybe the current default theme gets extracted into a "static site" consumer of the JSON for simple projects?)

In case it helps, here is my recent experience.
Doxygen supported multiple static pages for long, but the poor aesthetics were a major factor in avoiding it as much as possible.
Now, after Doxygen got a nice theme, I'm migrating all my C/C++ projects from Jekyll + Doxygen to Doxygen only. It is much easier to maintain, and, why not recognise, it looks really nice and clean. And not only that a separate static site generator is no longer needed, but I also moved the project README, README-MAINTAINER and README-DEVELOPER from plain GitHub pages to Doxygen, and everything is in one place:

https://micro-os-plus.github.io/utils-lists-xpack/

Then I'm considering to move the GitHub READMEs to the web for the TypeScript projects too and started this thread, to know your opinion.
As for the idea to turn everything into markdown and let another static site generator consume it, I don't have any experience with it, but I'm a bit concerned on the resulting aestehics.
Also from my recent experience, I searched for a solution to get rid of Jekyll & Ruby & bundler & Co, which I used for all my sites when I migrated to GitHub. After a very long search, I opted for Docusaurus, which, although it has a funny name, and its own site may look a bit childish, can generate very nice looking sites.
However, the problem is that Docusaurus is part of the React ecosystem, and markdown is not exactly GitHub markdown, it is in fact MDX, a relative of JSX, a syntax which is compiled into JavaScript. And there is no pre-processing step with a text based substitution engine like Liquid, all automation required by pages with configurable content is done within the limits of JavaScript code. The result is that Jekyll sites need a lot of manual rework to convert them to a MDX compliant syntax.
Thus, if I'd have to prioritise the two options, I'd vote for the first one, and focus on improving the aesthetics, for example by inspiring from the new Doxygen theme; once this is done successfully, sure, generating JSON or markdown can be further considered, but integrating into some other tools might not be trivial, plus that there are so many, and supporting all of them is not realistic.
There are plenty of small to medium projects that would benefit from having the entire documentation generated with TypeDoc alone, and do not need to use a separate static site generator.

@Gerrit0 - Thanks for your ongoing investment in the project - it's very much appreciated.

There are two competing options, and I really haven't decided which one makes more sense in the long run.

TypeDoc should provide the means to generate an entire site for documentation
TypeDoc should focus on generating API documentation that can be provided as input to another site generation tool.

This is actually something I have been thinking about quite a lot recently as I am currently completely re-writing typedoc-plugin-markdown. Naturally from my point of view i'd be interested in exploring the second option, or at least proving a better mechanism to achieve this goal.
typedoc-plugin-markdown currently attempts to piggy-back onto TypeDocs Renderer class. This has sort of worked but has never felt quite 'correct' as the Renderer is very coupled to HTML output. Really i'd like to create a custom renderer without all the HTML noise (loading highlighters, jsx hooks, assets plugins etc).
I thought perhaps a  base renderer class could be exposed that is completely decoupled from the type of generated output, that consumers could extended with a bespoke HTMLRenderer, MarkdownRenderer or whatever. Perhaps a renderer could be defined by a plugin and then applied at the bootstrap stage, or the DefaultRenderer HTML renderer would be used. I guess in a similar vain as to how the Theme model currently works.
The other option would be to break from the TypeDoc renderer completely and just consume the converted project and write a completely custom renderer. I'd prefer the former as the plugin remains aligned to the Renderer Event model.
Anyway I am not too sure what the best way forward but thought I'd throw in my two cents to get a conversation going. I'd be very happy to contribute too.

Since this topic also discusses integration with another site generators, did anyone consider integration with Docusaurus?
For example how do you pass Admonitions, Tabs, and other such advanced features?

I'm not entirely sure how it's been a full year since I last looked at this, but... I'm starting to take steps towards decoupling the idea of output from the renderer. #2597 has an outline of my first cut at what that might look like.

There are plenty of small to medium projects that would benefit from having the entire documentation generated with TypeDoc alone, and do not need to use a separate static site generator.

Ultimately, I agree with this. Architecturally, it'll probably end up split into a module that's only very lightly coupled, and could easily be lifted out into its own package if desired.

Anyway I am not too sure what the best way forward but thought I'd throw in my two cents to get a conversation going. I'd be very happy to contribute too.

Thanks! I'd really appreciate your thoughts on #2597

Since this topic also discusses integration with another site generators, did anyone consider integration with Docusaurus?

This is the emit markdown with typedoc-plugin-markdown and plug it into another generator approach! docusaurus-plugin-typedoc

For example how do you pass Admonitions, Tabs, and other such advanced features?

TypeDoc doesn't! In 0.26.0 (this Friday), TypeDoc swiches to markdown-it for markdown parsing, so now all of this is completely configurable at the user level markdown-it-admon could be added to the markdown renderer to customize the HTML output using the markdownItLoader option. A (very) quick google didn't reveal a tabs equivalent, but there's no reason that one couldn't be written by someone who really wanted that feature. DigitalOcean has built quite a few which show the flexibility of this system

I'm closing this issue as I've split out the renderer rework into another issue and the two questions originally posed are:

More static pages - added in 0.26
Improve the aesthetics - entirely too broad to be generally actionable... TypeDoc supports a --customCss option for local tweaks, and the markdown included may include HTML by default.... if you really wanted to, you could do cards with something like the following in TypeDoc today:

        Example

Go here for all your example needs

        TypeDoc

Go here for all your documentation needs

Which renders as:


Endpoint for app download returns empty response body

I have deployed a Dataspace connector version 7.0.1 and followed the documentation section https://international-data-spaces-association.github.io/DataspaceConnector/CommunicationGuide/v6/IdsEcosystem/AppStore#ids-app-store
I have created the app store entity, query the app store and downloaded the app. But when I try to get the app that was downloaded using GET /api/appstores/{id}/apps it is not responding with the app just downloaded in the respond body.
This is the message obtained when downloading the app.
{
    "creationDate": "2022-03-09T15:20:31.515+0000",
    "modificationDate": "2022-03-09T15:30:33.609+0000",
    "remoteId": "https://drm-appstore.fit.fraunhofer.de/api/resources/00decfc5-3735-42ff-8e43-f4c9e40208f0",
    "remoteAddress": "https://drm-appstore.fit.fraunhofer.de/api/resources/00decfc5-3735-42ff-8e43-f4c9e40208f0",
    "docs": "App-related human-readable documentation.",
    "envVariables": "dbUser=sa;dbPasswd=passwd",
    "storageConfig": "-v /data",
    "supportedPolicies": [
        "PROVIDE_ACCESS"
    ],
    "keywords": [
        "processing",
        "data",
        "fit"
    ],
    "publisher": "https://fit.fraunhofer.de",
    "sovereign": "https://fit.fraunhofer.de",
    "language": "https://w3id.org/idsa/code/EN",
    "license": "https://www.apache.org/licenses/LICENSE-2.0",
    "endpointDocumentation": "https://app.com",
    "distributionService": "https://drm-appstore.fit.fraunhofer.de",
    "runtimeEnvironment": "docker",
    "additional": {
        "ids:byteSize": "905",
        "ids:checkSum": "229372384",
        "ids:mediaType": "",
        "ids:fileName": "",
        "ids:language": "https://w3id.org/idsa/code/EN"
    },
    "_links": {
        "self": {
            "href": "https://localhost:7085/api/apps/7a7ffada-4efb-45f3-aaf9-ecda70a67a60"
        },
        "endpoints": {
            "href": "https://localhost:7085/api/apps/7a7ffada-4efb-45f3-aaf9-ecda70a67a60/endpoints{?page,size}",
            "templated": true
        }
    }
}

When I try to obtain the app downloaded I get empty respond body.
GET https://localhost:7085/api/appstores/fe82d372-f978-4a49-a972-c9edd3b7d3ed/app
{
    "_embedded": {
        "apps": []
    },
    "_links": {
        "self": {
            "href": "https://localhost:7085/api/appstores/fe82d372-f978-4a49-a972-c9edd3b7d3ed/apps?page=0&size=30"
        }
    },
    "page": {
        "size": 30,
        "totalElements": 0,
        "totalPages": 0,
        "number": 0
    }
}

Also, when I try to get the appstore via GET https://localhost:7085/api/apps/7a7ffada-4efb-45f3-aaf9-ecda70a67a60/appstore
I obtain an empty respond body, where there is no information of the appstore that corresponds to that app.

Is this the expected behaviour for this swagger UI calls?
Thanks in advance

Will close since there is a newer issue regarding this problem. Please try using the UUID of the created appstore when downloading app instead of the url (if done so) https://github.com/International-Data-Spaces-Association/DataspaceConnector/issues/128