[security] allow for requesting access when denied on a dashboard view

@bkyryliuk I had to change the approach a bit to make this work. Also got rid of the request_access endpoint by adding support for &action=go to request_access_form

Nice approach with implementing the action on the endpoint, should I follow it in my following PRs ?

LGTM, once tests are fixed. Thanks @mistercrunch  !


wanted: re2-abseil

I am trying to port a personal project to use bzlmod and bazel-central-registry, and one annoyance I've found is that the version of re2 in this repo is from the main branch. The re2 project also maintains an abseil branch which adds a dependency on abseil and has additional features not present in main (for example one that I rely on a lot is that the abseil branch has ubiquitous support for std::string_view but main does not).
It seems reasonable to me that some people may want to use re2 without a dependency on abseil, but I'm wondering if there's a way to support the abseil branch since it adds a lot of useful functionality.

An easy way out is to have an re2-abseil module.

Versions 2023-06-02 and onwards have the Abseil dependency. (See https://groups.google.com/g/re2-dev/c/m1Hqx2cMkY0 for background.) This bug is obsolete. :)


Feat/pfe tools accordion

Small fixes for demo page that help show that everything is, in fact, working well.
Updating floats to grid, because floats aren't for page layout anymore and I don't wanna debug that
Disclosure demo was missing the attribute

The dynamic addition of a header and panel isn't working, couldn't figure out why:


open side menu trigger back to first index of page

I integrate this smart swiper component with existed react-native-side-menu project,
but I found some issue that seem weird, I post the same question here, if don't mind, will you have a look?
thanks for your time,
regards.

This is probably being caused by https://github.com/leecade/react-native-swiper/issues/82 (my guess, I haven't tested)


perf(query): remove extraneous sort after push downs

When an ascending sort by time is included after a push down, it is now
removed. The reason for this is because all of the push downs return
points already sorted so the sort is not needed.
This is most important for ReadGroup because the native flux version
of group() does not return the data sorted so it might seem to be
necessary to use a sort after the group if you still need sorted data.
The push down does return sorted data so we can now remove that unneeded
sort.

The reason for this is because all of the push downs return
points already sorted so the sort is not needed.

Is this really true of readGroup? This wasn't my understanding. Do we have a test that (e.g. a table test) that shows the rows are sorted by time?

I thought it was the case and was experimenting with this. A test failed because apparently that wasn't the case. Let me try to convert this to a draft and I'm thinking to just close it.


Class methods clickable or expose more information in docs

Is your feature request related to a problem? Please describe.
Class methods in the generated API documentation don't show all information nor are they clickable for seeing the full definition
For example, the get_netlist method for https://gdsfactory.github.io/gdsfactory/_autosummary/gdsfactory.Component.html only shows this much information

while the actual docstrings contain this much

Describe the solution you'd like
Make the methods clickable for full definition and maybe show more information like argument types.

I like what we do with kfactory documentations for the API, where have the entire source code for each class and function, but this is in mkdocs, which ius different from jupyter. https://gdsfactory.github.io/kfactory/reference/kfactory/kcell/#:~:text=information in um-,Source code in src/kfactory/,-kcell.py
-SkandanC

yes, i like it more too,
@HelgeGehring  has also been looking at this
https://myst-tools.org/docs/mystjs

i think maybe that adding the :recursive: directive, as shown in this SO post might fix it...

i tried that but didn't work

The problem here is that you just specify **kwargs as an argument but then use specific arguments (not only kwargs which is misleading itself already). If you want the full arguments, you need to write all the args to the definition of the function or put the definition below the kwargs entry of the doc string args

The problem here is that you just specify **kwargs as an argument but then use specific arguments (not only kwargs which is misleading itself already). If you want the full arguments, you need to write all the args to the definition of the function or put the definition below the kwargs entry of the doc string args

For most docstring collectors, they will look for args in the function definition and match to the docstring and not vice-versa afaik

I think the type information would also be useful. That is currently not visible for the ones where they are defined.

We have been experimenting with myst here
https://github.com/joamatab/gdsfactory
https://joamatab.github.io/gdsfactory
once we figure out how to better document the API we can consider it
@HelgeGehring

This issue still persists


Fix: Drop plasteel when deconstructing reinforced walls

About the PR
Changelog

:cl: Carbonhell

tweak: Deconstructing reinforced walls now leads to the creation of a reinforced girder instead of a normal one, and it drops 2 plasteel sheets.
tweak: Deconstructing reinforced girders now only requires cutting for 2 seconds and drops 2 plasteel sheets.

based first PR

As said on Discord, I've changed the reinforced wall decon graph to lead to the creation of a reinforced girder (now promoted to an entity) rather than a normal one. The full deconstruction still drops 4 plasteel sheets.


better plot of tensorboard for publication

this snapshot from tensorboard does not look nice enough to be put in a paper, we need to redraw them using better plot.
To regenerate this plot use run_pacs_diva_fbopt.sh

Reference https://github.com/marrlab/DomainLab/blob/fbopt/domainlab/utils/generate_fbopt_phase_portrait.py

For a laptop run, use run_fbopt_mnist.sh @agisga

I think corresponding prettier plots can be easily created by loading the tensorboard "event" files of the finished run (see https://github.com/marrlab/DomainLab/blob/fbopt/domainlab/utils/generate_fbopt_phase_portrait.py#L11). However, there are too many plots in the screenshot above to put in the paper. Which ones do we really need?

after commit commit 24620555aa574394982cac184207160439a8f6e1¬


OpenAPI document doesnt adhere to standard

Hey :),
the provided document at https://koina.wilhelmlab.org/openapi.yml is not OpenAPI 3.3 compatible. I have checked the content at https://editor.swagger.io/ and also tried to use the official openAPI generator, e.g. openapi-generator generate -g python -i https://koina.wilhelmlab.org/openapi.yml.
It seems that it needs at least a version within the info section but throws more warnings for other areas.

Thanks for spotting this! I think this was broken since the latest rework of the openapi generation script.
It's going to be fixed once ceb7e6d7ca99ed33d6a325bcd2b0594ffb96314b is merged.
In the meantime, here is the fixed version: openapi.yml.zip
This version doesn't show any errors with https://editor.swagger.io/.


[nuxt] [request error] [unhandled] [500] global is not defined

After following the installation guide and configuring Cloudflare, when I deploy my app and try to access it, I get a "500 This page is temporarily unavailable" error, and the logs show the following:

I tried many solutions, and the only one that fixed the problem was to add to nuxt.config.ts:
vite: {
 define: {
          global: {}
       }
   }

However, the issue with this solution, as mentioned in the Vite documentation, is:

My Config

Nuxt 3.12.4
compatibilityVersion: 4 (with the new folder structure)
wrangler 3.67.1
@nuxthub/core 0.7.1

Expected behavior
Deploy without needing this configuration.

Why and where do you use the global variable @dalisys ?

I am not using it anywhere.
I don't now if its relevant but I am using the unstyled @primevue/nuxt-module  with the preset aura. And in the index.js of the preset they are exporting global https://github.com/primefaces/primevue-tailwind/blob/main/presets/aura/index.js

Thanks for looking, it could be this yes.
I created the Debug mode recipe, could you try it and confirm the error comes from the Aura preset?

I'm not sure what happened, but everything seems to be working fine now. I also redeployed the old branches where I was experiencing the error, and now they're functioning correctly. Thanks for your help.

@Atinux  I'm experiencing the error again. After multiple attempts, here’s what I’ve observed:
Vsharp
I'm using the Vitue Vsharp plugin, which apparently triggers this error (I tested configurations both with and without vite: define: global in nuxt.config):

SupaBase
I removed Vsharp to fix the issue, but then the original error came back. I started rolling back changes and discovered that the error appeared after adding the Supabase module "@nuxtjs/supabase": "^1.3.5".
Also with vite: define: global in nuxt.config

PS: I retested vsharp without the Supabase module, and although the (vsharp) errors were still present, the app worked, and I was able to access it.


Deduplicate packages

Based on name only? And keep the one with the latest version? Seems like the most obvious choice.

No longer applicable since ditching libraries.io


Large Profit Bot -FP

Attacker: 0xcd5ae62ce3016f909ee6b923b7fed2e1cb396931
AD Alert: https://app.forta.network/alerts/0xe0cfa539b1180a6c39fad5471e921eb4c034c11f807e2cdd19f2fb8046acb286
Base bots:  Large Profit Bot and ChangeNow Funding alerted
Potential cause: base alert is FP ,  TXN  issue with price api.

Fixed by extending the list of called contracts that we filter out, by including Maestro Router.


.vscode/settings.json should not have changes (be "dirty") after running (initial) builds

Expected Behavior
No changed files after initial build
Actual Behavior
.vscode/settings.json has changes, maybe IDE-generated files should not be under source control

Version: 2ce7768f42d2aee2cee8c9cfe82db96deca99387
Platform: Ubuntu 20.04

maybe IDE-generated files should not be under source control

May I disagree with this? Enola's .vscode/settings.json contains a number of settings which are required to work on this project with VSC. There is no "other source" for such settings (that I know of) which "duplicates" these, or from which they could be "generated". As such, my view would be that this file does belong under source control. Would you still disagree, given this additional new information for context?

No changed files after initial build Actual Behavior .vscode/settings.json has changes,

Ah, but that is do agree with! 😄  Let's perhaps re-focus this issue on seeing if we can do anything to improve that - OK for you?
What is "dirty", what's the "diff" that you are seeing, after an "initial build"? (Are you running ./test.bash for that?)
PS: You technically ARE free to use another IDE than VSC, if you prefer!

Yes, the issue is the dirty state after build, not having the file under source control.
Here is the diff:
index 128cd16..90fb0a6 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -128,10 +128,16 @@
     "**/CVS": true,
     "**/.DS_Store": true,
     "**/Thumbs.db": true,
+    ".gitignore": true,
+    ".pytest_cache": true,
+    ".vscode/": true,
+    "**/__pycache__/": true,
+    "**/*.pyc": true,
+    "**/obj/": true,
     "**/.classpath": true,
-    "**/.factorypath": true,
     "**/.project": true,
     "**/.settings": true,
+    "**/.factorypath": true,
     "**/*.crswap": true,
     "**/eclipse-bin/": true,
     "**/eclipse-testbin/": true,

"**/.factorypath": true,

"**/.factorypath": true,

This ^^^ I've also noticed keeps "jumping around" and changing position - and I've no idea why! I think it may be different between different versions of... well, I'm not entirely sure what! Is it VSC itself that changes this? Or is one of the (many) code formatters that I have set up in this project perhaps doing this? E.g. slightly different local versions of... prettier - maybe? I would also like to fix that, and welcome investigations into how!

".gitignore": true,
".vscode/": true,

This is very curious, because it's ".vscode": false, here... which VSC version do you use? I have 1.86.2..

".pytest_cache": true,
"**/pycache/": true,
"**/*.pyc": true,
"**/obj/": true,

These I have never seen! You probably have a more fancy Python environment than me? Or some Python related VSC extensions? Would you like to raise a PR to add at least these 4 already? I'm happy to merge that ASAP! (Maybe let's already do just these 4, to start with; I think if you raise a PR for the other ones they will just keep getting changed again by future changes from me.)


Found some conflict markers at settings file.

With removing git conflict markers at settings file, I assumed that WIKI_* notations changed to PINAX_WIKI_* due to https://github.com/pinax/pinax-wiki.
Migration tested, but actually I found some more bugs in this team-wiki branch. Will keep working on it.

@theeluwin thanks for that!


Add mark-up images for Commands section and rephrased command descriptions

Added images with the relevant mark-ups for each command
Tried rephrasing the commands section to make it more readable and reader-centric (tell me what you guys think!)

closes #101

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #102   +/-   ##
=========================================
  Coverage     73.42%   73.42%
  Complexity      429      429
=========================================
  Files            75       75
  Lines          1268     1268
  Branches        130      130
=========================================
  Hits            931      931
  Misses          273      273
  Partials         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d7982...daf001c. Read the comment docs.


Bring back side navigation for standards/community

Discussed in Exec call
Page(s) where issue occurs
https://dev.tdwg.org/standards/
https://dev.tdwg.org/community/
https://dev.tdwg.org/about/
Issue description
Some pages (standards, community) have a lot of subpages (images). Although these are divided in sections (current standards, etc.) it takes a lot of scrolling to discover those sections. Proposal is to list the sections in the side menu. That would make it easier to discover and jump to certain sections in the page and it is consistent with using the side menu only for in-page navigation (e.g. https://dev.tdwg.org/about/constitution/#article-3-membership) and not for sub pages.
In the about page, the subpages are not divided in sections and it is a bit hard to discover these (below the fold). It might be good to list those pages higher.

Solved in https://github.com/tdwg/tdwg-theme/pull/20. See for example at https://dev.tdwg.org/standards/#draft-standard


Hugo inserts a paragraph tag inside of blockquote elements during markdown conversion

Hugo automatically inserts <p> tags within a <blockquote> element.  Paragraphs generally have default margins, which can cause vertical rhythm problems.
It's an easy fix with css, but I see the paragraph tag as unnecessary.

Assuming this is default md (Blackfriday markdown), could open a issue at
https://github.com/russross/blackfriday

Note/Update: This issue is marked as stale, and I may have said something earlier about "opening a thread on the discussion forum". Please don't.
If this is a bug and you can still reproduce this error on the latest release or the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.

There's a simple SCSS workaround.
figcaption {
  p {
    margin: 0;
  }
}


need to get merge cell information

how to know if a cell is merged and the row and col number of merge cell?
thanks

I also encountered this problem, I found that the library does not support reading mergeCells, I found that you can add a conditional judgment to this function, you can get all the merged cell information


Clock Widget

great job
Would be nice to have a clock widget for wall mounted iPad

Sounds like a good idea. I've already got an Angular clock component I can reuse too.

This has been added in the next release (currently in @test).

Looks Great. Thank you.
Would Great if Font size would be custom die clock an Weather Widget.
Is ist also possible to Add the HomeKit Secenes or is it restricted By Apple?


FeatureRequest: Allow Parameters from settings.json file for compile functions

Describe the issue
We as well as other partners use the settings from the settings.json in their build pipelines.
Instead of having to parse the settings ourselves, we could implement this option directly in the corresponding cmdlets as an alternate parameter set.
This should be implemented for Compile-AppInBcContainer and Compile-AppWithBcCompilerFolder.
Params whe can use from settings.json:

$assemblyProbingPaths
$GenerateCrossReferences
$rulesetFile
$enableExternalRulesets
$EnableCodeCop
$EnableAppSourceCop
$EnablePerTenantExtensionCop
$EnableUICop
$GenerateReportLayout

I could provide a pull request. But I would like to clarify first so that I don't have to do any unnecessary work.
What do you think about this?

Is this the settings from VS Code?
Would this typically be checked into the repository?

yes. just the casual setting.json file in .vscode directory.
we check it into git to provide every dev the same experience (same cops, ruleset and compile options).

Got it.
How would you determine who wins? Parameters or settings? What is your suggested implementation?
And what about AL-Go - would we support the same there?

on Implantation i see three possibilities:
1. Use two parameter sets
Compile-AppInBcContainer -EnableCodeCop -rulesetFile [String] [...]
Compile-AppInBcContainer -FromVsCodeSettings
If you use FromVsCodeSettings you can not define any of the other params. Take all from settings, or none.
--> not so flexible but very clear and easy. not breaking
2. Load Settings as default
Compile-AppInBcContainer -EnableCodeCop -rulesetFile [String] [...]
Look for settings file and use as default value. overwriting values is possible by using a parameter. PowerShell Parameter always wins.
--> very flexible but might break existing implementations
3. Use an Additional Parameter
Compile-AppInBcContainer -FromVsCodeSettings -EnableCodeCop -rulesetFile [String] [...]
Use the vscode settings but allow overwriting them with another parameter. PowerShell Parameter always wins.
--> very flexible and does not break anything. My Fav.
I think option two is not a real option :)
for the sake of completeness, it must also be said that we can only use default .vscode/settings.json here. i do not see any possibility for the support of multi-root workspace files.

And what about AL-Go - would we support the same there?

Hard to tell since i do not use AL-Go on daily base, just playing around...
as i understand it, different app types (and configurations) are much more separated from each other in al-go. we even have different templates for appsource apps and ptes.
also in al-go we already have config file driven settings.

3 would also be my favorite.
Two more questions.
How would you determine from where to load the vs code settings file?
Would the same implementation make sense in Compile-AppWithCompilerFolder? (containerless compilation)


EachWithBreak returns the original selection object instead of the current selection object

// EachWithBreak iterates over a Selection object, executing a function for each
// matched element. It is identical to Each except that it is possible to break
// out of the loop by returning false in the callback function. It returns the
// current Selection object.
func (s *Selection) EachWithBreak(f func(int, *Selection) bool) *Selection {
  for i, n := range s.Nodes {
    if !f(i, newSingleSelection(n, s.document)) {
      return s
    }
  }
  return s
}

As per the documentation, if I have a list of link objects for instance. EachWithBreak should return only the first matching link object. Not the original list. Am I missing something here?

Hello,
The return value of EachWithBreak is the same *Selection that was used to call the method, so yes it should return the original list. The break part is only to control how many times the function provided as argument to EachWithBreak will be called (i.e. if the original selection has 10 elements and you return false from the function passed as argument after 5 elements, it will not be called for the remaining 5, but the Selection returned from EachWithBreak will still be the original selection with 10 elements).
If you have a proposal/PR to clarify the documentation, I'd be happy to make it clearer (maybe specifying after current Selection object that this is the selection on which the method was called?).
Hope this helps!
Martin

Hello Martin,
I am trying to understand the intention behind this API. We have Each and EachWithBreak. The difference I see in both the cases is the efficiency aspect. While Each will go though every element whereas EachWithBreak returns early. In case if I am interested in a particular selection, the mechanisms to retrieve the selection I am interested in is the same regardless of which function I call. I am trying to understand perhaps there is a EachWithReturn API, that can return the selection I am interested in. I guess FilterFunction gives me what I am looking for at the moment.

Hey Ragunath,
The reason for the two functions is historical, Each came first but the lack of way to exit early was an oversight, which is why EachWithBreak was then added (see https://github.com/PuerkitoBio/goquery/issues/13). You're correct that the only difference is the efficiency in breaking out of the loop early.
For your intended use-case, where you want to use a function to control what gets selected, this is not the right approach. I do believe that FilterFunction (https://pkg.go.dev/github.com/PuerkitoBio/goquery#Selection.FilterFunction) is the right one for what you want to do.
Have fun!
Martin

Thank you very much for the explanation Martin :) FilterFunction is what I want.


Syntax highlight for align environments

I'm using tree-sitter with the latest Neovim nightly, and have run into the issue where text inside an align environment (between \begin{align*} and \end{align*} is not treated as math text. Here's a screenshot of some regular math text:

Here's a screenshot of math inside an align environment:

It doesn't show up in the screenshot, but the math inside the align environment occasionally switches to the default red because it doesn't have the highlight group attached. Thanks for your work on the project and let me know if there's anything else I need to add to this issue, or if this is the wrong place to put it!

Thanks for the report. Possibly this issue is placed inside the wrong repository. This repository was originally intended to replace the parser of texlab but in the end I did not end up replacing it so this grammar was reused to provide some benefit for the Neovim community. Note that this repository does not provide any highlighting queries. Instead, this grammar only provides the actual parser. So I think you are better up reporting this at nvim-treesitter as I am not in charge of the highlighting queries. From the parsing side, there should be no problem with distinguishing math environments. If there is, please feel free to open another issue, add a comment here or send me a PR.

Ah I see now, I'll raise an issue in the nvim-treesitter repository. Sorry about that!


Razor SDK test fixture exception causing tests to fail

Build: https://dev.azure.com/dnceng/public/_build/results?buildId=861315&view=results
Error:
xUnit.net Console Runner v2.4.1 (64-bit .NET 6.0.0-alpha.1.20507.4)
  Discovering: Microsoft.NET.Sdk.Razor.IntegrationTests
  Discovered:  Microsoft.NET.Sdk.Razor.IntegrationTests
  Starting:    Microsoft.NET.Sdk.Razor.IntegrationTests
    Build_Components_WithDesktopMSBuild_Works [SKIP]
      https://github.com/dotnet/aspnetcore/issues/24427
Unhandled exception. System.AggregateException: One or more errors occurred. (Shutting down the build server at pipe fc2929cb-edf8-44a6-9dfa-f30fc5662193 took longer than expected.
Output: .)
 ---> System.TimeoutException: Shutting down the build server at pipe fc2929cb-edf8-44a6-9dfa-f30fc5662193 took longer than expected.
Output: .
   at Microsoft.AspNetCore.Razor.Design.IntegrationTests.BuildServerTestFixtureBase.<>c__DisplayClass5_0.<Dispose>b__0() in /_/src/Razor/Microsoft.NET.Sdk.Razor/integrationtests/BuildServerTestFixtureBase.cs:line 36
   at System.Threading.CancellationToken.<>c.<.cctor>b__26_0(Object obj)
   at System.Threading.CancellationTokenSource.CallbackNode.<>c.<ExecuteCallback>b__9_0(Object s)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.CancellationTokenSource.CallbackNode.ExecuteCallback()
   at System.Threading.CancellationTokenSource.ExecuteCallbackHandlers(Boolean throwOnFirstException)
   --- End of inner exception stack trace ---
   at System.Threading.CancellationTokenSource.ExecuteCallbackHandlers(Boolean throwOnFirstException)
   at System.Threading.CancellationTokenSource.NotifyCancellation(Boolean throwOnFirstException)
   at System.Threading.CancellationTokenSource.<>c.<.cctor>b__56_0(Object obj)
   at System.Threading.TimerQueueTimer.CallCallback(Boolean isThreadPool)
   at System.Threading.TimerQueueTimer.Fire(Boolean isThreadPool)
   at System.Threading.TimerQueue.FireNextTimers()
   at System.Threading.TimerQueue.AppDomainTimerCallback(Int32 id)
=== COMMAND LINE ===
"F:\workspace\_work\1\s\.dotnet\dotnet.exe" exec --depsfile "F:\workspace\_work\1\s\artifacts\bin\Microsoft.NET.Sdk.Razor.IntegrationTests\Release\net5.0\Microsoft.NET.Sdk.Razor.IntegrationTests.deps.json" --runtimeconfig "F:\workspace\_work\1\s\artifacts\bin\Microsoft.NET.Sdk.Razor.IntegrationTests\Release\net5.0\Microsoft.NET.Sdk.Razor.IntegrationTests.runtimeconfig.json"  "F:\workspace\_work\1\s\.packages\xunit.runner.console/2.4.1/tools/netcoreapp2.0/xunit.console.dll" "F:\workspace\_work\1\s\artifacts\bin\Microsoft.NET.Sdk.Razor.IntegrationTests\Release\net5.0\Microsoft.NET.Sdk.Razor.IntegrationTests.dll" -noautoreporters -xml "F:\workspace\_work\1\s\artifacts\TestResults\Release\Microsoft.NET.Sdk.Razor.IntegrationTests_net5.0_x64.xml" -html "F:\workspace\_work\1\s\artifacts\TestResults\Release\Microsoft.NET.Sdk.Razor.IntegrationTests_net5.0_x64.html" -notrait "Quarantined=true"  -nocolor > "F:\workspace\_work\1\s\artifacts\log\Release\Microsoft.NET.Sdk.Razor.IntegrationTests_net5.0_x64.log" 2>&1

cc @ajaybhargavb @NTaylorMullen

@allisonchou this is like a SDK / razor-compiler bug that was already resolved. Perhaps your filter is picking up more things that it needs to?

@pranavkm Whoops, thanks for letting me know! I'm attempting to move over closed tooling issues per the tooling team's request. I think the original issue had the tooling label which is why it was moved over.


Update dialogflow.com (api.ai) response emulation to new format

Proposed changes:

api.ai now dialogflow.com. Change old format to new format
related issue #509
Status (please check what you already did):
[ ] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog

It seems the data object in https://github.com/RasaHQ/rasa_nlu/blob/master/rasa_nlu/emulators/dialogflow.py does not have necessary data for the format. Also, number of parameters for contexts and keys are not designed in the way to support dialogflow.com

What is the idea behind this PR?

To support dialogflow format, but format dependent on data, the data object is not sufficient for the response.

Did you by any chance forget to commit some files? The commits so far just fix some typos and rev the version, but they don't do anything to impact the Dialogflow emulation.
Also, is there a particular reason you can't just move up to the 0.10.x latest release? it has a lot of Dialogflow related improvements.


[Feature]: Eirini users can store LRP env vars in k8s secrets

Blockers/Dependencies
Background
Right now the process controller of cf-k8s is forced to load all env var values from a k8s secret and set them on the LRP as string key value pairs, which means the information that is potentially sensitive for the app can be exposed to whoever has permission to read LRPs on the cluster.
This defect is due to today's LRP definition and should be fixed so that users of Eirini can set env vars with values coming from Secrets, ConfigMaps, etc.
As a Eirini user
I want to be able to create LRPs with env values from secrets
So that I do not expose sensitive app information
Acceptance Criteria
GIVEN I have read/write permissions for LRPs in the cluster
WHEN I I apply the following yml
---
apiVersion: v1
kind: Secret
metadata:
  name: mysecret
type: Opaque
data:
  password: $(echo -n "s33msi4" | base64 -w0)
---
apiVersion: eirini.cloudfoundry.org/v1
kind: LRP
metadata:
  name: mylrp
  namespace: cf-workloads
spec:
  GUID: random-guid
  diskMB: 256
  image: eirini/dorini
  env:
  - foo: bar
  environment:
  - name: PASSWORD
    valueFrom:
      secretKeyRef:
        name: mysecret
        key: password
        optional: false

THEN I expect it to be accepted
AND I expect my app to have both the foo: bar and the password: s33msi4 env vars set
Dev Notes
In order to keep Eirini's contract backwards compatible we could introduce a new field for env vars of type []corev1.EnvVar next to the current one and deprecate the current one. The implementation would merge the values in the two env var fields thus not breaking old clients, but giving new clients the opportunity to hide their env values in secrets. Eventually after some time we would delete the deprecated field.

I think this has some overlap with https://github.com/cloudfoundry/cf-k8s-controllers/issues/796, this one might be better suited toward driving out those changes on the LRP Spec, but I wanted to link it here for reference as well.


Sig refactor

Did some refactoring on code pointed out by the SIG analysis
Focuses especially on removing duplicated code and shortening parameter lists
Unfortunately the result can only be checked when merged to develop

Some small comments, please take a look at them. Other than that great work refactoring our code!

Wow looks good!

Looks cool, and I've got nothing to comment. I'll merge.
Sidenote: that's a scary amount of commits.


New install removed a feature.

🧐 Have you read the FAQ and viewed similar issues?

[X] I have read the FAQ
[X] I have checked older issues, open and closed
[X] I did a clean install of SpotX as described in the FAQ

Сountry of your account
Ireland
What is your Spotify Plan?
Free
Do you have Spicetify installed?
Yes
ℹ Computer information
- Spotify: <IP_ADDRESS>1.ga588f749
- Windows: Windows 10 22H2 19045.3570
- PowerShell: 5.1.19041.3570

📝 Description
My lyrics weren't working for a little while so i decided to redownload SpotX (old-theme.bat is the only one i use) But once it reinstalled it got rid of the the cool song info and artist info that was on the right side.
It did fix the lyrics issue but I'm still annoyed it got rid of the side bar.
I had all of those on the old theme now theyre both gone? should have i just stuck without lyrics or is there now a toggleable option to add the right info bar back?
If so I'd like that alot thanks.
📸 Screenshots
screenshot showing the button for the side bar gone.

In the old theme, the right sidebar was never enabled by default, but you can activate it yourself using this instruction. You need to enable the experiment with the name enableRightSidebar

thx a bunch! i found some other cool options in there i liked aswell.


GRPC Method Descriptor Exposure

I'm working on some features in which we are attaching custom options to grpc methods. This can be exposed with something like this:
for method_proto in svc_desc_proto.method:
            method_name = method_proto.name
            method_desc: MethodDescriptor = service_descriptor.methods_by_name[method_name]

            options = method_desc.GetOptions()

I had started putting together a PR that exposed the MethodOptions output of the GetOptions call, but then I realized that maybe it just makes sense to put the MethodDescriptor in the MethodMetadata instead of pulling out individual fields. This would allow for advanced usage if needed, and not require upkeep.
And I guess while at it we could put the ServiceDescriptor somewhere as well. And probably the FieldDescriptors.
But the MethodDescriptor had the most obvious place to store it.
class MethodMetaData(NamedTuple):
    input_type: Any
    output_type: Any
    method_type: MethodType
    handler: Any
    descriptor: MethodDescriptor

metadata[method_name] = MethodMetaData(
    method_type=method_type,
    input_type=input_type,
    output_type=output_type,
    handler=handler,
    descriptor=method_desc
)

That does sound like it makes a good bit of sense - would perhaps allow making some of my own hamfisted attempts to open up access to fields information a bit more elegant.
If you wanted to put up a PR, that'd be much appreciated - for my own part, I'm going to be pretty swamped until after the holidays with my day to day.

You're very correct @artificial-aidan - the method descriptor exposure is pretty straight forward.
I'm going to work on a bit of a middle ground on the service and file descriptors, and add them to the base client in an accessible manner, at least for this pass.

Sounds good to me. Do you still want me to put something together for method descriptors?
I think a nice middle ground of providing the basic functionality, while exposing the descriptor protos is a good place to be. If you are leaving the simplicity that this library has created (which is awesome) then maybe you just use the raw protos.

I have got the method descriptors started, just need to write tests and get it up - should have some time to finish it up in the next day or two.

https://github.com/wesky93/grpc_requests/pull/56
Sorry that took a bit - this ought to expose the MethodDescriptors a bit more cleanly.
When it comes to the Service and File Descriptors - I think that could be accomplished to some degree without major changes by making the currently private _get_file_descriptor_by_symbol  method public and adding a convenience method around self._desc_pool.FindServiceByName(name) (and adding usage examples).
Though, rather than tacking that on to this PR - I figured I'd bounce it off of you to see if that idea would match your use case.

That looks great. And exposing the get_ methods for service and file descriptors would work fine. Allows for advanced usage if needed, and simple usage too.


Default handler processes updates out of order

At the end of the issue there is a very basic echo bot with debug enabled
When the bot is off, type in the chat messages:

1
2
3
4
5
6
7
8

Then launch the bot. The log (simplified):
[TGBOT] [DEBUG] request url: https://api.telegram.org/botFOO:BAR/getMe, payload: null
[TGBOT] [DEBUG] response from 'https://api.telegram.org/botFOO:BAR/getMe' with payload '{"ok":true,"result":{"id":botbotbot,"is_bot":true,...,"can_join_groups":true,"can_read_all_group_messages":false,"supports_inline_queries":false}}'
[TGBOT] [DEBUG] response from 'https://api.telegram.org/botFOO:BAR/getUpdates' with payload '{"ok":true,"result":[
{"update_id":180259658,"message":{"message_id":95,"from":{"...},"chat":{...},"date":1709399995,"text":"1"}},
{"update_id":180259659,"message":{"message_id":96,"from":{"...},"chat":{...},"date":1709399995,"text":"2"}},
{"update_id":180259660,"message":{"message_id":97,"from":{"...},"chat":{...},"date":1709399996,"text":"3"}},
{"update_id":180259661,"message":{"message_id":98,"from":{"...},"chat":{...},"date":1709399996,"text":"4"}},
{"update_id":180259662,"message":{"message_id":99,"from":{"...},"chat":{...},"date":1709399999,"text":"5"}},
{"update_id":180259663,"message":{"message_id":100,"from":{"...},"chat":{...},"date":1709400000,"text":"6"}},
{"update_id":180259664,"message":{"message_id":101,"from":{"...},"chat":{...},"date":1709400000,"text":"7"}},
{"update_id":180259665,"message":{"message_id":102,"from":{"...},"chat":{...},"date":1709400001,"text":"8"}}
]}'
INFO received message: text=8
INFO received message: text=4
INFO received message: text=5
INFO received message: text=7
INFO received message: text=1
INFO received message: text=6
INFO received message: text=2
INFO received message: text=3

TG server returns updates in order: messages in the array result are in the ascending order of update_id.
But the handler receives the messages in a random order.
Are there options to ensure the order of the updates in the handler?
The program:
package main

import (
	"context"
	"log/slog"
	"os"
	"os/signal"

	"github.com/go-telegram/bot"
	"github.com/go-telegram/bot/models"
)

func main() {
	ctx, cancel := signal.NotifyContext(context.Background(), os.Interrupt)
	defer cancel()

	opts := []bot.Option{
		bot.WithDefaultHandler(handler),
		bot.WithDebug(),
	}

	token, ok := os.LookupEnv("TG_BOT")
	if !ok {
		panic("Set TG_BOT environment variable")
	}
	b, err := bot.New(token, opts...)
	if nil != err {
		panic(err)
	}

	b.Start(ctx)
}

func handler(ctx context.Context, b *bot.Bot, update *models.Update) {
	if update == nil {
		slog.Info("nil update")
		return
	}
	if update.Message == nil {
		slog.Info("nil message")
	}
	slog.Info("received message:",
		"text", update.Message.Text,
	)
	b.SendMessage(ctx, &bot.SendMessageParams{
		ChatID: update.Message.Chat.ID,
		Text:   update.Message.Text,
	})
}

Indeed, now messages may arrive out of order due to implementation features (launching processing workers in goroutines). I'll look into what can be done soon

Worker pool removed in v1.2.0


Unable to override [requestHandler] as per angular documentation

Hi there,
I'm having a bit of difficulty defining a proxy to selectively fail a test on demand, in my E2E protractor testing...
Just for reference, this is how I instantiate the proxy module at the beginning of my tests...
beforeAll(function(){
    // Set initial window dimensions
    var width = 1280;
    var height = 780;
    browser.driver.manage().window().setSize(width, height);

    // Schedule to attach the mock $httpBackend when app starts
    browser.addMockModule('app', function () {
        angular.module('app').requires.push('ngMockE2E');
    });

    // Set global to allow using proxy throughout tests
    var proxy = global.proxy = new HttpBackend(browser);
    // Allow all GET requests before page loads to allow assets to load
    proxy.onLoad.when('GET', /.*/).passThrough();

    browser.get(browser.baseUrl).then(function(){
        browser.executeScript("localStorage.clear();");
        browser.executeScript("config.viewPath = 'views/';");
        browser.executeScript("config.version = 'v-<IP_ADDRESS>';");
        browser.executeScript("window.requestCount = 0;");
        browser.executeScript("window.responseCount = 0;");
        browser.executeScript("window.lastResponses = [];");

        // Returns the config object for use in testing
        browser.executeScript("return config").then(function(config){
            global.config = config;
        });

        proxy.onLoad.reset();
    });
});

According to the docs over at https://docs.angularjs.org/api/ngMockE2E/service/$httpBackend
...I should be able to do the following to allow me to ad-hoc 'override' an endpoint to allow me to force a failure, then reset that override to allow a normal API response in further tests...
        var httpHandler = proxy.whenPUT(/\/register$/);
        httpHandler.respond(500);

        helper.button.manualBarcode();
        helper.trigger.keypad(helper.setup.key());
        expect($('.pz-dialog.alert-dialog').isPresent()).toBeTruthy();

        httpHandler.passThrough();

I can't for the life of me get this to work. The initial httpHandler.respond(500) sets up the failure response perfectly fine but the second call to httpHandler.passThrough() has no effect. I expect it to effectively cancel the override. The test that runs after this block of code (that expects a 200 response from the API) is still getting the 500 error response from the proxy.
I've got to a point now where I just don't think it's possible without doing a full browser.get() for each test (which would be a massive pain due to the way we have the tests written, but alas, if it's the only way I might just have to go down that approach).
I know I can define a context for each test, then have the initial handler interpret the data and respond accordingly, but it doesn't seem that I can selectively passThrough() these requests and respond with fake data for others. It also isn't ideal as the initial setup needs to know about all the tests that follow; something which doesn't sit right with me.
Fundamentally, I just want to be able to selectively fail a HTTP request on-demand but having this proxy module work as required would be far more flexible. I've thought about creating a HTTP intercept service and injecting that at runtime and injecting a variable using browser.executeScript to change the behaviour when required but that's a last resort at the minute.
Any help would be highly appreciated!
Thanks

This directly relates to pull request #10 which was never completed.  The functionality you are trying to use was introduced into $httpBackend in 1.3.x which is after I wrote the proxy.  It never got rolled into the proxy.  I have my eye on it to implement this as a few people are asking for it now, but I don't see me getting to it till fall.  You are of course welcome to have a go at it yourself and send in a PR.  :)

Thanks for getting back to me so fast Ken. It would seem I have no other options so I'm definitely going to be working on that pull request today! I'm happy I now have a clear solution at least :) :+1:

@kbaltrinic Just FYI, it's quite obvious now that I didn't get round to doing that pull request. We decided to ditch protractor and keep our bespoke jasmine E2E tests instead. Should I close this or leave it open, as it's still a valid issue?

Please leave it open.  Thanks.


Close connection on network timeout.

WIth this PR go-redis closes connection on network timeout error except 2 cases:

PubSub.ReceiveTimeout()
Migrate, BLPop, BRPop, BRPopLPush when they are used with timeout > 0

But I still have to write tests...
Fixes https://github.com/go-redis/redis/issues/262 and https://github.com/go-redis/redis/issues/267
/cc @dim @FZambia

LGTM


Change Speak trait interface

Current
pub trait Speaker: Send + Sync {
    fn speak(&self, message: &str);
}

Proposed
pub trait Speaker: Send + Sync {
    async fn speak(&self, message: &str) -> Result<()>;
}

It should be async because it takes sometime to finish speaking.
And it might be failed.

Will be
pub trait Speaker {
    fn speak(&self, message: &str) -> Result<Wait>;
}

Because of #228


LR and False Positives Inquiry

Hello, I have two brief questions:

When training w/ this cfg I get lots of False Positives. Is there any recipe (besides from more data) to mitigate this? (i.e. changing loss weights?)
I was surprised to see that high learning rate was used for many epochs before reducing it with a scheduler (in most cfg's). Was this found empirically to work better? (i.e. start with lr=0.14)

This is a common problem when using Focal Loss and quality aware method(like GFL in NanoDet). One way to solve this is to use some target sampling method, but it is hightly relevant to your data. So I can not give a specific solution.
One reason to use such huge lr is because the batch size is very large here(192 per gpu). And I fond that using high learning rate to train a very long time before lr decay can improve the final mAP.

BTW, the hyperparameters in the config may not be the best because I do not have resources to search them. If anyone find a better setting on COCO, welcome PR.

@RangiLyu thanks for the reply! Final doubt:

I am a little confused, are gradients summed instead averaged across batches then? (when using sum generally lr must be adjusted based on batch size).

I will try different hyper-parameters for my custom dataset and try to alleviate (1). Thanks :)


Could not build module 'React'

#import <React/RCTRootView.h>       Could not build module 'React'

Have anyone ever met such a mistake

What is the problem?

Is there a solution

I'm encountering the same problem when trying to upgrade to RN 0.55.3 and after downgrading back to 0.53.3?


restructuring validation classes

The objective is to be able to chain validations after calling . perform();
This will require a complete restructuring of the validation helpers/builders/executors.
A recommended approach is to separate web browser and web element executors first... Then create a new webnative class that extends the native validations builder class.
Lastly have each executor return an object of the relevant validation builder...
It's an experiment and the pr will be merged with the issue closed as "won't do" if it fails.

experiment failed.


keyDown not working correctly in Windows

When I use keyDown in my script it does the same thing as the press function.  I've tested on Windows 8.1 and 7.  Has anyone else had this issue?
My example program that is not working correctly: https://github.com/rdugue/CheesePad/blob/master/CheesePad.py

Can confirm this issue exists in the current version

I have problems keyDown("shift")

Sorry for the delayed response.
This seems to be an issue with calling keybd_event on Windows. Hopefully this issue will go away when we move to SendInput(). I'm leaving this comment mostly as a note for myself to check this issue after that happens.


use pipx ?

Hi @davidmegginson
Thanks, as always, for this repo!
I just tried to install on a new laptop, with python 3.12.3 with

pip3 install iatisplit

and got:

error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.

    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.

    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.

I got around it by installing pipx and all is fine
Not sure if this is a me issue, or something to tweak in the README?
Thanks

Thanks for the report.  That's Debian warning you that you're trying to install the package globally instead of in a virtual environment (which Debian appears not to like).  The same issue, presumably, applies to any Python package you want to install from PyPi, but let me know if this one is behaving differently.


[Feature] [UI] Polish v9 UI and add theme support

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
No response
Use case
SkyWalking v9 booster UI supported most key features, right now, we have time to polish UI for making details better.
Then we could consider theme support theme framework and dark theme.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Some polish has been done, and we could continue this on 9.5.0.
Also, the theme is only considered to add in 9.5.0 too.


Ignore deno.lock file by default

Enter your suggestions in details:
Lume could ignore the deno.lock file by default.
It currently ignores deno.json, but not deno.lock.

Good idea. I just added it. Thanks!


[Navigation Material] Bottom sheet popped when navigating to a non-bottomsheet screen

Description
When navigating from bottom sheet A to bottom sheet B and then pressing the back button, bottom sheet A appears again which is expected. But when navigating from bottom sheet A to a full screen composable A and pressing the back button, bottom sheet A
does not appear.
Is this a bug? Also, is there a plan to support this library's functionality in jetpack navigation in the future?

This is intentional as per the documentation:

[these] destinations implement the FloatingWindow interface, indicating that they overlay other destinations on the back stack. As such, one or more FloatingWindow destinations can be present only on the top of the navigation back stack. Navigating to a destination that does not implement FloatingWindow automatically pops all FloatingWindow destinations off of the top of the stack. This ensures that the current destination is always fully visible above other destinations on the back stack.


zsh: fix notty issue

This fixes the issue https://github.com/NSLS-II/lightsource2-recipes/pull/451#issuecomment-429365550.
Related documentation:
A test for the function tcsetpgrp is turned on by default.  The test
needs to run the function to determine if the implementation is
usable. However, this can cause problems when configure is run without
a controlling terminal (eg. from cron).  To avoid this, use
--with-tcsetpgrp or --without-tcsetpgrp to tell configure whether the
function should be used.

This is already built locally and pushed to https://anaconda.org/lightsource2-tag/zsh/5.6.2/download/linux-64/zsh-5.6.2-0.tar.bz2.

OK, but we can still merge it here.

Absolutely! Thanks!

why are we packaging zsh?!

I see, weird that it depends on a shell...

Yep. http://swift-lang.github.io/swift-t/guide.html#_prerequisites (item 3) explains the requirements:

Ensure you have these third-party software development tools (APT packages are denoted in parentheses): SWIG (swig), ZSH (zsh), Apache Ant (ant), a Java Development Kit (default-jdk), Make (make), and GCC for C (gcc).

This script checks the deps are installed: https://github.com/swift-lang/swift-t/blob/e9579d01588e72656c7e8e7f07575b0f3da056ab/dev/build/check-tools.sh#L8.
And the main turbine script is written in zsh: https://github.com/swift-lang/swift-t/blob/e9579d01588e72656c7e8e7f07575b0f3da056ab/turbine/code/bin/turbine.in#L1


[5.4] Updating MakesHttpRequests

This is a fix for setting remote ip for http tests with the ->get($url, [ 'REMOTE_ADDR' => $custom_ip ])
see https://github.com/laravel/framework/issues/21350

Ugh, just saw this was to 5.4. Send this to 5.5.


Scatter bindings

Proposed changes
Implemented scatter_{op} bindings and added some trivial tests.
We still need to improve documentation by providing useful examples and detailed description of scatter operations. We also need more tests for more interesting scatter_{op} cases.
Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING document
[x] I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have updated the necessary documentation (if needed)

Looks great! Can't currently test it locally because of ml-explore#396 - so let's merge and perhaps iterate later

Let's hope this is resolved soon :)

@gboduljak feel free to merge whenever

@gboduljak feel free to merge whenever

I do not have permissions.

Ah right, apologies, merging now ;)


fix drag events to use current groupId if canChangeGroup is falsey

Issue Number
Bug Report in Row Renderer RFC Comments Section
Overview of PR

Update "dragmove" and "dragend" to use current group id if canChangeGroup is falsey.
Update readme to show npm run test instead of npm run jest due to package.json having a "test" command.
minor automatic white space fixes in the touched files.

@danielcruser thank you man. I will take a look at this

Any updates?


[Settings] Quick Accent character sets not sorted alphabetically

Microsoft PowerToys version
0.75.1
Installation method
GitHub, PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Settings
Steps to reproduce
The languages in the Quick Accent character set picker combobox aren't sorted alphabetically. It looks like there was an attempt to sort them, but some of them are in the wrong place.

AllCatalanCurrencyCroatianCzechDanishGaeilgeGaidhligDutchGreekEstonianFinnishFrenchGermanHebrewHungarianIcelandicItalianKurdishLithuanianMacedonianMaoriNorwegianPinyinPolishPortugueseRomanianSlovakSpanishSerbianSwedishTurkishWelsh
Character set picker languages
I understand that this will break anyway when localized and that it is really unimportant, but I think it would be better if it was sorted (at least in English).
I will work on this if someone says I should.
✔ Expected Behavior
Sorted
❌ Actual Behavior
Not sorted
Other Software
No response

Hello and thanks for your message. The crucial issue here is localization. "Greek", for example, is also known as "Ellenas", which is why it's at the beginning of "E". The best thing would be to sort a list after translation. The same applies to the names of the modules in the navigation menu.

Hello and thank you for the quick response. As I already mentioned, I know that this will be a problem after localization, but I don't think that anything is currently sorted after translation.
What I want to say is that for example the modules in the left pane are sorted alphabetically based on their English name, but they aren't sorted after localization (as already mentioned in #23763, #24577, #29323), but at least they are sorted by something that makes sense. The sorting of character sets in Quick Accent is a weird mix of English names and their language codes.
So the question is, should I leave this issue open until someone figures out a way to sort settings after localization or should I sort the character sets by their English names so that at least some users have them sorted?


download-latest: clean files

This streamlines getting a cached DB while still doing fuzzer development

We are deleting the misc files, not the .db files

I should also add this has bothered me for a while, but is causing more serious problems with people trying to get started

I think the correct solution is to move settings.sh files out of the database directory and then .gitignore the whole database directory?

It does seem a bit silly to have the settings.sh inside the database?

you are probably correct in that is the proper fix. But I'd rather not mess with that right now while we have people to work with

Filed https://github.com/SymbiFlow/prjxray/issues/421


Publish GitHub pages with explicit GitHub Action Steps

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Related to #2232
Description
This PR contains x3 Commits. You may want to review and merge #2459 and then #2460 separately, first? Or all together here - your call.
I'm intentionally raising small changes; this alone doesn't "do" all that much, yet; my plan is to gradually build upon this.
This step should, if it works, make the exact same website content that we currently have up on https://google.github.io/android-fhir/ re-appear.
What changes is that instead of GitHub "implicitly" building it for us, via its https://github.com/google/android-fhir/actions/workflows/pages/, we "control" it - which allows us hook our own documentation build steps into it.
All the magic GitHub Workflow Action YAML gobbledygook introduced here is inspired by https://github.com/enola-dev/enola/blob/ed2b1755b9dbf1a0668c86f80048d8bded94de4a/.github/workflows/ci.yaml#L131, where I learnt how to do this to create https://docs.enola.dev.
Type
Choose one: Builds
Checklist

[X] I have read and acknowledged the Code of conduct.
[X] I have read the Contributing page.
[X] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[X] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[ ] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[ ] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 Thank You for approval. I've now merged this with master, and resolved a related merge conflict.
I'll "self-merge" this, based on your approval, once the Kokoro build passed.

I've "verified" and found that this worked! See this run and note this (visually) still looks as before! Nice hit on 1st try... 🥇


rbdplugin: provision seperately from node controller

I'd like to deploy the rbdplugin a bit differently: instead of running it on each node, I want to handle provisioning in one pod that has external-provisioner+external-attacher+rbdplugin. Then rbdplugin can get deployed as NodeServer only on those nodes which are supposed to use it, or not at all (for example, when only testing provisioning).
This kind of deployment is currently possible, but could be simpler: the fix for #86 introduced a call to nsenter.NewNsenter that is executed before starting the gRPC service. It fails unless the provisioner pod has the /rootfs mount, which isn't actually needed. It would be better if the nsenter was done only when needed, for example when a NodeServer.PublishVolume call is invoked. The result could be cached for reuse in future calls.

@pohly The current deployment manifests do this exactly. The provisioners are deployed as a deployment with leader election and the nodeplugin is deployed on all nodes. (rbd manifests are provided as an example, cephfs manifests are similar).
I am closing this issue as the current state reflects required intent of this request.


Typo "Postgres servers"→""PostgreSQL servers""

https://docs.microsoft.com/en-us/azure/postgresql/flexible-server/concepts-backup-restore
https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/postgresql/flexible-server/concepts-backup-restore.md
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Reviewed it and approving from product side.

#sign-off

@kabharati: I'm sorry - only the author of this article, @sr-msft, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Enable mute / unmute mic button for live_provider: webrtc-card

I am not seeing the microphone unmute / mute button even when its enabled and two way audio works.
I am using this config:
...
live_provider: webrtc-card
    webrtc_card:
          url: webrtc_stream
          mode: webrtc
          media: microphone,audio,video
..
buttons:
        microphone:
          enabled: true

Describe the solution you'd like
I would like to see the microphone mute / unmute buttons
Describe alternatives you've considered
Using the webrtc card

Those lines:
  .microphoneStream=${this.microphoneStream}
  .microphoneConfig=${this.liveConfig.microphone}

are missing here:
https://github.com/dermotduffy/frigate-hass-card/blob/3b82dd6843d9a619d8e35151489dd90066a9b746/src/components/live/live.ts#L976

2-way audio only works with the go2rtc live provider, not the webrtc_card provider. Is there a reason you don't just use the go2rtc provider directly?

Those lines are missing here:

The webrtc card does not allow me to pass in a microphone stream, nor will it understand the frigate-card microphone config (i.e. those lines are missing intentionally).

Ok, nevermind then. I use the webrtc card, since I use the webrtc camera integration. In my setup I have go2rtc running in a seperate docker container. I am not using the instance from frigate. Off the top of my head I am not sure why I did this, but there were surly reasons.. :D. Thx, anyway!


Allow @RequestPart user-defined POJOs

I'm using Spring Cloud OpenFeign, and I have a use case where I need to send multiple files and user-defined POJOs as multipart/form-data, for example:
@PostMapping("/items")
SomeResponse uploadItems(@RequestPart List<SomePojo> items, @RequestPart List<MultipartFile> itemImages);

There was a recent fix in #258 that allowed the use of multiple @RequestParts, but it was only for MultipartFile and boxed primitive types. This PR builds on the abovementioned PR by:

Updating SpringEncoder to (optionally) use a new SpringPojoFormEncoder that comes with a PojoFormWriter, which serializes user-defined POJOs.
PojoFormWriter is abstract; developers can implement missing methods to serialize POJOs to any string format. In this PR, I implemented JsonPojoFormWriter, which uses Jackson.
Update FeignClientsConfiguration to optionally autowire a PojoFormWriter that will be used with SpringEncoder upon application start-up.
Update SpringMvcContract.processAnnotationsOnParameter to not expand parameters when the Content-Type is multipart/form-data. This is because a simple, single-field POJO like FeignClientTests.Hello would have been converted to a String.
Add unit tests.

I am not sure how best to fix the issue in processAnnotationsOnParameter and I don't have a good understand of what it does exactly. I'd like to know a better way to prevent expansion of simple POJOs like FeignClientTests.Hello.
I had earlier created a pull request on feign-form (OpenFeign/feign-form#89), but considering that the project is not regularly maintained, I decided to make a PR here instead.
I had also noticed that the recommended usage on feign-form's documentation is to create a new SpringFormEncoder(new SpringEncoder(...)), but because SpringEncoder itself has an internal instance of SpringFormEncoder, I thought it would be cleaner to make a PR here.

Thanks @spencergibb and @OlgaMaciaszek for reviewing and merging this PR!


Expand Signatures on IMessageRouter

Current signature is very C#-friendly. It'd be good to add an F#-friendly equivalent. Mostly, this means turning the Action inputs into F# functions. Also, the dynamic input should probably be something else (no idea what).

This has been attempted in PR #16


Create info command/class

Create info command/class, which analyzes a filled tiledb database and tells the user information about it.
Create test for info command that says:

That the information is being read correctly
That metadata stored in the tiledb database is correctly stored as read-only
That arguments passed to this command are correctly handled

info should have the following features

--json mode emits the content in JSON format
Normal stdout printing emits Markdown format to print to terminal
The resolution of the tdb
The bounds of the tdb in GeoJSON format
The extent of the tdb
A list of the files that have been inserted into the database, when they were inserted, how many points each file had, and what the geography of the file was that was
The srs of the tdb in PROJJSON and WKT2 formats
A list of the attribute slots available

Addressed in #27


add support for formality

The API knows a lot more settings than your addon can configure. It would be helpful to be able to configure the formality of the translated text, e.g.formality=less
$ curl https://api-free.deepl.com/v2/translate -d auth_key=xxx -d "text=Hello, how are you?" -d "target_lang=DE" -d "formality=less"

{"translations":[{"detected_source_language":"EN","text":"Hallo, wie geht es dir?"}]}

VS
$ curl https://api-free.deepl.com/v2/translate -d auth_key=xxx -d "text=Hello, how are you?" -d "target_lang=DE" -d "formality=more"

{"translations":[{"detected_source_language":"EN","text":"Hallo, wie geht es Ihnen?"}]}

Oh and split_sentences would be nice too ☺

@soerenuhrbach I'd like to tackle this, but am a bit lost on the UI. Where would you like to see these settings?
A) prompt the user like for source / target lang. This seems cumbersome because it will prompt for four things (worst case) on any translation.
B) set globally / per workspace in the settings, like the API key. This makes using the extension very snappy, but removes flexibility. However, I think each project will mostly use just one writing style. It would be possible to extend this later with path matching, e.g. "use formality=less in **/de.json, but formality=more in **/de_formal.json.".
I think B) is better. Which of those (or a totally different solution) do you prefer?

Hi @luto,
Glad to hear you want to contribute to the project. :)
I agree with you! Its fine the set the formality as setting, like the api key!

I will publish the new version soon!

Hi @nichtmax and @luto,
thanks for your participation. I just triggered a release for version 1.0.2 with the recent changes!
I hope you enjoy the extension. Happy Coding!


KAFKA-8264: decrease the record size for flaky test

This flaky test exists for a long time, and it happened more frequently recently. (also happened in my PR testing!! :(  ) In KAFKA-8264 and KAFKA-8460, it described the issue for this test is that

Timed out before consuming expected 2700 records. The number consumed was xxxx

I did some investigation. This test is to test:

we consume all partitions if fetch max bytes and max.partition.fetch.bytes are low.

And what it did, is to create 3 topics and 30 partitions for each. And then, iterate through all 90 partitions to send 30 records for each. Finally, verify the we can consume all the records successfully.
What the error message saying is that it cannot consume all the records in time (might be the busy system) So, we can actually decrease the record size to avoid it. I checked all the error messages we collected in KAFKA-8264 and KAFKA-8460, the failed cases can always consume at least 1440 up (total is 2700). So, I set the records half size of the original setting, it'll become 1350 records in total. It should make this test more stable.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@nepal @mjsax @abbccdda , could you review this PR to fix flaky test? Thanks.

I am not familiar with the details of this test and would leave it to others to review and merge. Maybe @omkreddy can help?

@omkreddy , could you help review this small PR? Thanks.

retest this please

retest this please

retest this please

hi @omkreddy , after running tests for 2 times, do you think we should run more tests for it? Thanks.

retest this please

@hachikuji , could you help review this small PR to fix flaky test? Thanks.

@hachikuji , please help review this small PR. Thanks.

hi @omkreddy , looks like @hachikuji is not available recently. Do you think we still need other people's comment? I think this change should be pretty straightforward and safe. Thanks.


[CT-3333] Remove usage of dbt.dataclass_schema in dbt/adapters

done in: https://github.com/dbt-labs/dbt-core/pull/8906/commits/469a9aca06037a46bcf607ea70b4305d72ee6dd1


Which type of TVs does support this adapter?

Max be extend Readme with thus Info?

Hmm... Sony Bravia... 😛 . I don't know because I don't have a Sony TV. I asked the tester and I'm waiting for the answer.

Ok. But as far as I know only Android TVs, isn't it?
2017-09-18 0:38 GMT+02:00 ldittmar<EMAIL_ADDRESS>
Hmm... Sony Bravia... 😛 . I don't know because I don't have a Sony TV. I
asked the tester and I'm waiting for the answer.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ldittmar81/ioBroker.sony-bravia/issues/1#issuecomment-330099065,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEXqgBHuad-NHea4663XgYPXu7-7WoC-ks5sjZ9jgaJpZM4PaTFO
.

Yes... only Android TV but I don't know if all Androids or only some.
On Mo., 18. Sep. 2017, 16:30 Bluefox<EMAIL_ADDRESS>wrote:

Ok. But as far as I know only Android TVs, isn't it?
2017-09-18 0:38 GMT+02:00 ldittmar<EMAIL_ADDRESS>
Hmm... Sony Bravia... 😛 . I don't know because I don't have a Sony TV. I
asked the tester and I'm waiting for the answer.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/ldittmar81/ioBroker.sony-bravia/issues/1#issuecomment-330099065
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AEXqgBHuad-NHea4663XgYPXu7-7WoC-ks5sjZ9jgaJpZM4PaTFO
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ldittmar81/ioBroker.sony-bravia/issues/1#issuecomment-330241667,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJHDvCm1MXgHgQ0M1v6FVuUvXg0JwMxdks5sjn6agaJpZM4PaTFO
.

Bezeichnung auf "Sony Bravia Android Smart-TV" geändert undals Beispiel den KD-65X8507C hinzugefügt.


python311Packages.sentry-sdk: 1.25.0 -> 1.25.1

Diff: https://github.com/getsentry/sentry-python/compare/refs/tags/1.25.0...1.25.1
Changelog: https://github.com/getsentry/sentry-python/blob/1.25.1/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 237299 run on x86_64-linux 1

2 packages marked as broken and skipped:

python310Packages.dalle-mini
python310Packages.dalle-mini.dist

63 packages built:

alerta-server
alerta-server.dist
cura
gns3-gui
gns3-gui.dist
gns3-server
gns3-server.dist
home-assistant-component-tests.sentry
ledfx
ledfx.dist
moodle-dl
moodle-dl.dist
mozphab
mozphab.dist
netbox
notus-scanner (python310Packages.notus-scanner)
notus-scanner.dist (python310Packages.notus-scanner.dist)
octoprint
octoprint.dist
openai-full
openai-full.dist
ospd-openvas
ospd-openvas.dist
peering-manager
python310Packages.django-rq
python310Packages.django-rq.dist
python310Packages.fastai
python310Packages.fastai.dist
python310Packages.k-diffusion
python310Packages.k-diffusion.dist
python310Packages.langchain
python310Packages.langchain.dist
python310Packages.sentry-sdk
python310Packages.sentry-sdk.dist
python310Packages.skrl
python310Packages.skrl.dist
python310Packages.spacy
python310Packages.spacy-loggers
python310Packages.spacy-loggers.dist
python310Packages.spacy-transformers
python310Packages.spacy-transformers.dist
python310Packages.spacy.dist
python310Packages.textacy
python310Packages.textacy.dist
python310Packages.textnets
python310Packages.textnets.dist
python310Packages.wagtail-localize
python310Packages.wagtail-localize.dist
python310Packages.wandb
python310Packages.wandb.dist
python311Packages.django-rq
python311Packages.django-rq.dist
python311Packages.notus-scanner
python311Packages.notus-scanner.dist
python311Packages.sentry-sdk
python311Packages.sentry-sdk.dist
python311Packages.wagtail-localize
python311Packages.wagtail-localize.dist
skytemple
skytemple.dist
tribler
tts
tts.dist

Result of nixpkgs-review pr 237299 run on x86_64-linux 1

2 packages marked as broken and skipped:

python310Packages.dalle-mini
python310Packages.dalle-mini.dist

63 packages built:

alerta-server
alerta-server.dist
cura
gns3-gui
gns3-gui.dist
gns3-server
gns3-server.dist
home-assistant-component-tests.sentry
ledfx
ledfx.dist
moodle-dl
moodle-dl.dist
mozphab
mozphab.dist
netbox
notus-scanner (python310Packages.notus-scanner)
notus-scanner.dist (python310Packages.notus-scanner.dist)
octoprint
octoprint.dist
openai-full
openai-full.dist
ospd-openvas
ospd-openvas.dist
peering-manager
python310Packages.django-rq
python310Packages.django-rq.dist
python310Packages.fastai
python310Packages.fastai.dist
python310Packages.k-diffusion
python310Packages.k-diffusion.dist
python310Packages.langchain
python310Packages.langchain.dist
python310Packages.sentry-sdk
python310Packages.sentry-sdk.dist
python310Packages.skrl
python310Packages.skrl.dist
python310Packages.spacy
python310Packages.spacy-loggers
python310Packages.spacy-loggers.dist
python310Packages.spacy-transformers
python310Packages.spacy-transformers.dist
python310Packages.spacy.dist
python310Packages.textacy
python310Packages.textacy.dist
python310Packages.textnets
python310Packages.textnets.dist
python310Packages.wagtail-localize
python310Packages.wagtail-localize.dist
python310Packages.wandb
python310Packages.wandb.dist
python311Packages.django-rq
python311Packages.django-rq.dist
python311Packages.notus-scanner
python311Packages.notus-scanner.dist
python311Packages.sentry-sdk
python311Packages.sentry-sdk.dist
python311Packages.wagtail-localize
python311Packages.wagtail-localize.dist
skytemple
skytemple.dist
tribler
tts
tts.dist

Nit about commit naming: python311Packages.wandb doesn't really evaluate
error: tensorboard-2.11.0 not supported for interpreter python3.11

I at least took the update to staging-next branch now, as it wouldn't even build without it due to updated python311.

Result of nixpkgs-review pr 237299 run on x86_64-linux 1

4 packages marked as broken and skipped:

netbox_3_3
peering-manager
python310Packages.dalle-mini
python310Packages.dalle-mini.dist

64 packages built:

alerta-server
alerta-server.dist
cura
gns3-gui
gns3-gui.dist
gns3-server
gns3-server.dist
home-assistant-component-tests.sentry
ledfx
ledfx.dist
moodle-dl
moodle-dl.dist
mozphab
mozphab.dist
netbox
notus-scanner (python310Packages.notus-scanner)
notus-scanner.dist (python310Packages.notus-scanner.dist)
octoprint
octoprint.dist
openai-full
openai-full.dist
ospd-openvas
ospd-openvas.dist
pentestgpt
pentestgpt.dist
python310Packages.django-rq
python310Packages.django-rq.dist
python310Packages.fastai
python310Packages.fastai.dist
python310Packages.k-diffusion
python310Packages.k-diffusion.dist
python310Packages.langchain
python310Packages.langchain.dist
python310Packages.sentry-sdk
python310Packages.sentry-sdk.dist
python310Packages.skrl
python310Packages.skrl.dist
python310Packages.spacy
python310Packages.spacy-loggers
python310Packages.spacy-loggers.dist
python310Packages.spacy-transformers
python310Packages.spacy-transformers.dist
python310Packages.spacy.dist
python310Packages.textacy
python310Packages.textacy.dist
python310Packages.textnets
python310Packages.textnets.dist
python310Packages.wagtail-localize
python310Packages.wagtail-localize.dist
python310Packages.wandb
python310Packages.wandb.dist
python311Packages.django-rq
python311Packages.django-rq.dist
python311Packages.notus-scanner
python311Packages.notus-scanner.dist
python311Packages.sentry-sdk
python311Packages.sentry-sdk.dist
python311Packages.wagtail-localize
python311Packages.wagtail-localize.dist
skytemple
skytemple.dist
tribler
tts
tts.dist


Local Docker Server Fixture

Continuing local docker server work. Also, keep the container running between test runs to save all the build time. All obj store tests pass with docker server. Shoutout to @carolineechen , this cluster takes a password and the password support worked like a charm.

Verified by:
$ pytest tests/test_obj_store.py -s -v
1 failed, 12 passed
FAILED tests/test_obj_store.py::test_stateful_generator[None] - types.RayTaskError(ModuleNotFoundError)
E           types.RayTaskError(ModuleNotFoundError): ray::EnvServlet.put_object() (pid=23754, ip=<IP_ADDRESS>, repr=<runhouse.servers.servlet.EnvServlet object at 0x7f3632062080>)
E             File "/opt/conda/lib/python3.10/site-packages/runhouse/servers/servlet.py", line 421, in put_object
E               obj = b64_unpickle(value)
E             File "/opt/conda/lib/python3.10/site-packages/runhouse/servers/http/http_utils.py", line 58, in b64_unpickle
E               return pickle.loads(codecs.decode(b64_pickled.encode(), "base64"))
E           ModuleNotFoundError: No module named 'tests.test_obj_store'


fix: support for react native 0.76

fixes: MBL-642
Changes

Added consistent objc annotations to all Swift methods used by Objective-C classes
Formatted Swift code using the same formatter as native iOS codebase
Formatted Objective-C code using online formatter for consistency

Tested On

[x] Current APN sample app (compiled and ran without errors)
[x] New sample app with React Native 0.76 (compiled and ran without errors)

@Shahroz16 The goal of this ticket was not to specifically include Turbo Modules but rather to ensure that our SDK compiles and runs with latest RN version (0.76) to unblock customers from using it. The PR you mentioned does address the issue, but the additional changes were added to ensure code consistency and to avoid any potential similar issues in the future.
Turbo Modules weren't expected to be covered under this ticket and may be addressed in a separate ticket/project, as implementing them might require more effort and a broader review of our SDK before going live with it.

@Shahroz16 The goal of this ticket was not to specifically include Turbo Modules but rather to ensure that our SDK compiles and runs with latest RN version (0.76) to unblock customers from using it. The PR you mentioned does address the issue, but the additional changes were added to ensure code consistency and to avoid any potential similar issues in the future.
Turbo Modules weren't expected to be covered under this ticket and may be addressed in a separate ticket/project, as implementing them might require more effort and a broader review of our SDK before going live with it.

I agree, the scope of this ticket didn't include Turbo, and that is not where my question is at either. Let me rephrase.
The obj-c annotation, that you added, they were in the code before too. But they were removed, because React native doesn't fully require explicit obj-c annotation as it moving towards "Turbo and bridgeless approach". So these annotations were removed in the data pipeline release.
The fix for the support for 0.76 requires parameter name changes done in the other PR, so the annotation doesn't provide any benefit here but actually takes us back. If you think these annotations are necessary for the compatibility with 0.76, then I am okay with adding them back, but if not then, we should probably not add them.
So, I would suggest probably, revert those, and keep the formating because we would need a fix PR for the release.

Thanks for sharing the details @Shahroz16. I wasn't fully aware of these changes in our SDK or the updates in React Native. I'm completely fine reverting the annotations, but I have a few questions I think we should consider before proceeding:

If I'm not mistaken, this change was introduced in RN 0.73. By reverting to simple @objc annotation, will the SDK still work for customers using older versions of React Native? If not, does this mean current v4 could already be causing issues for customers on versions older than 0.73? What do you think the SDK behavior would be in those cases?
Are these changes optional? If the annotations were updated purely because RN no longer require them now, perhaps we could consider keeping them to ensure compatibility with older versions of React Native? Unless reverting them still works seamlessly for older versions. If you believe it should work fine for older versions as well, I'm okay reverting this.

Let me know what you think so I can update PR accordingly!

@Shahroz16 Thanks for clarifying. I'll then go ahead and revert all the annotation changes.


Path not supported - Build failure IOS - reminder

Hello Eilon,
Got Stuck with that problem (see details on the original issue).
Have supplied you with the .csproj in the original issue.
Even tried to adapt your rezipe app to see where the problem comes from.
To say it short with that app including mudblazor produces no failure on the iphone.
It stops from developing my solution, since i have to know if that kind of thing is possible with
iphone.
Sorry that i opened a new issue but i do not know how to contact you or your team.
I am a Microsoft Partner but the only thing the partner portal offers is a web contact form.
And that github channel does not seem to have a discussion area.
Can you PLEASE help me to get my app running ?
Again under Android all if working perfectly!

Hi @whann0205 this project is currently an "experimental" project and not officially supported, so we have limited resources to offer. I will try to take a look at your issue today.


Set dataset starting point on X-axis

I need to have only one line with two different colors. I thought of using two different datasets, but they both start on the first label of X-axis.
It should be something like this:

Darker dataset should start on x-axis 3rd item (05-15)
But now I'm getting something like this:

Is there a way to set the dataset start point on X-axis?

if you are using the category scale, you can just use null for the first two values of the darker dataset and the last value of the first. Null values are not drawn by default

Hey @tannerlinsley, thanks for your quick answer!
Let me try that and get some feedback for you!

Just updating, using null values solve the issue.
@tannerlinsley thanks again for your help!

My pleasure
On Wed, May 4, 2016 at 11:36 AM fviazzi<EMAIL_ADDRESS>wrote:

Closed #2450 https://github.com/chartjs/Chart.js/issues/2450.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/chartjs/Chart.js/issues/2450#event-650450363


fix: coredump when table name contains '_' and prometheus is enabled

What problem does this PR solve?
After we enable prometheus(set "perf_counter_sink" to "prometheus"), pegasus ended up core dumped after restart.
We debuged the core, found out it was cored while analysing table name that contains "_".
This PR fixes the bug by changing the order of formating table names.
What is changed and how does it work?
Prometheus does not support some special charactor in metric name.
This original code first formated the table name by replacing special charactor to "" or "@".
Then, it try to parse gpid as prometheus labels by spliting the foramted name by ":" or "".
Unfortunately, tables that already contains "_" may results in unexpected group result, which eventually ended up core.
Checklist
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to be included in the release note

As this picture shows below, when core dumps it was trying to analyze metric naming replica_econ_replica_table_level_RPC_RRDB_RRDB_REMOVE_latency_ns_:impala_historical_profile_p999, where impala_historical_profile is a table we created earlier that contains multiple underscore.

As the code shown below on line 256, it tries to split metrics_name by : first, then split the last part by _ and put the splited tokens in an array that length is 3. Because this table already contains underscore, there are more than 3 tokens, so it got core dumped after at line 259 trying to set the fourth element of the array.

This patch fix it by switching these format order:
Firstly, it try to parse gpid as prometheus labels by spliting the foramted name by : or @.
Then, it  formated the table name by replacing special charactor to _ or "@".
In this order tables that contains _ can be parsed expectedly in the first step.


Make links optional

According to the specification links are optional, see:

http://jsonapi.org/format/#document-top-level
http://jsonapi.org/format/#document-resource-objects

I've encountered situations where I would like them not included. Saule autogenerates links and has AFAIK no option to disable them all or selectively. Would it make sense to introduce such a feature?
I have tried overriding as described by https://github.com/joukevandermaas/saule/wiki/Generating-links but even if returning null there will be an empty links objekt. Also, that way seem a bit overkill and I'm thinking an attribute could perhaps be created for this purpose instead.

Somewhat related to #121. I think it's pretty nice that Saule theoretically (after #121 is in) allows you to implement this attribute yourself, but I agree it could be a bit more ergonomic.
I imagine you want to disable links for a resource, not an endpoint. That implies the configuration should be in ApiResource.

I'm not certain it's always for ApiResource. In my mind I thought about excluding them for a specific relationship only. I'll see if I can think up a description on how it could be designed, unless you have a suggestion already? #121 does not seem to give any indication on how to make the properties optional.

I'm curious about your use-case for per-relationship link behavior. In any case, I would like for the configuration to occur on the ApiResource. Either on the resource itself, or when the relationship is defined. Examples:
// On relationship:

class PersonResource : ApiResource
{
  public PersonResource() {
    BelongsTo<CompanyResource>(nameof(Person.Job), "/job", LinkTypes.None);
  }
}

// On resource itself:

class PersonResource : ApiResource
{
  public PersonResource() {
    WithLinks(LinkTypes.None);
  }
}

The names of the methods/enum values are not really that important (they can change). The enum could  look something like this:
[Flags]
enum LinkTypes
{
  None = 0,
  Self = 1,
  Related = 2,
  RelatedCanonical = 4,
  All = 6
}

It would be respected by the UrlPathBuilders that come with Saule and the default value would be All.
This allows for easy configuration when the needs are simple, but it also allows custom UrlPathBuilders to have the same power as the built in ones.

In my initial case where I thought about this it's about the "self" link for a relationship object that will point to a path that is non-existent unless you implement it so I wanted to remove it since it was not relevant for use in this particular case. Also, the links property will take up considerable space if you are fetching a collection of entities with multiple relationships.
In any case I like your proposed API, will try to implement. :)


Added product and component roadmaps to kubeflow.md (#1594)

This change is

/ok-to-test
/assign @abhi-g


implement array_fill

implemented array_fill under #4153

not sure what arguments should i pass in auto_type.rs function call