Corruption read on term dictionaries in Lucene 9.9

Description
It seems that https://github.com/apache/lucene/pull/12699/ has inadvertantly broken reading term dictionaries created in Lucene 9.8<=.
To replicate a bug, one can index wikibigall with LuceneUtil & Lucene 9.8 & force-merge.
Then attempt to read the created index using a wildcard query:
    Path path = Paths.get("/data/local/lucene/indices/wikibigall.lucene-main.opt.Lucene90.dvfields.nd6.72652M/index");
    try (FSDirectory dir = FSDirectory.open(path);
        DirectoryReader reader = DirectoryReader.open(dir)) {
      IndexSearcher searcher = new IndexSearcher(reader);
      searcher.count(new WildcardQuery(new Term("body", "*fo*")));
    }

This will result in a trace similar to below:
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 3 out of bounds for length 3
	at org.apache.lucene.store.ByteArrayDataInput.readByte(ByteArrayDataInput.java:136)
	at org.apache.lucene.store.DataInput.readVInt(DataInput.java:110)
	at org.apache.lucene.store.ByteArrayDataInput.readVInt(ByteArrayDataInput.java:114)
	at org.apache.lucene.codecs.lucene90.blocktree.IntersectTermsEnumFrame.load(IntersectTermsEnumFrame.java:158)
	at org.apache.lucene.codecs.lucene90.blocktree.IntersectTermsEnumFrame.load(IntersectTermsEnumFrame.java:149)
	at org.apache.lucene.codecs.lucene90.blocktree.IntersectTermsEnum.pushFrame(IntersectTermsEnum.java:203)
	at org.apache.lucene.codecs.lucene90.blocktree.IntersectTermsEnum._next(IntersectTermsEnum.java:531)
	at org.apache.lucene.codecs.lucene90.blocktree.IntersectTermsEnum.next(IntersectTermsEnum.java:373)
	at org.apache.lucene.search.MultiTermQueryConstantScoreBlendedWrapper$1.rewriteInner(MultiTermQueryConstantScoreBlendedWrapper.java:111)
	at org.apache.lucene.search.AbstractMultiTermQueryConstantScoreWrapper$RewritingWeight.rewrite(AbstractMultiTermQueryConstantScoreWrapper.java:179)
	at org.apache.lucene.search.AbstractMultiTermQueryConstantScoreWrapper$RewritingWeight.bulkScorer(AbstractMultiTermQueryConstantScoreWrapper.java:220)
	at org.apache.lucene.search.LRUQueryCache$CachingWrapperWeight.bulkScorer(LRUQueryCache.java:930)
	at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:678)
	at org.apache.lucene.search.IndexSearcher.lambda$4(IndexSearcher.java:636)
	at org.apache.lucene.search.TaskExecutor$TaskGroup.lambda$0(TaskExecutor.java:118)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at org.apache.lucene.search.TaskExecutor$TaskGroup.invokeAll(TaskExecutor.java:153)
	at org.apache.lucene.search.TaskExecutor.invokeAll(TaskExecutor.java:76)
	at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:640)
	at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:607)
	at org.apache.lucene.search.IndexSearcher.count(IndexSearcher.java:423)
	at Corruption.main(Corruption.java:18)

We are currently not sure if this effects Lucene 9.9 created indices & reading via Lucene 9.9.
EDIT: This failure does NOT occur for indices created by 9.9 and read by 9.9.
NOTE: This also fails with just a prefix wildcard query. It seems to be all multi-term queries could be affected.
Will provide more example stack traces in issue comments.
Version and environment details
Lucene 9.9 reading Lucene 9.8 indices.

//cc @gf2121 && @mikemccand

Possibly related: https://github.com/apache/lucene/pull/12631
NOTE: the read corruption doesn't occur when reading from an index created in 9.9.

Git bisect has confirmed the read corruption occurs with: https://github.com/apache/lucene/pull/12699

I have a 9.8 index that reproduces the bug and ran a git bisect to figure out the first commit that fails, it pointed to #12699.

It's also curious that it's not happening w/ 9.9 created indices.  #12699 is about optimizing how we accumulate the long output while traversing (reading) the FST block tree terms index.

@mikemccand I have to use at a minimum: wikibig1m for it to replicate.
Couple of weird things I noticed in that optimization PR:

https://github.com/apache/lucene/pull/12699/files#diff-c30add12e4170e7905cdb0912fd869d447b5b1772d74c9fcaf0afe41cd58866aL200-R204 Now instead of giving a complete view of all appended arcs, there is this weird assumption that we only give one to floorDataReader
https://github.com/apache/lucene/pull/12699/files#diff-c30add12e4170e7905cdb0912fd869d447b5b1772d74c9fcaf0afe41cd58866aR200-L202. The frame outputPrefix is then set as the accumulation of all the arc outputs. I am not sure if this is relevant as for it to be important getFrame would have to return a frame already seen before, I am not sure if that is valid or not.

This makes me think that each frame should have its own OutputAccumulator But all this code seems incredibly subtle and opaque to me. Been staring at it for hours now :)

I think if a fix for this isn't found early next week, we should consider reverting it.
No user should upgrade to Lucene 9.9.0 with this bug.

I am travelling this weekend and unlikely to make much progress on this until early next week.
Maybe we just revert and release 9.9.1 now?

I opened #12899 to revert.

Thanks for all the discussion, and so sorry for introducing this bug!

https://github.com/apache/lucene/pull/12699/files#diff-c30add12e4170e7905cdb0912fd869d447b5b1772d74c9fcaf0afe41cd58866aL200-R204 Now instead of giving a complete view of all appended arcs, there is this weird assumption that we only give one to floorDataReader

This is actually one of the motivation of this PR. This works because we can not have two same fp encoded before floor data. I think this assumption works well for now, otherwise we will break this assert before meeting these exceptions.

https://github.com/apache/lucene/pull/12699/files#diff-c30add12e4170e7905cdb0912fd869d447b5b1772d74c9fcaf0afe41cd58866aR200-L202. The frame outputPrefix is then set as the accumulation of all the arc outputs. I am not sure if this is relevant as for it to be important getFrame would have to return a frame already seen before, I am not sure if that is valid or not.

This change is not actually intended. I suspect the bug is caused by this. I'll dig more to confirm.

Maybe we just revert and release 9.9.1 now?

+1 to revert it. Thanks @javanna for raising the revert PR!
BTW I wonder if we can only revert the part of IntersectTermsEnum and keep the change in SegmentTermsEnum, as it seems all exceptions are found in IntersectTermsEnum.

I've managed to repro (thanks @benwtrent!) and indeed the bug is happening because this assumption is (very, very rarely?) invalid:

This works because we can not have two same fp encoded before floor data. I think this assumption works well for now, otherwise we will break this assert before meeting these exceptions.

I see a case where a single byte prefix [0xfe] appears before the final arc that has the rest of the floor/frame data.  So the accumulator fails to put this 0xfe first and readVLong then fails.  This is on a 9.8.0 written index where the vLong is still LSB encoded.
I don't think this assumption is valid @gf2121?  Because that floor data first contains the file pointer of the on-disk block that this prefix points to (in MSB order as of 9.9, where lots of prefix sharing should happen), so, internal arcs before the final arc are in fact expected to output shared prefix bytes?
One thing I am curious about: it's possible that turning off suffix sharing (a separate change: #12722) sidesteps this bug and maybe that's why we are not seeing it with newly created (9.9.0) indices?  We could test this by backporting #12722 to 9.8.x SNAPSHOT build and re-build the wikibigall and see if the corruption still happens.  I'm not saying this is a workaround or anything but it'd make me more comfortable if we could understand why 9.9.0 written indices are not corrupt.  Alternatively, we could revert #12722 in 9.9.x, rebuild wikibigall, and see if the bug then happens?  I won't be able to try this likely for a day or two so if someone who can repro the bug could test this that would be awesome :). Thanks!

One thing I am curious about: it's possible that turning off suffix sharing (a separate change: #12722) sidesteps this bug and maybe that's why we are not seeing it with newly created (9.9.0) indices?

Doh!  Nevermind: 9.9.0 does NOT have this change (it is still sharing suffixes in the FST) -- so that is not the reason why a 9.9.0 written index seems to not show this corruption... still digging to understand why!

OK I turned back on the "old" way (inefficiently concatenating BytesRef as we visit arcs), and then diff'd old and new way when pushing the frame, then re-ran the *fo* WildcardQuery.  It uncovers a handful of cases where the accumulator is wrong:
IR: StandardDirectoryReader(segments_3:1256 _hc(9.8.1):C3978548:[diagnostics={mergeMaxNumSegments=1, timestamp=1702127242522, os.version=6.4.11-arch2-1, os=Linux, java.vendor=N/A, mergeFactor=4, java.runtime.version=21+35, os.arch=amd64, source=merge, lucene.version=9.8.1}]:[attributes={Lucene90StoredFieldsFormat.mode=BEST_SPEED}] :id=atd8lnurk6fe2ukuaobcgg5l7)
DIFF: oldWay=[9e c3 a8 1c] newWay=[c3 a8 1c]
DIFF: oldWay=[ae a7 ba 1f] newWay=[a7 ba 1f]
DIFF: oldWay=[a6 b3 97 2b] newWay=[b3 97 2b]
DIFF: oldWay=[82 c4 b2 4c] newWay=[c4 b2 4c]
DIFF: oldWay=[af 8b ba 4c 1 6b b7 4] newWay=[8b ba 4c 1 6b b7 4]
DIFF: oldWay=[c6 92 a7 5a] newWay=[92 a7 5a]
DIFF: oldWay=[e2 a0 db 66] newWay=[a0 db 66]
DIFF: oldWay=[a2 a2 ec 7c] newWay=[a2 ec 7c]
DIFF: oldWay=[9e e6 e0 82 1] newWay=[e6 e0 82 1]
DIFF: oldWay=[b6 aa e3 82 1] newWay=[aa e3 82 1]
DIFF: oldWay=[ee ab 92 8b 1] newWay=[ab 92 8b 1]
DIFF: oldWay=[f2 e2 f5 8b 1] newWay=[e2 f5 8b 1]
DIFF: oldWay=[e2 c3 e5 8d 1] newWay=[c3 e5 8d 1]
DIFF: oldWay=[82 d4 e0 8e 1] newWay=[d4 e0 8e 1]
count for body:"*fo*" is 2871441 vs slow=58963 total_term_count=5759190

Here's the new vs old differ patch I used:
12895-debug.patch

In each case it looks like the accumulator is missing a single prefix byte, which was set somewhere earlier in the arcs leading to the final arc.

I have to stop working on this for today ... earliest I can look again is tomorrow AM!  I'll try to mull in the background.  I still can't explain why 9.9 written indices sidestep the read-time bug.
We also need some certainty that this bug is not producing corrupt (somehow) 9.9.0 indices?  Note that SegmentTermsEnum is used during indexing when merging segments ... so if the bug is truly contained to IntersectTermsEnum, then we are fine (that is truly only search time).

OK I used 9.9.0 to write the wikibigall index, and confirmed that WildcardQuery *fo* runs and seems to produce the correct results, yet, there are a great many DIFF outputs, curiously.  Maybe the difference between old and new BytesRef floor date are somehow, sometimes, harmless?  So confused...

I don't think this assumption is valid @gf2121? Because that floor data first contains the file pointer of the on-disk block that this prefix points to (in MSB order as of 9.9, where lots of prefix sharing should happen), so, internal arcs before the final arc are in fact expected to output shared prefix bytes?

I thought the 'assumption' here means that we assert the floor data are all stored in the last arc. The whole FST output encoded as [ MSBVLong | floordata ]. We may share prefixes in MSBVLong, but we can not have two output having same MSBVLong so floordata will never be splitted into more than one arcs. Did i misunderstand something?
As @benwtrent pointed out, we should accumulate from the outputPrefix instead of arc.output. I raised https://github.com/apache/lucene/pull/12900 for this. This patch seems to fix the exception when searching WildcardQuery(new Term("body", "*fo*")) on Wikibig1m. I'll tryWikibigall as well.

and so sorry for introducing this bug!

BTW, please do not beat yourself up over this ;)
We of course try our best not to introduce bugs when making exciting optimizations, but, we are only human, this block tree code is insanely hairy / complex, especially IntersectTermsEnum (intersecting FST index + on-disk blocks with Automaton), and we have tests (which are inadequate now) that we improve every time we hit situations like this :)
Remember: in life and software, if you are not making mistakes, you are not trying hard enough!

OK I think I understand why we see the bug on 9.8.x indices but NOT 9.9.x. indices.  And I'm quite sure blast radius of the bug is contained solely to read-time, i.e. newly written 9.9.0 indices are not corrupt.  Though I'd really love to see some stronger testing -- I'm hoping a randomly written large enough index might reveal the bug.  I'll open a spinoff issue so we can create that.
Details:
We write FST with <term-prefix,byte[]> pairs, where term-prefix is the prefix of a set of terms sharing one on-disk block.  E.g. foo is prefix, and the N terms would be foobar, foobaz, ...  The start of that byte[] is a vLong, which is the absolute file pointer of the on-disk block shifted up by 2 bits, and 2 lower bits are two important flags: OUTPUT_FLAG_IS_FLOOR and OUTPUT_FLAG_HAS_TERMS.
Now, with 9.8.x, this is LSB encoded: those two flags are in the leading byte, not the last byte.  FST will share output byte prefixes when it can, and it does in fact happen (rarely!) that the LSB (6 bits + 2 bit flags) is the same across N term blocks.  It can happen if the last 6 bits of their block file pointers happen to be the same.  In this case that leading byte (or possibly, even more rarely, bytes) are not all on the last arc, and this PR loses that leading flag-containing byte/bytes in that case, and computes the wrong flag value for OUTPUT_FLAG_IS_FLOOR, then tries to readVInt when non was written --> exceptions at read time.
@gf2121 indeed the leading fp + 2-bit flags will never be the same across blocks, so this means even if FST is able to share leading prefix byte or two, it will never share that entire vLong: there must be at least one final (different) byte for readVLong to read.  And because vLong is self-delineating (each byte knows whether it is the last one by checking 8th bit is clear) losing a byte or two of its leading bytes won't break reading of the vLong, i.e., readVLong will indeed stop at the right byte (but of course produce the wrong value).
Importantly, IntersectTermsEnum does not use this encoded file pointer in the floorData!  It gets the file-pointer by traversing prior arcs in the FST and accumulating N incremental diffs contained in the on-disk block entries leading to that final floor block.  So IntersectTermsEnum just needs these two big flags.
In the 9.9.x written index, where we instead encode that leading long fp + 2 bits in MSB order, we share tons of prefixes of course (this is why FST got so much smaller), but, we will never share the entire thing, and that last byte contains our bit flags.  So at read-time we will always have the right (flag containing) byte.  The 9.9.x index is intact, and reading it is buggy yet buggy in a harmless way (throwing away bytes it does not try to use), and also because of how vLong is self delineating.  Fun!

I don't think this assumption is valid @gf2121? Because that floor data first contains the file pointer of the on-disk block that this prefix points to (in MSB order as of 9.9, where lots of prefix sharing should happen), so, internal arcs before the final arc are in fact expected to output shared prefix bytes?

I thought the 'assumption' here means that we assert the floor data are all stored in the last arc. The whole FST output encoded as [ MSBVLong | floordata ]. We may share prefixes in MSBVLong, but we can not have two output having same MSBVLong so floordata will never be splitted into more than one arcs. Did i misunderstand something?

Sorry @gf2121 -- that is indeed correct: except for the leading vLong-encoded "fp + 2 bits", the remainder of floor data will always be on the last arc.  But that leading vLong has those important flags that we were losing in the LSB encoded case.

As @benwtrent pointed out, we should accumulate from the outputPrefix instead of arc.output. I raised #12900 for this. This patch seems to fix the exception when searching WildcardQuery(new Term("body", "*fo*")) on Wikibig1m. I'll tryWikibigall as well.

+1 -- this is the right fix (to not lose any leading bytes for the FST's output in IntersectTermsEnum).  I'll review the PR and open followon issue to somehow expose the bug with stronger BWC test.

OK I opened #12901 to create a test -- can we do that, first, and then confirm #12900 indeed fixes it, then push the test, then push the fix?  I can try to work on creating that test case, but won't have much time until early tomorrow AM.  If anyone else wants to crack it, feel free!

and so sorry for introducing this bug!

I am with @mikemccand on this @gf2121!
The optimization proved valuable in benchmarks and all testing indicated it was good to go. Mistakes happen. I think the bigger thing is that our testing around this part of the code is lacking!
It's awesome to see that a solution was found so quickly!

Closing as all work has been done.


Send your termsrv.dll to project developer for support

During install of v1.6 on a Win10 Pro (build 10586), I got this:
[*] Installing...
[*] Terminal Services version: 10.0.10586.0
[-] This version of Terminal Services is not supported.
Send your termsrv.dll to project developer for support.
[+] TermService found (pid 1016).
I'm not sure where to submit the termsrv.dll file, so I'm attaching it here.
Well ... I'm trying to attach the file, but I seem to be having trouble with that.  :/

This version is already supported, run update.bat.

Wow.  I would've sworn I had downloaded the latest, and that's what I installed.  I ran update as you suggested, and now everything works just fine.  Thanks!
  My bad.)


Filter Versions Table

Feature Request
The versions table by default shows all tags and branches of a repo. The Broad HCA team would like for the table to show only tags, and on top of that, only specific tags.
Background
The https://github.com/HumanCellAtlas/skylab repo contains multiple pipelines/workflows. Even though GitHub releases/tags are across the whole repo, they create tags for specific workflows. For example, for the SmartSeq workflow in Dockstore, the would only want tags starting with "smartseq" to be displayed. The optimus workflow should only display tags starting with "optimus", etc.
Solution
Solution is up in the air. Probably some settings in  .dockstore.yml, e.g., something like this in Travis CI, although that would only handle not displaying branches, but doesn't filter tags.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Issue Number: DOCK-1059

Thanks Charles!

The versions table by default shows all tags and branches of a workflow. The Broad HCA team would like for the table to show only tags, and on top of that, only specific tags.

Am I correct that the versions table shows all tags and branches of a repo , not just of a workflow?
Not sure if it's relevant, but I'm representing pipelines for HCA, AoU, GATK, BRAIN initiative, and generally all data produced by the Broad Genomics Platform in this feature request. HCA is the best public example to link to in the background though :)

Am I correct that the versions table shows all tags and branches of a repo , not just of a workflow?

Yes, you're correct -- good catch! I  updated the description. Thanks.


PoC on OAM Kubernetes runtime from Crossplane

What: Look at how Open Application Model can benefit our capability concept in the DFDS self-service portal
Why: Being able to declare the need for certain "infrastructure components", e.g. application load balancers, via OAM traits will enable us to abstract the complexity of setting up essential infrastructure from the dev teams and place it with the operators where it belongs.

[ ] Read & discuss @ https://oam.dev/
[ ] Investigate OAM Kubernetes runtime @ https://github.com/crossplane/oam-kubernetes-runtime
[ ] Create an example OAM application
[ ] Talk with architects about how OAM fits into our Composable Architecture strategy

Closing as usecase is not imminently active.


log what ips we got and make defer pickup when no ips are found

Reason for Change:

We had an incident where it seems like nmagent returned an empty list of ip address.
Improve logging so we know next time
Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests

Notes:

/azp run

/azp run

/azp run

/azp run


M365 Business

I believe this article should be updated to include M365 "Business" licenses, but if for some reason this isn't the case, that should be called out as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd18b4c7-1c71-916d-cb5c-8322903e8ed5
Version Independent ID: 7b4c1663-1b1a-2952-7bf8-b0cb724013af
Content: Windows 10 Subscription Activation
Content Source: windows/deployment/windows-10-enterprise-subscription-activation.md
Product: w10
Technology: windows
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

@officedocsbot assign @e0i

@greg-lindsay Would you be able to provide further directions for this issue in coming up with content changes? Thank you.

@greg-lindsay We need authoritative input regarding whether license should be added to the document to move forward with this issue. Thanks.

@Mike-Crowley The issue is still under investigation and you will be followed up with updates. Thanks.

We are discussing this request internally and will make the necessary updates when the issue is resolved. I'm closing this issue for now.

Sorry, it appeared there was an MSFT logo on the original poster's avatar and his name was the same as an MSFT employee so I mistakenly thought I was forwarding the issue internally.
M365 Business license activates the Windows Business subscription, which is different from the Windows Enterprise subscription. But this license is not always purchased standalone so it gets complicated. I will try to follow up with licensing experts to get more details about this scenario if I can.

Sorry, it appeared there was an MSFT logo on the original poster's avatar and his name was the same as an MSFT employee so I mistakenly thought I was forwarding the issue internally.
M365 Business license activates the Windows Business subscription, which is different from the Windows Enterprise subscription. But this license is not always purchased standalone so it gets complicated. I will try to follow up with licensing experts to get more details about this scenario if I can.

Greg, any update here? Its nuts that M365 Business is nearly a year old and we don't have documentation on how the Win10 part works. We've got technical support, for example, telling us that to use the license we must upgrade from windows 7 and that Win10 will never activate properly, if a hard drive fails (unless you reinstall Win7). I'm hoping this isn't correct, but there isn't any documentation...


Cannot make ice cubes

Good morning,
I have encountered a problem. there is no recipe for making ice cubes. I have searched for a while but found no solution to this error. I even checked the source and there is something you call "slush cauldron" I thought normal cauldron will be enough but it seems to never work. Can you please tell me what I am doing wrong, eventually say a way how to obtain this item?
thank you in advance
Kate

Thanks for asking; I should have added an explanation in the description.
Right clicking a cauldron, containing water, with ice, makes slush. You can then right click the cauldron to take out ice cubes or put them back in.

Hi!
It still has the problem. I tried this thing you have written, even saw it in some comment section however it doesnt work.
Fill cauldron with water is no problem, but right clicking it with ice only places the ice block on the top of it. It doesnt create slush. either it placed on top of the cauldron or from the side.
I am using the Medieval minecraft fabric 1.18 version 12v for better context

Fixed in the next update


[CI]  criu installation failure block the CI procedure

Ⅰ. Issue Description
Recently we met logs of CI failure is caused by criu installation failure. This blocks a lot when checking pull request's CI status.
hack/install/install_criu.sh
>>>> install criu <<<<
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

Ⅱ. Describe what happened
criu installation failure block the CI procedure
Ⅲ. Describe what you expected to happen
other issue unrelated to code will not block the code review and merge.
Ⅳ. How to reproduce it (as minimally and precisely as possible)
none
Ⅴ. Anything else we need to know?
none
Ⅵ. Environment:

pouch version (use pouch version):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

close by #2323

Actually not fixed, we just add log to locate the step ?

Actually not fixed, we just add log to locate the step ?
add bash -x for install criu? how do you think?

Maybe we can add it if the problem appear next time，then we can know where is hang.


Adding a Chrome Extension

Want to add a chrome extension which will be able to detect phishing site

You have already created one issue on it @amitkroutthedev


Disable some builds to make -next green

The commits should be self explanatory, let me know if there are any issues!

Thanks for the review!


[ Feature ] Please add an option to change the color of the "VS" between the team names.

I love the Teamnames feature etc. But the Yellow "VS" stands out way to much ):
Can we have a feature option like with the team name color select to change the "VS" color?
I'd like to know where the color is described in the files if you can't add an option so I can change it manually there.
Thank you for this weird request but it's just something that I would like to have on this.

You can already do this with themes – directly modifying module files is not recommended since you will lose your changes when updating modules.
There are a few ways to do this:

The yellow is the "accent color" of the default theme, it's also used in other pages (e.g., End of Game screens). You can change the accent color of the theme everywhere by creating a custom theme and modifying the --accent-color value.

You can individually customize the color of the "VS" by adding custom CSS to your theme:
To change the color in both the talk and the break overlay, add this to your theme (with whatever color code you desire):

.vs {
  color: #123456;
}

If you want different colors for the overlays or only one to change, you can change them individually by adding:
.module-teams-talk-gfx .vs {
  color: #123456;
}

.module-teams-pause-gfx .vs {
  color: #ABCDEF;
}

The steps to create custom themes are documented in the wiki.


Tox: Don't install pytest-cov in the non-codecov testenv

Codecov Report

Merging #339 (8eaf2ba) into master (3f637db) will decrease coverage by 89.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #339       +/-   ##
==========================================
- Coverage   89.74%   0.00%   -89.75%
==========================================
  Files           5       5
  Lines        1063    1063
==========================================
- Hits          954       0      -954
- Misses        109    1063      +954

Impacted Files
Coverage Δ

toml/ordered.py
0.00% <0.00%> (-100.00%)
:arrow_down:

toml/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

toml/decoder.py
0.00% <0.00%> (-89.80%)
:arrow_down:

toml/encoder.py
0.00% <0.00%> (-88.33%)
:arrow_down:

toml/tz.py
0.00% <0.00%> (-88.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f637db...8eaf2ba. Read the comment docs.


small fix & mv normalize.scss to local

just avoid unnecessary problems.

I agree most of the changes but I would also like to know why moving normalize to the project. I think that's actually a third party dependency that doesn't belong to the project. Also, note that .app might belong to commons.scss file since it needs to be imported by client apps.
The rest of the changes are ok. Tell me about it and we can merge!

node-sass will convert @import "~ normalize.css"   to @import url(~ normalize.css)(lib).

I don't get why is that happening. The purpose of the import is to dump normalize.css in the resulting CSS files. It's working for the tests I'd been doing and it should work for you too.😕

@javivelasco It's sass-loader feature.
Now we should use css-loader in app(because we use css-modules). If we do not convert sass file to css in lib, we will add sass-loader in app.
So  i think css-loader is ok in react component, but sass-loader is not necessary.

Ok, I get it. Maybe we can better use webpack to generate the lib or to do something about. Anyway I'm not sure if we should go with this lib strategy. I'd been thinking during this weekend about customization. In an ideal scenario the user should be able to provide a SASS configuration file to override our sass variables. That would be the perfect case to have custom colors.
The only way to get that working is to provide a react-toolbox-loader that accepts some configuration from webpack config file to prepend the user configuration to each SASS module file. If we are providing a lib based in css modules, why not providing it base in sass modules instead? For the user is just adding other loader to the pipe and it will provide a lot of return.
In that scenario it doesn't make sense to provide a lib. I'm planning to write a react-toolbox loader soon. What do you think?

I support react-toolbox-loader! It is a good way to custom component style. You can create a repo first!

Great to know!! :) This afternoon I'm going to create the repo with a first approach. Let's go that way and keep normalize as a module. I think we can remove the lib build process to prevent confussion and make components the entry point of the package.
The rest of the changes are perfect :+1:

I think lib is also necessary. We should use babel to convert it to es5, because many app ignore node_modules(babel-loader, for speed).

I would love to have both options but still sounds weird not having normalize as a dependency. Maybe we can figure out a way to generate lib including normalize without having to move it to the repository. It should be a way, always! :dancer:


Update README to be roughly current

Revises some portions which had gone out of date, makes clear physical properties analysis is available, adds details of special issue.

Looks good!

Looks good!


Update parent LID integrity checking to fix bug introduced for collection integrity checking

I forget - was that error deliberately removed? I think validate should catch such errors, but maybe I missed/forgot some discussion.
Here's the current validate, followed by the build 9b's validate, with the error that 9b caught about 10 lines from the bottom. Hmmm, I couldn't attach a 160k zip. I uploaded it to pds-gamma:/home/rchen/bundleLID.zip
% validate -R pds4.bundle -t bundleLID/
PDS Validate Tool Report
Configuration:
Version                       1.17.3
Date                          2019-10-22T18:48:45Z
Parameters:
Targets                       [file:/Users/rchen/Desktop/bundleLID/]
Rule Type                     pds4.bundle
Severity Level                WARNING
Recurse Directories           true
File Filters Used             [*.xml, .XML]
Data Content Validation       on
Product Level Validation      on
Allow Unlabeled Files         false
Max Errors                    100000
Registered Contexts File      /PDS4tools/validate/resources/registered_context_products.json
Product Level Validation Results
PASS: file:/Users/rchen/Desktop/bundleLID/bundle_1.xml
Oct 22, 2019 11:48:50 AM com.sun.xml.bind.v2.runtime.reflect.opt.AccessorInjector
INFO: The optimized code generation is disabled
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/sol149b.xml
.........
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/sol149a.xml
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/data_derived_collection_1.xml
PDS4 Bundle Level Validation Results
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/data_derived_collection_1.xml
PASS: file:/Users/rchen/Desktop/bundleLID/bundle_1.xml
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/sol149b.xml
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/sol149a.xml
Validation complete.
Summary:
0 error(s)
0 warning(s)
End of Report
%
%
%
% /PDS4.9b.tools/validate-1.15.0/bin/validate -R pds4.bundle -f -t bundleLID/
PDS Validate Tool Report
Configuration:
Version                       1.15.0
Date                          2019-10-22T18:49:52Z
Parameters:
Targets                       [file:/Users/rchen/Desktop/bundleLID/]
Rule Type                     pds4.bundle
Severity Level                WARNING
Recurse Directories           true
File Filters Used             [.xml, *.XML]
Force Mode                    on
Data Content Validation       on
Allow Unlabeled Files         false
Max Errors                    100000
Registered Contexts File      /PDS4.9b.tools/validate-1.15.0/resources/registered_context_products.json
Product Level Validation Results
PASS: file:/Users/rchen/Desktop/bundleLID/bundle_1.xml
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.sun.xml.bind.v2.runtime.reflect.opt.Injector$1 (file:/PDS4.9b.tools/validate-1.15.0/lib/jaxb-impl-2.2.4.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int)
WARNING: Please consider reporting this to the maintainers of com.sun.xml.bind.v2.runtime.reflect.opt.Injector$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/sol149b.xml
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/sol149a.xml
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/data_derived_collection_1.xml
PDS4 Bundle Level Validation Results
FAIL: file:/Users/rchen/Desktop/bundleLID/data_derived/data_derived_collection_1.xml
ERROR  [error.integrity.missing_parent_prefix]   Member LID urn:nasa:pds:phx_ra:data_777:sol149b does not begin with parent LID urn:nasa:pds:phx_ra:data_derived
PASS: file:/Users/rchen/Desktop/bundleLID/bundle_1.xml
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/sol149b.xml
PASS: file:/Users/rchen/Desktop/bundleLID/data_derived/sol149a.xml
Summary:
1 error(s)
0 warning(s)
Message Types:
1            error.integrity.missing_parent_prefix
End of Report

@rchenatjpl great catch. about to merge a change to show this.
btw, when referencing data on our systems, we should probably try not to reference file paths since that can be a security concern. either send it to me over slack or say something like "home directory on pds-gamma". i know it is silly, but just to cover our bases.

Ok, I'll try to remember.
On 10/22/19, 13:43, "Jordan Padams"<EMAIL_ADDRESS>wrote:
@rchenatjpl <https://github.com/rchenatjpl> great catch. about to merge
 a change to show this.
btw, when referencing data on our systems, we should probably try not to reference file paths since that can be a security concern. either send it to me over slack or say something like "home directory on pds-gamma". i know it is silly, but just to cover
 our bases.
—
You are receiving this because you were mentioned.
Reply to this email directly,
view it on GitHub <https://github.com/NASA-PDS-Incubator/validate/issues/146?email_source=notifications&email_token=ANPP7XETE33Z73MZXISJXXLQP5QXXA5CNFSM4JDUJWZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7EIUY#issuecomment-545145939>, or
unsubscribe <https://github.com/notifications/unsubscribe-auth/ANPP7XGOCHAXT6BC7W2ZB6DQP5QXXANCNFSM4JDUJWZQ>.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/NASA-PDS-Incubator/validate/issues/146?email_source=notifications\u0026email_token=ANPP7XETE33Z73MZXISJXXLQP5QXXA5CNFSM4JDUJWZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7EIUY#issuecomment-545145939",
"url": "https://github.com/NASA-PDS-Incubator/validate/issues/146?email_source=notifications\u0026email_token=ANPP7XETE33Z73MZXISJXXLQP5QXXA5CNFSM4JDUJWZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7EIUY#issuecomment-545145939",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]


Fix stories bugs and clean up code

Description

A lot of code quality improvements

Removed unused code
Reduce duplicated code
Removed unreachable code
Improved logic
Removed magic numbers
etc...

Closes #2607
Closes #2608

Refer to full commit history and linked issues for details.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Code quality improvements

Checklist

[x] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 38 (0.0%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 37.445%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/stories/Stories.tsx
0
2
0.0%

src/features/stories/storiesComponents/SourceBlock.tsx
0
11
0.0%

src/features/stories/storiesComponents/UserBlogContent.tsx
0
25
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/features/stories/storiesComponents/SourceBlock.tsx
1
1.32%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
5734

Relevant Lines:
14389

💛  - Coveralls


python27Packages.shodan: 1.23.0 -> 1.23.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python27Packages.shodan is: "Python library and command-line utility for Shodan"
meta.homepage for python27Packages.shodan is: "https://github.com/achillean/shodan-python"
meta.changelog for python27Packages.shodan is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.23.1 with grep in /nix/store/s2gl6l1yzvcy5y0d98rmjp059sllfjgk-python2.7-shodan-1.23.1

directory tree listing: https://gist.github.com/9654f689cc0ee4f7e73889222cee4292

du listing: https://gist.github.com/547e35977e48bced612bffb245711568

Rebuild report (if merged into master) (click to expand)

16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python27Packages.shodan
python37Packages.shodan
python38Packages.shodan
theharvester

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s2gl6l1yzvcy5y0d98rmjp059sllfjgk-python2.7-shodan-1.23.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python27Packages.shodan https://github.com/r-ryantm/nixpkgs/archive/43021d0a65218b2ce9b4426020008f9357b2d207.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s2gl6l1yzvcy5y0d98rmjp059sllfjgk-python2.7-shodan-1.23.1
ls -la /nix/store/s2gl6l1yzvcy5y0d98rmjp059sllfjgk-python2.7-shodan-1.23.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

4 packages built:

python27Packages.shodan
python37Packages.shodan
python38Packages.shodan
theharvester

Maintainer pings
cc @lihop for testing.

:+1: Works for me.


Support for arguments following different syntax

Currently one can supply additional parameters to the application through deployment_arguments, which get appended to the docker run command. The syntax that Nova uses is key=value as defined here: https://github.com/gilt/nova/blob/master/nova/core/deploy/deploy_stack.py#L193.
This works well enough for many arguments, such as defining a config file in Play -Dconfig.resource=/path/to/file. However, some arguments like the JVM memory ones do not follow this syntax, but rather are simply -Xmx256m, or in the case of Play 2.3's mem argument, -mem 256. Currently, I believe, there is no way to specify params with this kind of syntax.
As Nova, with the help of Docker, aims to be a general deployment tool (one not strictly used for JVM-based applications), a solution shouldn't be designed which only caters to JVM arguments. I think it would be beneficial to provide another optional section in the Nova specification where the developer can pass a list of strings which get passed as-is to the launch command:
Option 1:
deployment_options:
    - --log-driver: syslog
deployment_arguments:
    - -Dconfig.resource: application.production.conf
deployment_strings:
    - '-mem 7168'
    - '-Xmx71668m'

Option 2:
deployment_options:
    - --log-driver: syslog
deployment_arguments:
    - -Dconfig.resource: application.production.conf
    - '-mem 7168'
    - '-Xmx7168m'

which would result in a launch command
docker run -d --log-driver=syslog org/docker_image -Dconfig.resource=application.production.conf -mem 7168 -Xmx7168m

This would allow for more flexibility in the varied syntax of arguments that could be specified to the application on launch.

Agreed. This shouldn't be a key/value list. And key=value shouldn't be treated in any special way - these should just be strings; each entry is one argument (including any spaces).


[WIP] Add contributors

What problem does this PR solve?
Add contributors
What is changed and how does it work?
Add contributors
Check List
Tests

No code

Code changes

No code

Side effects

None

Related changes

None

@AngleNet could you provide your email address. thank you

@yujunz PTAL

Codecov Report

Merging #225 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   43.64%   43.64%
=======================================
  Files          18       18
  Lines         685      685
=======================================
  Hits          299      299
  Misses        353      353
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d7166...12bd9ce. Read the comment docs.

@zhouqiang-cl can you clean useless commit?😂


Request body as a file

Add -f flag for providing body as a file

i made a pull request to support reading request body from file.
lol

Closed via https://github.com/rakyll/hey/commit/07ebe6726d667e01b795276b1f874844947fc0ba.


Admin can remove a question from a block using block dashboard

blocked on #110
Describe the solution you'd like
In block dashboard center panel is current block with list of questions in the block. Each question has a checkbox next to it. Single "Remove from Block" button removes the checked questions from the block.
See https://tiny.cc/uat-flow for lightweight UI mock.
Done when
Admin can remove a question from a block using block dashboard

wireframes : https://miro.com/app/board/o9J_lXULxwE=/?moveToWidget=3074457354358891906&cot=14

M1 Review - In progress


fix: build files for docker

Summary

~adds --ignore-scripts for now due to the pnpm check in our package.json~
adds build step to docker to build the js files

Checklist

[ ] I checked my UI changes against the design and there are no notable differences
[ ] I checked my UI changes for any responsiveness issues
[ ] I checked my UI changes in light AND dark mode
[ ] I checked my (code) changes for obvious issues, debug statements and commented code
[ ] I opened a corresponding card on Clickup for any remaining TODOs in my code
[ ] I added a short description on how to test this PR (if necessary)
[ ] Documentation (if necessary)
[ ] Tests (if necessary)
[ ] Ready to be merged

Removed --ignore-scripts as it's unnecessary after the change here


Error in Gemini connection: timed out during handshake

After installing the dependencies, it still shows a connection failure. Using a global VPN to access the Internet is still the same. As shown in the figure

The screenshot image is broken. Can you please reproduce and reopen if still happens?


Remove DOCKER_HOST parameter from ansible_docker_extra_args

Issue Type
Unexpected behavior / question
Molecule and Ansible details
molecule --version
molecule 3.6.1 using python 3.10
    ansible:2.12.4
    delegated:3.6.1 from molecule
    docker:1.1.0 from molecule_docker requiring collections: community.docker>=1.9.1

Desired Behavior
Molecule Docker should use the DOCKER_HOST from the environment instead of set it as ansible_docker_extra_argsor should at least allow to override this behaviour.
Actual Behaviour
When running Molecule with Podman as Docker replacement it fails with the following message:
FAILED! => {"msg": "Docker version check (['/usr/bin/docker', '-H=unix:///run/user/1000/podman/podman.sock', 'version', '--format', \"'{{.Server.Version}}'\"]) failed: Error: unknown shorthand flag: 'H' in -H=unix:///run/user/1000/podman/podman.sock\n"}

The root cause is that the driver adds the DOCKER_HOST as a parameter with -H to ansible_docker_extra_args.
https://github.com/ansible-community/molecule-docker/blob/3441d5a1e9e8980170796b66289ed53bf62f8596/src/molecule_docker/driver.py#L224
The Podman Docker replacement does not support this flag.
When i remove this specific line from the inventory everything works as expected because Docker/Podman pulls the config from the environment.
Is there a concrete reason to set the flag explicitly and not use the environment variable?
Otherwise i would recommend to remove this behavior and use the environment variable which works for both implementations.
Here's an example of the problematic part of the generated inventory.
# Molecule managed
---
all:
  hosts:
    instance-vault-agent: &id001
      ansible_connection: community.docker.docker
     # This line is the root cause - remove it and it works
      ansible_docker_extra_args: -H=unix:///run/user/1000/podman/podman.sock

Edit: This is an corner case where podman socket is running as user service to have rootless Docker over Podman.
https://major.io/2021/07/09/rootless-container-management-with-docker-compose-and-podman/
But the question is still the same, why is there an explicit config for the docker host?

Why not use the Podman Driver molecule-docker when using Podman?

Because I'm the only one using Podman in the team and cannot change the driver.
I know the driver and it works as expected, but Podman should act as an replacement for Docker.


bug:  multiple nested ion-slides not working [Github-Repo]

Bug Report
Ionic version:

[x] 5.2.1
Current behavior:
When nesting multiple ion-slides using ngFor the slider does not work properly, it drag the slides back.
Expected behavior:
Slide does not drag back.
Steps to reproduce:
Go to tab 1 from the github repo or use the snippet
https://imgur.com/a/vsWEDgk
Related code:

GITHUB REPO SAMPLE:
https://github.com/conde2/ionic-slides-bug
<ion-content>

{{category}}

    <ion-slides>

        <ion-slide>
          <ion-card>
            <ion-card-header>
              <ion-card-title>
                {{category}}
              </ion-card-title>
              <ion-card-content>

                <ion-button>{{data}}</ion-button>
              </ion-card-content>
            </ion-card-header>
          </ion-card>
        </ion-slide>

    </ion-slides>

</ion-content>

Ionic info:

Ionic:

   Ionic CLI                     : 6.9.2 (/usr/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.2.1
   @angular-devkit/build-angular : 0.901.8
   @angular-devkit/schematics    : 9.1.7
   @angular/cli                  : 9.1.8
   @ionic/angular-toolkit        : 2.2.0

Capacitor:

   Capacitor CLI   : not installed
   @capacitor/core : not installed

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v14.2.0 (/usr/bin/node)
   npm    : 6.14.5
   OS     : Linux 5.6

@conde2 have you try to update @angular/ionic until 5.2.1 ? There some ion-slides bugs was fixed which is solve my ion-slides errors.

Thanks for the issue. I am going to close this as this is not a bug in Ionic Framework.
You should only use ion-slide inside of ion-slides as immediate children. I removed the outer div, and the issue when away.


npm >= 5's prune reinstalls ignored node modules

Since version 5, npm prune reinstalls all missing dependencies, this breaks electron-packager's --ignore option when --no-prune is not set.

I assume you mean when --prune is set, because npm prune isn't run when --no-prune is set.
Sigh. This is why I'm dropping all support for npm and yarn when pruning.

Indeed !

The current workaround is to set --no-package-manager.

Thanks !


:bookmark: chore: changeset

Description
Added support for monorepo support as well as absolute imports
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #414   👈

This comment was auto-generated by Graphite.


Cant download the model from google driver

Cant download the model from google driver.Could you  share the model on baidu pan please?

Hi, @wuqiangch, we will upload these models on BaiduPan as soon as possible.

Ok，Thanks.

Hi @wuqiangch, we have uploaded the weights on BaiduPan, you can download all weights from this link(password:lkdo).


fix Fatal error when using the library with PHP version 7.2

Getting Fatal error when running the sites with PHP version 7.2

Debug Log

[19-Jul-2018 14:10:51 UTC] PHP Fatal error:  Uncaught Error: Call to undefined function Kishanio\CCAvenue\mcrypt_module_open() in /app/public/wp-content/plugins/Give-CCAvenue/includes/lib/CCAvenue-PHP-Library/src/Utils.php:89
Stack trace:
#0 /app/public/wp-content/plugins/Give-CCAvenue/includes/lib/CCAvenue-PHP-Library/src/Payment.php(255): Kishanio\CCAvenue\Utils->encrypt('merchant_id=990...', 'AVPB01FB51AQ01B...')
#1 /app/public/wp-content/plugins/Give-CCAvenue/includes/functions.php(107): Kishanio\CCAvenue\Payment->getEncryptedData()
#2 /app/public/wp-content/plugins/Give-CCAvenue/template/ccavenue-form.php(8): give_ccavenue_get_form()
#3 /app/public/wp-includes/template-loader.php(74): include('/app/public/wp-...')
#4 /app/public/wp-blog-header.php(19): require_once('/app/public/wp-...')
#5 /app/public/index.php(17): require('/app/public/wp-...')
#6 {main}
  thrown in /app/public/wp-content/plugins/Give-CCAvenue/includes/lib/CCAvenue-PHP-Library/src/Utils.php on line 89

Solution

https://stackoverflow.com/questions/41740600/php7-1-mcrypt-alternative

@raftaar1191 Would you like to take this ahead? Maybe create a pull request and i'll merge it.

Sure @kishanio will send a PR to update this

good


Precompilled dll library

Is there any chance to share compiled DLLs of this extension for windows users?

I'm not a windows user, but I'll try to prepare dll's. There is a tutorials how to do it:
https://wiki.php.net/internals/windows/stepbystepbuild
http://phalconphp-internals-documentation.readthedocs.org/en/latest/reference/compilation.html
http://szdredd.blogspot.cz/2013/11/how-to-setup-phalcon-framework-under.html

I added ice-1.0.36-php-5.6.16-vc11-x64 to Download and Building instruction.


start-stop-daemon: use vfork to avoid races

While running rc-service start docker on Gentoo,
I found that the command does not start the service 90% of the time,
with an enigmatic 'service crashed' message.
The root cause of this is apparently rc-service spawning a pty,
running start-stop-daemon inside that pty, and exitting,
before start-stop-daemon child process calls setsid(),
which results in the child process being killed with SIGHUP (SI_KERNEL).
Theoretically this bug was present ever since the file was created in
5af58b45146a ("Rewrite the core parts in C. We now provide...")
(or even before that), but it should have been only a minor issue before
45bd125dccdc ("Use a pty for prefixed output instead of pipes for...").
Not sure why nobody has had the issue so far (it has been present for
almost 15 years).
As here setsid() is the last call before execve(), the most natural
locking mechanism is vfork(), as it gives back control to parent
process only after execve() or process termination.
So this way the bug can be fixed by adding a single letter. :-)
Another way to ensure this would be using an O_CLOEXEC file descriptor
or some custom lock, which would need to be released not before setsid().
Fixes: 5af58b45146a ("Rewrite the core parts in C. We now provide...")

While you are all correct, I did not think about the state changes, because I only saw some error handling and printing (I overlooked environ mangling, but I see that now).  The changes should not 'corrupt' the parent though, since the parent is not running until the child process releases its memory, and the parent is not doing much meaningful things anyway. A probably more proper solution (on Linux at least, not sure whether OpenRC supports other kernels) would be to use clone(CLONE_VFORK) but without CLONE_VM and other problematic flags, but it would be a massive change here, primarily because clone() requires passing a function pointer, allocating some stack etc.
The signal mask will not work, too: if we sigprocmask() the SIGHUP away, it will be queued on arrival, and delivered as soon as the mask is restored in the child, thereby killing the process anyway.  If we do not unmask the signals, the daemon will be left unable to be signaled with SIGHUP (which many daemons implement as a way to communicate reloading their config for example).
Creating an O_CLOEXEC pipe would work probably work here, by closing the write end and blocking on reading from the read end in the parent, closing the read end and leaving the write end open (until process termination or execve() closes it automatically) in the child.  This would be the most portable, while keeping no need of having to unlock the lock on every single error path.  A similar file descriptor locking mechanism is implemented for example in xss-lock.

the child is opening file descriptors and creating FILE handles.  it's modifying the current environment which is shared.  i'm not auditing the C library for every function we use, directly or indirectly, to understand how its internal state is maintained, or what the compiler does with the stack.  the answer is "use vfork only as documented", and this clearly violates the strong statements in the vfork documentation.
i haven't looked at the bug/runtime situation you're describing in depth, so i don't have any immediate feedback as to a possible solution.  if the parent needs to wait for the child to exit or detach itself from the current session, and a sep program (ssd) is detaching from the current session, i don't think a pipe lock would work since ssd is unaware of that lock.  i can't think of any APIs off the top of my head the parent could use to monitor the child state short of polling it and checking its session id.

if the parent needs to wait for the child to exit or detach itself from the current session, and a sep program (ssd) is detaching from the current session, i don't think a pipe lock would work since ssd is unaware of that lock.

In this case, start-stop-daemon acts as both the parent process, and the child process which calls setsid. The pipe-based solution should work fine.

Superseded by #557


Add default tmp location for ansible

Pass temp location variable within container pointing with the workdir so that ansible can create and write the temp files.

The CI failure will be fixed in a different PR by @priyamsahoo

@ssbarnea Sorry I missed your review comment.

Is that related to the fact the ansible builder container is broken due to HOME != ~ ? Newer containers no longer have this issue.

Yes that's right.
I can either revert this PR or fix any comments you have in another PR

CI failure fix: https://github.com/ansible/ansible-language-server/pull/463

Reverted in PR https://github.com/ansible/ansible-language-server/pull/464


No "ToTransientMethod" method in BinderUntyped

Currently there is only a ToSingleMethod but I specifically need the dependency to be transient. Can this method be added to Zenject? I am trying to do the same as yesterday but now by passing types as parameters
        public static void ToPrefab(this BinderUntyped binder, String prefabLocation, Type type)
        {
            //NEED TRANSIENT VERSION
            binder.ToSingleMethod((ctx) => {
                var obj = Resources.Load(prefabLocation) as GameObject;
                return ctx.Container.InstantiatePrefabForComponent(type, obj) as MonoBehaviour;
            });
        }

You can just use ToMethod instead, which is transient.

  I'll fix that.

@svermeulen Thanks! I looked at the code inside BinderUntyped and there only seem to be singleton methods so the fix doesn't look that simple.

Ok I pushed a change that adds that method.  I tested it in the unit tests but will wait to hear from you whether that solves your problem before closing this item

I am having a small problem that didn't happen in ToSingleMethod, in the new extension method
        public static void ToPrefab(this BinderUntyped binder, String prefabLocation, Type type)
        {
            binder.ToMethod((ctx) => {
                var obj = Resources.Load(prefabLocation) as GameObject;
                return ctx.Container.InstantiatePrefabForComponent(type, obj) as MonoBehaviour;
            });
        }

TContract in ToMethod<TContract> gets set as MonoBehaviour because its the only sensible type I can cast to. However, the actual type of obj is type (obj.GetType() == type) and that type is known to extend MonoBehaviour.
So Zenject complains

ZenjectBindException: Invalid type given during bind command.  Expected type 'UnityEngine.MonoBehaviour' to derive from type

I actually commented your code (the part that check types) so it didn't throw that exception but I got

ZenjectException: Assert hit!
ModestTree.Assert.Throw (System.String message) (at Assets/Lib/Zenject/Internal/Assert.cs:195)
ModestTree.Assert.That (Boolean condition) (at Assets/Lib/Zenject/Internal/Assert.cs:29)
Zenject.MethodProvider`1[UnityEngine.MonoBehaviour].GetInstance (Zenject.InjectContext context) (at Assets/Lib/Zenject/Main/Scripts/Providers/MethodProvider.cs:25)
Zenject.DiContainer.Resolve (Zenject.InjectContext context) (at Assets/Lib/Zenject/Main/Scripts/Main/DiContainer.cs:578)
Zenject.DiContainer.Resolve (System.Type contractType) (at Assets/Lib/Zenject/Main/Scripts/Main/DiContainer.cs:1175)

I actually need something that binds the method type as a parameter like this
        public static void ToPrefab(this BinderUntyped binder, String prefabLocation, Type type)
        {
            //Pass "type" into ToMethod
            binder.ToMethod(type, (ctx) => {
                var obj = Resources.Load(prefabLocation) as GameObject;
                return ctx.Container.InstantiatePrefabForComponent(type, obj) as MonoBehaviour;
            });
        }

If passing type as a parameter is not possible, is the exception I get when I comment your code due to the same exception as yesterday (something about not having a CompositionRoot)?

Ok I added a non-generic version of ToMethod, try that.  What errors are you getting now?

Works!!!!!!!!!!!!!!!!!!!!!!!!
Thanks man. Now I am able to define Routes like this with my framework
    [Route("some/route")]
    public class SomeRouteView : MonoBehaviour
	{
        [PostInject]
        public void PostConstruct(...) {
            ...
        }
    }

and start and configure like this

    public class Startup : MVCApp
    {
        public override void Configure(IApplication app, DiContainer container)
        {
            //Set view dependencies
        }

        public override void Init(IRouter router)
        {
            router.GoTo(
                url: "some/view",
                body: 42
            );
        }
    }
```
the framework looks for classes annotated with `Route` and wires the dependencies with your code!!!

Ok great :)
Sounds like a cool setup


Unable to detect CRS, GeoJSON has no "crs" property

I am getting this error
Error parsing Geometry Error: Unable to detect CRS, GeoJSON has no "crs" property.
    at detectCrs (/home/joao/dev/geoapi.pt/node_modules/@ngageoint/geopackage/node_modules/reproject/index.js:57:11)
    at Object.reproject (/home/joao/dev/geoapi.pt/node_modules/@ngageoint/geopackage/node_modules/reproject/index.js:98:12)
    at Function.FeatureDao.reprojectFeature (/home/joao/dev/geoapi.pt/node_modules/@ngageoint/geopackage/dist/lib/features/user/featureDao.js:446:44)
    at Object._a.next (/home/joao/dev/geoapi.pt/node_modules/@ngageoint/geopackage/dist/lib/features/user/featureDao.js:389:51)
    at generateMunicipalityCensosJsonFIle (/home/joao/dev/geoapi.pt/routines/censos/generateCensosData.js:260:14)
    at generateJsonData (/home/joao/dev/geoapi.pt/routines/censos/generateCensosData.js:236:5)

with
GeoPackageAPI.open(file).then(geoPackage => {
  const table = geoPackage.getFeatureTables()[0]
  const featureDao = geoPackage.getFeatureDao(table)

  // colums which have statistical numbers to aggregate on the municipality
  const countableColumns = featureDao.columns.filter(c => c.startsWith('N_'))

  // statistical sum for all municipalities
  const sum = {}
  countableColumns.forEach(el => {
    sum[el] = 0
  })

  const geoPackageIterator = geoPackage.iterateGeoJSONFeatures(table)
  for (const feature of geoPackageIterator) { // <= ****** HERE *************
    for (const el in sum) {
      sum[el] += feature.properties[el]
    }
  }
})

I'm using the latest NPM version 4.2.3, and node  v16.19.0
Any idea what the problem is?

@jfoclpf your file probably doesn't have a CRS set for the table you are querying. I recommend opening it in QGIS to confirm if it is not set and then set it.


Add retry logic on .getReceipt for network response "Unknown"

Problem
As a developer, I need to get the receipt of a transaction to validate the transaction was successful or to get data from the transaction that executed which is returned in the receipt.
If I ask for the receipt and the receipt returns a status of Success then do not retry to get the receipt of the transaction.
If I ask for the receipt and receipt returns "Unknown" retry attempting to get the receipt. Unknown means that the status of returning the receipt or not is unknown https://github.com/hashgraph/hedera-protobufs/blob/main/services/response_code.proto#L147.
Solution

Review the getReceipt logic that is implemented in the SDK
Retry getting the receipt on an "Unknown" status
Test the feature works as expected when "Unknown" is returned

Alternatives
No response

Hi! I can confirm that this is implemented and has been for quite a long time, but I'm not sure how one would go about reliably testing this feature, given that using anything real will sometimes have the receipt return Success/ without hitting any Unknowns.

Need to rethink environment to provide the unknown response to test against.


Bad number in spyder.ini prevents spyder from showing

Description of your problem
What steps will reproduce the problem?

enable dual monitors. move spyder to the right monitor. exit spyder.
disable the right monitor. (or connect over remote desktop)
load spyder.

alternatively, just edit your .spyder-py3/spyder.ini and set window/position = (4134, 197)

What is the expected output? What do you see instead?
I expect to see spyder, but the window cannot be seen anywhere on the screen.
Poor fix:
I could spyder --reset, but that loses lots of settings I spent a long time to set up.
Best FIX (a developer should do this):
The last used window position is stored in my user folder /.spyder-py3/spyder.ini
Set the window position to a sane x,y pair like (100,100):
window/position = (100, 100)
It would be great if spyder could detect the width of the desktop, and if the window position X is greater than this width it decreases the number to compensate.
Versions and main components

Spyder Version: 3.0.2
Python Version: 3.5.2
Operating system: Windows 10

Thanks for reporting. We'll fix this for Spyder 3.1.
@dalthviz, please work on this one.

Hi @swharden as you are using Windows, for now, you can try to use the snapping shortcuts of Windows to work around the problem. Having Spyder as your current window use Windows Key + left arrow or Windows Key + right arrow. This will help you to find the main window of Spyder.


Fix linting issues and enable more eslint rules to enforce consistency

Those changes were done mostly automatically by eslint --fix command.
There should be no functional changes.
@akloeckner

LGTM


Circuit cache dir now uses os cache dir

Resolves #375.

Now attempts to use the OS's specific cache dir to store circuits.
This is done by setting the env var ZK_EVM_CACHE_DIR if the user has not already set it, which allows the user to override the circuit cache directory if they want to.

Also, do we want a clean command to clear out any cached circuits now that we're writing a potentially large amount of data to a OS specific cache (which the user might not be aware is happening)?

Regarding naming, this is already implied by the hardcoded constants + doc that we intend to specify the dir env at ZK_EVM_CACHE_DIR_ENV, so I would simplify the name of the method to set_circuit_cache_dir_env

@Nashtare I swear I responded to this last week, not sure what happened...
So just to be clear, the env var set_circuit_cache_dir_env_if_not_set is able to be set by the user manually, and if they set the env var, this function returns early and does not set it. I feel if we rename this to set_circuit_cache_dir_env then it might be a bit misleading just because it really won't set anything if it's already set. I might be misunderstanding, but let me know what you think.


Revert "Update to Miniconda 4.3.21"

This reverts commit 2ddc88e0, also use a different local tag to keep the
good conda version cache.

@elibarzilay,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


DOC bug: brent bracket is a,b

The brent doc string says brack is (a, c) for the bracket search, but from bracket it looks like it's (a,b) and bracket looks for c.
I'm using brent for the first time, and use 2-point bracket. I got weird results when I provide expected (a,c), but good results if I provide expected (a, b)

I think the documentation is correct but that it's a bug in Brent.get_bracket_info:
    elif len(brack) == 2:
        xa, xb, xc, fa, fb, fc, funcalls = bracket(func, xa=brack[0],
                                                   xb=brack[1], args=args)

Should be xb=brack[2]. Disclaimer: I only had a very quick look.

I think the code is fine (when len(brack) == 2 the two entries should be the endpoints for the bracket search). The documentation for bracket and brent uses different notation, which is confusing. Submitted a pr which hopefully makes things clearer.

AFAICS, the bracket search for xc continuous above xb
https://github.com/person142/scipy/blob/gh-5408/scipy/optimize/optimize.py#L2106
@rgommers   I don't think we can consider definitions a bug.
In your code snippet xb=brack[2] doesn't work because this is for the case when brack only has two elements. The question is whether these are (a,b) or (a,c)   for a<b<c as target.
I also didn't try to figure out more than to get to the line with xc = xb + _gold * (xb - xa)  with _gold = 1.618034

my example had f(brack[0) == f(brack[1])  and I thought brent/bracket will look for a point inside, instead it looks like it was looking above brack[1].
My code is pretty convoluted right now, and I don't have a simple example yet, and I don't have enough unit tests yet for the individual parts, to know whether my guesses are correct.

In your code snippet xb=brack[2] doesn't work ...

Indeed, sorry for the noise. Will go have a look at the PR.


Query with expanding manager does not return manager itself

I'm not sure if this is a bug with Graph explorer or MS Graph API itself.
Describe the bug
When querying users with $expand=manager the manager's user object is not returned.
To Reproduce
Steps to reproduce the behavior:

Query https://graph.microsoft.com/v1.0/users?$select=id&$expand=manager($levels=1;$select=id,displayName)
Result is:

{
<EMAIL_ADDRESS>"https://graph.microsoft.com/v2/d9e30361-69c3-4740-b391-c56653a0aabf/directoryObjects/11122233-5b47-43c2-8261-e67b9ef5f835/Microsoft.DirectoryServices.User",
            "id": "11122233-5b47-43c2-8261-e67b9ef5f835",
            "manager": {
<EMAIL_ADDRESS>"#microsoft.graph.user",
<EMAIL_ADDRESS>"https://graph.microsoft.com/v2/d9e30361-69c3-4740-b391-c56653a0aabf/directoryObjects/33344455-59a8-47c7-8a28-ba8c8cbb65c6/Microsoft.DirectoryServices.User",
                "id": "33344455-59a8-47c7-8a28-ba8c8cbb65c6",
                "displayName": "manager"
            }
        },

the manager is returned below the user. However, manager object itself is not returned as user.
Expected behavior
I expect that the manager's user object is also in the result list.
Example:
{
<EMAIL_ADDRESS>"https://graph.microsoft.com/v2/d9e30361-69c3-4740-b391-c56653a0aabf/directoryObjects/11122233-5b47-43c2-8261-e67b9ef5f835/Microsoft.DirectoryServices.User",
            "id": "11122233-5b47-43c2-8261-e67b9ef5f835",
            "manager": {
<EMAIL_ADDRESS>"#microsoft.graph.user",
<EMAIL_ADDRESS>"https://graph.microsoft.com/v2/d9e30361-69c3-4740-b391-c56653a0aabf/directoryObjects/33344455-59a8-47c7-8a28-ba8c8cbb65c6/Microsoft.DirectoryServices.User",
                "id": "33344455-59a8-47c7-8a28-ba8c8cbb65c6",
                "displayName": "manager"
            }
        },
        {
<EMAIL_ADDRESS>"https://graph.microsoft.com/v2/d9e30361-69c3-4740-b391-c56653a0aabf/directoryObjects/33344455-59a8-47c7-8a28-ba8c8cbb65c6/Microsoft.DirectoryServices.User",
            "id": "33344455-59a8-47c7-8a28-ba8c8cbb65c6"
        },

AB#10228

Hi @sven5,
I believe the manager is also returned as a user.
Running this query https://graph.microsoft.com/v1.0/users?$select=id,displayName&$expand=manager($levels=1;$select=id,displayName)
I have added the display name for explanation purposes
Returns an object where users whose id, display name and level 1 manager's id and display name are listed

From the example image I have shared, the user 'Debra Berger' has a manager named 'Diego Siciliani'
And we can see the user object of 'Diego Siciliani' also exists in the results.
Is this what you meant?

Hi @ElinorW
Thanks. Correct, this is what I meant.
However, I'm running the query against an AAD B2C directory. Perhaps there is an issue or it's not supported?

Hi @sven5, expanding managers' chain is part of the Advanced Query Capabilities, and unfortunately is currently not supported on B2C tenants.

Thanks @Licantrop0 for adding this detail. Closing this


Native scrollbars for mobile devices not working.

Hi guys,
Version  4.2.1  currently, native scrollbars for mobile devices not working.

Hi! Same problem. Did you manage to fix it somehow?

@samosad I'm moved to smooth-scrollbar-react


Use hmac.compare_digest()

Since all checks have passed, can we merge this PR?

@EdOverflow, because this function was introduced in Python 2.7.7, could you add a little bit of fallback logic? For example:
try:
    from hmac import compare_digest
except ImportError:
    def compare_digest(a, b):
        return a == b

Good idea @jparise! The only thing I want to do a bit differently is make sure that the fallback is also a constant time comparison:
try:
    from hmac import compare_digest
except ImportError:
    def compare_digest(a, b):
        if len(a) != len(b):
            return False
        result = 0
        for x, y in zip(a, b):
            result |= ord(x) ^ ord(y)
        return result == 0

Thanks @EdOverflow!


not working wth OLED Featherwing on nrf52840

I just tried running the test  cases on a particle argon (nrf52840) with an OLED featherwing and I just get a screen full of random pixels. The same code works fine on a metro_m4 _express
All of the test cases (bouncing bali,simpletest and ssd1306_framebuftest have the same results so it is not just framebuf)
Note -- the default nrf builds still include the "built in" framebuf  but I tried it with they built-in and the new adafruit_framebuf.py -- same results.
I have not test other nrf52840 boards yet.
also note, there is no RESET pin for the OLED Featherwing.

It works fine with the SPI interface to a 128x32 SPI OLED -- just not working with I2C to the featherwing -- SPI does have a RESET so that may be the issue -- is there a way to get a RESET signal to the OLED featherwing?

Can you verify that it works after you press the reset button on the wing manually?

It does not. That also resets the argon.

I will try later with the boards separated.

separating the boards and pressing RESET or setting the RESET pin to a GPIO pin and passing it to the configuration makes no difference - still just a lot of white pixels.

I verified the same behavior on a PCA10056.

closing this in favor of the https://github.com/adafruit/circuitpython/issues/1422


perf(vite-plugin-angular): add perf changes from esbuild browser builder

Relates to #14
Added the performance changes to the @analogjs/vite-plugin-angular-optimizer and @analogjs/vite-plugin-angular transform methods.

Hi, angular team added some other perf changes in its own builder regarding styles. It may interest you since you're working on this.

Thanks Enea, we don't use the sass functionality from the compiler plugin, as that's handled by Vite. We mainly use the plugin with Vite for optimizing the Angular/third-party dependencies.

Thanks! @allcontributors add @pjlamb12 for code


Yarn: install specific sub-dependency version

Allow passing a specific version to the yarn sub dependency updater,
will be used in future for lowest required security update.

@greysteil pretty confident that this is now good to go on yarn - going to do npm separately.

Cool, let's give it a spin!


Hooks without appendonly

I know it is not an officially supported feature, but is there anyway to make hooks work when the append only file is off? It makes a massive performance difference for me, but if it is too much work please let me know.
Currently I get the following error:
goroutine 14 [running]:
github.com/tidwall/tile38/vendor/github.com/tidwall/buntdb.(*Tx).lock(0xc420158600)
	/tmp/tile38.r1is/src/github.com/tidwall/tile38/vendor/github.com/tidwall/buntdb/buntdb.go:1057 +0x2d
github.com/tidwall/tile38/vendor/github.com/tidwall/buntdb.(*DB).begin(0x0, 0xc420147501, 0x46e604, 0xc420218280, 0xa27140)
	/tmp/tile38.r1is/src/github.com/tidwall/tile38/vendor/github.com/tidwall/buntdb/buntdb.go:1039 +0x82
github.com/tidwall/tile38/vendor/github.com/tidwall/buntdb.(*DB).managed(0x0, 0x1, 0xc42023cf50, 0x0, 0x0)
	/tmp/tile38.r1is/src/github.com/tidwall/tile38/vendor/github.com/tidwall/buntdb/buntdb.go:912 +0x53
github.com/tidwall/tile38/vendor/github.com/tidwall/buntdb.(*DB).Update(0x0, 0xc420147750, 0xc420218280, 0xc420147678)
	/tmp/tile38.r1is/src/github.com/tidwall/tile38/vendor/github.com/tidwall/buntdb/buntdb.go:957 +0x3a
github.com/tidwall/tile38/controller.(*Hook).proc(0xc4202125a0, 0xc42020e620)
	/tmp/tile38.r1is/src/github.com/tidwall/tile38/controller/hooks.go:478 +0x143
github.com/tidwall/tile38/controller.(*Hook).manager(0xc4202125a0)
	/tmp/tile38.r1is/src/github.com/tidwall/tile38/controller/hooks.go:427 +0x4a
created by github.com/tidwall/tile38/controller.(*Hook).Open
	/tmp/tile38.r1is/src/github.com/tidwall/tile38/controller/hooks.go:395 +0x13f

When executing this command:
SETHOOK kafka kafka://<IP_ADDRESS>/tile NEARBY fleet FENCE POINT 0 0 50000
Other hooks have the same behavior and the master branch does not have this problem.

Just to be clear, the error is occurring with the memoptz branch and with --appendonly no flag?

Just to be clear, the error is occurring with the memoptz branch and with --appendonly no flag?

As far as I am aware, yes

At the moment webhooks and replication rely on the AOF pipeline. The memoptz appendonly no hack breaks that.
I'm guessing that we can probably fix the problem with some modifications, but I'm not sure how much work it'll take just yet.
In the meantime is it possible to try a workaround (it may be a stretch)  by creating a symbolic link of /dev/null -> data/appendonly.aof?
Using the 1.9.0 release:
$ mkdir -p data
$ ln -s /dev/null data/appendonly.aof
$ tile38-server

In the meantime is it possible to try a workaround (it may be a stretch) by creating a symbolic link of /dev/null -> data/appendonly.aof?

Looks possible, will look into this tomorrow.

There seems to be still quite an impact on performance, from about 25.1k sets per second to 21.8k sets per second, tho it is better than with the aof enabled, about 19k sets per second.

25k->21k vs 19k doesn't seem like much.
Regarding the error above, would it be possible to include the full panic report? I'm wondering if the crash is unrelated to turning off appendonly.

25k->21k vs 19k doesn't seem like much.

The difference between 25k/s (no append) and 21k/s (/dev/null) is almost 20%, for now we decided on a different approach for the wanted functionality.

Regarding the error above, would it be possible to include the full panic report?

How would one acquire this report? :smile:

Great, that's all I need. Thanks!

This issue has been fixed when we added the "--appendonly no" options a few weeks ago.


setup.py tries to install to root instead of fake-root, fails on Arch

I tried to install themer from the AUR, but it always failed with:
error: could not create directory '/usr/share/themer'

After a bit of digging, I found out that setup.py tries to install to root, which one does not have the permissions to when building from AUR. Instead, the package should try to install to the current working directory, aka the fake-root --root="${pkgdir}".
I forked themer and removed the prefix / and it now happily builds with makepkg.

@phijor oh and by the way, if you end up writing any useful plugins, let me know so I can merge them in aswell.

@S0lll0s yeah, I'll look into that when I have the time. I'm glad I could contribute to the project, it feels good to know that I fixed something.
Btw: Look at the AUR-page for themer. It seem like a package is missing from the dependency-array, though I'm not quite sure wether it's just an error on my part or not.

Oh, right! I added python-requests to the package and removed the verson-dependency on python3 (the same commit that introduced requests enabled python2 compatibility).

During testing just now I found that without the slashes it actually does not install with sudo setup.py install. It instead creates the directory usr inside the source repo. I accidentally reverted back to the original version in 948b3fac29938073351aff6103451fff26bf9db9; not sure how to handle this...


Can you please also talk about SMTP inbound here. It seems to be very unclear for lots of people.

Please also add section about INBOUND.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 027fa865-2329-23de-3740-cfbe35359302
Version Independent ID: 99f0a52f-8df4-f8d4-3d4e-778fea2a389f
Content: Troubleshoot outbound SMTP connectivity in Azure
Content Source: articles/virtual-network/troubleshoot-outbound-smtp-connectivity.md
Service: virtual-network
GitHub Login: @asudbring
Microsoft Alias: allensu

@MikaVirkkunen thanks for your feedback!
@asudbring, Please review this ask

Thanks for your dedication to our documentation. We have created an internal work item in our backlog to resolve this issue. If you determine another possible update to our documentation, please don't hesitate to reach out again.
#please-close


Problem on adding on MainActivity (Android)

Hi there,
I have no problem to use your package on iOS but on Android, I managed to show a native splash screen on the app load. But on the final step of your documentation, when I try to plug your package in the MainActivity.java file, in order to get control of the splash screen display duration, I have the following error :
error: cannot find symbol
      protected void onCreate(Bundle savedInstanceState) {

Here is my MainActivity.java file :
package com.reactnativetest;

import com.facebook.react.ReactActivity;
import com.mehcode.reactnative.splashscreen.SplashScreen;

public class MainActivity extends ReactActivity {

    /**
     * Returns the name of the main component registered from JavaScript.
     * This is used to schedule rendering of the component.
     */
    @Override
    protected String getMainComponentName() {
        return "reactNativeTest";
    }

    @Override
      protected void onCreate(Bundle savedInstanceState) {
          // Show the js-controlled splash screen
          SplashScreen.show(this);

          // After react is initialized; set our background color (override splash screen theme)
          getReactNativeHost().getReactInstanceManager().addReactInstanceEventListener(new ReactInstanceManager.ReactInstanceEventListener() {
              @Override
              public void onReactContextInitialized(ReactContext context) {
                  // Hide the native splash screen
                  getWindow().getDecorView().setBackgroundColor(Color.WHITE);
              }
          });

          super.onCreate(savedInstanceState);
      }

}

What am I doing wrong here ?

I think you just need to import Bundle, using:
import android.os.Bundle;

Nice, thanx for your help, I'm not very at ease yet with android.


[SPARK-13403] [SQL] Pass hadoopConfiguration to HiveConf constructors.

This commit updates the HiveContext so that sc.hadoopConfiguration is used to instantiate its internal instances of HiveConf.
I tested this by overriding the S3 FileSystem implementation from spark-defaults.conf as "spark.hadoop.fs.s3.impl" (to avoid HADOOP-12810).

Can one of the admins verify this patch?

cc @marmbrus

Seems reasonable.

ok to test

Test build #51669 has started for PR 11273 at commit 32a3dcf.

Test build #51669 has finished for PR 11273 at commit 32a3dcf.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51669/
Test FAILed.

FWIW also seems reasonable to me; making a new conf is rarely correct. @rdblue can you rebase?

Also, could you fix the title to follow the Spark convention?
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#ContributingtoSpark-PullRequest

Test build #53377 has started for PR 11273 at commit f0f6cee.

Sorry for the delay, @vanzin and @srowen! I didn't get notified that you had commented. I've rebased this on master and fixed the PR title.

Test build #53377 has finished for PR 11273 at commit f0f6cee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53377/
Test PASSed.

Thanks - I'm going to merge this.

Thanks for the reviews!


Unify plotting - capitalize titles, lowercase x- and y-labels

Fixes #100

Current setup: capitalize titles, leave x- and y-labels in lowercase.


Skeleton based action recognition

This PR adds two learners (which train and evaluate a baseline model and three proposed models) for skeleton-based human action recognition.

A new data type named SkeletonSequence is added to the engine.data.py and a new target class named ActionCategory is added to engine.target.py.

The learners' implementation follows the provided template and sufficient tests are provided for all the functions which will be directly called by the user including, fit(), eval(), infer(), save(), load(), optimize(), multi_stream_eval(), network_builder().

@negarhdr testing is now available again. So, when you are ready, you can use the "test sources" label to run the style checks and "test tools" to run the tool tests.

@passalis , @stefaniapedrazzi
All the comments for this PR are addressed and it is ready to review. However, the API tests are failed after a while for STGCN fit function with this message:
/home/runner/work/_temp/ce3bf0a2-831e-4c0f-a74c-7d95f0238a4c.sh: line 8:  3283 Killed                   python -m unittest discover -s tests/sources Error: Process completed with exit code 137.
I test it on my own computer and it works without any problem. The dataset is very small (10 samples only) and it trains for only 1 epoch.
Could you please check it out and let me know if the problem is from my side?
Thank you.

One thing you could try in this branch is to temporary disable all the other tests.
This can be easily done by removing the __init__.py files in the other folder folder.
So you could run just your tests and check if there is maybe a conflict with some other.
Another one is try to run the tests in a clean environment and checking that you don't have any additional file or folder in the local  repository.
When I run them locally I also get some errors:

In Test STGCN optimize function:Error: ./tests/sources/tools/perception/skeleton_based_action_recognition/skeleton_based_action_recognition_temp/stgcn_nturgbd_cv_joint - Is a directory.

in test_save_load_onnx functions for all the different methods (here is just one of the 4 reported errors):

ERROR: test_save_load_onnx (skeleton_based_action_recognition.test_pstgcn.TestSkeletonBasedActionRecognition)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/stefi/develop/opendr_internal/tests/sources/tools/perception/skeleton_based_action_recognition/test_pstgcn.py", line 194, in test_save_load_onnx
    self.pstgcn_action_classifier.save(path=os.path.join(self.temp_dir, self.experiment_name),
  File "/home/stefi/develop/opendr_internal/src/opendr/perception/skeleton_based_action_recognition/progressive_spatio_temporal_gcn_learner.py", line 653, in save
    shutil.copy2(os.path.join(self.parent_dir, self.experiment_name, "onnx_model_temp.onnx"),
  File "/home/stefi/develop/opendr_internal/venv/lib/python3.8/shutil.py", line 435, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/home/stefi/develop/opendr_internal/venv/lib/python3.8/shutil.py", line 244, in copyfile
    raise SameFileError("{!r} and {!r} are the same file".format(src, dst))
shutil.SameFileError: './tests/sources/tools/perception/skeleton_based_action_recognition/skeleton_based_action_recognition_temp/pstgcn_nturgbd_cv_joint/onnx_model_temp.onnx' and './tests/sources/tools/perception/skeleton_based_action_recognition/skeleton_based_action_recognition_temp/pstgcn_nturgbd_cv_joint/onnx_model_temp.onnx' are the same file

Don't you get the same errors?
If it would be posible to reduce the logs of the tests (all of them not just the new ones in this folder), then it will also be easier to debug issues like this.

One thing you could try in this branch is to temporary disable all the other tests.
This can be easily done by removing the __init__.py files in the other folder folder.
So you could run just your tests and check if there is maybe a conflict with some other.
Another one is try to run the tests in a clean environment and checking that you don't have any additional file or folder in the local repository.
When I run them locally I also get some errors:

In Test STGCN optimize function:Error: ./tests/sources/tools/perception/skeleton_based_action_recognition/skeleton_based_action_recognition_temp/stgcn_nturgbd_cv_joint - Is a directory.

in test_save_load_onnx functions for all the different methods (here is just one of the 4 reported errors):

ERROR: test_save_load_onnx (skeleton_based_action_recognition.test_pstgcn.TestSkeletonBasedActionRecognition)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/stefi/develop/opendr_internal/tests/sources/tools/perception/skeleton_based_action_recognition/test_pstgcn.py", line 194, in test_save_load_onnx
    self.pstgcn_action_classifier.save(path=os.path.join(self.temp_dir, self.experiment_name),
  File "/home/stefi/develop/opendr_internal/src/opendr/perception/skeleton_based_action_recognition/progressive_spatio_temporal_gcn_learner.py", line 653, in save
    shutil.copy2(os.path.join(self.parent_dir, self.experiment_name, "onnx_model_temp.onnx"),
  File "/home/stefi/develop/opendr_internal/venv/lib/python3.8/shutil.py", line 435, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/home/stefi/develop/opendr_internal/venv/lib/python3.8/shutil.py", line 244, in copyfile
    raise SameFileError("{!r} and {!r} are the same file".format(src, dst))
shutil.SameFileError: './tests/sources/tools/perception/skeleton_based_action_recognition/skeleton_based_action_recognition_temp/pstgcn_nturgbd_cv_joint/onnx_model_temp.onnx' and './tests/sources/tools/perception/skeleton_based_action_recognition/skeleton_based_action_recognition_temp/pstgcn_nturgbd_cv_joint/onnx_model_temp.onnx' are the same file

Don't you get the same errors?
If it would be posible to reduce the logs of the tests (all of them not just the new ones in this folder), then it will also be easier to debug issues like this.

Thanks for the comments. These errors were mainly related to the clean-ups after the tests and they are resolved now. I test the code on our own server and I don't get any more errors or warnings. However, the tests are still failed here when it starts testing the ST-GCN method with this message:
/home/runner/work/_temp/add8f37b-fdcb-4171-ad50-a3f5e0c45922.sh: line 8:  3674 Killed
Both learners were passing all the tests here before. I don't know what could be the reason of this failure now.

Thanks for the comments. These errors were mainly related to the clean-ups after the tests and they are resolved now. I test the code on our own server and I don't get any more errors or warnings. However, the tests are still failed here when it starts testing the ST-GCN method with this message:
/home/runner/work/_temp/add8f37b-fdcb-4171-ad50-a3f5e0c45922.sh: line 8: 3674 Killed
Both learners were passing all the tests here before. I don't know what could be the reason of this failure now.

In general, tests are too verbose to get meaningful errors from the CI logs.
I'm now trying to ask every contributors to reduce the verbosity of the tests to improve it.
I also tried to disable a test that is known to be broken on the master branch.
Let we see if the tests pass successfully after this.
I tested locally (just the skeleton_based_action_recognition ones) and now they work correctly for me.

It seems there may be conflicts with other tests.
What I can suggest you it to try to debug the issue by disabling other tests and try to identify which one is causing the conflict.

It seems that the "Activity Recognition" branch causes the conflict (All the tests are passed when the tests of that branch are disabled). However, from the logs, it is not clear what is the reason for the conflict exactly.

Failing again even when I disable all the other tests. I think it might be a memory issue on this server, not sufficient RAM memory, or garbage collector's inconsistency.

Please resolve the conflicts and update to master to check if the new testing system is fixing the test errors.
You also have to add the test skeleton_based_action_recognition here:
https://github.com/tasostefas/opendr_internal/blob/7496b7356fd492b0fb9c9ba2e81111e95aac8140/.github/workflows/tests_sources.yml#L66

Please resolve the conflicts and update to master to check if the new testing system is fixing the test errors.
You also have to add the test skeleton_based_action_recognition in this list:
https://github.com/tasostefas/opendr_internal/blob/7496b7356fd492b0fb9c9ba2e81111e95aac8140/.github/workflows/tests_sources.yml#L66

@stefaniapedrazzi when I update the opendr_internal/.github/workflows/tests_sources.yml file, the Push is rejected!
Isn't it the case that this file can only be modified by code owners?

@stefaniapedrazzi when I update the opendr_internal/.github/workflows/tests_sources.yml file, the Push is rejected!
Isn't it the case that this file can only be modified by code owners?

It would be very helpful to also see the log you receive when the push is rejected.
I don't think that only code owners can modify it, but I'm not an administrator of this repository so I cannot check the settings.
 Directly from a terminal or using some applications?
If you are using an applications, could you please try directly from a terminal?

I think that the file can be edited by anyone (e.g., Lukas is not a codeowner and he edited this file). Can you provide more details regarding the reject? Please also check that you editing the file on your branch and not in the master branch.

Problem is solved. It was related to my personal access token.
All the tests are passed and the branch is ready to be merged.

Could you please also update the documentation index by adding your newly added documentation page?
https://github.com/tasostefas/opendr_internal/blob/master/docs/reference/index.md
Otherwise now everything is fine for me.

Could you please also update the documentation index by adding your newly added documentation page?
https://github.com/tasostefas/opendr_internal/blob/master/docs/reference/index.md
Otherwise now everything is fine for me.

@stefaniapedrazzi Index.md is updated.