Implement IAuthenticationService for Linux

DotNet core does not support starting a process as user. Creating this to investigate and implement using alternative means.

https://github.com/Microsoft/RTVS/pull/3516


Ensuring instruction labels are strings when provided to the Instruction constructor.

Summary
Fixes #7667 by adding a type check to the Instruction constructor which will raise a TypeError if the label parameter is provided, but not of type str. Per the associated issue, this guarantees that an informative exception is raised for labels of an invalid type at instruction creation time rather than when the label is later processed by print or draw.
Details and comments
Note that this pull request also adds a test for the type check that already existed for the label setter, but which was not under test coverage. I thought it prudent to add this test so that if our type checking rules change for labels in the future, we immediately know via a test failure that a change needs to be applied in both locations.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 83.336%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
52231

Relevant Lines:
62675

💛  - Coveralls

Thanks for the feedback, @jakelishman! I've applied each of the requested changes.

@jakelishman Do you think you'll have an opportunity to give this pull request another review?

We're getting some test failures here after this change, but I actually think that this PR is turning up buggy behaviour from existing code, and isn't the problem itself.  I'll have a look into it, and see what's going on there.

Thank you for the additional review and thank you for looking into the test failures! Feel free to let me know if you'd like any help.


feat: support symbols as keys in observed objects

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Take care about methods like initData that use Object.keys to make attributes directly declared in data() reactive, there're many Object.keys calls in the code, ensure that this feature will work properly in mixins,  extends or any other places where merging data and so on. The provide/inject option supports symbols by using Reflect.ownKeys and there's a function named hasSymbol in util to check whether symbol  and Reflect are available in runtime environment. Also, be aware that the type of param key in defineReactive is string, not string | symbol.

lable in runtime environment. Also, be aware that the type of param key in defineReactive is string, not string | symbol.

Symbols are not currently supported by Flow。Reflect.ownkeys returns all the properties on the object, including those that cannot be enumerated. On the other hand, if there is an enumerable "ob" attribute on the responsive object, the stack will overflow.

你的意思是, vue2在对data中的对象进行响应式处理的时候, 并不会处理key为symbol的属性. 但是用$set可以解决这个问题

lable in runtime environment. Also, be aware that the type of param key in defineReactive is string, not string | symbol.

Symbols are not currently supported by Flow。Reflect.ownkeys returns all the properties on the object, including those that cannot be enumerated. On the other hand, if there is an enumerable "ob" attribute on the responsive object, the stack will overflow.
yes, ensure that this feature will work properly everywhere, those places also need to be dealt with.

lable in runtime environment. Also, be aware that the type of param key in defineReactive is string, not string | symbol.

Symbols are not currently supported by Flow。Reflect.ownkeys returns all the properties on the object, including those that cannot be enumerated. On the other hand, if there is an enumerable "ob" attribute on the responsive object, the stack will overflow.
yes, ensure that this feature will work properly everywhere, those places also need to be dealt with.
还是vue3牛逼啊, 虽然我用$set可以让一个对象中symbol类型的key响应, 但是如果data里面定义的是一个数组, 数组的元素是对象, 对象有symbol类型的key呢, 又该怎么办


kew: init at 1.5.2

kew: init at 1.5.2
homepage: https://github.com/ravachol/kew
Listen to music in the terminal.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

nixpkgs-reviev failed because my last commit didn't make it into the master.
https://github.com/NixOS/nixpkgs/pull/266300


Load data from multinet

The functions don't load all the data from the tables right now and the graph doesn't display

I'm going to merge this since it's technically able to pull data from multinet now. We'll need some more development (#17, #18, #19. etc.)


Add Service Connection support from Testcontainers

Description

Add OpenSearchConnectionDetails
Add PropertiesOpenSearchConnectionDetails implementation
Add new module spring-data-opensearch-testcontainers
Add OpenSearchContainerConnectionDetails from OpenSearchContainer

Previously, opensearch.uris, opensearch.username and opensearch.password had to be declared via DynamicPropertySource. Since 3.1, Spring Boot added support for Service Connections, so, nowadays, just adding @ServiceConnection to OpenSearchContainer, the properties will take values from the container.
Issues Resolved
N/A
Check List

[x] New functionality includes testing.
[x] All tests pass
[x] New functionality has been documented.
[ ] New functionality has javadoc added
[x] Commits are signed per the DCO using --signoff

Thank you @eddumelendez !


Work in progress: Minification of /public

This PR cleans up the transform package etc. to make room for some minification.

For the curious, a minfied version of the HTML with minfier dialed in with defaults only: https://temp.bep.is/hugotest/
Still work to be done here, but I finally got to clean up the transform package so I could fit this into the "publisher processing chain".
/cc @regisphilibert @kaushalmodi @onedrawingperday and gang

Also, I think I will release the first version with a global on-off flag and minifiers at their default setting. I'm already a little tired about this issue, and I think people need to try it out before I spend time on adding more config options for it.

@kaushalmodi I noticed somewhere that you use this minifier for your site. What is your HTML config? I notice now that it, by default, strips some tags that should probably be conserved.

I tested a little, and think that if we enable KeepDocumentTags it should keep most people happy.

My minify config is none.. I use it as is. I had come across this issue someone posted on Discourse that minify stripped off some tags. But I didn't see that in my experience.. for what I cared, the meta-tags were retained and so the Twitter-cards, IndieAuth, etc. works fine.

if we enable KeepDocumentTags it should keep most people happy.

Shouldn't this be made a site config var? Lesser maintenance pressure from hugo side.

Shouldn't this be made a site config var? Lesser maintenance pressure from hugo side.

See my comment above. I have reached the limit of time I can spend on this.

I have reached the limit of time I can spend on this.

My config var suggestion was to prevent feature requests from people to config minify as they want in dozens of different ways. Having a single config var will solve all those issues.
Honestly, running minify externally is not painful at all. People seem to think that Netlify command can be set to only hugo and so demand everything should be packed in hugo. So I was actually surprised that you spent so much time on this feature.

Honestly, running minify externally is not painful at all.

That depends on a lot of factors. Making it Hugo built-in is guaranteeing minimum of efforts regardless of those factors.

So I was actually surprised that you spent so much time on this feature.

Maintainer motivation is the most important resource of any open source project. Please think about this when formulating comments in here 🙏.

Maintainer motivation is the most important resource of any open source project. Please think about this when formulating comments in here 🙏.

My aim was to say that @bep does not have to burn himself out (I saw signs like "I have reached the limit of time I can spend on this."). I am of course giving just my view point on the "simplicity" of running minify externally. I am simply encouraging prevention of feature-creep. My comment was very well-intentioned.

90% of the time spent on this feature is cleaning up old code, i.e. paying off some technical debt. Well-intentioned or not, doing these you have spent 20 hours for nothing motivational speeches is hardly ... motivational.

As to the motivation behind this particular issue. For me (and I will assume many others) this will be a nice conclusion to the Hugo Pipes -- i.e. a web project where the entire toolchain is handled by Hugo. Having to set up some "extra" for minification is not hard, but an annoyance -- and an order of magnitude slower than letting Hugo do it.

90% of the time spent on this feature is cleaning up old code, i.e. paying off some technical debt.

That's nice!

Well-intentioned or not, doing these you have spent 20 hours for nothing motivational speeches is hardly ... motivational.

You used to open issues to track proposed features. So this was a sudden PR based on your self-motivation. My suggestion to add that config var was to reduce your future maintenance commitment.

As to the motivation behind this particular issue. For me (and I will assume many others) this will be a nice conclusion to the Hugo Pipes

I am pretty sure this feature will be very well welcomed :) I am not denying that.

Having to set up some "extra" for minification is not hard, but an annoyance -- and an order of magnitude slower than letting Hugo do it.

As you already know, there are pros and cons of baking in external dependencies.

That said, I tested out a local build using your publisher branch, and it works great! 👍

I am just playing a devil's advocate here. I hope it's a common knowledge here that my comments are not to demotivate anyone.

At least for the HTML side of this, I think this is mostly a vanity feature. With Go templates it is almost impossible to get "pretty HTML".

With Go templates it is almost impossible to get "pretty HTML".

Agree, then again no one really needs "pretty" unless the compiled HTML will be used by a tier to create pages in another platform.
For me the main purpose of this feature is to make sure, I can write Go Template without having to care for extra linebreak and spaces.

That works fine too, and yes, now the generated public/ size is 55MB too; matches with the external minify run.

@bep Turns out that I need to use the minify aliases for resources plus the --minify switch to get "complete" minification. Is that correct?
I tried removing | minify everywhere in my code. But then except for those CSS/JS resources, everything else got minified. Does the --minify switch actively avoid the Resources? (may be this should be documented, if the case).

Turns out that I need to use the minify for resources plus the --minify switch to get "complete" minification. Is that correct?

This PR is about minification of the rendering of output formats, i.e. the final HTML/RSS. If you inline your resources, they should follow (re. the discussion we had earlier). But don't expect (resources.Get "styles/styles).RelPermalink to point to a minified resource. And please don't follow up with a "why not?" without thinking it through. Also, in general I never look at new notifications on closed issues.


[1610] Add provider code to course factory

Context
Due to the way we use the factories, it's difficult to set the
provider_code on the course without causing an endless loop.
Also, setting provider_code on the course factory gets overwritten by
the provider being set to nil in the factory, and removing that breaks
things.
This is further broken by a bug in the JSONAPI client.
Changes proposed in this pull request
Added workaround for broken factories/jsonapi client.
Removed workaround for provider_code not being in responses.
Guidance to review
I cleaned up the test affected, some of that is unrelated to these changes, sorry.

 Expose provider code in courses endpoint


Dockerfile improvements

Add missing build dependencies for sharp node module (dependency of
gatsby-plugin-sharp).
Add ARG instructions for firebase variables, allowing them to be set
via --build-arg flags when building the image.
Use npm ci instead of npm install, and execute it after copying
only package*.json. This prevents having to fetch all dependencies if
package*.json hasn't changed between builds.
Use node:alpine instead of node - not an improvement per-se,
but I happen to be more familiar with adding build dependecies in the
alpine based node image.

Thank you so much for this very insightful PR. I don't have much experience with docker, but I'm glad the project has you to help :) Hope this clears out some of the issues people have been facing with Docker and Firebase. We need a more straightforward guide/video on how to set this up...


service.send gets ignored past first call on initial setup

Appreciate the work on this! One issue I'm running into. I am using script/setup in a project with the Vue 2.7.10 compatibility build, and if I do two service.send() calls back-to-back in the root of the Vue script (the equivalent of the setup function as shown in this repo's README), only the first one gets honored. Took me a minute to realize that the reason is because the listener only gets set in the mount event.
https://github.com/ChrisShank/xstate-vue2/blob/479b93786071a1136e5725dcf42a024c347fe560/src/useInterpret.ts#L81-L85
For this reason, it's a bit misleading to show usage of this directly in the setup portion of a function, since setup fires before the component mounts. I wonder if we could use an earlier hook in the component lifecycle, in useInterpret.ts?

Thanks for filing an issue! Could you just share a small example of what you are describing? Just want to make sure I understand!
I’ve known there was a potential bug here since I ported this lib… the onMounted isnt necessary imo, but I wanted to keep the API/behavior the same so someone could easily move to @xstate/vue.

@ChrisShank Sure! I have a Vue component that looks like this:
<template>
  <div v-text="state.value.playing" />
</template>

<script lang="ts" setup>
import { sampleMachine } from './sample-machine';
import { useMachine } from 'xstate-vue2';

const { state, service } = useMachine(puzzleCoreMachine);

service.send('EVENT_1');
service.send('EVENT_2');
</script>

Both of those service.send() calls happen before the useInterpret's mount event, so only the last send() gets honored. (And even then, I think the only reason it works is because that send() changes the state of the core machine, so useMachine thinks it's the "initial" state.)
Does that make sense?

Interesting… Im not sure that creating the the subscription in mounted would affect what you are describing. I’ve put up a PR with your suggestion, but I need to do some more testing.

@ChrisShank Ah, I see what it is. You can't reproduce unless you have guards in place. With this state machine:
export const sampleMachine = createMachine({
  schema: {
    events: {} as
      | { type: 'EVENT_1' }
      | { type: 'EVENT_2' },
  },
  // eslint-disable-next-line @typescript-eslint/consistent-type-imports
  tsTypes: {} as import('./sample-machine.typegen').Typegen0,
  id: 'puzzleCore',
  predictableActionArguments: true,
  initial: 'playing',
  states: {
    playing: {
      initial: 'state1',
      states: {
        state1: {
          on: {
            EVENT_1: { target: 'state2', cond: 'guard1' },
          },
        },
        state2: {
          on: {
            EVENT_2: { target: 'state2', cond: 'guard2' },
          },
        },
      },
    },
  },
}, {
  guards: {
    guard1: () => true,
    guard2: () => false,
  },
});

...if you run these two transitions in the root of a script/setup component:
service.send('EVENT_1');
service.send('EVENT_2');

...you should still be in state2. The bug is that you won't be. This will be the case if you run them inside an onMounted event, but it's not the case if you run it in the root.

@martynchamberlin thanks for clarifying! Is EVENT_2: { target: 'state2', cond: 'guard2' }, a typo? You would be transitioning to the same state?

Published<EMAIL_ADDRESS>The forking the reproducer and bumping the version looks like a fix. https://stackblitz.com/edit/vite-skoepc?file=package.json


Refactor to another library

#36

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Republishing to Nexus in case of no new commits

When executing the release task on a branch with no new commits after the already tagged and released version, the plugin tries to re-release the version.
This has at least one unwanted side-effect: the plugin tries to republish already published release versions to the used repository manager(s).
Expected behaviour: republishing already released versions is not allowed and the plugin should warn the user of this fact and the release procedure should be aborted (no publish to a repository manager)

The gradle-git plugin doesn't provide anything for publishing, so I'm not sure there's anything that could be done here. There's a prepare task and a release task that cover the Git tag/push. But besides that, the plugin relies on the user adding dependencies on other tasks they want included in the release.
Let me know if I'm misunderstanding what you're looking for.

Maybe then my setup is wrong.
Basically what I want to prevent is the republishing of already released
versions.
Somehow as I see it, the release task could remove all tasks that depend on
it from the taskgraph to prevent them from being executed in case there is
nothing new to be released, but that may not be a recommended Gradle
solution.
Which solution could you recommend to avoid the republishing scenario?
Op 28 sep. 2017 03:21 schreef "Andrew Oberstar"<EMAIL_ADDRESS>The gradle-git plugin doesn't provide anything for publishing, so I'm not
sure there's anything that could be done here. There's a prepare task and a
release task that cover the Git tag/push. But besides that, the plugin
relies on the user adding dependencies on other tasks they want included in
the release.
Let me know if I'm misunderstanding what you're looking for.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ajoberstar/gradle-git/issues/269#issuecomment-332699944,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJWmxdz02JUbqmEa2sZ_NzZWyUjVbkrNks5smvSOgaJpZM4PmPIm
.

Maybe an up-to-date when head is tagged with a version compatible with the
release context?
Op 28 sep. 2017 03:21 schreef "Andrew Oberstar"<EMAIL_ADDRESS>
The gradle-git plugin doesn't provide anything for publishing, so I'm not
sure there's anything that could be done here. There's a prepare task and a
release task that cover the Git tag/push. But besides that, the plugin
relies on the user adding dependencies on other tasks they want included in
the release.
Let me know if I'm misunderstanding what you're looking for.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ajoberstar/gradle-git/issues/269#issuecomment-332699944,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJWmxdz02JUbqmEa2sZ_NzZWyUjVbkrNks5smvSOgaJpZM4PmPIm
.

You could add an onlyIf check on the tasks you don't want rerun that would check if the project version already has a tag. I don't think this is a good general solution, but may work for what you're describing.
As for any changes in gradle-git itself, given the status of the project (see the readme), I won't be doing anything more than bug fixes.


fix: revert wait_for_block_device_to_appear implementation

revert to previous wait_for_block_device_to_appear implementation https://github.com/ydb-platform/nbs/commit/98ac178cc7fc1cf886f38dae7ae5367780629686#diff-536ed3f8ea3b7c4f96c4e0fa2c894a1ee506c2da759d2ee1c77a334199779477

I think that we should instead of this revert, we should do readlink -f for the /dev/disk/by-id/virtio-b*.  This comment should be resolved. I do not think that the change from using lsblk/udevadm to symlinks in /dev/disk would fix the issue with disks being not found for 120 seconds though.

I think that we should instead of this revert, we should do readlink -f for the /dev/disk/by-id/virtio-b*. This comment should be resolved. I do not think that the change from using lsblk/udevadm to symlinks in /dev/disk would fix the issue with disks being not found for 120 seconds though.

Let's fix tests first and return to proper "wait block device" implementation later.


Indicate what type of atom it is in AtomicScene

I am thinking something such as a label underneath or a implementation such as Phet's radioactive decay simulator.

Fixed this a few commits ago, it now says element name and #!


[FEATURE] Add-PnPNavigationNode Set the option "Open in new tab" on navigation links

Is your feature request related to a problem? Please describe.
As of October 2022 Microsoft has added the option "Open in new tab" to navigation links.
Today this is not possible to configure with PNP Powershell.
Describe the solution you'd like
Add-PnPNavigationNode should have an extra property of type bool called something like "OpenInNewTab"
This should also be supported in Get-PnPSiteTemplate and Invoke-PnPSiteTemplate
Describe alternatives you've considered
As far as I know there is no alternative to this
Additional context
Relevant Microsoft 365 roadmap

Hello,
I just found this question, Do you know if there is something avaliable in pnp provisioning  to set up a node to be open in a new tab? since this is available on Oct 2022

This would be a great enhancement, also in the context of provisioning templates. There exists a property "external", but I do not get, what that does.

Are there any changes for this requirement or it still is not considered yet ?
Microsoft has been recommending to use PnP PowerShell for developments and scripts however still its missing many parameters.

Looking forward for this to be included.

I'm having the similar results as fm-kotwicki, no errors but Open in a new tab is not checked when I edit via GUI


[Feature Request] Add compatibility with vanilla clients

I'm using RpgDifficulty as a server-side mod and it seems to work just fine with vanilla clients. The only downside is that you can't see the nameplates so I was wondering if you could make it so it works with vanilla clients by renaming the mobs on the server side. Maybe toggling an option so the mods stops sending packets to the vanilla client.
Thanks.
edit: maybe you could do something like this mod https://modrinth.com/mod/healthcare
(compatibility with it would be awesome)

Closing as the dev's goal is not to provide one-sided mods

Source: developer's discord server


--reprocess flag on pachctl edit does not reprocess datums

What happened?:
I ran pachctl edit pipeline --reprocess, which triggered another job in that pipeline in which all datums were skipped (not reprocessed).
What you expected to happen?:
I expected all datums in that pipeline to be reprocessed, but instead they were skipped
How to reproduce it (as minimally and precisely as possible)?:
Run pachctl edit pipeline --reprocess on a pipeline, make a very minimal change.
Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version): 1.15.2
Pachyderm CLI and pachd server version (use pachctl version): 1.9.7
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s): aws (EKS)
OS (e.g. from /etc/os-release):
Others:

I'm not seeing a reprocess as a flag on pachctl edit. I'm not sure we actually even need edit given we have update pipeline.
Usage:
pachctl edit [command]
Available Commands:
pipeline    Edit the manifest for a pipeline in your text editor.
Global Flags:
--no-color   Turn off colors.
-v, --verbose    Output verbose logs
Use "pachctl edit [command] --help" for more information about a command.

I'm seeing it as a flag on the pipeline subcommand:
pachctl edit pipeline -h                                                                                ✱ add-internal-fdqn-output-from-gateway
Edit the manifest for a pipeline in your text editor.

Usage:
  pachctl edit pipeline <pipeline> [flags]

Flags:
      --editor string   Editor to use for modifying the manifest.
      --reprocess       If true, reprocess datums that were already processed by previous version of the pipeline.

Global Flags:
      --no-color   Turn off colors.
  -v, --verbose    Output verbose logs

I've found it useful because update pipeline requires a JSON file, or otherwise requires all information about the pipeline. If i just want to quickly trigger a reprocess I can use edit and make a minor change to the layout.
That would be a good feature if it doesn't already exist - the ability to trigger a reprocess without updating the pipeline. Does that exist?

update pipeline works great even if you just pass it the same manifest that's already running, but I understand the value of what you're asking with edit pipeline.

My problem with update pipeline is that my manifest is dynamically generated during CI (we actually use the python_pachyderm library for deployment), so I don't generally have a manifest on hand that I can pass into it.

FYI, you can use pachctl extract pipeline <pipeline> | pachctl update pipeline.

That is good to know! That's exactly what I need. Thanks.

@JoeyZwicker I confirmed that the --reprocess flag exists in 1.9.7.

This is a real bug the issue is that while reprocess is being set in the request, the salt for the pipeline is also being set which is overriding the reprocessing behavior.

Fixed by #4265.


Generate address native base58 check

Fixed #2 Shoutout to @CryptoSpaces
Updated readme with contributors
Tests

Coverage increased (+2.3%) to 98.45% when pulling e0dbb652d61e09ee0abd19504a6601f6967a6a5a on generateAddressNativeBase58Check into 284fa11a2b4ebaa512a5f259af7822a241a3ad5b on development.


Fix FreeBSD Cirrus CI build

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description
It's now available in two flavours: qtkeychain-qt5 and qtkeychain-qt6
We change our dependency from qtkeychain to qtkeychain-qt5 to keep things working

Looks good to me!


added cl_half support for test_conversions

According to issue description (conversions section):
https://github.com/KhronosGroup/OpenCL-CTS/issues/142
Additional remarks:

In the process of adding cl_khr_fp16 support source code was unified and as result heavily refactored.

Some pieces of code (eg. InitCL fuction) stayed as it was previously for the sake of comparison purposes. For consistency I would suggest to move it to methods (eg. ConversionsTest::SetUp).

Please take a closer look at method DataInfoSpec<>::init under condition is_in_half(). There is new code to initialize array of cl_half values for conversions. It was source of the problem due to some special values which brought undefined results. ATM this code avoids those problematic values.

Capacity of test was decreased. I had some difficult time trying to figure out why this number is so extremely big. I will appreciate your feedback. I limited number of tests to 16 777 216 conversions (uint64_t lastCase = 1000000ULL;)

At my machine intel driver do not implement some of kernel functions which I think should be available:

#pragma OPENCL EXTENSION cl_khr_fp16 : enable
__kernel void test_convert_half_sat_uchar( __global uchar *src, __global half *dest )
{
   size_t i = get_global_id(0);
   dest[i] = convert_half_sat( src[i] );
}
Build not successful for device "Intel(R) UHD Graphics [0x9a60]", status: CL_BUILD_ERROR
Build log for device "Intel(R) UHD Graphics [0x9a60]" is: ------------
3632:5:14: error: implicit declaration of function 'convert_half_sat' is invalid in OpenCL
   dest[i] = convert_half_sat( src[i] );

thus I wasn't able to finalize all tests successfully. I am counting on some help here, thanks!

In the process of adding cl_khr_fp16 support source code was unified and as result heavily refactored.

Have you considered doing this unification/refactoring in a new pull request on its own?  I would recommend doing so.  We should hopefully be able to merge such refactorings relatively sooner.  Then the changes for actually adding half support should be smaller, which benefits reviewers (a smaller patch is easier to review) and you (a smaller patch is easier to keep up to date).

Thanks for your feedback!

Have you considered doing this unification/refactoring in a new pull request on its own? I would recommend doing so.

yes, I think I have specific commit which is good candidate to separate work on unification and extension of test's functionality - so this is still an open door for us. On the other hand there were arguments to stick to single PR:

it turns out that the unification code takes ~75%+ of whole task. Please correct me if I am wrong but my conclusion was that reviewing of unification PR will take approximately the same time as slightly bigger one introducing cl_khr_fp16 extension support.

vast majority of the code responsible for the logic of the test stayed intact. What really changed is a wrapper layer around that logic + couple of necessary conditions. Thus I don't expect any major issues to investigate. BTW I had no problems with successful launch of whole unified test.

If you think those are not good enough to stick to single PR then let me know and I will start refactoring work on splitting it.

If you think those are not good enough to stick to single PR then let me know and I will start refactoring work on splitting it.

I can't speak for others so please don't take my opinion too strongly.  Maybe I'm the minority here who prefer multiple smaller commits/PRs that each do one thing instead of a large monolithic PR that does multiple things.
But to illustrate a point: this PR already seems to conflict with the main branch; and the larger the PR, the higher the chances of such conflicts occurring.  Hence I believe that doing the refactoring separately will simplify maintenance of this PR in the long term (as we will probably need to give vendors a fair amount of time to test the new fp16 coverage on their devices, whereas generic refactorings shouldn't need as much time).

We are still reviewing this change.

We would like to double check results at our end, can we get some more time.

We are having trouble testing and verifying this PR. Could this PR be split into two changes, one for the code refactoring and the other for enhancing fp16 coverage?

We are having trouble testing and verifying this PR. Could this PR be split into two changes, one for the code refactoring and the other for enhancing fp16 coverage?

@lakshmih here is PR with modernized conversions without cl_khr_fp16 support

This will need a rebase now that #1719 has landed.

FYI, I'm seeing failures here too, looking into them now.

This PR needs a new owner, so for now I've removed "focused review" and added "help wanted".

I spoke too soon, and I'm seeing a few failures in double to half conversions, for non-round-to-even rounding modes:
Example for: test_conversions half_rtn_double -w -1
Building convert_half_rtn( double ) test
Testing... .
Error for vector size 1 found at 0x00003f76:  *-0x1.8p+1 vs -0x1.804p+1
Input value: -0x1.8000000000001p+1  (convert_half_rtn( double ))
         *** convert_halfn_rtn( doublen ) FAILED **
conversions FAILED

I'm checking to see if this is an issue with our implementation or with the tests.

I think we should merge this as-is and fix any bugs that appear.
@lakshmih can you run a "wimpy" test first to gain confidence that the changes are OK?  Maybe even a scalar-only "wimpy" test?  This finishes fairly promptly on our devices.
Example: test_conversions -w -1

I just created an fp16-staging branch, as we discussed.  If this PR is retargeted at this branch I will merge it, also as we discussed.
It's been a few days now though.  @lakshmih has your testing completed?  If so, would we be OK to merge this to the main branch, instead?

I just created an fp16-staging branch, as we discussed. If this PR is retargeted at this branch I will merge it, also as we discussed.

@bashbaug I've created new PR to be merged with fp16-staging branch

Removing "focused review", since we are reviewing and merging changes into the staging branch now.

This PR was merged to main branch along with #1975, closing


npm version: 2 years old?

Hi, I worried from reading https://www.npmjs.com/package/pegjs that pegjs wasn't maintained any more. but I took a look at the commit history and development's still going strong.

In the past, PEG.js development intensity varied greatly, depending mostly on the amount of time I could (and wanted) to spend on it. Things should be more stable now as PEG.js is basically my “20% project” at Jut.
The 0.9.0 release is close, see this comment and #364 for details.

cool, thanks!


Rackspace CloudFiles

Interested in using Laravel Stapler with Rackspace CloudFiles rather than Amazon S3.
If we were to dev this change, would you merge the pull request?

Better yet, can Stapler use L5's Filesystem abstraction?
http://laravel.com/docs/5.0/filesystem


lev now converts expections in routines to fatal errors

lev now converts expections in routines to fatal errors and provides mechanisms for resurfacing those exceptions as well as raising any other errors as exceptions

@Dantemss @kevinburleigh75 please let me know what you think.

does this still abort transactions?

Rough experimentation by kb yesterday says yes. Since just converts exception to fatal error (which aborts transactions) should be fine. I know lev needs better tests. Volunteers? :-)
I tried some in memory active record stuff that doesn't seem to work

On Jan 14, 2015, at 11:03 AM, Dantemss<EMAIL_ADDRESS>wrote:
does this still abort transactions?
—
Reply to this email directly or view it on GitHub.


Help is needed to manage ambiguity

Hello,
I have the following rules for declaring variables:
state_declaration: DATA_FLOW var_declaration
DATA_FLOW: ("input" | "output" | "parameter")
var_declaration: (type | state_compartment) variable_name
type: PRIMITIVE_TYPE
PRIMITIVE_TYPE: "Boolean" | "Integer" | "Real"
state_compartment: name
variable_name: name
name: (ALPHABETIC_CHARACTER (ALPHABETIC_CHARACTER | DIGIT)*)
ALPHABETIC_CHARACTER: "a" | "b" | "c" | "d" | "e" | "f" | "g" | "h" | "i" | "j" | "k" | "l" | "m"
| "n" | "o" | "p" | "q" | "r" | "s" | "t" | "u" | "v" | "w" | "x" | "y" | "z"
| "A" | "B" | "C" | "D" | "E" | "F" | "G" | "H" | "I" | "J" | "K" | "L" | "M"
| "N" | "O" | "P" | "Q" | "R" | "S" | "T" | "U" | "V" | "W" | "X" | "Y" | "Z"
DIGIT: "0" | "1" | "2" | "3" | "4" | "5" | "6" | "7" | "8" | "9"
Everything works fine until I choose a variable name which causes ambiguity. For example, the following variable declaration can be parsed correctly:
input Real value
and the relevant tree nodes are as follows:
Tree(var_declaration, [Tree(type, [Token(PRIMITIVE_TYPE, 'Real')]), Tree(variable_name, [Tree(name, [Token(ALPHABETIC_CHARACTER, 'v'), Token(ALPHABETIC_CHARACTER, 'a'), Token(ALPHABETIC_CHARACTER, 'l'), Token(ALPHABETIC_CHARACTER, 'u'), Token(ALPHABETIC_CHARACTER, 'e')])])])
However, when I choose a variable name such as inputValue the problems start
input Real inputValue
and the relevant tree nodes are as follows:
Tree(var_declaration, [Tree(state_compartment, [Tree(name, [Token(ALPHABETIC_CHARACTER, 'V'), Token(ALPHABETIC_CHARACTER, 'a')])]), Tree(variable_name, [Tree(name, [Token(ALPHABETIC_CHARACTER, 'l'), Token(ALPHABETIC_CHARACTER, 'u'), Token(ALPHABETIC_CHARACTER, 'e')])])])
I would like to ask about a way to avoid confusion and make the parser read inputValue as a variable_name.
Thank you

Normally something like "name" is done as a token/terminal instead of a parse tree.
// change:
name: (ALPHABETIC_CHARACTER (ALPHABETIC_CHARACTER | DIGIT)*)
// to:
NAME: /[A-Za-z][A-Za-z0-9]*/
// change uses of: name
// to: NAME

This should fix your problem.

Thank you for your response, I actually cannot use name as a terminal because it can have several options, what I provided in my first example is just a snapshot, the name can have the following rule:
name: identification | quoted_identification
identification: (ALPHABETIC_CHARACTER (ALPHABETIC_CHARACTER | UNDERSCORE | NON_ZERO_DIGIT | ZERO)*) //- (keyword)
quoted_identification: "'" (PREV OPEN_PARENTHESES reference CLOSE_PARENTHESES)"'"

Okay leave name as-is, but then make identification a regex:
name: ID | quoted_identification
ID: /[A-Za-z][A-Za-z\d_]*/

Try that. This is the normal approach seen everywhere. At the "bottom" is a regex defining a name of some kind.

Thank you for your support, what you suggested works well for me. I would like to ask if it is possible to exclude any keywords from the name, meaning the name should not be any of the keywords.

You're welcome.
Keywords seem to happen automatically. For example, my grammar has a keyword "repeat" which I'm not able to use as a NAME. The keywords you use in the grammar get higher precedence.  Or maybe it's because I put my NAME token definition at the bottom.
If you have problems with this, move your ID further down in your grammar.
Also, check out https://gitter.im/lark-parser/Lobby for discussion and help.

I think you can close this issue now.


Allow single stubs to be removed in test mode

Hope this is a welcome possibility. I've got a test suite where folks want more fine-grained cleanup in their tests:
  before(:all) do
    Geocoder::Lookup::Test.add_stub(
      "New York City, NY", [
        {  'coordinates'  => [40.7143528, -74.0059731] }
      ]
    )
  end

  after(:all) do
    Geocoder::Lookup::Test.delete_stub('New York City, NY')
  end

We didn't want to reset because the default stub doesn't need to change across the suite.
I took a stab at a name (delete, versus the word reset you use elsewhere, or maybe a more generic remove). Happy to take feedback. The unit test is also a little indirect, but I think it covers the case?

Yes, I like this. Thanks for the test, the docs, and the clean code!


[Feature]: Add config of use_dummy_driver rather than default 'False'

🚀 The feature, motivation and pitch
I find out two limitation, with the unmodifiable param use_dummy_driver of the method RayGPUExecutor._run_workers , when I use entrypoints LLM() to submit vllm jobs to the local ray cluster on ray head node.
    def _run_workers(
        self,
        method: str,
        *args,
        async_run_remote_workers_only: bool = False,
        all_args: Optional[List[Tuple[Any, ...]]] = None,
        all_kwargs: Optional[List[Dict[str, Any]]] = None,
        use_dummy_driver: bool = False,
        max_concurrent_workers: Optional[int] = None,
        use_ray_compiled_dag: bool = False,
        **kwargs,
    ) -> Any:

The architecture of VLLM is shown as below. With the use_dummy_driver  set to False by default, the local driver_worker is always called. It works fine with only one vllm job, while two issues come out with multiply vllm jobs submitted.

Limitation of the parallel vllm job count. The total vllm job count is limited by the gpu count of the node job submitted to, while the local driver_worker must occupy one gpu.
Limitation of vllm integration. In my own codes__main__, I set the CUDA_VISIBLE_DEVICES and init the distribution env to run the raw llm code. While the torch cuda device cannot be updated once it is loaded, the torch cuda device of driver_worker will not be changed with the update of CUDA_VISIBLE_DEVICES, because it is in the same process of my customized__main__ process. I have to modify my own code if I want to  integrate vllm.

        # Set environment variables for the driver and workers.
        all_args_to_update_environment_variables = [({
            "CUDA_VISIBLE_DEVICES":
            ",".join(map(str, node_gpus[node_id])),
            "VLLM_INSTANCE_ID":
            VLLM_INSTANCE_ID,
            "VLLM_TRACE_FUNCTION":
            str(envs.VLLM_TRACE_FUNCTION),
        }, ) for (node_id, _) in worker_node_and_gpu_ids]
        self._run_workers("update_environment_variables",
                          all_args=all_args_to_update_environment_variables)

To fix the two limitation, I add use_dummy_driver to the parallel_config to use the driver_dummy_worker rather than the local driver_worker.
Here is the pr#5599
While the fix can remove the limitation mentioned above, I can not figure out the reason why vllm must use the local driver_worker. In my opinion, it can reduce the cross-process communication between the rank-0 worker, while it makes vllm run in a limited distributed way.
Alternatives
No response
Additional context
the test of torch cuda visible device

No response

Here is my pr to add use_dummy_dirver config
#5599

In the near future we would like to remove dummy worker. Stay tuned.

In the near future we would like to remove dummy worker. Stay tuned.

I'm looking forward to that day. BTW, I'd like to apply this pr to my own code while it can avoid the local driver_worker without any other influence to the usage of vllm.

In the near future we would like to remove dummy worker. Stay tuned.

I've read the latest roadmap and found out the target Provide non-ray option for single node inference, is this the approach to remove dummy worker. Would you like to introduce more about the newest design of the ray_gpu_executor, I am focus on the integration of vllm during my recent job and maybe I can do some contribution.


This is a work around. It finds any mask items that are None and remo…

This is a work around. It finds any mask items that are None and removes them. This is a sufficient temporary fix until the entire Dimensions conversion code is re-written using xmltodict instead of lxml.

This will resolve https://github.com/Quantipy/quantipy/issues/6

:+1:


Windows Support (#735)

Summary:
Hello :hand:
This PR gets OpenSfM to compile and run on Windows!
The main points that have been addressed:

[x] Rewrote the memory functions in context.py to work on all three platforms (Windows, Mac, Linux). This adds a new small dependency (vmem).
[x] Added a bin/opensfm.bat script for invoking the program.
[x] Some minor compilation issues related to Visual Studio are addressed. The definition of M_PI is a bit.. hackish, but the alternative is to include:

#define _USE_MATH_DEFINES
#include <cmath>

In a lot of places where M_PI is referenced. I'm not sure that's better (but I can change it if you want). I'm also unsure of what side effects the _USE_MATH_DEFINES macro might do. :bomb:

[x] Updated the docs with build instructions for Windows.
[x] Installs opencv-python as a pip dependency on Windows only; this is because vcpkg builds of OpenCV don't provide a version with OpenCV's Python bindings. This only affects Windows environments (it won't install on Mac or Linux).

I hope this can be useful to others.
Pull Request resolved: https://github.com/mapillary/OpenSfM/pull/735
Differential Revision: D29959025
Pulled By: YanNoun

@pierotofy we're on the verge of merging it. What's the purpose of the opencv-python==<IP_ADDRESS> ; sys_platform == "win32" in the requirements ?

The OpenCV python bindings (import cv2) are not included in vcpkg, so they need to be installed separately.
If we don't want to explicitly include this in the requirements.txt, we can always just add an install step in the docs to tell people to install opencv-python separately.


Price modifier only x2, can't increase more

This "issue" was fixed some month ago, but now it does'nt work anymore :( I'm playing Curse of Strahd, and would LOVE to be able to increase the price modifier to x10.
I think a bigger slider would be amazing for a lot of DM's :D

Fixed in: https://github.com/jopeek/fvtt-loot-sheet-npc-5e/pull/142


react.js support

Hello I'd like to use this for a React.js application where i have object-fit and object-position for a spritesheet.
I have my react component programmatically set the style. React will however automagically strip fontFamily:.. from the element. Would it be possible to come around this?

At some point I want to change the API to use background-size instead, but I don't see why react wouldn't work at the moment.
What's stripping fontFamily exactly and why?

I thought it was react, it is actually my browser (chrome) that removes it.

If it's being removed it's probably invalid, make sure it has the quotes:
.img {
   object-fit: contain;
   font-family: 'object-fit: contain;'
}

This is invalid CSS:
.img {
   object-fit: contain;
   font-family: object-fit: contain;
}

@bfred-it the problem was that i had to set styles programmatically ie
  <img style={{objectPosition: `0 {-spritePos}px`}} />

react will set the style prop using element.style[styleName] = styleValue..
The browser, Safari for instance, will however not add it at all if its not recognized. The same thing happenes in chrome when you do node.style['fontFamily'] = 'object-fit: foo; etc'

Yeah I guess that's not supported yet, you would have had to do this:
<img style={{objectPosition: `0 {-spritePos}px`; fontFamily: 'object-fit: contain; object-position: `0 {-spritePos}px`;' }} />

But OFI doesn't update values like that. You might just have to wait for v3

Actually you can use this syntax right now:
<img style={{objectPosition: `0 {-spritePos}px`; backgroundPosition: `0 {-spritePos}px`}} />

background-position already works, no need to include it in font-family (you still need object-fit in font-family though)

You're right! I was missing the quotes! Thanks!

It's works with react-jss. Thank you.

is not working

is not working


Unhandled Promise Rejection from handleFormSubmit when using Prisma and Safari

Hi. I've been having difficulties integrating this into my app so I created a test repo to help diagnose my issues.
https://github.com/spencersolberg/remix-passkey-test
It seems to work fine when using the fake in-memory database from the README in both Arc (Chromium) and Safari. Both registration and authentication works with that setup.
When I switch to a real Prisma database, registration still works for both browsers, however I cannot get authentication to work on Safari.
I only get this error in the browser console when I click authenticate:

Thanks for making a reproduction repo. Unfortunately, I was not able to reproduce this. I registered and then authenticated using Safari, and was able to log in properly in both circumstances.
I'm not sure how I can be helpful, but if you find out anything else let me know.


go client reports invalid connection after idle for wait_timeout

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)

dbt.mustExec("SET @@SESSION.wait_timeout = 2")

// wait for TiDB to close our connection
time.Sleep(3 * time.Second)

tx, err := dbt.db.Begin()
if err != nil {
	dbt.Fatal(err)
}

2. What did you expect to see? (Required)
The driver logs packets.go:122: closing bad idle connection: EOF 3 times but dbt.db.Begin doesn't report any errors because it creates a new connection internally and then retry.
3. What did you see instead (Required)
The driver logs packets.go:37: unexpected EOF and dbt.db.Begin reports invalid connection.
4. What is your version? (Required)

master.
The reason:
TiProxy doesn't close the connection immediately after wait_timeout and still receives requests. After it receives the request, it finds that TiDB has disconnected and then closes the client connection. So the client encounters an ErrInvalidConn in readPacket instead of ErrBadConn in writePacket.
The client will retry by creating a new connection if encounters ErrBadConn but won't retry if encounters ErrInvalidConn, see https://github.com/golang/go/blob/master/src/database/sql/sql.go#L1536-1546
I think there's no way to solve it.

Maybe a workaround is to add a client idle timeout to tiproxy configuration, like client timeout in haproxy: https://www.papertrail.com/solution/tips/haproxy-logging-how-to-tune-timeouts-for-performance/


apiv2(ticdc): resign owner

What problem does this PR solve?

Issue Number: ref #8019
What is changed and how it works?
resign owner api
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/merge


uint8, uint16, uint32, and uint64 in kernels

A forthcoming PR will update the RNG to use these types.
Also:

Add tests for the //, <<, and >> operators.
Change TensorWrapper to unwrap objects when the resulting object would be simpler.
Clean up throw_unreachable, since it was triggering compiler warnings.

You can see the RNG changes (plus a few other irrelevant ones) on my dev branch: https://github.com/openai/triton/pull/408/files

This is merged. Huge thanks!


Adds options menu to library

@smo-key Please review and sign off.
@ethan-schaffer @Shwinn Also please code review.

@Oksisane everything looks good to me after a quick scan

I trust you three. I am still a bit behind on the library. Now, if
something breaks, we know where the mistake probably is. ;-)
On Wed, Oct 14, 2015 at 11:23 PM, Shwinn<EMAIL_ADDRESS>wrote:

@Oksisane https://github.com/Oksisane everything looks good to me after
a quick scan
—
Reply to this email directly or view it on GitHub
https://github.com/lasarobotics/FTCLibrary/pull/31#issuecomment-148277025
.

:+1:
@homu r+

:pushpin: Commit efc64fc has been approved by smo-key

:hourglass: Testing commit efc64fc with merge 636740a...

:sunny: Test successful - status


Trying to fix make push-image

Signed-off-by: Bartosz Rybacki<EMAIL_ADDRESS>
What this PR does / why we need it:
Fix the build scripts, so that it is possible to push image to any repo.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

hack/build/build-image.sh: line 22: buildah: command not found
@awels do you know if there is and image available with buildah, you did change some lane build images in hpp lately

I switched to a container that had go in it. Don't know about buildah, let me see if I can find out.

For now I have switch to docker cli, so I can verify if everything works. If it works, then I can plan what to do next.

/retest

/approve


Fix tests failing due to Elixir 1.13 string representation of macros

Closes https://github.com/elixir-ecto/ecto/issues/3957.

@josevalim Is there a particular strategy Ecto uses for choosing Elixir versions to run the CI against? It's a couple versions behind now so I could work on updating the CI, if it's something that makes sense.

Typically three:

lowest Elixir version with lowest OTP version
highest Elixir version with lowest OTP version
highest Elixir version with highest OTP version


chore: setup codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@62c4e3d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #70   +/-   ##
=========================================
  Coverage          ?   96.42%
=========================================
  Files             ?       60
  Lines             ?      419
  Branches          ?        0
=========================================
  Hits              ?      404
  Misses            ?       15
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c4e3d...18d3a42. Read the comment docs.


Fixes crash in auction view controller caused by missing nullability specifier

I've added a macro so all properties, method parameters, etc on Artwork are assumed to be non-null, then added nullability specifiers for things that can be null (the artist property and methods that accept ObjC blocks).
As a result, if an artwork doesn't have an artist, its cell looks a little weird:

This happens rarely enough that this seems, to me, an acceptable solution. However, I'm open to suggestions :bow:
Fixes #1413.

1 Warning

:warning:
Needs testing on a Phone if change is non-trivial

  Generated by :no_entry_sign: danger

Ace 👍


add additional checks around whether a GnosisTransaction is cancelled or waiting to be indexed

Discussed with @rmeissner offline
Add checks or work around for safe-app-sdk's getBySafeTxHash or Safe Transaction API's getTransaction endpoint to ensure that we have a way to tell whether a transaction was actually cancelled (invaliated nonce) or whether it is marked as cancelled temporarily (nonce transaction detected but transaction has not yet been indexed).
For now we have a work around to only accept cancelled transactions that have cleared a few minutes after it's last updated date.

related issue which was flagged: https://github.com/safe-global/safe-client-gateway/issues/37


Issue with inherited _input_event()

Godot version:

3.1 from Steam
OS/device including version:

Windows 10 fully up to date, doesn't seem graphics-related.
Not sure if relevant but I have a Ryzen 5 1600, a GTX 1080, 16GB of ram.
Issue description:

I have a (brown) Door scene that I can click on to open. I created a (silver) LockedDoor class that inherited from the Door scene, but with additional functionality. The idea is to use a keypad and once you enter the correct combination, the door should open.
Once setting everything up, I placed a LockedDoor into my scene to test it out. I used a few print statements to try to troubleshoot and while it did recognize when I was in the area2d, it never once recognized my clicks on it. If i changed my code from _input_event(): to _input(): it did start to work but obviously it wasn't usable because everytime I clicked anywhere it would pull up the keypad, which isn't what I was going for.
What clued me in to this bug is that I follow an online tutorial and have copied the instructors code word for word all the way through. When he tested it, his worked fine, but mine did not. Granted, the course is in Godot 3.0, and I am running Godot 3.1, so maybe this isn't a bug and I just don't know how it works now... Unsure.
HOWEVER - I was able to get it to work how I wanted it to by completely deleting my LockedDoor.tres and LockedDoor.gd and restarting the client. I then build the LockedDoor.tres from scratch (and the .gd) and did it without the inheritance. THAT version did work. (I did not attach it because I am not sure if you'd want 2 projects, haha.)
This leads me to believe that there may be some issue with inheritance although I don't know what it is.
Steps to reproduce:
If you open the attached project, once you hit play, hit the space bar so you can actually see. I placed two easy access doors you should be able to just click on the brown door and see it open and then click on the silver door and it won't open or register the click.
Minimal reproduction project:

For_Godot.zip

For some reason your instanced locked door in the level don't have any collision layer bits enabled and that's why it doesn't work.

Thanks so much for this response. Sorry for putting this as a bug. I don't know why it did that since it did have the collision enabled in the LockedDoor scene.


Implement Appointment model and test

Codecov Report

Merging #72 (1aa3524) into master (ebe816c) will increase coverage by 0.35%.
The diff coverage is 94.28%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
+ Coverage     76.49%   76.85%   +0.35%
- Complexity      471      487      +16
============================================
  Files            77       78       +1
  Lines          1455     1486      +31
  Branches        144      152       +8
============================================
+ Hits           1113     1142      +29
- Misses          308      309       +1
- Partials         34       35       +1

Files
Coverage Δ

...va/seedu/address/model/person/patient/Patient.java
96.55% <100.00%> (ø)

...a/seedu/address/model/appointment/Appointment.java
93.54% <93.54%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add in flickr attribution message in bottom-right hand corner

'This product uses the Flickr API but is not endorsed or certified by Flickr.'

Added subtle Flickr Attribution

@justin0022


[dv/lc_ctrl] Support coverage for regwen = 1 and writing to locked regs

Description
The sequence has below scenario:
1). claim the mutex lock
2). write to transition registers and start lc transition.
But in automatic collected functional coverage group, the regwen = 1 is not collected.
I tagged it to V3 because clearly we have the sequence (otherwise we cannot create any lc transition). We just need to update csr mirrored value.

I believe this should probably wait until a later milestone, as it's a V3 issue. Marking as a triage priority.

Moving to M7 because this is part of V3 signoff.

Moving V3 tasks to the next release of EarlGrey.


Couldn't install charts because of existing resources

I have issue with installing calico with tigera-operator.
First I installed in application's namespace so that I uninstall charts and re-install to tigera-operator namespace, but It fails with errors below.
Error: rendered manifests contain a resource that already exists.  Unable to continue with install: Namespace "tigera-operator" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "calico"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "tigera-operator"
Expected Behavior

Succefully install calico with no errors
Or indicate which resources are issue

Current Behavior

Succefully install calico with no errors

Possible Solution

It could be better if there is guide to delete old resources manually.

Steps to Reproduce (for bugs)

install calico with this command helm install calico projectcalico/tigera-operator --version v3.21.4 to namespace-1
un-install calico with this command helm uninstall calico in namespace-1
re-install calico helm install calico projectcalico/tigera-operator --version v3.21.4 to tiger-operator namespace

Context
I found out there are un-removed CustomResourceDefinition as below
bgpconfigurations.crd.projectcalico.org               2022-02-11T06:34:30Z
bgppeers.crd.projectcalico.org                        2022-02-11T06:34:30Z
blockaffinities.crd.projectcalico.org                 2022-02-11T06:34:30Z
caliconodestatuses.crd.projectcalico.org              2022-02-11T06:34:30Z
clusterinformations.crd.projectcalico.org             2022-02-11T06:34:30Z
felixconfigurations.crd.projectcalico.org             2022-02-11T06:34:30Z
globalnetworkpolicies.crd.projectcalico.org           2022-02-11T06:34:30Z
globalnetworksets.crd.projectcalico.org               2022-02-11T06:34:30Z
hostendpoints.crd.projectcalico.org                   2022-02-11T06:34:30Z
ipamblocks.crd.projectcalico.org                      2022-02-11T06:34:30Z
ipamconfigs.crd.projectcalico.org                     2022-02-11T06:34:30Z
ipamhandles.crd.projectcalico.org                     2022-02-11T06:34:30Z
ippools.crd.projectcalico.org                         2022-02-11T06:34:30Z
ipreservations.crd.projectcalico.org                  2022-02-11T06:34:30Z
kubecontrollersconfigurations.crd.projectcalico.org   2022-02-11T06:34:30Z
networkpolicies.crd.projectcalico.org                 2022-02-11T06:34:30Z
networksets.crd.projectcalico.org                     2022-02-11T06:34:30Z
apiservers.operator.tigera.io                         2022-02-11T06:34:30Z
imagesets.operator.tigera.io                          2022-02-11T06:34:30Z
installations.operator.tigera.io                      2022-02-11T06:34:31Z
tigerastatuses.operator.tigera.io                     2022-02-11T06:34:31Z

and delete thems or  label thems manually like
labels
- app.kubernetes.io/managed-by=Helm
annotations
- meta.helm.sh/release-name=calico
- meta.helm.sh/release-namespace=tigera-operator

but It still generate the error above
Your Environment

Operating System and version: EKS 1.21
Link to your project (optional):

I think the error you're reporting is due to the helm chart you're using doesn't support installing to the tigera-operator namespace since that namespace is hard coded in the chart. See https://github.com/projectcalico/calico/issues/4812.
I think the CRDs not being removed is a separate issue, but I think that might just be the way CRDs are handled by helm.

If you think there is something here not covered by https://github.com/projectcalico/calico/issues/4812 feel free to respond here and I can re-open this. I think more appropriately would be to create an issue in https://github.com/projectcalico/calico, since that is the source of the chart I believe you are referring to.


Add in the new Scripts for the MJO ENSO use case

Describe the New Feature
These programs will calculate 30-90 day band pass filtered uflx, and wind power data
Acceptance Testing
List input data types and sources.
Describe tests required for new functionality.
Time Estimate
It is already completed by Cristiana Stan
Sub-Issues
Consider breaking the new feature down into sub-issues.

[ ] Add a checkbox for each sub-issue here.

Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2793541
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[ ] Select component(s)
[ ] Select priority
[ ] Select requestor(s)

Projects and Milestone

[ ] Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
[ ] Select Milestone as the next official version or Future Versions

Define Related Issue(s)
Consider the impact to the other METplus components.

[ ] METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

New Feature Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding source.
[ ] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

PR approved and merged


Feature/empty present

Coverage decreased (-59.3%) to 34.615% when pulling 741900b033bf6fa11fd360c032a7573125f88bc8 on feature/empty_present into e63f6ea221ff5016297cf3ca76c0c7be3f51b78d on master.

Coverage decreased (-59.3%) to 34.615% when pulling 741900b033bf6fa11fd360c032a7573125f88bc8 on feature/empty_present into e63f6ea221ff5016297cf3ca76c0c7be3f51b78d on master.

Coverage decreased (-59.3%) to 34.615% when pulling 741900b033bf6fa11fd360c032a7573125f88bc8 on feature/empty_present into e63f6ea221ff5016297cf3ca76c0c7be3f51b78d on master.

Coverage decreased (-78.4%) to 15.525% when pulling bca9eb7daf412082248ee6cae3bb975974b3b5eb on feature/empty_present into e63f6ea221ff5016297cf3ca76c0c7be3f51b78d on master.

Coverage decreased (-1.5%) to 93.162% when pulling 4d87d2e378b632387eb0353eb6afb4679c5abfea on feature/empty_present into 5b501c8e0953d9896c38769798e936dca5e3cb9f on master.

Coverage decreased (-1.5%) to 93.162% when pulling 4d87d2e378b632387eb0353eb6afb4679c5abfea on feature/empty_present into 5b501c8e0953d9896c38769798e936dca5e3cb9f on master.

Coverage decreased (-1.5%) to 93.162% when pulling 4d87d2e378b632387eb0353eb6afb4679c5abfea on feature/empty_present into 5b501c8e0953d9896c38769798e936dca5e3cb9f on master.

Coverage decreased (-1.5%) to 93.162% when pulling 4d87d2e378b632387eb0353eb6afb4679c5abfea on feature/empty_present into 5b501c8e0953d9896c38769798e936dca5e3cb9f on master.

Coverage decreased (-1.8%) to 92.909% when pulling 3700d191a81e5f924f5a87f2edd4a0ee9e2f955f on feature/empty_present into 5b501c8e0953d9896c38769798e936dca5e3cb9f on master.

Coverage decreased (-0.3%) to 94.362% when pulling<PHONE_NUMBER>9bbd1dcfdc152789533ab23ac8500a on feature/empty_present into 5b501c8e0953d9896c38769798e936dca5e3cb9f on master.


Rewrite commitstatus copy

Codecov Report
Attention: Patch coverage is 18.18182% with 36 lines in your changes missing coverage. Please review.

Project coverage is 48.17%. Comparing base (d710599) to head (4150c90).

Files with missing lines
Patch %
Lines

...nternal/controller/promotionstrategy_controller.go
15.78%
26 Missing and 6 partials :warning:

internal/controller/commitstatus_controller.go
0.00%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   45.01%   48.17%   +3.16%
==========================================
  Files          15       15
  Lines        1073     1071       -2
==========================================
+ Hits          483      516      +33
+ Misses        521      483      -38
- Partials       69       72       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bibliography partially loaded and PDF annotation imported

The extension is amazing but I'm facing a weird issue. I made sure my API was on “read-only” and that only “library access” was allowed. But when using the extension to cite a paper, I can retrieve only a very few of them and a bunch of annotations from some pdf files.

Thank you. I think this might be the same issue that we saw in #44. I will have another look next week.

The relevant code is in:
https://github.com/krassowski/jupyterlab-citation-manager/blob/6fd14d31d7572725b5ac372cc42adc40d4185b6e/src/zotero.ts#L358-L428

I have the same problem, 808 items in Zotero, but JupyterLab fetches only 300 citable items

I think the issue lies in the line below. The global counter is incremented by the page start index each time, so if we have 25 items in each index, then the start index will be 25, 50, 75 etc. Summing all these will be 25*n(n+1)/2.
In my case I have 1146 citations and I am downloading 250 citations which happens to be 25*ceil(-1/2 + sqrt((1/2)^2 + 2*1146/25)).
Similarly, in issue #44 note that 25*ceil(-1/2 + sqrt((1/2)^2 + 2*1146/25)) = 875.
I think the solution might be some a case of replace the line:
https://github.com/krassowski/jupyterlab-citation-manager/blob/6fd14d31d7572725b5ac372cc42adc40d4185b6e/src/zotero.ts#L395
with something like:
i = parseInt(nextParams.start, 10);

I'd raise a PR but not in a position to test it.

Thank you! I have released v0.3.2 including the fix from #61.


site(http_header): add nosniff and feature-policy

[x] Others (Update, fix, translation, etc...)

nosniff is to opt-out from mime-type sniffing.
Feature-policy is mainly to prevent third-party resources to access device sensors, e.g. to mitigate possible privacy risk. This header is highly experimental, so some of the directives are not supported in certain browsers.
ref: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy

🤔 embedded youtube still works even when 'speaker' is disabled.
next up is disqus.

Tested disqus.


Update aNP combinator

We either need to update the aNP combinator or create a new one that creates a NounPhrase.

aNP already creates a NounPhrase, so I'm assuming you meant NamedIdea.

Fixed with the addition of a_ from 1fd5d51551d60256b9d6b450efd1ff15e87d16cd


add lv_ll_ins_pos function

Hi,
Thank you very much! I like your updates!
Just two things to mention:

lv_ll_ins_prev might be a more intuitive name for the new function
in lv_task_handler after a function is executed on a lower priority (e.g. MID) the higher priority functions should be checked again. I see that in your update and it's a very good idea! However after the higher priority tasks are executed the next MID priority task should be executed not the first again. Else the order of adding task would be a high effect on the same priority. The lastly added would be checked more times.

Hi,
You're welcome。
1.Yes, I also think lv_ll_ins_prev function name more intuitive
2.Polling task list will not take up a few CPU time, because lv_task_exec function will go to judge whether the time has been met. However, it can add a judge, if this is the highest priority of the task is not re-polling. But, this still can not be avoided, if it is the same priority and not the highest priority, it still needs to be polled from scratch.
while(1){
endFlag = 1;
LL_READ(lv_task_ll,tmp){
if(true == lv_task_exec(tmp,tmp->prio)){
if(tmp->prio != LV_TASK_PRIO_HIGHEST){
endFlag = 0;
break;
}
}
}
if(endFlag) {
break;
}
}

You can also add a variable to record the highest priority registered task history, if the registered tasks are in the middle priority, then the highest priority is the middle history, delete the task to correct the highest priority in history, so Do not poll as long as the task is not equal to the highest priority in history, but doing so is more complicated.

If you feel that the task you created earlier is more important, you can modify the function that created the task to change the priority to less than or equal to less than it.
lv_task_create
....
if(tmp->prio < prio){    //change <= to <
new_lv_task = lv_ll_ins_pos(&lv_task_ll, tmp);
break;
}

Hi,
I thought something different. Let's say we have 6 tasks: H1, H2, H3 with HIGH priority  and M1, M2, M3 with MID priority.
When we poll the list and M2 is executed then H1, H2, H3, M1 will be checked again. If meanwhile  M1 and M3 become ready then M1 it will be executed. If M1 do something long then it will be executed again and prevents M3 to run even they have the same priority.
My idea is to register the interrupted priority and the interrupter task. When the polling starts again it should not call the tasks with interrupted priority before interrupter task.

Hi,
You are right, I did not consider this situation, just pushed an update on this issue, you see

Hi
Thank you!
Can you explain the purpose of list shorting? I thought a "smart" lv_task_create function which puts the tasks into the right position according their priority is fine.

Your email was blocked, I just saw it.
Because the task was created prioritized when creating the task,。
you see, In lv_task_handler function, the implementation of the task added to another list.
so wait for the task to be reordered after execution.

In order to solve the situation you said above, I added a new linked list, the lv_task_handler function after the completion of a task will be the task added to the new list.

Lv_task_create function to create the task according to the order of priority high to low list, lv_task_handler function in order to avoid that you say, I will run the task added to a new list, when all tasks After running, then the new list of tasks in the order inserted into the original task list.

See lv_task_handler function to achieve：
while(1){
endFlag = 1;
LL_READ(lv_task_ll,tmp){
if(true == lv_task_exec(tmp,tmp->prio)){
            /*1.Add a runned task to the new linked list*/
            lv_ll_chg_list(&lv_task_ll,&lv_task_runed_ll,tmp);
            endFlag = 0;
            break;
        }
    }
    if(endFlag) {
        break;
    }
}

//2. the new list of tasks in the order inserted into the original task list
lv_ll_sort(&lv_task_ll,&lv_task_runed_ll,lv_ll_sort_func_task);

I can't see where do you run the task's in lv_task_runed_ll when a task is executed and higher priority ones need to be executed again. What have I missed?
Based on your great idea (in lv_task_create() insert the task according to their priority) I wrote my solution:
/* Run all task from the highest to the lowest priority
 * If a lower priority task is executed check task again from the highest priority
 * but on the priority of executed tasks don't run tasks before the executed*/
lv_task_t * task_interruper = NULL;
lv_task_t * tmp;
while(1){
    LL_READ(lv_task_ll,tmp){

        /*Here is the interrupter task. Don't execute it again.*/
        if(tmp == task_interruper) {
            task_interruper = NULL;     /*From this point only task after the interrupter comes, so the interrupter is not interesting anymore*/
            continue;
        }

        /*Just try to run the tasks with highest priority.*/
        if(tmp->prio == LV_TASK_PRIO_HIGHEST) {
            lv_task_exec(tmp);
        }
        /*Tasks with higher priority then the interrupted shall be run in every case*/
        else if(task_interruper) {
            if(tmp->prio > task_interruper->prio) {
                if(lv_task_exec(tmp)) {
                    task_interruper = tmp;  /*Check all tasks again from the highest priority */
                    break;
                }
            }
        }
        /* It is no interrupter task or we already reached it earlier.
         * Just run the remaining tasks*/
        else {
            if(lv_task_exec(tmp)) {
                task_interruper = tmp;  /*Check all tasks again from the highest priority */
                break;
            }
        }
    }
}

In this approach we don't need to use lv_ll_sort which looks a little bit heavy.
What do you think?

Hi,
This program is a bit of a problem，Without the end of a flag, then the above two cycles will die cycle.
With your previous model, I made a slight modification，I'll talk about it。
Let's say we have 8 tasks: H1, H2, H3, H4 with LV_TASK_PRIO_HIGHEST priority and The respective priorities of M1, M2, M3 and M4 are LV_TASK_PRIO_HIGH, LV_TASK_PRIO_MID, LV_TASK_PRIO_LOW, LV_TASK_PRIO_LOWEST.
When we poll the list and M2 is executed then H1, H2, H3, H4, M1 will be checked again.If meanwhile M1、M3 and M4 become ready then M1 it will be executed.
If M1 do something long then ,H1, H2, H3, H4 will be checked again. Then M3,M4 after the executed of each may be run again after M1.
What I want to say is that the long executions of the kind of tasks you said earlier, if they exist, are likely to iterate over each other's tasks, causing the program to cycle through.
I submitted before the two linked list of programs think so, to ensure that the outer loop call lv_task_handler function, its internal task list in order of priority, each task has at least one execution opportunity.
Because the lv_task_handler function is called by the loop, the next call lv_task_handler function, or by priority from high to low order of execution.

LL_READ function is also a loop, if you jump out of a loop, LL_READ function will read back from the list header, then the beginning of this judge will set it to NULL, and then continue to find out.
if(tmp == task_interruper) {
task_interruper = NULL;     /From this point only task after the interrupter comes, so the
interrupter is not interesting anymore/
continue;
}

Hi,
You are right, I messed the end_flag, it is required.
In your suggestion: Use the "names" from your example (H1, H2 ...). What if M1 become ready very often (just for example in every milliseconds) An mean while H1 will be ready in every 10 milliseconds. Then the expected behavior is to after each M1 run check Hx and execute H1 when ready.
If I understood your code well then you remove the executed H1 from lv_task_ll there fore it has no chance to run again when M1 is executed. As you said in your implementation: "each task has at least one execution opportunity" However THe HIGHEST priority newer should wait until all lower priority task is ready.
Here is my refined code with and_flag:
/* Run all task from the highest to the lowest priority
 * If a lower priority task is executed check task again from the highest priority
 * but on the priority of executed tasks don't run tasks before the executed*/
lv_task_t * task_interruper = NULL;
lv_task_t * tmp;
do {
    end_flag = 1;
    LL_READ(lv_task_ll,tmp){

        /*Here is the interrupter task. Don't execute it again.*/
        if(tmp == task_interruper) {
            task_interruper = NULL;     /*From this point only task after the interrupter comes, so the interrupter is not interesting anymore*/
            continue;
        }

        /*Just try to run the tasks with highest priority.*/
        if(tmp->prio == LV_TASK_PRIO_HIGHEST) {
            lv_task_exec(tmp);
        }
        /*Tasks with higher priority then the interrupted shall be run in every case*/
        else if(task_interruper) {
            if(tmp->prio > task_interruper->prio) {
                if(lv_task_exec(tmp)) {
                    task_interruper = tmp;  /*Check all tasks again from the highest priority */
                    end_flag = 0;
                    break;
                }
            }
        }
        /* It is no interrupter task or we already reached it earlier.
         * Just run the remaining tasks*/
        else {
            if(lv_task_exec(tmp)) {
                task_interruper = tmp;  /*Check all tasks again from the highest priority */
                end_flag = 0;
                break;
            }
        }
    }
} while(end_flag);

Hi,
Yes, there are two linked list of words that you say, I was in order to avoid having a task frequently executed and take a long time。
May I did not understand the meaning of your previous code to achieve, you now see the code As long as the implementation of a non-highest priority task exit lv_task_handler function?

run a non-highest-priority task and exit the lv_task_handler function?

The two linked lists I implemented put the runed of high-priority tasks on other linked lists, in the situation that the high-priority tasks may not be queried in time。
Now discuss your code, whether end_flag assignment is wrong, because these two pieces of code in the loop will lapse.
if(tmp == task_interruper)
....
else if(task_interruper)
....

Hi,
you are right. I didn't test the my code... :( The last line should be while(!end_flag); So until at leas one non-highest priority task is executed restart the polling.
But I can't see the problem with the snippet you mentioned:
if(tmp == task_interruper)
....

else if(task_interruper)
....

The if just ignores the interrupter task. Later in the else if run the tasks with higher priority then the interrupter. This structure won't run the tasks with priority of the interrupter (which is the desired behavior).

Hi,
After modifying the end_flag flag, these two judgments are valid.
This can not see any problem , look at the test results.

Okay, I will make some test tomorrow.

Hi,
I added a test in lv_examples/lv_test/lv_test_misc/lv_test_task.c and ad your changes to lvgl/beta.
Can you check them?

Okay, I'll see tomorrow, Happy New Year.

Okay, happy new year!

I close according to #99


APRProof specific viewer

Fixes: #413
This PR introduces proof-specific viewers, and does a few refactors to make that possible:

Helpers are added to KCFG for turning into modules, including:

KCFG.Split.covers which returns each individual split as a reverse cover.
KCFG.NDBranch.edges, which returns each non-deterministic step as an edge.
KCFG.Edge.to_rule, which converts an edge into a K rule (or claim).

Small refactorings to KCFGShow structure:

KCFGShow.dot returns a Digraph directly (for further manipulation) instead of a list of str.
KCFGShow.to_module which returns a KFlatModule is factored out and used directly in KCFGShow.show.
Helper methods embedded in other methods in KCFGShow are factored out directly to staticmethods of KCFGShow so they can be reused easily.
We just treat stuck as a node attribute now, printed at the beginning of a node, instead of printing it a second time following a node too.

The way that KCFGShow calculates node attributes is adjusted and factor out.

A new class NodePrinter is factored out, which by default just uses the attributes the KCFG knows about for printing out nodes.
That class is extended by APRProofNodePrinter and APRBMCProofNodePrinter, which add the additional information about the nodes pending,terminal,bounded state, in addition.
KCFGShow now takes an optional *NodePrinter as an argument (or builds on itself), so instantiating that class is how you can customize how nodes are displayed in text.
The tests are adapted to use the more specific *NodePrinter classes, and the output checked that the more specific node information is indeed being included.

Adds helper predicates APRProof.is_{pending,terminal} and APRProof.is_bounded, which should behave better in case there are qualified node ids passed in.

Running bmc-loop-symbolic-1 test with log level set to INFO now prints out something looking like this for BMC depth-bounded nodes:

You can see that it includes the bounded label in that node ID, which makes it easier to spot that it's stuck because it's depth-bounded.


Question: How to use deploy.sh with Travis CI?

I would like to know how can I use deploy.sh with Travis CI for auto-pushing to gh-pages after the build?
I am getting Github authentication error when I use the below config.
sudo: false

language: ruby

rvm:
  - 2.4.0

cache: bundler

script:
  - bash deploy.sh

#deploy:
#  provider: pages
#  skip_cleanup: true
# local_dir : build
# target_branch : gh-pages
# github_token: $GITHUB_TOKEN # Set in travis-ci.org dashboard
# on:
#    branch: master

Found the solution. Sorry for the trouble.
Have to use the below instead of using origin as explained in https://github.com/X1011/git-directory-deploy
<EMAIL_ADDRESS>


issues Popup dialog content haven't been rendered.

@jolheiser

This should render the first few markup lines, similar to frontpage. Only "problem" is if the first content is a big image, this would produce a huge popup and that problem is also seen on frontpage.


Cypress test. Edit handler feature.

Motivation and context
Add Cypress test. Edit handler for polygon, polyline, points.
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage increased (+0.6%) to 72.799% when pulling 0c84c570bcda146ca2620254c394a5f45b0d5ff6 on dvkruchinin:dkru/cypress-test-case-59-edit-handler into 86eef84717fc901a1910a0c0290758b774835164 on openvinotoolkit:develop.

Hi @ActiveChooN ,
Please, make a review of the PR>

I will add autoborder activation.


Remove Error Types (Except APKError) From Runtime APIClient

Description:
From this effort below error types will be removed.

BadRequestError
InternalServerErrorError
NotFoundError
ForbiddenError
PreconditionFailedError

Work Log [2023-04-18]
Started doing this and sent below PR.

https://github.com/wso2/apk/pull/1041


grep is not a standard Powershell alias

[Enter feedback here]
Many of the Powershell commands in this article use "grep" which doesn't seem to be an out-of-the-box alias for Select-String. I found "sls" substituted worked.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd4c4f41-2050-234e-e35b-750158cfba54
Version Independent ID: 09c0145e-fa2b-210d-d1a0-4acb8c790bc3
Content: Create a Windows VM with Azure Image Builder (preview) - Azure Virtual Machines
Content Source: articles/virtual-machines/windows/image-builder.md
Service: virtual-machines
GitHub Login: @kof-f
Microsoft Alias: kofiforson

@alansingfield I'm doing some additional investigation but I believe that grep was added in Azure CLI version 2.0 in 2017.  What version of Azure CLI are you running?

@alansingfield It looks like the intention was for the reader to run these with Azure CLI using Bash in the Azure Cloud Shell.  That's what the "Try It" defaults to but for a Windows targeted document it looks like many people (myself included) defaulted to something else like running Azure CLI in PowerShell:
https://github.com/MicrosoftDocs/azure-docs/issues/50675
I'm going to make sure we include a note in this to avoid confusion moving forward.  Thank you very much for bringing this to our attention.

I'm using Powershell 7 within Windows Terminal.
`
PowerShell 7.1.3
Copyright (c) Microsoft Corporation.
https://aka.ms/powershell
Type 'help' to get help.
PS C:\Users\xxxxx> Get-AzVMImagePublisher -location westus | grep 2019
grep: The term 'grep' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
PS C:\Users\xxxxx>
`

@alansingfield I've submitted a pull request awaiting review from @kof-f which will make this clear to future readers.  Sorry again about the confusion and thank you so much for helping us to improve our docs!  We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Option to filter by author

Is it possible to only display publications on a page for a particular author, without using search?

No, right now that isn't possible.
So what you would like is to select bibtex entries link but for a particular author, correct?
An example of what it could look like:

Yes, that's correct - I'd like to use one bibtex file, but have dedicated pages on a website for members of staff. Your example looks good, although sometimes first names are only represented by an initial, so it might be useful to be able to search by first initial and last name.

Yeah that makes sense. So, the way I was tackling this was to expand the generality of the code that handled bibtexkeys and allow it to work with other bibtex types like author. That would make the value of the author attribute a regex value which is used in the javascript match function.
Example for searching for multiple variations of Tim Smith:

or

or uses regex or `|` search for all types

I've add this ability in the develop branch (specifically 5ccf967e3afb0e319b14b12a6e3a442be932bf0a).

I've pushed this to master and added an explanation to the wiki
Closing this issue for now. Reopen the issue if you have any problems with this feature.


docs(how-to-guides): deploy different neural network models from Pytorch hub inside traffic_light_classifier node

Description
With this pull request models in torchvision hub trained again and tested which ones are compatible with current traffic_light_classifier node to make using another model optional.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

I closing this PR, and will be preparing more generic docs using mmlab repositories.

https://github.com/autowarefoundation/autoware-documentation/pull/447


[Keyboard Manager] Fix Remap buttons stop working

Summary of the Pull Request
I got it to stop crashing by bypassing XamlBridge Window focus handling.

PR Checklist

[x] Applies to #2321
[x] CLA signed. If not, go over here and sign the CLA

Detailed Description of the Pull Request / Additional comments

Xaml Bridge seems to not handle focus events properly, so this fix just bypasses it by handling the WM_SETFOCUS event directly.
This also solves another not documented crash that involved minimizing the window, then closing by pressing the X button without interacting with the window content itself.

Validation Steps Performed

Click on the Remap a key button with no key remappings.
Close the window by pressing the X button.
It shouldn't crash.
Repeat for Redefine a shortcut.

Another crashing scenario.

Click on the Remap a key button.
Minimize the Window.
Click on the taskbar to show the window again.
Close the window by pressing the X button.
It shouldn't crash.

Also could you find any explanation for why it happens only when there are no key remaps?

And also if you minimize it and right click close it.

Good catch, this causes a crash.

Since I can't repro the error, can you verify that if you open it, click away to another window and then close it (while it's not in focus), will it still not crash?

This doesn't cause a crash, on the other hand.

This is to confirm that the crash happens because the window requires focus atleast once before closing, rather than the window needing focus whenever it is closed.

Maybe just calling SetFocus before closing the window does the trick? I'll try that out.

I actually was able to the minimize thing. I think its unrelated to the focus problem, cause I got it as well. It doesn't actually crash the runner in my case, but the buttons stop working. I think there is probably something going wrong with the mutex in that case. Sak is making a separate issue for it.

I actually was able to repro the minimize thing. I think its unrelated to the focus problem, cause I got it as well. It doesn't actually crash the runner in my case, but the buttons stop working. I think there is probably something going wrong with the button mutex in that case. Sak is making a separate issue for it. I can look into that, since I think it might be unrelated to the PR. I'm not sure if it would also crash the runner in your case, but it isnt happening now because of some other issue.

It looks like in case of minimize the code after the message loop where EditKeyboardNativeHandle is set to null does not take place, and since that remains non-null, when the button is pressed after that since it is not null, the runner thinks the window is still open, so it tries to bring that to the foreground even though it doesn't exist. I'm not entirely sure why it doesn't close though, maybe WM_DESTROY does not get executed on closing from the right-click menu after minimize.

Actually, it looks like it applies even if you don't minimize and you just right-click at the bottom and exit it. Seems unrelated to this issue though, so I'll see if I can come up with a fix and then you can verify that it doesn't have the focus interaction in addition to it

Actually, it looks like it applies even if you don't minimize and you just right-click at the bottom and exit it. Seems unrelated to this issue though, so I'll see if I can come up with a fix and then you can verify that it doesn't have the focus interaction in addition to it. This PR #2566 fixes the the issue. Maybe you can check if it works in your case as well since the focus could also be another problem to add to it

#2566 does seem to fix the issue, however as you said it now causes a crash on insiders builds since the window doesn't have focus when its closed. I'll try SetFocus when receiving a WM_SYSCOMMAND message to close the window.


Missing support for allowJS in tsconfig.json

I am using Typescript 1.8.0 (installed via npm install typescript@1.8.0), and using the following tsconfig.json:
{
  "compilerOptions": {
    "target": "es5",
    "sourceMap": true,
    "allowJS": true
  }
}

Running ./node_modules/bin/tsc fails with the following message:
error TS5023: Unknown compiler option 'allowJS'.

Whereas running ./node_modules/bin/tsc --allowJS seems to be ok.

It's allowJs, lowercase "S".
I've filed this related bug about the docs and the JS schema not matching:
https://github.com/Microsoft/TypeScript/issues/6490
I think the best solution is to always enforce one casing of compiler flags and disallow the others.  It's really confusing otherwise.

Making the command-line args case sensitive is really user-hostile.
The JSON should match the schema, but there's no reason we shouldn't give you a suggestion (Unknown compiler option 'allowJS'. Did you mean 'allowJs' ?) when there's a case sensitivity mismatch.

Ah yes, that seems to be it. I just assumed that the command line arg name would be the same as the tsconfig.json arg name.
If the CLI is case-insentive though, I see no reason to not document it with the correct case sensitivity for the config file though.

I just assumed that the command line arg name would be the same as the tsconfig.json arg name.

It does.
Options:
 --allowJs                           Allow javascript files to be compiled.

Oh I was following the instructions in the What's new page and they show it as --allowJS.
Where is that list you showed?

Fixed the wiki page (thanks!). The list there is what you see when you run tsc without any args.

Cheers? :+1:
Was it this one? I don't see it there but maybe it's a cache thing.
https://github.com/Microsoft/TypeScript/wiki/Compiler-Options

looks like this issue is already addressed. closing.

The migrating from Javascript doc still shows the incorrect spelling "allowJS".

There is a pull request up that seems to fixes it on the handbook repo. https://github.com/Microsoft/TypeScript-Handbook/pull/393

should be updated now on the live site.


Improve settings menu on TV demo

Pull request
Description
This PR improves the player settings menu in the TV demo app, and reduce code duplication.
Changes made

Improve light mode support on TV
Add the missing "Reset to default" option to audio tracks and subtitles settings
Add the missing "Disabled" option to audio tracks and subtitles settings
Reorder settings on TV to match what was done in the mobile demo
Move the PlayerSettingsViewModel to pillarbox-demo-shared, so it can be used in both demo app. I've also moved a bunch of logic to it (settings definition, settings actions, ...)

Screenshots
Light mode on TV:

The rest of the changes don't impact the UI too much (except the reordering of settings on TV).
Checklist

[ ] Your branch has been rebased onto the main branch.
[ ] APIs have been properly documented (if relevant).
[ ] The documentation has been updated (if relevant).
[ ] New unit tests have been written (if relevant).
[ ] The demo has been updated (if relevant).
[ ] All pull request status checks pass.

When opening tracks settings in the Mobile demo, it select first disabled and then the one currently selected.

Should be fixed now.
I've also removed the popBackStack() when clicking on a track, so the behaviour is aligned between mobile and TV.


"net.protyposis.android.mediaplayer.VideoView" is not being recognized as a view

I implemented the "implementation 'net.protyposis.android.mediaplayer:mediaplayer:4.5.0' " in the dependencies of my app build.gradle but is not working

Hi ! Yes, the dependency did download and installed correctly, i didn't had any error or anything, is just that it does not recognize the "net.protyposis.android.mediaplayer.VideoView" view for some reason, in any case i just cloned the repo and imported it as a module directly into my project, and it works just fine now, so I guess the problem is just related to the implementation in the dependencies

The dependency didn't download because I forgot to publish it in Maven Central :) You must have gotten a Failed to resolve error during Gradle sync.
Anyway, I just published it and now it works correctly.