Incorrect access token for API scope when using a personal Microsoft account

Library

[x]<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>
Framework
AngularJS 1.6.1
Description
Setup:

Frontend SPA (AngularJS) and a backend. Both access Graph APIs on behalf of the user.
1 Azure app.
API scope under "Expose an API" in Azure (eg: api://1ae23a84-215a-4bd5-ae99-d54f1b7b211a/access_as_user).

In the browser, login with:
msal.acquireTokenPopup({
  prompt: 'select_account',
  redirectUri: "https://local.com/redirect_microsoft.html",
  scopes: ["profile", "email", "openid", "offline_access", "user.read", "files.readwrite.all"],

  // Get consent for this scope, but it won't be included in the access token
  extraScopesToConsent: ["api://1ae23a84-215a-4bd5-ae99-d54f1b7b211a/access_as_user"]
})

This works correctly so far for personal and business Microsoft accounts.
Next, try to get an access token for the API scope. The returned token will be passed to our API, which uses the OBO flow to exchange it for its own access and refresh token. We store the refresh token for future use.
msal.acquireTokenSilent({
  scopes: ["api://1ae23a84-215a-4bd5-ae99-d54f1b7b211a/access_as_user"],
  account: account // from the result of acquireTokenPopup()
})

In @azure/msal-browser 2.0.2 this step would fail for personal Microsoft accounts with the error ClientAuthError: null_or_empty_id_token: The idToken is null or empty. It succeeds in 2.1.0 even though the id token is not present. It works for non-personal Microsoft accounts in both versions, and includes an id token. I don't know why personal accounts do not get an id token here.
The access token is then passed to our API to perform the OBO flow. It works for non-personal Microsoft accounts, but fails for personal accounts with the error:
{
    "error": "invalid_request",
    "error_description": "AADSTS90023: Cross-origin token redemption is permitted only for the 'Single-Page Application' client-type.\r\nTrace ID: 32db7dc0-ab90-4a03-94bc-69522f919100\r\nCorrelation ID: 3b10fa8d-0527-4cad-a459-206f4086a731\r\nTimestamp: 2020-08-26 07:27:14Z",
    "error_codes": [
        90023
    ],
    "timestamp": "2020-08-26 07:27:14Z",
    "trace_id": "32db7dc0-ab90-4a03-94bc-69522f919100",
    "correlation_id": "3b10fa8d-0527-4cad-a459-206f4086a731"
}

Regression
Did not work in 2.0.2.
MSAL Configuration
new PublicClientApplication({
  auth: {
    clientId: "<<client id here>>",
  },
  cache: {
    cacheLocation: "sessionStorage",
    storeAuthStateInCookie: false,
  }
})

Expected behavior

acquireTokenSilent should return an access token that is valid when used in the OBO flow for personal Microsoft accounts.

I'm not sure if this is actually a bug in MSAL. It may be a problem somewhere else with personal Microsoft accounts, or perhaps we aren't using the OAuth APIs correctly.
Browsers/Environment

[x] Chrome

Issue occurs with multiple personal Microsoft accounts.
Issue does not occur in testing with non-personal accounts across several different tenants.

I've been running into this lately, but can confirm that there's no more error message with 2.1.0. When I looked through the code I saw it wasn't actually using the account param when calling acquireTokenSilent, but rather using this.getAccount(). Not sure if this is still the case.

@jviney thanks for raising the issue. We believe this is an issue with the AAD service and we've raised this issue with that team. We'll let you know when we have further information.

Any update?

@jviney this is being tracked internally and worked on by another AAD team. I will leave this open as a work-in-progress for updates.

Any update?

Any update?

I've retested this with @azure/msal-browser 2.10. The situation certainly seems to have improved - the issue is now that when using a personal account the backend OBO request doesn't provide a refresh token, where non-personal accounts do.
Example OBO response for personal account:
{"token_type": "Bearer", "scope": "https://graph.microsoft.com/.default https://graph.microsoft.com/User.Read https://graph.microsoft.com/Files.ReadWrite.All", "expires_in": 3557, "ext_expires_in": 3557, "access_token": "REMOVED"}

Example OBO response for non-personal account:
{"token_type": "Bearer", "scope": "email openid profile https://graph.microsoft.com/Files.ReadWrite.All https://graph.microsoft.com/User.Read https://graph.microsoft.com/.default", "expires_in": 3589, "ext_expires_in": 3589, "access_token": "REMOVED", "refresh_token": "REMOVED"}

The scopes are also different for the two scenarios. The personal account is missing the OpenID scopes email openid profile.

I've retested this with @azure/msal-browser 2.10. The situation certainly seems to have improved - the issue is now that when using a personal account the backend OBO request doesn't provide a refresh token, where non-personal accounts do.
Example OBO response for personal account:
{"token_type": "Bearer", "scope": "https://graph.microsoft.com/.default https://graph.microsoft.com/User.Read https://graph.microsoft.com/Files.ReadWrite.All", "expires_in": 3557, "ext_expires_in": 3557, "access_token": "REMOVED"}

Example OBO response for non-personal account:
{"token_type": "Bearer", "scope": "email openid profile https://graph.microsoft.com/Files.ReadWrite.All https://graph.microsoft.com/User.Read https://graph.microsoft.com/.default", "expires_in": 3589, "ext_expires_in": 3589, "access_token": "REMOVED", "refresh_token": "REMOVED"}

The scopes are also different for the two scenarios. The personal account is missing the OpenID scopes email openid profile.

Ah - so it works if you explicitly add the offline_access scope to the OBO request for personal accounts. So the scope becomes: https://graph.microsoft.com/.default offline_access. Great!
The Azure app I'm using includes openid profile email offline_access in the default scopes - but perhaps they aren't being picked up correctly for personal accounts?

Ah - so it works if you explicitly add the offline_access scope to the OBO request for personal accounts. So the scope becomes: https://graph.microsoft.com/.default offline_access. Great!
The Azure app I'm using includes openid profile email offline_access in the default scopes - but perhaps they aren't being picked up correctly for personal accounts?

Can you record the POST to /token being made by your server, and see what the scope parameter looks like? It should be openid profile offline_access https:://graph.microsoft.com/.default or similar, even before you use manually append offline_access

Can you record the POST to /token being made by your server, and see what the scope parameter looks like? It should be openid profile offline_access https:://graph.microsoft.com/.default or similar, even before you use manually append offline_access

The scope sent to /token for non-personal accounts is https:://graph.microsoft.com/.default. The returned scopes are email openid profile https://graph.microsoft.com/Files.ReadWrite.All https://graph.microsoft.com/User.Read https://graph.microsoft.com/.default

The scope sent to /token for non-personal accounts is https:://graph.microsoft.com/.default. The returned scopes are email openid profile https://graph.microsoft.com/Files.ReadWrite.All https://graph.microsoft.com/User.Read https://graph.microsoft.com/.default

Thanks! This is a combination SDK bug and server side bug.  AAD considers "offline_access" to be part of MS Graph, so it gives you an RT since it's part of tokens for Graph.  MSA handles this differently and requires offline_access in the request, per OIDC spec. I'll file this bug internally.
The SDKs should also be adding this in automatically if they expect there to be a refresh token provided.

Thanks! This is a combination SDK bug and server side bug.  AAD considers "offline_access" to be part of MS Graph, so it gives you an RT since it's part of tokens for Graph.  MSA handles this differently and requires offline_access in the request, per OIDC spec. I'll file this bug internally.
The SDKs should also be adding this in automatically if they expect there to be a refresh token provided.

Thanks - so is providing the OpenID scopes in the OBO request a sufficient workaround?

Thanks - so is providing the OpenID scopes in the OBO request a sufficient workaround?

Yup, for the issue you ran into.  Per OIDC if you want a refresh token you need to request it, so certainly that's the more standards-based way of making this work.

Yup, for the issue you ran into.  Per OIDC if you want a refresh token you need to request it, so certainly that's the more standards-based way of making this work.

Thanks! This is a combination SDK bug and server side bug. AAD considers "offline_access" to be part of MS Graph, so it gives you an RT since it's part of tokens for Graph. MSA handles this differently and requires offline_access in the request, per OIDC spec. I'll file this bug internally.
The SDKs should also be adding this in automatically if they expect there to be a refresh token provided.

Thanks @hpsin, we'll take a look at fixing this.

Thanks! This is a combination SDK bug and server side bug. AAD considers "offline_access" to be part of MS Graph, so it gives you an RT since it's part of tokens for Graph. MSA handles this differently and requires offline_access in the request, per OIDC spec. I'll file this bug internally.
The SDKs should also be adding this in automatically if they expect there to be a refresh token provided.

Thanks @hpsin, we'll take a look at fixing this.


Scroll to top on statusTap native event

How can I disable it for my app?
I tried removeEventListener, make stopPropagation, make preventdefault, return false on event.
All of this in $ionicPlatform.ready but nothing works


Set download/upload limit not working

Upload and download limits are not working from torrent details,
Reported by Carlos Fanini thru Google Play Console

Fixed it will available in the next release!


PauseChamp mods make it so dj bot songs stay at the bottom of q so anybody can q above them

https://cdn.discordapp.com/attachments/482748530834800641/932891451724013619/Clueless3x.png

This is not the right repository and this is not the correct format. Please reread the Information dropdown for what you're looking for. (I think you're referring to the bot so here's the link to that https://github.com/airforce270/CytubeBot)

have bot move user queued songs above?

Again this is the wrong repository. You're looking for this one https://github.com/airforce270/CyDJ/CytubeBot


Forward video has tearing artifacts

Describe the bug
The first drive's after a cold boot's forward video is fine. The next ONROAD's forward video is not. Might need the screen to go dark in-between drives. The wide video seems fine on all the drives. Third drive and up seemed to be fine in one of the cases.

this one's first boot's drive is fine: https://connect.comma.ai/fe18f736cb0d7813/00000404--83516f16c4
second boot: fe18f736cb0d7813/0000040b--78d26612d7/2
https://github.com/user-attachments/assets/ffeda102-b76b-4257-affd-5565b44460f1
https://github.com/user-attachments/assets/e6527965-1691-4b06-8b26-b4adde2ae36a
Context: Vehicle started from cold boot, had a bit of a drive, saw TPMS low tire pressure, went back to house to get tire pump, pumped all four tires, started second drive, saw errors.
Did not attempt to drive the rest of the route with openpilot engaged. It was ping-ponging like mad, which isn't unexpected for this issue.

first boot is fine: https://connect.comma.ai/fe18f736cb0d7813/0000040a--0dbe63a02e
second boot: fe18f736cb0d7813/00000405--2b441abe00/9
https://github.com/user-attachments/assets/d7d51a3f-f911-485d-a100-cde7e910dcfb
https://github.com/user-attachments/assets/94c96e84-9179-430c-b36d-aad36102f124
third to fifth drive seems fine?:

https://connect.comma.ai/fe18f736cb0d7813/00000406--f82bf78ec4

https://connect.comma.ai/fe18f736cb0d7813/00000407--a56e0a2bec

https://connect.comma.ai/fe18f736cb0d7813/00000408--9eb4d4c06f

Context: Just went out, got something to eat, groceries. Did use openpilot for rest of drive though. It didn't seem to be badly affected like the route above.
Provide a route where the issue occurs
fe18f736cb0d7813/0000040b--78d26612d7/2 , fe18f736cb0d7813/00000405--2b441abe00/9
openpilot version
master-ci
Additional info
Discord links:

feedback: https://discord.com/channels/469524606043160576/1305837783490891826

openpilot-experience: https://discord.com/channels/469524606043160576/616456819027607567/1305838954825777162

While not yet reported yet, a447729c1d15ff89 might have the same issue (patienc3 on Discord). They might come in with a report or data of their own.

Same issue observed in the route https://connect.comma.ai/a447729c1d15ff89/0000001b--0585570655

Thanks for the great report!  We made a bunch of relevant changes here recently (mostly ISP + tinygrad), but nothing that particularly points at the fcam.

confirmed on both your drive's that it's just fcam (ecam and dcam are fine)
friom commit 97c990dac6425e6a7eb0299007927ceb6d1c1ea4

Reproduced on an AR231 device. Repro procedure is reboot and cycle ignition a few times.

on master, 3/4 boot ups had the tearing
with BLOCK=modeld,dmonitoringmodeld, 0/6 boot ups had the issue

Had the same issue on my trip tonight. Lower third of the forward camera has this issue. Route: 5130484aa8069bad/00000007--b9a36bd4fa

Reverting until this is fixed #34020.

I had this happen to me earlier this year. Have not noticed it since. https://connect.comma.ai/164080f7933651c4/2024-04-07--11-04-32

I had this happen to me earlier this year. Have not noticed it since. connect.comma.ai/164080f7933651c4/2024-04-07--11-04-32

This looks a bit different, but may be the same underlying cause. Do you happen to remember whether it looked like that in the UI or just the recorded video?

Alright so more info on this:

tearing happens once you hit the output fence timeout
once it's timed out, the ISP gets in a bad state and never recovers
AR is more likely since the readout is 2x longer than OX


Use proper refer function

Closes #180
Fixes wrong reference function link, introduced in https://github.com/IntelPython/dpbench/pull/151

Example of report:
Legend
impl_postfix                                    description
0          dpnp                   Data-parallel Numeric Python
1  numba_dpex_k                         Numba-dpex with kernel
2  numba_dpex_p                         Numba-dpex with prange
3  numba_dpex_n         Numba-dpex with NumPy array expression
4       numba_n                            Numba with nopython
5      numba_np             Numba with nopython, Parallel=True
6     numba_npr  Numba with nopython, Parallel=True and prange
7         numpy                                          Numpy
8        python                                         Python
9          sycl                      DPC++ with dpctl bindings
Summary of current implementation
             As_of          benchmark problem_size      numba_dpex_k   numba_dpex_p      numba_dpex_n              dpnp          numpy         python        numba_n       numba_np      numba_npr          dpcpp

0  03.27.2023_21.12.03      black_scholes            S           Success        Success           Success           Success        Success        Success        Success        Success        Success        Success
1  03.27.2023_21.12.03             dbscan            S  Failed Execution        Success     Unimplemented     Unimplemented  Unimplemented        Success        Success  Unimplemented        Success  Unimplemented
2  03.27.2023_21.12.03             gpairs            S           Success        Success     Unimplemented  Failed Execution        Success  Unimplemented        Success  Unimplemented        Success        Success
3  03.27.2023_21.12.03             kmeans            S           Success        Success           Success     Unimplemented        Success        Success        Success  Unimplemented        Success  Unimplemented
4  03.27.2023_21.12.03                knn            S           Success        Success     Unimplemented     Unimplemented  Unimplemented        Success  Unimplemented  Unimplemented        Success        Success
5  03.27.2023_21.12.03            l2_norm            S           Success  Unimplemented  Failed Execution           Success        Success  Unimplemented        Success        Success  Unimplemented        Success
6  03.27.2023_21.12.03  pairwise_distance            S           Success        Success  Failed Execution  Failed Execution        Success  Unimplemented  Unimplemented        Success        Success        Success
7  03.27.2023_21.12.03              rambo            S           Success        Success     Unimplemented     Unimplemented        Success  Unimplemented        Success  Unimplemented        Success        Success

Knn numba_dpex_p implementation has a known issue and it should fail. Surprising that it is shown as "Success" in all your logs above. Here is the log from the CI.
4  03.28.2023_03.41.09                knn            S           Success  Failed Execution     Unimplemented     Unimplemented  Unimplemented        Success  Unimplemented      Unimplemented        Success        Success

@adarshyoga I guess it could be because I'm running on numba-dpex 0.20.0, while CI runs it on 0.19.0 version. I can update CI, but then it will be stuck to nightly released and with particular version of numb-dpex. I guess this is because of my lack of knowledge of conda package manger. If you feel it is worth doing so, you can take a look into CI.
As alternative solution, now that we have docker packages provided by numba-dpex we can use those in benchmark runs. But it will require some work to install dpbench inside docker as well.


Add support to retry attaching within a specific timeout

Summary

Basically the debugger is launched before the preLaunch script completes. Hence the debugger fails (as the process has not started and socketserver is not listening).
Suggestion: Retry attaching to the socket with a default timeout period.
Note; This is not a bug, but a work around for the preLaunchScripts returning even before the script has actually completed (i.e. work around for docker extension issues).

Environment data

VS Code version: 1.38
Extension version: 2019.9.34911
OS and version: Windows 10, 1903
Python version: 3.7.2

Steps to reproduce:

Create a Python file, e.g. myApp.py within a workspace folder
Create a task in tasks.json to launch that file in PTVSD in a Docker container (see below for full tasks.json), e.g. with:
docker run -dt -v C:\Users\brandonw\.vscode\extensions\ms-python.python-2019.9.34911\pythonFiles:/pydbg -v ${workspaceFolder}:/app -w /app -p 5678:5678 --entrypoint python python:alpine /pydbg/ptvsd_launcher.py --default --host <IP_ADDRESS> --port 5678 --wait myApp.py
Set that task as the preLaunchTask for a Python remote attach launch config (see below for full launch.json)
F5

Expected behaviour
Attach works if preLaunchTask is used to start a waiting debug server with ptvsd
Actual behaviour
Attach does not work. No error is shown, it appears like debugging starts and immediately stops. If you comment out the preLaunchTask in launch.json, and then manually run the task with Ctrl + Shift + P > Run Task, it will start the container. If you then F5 it attaches successfully. I've also tried putting a dummy task containing a 2-second sleep inbetween, and this also works. So it seems to just be a race condition.
Logs
Nothing is output in Python output window, nor in Developer Tools console window.
Workspace
.vscode/launch.json:
{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python: Remote Attach",
            "type": "python",
            "request": "attach",
            "port": 5678,
            "host": "localhost",
            "pathMappings": [
                {
                    "localRoot": "${workspaceFolder}",
                    "remoteRoot": "."
                }
            ],
            "preLaunchTask": "Docker start",
            "postDebugTask": "Docker remove"
        }
    ]
}

.vscode/tasks.json (note, you'll need to change the C:\users\brandonw...\pythonFiles:/pydbg path):
{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "Docker start",
            "type": "shell",
            "command": "docker run -dt -v C:\\Users\\brandonw\\.vscode\\extensions\\ms-python.python-2019.9.34911\\pythonFiles:/pydbg -v ${workspaceFolder}:/app -w /app -p 5678:5678 --name myPythonApp --entrypoint python python:alpine /pydbg/ptvsd_launcher.py --default --host <IP_ADDRESS> --port 5678 --wait myApp.py",
            "problemMatcher": []
        },
        {
            "label": "Docker remove",
            "type": "shell",
            "command": "docker rm -f myPythonApp"
        }
    ]
}

myApp.py:
print("Hello world!")

print("Farewell!")

Blocks https://github.com/microsoft/vscode-docker/issues/1255

Isn't the problem the fact that the preLaunch task returns even before the script has completed. I.e. it's not really an issue with the python extension. However an issue with the preLaunch script.

@DonJayamanne VSCode does actually wait until 'docker run' has finished, but I don't think that 'docker run' waits for python to get up, running, and ready in the container before returning.

Since it's expected that the entrypoint is a long-running application, the -d option (detached) would mean it doesn't wait for the application to return. We also can't do -i (interactive) as then the task would never return.

but I don't think that docker run waits for python to get up, running, and ready in the container before returning.

Not sure how this is a bug in the extension.

Same problem could happen with other debuggers.
Either you'd need to find a way to synchronize the two, or find an alternative. (E.g  use custom tasks  in vscode), or a custom debugger when you manually start docker and that start the debugger using the VSCode API).

I'm closing this issue for now.
Will be happy to reopen if it's going to be an issue with the extension. If you have a work around (for python extension) please do advise.
Again, closing as it's not a python extension specific, related to more preLaunch task and docker.

Leaving it open to discuss further.

It's not a bug, but it's a shortcoming that can't be addressed by Docker itself or by the Docker VSCode extension (they have no idea what constitutes 'the debugger listener is ready' or how to detect it).
For comparison, the Node.js debugger has a timeout parameter that can help in this sort of scenario: https://github.com/microsoft/vscode-node-debug2/blob/965054f347a8f4ea4a690f82083e9ad8f708633e/package.json#L301

Updated as enhancement, as this isn't a bug.
Again it's basically a problem with the oreLaunch talk and it's shortcomings.

Proposed solution

*Retry attaching to the socket with a default timeout period.
Note; This is not a bug, but a work around for the preLaunchScripts returning even before the script has actually completed (i.e. work around for docker extension issues).

@bwateratmsft
Have you looked at using the HEALTHCHECK option to wait for the port to be opened. (https://www.alibabacloud.com/help/doc-detail/58588.htm)
If you incorporate this, then there's no need to modify the extension. Makes it more bullet proof (no need to change, node, python and other language specific extension to get around this issue with preLaunchScript in the docker extension).
E.g. creating a custom debugger in docker extension would also resolve this. This way docker extension can wait for the port to be opened.
I'm looking for generic fix that wouldn't require all other extensions to add a timeout/retry option (it is too specific to docker).

I have looked into health checks, but there's still problems:

docker run doesn't wait for health checks before returning, so we would still need a task inbetween, which is a terrible UX.
Knowing if the debugger is ready shouldn't be something that we have to do. The port being open is not enough. Docker starts the container with the port open. I have no idea how to determine if the debugger is ready.
This doesn't solve the problem for anything other than specifically our Docker extension's scenario. Anyone else wanting to start a remote with a preLaunchTask has to reimplement the wheel.

Again, this is not specific to Docker. This is any scenario where the user wants to do remote debugging and use a preLaunchTask to start the remote debugger.

Why would any other extension need to make changes? If the Python debug extension had a timeout option, just like the Node debug

Java, C#, and other languages would have similar issues when waiting for ports to open...

I haven't looked into Java yet so I can't speak for it, but for .NET debugging retry is already built in between vsdbg and the debug adapter. In any case our usage is primarily Node, with .NET Core and Python in second and third. No other languages come even close to these three.

I got one part about .NET Core wrong; we don't launch vsdbg inside then attach, rather we are launching it interactively with docker exec -i, then instructing it on how to launch the actual .NET Core app. It'd be nice if we could do something like that for Python but I understand that would be a much, much larger change.

@karthiknadig @int19h /cc

I wonder if it would help if you could reverse the direction of the connection? i.e. from Docker to VSCode, rather than the other way around? Basically the order for the debugger bits would be:

User (or extension) starts debug session.
IDE waits for incoming connection from debuggee.
Debuggee starts, connects to IDE at the specified port.
Debugging proceeds.

It sounds like this would solve the prelaunch problem?

@int19h I'm not really sure how that works. We are constrained by the order of execution that VSCode does things with (debug config resolved, preLaunchTask(s) executed, debug config 'executed'). In our case, it's this:

Debug config resolved
docker build
docker run
Debug config 'executed'

Would it still be possible to do what you're describing with that order?

In particular, one thing I do want to avoid is cramming everything into DebugConfigurationProvider.resolveDebugConfiguration. We recently spent a lot of time refactoring our whole debugging flow so that docker build and docker run could become tasks (previously, we had shoehorned them into DebugConfigurationProvider.resolveDebugConfiguration which is a bit of an abuse of that API).

To clarify the specifics. We have an (experimental, not officially advertised or supported yet) feature in our prerelease bits where you can do this in debug.config:
"request": "attach",
"host": ...,
"port": ...,
"listen": true,

If you do this and then start the debug session, it will sit there and wait for the incoming connection. And you can tell ptvsd to initiate by either using --client in CLI, or using ptvsd.attach() instead of ptvsd.enable_attach() in API.
On the protocol level, what happens there is that VSCode will send the "attach" request, but it won't receive "initialized" event or the "attach" response until there's a socket connection from the adapter to the debuggee.
So if I'm understanding everything correctly, the way this will work in your scenario is that the preLaunchScript will return before the actual script completes, and move on to start the debug session. But the debug session, once started, will then block waiting for connection, and that will only happen once the script completes and starts the debuggee. So you wouldn't really need to sync anything explicitly.

It is definitely possible that the the client part in the container starts up before the listener is ready on the host--would that fail as it does currently? If so we'd still have the race condition, just swapping the client/server.

Ahh, I see what you mean now. Yes, it would also be a race condition...
Can you clarify how this flow works with vsdbg.exe? Specifically, at which step do you launch it, such that it is guaranteed to be there and listening by the time the debug session starts? Our new adapter design has an out-of-process bit as well, and I'm thinking that it might be possible to rig it to be used in a similar way, but it depends on the details.

For .NET Core / vsdbg, it looks like this:

Resolve config (we resolve to coreclr)
The C# extension now gets a hold of it, and does whatever they do when resolving
docker build
docker run, but this starts a container that's doing nothing--just alive and waiting
Executing the config--the C# extension has a bunch of pipeTransport options, which are basically a thing you execute that gets you to vsdbg. For us, pipeProgram=docker and pipeArgs=exec -i <containerName> /remote_debugger/vsdbg. This docker exec command is an interactive process, so stdio, stdout, and stderr are piped up. Once this is running, the C# extension / debug adapter tells vsdbg (through stdio) to start the actual .NET Core app itself, via dotnet /path/to/app.dll.

So, basically the C# extension lets you customize the command line for spawning the adapter, which allows it to be spawned remotely inside the container via the appropriate helper - and then it's really a "launch" scenario, where the remote adapter starts the process within the container?
It sounds like this approach could be reused. We spawn our new out-of-proc adapter via DebugAdapterDescriptor and DebugAdapterExecutable. That code could also allow similar customization, maybe even using the same property names. And it sounds like that's the only bit that would need to change? docker exec would take care of moving the bits back and forth, and as far as VSCode is concerned, it's still dealing with a local process and its stdin/out. The actual adapter is similarly oblivious.

Yes, for C# it truly is a 'launch' scenario instead of 'attach'. That approach would work great for us, if you're already working toward it anyway. If it helps, here's where their settings start: https://github.com/OmniSharp/omnisharp-vscode/blob/6405d17613152249d820a11e1120d03fdc8f20df/package.json#L1123
And here's an example of what we resolve (some irrelevant bits removed for brevity) that results in launching 'TestWeb.dll':
{
    "name": "Docker .NET Core Launch",
    "preLaunchTask": "docker-run: debug",

    "pipeTransport": {
        "debuggerPath": "/remote_debugger/vsdbg",
        "pipeArgs": [
            "exec",
            "-i",
            "testsln-dev",
            "${debuggerCommand}"
        ],
        "pipeCwd": "${workspaceFolder}",
        "pipeProgram": "docker",
        "quoteArgs": false
    },

    "program": "dotnet",
    "args": "--additionalProbingPath /root/.nuget/packages --additionalProbingPath /root/.nuget/fallbackpackages /app/bin/Debug/netcoreapp3.0/TestWeb.dll",
    "cwd": "/app",

    "request": "launch",
    "type": "coreclr"
}

Of note, the C# extension will call pipeProgram + pipeArgs from within pipeCwd, (${debuggerCommand} is essentially just ${debuggerPath} --interpreter=vscode). So it does this:
${pipeProgram} ${pipeArgs} ${debuggerCommand}, resulting in
docker exec -i testsln-dev /remote_debugger/vsdbg --interpreter=vscode
Then, to VSDBG, it instructs it on launching the process, with program + args from within cwd:
${program} ${args}, resulting in
dotnet --additionalProbingPath /root/.nuget/packages --additionalProbingPath /root/.nuget/fallbackpackages /app/bin/Debug/netcoreapp3.0/TestWeb.dll.
As far as vsdbg is concerned, it's just launching a dotnet ...TestWeb.dll process, and happens to be running inside a Linux container; and as far as VSCode is concerned, it's debugging with vsdbg the normal way--through stdio/stdout/stderr.

Closing as stale.

Hey guys! I have a different usecase, but could benefit from debugger attach retry.
I've got a Django app running in a docker-dompose cluster, launched with watchmedo to enable quick code reload on file changes. Watchmedo restarts the Django process completely on code change, but that also means the debugger session disconnects.
How an I configure debugger launch configuration, so that it would try to reconnect debugger session, when Django process restarts? It takes about 5-10 secs to restart Django process and relaunch ptvsd.
In my current setup, Django spins up with docker-compose up on the side, exposes ports 8000 and 8001.
ptvsd is enabled in local debug mode:
# manage.py

if __name__ == "__main__":
    from django.conf import settings
    from django.core.management import execute_from_command_line

    if settings.DEBUG:
        if os.environ.get('DJANGO_SETTINGS_MODULE').split('.')[-1] == 'docker-local':
            DEBUG_PORT = 8001
            import ptvsd
            ptvsd.enable_attach(address=('<IP_ADDRESS>', DEBUG_PORT))
            print(f'VSCode debug tools attached. Listening on port {DEBUG_PORT}')

    execute_from_command_line(sys.argv)

Debugger launch configuration:
{
  "version": "0.2.0",
  "configurations": [
    {
      "name": "Django: Docker debug",
      "type": "python",
      "request": "attach",
      "pathMappings": [
        {
          "localRoot": "${workspaceFolder}",
          "remoteRoot": "/src"
        }
      ],
      "port": 8001,
      "host": "<IP_ADDRESS>",
      "listen": {
        "port": 8001,
        "host": "<IP_ADDRESS>",
      }
    }
  ]
}


Remove hosting and logging dependencies

Means test code has to provide logging/hosting services, and added null guards for code to compensate for lack of defaults
cc @divega @suhasj

Fixes https://github.com/aspnet/Identity/issues/431

Can we have a test when the when no logger is passed ? The TestIdentityFactory is registering AddLogging so I feel the current test will always have some value

We could go the other direction on this and require it via [NotNull] instead.  No test necessary that way

Added a new test with null logger to ensure things don't blow up, also cleaned up SignInmanager tests reducing a lot of the duplication with a SetupHelper

This looks good. Better than having the NotNull attribute since that would enforce using a logger always which I am not sure would be the right approach

3e9433639021255c1373c9a4bd36c4a511982d18


Issue template should ask for version of Storybook and addon-svelte-csf that are being used

I noticed in https://github.com/storybookjs/addon-svelte-csf/issues/114#issue-1814593017 that it's unclear what versions are being used. It's possible the issue is already fixed, but I can't tell without setting up a whole project to test it. If I go to create a new issue the "Environment" section asks for a bunch of info, but not these important pieces. Maybe we should ask users to run npx envinfo --system --binaries --browsers --npmPackages "{storybook,@storybook/*,vite,webpack,svelte,@sveltejs/*}". I'm not sure where this is configured though

We shoukd probably use the "default" storybook template ? https://github.com/storybookjs/storybook/blob/next/.github/ISSUE_TEMPLATE/bug_report.yml?plain=1

I think the issue is that https://github.com/storybookjs/.github/blob/master/.github/ISSUE_TEMPLATE/bug_report.md is used currently. If the version on master were updated to match what was on next it would address this

I guess I'll just go ahead and close this because assuming that the next version is eventually promoted then this will be fixed


Vim9: type checking ignores wrong type in funcref declaration in ":def" function

Describe the bug
In Vim9 script, sometimes, type checking ignores a wrong type in a funcref declaration in a :def function.
To Reproduce
Run this shell command:
vim -Nu NONE -S <(cat <<'EOF'
    vim9
    def Func()
        var l = [1, 2, 3]
        var Ref: func(number, job): bool
        Ref = (_, v) => v == 2
        echo l->filter(Ref)
    enddef
    Func()
EOF
)

No error is raised.  [2] is echo'ed.
Expected behavior
An error is raised, because the funcref Ref is declared with the type func(number, job): bool:
var Ref: func(number, job): bool

But filter() did not pass jobs to Ref; it passed numbers.
Environment

Vim version: 8.2 Included patches: 1-2318
OS: Ubuntu 16.04.7 LTS
Terminal: xterm(363)

Additional context
There are other issues at the script level, but it's going to get confusing, so I'll open a separate issue.

I'm not this is a bug actually.  Maybe the types are only inspected at compile time, when the assignment occurs.  At that moment, it might be hard – if not impossible – for Vim to know whether the given types are right or wrong, simply by looking at the expression in the lambda which could be arbitrarily complex.
I wasn't expecting an error to be raised at that moment though.  I was expecting an error to be raised at runtime.  I'm not sure whether the types specified in the funcref declaration are meant to be still in effect after the assignment, once the funcref is invoked...

I'm not this is a bug actually.  Maybe the types are only inspected at compile time, when the assignment occurs.  At that moment, it might be hard – if not impossible – for Vim to know whether the given types are right or wrong, simply by looking at the expression in the lambda which could be arbitrarily complex.
I wasn't expecting an error to be raised at that moment though.  I was expecting an error to be raised at runtime.  I'm not sure whether the types specified in the funcref declaration are meant to be still in effect after the assignment, once the funcref is invoked...

I suspect it's not a bug, so closing.

I suspect it's not a bug, so closing.

I suspect it's not a bug, so closing.

Yes, I'm sure it's not a bug.  The types in a funcref declaration are only meant to be compared to the optional types in the lambda assignment.

However, there are still what seems to be inconsistent behaviors at the script level.
For example, this is OK in a :def function:
vim9
def Func()
    var l = [1, 2, 3]
    var Ref: func(number, number): bool
    Ref = (_, v) => v == 2
    echo l->filter(Ref)
enddef
Func()

But not at the script level:
vim9
var l = [1, 2, 3]
var Ref: func(number, number): bool
Ref = (_, v) => v == 2
echo l->filter(Ref)

E1012: Type mismatch; expected func(number, number): bool but got func(any, any): any

And this doesn't raise any error:
vim9
var l = [1, 2, 3]
var Ref: func
Ref = (_: job, v: job): job => v.n+1 == 2
echo l->filter(Ref)

[1, 2, 3]

But it should because:

all the types are wrong
the expression in the lambda's body handles v as a dictionary and tries to access the key n, while v is not a dictionary but a number
there is no whitespace around the +

Regarding the last bullet point, usually, Vim does enforce the rule even in a lambda's body:
vim9
echo (() => 1+1)()

E1004: White space required before and after '+' at "+1"

I suspect it's not a bug, so closing.

Yes, I'm sure it's not a bug.  The types in a funcref declaration are only meant to be compared to the optional types in the lambda assignment.

However, there are still what seems to be inconsistent behaviors at the script level.
For example, this is OK in a :def function:
vim9
def Func()
    var l = [1, 2, 3]
    var Ref: func(number, number): bool
    Ref = (_, v) => v == 2
    echo l->filter(Ref)
enddef
Func()

But not at the script level:
vim9
var l = [1, 2, 3]
var Ref: func(number, number): bool
Ref = (_, v) => v == 2
echo l->filter(Ref)

E1012: Type mismatch; expected func(number, number): bool but got func(any, any): any

And this doesn't raise any error:
vim9
var l = [1, 2, 3]
var Ref: func
Ref = (_: job, v: job): job => v.n+1 == 2
echo l->filter(Ref)

[1, 2, 3]

But it should because:

all the types are wrong
the expression in the lambda's body handles v as a dictionary and tries to access the key n, while v is not a dictionary but a number
there is no whitespace around the +

Regarding the last bullet point, usually, Vim does enforce the rule even in a lambda's body:
vim9
echo (() => 1+1)()

E1004: White space required before and after '+' at "+1"

Yeah, it's going to be hard to raise an error for this.  The individual commands are OK.
It would require adding a wrapper around the lambda when it is assigned to "Ref", checking that the argument indeed is a job.
But the lambda itself is fine, when assigning it to another funcref it should not check for a job argument.
Also, it's unlikely type checking will help the author of the script here.  So let's leave it.

Yeah, it's going to be hard to raise an error for this.  The individual commands are OK.
It would require adding a wrapper around the lambda when it is assigned to "Ref", checking that the argument indeed is a job.
But the lambda itself is fine, when assigning it to another funcref it should not check for a job argument.
Also, it's unlikely type checking will help the author of the script here.  So let's leave it.


[MBProgressHUD showHUDAddedTo: animated:] in 1.0.0 displaying empty button

For some reason, the vanilla HUD is showing an empty button (see attached)

Any ideas why this might be happening?

This problem solved?How to solve?

I face the same problem , any help?

What are the steps needed to reproduce this?

This looks like the button title is not set.
Closing due to inactivity.


Graph sorting produces wrong routes after GraphHopper restart

Just tested our current master with graph.do_sort: true and got "interesting" results after i restarted GraphHopper.
Testcase: http://localhost:8989/maps/?point=GraphHopper München&point=48.748945%2C11.451874&profile=car
Routing is perfectly fine if i test directly after importing:

If i restart GH and try the same route:

The route seems to target completely different start/end points.

Maybe related to #2323 ?

The problem seems to be if graph.do_sort is enabled it is done on import and on every restart.
We should introduce something like hasSorted like we have for the interpolation. Strange that this wasn't a problem earlier.

Fixed by https://github.com/graphhopper/graphhopper/commit/48d2c93916c2364baa6d4c3cdc1299a4a7d0056d


Error in MS Edge ("Security Problem")

First of all, sorry If this was "reported" or "asked" before, however I've been facing the following issue on MS Edge (note that Chrome, Firefox and Safari are all working just fine), and I'm unable to resolve it.

More specifically it errors out on the following line:

Steps to reproduce:
run create-react-app my-new-app-name
then npm install --save normalize-url
Then simply try normalizeUrl("www.google.com") in the App component (or anywhere for that matter). Works fine everywhere except MS Edge (v. 42.17134.1.0).
I apologize if this is something silly and obvious (like adding a polyfill of some sorts). Just for the record, after some desperate googling, I've tried adding url-polyfill and babel-polyfill and importing them in the app:
import "url-polyfill";
import "babel-polyfill";

Didn't really help.
Any help is highly appreciated.

Ok, I think I found the problem (I hope it's helpful in any way). It appears that MS Edge doesn't like the following:
https://github.com/sindresorhus/normalize-url/blob/e02a3aaa149ddf34ba4076adc0885c26718b7a37/index.js#L63-L66
If I set stripAuthentication to true (or if I remove urlObj.username & urlObj.password from the code) everything seems to work just fine.
It's something that MS Edge does when running .toString() on the URL when username and password are defined (even if empty).
It seems to be working fine on other browsers.

Sorry, I don't care about Edge, and neither does Microsoft: https://www.computerworld.com/article/3325333/web-browsers/with-move-to-rebuild-edge-atop-googles-chromium-microsoft-raises-white-flag-in-browser-war.html

Yeah, I read about that, however this is not exactly happening today... Anyway, I get it, no issue. Thanks anyway.


Improve unit test coverage in deprovision_test.go

found with coveralls

Coverage increased (+0.9%) to 48.661% when pulling c6c6cf6ac18d39f7f89d16b822e4f826d1d28f41 on deprovision-test-coverage into 9f7004ec55a417d586ea89ef576644b1556fe544 on master.


Correct nextPaintTime definition

This was simplified in #528 but we forgot to update the descriptions to match

Thanks so much!
Aaron D Wood
On Tue, Oct 15, 2024 at 1:46 PM Philip Walton @.***>
wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/web-vitals/pull/546#pullrequestreview-2370410107,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK4LDQJIRI2WQFIWQBSJTZTZ3VWLHAVCNFSM6AAAAABP7KVSPWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZQGQYTAMJQG4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


typo in definition for GO:0070184 mitochondrial tyrosyl-tRNA aminoacylation

Definition starts off like this: "The process of coupling threonine to tyrosyl-tRNA ...."
shouldn't that be "...coupling tyrosine..."?

Thanks for the report. Fixed rev 32315.


How to write select in mvc 6

Hi there, can you help me that " How to write select tag in mvc6 using taghelper.
'select id='sel_gender' name=sel_gender
option selected value=""I am.../option
option value="male"Male/option
option value="female"Female /option
/select
This throws an error
' select asp-for='LastName" name='dddsd'
option value="male"Male/option
/select'
see screenshot

I found where was the issue. fixed it.


8/10/2021 Publish

Docs Build status updates of commit 8e08d6b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 994efd5:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f2781d5:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 33e07d1:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e269a1b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f015ee9:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2ad0bac:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 93702d8:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 43f96c4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ef2c856:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

This merge conflict should not block us going to live. The source in main is what we want to publish. Building ef2c85696ce43d2ce100280094cba2ce98bd77a4 succeeds in OPS and this can be pushed to live by other means.

Also, no changes to docfx.json

This has merged.


Interactive Loader (single thread) blocks the main thread

It needs to be optimized: the while loop can be removed

Fixed by https://github.com/crystal-bit/godot-game-template/commit/8a4f143a2b71c9d11a7034d859d6238725a12ef2


[BEAM-12830] Update local Docker env Go version.

Fix the local docker dev environment to have a more recent Go version.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @TheNeuralBit


NYC fails to instrument files that have private class methods (#method(){})

Example problem_file.js:
class a {
 #method(){}
}

nyc --all --cache=false node ./problem_file.js

Expected Behavior
To have the file show up in the listed output.
Observed Behavior
The file does not show up in the list
Troubleshooting steps
If you look at the node_module/.cache you see the file was not actually instrumented.
Environment Information
System:
OS: macOS 11.1
CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
Memory: 79.61 MB / 16.00 GB
Binaries:
Node: 14.15.4 - ~/.nvm/versions/node/v14.15.4/bin/node
Yarn: 1.22.10 - ~/.nvm/versions/node/v14.15.4/bin/yarn
npm: 6.14.10 - ~/.nvm/versions/node/v14.15.4/bin/npm
npmPackages:
nyc: ^15.1.0 => 15.1.0
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |
----------|---------|----------|---------|---------|-------------------

Figured out I needed additional babel modules (which I hope will be included by default in the future).
My commands to resolve:
yarn add --dev @istanbuljs/nyc-config-babel @babel/register @babel/plugin-proposal-private-methods @babel/preset-env
echo '{
  "extends": "@istanbuljs/nyc-config-babel"
}' > .nycrc
echo '{
  "presets": ["@babel/env"],
  "plugins": ["istanbul", "@babel/plugin-proposal-private-methods"]
}' > .babelrc

I'd assume that, lacking the babel method, nyc would error out with a syntax error.

nyc uses babel internally and does allow for configuration of the parserPlugins that are used.  By default this does not include classPrivateMethods as no version of node.js supported that when the latest release was cut.  This can be added at https://github.com/istanbuljs/schema/blob/c7747f7a7df8a2b770036834af77dfd0ee445733/index.js#L121-L141 along with any additional babel parser plugins which would be needed to parse code supported directly by any release of node.js.  The full list of parser plugins are at https://babeljs.io/docs/en/babel-parser#plugins.
For reference the best way in the mean time to support this for your project is to create nyc.config.cjs:
'use strict';

const {parserPlugins} = require('@istanbuljs/schema').defaults.nyc;
module.exports = {
  parserPlugins: [
    ...parserPlugins,
    'classPrivateMethods'
  ]
};

I've created https://github.com/istanbuljs/schema/issues/16 for this since the fix would go in that module.

Awesome. Much better fix than what I had implemented.
Do you know when the next version will be released so the work around won't be necessary?

Also, for the record, where do your babel plugins come from? Do I need to also install them, and where do the names actually come from (meaning, on the babel plugin page as well as npm repo they are dash separated, but the plugins listed are all camel case). How does the list actually get used?
For instance, adding 'classPrivateMethods' does indeed work, but where on earth is it getting the code to do the translations from at that point (given I do not have the babel plugin installed via npm)?
Thanks

babel parser plugins are all built-in, babel does not support 3rd party parser plugins so the complete list for the current version of @babel/parser is at https://babeljs.io/docs/en/babel-parser#plugins.  Normal babel plugins are a different thing from parser plugins.
I've made a new in-range release of @istanbuljs/schema which sets nyc's default babel parser features to match the capabilities of node.js 15.8.0.


Recommended slippage is not accurate

Describe the bug
Recommended slippage is not accurate
To Reproduce
Steps to reproduce the behavior:

Go to '...'

Additional context
Calculations that lead to this user CTA, should be reviewed, as in this case there is prob no need for user CTA.

@coinhippo can you check exactly what the estimate is here?
it's possible if new tolerance == current then we should display higher decimal precision, or otherwise there is a bug

The UI shows the exact value of the destinationSlippage returned by the SDK; only convert it from BigNumber to Decimal number. (hex: 0x261b -> decimal: 9755)

@preethamr thoughts on next steps here?

Confirmed this is not a bug.


Prevent empty matching macros to stop events propagation

The event handler in the key manager service is stoping event propagation for non matching macros.
E.g. if I have a macro as follow:
this.get('keyManager').addMacro({ 	callback: bind(this, this.controlKeyDown), 	executionKey: 'Control', 	keyEvent: 'keydown' });
Now, for a e.g. left arrow key pressed, in the handleEvent, the  _findMatchingMacros return an empty array,  but the check for match if(matchingMacros) return true and therefore stop the event propagation for that key pressed
Using if(isPresent(matchingMacros))  will do it, unless I'm missing something here!.
Thanks for the nice work, this plugin is lovely

Thanks @mkamneng. Yeah that sounds like it will work. Want to open an PR with a test?

Ok, will do.

A PR with a test have being submitted.
Thanks

Closed by #48


ProviderError: Error: -32603: execution error: OutOfOffset: 0x

ProviderError: Error: -32603: execution error: OutOfOffset: 0x
specifically,  trying to run this command:
cd packages/contracts
hardhat test test/contracts/token/Vesting.ts --network mandala

{
    "jsonrpc": "2.0",
    "method": "eth_estimateGas",
    "params": [
        {
            "data": "0xb6b55f250000000000000000000000000000000000000000000000000000000000989680",
            "from": "0xd2a5c8867d1b3665fb3b2d93d514bd1c73bb2227",
            "to": "0x4e3e1108e86c3fafb389629e99bff9c4fa911e54"
        }
    ],
    "id": 1
}

I find the RPC returns the error.
0xb6b55f25 is signature of deposit(uint256).
Can you check the contract at 0x4e3e1108e86c3fafb389629e99bff9c4fa911e54 with deposit(uint256)?

https://github.com/rust-blockchain/evm/pull/94/files#diff-363a23d98a6c2addecef2665cf68deec178a1dc19d7b625439d4cc50f7f4af50R140
In eth_estimateGas RPC, OutOfGas should be returned, but because the index has changed, the client thinks it is OutOfOffset.
Upgrading the client is resolved


Feat/dialog resources

Should we store the custom links in localstorage with the card's/arrow's id?

Should we store the custom links in localstorage with the card's/arrow's id?

I don't think we have localstorage setup atm, maybe we should handle this in a new issue?

Should we store the custom links in localstorage with the card's/arrow's id?

I don't think we have localstorage setup atm, maybe we should handle this in a new issue?

Sure

/rebase

/rebase

/rebase


fix timestamp error in table view

fix #1934, using iso serializer instead of int serializer in table view.

@xrmx hi, i found only one place that used simplejson in view.py, that's line 1408 where i modified the code. so i deleted this module in this file.

I meant just for consistency wrt other superset code, i agree we should just use json and drop simplejson dependency altogether.


Milestone 0.1.2

Changes Unknown when pulling 01ed61f617e733541d77a102648cc497904c9792 on milestone-0.1.2 into ** on master**.

Changes Unknown when pulling 01ed61f617e733541d77a102648cc497904c9792 on milestone-0.1.2 into ** on master**.


Remove unused empty constructors #100

Fixes #100

Hi @yamgent, I'm getting an Internal Server Error when I try to submit a new iteration.

Seems fine on my side, try again later? Or have you tried it a couple of times and the same error throws up?

Good job on your first PR @apoorva17. You may wish to work on slightly more challenging issues for your next PR.


create walkthrough for non development setup

For someone who does not want to develop the MCP but rather just wants to try it out, we should have a walkthrough that uses the installer, but then takes them only through the OpenShift UI or OC tool

@maleck13 Does https://github.com/feedhenry/mcp-standalone/blob/master/docs/walkthroughs/local-walkthrough.md satisfy this issue?

Yes


feat(cart number): fixed minor bugs and added the number for cart orders

Fixed minor bugs found when in mobile phone.

It's good 👍


Showing reportundefinedVariable

Environment data

Language Server version: XXX
OS and version: XXX
Python version (& distribution if applicable, e.g. Anaconda): XXX

Expected behaviour
XXX
Actual behaviour
XXX
Logs

XXX

Code Snippet / Additional information

XXX

We'll need more information. Can you provide a code snippet that demonstrates the problem you're seeing?


[Bug Report] Changing Bot Volume Crashes Entire Bot

Describe the bug
When I type into Discord (calling key)volume (any volume number that isn't 100) The bot stops laying music and the console log is overloaded with errors
To Reproduce
Steps to reproduce the behavior:
run the bot and ask it to change the volume to 5 and have to bot play music or change it while the bot is playing music.
Expected behavior
the bot to get quieter or louder depending on what the last volume number was
Screenshots
If applicable, add screenshots to help explain your problem.

Version Info (please complete the following information):

Operating System: Windows 10 1903
JMusicBot Version:0.2.5
Java Version:1.8.0

You're running this on 32-bit java. You must use 64-bit.


squid:S2293 - The diamond operator ("<>") should be used

This pull request is focused on resolving occurrences of Sonar rule
squid:S2293 - The diamond operator ("<>") should be used.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS2293
Please let me know if you have any questions.
George Kankava

I was a bit concern when reading the title as I would to be compliant with JDK1.6 as much as possible. You update the operator only on modules requiring >JDK7+ thank you


Added support for ArrayBuffer views as colors.

Hey, I wanted to pass Float32Array buffers to this lib for colors so I ended up writing this tiny patch. I tried to update the tests as well, worked great for my use case !
Thanks for writing this nice lib btw !

Hey this is great! Thanks so much for being so thorough with the tests.
If I understand, this change should let us use pretty much any of the TypedArrays as colors, right?

No problem :). Yes, this lets us use any of the typed arrays but in practice I think only the Float16Array, Float32Array and Float64Array are useful because lilgui expects the color data to be between 0 and 1. Some of the save-load tests seem to have colors stored in the [0-255] format which would let us use the int/uint typed arrays as well but I haven't found how to make the lib do that in practice.


[Onboarding] - Permissions Flow Bugs

Issue type
UI
Steps to reproduce

Navigate to permissions steps in onboarding
Select "Enable Location"
Screen advances immediately without waiting for the user to approve/deny location permissions

Expected Behavior

When I click "Enable Location", the screen does not advance until I approve or deny

Upload any files to the Issue useful in helping us to investigate
In the screenshot below, note that the screen has advanced to the HA permissions before the user has selected approve/deny from location permissions

@namit-agrawal want to take a look at this?

Sure, I can work on this!

Hi, I'm new to this project. I don't have much experience in JavaScript, but I can learn fast. Can anybody point me in the right direction in how to contribute? I came here from the contribution guidelines, but am having trouble in figuring out where to start. Thanks!

Hi, I'm new to this project. I don't have much experience in JavaScript, but I can learn fast. Can anybody point me in the right direction in how to contribute? I came here from the contribution guidelines, but am having trouble in figuring out where to start. Thanks!

Hi Rsrinivasan1 - Do you have access to our Slack? If not, fill out the "Join-Us" form on the PathCheck.org website (directly: bit.ly/pathcheck) and I'll invite you to Slack and send you a welcome email. Then we can assist you in the #app_dev slack channel.

Hi, I'm new to this project. I don't have much experience in JavaScript, but I can learn fast. Can anybody point me in the right direction in how to contribute? I came here from the contribution guidelines, but am having trouble in figuring out where to start. Thanks!

Hi Rsrinivasan1 - Do you have access to our Slack? If not, fill out the "Join-Us" form on the PathCheck.org website (directly: bit.ly/pathcheck) and I'll invite you to Slack and send you a welcome email. Then we can assist you in the #app_dev slack channel.

I just submitted the form, thanks for your help!


LocalDate and LocalTime Parse() implementation

Fixed xmldoc and exception typos, I'll merge it as soon as unit tests on CI builds finish.


Unknown provider: $$isDocumentHiddenProvider

support request
Browser console shows me the following error:
final-fb558dc2f3.js:68 Uncaught Error: [$injector:unpr] Unknown provider: $$isDocumentHiddenProvider <- $$isDocumentHidden <- $$animateQueue <- $animate <- $compile <- $$animateQueue
And I don't know where to make the fix. Any help?

Laravel & Angular version: 3.4.0

can you show your bower.json please?, it's a problem with angular-animate

Yup ran into this too yesterday, in my case reverting to these versions of angular-animate and aria solved it
"dependencies": {
"angular-animate": "1.5.9",
"angular-aria": "1.5.9",
}

Thanks for answering so soon. This is my bower.json
{
  "name": "laravel5-angular-material-starter",
  "authors": [
    "Jad Joubran<EMAIL_ADDRESS>  ],
  "ignore": [
    "**/.*",
    "node_modules",
    "bower_components",
    "test",
    "tests"
  ],
  "dependencies": {
    "angular": "~1.5",
    "angular-ui-router": "~1.0.0-alpha.3",
    "ngstorage": "~0.3.10",
    "angular-material": "~1.1.1",
    "angular-animate": "1.5.9",
    "angular-aria": "1.5.9",
    "restangular": "~1.5.2",
    "angular-loading-bar": "~0.9.0",
    "satellizer": "^0.14.0"
  }
}

Then I ran gulp && gulp watch but nothing happens. There's still the error.

remove angular-animate, and angular-aria, those are added automatically by angular-material

I had to remove angular-animate and angular-aria as @flick36 said, then I run the command:
bower install "angular-animate" so bower answered me again which version of angular I'd wanted to install and I chose one compatible with angular-animate 1.5.9. Thanks.

Yes, you have to keep consistency between versions, normally if you are using angular version 1.5.3 for example, you should use the same version for angular-{something} in this case... if you are using angular 1.5.9 you should use angular-aria and angular-animate 1.5.9

confirm the problem with angular > 1.5.9

@nueko as @flick36 said, you need to keep the consistency between versions. Please verify that your angular and angular plugins all of them have the same version.

When you first run bower install and you will see that
1) angular#~1.5 which resolved to 1.5.11 and is required by laravel5-angular-material-starter
2) angular#1.6.1 which resolved to 1.6.1 and is required by angular-animate#1.6.1, angular-aria#1.6.1, angular-messages#1.6.1

It means that angular-animate#1.6.1, angular-aria#1.6.1, angular-messages#1.6.1 need angular#1.6.1  but laravel5-angular-material-starter need angular 1.5.~,you can choose to reverte three package to 1.5.9, but use angular1.6.1 also works.


[Bug] Diver - Path variables not protected

Given the last 2.10.0 version and a workspace with spaces in its path because of directory names (e.g. "X - Foo Bar Wizz")
When I run the script extract-emails-from-history.sh
The final rm command and also some tests fail.

Fixed in version 2.10.1 (commit 72a57a43d2f03d4c0361a2813ae9a75954cbe3a6)


Moved errors into their own module

Nice work with adding the errors! I think it would be wise to move them into their own module though to prevent lib.rs from growing even larger.
Note that I made the Error type the public export instead of the module to prevent this from being a breaking change. However I would suggest having the module publicly exported instead to follow the convention of other libraries like hyper and rust-postgres.

I'm fine with breaking changes, the code in master is tagged as 0.9.X and
nothing beyond 0.8.X has been published to crates.io yet, And the one other
dependent project I'm aware of has not been updated since june (
https://crates.io/crates/chatbot).
I agree we should follow the convention, in 0.9 forward I want to bring
slack inline with idiomatic, stable, rust.
On Sun, Oct 4, 2015 at 12:11 AM, Matt Jones<EMAIL_ADDRESS>wrote:

Nice work with adding the errors! I think it would be wise to move them
into their own module though to prevent lib.rs from growing even larger.
Note that I made the Error type the public export instead of the module
to prevent this from being a breaking change. However I would suggest
having the module publicly exported instead to follow the convention of
other libraries like hyper http://hyper.rs/hyper/hyper/error/index.html
and rust-postgres
https://github.com/sfackler/rust-postgres/blob/master/src/lib.rs#L94.
You can view, comment on, or merge this pull request online at:
https://github.com/BenTheElder/slack-rs/pull/13
Commit Summary

Moved errors into their own module.

File Changes

A src/error.rs
https://github.com/BenTheElder/slack-rs/pull/13/files#diff-0 (77)
M src/lib.rs
https://github.com/BenTheElder/slack-rs/pull/13/files#diff-1 (75)

Patch Links:

https://github.com/BenTheElder/slack-rs/pull/13.patch
https://github.com/BenTheElder/slack-rs/pull/13.diff

—
Reply to this email directly or view it on GitHub
https://github.com/BenTheElder/slack-rs/pull/13.

Cool, I'll make the breaking change and squash this PR.

Thanks, I appreciate the contributions!
On Sun, Oct 4, 2015 at 12:21 AM, Matt Jones<EMAIL_ADDRESS>wrote:

Cool, I'll make the breaking change and squash this PR.
—
Reply to this email directly or view it on GitHub
https://github.com/BenTheElder/slack-rs/pull/13#issuecomment-145317180.


How to set the flag connect_tools_all ?

Hi! Boey. Thank you for providing such a beautiful work! I noticed in the "construct_edges_from_state"function in graph.py that there is a line of code that reads:
if connect_tools_all:     adj_matrix[obj_tool_mask_1] = 0     adj_matrix[obj_tool_mask_2] = 1     adj_matrix[tool_mask_12] = 0  # avoid tool to tool relations
I would like to understand why connect_tools_all is set to False. And in what scenarios would it be more beneficial to set connect_tools_all to  True? Thank you for your time !

Hi, the connect_tools_all variable is used to link all object particles to the tool particle, rather than basing the connection on spatial distance. Typically, this is set to False because the intuition is that the tool primarily affects the dynamics of nearby object particles.
However, we apply this variable in the cloth case because cloth occupies a larger spatial area, and the default object-tool edge construction method struggles to learn the dynamics due to slow message passing. In this scenario, connecting all cloth particles to the tool effectively transmits the action message to distant object particles.
I hope this explanation clarifies things!

Thank you for your reply, that makes a lot of sense!


Key binding to send a window to a specific desktop

A follow on to #119.
The idea is to have a key binding to send a window to a specific desktop rather than just up/down/left/right.  Something like “send#”.

This is available as of snapshot 1621.

@joewing, How do I make a binding for this? I have the below bindings to switch desktops. Can I add a "Shift" to this and use that to move windows across desktops? I am using the latest jwm.
    <Key mask="4" key="Right">rdesktop</Key>
    <Key mask="4" key="Left">ldesktop</Key>
    <Key mask="4" key="Up">udesktop</Key>
    <Key mask="4" key="Down">ddesktop</Key>

This issue added the send# binding, which sends a window to a specific desktop identified by whatever number you select (having a mask of alt with the send# binding will allow you to press alt+5 to send to desktop 5).
I think you are interested in the sendl/r/u/d bindings, which send the window left/right/up/down.

Thank You. I actually needed send# itself. I pasted the wrong section here!
I have <Key mask="4" key="#">desktop#</Key>
The problem was that I was still using /bin/jwm while the latest was in /usr/local/bin/jwm.


"jenv use" doesn't work in powershell

powershell

cmd

seems invoking ps1 script via pwsh got another scope.
> pwsh -Command '& {$Env:var=1; echo "Inner: $Env:var"}' ; echo "outer: $Env:var"
Inner: 1
outer:

We still need to use batch because there are windows user using cmd.
Normally the powershell script can change the env vars of powershell. The batch file is not ment to be used by powershell users as stated in the readme. Please call jenv.ps1 directly. Then no batch file is called and your env vars will be set correctly. At least I hope so. :) The batch scripts only purpose is to be called by cmd users

We still need to use batch because there are windows users using cmd.
Normally the powershell script can change the env vars of powershell. The batch file is not ment to be used by powershell users as stated in the readme. Please call jenv.ps1 directly. Then no batch file is called and your env vars will be set correctly. At least I hope so. :) The batch scripts only purpose is to be called by cmd users

Thx for the explanation. The awkward situation is when JEnv-for-Windows directory put into PATH, the jenv.bat precedes the jenv.ps1(even putting JEnv-for-Windows/src before JEnv-for-Windows). If it's possible to provide jenv by installing it as PowerShell module.

You may just delete or rename jenv.bat for now. All of these issues will be
fixed once I have time to do a proper rewrite
kid1412621 @.***> schrieb am Do., 25. Mai 2023, 17:39:

We still need to use batch because there are windows users using cmd.
Normally the powershell script can change the env vars of powershell. The
batch file is not ment to be used by powershell users as stated in the
readme. Please call jenv.ps1 directly. Then no batch file is called and
your env vars will be set correctly. At least I hope so. :) The batch
scripts only purpose is to be called by cmd users
Thx for the explanation. The awkward situation is when JEnv-for-Windows
directory put into PATH, the jenv.bat precedes the jenv.ps1(even putting
JEnv-for-Windows/src before JEnv-for-Windows). If it's possible to
provide jenv by installing it as PowerShell module.
—
Reply to this email directly, view it on GitHub
https://github.com/FelixSelter/JEnv-for-Windows/issues/52#issuecomment-1563121143,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANHZIAVWSQYXJRXM76O7CU3XH54JHANCNFSM6AAAAAAXGOPDZU
.
You are receiving this because you were mentioned.Message ID:
@.***>

For those using pwsh to resolve this temporally:

remove/rename jenv.bat and java.ps1 in the project root path.
add src/java.ps1 file with this content:

$javaHome = jenv getjava
$javaExecutable = "$javaHome/bin/java.exe"
if (test-path -Path $javaExecutable -PathType Leaf) {
    & $javaExecutable $args
}
else {
    Write-Host "There was an error:"
    Write-Host $javaHome
}

modify src/jenv.ps1 line 70. From $dummyScript = ("{0}\java.bat" -f $root) to $dummyScript = ("{0}\src\java.ps1" -f $root).

need minor change in java.bat.
where /q pwsh
IF ERRORLEVEL 1 (
    where /q powershell
    IF ERRORLEVEL 1 (
        echo Neither pwsh.exe nor powershell.exe was found in your path.
        echo Please install powershell it is required
        exit /B
    ) ELSE (
        set ps=powershell
    )
) ELSE (
    set ps=pwsh
)
for /f "delims=" %%i in ('%ps% -Command & {jenv getjava}') do set "var=%%i"

You may just delete or rename jenv.bat for now. All of these issues will be fixed once I have time to do a proper rewrite kid1412621 @.> schrieb am Do., 25. Mai 2023, 17:39:
…
We still need to use batch because there are windows users using cmd. Normally the powershell script can change the env vars of powershell. The batch file is not ment to be used by powershell users as stated in the readme. Please call jenv.ps1 directly. Then no batch file is called and your env vars will be set correctly. At least I hope so. :) The batch scripts only purpose is to be called by cmd users Thx for the explanation. The awkward situation is when JEnv-for-Windows directory put into PATH, the jenv.bat precedes the jenv.ps1(even putting JEnv-for-Windows/src before JEnv-for-Windows). If it's possible to provide jenv by installing it as PowerShell module. — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANHZIAVWSQYXJRXM76O7CU3XH54JHANCNFSM6AAAAAAXGOPDZU . You are receiving this because you were mentioned.Message ID: @.>

Thanks, no worries. Take your time, and I'd glad to help.

Thank you for your suggestion. I`ll keep this in mind when doing the proper rewrite. Its planned to add a fully functional powershell integration as well as many more for other shells. Tomorrow holidays will start so I have two weeks of partially spare time to enhance this tool

@FelixSelter I see this same issue while using Git Bash on Windows

This problem can be solved by adding a jenv.ps1 at the top level of this project:
Invoke-Expression "${PSScriptRoot}/src/jenv.ps1 $args"

This problem can be solved by adding a jenv.ps1 at the top level of this project:
Invoke-Expression "${PSScriptRoot}/src/jenv.ps1 $args"

@FelixSelter I see this same issue while using Git Bash on Windows

if you use git bash on windows, you should use https://www.jenv.be/ instead of this project.


Fix a typo: change "such Bash" to "such as Bash" in dockerfile_best-practices.md

PS There is "BASH" in docs/project/set-up-dev-env.md, there are also "Bash" and "bash" in other doc files. Which should be the consistent way?

According to Bash Reference Manual, and Wikipedia the name is Bash.
when referred to as a command, it is bash.

LGTM

Thanks, that was really fast!
One more question: when should be documentation fixes like this one be based on origin/master, and when on origin/docs? I've tried to find it in the docs, and I thought origin/docs is being merged to origin/master from time to time, but git log origin/master..origin/docs says there are unmerged commits 6 months old.


Crouch while falling does nothing visually but the viewpoint goes down as if it's crouched

Press c key while falling
It's still the same falling animation with no differences
The viewpoint goes down as if it's crouched

fixed in this PR: https://github.com/webaverse/app/pull/3543


Include source for salesforce-flow-visualiser

Seems like the bulk of the work being done in this package is happening in a file called salesforce-flow-visualiser that isn't included in the source.
Are there any plans to open source this?  Would be nice to be able to contribute to bug fixes or use this in other projects (depending on the license).
Thanks

Oh yes... on this version that is the case.
The next version brings some more out, though that lib is still needed.
And yes, the plan is indeed to open up the lib and have it on npm so it be used in other things (like DX CLI plugins, etc).


Added E-commerce website

Description 📜
Included E-commerce website with many functionalities (You can find it out in readme.md).
Functionalities :

Login / sign up using local storage
Dark / Light theme
Product images linked to original product
Cart functionalities (products can be added to cart and it will be there till you remove them)
Fully Responsive

Fixes #1190

Type of change 📝

[x] Add a new project

Domain of Contribution 📊

[x] Project using HTML, CSS & JS

Checklist ✅

[x] I have performed a self-review of my own code or work.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[x] I'm GSSoC'22 contributor

Screenshots / Gif (Recommended) 📸

More images in readme.md file

@gurjeetsinghvirdee Please Review my PR.

@aaryahjolia attach video

@aaryahjolia attach video

https://user-images.githubusercontent.com/82600388/167143885-419aed9a-eac2-49da-8fd7-33b4719b2214.mp4

@aaryahjolia Mera mnn level10 dene ka h par aisa koi label ni h✨
Great work


docs: add Japanese README

I created Japanese translated README.

I'm not sure about whether we should add more languages for the repo. We have English version and Chinese version because we have ability to maintain them, adding another languages might result in lack of updates.

I'm going to close the request because of the above concern. But thanks for your contribution anyway!


Add RTP Stats to stats report

This PR implements inbound and outbound RTP stats according to the
specification, with some
limitations.
Todo

[x] Inbound RTP
[x] Outbound RTP
[x] Tests

Will tackle Remote{Inbound,Outbound}RTP in another PR


Support git-sparse-checkout option to check out a subset of a git dependency

Added new param into .cargo/config to skip fetching of git submodules during the cargo build/run.
Per my understanding, this param will not be widely used in open-source community where every module is available, but it will be mostly used in commercial development.
Current behavior: if user has no access to the git submodule(e.g. trade-secret), then build fails because git fetch fails. This PR solves that by allowing users to skip fetching for optional submodules.
Added:
new section: git
new param in git section: ignore-fetch-modules
PR simulates GIT's setting to skip submodule's updating. e.g. setting in .gitconfig may look like this:
[submodule "somename1"]
        active = false
        ignore = all
        url = https://github.somelink.com/soemname1.git
        update = none

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

We talked about this in today's @rust-lang/cargo meeting.
We don't feel that this option should be global; rather, it should be something that's specific to a given dependency in a specific Cargo.toml (or an override of that dependency).
As a general solution, we'd propose having a git-sparse-checkout = """...""" option. This option would specify the content of a git sparse-checkout file. If present, cargo would do a sparse checkout of the git dependency, which would also skip any git submodules omitted from the sparse checkout.
Does this seem like it would address your use case?

@joshtriplett Thank you for your response and proposed possible solution.  I will talk to our team members and other team leads to see if git's sparse-checkout is going to work for us.

@ariva I've retitled this issue accordingly. And if you are interested in implementing this, please by all means do!

@joshtriplett Thank you. I will do it.

Closing due to inactivity.  If you want to continue to pursue this, feel free to reopen (or open a new PR) with the concerns addressed.

Closing due to inactivity.  If you want to continue to pursue this, feel free to reopen (or open a new PR) with the concerns addressed.


Resize large images to conserve storage

The app currently seems to allow any size image to be uploaded (I was able to upload a 35MB sample image see #84).
Suggest automatically resize large attached images (to 1920p max?) to conserve storage space.

Assuming we can limit the upload file size, I don’t think it is worth resizing the images, at least for the S3 upload.

Was just thinking that cameras often take large images where smaller resolution one would likely suffice for viewing. For example, imagine all 20,000 existing expenses had a 1MB image => 20,000MB => 20GB Auto-resizing to a max resolution “should” conserve storage in the long term I think?

Just adding a comment that you can achieve this type of functionality by running a lambda that resizes images for you (based on S3 events or MinIO equivalent), without it having to be a part of the app.
Unless I'm mistaken, it seems like the images never pass the backend with the current solution, so adding some sort of resizing is not a minor change.

I like this approach @justcallmelarry, thanks for the input :)


Hashing in C++ #2211

Description 📜
Added documentation and a video on Hashing in CPP.
#2211

Type of change 📝

[ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[x] Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[x] Doc#umentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev #(Flutter)
[ ] Android Dev #(Java)
[ ] Android Dev #(Kotlin)
[ ] Backend Dev #(Java)
[ ] Backend Dev #(.NET)
[ ] Backend Dev #(PHP)
[ ] Backend Dev #(Python)
[x] C/#CPP
[ ] Competitive #Programming
[ ] Cyber #Security
[ ] DS#A
[ ] Data#base
[ ] Datascience with #Python
[ ] Datascience with #R
[ ] Frontend Dev #HTML/CSS/JS
[ ] Frontend Dev #React/Angular/Vue
[ ] Go#lang
[ ] Interview #Prep
[ ] Java_#Domain
[ ] Java#Script
[ ] ME#RN
[ ] Machine #Learning
[ ] Open #Source
[ ] Python_#Domain
[ ] Ru#st
[ ] Statis#tics
[ ] UI/#UX

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@Suvraneel Please review my code.

@Shivani0701 @deeqakk Review the doc... Video is cool :rocket:

@Suvraneel I have made the changes. Please review!

@ChetasShree @gunjan-g

@Shivani0701 @deeqakkk Review the doc... Video is cool 🚀

@Suvraneel It is perfect ✌

@ChetasShree @gunjan-g Doc dekh lo ekbar

Yes, It's good

@elixir14082002  This is nice ... Just 1 last thing...
In the readme for Data Structure add a relative link to this

@Suvraneel I have updated the readme for Data Structures.

@elixir14082002 Awesome ❤  Make more video contribs :octocat:
Also, just 1 suggestion, instead of bits std, from next one show them the actual headers (Knowledge is essential)


Routes not working?

I installed the new version and are you sure routes are working?

Version 2.1.0

Hovering doesn't work either


Windows Settings DSC Resources

Description of the new feature / enhancement
I'd like to capture all Windows Settings as DSC Resources.
Microsoft.Windows.Setting would be the "top level" module so all the children could be included for WinGet to be able to winget configure export.
This list below is organized based on appearance in Windows Settings (Windows 11).

[ ] Microsoft.Windows.Setting.System
[ ] Microsoft.Windows.Setting.Bluetooth
[ ] Microsoft.Windows.Setting.Device
[ ] Microsoft.Windows.Setting.Network
[ ] Microsoft.Windows.Setting.Personalization
[ ] Microsoft.Windows.Setting.App
[ ] Microsoft.Windows.Setting.Account
[ ] Microsoft.Windows.Setting.Time
[ ] Microsoft.Windows.Setting.Language
[ ] Microsoft.Windows.Setting.Gaming
[ ] Microsoft.Windows.Setting.Accessibility

https://github.com/microsoft/winget-dsc/issues/53

[ ] Microsoft.Windows.Setting.Privacy
[ ] Microsoft.Windows.Setting.Security
[ ] Microsoft.Windows.Setting.Update

I'll update the description as we continue to break things out. I just wanted to get this issue in place to help track the work as we coordinate with other collaborators.
Proposed technical implementation details
No response

Mentioning @stephengillie to see if that let's me assign the issue...

I can't edit the above comment, so adding new Issues here:

[ ] Microsoft.Windows.Setting.System

#81

[ ] Microsoft.Windows.Setting.Bluetooth
[ ] Microsoft.Windows.Setting.Device
[ ] Microsoft.Windows.Setting.Network
[ ] Microsoft.Windows.Setting.Personalization
[ ] Microsoft.Windows.Setting.App
[ ] Microsoft.Windows.Setting.Account
[ ] Microsoft.Windows.Setting.Time
[ ] Microsoft.Windows.Setting.Language
[ ] Microsoft.Windows.Setting.Gaming
[ ] Microsoft.Windows.Setting.Accessibility

#53

[ ] Microsoft.Windows.Setting.Privacy
[ ] Microsoft.Windows.Setting.Security
[ ] Microsoft.Windows.Setting.Update


Need a way to suppress welcome email to guest users

This is a great feature, but I needed to create a dynamic group for guest users, without having a welcome-email sent to the group members. The welcome email listed all the names of the members of the group, which is certainly not appropriate for guest users - which in my case included customers. There absolutely needs to be an option to suppress the welcome email.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 24c25353-cfb3-811c-a970-2a04678eff6e
Version Independent ID: 145d404a-f7ed-17f6-79a6-0204ab7ee70b
Content: Create a dynamic group and check status - Azure Active Directory
Content Source: articles/active-directory/users-groups-roles/groups-create-rule.md
Service: active-directory
GitHub Login: @curtand
Microsoft Alias: curtand

@brianmair Thanks for your feedback! We will investigate and update as appropriate.

@brianmair Unfortunately this is currently not possible and you can find an existing UserVoice. You can upvote the same and this will allow the community to upvote and for the product team to include into their plans.

Thanks for getting back to me. I’ve added my vote.
Best Regards
Brian
[logo_signature2]
Brian Mair | +852 6340 7631 | bornsolutions.comhttps://www.bornsolutions.com/ | SharePoint & Office 365
From: SaurabhSharma-MSFT<EMAIL_ADDRESS>Sent: Friday, 1 March 2019 6:46 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Brian Mair<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Need a way to suppress welcome email to guest users (#25835)
@brianmairhttps://github.com/brianmair Unfortunately this is currently not possible and you can find an existing UserVoicehttps://office365.uservoice.com/forums/286611-office-365-groups/suggestions/13121412-disable-email-notifiations-when-assiging-to-group. You can upvote the same and this will allow the community to upvote and for the product team to include into their plans.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/25835#issuecomment-468469798, or mute the threadhttps://github.com/notifications/unsubscribe-auth/At03NioXEcadQLvWTjwaJhyW1s92HAK4ks5vSFxAgaJpZM4bUKkh.

Hi, I presume this is an O365 group ?  If so you can disable the welcome email using this powershell command:  Set-UnifiedGroup -Identity "Name of your group" -UnifiedGroupWelcomeMessageEnabled:$false

@brianmair We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Specify git revision to avoid breakage as possible on semverver

@JohnTitor: no appropriate reviewer found, use r? to override

@bors r+

:pushpin: Commit 908363d836fd0ebab499d4356b6f0805c8ebbecc has been approved by JohnTitor

:hourglass: Testing commit 908363d836fd0ebab499d4356b6f0805c8ebbecc with merge e67af59e53842658be194d9f26a5a5236e297142...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing e67af59e53842658be194d9f26a5a5236e297142 to master...


play.grid.tf is down with reservation can only contain either free nodes or paid nodes, not both

When I tried to create a new container

the gateway used for reservations is no longer free_to_use
https://explorer.grid.tf/explorer/gateways/EwPS7nPZHd5KH6YH7PtbmUpJUyWgseqsqS7cGhjXLUjz