[QUESTION] lock is held by csi-attacher-5dcdcd5984-wq54x and has not yet expired

Question
I used the harvester charts to deploy longhorn, but I saw a lot of error messages in csi-attacher when create pvc for pod
I0803 02:54:03.154923       1 leaderelection.go:352] lock is held by csi-attacher-5dcdcd5984-wq54x and has not yet expired
I0803 02:54:03.154939       1 leaderelection.go:247] failed to acquire lease longhorn-system/external-attacher-leader-driver-longhorn-io

longhorn-system    csi-attacher-5dcdcd5984-vxsqq                           1/1     Running             0          54m
longhorn-system    csi-attacher-5dcdcd5984-wq54x                           1/1     Running             0          54m
longhorn-system    csi-attacher-5dcdcd5984-xjlvm                           1/1     Running             0          54m
longhorn-system    csi-provisioner-5c9dfb6446-2fff6                        1/1     Running             0          54m
longhorn-system    csi-provisioner-5c9dfb6446-6j7f4                        1/1     Running             0          54m
longhorn-system    csi-provisioner-5c9dfb6446-jtgrs                        1/1     Running             0          54m
longhorn-system    csi-resizer-6696d857b6-774xk                            1/1     Running             0          54m
longhorn-system    csi-resizer-6696d857b6-dscqd                            1/1     Running             0          54m
longhorn-system    csi-resizer-6696d857b6-jzgf7                            1/1     Running             0          54m
longhorn-system    csi-snapshotter-96bfff7c9-2rcqk                         1/1     Running             0          54m
longhorn-system    csi-snapshotter-96bfff7c9-l9q2x                         1/1     Running             0          54m
longhorn-system    csi-snapshotter-96bfff7c9-tjr2q                         1/1     Running             0          54m
longhorn-system    engine-image-ei-611d1496-8xbpz                          1/1     Running             0          54m
longhorn-system    engine-image-ei-611d1496-dzd6n                          1/1     Running             0          54m
longhorn-system    engine-image-ei-611d1496-nvknt                          1/1     Running             0          54m
longhorn-system    instance-manager-e-3efe0bf2                             1/1     Running             0          54m
longhorn-system    instance-manager-e-6499e0bd                             1/1     Running             0          54m
longhorn-system    instance-manager-e-86a3f832                             1/1     Running             0          54m
longhorn-system    instance-manager-r-6151162c                             1/1     Running             0          54m
longhorn-system    instance-manager-r-9306a803                             1/1     Running             0          54m
longhorn-system    instance-manager-r-fc31f75c                             1/1     Running             0          54m
longhorn-system    longhorn-csi-plugin-n6cmh                               2/2     Running             0          54m
longhorn-system    longhorn-csi-plugin-vs6w5                               2/2     Running             0          54m
longhorn-system    longhorn-csi-plugin-w8kx9                               2/2     Running             0          54m
longhorn-system    longhorn-driver-deployer-7d4b5b75cb-76drn               1/1     Running             0          55m
longhorn-system    longhorn-manager-c7lrq                                  1/1     Running             0          55m
longhorn-system    longhorn-manager-kbcnm                                  1/1     Running             0          55m
longhorn-system    longhorn-manager-tf6rr                                  1/1     Running             1          55m
longhorn-system    longhorn-ui-b4fb6fc48-qjtpp                             1/1     Running             0          55m
default            volume-test                                             0/1     ContainerCreating   0          47m

Environment:

Longhorn version: 1.1.1
Kubernetes version: v1.20.8

ref: https://github.com/longhorn/longhorn/issues/1202

THX.
But why my pod doesn't work. I see the error message is
  Warning  FailedMount         40m (x11 over 151m)    kubelet                  Unable to attach or mount volumes: unmounted volumes=[volv], unattached volumes=[default-token-fndmc volv]: timed out waiting for the condition
  Warning  FailedAttachVolume  11m (x16 over 139m)    attachdetach-controller  AttachVolume.Attach failed for volume "pvc-fe64ff3d-aec4-43b6-aa47-c8aab665d09a" : rpc error: code = Aborted desc = The volume pvc-fe64ff3d-aec4-43b6-aa47-c8aab665d09a in state detaching is not ready for workloads
  Warning  FailedMount         6m45s (x53 over 147m)  kubelet                  Unable to attach or mount volumes: unmounted volumes=[volv], unattached volumes=[volv default-token-fndmc]: timed out waiting for the condition
  Warning  FailedAttachVolume  73s (x65 over 151m)    attachdetach-controller  AttachVolume.Attach failed for volume "pvc-fe64ff3d-aec4-43b6-aa47-c8aab665d09a" : rpc error: code = DeadlineExceeded desc = Failed to attach volume pvc-fe64ff3d-aec4-43b6-aa47-c8aab665d09a to node k8s-165

Have you install the open-iscsi and enable iscsid service?

Could you please provide the support bundle to us?

@yuchunyun
How many nodes do you have? 1 or 2?

After install the open-iscsi and enable iscsid service, it was back to normal. Thank you very much


Unforce WinRM over HTTPS on Gateway

Hi all
I have updated WAC to version 1909 and I have checked force WinRM over HTTPS option.
And now we have a problem, our servers and clients doesn't have WinRM over HTTPS configured.
As long as we reconfigure WINRM, there is an option to unforce  WinRM over HTTPS in WAC Gateway?.
Regards

Any help is appreciated.


Instances of global classes not observable

Test case:
https://runkit.com/scriptspry/observer-utils-global-definitions-not-observable

const {observable, observe, isObservable} = require('@nx-js/observer-util');

class Counter {
    constructor() { this._count = 0 }
    increment() { this._count += 1 }
    decrement() { this._count -= 1 }
}

const c = observable(new Counter());
console.log('c', isObservable(c));

global.Counter = Counter;
const c2 = observable(new Counter());
console.log('c2', isObservable(c2));

Hi!
That's intended, but it is a dirty hack and it should be changed. I introduced this in the latest patch (4.1.2). The reason:
Built-in JS objects can not be wrapped with Proxies because of their 'internal slots'. They throw an 'Invalid Invocation' error when you try to call their methods on the wrapping Proxy. To work around this I had to do two things.

Instrument stateful built-in objects - like Map and Set - with monkey patching instead of Proxies.
Opt-out stateless built-in objects from the Proxy wrapping, since there is not state to observe and and it would throw errors.

To do the latter I need an algorithm, which detects built-in Objects. At first I tried to maintain a list, since there or not so many standard JS built-ins. I failed to do this though, because this lib supports both NodeJS and browsers, which have a lot of different built-ins. I got issues about illegal invocation error on WebAudio objects (browser built-in) for example. Maintaining a list of all browser and NodeJS built-ins is not feasible, so I decided to do the current dirty detection. I check if the object constructor is available on the global Object, since all built-ins are global.
This should swapped with a more elegant algorithm, but I couldn't find any. I will keep thinking about this and change it soon and I am open to any suggestions, ideas and PRs.
I hope this made the issue clear. Thanks for the issues 🙂 (I won't be around during the weekend.)

Hi,
I couldn't find any nice general way to detect built-ins yet. One improvement I could do is to save all global constructors in a Set at startup time and use it later, instead of dynamically checking the global object each time. It means it would not instrument only objects that has a constructor, which was global when the library initialized. This way your specific example would work.
 I am looking for a better alternative 🙁

This repo is 8 years old, but the getCleanWindow seems promising. If it isn't costly on performance and about:blank is robust enough url to load across browsers, this could help in checking if it's a browser native or a user defined property on the window.

On second thought, I don't think that will work, It will just check for things in Window but not things like Map, Array etc. which are what need to be skipped. I have no other ideas. Perhaps posting on stackoverflow may help us.


Issue with generation in Response while code generation

Thanks for this very useful library. Appreciate the hard work.
As described in https://github.com/epam-cross-platform-lab/swagger-dart-code-generator/issues/58 - we still face the issue where the return type is generated as
Future<Response<Bool>> instead of Future<Response<bool>> causing compile time errors.
Having gone through the changes in https://github.com/epam-cross-platform-lab/swagger-dart-code-generator/pull/60 it didn't look like bool was included in the list of exception words.
We are currently using swagger_dart_code_generator: ^1.6.8 and still seeing the issue.
Requesting for any advice or assistance.

is it possible to share the swagger file to reproduce the issue?

Hey @fryette, Here's the link https://devweb.optotax.com/optomoney/v3/api-docs.

I havan same issue. Swagger json file generic type with '«»' will break generation with Illegal character error message.

Now we are mostly working on the null-safety version.
We will take a look at it this week.
@syq7970 Swagger has standards and if it breaks standards we really don't want to support it because it is impossible to handle all issues.
As a workaround, you can write a script that will remove all illegal characters from your swagger files and then run generation.

@fryette
Thx for reply.
I'm trying fix illegal characters with script, but it seems like the generation process is not completed, because illegal characters break the process, so even replace all  '«»' to '<>', It still have lot of errors.
Maybe it is dart not support 'illegal characters', I use Swift code generation  with the same Api json file, and it worked like a charm.

@syq7970 is it possible to create the separate issue and share swagger?

I have run into the same Response issue as @sakthivel-sm. I believe that the issue is at line 426 of the src/code_generators/swagger_requests_generator.dart file.
    if (returnType.isNotEmpty && returnType != 'num') {       returnType = returnType.pascalCase;     }
When the returnType 'bool' comes along, it Pascal cases it to 'Bool'. It works as expected if I modify the line to:
        if (returnType.isNotEmpty && (returnType != 'num' && returnType != 'bool')) {       returnType = returnType.pascalCase;     }
Not sure, but might this affect other built-in types?

Hi @LanderTome ,
if you want feel free to create PR with fix. Or I can take a look into it soon.

Hi @sakthivel-sm , @syq7970 , @LanderTome ,
Just checked your file and it's generated without issues. Thanks @LanderTome  for fix. I'm closing the issue. Feel free to create another ones :)

The only one thing there is no next ref
Error-ModelName{namespace='org.javers.core.diff', name='Change'}
It's crazy thing possible swagger file is incorrect :D


Tasks 877-881: kde4, schema_guided_dstc8 Datasets

Overall the tasks look good. For one of the tasks (as suggested above), you need to elaborate on the task definition.

Please make sure to set the "Categories": [""] and "Domains": [""] fields according to the taxonomy presented here.


Suspend sub-processes when control-z is hit.

When control-z is hit the shell sends SIGTSTP to the front process group.
Generally it suspends all the process tree started by the command. But ninja
moves its sub-process to their own group so that it can stop them all on
interruption. This is a great improvement compared to make(1). However in such
a case sub-processes are not automatically suspended by the shell when you
hit control-z. Only ninja is and the command it has started keep running.
This patch addresses this issue by catching SIGTSTP and forwarding it to its
sub-processes groups. Thus, the entire ninja's process tree is suspended as
expected.
This pull-request is based on the #743.

Can you rebase this on top of trunk now that your SIGTERM change is merged?

Done

@nico I have tested this PR on OSX 10.10.5, Linux 2.6.32-35 and Linux 3.16.0-4-amd64 and it passes. I think the reason why the travis job fails is because it uses Linux 2.6.32-042stab090.5. Unfortunately, I did not succeed to reproduce Travis environment locally to debug it because all the VM images I found on Travis' web site have a 3.12 kernel version. Apparently, our travis jobs uses the legacy infrastructure so maybe that's why I cannot find older image.

If anyone have tried this PR on its setup, I will be glade to have some feedback whether 1) it works 2) the test suite passes. TIA.

@nico I have improved the test robustness and now it passes travis' check.

Bump. @nicolasdespres, could you rebase it, please?

I will try to do it shortly.

@mgorny rebase done. Have fun.

TravisBuild fails on Linux (4.4.0-101-generic). I cannot reproduce it on my Linux box (kernel 4.9.0-8-amd64). Any idea how to have access to the Travis environment without the Debug Mode ?

Have you tried Debug Mode already?

It is not enabled on this repository. I think one of the maintainer should do it. See the link in my previous post.

You can enable Travis CI for your fork on GitHub :)

I do not now how to this and Travis only run on the master repository not mine.

Debug mode enabled. Sorry for the noise.

The build passes in debug mode. If have pushed multiple debug patches to investigate. There is something wrong with SIGTSTP which did not get caught when sent from Ninja... That is very unfortunate. I have double checked the timestamp and run the test a hundred times to make sure there is not a race condition going one. VFORK does not interfere either. Honestly I do not know what to try now. I think I would merge the PR and disable the test on Travis and see if there is a people complaining about this test. If there is we can still revert the commit during the candidate release process. WDYT?

I would prefer if the test passes on Travis CI.
Have you tried reproducing on Ubuntu 14.04?

No. I tried on Debian 9.8 and it succeeds. But I just found a Ubuntu 16.04.6 host where I can reproduce it. I'll try to find some time to investigate.

Something to consider for a future PR (not this one) is that on newer Linux kernels, the cgroups functionality has support for assigning child processes to a cgroup, which also ensures that all child processes of the child process will be in the same cgroup.
The main benefit for underlying concept of this PR is that cgroups allow all processes inside of a cgroup to be "frozen" simultaneously.
https://www.kernel.org/doc/Documentation/cgroup-v1/freezer-subsystem.txt
I can't speak to non-Linux operating systems having support for something like this, but for Linux, using cgroups (when detected at runtime as available) would likely be a superior way to implement this functionality.


Literature research to improve cost calculation for public transport

Google Maps API can return one out of many types of public transports (full list here).
We need to estimate the costs for each of these. The idea is to use a formular like:
price = base_price + distance * price_per_km
Both base_price and price_per_km need to be hard-coded in the metadata.json for each type of transportation.
We are lacking a good source for computing these prices.  A literature review is needed, maybe we find a single source that can cover most transportation types.
@NinaWie you found a good source to start with, maybe you can post.

In this paper they show a table (Table1) where they describe prices for train, airplane and bus, but only for long distance transport in Norway. Maybe we can do something similar and use Table 1 as a baseline (but prices need to be changed from NOK to Euros and the price level might need to be adapted).
Maybe we can also find out something here, I haven't checked the document completely:

Cool. I don't think we have to find specific values for each possible transportation type (see above, some are quite weird) but it would be cool to be as fine grained as reasonably possible - and then copy paste the rest.

Cool. I don't think we have to find specific values for each possible transportation type (see above, some are quite weird) but it would be cool to be as fine grained as reasonably possible - and then copy paste the rest.


Changing Body Width causes text color to change

Describe the bug
setting width to anything other than default causes all text in body to be black in some email clients.
 <mj-body width="700px" background-color="#D3D3D3">
Simply removing the width=700px fixes the problem
To Reproduce

 with hard coded text in white.
Send test email and read in Spark

Expected behavior
Text should be white, but showing up as black
MJML environment (please complete the following information):

OS: MacOS
MJML Version 4.8.1
MJML tool used MJML Editor

Email sending environment(for rendering issues):

Mailjet

Affected email clients (for rendering issues):

Spark
OS: MacOS

Spark isn't in our test scope so I don't know what could happen here.
It's a bit weird as body's width is defined anyway. Can you post full MJML
here https://mjml.io/try-it-live ?
On Tue, Feb 2, 2021 at 1:20 AM Collin Moore<EMAIL_ADDRESS>wrote:

Describe the bug
setting width to anything other than default causes all text in body to be
black in some email clients.

Simply removing the width=700px fixes the problem
To Reproduce

with hard coded text in white.
Send test email and read in Spark

Expected behavior
Text should be white, but showing up as black
MJML environment (please complete the following information):

OS: MacOS
MJML Version 4.8.1
MJML tool used MJML Editor

Email sending environment(for rendering issues):

Mailjet

Affected email clients (for rendering issues):

Spark
OS: MacOS

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/2166, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELHTPAHYCLOJKPQEIEZODS45AOLANCNFSM4W5WJYGQ
.

Adding another variable when having a background-image.
`

<mj-attributes>
  <mj-text align="center" color="#555" />
  <mj-section background-color="#fff" />
</mj-attributes>

just testing out some text here

`

It's not related to mj-body width but to background image. It seems like a bug in their HTML sanitizer because if you replace #FFFFFF by #FFFFEE text will appear properly.
You should contact them to see what they can do about it, for now you can just use a non true white color as we can't do anything on our side


Extend editor to have tabs for different edit parts

Navigation Attributes
Access Rights
Page layout of the Widget

Pluggable tab spaces!

obsolate


IngestLDD updates per LDD generation

Summary

Enter summary here
Test Data and/or Report

Enter info here
Related Issues

Enter related issues here

@rsjoyner LDD generation process failed

https://github.com/pds-data-dictionaries/ldd-ladee/actions/runs/8072031503/job/22052961063
not sure what is going on here.

@rsjoyner looks like you removed the IngestLDD from the repo:
https://github.com/pds-data-dictionaries/ldd-ladee/tree/rsjoyner-patch-2/src
I think you will want to add it back from main.
Also, make sure you name it PDS4_LADEE_IngestLDD.xml. No need to add the dates or anything to the files. It just confuses some of our automation tools


Doc page refers to earlier mention that doesn't exist

Page says "See the earlier-mentioned documentation on how to refresh your subscriptions." but there is no earlier mention of refreshing subscriptions, much less a link to its documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b036f172-b0cf-d2af-1307-a3f5abf49524
Version Independent ID: 894da04b-5803-4f44-a94f-0fa462b006a9
Content: Best practices for discovering files and detecting changes at scale - OneDrive dev center
Content Source: docs/rest-api/concepts/scan-guidance.md
Product: onedrive
GitHub Login: @JeremyKelley
Microsoft Alias: JeremyKe

@bmulholland The documentation we are referring to is the Graph subscription page linked above.

https://aka.ms/webhookdoc

@k-tsoi Okay, but that's not in the documentation page, and answering me here doesn't fix the problem on the page itself. This issue is not closed.


Heartbeating the executor is too chatty

I ran docker-compose -f docker-compose-LocalExecutor.yml up and the log prints out the following 2 lines non-stop.  Is that normal?  I don't remember seeing that when I tried a non docker version long time ago.
webserver_1  | [2018-08-28 02:32:05,752] {jobs.py:1662} INFO - Heartbeating the executor
webserver_1  | [2018-08-28 02:32:06,756] {jobs.py:1627} INFO - Heartbeating the process manager
...

Since airflow 1.10.0 these logs are DEBUG not INFO so hopefully won't appear any more:
https://github.com/apache/incubator-airflow/commit/a5d9d5038b3ab59dcc1f64a1c161fb63f41c58cf
Also, since airflow 1.9 airflow uses the Python logging module internally, and you can configure the log levels for various components as described here:
https://github.com/apache/incubator-airflow/blob/master/UPDATING.md
Though I've not tried myself.


Fix copy-pasteism in CFI directives.

I don't think this actually affects anything since the cfi_restore
directives aren't strictly needed anyway. (The old values are still in
memory so either will do.)

Description of change
I failed to catch this mistake in the review of 76e624a003db22db2d99ece04a15e20fe44c1fbe although, as noted, I don't think it actually affects anything.

@dot-asm, sorry for not catching this before.

I recall fixing it... Might be false memory. But I've also found typo in x86_64-xlate I recall fixing, and this is not false memory. Looks like I've fixed up something when splitting modifications to different commits.... Oh well, I'll commit this tomorrow and submit more requests...


Aliased actions and relative paths

I'm trying to think through how to handle the following:
We agree that remote calls (e.g. database) should be handled exclusively in the main thread. Using aliased actions is there to help.  However, what if there are credentials necessary for that call? These credentials shouldn't be exposed to the renderer thread, however, that is where the request originates and maps the relative paths using createAliasedAction() in my testing.
So with some sloppy code example:
main thread - dbCred.js
// @flow
import fs from 'fs';
import path from 'path';
import { app } from 'electron';

//
// ─── IMPORT CERTIFICATES ────────────────────────────────────────────────────────
//
const appPath = process.env.NODE_ENV === 'production' ? app.getAppPath() : path.join(__dirname, '..', '..');
export const cKey = fs.readFileSync(path.join(appPath, 'main/certs/client-key.pem'));
export const cCert = fs.readFileSync(path.join(appPath, 'main/certs/client-cert.pem'));
export const cCA = fs.readFileSync(path.join(appPath, 'main/certs/ca-cert.pem'));

main thread - database.js
import Sequelize from 'sequelize';
import { dbCredentials, cKey, cCert, cCA } from './dbCred';
import { mapQry } from './queries';

// Instantiate model connection using Sequelize
const sequelize =
  new Sequelize(dbCredentials.database, dbCredentials.user, dbCredentials.password, {
    host: dbCredentials.host,
    dialect: 'mysql',
    dialectOptions: {
      ssl: {
        key: cKey,
        cert: cCert,
        ca: cCA
      }
    },
    pool: {
      max: 5,
      min: 0,
      idle: 10000
    },
  });
...

renderer thread - get-records-creators.js
import { createAliasedAction } from 'electron-redux';
// Action Types
import { FETCH_QUERY, FETCH_RECORD_DISPOSE, TOGGLE_DISPOSE } from '../../shared/constants/ActionTypes';
import { sequelizeQry } from '../../main/sql/database';

/** Action-creators */
export default function fetchRecords(qryName: string) {
  const actionType = FETCH_QUERY;

  if (qryName === 'DISPOSE') {
    return (dispatch: *) => {
      dispatch({
        type: `${actionType}_DISPOSE`
      });
      // Also clear activeRecord
      dispatch({ type: FETCH_RECORD_DISPOSE });
      // ... and clear any selected items from store
      dispatch({ type: TOGGLE_DISPOSE });
    };
  }

  return (dispatch: *) => {
    dispatch({ type: `${actionType}_PENDING` });
  // Converted to ALIAS for testing ...
    createAliasedAction(
      actionType,
      () => ({
        type: actionType,
        payload: sequelizeQry(qryName)
          // Convert to ALIAS?
          .then(
          (payload) => dispatch({ type: 'FETCH_QUERY_FULFILLED', payload })
          )
          // Convert to ALIAS?
          .catch((error) => dispatch({ type: 'FETCH_QUERY_REJECTED', error }))
      })
    );
  };
}

With the above code I'm initiating from the renderer side a database call with Sequelize which is Promised based and using createAliasedAction to execute purely in the main thread with the needed credentials as to my understanding of how it works.  (Note: I've not worried about the returns from the Promise yet)
I've called this structure purely with IPC and it works as expected, but then of course the request to Sequelize initialized in effect from the main thread based on the listener.
I'd welcome a bit of a nudge on how to accomplish this.
Many thanks!

I've decided to go another direction so I am closing this ticket.
I do believe, however, that the issue remains.
Good luck!

Hey,
Sorry for the late reply, I'm currently on vacation. Without being able to further read into your code or test this out myself - what is your concern in sending the credentials across? Is it purely a security concern (there should be none) or is it because of the payload size?
Thanks,
Burkhard


how use with normal prompt

like ip dapter

Hi, this is an ID-focused face model, it is not designed for text2image synthesis.


(FEATURE TARGET) perfect the synchronization

DModels at its heart works by spawning armor stands with items on their heads and moving them around.
This uses two core pieces: teleporting the location, and adjusting the armor_pose.
When armor_pose is updated, it is instant - the model snaps to the new rotation.
When location is updated, this is delayed - the client does a slow lerp to its target location.
The end result of this is that animations that both rotate and move at the same time visibly bend and distort as the position and rotation lose sync with each other.
This feature target is an open request for any contributors to help find a way to get both of these updates in sync.
Either by making both instant, or making both slow-lerp.

An idea that came up a while ago (initially on Discord by calicokid) that we could potentially:
A: rapidly despawn&spawn new armor stands to cause an instant position update, rather than moving the same stands.
Or B: spawn two stands for every model piece, and have one visible and the other invisible, and move the invisible ones ahead and make them visible on the next frame (to implement the "visible" or not part, probably could equip/unequip the item from the entity's head)

Sync is now perfect.


Flow does not infer return type of delegated yield expression

Flow version: 0.84.0
Hey all! I'm currently using delegate expressions, i.e. yield*s, as part of a redux-saga workflow. Looks like Flow thinks the return type of delegated yield expressions is Generator<*, T, *>, instead of T.
Perhaps this isn't an issue, and that my understanding of generator expressions is wrong? Correct me if so 😬
Expected behavior
const a = yield* foo(bar)
a should have type of return of foo
Actual behavior
a has type Generator

Link to Try-Flow or Github repo: try it here

Thanks!!

Resolved!! Ended up being a combination of (1) my misunderstanding of the return type of a function that calls yield * (should be Generator<*, T, *> instead of just T), and (2) a custom wrapper around redux-saga's call that confused Flow about the return type.


[Feature] Execution order

Search before asking

[X] I had searched in the issues and found no similar issues.

Feature Request
default  If the return is false, it will continue to run to the interceptor
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Could you provide more information?


Where is diff.png stored?

I'm trying to implement blue-harvest screen comparison in a E2E test setup, running in Azure (windows machines).
When using the screen comparison on localhost, the diff.png is written within the root of the angular project that I run e2e test on, and I can copy the diff image to our test reports.. But when the test is run on the azure build agents, then the diff.png is nowhere to be found.
The question is, is there a defined place where the png could be written to?

Turned out to be partly an error 40.. baseline images where never deployed to the build agents, as the chosen directory was never copied to the artifacts that was going to be deployed.
After we added the directory path to the artifacts, then it was working.


Use C++11's support for providing default values for class members

There are some test failure. Just in case, I restart building and testing process for failed cases.

Should fix it.
Apparently the lambdas were the problem.

LGTM, thanks.


Stream Property doesn't exist in Event property

This samples weren't working: There is no Property named Stream in the Events definition. According to https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-property-function-eventsource.html the code should look like:
Resources:
LambdaFunction:
Type: AWS::Serverless::Function
Properties:
Handler: index.handler
Runtime: nodejs12.x
Timeout: 10
Tracing: Active
Events:
Properties: <------- This is the difference
Type: Kinesis
Properties:
Stream: !GetAtt stream.Arn
BatchSize: 100
StartingPosition: LATEST
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi Pablo,
That key is a freeform identifier of the event resource that you are creating. Here's another example:
sample-apps/list-manager/template.yml
This is similar to the logical IDs that you use to name resources higher up in the Resources block. I'll change the casing to make it look less like a keyword.
Did you see an error when you tried to deploy the template?
Thanks,
-Michael at AWS

Interesting, I've got an error that got me into finding this alternative, and the template only worked after I've modified the "stream" property with "Properties"  - I'll close this but I'll try to reproduce later and re open if needed. Thanks


Program doesn't activate on startup

LinearMouse does not activate when the computer starts, and I have to manually recheck my settings.

Thank you for your feedback!
What does "not activate" mean exactly? Not launched (without an icon shown in the menu) or launched but settings not applied?
And do you mean that the settings have been lost after the restart when you say "manually recheck my settings"?

Sorry for wasting your time. I realized this only happened when I plugged in my external mouse, so I had to put in new settings.

Not at all. Anything about LinearMouse that is confusing would be great to hear.
Each mouse should only require a single configuration, and LinearMouse will then automatically apply the settings even if the mouse is re-plugged.
However, it is not very convenient for users who switch mice oftenly, so I'll think about integrating the ability to configure "all mice" into the UI.


If NFPC is present in HDF5 header, use it to calculate n_coarse_channels

In h5_file.cpp, I saw code to guess the course_channel size.   When nfpc is present (new rawspec feature), seticore should be looking for the HDF5 header field nfpc = number of fine channels per coarse channel (FFT length).  Then,
n_coarse_channels = num_freqs / coarse_channel_size = num_freqs / nfpc
Suggestion: put the n_coarse_channels calculation in a callable function for convenience.

i'll have to figure out how to read headers that may or may not be there with this unpleasant hdf5 c api....

Pass a flag that when sets forgives a missing tag and returns nil.

It now checks the heuristics against nfpc in: https://github.com/lacker/seticore/commit/5cffa57b59f0338422d34104a0bc4e527fdc3db9
It still refuses to run on data that doesn't match one of the hard-coded GBT and ATA values, because I'd like to find out if the inference logic is incorrect, but if we run into something we can't distinguish with heuristics then it makes sense to fall back to nfpc I think.


[6527] Enable performance/profile monitoring

Context
Enables Sentry's performance and profile monitoring so we can setup some anomaly alerts around this category. Start with a low traces_sample_rate rate. We'll assess how noisy it is in Sentry and adjust accordingly.

 Set up anomaly alerts in register support slack channel


[coverage] Add memory errors display check

Increase codecov
Description
Add testing for error displays

Codecov Report

Merging #199 (61edd2c) into main (47e5193) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   94.87%   95.28%   +0.41%
==========================================
  Files          26       26
  Lines        4816     4832      +16
==========================================
+ Hits         4569     4604      +35
+ Misses        247      228      -19

Impacted Files
Coverage Δ

src/vm/errors/vm_errors.rs
42.85% <100.00%> (+42.85%)
:arrow_up:

src/vm/vm_core.rs
97.28% <100.00%> (+0.01%)
:arrow_up:

src/vm/vm_memory/memory.rs
98.39% <100.00%> (+0.07%)
:arrow_up:

src/vm/errors/memory_errors.rs
77.77% <0.00%> (+77.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e5193...61edd2c. Read the comment docs.

Since there's the same suggestion (first assert it's an error) in some places and I don't want to spam you, here's my general advice: assert .is_err first, then .unwrap_err and make the assertion for display.

Thank you for the input, the error checking has been changed to use unwrap_err and remove the if let clause in commit 2f6e28d1cd396d9b3fce3a91d6baf609872b52f6

The performance assert is odd. We shouldn't observe any change in runtime from this changeset. Is the GH provided instance always the same type?


SyntaxError: invalid regexp group

function parseHash(url) in plyr.js
const regex = /^.*(?:vimeo.com\/|video\/)(?:\d+)(?:\?.*&*h=|\/)+(?<hash>[\d,a-f]+)/;
This regex is no valid javascript in some browsers (such as PaleMoon) and causing the player not to load.
Removing this function from plyr.js will fix, but I recommend to update the regex to a more browser compatible javascript code.
Best regards.

I'm seeing the same issue, this seems to be caused by the use of Named Regexp Capture Groups (https://caniuse.com/mdn-javascript_builtins_regexp_named_capture_groups).
I submitted a PR in order to resolve this issue: https://github.com/sampotts/plyr/pull/2426

Thanks for your work on this. It's released in v3.7.0 🎉


sgx-azure-dcap-client: fix gcc-13 build failure

Without the change build fails on master as
https://hydra.nixos.org/build/247706272:
local_cache.cpp: In function 'void throw_if(bool, const std::string&)':
local_cache.cpp:40:20: error: 'runtime_error' is not a member of 'std'
   40 |         throw std::runtime_error(error);
      |                    ^~~~~~~~~~~~~
local_cache.cpp:17:1: note: 'std::runtime_error' is defined in header '<stdexcept>'; did you forget to '#include <stdexcept>'?
   16 | #include <sys/file.h>
  +++ |+#include <stdexcept>
   17 | #include <sys/stat.h>

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@GrahamcOfBorg eval

Oh wait, still failing due to other missing headers:
       > local_cache.cpp:231:16: error: 'runtime_error' is not a member of 'std'
       >   231 |     throw std::runtime_error("No cache location was found. Please define one of the following environment variables to enable caching: " + environment_variable_list);
       >       |                ^~~~~~~~~~~~~
       > local_cache.cpp:231:16: note: 'std::runtime_error' is defined in header '<stdexcept>'; did you forget to '#include <stdexcept>'?
       > make: *** [Makefile:37: local_cache.o] Error 1
       > make: Leaving directory '/build/source/src/Linux'

I wonder why it works for me locally:
$ nix build --no-link github:NixOS/nixpkgs/pull/287891/merge#sgx-azure-dcap-client && echo ok
ok

File/header patch addressed was expected to fix it. Cound it be th`t ofborg did not actually apply the branch when did a build?

The testsuite clobbered patches in the package. Fixed as
--- a/pkgs/os-specific/linux/sgx/azure-dcap-client/test-suite.nix
+++ b/pkgs/os-specific/linux/sgx/azure-dcap-client/test-suite.nix
@@ -9,7 +9,7 @@ sgx-azure-dcap-client.overrideAttrs (old: {
     gtest
   ];

-  patches = [
+  patches = (old.patches or []) ++ [
     ./tests-missing-includes.patch
   ];

Ready for review.


Please check ioBroker.mqtt-client with js-controller 2.0

Hi,
the new js-controller 2.0 will come into latest repository in the next days and we want to make sure that all adapters are working well. We already did a 2 weeks Beta test and so some adapter were aleady checked and some needed slight adjustments.
You can find more information in https://github.com/ioBroker/ioBroker.js-controller/issues/482 and in the ioBroker Forum. If you have more technical questions please write in the referenced issue or in the Developer thread please. General questions are best in the genral thread.
Please update your systems to js-controller 2.0 and check your adapter.
Please close this issue once you have checked your adapter or received successfull reports from users.
Thank you very much for your support. Please contact us in the other Threads or Forum on any question.

mqtt client on  js-controller 2.0 not work!

continued here: #17


Add support for terraform overrides in cloud and VPC deployment for Azure

Add support for terraform overrides in cloud and VPC deployment for Azure
Resolves partially #1211 for Azure

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

Add ability to override terraform for Azure to be able to provide vnet_subnet_id and private_cluster_enabled

Types of changes
What types of changes does your PR introduce?
Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features to not work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing
Manually deployed on Azure
Requires testing

[ ] Yes
[x] No

In case you checked yes, did you write tests?

[ ] Yes
[x] No

Documentation
Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

[ ] Yes, docstrings
[ ] Yes, main documentation
[ ] Yes, deprecation notices

Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@aktech would you mind adding some docs on this. Want to make sure when someone else on our team decides to use this feature they know how to use it.


HDDS-5480. [Ozone-Streaming] Client and server should support stream setup.

What changes were proposed in this pull request?
Before we add new BlockDataStreamOutput, we need to support stream setup. In this way, we can get the DataStreamOutput instance through xceiverClient.
We can DataStreamOutput instance as we used in our POC code.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5480
How was this patch tested?
CI test will be added after DataStreamOutput Client is finished

One more question, whats the use of stream init, and how is it different from the first data packet to be sent from client to the datanode ?

Thanks @captainzmc for working on this. I think, we need define a config option to enable/disable the feature both on client and server.

One more question, whats the use of stream init, and how is it different from the first data packet to be sent from client to the datanode ?

The strream init will be used to instantiate the streaming client instance and the will try to write the 1st packet.

One more question, whats the use of stream init, and how is it different from the first data packet to be sent from client to the datanode ?

Stream init do 2 things: build the stream pipeline, and get a file path from the container for subsequent writes.
Ratis: Build the stream pipeline according to the routing table. If no routing table is given, it will fallback to
Client -----> Primary -----> Secondary 1
                 |
                 +---------> Secondary 2

HDDS Container: prepare a file for write, but does not write any data. In our POC code, we let the ContainerStateMachine calculate the path of that file as if there is a WriteChunk request.

The first data packet, of course, write data into that file.

Thanks @captainzmc for working on this. I think, we need define a config option to enable/disable the feature both on client and server.

Thanks @bshashikant for the review and suggestions.
On the server side, I think it's easy to distinguish. We added a stream method to ContainerStateMachine that follows the stream Init logic. This method is executed only if invoked actively by the client.  The new interface on the server has no impact on the existing logic.
About the client. Can we write a key based on the size of the key and decide whether to use stream?  We can configure in putKeyHandler.java.  And if the user uses the API directly, they can call our new interface directly. We won't make any changes to the existing Key/Block OutPutStream. We will add some new interfaces as described in the previous design document values.

I will solve the remaining review and CI problems.

@captainzmc , Just have went through the entire change once.  The change looks great!  Will review this again tomorrow.
In the mean time, please take a look the build failures.  Thanks a lot.

@captainzmc , Just have went through the entire change once. The change looks great! Will review this again tomorrow.
In the mean time, please take a look the build failures. Thanks a lot.

Yes, now I am solving the problem of CI failure, and I will update this PR again after solving it.

Hi @szetszwo @bshashikant @mukul1987 CI had been fixed. Could you help take another look？


Scaling problem

I got a little scaling problem, the icon appears very big and take much of the space. I've tried to set the banner_scale to noscale and fillscreen but nothing seems to work for me. I got a 1080p monitor if that may help. Is the problem only the background? I've opened it with feh and it fit my screen perfectly.
Thanks you

Do other themes have this issue?

Yes I've tried this theme as well: https://github.com/lukechilds/refind-ambience but i may have resolved my problem. I was using a .jpg to test another background I've switch to a .png as stated in the documentation and the scaling is much better now


WIP: Add DesiredStateChanged event filter

Description of your changes
Added the DesiredStateChanged EventFilter to the controller to avoid unnecessary reconciliations.
I have:

[X] Read and followed Crossplane's contribution process.
[X] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Executed this code in a development cluster doing multiple deployments.

Further testing has revealed a possible issue with Objects not getting updated properly.  I'm investigating.

@bobh66 do you still want to proceed here?


Cow: Watch nowgoal15.com

Cow requests the watch of the watch_keyword nowgoal15\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

nowgoal15\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


System wide Discord push to talk

Is your feature request related to a problem? Please describe.
Discord only supports push to talk on the web client, while the tab is opened and focused, which means that when Ferdi is minimised, or hidden in the system tray, there is no push to talk within Discord.
Describe the solution you'd like
I would like for push to talk to work system-wide, as it does on the Discord desktop client. Discord is currently the only service that I use with its dedicated client, and it'd be nice to ditch it for Ferdi.
What I suggest is that the Discord service override the browser functionality of telling the webpage that it currently has no focus, and that it passes through a selected push to talk key(s), so that Discord believes it is focussed and continues to provide push to talk functionality.
What could also be done is to add an action to the services section of the menubar, it could be called something like "Push to Talk" with a checkbox or "Enable Push to Talk". What this action would do is make it so that Ferdi starts listening, even if the Ferdi window has no focus, for the push to talk key(s), pass through said key(s) to Discord, and trick Discord into believing it currently has focus. While this means that the user must configure push to talk twice(once in Discord, and once in Ferdi), it also ensures that Ferdi isn't needlessly listening for a keyboard key while the user doesn't want to use push to talk.
Another way to implement this feature, would be to detect when Discord is listening for a key(s)(I'm actually not sure if this is possible), detected which key(s) Discord is listening for(again, not sure if possible), and then trigger a function so the Ferdi starts listening for said key(s) even if it has no focus(i.e. minimised or in the tray), and trick Discord discord into thinking it's open and has focus.
Describe alternatives you've considered
The only current available alternative is using the official Discord desktop client.
Additional context
I believe this is possible to do, and could be an elegant solution(especially the second alternative) to make Discord push to talk work system wide with Ferdi, though it could very well be against Discord's ToS, in which case that would be a shame.
I was unsure if I should post this feature request here, since I'm not sure how much this project wants to diverge from Franz. If I should have posted it in the Franz repo, since I've never used Franz and I'm unsure of how welcoming they'd be of this feature request. Or if I should have posted it in the recipe repo, since this is after all a feature related to the Discord service. I decided to post here because I'm a Ferdi user, and not a Franz user, and I figured Ferdi has to first support the functionality of tricking the service into thinking it has focus and listening for a push to talk key(s), before the service can actually support it.
If I should post this in either of the other two repos I listed, please tell me. Maybe it's also worth requesting this feature here and in the Franz repo simultaneously, so if the Franz people like the idea, Ferdi is able to get this feature from upstream, and if they don't, hopefully I've made my case convincing enough so you guys can accept it.😊 If I had any idea of how programming with electron and javascript works, I'd make a proof of concept and open a pull request, but I'm a novice to programming, and more of a C++ guy and have no idea how these web focused technologies work.

I'm not a dev but I don't know if this would be possible as Ferdi uses Discord's web version which doesn't support the push-to-talk feature :neutral_face:

Discord's web version which doesn't support the push-to-talk feature

In my first comment I explain how one could possibly bypass this.

OK, my bad, I though Discord Web didn't even support the feature. I haven't used it in a while xD sorry

This is an interesting feature request. Thanks for reporting this. @vantezzen @kytwb @sampathBlam Should we have a mechanism to listen for keyboard hooks and make the services configurable? This could be used by the recipes to listen for the system wide keyboard events and perform functionality inside the recipe itself. What do you think?

Trying to listen for system-wide keyboard events only works under X11. While ferdi runs under Xwayland when started under a Wayland compositor, the compositor won't deliver keyboards events unless its window is in focus. Maybe the push-to-talk listener service could have an (optional) IPC backend (with something like DBus), so Wayland users can bind the push-to-talk key in their compositor (sending an IPC message to ferdi on key push/release).

On Linux, trying to listen for system-wide keyboard events only works under X11. While ferdi runs under Xwayland when started under a Wayland compositor, the compositor won't deliver keyboards events unless its window is in focus. Maybe the push-to-talk listener service could have an (optional) IPC backend (with something like DBus), so Wayland users can bind the push-to-talk key in their compositor (sending an IPC message to ferdi on key push/release).

Yes. An IPC mechanism was in my mind as well. We could leverage electron's main process to pass events to the renderer and thereby to the recipes.
Maybe use something like this library - https://www.npmjs.com/package/iohook ?

At first glance, iohook looks like a library for listening to keyboard evens (on platforms where that's allowed, which is quite possibly everywhere but Wayland. Although I haven't looked into any sandboxing mechanisms recently introduced my Mac OS or Windows, so maybe it's also limited there.) This would be most certainly required for the common cases (unsandboxed Windows or Mac, Linux X11).
I was thinking more along the lines or receiving the push-to-talk even entirely out-of-band, where ferdi does not get access to global keyboard events. For that, DBus came to my mind, because ferdi already has to connect to the session DBus to deliver notifications and display the tray icon. So maybe another, custom DBus interface could be added for "remote control". Admittedly, I am unfamiliar with the process model of Electron, so I don't know how to do that exactly.

@kris7t I am starting to work on a small prototype for this. If I make some progress, will put up a draft PR and then probably you can continue up from there? I assume from the other thread are you are busy this week.

@mahadevans87 Great, thanks! 🙏


WIP: adjust for new seq/map serialization

just leaving this here so noone repeats any work when doing the next serde update

:+1:


Added media query to the search boxes

Added media query to the search boxes hoping that this will solve the issue on Apple devices.
Closes #149

Is the CodeClimate issues something I can fix? Been trying to go around it and use the className of the input but they seem to be drawing the styles from different areas (the top box: unsure & the bottom box: _auto-suggest.scss).


SocketLoader: safer check for timeout?

Q
A

Branch?
master

Bug fix?
yes/no

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed tickets
#136, #139, #151

License
MIT

fread returning empty string is valid thing to happen and shouldn't be used to detect timeouts.
Since stream_set_timeout is applied, timeout should be checked via stream_get_meta_data.

Good. Thanks!

Could you please issue a release as well? Thanks!

Done :)
https://github.com/io-developer/php-whois/releases/tag/4.1.1

By the way.. Are you sure 'timed_out' key always exists in stream_get_meta_data($handle)['timed_out']?

According to the php manual it should be there, but I can send a new PR if you'd like to be on the safe side.

Ok, nothing needed in that case. Just never used this function


[BUG] Blocks are missing when this mod is used with Sodium

Description:

Without Sodium
With Sodium

Steps to Reproduce:

Add this mod to your list of mods
Add Sodium too
Start up Minecraft
See that some blocks don't have textures at all

Technical Information:

Minecraft: 1.16.5 on MultiMC 0.6.12-1438
Fabric API: 0.32.5+1.16
Industrial Revolution: 1.8.13-BETA
Modpack: None
Sodium: Latest official release and my build of 1.16.x/next branch

Logs:
This gist has multiple files, check out with_sodium.log and without_sodium.log
https://gist.github.com/nm17/3fd76260e2f8f45d3b3e2ddc9a455a04
Details:
I've tried:

Changing java version
Changing texture packs and disabling them all
Disabling and enabling other mods to see if it would make a difference (in the end, it only happens with Sodium)

CPU: Intel(R) Core(TM) i5-9300H CPU
GPU: GeForce GTX 1650
I'm on Kubuntu 20.10 if that matters.

Nvm, I found #130. Please add this to the desctiption of the mod @GabrielOlvH

Also the discord link doesn't work now

Also the discord link doesn't work now

https://discord.gg/dhecUAJFrT

Also the discord link doesn't work now

https://discord.gg/dhecUAJFrT

Check #industrial-revolution , I still can't access the file.

Join the All of Fabric Discord and check the FAQ channels. They have descriptions of how to do it and a ready to install zip with sodium and indium.


Automated cherry pick of #8517: fix: set secgroup status

Cherry pick of #8517 on release/3.4.
#8517: fix: set secgroup status

Codecov Report

Merging #8519 into release/3.4 will decrease coverage by 2.69%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           release/3.4   #8519      +/-   ##
==============================================
- Coverage         6.22%   3.53%   -2.70%
==============================================
  Files              759     304     -455
  Lines           117145   62433   -54712
==============================================
- Hits              7289    2205    -5084
+ Misses          109197   60075   -49122
+ Partials           659     153     -506

Flag
Coverage Δ

#aFlag
3.53% <0.00%> (-2.70%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/appsrv/stats.go
0.00% <0.00%> (ø)

pkg/cloudcommon/notifyclient/events.go
0.00% <0.00%> (ø)

pkg/cloudcommon/notifyclient/notify.go
1.84% <0.00%> (-0.40%)
:arrow_down:

pkg/compute/models/buckets.go
1.10% <0.00%> (+0.03%)
:arrow_up:

pkg/compute/models/cachedimages.go
1.66% <0.00%> (-0.15%)
:arrow_down:

pkg/compute/models/capabilities.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudaccounts.go
0.48% <0.00%> (-4.66%)
:arrow_down:

pkg/compute/models/cloudregions.go
1.54% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/models/dbinstance_skus.go
2.83% <0.00%> (-0.02%)
:arrow_down:

pkg/compute/models/dbinstances.go
0.78% <0.00%> (-0.01%)
:arrow_down:

... and 446 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749b819...44046f2. Read the comment docs.


Added java program to perform quicksort

Pull Request Template
Description
This java program is to perform quick sort on 'n' numbers, this is a part of Object Oriented Programming in Java.
Put check marks:
Have you made changes in README file ?

[x] Added problem & solution under correct topic.
[ ] Specified Space & Time complexity.
[ ] Specified difficulty level, tag & Note(if any).

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Test A
[x] Test B

Make sure all below guidelines are followed else PR will get Reject:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code so that it is easy to understand
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

Ok. I'm sorry.


Add bodyforces + oscillations

Can add progress here as appropriate.

Progress

[ ] Validate RT instability
[ ]


Task keep running after cancel

Steps to reproduce
We have 2 sagas:
function* pollNewDocuments() {
    while (true) {
        yield delay(DOCUMENTS_POLLING_TIMEOUT);
        yield call(pullDocuments);
    }
}

function* initDocumentsPage() {
    let pollingTask = yield fork(pollNewDocuments);

    yield takeEvery(searchDocuments, function* onSearchDocuments({payload}) {
        if (payload) {
            yield cancel(pollingTask);
            yield call(searchDocumentsSaga, payload.query);
        } else {
            yield call(dropSearchDocuments, docs);
            pollingTask = yield fork(pollNewDocuments);
        }
    });
}

Description of the bug/issue
The point is that we have 2 sagas. First one (pollNewDocuments) just fetching data every DOCUMENTS_POLLING_TIMEOUT milliseconds, the second one initDocumentsPage forks when we visit documents page. And when we receive searchDocuments action we canceling polling task in case of search query is not empty. But sometimes pollNewDocuments task doesn't canceling and it still keeps calling pullDocuments. Moreover when I tried wrap task into try { } finally { console.log(yield cancelled()) } it returns true, but while(true) loop keeps running.
Environment information

redux-sag": "^0.16.0"
babel: "^6.26.0"

I suspect there is some (maybe subtle) bug in your code. Ofc can't be sure but to help you you would have to provide a codesandbox with the issue reproduced on it so I could take a look.

After research I've found that searchDocuments action could be dispatched twice with empty payload which forking pollNewDocuments and rewriting already running task. So we loose context to running task and could not cancel it. So decision was into:
  if (pollingTask.isCancelled()) {
    pollingTask = yield fork(pollNewDocuments);
  }

Excuse me for false alarm. Thanks for attention and be careful with your sagas. Closing this issue.


"import gpiozero" shouldn't fail without a valid pin factory

The following example is a valid method of setting the pin factory to mock:
import gpiozero
from gpiozero.pins.mock import MockFactory
gpiozero.Device.pin_factory = MockFactory()

but it only works if import gpiozero is successful, having found a valid pin factory.
If you're on a Raspberry Pi, that's easy - you just install rpi.gpio (even if you don't intend to use it).
If you're on a PC, the following will happen:

rpi.gpio will fail (even if it's installed - can only be run on a Pi)
rpio will fail (even it it's installed - can only be run on a Pi)
pigpio will fail (even if it's installed - pigpiod not running on localhost)
native will fail (can't access /dev/mem)

And it runs out of options.
The only way to get it to work is to set the pin factory in an environment variable.
It would be nice if you could get past import gpiozero, and if no pin factory is found, it's set to None and fails when you try to create a device. Would that be that possible?

This would also resolve the issue with pinout on PCs needing pin factory set.

+1

This should probably be explained in the documentation in the meantime, I spent a while trying to figure out why the example code here was throwing errors when trying to run on my laptop without a pi connected.

@drewcassidy. I am frustated with this thing. Why does a mock exist, when you can't even use it on a PC?
In [3]: from gpiozero.pins.mock import MockFactory
/home/dev/.pyenv/versions/3.6.4/lib/python3.6/site-packages/gpiozero/devices.py:452: PinFactoryFallback: Falling back from rpigpio: No module named 'RPi'
  'Falling back from %s: %s' % (name, str(e))))
/home/dev/.pyenv/versions/3.6.4/lib/python3.6/site-packages/gpiozero/devices.py:452: PinFactoryFallback: Falling back from rpio: No module named 'RPIO'
  'Falling back from %s: %s' % (name, str(e))))
/home/dev/.pyenv/versions/3.6.4/lib/python3.6/site-packages/gpiozero/devices.py:452: PinFactoryFallback: Falling back from pigpio: No module named 'pigpio'
  'Falling back from %s: %s' % (name, str(e))))
/home/dev/.pyenv/versions/3.6.4/lib/python3.6/site-packages/gpiozero/devices.py:452: PinFactoryFallback: Falling back from native: unable to open /dev/gpiomem or /dev/mem; upgrade your kernel or run as root
  'Falling back from %s: %s' % (name, str(e))))
---------------------------------------------------------------------------
BadPinFactory                             Traceback (most recent call last)
<ipython-input-3-456f994e72a8> in <module>()
----> 1 from gpiozero.pins.mock import MockFactory

~/.pyenv/versions/3.6.4/lib/python3.6/site-packages/gpiozero/pins/mock.py in <module>()
     26     PinInvalidPull,
     27     )
---> 28 from ..devices import Device
     29 from .pi import PiPin
     30 from .local import LocalPiFactory

~/.pyenv/versions/3.6.4/lib/python3.6/site-packages/gpiozero/__init__.py in <module>()
     20 # contamination here ... and besides, have you *seen* the list lately?!
     21 from .exc import *
---> 22 from .devices import (
     23     Device,
     24     GPIODevice,

~/.pyenv/versions/3.6.4/lib/python3.6/site-packages/gpiozero/devices.py in <module>()
    484
    485
--> 486 Device.pin_factory = _default_pin_factory()
    487 atexit.register(_shutdown)

~/.pyenv/versions/3.6.4/lib/python3.6/site-packages/gpiozero/devices.py in _default_pin_factory(name)
    451                     PinFactoryFallback(
    452                         'Falling back from %s: %s' % (name, str(e))))
--> 453         raise BadPinFactory('Unable to load any default pin factory!')
    454     else:
    455         # Try with the name verbatim first. If that fails, attempt with the

BadPinFactory: Unable to load any default pin factory!

I am frustated with this thing. Why does a mock exist, when you can't even use it on a PC?

@devxpy It does. You just have to set it in an environment variable, like I said above.
I see you're running on Linux so you should be able to launch IPython with the env var set in-line:
$ GPIOZERO_PIN_FACTORY=mock ipython

or export it:
$ export GPIOZERO_PIN_FACTORY=mock
$ ipython

or add it to your .bashrc or equivalent.
This issue points out that it's not currently possible to set the pin factory to mock if the default pin factory fails to load. There are situations where it does, like on a Pi, but as you have also discovered, there are situations where it doesn't, and it's impossible to import without a fatal error.
For now, this is easily resolved by setting the pin factory to mock in an environment variable, and we'll try to fix it for the next release.

@bennuttall. I'm sorry, i was in a virtualenv and was exporting outside the virtualenv

How about if importing gpiozero without a valid pin factory just shows a warning?
>>> import gpiozero
Warning: No default pin factory found. Please set gpiozero.Device.pin_factory
>>> led = LED(2)
InvalidPinFactory: No default pin factory set
>>> gpiozero.Device.pin_factory = MockFactory()
>>> led = LED(2)
>>> led
<gpiozero.LED object on pin GPIO2, active_high=True, is_active=False>

@waveform80 agrees - let's get this in v1.5

In case anyone else hits this, hacky workaround:
import os
os.environ['GPIOZERO_PIN_FACTORY'] = os.environ.get('GPIOZERO_PIN_FACTORY', 'mock')
import gpiozero

NOTE from gpiozero.pins.mock import MockFactory as documented in https://gpiozero.readthedocs.io/en/stable/api_pins.html#mock-pins isn't needed with this (nor does it work without this). Setting the explicit mock factory is not required.

Note that if/when this gets fixed, the note I added to the docs will need removing: https://gpiozero.readthedocs.io/en/latest/remote_gpio.html#pin-factories

Seems that #722 forgot to do that? :wink:


Setup from readme is insufficient to use Cog

After following the Setup guide in Readme I can't use F1 or Cog.ToggleInput (this command doesn't exist, only Cog.ToggleSelectionMode exists, which crashes the editor likely due to the incomplete setup) and nothing in the Readme explains why its missing. It simply doesn't work and there is no context - there are no warnings or errors in the output log, no ensure failing, etc.
I triple checked the steps in the readme to no avail.
So I looked through the example project but I can't find anything related to the setup because there is way too much stuff there - it would be all but impossible to not miss whatever it is I need to do with the amount of content.
Could you let me know what is missing and add it to the Readme?

Can you show your code where you create the UCogWindowManager ? Where you
add Windows, where you Tick it ?
The console comnmands gets created in :
void UCogWindowManager::InitializeInternal()
On Tue, Jan 9, 2024, 22:54 Jared Taylor @.***> wrote:

After following the Setup guide in Readme I can't use F1 or
Cog.ToggleInput (this command doesn't exist, only Cog.ToggleSelectionMode
exists, which crashes the editor likely due to the incomplete setup) and
nothing in the Readme explains why its missing. It simply doesn't work and
there is no context - there are no warnings or errors in the output log, no
ensure failing, etc.
I triple checked the steps in the readme to no avail.
So I looked through the example project but I can't find anything related
to the setup because there is way too much stuff there - it would be all
but impossible to not miss whatever it is I need to do with the amount
of content.
Could you let me know what is missing and add it to the Readme?
—
Reply to this email directly, view it on GitHub
https://github.com/arnaud-jamin/Cog/issues/26, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJT6POV7QLIDWHO323RIRTYNYGFXAVCNFSM6AAAAABBUDY2UKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3TGNJTGY4DEMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Ah-hah, so it turns out GameStateBase has tick disabled by default, and the InitializeInternal() stems from the Tick.
In that case, it may be worth simply adding to the Readme a reminder to enable tick on the game state if you do use it :)

I updated the readme. Thanks!


Initial draft TAPI 2.0 UML Model

Includes

Draft of the Resiliency/Protection model
Draft of the OAM Model
Draft of the Alarm/TCA model
Draft of the Node constraints

Reviewed the .uml and the model via Papyrus. Did a relatively lightweight assessment as we covered much of this in Heidelberg. I note that in general the lifecycle stereotypes are not being used. Use of these stereotypes would help focus the review on areas that were considered solid.


Merge digests function exposed.

While aggregating data frames with t-digest columns it is required that those columns can be merged for further percentile evaluation on the grouped data frame. The use-cases may vary, including storage of pre-aggregated data frames for the analysis and further grouping.

All, what about this request?

@grishasen Thank you for your PR and sorry for not getting a timely response. I had been out for a while and the PR fall through the cracks. As you deleted your forked repository, we have created a new PR and merged it with some slight changes.


Bump services 0.30.0-alpha.0 and mirror 0.64.0-beta1

Signed-off-by: Nana Essilfie-Conduah<EMAIL_ADDRESS>Description:

Bump services 0.30.0-alpha.0
Bump mirror 0.64.0-beta1
Fix dapp example boostrap string check

Related issue(s):
Fixes #483
Notes for reviewer:
Should unblock all but 1 of the draft acceptance test PRs
Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report

Merging #484 (062900e) into main (37b3bae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   76.38%   76.38%
=======================================
  Files          12       12
  Lines         923      923
  Branches      144      144
=======================================
  Hits          705      705
  Misses        165      165
  Partials       53       53

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This needs a new version of the local node dependency with these versions.
Will wait for Luke's PR to go in then will rebase and reduce the scope of this PR


Error in Svelte App

Error
Initially the dice roll fine but after a while i get this error
colliderFaceMap Error: No value found for d20 mesh face -1
After reloading everything works again, for a while.
Setup
SvelteKit App with 3d-dice as npm dependency
I have a Tailwind dice box at top level:

On document ready i initialize it and everything works fine:
diceBox = new DiceBox("#dice-box", {             assetPath: "/assets/dice-box/", // required         });         diceBox.init();
<button id="roll-dice-button"                     class="btn btn-ghost m-3 "                     disabled={rolledValueState.value}                     onclick={(evt) => {diceBox.show(); diceBox.roll("1d20").then(results => {rolledValueState.value = results[0].value;})}}>

Duplicate of #74 .
I was also using hide() and show().
Lets see if removing it fixes the issue.

 This can happen when the dice are thrown with a high enough force to go through the dice-box walls. It also sometimes happened when the dice are too big for the box they're in.
Let me know if removing hide/show methods works. I'll have to set up a testing sandbox to see if I can recreate the issue.

After removing the hide/show i did not get this error anymore.


Add TargetIsa::map_dwarf_register; fixes #1471

This exposes the functionality of fde::map_reg on the TargetIsa trait, avoiding compilation errors on architectures where register mapping is not yet supported. The change is conditially compiled under the unwind feature.

@peterhuene, not sure how this will play with #1466 but this does seem like the better long-term solution. Also, I hope my liberal use of #[cfg(feature = "unwind")] is what we are looking for here.

@stefson, any chance you can try a compile of this branch to see if it actually fixes #1471?

I'll tackle any conflicts this might cause for #1466.

LGTM 👍, but let's get @yurydelendik's opinion as well.

I'm good with the approach.

@stefson, any chance you can try a compile of this branch to see if it actually fixes #1471?

@abrown it seems to depend on an unreleased version of witx ?
/tmp/wasmtime $ cargo build --target armv7-unknown-linux-gnueabihf
Updating crates.io index
error: failed to select a version for the requirement witx = "^0.8.5"
candidate versions found which didn't match: 0.8.4
location searched: /tmp/wasmtime/crates/wasi-common/WASI/tools/witx
required by package wig v0.15.0 (/tmp/wasmtime/crates/wasi-common/wig)

@stefson, I see witx at 0.8.5 available on crates.io so I'm not exactly sure what is going on (@pchickey, is it clear to you?). Perhaps there is a git submodule update needed when jumping on to this branch?

I forgot to update the submodules, I'm sorry :c
But yes, with your branch it is now back to the old state of an error in wasmtime-obj, where it flakes out with an unsupported platform error, which is expected.


Print Area

Hi Doug,
is it possible to set a print area?
Thank You,
Jo

DIY
Nothing is in the module that does that. I found this, you'd need to translate it from C# to PS.
http://atakala.com/browser/Item.aspx?user_id=amos&dict_id=2363
Getting Started
$data = ConvertFrom-Csv @"
Region,State,Units,Price
West,Texas,927,923.71
North,Tennessee,466,770.67
East,Florida,520,458.68
East,Maine,828,661.24
West,Virginia,465,053.58
North,Missouri,436,235.67
South,Kansas,214,992.47
North,North Dakota,789,640.72
South,Delaware,712,508.55
"@

$pkg = $data | Export-Excel  ./printarea.xlsx -PassThru

$pkg.Sheet1.Dimension
#$pkg.Sheet1.PrinterSettings
Close-ExcelPackage $pkg


Helm v3 expects a default value for all keys

On Helm v3 I'm unable to use the chart with metrics_enabled="true" .
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: unknown object type "nil" in Deployment.spec.template.metadata.annotations.prometheus.io/port

@Lerring  Are you sure you mean metrics_enabled of "true"? No one has ever seen this error before and  "metrics_enabled" of "true" is the default- so everyone that has been using this helm chart has not seen this issue (indeed, with that setting equal to true (again, the default) the "null" annotation isn't even processed - so this line that is changed in the PR has no apparent effect if metrics_enabled == true)
Perhaps you meant you set it to "false" and you see an error?

Hi @jmazzitelli apologies, I got them mixed up. This is upon setting to false. Like so:
helm install -f values.yaml  \
  --namespace istio-system \
  --set auth.strategy="anonymous" \
  --set server.metrics_enabled="false" \
  --set deployment.ingress_enabled="false" \
  --repo https://kiali.org/helm-charts \
  kiali-server \
  kiali-server

I can confirm an error occurs if you disable metrics:
$ helm install --namespace istio-system --set server.metrics_enabled=false --repo https://kiali.org/helm-charts kiali-server kiali-server

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: unknown object type "nil" in Deployment.spec.template.metadata.annotations.prometheus.io/port

I can confirm an error occurs if you disable metrics:

Thanks for confirming this


Update finagle-http to 20.8.0

Updates com.twitter:finagle-http from 20.6.0 to 20.8.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.twitter", artifactId = "finagle-http" } ]

labels: library-update, semver-minor

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   98.07%   98.07%
=======================================
  Files           1        1
  Lines          52       52
  Branches        4        4
=======================================
  Hits           51       51
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8750093...bf7a5f2. Read the comment docs.


Fix for repeated letters on wordWrapped bitmap text

Record how many spaces have already been removed when resetting the index for a new line of text after hitting the maxWidth limit
Fixes https://github.com/pixijs/pixi.js/issues/4063

Fiddle with the fix applied: https://jsfiddle.net/vvg5wntk/1/


Add default git hooks

As per GH-#10 this branch uses https://github.com/jakemarsden/git-hooks-gradle-plugin to add to default git-hooks to the baseline. By default a pre-commit hook is created to run the spotlessApply task.

From what I can tell, that plugin overwrites .git/hooks/pre-commit.
So we might need to think about this a little more, as it is not going to play nice for any husky added hooks.
Not sure if husky does the same thing, or whether it appends to the pre-commit hook file


Can support tool for building components in isolation like Storybook?

Does Fresh plan to offer component-driven development tools like Storybook?

Sorry!
This content was discussions, not issues.
It has been moved to Discussions and will be closed.
https://github.com/denoland/fresh/discussions/542


feat: allow husky v6 updates

husky is now MIT again, but needs manual migration.
closes #17

I think husky will need dashboard approval, so we can do repo by repo


[BUG] - Azure Supporting Services has an arbitrary limit of 10

When attempting to create a bunch of supporting services for an Azure integration, we get various errors on resource constraints
for example:
 on main.tf line 59, in resource "dynatrace_azure_credentials" "azure_dyna_integration_nonp":

        content {

No more than 10 "monitored_metrics" blocks are allowed

I have a PR in the functional GoLang code here: https://github.com/dtcookie/dynatrace/pull/8 to fix this, seems related to this issue: https://github.com/dynatrace-oss/terraform-provider-dynatrace/issues/73 and I proposed to fix it in the same manner - adding an issue here for reporting just in case :)

for now will use the 'unknowns' block just to unblock my current needs - but the PR might be helpful to others so will leave it up just in case

Hello @Forcebyte ,
Thanks for the PR.
A new release will get pushed out within the week of Feb 14. It will contain this fix.


Cannot unbuckle people from Janicart

Description

Cannot unbuckle people from the janicart, which if someone is in crit, can result in death due to the cart itself being too heavy/slow to move.
Reproduction

Buckle someone to the cart. Try to unbuckle. Scream in despair.
Screenshots

Additional context

happens for any vehicle
only 3 ways i know of to do it:

stunbaton/disabler
stamcrit from shove
forcing player to vault a table

This seems to have been intended in the comment in Content.Shared/Buckle/SharedBuckleSystem.Buckle.cs:
            // If the strap is a vehicle and the rider is not the person unbuckling, return.
            if (TryComp<VehicleComponent>(strapUid, out var vehicle) &&
                vehicle.Rider != userUid)
                return false;

Vehicles removed awaiting better implementation.


Remove version: Jackett.Jackett version 0.20.2671

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.20.2671/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


How to use a custom camera

Description
Hi
I have a custom camera I want it to replace the webcam and be able to implement the mediapipe function through this camera

You may need to build ImageFrame instances using the input.
See also #343.

Sorry for replying so late
I am currently rendering the camera image to RawImage and I want to pass the texture2d of the image to the mediapipe for use, but the image will only move when the camera is initialized
I would like to ask how to make him execute continuously
The picture below shows me rewriting WebcamSource and replacing it with rawimage input

Sorry, I don't understand your situation precisely.
What is your input class (e.g. WebCamTexture)? What you need to do is to build an ImageFrame instance using that.

Sorry, maybe I didn’t make it clear enough. I got a texture2D from my  custom camera  and I pass it into ReadFromImageSource but the result I get is that the mediapipe's image is only rendered when my camera is initialized, after that the mediapipe's image is still

As for ImageFrame I am trying using that.

I just solved the problem
I sent Textur2d to the past, but I didn't keep updating texure2d, so in order to solve it, I kept inputting the transmitted picture in my camera
Thanks for taking the time to reply

@bbq82828 Hello,
I am currently working on a similar problem as you are and trying to find a solution. If it's not too much trouble, could you provide any hints or code snippets on how to use the data from a custom camera that renders on a RawImage for mediapipe? Thank you

@zzanyoung Hello,
You must first find GetCurrentTexture() in WebCamSource and replace webCamTexture with the texture2D of your custom camera

@bbq82828 Thank you for your response. However, I tried to write a script based on the code in #738, but it doesn't work. I am using a Texture2D input from a UVC camera. So, I changed the code to use Texture2d instead. But when I build the modified project for Android, a white or gray screen occurs. Can you provide any tips here as well? Thank you again for your response :)


add DDPM (online + offline), PLMS (online + offline) inference for video composer

In vc/diffusion/gaussian_diffusion.py, GaussianDiffusion class still has the ddim_steps argument.  It seems that vc/diffusion/gaussian_diffusion.py is no longer useful. You may consider to remove this file.

In vc/diffusion/gaussian_diffusion.py, GaussianDiffusion class still has the ddim_steps argument. It seems that vc/diffusion/gaussian_diffusion.py is no longer useful. You may consider to remove this file.

removed. thx


Suggestion

Add streamlit in requirements.txt and deploy it.Also try web scraping for links in pdf.

thanks


I have an exception if generate V2 version

I have an exception when trying to generate V2 format of swagger specification:
System.UriFormatException: Invalid URI: The format of the URI could not be determined.
at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
at System.Uri..ctor(String uriString)
at Microsoft.OpenApi.Models.OpenApiDocument.WriteHostInfoV2(IOpenApiWriter writer, IList1 servers)    at Microsoft.OpenApi.Models.OpenApiDocument.SerializeAsV2(IOpenApiWriter writer)    at Swashbuckle.AspNetCore.Swagger.SwaggerMiddleware.RespondWithSwaggerJson(HttpResponse response, OpenApiDocument swagger)    at Swashbuckle.AspNetCore.Swagger.SwaggerMiddleware.Invoke(HttpContext httpContext, ISwaggerProvider swaggerProvider)    at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)    at Microsoft.AspNetCore.Builder.Extensions.MapMiddleware.Invoke(HttpContext context)    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication1 application)
My settings:
"DocumentName": "v1",
"RouteTemplate": "/api-docs/{documentName}/swagger.json"

It is actual when my web api uses basepath. For example my web api hosted at http://example.com:8111/someservice.
When i am trying to get swagger.json as http://example.com:8111/someservice/swagger/v1/swagger.json i have an exception described above.

hi!
did it resolved?

it was a base path problem

I get this UriFormatException when doing a UsePathBase (as described in #1253) together with SerializeAsV2 = true in UseSwagger (this is with version 5 of Swashbuckle.AspNetCore)
It looks like OpenApiDocument is not able to serialize an OpenApiServer.Url that contains only the path portion for V2 (but it works for V3). For V2 the serializer should probably map such URLs directly to basePath with an empty host field.

Dup of #1495


Changes to keypress handling for #297 and #298

Adds check for allow item copy for the copy hotkey for #298
Changes functionality of d hotkey to duplicate an item for #297 since dropping an item is no longer applicable without a trash panel.

Would this make D and C the same then?

Would this make D and C the same then? If so, can we extract the common code/handle it in the same condition?

The keys would mirror the context menu functionality as both Duplicate and Copy are listed in the menu.
Copy makes a copy of the item, but randomizes the item seed.
Duplicate makes a copy of the item, but preserves the item seed.
The code is basically the same other than the call to focusedItem.Duplicate().  It may be better to just combine them and pass the keypress to the item Duplicate call like this:
Item newItem = focusedItem.Duplicate(e.KeyChar == 'd');

Would this make D and C the same then? If so, can we extract the common code/handle it in the same condition?

The keys would mirror the context menu functionality as both Duplicate and Copy are listed in the menu.
Copy makes a copy of the item, but randomizes the item seed.
Duplicate makes a copy of the item, but preserves the item seed.
The code is basically the same other than the call to focusedItem.Duplicate(). It may be better to just combine them and pass the keypress to the item Duplicate call like this:
Item newItem = focusedItem.Duplicate(e.KeyChar == 'd');

I see the different parameter for .Duplicate. All is good then!


How to visualize multi-classes

Hi, Thanks for your great work and the results look amazing. But I wonder that if it can visualize multi-classes by grad-cam whatever in classification or detection task.

@O2andsAnoxia
Hi, it's my pleasure. As far as I'm aware, GradCam and other gradient-based visualization algorithms maximize the output of a single class, not altogether. If you have any different algorithms in mind, inform me, please.


[Bug]: add_electrodes throws error when writing two recordings with differing additional electrode properties

What happened?
Unsure to what extent this behavior is intended, so it may not be a bug, but I'm hitting an error from the check in these lines in add_electrodes when trying to write two separate recordings.
Issue seems to be:

Both recording interfaces separately modify metadata["Ecephys"]["Electrodes"] to add (non-overlapping) property descriptions
NWBConverter.get_metadata combines these with deep_dict_update into a single list
add_electrodes uses this merged list to create property_descriptions dict
Neither recording has all of the properties now in property_descriptions so the check in the lines linked above fails

I can get around this by manually adding any missing properties to the recordings but I'm hoping there's a better solution.
Steps to Reproduce
import numpy as np
from neuroconv.tools.testing.mock_interfaces import MockRecordingInterface
from neuroconv import NWBConverter

class DummyRecordingInterface1(MockRecordingInterface):
    def __init__(self, verbose: bool = True, es_key: str = "ElectricalSeries", **kwargs):
        super().__init__(verbose=verbose, es_key=es_key, **kwargs)
        self.recording_extractor.set_property(
            key="property_a",
            ids=self.recording_extractor.get_channel_ids(),
            values=np.full(self.recording_extractor.get_num_channels(), np.nan),
        )

    def get_metadata(self):
        metadata = super().get_metadata()
        metadata["Ecephys"]["Electrodes"] = [
            dict(name="property_a", description="no description.")
        ]
        return metadata

class DummyRecordingInterface2(MockRecordingInterface):
    def __init__(self, verbose: bool = True, es_key: str = "ElectricalSeries", **kwargs):
        super().__init__(verbose=verbose, es_key=es_key, **kwargs)
        self.recording_extractor.set_property(
            key="property_b",
            ids=self.recording_extractor.get_channel_ids(),
            values=np.full(self.recording_extractor.get_num_channels(), np.nan),
        )

    def get_metadata(self):
        metadata = super().get_metadata()
        metadata["Ecephys"]["Electrodes"] = [
            dict(name="property_b", description="no description.")
        ]
        return metadata

class DummyNWBConverter(NWBConverter):
    data_interface_classes = dict(
        Recording1=DummyRecordingInterface1,
        Recording2=DummyRecordingInterface2,
    )

source_data = dict(
    Recording1=dict(es_key="ElectricalSeries1"),
    Recording2=dict(es_key="ElectricalSeries2"),
)

converter = DummyNWBConverter(source_data=source_data)
converter.run_conversion()

Traceback
Traceback (most recent call last):
  File "/home/jovyan/scripts/test_add_electrodes.py", line 49, in <module>
    converter.run_conversion()
  File "/home/jovyan/neuroconv/src/neuroconv/nwbconverter.py", line 160, in run_conversion
    self.add_to_nwbfile(nwbfile_out, metadata, conversion_options)
  File "/home/jovyan/neuroconv/src/neuroconv/nwbconverter.py", line 114, in add_to_nwbfile
    data_interface.add_to_nwbfile(
  File "/home/jovyan/neuroconv/src/neuroconv/datainterfaces/ecephys/baserecordingextractorinterface.py", line 335, in add_to_nwbfile
    add_recording(
  File "/home/jovyan/neuroconv/src/neuroconv/tools/spikeinterface/spikeinterface.py", line 752, in add_recording
    add_electrodes_info(recording=recording, nwbfile=nwbfile, metadata=metadata)
  File "/home/jovyan/neuroconv/src/neuroconv/tools/spikeinterface/spikeinterface.py", line 725, in add_electrodes_info
    add_electrodes(recording=recording, nwbfile=nwbfile, metadata=metadata)
  File "/home/jovyan/neuroconv/src/neuroconv/tools/spikeinterface/spikeinterface.py", line 258, in add_electrodes
    raise ValueError(f"{extra_descriptions} are not available in the recording extractor, set them first")
ValueError: ['property_b'] are not available in the recording extractor, set them first

Operating System
Linux
Python Executable
Python
Python Version
3.9
Package Versions
issue_environment.txt
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Have you ensured this bug was not already reported?

@h-mayorquin The inner workings of this ought to be right up your alley with regards to the append feature of the electrodes table for multiple SpikeInterface recording objects - any idea how to fix (and add tests) to catch this going forward?
@felixp8 Thanks for your patience; I suppose just stick to populating the missing properties manually for the time being, but I'm fairly certain our original design for the add_electrodes function is that it would work in situations just like this

Thanks for such a clean example when reporting the bug, @felixp8.
I think that those lines are outdated and after some thinking I can't see what will be the ill of removing them. They were introduced a while ago and I just carried them out after the refactoring that I did:
https://github.com/catalystneuro/neuroconv/commit/402123086a05600c881298fe12ace8b685b459d9
I think we should just remove those lines:
https://github.com/catalystneuro/neuroconv/blob/main/src/neuroconv/tools/spikeinterface/spikeinterface.py#L256-L258
Properties in the general electrode metadata might exists that are not in that specific recoder as your use case illustrates. As long as the add_electrodes function is properly appending them right to each other if they share channel_names there should not be a problem.

@h-mayorquin Thanks for clarifying
@felixp8 will open a PR to test the removal of those lines and add a specific unit test for his desired behavior


confirmations on Beer and Jail

added confirmations on drinking beer with max HP and putting yourself to Jail + renamed option.type to option.target_type

@Syarwin, I changed dojo.hitch to arrow function and added one more confirmation. Could you please take a look?


feat: add new sdk method to update instance home credentials

add new sdk method to update instance home credentials. Apply latest python-sdk-template changes.
PR summary

Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:

[X] The commit message follows the Angular Commit Message Guidelines.
[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Unit test
npm run test-unit

><EMAIL_ADDRESS>test-unit
> npm run build && jest test/unit/

><EMAIL_ADDRESS>build
> tsc && cp package.json dist/

jest-haste-map: Haste module naming collision: iaesdk
  The following files share their name; please adjust your hasteImpl:
    * <rootDir>/package.json
    * <rootDir>/dist/package.json

 PASS  test/unit/common.test.js
[BABEL] Note: The code generator has deoptimised the styling of /Users/silpidhua/SILPITHINGS/WORK/SDK/ibm-iae-node-sdk/node_modules/lodash/lodash.js as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /Users/silpidhua/SILPITHINGS/WORK/SDK/ibm-iae-node-sdk/node_modules/lodash/lodash.js as it exceeds the max of 500KB.
 PASS  test/unit/ibm-analytics-engine-api.v2.test.js
 PASS  test/unit/ibm-analytics-engine-api.v3.test.js
--------------------------|---------|----------|---------|---------|-------------------
File                      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
--------------------------|---------|----------|---------|---------|-------------------
All files                 |   99.79 |    93.05 |     100 |   99.79 |
 ibm-analytics-engine-api |   99.78 |    93.05 |     100 |   99.78 |
  v2.ts                   |   99.41 |    90.62 |     100 |    99.4 | 116
  v3.ts                   |     100 |       95 |     100 |     100 | 103,1428
 lib                      |     100 |      100 |     100 |     100 |
  common.ts               |     100 |      100 |     100 |     100 |
--------------------------|---------|----------|---------|---------|-------------------

Test Suites: 3 passed, 3 total
Tests:       150 passed, 150 total
Snapshots:   0 total
Time:        4.332 s
Ran all test suites matching /test\/unit\//i.

Integration test
npm run test-integration

><EMAIL_ADDRESS>test-integration
> npm run build && jest test/integration

><EMAIL_ADDRESS>build
> tsc && cp package.json dist/

 PASS  test/integration/ibm-analytics-engine-api.v3.test.js (22.478 s)
--------------------------|---------|----------|---------|---------|-----------------------------------------------------------------------------------------------------------------
File                      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
--------------------------|---------|----------|---------|---------|-----------------------------------------------------------------------------------------------------------------
All files                 |   66.32 |    27.77 |   62.71 |   66.18 |
 auth                     |     100 |      100 |    12.5 |     100 |
  index.ts                |     100 |      100 |    12.5 |     100 |
 ibm-analytics-engine-api |   64.96 |    27.77 |      70 |   64.81 |
  v2.ts                   |   18.82 |    28.12 |      30 |   18.34 | 58-89,111-135,157-193,215-251,272-315,335-371,391-428,460-499,519-555,576-618,636-672,688-717,738-781
  v3.ts                   |   91.02 |     27.5 |   96.66 |      91 | 58,82,87,107,135,187,250,321,380,434,491,546,599,659,720,778,833,886,943,996,1054,1114,1170,1231,1284,1337,1390
 lib                      |     100 |      100 |     100 |     100 |
  common.ts               |     100 |      100 |     100 |     100 |
--------------------------|---------|----------|---------|---------|-----------------------------------------------------------------------------------------------------------------

Test Suites: 1 skipped, 1 passed, 1 of 2 total
Tests:       13 skipped, 24 passed, 37 total
Snapshots:   0 total
Time:        22.862 s
Ran all test suites matching /test\/integration/i.

Due to problems in commit message closing this PR.