[[FIX]] Don't throw W080 when the initializer starts with undefined

Example:

var a = undefined === 0; // a is 'false', not 'undefined'

Fixes gh-2699

Thanks for the patch! It's missing a few test cases, though. Can you add assertions for destructuring patterns, eg:
var [ a = undefined === 0 ] = [];
[ a = undefined === 0 ] = [];
var { b: b = undefined === 0 } = {};
({ b: b = undefined === 0 } = {});

Can you add assertions for destructuring patterns

Done

Squashed and merged to master at commit 0d879196bab1c733f1299d2dbc470362b64c9bc6. Thanks!


docs: Add testing utils details

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7f4ccf0) to head (58b2eab).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines          122       122
=========================================
  Hits           122       122

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bump zwave2 to 3.0.5

Automated adapter checker
ioBroker.zwave2

:thumbsup: No errors found

[ ] :eyes: [W171] "common.title" is deprecated in io-package.json
[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI

Add comment "RE-CHECK!" to start check anew


How can I download files 1 by 1?

I want to download only one (or only set amount of) file(s) at a time. How can I configure it this way?

Great idea! I will look into it next week


[mesheryctl] Unit Testing for mesheryctl app commands

See mesheryctl Command Tracker for current status of commands.
check Epic here #3016
Current Behavior
Currently, we don't have any unit tests setup to test mesheryctl app commands and functions
Desired Behavior
Required to enable unit testing support for mesheryctl app commands and functions, to ensure the accuracy and robustness of each mesheryctl release.
mesheryctl Unit Testing

Mark all possible situations for each mesheryctl app commands and functions.
Write tests using Golang’s standard library.
A combination of CodeCov and GitHub Actions are to be used as mainstays in the approach to unit testing - https://github.com/codecov/codecov-action.

Subcommands to cover

[ ] mesheryctl app onboard
[ ] mesheryctl app list
[ ] mesheryctl app offboard
[ ] mesheryctl app view

Contributor Resources

mesheryctl Contributing Guide
Beginner's guide to contributing to Meshery and mesheryctl
mesheryctl Command Tracker
Meshery CLI Commands and Documentation
Layer5 Community Slack

https://docs.google.com/document/d/1t8Ilb72gpvkLXjywSAkaUOxN6arObC_xOLih66ggCUk/edit#heading=h.blih70a9hxp


15 make code for different conversion

Code for the Currency is done.

All the code is done. version-1 is completed


Proposal: Storage Overhaul

As a result of the conclusions reached in cosmos/cosmos-sdk#7100, the Cosmos-SDK is undergoing a switch away from the IAVL library which is going to impact the long term usability of Kepler in the Cosmos ecosystem. Currently Kepler relies on a gRPC based IAVL service to provide state storage and commitment, it is unlikely that this service will be updated or maintained in the future.
The Cosmos-SDK is moving to a decoupled storage model, where one module provides state storage, and another provides state commitments. Under this scheme the commitments will be provided by a "Sparse Merkle Tree", through the LazyLedger SMT Library, while the storage will be provided by an in-process KVStore (specific library TBD). Part of the rationale for this change is to allow for easy benchmarking of alternative storage or commitment modules, with a clear pathway to upgrading while maintaining the same standardized interface.
I am proposing that Kepler follow suit, and build support for this decoupled model, including SMT based commitments.
In (very) rough draft this would require:

New effects: StoreBackend and StateCommitment
Implementation of StoreBackend effect using Haskell based storage library

At minimum this needs support for Read/Write and Begin/Rollback/Commit
Currently looking at SQLite based libraries such as Persistent and sqlite-simple, as well as KVStore libraries such as haskey or RocksDB
I'm leaning towards the SQLite options to take advantage of the better ACID guarantees, automatic support for Begin/Rollback/Commit, and support for multi-index data / join style queries
With a KVStore based implementation begin/rollback/commit functionality would likely to have to be built manually using in-memory write caching. Multi-index data / join style queries could be added manually as well.

Implementation of StateCommitment effect using Haskell based SMT implementation, on top of raw storage provided by StoreBackend

Proof generation / verification
Updates to commitment on state writes
Returning new root hash on block commit

Generic evaluator for StoreEffs using combination of StoreBackend and StateCommitment

This would handle coordination between reads/writes to state and commitment layer, transactions, block commits, etc.
Given that root hash is only returned on block commit, it would likely be most efficient to queue writes to the StateCommitment and submit them as a batch update on commit.

Replacement for IAVLStore in CoreEffs using combination of above implementations

Completing this overhaul will improve the speed and efficiency of Kepler, as well as simplify future feature upgrades such as State Syncing and IBC compatibility.
I would appreciate feedback on the proposed ideas, both from the FOAM team and anyone else who is or will be a user of Kepler. I have spoken with @hxrts about applying for ICF grant funding to support this and other contributions to Kepler (such as State Syncing or IBC), so I would like to make sure that my proposed changes will be beneficial not just to my own dependent project but to others as well.
Relevant Links:

cosmos/cosmos-sdk#7100
cosmos/cosmos-sdk#8297
cosmos/cosmos-sdk#8430 (rendered ADR)
cosmos/cosmos-sdk#8507
https://github.com/lazyledger/smt

This sounds really cool, i'd be happy to help out on some of this!


Update dotnet-grpc.md

Internal review URL
Merges into #14565

@JunTaoLuo  let me know what you want changed, then I'll merge this into your PR.

Shortened sentences
Removed future tense.

@JunTaoLuo let me know what to change before merging into #14565


Measuring contributors who have never contributed to Commons before

When I wrote the "measures of success" for my IEG grant proposal last year, one of them was "10+ new contributors who have never contributed to Commons before". Clearly I did not think that through very well, haha, since I still have no idea how this could possibly be measured. :/ It would definitely need to be measured on the WMF side since we should not collect such data via the app.
Even worse, the next measure of success that I suggested was "Less than 10% of pictures uploaded by new users (who have never contributed to Wikimedia before) are unusable". Not only is this dependent on us being able to do the former item, it is also dependent on us having knowledge of which accounts exactly are new. I understand that we can check the contributions of every user tagged under "Uploaded with Mobile Android app", but with 2000+ active users now, that is not going to be a trivial undertaking (I wrote the proposal when we had 200 active users).
Any idea if there is any way I can do such a thing, or at least something close to it?

For the second criteria:
As a sample, I took the last full period available at https://commons.wikimedia.org/wiki/User:Didym/Mobile_upload, which is: https://commons.wikimedia.org/wiki/User:Didym/Mobile_upload/2017_April_11-15
This period (5 days) has 341 pictures. Among those I have found:

10 copyvio
10 useless pictures (selfies, tests, pictures unusable without knowing the context)
4 pictures that, while not good candidates for speedy deletion, are very unlikely to help illustrate Wikipedia.

That makes 7% of "useless" pictures. That's less than 10%

Thanks @nicolas-raoul !
For the 1st criteria, how are you looking for them? Is there a process I can replicate?
For the 2nd one, can we assume that Didym will collect all the images from new users, or at least enough of them that we can use it as a representative sample?

Yes, I picked random pictures at https://commons.wikimedia.org/wiki/User:Didym/Mobile_upload then clicked on the author's name then on "contributions" in the left bar to see this user's contributions, then "500" to see them all then "Earliest" if needed to see what there first uploaded file was. Then just check whether this file has the mobile app tag or not. By the way the second example is not great as the picture will probably be deleted soon, better find other accounts.
Didym's tool has been around for a long time, and collects all new files created by the app. When do you want to take the sample? Better decide right now on the date, so that you can not be accused of "cherry picking" a favorable sample.

@nicolas-raoul Thanks, will do that for the 1st criteria.
Re: the 2nd criteria, does Didym's tool collect files from new users, or just all files created by the app?
I'm not sure exactly when I will take the sample - I will probably only be able to take it once I have completed the entire project, which is looking unlikely to be before the hackathon. Since I will be leaving for vacation shortly, and also it would be nice to have all the new improvements from the hackathon before making the final (and most significant) round of media notifications.

Didym's tool collects all files created by the app, not just new users.

Here is a list of the users whose first upload is tagged "mobile app edit": https://quarry.wmflabs.org/query/18084
I'm not done with fully checking the results but it appears to contain items that Didym's list misses, such as https://commons.wikimedia.org/wiki/File:Bharath_mata_cut_out.jpg
(I'm less sure about possible false negatives in my list.)

Wonderful, thanks @whym ! :) I won't be using it for a while yet (until after the hackathon), but it looks like it will come in very handy.

Would it be possible to sort these users by decreasing number of subsequent uploads?
This would allow us to grasp how addictive the app is :-)

Would it be possible to sort these users by decreasing number of subsequent uploads?

Good point, added. (Click "uploads" twice to sort.)

Would it be possible to gather anonymous statistics where people are using the app? It would be great to see how well we are covering certain areas of the globe.

It seems that according to http://tools.wmflabs.org/commons-app-stats/ the deletion rate is around 20% (the blue bar to red bar ratio is roughly 5:1). I guess that's not too bad, but not what we had hoped.
I wonder if there's any way to find the uploads vs deletions stats for the web upload wizard?

This is done, thanks all!


The Legend of Zelda A Link Between Worlds

Game Name (and version if necessary)
The Legend of Zelda A Link Between Worlds
Hardware Specs (If necessary)
No response
Operating System
Windows
Game State
Playable with distorted graphics on menus
Screenshots

Additional information
No response

I think this game has some differences between shader JIT and interpreter

Oh you are correct, with 'EnableShaderJIT = true' the upper screen is also the bottom screen


Add support for HTTP/2

Add support for intercepting requests issued over HTTP/2. As HTTP/2 becomes more and more popular and Microsoft Graph SDKs start to use HTTP/2, we need to ensure that developers who use APIs over HTTP/2 can still use Developer Proxy.

I've tested the latest Microsoft Graph .NET SDK v5 with the proxy and it works just fine. Let's postpone this work until Microsoft Graph will start using HTTP/2 itself and we can verify if it's even necessary for the purposes we need it.


Replicator Preview Text

Hi, first thanks for the addon, it's really great !
When using inside a replicator, the preview text is [object Object] which is not really helpful.
It would be great to have the same as the classic assets fieldtype.
So I tried to do this:

Add a ref to the assets fieldtype component : v-ref:field
Implement getReplicatorPreviewText : getReplicatorPreviewText: function() {
     if (this.$refs.field) {
       return this.$refs.field.getReplicatorPreviewText();
     }
     return null;
 }

Now this works except you're oblige to interact with the set (open then close) in order to work. Because the function is called on ready lifecycle hook but the assets fieldtype is not yet ready (which is why i put if (this.$refs.field) .
By opening or closing the set, the replicator will call the function and this time the assets fieldtype will be ready.
Hope this will help you !

Currently, I don't have the time to make changes to the addon. If you submit a pull request for this, I will merge it and add a new release for it.


knife cookbook upload --all does not upload all cookbooks if any one of the cookbook version is frozen.

Description

knife cookbook upload --all does not upload all the cookbooks if anyone of the cookbook's version is frozen. And as per current behaviour knife cookbook upload --alll shows wrong message at the end of command execution i.e. Uploaded all cookbooks.  which confuse the user.
We either need to fix the message or the functionality to fix this.
Chef Version

ChefDK version: 4.6.35
Chef Infra Client version: 15.5.17
Chef InSpec version: 4.18.39
Test Kitchen version: 2.3.4
Foodcritic version: 16.2.0
Cookstyle version: 5.13.7

Present in Chef 14 too.
Platform Version

Replication Case

I have one of the cookbook in repo whose version is frozen.
Then I try to upload all cookbooks from my cookbook repo using --all option
Client Output

knife cookbook upload --all
Uploading berks-test [0.1.0]
Uploading one-more-test [0.1.0]
Uploading one-moret-test [0.1.0]
Uploading starter [1.3.0]
Uploading test-cookbook [0.1.0]
Uploading test-one [0.1.0]
Uploading test-two [0.1.0]
ERROR: Version 0.1.0 of cookbook berks-test is frozen. Use --force to override.
WARNING: Not updating version constraints for some cookbooks in the environment as the cookbook is frozen.
Uploaded all cookbooks.

Stacktrace

that seems to be the correct behavior though.  frozen cookbooks need to never be overwritten unless the user specifies --force.
seems like a semantic issue where "uploaded all cookbooks" really means "uploaded all the cookbook that i could".

@lamont-granquist it does not upload any of the cookbook but says "Uploaded all cookbooks"

Adding more command execution logs
$ knife cookbook list
berks-test       0.1.0
one-moret-test   0.1.0
registry_key     0.1.0
starter          1.3.0

$ knife cookbook upload starter
Uploading starter        [1.3.0]
ERROR: Version 1.3.0 of cookbook starter is frozen. Use --force to override.
WARNING: Not updating version constraints for starter in the environment as the cookbook is frozen.
ERROR: Failed to upload 1 cookbook.

$ knife cookbook upload --all
Uploading one-more       [0.1.0]
Uploading one-more-test  [0.1.0]
Uploading one-moret-test [0.1.0]
Uploading starter        [1.3.0]
Uploading test-cookbook  [0.1.0]
Uploading test-one       [0.1.0]
Uploading test-two       [0.1.0]
ERROR: Version 1.3.0 of cookbook starter is frozen. Use --force to override.
WARNING: Not updating version constraints for some cookbooks in the environment as the cookbook is frozen.
Uploaded all cookbooks.

$ knife cookbook list
berks-test       0.1.0
one-more         0.1.0
one-more-test    0.1.0
one-moret-test   0.1.0
registry_key     0.1.0
starter          1.3.0

That's still very low priority.  People should really be using Berkshelf or PolicyFiles, and if they're trying to upload everything they can still see the error and override it with --force which is probably what they're going to want to do.  Until a user error comes in based on this, I'm not sure what the correct behavior would be.

Its fixed as UX in #9073


[ci:component:github.com/gardener/egress-filter-refresher:0.4.0->0.5.0]

Release Notes:
Ensure that only egress traffic is blocked and ingress traffic is allowed.

/close in favor of https://github.com/gardener/gardener-extension-shoot-networking-filter/pull/15


[PHP] Optional Parameterized Token

This makes running multiple instances of the bot easier as you do not need a copy of the bot in a new directory for each account.

Why not just provide token directly in argument instead of a file name?

Filename allows for some organization of multiple tokens

I made it support providing tokens via CLI, there's no need for files.
You can easily make a batch script to list your tokens or something.

I meant knowing what token is owned by what account. I'm personally running bots for people in different Discords, and using filenames makes it much easier to enable / disable the bot when they ask.


Fix metadata resolution using recursive=true|false

If two metadata relevant classes (e.g. a finder column and a presenter) are annotated with the same @Requires annotation and one of the classes uses recursive=true and the other recursive=false (default), the resolution works not correctly.
If it happens that the recursive=false class is processed first, the second with recursive=true is not processed and thus the recursive metadata never gets processed. The metadata registry takes only the address into account, but not whether the resolution should happen recursively or not.
When fixed, adjust the @Requires annotations on these columns and presenters:

org.jboss.hal.client.configuration.subsystem.security.SecurityDomainColumn
org.jboss.hal.client.configuration.subsystem.security.SecurityDomainPresenter
org.jboss.hal.client.configuration.subsystem.infinispan.CacheContainerColumn
org.jboss.hal.client.configuration.subsystem.infinispan.CacheContainerPresenter

After some analysis there's no real solution atm. The only thing you can do is to not use the same address with different recursive flags on different classes.

The mentioned Column and Presenter already contains the @Requires annotation.

There's another real issue related to this:
If you select a resource (say subsystem=remoting) in the model browser, the model browser always processes the resource using recursive=false. If you then try to open the remoting presenter, an metadata error is thrown because the presenter requires recursive=true.


Bump uniform and other dependencies

This change bumps maestro dependencies to the latest release.
I've checked the uniform version of the dependencies that were bumped:
humbug       0.7.2-20160617114039-c10e869  (uniform 1.11)
thermometer  1.4.3-20160617114144-562e6e0  (uniform 1.11)
ebenezer     0.22.2-20160619063420-4eb964f (uniform 1.11)
beeswax      0.1.2-20160619053150-80dbb0a  (uniform 1.11)
omnitool     1.14.1-20160617114243-1143bc9 (uniform 1.11)
permafrost   0.12.2-20160307061149-afd1611 (uniform 1.8)*
edge         3.6.1-20160307143412-9402c13  (uniform 1.8)*
parlour      1.11.2-20160301032329         (uniform 1.6)* (1.11 exists but build failed publish with HTTP 500)

Once the AFO issues are sorted out, I'll update this PR with the latest parlour version.

Going to update permafrost, edge and parlour to the latest uniform while at it. Closing this PR for now.


EBNF on website refers to undefined PRERELEASE_TRUNKVER rule

https://github.com/crftd-tech/trunkver/blob/main/website/index.md#ebnf-definition refers to PRERELEASE_TRUNKVER, but it is not defined.
Is maybe MINOR_TRUNKVER ment to be named PRERELEASE_TRUNKVER?

It also doesn't have any numbers in the ALPHANUMERIC rule, only a-zA-Z, as far as I can tell


Add support for Flux cryptocurrency. Coin Type: 19167

Hi there,
I would be happy to implement this myself and submit a PR.
Is there anywhere I can find a detailed explanation for the Cryptocurrency class and the parameters?
Thanks

Actually, I might have found them
        // guarantees the first 2 characters, when base58 encoded, are "t1"
        base58Prefixes[PUBKEY_ADDRESS]     = {0x1C,0xB8};
        // guarantees the first 2 characters, when base58 encoded, are "t3"
        base58Prefixes[SCRIPT_ADDRESS]     = {0x1C,0xBD};
        // the first character, when base58 encoded, is "5" or "K" or "L" (as in Bitcoin)
        base58Prefixes[SECRET_KEY]         = {0x80};
        // do not rely on these BIP32 prefixes; they are not specified and may change
        base58Prefixes[EXT_PUBLIC_KEY]     = {0x04,0x88,0xB2,0x1E};
        base58Prefixes[EXT_SECRET_KEY]     = {0x04,0x88,0xAD,0xE4};

#73


Support sqlite databases

We should definitely support sqlite.
From the little I understand about sqlite, the execution model is fairly strongly dependent on the database being accessed by a single thread. This is at odds with the model we use here, where a new sqlalchemy engine is created for every query. Each of these engines could belong to a different thread in the tornado application.
I suspect one way to do this would be to push database queries through a single thread (probably just for sqlite).

Is there a specific case (e.g. a unit test) highlighting the current reason for calling it unsupported? At first glance it seems like SQL alchemy is aware of this and tries to solve it: https://docs.sqlalchemy.org/en/latest/dialects/sqlite.html#threading-pooling-behavior

Quoting the relevant parts from the link for posterity:

SQLAlchemy sets up pooling to work with Pysqlite’s default behavior:
- When a :memory: SQLite database is specified, the dialect by default will use SingletonThreadPool. This pool maintains a single connection per thread, so that all access to the engine within the current thread use the same :memory: database - other threads would access a different :memory: database.
- When a file-based database is specified, the dialect will use NullPool as the source of connections. This pool closes and discards connections which are returned to the pool immediately. SQLite file-based connections have extremely low overhead, so pooling is not necessary. The scheme also prevents a connection from being used again in a different thread and works best with SQLite’s coarse-grained file locking.

Thanks for looking into it!
I've tried changing the connection pool to both the SingletonThreadPool and the NullPool, but these don't fix the problem.
Basically, in most web apps, you have a single connection pool that is defined at start-up and whose lifetime matches that of the app. For jupyterlab-sql, we don't have this: the user can change what database to connect to between queries.
We therefore create a new engine in response to every execution. Since these are created asynchronously, they are in general on different threads.
I think the right solution would be to have a store mapping connection strings to sqlalchemy engines (maybe just for sqlite). We could then re-use the engine if it's present in the cache.

Having a cache of connection string to sqlalchemy engine that persists across requests seems to work. I have been prototyping with this:
import tornado.ioloop
import tornado.web
import tornado.options
from tornado.log import app_log as log
from tornado.escape import json_decode

from sqlalchemy import create_engine

cache = dict()

class MainHandler(tornado.web.RequestHandler):
    def initialize(self, cache):
        self.cache = cache

    def post(self):
        data = json_decode(self.request.body)
        query = data['query']
        connection_string = 'sqlite://'
        try:
            engine = self.cache[connection_string]
        except KeyError:
            engine = create_engine(connection_string)
            self.cache[connection_string] = engine
        response = engine.connect().execute(query)
        log.info(response)
        if response.returns_rows:
            log.info(list(response))
        else:
            log.info('no rows')
        self.write('done')

def make_app():
    return tornado.web.Application([
        (r'/', MainHandler, dict(cache=cache))
    ], debug=True)

if __name__ == '__main__':
    tornado.options.parse_command_line()
    app = make_app()
    app.listen(8866)
    tornado.ioloop.IOLoop.current().start()

Now fixed in jupyterlab-sql 0.1.8.


base64url versus base64-url

jwa depends on base64url.  But it also depends on ecdsa-sig-formatter, which depends on base64-url.  Would it reduce the total number of dependencies to replace base64url with base64-url?

I agree, I know you're the author of base64url, but reducing the dependencies is worthwhile and the base64 implementation is really simple anyway.


min API

What is min API version supported?

https://github.com/afollestad/material-dialogs/blob/master/library/build.gradle

comment on here http://stackoverflow.com/a/26721975/3736955 says 14, write this min 8 to initial page https://github.com/afollestad/material-dialogs

That's old old comment
On Tue, Mar 24, 2015, 8:43 AM Jemshit Iskenderov<EMAIL_ADDRESS>wrote:

comment on here http://stackoverflow.com/a/26721975/3736955 says 14,
write this min 8 to initial page
https://github.com/afollestad/material-dialogs
—
Reply to this email directly or view it on GitHub
https://github.com/afollestad/material-dialogs/issues/357#issuecomment-85501449
.

People can see what the current min SDK is from the Gradle file. ☺


⚠ Bofrost.de has degraded performance

In 8da1941, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1575 ms

Resolved: Bofrost.de performance has improved in 5fe339c after 57 minutes.


Add go-to definition for dependency types: ImplTraits

Ref #4705
What this does:

Adds go-to definition functionality for external traits implemented for some local type, eg impl Foo for Bar where Foo is a dependency type
Adds no_deps to RenderPlan, when this flag is passed dependencies aren't built, so we also shouldn't produce links to docs that won't be there

Can we add some tests please?


Add Keycloak doc and clean up others for OIDC providers

Pull Request Test Coverage Report for Build 986d0ff170bd1dcd0f975e55f60c9c7a6969b034-PR-1024

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.414%

Totals

Change from base Build aa67b689e583a052c74bd014d9bb2f32c38932ad:
0.0%

Covered Lines:
1141

Relevant Lines:
1718

💛  - Coveralls


Customize style of overridden methods instead of bold

ie. Underline, change color, italic, etc.

I notice you've got a todo comment! i'm working on a PR


fix: clicker gremlin in Cypress

What:
The clicker gremlin did not work in Cypress. There were no log and no visual clicks.

How:
By using the same logic as the toucher: using the passed in window to define the document and the body when called.
My guess is that window is something else when the functions get called?

Checklist:

[ ] Documentation added to the README.md file
[ ] Tests
[ ] Typescript definitions updated
[ ] RFR, Ready for review label

I can reproduce the problem and I can confirm that the fix works, thanks for sharing. Would love to see a release with this fix. Thanks everyone!

Thanks!


User/bpet/guifix

@BrianLPeterson,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Closing pull request and resubmitting it to vnext per suggestion


Fixing some code that have some errors and resolve some checkstyle issues for View files and etc

Great job on working on your code!


Add K-NN plugin to 2.2.0 manifest

Signed-off-by: Junqiu Lei<EMAIL_ADDRESS>Description
Add K-NN plugin 2.x branch to 2.2.0 manifest
Issues Resolved
https://github.com/opensearch-project/k-NN/issues/467
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2409 (e7ece78) into main (dc7dae2) will increase coverage by 5.37%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #2409      +/-   ##
=============================================
+ Coverage     94.62%   100.00%   +5.37%
=============================================
  Files           210         6     -204
  Lines          4317       105    -4212
  Branches         29        19      -10
=============================================
- Hits           4085       105    -3980
+ Misses          226         0     -226
+ Partials          6         0       -6

Impacted Files
Coverage Δ

src/checkout_workflow/checkout_args.py

src/sign_workflow/signer_windows.py

tests/jenkins/jobs/Hello_Jenkinsfile

src/test_workflow/integ_test/service_opensearch.py

tests/jenkins/jobs/UploadTestResults_Jenkinsfile

src/paths/script_finder.py

...sts/jenkins/jobs/DetectTestDockerAgent_Jenkinsfile

...est_workflow/test_result/test_component_results.py

...jobs/PromoteArtifactsQualifier_actions_Jenkinsfile

...nIntegTestScript_OpenSearch_Dashboards_Jenkinsfile

... and 194 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


ltris: init at 1.0.19

Motivation for this change
Added another lgames package. Needs gcc 4.9 because of known compilation issues since 2015 (cf. http://git.net/ml/general/2015-05/msg25721.html).
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

I'd strongly suggest setting up the GCC5 patch that is in the (unreleased) upstream tree and using that (and building against the latest GCC), or bugging the lgames project to cut a new release for ltris.
Here's the pointer to the lgames commit in question that fixes the GCC build: https://sourceforge.net/p/lgames/code/164/
If you can find a retrievable patch (as opposed to the SourceForge HTML uselessness), then that could be added to the patches list instead of adding one to the tree.
If you leave it as building against GCC49 or add the patch, make sure you comment in the derivation as to why this deviates from normal practice so that a well-meaning update doesn't break it later.

Thanks for the link. I didn't even think to check the actual source for some unreleased code addressing the problem. Luckily, there's a subversion repository, so patch extraction was easy and with the patch applied it now builds locally with current gcc well enough.
I think the patch name and content (including the simple ChangeLog at the beginning) should suffice as a comment for why it's there?


We need a branch for 1.0.10

I can't remember what we call them, patch-1.0.10 ?

Here it is!
https://github.com/elkarte/Elkarte/tree/patch_1-0-10

Early Feb?  Last release was August 7

You already fixed most of the open bugs. xD
I think the only confirmed one left is the backport of the auto-orientation thingy, the other two are mostly some odd cases that is not even clear what the issue is. :angel:

I was not sure if we needed to wrap the eval() in a try/catch block for php7l ... and yup the other two are a bit odd for sure.
Need to troll the site and see if there are any other 1.0.x things that we did not log here, just so we can be as complete as possible.

Yeah, I guess the try/catch is not so relevant.


[proxima-core]: Added read/write methods into ValueSerializer.

In this patch we introduce new methods which allows
to read and write values provided by ValueSerializer.
This is required for accessing fields in value with
respect of schema.

resolved in another PR.


Deploy directly onto DO VM with ssh

Look into deploy-keys
https://docs.github.com/en/developers/overview/managing-deploy-keys

https://faun.pub/full-ci-cd-with-docker-github-actions-digitalocean-droplets-container-registry-db2938db8246

@RicSegundo I'm 95% of the way there, but cannot write the data into postgres.
You'll see there's a container running postgres now docker ps -a
You'll also see the app container that exited. To see the exit log: docker logs b3d17c9b5fd9
First I set the hostname to "localhost" in the tools.py file. Then I got the error in this SO question.
I followed the instructions and changed the host name from "localhost" to the container name running postgres "pg-docker"
Now i'm getting this:

sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) could not translate host name "pg-docker" to address: Name or service not known

looks like this might help.
Fyi, the droplet IP is different. I destroyed it then created a new one to test something.
Also, to enter psql on the droplet, type this: psql -h localhost -U postgres. Then enter my coderbyte pw.

https://stackoverflow.com/questions/45637206/docker-is-the-server-running-on-host-localhost-1-and-accepting-tcp-ip-con

top voted comment here is:

Need you brain @RicSegundo

https://medium.com/it-dead-inside/docker-containers-and-localhost-cannot-assign-requested-address-6ac7bc0d042b

https://forums.docker.com/t/is-the-server-running-on-host-localhost-1-and-accepting-tcp-ip-connections-on-port-5432/113289

For future reference:
Docker commands:
https://docs.docker.com/engine/reference/commandline/run/

Managed to fix this by creating a user defined network inside docker:
https://stackoverflow.com/questions/54272997/access-docker-postgres-container-from-another-container

The only problem is how I am connecting now, it says the password is invalid for the user Postgres.
I am tackling that issue, but now we can access the DB inside the container, from the other container.
This would all be solved if we use a docker-compose file and create 2 services there.
2 containers will be started nevertheless, but the management of this overarching network would be managed by docker compose, among its services.
We should definitely move to that solution asap!

As we are doing things, we'll encounter a lot of problems, e.g. the Postgres container and/or DB might not be yet initialised and listening when we run the other script (independently of the order you write them on the file). Again, docker compose fixes this with "depend on" service, so it only starts one after the other.
https://docs.docker.com/compose/startup-order/
There is also a tool for this called "wait for it":
https://github.com/vishnubob/wait-for-it


Register all modules in assembly

It would be handy to have an option to pass an Assembly or a string pattern to register all Ninject Modules.
c.UseNinject(Assembly.GetExecutingAssembly());
c.UseNinject("Service.Injection.*.dll")

The kernel already contains Load method with these signatures.

One of the overloads of UseNinjects provides an INinjectSettings you can pass in which has settings.ExtensionSearchPatterns . That may get you what you need.


feat: check CoreDNS

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9752
What this PR does / why we need it:
Add GetDeployment.
Special notes for your reviewer:
None
Additional documentation or context
None

@coderabbitai review

@coderabbitai review


feat: Allow nested arrays and vectors in Brillig foreign calls

This PR mirrors the changes of https://github.com/AztecProtocol/aztec-packages/pull/4404 to make them easier to merge

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 545b3341 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,636
180,516
720,036

l1_rollup_calldata_gas
222,552
871,116
3,465,732

l1_rollup_execution_gas
315,039
988,856
3,685,389

l2_block_processing_time_in_ms
1,160
4,386 (+1%)
17,310 (+1%)

note_successful_decrypting_time_in_ms
307
979 (+2%)
3,619 (+1%)

note_trial_decrypting_time_in_ms
15.7 (-22%)
109 (+18%)
148 (+5%)

l2_block_building_time_in_ms
17,925
70,802
285,563 (+1%)

l2_block_rollup_simulation_time_in_ms
13,088
51,693
208,845 (+1%)

l2_block_public_tx_process_time_in_ms
4,807
19,026
76,453 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
13,766 (-10%)
26,836 (-8%)

note_history_successful_decrypting_time_in_ms
2,444 (+1%)
4,561 (+1%)

note_history_trial_decrypting_time_in_ms
86.6 (+1%)
205 (+2%)

node_database_size_in_bytes
17,313,872
33,050,704

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
312
44,476
26,153

private-kernel-ordering
198
44,473
16,553

base-rollup
1,408
128,930
881

root-rollup
82.6
4,088
677

private-kernel-inner
445
71,607
26,153

public-kernel-private-input
247
32,563
26,153

public-kernel-non-first-iteration
246
32,605
26,153

merge-rollup
7.63 (+1%)
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
17,187
40,012

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
554
1,319

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.522 (-13%)
591 (+1%)


Dates are replicated incorrectly

I fully replicate a table with a date column:
mysql> SELECT DISTINCT r.test_date FROM test AS r LIMIT 10;
+------------+
| test_date  |
+------------+
| 2015-05-21 |
| 2015-05-24 |
| 2015-05-25 |
| 2015-05-27 |
| 2015-05-28 |
| 2015-05-31 |
| 2015-06-01 |
| 2015-06-02 |
| 2015-06-04 |
| 2015-06-07 |
+------------+

Same table in clickhouse after replication:
:) select distinct r.test_date from temp as r limit 10

SELECT DISTINCT r.test_date
FROM temp AS r
LIMIT 10

Query id: 001562f9-fcc7-42ec-8404-0dc0cca3a80c

   ┌──test_date─┐
1. │ 1970-01-01 │
   └────────────┘

I'll try to debug more and provide more details.
Original table is created like this:
CREATE TABLE `test` (
  `id` bigint NOT NULL AUTO_INCREMENT,
  `test_date` date NOT NULL,
PRIMARY KEY (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=1566108 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci

Fixed in 0.0.39

Dates are replicated correctly now.


qt + cotire automoc fails to moc a few files

This is what should be mocced:
$ rm `ls src/*moc*`
$ ninja qtwallet_automoc
(2.929s) [0/0/1] Automoc for target qtwallet
Generating bitcoin.moc
Generating intro.moc
Generating overviewpage.moc
Generating rpcconsole.moc
Generating moc_addressbookpage.cpp
Generating moc_addresstablemodel.cpp
Generating moc_askpassphrasedialog.cpp
...
Generating moc_walletframe.cpp
Generating moc_walletmodel.cpp
Generating moc_walletview.cpp

But with unity, the first few are skipped:
$ rm `ls src/*moc*`
$ ninja qtwallet_unity_automoc
(2.546s) [0/0/1] Automoc for target qtwallet_unity
Generating moc_addressbookpage.cpp
Generating moc_addresstablemodel.cpp
Generating moc_askpassphrasedialog.cpp
....
Generating moc_walletframe.cpp
Generating moc_walletmodel.cpp
Generating moc_walletview.cpp

The bitcoin.moc, intro.moc, etc., are included in the cpp files, e.g. #include "bitcoin.moc", whereas the moc_*.cpp are auto-generated from the presence of slots and signals.
Work-around for now is:
add_dependencies(qtwallet_unity qtwallet_automoc)

This should be fixed in cotire version 1.7.0.


chore: link build badge to master builds only

The badge is showing build status for the default branch, but it links to builds on all branches. This PR fixes that.

Thanks!


CHEBI:61259, please correct typo under 'Synonyms'

The second line under 'Synonyms' subheader is "PHEMA" when the acronym is correctly spelled 'PEHMA' (poly ethylhexyl methacrylate.) Thank you

Thanks for letting us know. The error has now been corrected.
Kind regards,
Gareth


Create download command tests.

This will break temporarily ci.

Coverage increased (+3.02%) to 75.633% when pulling 5098b4688df67056abbe8c488a297a21dabd519a on download-cmd-tests-aleksi into c4062ad87e475926ee916bff06f323d1beea5b68 on master.

Coverage increased (+3.02%) to 75.633% when pulling 5098b4688df67056abbe8c488a297a21dabd519a on download-cmd-tests-aleksi into c4062ad87e475926ee916bff06f323d1beea5b68 on master.

LGTM.


Update to milestone dependencies

@melix could you look into the failures of this PR ? https://github.com/micronaut-projects/micronaut-test-resources/actions/runs/4608497488/jobs/8144336667?pr=196

I think this is due to hibernate and hibernate reactive dependencies in data and sql.
We updated micronaut-sql dependency to
managed-hibernate = "6.2.0.Final"
managed-hibernate-reactive = "2.0.0.Beta1"

and I think it is in 5.0.0-SNAPSHOT but not in M1 which is being pulled here.
test-resources is pulling micronaut-data but getting  hibernate reactive alpha currently and hibernate final. Probably sql M2 should be built so we can update data and pull correct dependencies.

HiveMQ failed https://ge.micronaut.io/s/vhuiwrcqzmgge

mmm, this seems to be a new regression, I'll take a look.

Seems that I have to add an application-test.yml file with the following contents now:
mqtt:
  client:
    client-id: ${random.uuid}

And then the test passes. I guess something has changed in our MQTT support which mandates this now.


Parallel Bundle Install extension overwrites "typeset" built-in and breaks compinit (on some systems/versions of ZSH)

Hi Antigen Devs,
I spent a few hours banging my head against this problem, and in the spirit of giving you the most information possible, forgive me for the text wall. But I feel that you will want to fix this so other users don't start complaining :)
I git cloned the repo on the develop branch (since its the default branch). I added the following config to my .zshrc.
source ~/antigen/antigen.zsh
antigen use oh-my-zsh
antigen bundle zsh-users/zsh-syntax-highlighting
antigen theme bureau
antigen apply

where ~/antigen is where I am cloning this repo from.
This worked fine on my mac (zsh 5.2 (x86_64-apple-darwin16.0) macOS Sierra 10.12.5)
It does not work on my ubuntu VM running Ubuntu Trusty 14.04 (zsh 5.0.2 (x86_64-pc-linux-gnu))
When ZSH starts up, first error:
-antigen-hook-antigen-apply:zcompile:11: can't open file: /home/dmotles/.antigen/.zcompdump

I noticed that the system /etc/zsh/zshrc applies compinit...
cat /etc/zsh/zshrc
# /etc/zsh/zshrc: system-wide .zshrc file for zsh(1).
#
# This file is sourced only for interactive shells. It
# should contain commands to set up aliases, functions,
# options, key bindings, etc.
#
# Global Order: zshenv, zprofile, zshrc, zlogin

READNULLCMD=${PAGER:-/usr/bin/pager}

# An array to note missing features to ease diagnosis in case of problems.
typeset -ga debian_missing_features

if [[ -z "$DEBIAN_PREVENT_KEYBOARD_CHANGES" ]] &&
   [[ "$TERM" != 'emacs' ]]
then

    typeset -A key
    key=(
        BackSpace  "${terminfo[kbs]}"
        Home       "${terminfo[khome]}"
        End        "${terminfo[kend]}"
        Insert     "${terminfo[kich1]}"
        Delete     "${terminfo[kdch1]}"
        Up         "${terminfo[kcuu1]}"
        Down       "${terminfo[kcud1]}"
        Left       "${terminfo[kcub1]}"
        Right      "${terminfo[kcuf1]}"
        PageUp     "${terminfo[kpp]}"
        PageDown   "${terminfo[knp]}"
    )

    function bind2maps () {
        local i sequence widget
        local -a maps

        while [[ "$1" != "--" ]]; do
            maps+=( "$1" )
            shift
        done
        shift

        sequence="${key[$1]}"
        widget="$2"

        [[ -z "$sequence" ]] && return 1

        for i in "${maps[@]}"; do
            bindkey -M "$i" "$sequence" "$widget"
        done
    }

    bind2maps emacs             -- BackSpace   backward-delete-char
    bind2maps       viins       -- BackSpace   vi-backward-delete-char
    bind2maps             vicmd -- BackSpace   vi-backward-char
    bind2maps emacs             -- Home        beginning-of-line
    bind2maps       viins vicmd -- Home        vi-beginning-of-line
    bind2maps emacs             -- End         end-of-line
    bind2maps       viins vicmd -- End         vi-end-of-line
    bind2maps emacs viins       -- Insert      overwrite-mode
    bind2maps             vicmd -- Insert      vi-insert
    bind2maps emacs             -- Delete      delete-char
    bind2maps       viins vicmd -- Delete      vi-delete-char
    bind2maps emacs viins vicmd -- Up          up-line-or-history
    bind2maps emacs viins vicmd -- Down        down-line-or-history
    bind2maps emacs             -- Left        backward-char
    bind2maps       viins vicmd -- Left        vi-backward-char
    bind2maps emacs             -- Right       forward-char
    bind2maps       viins vicmd -- Right       vi-forward-char

    # Make sure the terminal is in application mode, when zle is
    # active. Only then are the values from $terminfo valid.
    if (( ${+terminfo[smkx]} )) && (( ${+terminfo[rmkx]} )); then
        function zle-line-init () {
            emulate -L zsh
            printf '%s' ${terminfo[smkx]}
        }
        function zle-line-finish () {
            emulate -L zsh
            printf '%s' ${terminfo[rmkx]}
        }
        zle -N zle-line-init
        zle -N zle-line-finish
    else
        for i in {s,r}mkx; do
            (( ${+terminfo[$i]} )) || debian_missing_features+=($i)
        done
        unset i
    fi

    unfunction bind2maps

fi # [[ -z "$DEBIAN_PREVENT_KEYBOARD_CHANGES" ]] && [[ "$TERM" != 'emacs' ]]

zstyle ':completion:*:sudo:*' command-path /usr/local/sbin \
                                           /usr/local/bin  \
                                           /usr/sbin       \
                                           /usr/bin        \
                                           /sbin           \
                                           /bin            \
                                           /usr/X11R6/bin

(( ${+aliases[run-help]} )) && unalias run-help
autoload -Uz run-help

# If you don't want compinit called here, place the line
# skip_global_compinit=1
# in your $ZDOTDIR/.zshenv or $ZDOTDIR/.zprofile
if [[ -z "$skip_global_compinit" ]]; then
  autoload -U compinit
  compinit
fi

I decided to disable it by setting  skip_global_compinit=1 in my .zshenv to let antigen do the compinit stuff.
That yielded an interesting error next time I started ZSH:
compinit:493: _i_test: assignment to invalid subscript range

I enabled shell tracing at the top of my .zshrc (set -x) to figure out what was going on, and inspected the compinit function.
I noticed something weird in the traceback...
+compinit:485> typeset -A _i_test
+typeset:1> -antigen-interactive-mode
+-antigen-interactive-mode:1> WARN '-antigen-interactive-mode: file:shfunc:shfunc:shfunc:shfunc:shfunc:shfunc:shfunc:loadautofunc:shfunc:shfunc $_ANTIGEN_INTERACTIVE = '
+WARN:1> local 'PREFIX=[WRN][1498177056.9634315968]'
+WARN:2> echo '[WRN][1498177056.9634315968] /home/dmotles/antigen/bin/antigen.zsh:246\n[WRN][1498177056.9634315968] -antigen-interactive-mode: file:shfunc:shfunc:shfunc:shfunc:shfunc:shfunc:shfunc:loadautofunc:shfunc:shfunc $_ANTIGEN_INTERACTIVE = '
+-antigen-interactive-mode:2> [[ '' !=  ]]
+-antigen-interactive-mode:7> [[ file:shfunc:shfunc:shfunc:shfunc:shfunc:shfunc:shfunc:loadautofunc:shfunc:shfunc == toplevel* || file:shfunc:shfunc:shfunc:shfunc:shfunc:shfunc:shfunc:loadautofunc:shfunc:shfunc == cmdarg* ]]

Huh? compinit called the built-in typeset command and the -antigen-interactive-mode function was called from that? I checked and lo and behold:
+-zsh:2> which typeset
typeset () {
	if -antigen-interactive-mode
	then
		return 1
	fi
}

That seems... broken. I checked against my mac, and typset is still set to the built-in.
I started adding which typeset all over the place, and noticed that typeset gets overridden after the initial source ~/antigen/antigen.zsh. I added some more which typeset into the bin/antigen.zsh on my system, and saw that it gets overridden after the parallel extension is loaded in antigen-ext-init.
+antigen-ext:9> _ANTIGEN_EXTENSIONS+=( lock )
+antigen-ext-init:6> echo '------------------\t\t\t\t\tMOTLES DEBUG>>> lock'
------------------					MOTLES DEBUG>>> lock
+antigen-ext-init:7> which typeset
typeset: shell built-in command
+antigen-ext-init:3> ext=parallel
+antigen-ext-init:5> ((  1  ))
+antigen-ext-init:5> antigen-ext parallel
+antigen-ext:1> local 'ext=parallel'
+antigen-ext:2> local 'func=-antigen-parallel-init'
+antigen-ext:3> ((  1 && 0 == 0  ))
+antigen-ext:4> eval -antigen-parallel-init
+(eval):1> -antigen-parallel-init
+-antigen-parallel-init:1> WARN 'Init parallel extension' PARALLEL
+WARN:1> local 'PREFIX=[WRN][1498177562.1505901814]'
+WARN:2> echo '[WRN][1498177562.1505901814] /home/dmotles/antigen/bin/antigen.zsh:1658\n[WRN][1498177562.1505901814] Init parallel extension' PARALLEL
+antigen-ext:5> local 'ret=0'
+antigen-ext:6> WARN '-antigen-parallel-init return code was 0'
+WARN:1> local 'PREFIX=[WRN][1498177562.1507265568]'
+WARN:2> echo '[WRN][1498177562.1507265568] /home/dmotles/antigen/bin/antigen.zsh:1554\n[WRN][1498177562.1507265568] -antigen-parallel-init return code was 0'
+antigen-ext:7> ((  0 == 0  ))
+antigen-ext:8> LOG 'LOADED EXTENSION parallel' EXT
+LOG:1> local 'PREFIX=[LOG][1498177562.1508214474]'
+LOG:2> echo '[LOG][1498177562.1508214474] /home/dmotles/antigen/bin/antigen.zsh:1556\n[LOG][1498177562.1508214474] LOADED EXTENSION parallel' EXT
+antigen-ext:9> -antigen-parallel-execute
+-antigen-parallel-execute:1> WARN 'Exec parallel extension' PARALLEL
+WARN:1> local 'PREFIX=[WRN][1498177562.1509151459]'
+WARN:2> echo '[WRN][1498177562.1509151459] /home/dmotles/antigen/bin/antigen.zsh:1666\n[WRN][1498177562.1509151459] Exec parallel extension' PARALLEL
+-antigen-parallel-execute:62> antigen-add-hook antigen-apply antigen-apply-parallel pre once
+antigen-add-hook:1> local 'target=antigen-apply' 'hook=antigen-apply-parallel' 'type=pre' 'mode=once'
+antigen-add-hook:3> ((  ! 1  ))
+antigen-add-hook:8> ((  ! 1  ))
+antigen-add-hook:13> [[ antigen-apply-lock ==  ]]
+antigen-add-hook:16> _ANTIGEN_HOOKS[$target]=antigen-apply-lock:antigen-apply-parallel
+antigen-add-hook:19> _ANTIGEN_HOOKS_META[$hook]='target antigen-apply type pre mode once called 0'
+antigen-add-hook:22> local 'hook_function=-antigen-hook-antigen-apply'
+antigen-add-hook:23> ((  ! 1  ))
+antigen-add-hook:34> return 0
+-antigen-parallel-execute:74> antigen-add-hook antigen-apply antigen-apply-parallel-execute replace once
+antigen-add-hook:1> local 'target=antigen-apply' 'hook=antigen-apply-parallel-execute' 'type=replace' 'mode=once'
+antigen-add-hook:3> ((  ! 1  ))
+antigen-add-hook:8> ((  ! 1  ))
+antigen-add-hook:13> [[ antigen-apply-lock:antigen-apply-parallel ==  ]]
+antigen-add-hook:16> _ANTIGEN_HOOKS[$target]=antigen-apply-lock:antigen-apply-parallel:antigen-apply-parallel-execute
+antigen-add-hook:19> _ANTIGEN_HOOKS_META[$hook]='target antigen-apply type replace mode once called 0'
+antigen-add-hook:22> local 'hook_function=-antigen-hook-antigen-apply'
+antigen-add-hook:23> ((  ! 1  ))
+antigen-add-hook:34> return 0
+antigen-ext:9> _ANTIGEN_EXTENSIONS+=( parallel )
+antigen-ext-init:6> echo '------------------\t\t\t\t\tMOTLES DEBUG>>> parallel'
------------------					MOTLES DEBUG>>> parallel
+antigen-ext-init:7> which typeset
typeset () {
	if -antigen-interactive-mode
	then
		return 1
	fi
}

I noticed that parallel bundle install was added recently, and started checking out older commits. I found that this problem appears to go away if you go back to 09e589f69d489dccd9ebf1c1a66831a6e3d818c9, before the parallelization change was added.
I looked all around the code but to be honest, I have no idea why this happens. There is no function explicitly defined anywhere called "typeset". My zsh-foo is not strong enough to understand this. I hope that perhaps you guys might be able to offer some insight as to why this is happening.
As for now, I will probably leave the develop branch and just try to use a stable release... :)

I did face this same issue on older zsh versiones and made a hack to avoid it as I could not find the core issue.
Gonna take a look.

Can confirm this happens on 5.0.x (5.1 and above works).

@dmotles Should be fixed in v2.2.1. Thanks for reporting!


[Java] Test fails due to JSON key order

While verifying 10.0.1 I came across this java test error that is caused by a mismatch in the ordering of the JSON metadata description (see attached image)
ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.177 s <<< FAILURE! - in org.apache.arrow.adapter.jdbc.JdbcToArrowCommentMetadataTest
[ERROR] org.apache.arrow.adapter.jdbc.JdbcToArrowCommentMetadataTest.schemaCommentWithDatabaseMetadata Time elapsed: 0.141 s <<< FAILURE!
org.opentest4j.AssertionFailedError:
cc @lidavidm
Reporter: Jacob Wujciak / @assignUser
Original Issue Attachments:

image.png

Note: This issue was originally created as ARROW-18385. Please see the migration documentation for further details.

Stale


UnboundLocalError: local variable 'keep_tri' referenced before assignment

https://github.com/Jingkang50/OpenPSG/blob/bdd3c548257b99468e7adddfac7f1fd41a4321a7/configs/psgtr/psgtr_r50_psg.py#L108
I changed the above line into use_mask=False to try to only get the bounding box predictions rather than panoptic masks, but got this error local variable 'keep_tri' referenced before assignment on the following line at inference time after training the first epoch.
https://github.com/Jingkang50/OpenPSG/blob/bdd3c548257b99468e7adddfac7f1fd41a4321a7/openpsg/models/relation_heads/psgtr_head.py#L1171
I noticed keep_tri is defined on line 992, only when use_mask==True.
https://github.com/Jingkang50/OpenPSG/blob/bdd3c548257b99468e7adddfac7f1fd41a4321a7/openpsg/models/relation_heads/psgtr_head.py#L992
Could you kindly help me to resolve this issue or give any suggestions? Thank you so much :)

[Click Here for Full Error Log]
Traceback (most recent call last):
  File "tools/train.py", line 196, in <module>
    main()
  File "tools/train.py", line 192, in main
    meta=meta)
  File "/home/shunchiz/mmdet/mmdet/apis/train.py", line 209, in train_detector
    runner.run(data_loaders, cfg.workflow)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 127, in run
    epoch_runner(data_loaders[i], **kwargs)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 54, in train
    self.call_hook('after_train_epoch')
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/base_runner.py", line 309, in call_hook
    getattr(hook, fn_name)(self)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/hooks/evaluation.py", line 267, in after_train_epoch
    self._do_evaluate(runner)
  File "/home/shunchiz/mmdet/mmdet/core/evaluation/eval_hooks.py", line 119, in _do_evaluate
    gpu_collect=self.gpu_collect)
  File "/home/shunchiz/mmdet/mmdet/apis/test.py", line 98, in multi_gpu_test
    result = model(return_loss=False, rescale=True, **data)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/torch/nn/parallel/distributed.py", line 886, in forward
    output = self.module(*inputs[0], **kwargs[0])
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/fp16_utils.py", line 110, in new_func
    return old_func(*args, **kwargs)
  File "/home/shunchiz/mmdet/mmdet/models/detectors/base.py", line 174, in forward
    Traceback (most recent call last):
return self.forward_test(img, img_metas, **kwargs)
  File "/home/shunchiz/mmdet/mmdet/models/detectors/base.py", line 147, in forward_test
    return self.simple_test(imgs[0], img_metas[0], **kwargs)
  File "/home/shunchiz/OpenPSG/openpsg/models/frameworks/psgtr.py", line 144, in simple_test
    rescale=rescale)
  File "/home/shunchiz/mmdet/mmdet/models/dense_heads/base_dense_head.py", line 360, in simple_test
    return self.simple_test_bboxes(feats, img_metas, rescale=rescale)
  File "/home/shunchiz/OpenPSG/openpsg/models/relation_heads/psgtr_head.py", line 1187, in simple_test_bboxes
  File "tools/train.py", line 196, in <module>
    main()
  File "tools/train.py", line 192, in main
    meta=meta)
  File "/home/shunchiz/mmdet/mmdet/apis/train.py", line 209, in train_detector
    runner.run(data_loaders, cfg.workflow)
    results_list = self.get_bboxes(*outs, img_metas, rescale=rescale)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/fp16_utils.py", line 198, in new_func
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 127, in run
    epoch_runner(data_loaders[i], **kwargs)
    return old_func(*args, **kwargs)
  File "/home/shunchiz/OpenPSG/openpsg/models/relation_heads/psgtr_head.py", line 899, in get_bboxes
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 54, in train
    self.call_hook('after_train_epoch')
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/base_runner.py", line 309, in call_hook
    getattr(hook, fn_name)(self)
    scale_factor, rescale)
  File "/home/shunchiz/OpenPSG/openpsg/models/relation_heads/psgtr_head.py", line 1171, in _get_bboxes_single
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/hooks/evaluation.py", line 267, in after_train_epoch
    self._do_evaluate(runner)
  File "/home/shunchiz/mmdet/mmdet/core/evaluation/eval_hooks.py", line 119, in _do_evaluate
    gpu_collect=self.gpu_collect)
    det_bboxes = torch.cat((s_det_bboxes[keep_tri], o_det_bboxes[keep_tri]), 0)
UnboundLocalError: local variable 'keep_tri' referenced before assignment
  File "/home/shunchiz/mmdet/mmdet/apis/test.py", line 98, in multi_gpu_test
    result = model(return_loss=False, rescale=True, **data)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/torch/nn/parallel/distributed.py", line 886, in forward
    output = self.module(*inputs[0], **kwargs[0])
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/fp16_utils.py", line 110, in new_func
    return old_func(*args, **kwargs)
  File "/home/shunchiz/mmdet/mmdet/models/detectors/base.py", line 174, in forward
    return self.forward_test(img, img_metas, **kwargs)
  File "/home/shunchiz/mmdet/mmdet/models/detectors/base.py", line 147, in forward_test
    return self.simple_test(imgs[0], img_metas[0], **kwargs)
  File "/home/shunchiz/OpenPSG/openpsg/models/frameworks/psgtr.py", line 144, in simple_test
    rescale=rescale)
  File "/home/shunchiz/mmdet/mmdet/models/dense_heads/base_dense_head.py", line 360, in simple_test
    return self.simple_test_bboxes(feats, img_metas, rescale=rescale)
  File "/home/shunchiz/OpenPSG/openpsg/models/relation_heads/psgtr_head.py", line 1187, in simple_test_bboxes
    results_list = self.get_bboxes(*outs, img_metas, rescale=rescale)
  File "/home/shunchiz/miniconda3/envs/mmdet/lib/python3.7/site-packages/mmcv/runner/fp16_utils.py", line 198, in new_func
    return old_func(*args, **kwargs)
  File "/home/shunchiz/OpenPSG/openpsg/models/relation_heads/psgtr_head.py", line 899, in get_bboxes
    scale_factor, rescale)
  File "/home/shunchiz/OpenPSG/openpsg/models/relation_heads/psgtr_head.py", line 1171, in _get_bboxes_single
    det_bboxes = torch.cat((s_det_bboxes[keep_tri], o_det_bboxes[keep_tri]), 0)
UnboundLocalError: local variable 'keep_tri' referenced before assignment

Hi Shunchi, thanks for your question! We will fix this bug as soon as possible.
BTW, if you want to see the bounding box triplet results, you can still set use_mask=True. Under this condition, the model also outputs the bounding box triplets(but deduplicated ones, compared with setting use_mask=True).

Hi Shunchi,
Here are my answers to your questions:

One-stage models with use_mask=True and eval_pan_rels=False as their settings during inference will give you non-duplicated triplets. However, as our deduplication operation is based on masks, the models have to contain mask heads.
Using use_mask=True will decelerate your training process as mask heads are also optimized in training and yes, the model will thus focus on mask predictions too.

Since our competition and demos are all meant to get good mask predictions, code for bbox-only models may not be updated instantly.
If you want to train and evaluate bbox-only models, you can try to substitute following lines:
https://github.com/Jingkang50/OpenPSG/blob/bdd3c548257b99468e7adddfac7f1fd41a4321a7/openpsg/models/relation_heads/psgtr_head.py#1173-1177
        if self.use_mask:
            return det_bboxes, complete_labels, rel_pairs, output_masks, pan_rel_pairs, \
                pan_img, complete_r_labels, complete_r_dists, r_labels, r_dists, pan_masks, rels, pan_labels
        else:
            return det_bboxes, labels, rel_pairs, r_labels, r_dists

with
        if self.use_mask:
            det_bboxes = torch.cat((s_det_bboxes[keep_tri], o_det_bboxes[keep_tri]), 0)
            return det_bboxes, complete_labels, rel_pairs, output_masks, pan_rel_pairs, \
                pan_img, complete_r_labels, complete_r_dists, r_labels, r_dists, pan_masks, rels, pan_labels
        else:
            labels = torch.cat((s_labels, o_labels), 0)
            rel_pairs = torch.arange(len(labels),
                dtype=torch.int).reshape(2, -1).T
            det_bboxes = torch.cat((s_det_bboxes, o_det_bboxes), 0)
            return det_bboxes, labels, rel_pairs, r_labels, r_dists


Program quits on not being able to find thumbnail

The program closes with the following error after error on parsing the json and not being able to extract info.
Error:
File "run.py", line 58, in start_rich_presence
RPC.update(large_image=get_album_artwork(artist, song_playing), state='by ' + artist, details=song_playing, start=start, large_text=song_playing + ' by ' + artist)
File "run.py", line 38, in get_album_artwork
artwork = track['tracks']['items'][0]['album']['images'][0]['url']

Possible Solution:
Adding a try, except statement and replacing the thumbnail of RPC with random Tidal Logo.

Fixed, just added an except statement returning None when doing so.
Check the changes in detail using this commit.


Update container topology service spec

The FactoryGirl.create with :id seemed really bad, so I fixed that and wound up making a bunch of other changes along the way.

@jrafanie Please review
cc @Fryguy

@miq-bot add_label test

@abonas Please review

The initial "Don't create with :id" change looks good to me.  The other changes, :confused:, look unrelated to the id bug.

The initial "Don't create with :id" change looks good to me. The other changes, , look unrelated to the id bug.

+1, although I do like some of the proposed refactorings, they do look cleaner.
worth to note,  https://github.com/ManageIQ/manageiq/pull/4997 waits for merge for some time now, and merging this current PR will create quite a few conflicts.

@abonas @jrafanie Do I need to break this into multiple PR's?

@chessbyte, merged with all conflicts and without final ack?

@abonas What conflicts?


Make staged_files more robust and warn if commit.exs does not work; Closes #12

For a description of changes made, the commit messages are pretty descriptive :smile:
This PR attempts to address #12 by outputting a clean error message if commit.exs is not present

👋Hello @PurpleMyst!
Appreciate you taking the time to send in the PR :)
I did not know there's a -z switch for git diff, TIL!
I checked out this PR and things look good so I'm going to go ahead and merge it, but I was thinking, do you think we should abort the commit when the commit.exs file is gone, or should we just print out the message and let it go on? (This probably requires some more refactoring)
Let me know what you think and happy Elixiring! :)
💯💯💯💯💯

Well, maybe prompting might be a good idea? :man_shrugging:


Update from 0.1.1096 to 0.2.15: Multiple Compilation Errors

As usual, using my repository for checking out new versions of TUnit:
https://github.com/SharpMUSH/SharpMUSH
I'm going to include the errors as a Text File this time, because it's a lot of them. But it's of course largely repeats of various things.
TUnit Upgrade.txt

PR of changes related to this:
https://github.com/SharpMUSH/SharpMUSH/pull/64
Log of errors on Github:
https://github.com/SharpMUSH/SharpMUSH/actions/runs/11528756570

@HarryCordewener Can you remove the package <PackageReference Include="TUnit.Engine.SourceGenerator" Version="0.1.984" /> ?

That indeed fixed the build. Though now Visual Studio never has the tests return to it, and Rider takes quite a while to run them.

I think I might know why. I tried to make the source generator generate a file per test class, but this involves it having to aggregate all the files at once in order for me to filter and group them.
I've reverted this, can you let me know if it improves performance?
Version 0.2.30

That did fix performance for Rider etc, though Visual Studio Preview is still failing to report on findings.
Since dotnet test and rider can run just fine, this to me just reads as a Visual Studio Preview bug. I dunno.

That did fix performance for Rider etc, though Visual Studio Preview is still failing to report on findings. Since dotnet test and rider can run just fine, this to me just reads as a Visual Studio Preview bug. I dunno.

That's good news. I don't think it's a TUnit problem. I've recently added tests to assert I'm sending discovery messages.
Happy to be proven wrong but it also seems to work fine on my machine. (Famous words!)
If you can create a repo reproduction though then please do as that'd help.

It's reproducible on my repo, but would need Docker Desktop installed to run it.
But for now, rider will work. Especially now that it's free for non-commercial use. Just crashes more often than VS.

Very weird that it works in rider but not vs. but if you can produce a mini repro send it over and I can try and investigate!
Vs seems to work fine for me

Trying to generate a mini-repo, but can't even get it to compile at the moment:
https://github.com/HarryCordewener/sample-repo-for-tunit

Severity	Code	Description	Project	File	Line	Suppression State
Error (active)	CS0111	Type '' already defines a member called 'Initialise' with the same parameter types	TUnit-Test	D:\sample-repo-for-tunit\TUnit-Test\obj\Debug\net9.0\TUnit.Core.SourceGenerator\TUnit.Core.SourceGenerator.CodeGenerators.TestsGenerator\Tests_TUnit_Test_TUnit-Test_0cc549a95d254c2fb74621e52114e01a.Generated.cs	13
Error (active)	CS0116	A namespace cannot directly contain members such as fields, methods or statements	TUnit-Test	D:\sample-repo-for-tunit\TUnit-Test\obj\Debug\net9.0\TUnit.Core.SourceGenerator\TUnit.Core.SourceGenerator.CodeGenerators.TestsGenerator\Tests_TUnit_Test_TUnit-Test_0cc549a95d254c2fb74621e52114e01a.Generated.cs	17
Error (active)	CS0111	Type '' already defines a member called 'CollectTests' with the same parameter types	TUnit-Test	D:\sample-repo-for-tunit\TUnit-Test\obj\Debug\net9.0\TUnit.Core.SourceGenerator\TUnit.Core.SourceGenerator.CodeGenerators.TestsGenerator\Tests_TUnit_Test_TUnit-Test_0cc549a95d254c2fb74621e52114e01a.Generated.cs	17
Error (active)	CS0111	Type '' already defines a member called 'Tests0' with the same parameter types	TUnit-Test	D:\sample-repo-for-tunit\TUnit-Test\obj\Debug\net9.0\TUnit.Core.SourceGenerator\TUnit.Core.SourceGenerator.CodeGenerators.TestsGenerator\Tests_TUnit_Test_TUnit-Test_0cc549a95d254c2fb74621e52114e01a.Generated.cs	24
Error (active)	CS0116	A namespace cannot directly contain members such as fields, methods or statements	TUnit-Test	D:\sample-repo-for-tunit\TUnit-Test\obj\Debug\net9.0\TUnit.Core.SourceGenerator\TUnit.Core.SourceGenerator.CodeGenerators.TestsGenerator\Tests_TUnit_Test_TUnit-Test_de79c3e32f6944edbb32af2a2205e577.Generated.cs	17

Ah the compilation error was because there was a - in the class name which isn't valid. I've just pushed a fix to sanitize that.
After that fix, I can see discovered tests in that repo in both Rider and VS and VSCode.
Rider:

VS:

VSCode (though I had to use the pre-release version?):

The new version of the Repository has the problem reproduced.
I suspect it's because of the Task not completing until Disposed - and Rider handling this situation differently from VSCode/Visual Studio somehow?

Unable to reproduce so far. Did find that if I run in Debug mode, it runs the Tests in Visual Studio. But if I run them normally, no go. But amusingly, it misreport the time taken. The following tests took maybe like 5 minutes:

Looks like it's totalling up the time of all tests. Might be an issue with the test explorer itself


error: unable to load server certificate: open /etc/kubernetes/pki/apiserver.crt: permission denied

Inventory File
[primary-master]
ec2-34-216-121-64.us-west-2.compute.amazonaws.com ansible_user=centos

[masters:children]
primary-master

[primary-etcd:children]
primary-master

[etcd:children]
primary-etcd

[nodes]
ec2-18-236-109-252.us-west-2.compute.amazonaws.com ansible_user=centos

[node:children]
nodes

Last Task
TASK [master : Initialize cluster with {{kubeadm_init_args}} --config /etc/kubernetes/kubeadm-master.conf] *************************************************************************************************
fatal: [ec2-34-216-121-64.us-west-2.compute.amazonaws.com]: FAILED! => {"changed": true, "cmd": ["/usr/bin/kubeadm", "init", "--config", "/etc/kubernetes/kubeadm-master.conf"], "delta": "0:04:04.388213", "end": "2019-05-13 16:40:29.313286", "msg": "non-zero return code", "rc": 1, "start": "2019-05-13 16:36:24.925073", "stderr": "\t[WARNING Service-Kubelet]: kubelet service is not enabled, please run 'systemctl enable kubelet.service'\nerror execution phase wait-control-plane: couldn't initialize a Kubernetes cluster", "stderr_lines": ["\t[WARNING Service-Kubelet]: kubelet service is not enabled, please run 'systemctl enable kubelet.service'", "error execution phase wait-control-plane: couldn't initialize a Kubernetes cluster"], "stdout": "[init] Using Kubernetes version: v1.13.4\n[preflight] Running pre-flight checks\n[preflight] Pulling images required for setting up a Kubernetes cluster\n[preflight] This might take a minute or two, depending on the speed of your internet connection\n[preflight] You can also perform this action in beforehand using 'kubeadm config images pull'\n[kubelet-start] Writing kubelet environment file with flags to file \"/var/lib/kubelet/kubeadm-flags.env\"\n[kubelet-start] Writing kubelet configuration to file \"/var/lib/kubelet/config.yaml\"\n[kubelet-start] Activating the kubelet service\n[certs] Using certificateDir folder \"/etc/kubernetes/pki\"\n[certs] Generating \"ca\" certificate and key\n[certs] Generating \"apiserver\" certificate and key\n[certs] apiserver serving cert is signed for DNS names [ip-172-31-52-113.us-west-2.compute.internal kubernetes kubernetes.default kubernetes.default.svc kubernetes.default.svc.cluster.local ec2-34-216-121-64.us-west-2.compute.amazonaws.com ec2-34-216-121-64 master-demok8s.corp.example.com] and IPs [<IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>]\n[certs] Generating \"apiserver-kubelet-client\" certificate and key\n[certs] Generating \"front-proxy-ca\" certificate and key\n[certs] Generating \"front-proxy-client\" certificate and key\n[certs] Generating \"etcd/ca\" certificate and key\n[certs] Generating \"etcd/peer\" certificate and key\n[certs] etcd/peer serving cert is signed for DNS names [ip-172-31-52-113.us-west-2.compute.internal localhost] and IPs [<IP_ADDRESS> <IP_ADDRESS> ::1]\n[certs] Generating \"etcd/healthcheck-client\" certificate and key\n[certs] Generating \"etcd/server\" certificate and key\n[certs] etcd/server serving cert is signed for DNS names [ip-172-31-52-113.us-west-2.compute.internal localhost] and IPs [<IP_ADDRESS> <IP_ADDRESS> ::1]\n[certs] Generating \"apiserver-etcd-client\" certificate and key\n[certs] Generating \"sa\" key and public key\n[kubeconfig] Using kubeconfig folder \"/etc/kubernetes\"\n[kubeconfig] Writing \"admin.conf\" kubeconfig file\n[kubeconfig] Writing \"kubelet.conf\" kubeconfig file\n[kubeconfig] Writing \"controller-manager.conf\" kubeconfig file\n[kubeconfig] Writing \"scheduler.conf\" kubeconfig file\n[control-plane] Using manifest folder \"/etc/kubernetes/manifests\"\n[control-plane] Creating static Pod manifest for \"kube-apiserver\"\n[control-plane] Creating static Pod manifest for \"kube-controller-manager\"\n[control-plane] Creating static Pod manifest for \"kube-scheduler\"\n[etcd] Creating static Pod manifest for local etcd in \"/etc/kubernetes/manifests\"\n[wait-control-plane] Waiting for the kubelet to boot up the control plane as static Pods from directory \"/etc/kubernetes/manifests\". This can take up to 4m0s\n[kubelet-check] Initial timeout of 40s passed.\n\nUnfortunately, an error has occurred:\n\ttimed out waiting for the condition\n\nThis error is likely caused by:\n\t- The kubelet is not running\n\t- The kubelet is unhealthy due to a misconfiguration of the node in some way (required cgroups disabled)\n\nIf you are on a systemd-powered system, you can try to troubleshoot the error with the following commands:\n\t- 'systemctl status kubelet'\n\t- 'journalctl -xeu kubelet'\n\nAdditionally, a control plane component may have crashed or exited when started by the container runtime.\nTo troubleshoot, list all containers using your preferred container runtimes CLI, e.g. docker.\nHere is one example how you may list all Kubernetes containers running in docker:\n\t- 'docker ps -a | grep kube | grep -v pause'\n\tOnce you have found the failing container, you can inspect its logs with:\n\t- 'docker logs CONTAINERID'", "stdout_lines": ["[init] Using Kubernetes version: v1.13.4", "[preflight] Running pre-flight checks", "[preflight] Pulling images required for setting up a Kubernetes cluster", "[preflight] This might take a minute or two, depending on the speed of your internet connection", "[preflight] You can also perform this action in beforehand using 'kubeadm config images pull'", "[kubelet-start] Writing kubelet environment file with flags to file \"/var/lib/kubelet/kubeadm-flags.env\"", "[kubelet-start] Writing kubelet configuration to file \"/var/lib/kubelet/config.yaml\"", "[kubelet-start] Activating the kubelet service", "[certs] Using certificateDir folder \"/etc/kubernetes/pki\"", "[certs] Generating \"ca\" certificate and key", "[certs] Generating \"apiserver\" certificate and key", "[certs] apiserver serving cert is signed for DNS names [ip-172-31-52-113.us-west-2.compute.internal kubernetes kubernetes.default kubernetes.default.svc kubernetes.default.svc.cluster.local ec2-34-216-121-64.us-west-2.compute.amazonaws.com ec2-34-216-121-64 master-demok8s.corp.example.com] and IPs [<IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>]", "[certs] Generating \"apiserver-kubelet-client\" certificate and key", "[certs] Generating \"front-proxy-ca\" certificate and key", "[certs] Generating \"front-proxy-client\" certificate and key", "[certs] Generating \"etcd/ca\" certificate and key", "[certs] Generating \"etcd/peer\" certificate and key", "[certs] etcd/peer serving cert is signed for DNS names [ip-172-31-52-113.us-west-2.compute.internal localhost] and IPs [<IP_ADDRESS> <IP_ADDRESS> ::1]", "[certs] Generating \"etcd/healthcheck-client\" certificate and key", "[certs] Generating \"etcd/server\" certificate and key", "[certs] etcd/server serving cert is signed for DNS names [ip-172-31-52-113.us-west-2.compute.internal localhost] and IPs [<IP_ADDRESS> <IP_ADDRESS> ::1]", "[certs] Generating \"apiserver-etcd-client\" certificate and key", "[certs] Generating \"sa\" key and public key", "[kubeconfig] Using kubeconfig folder \"/etc/kubernetes\"", "[kubeconfig] Writing \"admin.conf\" kubeconfig file", "[kubeconfig] Writing \"kubelet.conf\" kubeconfig file", "[kubeconfig] Writing \"controller-manager.conf\" kubeconfig file", "[kubeconfig] Writing \"scheduler.conf\" kubeconfig file", "[control-plane] Using manifest folder \"/etc/kubernetes/manifests\"", "[control-plane] Creating static Pod manifest for \"kube-apiserver\"", "[control-plane] Creating static Pod manifest for \"kube-controller-manager\"", "[control-plane] Creating static Pod manifest for \"kube-scheduler\"", "[etcd] Creating static Pod manifest for local etcd in \"/etc/kubernetes/manifests\"", "[wait-control-plane] Waiting for the kubelet to boot up the control plane as static Pods from directory \"/etc/kubernetes/manifests\". This can take up to 4m0s", "[kubelet-check] Initial timeout of 40s passed.", "", "Unfortunately, an error has occurred:", "\ttimed out waiting for the condition", "", "This error is likely caused by:", "\t- The kubelet is not running", "\t- The kubelet is unhealthy due to a misconfiguration of the node in some way (required cgroups disabled)", "", "If you are on a systemd-powered system, you can try to troubleshoot the error with the following commands:", "\t- 'systemctl status kubelet'", "\t- 'journalctl -xeu kubelet'", "", "Additionally, a control plane component may have crashed or exited when started by the container runtime.", "To troubleshoot, list all containers using your preferred container runtimes CLI, e.g. docker.", "Here is one example how you may list all Kubernetes containers running in docker:", "\t- 'docker ps -a | grep kube | grep -v pause'", "\tOnce you have found the failing container, you can inspect its logs with:", "\t- 'docker logs CONTAINERID'"]}

Command: ansible-playbook -i hosts.example site.yml --private-key=Key.pem
Kubernetes: v1.13.4
CentOS: 7.6
Repo Branch: v1.13
When I ssh into master, and try to get the logs of kube-api-server pod, I get the following error
 error: unable to load server certificate: open /etc/kubernetes/pki/apiserver.crt: permission denied
I have even tried to run the api manually after giving all the permission to the pki directory, just for test but the error is still same.
Please help me fix the issue

Maybe there are some permission issues indeed.
Can you run the setup with root?
What does systemctl status kubelet and journalctl -xeu kubelet say?
Also cat 10-kubeadm.conf
Can you check if the the cgroup driver used by kubelet and docker is the same?

I couldn't exactly pinpoint the issue, but got it fix by following one of the two options below:

Need to disable the selinux myself on CentOS 7+, I thought playbook was handling it.
OR
Since the playbook was installing docker v1.13, when I configured the playbook to install the lastest Docker CE, issue was fixed right on.

there is a flag, playbook does handle when enabled. Best experience is when selinux is permissive (not disabled). Disabled might cause issues.
I guess the issue was a cgroups miss-match; There should be no limitation on which docker version is used.


(becyicongrabber) projectUrl and licenseUrl need amending as site no longer available

Chocolatey Version
2.2.2
Chocolatey License
None
Package Version
<IP_ADDRESS>61027
Current Behaviour
Package URL:
https://community.chocolatey.org/packages/becyicongrabber
Clicking on "Software Site" links to here:
http://www.becyhome.de/download_eng.htm#becyicongrabber
That is dead, shows 404 Not Found...

The homepage http://www.becyhome.de is also dead. White page, empty HTML document, although HTTP status code 200.
Did a WHOIS lookup but experienced issues, oddly enough.
Expected Behaviour
Working link.
Steps To Reproduce

Visit package
Click Software Site

Environment
N/A

Chocolatey Log
N/A

Anything else?
No response

As far as I'm aware, there is not a replacement website, so there is nothing to amend the links to.
The package is embedded and it still works, so there is no reason to unlist the package.
The package is in the manual folder in this repository, so I'm not seeing any action required for this package.

Understood. I wasn't concerned about delisting so much as someone else taking over the domain of the Software Site, and potentially linking to or providing some malicious or questionable content.  I wasn't concerned about delisting so much as someone else taking over the domain of the Software Site, and potentially linking to or providing some malicious or questionable content. More of a head's up than anything. 😊

I understand your concern, but unfortunately the only action we can take is to unlist the package. Changing the URLs requires a new fix version of the package, and with the upstream URLs no longer existing and there is nothing that replaces them we cannot create a fix version as the binary file cannot be verified anymore.
Also, since there are no replacement URLs, there isn't anything to change them to either, and the software URL is a required URL for any packages on the Chocolatey Community Repository.
Finally, while we can unlist the package, I am hesitant to do so as the software is still used by other people (myself included).
Due to the above, I'll be closing this issue. But we can always re-open this if the situation changes in the future.


Badge request: PR count by user in repository /github/issues-pr/:owner/:repo/:user

:clipboard: Description
Display the number of PR's contributed by a specific user to a specific (GitHub) repo.

:link: Data
https://api.github.com/search/issues?q=is:pr+author:USER+repo:OWNER/REPO+state:STATE&per_page=1 and check the value of total_count
Example:
"shields pull requests by jakkdl | 32"
"open shields pull requests by jakkdl | 32"
"closed shields pull requests by jakkdl | 32"

:microphone: Motivation
I want to showcase my FOSS contributions in my readme, there are other badges that show total PR's committed - but I have loads of personal repositories that nobody cares about, so I would like to specifically highlight how many PR's I have to some specific large repositories.

Thank you for reaching out with your request. We do already support this via our existing GitHub Issues Custom Query badge:
e.g.
https://img.shields.io/github/issues-search?label=shields pull requests by caleb&query=is%3Apr author%3Acalebcartwright repo%3Abadges%2Fshields

My inclination is to leverage this existing capability, as we largely provide it to handle such circumstances where users have various query-driven badges they'd like to have. I don't think there's a large enough need for this particular badge to justify the overhead on the codebase of having a dedicated badge route just to make things a tad simpler for this specific query/set of queries.
I'll hold off to see if others disagree, but would move we close this issue

Ah, I'd missed that was a thing. Makes perfect sense to use custom queries for niche requests, and I agree with your logic in the PR that it should be seen as the general solution.
I saw that it was possible to create your own endpoint but somehow missed the custom query completely, so maybe it's a good idea to make it more prominent. Could e.g. put an example or two on the top of pages such as https://shields.io/category/issue-tracking

There already are a few examples there amongst the listings (GitHub issue custom search in repo):

But we are currently undergoing a process (albeit a rather long and complicated one) to overhaul the site UX so perhaps there will be opportunities there to make things pop a bit more.
Going to go ahead and close this for now given the above discussion


Support migration of page type URL patterns

Motivation
In Kentico Xperience 13, you could create page types that had their own URL pattern rather than using content tree-based routing. This meant that URLs could be based off patterns instead of the content tree.
Although the KX13 documentation recommends content tree routing, some websites will have been built using custom routing with URL patterns. Especially if they have previously migrated from Kentico 12 MVC as content tree-based routing was not available at the time.
These existing clients should be able to use the migration toolkit, they should not be left out.
Proposed solution
As Xperience by Kentico does not support page type URL patterns, it obviously can't be mapped 1:1. I think a suitable solution would be to resolve the URL of the existing page, store it as a vanity URL when that is released, and set that URL as the canonical. This way, migrated pages will keep the existing URL and not break when switching to Xperience by Kentico.
The expectation then would be that new pages using these page types would start to use the content tree-based routing.
If the team managing the website wanted to continue using page type URL patterns, it would be their responsibility to implement a bespoke solution to handle this going forward.

Thank you for your recommendation. We'll evaluate its feasibility and provide regular updates on its integration progress.

Hi Liam, technically this could be added into the migration tool, however we think that this is not a best practice for utilizing Vanity URLs and therefore we decided not to go on with the implementation. Instead, we will recommend to achieve this scenario through customization and offer an example for this purpose.

That's fine with me - as long as there is a recommended approach to follow that supports these clients then I am happy.
If we're no longer using Vanity URLs for this, do you know how long it will take for the recommended approach to be published?

Thanks @tkrch - this would only correct it from a routing perspective, right?
How do you suggest correcting the URL being displayed on the page in the web channel?
When resolving the page's URL through Kentico's APIs will the content-tree based URL still be used?
When a URL has been previously added to rich text blocks, and in the future, which URL will be used?


Add function to create array of RawRepresentables

This enables you to easily take an array in the source data, and get a
strongly typed array of RawRepresentable values. This is heavily
documented to make as obvious as possible the fact that we are
discarding (or replacing) unknown values.
Supersedes https://github.com/lyft/mapper/pull/34

👍


Output to JPG

Expected behavior
I would like the plugin to output the signature to JPG instead of PNG.
Actual behavior
Seems like the default when saving the BLOB is PNG.
Steps to reproduce the issue
Take the normal steps and save to the DB using a simple insert statement.
APEX version (4.2.6 / 5.0.3)
<IP_ADDRESS>.45
Used web server / version and platform (ORDS 3.0.3 / Tomcat 7 / Apache 2.4 / Linux x64)
ORDS
Used web browser / version and platform (Chrome 48 Mac / Firefox 44 Windows)
Chrome latest
Question
I am sure that I missed this setting somewhere, but is it possible to have the plugin output a JPG/BLOB instead of PNG?

Hi there!
Did you solve this?
I want to be able to save it as jpg file.
Regards,
Mathias


new iohk-monitor

Move to a newer version of iohk-monitor which support disabling
of syslog deps.

looks good

bors r+


From server side how to limit the number of the parties one user can create and message sending frequency?

Hi,
I have some further test on the party functions. It seems one user can create unlimited number of parties. It seems that a malicious client can dry up the server resources by creating an infinite loop of party creation function, can’t it? I do not find any before hooks for Party related functions. How can I control the party behaviors from the server side? For example, I would like to forbid each player to create more than one party.
Additionally, I wonder where I can limit the frequency of the messages sent(Room, Group, DM) by users. I would like to limit the interval time of message sending to 1 sec for every player to avoid spamming.
I am still in progress on getting familiar with everything about Nakama, Kind of needing some help on those security mechanism in Nakama. Thanks

@ownway88 You're looking for before hooks which let you intercept, validate, and throttle calls from the client based on the operation being attempted.
This discussion is better suited to the forum, please head over there if you need further help.

Yes, before hooks for parties do exist same as before hooks on all other socket-based operations. The forum is the best community support resource, the issue tracker is not an appropriate venue for this topic.


No commitment attribute for the function perform swap

On the function perform swap there is no commitment attribute

In the latest version there is.  Can you confirm you are on the latest version?

I installed the dependency by using yarn add solana-swap. Not sure if it is the latest version

Try: yarn add solana-swap@latest

I tried yarn add solana-swap@latest
This is the current version I have "solana-swap": "^1.0.14"
Still the same issue

Still no luck figuring out how to send the commitment level. Do you recommend to use the API instead?

I will take a look tomorrow and push a fix!
On Tue, Jun 25, 2024 at 00:30 Anthony Dandrade @.***>
wrote:

Still no luck figuring out how to send the commitment level. Do you
recommend to use the API instead?
—
Reply to this email directly, view it on GitHub
https://github.com/YZYLAB/solana-swap/issues/3#issuecomment-2187521747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKYUSFHPD6UFDCGPZV575Y3ZJCMX7AVCNFSM6AAAAABJ2FNDWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXGUZDCNZUG4
.
You are receiving this because you commented.Message ID:
@.***>

Thanks! Looking forward to continue using the package

I believe it should be fixed now if you install version 1.0.15. Please check and let me know

Yes it's working great now. Thank you very much


Fix https://github.com/nrc/rustfmt/issues/270

The variants of an enum use the list module rather than its own special case handling. This makes for better pre- and post-comment handling.
Additionally, there was a small bug in struct formatting that I never reported but resolved in this PR. I'll document it here:
If a field had any attributes and the post-comment needed to be split into a multi-line, the subsequent comment lines were misaligned. e.g.:
struct FieldsWithAttributes {
    // Pre Comment
    #[rustfmt_skip] pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
                                      * BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
    // Another pre comment
    #[attr1]
    #[attr2]
    pub id: usize, /* CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCCCC
                    * CCCCCCCCCCCCCC CCCCCCCCCCCC */
}

was formatted to:
struct FieldsWithAttributes {
    // Pre Comment
    #[rustfmt_skip] pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
                                      * BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
    // Another pre comment
    #[attr1]
    #[attr2]
    pub id: usize, /* CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCCCCC
                                              * CCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCCCC
                                              * CCCCCCCCCCCCCC CCCCCCCCCCCC */
}

Could you tidy up the git history before landing please? Probably the easiest way to do this is to pull master, checkout a fresh branch and then cherry pick your commits. Thanks!

:100:
These are great changes!

Thanks for the help, guys. I've made a new PR with a cleaned-up history -- #420.
I explicitly marked the latest changes I made because your comments here won't migrate. Hope it wasn't annoyingly verbose of me emoticon.


Fine tuning for new topic

Would I be correct in saying that for fine-tuning a topic that the models were not trained on, I could simply finetune PixArt on the subject?
I just noticed train_t2iv_lora.sh, that should do!

yes, and also you can refer to train_t2iv.sh to train the whole model.


Add ability for KerasClassifier to process string classes.

Scikit-learn classifiers are able to process strings in their target classes. This PR allows KerasClassifier to do the same while also exposing a .classes_ attribute containing the classes used during fitting.
I modified the corresponding unit tests to test the behavior of KerasClassifier when fitted with string labels.

Closing outdated PR. If you still care about the content of the PR, please submit a new PR to master, updated for the Keras 2.0 API.