9+ Feature Requests (From ~Discord ~Internet)

9+ Feature Requests (From ~Discord ~Internet):
1.) Can we have women and men gender selection and various appearance customization features per character?
2.) Can we have 1 account have a character selection screen like in wow / eq so we can have alts and not a billion passwords to keep track of like at least 16 characters if not like 100+? At least 16+ characters per account is ideal.
3.) Can we have an Adventurer (start with no features at the start) / 'default' / 'classless' class option like in osrs / oblivion?
4.) Can we have ~6 classes to pick at the start?:

Adventurer (default / no features at the start / 'classless' / make your own class)
Warrior (Melee dps / tank starter boost)
Ranger / Wanderer (Ranged / bow dps starter boost)
Wizard (Caster / dps starter boost)
Warden / Cleric / Priest (Healer / support / dps start boost)
Bard / Rogue / Worlder (Hybrid / dps / tank / healer jack of all trades boost)

5.) Can we have multiclassing like in BG3/D&D?
6.) Can we hotswap classes technically like in that demo you could selection 1 class load it up and play that with its own set of abilities can we bring that back as a hotswap to test things online? As like in the previous classes build demo press j to bring up class selection screen then swap to a class like ranger or caster to test abilities?
7.) Can we have classes that can just be titles and new classes can be changed into as options like unlocking new titles from hero orders and like D&D where classes can be added and changed later too? It makes it like legos for player choice and that's good for open source having those kinds of rpg options.
8.) Can we have multiboxing of up to 16 characters from 1 account on 1 client / player / computer like with bg3/infinity engine games/d2 merc/rts?
9.) Can we have /follow /stop /hostile /defensive /passive /heal_lowest_ally commands (akin to bg / wow combat pet commands) would go so far with group / multiboxing / rts features?
Bonus.) More Feature Requests:
Arbitrary Attributes, Arbitrary Resources (e.g. Health, Spirit, Mana etc.), Arbitrary Abilities, Groups, Raids, Instances, Guilds, Storage, Banking, Trade, Auction House, Mail Box System, Player / Guild Housing, Customizable Player Decorations / Tabards / Images / Armour / Weapons / Items / Appearances / Objects etc., Building, Tradeskills, Gather Skills, Crafting Skills, Skills minigames (e.g. weave stitches to sew item etc.), PvP, 'Single Player' / 'Personal Server' / 'Offline / Dev Mode', Mounts, Pets, LIGHT cosmetic only monetization and website store guide, Game Masters, Moderation and forums, Account Security, 'Vehicles' (e.g. siege tower, catapult, ship, hot air balloon, wagon, chariot, 'tank', 'air ship' etc.), public transportation (e.g. boats, wagons, trains, griffins etc.), sieges with destructible walls / gates (e.g wintergrasp in wow / mount and blade banner lord / lord of the rings / history). Barber shop to customize hair appearance etc. 2.5D graphics, 3D graphics VR, physics, realistic ballistics etc., summon avatars like D&D and conan mmorpg, dynamic spawning / populating world, music and play instruments like bg3/D&D, player feature voting polls for big time open source forever free MMORPGs!
Discord Requests Archived:
"Mawakajaka — Today at 02:28
what do you think of this class selection menu?
Cablefish — Today at 02:36
The Pick X in the bottom seems redundant
Mawakajaka — Today at 02:44
it's the actual button XD
[02:44]
but I understand your remark (edited)
Cablefish — Today at 04:59
I know. Just think the design could be neater someway
Matthew — Today at 08:37
can we have a classless option like in osrs / oblivion too?
[08:38]
like maybe 4-6
adventurer (classless)
melee
ranged
caster
support
hybrid
[08:41]
also can 1 account have a character selection screen like in wow / eq so we can have alts and not a billion passwords to keep track of like at least 16 characters if not like 100+ but like idk how we handle multiboxing I guess you have a feature like add alt to 1 client with ai / macros like rts / crpg like bg or iwd or d2 merc etc
Matthew — Today at 09:00
https://github.com/jonathaneeckhout/jdungeon/issues/252 I made it on github to better keep track of it. (edited)
GitHub
Classless / 4-6 Class Options, 16+ multiple characters per account ...
From Discord Suggestion. Can we have a classless option like in osrs / oblivion too? like maybe 4-6 adventurer (classless) melee ranged caster support hybrid Also can 1 account have a character sel...
@Matthew
https://github.com/jonathaneeckhout/jdungeon/issues/252 I made it on github to better keep track of it. (edited)
Nancok — Today at 18:42
Atm it would be easier to assign them the default class (which has no features) Since a lot of stuff REQUIRES the character to have a class to know how to define the stats.
But it wouldn't do anything other than making you play for a bit without any skills.
[18:42]
We can def. have multiple per account, but it would require a bit of a rework in how we store and load the data.
[18:44]
Also a reminder that characters can support ANY amount of classes, it is currently set to 1 in case new issues pop-up regarding multi-classing. That way we can focus on adding more features.
(Not like there's many options to multiclass towards rn) (edited)
Matthew — Today at 18:59
Hmmmm
@Nancok
Atm it would be easier to assign them the default class (which has no features) Since a lot of stuff REQUIRES the character to have a class to know how to define the stats. But it wouldn't do anything other than making you play for a bit without any skills.
Matthew — Today at 19:44
I just want a clean start by default (no features to start as you say) like osrs or oblivion where in oblivion you can pick a class that is a little boost to melee or range or caster or support or hybrid etc but with 'Adventurer' you get the option of build your own play style like osrs so if the default class was 'Adventurer' that started at a base default like a stem cell that could be further customized then we can have the best of both worlds. Also I hope classes can just be titles too and new classes can be changed into as options like unlocking new titles from hero orders and like D&D where classes can be added and changed
later too. It makes it like legos for player choice and thats good for open source having those kinds of rpg options. (edited)
@Nancok
We can def. have multiple per account, but it would require a bit of a rework in how we store and load the data.
Matthew — Today at 19:46
at least characters 16+ per account is ideal
@Nancok
Also a reminder that characters can support ANY amount of classes, it is currently set to 1 in case new issues pop-up regarding multi-classing. That way we can focus on adding more features. (Not like there's many options to multiclass towards rn) (edited)
Matthew — Today at 19:49
can we hotswap classes technically like in that demo you could selection 1 class load it up and play that with its own set of abilities can we bring that back as a hotswap to test things online? like swap to 'adventurer' which is the base like a default thing (like you said has no features at the start) and like in the demo press j to bring up class selection screen then swap to a class like ranger or caster to test abilities?
[19:49]
Also multiclassing would be cool like in bg3/D&D (edited)
[19:52]
multiboxing is like bg3/infinity engine games/wow/eq/osrs where you control multiple characters with 1 client / pc / player. I had unreal easyrpg do this 3rd person 3D with 4k-8k metahumans with 16 party members multiboxing like bg3 or and rts kinda lol. I hope to be able to do so here so I can built big content like raids that work in multiplayer and single player and get bits of rts / crpg / bg3 type gameplay going."
-7:52 PM to 8:48 PM 13th / 02 (February) / 2024
Also inspired from:
https://github.com/jonathaneeckhout/jdungeon/issues/252
https://github.com/jonathaneeckhout/jdungeon/issues/244
https://github.com/jonathaneeckhout/jdungeon/issues/240
https://github.com/jonathaneeckhout/jdungeon/issues/238
Feedback is welcome!

Out of scope for this project or near future roadmap, closing this ticket


BER-395: Sync origin with upstream v0.27.13

Context

Why do we want/need it?

To keep origin up to date.

Relevant issues

Closes https://github.com/nedap/berichten-ios/issues/395

Changes

What does it do?
In summary, what changes are made to the code?

Merged upstream (MatrixSDK v0.27.13)
Matrix adds accessToken to loading media, logic that we added some time ago. In this case I replaced our changes with Matrix changes (basically removing Modified by Nedap comments) because it's doing the same thing.
I added the tag nedap/0.1.4 to this branch to be able to test it in berichten-ios, but I will remove it and add it to ons_master once the branch is approved and merged.

Known problems

What problems do still arise or are anticipated?
Which part of the solution do you need help with?

Extra attention

What do I need to pay extra attention to as a reviewer?

Check-list

[ ] Acceptance criteria described in the issue are satisfied, or the bug(s) is/are fixed.
[ ] Documentation present (relevant information is properly documented).
[ ] Written tests for test suite (optional).
[ ] CHANGELOG updated.

Tested on devices

[ ] Minimum supported iOS version.
[ ] Maximum supported iOS version.
[ ] Lowest resolution supported.
[ ] Highest resolution supported.
[ ] Device with a notch.
[ ] Device without a notch.

Is this issue considered as Done?

[ ] It meets our DoD.

It seemed to work in the app, but please double check that there is some Nedap code removed

Thanks for the review! I was also surprised to see matrix now adding accessToken to the request, feature we implemented some time ago. So, I've removed our code and kept the matrix implementation since it is doing the same thing 😄


RedisGraph now supports parameters

Hi
As part of the RedisGraph 2.0 development efforts, we recently enabled parameterized queries at RedisGraph.
You can get it by cloning our master branch or with docker docker run -p 6379:6379 -it --rm redislabs/redisgraph:edge.
The python client supports parameters, and can be installed by pip install git+https://github.com/RedisGraph/redisgraph-py.git@master. golang, js, and java clients will get this updated in the next few days.
We'll be happy to get your input ragarding this feature.

Awesome, thank you for the heads-up! We're currently focusing on final polish for our v2.0 release, and we're looking forward to doing some more Cypher and RedisGraph work after that.


Keyboard fails to access Year on Focus

When I am trying to access the Year using keyboard I am not getting focus on the Year In the Calendar. For Other fields Focus is appearing except Year. Can you please provide the focus on Year also..

I have the same issue. (it's a WCAG issue to not offer keyboard navigation to YEAR)

Are you referring to the Year selection in the toolbar, like below? If so, this is being addressed in #976 for all picker toolbars.


No "upgrade" option available

The current recipe has no option to pass the ":upgrade" option to python_package. This prevents recipes from being able to update awscli, even if a specific and more recent version is activated as an attribute.

PR welcome for this. However it isn't needed if you specify the version with the proper node attribute. All underlying dependencies will be upgraded for the new version if needed.


~

Hi @strummer75, this looks like it may have been a mistake? Closing this ticket, please open a new one with details if you have an issue.


Rating - Adds container around icons for visible keyboard focus

For Issue #249
Adds container around spectrum-Rating-icon icons for visible keyboard focus
Description
In order to preview the focus state of the Rating component this PR adds a container around spectrum-Rating-icon icons for visible keyboard focus using a .focus-ring + & sibling selector.

Just realized spectrum-Rating-input is inside of spectrum-Rating and that's not valid. Refactoring....

Refactored and push.

Thanks for the contribution, @Martskin! So #249 is more about showing the already implemented behavior in the docs site, with a simple JS enhancement. Your PR makes it possible to show focus purely with CSS, which enables partial interactivity, but I think we can do this real quick in JS. I'll go ahead and close this and push a branch with the enhancement so we show focus.

Superseded by https://github.com/adobe/spectrum-css/pull/373
@Martskin, can you please take a look at that?


Add bucket cardinality information to the /metrics endpoint

Proposal:
Add counters to the /metrics endpoint that report the cardinality of each bucket in the oss instance
Current behavior:
There is no cardinality information stored there
Desired behavior:
Similar to the https://docs.influxdata.com/platform/monitoring/influxdata-platform/tools/measurements-internal/#nummeasurements and https://docs.influxdata.com/platform/monitoring/influxdata-platform/tools/measurements-internal/#numseries information in 1.x, adding this information to the /metrics endpoint would allow users to monitor for runaway cardinality issues

Closed by https://github.com/influxdata/influxdb/pull/22938

Specifically:
# HELP storage_bucket_series_num Gauge of series cardinality per bucket
# TYPE storage_bucket_series_num gauge
storage_bucket_series_num{bucket=“b7da63cc2f6d922f”} 85
storage_bucket_series_num{bucket=“d2dc443f48b2c910"} 25


fixed error in DBtables syntax, and added new cert for new CloudDB

fixes the issue where creating new tables for a DB throws a syntax error.
bug: https://github.com/Taks0708/SOFTENG310-FinTrack/issues/138

looks good to me!


Allow for generating kubernetes YAML files from modules

This PR adds the ability to generate kubernetes YAML files from modules.
By adding the request's dictionary to the returned ansible results and the ability to have dry_run executions, we'll allow consumers of this module for registering the result variable and dumping the requests onto a YAML file for later use with other k8s specific CLI tools.

@flaper87
This PR doesn't belong here. It needs to be made against the ansible repo. k8s_common.py is actually part of module_utils, here.
We should probably remove this copy. It was added here to help older version of Ansible that don't include a k8s_common.py.

@chouseknecht holy moly, I had no idea! Will move this PR, thanks 👍


Introduce wrap multi errors using Go standard library

At the moment, We use our own built in multierror package in order to handle multi errors. As Go community released the 1.20 version. The wrap multi errors is possible.
As a Developer I want to use the standard library to handle multi errors by introducing wrapping multiple error.
AC:

Revisit current multi error handling implementation.
Use the standard library to wrap multi error checking (e.g: func Join(errs ...error) error{//...}).
Correct tests accordingly.

https://github.com/kyma-project/lifecycle-manager/blob/e76fb556aa320e9901fc356430b70bb947092363/pkg/types/multi_error.go#L12


Power Tower Cavity Receiver in Southern hemisphere optimizes heliostat field incorrectly

Describe the bug
For Southern Hemisphere locations, MSPT with cavity receiver optimizes heliostat field with more heliostats north of the tower than south. Note that external receiver works correctly.
To Reproduce

Create a default MSPT / Single Owner case.
Use the Advanced Download option on the Location and Resource page to download a 60-min 2009 weather file for -28.3,23.07 (a location in Northern Cape Province in South Africa).
On the Heliostat Field page, click Calculate for Optimize heliostat layout and tower dimensions to optimize the field layout.
When the optimization finishes, click Yes to update inputs and note distribution of heliostats south of the tower in the diagram.
On the Tower and Receiver page, change MSPT Receiver External to MSPT Receiver Cavity.
Repeat Steps 3 and 4, noting distribution of heliostats north of tower.

Expected behavior
Cavity receiver option should work correctly for Southern Hemisphere locations.
Screenshots
Heliostat distribution for Southern Hemisphere location with cavity receiver:

External receiver:

@qualand (can't figure out how to assign this to you...)


Vulnerable Dependencies introduced with v6.2.1: org.bouncycastle:bcprov-jdk15on org.apache.commons:commons-dbcp2

Describe the bug
v6.2.1 introduced two vulernable dependencies in the core library.

<EMAIL_ADDRESS>which is vulnerable to CVE-2020-15522
<EMAIL_ADDRESS>which has a information exposure vulnerability: https://snyk.io/vuln/SNYK-JAVA-ORGAPACHECOMMONS-559327

The latter has no fix for the vuln, so my recommendation would be to remove it all together and not enforce configuring a suppression for users.
Version of dependency-check used
The problem occurs using version 6.2.1 of the core library
Log file
See https://app.snyk.io/org/albuch/project/d94fb5ab-fc33-4437-a44b-103c4e384a3f/pr-check/0a08ce7c-baf4-4b4a-9197-e2ad7aebf5f8 for SNYK report of my update pull request: https://github.com/albuch/sbt-dependency-check/pull/194

Btw. dependency-check did not identify these vulnerabilities. See my build step "DependecyCheck" for the PR: https://github.com/albuch/sbt-dependency-check/pull/194/checks?check_run_id=2774649259
The second one is understandable as it has not CVE assigned.
However the first for<EMAIL_ADDRESS>seems to be a false-negative I'll open up a seperate issue with a false-negative report.

We will upgrade dbcp when the new version is available.  In our use of the eclipse packager-rpm - bouncy castle does not appear to be used so I just put an exclusion in place.

With https://github.com/jeremylong/DependencyCheck/pull/3567 - this issue can be closed.
Thanks!


Suggestion: Mending working in Killer joe As Default.

Could we have it so that the mending works with the sword the killer joe is using.
Or if there is a configuration for this could it be default.

Could you just, you know, enable it in the configuration, instead of wasting everyone's time reporting a nonissue?

no need to be a prick about it.

@HeavyDeception if you look through the configuration you will see an option to enable that feature you requested.
Please close the issue.

@AnrDaemon When you type to someone Please be nicer like saying "There is a setting for that and its off by default. Plz Look at the configs for Enderio."

It's fine, there are a lot of config options and it is easy to get lost in them.

@tterrag1098 thanks you.

@AnrDaemon do you want the repository owners to ban you? Cause being a D-bag to people when it is not needed is how you do that.
Not that I am much better but still...
Also, @tterrag1098 thank you for never banning me for my d-baggery. :)

BTW, the config is on by default. If it is not working for you, you are either using an old version, your pack creator disabled it, your server owner disabled it, or there's a bug.

@HenryLoenwind Its and 1.10 enderio is <IP_ADDRESS> beta


Update dependencies

Substitute this line for a meaningful title for your changes
Overview
This PR updates dependencies, such as Typeorm, nestjs-base-service, nest.js and node.
For now this is just initial basic change of a version in package.json, all the required refactoring will be added in parts as PR to this branch. Once all the required updating and refactoring is merged to the the branch, we can do final review, testing and merge it to develop
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets

Checklist before submitting

[ ] Meaningful commits and code rebased on develop.
[ ] If this PR adds feature that should be tested for regressions when
deploying to staging/production, please add brief testing instructions
to the deploy checklist (docs/deployment-checklist.md)
[ ] Update CHANGELOG file

maybe include the updated yarn.lock, to keep this change atomic (and package.json and yarn.lock in sync)

@yulia-bel can we merge this, rolling back the branch's head to 3f12eb8a2abd683c331cb691497d8ecb0911220a?
#1317 is rebased on top of that commit, and all tests pass there, so I would not waste more time waiting for GH runners and planets to align on getting all tests green in this PR - we know that the branch as of 3f12eb8a2abd683c331cb691497d8ecb0911220a is green, so I'd very much push for us to merge this.
In practice, I suggest that you continue your work on NodeJS version bump in a new branch which would be an exact copy of this one as it is now (645ddc4239c209bb056274052ba54c3fff4f5418), remove all commits from chore/api/MRXN23-2-update-typeorm after 3f12eb8a2abd683c331cb691497d8ecb0911220a, force-push, and then merge this PR.
I'll actually "threaten" to do this myself as soon as possible after 6pm Madrid time today if neither of you PR authors wishes to pull the trigger 😉


Fix unexpected route registration/unregistration messages during cf redeployment

Fix unexpected route registration/unregistration messages during cf redeployment
Summary
On our live environments when diego-api is updated during a bosh deploy ... some apps experience 503 Service Unavailable for a brief time period.
Chronology of events:

Run bosh deploy ... with the regular sprint update. (all is fine for now)
The diego-api (0) with the active bbs instance shuts down. (all is fine for now)
diego-api (0) starts and diego-api (1) is shut down by bosh. (all is fine for now)
bbs from diego-api (0) becomes the active bbs instance. (and all turns on fire 🔥)
Some apps experience 503 Service Unavailable for 1-7 minutes.
All gets fixed by itself. ✅

Errors in gorouter:
"error":"x509: certificate is valid for <app-guid-1>, not <app-guid-2>"

Hence route-emitter should be involved which could actually be observed from the metrics below (step 4 was performed around 2:30):

Such events in route-emitter occur only when the bbs hub module sends events to route-emitter with ActualLRP changes (code).
On some environments we see the following errors within bbs whenever the issue occurs:
"message": "bbs.request.start-actual-lrp.db-start-actual-lrp.failed-to-transition-actual-lrp-to-started",

On others we see:
{
    "timestamp": "2021-07-29T02:33:22.404279874Z",
    "level": "error",
    "source": "bbs",
    "message": "bbs.got-error-sending-event",
    "data": {
        "error": "slow consumer"
    }
}

{
    "timestamp": "2021-07-29T02:30:55.825459239Z",
    "level": "error",
    "source": "bbs",
    "message": "bbs.request.subscribe-r0.failed-to-get-next-event",
    "data": {
        "error": "read from closed source",
        "session": "1827.1"
    }
}

# Also this one is seen but it is due to encryption key rotation and I guess it is nothing to worry about.
{
    "timestamp": "2021-07-29T02:35:37.111491890Z",
    "level": "error",
    "source": "bbs",
    "message": "bbs.encryptor.failed-to-scan-blob",
    "data": {
        "blob_columns": [
            "run_info",
            "volume_placement",
            "routes"
        ],
        "desired-key-label": "key1_2021T07a_0",
        "error": "sql: no rows in result set",
        "existing-key-label": "key1_2021T06b_0",
        "primary_key": "process_guid",
        "session": "7",
        "table_name": "desired_lrps"
    }
}

Expectation:
Such "bursting" route registration/unregistration behaviour should be observed only during diego-cell updates and shouldn't lead to app downtime. In our case only diego-api is updated separately from the diego-cells which is why I would classify it as a strange behaviour.
Steps to Reproduce
Not clear yet but a good starting point is:
GIVEN a foundation with at least 10 diego-cells each with ~50 containers,
WHEN you redeploy cf with bosh and diego-api gets updated,
THEN route_emitter.RoutesRegistered and route_emitter.RoutesUnregistered metrics rapidly increase their values for a short period of time on almost all diego-cells resulting in x509: certificate is valid for <app-guid-1>, not <app-guid-2> errors in gorouter.
💡 I'll work over finding a better way to reproduce it.
💡 I'm also not sure whether it happens during each failover of bbs.
Diego repo
My suspicions are that the issue is coming from the:

bbs
route-emitter

Environment Details
The issue can be seen amongst environments ranging from 2k to 60k app instances.
We're running diego-release v2.50.0 and routing-release v0.216.0.
We've been observing the issue for around 1-2 months already.
Last observed with this cf-deployment version.
Possible Causes or Fixes (optional)
I thought it was due to bbs encryption key rotation because there were good correlations between bbs.EncryptionDuration and the duration of the outage. Anyways I saw it happen without a key rotation so it shouldn't be it.
I have also only seen it happen during regular updates and not when diego-api fails over.
My guts tell me the new active bbs instance performs a rollback of events because it had been outdated. Also I think locket might be involved in all of this since I see a lot of errors related it.

Here's a quick update on my progress.
It turned out that the way I had recreated the issue initially was a bit incorrect since I was using a single diego-api instance leading to locket downtime. The good news is that I'm able to recreate it with the same scenario as above but this time using 2 x diego-api instances. Also I rotate the bbs_encryption_key every time.
I also intercepted all of the events received during an update within diego-api (pastebin). As it could be seen there is a burst of actual_lrp_instance_changed and actual_lrp_changed events. This behaviour is totally unexpected.
I then inspected the event objects thoroughly and it turns out that there is a mismatch between ActualLRPNetInfo. This is an example intercepted event through cfdot:
{
    "type": "actual_lrp_changed",
    "data": {
        "before": {
            "instance": {
                "process_guid": "bcadd3da-6307-4d12-93db-151c2ebf44f9-f526171a-a3af-41e9-b441-39f40a468a42",
                "index": 3,
                "instance_guid": "15a58566-f0f1-494c-5de4-679a",
                "cell_id": "593fc7d4-f523-4b01-9219-cc28eb5ffdd9",
                "address": "<IP_ADDRESS>",
                "instance_address": "<IP_ADDRESS>",
                "preferred_address": "HOST",
                "crash_count": 0,
                "state": "RUNNING",
                "presence": "ORDINARY",
                ...
            }
        },
        "after": {
            "instance": {
                "process_guid": "bcadd3da-6307-4d12-93db-151c2ebf44f9-f526171a-a3af-41e9-b441-39f40a468a42",
                "index": 3,
                "instance_guid": "15a58566-f0f1-494c-5de4-679a",
                "cell_id": "593fc7d4-f523-4b01-9219-cc28eb5ffdd9",
                "address": "<IP_ADDRESS>",
                "instance_address": "<IP_ADDRESS>",
                "preferred_address": "HOST",
                "crash_count": 0,
                "state": "RUNNING",
                "presence": "ORDINARY",
                ...
            }
        }
    }
}

As it could be observed the address and instance_address fields have changed. The ones from the before section are incorrect and the ones from the after section are correct.
I then inserted debug logs and empirically proved that the state changed events are emitted through the ActualLRPEventCalculator.EmitEvents function and in particular through here (for new events) and here (for deprecated events).
I additionally traced that these changed events happen via calls to the actual_lrp_db.StartActualLRP function which:

fetches the current info from the database.
checks for any changes in the actual-lrp data.
updates the db if changes have been noticed.

If changes have been noticed an event to the respective route-emitter is emitted.
Also every single time there is a changed event the only difference is within the ActualLRPNetInfo (at least according to my debug logs). This aligns perfectly with having the event occur only during database encryption key rotation since it reads the records as blobs and then possibly re-encrypts them leaving the db in an incorrect state. The good thing is that bbs is smart enough to restore its db to a correct state.

Sooo my brain makes me think that it is due to functional dependency anomalies since it turns out that bbs_db is breaking the first normal form by having nested records when inserting/reading ActualLRPNetInfo objects as blobs.

First to reflect the worries of @aminjam regarding the fact that the issue occurs not only when bbs encryption key is being rotated. I totally forgot about that. :smile::gun: I’ve seen it happen only once when there is no bbs encryption key rotation but with much weaker symptoms. It was after a regular diego-api redeploy:
12:48:13 | Updating instance diego-api: diego-api/fe97535c-a45b-4768-a296-ad486c2257fc (0) (canary)
... trimmed for readability ...
12:49:09 | Updating instance diego-api: diego-api/fe97535c-a45b-4768-a296-ad486c2257fc (0) (canary) (00:00:56)
12:49:09 | Updating instance diego-api: diego-api/a44ca6fa-7882-45f1-801e-415595dedaa5 (1)
... trimmed for readability ...
12:50:09 | Updating instance diego-api: diego-api/a44ca6fa-7882-45f1-801e-415595dedaa5 (1)
12:50:09 | L executing post-start: diego-api/a44ca6fa-7882-45f1-801e-415595dedaa5 (1) (00:01:01)

You can see the small burst in the number of registered routes after we switch to the updated diego-api. It is interesting to note out that the spikes reach up only to a value of 1 or 2 (a really small amount) but there is a burst on one third of the route-emitters.

And here we have an actual occurrence from the same environment in the same day when the bbs encryption key had been rotated. I think that it is much more obvious because the spikes reach up to values of 15-20.

So most probably the spikes from 12:50 are something expected whilst the ones from 3:18 obviously aren't. And I’ve been initially confused by the small burst at 12:50 to state that the bug actually occurred then. Sadly all of the logs are now lost and I never had the chance to play around with them.

Secondly the RC lies within the reEncrypt function since it relies on a single attribute as the primary key of the table but a primary key could consist of multiple attributes. Such is the case with the actual_lrps table as listed by postgres:
"actual_lrps_pkey" PRIMARY KEY, btree (process_guid, instance_index, presence)

On the other hand the reEncrypt function is called only with the process_guid as a primary key leaving us with wrong actual_lrps records.

Third but not least I've made a PoC as part of my debugging exercise that fixes the problem. The commit is a bit polluted by debug logs but the fix is there (in the db/sqldb/encryption_db.go module) and I've tested it to work on my dev environment.

I've found an easier way to recreate the problem:
mkdir simple
pushd simple &> /dev/null
    echo "Hi, Diego!" > index.html
    cf push simple -b staticfile_buildpack
    cf scale simple -i 250
popd &> /dev/null

# Provision green BBS encryption key.
# Rotate the BBS encryption key by redeploying CF and applying the green one.

# Observe how the route_emitter.RoutesRegistered and route_emitter.RoutesUnregistered metrics burst
# after the BBS on the diego-api instance with the rotated key becomes active.

I also found an issue with my fix PoC. Will try to fix it ASAP.

I fixed the issue with my PoC. I was having issues with db blob scanning. Hence I had to use a bit of reflection to make the function more generic.
fix commit - https://github.com/IvanHristov98/bbs/commit/50079b237b0c52ca37fca8f7f1e69ab8db2037d3
fix branch - https://github.com/IvanHristov98/bbs/tree/fix-actual-lrp-re-encryption

Thanks for your feedback @mariash! I have a few questions in mind though:

I added a test that exposes this.

What kind of test and where?
Have you began working over a bug fix? If not then my team could provide it. My point here is not to double the effort by working simultaneously over the fix.

Hi Ivan I just pushed a fix to BBS - https://github.com/cloudfoundry/bbs/commit/6cc24b64cc4ec5e7f45743a276ded4d8e9995e88
I could not reproduce it, so I added a unit test that exposes this. I was trying to avoid using the reflect in a fix.
Thank you so much for reporting this! Hopefully this will fix your deployments. Please let us know if the issue persists.


Setting output directory on Synology DSM 7 [YoutubeDL-Material]

Hello. It's my first time of use Youtube-dl started by Docker*.How I can change default folder ( Path: subscriptions  ) to my Downloads? And how I can change audio formats from .mp3 to flac? Thanks
Device based on DSM 7.0.1-42218 Update 2

https://registry.hub.docker.com/r/tzahi12345/youtubedl-material/

Seemingly the GUI doesn't offer that option, so you need to edit the config, read the Linux parts of the readme here on GitHub.

Otherwise, ask at https://github.com/Tzahi12345/YoutubeDL-Material/issues.

If you need more help, reopen the issue.


fixes #12 Enable local plugin config override

Fixes #12

[Current coverage][cc-pull] is 100%

Merging [#13][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #13   diff @@
===================================
  Files          10    10
  Lines         333   333
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits          333   333
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last updated by [a8cf4c9...23e5b67][cc-compare]
[cc-base-branch]: https://codecov.io/gh/kuzzleio/kuzzle-proxy/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/kuzzleio/kuzzle-proxy/compare/a8cf4c9ce33a5a2c614bd334dd18de3bbe03ac14...23e5b67ccc5e2289250516685c9b0c8a5390c577?src=pr
[cc-pull]: https://codecov.io/gh/kuzzleio/kuzzle-proxy/pull/13?src=pr

+1

+1

LGTM


Listener [Not Supported] for Win 10 Pro ver 1803 Build 17134.950

Hi Developers,
My Windows just got updated KB4512501 & KB4507435.
Currently running on Win 10 Pro ver 1803 OS Build 17134.950
Previously running on 17134.706 RDP works fine.

Appended herewith the termsrv.dll and rdpwrap.ini files that currently using:
termsrv.zip
rdpwrap.zip

I think I have similar problem such as yours
I was running Windows 1803 with RDP version 10.0.17763.168 ( which is working )
After recent Windows update I now have RDP version 10.0.17763.437 which is not working. According to RDP it's not listening
However when I open up the rdpwrap.ini version 10.0.17763.437 is supported

Note: this is not a solution to your issue, rather a workaround of sorts
Can you try checking for upgrade to 1903? Did this in my Win 10 Home and it is working

Note: this is not a solution to your issue, rather a workaround of sorts
Can you try checking for upgrade to 1903? Did this in my Win 10 Home and it is working

Thanks pekatete for the sharing.
Well I did, I had another PC on Windows 10 Pro upgraded to 1903 OS Build 18362.295. I had the rdp wrapper ini file updated to exactly like yours.
Yes, it is running like yours but the issue that I'm facing for this version 1903 came from AVG antivirus which constantly turned off (block) my port 80, 443, 3389 eventhough I had manually enabled the remote desktop in the firewall setting. I had tried also uninstalling and reinstall the av then only it back to function for a few hours. Meanwhile, I am still waiting for AVG support to revert to me on their investigation.

and for this current issue, I had uninstall KB4512501 (17134.950) & KB4507435 (17134.885) and reverted back to 17134.1

Same issue after installing patch for KB4512516. Removed the patch and it worked again.

Hello.
Thanks for the effort here. Really nice solution. On 2 workstations i have to use windows. the goal for them is one user locally working and optionaly one remote. Both workstations run same windows.
one accept multiple usersessions, the other one dont. see
screens:

Any one had that before? any ideas on this?
-Stephan

Hi Stephan,
Please post your issue onto the thread https://github.com/stascorp/rdpwrap/issues/864#issuecomment-522485311
With regards,
Kenny Tan

From: Stephan<EMAIL_ADDRESS>Sent: Monday, 19 August, 2019 5:17 PM
To: stascorp/rdpwrap<EMAIL_ADDRESS>Cc: kennydavinci<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [stascorp/rdpwrap] Listener [Not Supported] for Win 10 Pro ver 1803 Build 17134.950 (#864)
Hello.
Thanks for the effort here. Really nice solution. On 2 workstations i have to use windows. the goal for them is one user locally working and optionaly one remote. Both workstations run same windows.
one accept multiple usersessions, the other one dont. see
screens:

[screen_a]https://user-images.githubusercontent.com/47381132/63253600-72d2f900-c272-11e9-9880-11a5699cf8c3.PNG

[screen_b]https://user-images.githubusercontent.com/47381132/63253706-a31a9780-c272-11e9-8355-3196a9193348.PNG

Any one had that before? any ideas on this?
-Stephan
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/stascorp/rdpwrap/issues/864?email_source=notifications&email_token=AM5HS36REOVS7I7FMHIWSNDQFJQLBA5CNFSM4IMD34XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4SH4PY#issuecomment-522485311, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM5HS3YXQSBZESKPGVZF3NTQFJQLBANCNFSM4IMD34XA.

ver.10.0.17134.706
Listener state :Not listening
why?how?

please read issues , you need updates from others , like https://github.com/stascorp/rdpwrap/issues/860

Hi, i have the same issue. I have uninstall the Windows updata as same as you. Now the Windows OS version is 1803(17134.228). The RDPConf ver. is 10.0.17134.1. For this issue, i have two doubts. Can your released two file  work in 17134.1?  Can i only replace the rdpwrap.ini? (termsrv.dll is the native version)


Maestro doesn't work with WSL 2

Followed everything there : https://maestro.mobile.dev/getting-started/installing-maestro/windows
On powershell I have:
C:\Work> adb -a -P 5037 nodaemon server
07-30 15:36:51.787 14820 14216 I adb.exe : auth.cpp:416 adb_auth_init...
07-30 15:36:51.792 14820 14216 I adb.exe : auth.cpp:152 loaded new key from 'C:\Users\Nino\.android\adbkey' with fingerprint <...>
07-30 15:36:51.792 14820  8748 I adb.exe : transport.cpp:338 emulator-5554: read thread spawning
07-30 15:36:51.793 14820 10548 I adb.exe : transport.cpp:310 emulator-5554: write thread spawning
07-30 15:36:51.802 14820 14216 I adb.exe : transport.cpp:1704 fetching keys for transport emulator-5554
07-30 15:36:51.802 14820 14216 I adb.exe : auth.cpp:468 Calling send_auth_response
07-30 15:36:51.820 14820 14216 I adb.exe : adb.cpp:180 emulator-5554: offline

Then on WSL 2 (Ubuntu 22.04), on another tab:
C:\Work> wsl
nino@Desktino:/mnt/c/Work$ adb kill-server
cannot connect to daemon at tcp:5037: Connection refused
nino@Desktino:/mnt/c/Work$ export ADB_SERVER_SOCKET=tcp:<IP_ADDRESS>:5037
nino@Desktino:/mnt/c/Work$ adb devices
List of devices attached
emulator-5554   device

nino@Desktino:/mnt/c/Work$ cd lapresse/rubicon
nino@Desktino:/mnt/c/Work/lapresse/rubicon$ maestro --host <IP_ADDRESS> test -e APP_ID=ca.lapresse.android.lapressemobile.debug flows/run_flow.yaml

------------------ Shard 1 ------------------

Please specify a device platform [android, ios, web]:
android

Please specify Android version [34, 33, 31, 30, 29, 28]: Press ENTER for default (30)

Attempting to create Android emulator: Maestro_Pixel_6_API_30_1

Created Android emulator: Maestro_Pixel_6_API_30_1 (system-images;android-30;google_apis;x86_64)

❌ Error: BlockingCoroutine is cancelling
kotlinx.coroutines.JobCancellationException: BlockingCoroutine is cancelling; job=BlockingCoroutine{Cancelling}@28a65353
Caused by: maestro.cli.CliError: Unable to start device: Maestro_Pixel_6_API_30_1
        at maestro.cli.device.DeviceService.startDevice(DeviceService.kt:74)
        at maestro.cli.command.TestCommand$handleSessions$1$1$results$1$1.invokeSuspend(TestCommand.kt:237)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
        at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:115)
        at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:100)
        at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)

Note :

<IP_ADDRESS> is my local adress (found with ipconfig via Powershell), I don't know what is meant by "Note down the IPV4 address of your Windows host PC/machine." in the tutorial, but I guess this is it.
The test suite is already working on MacOS (they are running the command without the --host param)
I tried with an Android 35 emulator, and then with an Android 30 emulator, to no avail.

Hi @NinoDLC, thanks a lot for this bug report. Could you please adapt it to follow the bug report template? You can create a new issue, paste existing stuff, and fill out fields that are missing. Thank you.

Closing as a very likely duplicate of #1863


The translation of the second option string is incorrect in 'File Changes Detected' dialog

Storage Explorer Version: 1.11.1
Build: 20191212.4
Branch: master
Language: Chinese(zh-CN)
Platform/OS: Windows 10/ Linux Ubuntu 18.04/macOS High Sierra
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Launch Storage Explorer.
Open 'Settings' -> Application (Regional Settings) -> Select '中文(简体)' -> Restart Storage Explorer.
Expand one non-ADLS Gen2 storage account -> Blob Containers.
Create a blob container -> Upload a text file.
Open this file then make some changes -> Save the file.
Check the translation of the second option string in the prompt dialog.

Expect Experience:
The translation of the second option string is correct.
Like: （创建原始blob的快照然后上传）
Actual Experience:
The translation of the second option string is incorrect.

More Info:

It is better to translate Upload to '上传' instead of '上载' in zh-CN.

ENU screenshot.

zh-TW screenshot.

On review.
File: loc\en\src\components\se-blob-extension\resources\BlobEditor.json
ID: 0; "OptionFileWatcherSnapshotUpload"
SRC: Snapshot original blob then upload
TGT: 然后上载快照原始 blob
File: loc\en\src\components\se-blob-extension\resources\BlobEditor.json
ID: 0; "OptionFileWatcherUpload"
SRC: Upload
TGT: 上载

Fixed.
SRC: Snapshot original blob then upload
New TGT: 然后上传快照原始 blob
SRC: Upload
New TGT: 上传

@lukaschal
Translate the option 'Snapshot original blob then upload' to '创建原始blob的快照然后上传' would be better.

On review.
File: loc\en\src\components\se-blob-extension\resources\BlobEditor.json
ID: 0; "OptionFileWatcherSnapshotUpload"
SRC: Snapshot original blob then upload
TGT: 然后上传快照原始 blob

Fixed.
new tgt: 创建原始 blob 的快照然后上传

@lukaschal
This issue still reproduces on build 20200226.4.

This has been fixed and verified in build 20200228.1.  Here is a screenshot:

Feel free to close.

@jinglouMSFT Thank you very much for helping to verify this bug. We will close it.


plugin: corrected support for basic actions for ardupilot

At the moment, takeoff action for APM does not work at all with MAVSDK since takeoff command can only be executed with the flight mode Guided for APM. Arming works sometime but does not work after landing is completed.
Following the work from https://github.com/mavlink/MAVSDK/pull/1703, this pull request tries to correct the broken actions (takeoff and arming) for Ardupilot.
Following are the changes made:

Arming for Ardupilot(Copter 4.1.2) can be done only in specific flight modes: Hold, Stabilized and Offboard. To keep compatibility with PX4 and MAVSDK, Hold mode is selected for arming of the copter.
Takeoff can only be done in Offboard mode, hence a function specific to apm takeoff is implemented to take care of this.
Flight mode conversion between Arducopter and MAVSDK is also updated.
Integration tests are added/updated for mission raw and action hover. This way 7 more integration tests for APM will run now in addition to the 5 previously.

Looking forward to get reviews :)

@ykhedar I really appreciate your work here. I hope to get to it soon. That being said I also have a couple of refactoring changes in a local branch related to this, that will heavily conflict. I will have to resolve the conflicts.

@julianoes you mentioned before that you are working on a local branch which might conflict with this PR. Is that still the case? I did a rebase to the current main branch and resolved some conflicts thus arising.

Is the CI failure related to this PR?

Not really. Randomly one or two of the tests fail because the health_all_ok is not true. I did some digging and found its mostly because the home position not received/set. I did a test locally by making the home position request to retry every 2 seconds until home position is received something like this:
_parent->add_call_every([this]() { request_home_position_again(); }, 2.0f, &_call_every_cookie);
The change seems to make the integration tests pass (at least for the 10 times i tested locally.)
I was thinking making that another PR since was not related to this PR. If you disagree i can commit the changes to this PR


Does Nodemailer support retries?

Is there any built-in way to retry failed sends?

Retries are only used with using direct-transport module. If you send a message to your own MTA and it fails, it should be your own responsibility to see what is wrong and what should be done.


Provide complete documentation on APIs

I will like to work on this, can you assign me?

Sorry but I think I should do this by myself at this point.

Ok


Autocompletion broke after 2nd degree member

Godot version
4.0.3 stable
System information
Windows 10
Issue description
Something is breaking the autocompletion when I used 2nd degree or more member of a variable.
Here's an exemple:
class_name MyClassA extends Node2D

func get_num():
	return 1

var classB : MyClassB

func _ready() -> void:
	Global.classA = self

	pass

And
class_name MyClassB extends Node2D

var classA : MyClassA

# Called when the node enters the scene tree for the first time.
func _ready() -> void:
	classA.classB.classA.get_num()
	pass

If you rename get_num to get_numb for exemple, the autocompletion in MyClassB will continue to show get_num (and CTRL+Click to it will refer to get.num), and I need to reload all the project because all future autocompletion will be outdated (like it stopped to update)
By the way, maybe it's related to https://github.com/godotengine/godot/issues/78003
I tested with the 4.1Beta, it still present
(First issue, I hope it's complete enough 😄)
Steps to reproduce

Download the sample project
Rename get_num to get_numb (or something else) in MyClassA
Try to autocomplete in MyClassB script after classA.classB.classA.

Minimal reproduction project
Issue.zip

Could you test the latest builds of Godot 4.1 (beta 3 at the time of writing) and compare?

Just tried with the Godot 4.1 RC 1, and it's still there

I confirm that the issue is still there in Godot 4.1.1 stable.

Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; <IP_ADDRESS>13) - AMD Ryzen 5 5500 (12 Threads))

class_name Foo extends Node

func bar() -> int:
    return 5

class_name Mob extends Node

@onready var foo: Foo = get_node("Foo")

func _process(_delta):
    foo.bar() // autocomplete succeeds

extends Node

@onready var mob: Mob = get_node("Mob")

func _ready():
	mob.foo.bar() // autocomplete fails

Did further testing, it looks like autocompletion works for members of the base class (e.g. Node2D), just not for custom members of the child class.

Similarly, Ctrl+click won't work at all.
I tried VS Code + GDScript plugin as a workaround, but it doesn't work either - I suspect because the language server asks Godot for autocompletion, but Godot has the bug so it propagates to VS Code.

Having the same problem. Did anyone find a solution?

Looking at this I think it is not quite clear which issue we are talking about. The OP looks like a reload problem with Cyclic references.

I confirm that the issue is still there in Godot 4.1.1 stable.

Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; <IP_ADDRESS>13) - AMD Ryzen 5 5500 (12 Threads))

class_name Foo extends Node

func bar() -> int:
    return 5

class_name Mob extends Node

@onready var foo: Foo = get_node("Foo")

func _ready():
    foo.bar() // autocomplete succeeds

extends Node

@onready var mob: Mob = get_node("Mob")

func _ready():
    mob.foo.bar() // autocomplete fails

This is a different setup without cyclic references.
Please try substituting @onready var mob: Mob = get_node("Mob") with @onready var mob: Mob = get_node("Mob") as Mob. (Same for Foo). If this solves the problem you are actually looking at #73638.
If this does not solve your problem please provide a MRP with your setup.

I think I'm running into this quite a bit, I'm running on a modified version of 4.3dev3 and was wondering if something I did in my modifications was causing the behavior but after looking at this and other similar issues it seems to be a known issue. I find myself restarting the editor a lot when coding. If I'm mostly in the same file it's fine, but the moment I need to edit a file that's referenced by a lot of others, I ran into the issue and have to restart.
Since the restart seems to fix it I guess a possible solution would be some sort of "clean and rebuild autocomplete cache" or something? Perhaps adding a button to the GDScript "File menu" similar to the existing "Soft Reload Tool Script" but a "Rebuild Autocompletion Cache" button? (When I was trying to find solutions that was one of the first things/places I looked)

I'm not 100% certain if cyclic reference per se causes the autocomplete break. I've had cyclic references in my v4.2.stable.official [46dc27791] version and the autocomplete was working fine until I copy-pasted some code into the project.
The code causes an error, I immediately commented the whole thing but the autocomplete is irrevocably broken after that. It's really frustrating. This bug has been around since 4.0 iirc. (Probably unrelated: enums doesn't autocomplete if it's in a match block or if invoked from an instance instead of the class name.)

I think I'm running into this quite a bit, I'm running on a modified version of 4.3dev3 and was wondering if something I did in my modifications was causing the behavior but after looking at this and other similar issues it seems to be a known issue. I find myself restarting the editor a lot when coding. If I'm mostly in the same file it's fine, but the moment I need to edit a file that's referenced by a lot of others, I ran into the issue and have to restart.
Since the restart seems to fix it I guess a possible solution would be some sort of "clean and rebuild autocomplete cache" or something? Perhaps adding a button to the GDScript "File menu" similar to the existing "Soft Reload Tool Script" but a "Rebuild Autocompletion Cache" button? (When I was trying to find solutions that was one of the first things/places I looked)

I'm not sure if rebuilding the cache matters, I tried deleting and regenerating the .godot folder which contains all cache files but autocompletion remains broken

CC @godotengine/gdscript
Given the last description, I think this might relate to other issues we've had where cached scripts seem to be out of sync with the files on disk and lead to weird errors.

Another thing I've noticed: static functions does not seem affected by broken auto-completes. That is to say, autocompletes that wouldn't work in the body of func will work in the body of static func and newly added static func will appear in other scripts whereas newly added func wouldn't

I tried to reproduce on master using the scripts that have no cyclic reference, and wasn't able to.
Using the mrp from the original issue which has cyclic references, I was able to.
When auto completion shows old names, outdated class types are set by the analyzer. This happens because the new parser created by code_completion is not part of the GDScriptCache, so when the analyzer encounters the same type which is currently completed on, it will use an old parser ref from the script, which might still have some old class types, depending on the idle parse time (I could only reproduce when being fast enough, and also needed some tries before it happened). Invalidating the gdscript cache for the current script when autocompleting could probably solve this issue.
On a different note, with #84266 I wasn't able to reproduce even with the cyclic references, I suppose it forces an update on the cache. This isn't the correct fix for this issue though.
Also the bug I found here, does not really fit all users who reported on having this problem in this thread. There have been some fixes with GDScript caching so I could imagine, that some more grave issues were already fixed by them. Did anyone with the problem give it a try with the last dev build?

Another thing I've noticed: static functions does not seem affected by broken auto-completes. That is to say, autocompletes that wouldn't work in the body of func will work in the body of static func and newly added static func will appear in other scripts whereas newly added func wouldn't

Update: this also breaks after adding enough things to the project. I get the feeling now that the autocomplete breaking is not a matter of quality but a matter of quantity. i.e.: when there are too many things to autocomplete, the autocompletion deteriorates, starting with "vulnerable" things like classes with cyclic references then eventually affecting even less vulnerable things like static functions

I feel like now I have a new version of this issue, which now spawns a new error.
In general, I feel like the issue has been mostly solved, the autocompletion seems to be way more resilient to code changes and in places where they would often break before it stays working just fine in 4.3beta1.
But every once in a while I noticed I would get errors like this spammed in the output:
USER ERROR: Parser bug: Mismatched external parser.

The error message doesn't tell me much, so I went digging around. The error was coming from this method in gdscript_analyzer.cpp:
void GDScriptAnalyzer::resolve_class_member(GDScriptParser::ClassNode *p_class, int p_index, const GDScriptParser::Node *p_source) {

		ERR_FAIL_COND_MSG(!parser_ref->get_parser()->has_class(p_class), R"(Parser bug: Mismatched external parser.)");

So I added these before it to catch some more information:
if (!parser_ref->get_parser()->has_class(p_class)) {
			if (p_class == nullptr) {
				push_error(vformat(R"(Parser did not have class NULLPTR script "%s" member "%s")",script_path,member.get_name()),p_source);
			} else {
				push_error(vformat(R"(Parser did not have class %s script "%s" member "%s")",p_class->get_global_name(), script_path,member.get_name()),p_source);
			}
		}

I think it would be good in general to include some more information in that error.
It took a while to happen in the editor again, but in the meantime it popped up in a build for me.
USER ERROR: Parser bug: Mismatched external parser.
   at: GDScriptAnalyzer::resolve_class_member (modules\gdscript\gdscript_analyzer.cpp:916)
USER SCRIPT ERROR: Parse Error: Parser did not have class Skill script "res://resources/skill.gd" member "found_button"
   at: GDScript::reload (res://resources/skill.gd:100)
USER SCRIPT ERROR: Parse Error: Parser did not have class Skill script "res://resources/skill.gd" member "relevant_button_ui"
   at: GDScript::reload (res://resources/skill.gd:103)

The code in question was this, which was in the Skill class, referencing a member in the Skill class itself, but iterating over an Array[Skill] that was in another class:
	for skill in p.current_skills:
		if skill.found_button:
				continue
		skill.button_desired = "skill_"+str(non_ult_non_mov_skill_count+1)
		skill.relevant_button_ui.texture = App.skill_glyphs[non_ult_non_mov_skill_count]
			non_ult_non_mov_skill_count+= 1
		skill.found_button=true

That error was present every time I built, that one was pretty reproducible. I tried building an MRP trying to do a similar thing but I couldn't get an MRP to reproduce the same error.
I noticed I had not typecasted skill in the for loop. Typecasting it instantly made the error go away on builds.
I'm not sure why the error on builds happened, but this script used to be fine when I was using a previous 4.3dev so I'm assuming some sort of regression.
Now back to the editor, took a while but the same USER ERROR: Parser bug: Mismatched external parser. came back.

In this case the script (the one in game_syncer) was valid, then I edited it became invalid, I fixed whatever error made it invalid but the fix is not taken into account in other scripts that reference it maybe? Restarting the editor makes the error go away and the parser recognizes the member just fine. This made me think that it's related to this issue with cyclic reference.
Should I start a new issue or is this still related to the same issue? So far it seems to happen way more rarely than the original issue, and I can't seem to make an MRP for it as it happens semi-randomly while working. I'm also running a custom build with custom modules so I can't 100% say it isn't related to my  own custom code.

@godotengine/bugsquad Can we please close this issue?
As per the comment of @dandeliondino the original issue seems to be not a problem anymore. The other problems/issues mentioned in this thread require different conditions than the original report and should be their own issue with an MRP. The way it currently is, it's just not possible to reproduce, work on or keep track of any of them.
@DanielSnd please create a new issue including an MRP if this issue is still present with 4.3.beta3. Same to all other users who encountered loosely related problems. (This issue is about cyclic references and outdated members. Anything else belongs in an own report.)

Closing the issue as the MRP behaves as it should on v4.3.beta.custom_build [26d1577f3] (latest master).


Use --fix instead of -t applyFixes

PR checklist

[x] Addresses an existing issue: closes #1684
[x] New feature, bugfix, or enhancement

[x] Includes tests

[x] Documentation update

What changes did you make?
When fixes are applied, they are applied first. If a rule triggers a fix, the AST is reloaded to prevent one fix from overwriting another fix. When all fixes are complete, the sourceFile is linted again if there were fixes. That way, we don't show errors that are already fixed and the positions will be correct.
here's what it looks like when using the prose formatter (the only formatter to output that there are fixes) when there is 1 issue fix and 1 remaining issue that can't be fixed:
Fixed 1 error(s) in ../a.ts

../a.ts[6, 1]: Exceeds maximum line length of 140

@adidahiya made changes

heads up @alexeagle


turn on sample filtering

Summary

What: Turn on sample filtering
Env: https://samplefiltering-frontend.dev.czgenepi.org/
Design: https://www.figma.com/file/nGRxk2lhJoWoiPSnM0GY8g/Self-Serve-Tree-V4---Sample-Filtering?node-id=2667%3A183591

Testing
Already tested and design reviewed.
Checklist

[x] I merged latest trunk
[x] I manually verified the change
[x] I added labels to my PR
[x] I either asked design for a review or hid my changes behind a feature flag
[ ] I tested in multiple browsers
[ ] I added relevant unit tests
[ ] I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

I was building trees on staging and saw this so I poked around. Looks great 🤩 🤩 🤩

ThisLearn More here should link out to: https://docs.google.com/document/d/1_iQgwl3hn_pjlZLX-n0alUbbhgSPZvpW_0620Hk_kB4/edit?usp=sharing

(Nice to have) Can we sort the lineages the same way as the lineage filter in sample table view?

All others look great!! Thanks Maya <3

@danrlu

ThisLearn More here should link out to: https://docs.google.com/document/d/1_iQgwl3hn_pjlZLX-n0alUbbhgSPZvpW_0620Hk_kB4/edit?usp=sharing

Wait, really? That seems surprising to me. That "Learn More" link currently in the tooltip just above the filtering dropdowns goes to the Google Doc that specifies how the "Customized Tree Builds" (Sample Filtering) works. https://docs.google.com/document/d/1NhDW42YZQ7DMhPhUOIBWp04n51FO8GItCZPaw7hRtQk
The link you put in the note goes to the general "Phylogenetic Tree Building Guide", which is the same as the link we curently have in the "Read our guide to learn more" tooltip next to the Tree Type selection. https://docs.google.com/document/d/1_iQgwl3hn_pjlZLX-n0alUbbhgSPZvpW_0620Hk_kB4

The link locations as they currently are in the rdev seem correct to me.

(Nice to have) Can we sort the lineages (the same way as the lineage filter in sample table view)?

I don't know if it matters, but when I set this up, I didn't touch the order at all for the lineages in the new Sample Filtering section, so -- I'm pretty sure -- they wind up coming in the same order they are presented in the lineage_notes.txt over in cov-lineages, which -- I'm pretty sure again -- winds up matching the order on the website version of that list they host. I don't know if that provides any value, but wanted to point it out just in case that actually is useful at all.

Sorry for the confusion! This is the doc that will get copied over to the link I suggested above together with feature release. That specific tooltip should like out to the lineage/date filter section of this file but we won't have its URL until it's copied over, so I'll further update it after the feature release (very good point in reminding me this, thanks Vincent!)
For lineages, I looked around and I don't think they sorted it in a meaningful way (but good precautions). It's good if we could sort it on our end, but this is good to have, not a must have!
Thanks very much!

🎉 🎉 🎉


Feature/76/dynatraceslosupport

work in progress

closing #112 - you can now have SLIs on every level (service, stage & project) and they are correctly "merged/inherited" as described in the doc
closing #109 - Dynatrace API Responses are now better handled. When unexpected errors happen they will be logged correctly instead of resulting in a parsing error
closing #97 - Now supporting native Dynatrace SLO definitions for both dashboard parsing as well as introducing a query option in sli.yaml
closing #104  - will now include better logging which includes the actual query string that was sent to the dynatrace metrics api
closing #105 - will now produce a logoutput in case we default to one of the 4 core SLIs (error_rate, p90, ...)


The querystring package is deprecated

Laravel Mix Version: 6.0.43
Node Version (node -v): 17.8.0
NPM Version (npm -v): 8.5.5
OS: Windows 11

Description:
When installing Laravel Mix, the following message appears (due to the use of node-libs-browser, which is also deprecated):
npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
Steps To Reproduce:
npm install laravel-mix

same problem

after doing an npm update on my project laravel 9.11 and laravel mix 6.0.43 the same warning...

Same issue here! More info:
  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └─┬<EMAIL_ADDRESS>        └──<EMAIL_ADDRESS>
npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

Same problem. Only works on mac, windows clients not working when you use multiple query strings from a useForm object from inertiajs, and then execute  frmFilter.get( route('route.name') ), no errors, no warnings. Any idea?

Issue is still active.

Just found a solution for me:

Install the querystring-es3 package

npm install querystring-es3

Add the resolve to the config file (webpack.min.js)

mix.webpackConfig({
    "resolve": {
        "fallback": { "querystring": require.resolve("querystring-es3")}
    }
})


Muting one VlcPlayer object mutes all

I have an issue about Vlc.DotNet.
Generic information

Vlc.DotNet version : 3.0.0-develop333
Vlc.DotNet project used : WinForms & Core
libvlc version : 3.0.4 (x86) downloaded
.net version : 4.6.2
Project language : C#
Project build architecture : AnyCPU (prefer 32bits)
Operating system : Windows 10 x64

Summary
I am using 3 individual VlcPlayer objects.
Two of them are .DotNet.Forms.VlcControl instances, and the third is a .Core.VlcPlayer instance.
When calling myVlcPlayer1.Audio.ToggleMute(); on one of the instances, all three toggles the mute so all three is either muted or not muted.
I am unsure how confirm that my issue doesn't happen in VLC itself.

This is a known issue of libvlc itself (it happens on libvlcsharp too). if you could share a sample code to reproduce the issue, that would help us

Oh, ok. Is there any way around it @jeremyVignelles  ?
I could of course put together a simple C# forms application with two players and a mute button, but I am unsure how much use you would have of it if this is a known issue.

maybe setting the volume to 0?
This is a known issue by me, but so far, I never found the time to report that to VLC.

setting the volume produces the same result. Tried that already.
I tried to set the parameter to "-an" when loading the media via
MyVlcControl.SetMedia(myFileInfo,  new string[] {"-an"});
which theoretically should disable the audio altogether, but that didnt work either :-(

It seem a bug of LibVlc 3.0
You can see this thread https://forum.videolan.org/viewtopic.php?t=147229
If you have multiple player in your application, set volume of one of those, and volume of all player will be changed, so, if you set some diff for your players, it will case some conflict.
In this thread, he said set ‘--aout=directsound’ to vlc can solve it, I have tried it, it works.

@devkanro  thank you for your info. I would like to test it, but can't figure out how to set that flag in Vlc.DotNet.Core. I tried to use it as a flag with VlcControl.SetMedia(myfile, " --aout=directsound "), but that didn't do anything. Any help is appreciated

@perkalkyl : -- options are meant to be set at libvlc initialization, that is, you need to set them in VlcMediaPlayerOptions before EndInit

@jeremyVignelles thank you for your info and very fast response. I have to do some readup on where to do what :-D
I am very happy, cause it seems to work @devkanro !! Setting the flag in VlcMediaPlayerOptions as you suggested, I can now turn that particular play to mute without affecting the other players.
Thank you very much for your info guys!


Upgrade to Go 1.18 as target, 1.19 as latest

Description
Upgrading our "target" and "latest" go to 1.18/1.19 respectively, allowing us to use generics and up-to-date golangci-lint (which only supports 1.18+ rn).
This includes the golangci-lint update from #159, as the old version just goes OOM on Go 1.19 (https://github.com/golangci/golangci-lint/issues/731) - as I found out the annoying, very monday way of having to force-reboot my laptop...
Checklist

[x] added release notes to Unreleased section in CHANGELOG.md, if user facing change

References

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Should we also update the go version in go.mod?

yes, thanks - updated :)


qpdf error "file is damaged" for pdf saved by Excel

WARNING: C:\pdftemp\018.pdf (xref stream: object 17 1, offset 110340): EOF while reading token
WARNING: C:\pdftemp\018.pdf (xref stream: object 17 1, offset 110830): unexpected EOF
WARNING: C:\pdftemp\018.pdf (xref stream: object 17 1, offset 110830): parse error while reading object
WARNING: C:\pdftemp\018.pdf (xref stream: object 17 1, offset 110830): expected endobj
WARNING: C:\pdftemp\018.pdf: file is damaged
WARNING: C:\pdftemp\018.pdf (offset 110267): xref not found
WARNING: C:\pdftemp\018.pdf: Attempting to reconstruct cross-reference table
qpdf: C:\pdftemp\018.pdf: unable to find trailer dictionary while recovering damaged file
When I use qpdf to merge pdf files, the error above shows the file is damaged. However, this pdf is saved by Excel and works fine. The pdf is attached.
Could you please fix this problem?
Thanks
018.pdf

I acknowledge that there is a bug in qpdf's tokenizer that is affecting this file. I will provide a fix.

@m-holger I believe you introduced this bug when reworking the tokenizer. qpdf 10.6.3 parses this file correctly.

The bug is that this file has the character \35, which is valid per the spec, but the current tokenizer requires exactly 3 digits after the \ rather than at most 3 as stated in the spec.

I am working on a fix now.

This was a serious bug. I intend to release 11.6.3 this weekend with a fix. Thanks for the report.

@shawn8888 11.6.3 is out if you'd like to test.

@jberkenbilt
I can confirm the bug is fixed!
Thanks a lot for your support!


undefined local variable or method "event"

I've introduced a bug in my last PR due to a bad merge on my local branches.
NameError: undefined local variable or method `event' for #<LogStash::Outputs::Stomp:0xaf2d433>
         multi_receive at /usr/local/Cellar/logstash/2.3.2/vendor/bundle/jruby/1.9/gems/logstash-output-stomp-2.0.5/lib/logstash/outputs/stomp.rb:78
                  each at org/jruby/RubyHash.java:1342
         multi_receive at /usr/local/Cellar/logstash/2.3.2/vendor/bundle/jruby/1.9/gems/logstash-output-stomp-2.0.5/lib/logstash/outputs/stomp.rb:77
  worker_multi_receive at /usr/local/Cellar/logstash/2.3.2/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.2-java/lib/logstash/output_delegator.rb:130
         multi_receive at /usr/local/Cellar/logstash/2.3.2/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.2-java/lib/logstash/output_delegator.rb:114
          output_batch at /usr/local/Cellar/logstash/2.3.2/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.2-java/lib/logstash/pipeline.rb:301
                  each at org/jruby/RubyHash.java:1342
          output_batch at /usr/local/Cellar/logstash/2.3.2/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.2-java/lib/logstash/pipeline.rb:301
           worker_loop at /usr/local/Cellar/logstash/2.3.2/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.2-java/lib/logstash/pipeline.rb:232
         start_workers at /usr/local/Cellar/logstash/2.3.2/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.2-java/lib/logstash/pipeline.rb:201

@ph is there any chance to get this one merged? Thanks much

Thanks for the ping @consulthys  really appreciated! I've merged the PR and published 3.0.3 that contains your changes!

Awesome, thank you @ph !!


Fix for Userforms 3.x

Something has changed in the object flow in the current Framework 3.2 / UserForms 3.x combination.
$this inside the HoneypotField object during validation now contains no references to the current controller. $this->value is null and before that this line (26) baulks:
$timestamp = $this->getForm()->getController()->getRequest()->postVar($this->getName() . '_Timestamp');
I propose a change thus:
       $honeypot = \Controller::curr()->getRequest()->postVar($this->getName());
       $timestamp = \Controller::curr()->getRequest()->postVar($this->getName() . '_Timestamp');

L42      if (!empty($honeypot) || ($timeLimit > 0 && ($timestamp + $timeLimit) > time())) {
This change makes UserForms 3 work. YMMV. Note that any error messages displayed are not the ones created here. This is down to Userforms and I will try to fix it.

Hi @tazzydemon thanks for the issue report. This seems like it might actually be a bug with Userforms bypassing the validation method? Although your suggestion works around the issue you've highlighted it bypasses FormField::setValue() which could cause unexpected behaviour in other integrations, what do you think?

I was about to deploy as it seemed close to stable but the latest change to UserForms has chucked the baby out with the bathwater so to speak. I think that my modifications are still valid - the problem now is that the entire method of validation may (probably will) need a rework so I'm hanging fire.

Is Honeypot still not working in the latest Userforms?

Well my one is if you want a copy!
From: James Cocker<EMAIL_ADDRESS>Sent: Wednesday, 28 March 2018 11:00 PM
To: studiobonito/silverstripe-spamprotection-honeypot<EMAIL_ADDRESS>Cc: tazzydemon<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [studiobonito/silverstripe-spamprotection-honeypot] Fix for Userforms 3.x (#2)
Is Honeypot still not working in the latest Userforms?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/studiobonito/silverstripe-spamprotection-honeypot/issues/2#issuecomment-376831114 , or mute the thread https://github.com/notifications/unsubscribe-auth/ABeowr-6eGGvFZQDhFEY51DHq4W9EqMJks5ti18mgaJpZM4GuZ5K .  https://github.com/notifications/beacon/ABeowice_T_jrz5E3RpBP40zhfOtsZPcks5ti18mgaJpZM4GuZ5K.gif

This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Please! :) Can't seem to see a fork in your account.


Improve createTestContext in debugger

Replace mockOutPoint with real life OutPoint in testnet/mainnet. For well known scripts, they are always the same and can be hard coded.

It's a cool idea. For Lumos to achieve this, we'll need to change the hash_type to type in createTestContext.
However, I must admit that things are a bit hectic over here at the moment, so we might not be able to implement it as soon as we'd like.

Improve it if you have time. It's not an urgent feature.
My initial requirement is to make it possible to dump transaction before going to p2p network. For transactions already confirmed, we have ckb-transaction-dumper. But for these failed transactions, currently, we don't have any tool.


Packager error upgrading to 0.21 from 0.20

Upgrading from 0.20 to 0.21 causes an error in the packager. The project builds fine, but when the packager launches, it gives an error
[3:05:34 PM] <END>   Building (deprecated) Asset Map (431ms)
Failed to build DependencyGraph: ENOENT: no such file or directory, open '/Users/agh/dev/schoolapp/mobile/SchoolApp/node_modules/react-native/ReactAndroid/src/androidTest/assets/ScrollViewTestModule.js'
Error: ENOENT: no such file or directory, open '/Users/agh/dev/schoolapp/mobile/SchoolApp/node_modules/react-native/ReactAndroid/src/androidTest/assets/ScrollViewTestModule.js'
    at Error (native)
~
Process terminated. Press <enter> to close the window

It might have something to do with the change in directory structure.
in 0.20
ls node_modules/react-native/
LICENSE       Libraries     PATENTS       README.md     React         React.podspec ReactAndroid  cli.js        jestSupport   local-cli     package.json  packager

in 0.21
ls node_modules/react-native
LICENSE       Libraries     PATENTS       README.md     React         React.podspec android       cli.js        jestSupport   local-cli     package.json  packager

Is there a workaround ?

@arunabha It appears that the ReactAndroid folder is not being copied when you upgrade.
This is from some recent changes to the Android build process.
A update has already been pushed here.
https://github.com/facebook/react-native/commit/403176ae9332fb7c8beac339dd41cbb067f995fd
You can either update react natives package.json and run npm install again, or just copy the the directory  over manually.
That should get things working again. Feel free to re-open the issue if the problem persists.


Update Glossary for Developer Guide (DG)

Child issue of #13
Glossary: Define terms that are worth recording.

Will finish this after the rest of the Developer Guide is finalised.


chore: migrate to travis-ci.com

Pull Request Test Coverage Report for Build 94

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.119%

Totals

Change from base Build 92:
0.0%

Covered Lines:
236

Relevant Lines:
243

💛  - Coveralls


Download should be incremented as soon as you click on downloads

@ddey2
I am testing this for datasets and files.
With datasets, when I click the download button the download increments, but the dataset did not download. This happens both on the regular dataset view and the public dataset view.

this is fixed. @tcnichol @longshuicy feel free to take a look

Tested.
From the dataset page, every click of download increments. Same for files.
If I download datasets from 'explore' download also increments. Same with downloading files from the filelist.
Marking this one approved.


Add Angular.js interactive tutorial

Could you please move this link to the course file?

The conflicts arise from his fork, it´s pretty behind the normal file (exactly 558 commits). I try to check some old PR and work over them (somehow)


Resource not found: The following package was not found in : Pa

Resource not found: The following package was not found in : Pa

map.world file is present in this repository, you have to copy it to the catkin workspace you created.
I have given detailed steps in README.md, kindly follow that.

Excuse me, I follow the steps, and have the same problem.
the error said
Resource not found: The following package was not found in : PathPlanning-for-DifferentialDriveRobot
ROS path [0]=/opt/ros/noetic/share/ros
ROS path [1]=/home/harvey/catkin_ws/src
ROS path [2]=/opt/ros/noetic/share
The traceback for the exception was written to the log file


configurable robots settings

problem:
an unlisted homepage gets a meta name="robots" content="none" tag.
possible solution:
configurable robots settings to impede this behavior.

added in 9191998f1bb6736d30af69ac492613388b601dc3, coming next release


Checkbox are display at the bottom of the window

When using store_true arguments, the Checkbox widget is created at the very bottom of the
configuration window, not following the order of creation as the other widgets.

Umm, taking a look at component_builder.py, it seems that this is made on purpose: checkbox_args are separated from the rest of the optional_args and added at the end...
Is there a reason for this?
Thanks

Yup. Pretty simple reason: I thought it was ugly to mix 'em.
However, this is now configurable! Mingling widget types are now covered. It's controlled via the group_by_type flag on the Gooey decorator.

@Gooey(dump_build_config=True, program_name="Widget Demo", group_by_type=False)
def main():
  my_cool_parser = ArgumentParser(description=desc)
  ...
  # your options here


Hot Question message not appearing

I can't seem to get the hot question message to appear. From the testing I've done, it seems that nothing in preprocess is being run. The rest of the .feeds() call works fine, but nothing I add to preprocess takes any effect, not sure why.

@SnoringFrog I will look into this -- but I'm away for the next 3 days and might not have time during the week -- but at the latest, I'll look at it by next weekend! :)

Gotcha. No rush (for me at least). It's probably one of the more minimal features, but I figured you'd want to know about the bug regardless. I tried looking into it some but couldn't make any headway on it.

Very weird... It seems onComplete: function() or preprocess: function() are just ignored.
I get the error jQuery21409325341042131186_1443266418820 is not defined because the response starts with /* callback */jQuery214013556369650177658_1443266447976({"responseData" .... }):.

btw @SnoringFrog SOOF is now SOX, and has moved to https://github.com/soscripted/sox. This feature is under consideration - we may remove it.
@Loxos and @nwinkler, you may also be interested in knowing that SOOF is now SOX, at https://github.com/soscripted/sox!! :)


Raise an error if repo used in image meta is undefined

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6089260). Click here to learn what that means.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master     #267   +/-   ##
=========================================
  Coverage          ?   27.31%
=========================================
  Files             ?       30
  Lines             ?     6392
  Branches          ?     1290
=========================================
  Hits              ?     1746
  Misses            ?     4586
  Partials          ?       60

Impacted Files
Coverage Δ

doozerlib/repos.py
42.70% <0.00%> (ø)

doozerlib/cli/__main__.py
0.00% <0.00%> (ø)

doozerlib/dotconfig.py
21.42% <0.00%> (ø)

doozerlib/cli/cli_opts.py
81.25% <0.00%> (ø)

doozerlib/olm/bundle.py
0.00% <0.00%> (ø)

doozerlib/embargo_detector.py
84.78% <0.00%> (ø)

doozerlib/cli/release_gen_payload.py
0.00% <0.00%> (ø)

doozerlib/brew.py
40.16% <0.00%> (ø)

doozerlib/source_modifications.py
68.29% <0.00%> (ø)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6089260...63dbd87. Read the comment docs.


Load all Cell

how to load all cells

await sheet.loadCells(); let cell = sheet.getCell(0, 0) cell.value = 1
sheet.loadCells(); will return undefined. But it will load the cells.


Passing UniformLocation by reference

In order to avoid cloning when updating uniform variables I suggest use references, like so:
   // wasm
    unsafe fn uniform_1_i32(&self, uniform_location: Option<&Self::UniformLocation>, x: i32) {
        match self.raw {
            RawRenderingContext::WebGL1(ref gl) => gl.uniform1i(uniform_location, x),
            RawRenderingContext::WebGL2(ref gl) => gl.uniform1i(uniform_location, x),
        }
    }

   // native
    unsafe fn uniform_1_i32(&self, location: Option<&Self::UniformLocation>, x: i32) {
        let gl = &self.raw;
        gl.Uniform1i(*location.unwrap_or(&0) as i32, x);
    }

Sounds good to me, could you submit a PR with this change (for all uniform_ functions)?

Okay

Fine!


Closes: #1

Fixed the behavior of validate_user function in
modified:   validations.py
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Closes: #`


Allow not escaping string (the :l flag on {Message}) (or allow setting the output template)

(Related to #117, but this issue has another focus.)
As you are probably aware, Serilog allows setting custom output templates. The {Message} token supports a flag :l that turns off quoting of strings.
I am able to configure the output template for all my sinks except Serilog.Sinks.ApplicationInsights. It seems that Serilog.Sinks.ApplicationInsights does not use the :l flag, because when my message template contains a JSON string, it is escaped.
My message template is this:
Log.Debug("Operation {OpName}\n{InteractionData}", opName, json)

My wish is to have a rendered message that looks like this:
Operation User.byId
{
  "Input": {
    "UserId": 10036
  },
  "Output": null
}

Here is how the message looks in AI:

If I view just the telemetry property corresponding to the JSON in AI, it looks even worse:

This looks similar to how the console sink looks when just using {Message} (no :l flag):

Whereas if I specify {Message:l} in the output template for the console sink, it looks just like I want it to:

My guess is that if Serilog.Sinks.ApplicationInsights were to allow setting a custom output template, and I then use {Message:l}, then the message and/or the property in AI would look properly formatted, as shown in the last console image above.

@cmeeren I faced with the same issue. Did you find any solution to the case?

Nope, no solution.

I solved my issue with using custom TraceTelemetry and would like to share it here, which may help someone in the future! 🎉
Checked the broken property key and if it has. I can replace the unwished chars with string.Empty
Code talks;
public class AybTelemetryConverter : TraceTelemetryConverter
{
    public override IEnumerable<ITelemetry> Convert(LogEvent logEvent, IFormatProvider formatProvider)
    {
        foreach (var telemetry in base.Convert(logEvent, formatProvider))
        {
            ISupportProperties propTelematry = (ISupportProperties)telemetry;

            if (propTelematry.Properties.Any(x => x.Key == "response_body"))
            {
                var value = Regex.Replace(propTelematry.Properties["response_body"], @"\t|\n|\r", "").Replace("\\","");
                if (value.Length < 8192)
                {
                    propTelematry.Properties.Add("ResponseBody", value);
                }
                propTelematry.Properties.Remove("response_body");
            }
            yield return telemetry;
        }
    }
}

Hope it will help someone. Viso! 👋

Won't that replace even backslashes that are meant to be in the string? E.g. if the string contains a Windows path.

Yes, you are right my solution just an easy workaround for saving the day. Otherwise need to implement :l feature

Hi! 👋 Thanks for getting in touch, and sorry we were unable to respond to your request. We're in the process of bringing new maintainers onto this project, and need to close stale tickets so that we can identify which items are still important to users of the sink.
If this issue still affects you:

Please consider whether it's a question that can be asked on Stack Overflow; if so, the serilog tag will get your question in front of many more people who can help you
Please consider whether you can research or investigate the issue and propose a solution for other users to benefit from
Feel free to comment here, letting us know it's still a problem

Thanks again!

This is still something I (and, I assume, @arslanaybars) would like to see implemented. The fact that it hasn't been implemented/fixed yet doesn't make it irrelevant. 🙂 I mean, if I had reported this a week ago instead of two years ago, it would have been left open, I assume?
WIth this in mind, could it be re-opened?

Hi Christer! Thanks for the nudge.
I agree that this would be a big improvement (the old quoted style of templates are a bit hard on the eyes :-)).
I closed just about all of the open issues because we've had very little maintainer time available for the past couple of years, and with 50+ open issues it was very hard to see which are even still relevant.
I'm just filling in, for now. I can definitely review PRs - is this one you're keen on having a shot at? I think there's room in 4.0 for some breaking changes or additional configuration options, I'd be happy to help figure out an approach.

If you can guide me to what parts of the code needs changing and if it's fairly simple, then maybe, though I am currently on a strict time budget and don't really have the capacity to really delve into new codebases.

@cmeeren thanks! I'm 99% sure that the line to change is this one:
https://github.com/serilog-contrib/serilog-sinks-applicationinsights/blob/dev/src/Serilog.Sinks.ApplicationInsights/Sinks/ApplicationInsights/TelemetryConverters/TelemetryConverterBase.cs#L111
Instead of calling RenderMessage() it's necessary to call Format() on a new MessageTemplateTextFormatter("{Message:lj}"). The formatter would need to be reused for each event.
Apart from that change, a test to show the behavior would be needed (I think there's already test infrastructure there to get this down to a few lines of code). Let me know if you need more info 👍


Doesn't work on WindowServer2019

I got the following message when I used platform 2019-Datacenter image to create VMSS with AutomaticOSUpgrade enabled. The message seems claim platform image doesn't support the feature.
Automatic OS Upgrade cannot be enabled on virtualMachineScaleSets configured with a Platform Image.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 51c75ce7-2144-d81a-693c-fb51cc00f3e5
Version Independent ID: cba654ea-ee84-fca4-a76d-717bfb9d9bf5
Content: Automatic OS image upgrades with Azure virtual machine scale sets
Content Source: articles/virtual-machine-scale-sets/virtual-machine-scale-sets-automatic-upgrade.md
Service: virtual-machine-scale-sets
GitHub Login: @rajsqr
Microsoft Alias: rajraj

@northtyphoon In the list of supported  platform OS, 2019 Datacenter is missing.  I will check and let you know.
CC: @MicahMcKittrick-MSFT

@rajsqr could you comment on when Windows 2019 will be supported? I know we just recently rolled these images out to the marketplace

@northtyphoon we worked offline and currently Windows Server 2019 is not yet supported for Automatic OS upgrades. That being said, we are working to enable them as we speak. The goal is to have it supported by Q1 2019. Once it is supported, we will be sure to update the doc accordingly.
Let me know if you have any additional questions.


Fix off-center text rendering for avatar

Before submitting the PR:

[x] Did you update and run tests before submission using npm run test?

Ran test but there was un-related error: src/lib/components/RangeSlider/RangeSlider.test.ts > RangeSlider.svelte > Ticks enabled AssertionError: expected null to be truthy

[x] Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name

What does your PR address?
Fix the SVG off-center text rendering for the Avatar component. Fixed by changing dominant-baseline HTML value to "central"

@saturnonearth is so odd I swear I tried that change, but oh well. It's working. My OCD thanks you kindly sir :)


Installing this runtime requires Xcode 16.1 or greater to be selected, but is currently 16.0.0

I do this:

brew install xcodes aria2
xcodes install 16.0 --experimental-unxip
xcodes runtimes install "iOS 18.0"

Getting this error:
Error: Installing this runtime requires Xcode 16.1 or greater to be selected, but is currently 16.0.0
But it is possible to download iOS 18.0 runtime from Xcode 16.0 settings.
Is there any bugs in checking versions logic?

To download runtimes, you need Xcode 16.1 selected(active) as it uses a command from that version in order to download specific runtime versions. Once you have that selected, you'll be able to run the commend xcodes runtimes install "iOS 18.0"


Add transient dependencies for cachito

Signed-off-by: Paul Belanger<EMAIL_ADDRESS>

Pull-request updated, HEAD is now 5fa7c8fb6d59d266f327731c54003f2c20e6151d

Pull-request updated, HEAD is now add683bbc76de03da9296bbca5f530e5382c6796

Pull-request updated, HEAD is now 84e4881cb6830fcdc288151b1cdd12c5fb52be88

Pull-request updated, HEAD is now fc6e7173171d144d79577206a5e40e4c4123c097

Pull-request updated, HEAD is now fc6e7173171d144d79577206a5e40e4c4123c097

Pull-request updated, HEAD is now 50ad954c8fc1110dbb96e6c568eadccfc0146d44


feat(core): added timeout and ssh identity file support

fix docs in README.md
add base app icon 32dll
add timeout support
add identity file ssh support

Tested : All good


Cleanup string resources and make accessing them consistent

While doing other work, I noticed that the Razor tooling string resources were defined a bit haphazardly. So, I went ahead and cleaned them up.
Here's a summary of the changes:

All resources are now accessed through the same type name: SR. This matches the style used in the .NET runtime.
All SR.resx and associated .xlf files have been moved into a Resources folder within each project that defines them.
To avoid collisions from InternalsVisibleTo, every project that defines string resources embeds them using a name based on the project name.
Every project that defines string resources now includes an implicit global using for the *.Resources namespace. So, you just have to type SR in any file in that project to get at the string resources.

While going through this exercise, I found a couple of places where string resources were being used from a different assembly unintentionally. These are now fixed up.
Notes:

I did not change the compiler projects to match. It shouldn't be a big deal to do so, but I decided not to because there are a lot more string resources and the compiler appears to have the XLIFF tasks disabled for some reason.
There a lot of files changed, but most of them are just renames. Reviewing should be easy.

the compiler appears to have the XLIFF tasks disabled for some reason

The ASP.NET team did not localize at all. Tooling only started localizing when it moved here to .NET. I'm surprised the compiler even has resource files.


cegispro2 does not terminate, no expectation expression

I wanted to know how is it possible to generate/verification expectations for these examples.
Could you please point me some examples where expectations are getting computed? I see that there is an expectation module here,
https://github.com/moves-rwth/cegispro2/tree/main/cegispro2/expectations

Also when running this benchmark with optimization flags, the execution runs for more than 6 hours with no results produced.
python3 -m cegispro2.cmd ./benchmarks/TACAS23_EXIST/Bin01_0.pgcl --post "x" --prop "x" --optimizing-synthesizer --debuglog

Am I missing something here?
Thanks.

Hi,
by default, cegispro2 tries to compute wp-superinvariants for verifying upper bounds on weakest preexpectations of the form wp[loop](post) <= prop (see our  paper for details). For your example, cegispro2 does not terminate because the property that is to be proven does not hold, i.e., wp[loop](x) <= x  does not hold.
The lower bound property x <= wp[loop](x), on the other hand, does hold. You can synthesize a wp-subinvariant by running
python3 -m cegispro2.cmd ./benchmarks/TACAS23_EXIST/Bin01_0.pgcl --post "x" --prop "x" --invarianttype sub

See Section 6 of our paper for details.
(--optimizing-synthesizer is not an optimization flag but a synthesizer based on Optimization Modulo Theories. It is not included in our paper and I recommend not to use it.)
All benchmarks from our paper are included in our Zenodo artifact. Under
\cegispro2\cegispro2\benchmarks\scripts\TACAS23

you can find scripts including all calls to cegispro2 we used to generate the benchmarks.
Please let me know if I can provide further help.


Un-blacklist gulp-connect

I'd like to request that gulp-connect be removed from the blacklist. Currently, the suggestion given is this:

use the connect module directly

gulp-connect does quite a bit more than just starting a Connect server.

It provides a simple, pre-configured server task function.
It includes a reload function that can be chained at the end of a task to automatically reload the server.
It sets up LiveReload so I don't have to.

Reimplementing all of that would be a pain in every project without using gulp-connect.
I tried to search for some example or documentation on how I would set up Gulp and Connect without gulp-connect, but I couldn't find any. Every reference I suggested using gulp-connect. I did find this issue, which suggested to read the documentation and use Connect as is. When I looked through the Connect documentation, the impression I got was I'd have to reimplement all of gulp-connect to get the same functionality. I don't see the benefit in that.
It seems to be that gulp-connect has a legitimate use case. If you have a suggestion of how I could approach this problem differently, I'd appreciate a reply with more detail.
Thanks!

Modules shouldn't provide tasks. Gulp 4 has custom registries for that use case.

@phated Thanks for the quick reply. I'm not quite following the issue. I don't see anywhere in the gulp-connect codebase where it's providing a task. Am I missing something? Can you reopen this issue until there's a more definitive answer on how to solve this problem?
If you don't think I should use gulp-connect, do you have an alternative suggestion about how I could accomplish this without gulp-connect? Is there an example I could look at? Is there some kind of documentation?

@phated Could you please comment on this or reopen the issue? I don't feel like my original question was addressed.


Dragging connection in Database Navigator

After importing all my dbvisualizer connects (thanks for that... great feature), I cannot organise the connections into the folders I require because a drag does not go beyond the length of the panel.
I'm running Dbeaver 6.1.3 Community Edition on a Fedora  30 64 bit installation.

Thank you for the suggestion.


Inconsistent Sample IDs produced when shuffle=True

It appears that https://github.com/UKGovernmentBEIS/inspect_ai/pull/477 introduced a bug where the sample_id is dependent on the shuffle order when the sample_id is not explicitly provided (e.g., in MMLU). This makes it difficult to track samples across runs.

I think the answer to this is to introduce an auto_id feature that ensures that the samples get the same ID even in the presence of shuffling: https://github.com/UKGovernmentBEIS/inspect_ai/pull/626
The reason we can't just always do that when shuffling is that many datasets will indeed already have an ID field (so our auto_id would plow over that).
Also updated evals using shuffle that don't already have an ID to use auto_id=True.

Should be resolved with https://github.com/UKGovernmentBEIS/inspect_ai/pull/626


Feature/remove vue compat

remove @vue/compat (migration build)
fix issues that came up
comment out code that is filtering errors since that is no longer possible (will be fixed in a next PR when we decide how to handle this)

The reason it is not being build on side of ci is, that it is trying to get some dependencies through ssh instead of https
https://github.com/aeternity/superhero-wallet/actions/runs/4880223539/jobs/8707607063?pr=2046#step:8:8


[C++] Allow to configure KeyShared with out of order delivery

Motivation
Similar to #7188, allow to configure key-shared with relaxed ordering in C++ client

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Cancel request does not work for continuous updates

Hi ;-)
I create a GPS Request with a pretty straightforward code
locationRequest = SwiftLocation.gpsLocationWith(serviceOptions)
How ever, when I want to stop getting the location, I call
locationRequest?.cancelRequest()
locationRequest = nil

I do get the log message
- Remove request: 69CC91CB-821F-4CBC-A512-903CCC9F0E99
but I keep getting my logs that are triggered inside then .then{} block
Am I doing something wrong or is it a bug?
Thanks.

My bad @malcommac, I actually stored 2 requests, hence the stop location not working. Every works fine ;-)

My bad @malcommac, I actually stored 2 requests, hence the stop location not working. Every works fine ;-)