Server busy with "SSL: inappropriate fallback (_ssl.c:720)" & "SSL: peer did not return a certificate (_ssl.c:720)" Errors

I have set up a Sanic Server supporting SSL_SERVER_AUTH. (with ca_cert).
From clients who has authorized certificates, they are successfully connecting to Server  but who has not, Server also handling these exceptions and becoming busy. Instead of being busy, i want my server directly reject (or even not accept) these connections. You can see following errors which i want to ignore or at least i want to handle them on main function.
Server-Side;
context = ssl.create_default_context(purpose=ssl.Purpose.SERVER_AUTH)
context.load_verify_locations("client.crt")
context.load_cert_chain("server.crt", keyfile="server.key")
ERRORS;
    <uvloop.loop.SSLProtocol object at 0x7f3819055f28>: SSL handshake failed
    protocol: <uvloop.loop.SSLProtocol object at 0x7f3819055f28>
    transport: <TCPTransport closed=False reading=False 0x564cdf49c368>
    Traceback (most recent call last):
      File "uvloop/sslproto.pyx", line 592, in uvloop.loop.SSLProtocol._on_handshake_complete
      File "uvloop/sslproto.pyx", line 171, in uvloop.loop._SSLPipe.feed_ssldata
      File "/usr/lib/python3.5/ssl.py", line 641, in do_handshake
        self._sslobj.do_handshake()
    ssl.SSLError: [SSL: PEER_DID_NOT_RETURN_A_CERTIFICATE] peer did not return a certificate (_ssl.c:720)
    <uvloop.loop.SSLProtocol object at 0x7f3819055f28>: SSL error errno:1 reason: PEER_DID_NOT_RETURN_A_CERTIFICATE
    protocol: <uvloop.loop.SSLProtocol object at 0x7f3819055f28>
    transport: <TCPTransport closed=False reading=False 0x564cdf49c368>
    Traceback (most recent call last):
      File "uvloop/sslproto.pyx", line 496, in uvloop.loop.SSLProtocol.data_received
      File "uvloop/sslproto.pyx", line 204, in uvloop.loop._SSLPipe.feed_ssldata
      File "uvloop/sslproto.pyx", line 171, in uvloop.loop._SSLPipe.feed_ssldata
      File "/usr/lib/python3.5/ssl.py", line 641, in do_handshake
        self._sslobj.do_handshake()
    ssl.SSLError: [SSL: PEER_DID_NOT_RETURN_A_CERTIFICATE] peer did not return a certificate (_ssl.c:720)
    <uvloop.loop.SSLProtocol object at 0x7f3815f70860>: SSL handshake failed
    protocol: <uvloop.loop.SSLProtocol object at 0x7f3815f70860>
    transport: <TCPTransport closed=False reading=False 0x564cdf4af0c8>
    Traceback (most recent call last):
      File "uvloop/sslproto.pyx", line 592, in uvloop.loop.SSLProtocol._on_handshake_complete
      File "uvloop/sslproto.pyx", line 171, in uvloop.loop._SSLPipe.feed_ssldata
      File "/usr/lib/python3.5/ssl.py", line 641, in do_handshake
        self._sslobj.do_handshake()
    ssl.SSLError: [SSL: PEER_DID_NOT_RETURN_A_CERTIFICATE] peer did not return a certificate (_ssl.c:720)
    <uvloop.loop.SSLProtocol object at 0x7f3815f70860>: SSL error errno:1 reason: PEER_DID_NOT_RETURN_A_CERTIFICATE
    protocol: <uvloop.loop.SSLProtocol object at 0x7f3815f70860>
    transport: <TCPTransport closed=False reading=False 0x564cdf4af0c8>
    Traceback (most recent call last):
      File "uvloop/sslproto.pyx", line 496, in uvloop.loop.SSLProtocol.data_received
      File "uvloop/sslproto.pyx", line 204, in uvloop.loop._SSLPipe.feed_ssldata
      File "uvloop/sslproto.pyx", line 171, in uvloop.loop._SSLPipe.feed_ssldata
      File "/usr/lib/python3.5/ssl.py", line 641, in do_handshake
        self._sslobj.do_handshake()
    ssl.SSLError: [SSL: PEER_DID_NOT_RETURN_A_CERTIFICATE] peer did not return a certificate (_ssl.c:720)
    <uvloop.loop.SSLProtocol object at 0x7f3815f70908>: SSL handshake failed
    protocol: <uvloop.loop.SSLProtocol object at 0x7f3815f70908>
    transport: <TCPTransport closed=False reading=False 0x564cdf4c19d8>
    Traceback (most recent call last):
      File "uvloop/sslproto.pyx", line 592, in uvloop.loop.SSLProtocol._on_handshake_complete
      File "uvloop/sslproto.pyx", line 171, in uvloop.loop._SSLPipe.feed_ssldata
      File "/usr/lib/python3.5/ssl.py", line 641, in do_handshake
        self._sslobj.do_handshake()
    ssl.SSLError: [SSL: INAPPROPRIATE_FALLBACK] inappropriate fallback (_ssl.c:720)
    <uvloop.loop.SSLProtocol object at 0x7f3815f70908>: SSL error errno:1 reason: INAPPROPRIATE_FALLBACK
    protocol: <uvloop.loop.SSLProtocol object at 0x7f3815f70908>
    transport: <TCPTransport closed=False reading=False 0x564cdf4c19d8>
    Traceback (most recent call last):
      File "uvloop/sslproto.pyx", line 496, in uvloop.loop.SSLProtocol.data_received
      File "uvloop/sslproto.pyx", line 204, in uvloop.loop._SSLPipe.feed_ssldata
      File "uvloop/sslproto.pyx", line 171, in uvloop.loop._SSLPipe.feed_ssldata
      File "/usr/lib/python3.5/ssl.py", line 641, in do_handshake
        self._sslobj.do_handshake()
    ssl.SSLError: [SSL: INAPPROPRIATE_FALLBACK] inappropriate fallback (_ssl.c:720)

I have a similar issue, although even with a valid stored SSL certificate on the client side, it will deny access to the client.
Ideally, I'd like to reroute HTTP traffic to HTTPS, and refresh client certs. I'm not sure why the client-side cert is not refreshed, as the cert, keyfile, host, nor domain have changed.
After digging around a bit, I attempted to create a custom SSLObject that handled do_handshake() exceptions and pass it to a custom SSLContext which should be passed from app.Run() all the way to the ssl lib. Unfortunately, this problem is in a different space.
UVLoop uses their own handshake in SSLProtocol, and seems to trigger a callback on error.
I think handling the error in that callback is the way to go. Currently freeing up some cycles from other work to delve into callback shenanigans.

Hi @Sunrise17 I think that is because sanic doesn't pass the ssl error from the loop to the app to handle it.
But if you don't mind, you could use my trick below, where I put the sanic app behind nginx and pass the cert from nginx.
 I AM NOT SURE THEY CAN BE RUN DIRECTLY
server {
    listen 443 ssl;
    ssl_certificate     /certs/nginx.crt;
    ssl_certificate_key /certs/nginx.key;
    # client certificate
    ssl_client_certificate /certs/ca.crt;
    ssl_verify_client on;
    location / {
        root /frontend;
    }
    location /api {
        # NOTICE: this requires higher version of nginx, or you have to use $ssl_client_cert
        proxy_set_header X-SSL-CERT $ssl_client_escaped_cert;
        proxy_pass http://upstream;
    }
}

@app.middleware('request')
async def set_ssl_context(request):
    cert = request.headers.get('x-ssl-cert')
    if cert is None:
        raise SanicException('Invalid Cert')
    cert = unquote(cert)
    cert = crypto.load_certificate(crypto.FILETYPE_PEM, cert)
    ca_cert = request.app.ca_cert
    store = crypto.X509Store()
    store.add_cert(ca_cert)  # add trusted ca
    store_ctx = crypto.X509StoreContext(store, cert)
    # this line will raise an error if the cert is invalid
    store_ctx.verify_certificate()
    subject = cert.get_subject()
    for name, value in subject.get_components():
        # get info from the cert
        name_map = {
            b'C': 'countryName',
            b'UID': 'userId',
            b'CN': 'commonName',
            b'O': 'organizationName',
        }
        if name in name_map:
            name = name_map[name]
        request.client_cert[name] = value.decode()
    # further operations...

I didn't notice this problem before since I only tested with valid certification and take it for granted that one should reject the invalid request by default...
My previous implementation is like that (where the keys for cert subject are different):
@app.middleware('request')
async def set_ssl_context(request):
    transport = request.transport
    peer_cert = transport.get_extra_info('peercert')
    for term in peer_cert['subject']:
        # notice the difference here
        (key, value), = term
        request.client_cert[key] = value

ca_file = config['ssl']['ca']['cert']
cert = config['ssl']['server']['cert']
key = config['ssl']['server']['key']
context = ssl.create_default_context(purpose=ssl.Purpose.CLIENT_AUTH, cafile=ca_file)
context.set_ciphers('TLSv1.2')
context.verify_mode = CERT_REQUIRED
context.load_cert_chain(cert, keyfile=key)
app.run(ssl=context)


Upgrade dupe with item frames

Just Dire Things version
1.4.9
Minecraft Version
1.12.1
(Neo)Forge Version
1.21.1
Modpack & Version
Craftoria 1.21
Do you have optifine or Rubidium installed?
None
Describe the issue
Upgrades drop when item is put in item frame. Item keeps the upgrades
Steps to reproduce

Get JustDireThings Gear/Tool (i.e Celestigem Helmet)
Put Upgrade on Gear/Tool (e.g. Night Vision)
Put upgraded Gear/Tool in Item Frame
Pick up dropped (duped) Upgrades
Get Gear/Tool out of Item Frame

Expected behaviour
Gear/Tool to go into item frame without anything dropping
Screenshots
No response
Log files
No response
Additional information
No response

Unfortunately this is a bug in Forge :)


(HotFIX) Fix tags not wrking properly in docs

'-' was acting as a word separator so replaced it with '_'

@hoob3rt do merge it as soon as you can.
This one just changes '-' to '_' in tag_names in doc file.


Fix memory leak in WebSocket proxy

Motivation
In our Pulsar instance, running WebSocket proxy gradually increase memory usage.
As a result of analyzing the heap dump, I've found that a lot of ConsumerHandler instances are retained by topicConsumerMap.
private final ConcurrentOpenHashMap<String, List<ConsumerHandler>> topicConsumerMap;

Since ArrayList is not thread-safe unlike ConcurrentOpenHashMap, it seems that some ConsumerHandler instances are not removed as expected.
This can be confirmed with the following test code:
https://gist.github.com/massakam/5726be965fff0a7bb8b3a6dd7e970e28
Modifications
Use ConcurrentOpenHashSet instead of ArrayList.
-private final ConcurrentOpenHashMap<String, List<ConsumerHandler>> topicConsumerMap;
+private final ConcurrentOpenHashMap<String, ConcurrentOpenHashSet<ConsumerHandler>> topicConsumerMap;

Result
ConsumerHandler instances will be removed as expected and memory leak can be avoided.

retest this please

retest this please


fixing animation

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #140
Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Opened the application in Chrome
Scrolled through the Home page and observed the transitions for each section
Confirmed that the sections animate into view as expected without any abrupt transitions
Screenshorts and Vedios:
https://github.com/pooranjoyb/popShop/assets/127961738/dd7f2bcf-7e94-4305-a449-ad8bffac11ee
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my code
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works

Nice work @Yogesh-ok55 🚀


Ignore disabled shapes during 2d raycast

Prevents raycast2d from returning hits with disabled shapes.
Fixes #17015

Is it intented that disabled shapes would still take space into the collision engine data structure? (and still being detected in broadphase?)

Just looking at the code all the intersection methods ( intersect_point, intersect_ray and intersect_shape ) indeed share the same problem and perform tests against disabled shapes.
As both BroadPhase2DHashGrid and BroadPhase2DBasic do not really have their own structure, but directly access the shapes via the CollisionObject2DSW's shapes list, I believe that all shapes (disabled or not) being tested is intentional.
Having only enabled shapes to iterate over and calculate with is of course faster and seems cleaner to me. I'm not sure, if there is an easy way to split that list into one for enabled and one for disabled shapes, though as you have to make sure that the list appears as one single list to the editor and scripting systems while making sure that the physics engine only sees the enabled ones. Would be a bigger rewrite / feature request?
Just noticed that cull_aabb and cull_segment take a parameter which specifies the maximum number of hits they return. It is defined in space_2d_sw.h as INTERSECTION_QUERY_MAX = 2048 which is a lot, but in theory you could end up with 2048 hits against disabled shapes with a 2049th shape that is enabled not getting checked and not being returned which leads to a false result. So checking a shape's disabled property in the broad phase might actually a better idea than checking it in the intersect method(s).
Opinions on this? Fix the other two methods or put the checks in the broad phase cull_aab and cull_segment methods? Splitting the list might be the best solution, but feels like a somewhat bigger task?

Actually removing disabled shapes from physics calculations wasn't that difficult to do.
Closing this pull request as it is replaced by a better solution ( see #17151 ).


ValueError: No transformer cached credit_card_balance_cleaning_fold_1

When I run "python main.py -- train_evaluate_predict_cv --pipeline_name XGBoost", I got this error in the title. However, I can run the lightGBM pipeline successfully.

Probably you interrupted training process during fold_1.


Fix extensions.bzl to allow for multiple versions

Current code has a bug, where if there are multiple registration it will not run with error:
Error in sorted: unsupported comparison: dict <=> dict

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Chore][Doc] Run a Pulsar cluster locally with Docker Compose

Search before asking

[X] I searched in the issues and found nothing similar.

What issue do you find in Pulsar docs?
In the docs https://pulsar.apache.org/docs/3.3.x/getting-started-docker-compose/
At Step 2: Create a Pulsar cluster, it should be very clear that creating the data directory is only for Linux.
When doing the step on mac, the whole docker-compose up will fail because of permissions.
What is your suggestion?
Step 2: Create a Pulsar cluster
For Mac users:
To create a Pulsar cluster by using the compose.yml file, run the following command.
run docker compose up -d

For Linux users:
As preparation, create data directories and change the data directory ownership to uid(10000) which is the default user id used in the Pulsar Docker container.
sudo mkdir -p ./data/zookeeper ./data/bookkeeper
sudo chown -R 10000 data

then create a Pulsar cluster by using the compose.yml file by running the following command.
docker compose up -d

Any reference?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Agree on mac you have to avoid this command: sudo chown -R 10000 data


use_cookie causes panic

I'm trying to write a logged in wrapper that uses the following cookie.
I seem to be able to set the cookie just fine from inside a server function, but adding the following code as a component causes this error.
I am using nightly rust with leptos if that matters.
thread 'main' panicked at ...\.cargo\registry\src\index.crates.io-6f17d22bba15001f\js-sys-0.3.69\src\lib.rs:6013:9:
cannot call wasm-bindgen imported functions on non-wasm targets
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at /rustc/ab5bda1aa70f707014e2e691e43bc37a8819252a\library\std\src\thread\local.rs:260:26:
cannot access a Thread Local Storage value during or after destruction: AccessError
fatal runtime error: thread local panicked on drop

#[component]
pub fn AuthRequired(children: Children) -> impl IntoView {
    let (cookie, _) = use_cookie::<String, FromToStringCodec>("token");

    cookie.with(move |jwt| match jwt {
        Some(_) => children().into_view(),
        _ => view! { <Redirect path="/login"/> },
    })
}

The crash happens so long as use_cookie is anywhere in any component.
I can comment out the cookie.with(...) code and the error still occurs until I also comment out use_cookie

Hm... do you have SSR correctly configured? Could you send your Cargo.toml?

[package]
name = "emp"
version = "0.1.0"
edition = "2021"

[lib]
crate-type = ["cdylib", "rlib"]

[dependencies]
axum = { version = "0.7", optional = true }
console_error_panic_hook = "0.1"
leptos = { version = "0.6", features = ["nightly"] }
leptos_axum = { version = "0.6", optional = true }
leptos_meta = { version = "0.6", features = ["nightly"] }
leptos_router = { version = "0.6", features = ["nightly"] }
tokio = { version = "1", features = ["macros", "rt-multi-thread"], optional = true }
tower = { version = "0.4", optional = true }
tower-http = { version = "0.5", features = ["fs"], optional = true }
wasm-bindgen = "=0.2.92"
thiserror = "1"
tracing = { version = "0.1", optional = true }
http = "1"
serde = { version = "1", features = ["derive"] }
serde_json = "1"
surrealdb = { version = "1.5.3", optional = true}
bcrypt = {version = "0.15.1", optional =  true}
chrono = {version = "0.4", optional = true}
cfg-if = "1.0.0"
leptos-use = "0.10"
tower-sessions = {version = "0.12", optional = true}
dotenv = {version = "*", optional = true}
# tower-cookies = "0.10.0"

[features]
hydrate = ["leptos/hydrate", "leptos_meta/hydrate", "leptos_router/hydrate"]
ssr = [
    "dep:axum",
    "dep:tokio",
    "dep:tower",
    "dep:tower-http",
    "dep:leptos_axum",
    "leptos/ssr",
    "leptos_meta/ssr",
    "leptos_router/ssr",
    "dep:tracing",
    "dep:surrealdb",
    "dep:bcrypt",
    "dep:chrono",
    "dep:tower-sessions",
    "dep:dotenv"
]

# Defines a size-optimized profile for the WASM bundle in release mode
[profile.wasm-release]
inherits = "release"
opt-level = 'z'
lto = true
codegen-units = 1
panic = "abort"

[package.metadata.leptos]
# The name used by wasm-bindgen/cargo-leptos for the JS/WASM bundle. Defaults to the crate name
output-name = "emp"

# The site root folder is where cargo-leptos generate all output. WARNING: all content of this folder will be erased on a rebuild. Use it in your server setup.
site-root = "target/site"

# The site-root relative folder where all compiled output (JS, WASM and CSS) is written
# Defaults to pkg
site-pkg-dir = "pkg"

# [Optional] The source CSS file. If it ends with .sass or .scss then it will be compiled by dart-sass into CSS. The CSS is optimized by Lightning CSS before being written to <site-root>/<site-pkg>/app.css
style-file = "style/style-file.css"

# Activates the tailwind build
tailwind-input-file = "style/tailwind.css"
tailwind-config-file = "tailwind.config.js"

# Assets source dir. All files found here will be copied and synchronized to site-root.
# The assets-dir cannot have a sub directory with the same name/path as site-pkg-dir.
#
# Optional. Env: LEPTOS_ASSETS_DIR.
assets-dir = "public"

# The IP and port (ex: <IP_ADDRESS>:3000) where the server serves the content. Use it in your server setup.
site-addr = "<IP_ADDRESS>:3000"

# The port to use for automatic reload monitoring
reload-port = 3001

# [Optional] Command to use when running end2end tests. It will run in the end2end dir.
#   [Windows] for non-WSL use "npx.cmd playwright test"
#   This binary name can be checked in Powershell with Get-Command npx
end2end-cmd = "npx playwright test"
end2end-dir = "end2end"

#  The browserlist query used for optimizing the CSS.
browserquery = "defaults"

# The environment Leptos will run in, usually either "DEV" or "PROD"
env = "DEV"

# The features to use when compiling the bin target
#
# Optional. Can be over-ridden with the command line parameter --bin-features
bin-features = ["ssr"]

# If the --no-default-features flag should be used when compiling the bin target
#
# Optional. Defaults to false.
bin-default-features = false

# The features to use when compiling the lib target
#
# Optional. Can be over-ridden with the command line parameter --lib-features
lib-features = ["hydrate"]

# If the --no-default-features flag should be used when compiling the lib target
#
# Optional. Defaults to false.
lib-default-features = false

# The profile to use for the lib target when compiling for release
#
# Optional. Defaults to "release".
lib-profile-release = "wasm-release"

well, I'm at a complete loss now.
I read the docs for use_cookie again and it said to enable the feature "axum", but when I do that like so
leptos-use = {version = "0.10", features = ["axum"]}
I get this compilation error
compile_error!("Only features sync,macros,io-util,rt,time are supported on wasm.");

I'm trying to fake it by wrapping it in a call to a server function, but I can't seem to figure out how to use the getter inside a server function.
If I try cookie.get() or cookie.with() I get "Send is not implemented" compiler error.
#[server(LoggedIn, "/api")]
pub async fn logged_in() -> Result<(), ServerFnError> {
    let (cookie, _) = use_cookie::<String, FromToStringCodec>("token");
    let result = cookie.get();

   // ....
}

future cannot be sent between threads safely
the trait `Send` is not implemented for `(dyn std::ops::Fn() -> std::option::Option<std::string::String> + 'static)`, which is required by `{async block

leptos-use = {version = "0.10", features = ["ssr"]}
That fixes the crash in the component, but if I add the "axum" feature as well I still get this compiler error
compile_error!("Only features sync,macros,io-util,rt,time are supported on wasm.");

I guess you didn't read https://leptos-use.rs/server_side_rendering.html? 😂
Do this:
[dependencies]
...
leptos-use = "0.10"

[features]
...
ssr = [
    ...
    "leptos-use/ssr",
    "leptos-use/axum",
]


Test that triggers the len error

Added len as an "internal" function, much the way abs is already added.
Added small test to make sure this fixes the warning we've been seeing.

Fixes #146

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.94%. Comparing base (29a3406) to head (b51dae6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   96.93%   96.94%
=======================================
  Files          15       15
  Lines        1338     1340    +2
=======================================
+ Hits         1297     1299    +2
  Misses         41       41

Flag
Coverage Δ

unittests
96.94% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Feature]: Add message to set the trim values

The Flight ControlState API allow setting the values for the trim and there is currently no way to set them from the SimpitAPI.
One solution would be to reuse the Rotation message and use the unused bits from the bitmask to indicate that the values in the message should be the new trim value.

The trim values does not seem to work with an autopilot such as the one used by Simpit. Setting the trim values using the FlightCtrlState API does not seem to do anything. I tried to add a new channel that control the trim values (with the same code as the one controlling the rotation, only updating the trim values of the FlightCtrlState).
kOS seems to have the same issue. See here for instance.
Not sure how to proceed from here, except excluding this from the feature we want to support.

For those that want to try, see the diff file of what I tried.
Following a discussion on Discord, adding trim can be done in the controller without using KSP builin trim. It seems also that KSP built-in trim are not used when setting rotation command the way we use them, meaning that the controller command will in any way ignore KSP trim. So I suggest not to implement a message to set KSP trim values with Simpit and instead favor a trim setting Arduino side, by each user.


Generate custom icon set

We are currently using font awesome, but we only use ~5 icons. We could generate a custom icon font that would be much smaller.

We're now using enough of the icons that the set is probably worth it. Also, more people probably have font-awesome cached already.


Azure DevOps Fedramp

@SaurabhSharma-MSFT This page is the Fedramp roadmap. The 4th column shows if meeting Fedramp requirements is planned for 2019. So you are already showing audit release plans. I am pretty sure @jaredtait and are interested Azure DevOps once it meets Fedramp requirements. Obviously it is not on the above roadmap for 2019, is it on the roadmap for 2020?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f0757109-f5b1-f77c-9e15-9497891db841
Version Independent ID: 01f4f175-bfb0-5146-ae7d-02a62b7448b1
Content: Azure Services in FedRAMP and DoD SRG Audit Scope
Content Source: articles/security/compliance/azure-services-in-fedramp-auditscope.md
Service: security
GitHub Login: @Jain-Garima
Microsoft Alias: gjain

@Mul-ti-pass My apologies I am not aware of the plan.  @Jain-Garima Can you please help providing this detail.

Thank you @Mul-ti-pass for keeping this going.  I am interested in using Azure DevOps as well as Application Insights when it reaches Fedramp requirements at any level.

I was wondering if there is an update on this issue.
My company would love to use Azure DevOps but require it to be Fedramp compliant.

I was wondering if there is an update on this issue.
My company would love to use Azure DevOps but require it to be Fedramp compliant.

Was just looking today (8 July 2022) and did not see Azure DevOps on the list.  Saw GitHub AE there and numerous other Azure/Microsoft products but not DevOps.  Any update on this?

Bumping the thread. Would really like to have a clear answer if Azure DevOps Services is FedRAMP authorized given that it's build on Azure, which could mean by-proxy, that it is for at least US-based instances.

Keeping this alive.  It would be great if Azure DevOps had FedRAMP ATO.  It seems that there is interest in the Azure Government community, but I cannot find anything on whether Azure DevOps is authorized to operate.  Any information would be great.

Keeping this alive. It would be great if Azure DevOps had FedRAMP ATO. It seems that there is interest in the Azure Government community, but I cannot find anything on whether Azure DevOps is authorized to operate. Any information would be great.

Azure DevOps is not authorized for FedRAMP. Will update once we have plans to get it reviewed and authorized.

Any updates on FedRAMP status?

@Jain-Garima any update for us on FedRAMP for Azure DevOps?

It is crazy that Atlassian only authorized tool is "Trello" and its crazy that Atlassian Jira isn't either. Microsoft could take more business from Atlassian if Azure DevOps was authorized.

Agree 100% here.  It'd be extremely valuable if DevOps got FedRAMP certified.

+1 for ADO FedRAMP.  A customer I work with would move to ADO service if it had FedRAMP accreditation. They are currently using ADO Server, but because ADO Server is not FIPS 140-2 or 140-3 compliant, they are making moves to remove it and have the 400+ projects move to another solution :(

You pretty much have to go to GitHub and GitHub actions as they are FedRAMP Tailored. We passed our audits multiple times and our company and product was FedRAMP moderate.

Speaking as a project manager, I need more than just a code repo. Azure DevOps has a Wiki for knowledge management, boards for status of tasks, long range planning tools, a test service to create/execute/track test cases and test plans. It's a pretty comprehensive all-in-one PM tool.

Any update on AZURE DEVOPS GETTING FEDRAMP AUTHORISED??


Fix integration tests (Jenkins)

Actual behavior
Currently the Jenkins tests are not running properly and throw errors.
Expected behavior
Make sure tests are up-to-date and the Jenkinsfile is able to run it completely.
Integrate the Jenkins tests in nightly tests build.
Steps to reproduce
Run the CI tests.
Which version(s) does this affect? (Environment, OS, etc...)
0.5.0

This issue will be handled with help of DevOps team. Any further changes to the codebase will be done within that issue. It will be closed after the QA/CI setup is done.


add source and links

@sandy081 looks like there is some build issue. Just @ me when you fix it.

@karthiknadig Fixed. Thanks for the ping/


POST on nested data throws 404

Hello everybody,
we're trying get json-server accepting a nested POST request to /findingsets/ where findings are nested to. Unfortunately when doing POST /findingsets/1/findings/ it throws 404 where we would expect that json-server adds our payload to the nested array. This is how our data structure looks like
{
  "findingsets": [
    {
      "id": 1,
      "name": "First findingSet",
      "findings": [
        {
          "id": 888213,
          "name": "First finding (Backend)",
          "latitude": 2,
          "longitude": 6,
          "description": "Ich bin ein erster Platz"
        }
      ]
    },
    {
      "id": 2,
      "name": "Second findingSet",
      "findings": [
        {
          "id": 852033,
          "name": "First finding (Backend)",
          "latitude": 18,
          "longitude": 33,
          "description": "Ich bin ein zweiter Platz"
        },
        {
          "id": 101543,
          "name": "Second finding (Backend)",
          "latitude": 26,
          "longitude": 30,
          "description": "Ich bin ein dritter Platz"
        },
        {
          "id": 453135,
          "name": "Third finding (Backend)",
          "latitude": 19,
          "longitude": 30,
          "description": "Ich bin ein vierter Platz"
        }
      ]
    }
}

Any idea what we're doing wrong here?

Following the this thread because I have the same issue. I can GET from /profile/1 just fine but trying to send a POST req to the same endpoint gives me a 404. POST req to the /profile endpoint without the id also works fine.

Following the this thread because I have the same issue. I can GET from /profile/1 just fine but trying to send a POST req to the same endpoint gives me a 404. POST req to the /profile endpoint without the id also works fine.

Same problem with POST /tasks/1/ and PUT /tasks/ as well. It gives me a 404 Error as well in my Angular App. It doesn't work with Postman as well. Not an issue with DELETE /tasks/1/ and GET /tasks/ though

@shreym03 you gotta use PATCH instead of POST if you want to update /tasks/1. Only use POST for adding to /tasks. Not very intuitive, but I'm sure they have their reasons for it.

Did anyone found a solution to this problem? 🙏

@dimitri-bourreau see my comment above. This server doesn't work like a normal server, so to update existing records you need to send a PATCH.

@crevulus thanks, I've seen your comment and it doesn't help me.
I can not use PATCH. json-server is used in my case as some sort of a mock of a real server, for testing.
The very specific 404 on a POST on a "complex" path (/this/is/complex) is my issue.
Would you agree to say that json-server is not meant for this particular use? This is my fear.

Yes, I've also found that the odd behavior of json-server means that it is useless for use as a mock server, unless your production server is also using json-server..

We agree, thank you for sharing your idea on this. 👍


Add post-install-job/pre-delete-job to generate/delete all primitives for helm chart

After PR #426 , all of the primitives are now generated by kubefed2 federate enable, so with helm chart, we need to introduce post-install-job/pre-delete-job to generate and delete those primitives.
An example of post-install-job can be referenced here https://github.com/helm/helm/blob/master/docs/examples/nginx/templates/post-install-job.yaml
/cc @marun

@marun Yes, this is the behavior from day 1, please refer to https://github.com/kubernetes-sigs/federation-v2/blob/master/charts/federation-v2/README.md#uninstalling-the-chart for detail.
The following command will delete the control plane.
$ helm delete --purge federation-v2

So this shouldn't be required if yaml is used instead of kubefed2?


ComboBox is unclickable

Describe the bug
I can't click on the ComboBox. If I select the ComboBox using the Tab key, then I am able to select an item using the Up/Down keys. Either way, if I click on the ComboBox, nothing happens. I made sure that it IsEnabled is true
To Reproduce
Create a new ComboBox and populate it with anything
Expected behavior
When I click on the ComboBox I aspect a drop-down menu/list to appear.
Screenshots
No screenshots, but I added a recording.
Desktop:

OS: Mac
Version Ventura 13.3

Additional context
Recording
Code

Can you try it using a fresh new sample App with just a ComboBox in it?

Can you try it using a fresh new sample App with just a ComboBox in it?

I tried it, no luck. I will add the sample code I used.
Code

Works using Windows. I can't say much about MacOS. Can you try latest 11.0 preview 6 with your sample?

I have exactly the same problem. Have you been unable to find a solution?

@timunie no, I can't reproduce it on my mac.

My problem was solved after a clean reinstall and update for last version of all frameworks (Xamarin, Mono,  .Net)


Add patch suggested by Scrutinizer CI

Add a patch as suggested by PHP Scrutinizer.
See also https://scrutinizer-ci.com/g/crate/crate-dbal/inspections/4fb5c82a-104e-40f4-8973-92ff509225ba/patches

Pull Request Test Coverage Report for Build 496683060

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.651%

Totals

Change from base Build 496655892:
0.0%

Covered Lines:
291

Relevant Lines:
332

💛  - Coveralls

Pull Request Test Coverage Report for Build 496683060

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.651%

Totals

Change from base Build 496655892:
0.0%

Covered Lines:
291

Relevant Lines:
332

💛  - Coveralls

Pull Request Test Coverage Report for Build 496683060

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.651%

Totals

Change from base Build 496655892:
0.0%

Covered Lines:
291

Relevant Lines:
332

💛  - Coveralls

Pull Request Test Coverage Report for Build 496683060

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.651%

Totals

Change from base Build 496655892:
0.0%

Covered Lines:
291

Relevant Lines:
332

💛  - Coveralls


[Integration] implement JDBC persistent store extension

it can behave differently for different DBs
can create DocStore with basic functionality and ability to extend/override some specifics

replaced by https://github.com/dsukhoroslov/bagri-extensions/issues/3, closing


Linux bridge setup

@phoracek @RamLavi
Updated the script with the new LB settings

@phoracek fixed the readme and the script paths to fit the new script name.


Include locked nodes on selection list

Closes https://github.com/godotengine/godot-proposals/issues/410

It works both with TOOL_SELECT and TOOL_LIST_SELECT, but maybe the latter shouldn't behave like that?
EDIT:
I just realized it would be useful to make this work for grouped too, i.e. allowing to pick a node from group (the locked children thing). Although it's not as straight-forward as adding them to list, because this might be unwanted...
EDIT2:
Added another commit that slightly alters the behavior.

I just added the behavior I mentioned in https://github.com/godotengine/godot-proposals/issues/410#issuecomment-579978559 as another commit.

It might be good to specify in the list of nodes the ones that are supposed to be locked. Maybe by having "locked" in parenthesis?

Done.

Oh I would have put it in the end. But well... it works too ^^

Yeah, this looks better.

btw initially I wanted to use lock emoji, but sadly it didn't display correctly.

The font needs to include the given emoji for this to work. The editor font we use doesn't come with a set of emojis, so it won't work. (Including emoji would increase binary size by a fair bit, as emoji fonts are often quite large.)

Commits should be squashed, otherwise it seems OK to me.

If I am not mistaking, grouped node also appear as "locked" isn't it ? This might be confusing for users.
If this is not too much work, would rather have both a "Grouped" and a "Locked" labels to distinguish the two cases.

Squashed. Also grouped nodes are now listed as "(Grouped)".

Thanks!


Correctly handle the case of an empty suggestion

Like this one:
https://github.com/oleg-derevenetz/fheroes2/pull/74#discussion_r851792009
Plus a few minor fixes suggested by the pylint.

:thinking: I don't get it. Where is the wrong behavior in the link you provided?

🤔 I don't get it. Where is the wrong behavior in the link you provided?

There is nothing wrong with it :) This is the final result. Previously, when suggestion was an empty string, script just crashed because of invalid index, like here:
https://github.com/ihhub/fheroes2/runs/6055970601?check_suite_focus=true


Change src/env.ts to src/env.mjs

As we have to import env.ts in next.config.js for runtime type validation check and next still now don't support ts extension for their config file, so we must have to make env.mjs. That is why I changed extension from doc.

It makes sense for NextJS, but it's not the case for others framework though. For instance, you are allowed to use .ts in vite.config.ts for Vite.
Speaking of NextJS, I'm quite curious what is the reason that we want to import env.mjs into next.config.js, as I saw the same pattern in create-t3-app? I assume it's because we want to run the validation before build process?


added simple padding functionality

Saw other attempts. This one is the easiest

@hdodenhof mentioned this in another pull request (here) to add padding:

Padding support would have to handle different values for each side while still maintaining a 1:1 ratio for the drawable and border.

Thanks for your contribution! While this probably is the most simplistic approach, I prefer to use the platform's padding attributes here to avoid confusion. Please have a look at d3ced7d for the implementation.


Issue 43200: Update default audit log behavior for dataset table

Rationale
When truncating a dataset, our default audit log level is NONE but the expectation is that we will at least create a summary record.  This change overrides the default from NONE to SUMMARY.  The audit log will appear in the Query Update Events instead.  Attempts to set this audit behavior on the configParameters within truncateRows were not successful because we still call getAuditBehavior to figure out which AuditHandler to return.
Changes

set default audit behavior for DatasetDefinition

Gonna have to try something else.


sub-defined usernote templates

This is deferred, but not a bad idea, because it contributes to the ever-an-issue wiki space problem.
Basically, subs can define common usernotes which can be stored as constants in the schema.
More here: https://www.reddit.com/r/toolbox/comments/33sn33/request_preset_user_note_options_to_choose_from/
A usernote template should include:

Note text (required)
Tag type (optional)

They should be configured via tbconfig.
This will be a bit of an engineering task, since ConstMgr uses simple ints as keys.  Meaning you could have an issue if someone saves a usernote of just "1" which would be translated to Constant User Note ID: 1.   Sure, that is unlikely, but something to consider in design and testing.

Neat, I can close this now.


In ng test Reduce 5 second pause between saving a file and running tests

Please provide us with the following information:

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Macbook Air: OSX (El Capitan) 10.11.6

Versions. Please run ng --version. If there's nothing outputted, please run
in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.15
node: 6.5.0
os: darwin x64

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.

Run ng test on a CLI project (e.g. https://github.com/angular-workshops/angular2-testing/tree/solution/tour-of-heroes)
Change a source or test file
Wait approximately 5 secs before anything happens in the terminal

The log given by the failure. Normally this include a stack trace and some
more information.

Mention any other details that might be useful.

This is becoming very frustrating for doing any kind of TDD since it breaks your focus waiting for a change to be tested.
Even some logging indicator that something is happening would help psychologically.
(Discussed with Filipe on Slack)

Thanks! We'll be in touch soon.

Are browser remain launched while watching for changes?
May be browser is closed after test finish and restarted after file saving for some reason?
On Ubuntu, it takes ~5 sec before first test (browsers are launching), but next time runs immediately.

With Angular CLI 1.0.0.beta.30, I do not experience 5 seconds "grace period".
I either change the spec or source TS file, and the tests are performed right away.

I think it has to do with the number of modules (and especially connected modules) that you have in a project. Large projects take a long time to recompile and re-run the tests. At Pix4d our project is growing larger each day and our waiting period is now between 5,5s and 15s depending on which file gets touched. I've even experienced over 20s when touching certain files that depend on a lot of stuff, although that is not so common.
Unfortunately I don't think there is a lot that can be done (would love to be wrong about this), especially in the CLI. Or maybe there could be a way of including certain files for testing by looking for "fdescribe"?

@petebacondarwin do you still these delays?

I haven't noticed it recently but I have not been running large test suites either.

I'll closed as fixed for now, but will reopen if it comes up again.


bitmap working sample ?

HI, Thanks for sharing your work. I was glad to find it. Thanks to this repo i was able to send commands to my printer. But unfortunatelly wasn't able to print a valid bitmap yet. Could you share a working bitmap sample you have used on ur D11 printer ?
trying to figure out why my bitmap isn't being printed. Getting the error below:

hello image:

description edit with screenshots

Issue resolved. I'm able to print now but have to use the original width/height of the bitmap. Could not request smaller properties to print.

Hello @dnovaes
Could you tell me what was the solution because I am facing the same issue?

Hello @dnovaes
I can print but the image is distorted, although while printing with nibmot app it works fine


Remote branch error when creating PR

Issue Description
Type: bug report
Describe what happened (or what feature you want)
Recently I have been getting a weird error where I get weird characters appearing when the Remote Branch step of the PR creation pops up. Whether I simply open :Octo or do :Octo pr create I get the same error as below:

Describe what you expected to happen
I expected the steps to ask what the remote branch, etc to work as it used to a few weeks ago
How to reproduce it (as minimally and precisely as possible)

Open neovim and change a file.
Open lazygit and push local changes to a new remote branch
Run :Octo pr create

Tell us your environment
MacOS 14.0
Alacritty 0.12.3
Neovim
NVIM v0.10.0-dev-1080+g676e1d490
Build type: RelWithDebInfo
LuaJIT 2.1.1694316387

gh 2.36.0 (2023-10-03)
octo master e933611c74cb735c00d0db8ca94533bec1444bf0
Anything else we need to know?

$GITHUB_TOKEN is set to a new personal token I have created
I did gh auth logout and then gh auth login and I followed the steps to use ssh and pasted in the same personal token that I had in my $GITHUB_TOKEN
Doing gh pr create works fine

Update:
This happened because I had no idea how to work with my new shell (fish).
I had neofetch at the bottom of my config.fish but I just learned that this means it runs whether it is an interactive or non interactive shell.
For other's benefits, the way I got this working was setting a variable in fish called fish_greeting. I had to do the following:
function fish_greeting
    neofetch
end

funcsave fish_greeting

Thanks for sharing it here. Will close the issue but people with the same error should be able to find it.


How to find by ObjectId?

I hope this message finds you well. I wanted to reach out to express my gratitude for the wonderful tool you've developed.
Question:
My entity in MongoDB:
{
  "_id": {
    "$oid": "666fde1af688038e64d6b58a"
  },
  "warehouseId": {
    "$oid": "666f3a3ecf615a0f4d455411"
  }
}

Code:
query:= "warehouseId=666f3a3ecf615a0f4d455411"
opts := mgs.FindOption()
result, mgsErr := mgs.MongoGoSearch(query, opts)
entity, err = collection.Find(context.TODO(), result.Filter, findOpts)

AR: entity is not found.
How can I find the entity by the query? I understand that it is not found because "warehouseId" is an ObjectId, not a string.
As a workaround, I can do this:
filter := result.Filter["$and"][0].(map[string]interface{})
filter ["warehouseId"]=primitive.ObjectIDFromHex(filter ["warehouseId"])
entity, err = collection.Find(context.TODO(), result.Filter, findOpts)

AR: entity is found.
I see that for this purpose Casters exist, but it doesn't have an OBJECT_ID caster.
Is there any other way to find the entity by the query?
If not, do you agree that this functionality is required? If you agree but don't have time to implement it, we can discuss the design here and I will prepare a PR. The easiest way would be to just add a new caster OBJECT_ID, but I think this is not the best solution because it will create a dependency on the MongoDB driver. I think an extension point can be created to avoid dependency on the driver.

Hi @voronovmaksim,
Thank you for reporting this issue and for your kind words about the tool.
I agree that adding functionality to handle ObjectId casting is necessary. I appreciate your detailed workaround.
I will analyze this further to see how we can implement an extension point to handle ObjectId casting without tightly coupling it to the MongoDB driver. It’s indeed important to avoid such dependencies to keep the tool as flexible and independent as possible.
I’m planning to release a new version in a few days that should address this issue. In the meantime, if you have a solution or enhancement, please feel free to submit a PR. Your contribution would be greatly appreciated.
Thank you again for your feedback and for taking the time to help improve the tool.

Hi @voronovmaksim,
I have released version 1.1.0, which includes support for ObjectID. There are a few small changes in how it is used, so please make sure to check the updated documentation for details.
I would appreciate it if you could test this new version and provide your feedback.
Thank you very much for reporting the initial issue.
Looking forward to your comments and test results.

Hi @ajclopez,
Thanks a lot for implementing the feature so quickly.
I have checked it for the simple case mentioned above, and it works. Thank you. It is enough for me.
I want to note that I haven't checked it for more complicated cases like $exists, AND, OR, and so on. My application doesn't require these right now.
I want to help make your tool better, so let me highlight my concern about your implementation:

What if a client like me has a document with a STRING field that looks like an OID but is actually a STRING in MongoDB? As I see it, Primitives.ObjectID(val string)(oid interface{}, err error) is always called, so there is no way to recognize whether the field type is STRING or OID. Therefore, I cannot decide whether to cast it to OID or not. As I understand, to cover this case, I will be forced to use a caster with "<STRING_FIELD>": mgs.STRING to avoid calling Primitives.ObjectID(val string)(oid interface{}, err error). In my humble opinion, this is not a good practice.

If I had implemented this feature, I would have used casters. I would add a new caster like OID, and only if the caster is set, your new method would be called.

I would change the signature of the new method to ObjectID(ctx context.Context, oidStr string) (interface{}, error). This would allow clients to pass any data to the extension point. It would require a lot of changes, so I don't think it is necessary right now. it's just a suggestion for the future.

Hi @voronovmaksim,
Thank you for testing and for your feedback. The main idea behind the implementation is to infer data types. In the case of ObjectId, it depends on the MongoDB drivers. The use of casters is intended for situations where you need to force the type, as you mentioned. However, if a client uses the library and tries to search by "_id", which are always ObjectID, then they will always have to implement a caster.
Now, if someone uses a string similar to a MongoDB ObjectID, the use of casters is intended for that. Another example would be if you have a collection where you store phone numbers in E164 format, for example, +17252800241, as a string in your collection. However, when you use the library, it will infer it as a number. In this case, you would need to tell the library that your field for the phone number is a string through the use of caster.
I will take your suggestion into account in the future if I need to adjust the library. Please feel free to report any other issues you encounter.
Thank you again for your contributions and for helping me improve the library.

@ajclopez Hi.
FYI: The same issue i faced for primitive.Decimal128

Hi @voronovmaksim,
Apologies for the delayed response! Could you please open a new issue for this since this one is already closed? And of course, feel free to submit a PR with the fix!


MoveToMapPokemon / MoveToFort cycling

Actual Behavior
move_to_map_pokemon is cycling again (last release seem to have solved it):

[MoveToMapPokemon] [INFO] [move_to_map_pokemon_encounter]
[MoveToFort] [INFO] [moving_to_fort]
[MoveToMapPokemon] [INFO] [move_to_map_pokemon_move_towards]
then 1) again...

Your FULL config.json (remove your username, password, gmapkey and any other private info)
http://pastebin.com/JTUPEe98
Output when issue occurred
http://pastebin.com/AfUcZhgw
Other Information
OS: OSX Maverick
Branch: dev
Git Commit: aaaa4807299fc7647a76fd3ba9829664b96f88a7
Python Version: Python 2.7.12

@Gurzeh can you verify your commit please

you mean
git fetch upstream

All good mate, it just wasn't linking to a commit.  It will be fixed in #4115

Duplicate of #4113


BIC-228 # Some Forms dont show client side errors

change action view to use Backbone.View#listenTo
Track status of enhancement in ErrorSummaryView

Problem was caused by the listener for a stale view still being in the models listener hash. no idea why I used model#on rather than view#listenTo :O

I'm sure we're doing this throughout Forms as well.

Is there some amount of automated testing that could be added for this?

i didnt think it warranted tests, but ive added one for the isEnhanced flag

LGTM :+1:
Something we should think about is whether a value should be a property or a Backbone.Model attribute. It would probably be useful to discuss some sort of convention around this.

Generally I think all those things should be in a backbone.Model, as that is really the purpose of the models, however, in this particular case the model is the current form, adding an isEnhanced flag to it doesnt make sense... I wasnt too keen on using the flag on the view, but it does make sense given our current setup, even if its not ideal.
and with BIC the other problem we have is that for (i think) every view, its the same model - the interaction.
I have been wondering if a ViewModel for the views would be useful... would defs be worth looking at what we have in light of what we have learnt

ux review from ray


Not seeing anything

I have a site and have added uCop however when I go to the tag I don't see anything is there something I am missing?

Hi William,
thanks for reporting this issue. We released uCop just yesterday so there are definitely some problematic corner cases still to be discovered!
I suspect this is caused by some weird backend data type / content configuration that we didn't account for, and the callback that the page is making returns an error. Could you open the Chrome Developer Tools (F12) whilst on the page, and do a reload? Then, on the network tab, you should see a call to DocumentTypes:

Could you check what status code it is returning? Should return 200 OK and you should see the raw data there in JSON. My suspicion is that you will see a status code of 500 and the contents should tell us more about the problem. If there is an error with a stacktrace then please do post it here.
Other things to check would be - did you add permissions to yourself under the user menu? I think you have otherwise I don't think you'd be able to see the page at all :) Could you also let me know what Umbraco version you are running?
Thanks,
Ondrej.

Ok I can see the call unfortuntely my status is pending (after 5 minutes) it could be due to the sheer amount of nodes that we have on the site (over 10,000). I will leave it to run in the browser to see what happens and let you know

Ok after the browser crashed it took 4.5 minutes to load 2mb is size
Perhaps an indicator would help here to show something is loading

Blimey! You must have a pretty large site!
The problem is that it streams the whole site structure at once, which is quite a feat on itself (especially in your case), and it is also doing some post-processing in the browser once it receives the data, so it must have just ground to halt either during the transmission or during the post-processing.
I'll need to improve the performance and scaleability so that it can handle sites of your size. And showing an indicator is a great idea!
Out of curiosity, when you say you have over 10k nodes, is that document types or content?
Thanks again for bringing this issue up and I'll update the ticket once this is addressed.

Content As I have a quite a few pages made up of several nodes

Hi William,
a new release should appear here on GitHub shortly. Could you test it and let me know if it helped?
What it's doing now is just displaying 10 links per document type and you can load the whole set on demand. Should reduce the file size for you dramatically.
Also added a progress indicator ;)
Cheers,
Ondrej.

An big improvement only 1.5 minutes :) and the indicator certainly helped.
Only other improvement I can think of is maybe cache the site structure in the current session until the user refreshes. ie if you navigate away and then come back you have to wait until everything downloads again. Apart from that however can see this being very useful to quickly see what is what on the site


Error when loading Lora weights in example notebook.

System Info
Running on Colab using T4 GPU but I've run into this issue aswell on a RTX4090 with other models. Using the example found in examples/int8_training/Finetune_flan_t5_large_bnb_peft.ipynb, specifically the cell where the adapters are loaded from the hub.
Who can help?
No response
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder
[ ] My own task or dataset (give details below)

Reproduction
import torch
from peft import PeftModel, PeftConfig
from transformers import AutoModelForSeq2SeqLM, AutoTokenizer

peft_model_id = "ybelkada/flan-t5-large-financial-phrasebank-lora"
config = PeftConfig.from_pretrained(peft_model_id)

model = AutoModelForSeq2SeqLM.from_pretrained(config.base_model_name_or_path, torch_dtype="auto", device_map="auto")
tokenizer = AutoTokenizer.from_pretrained(config.base_model_name_or_path)

# Load the Lora model
model = PeftModel.from_pretrained(model, peft_model_id)

Getting the following error:
TypeError                                 Traceback (most recent call last)
[<ipython-input-2-b64e9cbc4a96>](https://localhost:8080/#) in <cell line: 6>()
      4
      5 peft_model_id = "ybelkada/flan-t5-large-financial-phrasebank-lora"
----> 6 config = PeftConfig.from_pretrained(peft_model_id)
      7
      8 model = AutoModelForSeq2SeqLM.from_pretrained(config.base_model_name_or_path, torch_dtype="auto", device_map="auto")

[/usr/local/lib/python3.10/dist-packages/peft/config.py](https://localhost:8080/#) in from_pretrained(cls, pretrained_model_name_or_path, subfolder, **kwargs)
    132
    133         kwargs = {**class_kwargs, **loaded_attributes}
--> 134         config = config_cls(**kwargs)
    135         return config
    136

TypeError: LoraConfig.__init__() got an unexpected keyword argument 'enable_lora'

Expected behavior
Model weights should load.

Hi, this notebook is kinda old and the generated files stored on https://huggingface.co/ybelkada/flan-t5-large-financial-phrasebank-lora don't work anymore. However, if you run the notebook yourself and save the weights on your own Hugging Face repo or locally, it will work fine.

There is no direct support for loading those old adapters. One thing you could do which may work: Download the repo to a  local folder, edit the adapter_config.json and remove the line "enable_lora": null,, then try to load the model from your local folder instead of from HF. If that works, you can create your own HF repo and upload the "fixed" version there for the future.

This solved the issue. I also had to remove a few other parameters that were giving the same error. Thank you so much for your help! :)

+1 we ran into this issue as well. There are a lot of (old) adapters in the wild that still have this parameter. e.g. https://huggingface.co/hfl/chinese-llama-2-lora-7b/blob/main/adapter_config.json#L4
Would be great if we can make this a backwards compatible change

https://huggingface.co/tloen/alpaca-lora-7b/discussions/8
The issue also has arisen from this repo, but it seems like it's not yet merged.


Why Razor is part of MVC? Can we make a Razor website without MVC?

Makes no sense.

Why does it matter?

Kinda resembles the logic behind the decision to release ASP.NET Core MVC first without releasing a simple basic ASP.NET Core. So many people I've spoken to hate the fact that .NET Core comes without a straightforward non frameworked ASP/PHP option.
I wanna be able to write Razor without having to include MVC logic with it. It just doesn't make sense (at least from a technical/architectural POV).

Why does it matter?

Because you can only have MVC once in the DI system and the pipeline :)

Kinda resembles the logic behind the decision to release ASP.NET Core MVC first without releasing a simple basic ASP.NET Core. So many people I've spoken to hate the fact that .NET Core comes without a straightforward non frameworked ASP/PHP option.

Razor Pages solves that problem in ASP.NET Core 2.0. It's pretty much what you want. As for it being coupled to "MVC", that should have no effect on your experience with it. If if makes you feel any better, it's built on top of the same primitives in MVC because we want the exact same feature set. The only difference is the "dispatcher".

Because you can only have MVC once in the DI system and the pipeline :)

This won't solve that problem. It's a much more fundamental problem than whatever this supposed decoupling would achieve.

Why Razor is part of MVC

It's not, Razor is a language, and is used to generate code. MVC's view engine is an implementation.

Can we make a Razor website without MVC?

Yes, you will have to implement it.


add Politeknik Manufaktur Bandung

University website**
https://polman-bandung.ac.id/
Proof as the university uses the domain**
https://polman-bandung.ac.id/tentang-kami/

@rafzarf First stage of verification passed, official domain is polman-bandung.ac.id as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@rafzarf Pull request merged. Thank you.


Update enforcement.md

Docker example with enforcement was fetching the yaml policy without enforcement, that's fixed with this cange.

Thanks for taking the time to fix this, @jrfastab could you take a look?


feat: support rspack

Description
This PR adds an rspack export to the package, using unplugin's experimental rspack support.
Linked Issues
This has not been brought up yet.
Additional context
rspack just recently added support for vue-loader. As far as I have tested it, this works flawlessly. Having Vue support in rspack was a good occasion to look for rspack support in some popular build tools that commonly come with Vue projects.

Here's also a basic proof of concept of a Vue app bundled by Rspack, using this PR's branch for auto-importing: https://github.com/loilo/rspack-vue-demo


Java creates an incorrect pipeline proto when core-construction-java jar is not in the CLASSPATH

Seems like Java ends up creating incorrect pipeline API proto segments when "core-construction-java" is not available in the system.

For example, this may create  a GBK transform without the URN.

This can be reproduced by running the wordcount example in [1] after  removing the following dependency from the pom.xml file.
<dependency>
      <groupId>org.apache.beam</groupId>
      <artifactId>beam-runners-core-construction-java</artifactId>
      <version>${beam.version}</version>
    </dependency>

Seems like this is because Java is unable to register corresponding XYZTranslation classes (for example [2]).
I think we should fail here instead of generating default incorrect proto segments.

[1] https://github.com/chamikaramj/multi-language-pipelines
[2] https://github.com/apache/beam/blob/master/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/GroupByKeyTranslation.java

Imported from Jira BEAM-12807. Original Jira may contain additional context.
Reported by: chamikara.

Agreed. We should fail if we have a primitive that cannot be translated. Is this still occurring? /cc @lukecwik @robertwb who may have some context on the portable translation recent state of affairs.

Any reason why we don't merge most of these into sdks/java/core and make classes package private?
I feel as though we have a lot of modules like core-construction-java or java-fn-execution that don't add more dependencies but are split up into separate modules making the code organization more complex then necessary.

Agree. The separation of core-construction-java was to keep protobuf out of the core dependencies. That is clearly obsolete. The separation of java-fn-execution I don't know. I assume it had something to do with the SDK harness and runners sharing the logic there?

To mitigate this, we should have all the runners depend on core-construction so it is always on the classpath.

(until we feel like taking the time to merge the modules)


chore: rename Jarred-Sumner/bun

The Organization name had been changed.
https://github.com/Jarred-Sumner/bun to https://github.com/oven-sh/bun

Thanks!

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.62.0


If there's no navigation, fallback doesn't produce anything

Does @timiwahalahti have a clue?
https://github.com/digitoimistodude/air-light/blob/a75b9f6fe8c9dfb39b534973942e86b025da6797/template-parts/header/navigation.php#L36

Never mind, it works in production version. Sorry!


Custom input

Is it possible to use a custom input component?

Hi,
Reading the docs: yes.
DOCS

this doesn't work if the custom component is a functional component. Gives me Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

this doesn't work if the custom component is a functional component. Gives me Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

Hi, its happening with me to, did you discover how to fix it?

Same here, anyone knows how to fix it?

I don’t quite remember but probably using a regular class component or forking this and refactor code to support hooks and what not.

Same here, anyone knows how to fix it?

Just use class Component for you custom Input


esp-tls mbedtls - leakage of open sockets when connection to host failed (IDFGH-8378)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v4.4.2
Operating System used.
Linux
How did you build your project?
VS Code IDE
If you are using Windows, please specify command line type.
No response
Development Kit.
ESP32-WROOM + ETH W5500 SPI
Power Supply used.
External 3.3V
What is the expected behavior?
correct closure of a socket after calling  esp_tls_conn_destroy in case of a failed connection to the server using esp_tls_conn_new_sync   esp-tls and mbedtls.
What is the actual behavior?
despite calling
esp_tls_conn_destroy
socket is not closed so that the number of available sockets is exhausted and no other connection can be established
in log can be observed a message
E (72500) esp-tls: Failed to create socket (family 2 socktype 1 protocol 0)
Steps to reproduce.
my configuration
eth module to connect to AWS MQTT using esp-aws-iot,  esp-tls,  mbedtls
tls configuration set to non blocking mode  non_block = true in esp_tls_cfg_t
the connection to the MQTT server must be blocked to simulate connection problems e.g. with a firewall.
other network traffic such as DNS should work
step 1 - attempt to connect to esp_tls_conn_new_sync server (failed -host unreachable)
step 2 - esp_tls_conn_destroy
repeat the above until all available sockets are taken and you see the message in the log
esp-tls : Failed to create socket (family 2 socktype 1 protocol 0)
at this point no network connection can be established anymore
Debug Logs.
D (47002) esp-tls: [sock=62] Resolved IPv4 address: <IP_ADDRESS>
D (47008) esp-tls: [sock=62] Connecting to server. HOST: qwertyuiop1234-ats.iot.eu-central-1.amazonaws.com, Port: 8883
D (47019) esp-tls: connecting...
D (47191) spi_master: Allocate RX buffer for DMA
D (50022) esp-tls: select() timed out
W (50022) esp-tls: Failed to open new connection in specified timeout
D (52829) esp-tls: host:qwertyuiop1234-ats.iot.eu-central-1.amazonaws.com: strlen 49
D (52898) esp-tls: [sock=63] Resolved IPv4 address: <IP_ADDRESS>
D (52899) esp-tls: [sock=63] Connecting to server. HOST: qwertyuiop1234-ats.iot.eu-central-1.amazonaws.com, Port: 8883
D (52905) esp-tls: connecting...
D (55908) esp-tls: select() timed out
W (55908) esp-tls: Failed to open new connection in specified timeout
D (58432) spi_master: Allocate RX buffer for DMA
D (60156) esp-tls: host:qwertyuiop1234-ats.iot.eu-central-1.amazonaws.com: strlen 49
E (60164) esp-tls: Failed to create socket (family 2 socktype 1 protocol 0)
E (60171) esp-tls: Failed to open new connection
D (67124) esp-tls: host:qwertyuiop1234-ats.iot.eu-central-1.amazonaws.com: strlen 49
E (67132) esp-tls: Failed to create socket (family 2 socktype 1 protocol 0)
E (67139) esp-tls: Failed to open new connection
D (70771) spi_master: Allocate RX buffer for DMA
D (72113) esp-tls: host:qwertyuiop1234-ats.iot.eu-central-1.amazonaws.com: strlen 49
E (72121) esp-tls: Failed to create socket (family 2 socktype 1 protocol 0)
E (72128) esp-tls: Failed to open new connection
D (72492) esp-tls: host:qwertyuiop1234-ats.iot.eu-central-1.amazonaws.com: strlen 49
E (72500) esp-tls: Failed to create socket (family 2 socktype 1 protocol 0)
E (72507) esp-tls: Failed to open new connection

More Information.
Proposed solution
This line
https://github.com/espressif/esp-idf/blob/1b16ef6cfc2479a08136782f9dc57effefa86f66/components/esp-tls/esp_tls_mbedtls.c#L256
should be replaced with
if (tls->is_tls && tls->server_fd.fd != -1) {
This has been successfully tested by me on the above example
The problem was introduced during the resolution of this bug #6163
An incorrect assumption was made, that the socket would be closed by calling mbedtls_net_free
Unfortunately, if the connection to the server fails (e.g. host is unreachable), mbedtls_net_context   struct is not initialised - the previously opened socket is not assigned to fd  thus can't be closed by mbedtls.
socket number is assigned to fd in this place
https://github.com/espressif/esp-idf/blob/1b16ef6cfc2479a08136782f9dc57effefa86f66/components/esp-tls/esp_tls_mbedtls.c#L67-L73
but it's only invoked after connection is established
https://github.com/espressif/esp-idf/blob/1b16ef6cfc2479a08136782f9dc57effefa86f66/components/esp-tls/esp_tls.c#L413-L414
Unfortunately the connection will not always be established
Someone is experiencing similar problems https://esp32.com/viewtopic.php?t=29821

@klaudiusz223 Thanks for reporting and suggesting the fix. We will raise an internal MR.

v4.3 fix: 3a92e82e9749110ae03ba95e0c5bd16332393fbc

@AxelLin Yes, when ctx->fd is -1, mbedtls_net_free() will return directly. But it will make tls->sockfd to be -1, and make original socket fd not be closed.