ActsInRelation::MissingRoleError というエラーが出ました。

➜  git:(master) ✗ rails s
=> Booting WEBrick
=> Rails 4.2.4 application starting in development on http://localhost:3000
=> Run `rails server -h` for more startup options
=> Ctrl-C to shutdown server
Exiting
User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/acts_in_relation-0.2.2/lib/acts_in_relation/core.rb:44:in `acts_in_relation': ActsInRelation::MissingRoleError (ActsInRelation::MissingRoleError)
  from test_app/app/models/user.rb:8:in `<class:User>'
  from test_app/app/models/user.rb:1:in `<top (required)>'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:457:in `load'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:457:in `block in load_file'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:647:in `new_constants_in'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:456:in `load_file'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:354:in `require_or_load'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:494:in `load_missing_constant'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:184:in `const_missing'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/inflector/methods.rb:261:in `const_get'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/inflector/methods.rb:261:in `block in constantize'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/inflector/methods.rb:259:in `each'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/inflector/methods.rb:259:in `inject'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/inflector/methods.rb:259:in `constantize'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:566:in `get'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:597:in `constantize'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise.rb:292:in `get'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise/mapping.rb:81:in `to'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise/mapping.rb:76:in `modules'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise/mapping.rb:93:in `routes'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise/mapping.rb:160:in `default_used_route'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise/mapping.rb:70:in `initialize'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise.rb:326:in `new'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise.rb:326:in `add_mapping'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise/rails/routes.rb:238:in `block in devise_for'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise/rails/routes.rb:237:in `each'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise-3.5.5/lib/devise/rails/routes.rb:237:in `devise_for'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/devise_token_auth-0.1.37/lib/devise_token_auth/rails/routes.rb:25:in `mount_devise_token_auth_for'
  from test_app/config/routes.rb:3:in `block in <top (required)>'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/actionpack-4.2.4/lib/action_dispatch/routing/route_set.rb:434:in `instance_exec'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/actionpack-4.2.4/lib/action_dispatch/routing/route_set.rb:434:in `eval_block'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/actionpack-4.2.4/lib/action_dispatch/routing/route_set.rb:412:in `draw'
  from test_app/config/routes.rb:1:in `<top (required)>'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:268:in `load'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:268:in `block in load'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:240:in `load_dependency'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:268:in `load'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/application/routes_reloader.rb:40:in `block in load_paths'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/application/routes_reloader.rb:40:in `each'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/application/routes_reloader.rb:40:in `load_paths'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/application/routes_reloader.rb:16:in `reload!'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/application/routes_reloader.rb:26:in `block in updater'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/file_update_checker.rb:75:in `call'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/file_update_checker.rb:75:in `execute'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/application/routes_reloader.rb:27:in `updater'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/application/routes_reloader.rb:7:in `execute_if_updated'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/application/finisher.rb:69:in `block in <module:Finisher>'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/initializable.rb:30:in `instance_exec'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/initializable.rb:30:in `run'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/initializable.rb:55:in `block in run_initializers'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/tsort.rb:226:in `block in tsort_each'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/tsort.rb:348:in `block (2 levels) in each_strongly_connected_component'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/tsort.rb:429:in `each_strongly_connected_component_from'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/tsort.rb:347:in `block in each_strongly_connected_component'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/tsort.rb:345:in `each'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/tsort.rb:345:in `call'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/tsort.rb:345:in `each_strongly_connected_component'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/tsort.rb:224:in `tsort_each'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/tsort.rb:203:in `tsort_each'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/initializable.rb:54:in `run_initializers'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/application.rb:352:in `initialize!'
  from test_app/config/environment.rb:5:in `<top (required)>'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:274:in `require'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:274:in `block in require'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:240:in `load_dependency'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:274:in `require'
  from test_app/config.ru:3:in `block in <main>'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/builder.rb:55:in `instance_eval'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/builder.rb:55:in `initialize'
  from test_app/config.ru:in `new'
  from test_app/config.ru:in `<main>'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/builder.rb:49:in `eval'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/builder.rb:49:in `new_from_string'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/builder.rb:40:in `parse_file'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/server.rb:299:in `build_app_and_options_from_config'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/server.rb:208:in `app'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/commands/server.rb:61:in `app'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/server.rb:336:in `wrapped_app'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/commands/server.rb:139:in `log_to_stdout'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/commands/server.rb:78:in `start'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:80:in `block in server'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:75:in `tap'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:75:in `server'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/railties-4.2.4/lib/rails/commands.rb:17:in `<top (required)>'
  from test_app/bin/rails:9:in `require'
  from test_app/bin/rails:9:in `<top (required)>'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/spring-1.6.2/lib/spring/client/rails.rb:28:in `load'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/spring-1.6.2/lib/spring/client/rails.rb:28:in `call'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/spring-1.6.2/lib/spring/client/command.rb:7:in `call'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/spring-1.6.2/lib/spring/client.rb:28:in `run'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/spring-1.6.2/bin/spring:49:in `<top (required)>'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/spring-1.6.2/lib/spring/binstub.rb:11:in `load'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/spring-1.6.2/lib/spring/binstub.rb:11:in `<top (required)>'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
  from User/user_name/.rbenv/versions/2.2.3/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
  from test_app/bin/spring:13:in `<top (required)>'
  from bin/rails:3:in `load'
  from bin/rails:3:in `<main>'

@andoromeda :role が指定されていないことが原因だと考えられます。
acts_in_relation メソッドはどのように呼び出していますか？
ref: https://github.com/kami-zh/acts_in_relation/blob/master/lib/acts_in_relation/core.rb#L44

動かしてたプロジェクトを消してしまったので、同じではないかもですが確かめてみます

問題が確認できた際にissueを開けていただければまた対応できるかと思います :)


Fix empty ingress annotations

Change ingress annotations from null to empty dict

The nginx-ingress is already installed on my cluster, so it will fail if I enable it.
My issue is the rancher manager way of releasing helm charts. It merges the chart`s values.yaml and the values what you set during the release.
The nginx.annotations is null and null merged with a {} (dict) will result a null.
Not sure but I think this can be reproduced also if you release without annotations and upgrade with annotations.

@davividal @jCOTINEAU
is there anything else I can do to merge?

hello @zoltanlaczko, i created this PR that will trigger tests on our side.
In the meantime is see there are small conflicts with your PR, could you fix them?


fix compiler error if EEPROM is used

See Issue 28 on ESPAsync_WiFiManager_Lite.

It seems much better now. Merging. Will create new release ASAP.
Thanks

Hi @hmueller01
The new ESP_WiFiManager_Lite releases v1.10.3 has just been published. Your contribution is noted in Contributions and Thanks
Best Regards,

Release v1.10.3

Fix compiler error if EEPROM is used. Check fix compiler error if EEPROM is used #33


Resolves: Add native GitHub security and versioning dependency alerts

add dependabot.yml which automatically enables Dependabot's dependency versioning scanner and dependency update PRs bot by declaring dependency ecosystems and sources in the project. For dependency security vulnerabilities scanner and vulnerable dependency update PRs bot, enable "Dependabot alerts" and "Dependabot security updates"

use the target-branch attribute, if you would like to run Dependabot's scan against a branch other than your default branch (for example if you have a separate development branch)

should you decide that certain people on your team should take care of the PRs that Dependabot creates, use the two attributes assignees and reviewers to automatically set personnel respectively.

Resolves #1560

Thanks for the contribution! We'll need to investigate this proposal a bit further. Let's resolve that conversation in the issue first.


Cell randomly losing focus, view jumping (reopening #12863)

Environment data

VS Code version: 1.88.1
Jupyter Extension version (available under the Extensions sidebar): v2024.3.1
Python Extension version (available under the Extensions sidebar): v2024.4.1
Pylance Extension: v2024.6.1
OS (Windows | Mac | Linux distro) and version: Windows 10
Python and/or Anaconda version: Python 3.9.13
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Jupyter server running: N/A

Expected behaviour
Uninterrupted editing of Notebooks
Actual behaviour
Whenever an autosave occurs or whenever the notebook is saved with Ctrl-S, the current cell loses focus and the notebook scrolls to a  random place. This makes VSC more or less unusable.
During the save, the "Problems" box is updated. The location to which the notebook scrolls often (but not always) seems to be related to the position of the errors displayed in the Problems box.
The issue has been described comprehensively in bug report 12863, but was auto-closed without resolution.
Unfortunately I cannot access Github or upload any files from my work laptop where the issue occurs. I cannot reproduce the issue on my personal laptop, despite running the same versions of VSC, Jupyter, Python and Pylance.
Steps to reproduce:
See above. The issue has been described comprehensively in 12863.

Following. Same issue here.

closing in favor of https://github.com/microsoft/vscode-jupyter/issues/12863 since that has videos that show the issue

@amunger Though this is closed, #12863 is marked as resolved, and so I can't comment. I just want to chime in and say that this has started happening to me this year. At first, it was only on VSCode in the cloud, when launching from AML, so I switched to using VSCode with the remote extension, and that worked for a while. Now it's happening again. Do you know of any workaround currently? It's driving me nuts and really breaking the flow

Currently my workaround is to disable Autosave. Which obviously isn’t a solution – but at least I can use Jupyter NBs for demos and tests now and then.
From: David Morton @.>
Sent: Wednesday, August 14, 2024 10:00 PM
To: microsoft/vscode-jupyter @.>
Cc: thobitz @.>; Author @.>
Subject: Re: [microsoft/vscode-jupyter] Cell randomly losing focus, view jumping (reopening #12863) (Issue #15797)
@amunger https://github.com/amunger  Though this is closed, #12863 https://github.com/microsoft/vscode-jupyter/issues/12863  is marked as resolved, and so I can't comment. I just want to chime in and say that this has started happening to me this year. At first, it was only on VSCode in the cloud, when launching from AML, so I switched to using VSCode with the remote extension, and that worked for a while. Now it's happening again. Do you know of any workaround currently? It's driving me nuts and really breaking the flow
—
Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode-jupyter/issues/15797#issuecomment-2289873374 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOFVG32UKOSBPXVS5KRPPTZRPAMLAVCNFSM6AAAAABJ4KHHTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZHA3TGMZXGQ .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/AEOFVG3UXLMCAMZW7CBMWCDZRPAMLA5CNFSM6AAAAABJ4KHHTGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUIPSY54.gif Message ID: @.*** @.***> >

oh, sorry, didn't realize the conversation was still locked, I've unlocked https://github.com/microsoft/vscode-jupyter/issues/12863


package capitalization: NgSpice?

The capitalization of this package seems a bit odd. NgSpice, NGSpice, or NgSPICE all seem better. It's generally easier to fix these things early rather than later on when there are lots of entanglements.

In the manual and website they have preferred Ngspice. So I followed the same convention to be consistent.

In the manual and website they have preferred Ngspice. So I followed the same convention to be consistent.

I've renamed the repo. I'll leave the rest to you.

I've renamed the repo. I'll leave the rest to you.

I've changed all Ngspice in the repo to NgSpice.

I've changed all Ngspice in the repo to NgSpice.


Input text hidden behind search icon

The search text is hidden behind the search icon. It seems like the paddin-left: 44px property was overridden and thus not in effect.
Wagtail version: 2.12.2
Django version:  3.1.6
Wagtail autocomplete version: 0.6

@ARogovskyy this should be fixed once https://github.com/wagtail/wagtail-autocomplete/pull/84 is merged


Update baseof template

I use this template and I realized via Google Lighthouse that the <meta name="description" content="">
tag was missing. Also, I updated the link to the internal templates doc.

Update comments about internal templates
Add missing meta description for SEO

Let me know if the PR needs more work.

This covers https://github.com/theNewDynamic/gohugo-theme-ananke/issues/238


remove owner.email from our database & code

Is this something we never exposed publicly? r=me if so

@jyn514 jep, also we don't get it from the crates.io API any more.
( I'm also removing the name, since we don't use that one)

cc https://rust-lang.zulipchat.com/#narrow/stream/356853-t-docs-rs/topic/owner.20emails.3F
(btw @syphar, for changes that these that happen because of a zulip conversation, it would be very helpful for me if you could link the conversation so I know this has past discussion.)

(btw @syphar, for changes like these that happen because of a zulip conversation, it would be very helpful for me if you could link the conversation so I know this has past discussion.)

Yeah, you're absolutely right.


[TritonCTS] Updated the clock_tree_synthesis command

Now works without supplying res_sqr or cap_sqr. It uses the values from the DB instead. Also sets a default max_cap and max_slew based on the slew_inter and cap_inter.

Since a couple of tools use the set_wire_rc command to set parasitic information, I tried something similar with the on-the-fly characterization of TritionCTS. After looking into the implementation a bit, it seems it wasn't needed to actually run the command. Instead, I put a small piece of code based on the Resizer/FastRoute layer RC calculations.


Japanese: implementation of duration attribute

The Japanese language model currently supports DateTime attribute, which mostly covers those expressions that can be either Time or Duration. However, there are certain expressions that can definitely be considered Duration, and detecting them would be helpful in both medical/clinical and standard text.

I found this issue while working on issue #221. Duraion attribute detection is simpler than Negation expansion, so I will resolve this issue first.


Iksolver reset to none

This is likely the same issue as https://github.com/personalrobotics/prpy/issues/111, but it appears also in the master version of prpy. After running [Jen's branch] (https://github.com/personalrobotics/ada_meal_scenario/tree/feature/action_framework) once, the iksolver is reset to none probably in some clone-bindings, and the planners that use an iksolver fail.

Mostly a note to self...the problem is that CloneBindings only gets called
the first time an environment is used as a clone target. We need to
manually clear parent pointers in the target environment in prpy.Clone.
On Fri, Apr 10, 2015 at 11:55 PM Stefanos Nikolaidis <
<EMAIL_ADDRESS>wrote:

This is likely the same issue as #111
https://github.com/personalrobotics/prpy/issues/111, but it appears
also in the master version of prpy. After running Jen's branch
https://github.com/personalrobotics/ada_meal_scenario/tree/feature/action_framework
once, the iksolver is reset to none probably in some clone-bindings, and
the planners that use an iksolver fail.
—
Reply to this email directly or view it on GitHub
https://github.com/personalrobotics/prpy/issues/114.

Resolved with https://github.com/personalrobotics/prpy/commits/bugfix/CloneUserData


Added log format support to prometheus spec

What this PR does / why we need it:
It adds support for setting the log format of prometheus so prometheus can log in json format.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/ok-to-test

/lgtm

/lgtm


Not Building

Hi,
I've tryed to build tensorflow from source because I need OpenCL support.
The environment was successfully setted as in the guide but the build did not end correctly.
I'm running Ubuntu 16.04, I've tryed to build both with GCC and Clang. The output provided here is with CLANG.
If you need addictional informations please ask, I really need TF to work on this computer.
Thank you
$ bazel version
Build label: 0.4.3
Build target: bazel-out/local-fastbuild/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Dec 22 12:31:25 2016<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>
Errors.txt

We are just trying to reproduce this at the moment.

@lorenzo93  Does it compile fine without --config=sycl ?

@lukeiwanski Without the parameter just build fine with GCC6 and G++6.
As you sad in the other issue I tryied also to downgrade GCC6 header to GCC5.
(Don't know if is correct but I just installed gcc-5 g++-5 and when ./configure asked the compilers i gave it /usr/bin/gcc-5 and /usr/bin/g++-5)
During this compilation the error was different, you can find the file in the attachments.
Errors
Thank you very much for your help! :)

/usr/lib/gcc/x86_64-linux-gnu/6.2.0/../../../../include/c++/6.2.0/bits/stl_vector.h:914:7: note:
you are still using GCC6 headers

I'm sorry but I'm not so used to work with linux.
I've setted the default GCC and G++ link to gcc-5 and g++-5 and build it but is still using the 6th version.
I've also tryed to unistall gcc6 but seems to be required by bazel.
It seems that is bazel calling the wrong gcc bin, someone is telling to change the CROSSTOOL file changin manually the gcc path.
I modified third_party/sycl/crosstool/CROSSTOOL.tpl file but the compiler is still using GCC6.
How can I switch correctly GCC version?

Did you re-configur project after modifying hird_party/sycl/crosstool/CROSSTOOL.tpl?

Yes, but I checked and the modification is still there.
The only change I made to that file was on line 45 making the path pointing directly to gcc5 include folder.
CROSSTOOL


AWS Regions

Add AWS regions with

[ ] Friendly names
[ ] Location flag emojis as icon

done in #19


Add some security blogs and the oracle one

@uberspot Sorry that it took a time to check all your list, but we really check all links before merging and it's been a very busy week. Could you send all links one by one as PR? Because this was a very good list and we want to make sure each link is really interesting.

It would take too much time to create 8 PRs right now. :/ You can review them offline if you want and add just the ones you want as a simple commit from your account, it's ok. :)
Here's an extra security/engineering blog http://daniel.haxx.se/blog

@uberspot thanks :) I'll be more happy if you create the PRs, but if you don't have time tomorrow as well, I'll surely add some of those links. :+1:


bug: cannot install api client with npm

Overview
npm install @opentrons/api-client

as described here does not work.
Steps to reproduce
see above
Current behavior
$ npm install @opentrons/api-client
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@opentrons%2fapi-client - Not found
npm ERR! 404
npm ERR! 404  '@opentrons/api-client@*' is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

Expected behavior
No response
Operating system
Mac
System and robot setup or anything else?
latest

@rickwierenga
Actually, we don't register @opentrons/api-client on npm.
The only way to install @opentrons/api-client is to clone this repo and build api-client and run npm install or yarn add to install the package to your project.


Acceptance tests don't work in py3

Summary
The atest structures were never converted to be py3 compatible.
Immediate fix
Replace mix of bytes and string comparisons with all strings. Replace all print keywords with print function calls. Fix unichr calls.
Long term fix
Setup CI against py3.x, so that these issues can be caught.

I have some of the fixes above in this branch.

Acceptance tests runner side working only with Python 2 is actually by design. There are no real benefits in supporting both Python 2 and Python 3 when you anyway must have both available to be able to test the framework itself on both of them. More importantly, there are absolutely no benefits in spending time testing that such code works with both Python 2 and Python 3.
Instead of changing the code to work both with Python 2 and Python 3, we should make it Python 3 only. This avoids all the annoyances required when writing Python 2 and 3 compatible code, removes the need to test on both variants, and makes it possible for us to use all the goodies Python 3 has. I'd actually go as far as saying that we can make the runner side Python 3.6+ only to be able to use the great f'string' syntax. That's what I already did with https://github.com/robotframework/rellu/.
The CI issue is important. We used to have comprehensive CI but it was maintained by a company not involved with Robot Framework anymore. Back then we executed tests with Python (2.6-3.5), Jython and IronPython on Linux and Windows, and AFAIK this is not something Travis can provide. I'm fairly certain we get CI organized somehow via Robot Framework Foundation, but I've got other more important tasks and haven't spent time with that. I hopefully have time to start RF 3.1 development this autumn and then working CI is a must.

Ah, that makes a lot of sense.
I wasn't aware robot was planning on dropping py2 support with more than a year left of py2 support. Glad to hear it though!
Travis only supports linux and osx. I don't know of a free to open-source CI tool that currently includes windows as an os option. I've only used gitlab ci, travis and shippable and know that shippable has windows support on their roadmap.
os:
  - linux
  - osx

I will close this issue as it is invalid. Would you like me to leave the pull open as a half-measure until a more comprehensive Robot Framework Foundation guided implementation can be added?

We aren't planning to drop Py2 support! From dev point of view it would be awesome, but from community perspective it would be a disaster.
It just doesn't matter what language we use with development tools and utilities. At the moment our own stuff is mainly Python 2, but we could (and should) use Python 3 too. They could as well be written using Ruby, Perl, or anything else, but I can assure you that's not going to happen. :)
If you are interested, run_atest.py could be converted to Python 3(.6). What I don't like is these tools to get any more complicated in order to support both Py 2 and 3, and to lose the ability to use Py 3(.6) goodies.
CI is something I'd like to discuss more. Can we do it on Slack?


I'm not sure how Github decides the nesting. I could try pulling perf-tests out to its own YML but I'm not sure if that'll break something else in ci.yml and it'd eat up CI cycles figuring out how it works

          > I'm not sure how Github decides the nesting. I could try pulling `perf-tests` out to its own YML but I'm not sure if that'll break something else in `ci.yml` and it'd eat up CI cycles figuring out how it works

I suspect it'd work though 🤔

This might be a task for Yaml @jamilbk .
Originally posted by @thomaseizinger in https://github.com/firezone/firezone/issues/4598#issuecomment-2052698274

Closing for reason


Implement normalize! for the Canonical form of AbstractMPO

This is currently not implemented and needs to. There's surely a way to update all the lambdas without the need to recanonize.

This was fixed in PR #255.


Add 'pluginlib' package

I've followed this guide step by step carefully. [Yes]

I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":

https://ci.appveyor.com/project/kgeorgiev93/hunter/builds/26467505
https://travis-ci.com/kgeorgiev93/hunter/builds/121909466

I have submitted CI configs to https://github.com/ingenue/hunter targeting pkg.template branch,
see this merged pull request https://github.com/ingenue/hunter/pull/386

My change is part of this "New package" request: https://github.com/ruslo/hunter/issues/1397

Testing:

https://ci.appveyor.com/project/ingenue/hunter/builds/26492520
https://travis-ci.org/ingenue/hunter/builds/568180220?utm_source=github_status&utm_medium=notification

Released: https://github.com/ruslo/hunter/releases/tag/v0.23.207


Cyberpunk2k20 v2

Changes / Comments
Change start value of 4 button for new api script compatibility
!test is removed replace by !damage and !wp-damage
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

You need to update your fork with the current roll20 master

how I can do that please?

The GitHub has an option below to resolve conflicts. You can walk through that process or resolve them locally.

Cassie

This pull request is being closed due to unresolved merge conflicts. If you wish to proceed please resolve merge conflicts with master and submit the pull request again.
Thank you,
Cassie


pkg/oscap: refactor & clean up

The oscap tailoring and remediation configs were too tightly coupled with the osbuild stage implementations. These configs can be refactored further by making the TailoringConfig a pointer on the
RemediationConfig, reversing the dependency of the configs.
These changes should reduce the complexity of the OpenSCAP stage options and hopefully reduce some of the confusion too.
Thanks to @thozza for the suggestion

Yes, this is much nicer.

Thanks, I guess I was too close to the code and @thozza made a great suggestion and helped me zoom out a bit and untangle this... so big thanks to him for that! 🙏


  For testing purposes only.
2020-10-06T07:16:35.489140213+01:00 stderr F       --kubelet-port int                                        The port to use to connect to Kubelets. (default 10250)
2020-10-06T07:16:35.48919251+01:00 stderr F       --kubelet-preferred-address-types strings                 The priority of node address types to use when determining which address to use to connect to a particular node (default [Hostname,InternalDNS,InternalIP,ExternalDNS,ExternalIP])
2020-10-06T07:16:35.489250455+01:00 stderr F       --log-flush-frequency duration                            Maximum number of seconds between log flushes (default 5s)
2020-10-06T07:16:35.48931453+01:00 stderr F       --log_backtrace_at traceLocation                          when logging hits line file:N, emit a stack trace (default :0)
2020-10-06T07:16:35.489366475+01:00 stderr F       --log_dir string                                          If non-empty, write log files in this directory
2020-10-06T07:16:35.489455661+01:00 stderr F       --log_file string                                         If non-empty, use this log file
2020-10-06T07:16:35.489513495+01:00 stderr F       --logtostderr                                             log to standard error instead of files (default true)
2020-10-06T07:16:35.489566866+01:00 stderr F       --metric-resolution duration                              The resolution at which metrics-server will retain metrics. (default 1m0s)
2020-10-06T07:16:35.489618497+01:00 stderr F       --profiling                                               Enable profiling via web interface host:port/debug/pprof/ (default true)
2020-10-06T07:16:35.489999594+01:00 stderr F       --requestheader-allowed-names strings                     List of client certificate common names to allow to provide usernames in headers specified by --requestheader-username-headers. If empty, any client certificate validated by the authorities in --requestheader-client-ca-file is allowed.
2020-10-06T07:16:35.490103262+01:00 stderr F       --requestheader-client-ca-file string                     Root certificate bundle to use to verify client certificates on incoming requests before trusting usernames in headers specified by --requestheader-username-headers. WARNING: generally do not depend on authorization being already done for incoming requests.
2020-10-06T07:16:35.49017493+01:00 stderr F       --requestheader-extra-headers-prefix strings              List of request header prefixes to inspect. X-Remote-Extra- is suggested. (default [x-remote-extra-])
2020-10-06T07:16:35.490236782+01:00 stderr F       --requestheader-group-headers strings                     List of request headers to inspect for groups. X-Remote-Group is suggested. (default [x-remote-group])
2020-10-06T07:16:35.490288394+01:00 stderr F       --requestheader-username-headers strings                  List of request headers to inspect for usernames. X-Remote-User is common. (default [x-remote-user])
2020-10-06T07:16:35.490346006+01:00 stderr F       --secure-port int                                         The port on which to serve HTTPS with authentication and authorization.If 0, don't serve HTTPS at all. (default 443)
2020-10-06T07:16:35.490399173+01:00 stderr F       --skip_headers                                            If true, avoid header prefixes in the log messages
2020-10-06T07:16:35.490468248+01:00 stderr F       --stderrthreshold severity                                logs at or above this threshold go to stderr
2020-10-06T07:16:35.490588324+01:00 stderr F       --tls-cert-file string                                    File containing the default x509 Certificate for HTTPS. (CA cert, if any, concatenated after server cert). If HTTPS serving is enabled, and --tls-cert-file and --tls-private-key-file are not provided, a self-signed certificate and key are generated for the public address and saved to the directory specified by --cert-dir.
2020-10-06T07:16:35.490679177+01:00 stderr F       --tls-cipher-suites strings                               Comma-separated list of cipher suites for the server. If omitted, the default Go cipher suites will be use.  Possible values: TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_RSA_WITH_RC4_128_SHA,TLS_RSA_WITH_3DES_EDE_CBC_SHA,TLS_RSA_WITH_AES_128_CBC_SHA,TLS_RSA_WITH_AES_128_CBC_SHA256,TLS_RSA_WITH_AES_128_GCM_SHA256,TLS_RSA_WITH_AES_256_CBC_SHA,TLS_RSA_WITH_AES_256_GCM_SHA384,TLS_RSA_WITH_RC4_128_SHA
2020-10-06T07:16:35.490763474+01:00 stderr F       --tls-min-version string                                  Minimum TLS version supported. Possible values: VersionTLS10, VersionTLS11, VersionTLS12
2020-10-06T07:16:35.490829531+01:00 stderr F       --tls-private-key-file string                             File containing the default x509 private key matching --tls-cert-file.
2020-10-06T07:16:35.490994292+01:00 stderr F       --tls-sni-cert-key namedCertKey                           A pair of x509 certificate and private key file paths, optionally suffixed with a list of domain patterns which are fully qualified domain names, possibly with prefixed wildcard segments. If no domain patterns are provided, the names of the certificate are extracted. Non-wildcard matches trump over wildcard matches, explicit domain patterns trump over extracted names. For multiple key/certificate pairs, use the --tls-sni-cert-key multiple times. Examples: "example.crt,example.key" or "foo.crt,foo.key:*.foo.com,foo.com". (default [])
2020-10-06T07:16:35.491083793+01:00 stderr F   -v, --v Level                                                 number for the log level verbosity
2020-10-06T07:16:35.491137238+01:00 stderr F       --vmodule moduleSpec                                      comma-separated list of pattern=N settings for file-filtered logging
2020-10-06T07:16:35.491184924+01:00 stderr F
2020-10-06T07:16:35.49127237+01:00 stderr F panic: Get https://<IP_ADDRESS>:443/api/v1/namespaces/kube-system/configmaps/extension-apiserver-authentication: dial tcp <IP_ADDRESS>:443: i/o timeout
2020-10-06T07:16:35.491343241+01:00 stderr F
2020-10-06T07:16:35.491395038+01:00 stderr F goroutine 1 [running]:
2020-10-06T07:16:35.491450835+01:00 stderr F main.main()
2020-10-06T07:16:35.491500873+01:00 stderr F    /go/src/github.com/kubernetes-incubator/metrics-server/cmd/metrics-server/metrics-server.go:39 +0x10c

No idea how- / why this could've made 'everything work', but I basically (for the first time since installing k3s):

copied the kube config to my computer (for remotely accessing the k3s cluster from computer)
and allowed the cluster port (default 6443) through the firewall with ufw

After accessing the cluster remotely, via vscode kubernetes extension, I started noticing that the kube-system pods recovering to running states. First via vs code extension, and then validated with kubectl on the PI:
kubectl get pods -n kube-system
NAME                                     READY   STATUS      RESTARTS   AGE
helm-install-traefik-qr2bd               0/1     Completed   0          5d11h
svclb-traefik-kjbbr                      2/2     Running     8          5d11h
traefik-758cd5fc85-8s9qf                 1/1     Running     1          12h
coredns-7944c66d8d-qwxjf                 1/1     Running     1          12h
metrics-server-7566d596c8-nnzg2          1/1     Running     33         12h
local-path-provisioner-6d59f47c7-4hvf2   1/1     Running     35         12h

With this working, it was also possible to view the cluster with ingress from my Traefik dashboard:

No explanation why this could've recovered the pods to recovered states (don't nearly have enough of an idea what goes on in the inner-workings of k3s system pods), but this is all I saw. If someone is still able to provide some clarity on why / how this happened, that would also be great for future reference.


Service unstable?

Hi @alanshaw!
I just found that I keep getting error like Internal Server Error on https://david-dm.org, and the image/badge is also unavailable. Is there anything I can help? Thanks!

@alanshaw anything anyone can do to help on this?

@alanshaw same issues over a month already

any news? it is getting really bad

No offense, if, I mean if, if there is no any updates, maybe we can try to host another one in the meantime.

I have very limited time to work on david outside of my day job and I'm trying to work on this whenever I can so please be patient.
I believe the most recent downtime was that the david module was upgraded to use<EMAIL_ADDRESS>whereas the website was still using<EMAIL_ADDRESS>I've now updated the website so they're both using the same version. Hopefully that'll help.
The wider issue is that the site is popular, and doing a lot of work on every request. It depends on two external services (github+npm) that sometimes respond slowly to requests. Many requests to david and slow responses from github and/or npm causes a backlog that is difficult for it to clear, causing it to be unable to respond to requests in a reasonable time. The two need to be decoupled so that david can respond quickly to requests, and update dependency information in the background. I'm working to address this.

@alanshaw thank you very much for your reply, at least we know what the problem is, if you need support or help, maybe could also let us know and we can see what we can help, thanks for your great work on it!

@alanshaw I think the consensus feeling here is not that we're frustrated by your lack of time to work on this. Really want to emphasize – even overemphasize if possible – how thankful we are that you do any of this at all.
Rather, I think we'd just love to see what's frustrating you or blocking you right now, raw and out in the open. That way we can help to share the load. It ain't heavy if we help!

Thanks @JoshSmith those kind of comments make it worth while 😄

Closing as stability has resumed. Thanks for reporting and all your comments 🥇

Awesome thank you for all your hard work on this @alanshaw. :raised_hands:

@alanshaw The issues continue, this is yesterday and today when trying to go anywhere

and this

Yesterday it worked here briefly and after half hour it went just as fast.
I was able to visit the basic https://david-dm.org page but anything else like badges https://david-dm.org/Style-it-Themes/dd-wrt-inspired-themes?type=dev
is at best random mixed bag of results.


Cannot cache serializer with Carrierwave Uploader attribute

When caching is enabled on a serializer that has an attribute defined for a Carrierwave Uploader, a TypeError: no _dump_data is defined for class Proc is thrown.
# app.serializers/user_serializer.rb

class UserSerializer
  include FastJsonapi::ObjectSerializer

  set_type :users
  cache_options enabled: true

  attributes :id, :avatar
end

# app/models/user.rb

class User < ApplicationRecord
  mount_uploader :avatar, AvatarUploader
end

# app/uploaders/avatar_uploader.rb

class AvatarUploader
class AvatarUploader < CarrierWave::Uploader::Base
  include CarrierWave::MiniMagick

  version :thumb do
    process resize_to_fill: [300, 300]
    process quality: 85
  end

  def store_dir
    "uploads/#{model.class.to_s.underscore}/#{mounted_as}/#{model.id}"
  end

  def extension_whitelist
    %w[jpg jpeg png]
  end

  def content_type_whitelist
    %r{image/}
  end

  def default_url(*_args)
    ActionController::Base.helpers.asset_path('placeholder.png')
  end

  def exists?
    default_url != url
  end

  def as_json(options = {})
    super.merge(exists: exists?)
  end
end

Here's the trace:
TypeError: no _dump_data is defined for class Proc
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 807, in dump
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 807, in marshaled_value
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 787, in should_compress?
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 718, in initialize
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 445, in new
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 445, in block in write
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 663, in block in instrument
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/notifications.rb", line 170, in instrument
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 663, in instrument
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 444, in write
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 697, in save_block_result_to_cache
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache.rb", line 323, in fetch
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 67, in record_hash
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 148, in block (3 levels) in get_included_records
  File "/app/vendor/bundle/ruby/2.5.0/gems/activerecord-5.2.0/lib/active_record/relation/delegation.rb", line 41, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/activerecord-5.2.0/lib/active_record/relation/delegation.rb", line 41, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 132, in block (2 levels) in get_included_records
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 118, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 118, in block in get_included_records
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 116, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 116, in each_with_object
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 116, in get_included_records
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 139, in block (3 levels) in get_included_records
  File "/app/vendor/bundle/ruby/2.5.0/gems/activerecord-5.2.0/lib/active_record/relation/delegation.rb", line 41, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/activerecord-5.2.0/lib/active_record/relation/delegation.rb", line 41, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 132, in block (2 levels) in get_included_records
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 118, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 118, in block in get_included_records
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 116, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 116, in each_with_object
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/serialization_core.rb", line 116, in get_included_records
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/object_serializer.rb", line 57, in block in hash_for_collection
  File "/app/vendor/bundle/ruby/2.5.0/gems/activerecord-5.2.0/lib/active_record/relation/delegation.rb", line 41, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/activerecord-5.2.0/lib/active_record/relation/delegation.rb", line 41, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/object_serializer.rb", line 55, in hash_for_collection
  File "/app/vendor/bundle/ruby/2.5.0/gems/fast_jsonapi-1.4/lib/fast_jsonapi/object_serializer.rb", line 31, in serializable_hash
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/core_ext/object/json.rb", line 54, in as_json
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/json/encoding.rb", line 22, in encode
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/json/encoding.rb", line 22, in encode
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/core_ext/object/json.rb", line 41, in to_json
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/renderers.rb", line 157, in block in <module:Renderers>
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/renderers.rb", line 150, in block in _render_to_body_with_renderer
  File "/app/vendor/ruby-2.5.3/lib/ruby/2.5.0/set.rb", line 338, in each_key
  File "/app/vendor/ruby-2.5.3/lib/ruby/2.5.0/set.rb", line 338, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/renderers.rb", line 146, in _render_to_body_with_renderer
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/renderers.rb", line 142, in render_to_body
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/abstract_controller/rendering.rb", line 25, in render
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/rendering.rb", line 36, in render
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/instrumentation.rb", line 46, in block (2 levels) in render
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/core_ext/benchmark.rb", line 14, in block in ms
  File "/app/vendor/ruby-2.5.3/lib/ruby/2.5.0/benchmark.rb", line 308, in realtime
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/core_ext/benchmark.rb", line 14, in ms
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/instrumentation.rb", line 46, in block in render
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/instrumentation.rb", line 87, in cleanup_view_runtime
  File "/app/vendor/bundle/ruby/2.5.0/gems/activerecord-5.2.0/lib/active_record/railties/controller_runtime.rb", line 31, in cleanup_view_runtime
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/instrumentation.rb", line 45, in render
  File "/app/app/controllers/api/v1/projects_controller.rb", line 15, in current
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/basic_implicit_render.rb", line 6, in send_action
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/abstract_controller/base.rb", line 194, in process_action
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/rendering.rb", line 30, in process_action
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/abstract_controller/callbacks.rb", line 42, in block in process_action
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/callbacks.rb", line 109, in block in run_callbacks
  File "/app/vendor/bundle/ruby/2.5.0/gems/react-rails-2.4.4/lib/react/rails/controller_lifecycle.rb", line 31, in use_react_component_helper
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/callbacks.rb", line 118, in block in run_callbacks
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/callbacks.rb", line 136, in run_callbacks
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/abstract_controller/callbacks.rb", line 41, in process_action
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/rescue.rb", line 22, in process_action
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/instrumentation.rb", line 34, in block in process_action
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/notifications.rb", line 168, in block in instrument
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/notifications/instrumenter.rb", line 23, in instrument
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/notifications.rb", line 168, in instrument
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/instrumentation.rb", line 32, in process_action
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal/params_wrapper.rb", line 256, in process_action
  File "/app/vendor/bundle/ruby/2.5.0/gems/activerecord-5.2.0/lib/active_record/railties/controller_runtime.rb", line 24, in process_action
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/abstract_controller/base.rb", line 134, in process
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionview-5.2.0/lib/action_view/rendering.rb", line 32, in process
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal.rb", line 191, in dispatch
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_controller/metal.rb", line 252, in dispatch
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/routing/route_set.rb", line 52, in dispatch
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/routing/route_set.rb", line 34, in serve
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/journey/router.rb", line 52, in block in serve
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/journey/router.rb", line 35, in each
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/journey/router.rb", line 35, in serve
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/routing/route_set.rb", line 840, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/warden-1.2.7/lib/warden/manager.rb", line 36, in block in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/warden-1.2.7/lib/warden/manager.rb", line 35, in catch
  File "/app/vendor/bundle/ruby/2.5.0/gems/warden-1.2.7/lib/warden/manager.rb", line 35, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/tempfile_reaper.rb", line 15, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/etag.rb", line 25, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/conditional_get.rb", line 25, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/head.rb", line 12, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/http/content_security_policy.rb", line 18, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/session/abstract/id.rb", line 232, in context
  File "/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/session/abstract/id.rb", line 226, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/middleware/cookies.rb", line 670, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/middleware/callbacks.rb", line 28, in block in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/callbacks.rb", line 98, in run_callbacks
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/middleware/callbacks.rb", line 26, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rollbar-2.16.2/lib/rollbar/middleware/rails/rollbar.rb", line 24, in block in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rollbar-2.16.2/lib/rollbar.rb", line 146, in scoped
  File "/app/vendor/bundle/ruby/2.5.0/gems/rollbar-2.16.2/lib/rollbar/middleware/rails/rollbar.rb", line 22, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/middleware/debug_exceptions.rb", line 61, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rollbar-2.16.2/lib/rollbar/middleware/rails/show_exceptions.rb", line 22, in call_with_rollbar
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/middleware/show_exceptions.rb", line 33, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/rack/logger.rb", line 38, in call_app
  File "/app/vendor/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/rack/logger.rb", line 26, in block in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/tagged_logging.rb", line 71, in block in tagged
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/tagged_logging.rb", line 28, in tagged
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/tagged_logging.rb", line 71, in tagged
  File "/app/vendor/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/rack/logger.rb", line 26, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/middleware/remote_ip.rb", line 81, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/middleware/request_id.rb", line 27, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/method_override.rb", line 22, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/runtime.rb", line 22, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.0/lib/active_support/cache/strategy/local_cache_middleware.rb", line 29, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/middleware/executor.rb", line 14, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/middleware/static.rb", line 127, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/sendfile.rb", line 111, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.0/lib/action_dispatch/middleware/ssl.rb", line 74, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/rack-cors-1.0.2/lib/rack/cors.rb", line 97, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/engine.rb", line 524, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/puma-3.11.4/lib/puma/configuration.rb", line 225, in call
  File "/app/vendor/bundle/ruby/2.5.0/gems/puma-3.11.4/lib/puma/server.rb", line 632, in handle_request
  File "/app/vendor/bundle/ruby/2.5.0/gems/puma-3.11.4/lib/puma/server.rb", line 446, in process_client
  File "/app/vendor/bundle/ruby/2.5.0/gems/puma-3.11.4/lib/puma/server.rb", line 306, in block in run
  File "/app/vendor/bundle/ruby/2.5.0/gems/puma-3.11.4/lib/puma/thread_pool.rb", line 120, in block in spawn_thread

Solution was to use a custom attribute convert the uploader to json.
# app.serializers/user_serializer.rb

class UserSerializer
  include FastJsonapi::ObjectSerializer

  set_type :users
  cache_options enabled: true

  attributes :id

  attributes :avatar do |object|
    object.avatar.as_json
  end
end


Captions and switch from "gallery" to "images" style fancybox

Signed-off-by: leecalcote<EMAIL_ADDRESS>

Ready to be  merged sir @leecalcote

Thanks, @gunjanmimo.


fix(instr-fetch): do not enable in Node.js; clarify in docs this instr is for web fetch only

A side issue from https://github.com/open-telemetry/opentelemetry-js/issues/4496 was the mistaken use of instrumentation-fetch for Node.js's fetch(). instrumentation-fetch does not intend to handle Node.js's fetch.
This change makes it so instrumentation-fetch will noop when used in Node.js.
Refs: https://github.com/open-telemetry/opentelemetry-js/issues/4496

Theoretically I think instrumentation-fetch should be able instrument Node.js fetch, but currently it is written with dependencies on a web otel package and its tests assume web/browser. See https://github.com/open-telemetry/opentelemetry-js/issues/4333 for discussion on instrumenting Node.js' fetch().

There is this PR that is relevant:
https://github.com/open-telemetry/opentelemetry-js/pull/4393


Why connect ETIMEDOUT?

{ stack: 'Error: Redis connection to <IP_ADDRESS>:6379 failed - connect ETIMEDOUT\n  at RedisClient.flush_and_error (/srv/node_modules/redis/index.js:149:13)\n  at RedisClient.on_error (/srv/node_modules/redis/index.js:191:10)\n  at Socket.<anonymous> (/srv/node_modules/redis/index.js:106:14)\n  at Socket.emit (events.js:95:17)\n  at net.js:440:14\n  at process._tickDomainCallback (node.js:463:13)\n',
  message: 'Redis connection to <IP_ADDRESS>:6379 failed - connect ETIMEDOUT' }

Some job success , other job failed?
code as follow(coffeescript)
kue     = require 'kue'
config  = require '../config'
jobs    = kue.createQueue config.kue

jobs.on 'error', (e) ->
  console.log 'kue jobs error'
  console.log e

the error shows your connection to redis server is timed out. check your server not crashed, and connection to <IP_ADDRESS> is healthy

redis server not crashed, some job connect redis success, other job connect redis failed, I guess network cause!!!

you should check your connectivity stability then....

@behrad  Could you recommend a reconnection handling when this kind of error happens?

I believe this should be handled by node_redis / ioredis modules inside kue.


Missing items in Cold War

On the step where you make the Clockwork Penguin in your POH, you require a Plank and Silk in addition to the clockwork or steel bar. The plugin does not reflect this properly.
I believe it's around this line in the code:
https://github.com/Zoinkwiz/quest-helper/blob/e69a40117c10940a2b9d8970c8138e3f809dfb40/src/main/java/com/questhelper/quests/coldwar/ColdWar.java#L77

Thanks for raising, added with https://github.com/Zoinkwiz/quest-helper/commit/d866f6fbb385378fdec64a7ec3d7e05f6609ceeb


OpenAPI Spec Linting

Adds github action to check for uncommitted changes for api
Jira: https://issues.redhat.com/browse/ARO-6276

Ah /retest doesn't work, I think you should rebase to pull in your latest changes

Should be good now with one more rebase


UnsupportedChainIdError

In web3-react, we are able to catch errors during activation or network change, and check the type of the error, for example:
import { UnsupportedChainIdError } from '@web3-react/core'
// ...

function Component () {
  const { error } = useWeb3React()
  const isUnsupportedChainIdError = error instanceof UnsupportedChainIdError
  // ...
}

It's not clear from the documentation as to how we can achieve the same thing. Is it possible to do this in useDapp?

Hi @jacobedawson , your example is catch error in UnsupportedChainIdError. I don't think why my app only can not catch this error. Do you have more example?


Fix send message error when MessageType unspecified.

Even if the proxy config set  enableTopicMessageTypeCheck false, sending a message always throw an error.

Codecov Report

Merging #358 (8a0c696) into master (2ff904e) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master     #358   +/-   ##
=========================================
  Coverage     33.94%   33.95%
  Complexity      643      643
=========================================
  Files           220      220
  Lines         11439    11442    +3
  Branches        277      278    +1
=========================================
+ Hits           3883     3885    +2
  Misses         7306     7306
- Partials        250      251    +1

Flag
Coverage Δ

java
60.66% <66.66%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ache/rocketmq/client/java/message/MessageType.java
38.88% <66.66%> (+3.59%)
:arrow_up:

...e/rocketmq/client/java/route/MessageQueueImpl.java
76.31% <66.66%> (-1.47%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@echooymxq  Producer will get the settings from the proxy, which contains the config of validateMessageType. you can debug the settings the client received.

@echooymxq Producer will get the settings from the proxy, which contains the config of validateMessageType. you can debug the settings the client received.

@aaron-ai Hi, what i mean is if the proxy return the topic unspecified  message type(in most cases, never will be happen), even though not validate message type, it always send message error. you can also see the golang implementation.

@echooymxq Actually route data of each topic should have its message type explicitly, could you describe it clearly?
When does the proxy return unspecified message type?

@aaron-ai thank your patient reply, there are some potential point ???
// ClusterMetadataService#getTopicMessageType
public TopicMessageType getTopicMessageType(String topic) {
      TopicConfigAndQueueMapping topicConfigAndQueueMapping;
      try {
          topicConfigAndQueueMapping = topicConfigCache.get(topic);
      } catch (Exception e) {
         // Potential point ???
          return TopicMessageType.UNSPECIFIED;
      }
      if (topicConfigAndQueueMapping.equals(EMPTY_TOPIC_CONFIG)) {
          // Potential point ???
          return TopicMessageType.UNSPECIFIED;
      }
      return topicConfigAndQueueMapping.getTopicMessageType();
  }

i will close this pr firstly until you think it's necessary.

@echooymxq you could create an issue to track it in rocketmq's repo. In rocketmq 5.0, route data of each topic should have its message type explicitly, so UNSPECIFIED should never be considered.

@aaron-ai thank your patient reply, there are some potential point ???
// ClusterMetadataService#getTopicMessageType
public TopicMessageType getTopicMessageType(String topic) {
      TopicConfigAndQueueMapping topicConfigAndQueueMapping;
      try {
          topicConfigAndQueueMapping = topicConfigCache.get(topic);
      } catch (Exception e) {
         // Potential point ???
          return TopicMessageType.UNSPECIFIED;
      }
      if (topicConfigAndQueueMapping.equals(EMPTY_TOPIC_CONFIG)) {
          // Potential point ???
          return TopicMessageType.UNSPECIFIED;
      }
      return topicConfigAndQueueMapping.getTopicMessageType();
  }

even if return the unspecified MessageType, if we set the validateMessageType false, send message maybe success.

The code means it is not TopicConfig in the cache. The getTopicMessageType will return NORMAL type if the type is unset.


storage inspector?

when i use this addon, in firefox storage inspector I see another source beside the opened page that related to this addon.
no other addon does this.
this is a bit confusing.
can this be fixed?
without this addon

with this addon

no other addon does this.

I'm sure there are others that do this, it's just that LSR is probably the only one you've encountered.

can this be fixed?

No. The storage inspector shows all origins in the page, including iframes. And the LSR popup overlay is an iframe, as that is the only (sane/secure(ish)) way for a WebExtension to have UI elements on top of the page area (you can see the LSR iframe in the inspector, at the bottom with id e0fe7e79ef044e56993c0a0a6874baed).

ok? so the only way to create overlays is iframes( because webexts in firefox made it that way?)
btw I have never encountered this before your addon.(and I have a LOT of addons installed)
maybe adding it as a item to right click menu for links would be better?
but this is your addon. you know best and I wont push for a change.

Well, using an iframe is not the only way, but the main point is that the overlay needs to be part of the page DOM. You can inject any elements, but not encapsulating the overlay in an iframe is much more fragile (wrt. DOM and CSS modification) and also might expose private information (see issue #7).


Use correct "ByteCommandParameter" for three parameters

Using "UshortCommandParameters" for advertisingType, ownAdressType and peerAdressType caused 3 "00"-Bytes extra within the parameter, causing the parameter to be ignored by the Bluetooth device. Changing this to the correct "ByteCommandParameter", the parameter holds 16 Bytes which are accepted by the Bluetooth device. Only by employing this change, the advertisment-Interval can be changed at all.
(Finally both edits in one pull request...)

Thank you for this!


Add-PnPCustomAction : A parameter cannot be found that matches parameter name ‘ClientSideComponentId’.

I have faced the issue with:
“Add-PnPCustomAction : A parameter cannot be found that matches parameter name ‘ClientSideComponentId’.”
I have tried both created own .sppkg file and run this cmd,
Add-PnPCustomAction -ClientSideComponentId “xxxxxxxxxxxx” -Name “Analytics” -Title “Analytics” -Location ClientSideExtension.ApplicationCustomizer -ClientSideComponentProperties: ‘{“trackingID”:”UA-my-own-id”}’ -Scope site.
Please give me a suggestion.
Thanks and Regards,

Could you please make sure the ClientSideComponentId  is correct. If so, please try to remove the quotation marks. For example, Add-PnPCustomAction -ClientSideComponentId xxxx

Worked for me. Thanks for the support


Hierarchically mapping two identical fields

Have you read the project documentation?

[x] Yes, but I am having difficulty understanding it and want clarification.

Describe your question
I'm trying to govert a struct that has two identical fields that need to be hierarchically mapped to two different target fields.
Source code
// goverter:converter
// goverter:extend TimeToTime
type Converter interface {
    ConvertQueueItem(source generated.GetQueueItemsRow) model.PlaybookQueueItem
}

## Input:

type GetQueueItemsRow struct {
	Playbook     Playbook
	Inventory    Inventory
	Repository   Repository
	Repository_2 Repository
}

type Playbook struct {
	ID          int64
	RepoID      int64
	FilePath    string
	DateUpdated *time.Time
}

type Inventory struct {
	ID     int64
	Name   string
	Path   string
	RepoID int64
}

type Repository struct {
	ID                   int64
	Name                 string
	RepoUrl              string
	Branch               string
	ContentType          string
	LastFetch            *time.Time
	LastScan             *time.Time
	PlaybookIncludeRegex *string
	PlaybookExcludeRegex *string
}

---

## Output

type PlaybookQueueItem struct {
	Playbook    *Playbook  `json:"playbook,omitempty"`
	Inventory   *Inventory `json:"inventory"`
}

type Playbook struct {
	ID          int64       `json:"id"`
	FilePath    string      `json:"file_path"`
	DateUpdated *time.Time  `json:"date_updated,omitempty"`
	Repository  *Repository `json:"repository,omitempty"`
}

type Inventory struct {
	ID         int64       `json:"id"`
	Name       string      `json:"name"`
	Path       string      `json:"path"`
	Repository *Repository `json:"repository,omitempty"`
}

type Repository struct {
	ID                   int64      `json:"id"`
	Name                 string     `json:"name"`
	RepoUrl              string     `json:"repo_url"`
	Branch               string     `json:"branch"`
	ContentType          string     `json:"content_type"`
	LastFetch            *time.Time `json:"last_fetch"`
	LastScan             *time.Time `json:"last_scan"`
	PlaybookIncludeRegex *string    `json:"playbook_include_regex"`
	PlaybookExcludeRegex *string    `json:"playbook_exclude_regex"`
}

Errors
I tried several combinations using map and nested mapping but I didn't get it to work properly.
Is there an easier way to achieve this conversion using goverter? Thanks!

Could you be a little more specific with your example, which fields should be mapped to where?

Thanks for the rapid reply!
Ah yeah sorry, I guess it wasn't that obvious. :^)
To successfully map from GetQueueItemsRow to PlaybookQueueItem I need to map
GetQueueItemsRow.Playbook -> PlaybookQueueItem.Playbook
GetQueueItemsRow.Repository -> PlaybookQueueItem.Playbook.Repository
GetQueueItemsRow.Inventory -> PlaybookQueueItem.Inventory
GetQueueItemsRow.Repository_2 -> PlaybookQueueItem.Inventory.Repository
I hope that makes it clearer!

Yeah. You can use autoMap together with map . TARGET to achieve this.
// goverter:converter
// goverter:extend TimeToTime
type Converter interface {
	// goverter:map . Playbook
	// goverter:map . Inventory
	ConvertQueueItem(source generated.GetQueueItemsRow) model.PlaybookQueueItem

	// goverter:autoMap Playbook
	// goverter:map Repository Repository
	// above :map isn't needed, but makes it more obvious
	ConvertPlaybook(source generated.GetQueueItemsRow) model.Playbook

	// goverter:autoMap Inventory
	// goverter:map Repository_2 Repository
	ConvertInventory(source generated.GetQueueItemsRow) model.Inventory
}

I guess I've tried a combination that looked similar, but I honestly can't say for sure.
Thanks for the help, I'll try it on Wednesday when I'll have access to a computer again and will close the issue if it works!

Awesome, it works. Thanks for the help!


Change project name name to 'parseltongue'

If you're going to converse with a Serpent, might as well use the correct word for it, right?
This is meant to be tongue-in-cheek, of course.

Being a mudblood myself, I fear the dark lord just too much. Hence I dropped the idea.


chore: Deprecates React.SFC

Summary of Changes
Swaps React.SFC (Stateless Functional Component) for React.FC (Functional Component) types
Why
React.SFC is now deprecated as mentioned here. This is a simple cleanup of all mentions to React.SFC in our repo.
Tests
Ran tests
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide

Codecov Report

Merging #536 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   81.20%   81.20%
=======================================
  Files         230      230
  Lines        5742     5742
  Branches      682      682
=======================================
  Hits         4663     4663
  Misses       1011     1011
  Partials       68       68

Impacted Files
Coverage Δ

...pplication/static/js/components/Feedback/index.tsx
100.00% <ø> (ø)

...mponents/DashboardPage/QueryListItem/CodeBlock.tsx
100.00% <100.00%> (ø)

...cation/static/js/components/NotFoundPage/index.tsx
100.00% <100.00%> (ø)

...tic/js/components/SearchPage/SearchPanel/index.tsx
100.00% <100.00%> (ø)

...tic/js/components/TableDetail/ColumnList/index.tsx
54.54% <100.00%> (ø)

.../js/components/TableDetail/FrequentUsers/index.tsx
50.00% <100.00%> (ø)

...ic/js/components/TableDetail/LineageLink/index.tsx
46.15% <100.00%> (ø)

...ents/TableDetail/ResourceReportsDropdown/index.tsx
100.00% <100.00%> (ø)

...tic/js/components/TableDetail/SourceLink/index.tsx
62.50% <100.00%> (ø)

...omponents/TableDetail/TableHeaderBullets/index.tsx
100.00% <100.00%> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d843e...7477ded. Read the comment docs.

That said, maybe we shouldn't even use React.FC, as explained here: https://fettblog.eu/typescript-react-why-i-dont-use-react-fc/


Add option for a preview line to textDocument/references

I'm implementing an editor extension that will connect to a language server to display references to a symbol in Sublime.
As specified, the LSP textDocument/references call returns Location[], which just have uri and range information for the symbol references.
There are many situations where the user of a language server would want a preview of the reference. I think this use case might be common enough to warrant modifying LSP to allow for that.
Reasons to include preview with references:

Efficiently accessing many files and extracting lines is harder from editor plugin environments than in a language server process.
Many editors would need a preview for references - Sublime, VSCode, and many others already have this requirement. It seems common enough to warrant an API call.
The Microsoft TypeScript Sublime plugin's bundled TypeScript language server does this.
Servers implementing textDocument/refences need to open the file where the reference occurs already, so would they likely get this for free.

Reasons not to include preview:

For editors like VSCode that support previews via the peek pane, the code and logic for acquiring chunks from different files already exists, so why duplicate code paths.

Open to suggestions, thanks!

Hi @uforic, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Good idea. But I think that the content field should be optional. I would force every language server to provide a content preview.

Thanks for the feedback - I modified the pull request to return the LocationPreview, and made the contents field optional. Let me know if there are any other changes you'd like to see!

This feels heavy-weight. What if it takes work to retrieve those previews (e.g. because the project is too large to fit in the LSP server's memory? or because they require additional disk lookup similar to autocomplete?)
I'm solving this problem by calling textDocument/hover. That's already the part of the LSP that's responsible for generating a preview for a given location in text. I don't think there should be a second place in LSP where previews are generated.

Roger that - I'm wondering how the textDocument/hover idea works; the use case in mind is I find all textDocument/references to struct Foo, and there is a list of Locations[] that are returned.
Ultimately, the UX desires a preview of lines mentioned in the Location[]'s. I suspect if you called "textDocument/hover on the locations returned by textDocument/references, you'd get hover information for struct Foo, not a one-line preview of where the reference occurs.
It definitely takes work to retrieve those previews - hence it being optional. Justification for allowing this option is that however much work it is for the language server to request these files, it is less work and more reasonable for the LS to perform the work then the front-end client (which is usually more resource constrained).

The LocationPreview.contents seems like it just duplicates the first line of the Range. Couldn't a client generate the contents if it wants them?

Hey @rictic , definitely - in a client/server environment, in the case of 50 references found, do we want the client make 50 requests for entire documents and parsing out the right lines (which involves guessing the same encoding as the server), or would we prefer to have the server performing the work. Assumption here is that the client is more resource constrained, not the ideal place to be doing this kind of batch work, and it's common enough that we'd prefer the server to support it. Thoughts?

Couldn't the client read documents on demand, as the user interacts? The protocol assumes that clients are able to access documents, decode them, and understand them in terms of lines and columns.

Agree with @rictic , the protocol already returns enough information for preview to be handled on client-side. For example, Eclipse IDE with LSP4E already gives preview of the line where reference is defined. I don't think this is something that needs to be added to the protocol.

I the server is really needs to be contacted for fetching the preview / parts of the document we might want to consider having a special request for this instead of having this embedded into find references. It might be useful in other places as well.

For the scenario where files are stored remotely not locally, I think there are two completely separate functionalities:

Directory and file contents retrieval, and file-change notification, presumably provided by a server that's co-located with the files.

Language services based on files. This might be an LSP server which uses the file-server to fetch files, or it might be an LSP server which is co-located with the file-server and has access to the same files on disk, or it might be a single JsonRPC server which provides both LSP and file services.

I understand your motivating scenario, @uforic. For instance if we do find-references, and there are references from a 10kloc monster file like in Rosyn https://github.com/dotnet/roslyn/blob/master/src/Compilers/CSharp/Portable/Generated/BoundNodes.xml.Generated.cs, then it'd be crazy to have to fetch 50 files that big merely to display previews.
But fetching file-contents is the job of the file server, not the LSP server. We shouldn't be adding arbitrary file-server-functionality into LSP.
Instead, to fulfill this scenario, I'd expect the fileserver to offer a service like "please fetch this range within this file". It would be fine to issue 50 requests to the server, one after the other, and thanks to HTTP2 it's no worse to send 50 requests then it is to send a single request that gets back an array of 50 strings.
HOWEVER There's a problem that LSP has to knows the translation between byte-offset and line-numbers, but file-servers generally don't.
Maybe LSP should be sending byte-offsets in addition to line+columns, to support this kind of scenario.


Graphics::Printing : DocumentProperties return wrong size

Summary
Hi there,
I'm facing some challenges while trying to retrieve the DEVMODE of a printer using DocumentPropertiesW in Rust. I have existing C++ code that successfully accomplishes this using the standard Windows API. Here's the C++ code for reference:
bool getDevMode(TCHAR* deviceName, DEVMODE** devMode)
{
	HANDLE hPrinter = NULL;
	HWND hWnd = NULL;
	bool res = false;

	// Acquires the printer handle.
	if (OpenPrinter(deviceName, &(hPrinter), NULL) == 0)
		return false;

	// Acquires the DEVMODE structure size.
	DWORD dwNeeded = DocumentProperties(hWnd, hPrinter, deviceName, NULL, NULL, 0);
	if (dwNeeded > 0)
	{
		// Allocates a memory area to acquire DEVMODE structure information.
		*devMode = (LPDEVMODE)malloc(dwNeeded);
		if (*devMode != NULL)
		{
			// Acquires the DEVMODE structure.
			DWORD dwReturned = DocumentProperties(hWnd, hPrinter, deviceName, *devMode, NULL, DM_OUT_BUFFER);
			if (dwReturned > 0)
				res = true;
		}
	}
	// Closes the printer handle.
	if (hPrinter != NULL)
	{
		ClosePrinter(hPrinter);
		hPrinter = NULL;
	}
	return res;
}

I'm trying to reproduce this functionality in Rust, but I've encountered a couple of challenges:

Allocation: I can't find a clear way to allocate memory for a Win32::Gdi::DEVMODEW struct with the correct size. Code samples demonstrating this would be helpful.
Size Mismatch: When I call DocumentPropertiesW with fMode=0 (to retrieve the DEVMODE struct size), it returns 18200. In C++, for the same printer, this size is 228. This significant difference make me think that's there is something worng (or may I do something wrong ?).

Here's my Rust code:
    pub fn get_devmode (&mut self) -> bool {
        unsafe {
            // convert printer name form string
            let pname = PWSTR(self.printer_name.encode_utf16().chain(::std::iter::once(0)).collect::<Vec<u16>>().as_mut_ptr());
            match OpenPrinterW(pname, &mut self.printer_h, None) {
                Ok(_) => {}
                Err(e) => {
                    eprintln!("{e}");
                    return false;
                }
            }
            let hwnd: HWND = HWND::default();
            let size = DocumentPropertiesW(hwnd, self.printer_h, pname,None , None, 0);
            println!("Size : {size}"); // Gave me 18200 (and 17888 with DocumentPropertiesA)
            // Below here's where I don't know what to do, using DEVMODEW::default() result in STATUS_ACCESS_VIOLATION
            // let mut devmode = DEVMODEW::default();
            //let size = DocumentPropertiesW(hwnd, self.printer_h, pname,Some(&mut devmode) , None, DM_OUT_BUFFER.0);
        }
        return true;
    }

Crate manifest
No response
Crate code
No response

How about something like this? Can't guarantee this is the most idiomatic, maybe others have some suggestions.
[dependencies.windows]
version = "0.57.0"
features = [
    "Win32_Foundation",
    "Win32_Graphics_Gdi",
    "Win32_Graphics_Printing"
]

use std::{
    alloc::{alloc, alloc_zeroed, dealloc, Layout},
    mem::align_of,
};

use windows::{
    core::w,
    Win32::{
        Foundation::{HANDLE, HWND},
        Graphics::{
            Gdi::{DEVMODEW, DM_OUT_BUFFER},
            Printing::{DocumentPropertiesW, OpenPrinterW},
        },
    },
};

fn main() -> windows::core::Result<()> {
    unsafe {
        let device_name = w!("Brother MFC-L2740DW series");

        let mut handle = HANDLE::default();
        OpenPrinterW(device_name, &mut handle, None)?;

        let size = DocumentPropertiesW(HWND::default(), handle, device_name, None, None, 0);

        let layout = Layout::from_size_align(size as usize, align_of::<DEVMODEW>()).unwrap();
        let mut devmode = alloc_zeroed(layout) as *mut DEVMODEW;

        let written = DocumentPropertiesW(
            HWND::default(),
            handle,
            device_name,
            Some(devmode),
            None,
            DM_OUT_BUFFER.0,
        );

        dbg!((*devmode).dmYResolution);

        // ...
    }

    Ok(())
}


Added My name in the index html

Added my name and github profile link in the index.html page.

Hey @SuvamPrasd thnx for contributing , Contribute in this year's Hacktoberfest in October 2020 and follow me on Github and Star this repo for updates and notifications about the project.


config.yaml missing in readme

The config.yaml is missing in the readme. There is a config.yaml here, but I don't know if it's the right one?

Thats the right one, yes. For the colplus-ws at least, the colplus-admin server which does the indexing needs a slightly different one. The entire README needs an update to be honest


No mechanism to create empty object.

There doesn't seem to be a mechanism to create an empty dictionary object? Since [] in swift can be interpreted as an empty array or empty object. And,
var json:JSON = JSON([])
creates an empty array, so you can't add properties.
E.g., This would seem to be appropriate, but doesn't work
var json:JSON = JSON()
json["id"].intValue = 123
println(json)
{
"id": 123
}

In Swift, [:] represents an empty dictionary, but SwiftyJSON doesn't have an dictionary-based initializer yet. This should be quite easy to add.

Just checked it: var json:JSON = [:] works, because JSON implements the DictionaryLiteralConvertible protocol.

I think this issue can be closed.

@chschu Any idea why var parcelData : JSON = [:] is throwing me a warning of 'init(nilLiteral:)' is deprecated: use JSON.null instead. Will be removed in future versions.
{Swift 3, Xcode 9.0, SwiftyJSON v3.1.4}

@chschu its resolved...was just xcode bug i guess...sorry & thanks!


"Zombies made:" Broadcast

Hello,
How can i disable this:

I was not a zombie or 049 during that round.

That was intended to be apart of the soon-to-come v2.0 release. I must've mixed up the workspaces or something if that's showing up.

Ah yes, no problem :)
Thanks for the response

No problem, just released v2.0 that has a config option to toggle that. Thank you for your reports! :)


sync other metaphor github image repo template values with aws-github

In https://github.com/kubefirst/gitops-template/commit/cafa37eb633713ce3d38b4aaf82e915d418f0997, the aws-github metaphor chart values were transitioned from
metaphor:
  image:
    repository: ghcr.io/<GITHUB_OWNER>/metaphor

to
metaphor:
  image:
    repository: <CONTAINER_REGISTRY_URL>/metaphor

which ensured the package name was appended. The other providers never received this update, which lead to failure to pull the image when the URI contained only a tag after the repo name without reference to the package name. This PR simply synchronizes this change across providers.

Another option is that the above theory is incorrect and there's some issue in the image push logic (at least in gcp) leading to ghcr.io/ghorg/reponame/reponame:tag instead of just ghcr.io/ghorg/reponame:tag.

It seems like this is almost surely an issue with package creation rather than setting the image uri downstream.


added documentation for deploying SaxML multihost using LWS

What type of PR is this?
/kind documentation

What this PR does / why we need it
Which issue(s) this PR fixes

Fixes #20
Special notes for your reviewer
Does this PR introduce a user-facing change?

/ok-to-test

/lgtm
/approve
/hold
hold in case Rupeng has other comments

/hold cancel


Extend with lazy loading and basic routing features

For my sample app, I have used angular2-router-loader plugin.
I have tried many solutions, but it seems the best, and it works fine with both JiT and with AoT compilation.

closing, solved in Roberto's links, thanks


hot reloading feature doesn't compile

Under Bevy 0.9.1, the asset loading changed.
I think you want main.rs to look something like this:
use bevy::prelude::*;

fn main() {
    DefaultPlugins.build();
    DefaultPlugins.set(AssetPlugin {
        watch_for_changes: true,
        ..Default::default()
    });
    App::new().add_plugins(DefaultPlugins).run();
}

Thanks for the report :)
This has already been fixed in #23, but I didn't make a release yet.
I'll try to do that over the weekend.


pod_util: fix liveness check to use MY_POD_IP

Previously we rely on etcd to listen on localhost:2379.
This is problemantic. We should talk to the interface that it listens to.

lgtm

After trying out this patch, it won't work as expected.
After an etcd pod is created, its liveness section didn't get replaced:
    livenessProbe:
      exec:
        command:
        - /bin/sh
        - -c
        - ETCDCTL_API=3 etcdctl --endpoints=$(MY_POD_IP):2379 get foo

This will cause liveness probe to fail.
From pod events:
{kubelet jenkins-etcd-operator-minion-group-vm4j}	spec.containers{etcd}Warning	Unhealthy	Liveness probe failed: /bin/sh: MY_POD_IP: not found
{kubelet jenkins-etcd-operator-minion-group-vm4j}	spec.containers{etcd}Normal	Killing		Killing container with docker id 9f6db5823442: pod "etcd-cluster-0000_default(1e08b17e-ae7d-11e6-8092-42010af00002)" container "etcd" is unhealthy, it will be killed and re-created.

its liveness section didn't get replaced:

What do you mean?

Oh. I guess we can simply remove liveness checking for self-hosted cluster... we have to set restart.Always anyway... liveness checking is meaningless for self-hosted.

@xiang90
What's the reason behind "restart: Always"?

@xiang90
What's the reason behind "restart: Always"?

I think I explained this before once. So self-hosted cluster need to handle all master nodes restart. If we set it to Never, the pod wont restart.

OK. Made sense.
Let me close this and submit a new PR.


Fix the Real World OCaml link

What does this PR do?
Improve Repo
Description
The current Real World OCaml link returns the 301 Moved Permanently status. The book, however, seems to still be available online. This PR replaces the older obsolete link with the new working one.

Thanks!


fix(quantic): fix citation pop over glitch

SFINT-5291
Before
https://github.com/coveo/ui-kit/assets/86681870/bc2436de-1960-470b-86d1-199fb690f88d
After
https://github.com/coveo/ui-kit/assets/86681870/43a905b1-13be-4e10-83ee-d46593979bb6
The issue
The small space between the citation and the tooltip was the cause of the issue:

When the mouse is in this highlighted space, the mouse thecnically become outside the citation so the tooltip is no longer displayed.
To solve this issue, I removed the ability to hover over a citation, this would allow us to respect the mockups and avoid the glitchy behaviour, more discussion can be found here: https://coveord.atlassian.net/browse/SFINT-5292?focusedCommentId=706476

The fix looks good to me. I just wonder what happens in the case of a keyboard user? Does the tooltip still shows up for screen readers if a user is not using a mouse to hover/focus on the citation? Am I overthinking this? 😅

No no it's a good question, for now we are showing the tooltip only on mouseenter events but I think it wouldn't be that complicated to support showing the tooltip on focus as well if necessary.
But anyways the screen reader always announces the labels of these buttons which is the relevant information that's displayed inside the tooltip.


Add turnCurveGain for Differential

####Summary
Added curves to the turn input in arcade and curvature drives. This helps users customize their driving a little bit more and get better control over their turning in opcontrol.
####Motivation
A lot of teams have their turning curve a little bit different from their linear speed curves.

Download the template for this pull request:

[!NOTE]
This is auto generated from Add Template to Pull Request

via manual download<EMAIL_ADDRESS>via PROS Integrated Terminal:

curl -o<EMAIL_ADDRESS>https://nightly.link/LemLib/LemLib/actions/artifacts/1081726622.zip;
pros c fetch<EMAIL_ADDRESS>pros c apply<EMAIL_ADDRESS>rm<EMAIL_ADDRESS>

The code itself is good. But, I do have a suggestion: take a curve function for both linear and angular movements, instead of just the normal driveCurve

Will merge upon testing

Tested, merging now


document-behaviour-difference-between-amqp-and-sbmp

messageReceiver.CompleteAsync or messageReceiver.Complete() behaves differently between SBMP and AMQP.
/cc @sethmanheim @jtaubensee

Hi @SeanFeldman, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

@SeanFeldman : Thanks for your contribution to the Azure documentation! The author, @sethmanheim, has been notified to review your proposed change.

@sethmanheim - Can you add this to MSDN as well?

MSDN:
https://msdn.microsoft.com/en-us/library/microsoft.servicebus.messaging.messagereceiver.completeasync.aspx
https://msdn.microsoft.com/en-us/library/microsoft.servicebus.messaging.messagereceiver.completebatchasync.aspx

Sure will @jtaubensee. Thanks for the links, @SeanFeldman.

Actually @jtaubensee, for the .NET reference those changes will need to be made in the triple slash comments in the sources.

@sethmanheim - We can go ahead and merge this. I have a code review out for the source/msdn changes.

#sign-off

Only the author of the article can use the sign off comment to add the ready-to-merge label.

@jtaubensee

I have the power... #sign-off


Remove beta Pyyaml dependency

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

Closing due to problems with conflicts. Will open a fresh PR.


[BEAM-5406] Return null when a datetime data element is null.

Null Datetime column values are valid and should be converted to null in the corresponding TableRow
@lukecwik
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

Thanks


Update sys-dm-exec-query-stats-transact-sql.md

It would be helpful to mention that this is in the database/instance timezone (rather than UTC, like query store data)

@rwestMSFT
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks, I'll take a look at refreshing this article and incorporating your change at the same time.