[SPARK-43881][SQL][PYTHON][CONNECT] Add optional pattern for Catalog.listDatabases

What changes were proposed in this pull request?
Currently, the syntax SHOW [NAMESPACES | DATABASES | SCHEMAS] LIKE pattern supports an optional pattern, so as filtered out the expected databases.
But the Catalog.listDatabases missing the function both in Catalog API and Connect Catalog API.
In fact, the optional pattern is very useful.
Why are the changes needed?
This PR want add the optional pattern for Catalog.listDatabases.
Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
New test cases.

ping @cloud-fan @MaxGekk @HyukjinKwon @zhengruifeng cc @amaliujia

Merged to master.

@HyukjinKwon Thank you.


update game model with reviews entity

In this issue, we will update the game models in order to introduce a review entity. This is in response to issue #261 in which we will add a button to make reviews and view the reviews in the game detail page that was made in issue #40. This issue is consistent with the user stories that relate to users reviewing games which can be found here https://github.com/uchicago-cs/chigame/wiki/Games-~-User-Stories#rating-viewing-and-favoriting-games

Made new branch game-management/review-model

Made a new Review entity in the models.py file to account for the reviews that a User leaves on a Game.

This issue is closed as per PR #274. I added a Review model that allows a user to leave reviews and rate games. This issue will be useful in issue #261 where I will make views for reviews


852 | Peak Index in a Mountain Array | C++

Title - Peak Index in a Mountain Array
What will change - Add solution for the problem 852. Peak Index in a Mountain Array in C++
Type of Issue -

[x] Adding New Code

Programming Language

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Can you assign it to me, please?

Hey! I would like to work on this problem.


Xcode 16 report 0% coverage using xcov

I have been using XCode 14 and xcov to report coverage, it was working fine until we moved to Xcode 16.
Gemfile has the following,
gem 'xcov', '1.8.1'
gem 'danger'
gem 'xcresult', '0.2.2'

And how I generate report,
 xcov(
        workspace: "NetworkPolling.xcworkspace",
        scheme: "Local",
        include_targets: "Network.app",
        include_test_targets: false,
        output_directory: outpul_directory,
        derived_data_path: "build/fastlane/derived_data",
        ignore_file_path: ignore_file_path,
        json_report: true,
        skip_slack: true,
      )

Output is
INFO [2024-10-07 08:48:23.70]: $ xcodebuild -showBuildSettings -workspace NetworkPolling.xcworkspace -scheme Local -derivedDataPath build/fastlane/derived_data 2>&1
++
| xcov Coverage Report |
++
++

INFO [2024-10-07 08:48:29.42]: Feature: Local

ERROR [2024-10-07 08:48:29.42]: Network: 0.00% (below minimum coverage of 70.0%)
INFO [2024-10-07 08:48:29.42]: Successfully generated documentation at path '/Users/<USERNAME>/Git/Network/fastlane/README.md'

If I try the same with legacy_support: true
then the output is like this,
INFO [2024-10-07 08:59:59.74]: ▸ Loading...
INFO [2024-10-07 08:59:59.76]: ▸ ------ xcov-core ------
INFO [2024-10-07 08:59:59.76]: ▸ Opening .xccoverage file at path: /Users/<USERNAME>/Git/Network/build/fastlane/xcov_output/Network/xccovreport-0.xccovreport
INFO [2024-10-07 08:59:59.80]: ▸ Parsing .xccoverage file...
INFO [2024-10-07 08:59:59.80]: ▸ Caught: NSInvalidArgumentException: -[_NSInlineData countByEnumeratingWithState:objects:count:]: unrecognized selector sent to instance 0x7fc6c880fa00
------ xcov-core ------
Opening .xccoverage file at path: /Users/<USERNAME>/Git/Network/build/fastlane/xcov_output/Network/xccovreport-0.xccovreport
Parsing .xccoverage file...
Caught: NSInvalidArgumentException: -[_NSInlineData countByEnumeratingWithState:objects:count:]: unrecognized selector sent to instance 0x7fc6c880fa00
ERROR [2024-10-07 08:59:59.80]: Exit status: 1
ERROR [2024-10-07 08:59:59.80]: Failed to execute xcov: Error creating your coverage report - see the log above
INFO [2024-10-07 08:59:59.80]: Successfully generated documentation at path '/Users/<USERNAME>/Git/Network/fastlane/README.md'

We are seeing the same thing 😕 ... did you make any headway?

No @stephengilroy-grx . Still the same.


Vim: Caught deadly signal SEGV (from drawscreen.c)

Steps to reproduce
This is intermittent, happened 2 times out of ~15 tries. Mercurial is configured to run a vim based merge tool (Splice). Splice does configuration when it starts up. There some gtk on the stack, timing issue? The version of vim is less that a week old and I didn't see any recent changes that obviously covered this.
Some gdb output, full backtrace below
(gdb)  up 5
#5  0x000056524e7b781d in update_screen (type_arg=type_arg@entry=40) at drawscreen.c:273
273		if (wp->w_buffer->b_mod_set)
(gdb) p wp
$1 = (win_T *) 0x5652512bc640
(gdb) p wp->w_buffer
$2 = (buf_T *) 0x0

Here's console
$ hg merge tip
merging swingset/CHANGELOG-POMS.txt
4 files to edit
Vim: Caught deadly signal SEGV
Vim: preserving files...
Vim: Finished.
Segmentation fault (core dumped)
merging swingset/CHANGELOG-POMS.txt failed!

Expected behaviour
No SEGV
Version of Vim
9.0.1274
Environment
ubuntu/gtk
Logs and stack traces
(gdb) bt
#0  0x00007fcee004275b in kill () at ../sysdeps/unix/syscall-template.S:120
#1  0x000056524e8a91bc in may_core_dump () at os_unix.c:3511
#2  mch_exit (r=r@entry=1) at os_unix.c:3477
#3  0x000056524ea15316 in getout (exitval=1) at main.c:1750
#4  0x00007fcee0042520 in <signal handler called> () at /lib/x86_64-linux-gnu/libc.so.6
#5  0x000056524e7b781d in update_screen (type_arg=type_arg@entry=40) at drawscreen.c:273
#6  0x000056524e9520a9 in set_shellsize_inner (height=0, mustset=0, width=<optimized out>)
    at term.c:3702
#7  set_shellsize (width=<optimized out>, height=0, mustset=0) at term.c:3740
#8  0x000056524e9ce435 in gui_resize_shell (pixel_width=1796, pixel_height=pixel_height@entry=872)
    at gui.c:1593
#9  0x000056524e9d9872 in form_configure_event
    (widget=<optimized out>, event=0x7ffdeecc8808, data=<optimized out>) at gui_gtk_x11.c:4233
#10 0x00007fcee17e5b77 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#11 0x00007fcee0fadd2f in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#12 0x00007fcee0fc9c36 in  () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#13 0x00007fcee0fcb026 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#14 0x00007fcee0fcb863 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#15 0x00007fcee17ae724 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#16 0x00007fcee1652001 in gtk_main_do_event () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#17 0x000056524e9dec42 in form_send_configure (form=<optimized out>) at gui_gtk_f.c:860
#18 form_size_allocate (widget=0x565250a87260, allocation=0x7ffdeecc88e0) at gui_gtk_f.c:520
#19 0x00007fcee179ee20 in gtk_widget_size_allocate_with_baseline ()
    at /lib/x86_64-linux-gnu/libgtk-3.so.0
#20 0x00007fcee1531812 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#21 0x00007fcee153276c in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#22 0x00007fcee1588d07 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#23 0x00007fcee15327e9 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#24 0x00007fcee179ee20 in gtk_widget_size_allocate_with_baseline ()
    at /lib/x86_64-linux-gnu/libgtk-3.so.0
#25 0x00007fcee17bb78b in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#26 0x00007fcee0fadd2f in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#27 0x00007fcee0fc9895 in  () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#28 0x00007fcee0fcb614 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#29 0x00007fcee0fcb863 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#30 0x00007fcee179f1a2 in gtk_widget_size_allocate_with_baseline ()
    at /lib/x86_64-linux-gnu/libgtk-3.so.0
#31 0x00007fcee17c01b4 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#32 0x00007fcee0fcb700 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#33 0x00007fcee0fcb863 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#34 0x00007fcee1575740 in  () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#35 0x00007fcee0fcb700 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#36 0x00007fcee0fcb863 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#37 0x00007fcee133fbe6 in  () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#38 0x00007fcee132c2ad in  () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#39 0x00007fcee0eb52c8 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#40 0x00007fcee0eb4c44 in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#41 0x00007fcee0f096c8 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#42 0x00007fcee0eb23e3 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#43 0x000056524e9d6290 in gui_mch_update () at gui_gtk_x11.c:6430
#44 0x000056524e9c070e in win_alloc (after=0x0, hidden=hidden@entry=0) at window.c:5513
#45 0x000056524e9bf7f7 in win_split_ins (size=0, flags=0, new_wp=0x0, dir=0) at window.c:5731
#46 0x000056524e7fa597 in ex_splitview (eap=0x7ffdeecc9ae0) at ex_docmd.c:6825
#47 0x000056524e7f3d6e in do_one_cmd
--Type <RET> for more, q to quit, c to continue without paging--c
    (cmdlinep=0x7ffdeecc9ab0, flags=11, cstack=0x7ffdeecc9c68, cookie=0x0, fgetline=<optimized out>) at ex_docmd.c:2580
#48 do_cmdline (cmdline=<optimized out>, fgetline=0x0, cookie=0x0, flags=11) at ex_docmd.c:993
#49 0x000056524e9f5751 in VimCommand (self=<optimized out>, string=<optimized out>) at ./if_py_both.h:699
#50 0x00007fcee052e9ee in  () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#51 0x00007fcee047b9b8 in _PyEval_EvalFrameDefault () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#52 0x00007fcee05c681f in  () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#53 0x00007fcee047862e in _PyEval_EvalFrameDefault () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#54 0x00007fcee05c681f in  () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#55 0x00007fcee047b9b8 in _PyEval_EvalFrameDefault () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#56 0x00007fcee05c681f in  () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#57 0x00007fcee047862e in _PyEval_EvalFrameDefault () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#58 0x00007fcee05c681f in  () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#59 0x00007fcee05c194e in PyEval_EvalCode () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#60 0x00007fcee06107bd in  () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#61 0x00007fcee06117e9 in PyRun_StringFlags () at /lib/x86_64-linux-gnu/libpython3.10.so.1.0
#62 0x000056524e9ebe78 in run_cmd (cmd=0x0, arg=<optimized out>, pygilstate=<optimized out>) at ./if_py_both.h:5697
#63 0x000056524e9ebd80 in DoPyCommand (cmd=<optimized out>, init_range=<optimized out>, run=0x56524e9ebe60 <run_cmd>, arg=arg@entry=0x7ffdeeccaef0) at if_python3.c:1275
#64 0x000056524e9eb31d in ex_py3 (eap=0x7ffdeeccaef0) at if_python3.c:1309
#65 0x000056524e7f3d6e in do_one_cmd (cmdlinep=0x7ffdeeccaec0, flags=11, cstack=0x7ffdeeccb078, cookie=0x7ffdeeccc220, fgetline=<optimized out>) at ex_docmd.c:2580
#66 do_cmdline (cmdline=cmdline@entry=0x56525129aad0 "python3 SpliceInit()", fgetline=0x56524e90af70 <getsourceline>, cookie=0x7ffdeeccc220, flags=flags@entry=11) at ex_docmd.c:993
#67 0x000056524e98027c in do_ucmd (eap=eap@entry=0x7ffdeeccb8d0) at usercmd.c:1953
#68 0x000056524e7f3d8c in do_one_cmd (cmdlinep=0x7ffdeeccb8a0, flags=11, cstack=0x7ffdeeccba58, cookie=0x7ffdeeccc220, fgetline=<optimized out>) at ex_docmd.c:2573
#69 do_cmdline (cmdline=<optimized out>, fgetline=0x56524e90af70 <getsourceline>, cookie=cookie@entry=0x7ffdeeccc220, flags=flags@entry=11) at ex_docmd.c:993
#70 0x000056524e99cc7a in exec_command (iptr=0x5652512b9000) at vim9execute.c:1951
#71 exec_instructions (ectx=ectx@entry=0x7ffdeecccb50) at vim9execute.c:3098
#72 0x000056524e9a2aaa in call_def_function (ufunc=ufunc@entry=0x565251138450, argc_arg=1, argc_arg@entry=32765, argv=argv@entry=0xeeccce10, flags=flags@entry=0, partial=0x0, object=0x0, funccal=0x565251194f90, rettv=0x7ffdeeccd580) at vim9execute.c:6065
#73 0x000056524e98431b in call_user_func (fp=0x565251138450, argcount=0, argvars=0x0, rettv=<optimized out>, funcexe=0x7ffdeeccd490, selfdict=<optimized out>) at userfunc.c:2784
#74 call_user_func_check (fp=fp@entry=0x565251138450, argcount=0, argcount@entry=1, argvars=0x0, argvars@entry=0x7ffdeeccd560, rettv=<optimized out>, rettv@entry=0x7ffdeeccd580, funcexe=funcexe@entry=0x7ffdeeccd490, selfdict=selfdict@entry=0x0) at userfunc.c:3202
#75 0x000056524e983191 in call_func (funcname=0x5652511bdf00 "\200\375R28_Trampoline", len=<optimized out>, rettv=0x0, argcount_in=<optimized out>, argvars_in=<optimized out>, funcexe=funcexe@entry=0x7ffdeeccd490) at userfunc.c:3758
#76 0x000056524e98557f in call_callback (callback=callback@entry=0x565251183358, len=0, len@entry=-1, rettv=0x0, rettv@entry=0x7ffdeeccd580, argcount=0, argcount@entry=1, argvars=0x0, argvars@entry=0x7ffdeeccd560) at userfunc.c:3503
#77 0x000056524e971aa6 in timer_callback (timer=0x565251183320) at time.c:510
#78 check_due_timer () at time.c:582
#79 0x000056524e976a95 in ui_wait_for_chars_or_timer (wtime=4000, wait_func=0x56524e9d2360 <gui_wait_for_chars_3>, interrupted=0x7ffdeeccd638, ignore_input=0) at ui.c:455
#80 0x000056524e976653 in inchar_loop (buf=buf@entry=0x56524eaed7c9 <typebuf_init+57> "", maxlen=maxlen@entry=69, wtime=wtime@entry=-1, tb_change_cnt=tb_change_cnt@entry=5, wait_func=0x56524e9d2340 <gui_wait_for_chars_or_timer>, resize_func=resize_func@entry=0x0) at ui.c:384
#81 0x000056524e9cfadd in gui_wait_for_chars_buf (buf=0x56524eaed7c9 <typebuf_init+57> "", maxlen=69, wtime=-1, tb_change_cnt=5) at gui.c:3026
#82 0x000056524e97647f in ui_inchar (buf=buf@entry=0x56524eaed7c9 <typebuf_init+57> "", maxlen=69, wtime=wtime@entry=-1, tb_change_cnt=tb_change_cnt@entry=5) at ui.c:226
#83 0x000056524e8247e3 in inchar (buf=0x0, maxlen=207, wait_time=-1) at getchar.c:3766
#84 0x000056524e8287d3 in vgetorpeek (advance=advance@entry=1) at getchar.c:3547
#85 0x000056524e82792c in vgetc () at getchar.c:1739
#86 0x000056524e829bc6 in safe_vgetc () at getchar.c:1990
#87 0x000056524e88132f in normal_cmd (oap=oap@entry=0x7ffdeeccda10, toplevel=toplevel@entry=1) at normal.c:750
#88 0x000056524ea15b9d in main_loop (cmdwin=cmdwin@entry=0, noexmode=noexmode@entry=0) at main.c:1533
#89 0x000056524ea14f25 in vim_main2 () at main.c:887
#90 0x000056524ea13b3f in main (argc=<optimized out>, argv=<optimized out>) at main.c:433

Ernie Rael wrote:

Steps to reproduce
This is intermittent, happened 2 times out of ~15 tries. Mercurial is
configured to run a vim based merge tool (Splice). Splice does
configuration when it starts up. There some gtk on the stack, timing
issue? The version of vim is less that a week old and I didn't see any
recent changes that obviously covered this.
Some gdb output, full backtrace below
(gdb)  up 5
#5  0x000056524e7b781d in update_screen<EMAIL_ADDRESS>at drawscreen.c:273
273		if (wp->w_buffer->b_mod_set)
(gdb) p wp
$1 = (win_T *) 0x5652512bc640
(gdb) p wp->w_buffer
$2 = (buf_T *) 0x0

[...]

#3  0x000056524ea15316 in getout (exitval=1) at main.c:1750
#4  0x00007fcee0042520 in  () at /lib/x86_64-linux-gnu/libc.so.6
#5  0x000056524e7b781d in update_screen @.=40) at drawscreen.c:273
#6  0x000056524e9520a9 in set_shellsize_inner (height=0, mustset=0, width=)
at term.c:3702
#7  set_shellsize (width=, height=0, mustset=0) at term.c:3740
#8  0x000056524e9ce435 in gui_resize_shell (pixel_width=1796, @.=872)
at gui.c:1593
[...]
#43 0x000056524e9d6290 in gui_mch_update () at gui_gtk_x11.c:6430
#44 0x000056524e9c070e in win_alloc (after=0x0, @.***=0) at window.c:5513
#45 0x000056524e9bf7f7 in win_split_ins (size=0, flags=0, new_wp=0x0, dir=0) at window.c:5731
#46 0x000056524e7fa597 in ex_splitview (eap=0x7ffdeecc9ae0) at ex_docmd.c:6825

Yeah, update_screen() should not be called halfway adding a new window.
There is actually a check near the start of set_shellsize_inner() if the
buffer of the current window is NULL, but that doesn't catch this case.
We could check all windows, but then resizing might not work properly.
It's probably best to set the "RedrawingDisabled" flag while splitting a
window.  The redrawing() function returns FALSE then and
update_screen() will return early.
--
Execuses for making a mistake:
In the morning: "I didn't have enough coffee yet!"
In the afternoon: "Look at all the things that I did right!"
In the evening: "I'm too tired!"
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Error : Flavor nativescript-camera has unknown dimension nativescript-camera

Error : Flavor nativescript-camera has unknown dimension nativescript-camera
I get the above error after I execute 'tns run android'
Can you please help ?

Hi @nachiketglobant
Did you found the solution for this issue? Im facing the same issue. pls suggest me to fix this issue.


Project refactoring

Project refactoring & cleanup

Moving files into a source directory & improve general usability (see #6)
General refactoring of almost all methods to improve usability and the option to configure the project for each release (#6)
Use the polars library instead of the pandas to process 'data-frames'
Add new charts (see #11)

/kind clean-up
/kind feature
Fixes #11
Fixes #6
Info:
Regarding which diagrams can be published publicly (see #7):
This PR removes pronoun diagrams and subteam diagrams. After a conversation with @palnabarun a few weeks ago, I remembered the CoCC expressing concern about showing pronouns of applicants in a chart (even if anonymized) + regarding the other charts... the "number of applicants for the release team subteams" is sometimes too low to create charts (applicants could be tracked).

Hello 👋 @puerco / @cpanato friendly ping – do you find time to review the code in the next days? Otherwise, I would kindly ask via slack for volunteers 🙂👍

/priority important-soon
cc @palnabarun @saschagrunert

/lgtm


Backport IPv4 reassembly code and tests to lwaftr_nutmeg

This backports #87 to be applied into lwaftr_nutmeg, plus a couple of small changes needed to accomodate the backported code.
Merging this is needed to tackle issue #103.

To me the patch LGTM to apply to the branch.  Nits should be fixed on lwaftr_olive and then cherry-picked back, if needed.  I would appreciate more end-to-end tests but that also should be done on lwaftr_olive.  Would like a quick PTAL from @kbara tho.

I've taken a quick look, and it seems ok to me. We may end up modifying it a bit with the MTU refactoring.


Fix Starshot build (patch removed)

https://github.com/mglaman/wasm-drupal/actions/runs/10103298026/job/27940413648

fixed with https://github.com/mglaman/wasm-drupal/commit/4a41e68aeeb0000bf69bcddc8ae4c8867554a4c7


Stories/ecer 1791

ECER-1791: Update validation in application wizard to always validate on save and continue
Description

Moved validation to occur on each step including education + work experience.
Note with education added in feedback for number of education based on program requirement.
Work experience, user must enter at least 500 hours or 6 work experiences.
Removed validation checks in preview cards since user should never be in an error state here.
Removed validation state + all stage validation from wizard.ts.
HasDuplicates check moved back to the character + work experience components.
Application.vue - removed check that information is in a valid state. User should always be in a valid state at this point.

Random bug fix

Added security content policy for recaptcha to load recaptcha script.

Checklist

[x] I have tested these changes locally.
[ ] Changes to backend endpoints are covered by passing integration tests.
[ ] I have added or updated the necessary documentation.

Screenshots (if applicable)
Duplicates check (will disappear when user changes the input)

Extra input check for education

Additional Comments (optional)
Any additional context or information that might be helpful for the reviewer.

Yeah, learned the trick when we had to make our own inputs for radios + select all dropdowns. :D


Error: Cannot find module '/node_modules/.pnpm/vite-plugin-checker<EMAIL_ADDRESS>

Describe the bug
When enabling vueTsc inside vite.config.ts by setting vueTsc: true, this error appears when running vite in dev-mode.
It appears, that a package.json is missing inside node_modules/vite-plugin-checker/lib/checkers/vueTsc/typescript-vue-tsc/
The issue was fixed by downgrading to v0.4.3
Reproduction

Install vite-plugin-checker with pnpm
set vueTsc: true inside vite.config.js
run vite

Expected behavior
It should run without error.
System Info
System:
    OS: macOS 12.3
    CPU: (8) arm64 Apple M1
    Memory: 166.08 MB / 16.00 GB
    Shell: 5.8.1 - /opt/homebrew/bin/zsh
Binaries:
    Node: 16.14.0 - /usr/local/bin/node
    Yarn: 1.22.15 - /usr/local/bin/yarn
    npm: 8.5.5 - /usr/local/bin/npm
Browsers:
    Chrome: 99.0.4844.84
    Safari: 15.4
npmPackages:
    vite-plugin-checker: 0.4.4 => 0.4.4

Additional context
node:internal/event_target:916
  process.nextTick(() => { throw err; });
                           ^
Error: Cannot find module '<projectDir>/node_modules/.pnpm/vite-plugin-checker<EMAIL_ADDRESS>Require stack:
- <projectDir>/node_modules/.pnpm/vite-plugin-checker<EMAIL_ADDRESS>- <projectDir>/node_modules/.pnpm/vite-plugin-checker<EMAIL_ADDRESS>    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at prepareVueTsc (<projectDir>/node_modules/.pnpm/vite-plugin-checker@0.4.4_vite@2.8.6/node_modules/vite-plugin-checker/lib/checkers/vueTsc/prepareVueTsc.js:44:33)
    at Object.configureServer (<projectDir>/node_modules/.pnpm/vite-plugin-checker@0.4.4_vite@2.8.6/node_modules/vite-plugin-checker/lib/checkers/vueTsc/main.js:27:71)
    at MessagePort.<anonymous> (<projectDir>/node_modules/.pnpm/vite-plugin-checker@0.4.4_vite@2.8.6/node_modules/vite-plugin-checker/lib/worker.js:56:36)
    at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:647:20)
    at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)
Emitted 'error' event on Worker instance at:
    at Worker.[kOnErrorMessage] (node:internal/worker:289:10)
    at Worker.[kOnMessage] (node:internal/worker:300:37)
    at MessagePort.<anonymous> (node:internal/worker:201:57)
    at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:647:20)
    at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)
    at Worker.[kOnExit] (node:internal/worker:267:5)
    at Worker.<computed>.onexit (node:internal/worker:198:20) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '<projectDir>/node_modules/.pnpm/vite-plugin-checker<EMAIL_ADDRESS>    '<projectDir>/node_modules/.pnpm/vite-plugin-checker<EMAIL_ADDRESS>  ]
}

Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Try deleting node_modules and pnpm i again. Does it work? Did you disabled hoist of pnpm in npmrc?

I already tried that. I also didn't change the default pnpm settings.

Would you like to paste your package.json

Issue was fixed with (probably) version 0.4.5 👍

I still get this issue on 0.4.6
node:internal/event_target:916
  process.nextTick(() => { throw err; });
                           ^
Error: Cannot find module 'C:\Git\BlocPlatform\Bloc\Frontend\Bloc.Vue\node_modules\.pnpm\vite-plugin-checker<EMAIL_ADDRESS>Require stack:
- C:\Git\BlocPlatform\Bloc\Frontend\Bloc.Vue\node_modules\.pnpm\vite-plugin-checker<EMAIL_ADDRESS>
- C:\Git\BlocPlatform\Bloc\Frontend\Bloc.Vue\node_modules\.pnpm\vite-plugin-checker<EMAIL_ADDRESS>    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at prepareVueTsc (C:\Git\BlocPlatform\Bloc\Frontend\Bloc.Vue\node_modules\.pnpm\vite-plugin-checker@0.4.6_vite@2.9.8\node_modules\vite-plugin-checker\lib\checkers\vueTsc\prepareVueTsc.js:61:29)
    at Object.configureServer (C:\Git\BlocPlatform\Bloc\Frontend\Bloc.Vue\node_modules\.pnpm\vite-plugin-checker@0.4.6_vite@2.9.8\node_modules\vite-plugin-checker\lib\checkers\vueTsc\main.js:46:70)
    at MessagePort.<anonymous> (C:\Git\BlocPlatform\Bloc\Frontend\Bloc.Vue\node_modules\.pnpm\vite-plugin-checker@0.4.6_vite@2.9.8\node_modules\vite-plugin-checker\lib\worker.js:75:24)
    at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:647:20)
    at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)
Emitted 'error' event on Worker instance at:
    at Worker.[kOnErrorMessage] (node:internal/worker:289:10)
    at Worker.[kOnMessage] (node:internal/worker:300:37)
    at MessagePort.<anonymous> (node:internal/worker:201:57)
    at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:647:20)
    at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)
    at Worker.[kOnExit] (node:internal/worker:267:5)
    at Worker.<computed>.onexit (node:internal/worker:198:20) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    'C:\\Git\\BlocPlatform\\Bloc\\Frontend\\Bloc.Vue\\node_modules\\.pnpm\\vite-plugin-checker<EMAIL_ADDRESS>    'C:\\Git\\BlocPlatform\\Bloc\\Frontend\\Bloc.Vue\\node_modules\\.pnpm\\vite-plugin-checker<EMAIL_ADDRESS>  ]
}
The terminal process "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command npm run dev" terminated with exit code: 1.

Me too...

I could fix this issue by running pnpm store prune or manually deleting the whole pnpm store in pnpm store path and reinstalling the dependencies with pnpm install.

It's very weird, because 1 hour ago everything was ok.
I think a pnpm install in a different repo somehow deleted the package.json inside typescript-vue-tsc in my local pnpm store... So it seems to be an issue with pnpm?

Has this problem been solved

Has this problem been solved

hello,Has this problem been solved

Can confirm this is still an issue

I can also confirm this is still an issue. I made a fresh project with create-vue to test out this plugin, enabled the vueTsc option and immediately got the same error as everyone else.
Vite config
import { fileURLToPath, URL } from 'node:url';

import vue from '@vitejs/plugin-vue';
import { defineConfig } from 'vite';
import checker from 'vite-plugin-checker';

// https://vitejs.dev/config/
export default defineConfig({
	plugins: [
		checker({
			vueTsc: true,
		}),
		vue(),
	],
	resolve: {
		alias: {
			'@': fileURLToPath(new URL('./src', import.meta.url)),
		},
	},
});

Stack trace
node:internal/event_target:964
  process.nextTick(() => { throw err; });
                           ^
Error: Cannot find module '/Users/benwebb/code/create-vue-test/node_modules/vite-plugin-checker/lib/checkers/vueTsc/typescript-vue-tsc/package.json'
Require stack:
- /Users/benwebb/code/create-vue-test/node_modules/vite-plugin-checker/lib/checkers/vueTsc/prepareVueTsc.js
- /Users/benwebb/code/create-vue-test/node_modules/vite-plugin-checker/lib/checkers/vueTsc/main.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:956:15)
    at Module._load (node:internal/modules/cjs/loader:804:27)
    at Module.require (node:internal/modules/cjs/loader:1022:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at prepareVueTsc (/Users/benwebb/code/create-vue-test/node_modules/vite-plugin-checker/lib/checkers/vueTsc/prepareVueTsc.js:61:29)
    at Object.configureServer (/Users/benwebb/code/create-vue-test/node_modules/vite-plugin-checker/lib/checkers/vueTsc/main.js:46:70)
    at MessagePort.<anonymous> (/Users/benwebb/code/create-vue-test/node_modules/vite-plugin-checker/lib/worker.js:75:24)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:689:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)
Emitted 'error' event on Worker instance at:
    at [kOnErrorMessage] (node:internal/worker:290:10)
    at [kOnMessage] (node:internal/worker:301:37)
    at MessagePort.<anonymous> (node:internal/worker:202:57)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:689:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)
    at [kOnExit] (node:internal/worker:268:5)
    at Worker.<computed>.onexit (node:internal/worker:199:20) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/benwebb/code/create-vue-test/node_modules/vite-plugin-checker/lib/checkers/vueTsc/prepareVueTsc.js',
    '/Users/benwebb/code/create-vue-test/node_modules/vite-plugin-checker/lib/checkers/vueTsc/main.js'
  ]
}

Deleting node modules and reinstalling as described by @DrJume does seem to resolve the issue. Strange.

I think it basically fails to put the package.json in the directory. A first install worked, maybe the (pnpm) upgrade sometimes deletes the package.json?

Does this issue still exists after 0.5.0? Although I'm not very clearly what cause the issue, but I added a try catch statement to prevent this.
https://github.com/fi3ework/vite-plugin-checker/blob/140f96c3d24f70e118e8397fc23aa7e41e01ee91/packages/vite-plugin-checker/src/checkers/vueTsc/prepareVueTsc.ts#L53-L66

I think it should be fixed in 0.5.0 due to https://github.com/fi3ework/vite-plugin-checker/issues/137

I think it should be fixed in 0.5.0 from latest response in #137

Still getting this error in 0.5.1

Same here on 0.5.2 when using stylelint
node:internal/event_target:969
  process.nextTick(() => { throw err; });
                           ^
TypeError [Error]: (0 , import_options.default) is not a function
    at Object.configureServer (/.../node_modules/.pnpm/vite-plugin-checker@0.5.2/node_modules/vite-plugin-checker/dist/cjs/checkers/stylelint/main.js:58:60)
    at MessagePort.<anonymous> (/.../node_modules/.pnpm/vite-plugin-checker@0.5.2/node_modules/vite-plugin-checker/dist/cjs/worker.js:80:26)
    at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:694:20)
    at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)
Emitted 'error' event on Worker instance at:
    at Worker.[kOnErrorMessage] (node:internal/worker:290:10)
    at Worker.[kOnMessage] (node:internal/worker:301:37)
    at MessagePort.<anonymous> (node:internal/worker:202:57)
    at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:694:20)
    at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)

The mentioned import refers to options.js, but that file does exist, so it's the problem isn't clear

This seems like not the same issue in this thread but related to https://github.com/fi3ework/vite-plugin-checker/issues as the default export is not found in CJS mode. Let's track in that issue and would like to provide a minimal re-pro?

version<EMAIL_ADDRESS>yarn v1.22.19
When I install a new package, the folder of dist/cjs/checkers/vueTsc/typescript-vue-tsc will be removed automatically, and then dev error.
The same as dist/esm/...
Error logs:
ERROR(vue-tsc)  File '/.../node_modules/vite-plugin-checker/dist/cjs/checkers/vueTsc/typescript-vue-tsc/lib/lib.dom.d.ts' not found.

This seems like not the same issue in this thread but related to https://github.com/fi3ework/vite-plugin-checker/issues/184

I ignored that one since I'm using Vite 2, while that's about Vite 3
I'm gonna create a repro, I think the problem may related to the monorepo structure of my project

VITE v4.0.4  ready in 633 ms

  ➜  Local:   http://localhost:8000/
  ➜  Network: http://<IP_ADDRESS>:8000/
  ➜  press h to show help

node:internal/event_target:1013
  process.nextTick(() => { throw err; });
                           ^
Error: start < 0
    at createTextSpan (/Users/dan/example/node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/typescript.js:12547:19)
    at Object.createTextSpanFromBounds (/Users/dan/example/node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/typescript.js:12556:16)
    at getErrorSpanForNode (/Users/dan/example/node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/typescript.js:15597:19)
    at Object.createDiagnosticForNodeFromMessageChain (/Users/dan/example/node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/typescript.js:15462:20)
    at resolveExternalModule (/Users/dan/example/node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/typescript.js:52379:52)
    at resolveExternalModuleNameWorker (/Users/dan/example/node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/typescript.js:52301:19)
    at resolveExternalModuleName (/Users/dan/example/node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/typescript.js:52296:20)
    at getSymbolAtLocation (/Users/dan/example/node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/typescript.js:88409:32)
    at Object.getSymbolAtLocation (/Users/dan/example/node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/typescript.js:49394:31)
    at getReferencedFilesFromImportLiteral (/Users/dan/example/node_modules/.pnpm/typescript@4.9.4/node_modules/typescript/lib/typescript.js:122348:34)
Emitted 'error' event on Worker instance at:
    at [kOnErrorMessage] (node:internal/worker:300:10)
    at [kOnMessage] (node:internal/worker:311:37)
    at MessagePort.<anonymous> (node:internal/worker:207:57)
    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:738:20)
    at exports.emitMessage (node:internal/per_context/messageport:23:28)

Node.js v19.3.0

works for me when you add  pnpm add vue-tsc@latest typescript vite-plugin-checker  -D  (monorepo case)

@isabolic Which re-produce method or solution works for you? 🤔

@fi3ework  I had a exact error, so I run

rm -rf node_modules

pnpm install

pnpm add --filter MONOREPO_PCK vue-tsc typescript vite-plugin-checker -D

now pnpm dev has no errors

@isabolic Which version of the plugin you're using?

issue still present after double check... sorry about that :)

Error: EEXIST: file already exists, mkdir

I think this is monorepo case, if i go into packages/ui-components and run pnpm dev/vite dev and go back to root repo directory, after that run again pnpm dev but after you add new package or update to latest  the same error appears..

same error in pnpm workspace

Got the same here in v0.4..8. Any update on this?

Encountered this issue as well vue-tsc + vite-plugin-checker + yarn 4
the only thing that helped in my case was deleting yarn.lock file and running yarn afterwards.
node:internal/event_target:1033
  process.nextTick(() => { throw err; });
                           ^
Error: EROFS: read-only filesystem, mkdir '/node_modules/vite-plugin-checker/dist/cjs/checkers/vueTsc/typescript-vue-tsc'

vite-plugin-checker version 0.7.2, I got the error
  VITE v5.3.3

error when starting dev server:
Error: Cannot find module 'vue-tsc/package.json'
Require stack:
- E:\my-workspace\xh-bms\xh-admin-frontend\node_modules\.pnpm\vite-plugin-checker@0.7.2_eslint@8.57.0_optionator@0.9.4_typescript@5.4.5_vite<EMAIL_ADDRESS>    at Module._resolveFilename (node:internal/modules/cjs/loader:1186:15)
    at Function.resolve (node:internal/modules/helpers:133:19)
    at file:///E:/my-workspace/xh-bms/xh-admin-frontend/node_modules/.pnpm/vite-plugin-checker@0.7.2_eslint@8.57.0_optionator@0.9.4_typescript@5.4.5_vite@5.3.3_@types+n_g2k6lq7lhxwlgneuifsug7ynae/node_modules/vite-plugin-checker/dist/esm/checkers/vueTsc/prepareVueTsc.js:10:36
    at ModuleJob.run (node:internal/modules/esm/module_job:262:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:475:24)
    at async createCheckers (file:///E:/my-workspace/xh-bms/xh-admin-frontend/node_modules/.pnpm/vite-plugin-checker@0.7.2_eslint@8.57.0_optionator@0.9.4_typescript@5.4.5_vite@5.3.3_@types+n_g2k6lq7lhxwlgneuifsug7ynae/node_modules/vite-plugin-checker/dist/esm/main.js:31:37)
    at async config (file:///E:/my-workspace/xh-bms/xh-admin-frontend/node_modules/.pnpm/vite-plugin-checker@0.7.2_eslint@8.57.0_optionator@0.9.4_typescript@5.4.5_vite@5.3.3_@types+n_g2k6lq7lhxwlgneuifsug7ynae/node_modules/vite-plugin-checker/dist/esm/main.js:64:18)
    at async runConfigHook (file:///E:/my-workspace/xh-bms/xh-admin-frontend/node_modules/.pnpm/vite@5.3.3_@types+node@20.14.10_sass@1.77.8_terser@5.31.2/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:67013:19)
    at async resolveConfig (file:///E:/my-workspace/xh-bms/xh-admin-frontend/node_modules/.pnpm/vite@5.3.3_@types+node@20.14.10_sass@1.77.8_terser@5.31.2/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:66464:12)
    at async _createServer (file:///E:/my-workspace/xh-bms/xh-admin-frontend/node_modules/.pnpm/vite@5.3.3_@types+node@20.14.10_sass@1.77.8_terser@5.31.2/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:63048:18)
 ELIFECYCLE  Command failed with exit code 1.

18:06:11 [vite] server restart failed

@Alixhan Did you installed vue-tsc alongside?

@fi3ework No, I got another error after installing vue-tsc.
vite --mode development

  VITE v5.3.3  ready in 1381 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: http://<IP_ADDRESS>:5173/
  ➜  Network: http://<IP_ADDRESS>:5173/
  ➜  Network: http://<IP_ADDRESS>:5173/
  ➜  press h + enter to show help

node:internal/event_target:1090
  process.nextTick(() => { throw err; });
                           ^
Error [ERR_REQUIRE_ESM]: require() of ES Module E:\my-workspace\xh-bms\xh-admin-frontend\node_modules\.pnpm\vite-plugin-checker@0.7.2_eslint@8.57.0_optionator@0.9.4_typescript@5.4.5_vite@5.3.3_@types+n_uhgroegrsorsy4x5zhojfsa6s4\nod
e_modules\vite-plugin-checker\dist\esm\checkers\vueTsc\typescript-vue-tsc\lib\typescript.js from E:\my-workspace\xh-bms\xh-admin-frontend\node_modules\.pnpm\vite-plugin-checker@0.7.2_eslint@8.57.0_optionator@0.9.4_typescript@5.4.5_vite<EMAIL_ADDRESS>not supported.
typescript.js is treated as an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which declares all .js files in that package scope as ES modules.
Instead either rename typescript.js to end in .cjs, change the requiring code to use dynamic import() which is available in all CommonJS modules, or change "type": "module" to "type": "commonjs" in E:\my-workspace\xh-bms\xh-admin-fr
ontend\node_modules\.pnpm\vite-plugin-checker@0.7.2_eslint@8.57.0_optionator@0.9.4_typescript@5.4.5_vite<EMAIL_ADDRESS>to treat all .js files as CommonJS (using .mjs for all ES modules instead).

    at Object.configureServer (file:///E:/my-workspace/xh-bms/xh-admin-frontend/node_modules/.pnpm/vite-plugin-checker@0.7.2_eslint@8.57.0_optionator@0.9.4_typescript@5.4.5_vite@5.3.3_@types+n_uhgroegrsorsy4x5zhojfsa6s4/node_modules/vite-plugin-checker/dist/esm/checkers/vueTsc/main.js:36:21) {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v22.2.0
 ELIFECYCLE  Command failed with exit code 1.

@Alixhan You need to change your project to type: "module".

@fi3ework Yes, It is

@Alixhan Could you provide a minimal reproduction

@Alixhan Could you provide a minimal reproduction

Thank you. I'll provide it later.

@fi3ework The demo create by latest vue .
https://stackblitz.com/edit/vitejs-vite-pqfh12?file=package.json,vite.config.ts&terminal=dev

Bumping typescript to 5.5.0 could fix the issue, I think vue-tsc requires a higher minimal version of ts now.

Sorry, I don't know why typescript can't be required...


In macro

see commit descriptions

There are a few problems with this change:

This is similar to the for-each concept macro, the principal difference being that the function to which for-each expands takes a function pointer representing the body of the loop, whereas this takes that body directly, which in turn allows the body to reference other bindings present in the local scope.
stdlib now includes references to container concepts, but container concepts are defined by modules that depend on stdlib.  Since this is a macro, and the dependency is implicit anyway, this doesn't prevent the relevant code from compiling.  However, it's not very appealing from a dependency graph perspective.
Macro expansions that require particular concepts to be implemented by their arguments should be implemented as concept macros, rather than plain macros.

The first problem is the main one.   Although being able to refer to local bindings in the body of the loop is very useful, I'm not sure whether this is the correct approach for dealing with that (cf. e.g. implementing closures and using the existing forms, or adding some sort of macro wrapper around the existing forms).  I'm not inclined to merge this until possible alternatives have been investigated more fully.

Seems good. If there are better alternatives, they should be used. Maybe with additional features. (maybe even similar to lisp loop)
I'd prefer adding typechecking at macroexpansion time instead of using concept macros


Exception in sci_plots.py

I'm getting exceptions sometimes in sci_plots when it tries to format the stringtable.
What I see is that at this line:
https://github.com/paulray/NICERsoft/blob/c9d684130c2dfe73881884eac8331438c313f7b8/nicer/sci_plots.py#L114
it grabs a table of the durations. Later it converts all the durations to float, but this fails because I'm getting '...' for one of the durations. I'm not sure why. Perhaps something is contracting down a longer table?

In my example, I added print(stringtable_duration) and got this:
['     DURATION    ', '        s        ', '-----------------', '            221.0', '            864.0', '            602.0', '            226.0', '            866.0', '            472.0', '            227.0', '            840.0', '            242.0', '            133.0', '            247.0', '            842.0', '            313.0', '             76.0', '             42.0', '            132.0', '            542.0', '             50.0', '             27.0', '            216.0', '            255.0', '              ...', '            163.0', '            799.0', '             91.0', '            196.0', '            779.0', '674.5389756560326', '            131.0', '            155.0', '            768.0', '            960.0', '            333.0', '            751.0', '            454.0', '             54.0', '             20.0', '            421.0', '            292.0', '            771.0', '            163.0', '            218.0', '            117.0', 'Length = 62 rows']

The print statement is right after line 114 ?
It is possible that str(gtitable[...]) adds ... when there are many GTIs in the fits file. But it is odd that only the stringtable_duration has ... and not the other two string tables.
One solution would be to remove the line with the ... in the three stringtable_.
I will try that.


Update primary key docstrings

Add an explicit statement that primary key columns should not contain NULL values. We are concurrently updating the API documentation to make this clear there as well.

Hm, something seems not right with this fork - it has old changes and such that should have already been merged.


use .get() for ObjectProxies in get-ancestor-descriptor

Purpose
Locally (though, for some reason, not on staging) I'm getting the "You attempted to access a property of an ObjectProxy without using .get()" error when trying to move a Quick File (specifically, when trying to choose a project). I traced it back to overeager ungetting in the get-ancestor-descriptor helper (guilty).
Summary of Changes
use .get() for ObjectProxies in get-ancestor-descriptor helper
Side Effects / Testing Notes
Ancestor descriptors should always work.
Ticket
n/a
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Coverage decreased (-0.02%) to 55.508% when pulling ab5b82fc75dbfd3249cb24fb2a9216992f7f85ed on jamescdavis:fix_move_quick_file_project_list into 32b78b5cdf6d7bc4dbdb5744c3ded68254db12e4 on CenterForOpenScience:develop.


[SPARK-6752][Streaming] Allow StreamingContext to be recreated from checkpoint and existing SparkContext

Currently if you want to create a StreamingContext from checkpoint information, the system will create a new SparkContext. This prevent StreamingContext to be recreated from checkpoints in managed environments where SparkContext is precreated.
The solution in this PR: Introduce the following methods on StreamingContext

new StreamingContext(checkpointDirectory, sparkContext)
Recreate StreamingContext from checkpoint using the provided SparkContext
StreamingContext.getOrCreate(checkpointDirectory, sparkContext, createFunction: SparkContext => StreamingContext)
If checkpoint file exists, then recreate StreamingContext using the provided SparkContext (that is, call 1.), else create StreamingContext using the provided createFunction

TODO: the corresponding Java and Python API has to be added as well.

Test build #29898 has started for   PR 5428 at commit 36a7823.

Test build #29898 has finished for   PR 5428 at commit 36a7823.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29898/
Test PASSed.

@jerryshao Mind taking a look at this? Its still WIP as unit tests are commented out.

@tdas , can this RP resolve this issue?
Restart a streaming app from checkpoint  incorrectly if using accumulators .

@tdas Yeah, will do.
@zzcclp I'm not sure, maybe you can take a try, from my guess, this could possibly work, since accumulator is registered in SparkContext, while SparkContext is still existed.

It looks good to me. Simply curious about the scenarios of this usage, is there any situation where streaming context is failed but spark context is still existed when driver failure is met?

@jerryshao , thanks, I will test this case later.

@zzcclp I dont think it will solve this issue directly. But it may allow the SparkContext to be re-initialized properly before the StreamingContext is recreated from checkpoints.

@all This is still a WIP. Adding the equivalent Java API requires refactoring the existing JavaStreamingContext.getOrCreate to not use JavaStreamingContextFactory and use o.a.s.java.api.Function0 (which needs to be added). I am going to open other PRs for them before this can be merged.

Test build #30389 has started for   PR 5428 at commit eabd092.

@JoshRosen Please take a quick look at the Function.
@jerryshao @harishreedharan I have updated the patch with Java API and unit tests. I think I am going to create a separate JIRA for python API.

Test build #30389 has finished for   PR 5428 at commit eabd092.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30389/
Test FAILed.

Jenkins, test this again.

Jenkins, test this.

Test build #691 has started for   PR 5428 at commit eabd092.

Test build #691 has finished for   PR 5428 at commit eabd092.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test build #692 has started for   PR 5428 at commit eabd092.

@tdas , I tested streaming recovering from checkpoint with this PR, it failed if it use accumulators, so this assuredly can't solve issue SPARK-5206 directly. how to solve issue SPARK-5206?

Yes, this is not intended to solve SPARK-5206.

Test build #692 has finished for   PR 5428 at commit eabd092.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test build #30743 has started for   PR 5428 at commit 524f519.

Test build #30743 has finished for   PR 5428 at commit 524f519.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30743/
Test FAILed.

Test build #30751 has started for   PR 5428 at commit 94db63c.

Test build #30751 has finished for   PR 5428 at commit 94db63c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30751/
Test FAILed.

Test build #693 has started for   PR 5428 at commit 94db63c.

Test build #693 has finished for   PR 5428 at commit 94db63c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test build #694 has started for   PR 5428 at commit 94db63c.

LGTM pending Jenkins.

Test build #695 has started for   PR 5428 at commit 94db63c.

Test build #695 has finished for   PR 5428 at commit 94db63c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test build #696 has started for   PR 5428 at commit 94db63c.

Test build #697 has started for   PR 5428 at commit 94db63c.

Test build #697 has finished for   PR 5428 at commit 94db63c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merging this.

hi, @tdas , why this PR was be reverted?

This PR was reverted because I had used MutableBoolean which does not seem to work well with Hadoop 1.0.4. I reopened the PR in #5773.

I have revised the implementation of this PR in a followup PR #6096


Rename files to have same names across all styles + new ATM symbol

Also, removed one duplicated symbol and .DS_Store

I have fixed an issue with some cloud symbols. Please see https://github.com/GNS3/gns3-gui/issues/3232 for details.
I think this PR can be merged now. Thanks :)

Ping ;)


Sound on/off and other options

Sound volume done in https://github.com/fexed/Pinball-on-Android/commit/118d614286476a2ba47a55c17550ee4ba27bde47 (referenced wrong issue there)


Huge byte[] allocations in Large Object Heap after big load

Hi
I am playing with performance tests for my app. It uses AspNet.Core  + Kestrel ver. 1.1.2. Response size is pretty big, in average about 2MB, so app takes a lot of memory during testing. But what is strange, it doesn't free memory even if testing is completed. Profiler shows a big amount of byte arrays referenced by MemoryChunk and MemoryPool.
Is there a way to reduce pool size if the app in the standby state?  Maybe some configs exist? What is the common strategy for Kestrel in this case? Should it keep allocated bytes forever?
Also, app throws OutOfMemory from time to time, is there some kind of limit for pool size, I would prefer to drop connection rather than lost my app at all on huge load,
Thank you in advance.
Ihor

What chunk size are you writing to the body? e.g. a writeasync loop of 4096 bytes or writing 2MB in a single chunk?

Hi, guys. I'm working with @kabazakra  on this issue.
Well, the response headers in browser contains
Transfer-Encoding: chunked
Server: Kestrel

What we are doing In our code is basically
static PostUpdate dummy_post;
public async Task<IActionResult> Events([FromQuery] string query)
        {
	if (dummy_post!=null)
	{
	            return Ok(dummy_post); // we just keep giving away our first response to omit  database reading and other business logic
	}
	dummy_post = await GetResult(query); //buisness code returns object with sizeof 2.0MB
	return Ok(dummy_post);
        }

Where
Ok method is
Microsoft.AspNetCore.Mvc.OkObjectResult Ok(object value)

So at first glance the answer is: "we are writing 2MB in  a single chunk"

Might want to raise in Mvc? https://github.com/aspnet/Mvc
Don't know what type PostUpdate is, e.g. a giant array or many small objects making 2MB; and if its dumped straight out or formatted to json/xml etc
From the Kestrel side of things; it will only put so much on the network at any time (TCP window-size); so if 2MB is written in one shot it still has to hold that in queued in memory until its all written out. If its done concurrently with many connections then that's many 2MB blocks it has to allocate while its holding on to them.
Since you are using an OkResult from MVC it should be handling writing it out in smaller chunks and listening to back pressure from WriteAsync when it will allocate less. So it might be worth raising an issue in MVC as they might not be doing that but writing it out in a single 2MB chunk?

Hi, @benaadams
What I see from sources, that KestrelThread has reference to MemoryPool. It is normal to allocate bytes in Gen2 or LOH during processing requests. But, what I don't see is the logic to free resources there (as I understand at least one KestrelThread should exist). Maybe you can point me to the code or just explain how it works in Kestrel. Does it free allocated (pinned) bytes (blocks, slab, etc) and what is a trigger for this. What happens with memory on application idle?
Because in my case, app continued to hold memory for MemoryPool event if testing is stopped
Thanks,
Ihor

The GC rarely frees memory as quickly as you might expect it to.
Can you share the structure of PostUpdate?

The above being said, with Kestrel's default configuration, 2MB of of memory will never be leased from the pool for a single request. The maximum is instead is 128KB per request. So it seems more likely that your dummy_post objects are using the majority of the memory in your application.
Additionally, Kestrel's memory pool intentionally allocates byte arrays large enough to end up in the LOH precisely because these arrays never get dereferenced for the entire lifetime of the server. This helps ensure the GC scans objects that have a better chance of becoming dereferenced in its more frequent sweeps.
It seems unlikely that Kestrel's memory pool would be the ultimate cause of your OOM issues because the pool only allocates more byte arrays if all of the memory ever allocated by the pool previously is currently in use processing requests. Under high load, the memory pool utilization should be extremely high. The only time memory is sitting in the pool not being utilized would be under low load when you generally wouldn't expect to see an OOM.
Can you collect a core dump of your application when it OOMs?

Hi, @halter73
Thanks for pointing me to #609 . I will try to collect dumps, but it is about 10 GB. I am still trying to understand what is the best practice in this case. If I had high load on a server, got alarms from monitoring about low memory, do I need to restart the app after?

@kabazakra I don't think that restarting your app should be necessary because of Kestrel's memory pool. It would require more than 75,000 concurrent connections fully buffering in both directions for Kestrel's memory pool to grow to 10GB. Gathering a dump should help you determine what's causing your app's memory consumption to grow so large.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Websocket: Add an orderbook subscribe call with prec/freq support

I needed to ask for another precision when subscribing to the order book feed. Since I didn't want to break compatibility with existing users, I added another call to do that.
This PR also adds what seemed to me like a missing return statement which caused a lot of garbage in the channel.
I'm a fairly new Go developper, so any advice to improve the quality of this PR is highly welcomed.
Signed-off-by: Julien 'Lta' BALLET<EMAIL_ADDRESS>

Hello @elthariel
Moving this to the 'review/qa' pipeline while we get someone to review and ultimately merge.
Thank you.


Datadog Agent Changes

This documentation is being written early to allow the information to be sent to interested parties, if required.

@markbastiaans

Do we need to update the Summary of Mendix Metrics in section 6 of the datadog-metrics.md document?
Is the database.diskstorage.size metric the one which is controlled by DATADOG_DATABASE_DISKSTORAGE_METRIC?

Can release now.


Support Python UDF

Feature request
support Python UDF for starrocks
grammar: extends the create function to support inline call
CREATE FUNCTION echo(int)
RETURNS int
properties(
"symbol" = "add",
"type" = "Python",
"file" = "inline" ,
"input" = "arrow"
)
AS
$$
def echo(a):
    return a;
$$;

UDFCall:
use grpc to call Python UDF
Be process
Python Env Support:
Since 3.8+ Arrow 16.0.0+
grpc
pip install pyarrow
pip install grpcio

make sure all package are install in PYTHONHOME (config in BE)
fe config:
enable_udf=true
be config:
python_envs=/root/python38

examples:
see test/sql/test_udf/test_python_udf
Additional context
PR Links

[x] https://github.com/StarRocks/starrocks/pull/46247
[x] https://github.com/StarRocks/starrocks/pull/46299
[x] https://github.com/StarRocks/starrocks/pull/46449

linked to this issue
Python UDF support · Issue #45843 · StarRocks/starrocks
https://github.com/StarRocks/starrocks/issues/45843

@stdpain  Hi, recently, I have been researching how to implement Python UDAF and UDTF. Can we add a WeChat conversation? Also, do you have any specific design documentation for your Python UDF?
My WeChat is Liuwenclever.😆

@stdpain Can this python UDF support date and time data type?
for my knowledge java UDF can't support it.

@stdpain Hi, recently, I have been researching how to implement Python UDAF and UDTF. Can we add a WeChat conversation? Also, do you have any specific design documentation for your Python UDF? My WeChat is Liuwenclever.😆

We could open a public discussion in slack. https://starrocks.slack.com/archives/C02FAD0JSSD

@stdpain Hi,
I have heard the python UDF will be supported in version 3.4, so when is the expected time?
Thanks a lot.


It crash my server

Please make sure your issue complies with these guidelines:

[ ] Server Software must be the official PMMP w/o vanilla patching plugins (i.e. TeaSpoon)

[ ] Issue must have not been reported previously

[ ] Make sure you are on the latest version of PMMP & PiggyAuctions

[ ] Have a detailed title.

Link to Crashdump:

Extra Information

What is label


Add MIT license file

Since the game will be released when 1.0 is reached, the source code should get a fitting license don't forget to put MIT license

License file has been added


Slow performance

Hello,
I am experimenting with Ocelot these days. I tried Ocelot on an ASP.NET Core 1.1, with a 2.0 runtime.
I have declared the downstreams in localhost, all good so far. Testing in IIS Express from Visual Studio, seems to work just fine.
Then I publish to IIS. It still works, but the responses are slow, it might take many seconds to respond or just hangs, and there is not such performance issue with the standalone services, they are fast enough. I could not find something alerting enough in IIS.
Is anybody experiencing any similar issues?
VM: Windows Server 2008 R2
IIS: IIS 7
.NET: .NET Core 2.0 installed

@gdyrrahitis thanks for contributing! I've had this reported previously and the issue was logging out to the console. What kind of logging do you have Ocelot set up to use? If you set it to errors only and console it shouldn't be too slow!
It could also be something to do with IIS. I haven't tested Ocelot with IIS :( or it could just be Ocelot!

I am following wiki's instructions on Startup. https://github.com/TomPallister/Ocelot/wiki/Startup
You say you haven't tested Ocelot with IIS. Do you suggest self hosting in a windows service? What is recommended, and working, for you?

@gdyrrahitis the startup adds console logging which is slow so that is probably why you are experiencing performance problems. The startup is just an example of how to get Ocelot up and running and is not recommended for production use. Consulting asp.net core docs should help with this! My apologies for any confusion!! :(
I have hosted Ocelot using Azure web apps and AWS ElasticBeanstalk (assume IIS under the hood). Docker and a Linux daemon using nginx in front of kestrel.
Ocelot is currently just a nuget package because I don't want to have the responsibility of looking at hosting options! However it might be something in the future!

Thanks for clearing this out.
There is definitely an issue with IIS + Kestrel. Might be the machine's setup/configuration at fault, I am not sure. I have to test it on my terminal as well. Logging has nothing to do with that. If I serve the application through Kestrel, the performance is fine.
I had to run the application with dotnet command, so Kestrel runs on port 5000 and add a reverse proxy rule on IIS. This works, but sucks, I mean, there is already support for IIS as reverse proxy, why is that problematic, I can't understand.
I suspect it might have to do with the version, maybe an update to .NET Core 2.0 will fix this. Good news is I see you are already on the move to migrate to 2.0.
I will investigate more and provide feedback, if any.

@gdyrrahitis yeh I think the issue is more to do with IIS and Kestrel than Ocelot itself...the application doesn't do anything special! There are quite a lot of posts online about IIS and Kestrel having slow performance.


Edit a repost of one of your status posts > Redirects to malformed repost feed

I just tried editing a post of mine that someone reposted from my repost feed. Once I clicked Edit, the editor from the top of the feed with the reposter's avatar, with a blank textarea. What I think is happening is that it is trying to edit it as the reposter, but it is empty because I don't have permissions to edit his post.

Just a note, this is completely different than https://github.com/tent/tent-status/issues/106, to clear any possible confusion.

@bnb a workaround for this is to click the time stamp of the post you want to edit to take you to the singleton view for it, then click edit there.


Fixes LUA_USE_WINDOWS already declared warnings

Lua already declares its own version of LUA_USE_WINDOWs. Removing the compiler definition flag will fix the warning C4005: 'LUA_USE_WINDOWS': macro redefinition warnings on Windows.

This looks like a bug in Lua to me. The code defines LUA_USE_WINDOWS like this:
#if !defined(LUA_USE_C89) && defined(_WIN32) && !defined(_WIN32_WCE)
#define LUA_USE_WINDOWS  /* enable goodies for regular Windows */
#endif

It would be nice to have !defined(LUA_USE_WINDOWS) && in the same condition as well to avoid that redefinition. As far as I can tell LUA_USE_{WINDOWS,LINUX,MACOSX} macros are expected to be set by the user of the library externally. The current behavior is to use Meson to detect Windows. This code is a potential behavior change. I don't know if the difference between !defined(LUA_USE_C89) && defined(_WIN32) && !defined(_WIN32_WCE) and host_machine.system() == 'windows' statements is expected.
Since the goal of your PR is to remove the warning I would consider sending a patch to the upstream instead. What do you think?
#if !defined(LUA_USE_WINDOWS) && !defined(LUA_USE_C89) && defined(_WIN32) && !defined(_WIN32_WCE)
#define LUA_USE_WINDOWS  /* enable goodies for regular Windows */
#endif


Add *-EnvironmentVariable cmdlets

MSFT:10836263
Add following cmdlets :

Get-EnvironmentVariable
Syntax :
Get-EnvironmentVariable [[-Name] <string[]>] [-ValueOnly] [-Scope {Process | Machine | User}]
[]

Set-EnvironmentVariable
Syntax :
Set-EnvironmentVariable [-Name]  [[-Value] ] [-Force] [-PassThru] [-Scope {Process |
Machine | User}] [-WhatIf] [-Confirm]  []

New-EnvironmentVariable
Syntax :
New-EnvironmentVariable [-Name]  [[-Value] ] [-Force] [-PassThru] [-Scope {Process |
Machine | User}] [-WhatIf] [-Confirm]  []

Add-EnvironmentVariable
Syntax :
Add-EnvironmentVariable [-Name]  [-Value]  [-Force] [-Prepend] [-PassThru] [-Scope
{Process | Machine | User}] [-WhatIf] [-Confirm]  []

Remove-EnvironmentVariable
Syntax :
Remove-EnvironmentVariable [-Name] <string[]> [-Scope {Process | Machine | User}] [-WhatIf]
Confirm]  []

This will almost certainly require an RFC here, following up offline as well. :)

Submitted to the Cmdlet Working group for discussion

https://github.com/orgs/PowerShell/teams/wg-powershell-cmdlets reviewed this:
Managing environment variables is an OS-specific task, and i.e. on Windows OS, the suggested cmdlets would just be a thin wrapper around easily accessible  .NET calls like [System.Environment]::GetEnvironmentVariable() et al. While it would be awesome to have easily discoverable cmdlets for more tasks, the PowerShell engine needs to focus on fundamental OS-agnosic functionality. That's why cmdlets like these should be added by the community and published to the Gallery.


about smart contract

Why does the function of the eos smart contract have no return value, but ethereum can return value, If not, the sense is much less  than ethereum .How do we communicate with smart contracts?

bump...

The way a smart contract can share information with each other is via the persistence storage, i.e. db API. You can write the information you want on the table and the other contract can read the table.


Specify default values on the Dart caller

Is your feature request related to a problem? Please describe.
Sometimes it is preferable for default values of flags to be written out on the Dart side:
void foo({bool makeIceCream = true});

If this is the case, the Rust binding code can skip using Option<bool>:
fn foo(make_ice_cream: bool)

Describe the solution you'd like
A new field attribute, #[frb(default = ..)] to annotate what the default value should be. Only types shared by both Dart and Rust, i.e. Strings, numbers, booleans and lists containing them to be supported for now.
Describe alternatives you've considered
Accepting an Option instead is valid solution, however it introduces a small overhead and the semantics wouldn't match up, e.g. you can't pass in a "null" value.
Additional context
None

Ideally, this should also be able to define default values on constructors as well:
class Foo {
  final String bar;
  Foo({this.bar = 'bar'});
}

The proposal LGTM :) Looking forward to your PR


Add support creating connection directly from raw handle

@bors-servo r+
I guess we don't have any CI that builds with this feature right now.

:pushpin: Commit 2fbd424 has been approved by jdm

:hourglass: Testing commit 2fbd4248103cb8640bee28576efaa6784b45121d with merge d7ad0ac39ecd6a3c6ccc2fe98264d8c6bda1c933...

:sunny: Test successful - checks-github
Approved by: jdm
Pushing d7ad0ac39ecd6a3c6ccc2fe98264d8c6bda1c933 to master...


Queries used to generate plots in screenshot?

Could you please share the queries (also which data store was used? InfluxDB or Graphite or?) used to generate the plots shown on the screenshots?
Thank you in advance!
Best regards,
Anton

Has there been any luck with a sample query to display a plotly panel using a MySQL data source?
This is a very good contribution but as it is it's not usable.


Refactor to handle more event cases

This pull request introduces 1 alert and fixes 1 when merging 243ad4f3d5d2e0ff89b9a616758d15775e98f439 into 03672a0998b25314359541951ccb311bf59ace19 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

fixed alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 1 when merging 061b76b954c63f04aa91e8f384b6c79c50436a51 into 03672a0998b25314359541951ccb311bf59ace19 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

fixed alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 1 when merging c1d101eae89e709e87258736e24ce25f2510b9a3 into 03672a0998b25314359541951ccb311bf59ace19 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

fixed alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 1 when merging 3e36a09efb3e81d23f749aa0e72baa42b73d6818 into 03672a0998b25314359541951ccb311bf59ace19 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

fixed alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 1 when merging a63fc005c72f3c49be750a46e502fadd6e8a0cc5 into 03672a0998b25314359541951ccb311bf59ace19 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

fixed alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 1 when merging 6d100406d78994473d47aaf79b09efb4b17a01bf into 03672a0998b25314359541951ccb311bf59ace19 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

fixed alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 1 when merging 2b7499567c781cf588c5a7ffa9b31a9877368a64 into 03672a0998b25314359541951ccb311bf59ace19 - view on LGTM.com
new alerts:

1 for Superfluous trailing arguments

fixed alerts:

1 for Superfluous trailing arguments

Comment posted by LGTM.com


Improve some of the language.

Hope this is useful.

Thanks a lot for the correction.
Much appreciated.


YAML code blocks update

Fix #480

@shcheklein rechecking all the md5 values again. and also updating the blocks once again as per your suggestions.

@ryokugyu closing this as stale.


[Generators] ActiveJob

WIP !

Are there any plans on supporting helpers like http://api.rubyonrails.org/classes/ActiveJob/TestHelper.html ?
I'd expect to be able to do this for example:
expect(enqueued_jobs).to be(0)

@Onumis there is now: https://github.com/rspec/rspec-rails/issues/1334 :heart:

@cupakromer you're the men! :trophy:


Shadowed exception

This fixes #3249. I also realized that I had a boolean variable stored as the opposite of its name.
As mentioned in the issue, it appears that rescue nil will effectively disable the rescue in Ruby 1.9.3. In versions after 1.9.3, a TypeError is thrown when the statement is rescued. There is opportunity for us to add a new Lint cop to recommend against this.

I added an extra commit to improve the highlight area of this cop as well.


Ensure failing workflow steps do fail the workflow

I thought I saw an issue with Bundle checks or Tests where a workflow step might fail, but it will still pass because we might not be catching it correctly. I could be wrong however and would appreciate help.

@thadguidry Can you link me to the Workflow run? I can take a look.

I assume you're talking about the ones that ran for this PR, right? https://github.com/dev-drprasad/delete-tag-and-release/pull/31/checks
It looks like the Bundle Check did correctly fail but that wouldn't have stopped you from being able to merge. In order to stop merges until they pass, you'll have to configure a branch protection rule for the master branch that requires certain checks to pass before allowing merges..
You'll likely want to enable all 4 of the current checks to be required before allowing merges.
If instead you're referring to the "error messages" you see when running the tests, that's actually expected behavior. Since the tests run this Action's normal code as directly as possible, it logs as if it were really running. GitHub interprets those as error messages, since if it had outputted those messages when running as a real Action in a real repo, they would be error messages. But don't worry; the test isn't really failing.
However, if you'd prefer, I can configure Jest to hide that output entirely.

The output was fine and errors on test where they are expected is also fine, as long as tests are correct and are passing.
If npm run package itself has an exit error (i.e. there is no package found to run), then that workflow step will indeed fail and hence the workflow will fail?  Are you confident in the workflow steps themselves to fail with exit 1 so that steps fail when they need to and there is some problem?  That's what I was generally asking in this issue.
As for as branch protection; I'm only a collaborator here, not a repo owner (i.e. I do not see a SETTINGS tab above the repo)  So I am limited in what I can do.  I would like to enable main branch protection, as well as setup the checks that must past before allowing merges to happen.  I asked the repo owner in one of the issues on his other repos if I could be given co-owner access... we shall see.

Ah, I understand you. Yes, I'm somewhat confident in the bundle check logic. I tested it extensively (both purposefully and accidentally a few times 😅). I'm fully confident that the check will correctly fail if the bundle isn't updated. It's much more likely that the check will incorrectly fail when the bundle doesn't actually need to be updated. Which could be annoying for PRs but still solves the problem of enforcing that the bundle always matches the branch.
Also, shame about the branch protection.

Closing as non-issue as per @wardellbagby comments above.


⚠ Turnos 24x7 has degraded performance

In 01fa8e0, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1405 ms

Resolved: Turnos 24x7 performance has improved in 004abf4.