Diagnostic settings misbehaviour in Portal

I'd like to add/set diagnostic settings for a Storage Account (v2).
According to "Creating a diagnostic setting" section after entering "Diagnostic settings (preview)" I should be able to see blob/table/file/queue and add settings to them.
In fact I don't see anything there, what could be the reason?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 63c3effd-7cc3-f021-358a-adeaf59a0a69
Version Independent ID: 36381f6b-f57b-95a2-67cd-80bffcee238c
Content: Monitoring Azure Blob storage
Content Source: articles/storage/blobs/monitor-blob-storage.md
Service: storage
GitHub Login: @normesta
Microsoft Alias: normesta

Hello @gawkes1 , thanks for the question! We are taking a look into this and will get back to you soon.

@gawkes1 Firstly, apologies for the delay in responding here and any inconvenience this issue may have caused.
I'd recommend posting your question in https://azure.microsoft.com/en-us/support/community/ since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
However, you can refer to this article, Azure Diagnostics troubleshooting
Note: While creating a thread add the screenshot or the issue and please clearly what all troubleshooting steps have you tried already


Nesting FastAPI instances doesn't work very well

Do this:
main_app = FastAPI()
sub_api = FastAPI()

...
main_app.router.routes.append(Mount('/subapi', app=sub_api))

sub_api will correctly serve ever /subapi -- docs, methods, all that. However, the docs will still look for /openapi.json (absolute link) when trying to load the openapi spec. Additionally, the spec will not be adjusted to have the correct links, relative to where the module is mounted.
Perhaps this is a corner use case, but a lot of apps might have different collections of routes mounted in different subpaths.

@kkinder Can you share why do you want to server both public and internal stuff from the same instance? Isn't there a security contradiction?

@haizaar No, that's not a security problem at all. Both APIs have access to the same database, same permissions, etc.
It's more that I don't want to expose methods I intend to change the signature of soon to potential end-users.

@kkinder I see - so it's not internal (network-wise) API, but rather external API that serves both internal users and other users. If so, then I wonder why not having separate backends for those and route traffic to them using API GW? Should help with independent updates, etc.

@haizaar Just more hassle. The model is the same, the authentication is the same, the middleware is the same, the update cycle is the same. I just want some methods listed on different swagger files, more or less.

Guys, this should be solved by PR #26 by @kabirkhan.
It is released as 0.4.0, the new docs are here: https://fastapi.tiangolo.com/tutorial/sub-applications-proxy/ :tada: :rocket:
Let me know if it works for you.

As a side note, I think I tend to do the same as @haizaar, to set up different APIs in different backends (and different containers too), and then put them behind a load balancer (Traefik in my case).
But I also see how @kkinder's use case and others including having a reverse proxy make this feature relevant (so much there's another issue and this PR from above).

I guess this was solved. I'll close this issue now. But feel free to add more comments or create new issues.


Expose search to geospatial analysis

A placeholder ticket (without defined use case besides, "It'd be cool if we could 'X' since we have the technology and the data to do it."). See https://www.elastic.co/guide/en/elasticsearch/reference/current/geospatial-analysis.html for reference.

0.37 will index collecting-event eventGeom as geo_point


Tutorial ?

Hello , where can I find the tutorial for this plug in ?

Hello @TharHtetAungg ,
This plugin does not come with a tutorial. In my personal opinion, I do not think it is necessary as the component editor menu is self explanatory


Require ndt7 tokens and static verifier key

This change is

FYI: @robertodauria - I'll wait for the ndt-server changes to be tagged for review here. This is a preview.

Thank you!


Can't clear time picker when allowInput = false

If allow input is false (e.g., default), then there is no way to clear the time picker. The back space key does not work like it does in calendar mode.
You can reproduce this  by looking at the timepicker example from the docs:
https://flatpickr.js.org/examples/#time-picker
I have a use case where I don't want to allow input but I want users to be able to clear the value.
Thanks!

@freeman-g in this case I would suggest adding a button next/near the input to clear it. See https://flatpickr.js.org/examples/#flatpickr-external-elements for an example

This is a valid issue and shouldn't have been closed. If you have a text input that allows input, then among the things that the end-user should be able to input is the lack of a date/time.
This is a bug in FlatPickr.

thanks @wyattoday - I was thinking the same thing especially since the backspace key does clear the Flatpickr in Calendar mode.

+1 This is very confusing behavior for users trying to remove a selection.

+1. I would expect allowInput: false to disable delete and backspace clearing as well as text inputting.
case 8:   case 46:       if (isInput && !self.config.allowInput) {           e.preventDefault();           self.clear();        }  break;


[cppgraphqlgen] Update to v4.1.1 for latest release

Describe the pull request

What does your PR fix?
Updates the latest version from v4.1.0 to v4.1.1.

Which triplets are supported/not supported? Have you updated the CI baseline?
All triplets are supported, but ci.baseline.txt still has an exception for x64-linux because the version of GCC is not new enough in the CI workflow.

Does your PR follow the maintainer guide?
Yes.

Yes.

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Thanks for the update!


Refactoring the Code object/module

The Code object appears to have an implementation that makes it rather rigid and difficult to work with. It inherits from a class that makes it rather confusing, given that it is in the text namespace, and it seems to have an implementation that breaks several design principles that would help to improve its maintainability and possibility for reuse in other modules and packages.
I would like to propose a refactor or implementation of the module code_mobject from which it derives. I have several suggestions that would serve as a starting point for discussion.
Before I continue, I just want to note that my primary experience in software development lies in other languages where things are done differently from what may be standard in Python. Additionally, I am not entirely familiar with the Manim library at large, so I hope I have not ignored intentional design choices due to some particular reason.
Observed issues
The interface
Problem
This problem is hard to describe and propose a single solution to, so I would like to motivate you with an example.
Suppose I wish to start off with a simple animation between these two code blocks, read from two files. I would like to use something like TransformMatchingTex, but unfortunately, Code is not compatible.
A second example is showing/fading in one line (or word) at a time. I have been told there are "invisible dots", and so steps have to be taken to perform this task. The Code object does make life a lot nicer, providing code highlighting, but there is an additional boilerplate surrounding its use that can likely be reduced.
Proposed solution
I admit that Python is not my strongest, most fluent language, so I do not have the skills to claim my way is a sound solution. So, what I suggest may not be best suited for Python.
I would suggest a form of adaptor interface or some other structural design pattern that best allows the user to interact with Code as if it were a text-like object. I am not sure what would be the best approach, since it makes sense to treat Code as a group. Yet, being that is it a complex structure by nature, not having the powerful tooling available to other text objects makes it difficult to use.
An alternate solution comes from the solution to the following problem.
Too much responsibility
Problem
The Code object has a lot of responsibility. For example, it is able to generate HTML and JSON. The latter of which takes up almost 100 lines of code, or around about 15% of the file. Furthermore, the particular method responsible for generating the JSON is littered with several commented-out print statements, which would indicate a form of debugging that was never removed.
Another detail is that the constructor generates a background from within its own class. Again, by employing the solutions listed in the next section, a user can design their own background and pass the code to it to use.
Proposed Solution
A refactoring of the class, in short. Firstly, putting the Background, HTML, and JSON generators into their own concrete class (with their own interfaces) allows you to implement a behavioural design pattern, such as the strategy or visitor pattern. This additionally allows for other generators to make use of and consume the Code class, were they ever needed to be made.
Secondly, and related to the previously listed problem, a refactor of the class, with the generators taken outside the class's responsibility, the class can be modified to better incorporate other interfaces. As mentioned earlier, if the Code class were to be believed as being able to be animated just as flexibly as other objects, then, since it is complex in nature, another interface may better suit the object. This would provide users with a means to interact with elements that compose the object's structure, which is currently rather difficult to do in complex cases.
As an example, suppose I had a Code object. Perhaps a code.get_word(5) returns a view of the 5th word. Or, if I want a line, code.get_line(3). These needn't necessarily return the internally maintained objects/strings/tex objects. It might make sense to instead return an object that would expose those lower-level components as an animatable object, which allows you to transform and animate the individual components as if they were. I say that since I do not fully understand how everything works beneath the Code object layer. For example, it may be difficult to build a more complex object to provide a better way to animate composed units, such as words, while being able to provide adequate syntax highlighting throughout the animation. Hence, exposing these units (e.g., a word) to be animated or modified (such as for overriding the syntax colour highlighting with something like .set_fill()) would encapsulate the state of that unit, and only expose the necessary tools for animating or modifying that unit.
I want to further describe that last point. Suppose you stored each word individually. Rather than returning a Tex object, or some other such object, you may return something else that allows the object to be consumed by the user. Now, I am not sure how this would be done in Python, so I may be coming across as ignorant, so I do apologise. In a language such as C#, you could return the type by an interface. So, a text-like object may have an IText interface, but you instead return the object as an IAnimatable, which changes how the user can interact with it. In Python, this "idea" may be done functionally, as much of Manim already is, such as by taking functions as arguments.
In closing
The Manim library is inherently a mathematics library and a Code object is something valuable given that there are many areas of STEM that overlap with mathematics, and so the Code class allows folks to incorporate the software side of mathematics into their animations.
I would like to motivate the discussion on extending this part of the Manim library, as it would be very helpful and useful for enhancing the creative possibilities of users by reducing the amount of work and confusing kinks they have to manage themselves.
I would love to have the opportunity to work on this myself, but unfortunately, I am unable to give my attention to this until closer to the end of the year. Assuming this is not addressed, I may very well do so then. For now, I would love for the discussion to begin, in the hopes that there are others out there like me, who would much appreciate using the library to present software animations.
Again, I apologise if I was off with any ideas or suggestions, not having the full understanding I require to properly achieve what I would like to suggest. I have had only a few weeks and limited time to learn the library's source, in the hope of using it for a project, but I ran out of time trying to get the Code object to behave in the way I would like. I did make some good progress, so I do hope my other experiences have allowed me to correctly translate my ideas in a manner that describes good and approachable ideas.

As a note for either myself in the future, or anyone else, it may be possible to largely reduce the complexity of the class without the need for HTML or JSON generation. I don't know the full specifications of Manim, nor the full complexity regarding LaTeX's use within Manim, but I see that pygments has a LaTeX formatter. I am not sure if the current class has a reason for why it has its current architecture, but it is purely historical, this (or the following) suggestion may better suffice.
While this is one approach, I would propose that a custom formatter may better suite the class, as it would allow for complete control of text using the existing library features. Though, this would require planning as originally mentioned in my original post. I will certainly think on this in a few months, should no one else tackle this, and there is interest in a refactor/reworking. If not, I will happily move this idea into a plugin.

For any practical purpose, formatting the code via LaTeX is almost surely a step in the wrong direction though.

I suspected as much. I didn't like the idea of requiring new packages, so it is more appealing to try an alternative approach.
I'll definitely give it a crack later this year, should no one else pick up interest.

While my University semester is still set to kick off, I decided to look more into this. I found a new potential implementation that seems to solve every problem, and so I wanted to get the opinions of folks with more experience using Manim.
The Pygments library provides all the tools for lexing and formatting, which is currently part of the architecture. I noticed, however, that Manim has the object MarkupText, which processes PangoMarkup. Incidentally, there is a pygments formatter for that.
In my fork of Manim, where I am currently experimenting, I currently just do
self.Text = highlight(
            self.code_string, lexer, PangoMarkupFormatter(style=self.style)
        )

within the __init__. In the state that the class is currently in (due to experimenting), I can render code really easily
class Test(Scene):
    def construct(self):
        file = "D:/Programming/ForkRepos/manim/testing_code/code.py"
        code_pango = Code(code_file_path=file, style="github-dark").Text  # This is not pretty for now
        code = MarkupText(code_pango).scale(0.5)

        self.play(Create(code))
        self.wait(2)

Result screenshot:

The leading alternatives to this would be either to use the HtmlFormatter, as used previously, but with a proper deserializer to then construct a dedicated object encapsulating the total combined structure of the code (e.g. as a VGroup containing all the various parts, as it more or less already is), or a custom formatter -- this latter idea has some kinks in terms of what the formatter interface requires. Both are problematic, either being more complex or by having potentially incorrect use of the formatter's interface (I think, I am not looking into custom formatting until after this semester, if necessary). Hence, this above proposal seems to be a perfect solution.
Are there any limitations regarding the use of MarkupText over other text objects? This approach solves a lot of problems if not. In fact, it would mean that Code would largely be a simple MarkupText with the __init__ logic I have in my fork, and little else (unless it makes sense to add helper functions for animations or something).

👍🏼 to me it makes sense that a piece of code is just some MarkupText 🤷🏼 How about the speed of this i remember Code objects being horrificly slow in the past. Does that improve the Situation a little bit?

How about the speed of this

I don't really remember, to be honest. It did have some issues that I had trouble avoiding such as no progress updating in the console when animating the object. I was working on an alternate solution/implementation, which is where my fork of the repo is currently situated.
For the moment, my implementations are very experimental, but am planning to do some benchmarking (even if it is only basic) when I finish my semester in a few months. Speed, for example, is one important thing I have in mind. It may not improve too much, but it certainly shouldn't get worse.
My current redesign (if my memory serves correctly) inherits from another object and seemed nicer than other experiments. Unfortunately, there were some issues, and I think it comes back to this lovely function. I didn't have time to work out how this works, so the problems with Code may be a bit deeper, and will take some more time, in the future.

Okay, that seems good just take your time with it! Happy to have you contributing!

#3237  Might be fixed by this

#3237 Might be fixed by this

Yeah, I noticed some issues with Code and font ligatures. I was never able to get FiraCode to be recognised. It's odd. I haven't looked into why yet. Definitely something in the back of my mind, though.

Any updates ?

Any updates ?

Apologies for not giving any updates. I am hoping to get into this after New Year's. There are some things up in the air regarding my study, but I should be able to do something either way :)


how to add new sd models?

only two models

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."


[Feature Request]: Change font color for soothing user experience

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I have observed that the red-lined font looks like a warning kind of answer, very disturbing to any user. I would love to solve this issue. Please assign this task to me under gssoc'24 extd and hacktoberfest @s

Use Case
Better experience and more impact.
Benefits
This feature would definitely improve user experience.
Priority
High
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

Hello PA, I want to work on this issue. Can you assign it to me?

I'm working on this
On Thu, Oct 24, 2024, 5:30 PM Anchal chaturvedi @.***>
wrote:

Hello PA, I want to work on this issue. Can you assign it to me?
—
Reply to this email directly, view it on GitHub
https://github.com/recodehive/Stackoverflow-Analysis/issues/384#issuecomment-2435082130,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7I3YXFPI5IDX263BOHMTYTZ5DOMRAVCNFSM6AAAAABPW27VM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVGA4DEMJTGA
.
You are receiving this because you were assigned.Message ID:
@.***>

@sanjay-kv I have solved the issue. Please check out.


Trigger branches without input values

Just a reminder that this usecase came up again during the Hackaton on Haystack 2.0 demos. @julian-risch has more context about the specific usecase.

This should be fixed


Content pack jr

add base backpack

resprite wooden frame

add wallpaper sprite

small sprite changes

[x] gobby was killed

no Gobby were harmed.

@TheShuEd чек описание.

все гуд


Add target arch support

Addresses comments in pull request #55.

Please merge this!

this will get published the next time electron gets released by GitHub


[frontend] upgrade to TypeScript

TODO:  cypress needs to comply with TS.  Will do tomorrow.
Description
Modernization effort
List of proposed changes:

add TypeScript
convert existing components and pages to .ts | .tsx

🤯


Merge Development into main

Codecov Report
Base: 43.28% // Head: 45.60% // Increases project coverage by +2.31% :tada:

Coverage data is based on head (6f2ef92) compared to base (1c8d1f1).
Patch coverage: 78.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   43.28%   45.60%   +2.31%
==========================================
  Files          81       85       +4
  Lines         529      557      +28
  Branches       46       47       +1
==========================================
+ Hits          229      254      +25
- Misses        260      263       +3
  Partials       40       40

Impacted Files
Coverage Δ

src/containers/helpers/home.mapper.tsx
0.00% <0.00%> (ø)

src/mocks/fixtures/rooms.ts
77.77% <ø> (ø)

src/components/Atoms/Icon/Icon.tsx
63.88% <37.50%> (-1.83%)
:arrow_down:

src/components/Organisms/Card/Card.tsx
84.61% <71.42%> (-7.70%)
:arrow_down:

src/components/Atoms/Icon/Icon.stories.tsx
100.00% <100.00%> (ø)

.../components/Molecules/Carousel/Carousel.fixture.ts
100.00% <100.00%> (ø)

...components/Molecules/Carousel/Carousel.stories.tsx
100.00% <100.00%> (ø)

src/components/Molecules/Carousel/Carousel.tsx
75.00% <100.00%> (+3.57%)
:arrow_up:

src/components/Molecules/Carousel/index.ts
100.00% <100.00%> (ø)

src/components/Organisms/Card/Card.fixtures.tsx
100.00% <100.00%> (ø)

... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Mount only subfolder of projet

I'm using devilbox on windows "docker for windows", but the issue is that working with magneto2 on docker (windows) is extremely slow.
I dealt with it (in my previous docker setup) by mounting only  the "/ app" subdolder of magento, not the entire folder with the magento installation.
But I'm not sure how do it on devilbox.
Can someone provide instruction, how to after magento installation
disable mount
data\www
and mount only
data\www\my_project\htdocs\subfolder_to_mount

You can override the mount via docker-compose-override.yml. See docs here: https://devilbox.readthedocs.io/en/latest/configuration-files/docker-compose-override-yml.html
I'm not sure if this will work at all, if only part of your code is available inside the container.
Nevertheless, hope this helps.


fix(lobbies): make list_regions public

#159  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite

Merge activity

Sep 17, 12:24 AM EDT: @NathanFlurry started a stack merge that includes this pull request via Graphite.


Merged the content with Benefits of MSAL

Based on an email discussion, merging Benefits of MSAL.docx with the concept page. Details here - Task 2161746: [Documentation][MSAL]Landing Page explaining 'Why MSAL' is needed to start S500 Customer Engagement

Learn Build status updates of commit 3576b6d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/active-directory/develop/msal-migration.md
:warning:Warning

Details

articles/active-directory/develop/msal-migration.md

Line 39, Column 267: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/fundamentals/resilience-client-app?tabs=csharp#use-the-microsoft-authentication-library-msal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 80, Column 80: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/reference-v2-libraries#single-page-application-spa' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 83, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-objc-adal-msal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 84, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-adal-msal-java' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 85, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/msal-net-migration' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 86, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/msal-node-migration' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 87, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-python-adal-msal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 39, Column 267: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/fundamentals/resilience-client-app?tabs=csharp#use-the-microsoft-authentication-library-msal' will be broken in isolated environments. Replace with a relative link.
Line 80, Column 80: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/reference-v2-libraries#single-page-application-spa' will be broken in isolated environments. Replace with a relative link.
Line 83, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-objc-adal-msal' will be broken in isolated environments. Replace with a relative link.
Line 84, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-adal-msal-java' will be broken in isolated environments. Replace with a relative link.
Line 85, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/msal-net-migration' will be broken in isolated environments. Replace with a relative link.
Line 86, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/msal-node-migration' will be broken in isolated environments. Replace with a relative link.
Line 87, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-python-adal-msal' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@Rinki-MSFT
Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request. Thanks!

@CelesteDG , Thanks for reviewing. I have applied your suggestions. Let me know if anything else is needed from my side.

Learn Build status updates of commit 2eb8113:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/active-directory/develop/msal-migration.md
:warning:Warning

Details

articles/active-directory/develop/msal-migration.md

Line 39, Column 267: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/fundamentals/resilience-client-app?tabs=csharp#use-the-microsoft-authentication-library-msal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 80, Column 80: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/reference-v2-libraries#single-page-application-spa' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 83, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-objc-adal-msal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 84, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-adal-msal-java' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 85, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/msal-net-migration' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 86, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/msal-node-migration' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 87, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-python-adal-msal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 39, Column 267: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/fundamentals/resilience-client-app?tabs=csharp#use-the-microsoft-authentication-library-msal' will be broken in isolated environments. Replace with a relative link.
Line 80, Column 80: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/reference-v2-libraries#single-page-application-spa' will be broken in isolated environments. Replace with a relative link.
Line 83, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-objc-adal-msal' will be broken in isolated environments. Replace with a relative link.
Line 84, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-adal-msal-java' will be broken in isolated environments. Replace with a relative link.
Line 85, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/msal-net-migration' will be broken in isolated environments. Replace with a relative link.
Line 86, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/msal-node-migration' will be broken in isolated environments. Replace with a relative link.
Line 87, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/develop/migrate-python-adal-msal' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 79868fc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/active-directory/develop/msal-migration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@Rinki-MSFT please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree [company="{Microsoft}"]

Hi @Rinki-MSFT - Please incorporate the changes I made to the PR. Thank you.

Done. Thank you

@Rinki-MSFT the command you issued was incorrect. Please try again.
Examples are:
@microsoft-github-policy-service agree

and
@microsoft-github-policy-service agree company="your company"

@microsoft-github-policy-service agree company="Microsoft"

To the PR review team: Reviewed the contribution. As business approver for this area, I approve of the changes.
Thank you.
#sign-off

#sign-off

@Rinki-MSFT @jmprieur @CelesteDG  - there are a couple things in this PR that make it imprudent to merge into the public repo.  I've made a couple of comments about these issues, but with so many changes, the commits should be moved to the private rep.
Can you move the commits to the private repo and open a PR there?  We can help with that, but we recommend addressing the above issues before you do:
Thanks
#hold-off

Thank you, @Jak-MS - I forgot I made that comment about the other image. It needs to be resolved or the link removed altogether.
@Rinki-MSFT - Can you please address?
Thank you.

Learn Build status updates of commit 9896165:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/active-directory/develop/msal-migration.md
:warning:Warning

Details

articles/active-directory/develop/msal-migration.md

Line 38, Column 24: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/active-directory/azuread-dev/azure-ad-endpoint-comparison' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 38, Column 24: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/active-directory/azuread-dev/azure-ad-endpoint-comparison' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Thank you, @Jak-MS - I forgot I made that comment about the other image. It needs to be resolved or the link removed altogether.
@Rinki-MSFT - Can you please address?
Thank you.

Addressed all the comments.

#sign-off

#sign-off

Learn Build status updates of commit d7cd714:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/active-directory/develop/msal-migration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit a3175b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/active-directory/develop/msal-migration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


[topgen/plic] Handling interrupt CDC

Whether inside each HW IP or inside PLIC, it should have 2flip-flop synchronizer if the interrupt is created in different clock domain, currently UART/GPIO/SPI_DEVICE are clocked at fixed clock (even the clock source is same at this moment)

RV_PLIC has synchronizer : A little bit hard to templating the plic top
CDC on the path at the top: Is it normally OK to have CDC logic at the top (or any other logic except instances and connections)
Inside each IP: How should IP know if it receives different clock source than the main clock?

CC: @tjaychen @msfschaffner

I added preliminary functionality for this to the alert handler (and the corresponding topgen logic). it's basically a logic parameter that I pass to the alert handler, which indicates whether CDC modules should be instantiated for a particular alert within the RX/TX pairs:
https://github.com/lowRISC/opentitan/blob/e19f42bd81f1a452be7d1528e23d47aec85a9dd4/hw/ip/prim/rtl/prim_diff_decode.sv#L43-L71
topgen extracts the information by comparing the clock name of the sender module and the alert handler, and passes that info to reggen, which in turn places it into the register package:
https://github.com/lowRISC/opentitan/blob/e19f42bd81f1a452be7d1528e23d47aec85a9dd4/util/topgen/merge.py#L94-L105
https://github.com/lowRISC/opentitan/blob/e19f42bd81f1a452be7d1528e23d47aec85a9dd4/hw/ip/alert_handler/rtl/alert_handler_reg_pkg.sv#L14
not saying this is ideal, but maybe you could do it in a similar way...

it looks like we resolved this issue by just jamming in synchronizers inside rv_plic.
we ended up doing this indiscriminately i believe.


Near Interaction Press is working in Unity Game view, but not physical Hololens when deployed.

Describe the bug
I am not able to use any buttons via near interaction on my Hololens 2. I have to use far-interaction hand rays instead. In my Unity Game view, however, everything is working exactly as it should. Also, for some reason, near interaction grabbables work on my hololens too, just not pressables like buttons.
To reproduce
Steps to reproduce the behavior:

Create Unity Project w/ MTRK with DefaultHololens2ConfigurationProfile
Create a Hololens2 Button from Prefab
Create a basic cube with Box Collider, Object Manipulator, and Near Interaction Grabbable
Go into Unity game mode, and press button (Listening for default sound effects) and grab cube.
Deploy to Hololens, and do same actions as Step 4.

Expected behavior
I expect to hear sound effects for near interaction pressing when on my hololens.
Screenshots
If applicable, add screenshots to help explain your problem.
Your setup (please complete the following information)

Unity Version [2020.3.25f1 Personal]
MRTK Version [v2.7.3]

Target platform (please complete the following information)

Hololens 2

Additional context
I came across this problem when I was going through the Hololens 2 Fundamentals Tutorial, and I tried deploying the Mars Rover project to my Hololens 2. I am new to Hololens and Holograms in general, so all feedback is welcome.

We haven't been able to reproduce this issue on v2, nor on the new v3 architecture. Closing for now unless we see more occurrences of this happening/have some video/logs to look at.


AIX 7.1 - Attempts to install says I must run make, despite already running make.

I am still using the GA version of 0.3.3, with modification to memory.c, Makefile.install, and Makefile.system.  I am getting this message:
$ sudo make install
The license for the Evaluation version of IBM XL C/C++ for AIX V11.1 compiler product has expired. Please send an email to<EMAIL_ADDRESS>for information on purchasing the product.
make: *** [Makefile.prebuild:62: getarch] Error 1
make -j 1 -f Makefile.install install
make[1]: Entering directory '/scratch/focal_point/Packages/OpenBLAS'
Makefile.install:21: *** OpenBLAS: Please run "make" firstly.  Stop.
make[1]: Leaving directory '/scratch/focal_point/Packages/OpenBLAS'
make: *** [Makefile:336: install] Error 2

Licensing message disappears if I use the same value I use for the compile, which to remind you is:
make BINARY=64 CC=gcc FC=gfortran FFLAGS="-O2 -maix64" RANLIB=ranlib LD=ld AR=ar MAKE_NB_JOBS=1
Same error message.  This is my 5th AIX 7.1 server install, and I never saw this one before.  Details attached for the make -d install:
log.txt
I don't understand why there's an error with getarch.
I am cleaning and recompiling and will update this ticket accordingly with the logs.

Your "compiler" did not compile "getarch" detection program.
You need a C compiler that emits binaries, like fine free gcc.

To clarify this - I did invoke the compiler in the other make:
make BINARY=64 CC=gcc FC=gfortran FFLAGS="-O2 -maix64" RANLIB=ranlib LD=ld AR=ar MAKE_NB_JOBS=1
make.txt
sudo make -d CC=gcc install > install.txt 2>&1
install.txt
As you can see, even when invoking gcc as the compiler, it continues to demand that I run make first, despite already doing so immediately before.
Another reminder:  This successfully worked on other AIX platforms, and I confirmed that the makefile changes matches on from the working environments and this one.  What can I do to expand on the reason for make install to demand I run make again?
To help, here's the modified Makefiles:
Makefile.install.txt
Makefile.system.txt

Does it work when you invoke the make install with both CC=gcc and BINARY=64 ?

Unfortunately, no.
Password:
make -j 2 -f Makefile.install install
make[1]: Entering directory '/scratch/focal_point/Packages/OpenBLAS'
Makefile.install:21: *** OpenBLAS: Please run "make" firstly.  Stop.
make[1]: Leaving directory '/scratch/focal_point/Packages/OpenBLAS'
make: *** [Makefile:336: install] Error 2

Strange. I see now that the Makefile.install is acting on a simple token - it expects an empty file "lib.grd" to be present as a sign that make has been run before (there is a touch lib.grd at the end of the libs target in Makefile). Do you have this file in /scratch/focal_point/Packages/OpenBLAS ?

Yup:
$ ls -al lib.grd
-rw-r--r--    1 Me  staff             0 Nov 30 13:13 lib.grd

Just for fun - do you still see it when you do sudo ls -al lib.grd ?

$ sudo ls -al lib.grd
Password:
-rw-r--r-- 1 Me staff 0 Nov 30 13:13 lib.grd

Hmm. System time or filesystem timestamp problems perhaps (lib.grd seen to be older than Makefile.install or some such) ?

Sorry, had to take care of things over the weekend:
-rw-r--r-- 1 u071625 staff 9355 Nov 30 10:31 Makefile.install
-rw-r--r-- 1 u071625 staff 0 Nov 30 13:13 lib.grd

Full file listing:
result.txt

Strange. Do I understand correctly that the same make install worked on a number of other AIX machines, and just one system is giving you this problem ?

That is correct.  The modified files (driver/others/memory.c, Makefile.install, and Makefile.system) was explicitly copied over from a different AIX server to this one.  Also confirmed (oslevel -s) that everything matches (7100-05-01-1731).  The only difference is AIX Toolbox's info-6.4-1.aix6.1.ppc.rpm and rpm.rte <IP_ADDRESS> on newer server, and info-6.3-1.aix6.1.ppc.rpm and rpm.rte <IP_ADDRESS> on older server.  I doubt they play a part, but have to mention.
I could chalk it up to "there is a ghost in this server" and package up the existing binaries on a different AIX server, and install on the new server.  Is there a documentation where everything is parked on, or do I have to go through the Makefile.install script to find them all?

Guess you could try touch lib.grd (or change the keyword error in Makefile.install to info)... ghost in this server looks plausible if there were no issues with the build as such.

Interesting.  When I changed to info, I got this:
Makefile.install:24: *** missing separator (did you mean TAB instead of 8 spaces?).  Stop.

It turns out that the file had all of its tabs converted to whitespace for some odd reason.  I fixed this, and the install script works.
So there's a ghost in the sftp software or something else that broke this the first time.  Maybe I watered the file after midnight by mistake...
Sorry about this, closing.


is node-main support ?

i add node-main in the package.json
"node-main": "./app.js",

the app.js startup express  server
but it not works
how to debug that ? no error logs

I just tested this and it works fine. As long as the file is included in the files array, either explicitly or in a glob pattern like **/* and it is not in the excludes, it will be copied to your dist. Also you need to make sure you are not using strippedProperties to remove node-main.
You should inspect your node_modules in your dist folder to see if it includes all the dependencies you need. If express is a devDependencies, then it will be stripped and not installed in your dist.

many thanks ,i use electron instead ,i will try later .


change generated function env package name from @env/<function-name> to $amplify/env/<function-name>

Environment information
System:
  OS: macOS 14.3.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 126.34 MB / 32.00 GB
  Shell: /opt/homebrew/bin/fish
Binaries:
  Node: 20.11.1 - ~/Library/Caches/fnm_multishells/74988_1710440395564/bin/node
  Yarn: 1.22.19 - ~/Library/Caches/fnm_multishells/74988_1710440395564/bin/yarn
  npm: 10.2.4 - ~/Library/Caches/fnm_multishells/74988_1710440395564/bin/npm
  pnpm: 8.15.5 - ~/Library/Caches/fnm_multishells/74988_1710440395564/bin/pnpm
NPM Packages:
  @aws-amplify/backend: 0.13.0-beta.8
  @aws-amplify/backend-cli: 0.12.0-beta.8
  aws-amplify: 6.0.21
  aws-cdk: 2.133.0
  aws-cdk-lib: 2.133.0
  typescript: 5.4.2
AWS environment variables:
  AWS_PROFILE = josef-gen2
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Description
The preceding @ on the current package names for generated env files used with Functions can be confusing, alluding to a separate npm package given the convention of using the @ symbol for package scopes.
Requesting change to the $ symbol and an amplify namespace.
from:
import { env } from "@env/post-confirmation"

to:
import { env } from "$amplify/env/post-confirmation"

it can also be considered to have a smaller import path without the amplify namespace
import { env } from "$env/post-confirmation"

marking as a feature request

released in https://github.com/aws-amplify/amplify-backend/pull/1192


JS: Added support for numeric separators

This fixes #1893.
The number pattern is quite a bit longer because of this change, so any ideas on how we could simplify this are more than welcome.

Spec changes.

@mathiasbynens Thank you for reviewing!

@RunDevelopment Thanks for the quick patch!
There’s no rush, but what’s the general process for releasing a new prism-js version on npm? Is there a fixed release schedule or something like that?

There is no fixed release schedule. A new version usually gets releases once enough changes have been made.
Looking at the committed changes since 1.16 and the pending PRs, I would say that we will release 1.17 soon (maybe in a few weeks or so).


Bug in combination with quickfix windows.

I use <cr> to Toogle zoom. If I press enter in quickfix window to go to the corresponding location, I get the following error:
E5108: Error executing lua ...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:25: Vim(tabedit):E499: Empty file name for '%' or '#', only works with ":p:h": tabedit %:p
stack traceback:
        [C]: in function 'cmd'
        ...nvim/site/pack/packer/start/NeoZoom.lua/lua/neo-zoom.lua:25: in function 'maximize_current_split'
        [string ":lua"]:1: in main chunk

Let me fix this now, wait some minutes

Since I don't know how to use quickfix list, so I didn't test the case when there are some items in it. But with an empty quickfix list and pressing <cr> I got no error after the newest update. You might try it and let me know the result :)

Now there is no error, but if I hit enter to go to the corresponding instance, nothing happens anymore. So Quickfix window is not working anymore.

@zbindenren Let me fix it again now...

@zbindenren: I will try to make this configurable, but as a temporary solution could you try this one in your .lua file?
vim.api.nvim_set_keymap('n', '<CR>', "if &ft != 'qf' ? 'NeoZoomToggle' : '<CR>'", { expr = true, noremap = true, silent = true, nowait = true })

Of course I have a lua config :smile: . Your suggestion did almost work, but with the following it seems to work:
keymap(
	"n",
	"<cr>",
	"&ft != 'qf' ? '<cmd> NeoZoomToggle <cr>' : '<cr>'",
	{ expr = true, noremap = true, silent = true, nowait = true }
)

see the <cmd> before NeoZoomToggle and the <cr> after.

@zbindenren: Lol, you're right, and I'm happy that you resolved it yourself! Thanks for your issue, let me fix the Readme now :)


sfdx force:source:deploy Cannot read property 'record' of undefined

Summary
sfdx force:source:deploy -u $deploy_username -l RunLocalTests -p force-app
Steps To Reproduce:
run it from the command line
Expected result
it will start deployment
Actual result
ERROR running force:source:deploy:  Cannot read property 'record' of undefined
Additional information

--dev-debug

[jaysonfaderanga@ip-172-30-0-21 salesforce]$ sfdx plugins
no plugins installed
[jaysonfaderanga@ip-172-30-0-21 salesforce]$ sfdx plugins --core
@oclif/plugin-autocomplete 0.1.5 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-help 3.1.0 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.9.0 (core)
@oclif/plugin-update 1.3.10 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-trust 3.2.1 (core)
analytics 1.12.0 (core)
generator 1.1.3 (core)
salesforcedx 49.6.1 (core)
├─ salesforce-alm 49.6.0 (core)
├─ salesforcedx-templates 49.2.0 (core)
├─ @salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
└─ custom-metadata 1.0.8 (core)
sfdx-cli 7.70.1 (core)

Same issue. Had to downgrade the salesforcedx version to be able to work:
sfdx plugins:install<EMAIL_ADDRESS>

awesome thanks @cesarParra , your suggestion works, hopefully they fixed it in the upcoming versions, for now I remove the update script and keep the 49.5.0..

I got the same error this afternoon when trying to perform "sfdx force:source:retrieve". Managed to get around it by following the same downgrade path.

I had the same issue and downgrading the plugin worked. Thanks @cesarParra.

Same here, downgrade helped.

Dup of #564.


Find an elegant way to track changes in follower/following over time

handling multiple archive uploads from the same person. e.g. their following/followers may have changed since last time and we may only want to display the most recent lists. Also allows us to estimate a bit of the following / follower history.
suggestion: track changes in an "append only" way - i.e. rows with type "follow" and rows with type "unfollow", then have functions to reconstruct the present graph from history - also add a view for just the present follow graphs

we added upload_archive_id


Python templates fixups

/cc @frenzymadness

@frenzymadness plz accept this. It should fix the failing tests.

You can push fixup commits directly to the main PR.


Crashes when closing a window with multiple monitors connected

Describe the bug
When I hit Mod+C to close a window and have a second HDMI monitor connected, Hyprland crashes immediately.
Images/videos/anything that would help
Please attach a log (it's in /tmp/hypr/hyprland.log) and, if crashing, a crashdump (coredumpctl, then coredumpctl info )
Please do NOT attach coredumps from any packaged version of Hyprland (AUR, etc.). Compile manually, and THEN attach a coredump of that.
crash_multi_monitor.txt
hyprland.log
EDIT: It is now just crashing everytime I try and close a window, even with no external monitor connected.
I have only added this line to my config:
monitor=eDP-1,1920x1080@144,0x0,1 and it seems to be the cause, as I then get crashes.
I can add monitor=HDMI-A-1,1920x1080@60,0x0,1 to my config (and get mirrored displays) and do not get any crashes, as long as I don't have the above eDP line. However if I add any offset it crashes when closing windows as well.

I think the defualt config quits Hyprland when you use mod + c could you post your config (in ~/.config/hypr/hyprland.conf)

The default behavior does indeed close a window.

I think it's something to do with your refresh rate have you tried using:
monitor=eDP-1,1920x1080@60,0x0,1

For me I have a laptop and moniter and can configure them to not mirrorby moving them EG:
monitor=,1920x1080@60,0x0,1 #hdmi moniter monitor=eDP-1,1080x720@60,300x1080,1 #laptop screen notice the 300x1080 this moves it down so you do not get mirrord displays

you can also try to use the releases if you don't know how to compile properly.


@Testcontainers is not found in parentclass

i am currently trying to upgrade from testcontainers version 1.11.4 to 1.12.1
it looks there might be an regression between that versions.
our current code (using v 1.11.4 looks like that). It uses an abstract base class that contains the @Testcontainers annotation.
@Testcontainers
abstract class MongoTests {
  ...
}

class MongoRepositoryIT(
...
) : MongoTests() {
  ...
}

this setup causes an runtime exception when upgrading to v 1.12.1:
Caused by: org.junit.platform.commons.PreconditionViolationException: Illegal state: required test class is not present in the current ExtensionContext
	at org.junit.platform.commons.util.Preconditions.condition(Preconditions.java:281)
	at org.junit.platform.commons.util.Preconditions.notNull(Preconditions.java:54)
	at org.junit.jupiter.api.extension.ExtensionContext.getRequiredTestClass(ExtensionContext.java:141)
	at org.testcontainers.junit.jupiter.TestcontainersExtension.findTestcontainers(TestcontainersExtension.java:62)
	at org.testcontainers.junit.jupiter.TestcontainersExtension.evaluateExecutionCondition(TestcontainersExtension.java:55)
	at org.junit.jupiter.engine.execution.ConditionEvaluator.evaluate(ConditionEvaluator.java:64)
	... 41 more

i can work around that by putting the @Testcontainers annotation directly into the concrete test class:
@Testcontainers
class MongoRepositoryIT(...)

sure. its the same exception with v 1.12.0. the workaround also works

@abendt-mhp thanks!
FYI this task is up for grabs if anyone wants to contribute it :) We will eventually take a look, but would also appreciate a fix contributed.
I confirm that org.testcontainers.junit.jupiter.inheritance.InheritedTests test fails if we remove @Testcontainers annotation from it.

I'd be interested taking this on

@bmuskalla thanks! It is yours 👍
I will soft timebox it to 7 days, just so that we can check in one week whether you are still working on it :)

@bsideup friendly ping :)

@bmuskalla thanks for the ping! 👍 there is one trivial thing (codestyle), happy to merge after 🎉

Hello! Could you tell when this PR will be merged approximately?

waiting for a new release that includes the fix as well :)

@Nipel-Crumple there is a PR (#1845) from @bmuskalla that waits a bit of polishing before we merge it

is it just because of the star import? i could fix that in case

Sorry, I totally missed the notification on this one. Pushed a new PR (#2001) for this with the imports fixed (and mssed up the old PR)

@bmuskalla thank you! 👍

Fixed by https://github.com/testcontainers/testcontainers-java/pull/2001


User location

Any plan to handle user location for channels (ie. Telegram) that support it?
Can we expect to find a dedicated button on bot emulator?

I think you should take a look at this one: https://github.com/BotBuilderCommunity/botbuilder-community-dotnet/tree/master/libraries/Bot.Builder.Community.Dialogs.Location
At the moment it supports Facebook Messenger's native location picker (not Telegram's), but based on this I think you could add support for Telegram as well - and submit a PR with your implementation, of course! ;)

I will have a look but I had something more "early" in pipeline since Telegram had "live location features" that not block the dialog with the user.
I think I will intercept it in Adapter.


[SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

What changes were proposed in this pull request?
For SQL
SELECT TRANSFORM(a, b, c)
  ROW FORMAT DELIMITED
  FIELDS TERMINATED BY ','
  LINES TERMINATED BY '\n'
  NULL DEFINED AS 'null'
  USING 'cat' AS (a, b, c)
  ROW FORMAT DELIMITED
  FIELDS TERMINATED BY ','
  LINES TERMINATED BY '\n'
  NULL DEFINED AS 'NULL'
FROM testData

The correct
TOK_TABLEROWFORMATFIELD should be , nut actually  ','
TOK_TABLEROWFORMATLINES should be \n  but actually '\n'
Why are the changes needed?
Fix string value format
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT

FYI @maropu

Test build #127430 has started for PR 29428 at commit b4d816e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32051/
Test PASSed.

Test build #127430 has finished for PR 29428 at commit b4d816e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127430/
Test PASSed.

Test build #127444 has started for PR 29428 at commit 65f69ba.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32065/
Test PASSed.

Test build #127455 has started for PR 29428 at commit 0a6c574.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32076/
Test PASSed.

Test build #127444 has finished for PR 29428 at commit 65f69ba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127444/
Test PASSed.

Test build #127455 has finished for PR 29428 at commit 0a6c574.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127455/
Test FAILed.

retest this please

Test build #127462 has started for PR 29428 at commit 0a6c574.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32083/
Test PASSed.

Test build #127462 has finished for PR 29428 at commit 0a6c574.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127462/
Test PASSed.

cc: @cloud-fan

After merge this I will rase pr about https://github.com/apache/spark/pull/29428,
Since it's UT need based on this pr

@maropu extract entry method as common util method.

Test build #127487 has started for PR 29428 at commit de41b19.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32108/
Test PASSed.

Test build #127487 has finished for PR 29428 at commit de41b19.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127487/
Test PASSed.

cc @cloud-fan

good catch! merging to master

@AngersZhuuuu can you open a new PR for 3.0?

@AngersZhuuuu can you open a new PR for 3.0?

Sure


go get error: go.mod file not found in current directory

What are the instructions for go install ?
$ brew install go

$ go version
go version go1.18.3 darwin/arm64

$ go get github.com/PuerkitoBio/goquery
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

Hello,
This is unrelated to goquery, it is how the go toolchain works - since Go1.16 (https://go.dev/blog/go116-module-changes), go get only works in module mode (see https://go.dev/blog/using-go-modules for details) so you need to run it in a directory that has a go.mod file.


Pub/Sub removeListener/unsubscribe by the topic.

Hello,
I would like to have an option to remove all listeners for a given topic which then unsubscribes the given topic from redis.
PS: probably a hint for removeListener which listenerId to use would be great or a possibility to remove by listener instance.
Thank in advance.

Done


Cannot load package added from github

I have added a package to my local/franklin environment by
add ~/.julia/packages/Franklin/c8x7s/src/eval/run.jl:81

But when I evaluate
```julia:./using.jl
using PlaneGeometry
```

in a markdown file, I got the error that the package is not found. Registered packages installed in local environment do not have this issue.

Problem solved itself after restarting...


Discriminator dominates over generator

I could get audible results at epoch>350, but they don't look good.
Also, d_loss gets too low and g_loss gets too high.

Perhaps this could be caused by:

Discriminator may have learned that real data have discrete values (np.int16): Adding a gaussian noise may help. See https://github.com/soumith/ganhacks/issues/14

I also found that there was a mistake in the average pooling of multiscale.py. Strides of each average pooling layer should be 2, not 2**i.

Currently working on this at fix/3, noisylabel.

Also thinking of G:D=N:1 updates.

The loss curve is unacceptable, but the quality of the generated audio is quite audible when compared to samples at https://melgan-neurips.github.io.
Our samples at 275 epoch: fix3_epoch275.zip

@seungwonpark I have got some audible audio, but g_loss keeps increasing.
tensorboard

@seungwonpark one more input, after 500 epochs I get good audible voice but with similar constant noise artifacts which present in no_patch_gan demo audio in Ablation section here.
patch_gan implementation and importance mentioned in Window-based objective section in research paper. Not sure this is the exact issue as patch_gan implemented by MelGAN but one thing is sure that model facing difficulty to generalize higher frequencies.
You can check  tensorboard

Thank you for sharing your results and insights, @rishikksh20
I'm also working hard on this.

I'm quite convinced that using beta1=0.5, beta2=0.9 for Adam optimizers harms the training of G, making D loss go to near zero.
Using the default value beta1=0.9, beta2=0.99 made things better. Also, Jaehyeon Kim's implementation use default values.
Blue: default / Orange: values from paper

Not sure about this, but I think I found out the point.
Observation: Order of D/G update makes result really different.

Hypothesis: We should use separate dataloader for G and D.
In the original GAN algorithm, random noise is sampled within training loop. However, when the conditional information is used, using identical data for G and D within single loop may harm the training.

@seungwonpark After 500 epochs I remove label noises and this line https://github.com/seungwonpark/melgan/blob/3041dcca2560b6dbc6534be4a6f277bf9779f26f/datasets/dataloader.py#L49 and fine-tune again.
Then what I noticed that the constant noise artifacts goes down slowly and audibility of audio get increase. Maybe we need to give model much more epochs though generator loss keeps increasing but so the quality of audio, like in paper they train more than 3200 epochs and getting good results after 800 epochs. Lets see after how many epochs audio get deteriorated.

@seungwonpark Order of G and D matter lot when we model a complex objective,though the  number of updates corresponding to G:D(like G:D=N:1 updates) play a very crucial role. These two acts as a extra hyper-parameters when we dealing with GANs.

I'm testing both swapping order of G/D, and using separate loader for G/D, but both of them are worser than results from original results at similar epoch.

Maybe we need to give model much more epochs though generator loss keeps increasing but so the quality of audio, like in paper they train more than 3200 epochs and getting good results after 800 epochs.

Can't agree more. Let's wait for them in all cases.
P.S. Thank you so much for testing my code and helping me out, @rishikksh20 . Would you mind if I write your nickname (or your real name) in "Implementation Authors" at README.md to acknowledge you?

When swapping G/D order,
Using default Adam(betas=(0.9, 0.999)) lead to this. I stopped training this.

Using paper's Adam(betas=(0.5, 0.9)) shows better results. I let this to train more.

@seungwonpark Sound quality drastically improve after 1000 epoch, I used original code of noiselabel branch you check here tensorboard . I think training more epoch is the key to check improvement. Though I am also checking GAN-TTS paper by deepmind, the model GASN-TTS is very complex compare to MelGAN but thinks some hyper-parameter might help to improve overall performance and understand GAN more for audio synthesis task.

P.S. Thank you so much for testing my code and helping me out, @rishikksh20 . Would you mind if I write your nickname (or your real name) in "Implementation Authors" at README.md to acknowledge you?

Sure I don't mine my name Rishikesh ( @rishikksh20 )

@seungwonpark @rishikksh20 could you post some audio samples of 1000 epochs? I find not including some L1/L2 loss for the generator at least in the beginning of training makes the generator have to do much more unnecessary "work". If not on the raw audio level at least a spectral loss, etc would probably speed up training.

@G-Wang here are some sample generated at 1200 epochs : https://soundcloud.com/rishikesh-kumar-1/sets/melgan-output-after-12000

@seungwonpark This model easily exports through torch.jit.script just by doing one change here:
https://github.com/seungwonpark/melgan/blob/1e31df8fe2129e45a6b87aef26d4a7bd228b0bba/model/discriminator.py#L44
to
features:List[torch.Tensor] = [] and  add import from typing import List
Check : https://colab.research.google.com/drive/187IHaEvwoh35xviDfpNvxuDzuBpcElyH
Using torch script model speed up training as well as inference by optimizing parameters. And later use to depoy model to IOT devices as well as smartphones.
Meanwhie I start getting good voice quaity after 1500 epochs though a little constant artifacts remains in audio.

Thanks, will consider using torchscript.
I've already merged fixlossavg branch(see #6), but I'm not sure this is correct since it'll make the loss proportional to hp.audio.segment_length. Though I've already posted some audio samples to GitHub pages(using version after #6), this can be changed anytime.
Your results (which was before merge of fixlossavg) looks good to me, too. Let's wait for our models to converge.

@seungwonpark don't require to do this :
https://github.com/seungwonpark/melgan/blob/d6017e8f134b2b8cff53ca66ecee1f76a2131a85/utils/stft.py#L183
As per MelGAN paper, Using spectral normalization or removing the window-based discriminator loss makes it harder to learn sharp high frequency patterns, causing samples to sound significantly noisy.
I think this is the culprit we don't require to do spectral normalization.

TL; DR: That doesn't matter much.
@rishikksh20 Oh, thanks for pointing it out.
That part was copied from NVIDIA/tacotron2, and what it's doing is just normalizing the spectrogram.
https://github.com/seungwonpark/melgan/blob/d6017e8f134b2b8cff53ca66ecee1f76a2131a85/utils/audio_processing.py#L84
The "spectral normalization" that paper mentioned differs from this: https://arxiv.org/abs/1802.05957

Getting good quality audio while generator loss is still going up, too.
(Audio samples at http://swpark.me/melgan/)
@rishikksh20 Even if generator loss is going up, it doesn't seem that discriminator is overly better than generator. How do you think? Shall we close this issue?

@seungwonpark  that's my point and the same thing reflected in my experiment also it's the rate of change of error b/w generative vs discriminative model rather than the actual number. Yeah, close this issue.

The one problem which common in both of us sample is the last click like sound artifact at the end of each sample. Have any idea how to deal with it this kind of artifact not present in the original paper's samples.

@rishikksh20 Thanks.
I also could catch some click like sound artifact in the last. Can you open a new issue for that, please?

This is getting interesting! After about 2000 epochs of training, discriminator finds it almost impossible to discriminate real/fake.


Validate that a location exists before emitting a location during GitHub Discovery

Feature Suggestion
Ensure that when configuring a GitHub org for entity discovery using the GitHub provider, the only locations that are emitted are ones where there actually exists a matching file.
At the moment, entities are emitted for every matching repository, regardless of whether the file they reference exists or not.
Possible Implementation
Use an instance of UrlReader in the GitHubEntityProvider to confirm that the location actually exists before emitting a location for it. I'm not 100% sure of how the plumbing works, but it seems like it should be possible to store the results of these requests in the cache, so that when the UrlReaderProcessor looks up these URLs, it can make use of the cached results, leading to no net increase in requests to GitHub.
Alternatively, it may be possible to adjust the existing GraphQL query to include information about whether the repositories have a matching file directly. It's certainly possible for a static file name, but it's much more complex if the catalogPath field includes a wildcard.
If people think this is a good idea, I'm more than happy to contribute this feature.
Context
At the moment, using GitHub Discovery at any sort of large organisation is largely broken, unless the entire organisation has created the required catalog-info.yaml file (or equivalent). This is because the GitHub discovery provider (and other providers) do not check that a file exists in a repository before emitting a location. The naive configuration of the provider (and in fact, the one suggested in the docs) is:
catalog:
  providers:
    github:
      providerId:
        organization: 'backstage'
        catalogPath: '/catalog-info.yaml'
        filters:
          branch: 'main'
          repository: '.*'

The result of this is that a location is created for every single non-archived repository in the organisation, regardless of whether these repositories contain a catalog-info.yaml file. The outcome is that for large organisations, your API rate limit will be rapidly exhausted because of the constant barrage of 404s from these locations being endlessly refreshed.
I think people's intuition is that the discovery provider will only discover locations that actually exist. I think this intuition should match the implementation.

Hi @Niksko!
Thanks for sharing this in an issue! This is very similar to the problems defined in #13959 and I'm not sure if we should move this discussion over there or keep it here.
In any case I think we should investigate the possibility of doing some additional "processing" to EntityProviders, as they are essentially controlled by the integrator it allows us to potentially do a bit more work prior to adding the Location into the catalog.
To combat this problem I wonder if we could leverage the GitHub search to only add locations that match the file pattern.
This is an example query: https://github.com/search?q=user%3Abackstage+path%3A%2F+filename%3Acatalog-info.yaml&type=code
user:backstage path:/ filename:catalog-info.yaml
I tried it out on the backstage org and it seems like we potentially could add Locations based on the search result.

@jhaals I agree it solves the same issue, but the approach is quite different. Happy to merge this discussion into that one, but I explicitly created this separate issue because the desire in #13959 seemed to be to holistically address the issue of 'rogue' locations which could end up in the catalog for a number of reasons. This issue is more about avoiding them getting into the catalog in the first place.
As far as GitHub search, that's a good idea. I'll have a play around and see if I can put up a PR.

@Niksko - Have a look at my suggestion in issue #13959. I believe this will accomplish your goal without using the search API.
https://github.com/backstage/backstage/issues/13959#issuecomment-1272414423

@Niksko - Have a look at my suggestion in issue #13959. I believe this will accomplish your goal without using the search API.
https://github.com/backstage/backstage/issues/13959#issuecomment-1272414423

This is a great suggestion and does avoid the search API, but what do we do about users who want the wildcard feature that is currently available in the configuration of this provider?
Perhaps I'll just put up a PR with this simple solution to get us part of the way there, and then think further about how to use search. One suggestion I've found to get around the API limitations is that you use date ranges in your search to partition the search space. That said, I'm sure there is some esoteric GitHub org out there that breaks this, but it's a start.

This really needs a better explanation in the docs.


Investigate workspace-level dependencies

Good stuff. I'd like to look into workspace-level dependencies at some point too.

Originally posted by @alice-i-cecile in https://github.com/bevyengine/bevy/issues/12313#issuecomment-1979531886
Workspace-level dependencies allow for consistent dependency versions across multiple crates. They can be handy for keeping popular libraries, such as serde, syn, toml_edit and more in sync and reduce dependency duplication.
They can be specified with:
# Root Cargo.toml
[workspace.dependencies]
serde = "1.0.99999"

And can be used by a crate with:
[dependencies]
serde = { workspace = true }
# or
serde.workspace = true

I want to be clear that I think this is worth investigating, but is not necessarily going to be implemented and approved. It may end up as a giant list of dependencies in an already massive Cargo.toml and lots of bikeshedding about which dependencies deserve this treatment.
But then again, please try it out and let us know how it goes.

Compile fail tests are incompatible with all workspace-inherited configuration, in their current form. That will need to be resolved before this issue can move forward.


Add manual address input component and pattern

Only adding the manual input for now as lookup version is still in prototype stage

 Address Input


Add merge_vars attribute to applyservice

Add merge_vars attribute to applyservice LWRP to support 3.5.7. Use Object Attributes in Apply Rules
Also allows for multiple Service objects to be created from the same set by always using the  icinga2_applyservice resource name in the Service object, rather than only when not using a set e.g.:
http_vhosts_example.com
http_vhost_example.com
Previously, when using the same set with two icinga2_applyservice resources this would only have used the set key as the Service name and created two Service objects named:
example.com
example.com
Please let me know if there is anything else you wish done so this can be merged. Thanks!

@gsreynolds 👍

👍  thanks!


Bump up rk-entry version to v2.2.0

Codecov Report

Merging #73 (35b3a41) into master (f8470e8) will decrease coverage by 0.08%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   86.88%   86.80%   -0.09%
==========================================
  Files          19       19
  Lines        1502     1508       +6
==========================================
+ Hits         1305     1309       +4
- Misses        164      166       +2
  Partials       33       33

Impacted Files
Coverage Δ

boot/proxy_entry.go
62.44% <ø> (ø)

middleware/panic/interceptor.go
81.81% <ø> (ø)

boot/grpc_entry.go
83.42% <60.00%> (-0.23%)
:arrow_down:

boot/error/grpc_error_wrap.go
100.00% <100.00%> (ø)

boot/gw_server_options.go
90.08% <100.00%> (-0.09%)
:arrow_down:

middleware/auth/server_interceptor.go
94.73% <100.00%> (ø)

middleware/csrf/interceptor.go
100.00% <100.00%> (ø)

middleware/jwt/server_interceptor.go
91.42% <100.00%> (+0.51%)
:arrow_up:

middleware/ratelimit/server_interceptor.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8470e8...35b3a41. Read the comment docs.


Failed to load confluence-integration obsidian plugin

Hi, I have an issue with the plugin. Previously it was working fine, but today I just realized it doesn't work anymore.
Plugin Version: 5.5.2
Obsidian Version: v1.5.8
Logs captured from dev tools.

Plugin failure: confluence-integration TypeError: W_e.isDesktopCapturerEnabled is not a function
at eval (VM328 plugin:confluence-integration:44:184470)
at eval (VM328 plugin:confluence-integration:6:265)
at eval (VM328 plugin:confluence-integration:44:184861)
at eval (VM328 plugin:confluence-integration:6:265)
at eval (VM328 plugin:confluence-integration:44:190951)
at eval (VM328 plugin:confluence-integration:6:265)
at eval (VM328 plugin:confluence-integration:44:190998)
at eval (VM328 plugin:confluence-integration:6:265)
at anonymous (VM328 plugin:confluence-integration:1718:226)
at e. (app.js:1:2046123)
(anonymous) @ app.js:1
4app.js:1 Plugin failure: confluence-integration TypeError: W_e.isDesktopCapturerEnabled is not a function
at eval (VM307 plugin:confluence-integration:44:184470)
at eval (VM307 plugin:confluence-integration:6:265)
at eval (VM307 plugin:confluence-integration:44:184861)
at eval (VM307 plugin:confluence-integration:6:265)
at eval (VM307 plugin:confluence-integration:44:190951)
at eval (VM307 plugin:confluence-integration:6:265)
at eval (VM307 plugin:confluence-integration:44:190998)
at eval (VM307 plugin:confluence-integration:6:265)
at anonymous (VM307 plugin:confluence-integration:1718:226)
at e. (app.js:1:2046123)

Hello, have the same problem. I try to install and use this plugin, but can't start.

I installed Obsidian using flatpak, downgraded to previous release fixed the issue for now.
flatpak update --commit=26c9563c28b3250935a00151e4efcb6b4a8488a6b1066b111cf943d882effca7 md.obsidian.Obsidian
flatpak mask md.obsidian.Obsidian # Freeze auto update

I installed Obsidian using flatpak, downgraded to previous release fixed the issue for now.
flatpak update --commit=26c9563c28b3250935a00151e4efcb6b4a8488a6b1066b111cf943d882effca7 md.obsidian.Obsidian
flatpak mask md.obsidian.Obsidian # Freeze auto update

Thank you, i downgraded version from 1.5.8-2 to 1.5.8-1 at archlinux and plugin works now.

I'm in the same boat. I found this plugin today and was hoping to use it to streamline documentation processes. I will not be downgrading Obsidian, hoping this plugin is fixed soon!

I am having the same issue on MacOS. Obsidian installed through Homebrew, but no other issues, so I do not believe this is imortant to the issue.
This is the error I keep getting. Looks like it is missing a CSS file, which I assume is where the missing function below that is located.
app.js:1 Confluence Integration: styles.css not found
app.js:1 Plugin failure: confluence-integration TypeError: W_e.isDesktopCapturerEnabled is not a function
    at eval (plugin:confluence-integration:44:184470)
    at eval (plugin:confluence-integration:6:265)
    at eval (plugin:confluence-integration:44:184861)
    at eval (plugin:confluence-integration:6:265)
    at eval (plugin:confluence-integration:44:190951)
    at eval (plugin:confluence-integration:6:265)
    at eval (plugin:confluence-integration:44:190998)
    at eval (plugin:confluence-integration:6:265)
    at anonymous (plugin:confluence-integration:1718:226)
    at e.<anonymous> (app.js:1:2046123)
    at app.js:1:237544
    at Object.next (app.js:1:237649)
    at a (app.js:1:236367)
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
s @ app.js:1
Promise.then (async)
l @ app.js:1
(anonymous) @ app.js:1
v @ app.js:1
e.enablePlugin @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
v @ app.js:1
e.enablePluginAndSave @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
v @ app.js:1
(anonymous) @ app.js:1

I am also having this issue on Android, version 1.5.8(126).  Also the previous version I had installed couldn't enable the plugin, 1.4.something (unfortunately it updated before I could grab the whole version number).

Fixed my locally for now by editing the plugin's main.js file.
Remove the W_e.isDesktopCapturerEnabled() function call, and it will work with the latest version of Obsidian.  This is quick and dirty (sorry, but didn't have time to find this in source and create a proper PR, but wanted to at least share a quick fix for folks here that are in a pinch and don't want to downgrade Obsidian).

I am having the same issue under Windows with v1.5.11. The plugin installs. However, I could not enable it. I used the suggestion that @justin-parker suggested and now I can enable the plugin.

The problem is the dependency "@electron/remote": "^2.0.9", in packages/mermaid-electron-renderer/package.json
I have changed it to  "@electron/remote": "^2.1.2", and built the package again and it works, could create a pull request. But I don't see any activity in the repo, so I'm not sure if one will merge it

The problem is the dependency "@electron/remote": "^2.0.9", in packages/mermaid-electron-renderer/package.json
I have changed it to "@electron/remote": "^2.1.2", and built the package again and it works, could create a pull request. But I don't see any activity in the repo, so I'm not sure if one will merge it

Hi @gergan can you tell more? I'm running in the same trouble, I don't find the file you're talking about.
EDIT: @justin-parker's solution worked fine. Thanks! I wonder how did you find about it though.

Sorry I had too much on my head - but here ist the patch, which fixes it for me
markdown-confluence-9ba7b11-fix.patch

I used @justin-parker workaround of removing the ||W_e.isDesktopCapturerEnabled() in main.js of the plugin.
@gergan where do you apply the patch? on the Obsidian source?
Thanks for finding a workaround!

@StefanD986 you can find the main.js in <your obsidian notes directory>/.obsidian/plugins/confluence-integration/

@justin-parker - Nice, dude!
I am growing increasing concerned that this simple, effective plugin has been abandoned; and it's only one of two publishing plugins.... and really, only one of one, as the other does not really compare.

@andymac4182 is the fellow behind this awesome plugin.  I know a couple people pinged him on DIscord.  He might just be on vacation at the moment.  I'd give him the benefit of the doubt - I know he put a lot of work into creating it last year.

@andymac4182 is the fellow behind this awesome plugin. I know a couple people pinged him on DIscord. He might just be on vacation at the moment. I'd give him the benefit of the doubt - I know he put a lot of work into creating it last year.

Nine months (since the last commit) of vacation?! Baller. At any rate, the plug-in is in maintenance mode right now, but I share the sentiment with the others: we find it super helpful. If everyone was willing to incentivize the code maintainer through sponsorship, that might sweeten the pot; it isn't all altruistic. IMO, their time is a precious commodity we should cherish.

I forked the repository, updated dependencies, and built the plugin to a working state for my own use.  I have published a patched release here, for those who might be looking for a short term solution: https://github.com/jvsteiner/markdown-confluence/releases/tag/v5.5.2_1

The problem is the dependency "@electron/remote": "^2.0.9", in packages/mermaid-electron-renderer/package.json
I have changed it to "@electron/remote": "^2.1.2", and built the package again and it works, could create a pull request. But I don't see any activity in the repo, so I'm not sure if one will merge it

Hi @gergan can you tell more? I'm running in the same trouble, I don't find the file you're talking about.
EDIT: @justin-parker's solution worked fine. Thanks! I wonder how did you find about it though.

Sorry I had too much on my head - but here ist the patch, which fixes it for me markdown-confluence-9ba7b11-fix.patch

Hi, How to use your patch exactly?

on the releases page, you download main.js and replace the main.js file in the .obsidian/plugins/confluence-integration folder

@jvsteiner What’s the best practice in this case? I reached out to the plugin but he doesn’t really have time to work on this.
So a partially non-working plugin remains in the community plugins, while your fix is working.
Can’t your version replace the original one (with due mention of course).


Add phpcs

Coverage decreased (-1.3%) to 73.488% when pulling 73f9c57422a48ea555cbdcbd04cddb6711271197 on addPhpcs into d75acfc72c0aea2f132b333913217cdcad9a8091 on master.