ospModelViewer + dragon.xml = no pixels

Look like data is loading correctly, but nothing being drawn. No CPU activity at all.
This was pulled/built from sources today.
(tao:~/local/ospray-data/dragon) > /u/wk/tsandstr/local/ospray/build/ospModelViewer dragon.xml
#ospModelViewer: starting to process cmdline arguments
#ospModelViewer: done parsing. found model with

num meshes   : 1 [922849]
num instances: 1 [922849]
num unique triangles   : 922849
num instanced triangles: 922849
#ospModelViewer: number of instances matches number of meshes, creating single model that contains all meshes
#ospModelViewer: adding parsed geometries to ospray model
#ospModelViewer: committing model
#osp/trimesh: Verifying index buffer ...
#osp/trimesh: Verifying vertex buffer ...
#ospModelViewer: done creating ospray model.
#ospModelViewer: Adding a hard coded directional light as the sun.
#ospModelViewer: done creating window. Press 'Q' to quit.
#ospModelViewer: set world bounds [(-6.83587, -0.431891, -6.93969); (7.11329, 7.60655, 5.10773)], motion speed 0.0201081

Hey, Tim,
Can you tell us what branch (or git hash) you have been using?
Also, please run with "--osp:debug", and let us know the output, as well
as what architecture you have been using.
I just updated to current sources (in devel tree), and rebuilt, and it
works fine on my side ... and the output it makes are actually exactly
the right ones, so I'm a bit confused ... !?
Ingo
On 5/18/15 3:33 PM, timsandstrom wrote:

Look like data is loading correctly, but nothing being drawn. No CPU
activity at all.
This was pulled/built from sources today.
(tao:~/local/ospray-data/dragon) >
/u/wk/tsandstr/local/ospray/build/ospModelViewer dragon.xml
#ospModelViewer: starting to process cmdline arguments
#ospModelViewer: done parsing. found model with

num meshes : 1 [922849]
num instances: 1 [922849]
num unique triangles : 922849
num instanced triangles: 922849 #ospModelViewer: number of
instances matches number of meshes, creating single model that
contains all meshes #ospModelViewer: adding parsed geometries to
ospray model #ospModelViewer: committing model #osp/trimesh:
Verifying index buffer ... #osp/trimesh: Verifying vertex buffer
... #ospModelViewer: done creating ospray model. #ospModelViewer:
Adding a hard coded directional light as the sun. #ospModelViewer:
done creating window. Press 'Q' to quit. #ospModelViewer: set
world bounds [(-6.83587, -0.431891, -6.93969); (7.11329, 7.60655,
5.10773)], motion speed 0.0201081

—
Reply to this email directly or view it on GitHub
https://github.com/ospray/OSPRay/issues/17.

Arg, new to git, not sure how to get that info.
Lemme try... well, doesn't look like v0.8.1 does it.
If yours work then it's probably user-error on my part.
(tao:~/local/ospray) > git rev-parse --verify HEAD
8723ce62037b5853a28613f16f71041ed769114c
(tao:~/local/ospray) > git log -n 1
commit 8723ce62037b5853a28613f16f71041ed769114c
Merge: e7cb749 f639788
Author: Gregory P. Johnson<EMAIL_ADDRESS>Date:   Fri May 8 11:56:13 2015 -0500
 Merge branch 'release-0.8'

ospModelViewer --osp:debug dragon.xml

Embree Ray Tracing Kernels 2.3.3 (May 18 2015)
Compiler : GCC 4.9.2
Platform : Linux (64bit)
CPU      : SSE SSE2 SSE3 SSSE3 SSE41 SSE42 POPCNT AVX F16C RDRAND
Features : intersection_filter bufferstride
general:
build threads = 1
verbosity     = 2
triangles:
accel         = default
builder       = default
traverser     = default
replications  = 2
motion blur triangles:
accel         = default
builder       = default
traverser     = default
hair:
accel         = default
builder       = default
traverser     = default
replications  = 3
subdivision surfaces:
accel         = default
#ospModelViewer: starting to process cmdline arguments
#ospModelViewer: done parsing. found model with

num meshes   : 1 [922849]
num instances: 1 [922849]
num unique triangles   : 922849
num instanced triangles: 922849
#ospModelViewer: number of instances matches number of meshes, creating single model that contains all meshes
#ospModelViewer: adding parsed geometries to ospray model
#ospModelViewer: committing model
#osp/trimesh: Verifying index buffer ...
#osp/trimesh: Verifying vertex buffer ...
building BVH4 with sse2::BVH4Builder() ... [DONE]
dt = 7068.84ms, perf = 0.130552 Mprim/s
primitives = 922849, vertices = 0, hash=<PHONE_NUMBER>3198374
sah = 1.0000, depth = 18
used = 68.3 MB, perPrimitive = 74.0 B
alignedNodes = 79799 (89.0% filled) (10.2 MB) (15.0% of total)
leaves = 204397 (58.1 MB) (85.0% of total)
vertices = 0 (0.0 MB) (0.0% of total) (75.0% used)
created scene intersector
accels[0]
intersector1  = sse41::BVH4Triangle4Intersector1Moeller
intersector4  = sse42::BVH4Triangle4Intersector4HybridMoellerNoFilter
selected scene intersector
intersector1  = sse41::BVH4Triangle4Intersector1Moeller
intersector4  = sse42::BVH4Triangle4Intersector4HybridMoellerNoFilter
#ospModelViewer: done creating ospray model.
#ospModelViewer: Adding a hard coded directional light as the sun.
#ospModelViewer: done creating window. Press 'Q' to quit.
#ospModelViewer: set world bounds [(-6.83587, -0.431891, -6.93969); (7.11329, 7.60655, 5.10773)], motion speed 0.0201081
Embree: Invalid operation, (rtcIntersect8 not supported)
Embree: Invalid operation, (rtcIntersect8 not supported)
...

On 05/18/2015 06:25 PM, Ingo Wald wrote:

Hey, Tim,
Can you tell us what branch (or git hash) you have been using?
Also, please run with "--osp:debug", and let us know the output, as well
as what architecture you have been using.
I just updated to current sources (in devel tree), and rebuilt, and it
works fine on my side ... and the output it makes are actually exactly
the right ones, so I'm a bit confused ... !?
Ingo
On 5/18/15 3:33 PM, timsandstrom wrote:

Look like data is loading correctly, but nothing being drawn. No CPU
activity at all.
This was pulled/built from sources today.
(tao:~/local/ospray-data/dragon) >
/u/wk/tsandstr/local/ospray/build/ospModelViewer dragon.xml
#ospModelViewer: starting to process cmdline arguments
#ospModelViewer: done parsing. found model with

num meshes : 1 [922849]
num instances: 1 [922849]
num unique triangles : 922849
num instanced triangles: 922849 #ospModelViewer: number of
instances matches number of meshes, creating single model that
contains all meshes #ospModelViewer: adding parsed geometries to
ospray model #ospModelViewer: committing model #osp/trimesh:
Verifying index buffer ... #osp/trimesh: Verifying vertex buffer
... #ospModelViewer: done creating ospray model. #ospModelViewer:
Adding a hard coded directional light as the sun. #ospModelViewer:
done creating window. Press 'Q' to quit. #ospModelViewer: set
world bounds [(-6.83587, -0.431891, -6.93969); (7.11329, 7.60655,
5.10773)], motion speed 0.0201081

—
Reply to this email directly or view it on GitHub
https://github.com/ospray/OSPRay/issues/17.

—
Reply to this email directly or view it on GitHub https://github.com/ospray/OSPRay/issues/17#issuecomment-103292779.

upon further inspection, my ispc is out of date [and llvm as well...] rebuilding... apologies :(

Ah; old ISPC version might explain it - the current version uses
multi-ISA build that may not be fully supported by an older ISPC. (We do
actually check the ISPC version when you first run cmake to check for
that case; but that check doesn't work if you update in an existing
repo, which is what I suppose happened).
Please update your ISPC, and ideally remove your build directory and
re-ccmake from scratch in a new build directory (just to be sure).
Let us know if that fixes it; until verified that it works I'll leave
this open.
Cheers,
Ingo
On 5/18/15 8:52 PM, timsandstrom wrote:

Arg, new to git, not sure how to get that info.
Lemme try... well, doesn't look like v0.8.1 does it.
If yours work then it's probably user-error on my part.
(tao:~/local/ospray) > git rev-parse --verify HEAD
8723ce62037b5853a28613f16f71041ed769114c
(tao:~/local/ospray) > git log -n 1
commit 8723ce62037b5853a28613f16f71041ed769114c
Merge: e7cb749 f639788
Author: Gregory P. Johnson<EMAIL_ADDRESS>Date: Fri May 8 11:56:13 2015 -0500
Merge branch 'release-0.8'

ospModelViewer --osp:debug dragon.xml

Embree Ray Tracing Kernels 2.3.3 (May 18 2015)
Compiler : GCC 4.9.2
Platform : Linux (64bit)
CPU : SSE SSE2 SSE3 SSSE3 SSE41 SSE42 POPCNT AVX F16C RDRAND
Features : intersection_filter bufferstride
general:
build threads = 1
verbosity = 2
triangles:
accel = default
builder = default
traverser = default
replications = 2
motion blur triangles:
accel = default
builder = default
traverser = default
hair:
accel = default
builder = default
traverser = default
replications = 3
subdivision surfaces:
accel = default
#ospModelViewer: starting to process cmdline arguments
#ospModelViewer: done parsing. found model with

num meshes : 1 [922849]
num instances: 1 [922849]
num unique triangles : 922849
num instanced triangles: 922849
#ospModelViewer: number of instances matches number of meshes,
creating single model that contains all meshes
#ospModelViewer: adding parsed geometries to ospray model
#ospModelViewer: committing model
#osp/trimesh: Verifying index buffer ...
#osp/trimesh: Verifying vertex buffer ...
building BVH4 with sse2::BVH4Builder() ... [DONE]
dt = 7068.84ms, perf = 0.130552 Mprim/s
primitives = 922849, vertices = 0, hash=<PHONE_NUMBER>3198374
sah = 1.0000, depth = 18
used = 68.3 MB, perPrimitive = 74.0 B
alignedNodes = 79799 (89.0% filled) (10.2 MB) (15.0% of total)
leaves = 204397 (58.1 MB) (85.0% of total)
vertices = 0 (0.0 MB) (0.0% of total) (75.0% used)
created scene intersector
accels[0]
intersector1 = sse41::BVH4Triangle4Intersector1Moeller
intersector4 = sse42::BVH4Triangle4Intersector4HybridMoellerNoFilter
selected scene intersector
intersector1 = sse41::BVH4Triangle4Intersector1Moeller
intersector4 = sse42::BVH4Triangle4Intersector4HybridMoellerNoFilter
#ospModelViewer: done creating ospray model.
#ospModelViewer: Adding a hard coded directional light as the sun.
#ospModelViewer: done creating window. Press 'Q' to quit.
#ospModelViewer: set world bounds [(-6.83587, -0.431891, -6.93969);
(7.11329, 7.60655, 5.10773)], motion speed 0.0201081
Embree: Invalid operation, (rtcIntersect8 not supported)
Embree: Invalid operation, (rtcIntersect8 not supported)
...

On 05/18/2015 06:25 PM, Ingo Wald wrote:

Hey, Tim,
Can you tell us what branch (or git hash) you have been using?
Also, please run with "--osp:debug", and let us know the output, as well
as what architecture you have been using.
I just updated to current sources (in devel tree), and rebuilt, and it
works fine on my side ... and the output it makes are actually exactly
the right ones, so I'm a bit confused ... !?
Ingo
On 5/18/15 3:33 PM, timsandstrom wrote:

Look like data is loading correctly, but nothing being drawn. No CPU
activity at all.
This was pulled/built from sources today.
(tao:~/local/ospray-data/dragon) >
/u/wk/tsandstr/local/ospray/build/ospModelViewer dragon.xml
#ospModelViewer: starting to process cmdline arguments
#ospModelViewer: done parsing. found model with

num meshes : 1 [922849]
num instances: 1 [922849]
num unique triangles : 922849
num instanced triangles: 922849 #ospModelViewer: number of
instances matches number of meshes, creating single model that
contains all meshes #ospModelViewer: adding parsed geometries to
ospray model #ospModelViewer: committing model #osp/trimesh:
Verifying index buffer ... #osp/trimesh: Verifying vertex buffer
... #ospModelViewer: done creating ospray model. #ospModelViewer:
Adding a hard coded directional light as the sun. #ospModelViewer:
done creating window. Press 'Q' to quit. #ospModelViewer: set
world bounds [(-6.83587, -0.431891, -6.93969); (7.11329, 7.60655,
5.10773)], motion speed 0.0201081

—
Reply to this email directly or view it on GitHub
https://github.com/ospray/OSPRay/issues/17.

—
Reply to this email directly or view it on GitHub
https://github.com/ospray/OSPRay/issues/17#issuecomment-103292779.

—
Reply to this email directly or view it on GitHub
https://github.com/ospray/OSPRay/issues/17#issuecomment-103297456.

OK, further updates...
so, cmake/gcc.make was not parsing the gcc --version output correctly
thus setting OSPRAY_COMPILER_SUPPORTS_AVX and OSPRAY_COMPILER_SUPPORTS_AVX2 to FALSE.
fixing that though, resulted in a compiler fail:
cd /u/wk/tsandstr/local/ospray/release/builddir/ospray/intel64 && g++   -DEMBREE_DISABLE_HAIR=1 -D__BUFFER_STRIDE__ -D__EXPORT_ALL_SYMBOLS__ -D__FIX_RAYS__ -D__INTERSECTION_FILTER__ -D__TARGET_AVX2__ -D__TARGET_AVX__ -D__TARGET_SSE41__ -D__TARGET_SSE42__ -fPIC -fno-strict-aliasing -DDEBUG  -g     -Wstrict-aliasing=1 -I/u/wk/tsandstr/local/ospray/release -I/u/wk/tsandstr/local/glut-3.7/include -I/u/wk/tsandstr/local/ospray -I/u/wk/tsandstr/local/ospray/release/builddir/ospray/intel64 -I/u/wk/tsandstr/local/ospray/ospray/embree -I/u/wk/tsandstr/local/ospray/ospray/embree/include -I/u/wk/tsandstr/local/ospray/ospray/embree/common -I/u/wk/tsandstr/local/ospray/ospray/embree/kernels -I/u/wk/tsandstr/local/ospray/ospray/embree/kernels/xeon    -mf16c -mavx2 -mfma -mlzcnt -mbmi -mbmi2 -o CMakeFiles/ospray_embree_avx2.dir/embree/kernels/xeon/geometry/instance_intersector8.cpp.o -c /u/wk/tsandstr/local/ospray/ospray/embree/kernels/xeon/geometry/instance_intersector8.cpp
/tmp/ccLi6Kxi.s: Assembler messages:
/tmp/ccLi6Kxi.s:3365: Error: suffix or operands invalid for `vpcmpeqd'
manually setting OSPRAY_COMPILER_SUPPORTS_AVX2 to FALSE in cmake/gcc.make
results in a successful compile and rendering...
So, thanks so much for your attention and help,
-Tim

CPU: Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz
OS: Linux version 2.6.32-504.16.2.el6.x86_64<EMAIL_ADDRESS>(gcc version 4.4.7 20120313 (Red Hat 4.4.7-9) (GCC) ) #1 SMP Tue Mar 10 17:01:00 EDT 2015
gcc: 4.9.2
ispc:Intel(r) SPMD Program Compiler (ispc), 1.8.2dev (build commit ebe165dff87213ce @ 20150519, LLVM 3.5)
(tao:~/local) > ./bin/llvm-as -version
LLVM (http://llvm.org/):
LLVM version 3.5.1
Optimized build with assertions.
Built May 18 2015 (21:49:13).
Default target: x86_64-unknown-linux-gnu
Host CPU: core-avx-i

The new release of OSPRay (and the master branch) now correctly detects the version of GCC.


LinkedIn website changed and scrapedin can't read basic data.

I want to get cv from "about section", so I change the template but I have this error LinkedIn website changed and scrapedin can't read basic data.

@khaledhesham2017 you broke the template. If any data is collected from the template it'll throw that message. Please post here your template.

yes, I need to edit the template to get cv from about section. how can make it?

@khaledhesham2017 please post here your template, so I can help tell you what's wrong.

aboutAlternative: {
selector: '.pv-about-section',
fields: {
text: 'p'
cv:'div'
}
}

@khaledhesham2017 print the rawProfile as console.log(JSON.stringify(rawProfile, undefined, 2)) before the line #76 on profile.js and post the full raw profile here.
aboutAlternative is only being used if there's no data on about, see here

Closed due to lack of feedback


Need solution for when card number (randomly) switches and breaks arecord command

A device name is needed for arecord to record audio. The device name is made up of a card number and device number in the format: plughw:cardnumber,devicenumber (find these with arecord -l).
The USB mic I have been using is identified with plughw:1,0.
However, on a couple of occasions, it wasn’t recording audio, and this was because (for a yet unknown reason) the device name changed to either plughw:2,0 or plughw:5,0.
These resources look useful:
•	https://forums.raspberrypi.com/viewtopic.php?t=244810
•	https://stackoverflow.com/questions/43361613/how-can-i-identify-multiple-usb-sound-cards

I tried quite a few things that didn't work including the resources above - said permission denied even when using sudo.
Eventually, found and followed this resource: https://alsa.opensrc.org/Udev#Identify_two_identical_audio_devices - specifically this section: Writing udev rules - Identify two identical audio devices. Basically change the way the mic is identified - use name which never changes, rather than card number which can.
I just followed it but only did it for one device (whereas they do it for 2).

Used cat /proc/asound/cards to show device name before - the dodo mic was r0.
Then skipped down to bit in guide where it says to "Create a file like "/etc/udev/rules.d/85-my-usb-audio.rules" " which I did. I used sudo nano /etc/udev/rules.d/85-my-usb-audio.rules to create and write in it. Copied the website's template.

I called the mic "dodoMic".
The device path came from running: ls -la /sys/class/sound - it was the card 1 one, with 'usb' in the path

Then unplugged the mic and plugged it back in.
Then re-ran cat /proc/asound/cards, which showed the updated device name is dodoMic.
Ran the birdRecording.py script with both plughw:1,0 and plughw:dodoMic,0 and both worked.

Did re-boot - changes remain and birdRecording.py still working with the new way of identifying the mic.
N.B. Not sure if will have to do this for every AMI set-up as the mic device path will likely be different??


Introduce Hybrid vector clock

What this PR does / why we need it:
Which issue(s) this PR fixes:

Address #723
Special notes for your reviewer:
https://hackmd.io/kfaV_ZAgSX-REVyKRnoU1Q?view\
Does this PR introduce a user-facing change?:

Additional documentation:

Checklist:

[ ] Added relevant tests or not required
[ ] Didn't break anything

Related to https://github.com/yorkie-team/yorkie/issues/789

This continues at #800.

About Min and LCA:
https://codepair.yorkie.dev/highcloud100/66bd684f28737f961bccd807/share?token=pgt8es


login –> username

As discussed on #31

Superb!

@pietbrauer: I think we're ready for a major release now?

I'm all for it. Can you prepare a change log?

Sure thing!

@pietbrauer: Done, change log is in the release draft.

Cool, thanks a lot for helping! I just published 0.5.0 following your draft

My pleasure! 👍


add details about clawback to XLS-33

Title says it all. LMK if you prefer I batch changes and keep a draft PR open instead.

Whatever makes sense. If there's a lot at the same time, I think batch changes are preferable :)


chore(build): fix the case when there is no key in the map

When there is no key in the map, the command was failing with
scripts/fetch_sources.sh: linia 61: patches_per_version["v${major}.${minor}"]:  unbound variable

added check which applies only to patches when they are defined

So we want to add an empty entry on each new version? As you can check currently build fails and we cannot check if a main branch build succesfully

So, we want to add an empty entry for each new version that doesn't require patches?

Yeah. the idea was to avoid not thinking about which patches need to be applied


enable_dns_server and ha_subnet arguments not supported in mc-transit

Hello,
The customer (Yara) is using our Aviatrix resources in Terraform.
The customer would like to "migrate" from resources to mc-modules.
We have been working currently on the mc-transit module and we faced an issue with the following two arguments:
**- enabled_vpc_dns_server

ha_subnet**
We are not able to set up values for those two arguments.

Therefore, TF Plan shows they will be changed.
I would like to ask you to adjust the mc-transit module and accommodate those two arguments.

enable_vpc_dns_server added in 2.4.1

ha_subnet no longer seems required.


ui-sortable + ng-repeat selects text, requires extra click, with jQuery 2.0

The code below is a ui-sortable list that uses ng-repeat, using jQuery 2.0.
The first attempt to drag and drop an item in the list will result in selecting text in the list, instead of moving the element. The second attempt works as expected, as do all attempts after that. When the page is refreshed, we're in a broken state again.
With jQuery 1.x, everything is fine.
If the ng-repeat is removed from the situation, and a static list is used instead, everything is fine.
Hard to say if this is an issue with jQuery, Angular, or Angular-ui, but the narrowed-down code below is a step toward answering that question.
    <!doctype html>

          {{t.name}}

I was having this exact issue with jQuery 2.0.0 but upgrading to jQuery 2.1.3 solved it. Thanks!


Aws In-tree support

Fixes #9110
Fixes #9204
Create an AWS cluster and select the AWS Cloud Provider.
Edit the cluster and change the k8s version to 1.27 - we now change the provider to 'External' and show a banner. If you change back to 1.26, we revert to the AWS Cloud provider.
Note: Added some test code (commented out) that can be un-commented to add a fake 1.27 version for dev/testing.

Thanks @mantis-toboggan-md  - I recall we said we'd add link to the docs in the banner, but I don't have that and will need to chase with @gaktive - we can add that in another PR.


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-network-trafficmanagerprofile
Module Details
Terraform equivalent of Bicep Module
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

I would like to take the ownership of this module. I understand the requirement of the module.

Hi Amjad ,
Yes , I am a Microsoft FTE. This is my alias : @.***
Regards,
Anubha
Thanks & Regards,

Anubha Rana                                                                                Azure Cloud & AI
Email<EMAIL_ADDRESS>                                                                                [product_logo]

From: Bilal Amjad @.>
Sent: Thursday, February 22, 2024 9:55 PM
To: Azure/Azure-Verified-Modules @.>
Cc: Anubha Rana @.>; Mention @.>
Subject: Re: [Azure/Azure-Verified-Modules] [Module Proposal]: avm-res-network-trafficmanagerprofile (Issue #659)
Hi @AnubhaR94https://github.com/AnubhaR94 thank you for your interest, could you please confirm if you are a Microsoft FTE as the AVM Spec requires an owner to be a FTE. If not than I can find one and pair him/her up with you to contribute to this module
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/Azure-Verified-Modules/issues/659#issuecomment-1959806363, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP3BCBWHGI2GGW746SXESWDYU5WOJAVCNFSM6AAAAABDI34456VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZHAYDMMZWGM.
You are receiving this because you were mentioned.

Hi @AnubhaR94,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

@.*** would like to recall the message, "Re: [Azure/Azure-Verified-Modules] [Module Proposal]: avm-res-network-trafficmanagerprofile (Issue #659)".

@AnubhaR94 if you still want to own this module, please confirm.

@pedrocsousa @pagyP pls check would you like to work on this?

I would like to own this module.

@prjelesi yes, I would like to work on this

Thanks, let me sync with @AnubhaR94 . will get to you soon.

@AnubhaR94 following our conversation today, can you please confirm that you would like to be module owner?

Yes , I would like to own the module.

Hi @AnubhaR94
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

@AnubhaR94 is planning to work on this one on the hackathon week- w/c 16 Sep

Repository created, testing the code.


[Google Translate] ...

Extension
https://www.raycast.com/gebeto/translate
Description
translate is not working
Steps To Reproduce
try to translate something... nothing happens
Current Behaviour
No response
Expected Behaviour
No response

Can you please share some more details?

Are you using VPN?
In which country are you located?
Is Google Translate works from your browser?


Twitter card doesn't include image

https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/abouts-cards
Example Tweet: https://twitter.com/LeGuud/status/1683674916833607680

This was fixed, but we are just displaying a single title/description/photo for all pages. We could improve upon this considerably.


chore: improve commit messages

After merging this PR, all future PR descriptions should be written in this style:
Which Problems Are Solved

The git merge commit history is not easily readable
The single PR commits don't help much in understanding the purpose of a merge commit.
Often, it requires implicit knowledge to be able to understand what a merge commit is about.

How the Problems Are Solved

Ensures that PR descriptions are concise
Enables configuring GitHub to use the PR descriptions for merge commit messages instead of the PRs single commits
The ready for review checks are removed from the PR description and instead automatically listed in a PR comment. This comment was created by the action: https://github.com/zitadel/zitadel/pull/7922#issuecomment-2097792384

Additional Changes

The acceptance criteria are more concise

Additional Context

Closes #6693

@muhlemmer I decided to not define the expectations in the CONTRIBUTING.md but directly in the PR comment and template description. They are easier accessible when it's already in the right context.

red by github? Git commits

Looks like GitHub doesn't render markdown in commit messages https://github.com/zitadel/zitadel/commit/eb551edef3e0ed6f067e209ea4691efafa2a1290
Do you think this is a problem? I'd leave the formatting in favor of nice PR descriptions. The commit history is IMO still easily readable with unrendered markdown.


[ENHANCEMENT] Multiple enhancements

[x]  Sticked messages that automatically repost every message so it always is at the bottom

[ ] Like and dislike reaction buttons for every message in certain channels 👍🏻👎🏻

Thank you for your great ideas! I will be looking into thoose once I have done the features I currently work on 👀

I have completed the sticky feature for now (some small adjustments might be made). Here is a quick preview:

Looks perfect!

I just added an 0.5s delay in case you write faster than Kayano writes to the database.

Sticky messages are now added and pushed to stable. The reaction channel feature however is still a thing we will work on!


cleanup: reduce nested level

Signed-off-by: jerryzhuang<EMAIL_ADDRESS>
What type of PR is this?
cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:

Special notes for your reviewer:

@kitianFresh Please take a look.

Thanks for contributing @zhuangqh

/LGTM


WHERE CAN I CHANGE THE HEART CONTAINER LOCATION

Sorry for the late response. What version of customhud are you using? Currently, versions posted to modrinth/curseforge can't remove or move vanilla hud elements.
If you're using the v4 betas from the discord, you can remove it, but not directly move it. (It can be added back via other customhud things)


Sync topology upon connection

As soon as we make a PUB/SUB connection, we should get the current topology, to ensure the flipper_client is up-to-date.
If for any reason we loose connectivity (such as a detectable TCP failure), this ensures any missed switch_master events can be mitigated.
This works by

firing a ConnectionEvent upon confirmation of SUBSCRIBE +switch-master
The Manger will then fetch the current topology
Inject MasterSwitchedEvent into the unthrottled connectionChannel

This means we can also remove the startup intiliseTopology(), as we know that same kind of event will take place upon any sentinel connection now.

vagrant@vagrant-ubuntu-trusty-64:~/go/src/github.com/mdevilliers/redishappy$ ./build/ci.sh
?   	github.com/mdevilliers/redishappy	[no test files]
?   	github.com/mdevilliers/redishappy/api	[no test files]
ok  	github.com/mdevilliers/redishappy/configuration	0.010s
?   	github.com/mdevilliers/redishappy/main/noop	[no test files]
?   	github.com/mdevilliers/redishappy/main/redis-consul	[no test files]
# github.com/mdevilliers/redishappy/sentinel
sentinel/monitor_test.go:27: not enough arguments in call to dealWithSentinelMessage
sentinel/monitor_test.go:39: not enough arguments in call to dealWithSentinelMessage
sentinel/monitor_test.go:57: not enough arguments in call to dealWithSentinelMessage
?   	github.com/mdevilliers/redishappy/main/redis-haproxy	[no test files]
FAIL	github.com/mdevilliers/redishappy/sentinel [build failed]
?   	github.com/mdevilliers/redishappy/services/haproxy	[no test files]
?   	github.com/mdevilliers/redishappy/services/logger	[no test files]
?   	github.com/mdevilliers/redishappy/services/redis	[no test files]
ok  	github.com/mdevilliers/redishappy/services/template	0.009s
ok  	github.com/mdevilliers/redishappy/types	0.010s
ok  	github.com/mdevilliers/redishappy/util	0.011s
godep: go exit status 2

vagrant@vagrant-ubuntu-trusty-64:~/go/src/github.com/mdevilliers/redishappy$ ./build/ci.sh
?   	github.com/mdevilliers/redishappy	[no test files]
?   	github.com/mdevilliers/redishappy/api	[no test files]
ok  	github.com/mdevilliers/redishappy/configuration	0.017s
?   	github.com/mdevilliers/redishappy/main/noop	[no test files]
?   	github.com/mdevilliers/redishappy/main/redis-consul	[no test files]
?   	github.com/mdevilliers/redishappy/main/redis-haproxy	[no test files]
ok  	github.com/mdevilliers/redishappy/sentinel	0.020s
?   	github.com/mdevilliers/redishappy/services/haproxy	[no test files]
?   	github.com/mdevilliers/redishappy/services/logger	[no test files]
?   	github.com/mdevilliers/redishappy/services/redis	[no test files]
ok  	github.com/mdevilliers/redishappy/services/template	0.012s
ok  	github.com/mdevilliers/redishappy/types	0.010s
ok  	github.com/mdevilliers/redishappy/util	0.011s
?   	github.com/mdevilliers/redishappy	[no test files]
?   	github.com/mdevilliers/redishappy/api	[no test files]
ok  	github.com/mdevilliers/redishappy/configuration	0.005s	coverage: 94.7% of statements
ok  	github.com/mdevilliers/redishappy/services/template	0.003s	coverage: 85.7% of statements
?   	github.com/mdevilliers/redishappy/services/logger	[no test files]
?   	github.com/mdevilliers/redishappy/services/redis	[no test files]
?   	github.com/mdevilliers/redishappy/services/haproxy	[no test files]
?   	github.com/mdevilliers/redishappy/main/redis-haproxy	[no test files]
?   	github.com/mdevilliers/redishappy/main/redis-consul	[no test files]
?   	github.com/mdevilliers/redishappy/main/noop	[no test files]
ok  	github.com/mdevilliers/redishappy/util	0.010s	coverage: 44.4% of statements
ok  	github.com/mdevilliers/redishappy/sentinel	0.007s	coverage: 58.6% of statements
ok  	github.com/mdevilliers/redishappy/types	0.004s	coverage: 100.0% of statements
github.com/mdevilliers/redishappy/configuration/configuration.go:32:	GetCurrentConfiguration		100.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:40:	NewConfigurationManager		100.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:49:	loop				100.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:58:	LoadFromFile			90.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:78:	parseConfiguration		100.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:89:	SanityCheckConfiguration	100.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:106:	FindClusterByName		100.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:116:	foldInEnvironmentalVariables	100.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:125:	getEnvironmentalVariable	100.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:134:	overrideClusterConfiguration	90.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:156:	overrideSentinelConfiguration	90.0%
github.com/mdevilliers/redishappy/configuration/configuration.go:179:	fauxHostAndIpToBits		71.4%
github.com/mdevilliers/redishappy/configuration/sanitycheck.go:14:	Check				100.0%
github.com/mdevilliers/redishappy/configuration/sanitycheck.go:34:	Check				100.0%
github.com/mdevilliers/redishappy/sentinel/manager.go:37:		NewManager			100.0%
github.com/mdevilliers/redishappy/sentinel/manager.go:64:		Notify				100.0%
github.com/mdevilliers/redishappy/sentinel/manager.go:68:		GetState			100.0%
github.com/mdevilliers/redishappy/sentinel/manager.go:72:		GetCurrentTopology		0.0%
github.com/mdevilliers/redishappy/sentinel/manager.go:78:		startNewMonitor			20.0%
github.com/mdevilliers/redishappy/sentinel/manager.go:100:		receiveConnectionMessage	0.0%
github.com/mdevilliers/redishappy/sentinel/manager.go:131:		getTopology			0.0%
github.com/mdevilliers/redishappy/sentinel/manager.go:161:		bootstrap			66.7%
github.com/mdevilliers/redishappy/sentinel/manager_types.go:49:		GetSentinel			100.0%
github.com/mdevilliers/redishappy/sentinel/manager_types.go:53:		GetSentinel			100.0%
github.com/mdevilliers/redishappy/sentinel/manager_types.go:57:		GetSentinel			100.0%
github.com/mdevilliers/redishappy/sentinel/manager_types.go:61:		GetSentinel			100.0%
github.com/mdevilliers/redishappy/sentinel/manager_types.go:65:		GetSentinel			100.0%
github.com/mdevilliers/redishappy/sentinel/manager_types.go:69:		FindSentinelInfo		100.0%
github.com/mdevilliers/redishappy/sentinel/manager_types.go:74:		createKey			100.0%
github.com/mdevilliers/redishappy/sentinel/monitor.go:23:		NewMonitor			40.0%
github.com/mdevilliers/redishappy/sentinel/monitor.go:49:		StartMonitoringMasterEvents	0.0%
github.com/mdevilliers/redishappy/sentinel/monitor.go:65:		loop				0.0%
github.com/mdevilliers/redishappy/sentinel/monitor.go:115:		shutDownMonitor			0.0%
github.com/mdevilliers/redishappy/sentinel/monitor.go:122:		dealWithSentinelMessage		100.0%
github.com/mdevilliers/redishappy/sentinel/monitor.go:158:		parseSwitchMasterMessage	100.0%
github.com/mdevilliers/redishappy/sentinel/sentinels.go:20:		NewSentinelState		100.0%
github.com/mdevilliers/redishappy/sentinel/sentinels.go:36:		Notify				100.0%
github.com/mdevilliers/redishappy/sentinel/sentinels.go:40:		GetState			100.0%
github.com/mdevilliers/redishappy/sentinel/sentinels.go:44:		loopEvents			100.0%
github.com/mdevilliers/redishappy/sentinel/sentinels.go:55:		updateState			95.3%
github.com/mdevilliers/redishappy/sentinel/throttle.go:13:		NewThrottle			100.0%
github.com/mdevilliers/redishappy/sentinel/throttle.go:28:		loopEvents			100.0%
github.com/mdevilliers/redishappy/services/template/writer.go:16:	RenderTemplate			85.7%
github.com/mdevilliers/redishappy/types/consul.go:17:			FindByClusterName		100.0%
github.com/mdevilliers/redishappy/types/flipper.go:31:			NewMasterDetailsCollection	100.0%
github.com/mdevilliers/redishappy/types/flipper.go:35:			AddOrReplace			100.0%
github.com/mdevilliers/redishappy/types/flipper.go:39:			Items				100.0%
github.com/mdevilliers/redishappy/types/flipper.go:48:			IsEmpty				100.0%
github.com/mdevilliers/redishappy/types/flipper.go:54:			Len				100.0%
github.com/mdevilliers/redishappy/types/flipper.go:55:			Swap				100.0%
github.com/mdevilliers/redishappy/types/flipper.go:56:			Less				100.0%
github.com/mdevilliers/redishappy/types/sentinel.go:12:			GetLocation			100.0%
github.com/mdevilliers/redishappy/util/exec.go:7:			ExecuteCommand			0.0%
github.com/mdevilliers/redishappy/util/file.go:8:			FileExists			100.0%
github.com/mdevilliers/redishappy/util/file.go:17:			WriteFile			0.0%
github.com/mdevilliers/redishappy/util/hash.go:9:			HashFile			100.0%
github.com/mdevilliers/redishappy/util/hash.go:17:			HashString			100.0%
github.com/mdevilliers/redishappy/util/hash.go:21:			HashBytes			100.0%
github.com/mdevilliers/redishappy/util/http.go:8:			WriteResponseAsJSON		0.0%
github.com/mdevilliers/redishappy/util/schedule.go:7:			Schedule			0.0%
github.com/mdevilliers/redishappy/util/stringify.go:7:			String				0.0%
github.com/mdevilliers/redishappy/util/stringify.go:12:			StringPrettify			0.0%
total:									(statements)			70.1%


Bulk UpdateOperation misses upsert options

What is the bug?
This is a follow-up for #282
The update-operation for bulks still misses crucial options like scriptedUpsert whereas the common UpdateRequest contains these options.
Without scriptedUpsert option it's not possible to insert documents by script.
Besides that, the less significant detectNoop is also missing.
How can one reproduce the bug?
n.a.
What is the expected behavior?
UpdateOperation should provide all options that the common UpdateRequest provides.
What is your host/environment?
OpenSearch 2.11
OpenSearch client 2.8.1
Java 17
Do you have any screenshots?
n.a.
Do you have any additional context?
n.a.

https://github.com/opensearch-project/opensearch-java/pull/748 was merged and reverted because it was made against a 2.8.1 branch which is only for security patches - looking for a PR on main


--no-proc-async duplicates --parallel

no-proc-async was added as a parallel processing option for highlights and parallel processing is enabled by default.
This needs to be merged into the existing --parallel option.
It also needs to be disabled by default - it hangs on my my OS X box, for example (See #1129)

It shouldn't be merged into the parallel option, since it denotes not using proc::async for rendering the pod or whether to spool up a new highlighter for every text segment. Will make $*DISTRO eq "macosx" have it use --no-proc-async by default

IME, we should have a unified way for the user to select that they want to
allow simultaneously processing, not one way per type of work.
On Tue, Jan 24, 2017 at 5:10 PM, Samantha McVey<EMAIL_ADDRESS>wrote:

It shouldn't be merged into the parallel option, since it denotes not
using proc::async for rendering the pod or whether to spool up a new
highlighter for every text segment. Will make $*DISTRO eq "macosx" have it
use --no-proc-async by default
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/perl6/doc/issues/1127#issuecomment-274955609, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADEUVUg9K1H05FKcDKoMx7k8EZ8MfoGks5rVnbhgaJpZM4Lf8DB
.

--
Will "Coke" Coleda

well... not using Proc::Async just uses that class, it still is --parallel=1...
They're not the same thing. --parallel decided how many start block promises to allow to accumulate and one is the method that the highlighter is started.

Parallel controls parallelism, and even when we use Proc::Async we are still using one thread. So I am closing this unless you have any objection.

I object, but not strenously enough to come up with a compelling argument. :)


Request handling on this client is a bit absurd

Guys, the way connections are handled looks a bit overengineered and moreover gives false alarms to the users:

looking at https://github.com/prismicio/prismic-javascript/blob/master/src/request.ts#L53 what happens if max connections are reached, we timeout in prod. And it's very hard to trace why did we timeout with this implementation. Why to make our node servers spend resources on holding the http(s) connection if you timeout? Just call callback with a verbose error. Now it's neither clear no performant

The MAX_CONNECTIONS set to 20 means that if we have one server, we cannot exceed ~60 users/minute. Then we either need to cache everything (then your cms is no longer instant) or we need to increase the amount of server. This should work ok with some little websites, but if we have a huge load, this doesn't work.

I'm not sure if there's a reason to have https://github.com/prismicio/prismic-javascript/blob/master/src/request.ts so complex? I.e. request is processed only at the time of queueing and etc. I don't think it's the best way to fix issue of too many requests spamming to your server, that's not client's thing. Why to have this queue implementation?

So to work around this, now I have 12 node instances and forked this repo to increase max connections to 100, to be able to withhold users at peaks times. But I think this is a bit absurd solution and your client library should be changed.
If you agree, maybe I could create a PR.
Don't you agree?

Hi @TomasRup,
I think even on client side it makes sense to have some kind of limit to prevent your client to run an infinite load of queries.
But you do have a point and I'd be happy if you could make a PR with a clean implementation that could really improve this mechanism which is complex, I agree on this.

Hi @TomasRup,
Do you have any progress on this?
I'd be happy to help you on this one so we can offer a smooth experience and prevent the timeout issue with the kit.

Hi @TomasRup
Can you try creating a http.Agent with the keepAlive option set to true and  pass it as proxyAgent option to the Prismic instance?
Something like this
const http = require('http');

const Agent = new http.Agent({ keepAlive: true });

Prismic.client("http://example.prismic.io", {
  proxyAgent: Agent,
});

And let me know if that helps?
Thanks
Marc

@TomasRup This issue is fixed in version 2.1.0 thanks to @MarcMcIntosh.

Awesome, thanks. Sorry I was on vacation, didn't help 😄

@TomasRup upgrade to the most recent version :)


Wrote D7 acceptance test and filled out D7 part 2

Some verification of the links and video will probably be needed once the merge goes through


Timer.current_time method is not available in the npm package

Hello! :wave:
I'm evaluating implementing livesplit-core in the GDQ graphics system. This system is a Node.js project, so I'm using the npm package here: https://www.npmjs.com/package/livesplit-core/
I am able to successfully instantiate a Timer, but the current_time method does not appear to be bound, and does not appear to be accessible via the npm package. Have I perhaps overlooked something? Is there another way I should be reading the current time from a Timer instance?
Thanks!
Alex

Hey Alex,
pretty cool that you are checking out livesplit-core. NodeCg should be a really good fit for livesplit-core. It seems like we indeed forgot to expose the current time in the timer object. But that's because we actually never needed it. And for good reason, usually you want to use the actual components instead of querying information manually from the timer object. All the components are written to be entirely UI independent. They just provide state objects (JSON in case of the JS version) that you can query and you can then choose to visualize them in whatever way. So that should work really well with NodeCg, as that also works similarly afaik. If you have further questions about how to use the components and co. then it's probably easier if you hit me up on Discord (CryZe#5623) (or Twitter DMs I guess).
I'll add those missing accessors regardless, as those might still be useful.


Include details on ranked progression in a separate tab

https://skill.svc.halowaypoint.com/hi/playlist/edfef3ac-9cbe-4fa2-b949-8f29deafd483/csrs?flight=62c6a8fe-9507-4342-a400-06734ba97624&players=xuid(2533274855333605)&season=CsrSeason6-1

Get the ranked overview in a separate Ranked tab.


GLSL auto version issue

If the following pixel shader
float4 PixelMain(float4 color : COLOR) : SV_Target
{
return color;
}
is compiled with Explicit Binding enabled, its result is
#version 130
in vec4 xsc_vary_COLOR;
layout(location = 0) out vec4 SV_Target0;
void main()
{
SV_Target0 = xsc_vary_COLOR;
}
This GLSL version is wrong, and the resulting shader will not compile.
Note, this is a minor issue for me, because I can easily force the GLSL version.
I just reported it so it's not getting forgotten

Thanks for the report, this might be an issue from the GLSLExtensionAgent.
I'm aware of a similar problem, but I didn't have the time to fix it yet.
As you mentioned, this can currently be avoided by forcing the GLSL version explicitly.

Solved with 7fc960c2f7b4f6f599209e15a8d15d87e53d12f4


Shape infer with correct dtype

A new shape_infer implementation which creates the correct tensor dtype.

The Sequence type of ONNX proto is not planned for support.


Inconsistency with localization and language

I'm deploying the bot in Arabic language and using the localization files in the folder.

I've changed the default culture in the azure deployment to ar.
I've changed the defaultlanguagetag to 'ar' in the manifest.
I've uploaded the manifest to Teams.

However, the language is inconsistent. Some buttons are in Arabic and others are in English.
I attempted to change in the manifest itself the command title and descriptions to Arabic, and this reflected in Teams in the commands part however the buttons are still in English.
How do I ensure that the cards and buttons are in Arabic only and not both. Bot should support multiple languages.

Hi @aidab98,
Thank you for posting the query, we already responded you over email, but posting it as well for benefit of others,
Below mentioned steps will change buttons text and other window texts to specific language.
•	Change the default language while custom deployment of FAQ.
•	Change the default language field in the manifest before uploading the package.
•	Suggestion command can also be customized for specific language. For this you can update the highlighted command text in the manifest.

•	For changing the text of the buttons, you can change the MS Team’s language settings.

After performing the above steps, you can find the texts in the specific language.

Hi @aidab98 ,
We are closing this request as the we have provided the inputs for the query raised. If you face any issue with company communicator please raise a new issue for further assistance.


Added Selection Sort

Implemented Selection Sort

Description

Added selection sort implementation.
Related Issue

This PR closes #
Motivation and Context

Screenshots (if any)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

Thanks for the PR! Merged 👍

Thank you!


.md linting standards and image addition

image front and center and whitespace around headings to pass markdown linting rules/spec

Thanks Bryan! I don't know exactly how that worked but I took it on faith and appreciate the results of an improved Readme. Many thanks!


Hot-fix for production-eu tests

When trying to do connection:info in our testing, the tests fail because
$HOME/.heroku does not exist. This is a temporary workaround for that
issue.

👍


Remove GetSigners from sdk.Msg implementations

Summary
The GetSigners method has been deprecated in favour of proto annotations. It can be removed.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Hi @damiannolan
I would like to work on this. Is it just to remove the GetSigners?
Am I replacing it with anything?

Hey @CyberGA, feel free to work on this issue! I can assign you.
Yes we can just remove the GetSigners method for each implementation of the sdk.Msg. The msgs are maintained under the types package of each module (transfer, interchain-accounts, 29-fee, ibc core). You can find them in the msgs.go file.
There no need to do any to replace them. The functionality has already been replaced using protobuf annotations. See here for example

Okay I will work on it

ayo @CyberGA still have time to work on this? If not, we can assign it elsewhere. An example of how this should look can be seen in linked PR.

I can do it 👍

Hey @damiannolan, do you still work on this? if you don't have time, I think I can handle it 😄

@ThanhNhann be my guest! I'll assign you :)

@damiannolan @DimitrisJim sirs can I continue the work on this ?

thank @hoangdv2429 but I'm working on it, you can check other issues and solve them too 🤝


Update of Kosakonia radicincitans DSM16656 required as genome is out of date

From a user:
I was checking your web interface regarding the genome of Kosakonia radicincitans DSM16656.
I have noticed that for the chromosome sequence the old taxonomic name and version (version1, contigs) still appear (Completion date: 7/19/12, GCA_000280495.1 http://www.ncbi.nlm.nih.gov/assembly/GCA_000280495.1), while the plasmids, announced in the newer version 2, are available and the updated name is given (Completion date: 4/4/17, GCA_000280495.2 http://www.ncbi.nlm.nih.gov/assembly/GCA_000280495.2).
The genome was re-sequenced completely in 2017. I that run the plasmids were discovered as well. The complete sequences for the two plasmids and the chromosome were uploaded to NCBI at the same time with the correct taxonomic name (GCA_000280495.2 http://www.ncbi.nlm.nih.gov/assembly/GCA_000280495.2).
Could you update the entry/record for the chromosome as well as it is still missing (‘old"), or will it be done with the current updating process?

New version of this genome has been added to the database. I have responded to the user and closed the JIRA ticket.
https://www.patricbrc.org/view/Genome/1177180.18


Add equal=1

This PR aims to reduce pum flicker.
By the way, In completion-nvim#master did not get work with vsnip in my environment...
@haorenW1025 do you get to work it?
And I have another fuzzy match algorithm. if you want it, I will send PR.

Sorry, it does not work correctly... I'm closing it for now...

Hmm vsnip seems to work fine on my side. Do you mean the LSP expansion part or the snippets part?

Yes, I intented snippet expansion.
OK, I setup completion-nvim after a long time so probably I may have overlooked some misconfiguration.
I will try it again!

@hrsh7th I added equal=1 and seems to improved the the flickering issue a lot.

Sorry, it does not work correctly... I'm closing it for now...
What was not working correctly.

Thanks


How best to work with Mistletoe?

In our review of existing Markdown parsers (ExecutableBookProject/meta#18 ExecutableBookProject/meta#19) mistletoe came out as the favourite for its mix of parsing speed, extensibility and well constructed API. However, the one con was that it is not really being actively maintained.
To this extent, for current development, a fork is being used as a dependency (ExecutableBookProject/mistletoe#1), to allow for required/desired changes to the core code. Eventually though these need to be up-streamed, or the fork needs to become its own package (with pypi and conda distributions).
What is the best way to contact/work with the current maintainer to achieve this?

I think the first step would be to try making a few small-ish PRs and see how responsive they are. We can slowly try to close the gap between this fork and mistletoe master, but if we make a giant PR all at once it'll probably be much less-likely they'll engage.
In an ideal world, we'd get the keys to mistletoe but it may be some time before that happens depending on what kinda maintainer they are. In an extreme case, if we decide it's not worth engaging w/ a fork, then we can hard-fork it and rename the project to something else.
WDYT?

I imagine making a PR will just hit a brick wall, like the other pending PRs. But can give it a go.
Yeh it depends on the reason why he is currently not engaging. If its just that he's super busy with other things, it might be good to send him a nicely worded email at some point, and explain our position and that we would (maybe) be happy to pick up some of the slack on maintenance.

yep for sure - I think that either way though we've gotta start by making a (probably small) PR...if we decide to escalate one way or another, then we can say that we've gone through the typical ways of engaging first

Issue opened  miyuchina/mistletoe#92

Shall we open up a PR in mistletoe? We haven't heard anything back from the author since our original post...perhaps a minor improvement, or the bugfix mentioned in #102 ? Just wanna keep the heartbeat going there...

Another note - Mistletoe was announced on Reddit 2 years ago here:
https://www.reddit.com/r/Python/comments/6sjz3x/mistletoe_a_fast_extensible_markdown_parser_in/

Shall we open up a PR in mistletoe?

See miyuchina/mistletoe#94

nice - thanks

FYI, here is a working list of 'up-streamable' changes that would be desired

Move testing from unittest to pytest: pytest is now the de facto testing architecture and vastly improves the usability/flexibility of testing. (already introduced in fork)
Introduce pre-commit code linting and formatting: This standardizes the code style across the package, and ensures that new commits and Pull Requests also conform to it.  (already introduced in fork)
Introduce ReadTheDocs documentation
Add a conda-forge distribution of the package
Improve the AST API and documentation: I view panflute's implementation of the pandoc API in python, as the gold standard for how a pythonic AST API should be written and documented. Some tweaks to the current token class objects, and creating auto-generated RTD documentation, could achieve this.
Storage of source line/column ranges: LSP and good rendering reporting of warnings/errors, requires access to the source line and column ranges of each parsed token.
Asynchronous parsing: LSP requires documents to be parsed asynchronously. Currently, mistletoe contains a number of global state elements, which make parsing inherently not thread-safe. The simple solution to this is to store these items as threading.local objects. A related but slightly more complete solution is to introduce the idea of a 'scoped session', similar to that used by sqlalchemy for database access: Contextual/Thread-local Sessions
Improve extensibility of block tokens: A Markdown parser is inherently a Finite State-Machine + Memory (a.k.a Push-down Automata (PDA)), with parsing tokens as states (for a good example of a python state-machine see pytransitions). The problem with extensibility, is that inherently states are interdependent; when introducing a new state/token you must provide logic to all the other tokens, w.r.t to when to transition to this new token. Currently, MyST Parser sub-classes nearly all the Mistletoe block tokens to implement the extensions it requires, but it would be ideal if there was a more systematic approach for this.
Improve extensibility for span tokens: Mistletoe does allow for span token extensions to be added, at least in a simple way. However, as with block tokens above, there is often an interconnectivity to them, especially when considering nested span tokens. As of 7cc2c92, MyST-Parser now overrides some of Mistetoe's core logic to achieve correct parsing of Math tokens, but if possible this should be made more general.
Improve rendering logic: Currently, there is no concept of recursive walk-throughs or 'visitor' patterns in the Misteltoe BaseRenderer, which is a better method for rendering tree like structures (as used by docutils/panflute). Also, the current token instantiating (within context managers) needs improvement (see  miyuchina/mistletoe#56).

Nice - this is really helpful.
I think the other question we should all consider is: what happens if it just doesn't work out? I am curious what @chrisjsewell thinks about the maintainability and sustainability of caring for Mistletoe (or in a worst-case scenario, needing to care for a differently-named fork of it). After having worked with the codebase thus far, what are your thoughts on that?

As you've noticed, I got impatient lol. mistletoe-ebp now has CD on pypi and soon on conda-forge. Then I can propagate this to MyST-Parser.
I still think mistletoe is the right tool for the job, in terms of its base API, it just needs the improvements above. I don't think maintainability/sustainability should be too much of an issue, given that a robust test suite is in place, since the underpinning Markdown syntax isn't exactly going to be changing any time soon (if ever from what we've seen from the decade long forum conversations lol).

Sounds good - it does increasingly look like the author isn't going to be very responsive. At some point, if we decide there's nothing we can do about mistletoe maintenance etc, we should rename this parser to something else and release it as a separate project in the hopes we can get more community buy-in on it.


42 documentation

@kvantricht @HansVRP @VincentVerelst
My last contribution for GFMAP (or at least as a VITO employee!)
This week was a bit crazy for me so I couldn't do it completely, hopefully this will be enough to carry on the development.
There is a missing section on the job managers, @VincentVerelst whenever you have the time could you complete it?
There should also be some github actions to automatically upload this documentation to a website upon merge to main, I think you can use WorldCereal's Documentation repository as a reference for it.

Thank you sir, you will be missed! Your contributions will live on till eternity 🌟 (or at least till next sprint 🤣) 🚀 🚀 🚀


Decouple orphan deletion from MMServer

Begins to address issue #110 by extracting orphan deletion into its own class, so it can be used when callers are bypassing MMServer but still using MMRecordResponse.

@cnstoll Did you mean to add this to the 1.4.2 milestone? I see that you modified the milestone, and you added the corresponding issue to it, but somehow this pull request wasn't added.


Missing rosdep key for pymap3d-pip in ubuntu jammy

Hi all, I'm new here, sorry if I'm not in the right place.
I'm getting a jenkins build error, not finding pymap3d-pip key. rosdep rule is defined here and it seems right. Also our own CI action finds it, any help?
Should I open a PR adding ubuntu jammy version? Should I add a new rule for python3-pymap3d apt pkg? Thanks!

The name in your package.xml is wrong pymap3d. The key is actually pymap3d-pip as you can see as the root name of the rosdep entries. This is what we look for in the package.xml parsing. Updating that should fix your issue.
Separately, we do generally prefer apt packages over pip packages, so submitting updates to use the apt version would be a separate and useful contribution

Hey, thanks for the help.
We actually are using the key as you mention in the package.xml.
Alright, I'll open a PR in the next days, glad to contribute!

Oh I see (sorry, I scanned quickly and that's the most common reason), that actually looks like the key resolved. It looks like that doesn't actually exist on your OS... which is odd because I can pip install that on my 22.04 machine. That is odd. Can't say I know the reasons for that, might be something pythony (which I don't use extensively). Its perhaps best to get the opinions of another maintainer here that is more familiar with these kinds of issues w.r.t. python

Solved in #36164 , thanks!


import.meta.url not available in dependencies, wasm-pack modules unusable in dev mode?

Describe the bug
I have built a package (@webonnx/wonnx-wasm) containing a WebAssembly module from Rust using wasm-pack. The source is here, command line used to build:
RUSTFLAGS=--cfg=web_sys_unstable_apis wasm-pack build --target web -d `pwd`/target/pkg --out-name wonnx --scope webonnx ./wonnx-wasm

I tried building a very simple app using Vite to test the package. Upon opening the app however, I get the following error:
Uncaught (in promise) TypeError: Failed to construct 'URL': Invalid URL
    at init (wonnx.js:422:17)
    at run (main.js:5:9)
    at main.js:32:1

The issue appears to be with this line in the part of the wonnx-wasm package that loads the WebAssembly module:
 input = new URL('wonnx_bg.wasm', import.meta.url);

Further digging revealed that import.meta.url is undefined here. It is defined when I try to log it from the app code. (So: Vite is likely not defining it for dependencies?).
Interestingly running npm run build makes it work just fine! (You will likely still see the error TypeError: Cannot read properties of undefined (reading 'requestAdapter') in your browser because the package attempts to use WebGPU, that's obviously not a problem in Vite). In the bundle the offending line compiles to:
_=new URL("/assets/wonnx_bg.d1675c64.wasm",self.location));

So my question is (1) is this behaving as expected, and (2) if so, how am I supposed to be using packages like this in dev mode (e.g. from wasm-pack) with Vite / is there anything wasm-pack should change?
Reproduction
https://github.com/pixelspark/wonnx-wasm-test
System Info
System:
    OS: macOS 12.2.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 25.01 GB / 64.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.0 - ~/.brew/bin/node
    npm: 8.3.1 - ~/.brew/bin/npm
  Browsers:
    Chrome Canary: 101.0.4939.0
    Edge: 99.0.1150.36
    Firefox: 97.0.2
    Firefox Nightly: 99.0a1
    Safari: 15.3
    Safari Technology Preview: 15.4

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I believe this is a bug of vite, it trys to transform the esm dep to cjs using esbuild, esbuild will convert import.meta.url to import_meta.url, which will be undefined. You can see this example produced by esbuild.

Is this the same as https://github.com/vitejs/vite/issues/5270?

@bluwy Yes, I confirm that set optimizeDeps.esbuildOptions.target to es2020 will fix this issue!

@bluwy esbuild will report an warning when build to target that does not support import.meta.url, you can see the debug example below and the esbuild repl

I think we should log this warning to user, or change this warning to our own warning to guide user to change their vite.config.ts file. What do you think?

I think a warning is good for the interim, but I haven't took a deeper look of why this happens in the first place and whether it can be fixed within esbuild (or Vite), so we can fix it without any warnings in the first place. Feel free to hack a PR out if you want though, it makes sense to me that esbuild warnings after pre-bundling should be printed out (Not sure if that could get noisy 🤔)
I'll close this issue then in favour of #5270 so we can keep the discussion in one place. Thanks for looking into this!

Thanks all!

@bluwy Yes, I confirm that set optimizeDeps.esbuildOptions.target to es2020 will fix this issue!

Yes, this fixes the URL error. It introduces a new one however (wonnx_bg.wasm cannot be found at http://localhost:3000/node_modules/.vite/wonnx_bg.wasm). This is probably some other config setting (if anyone here can point me in the right direction, much appreciated!)

So apparently the package is 'optimized' and put in node_modules/.vite but the referenced WASM-file is not. It is still available however as<EMAIL_ADDRESS>I fixed the issue by just excluding the package in optimizeDeps:
import { defineConfig } from "vite";

export default defineConfig({
  optimizeDeps: {
    exclude: ["@webonnx/wonnx-wasm"],
    esbuildOptions: {
      target: "es2020",
    },
  },
});


Add information about using NVM in development

Hello!
I recently made a PR in shiki php repo to add docs around using Node Version Manager.
I have made a similar PR here to update the documentation to provide some information to people using NVM to hopefully help them avoid the issues I had with not understanding why it was not working properly.
Thanks :)

Thanks!


add ./src/join

add one helper function "join" + tests

closes #4 tho it's a new functionality that has no direct issue related


SSL error when using --report

Snakemake version
7.18.1
Describe the bug

Unable to generate the report (snakemake --cores 8 --report filename). due to ssl error:
ssl.SSLError: [SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:997)
Logs

(p310) pdagosto@rckgxf0013 snakemake2cwl]$ snakemake -s main.make --cores 8 --report
Building DAG of jobs...
Creating report...
Traceback (most recent call last):
File "/work/miniconda3/envs/p310/lib/python3.10/site-packages/urllib3/connectionpool.py", line 703, in urlopen
httplib_response = self._make_request(
File "/work/miniconda3/envs/p310/lib/python3.10/site-packages/urllib3/connectionpool.py", line 386, in _make_request
self._validate_conn(conn)
File "/work/miniconda3/envs/p310/lib/python3.10/site-packages/urllib3/connectionpool.py", line 1042, in validate_conn
conn.connect()
File "/work/miniconda3/envs/p310/lib/python3.10/site-packages/urllib3/connection.py", line 414, in connect
self.sock = ssl_wrap_socket(
File "/work/miniconda3/envs/p310/lib/python3.10/site-packages/urllib3/util/ssl.py", line 449, in ssl_wrap_socket
ssl_sock = ssl_wrap_socket_impl(
File "/work/miniconda3/envs/p310/lib/python3.10/site-packages/urllib3/util/ssl.py", line 493, in _ssl_wrap_socket_impl
return ssl_context.wrap_socket(sock, server_hostname=server_hostname)
File "/work/miniconda3/envs/p310/lib/python3.10/ssl.py", line 512, in wrap_socket
return self.sslsocket_class._create(
File "/work/miniconda3/envs/p310/lib/python3.10/ssl.py", line 1070, in _create
self.do_handshake()
File "/work/miniconda3/envs/p310/lib/python3.10/ssl.py", line 1341, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:997)
Minimal example

taid='VCtest'
ref='mmv_NC_001510.fasta'

rule all:
	input:
		'{0}.bam'.format(taid)

rule index_reads:
	input:
		ref
	output:
		 multiext('{0}'.format(ref),'.amb', '.ann', '.bwt', '.pac', '.sa')
	shell:
		'bwa index {input}'

rule map_reads:
	input:
		index=multiext(ref, '.amb', '.ann', '.bwt', '.pac', '.sa'),
		reads='{0}_S2_R1.fastq'.format(taid)
	output:
		'{0}.sam'.format(taid)
	shell:
		'bwa mem {ref} {input.reads} > {output}'

rule samtools_view:
	input:
		'{0}.sam'.format(taid)
	output:
		'{0}.bam'.format(taid)
	shell:
		'samtools view -b -o {output} {input}'

```**Additional context**
<!--Add any other context about the problem here.-->
CentOS 7, Python 3.9

Perhaps someone could explain why the --report option causes snakemake to try to connect via ssl to somewhere on the internet? It's not obvious to me why the network would be coming into play when creating a report from local data.

I'm not super familiar with the code for report generation, but it would be helpful if you could strip down the Snakefile as much as possible to see if and when the error goes away. For example, I'm not able to reproduce the error with the following Snakefile:
rule all:
    input: 'out.txt'

rule runrule:
    input: 'in.txt'
    output: 'out.txt'
    run:
        shell("date > {output}")

In reports/data/packages.py there are references to a number of packages that reference license urls. The one that iin my example seems to trigger the error specifically mentions the host raw.gihubusercontent.com, probably the first one its running into:
requests.exceptions.SSLError: HTTPSConnectionPool(host='raw.githubusercontent.com', port=443): Max retries exceeded with url: /snakemake/snakemake/main/LICENSE.md (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate in certificate chain (_ssl.c:997)')))
Is the report function trying to download these packages? The ones listed are:
snakemake (already installed)
pygments (already installed)
These are all npm packages:
tailwindcss
react
vega
vega-lite
vega-embed
heroicons
I don't do web development but if I were to install these packages somewhere on my Linux VM would snakemake not try to download them? How would I tell snakemake where they're located?

Just took a look at the source code for this. It is indeed attempting to download all of those libraries to generate the report and there does not appear to be any workaround.
In normal development, just the links to the libraries would be embedded, and the browser would handle the downloads, allowing the report to be generated without an internet connection. The only rationale for the current behaviour that I can come up with is that the report can be completely self-contained and opened without an internet connection.
Unfortunately, any change in this behaviour would technically be breaking: folks may currently be relying on self-contained reports. So getting a fix incorporated into main may be challenging. But if I get time I can look into patching on a fork at least.

I wouldn't spend any time on trying to make a fork or getting this into the main branch. Now that I know what's going on I can try to figure out the network errors I'm getting which is something in my company's environment.


L7 deny rule check in authz validation

Warning message for L7 Deny rule which will block all the tcp traffic under the scope of the policy having that rule

@aryan16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
855e9c7d9f6797850efdb419e2affdbcbf55541a
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
855e9c7d9f6797850efdb419e2affdbcbf55541a
link
true
/test release-notes

lint_istio
855e9c7d9f6797850efdb419e2affdbcbf55541a
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
b8a98584b19c1405c306131848898fe0b341eadf
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@aryan16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
946869fa67d182715c1a72fbe5d3f61d979153a4
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson PTAL


npm init starknet not running

➜  my-starknet-app npm run dev

><EMAIL_ADDRESS>dev
> next dev

ready - started server on <IP_ADDRESS>:3000, url: http://localhost:3000
error - ./node_modules/@starknet-react/core/dist/connectors/injected.js:6:0
Module not found: Can't resolve 'get-starknet-core'

Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS>./pages/_app.tsx

https://nextjs.org/docs/messages/module-not-found

I get this error from creating a project with npm init starknet then npm run dev

Project was missing get-starknet-core and starknet dependencies

Happy to take this as it is related to #323


Updated Validation.py

Updated validation.py scripgt
Fixed the behaviour of validate_user function
Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Changes made to file


[C#] Remove ShallowCopy since we now have serialize

Fix https://github.com/microsoft/FASTER/issues/358

This PR also simplifies log compaction. Basically, it moves the Compact call to ClientSession. This way, we can use the existing IFunctions to perform the compaction. These functions would already handle concurrency for normal operations. What this also implies is that ICompactionFunctions can be simplified to only contain IsDeleted(...) and user does not need to provide anything by default.
Usage Example
using (var session = store.NewSession(...))
   session.Compact(address, true);

We can eventually deprecate the Compact operation on LogAccessor (i.e., store.Log.Compact(...)) - when we remove it, we can also remove the Copy and InPlaceCopy methods from the ICompactionFunctions interface.


bug: IDE experience incorrectly flags inherit constructor chaining where no vals

Using  2022.3.3 on a Mac, the IDE flags an (admittedly esoteric) bit of syntax, that compiles fine:

(if I add a dummy val, it works fine)
References:

https://learn.microsoft.com/en-us/dotnet/fsharp/language-reference/inheritance
https://stackoverflow.com/questions/75900935/f-add-multiple-constructor-overloads-that-call-the-base-class-constructor
https://github.com/fsharp/fslang-suggestions/issues/1302 (triggered me to try it)

@bartelink Hi, thank you for reporting it. Could you please check it on 2023.2 release? It should be fixed there.

Thanks, doh! (I was distracted by on March 20, 2023 in the about and didn't even consider I could be that far behind)
Closing; will necropost if it turns out this still repros

Unfortunately I'm still seeing it in 2023.2
If you replace EventStoreCategory in https://github.com/jet/equinox's master with
type EventStoreCategory<'event, 'state, 'context> =
    inherit Equinox.Category<'event, 'state, 'context>
    new(context: EventStoreContext, name, codec: FsCodec.IEventCodec<_, _, 'context>, fold, initial, access, caching) =
        { inherit Equinox.Category<'event, 'state, 'context>(name,
            Category<'event, 'state, 'context>(context, codec, fold, initial, access)
            |> Caching.apply Token.isStale caching) }

it's still asserting 'this record contains fields from inconsistent types', despite it compiling...
As mentioned, changing it to:
type EventStoreCategory<'event, 'state, 'context> =
    inherit Equinox.Category<'event, 'state, 'context>
    val dummy: int
    new(context: EventStoreContext, name, codec: FsCodec.IEventCodec<_, _, 'context>, fold, initial, access, caching) =
        { inherit Equinox.Category<'event, 'state, 'context>(name,
            Category<'event, 'state, 'context>(context, codec, fold, initial, access)
            |> Caching.apply Token.isStale caching); dummy = 1 }

shuts it up
(The ids branch applies a few more in the most recent commit, but they are all equivalent in that they don't have any vals to initialize etc)

@bartelink Thanks for checking! Yes, indeed, it's actually fixed in 2023.3 builds, not in 2023.2. There was an issue in the initial implementation of https://github.com/dotnet/fsharp/pull/15214 in our FCS work, and I've fixed it when proposed the change upstream.
2023.2:

2023.3:

I'll see if it's safe to backport it to a bug fix release.

I'll see if it's safe to backport it to a bug fix release.

Please don't; I'll wait

@jwosty Thanks for reporting it! Yes, all looks good in 2023.3:


Bug: Browser-View in Mac-Desktop-App not closeable

My Setup

Operating System: Mac 11 Big Sur
App Version: 3.1.1.
Installation type: dmg

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description
If i click on an URL inside a thread, the website will open inside Rocket-.Chat. The left navigation bar is gone and the window is completly filled with the content of that website. But there is no "back" button. I cannot close the website to get back to my threats. Mayby I'm to stupid to find it, but even though, it should be easy to find vor everyone to close that view.

Any update on this? Since upgrading to the latest RC version the links are always opened directly inside of the RC app instead of opening the link in the browser. This makes it very hard to work effectively with RC.
RC verison: 3.11.1
App version: 3.1.1

Maybe it's better to follow this issue here https://github.com/RocketChat/Rocket.Chat/issues/20543

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.
Thank you!


Broken Hyperlinks

In the Secure Boot section, both Microsoft hyperlinks appear to be broken.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c795c8ef-7caf-b8a7-4118-b00b1899eef8
Version Independent ID: cd85b6b4-d160-0c44-15ea-4b7c02fbe0eb
Content: Secure the Windows 10 boot process
Content Source: windows/security/information-protection/secure-the-windows-10-boot-process.md
Product: w10
GitHub Login: @Justinha
Microsoft Alias: justinha

Thanks for flagging them. I think the Dashboard is now at https://partner.microsoft.com/en-us/dashboard and for the other link it would be more stable to link to dreamwidth.org rather than a specific page.
@mypil would you like to submit a PR or should I just do it from my side?

@Justinha - Sure, I can assign someone to create a PR for this.  Thanks.

@officedocsbot assign @mypil

@lindspea - please assist to create a PR for this issue. Thank you.

@mypil @Justinha Thank you.  Will fix soonest.

@sympleconfigmgr - From our understanding, the issue has been resolved but it may take a few days for the merged content to appear in the article. If you feel it hasn't been resolved, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!

Thank you all!

@officedocsbot close


XD-2717 Add nameExpression Property to File Sink

I have signed and agree to the terms of the SpringSource Individual
Contributor License Agreement.

I tried something using this PR.
Input payload is a json containing a field date :
... | file --nameExpression='#jsonPath(payload,''$.date'')'"
Spring XD tells me that method jsonPath is null ...
if I try :
... | log --expression='#jsonPath(payload,''$.date'')'"
it works ...
I don't see why ! Could someone help me to fix that. Otherwise this PR is incomplete I think.

I'm adding dirExpression to this module don't merge now please I will have finished in 30 minutes ...

Can one option cover the full path as in the hdfs sink?

I'm gonna check the hdfs sink to see if I can do that. It's a good idea ! That would be easier to use.

I don't see the option you're talking about in HDFS sink ... I see directory but it's not a SpEL expression.

Look at http://docs.spring.io/spring-xd/docs/current/reference/html/#hadoop-hdfs and --partitionPath

Maybe it is in fact two distinct options after all...

Oh .... I see ... because I use the same options from Spring Integration file:outbound-adapter I  kept the two distinct options. I did this pull request because I need it in one of my projects and keeping the two options is easier in my case and the stream is more readable when you display it with stream list. Don't you think ?

Yea, you are right.  Mapping to the underlying options in SI is better.  Sorry for the noise

No pb :) That's always a pleasure to talk with you pivotal guys :) I always learn a lot from you. I'm gonna finish my PR. Hope it will be ok.

Job done.

@fmarchand Thanks for the PR!! Could you change DirExpression to DirectoryExpression (properties, the module options etc.). I think this will be more consistent with the underlying Spring Integration.

I've done the 'directory' thing

@fmarchand Sorry for my earlier confusion. I merged the PR. Only at second looks I realized that we were already using dir. In that context dirExpression actually makes sense. Thanks for the contribution!!!!

You're welcome ! NP for the confusion. That happens :)


Group all dependencies in the parent pom.xml

This will simplify the maintenance of the archetypes.
I've also renamed version.jboss.bom to version.wildfly.bom as this is the version that controls the org.wildfly.boms dependencies.

@jamezp Wdyt? On one hand, there is a single place to update any dependencies/plugins but on the other hand, the creation of the archetypes is a bit more complex (their pom.xml is filtered while the rest of their resources is not)

Just for my understanding: when we build the archetype, the property values in archetype-resources/pom.xml (e.g. ${version.wildfly.bom} ) are taken from "org.wildfly.archetype:wildfly-archetypes" pom.xml and written to the archetype-resources/pom.xml? The latter is no longer a file in git, but is generated every time?

@WolfgangHG not exactly.
The first part is correct: the property values are stored in the parent pom.xml
The archetype-resources pom.xml is still in Git but in a separate source tree (eg wildfly-jakartaee-ear-archetype/src/main/resources-filtered/archetype-resources/pom.xml).
When the archetypes are built, this pom.xml is filtered with the property values from the parent pom (so its own  version.wildfly.bom will have the value 29.0.0.Final).
The reason of this structure is that we want to evaluate some property values when we built the archetype (for the versions) and keep others that will be evaluate when the project is generated by the archetypes (eg rootArtifactId) . The latter properties are escaped from filtering by prepending a /.
Does that clarify it? (If this PR is approved, I'll add this comment to the archetypes README so that we know why the projects are structured this way.)

OK, I hope I got it ;-). Would have to see it myself, but not before late this evening...
Could you document this in some Readme.md? This would be hard to track otherwise.

@WolfgangHG There is no hurry to do that change but that was the last thing I was missing to lower the maintenance of the archetypes :)
I amended the PR to add some documentation (https://github.com/wildfly/wildfly-archetypes/compare/e06ee95a3f72c312a3f30ae87844fe7a7d8b36b9..fc90c2eaccd858061018847ca7e2b1553dd7cc4b)

@jmesnil Wait - there is something strange...
I cannot create a project from the EAR archetype 30.0.0.Final-SNAPSHOT.
This maven command fails:
mvn archetype:generate -DgroupId=foo.bar -DartifactId=multi -Dversion=0.1-SNAPSHOT -Dpackage=foo.bar.multi -DarchetypeGroupId=org.wildfly.archetype -DarchetypeArtifactId=wildfly-jakartaee-ear-archetype -DarchetypeVersion=30.0.0.Final-SNAPSHOT -DinteractiveMode=false -DarchetypeCatalog=local -X
Error:
[INFO] Generating project in Batch mode
[DEBUG] Getting archetypes from catalog: C:\Users\USERNAME\.m2\repository\archetype-catalog.xml
[INFO] Archetype repository not defined. Using the one from [org.wildfly.archetype:wildfly-jakartaee-ear-archetype:30.0.0.Final-SNAPSHOT] found in catalog local
[DEBUG] Not found archetype org.wildfly.archetype:wildfly-jakartaee-ear-archetype:30.0.0.Final-SNAPSHOT in cache
[DEBUG] Could not find metadata org.wildfly.archetype:wildfly-archetypes:30.0.0.Final-SNAPSHOT/maven-metadata.xml in local (C:\Users\USERNAME\.m2\repository)
[DEBUG] Resolving artifact org.wildfly.archetype:wildfly-archetypes:pom:30.0.0.Final-SNAPSHOT from [central (https://repo.maven.apache.org/maven2, default, releases)]
[DEBUG] Archetype org.wildfly.archetype:wildfly-jakartaee-ear-archetype:30.0.0.Final-SNAPSHOT doesn't exist
org.apache.maven.archetype.downloader.DownloadException: Error downloading org.wildfly.archetype:wildfly-jakartaee-ear-archetype:jar:30.0.0.Final-SNAPSHOT.

It works for the 29.0.0.Final-SNAPSHOT version:
[INFO] Generating project in Batch mode
[DEBUG] Getting archetypes from catalog: C:\Users\knuffi\.m2\repository\archetype-catalog.xml
[INFO] Archetype repository not defined. Using the one from [org.wildfly.archetype:wildfly-jakartaee-ear-archetype:30.0.0.Final-SNAPSHOT] found in catalog local
[DEBUG] Not found archetype org.wildfly.archetype:wildfly-jakartaee-ear-archetype:29.0.0.Final-SNAPSHOT in cache
[DEBUG] Found archetype org.wildfly.archetype:wildfly-jakartaee-ear-archetype:29.0.0.Final-SNAPSHOT in cache: C:\Users\knuffi\.m2\repository\org\wildfly\archetype\wildfly-jakartaee-ear-archetype\29.0.0.Final-SNAPSHOT\wildfly-jakartaee-ear-archetype-29.0.0.Final-SNAPSHOT.jar
[DEBUG] checking fileset archetype status on C:\Users\knuffi\.m2\repository\org\wildfly\archetype\wildfly-jakartaee-ear-archetype\29.0.0.Final-SNAPSHOT\wildfly-jakartaee-ear-archetype-29.0.0.Final-SNAPSHOT.jar
[DEBUG] Searching for META-INF/maven/archetype-metadata.xml inside C:\Users\knuffi\.m2\repository\org\wildfly\archetype\wildfly-jakartaee-ear-archetype\29.0.0.Final-SNAPSHOT\wildfly-jakartaee-ear-archetype-29.0.0.Final-SNAPSHOT.jar

The jar file for the archetype is in the repository and "archetype-catalog.xml" contains. But something is wrong with it, and I have no idea what. Might also be caused by the previous change to the directory names.
The log for the successful checks from your pull request also seems to have  an issue. See the line where it falls back to "29.0.0.Final".
2023-08-18T08:34:22.0889453Z env:
2023-08-18T08:34:22.0889763Z   JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.8-7/x64
2023-08-18T08:34:22.0890167Z   JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.8-7/x64
2023-08-18T08:34:22.0890517Z   ARCHETYPE_VERSION: 30.0.0.Final-SNAPSHOT
2023-08-18T08:34:22.0890776Z   WILDFLY_VERSION: 29.0.0.Final
2023-08-18T08:34:22.0891143Z   JBOSS_HOME: /home/runner/work/wildfly-archetypes/wildfly-archetypes/wildfly-29.0.0.Final
2023-08-18T08:34:22.0891485Z ##[endgroup]
2023-08-18T08:34:22.0987050Z creating test project directory
2023-08-18T08:34:22.1005310Z generate project from archetype.
2023-08-18T08:34:23.1372114Z [INFO] Scanning for projects...
2023-08-18T08:34:23.4378661Z [INFO]
2023-08-18T08:34:23.4384074Z [INFO] ------------------< org.apache.maven:standalone-pom >-------------------
2023-08-18T08:34:23.4389554Z [INFO] Building Maven Stub Project (No POM) 1
2023-08-18T08:34:23.4412144Z [INFO] --------------------------------[ pom ]---------------------------------
2023-08-18T08:34:23.4459603Z [INFO]
2023-08-18T08:34:23.4465672Z [INFO] >>> maven-archetype-plugin:3.2.1:generate (default-cli) > generate-sources @ standalone-pom >>>
2023-08-18T08:34:23.4470491Z [INFO]
2023-08-18T08:34:23.4473106Z [INFO] <<< maven-archetype-plugin:3.2.1:generate (default-cli) < generate-sources @ standalone-pom <<<
2023-08-18T08:34:23.4474906Z [INFO]
2023-08-18T08:34:23.4486208Z [INFO]
2023-08-18T08:34:23.4488862Z [INFO] --- maven-archetype-plugin:3.2.1:generate (default-cli) @ standalone-pom ---
2023-08-18T08:34:24.1513322Z [INFO] Generating project in Batch mode
2023-08-18T08:34:25.2601418Z [INFO] Archetype repository not defined. Using the one from [org.wildfly.archetype:wildfly-jakartaee-ear-archetype:29.0.0.Final] found in catalog remote
2023-08-18T08:34:25.2828272Z [INFO] ----------------------------------------------------------------------------
2023-08-18T08:34:25.2832942Z [INFO] Using following parameters for creating project from Archetype: wildfly-jakartaee-ear-archetype:30.0.0.Final-SNAPSHOT

Notice the line where it falls back to the archetype "29.0.0.Final" from remote repository.
The "webapp" archetype works for me.

I think we should add -DarchetypeCatalog=local to the scripts "runtest_xxx.bat/sh" to prevent the fallback to the previous release version.

@jamezp  The integration tests for the EAR must be "surefire", see https://github.com/wildfly/wildfly-archetypes/blob/main/wildfly-jakartaee-ear-archetype/src/main/resources/archetype-resources/README.txt, last paragraph.
And don't forget the problem the the EAR archetype does not seem to work...

@WolfgangHG I'm not able to replicate this issue.

@jmesnil Wait - there is something strange... I cannot create a project from the EAR archetype 30.0.0.Final-SNAPSHOT.
This maven command fails: mvn archetype:generate -DgroupId=foo.bar -DartifactId=multi -Dversion=0.1-SNAPSHOT -Dpackage=foo.bar.multi -DarchetypeGroupId=org.wildfly.archetype -DarchetypeArtifactId=wildfly-jakartaee-ear-archetype -DarchetypeVersion=30.0.0.Final-SNAPSHOT -DinteractiveMode=false -DarchetypeCatalog=local -X
Error:
[INFO] Generating project in Batch mode
[DEBUG] Getting archetypes from catalog: C:\Users\USERNAME\.m2\repository\archetype-catalog.xml

Could that be the issue? Your logs have  C:\Users\USERNAME for 30.0.0.Final-SNAPSHOT while the previous version displayed:

[DEBUG] Getting archetypes from catalog: C:\Users\knuffi.m2\repository\archetype-catalog.xml

I followed your suggestion and all tests to use the local catalog and the last run looks correct:
[INFO] Archetype repository not defined. Using the one from [org.wildfly.archetype:wildfly-jakartaee-ear-archetype:30.0.0.Final-SNAPSHOT] found in catalog local
[INFO] ----------------------------------------------------------------------------
[INFO] Using following parameters for creating project from Archetype: wildfly-jakartaee-ear-archetype:30.0.0.Final-SNAPSHOT
[INFO] ----------------------------------------------------------------------------

@jmesnil About your "C:\Users\USERNAME" comment: I anonymized the paths, but forgot one ;-).
I understand why it did not work for me: I just built the ear archetype, but I did not call "mvn clean install" in the root directory. So, "org.wildfly.archetype:wildfly-archetypes" was not in my local repository.
After having built the root directory, I can create a project from the archetype.
This is the file "wildfly-jakartaee-ear-archetype-29.0.0.Final-SNAPSHOT.pom" in my local repository:
    <parent>
        <groupId>org.jboss</groupId>
        <artifactId>jboss-parent</artifactId>
        <version>39</version>
        <relativePath />
    </parent>

And this "wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT.pom", which introduces a new parent dependency that was missing before:
    <parent>
        <groupId>org.wildfly.archetype</groupId>
        <artifactId>wildfly-archetypes</artifactId>
        <version>30.0.0.Final-SNAPSHOT</version>
        <relativePath>../pom.xml</relativePath>
    </parent>

The new file "wildfly-archetypes-30.0.0.Final-SNAPSHOT.pom" file in my local repository contains all the versions and the dependency management that should actually be only contained in the "archetype-resources\pom.xml" file. Isn't this a bunch of unnecessary dependencies, which is not necessary to create the archetype, but
Do we need a parent element at all in the final archetype? Probably it is necessary for building the archetype project, but not when deploying the generated archetype.

@jmesnil Could you fix the "copy additional files" calls in the batch files of the ear archetype - currently they fail and don't do anything:
Those four lines should be changed to "ejb" instead of "multi-ejb":
copy ..\additionalfiles\TestBean.java .\multi\multi-ejb\src\main\java\foo\bar\multi\

@jmesnil Could you fix the "copy additional files" calls in the batch files of the ear archetype - currently they fail and don't do anything:

Sorry, I forgot them. I did not have access to a Windows machine.
Could you please check that they know work fine?
@WolfgangHG I also added the -DarchetypeCatalog=local to them to be consistent with the .sh scripts.

Do we need a parent element at all in the final archetype? Probably it is necessary for building the archetype project, but not when deploying the generated archetype.

We need it if we want to group all dependencies that are used across the archetypes. This provides a single point of control in the parent pom.xml. By construction, this is a new artefact but this has no impact on the generated Maven project.
The alternative would be to remove the dependency to this parent and have all 3 archetypes define individually the same dependencies (wildfly, failsafe, surefire, etc.).

Batch files work again, thanks.
I still have a bad feeling about the archetype pom file being cluttered with stuff that is only required at build time, but not for the user of the archetype. But I don't have enough knowledge of maven to give a better suggestion.
Just a bit of brainstorming: would it be possible to create a dummy maven project in this repository that mainly declares the versions and dependencies and is a "catch all" for dependabot.
When building this "catch all" project, the file "wildfly-jakartaee-ear-archetype\src\main\resources-filtered\archetype-resources\pom.xml" is copied to "wildfly-jakartaee-ear-archetype\src\main\resources\archetype-resources\pom.xml" and then the properties are replaced. Same for war and subsystem archetype.
Seems my suggestion is similar to what you already do with the maven-resources-plugin and the parent pom, but with this suggestion, the archeptype project pom.xml would be as small as before, without a parent pom.
I found https://github.com/floverfelt/find-and-replace-maven-plugin which might help, if the "replaceValue property can be defined as "use value of pom.xml variable".

would it be possible to create a dummy maven project in this repository that mainly declares the versions and dependencies and is a "catch all" for dependabot

That's the intent of the wildfly-archetypes parent pom.

Seems my suggestion is similar to what you already do with the maven-resources-plugin and the parent pom, but with this suggestion, the archeptype project pom.xml would be as small as before, without a parent pom.

In its current state, the archetypes already have a parent pom (org.jboss:jboss-parent). All this PR does is add a intermediate layer to group the dependencies for the archetypes that are not coming from this jboss-parent.
The key point to me is that this has no impact on the generated Maven project. They will be strictly identical to the one that are generated now. When the user uses the archetype to generate them, they will pull an additional artifact from Maven (the new wildfly-archetypes parent pom) but this is completely transparent to them.

OK, I see. From my point of view we can accept your pull request ;-)

@WolfgangHG thanks for the thorough review


copy null db schema for foreman

this isn't strictly needed, as the current tests run, but its likely they run by chance due to other tasks being run


[SPARK-3545] Put HadoopRDD.getPartitions forward and put TaskScheduler.start back to reduce DAGScheduler.JobSubmitted processing time and shorten cluster resources occupation period

We have two problems:
(1) HadoopRDD.getPartitions is lazyied to process in DAGScheduler.JobSubmitted. If inputdir is large, getPartitions may spend much time.
For example, in our cluster, it needs from 0.029s to 766.699s. If one JobSubmitted event is processing, others should wait. Thus, we
want to put HadoopRDD.getPartitions forward to reduce DAGScheduler.JobSubmitted processing time. Then other JobSubmitted event don't
need to wait much time. HadoopRDD object could get its partitons when it is instantiated.
(2) When SparkContext object is instantiated, TaskScheduler is started and some resources are allocated from cluster. However, these
resources may be not used for the moment. For example, DAGScheduler.JobSubmitted is processing and so on. These resources are wasted in
this period. Thus, we want to put TaskScheduler.start back to shorten cluster resources occupation period specially for busy cluster.
TaskScheduler could be started just before running stages.
We could analyse and compare the execution time before and after optimization.
TaskScheduler.start execution time: [time1__]
DAGScheduler.JobSubmitted (excluding HadoopRDD.getPartitions or TaskScheduler.start) execution time: [time2_]
HadoopRDD.getPartitions execution time: [time3___]
Stages execution time: [time4_____].
(1) The app has only one job
(a)
The execution time of the job before optimization is [time1__][time2_][time3___][time4_____].
The execution time of the job after optimization is....[time3___][time2_][time1__][time4_____].
(b)
The cluster resources occupation period before optimization is [time2_][time3___][time4_____].
The cluster resources occupation period after optimization is....[time4_____].
In summary, if the app has only one job, the total execution time is same before and after optimization while the cluster resources
occupation period after optimization is less than before.
(2) The app has 4 jobs
(a) Before optimization,
job1 execution time is [time2_][time3___][time4_____],
job2 execution time is [time2__________][time3___][time4_____],
job3 execution time is................................[time2____][time3___][time4_____],
job4 execution time is................................[time2______________][time3___][time4_____].
After optimization,
job1 execution time is [time3___][time2_][time1__][time4_____],
job2 execution time is [time3___][time2__________][time4_____],
job3 execution time is................................[time3___][time2_][time4_____],
job4 execution time is................................[time3___][time2__][time4_____].
In summary, if the app has multiple jobs, average execution time after optimization is less than before and the cluster resources
occupation period after optimization is less than before.

Hi @YanTangZhai seems that there is some duplicate work between this and your other patch #3810. Can we close this issue?