feat: add rest api spec for ipTags

Data Plane API - Pull Request

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.

Link to engagement record issue:

Is this review for (select one):

[ ] a private preview
[x] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

Design Document: https://msazure.visualstudio.com/CloudNativeCompute/_wiki/wikis/CloudNativeCompute.wiki/358355/Node-Public-IP-ipTags
Previous Open API Doc: https://msazure.visualstudio.com/CloudNativeCompute/_wiki/wikis/CloudNativeCompute.wiki/358946/Node-Public-IP-ipTags
Updated paths:

❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR.


Ability to branch locally

As a user, I want to be able to create a local branch of a playlist

Need to be able to:

Create a branch
Delete a branch
Merge a branch


Fix the order in which the wrapper parses properties

Fixes #985 and #11864.
Context
There were already two issues reported about this, and the fix was easy, so this should be done esp. now as the stale bot closed / is about to close the referenced issues.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Well, it's wrong compared to how Gradle normally reads those properties, so I think that's worth fixing.

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

Your PR is queued because #17000 is being built.

OK, I've already triggered a build for you.

Are you fighting flaky tests, or is there still a problem with my change @jjohannes?

Pre-tested commit build failed.

@sschuberth yes there was some flakiness first, but there also seems to be an issue a link in the docs. If you don't mind, can you:

Rebase to latest master
Run :docs:checkDeadInternalLinks and fix the issue (if there is any). CI seems to find one, but I can't see what it is right now.

* Rebase to latest `master`

Done.

* Run `:docs:checkDeadInternalLinks` and fix the issue (if there is any). CI seems to find one, but I can't see what it is right now.

Also done, there indeed was a dead link (which I fixed by actually adding a marker to the section I wanted to link to).

@sschuberth ah yes. In favour of having the check and not breaking existing links when changing section titles, we decided to have markers for every section, although in practice the linking could work without.
Thanks for fixing this ans sorry for the trouble.

@bot-gradle test and merge

OK, I've already triggered a build for you.


NEXT React Tabs component

Linked Issue
Closes #2395
Description
Tabs React component

@endigo9740 notable changes:
The current implementation of reactCompose utility is not accepting required fields, I had to add <any> to make it work, I searched for other alternatives but didn't find any easier way to avoid using any.
Also I will update you on the rest of the tasks tomorrow.

@Hugos68 do you review the issue Mahmoud described above for the reactCompose feature and provide your recommendations. No rush, just when you can.

We can remove reactCompose all together, it's merely a wrapper for Object.assign, Object.assign is far more leanient aswell so will probably happily accept any.

@Mahmoud-zino given you mention work on this will continue onto the weekend I've bumped this back to the "draft" state.

@Mahmoud-zino unfortunately I've run out of time for a full review for this today, so I'll plan to circle back tomorrow. In the meantime, here's a few superficial bits of feedback:

[ ] I'd suggest trying to match the number of examples you had on the Svelte/React sandbox apps, including RTL!
[ ] Some of the panel content is a bit too long and wraps. Maybe keep it short like Mantine?
[ ] I'd suggest adding one example with focusable content within the panel to test a11y. Even an <a> would work!
[ ] On the Svelte Docs the T for "Television" is lowercase in the first example.
[ ] In the icon with text + icons stacked, put the icons on top. This is how Material UI handles it.
[ ] The Svelte docs > Layout snippets don't have syntax highlighting. Verify the language is set to svelte

I'll do a proper dive into the code tomorrow! Overall things are looking great!

@Mahmoud-zino no further changes here, everything looks great. You nailed it!
The only thing we might consider in the future is avoiding loose text within children slots. For example:
<SomeComponent>Skeleton</SomeComponent>

<SomeComponent>
    <SomeIcon />
    Skeleton
</SomeComponent>

See where the text "Skeleton" is implemented above. This can incur two issues:

Loose text isn't treated as block-like element, which can have some adverse affects when it comes to mixing text, icons, etc for flexbox or grid styles.
There's no guarantee the text will adhere to global styles. So if the text is intended to be a heading, we need to declare it as such.

But none of the issues appear to be present here - just wanted to give a heads up going forward!


zimg: 2.7 -> 2.7.4

Semi-automatic update. These checks were performed:

built on NixOS
found 2.7.4 with grep in /nix/store/3881hzp2frwjsw7xyafvr3zzlyacv7a8-zimg-2.7.4
found 2.7.4 in filename of file in /nix/store/3881hzp2frwjsw7xyafvr3zzlyacv7a8-zimg-2.7.4

cc "@rnhmjoj"

Success on x86_64-darwin (full log)
Partial log (click to expand)
 /nix/store/6b3jzg40vibmrjg85i46vvidyy915428-coreutils-8.29/bin/install -c -m 644 src/zimg/api/zimg.h src/zimg/api/zimg++.hpp '/nix/store/3lz6lpwhsz90jr54ndkqkk3qgg3hndpa-zimg-2.7.4/include'
 /nix/store/6b3jzg40vibmrjg85i46vvidyy915428-coreutils-8.29/bin/mkdir -p '/nix/store/3lz6lpwhsz90jr54ndkqkk3qgg3hndpa-zimg-2.7.4/lib/pkgconfig'
 /nix/store/6b3jzg40vibmrjg85i46vvidyy915428-coreutils-8.29/bin/install -c -m 644 zimg.pc '/nix/store/3lz6lpwhsz90jr54ndkqkk3qgg3hndpa-zimg-2.7.4/lib/pkgconfig'
make[2]: Leaving directory '/private/tmp/nix-build-zimg-2.7.4.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-zimg-2.7.4.drv-0/source'
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/3lz6lpwhsz90jr54ndkqkk3qgg3hndpa-zimg-2.7.4/lib
patching script interpreter paths in /nix/store/3lz6lpwhsz90jr54ndkqkk3qgg3hndpa-zimg-2.7.4
/nix/store/3lz6lpwhsz90jr54ndkqkk3qgg3hndpa-zimg-2.7.4

Success on x86_64-linux (full log)
Partial log (click to expand)
make[2]: Leaving directory '/tmp/nix-build-zimg-2.7.4.drv-0/source'
make[1]: Leaving directory '/tmp/nix-build-zimg-2.7.4.drv-0/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3881hzp2frwjsw7xyafvr3zzlyacv7a8-zimg-2.7.4
shrinking /nix/store/3881hzp2frwjsw7xyafvr3zzlyacv7a8-zimg-2.7.4/lib/libzimg.so.2.0.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3881hzp2frwjsw7xyafvr3zzlyacv7a8-zimg-2.7.4/lib
patching script interpreter paths in /nix/store/3881hzp2frwjsw7xyafvr3zzlyacv7a8-zimg-2.7.4
checking for references to /tmp/nix-build-zimg-2.7.4.drv-0 in /nix/store/3881hzp2frwjsw7xyafvr3zzlyacv7a8-zimg-2.7.4...
/nix/store/3881hzp2frwjsw7xyafvr3zzlyacv7a8-zimg-2.7.4

@grahamcofborg build vapoursynth-mvtools zimg vapoursynth

Success on x86_64-darwin (full log)
Partial log (click to expand)
libtool: install: /nix/store/6b3jzg40vibmrjg85i46vvidyy915428-coreutils-8.29/bin/install -c .libs/libmvtools.lai /nix/store/6m05rwyyibxgxzbbl2i2lbwygv7x78vn-vapoursynth-mvtools-19/lib/vapoursynth/libmvtools.la
make[1]: Nothing to be done for 'install-data-am'.
make[1]: Leaving directory '/private/tmp/nix-build-vapoursynth-mvtools-19.drv-0/source'
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6m05rwyyibxgxzbbl2i2lbwygv7x78vn-vapoursynth-mvtools-19/lib
patching script interpreter paths in /nix/store/6m05rwyyibxgxzbbl2i2lbwygv7x78vn-vapoursynth-mvtools-19
/nix/store/6m05rwyyibxgxzbbl2i2lbwygv7x78vn-vapoursynth-mvtools-19
/nix/store/3lz6lpwhsz90jr54ndkqkk3qgg3hndpa-zimg-2.7.4
/nix/store/zflg7jwhmvl91fvh31195fms6zva78zc-vapoursynth-R40

Success on x86_64-linux (full log)
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/854h4b4h6jn395iwnrb17q4n57kcvk16-vapoursynth-mvtools-19
shrinking /nix/store/854h4b4h6jn395iwnrb17q4n57kcvk16-vapoursynth-mvtools-19/lib/vapoursynth/libmvtools.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/854h4b4h6jn395iwnrb17q4n57kcvk16-vapoursynth-mvtools-19/lib
patching script interpreter paths in /nix/store/854h4b4h6jn395iwnrb17q4n57kcvk16-vapoursynth-mvtools-19
checking for references to /tmp/nix-build-vapoursynth-mvtools-19.drv-0 in /nix/store/854h4b4h6jn395iwnrb17q4n57kcvk16-vapoursynth-mvtools-19...
/nix/store/854h4b4h6jn395iwnrb17q4n57kcvk16-vapoursynth-mvtools-19
/nix/store/3881hzp2frwjsw7xyafvr3zzlyacv7a8-zimg-2.7.4
/nix/store/9xlqzfxfrvic64r4smhjx3rv3a7nxz5z-vapoursynth-R40

Success on aarch64-linux (full log)
Partial log (click to expand)
make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/27cbvvmjyk7qjx5j28s39xjam5vw9mzk-zimg-2.7.4
shrinking /nix/store/27cbvvmjyk7qjx5j28s39xjam5vw9mzk-zimg-2.7.4/lib/libzimg.so.2.0.0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/27cbvvmjyk7qjx5j28s39xjam5vw9mzk-zimg-2.7.4/lib
patching script interpreter paths in /nix/store/27cbvvmjyk7qjx5j28s39xjam5vw9mzk-zimg-2.7.4
checking for references to /build in /nix/store/27cbvvmjyk7qjx5j28s39xjam5vw9mzk-zimg-2.7.4...
/nix/store/27cbvvmjyk7qjx5j28s39xjam5vw9mzk-zimg-2.7.4

Failure on aarch64-linux (full log)
Partial log (click to expand)
src/core/cpufeatures.c:97:2: error: #error Do not know how to get CPU features on Linux.
 #error Do not know how to get CPU features on Linux.
  ^~~~~
src/core/cpufeatures.c:78:24: warning: unused variable 'hwcap' [-Wunused-variable]
     unsigned long long hwcap = getauxval(AT_HWCAP);
                        ^~~~~
make: *** [Makefile:1324: src/core/libvapoursynth_la-cpufeatures.lo] Error 1
builder for '/nix/store/9kbhibh883iwd3vyikpn43k89021skh0-vapoursynth-R40.drv' failed with exit code 2
cannot build derivation '/nix/store/k0cax146880k23crshzkbld9pmlddfb7-vapoursynth-mvtools-19.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9kbhibh883iwd3vyikpn43k89021skh0-vapoursynth-R40.drv', '/nix/store/k0cax146880k23crshzkbld9pmlddfb7-vapoursynth-mvtools-19.drv' failed


Add tests

Closes #4
This PR adds CI and testing to the app.

Refactor components into src/components folder structure
Add jest setup
Add Travis CI setup with stages test, lint, coverage, build
Add coverage, ci, lint commands in package.json
Add tests for all of src/lib

Lint and build steps are showing some warnings that we should probably fix.
Do you want to wire up something like coveralls to monitor the code test coverage?

@teetow, appreciate you taking a look when you get a second.


django-watchfiles handles additional glob patterns differently from StatReloader

Python Version
3.10.6
Django Version
4.1.3
Package Version
0.1.1
Description
Intro
Let me start with an example. Here is an example Django app configuration:
my_app/apps.py:
from django.apps import AppConfig
from django.conf import settings
from django.utils.autoreload import BaseReloader, autoreload_started

# my_app
_name = __name__[: __name__.index(".")]

class MyApp(AppConfig):
    name = _name

    def ready(self):
        autoreload_started.connect(receiver=self._configure_autoreload, dispatch_uid=_name)

    def _configure_autoreload(self, *, sender: BaseReloader, **kwargs):
        if not hasattr(settings, "BASE_DIR"):
            print(f"{_name}: Please provide BASE_DIR Django setting pointing to root folder of your project")
            exit_with_load_error()
        basedir = os.path.abspath(settings.BASE_DIR)
        sender.watch_dir(basedir, "**/.env")
        sender.watch_dir(basedir, "**/.env.*")

How are these patterns handled by Django's default StatReloader:
https://github.com/django/django/blob/f030236a86a64a4befd3cc8093e2bbeceef52a31/django/utils/autoreload.py#L411
class StatReloader(BaseReloader):
  # ...
  def snapshot_files(self):
        # ...
        for file in self.watched_files():
           # ...check if file changed

class BaseReloader:
    # ...
    def watched_files(self, include_globs=True):
        # ...
        if include_globs:
            for directory, patterns in self.directory_globs.items():
                for pattern in patterns:
                    yield from directory.glob(pattern)

TLDR: directory.glob is used, so a pattern like **/.env would, for example, match a file named .env placed directly in the given directory.
Here is what django-watchfiles is doing:
https://github.com/adamchainz/django-watchfiles/blob/fb2cbc2d08a45301d293302e4228e377aec2f6b1/src/django_watchfiles/__init__.py#L64
class WatchfilesReloader(autoreload.BaseReloader):
    # ...
    def file_filter(self, change: watchfiles.Change, filename: str) -> bool:
        # ...
        for directory, globs in self.directory_globs.items():
            try:
                relative_path = path.relative_to(directory)
            except ValueError:
                pass
            else:
                # ...
                for glob in globs:
                    if fnmatch.fnmatch(str(relative_path), glob):
                        # ...
                        return True

TLDR: It attempts to check if the relative path from directory to a changed file satisfies a glob pattern with fnmatch
The problem
Using fnmatch like this is no replacement for directory.glob(...). You can get more intuition, for example, here: https://stackoverflow.com/questions/27726545/. For sake of illustration:

fnmatch does not handle ** at all: https://docs.python.org/3/library/fnmatch.html

fnmatch matches the given path right to left and reports a successful match even if the path does not match fully. So, while Path('/home/user/').glob('a.txt') would only return a.txt placed directly in the given directory, fnmatch('a.txt', 'a.txt') and fnmatch('some/nested/folder/a.txt', 'a.txt') would both return true.

So, user gets different results when using the same pattern depending on whether StatReloader or WatchfilesReloader is used.
Possible solutions
Ideally Python should offer some equivalent to directory.glob(pattern) -> filenames, which would allow one to validate a filename against a glob within a given directory or, to the same extent, to validate a relative path against a glob, something like globmatch(relative_path, glob) -> bool.
Unfortunately, there is no such thing in Python's standard library. Also, as far as I discovered, there are no third-party packages that specifically aim to offer such an equivalent to Path.glob. However, there are packages that offer similar glob-matching.
I have prepared a test project comparing Path.glob with fnmatch, globmatch and globber:
import os

# Example:
#
#test_tree = [
#    "abc/def/ghi/a.txt",
#    "abc/def/a.txt",
#    "abc/a.txt",
#    "abc/c.txt",
#    "a.txt",
#    "b.txt"
#]

def mktree(root: str, tree: list[str]) -> None:
    for path in tree:
        if path.endswith('/'):
            os.makedirs(os.path.join(root, path), exist_ok=True)
        else:
            os.makedirs(os.path.dirname(os.path.join(root, path)), exist_ok=True)
            _touch(os.path.join(root, path))

def _touch(filename: str) -> None:
    open(filename, 'a+').close()
``

```python
from fnmatch import fnmatch
import itertools
from pathlib import Path
import sys
import tempfile
from typing import Iterable, Protocol

import globber
from globmatch import glob_match
import polars as pl

class _Glob(Protocol):
    def __call__(root: str, glob: str) -> Iterable[str]: ...

class _GlobImplementation:

    @staticmethod
    def glob(root: str, glob: str) -> Iterable[str]:
        return (str(name.relative_to(root)) for name in Path(root).glob(glob))

    @staticmethod
    def fnmatch(root: str, glob: str) -> Iterable[str]:
        for dir, dirnames, filenames in os.walk(root):
            for name in itertools.chain(dirnames, filenames):
                name = str(Path(os.path.join(dir, name)).relative_to(root))
                print(f"fnmatch({name!r}, {glob!r}) => {fnmatch(name, glob)!r}", file=sys.stderr)
                if fnmatch(name, glob):
                    yield name

    @staticmethod
    def globmatch(root: str, glob: str) -> Iterable[str]:
        for dir, dirnames, filenames in os.walk(root):
            for name in itertools.chain(dirnames, filenames):
                name = str(Path(os.path.join(dir, name)).relative_to(root))
                print(f"globmatch({name!r}, [{glob!r}]) => {glob_match(name, [glob])!r}", file=sys.stderr)
                if glob_match(name, [glob]):
                    yield name

    @staticmethod
    def globber(root: str, glob: str) -> Iterable[str]:
        for dir, dirnames, filenames in os.walk(root):
            for name in itertools.chain(dirnames, filenames):
                name = str(Path(os.path.join(dir, name)).relative_to(root))
                print(f"globber.match({glob!r}, {name!r}) => {globber.match(glob, name)!r}", file=sys.stderr)
                if globber.match(glob, name):
                    yield name

def _test_glob_implementation(root: str, globs: list[str], impl: _Glob) -> Iterable[str]:
    for glob in globs:
        yield "; ".join(impl(root, glob))

def gather_globs(tree: list[str], globs: list[str]) -> pl.DataFrame:
    with tempfile.TemporaryDirectory() as root:
        mktree(root, tree)
        return pl.DataFrame(dict(
            globs=globs,
            glob=list(_test_glob_implementation(root, globs, _GlobImplementation.glob)),
            fnmatch=list(_test_glob_implementation(root, globs, _GlobImplementation.fnmatch)),
            globmatch=list(_test_glob_implementation(root, globs, _GlobImplementation.globmatch)),
            globber=list(_test_glob_implementation(root, globs, _GlobImplementation.globber)),
        ))

def _gather_basic():
    tree = [
        "abc/def/ghi/a.txt",
        "abc/def/a.txt",
        "abc/a.txt",
        "abc/c.txt",
        "a.txt",
        "b.txt"
    ]

    globs = [
        "a.txt",
        "*/a.txt",
        "*/*/a.txt",
        "**/a.txt",
        "**/**/a.txt",

        # Path(...).glob() - non-relative paths are unsupported
        #"/a.txt",
        #"/*/a.txt",
        #"/*/*/a.txt",
        #"/**/a.txt",
        #"/**/**/a.txt",

        "abc/a.txt",
        "abc/*/a.txt",
        "abc/*/*/a.txt",
        "abc/**/a.txt",
        "abc/**/**/a.txt",

        "**/*.txt",
    ]

    return gather_globs(tree, globs)

def _gather_hidden():
    tree = [
        ".git/index"
    ]

    globs = [
        "**/index"
    ]

    return gather_globs(tree, globs)

def gather():
   df_basic = _gather_basic()
   df_hidden = _gather_hidden()

   os.makedirs("../data/globmatch", exist_ok=True)
   df_basic.write_csv("../data/globmatch/basic.csv")
   df_hidden.write_csv("../data/globmatch/hidden.csv")

   return [df_basic, df_hidden]

dfs = gather()

fnmatch and globmatch are junk, but globber did well, matching the behavior of Path.glob in my test cases exacltly. Here is a Google sheet with the results (those matching Path.glob highlighted with green):
https://docs.google.com/spreadsheets/d/1M2fcYlW19n1HACQi_MbYgBIMtbopnGur6mVjyNaowqc/

Based on that, I would suggest replacing fnmatch with globber.
globber is not a mature project and is not widely known, but it certainly improves the situation. Given that people haven't discovered that additional globs, basically, just don't work as expected with django-watchfiles, they probably won't have issues with globber either. If / when they do, globber's source code is only some 30 lines, so it should be fairly easy to tweak it if needed: https://github.com/asharov/globber/blob/main/globber/globber.py

Thanks for the detailed research. It's taken me a while to get back to looking at django-watchfiles.

Ideally Python should offer some equivalent to directory.glob(pattern) -> filenames, which would allow one to validate a filename against a glob within a given directory or, to the same extent, to validate a relative path against a glob, something like globmatch(relative_path, glob) -> bool.

Yes, that would be great.
Maybe we can reuse some internals of the glob module, which is what Path.glob() relies on.
I would like to check that before adding a dependency. globber does not look well-maintained, with the last release in 2019.
Perhaps we can copy in the relevant source instead, or find a hybrid where we rely on some internals of glob.


radicale: 2.1.11 -> 3.0.3

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@Valodim This breaks etesync-dav because it is too picky about the radicale version.


Duplicate file name problem

Godot version:

3.1
OS/device including version:

OSX, High Sierra
Issue description:

When you move the resource to the other folder that already exist same named file, there are no overlapping warning message. Because of that I lost my resource file.

Can you write steps to reproduce this problem?
With this info I'm unable to reproduce this.

The warning exists, but doesn't specify what file will be overwritten. Adding the filename to the dialog would be useful.

Above comment is still valid in 3.2.3 rc1


Rank feature - unknown field linear

Description
Add support for rank feature query linear
Issues Resolved
https://github.com/opensearch-project/OpenSearch/issues/977
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check

Much thanks!
@nknize Care to double check for me that this looks right?
@Hronom We need to document this - care to PR or open an issue in https://github.com/opensearch-project/documentation-website please?

@Hronom How do you feel about adding a REST API-level test for this that matches what you described in #977?

@dblock I will try to put some docs on weekends

@dblock I pretty new in this project, can you help me:

@Hronom How do you feel about adding a REST API-level test for this that matches what you described in #977?
Where is this REST API-level tests? Please point me to the class or example of it. I added tests for this feature, but not sure is they API level or not...

@dblock added docs https://github.com/opensearch-project/documentation-website/pull/114

start gradle check

I didn't forget about this, please bear with me. I need to do some homework before this can be merged, related to the fork.

@Hronom Thank you for your contribution! This PR looks very similar to elasticsearch#67438 and elasticsearch#67670. Was your code based off either of those PRs, or was it based on the current master of elasticsearch?

@dblock It's based on that PR's, also it use function provided by core Lucene.

Added fix in exception message for supported functions

start gradle check

start gradle check

Merged, thank you @Hronom. I imagine we want this in 1.1. Could you please open a backport PR into that branch? Thank you.

@dblock created https://github.com/opensearch-project/OpenSearch/pull/1025


Retry streaming read errors in bundle download

Could use some tests and also a warning in the client's streaming API autodoc, but I'm not sure how I would set up a test case, and I'd like to postpone docs until I verify that this works in the download stress tests.

Codecov Report

Merging #98 into master will decrease coverage by 0.07%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage      88%   87.92%   -0.08%
==========================================
  Files          29       29
  Lines         967      969       +2
==========================================
+ Hits          851      852       +1
- Misses        116      117       +1

Impacted Files
Coverage Δ

hca/dss/__init__.py
90.47% <76.92%> (-0.99%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ddfe2...baacc6d. Read the comment docs.


Add go mod and upgrade to use Go 1.17

To build with Go 1.17, we need to add Go module files (go.mod and go.sum).

I think this is overtaken by #3 now, I updated to 1.18 there.

Great. Thanks!


rali_unittests fails to build with HIP backend

rali_unittests app fails to build with the HIP backend.
Throws error:
fatal error: rali_api.h: No such file or directory
#include "rali_api.h"

@paveltc is this a regression? if so, could you please help find the PR that broke the rail_unittests?

@asalmanp I can no longer reproduce this issue on my system with TOT.


How is Azure NetApp Files different from Azure Files?

There's the NFS vs. SMB difference, and the storage pool management, anything else?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 533a34cf-3791-0a45-f9f3-991fb4cf8eb1
Version Independent ID: 8335006a-84b6-700d-03a4-36191da4791a
Content: FAQs About Azure NetApp Files
Content Source: articles/azure-netapp-files/azure-netapp-files-faqs.md
Service: azure-netapp-files
GitHub Login: @b-juche
Microsoft Alias: b-juche

@austindonnelly Thanks for your question. We are checking on this and will respond to you soon.

I myself am not familiar with Azure Files.  Looping in Lichun @lichunli-ms for response.

We could use a good statement about this in CSS as well. Has Lichun's alias changed? @SumanthMarigowda-MSFT please find someone to answer.

#reassign: lichunli-ms

lichunli-ms is not a valid GitHub ID, or is not a collaborator on this repo.

pinging @lichunli-ms for an update.

Pinging @lichunli-ms for an update about this product question.

You can refer to this page to understand the various Azure storage options and the scenario each option is best suited for.

#please-close


BGDIINF_SB-2043: Changed default GET /<shortlink> to redirect and don't validate origin for redirect

Changed the default get_shortlink endpoint behavior, now by default it does a redirect (main purpose of the service). with the redirect query parameter we can still set it to false to return the json instead.
When redirecting the get_shorlink endpoint to the full url we should not
check the origin header. The main purpose of this link is sharing to
people which means that the origin my be not set or be anything.
@procrastinatio This code is currently deployed on DEV and can be tested with mf-geoadmin3

Changed the default get_shortlink endpoint behavior, now by default it does a redirect (main purpose of the service). with the redirect query parameter we can still set it to false to return the json instead.
When redirecting the get_shorlink endpoint to the full url we should not check the origin header. The main purpose of this link is sharing to people which means that the origin my be not set or be anything.
@procrastinatio This code is currently deployed on DEV and can be tested with mf-geoadmin3

@procrastinatio Ooops, I only saw this now. An hour ago or so, I deployed develop.latest on DEV. I will create a new local image and re-deploy on DEV. Will give you a ping, when done (should be around 08.30ish).

@ltshb already did deploy gestern. Work as expected.


Unable to install any gem - SSL issue

I'm on Ubuntu 12.04 and have used linuxbrew to install rbenv.
Installed ruby 2.4.1 but couldn't get any of the gem to install due to the following error:
Unable to pull data from 'https://rubygems.org/':  SSL_CTX_set_ecdh_auto
Tried uninstalling and reinstall ruby 2.4.1 with
CONFIGURE_OPTS="--with-opessl-dir=home/.linuxbrew/bin/openssl" rbenv install 2.4.1
But no luck, the error message changes to:
 Unable to pull data from 'https://rubygems.org/': SSL_CTX_set_ecdh_auto: cert already in hash table
Followed the SSL update guide from RubyGems.org but that didn't help either. My gem version is already the latest - 2.6.11
System Setup:
which rbenv
'home/.linuxbrew/bin/rbenv'
which openssl
'home/.linuxbrew/bin/openssl'
ruby -ropenssl -e 'puts OpenSSL::OPENSSL_VERSION'
OpenSSL 1.0.2k  26 Jan 2017
ruby -ropenssl -e 'p OpenSSL::X509::DEFAULT_CERT_FILE'
"/usr/lib/ssl/cert.pem"
Any help is greatly appreciated!

Same here.

It looks like you're having problems with ruby-build, which is the plugin that provides rbenv-install.

First, ensure that ruby-build is updated to the latest version.
If your problem persists, check existing issues in the ruby-build repo and open a new one if necessary. When opening a new issue, please attach the full build log.


Restangular makes an extra get request to server!

When I make any get request on server, Restangular makes 2 request on API. Below is the code through which I am making request.
function getLevel1Codes() {
var level1Codes = Restangular.all(levelCodeUrl).getList();
return level1Codes;
}
}

Your code is pretty ok. Please provide a plunkr replicating this issue as AFAIK this looks more like implementation error.

In my case this was due to a mistake on my angular app. I had the controller executed twice, once because of a ng-controller tag on the html and once because of routing. I'm just leaving this here in case someone ends up on this issue report (like me)


JSON Repository No SUB Index of type NUMBER

When try to index referenced classed the Library only crete index of type TEXT. NUMBER and TAG seems not present.
Following a basic example.
If you try to map the following class:
@Data
@RequiredArgsConstructor(staticName = "of")
@AllArgsConstructor(access = AccessLevel.PROTECTED)
@Document
public class Company {
    @Id
    private String id;

    @NonNull
    @Searchable
    private String name;

    @Indexed
    @NonNull
    private Integer numberOfEmployees;

    @NonNull
    @Indexed
    private Set<CompanyMeta> metaList;
}

@Data
@RequiredArgsConstructor(staticName = "of")
@Document
public class CompanyMeta {

    @Indexed
    @NonNull
    private String name;

    @Indexed
    @NonNull
    private String value;

    @Indexed
    @NonNull
    private Integer numberOfEmployees;
}

The library creates an index in the following way (copied using the client monitor):
"FT.CREATE" "com.synapseslab.example.redisjson.domain.CompanyIdx" "ON" "JSON" "PREFIX" "1" "com.synapseslab.example.redisjson.domain.Company:" "SCHEMA" "$.name" "AS" "name" "TEXT" "$.numberOfEmployees" "AS" "numberOfEmployees" "NUMERIC" "$.metaList[0:].name" "AS" "metaList_name" "TAG" "SEPARATOR" "|" "$.metaList[0:].value" "AS" "metaList_value" "TAG" "SEPARATOR" "|" "$.id" "AS" "id" "TAG" "SEPARATOR" ","

Need to have also an index like the following:
"$.metaList[0:].numberOfEmployees" AS metalList_numberOfEmployees NUMERIC
Same for type TAG. Seems only the TEXT index is supported.

The one issue I see above is the extra @Document in CompanyMeta, since child/many-to-one objects with Redis JSON are just embedded in the document and not referenced. But, that wouldn't likely cause the issue above. Can you post a full example? I'll play with it tonight and see if I can figure it out. Cheers!

Hello Brian,
thanks for the feedback in attach the full example, it is just a test project made with with Spring Boot.
Anyhow I have to amend my previous. The problem is present only for type NUMBER the type TAG works as expected.
redisjson.zip

Hi Brian,
I download the repo and try to fix it on the example.
In attach the project with the fix.
I'm not sure this is the beast approach but it works.
If needed I can push a branch with the fix.
The mdofication affect the class RedisSearchIndexer
 } else if (subField.isAnnotationPresent(Indexed.class)) {
          boolean subFieldIsTagField = ((subField.isAnnotationPresent(Indexed.class)
              && ((CharSequence.class.isAssignableFrom(subField.getType()) || (subField.getType() == Boolean.class)
                  || (maybeCollectionType.isPresent() && (CharSequence.class.isAssignableFrom(maybeCollectionType.get())
                      || (maybeCollectionType.get() == Boolean.class)))))));
          if (subFieldIsTagField) {
            Indexed indexed = subField.getAnnotation(Indexed.class);
            tempPrefix = field.getName() + "[0:].";

            FieldName fieldName = FieldName.of(fieldPrefix + tempPrefix + subField.getName());
            fieldName = fieldName.as(QueryUtils.searchIndexFieldAliasFor(subField, prefix));

            logger.info(String.format("Creating nested relationships: %s -> %s", field.getName(), subField.getName()));
            fieldList.add(new TagField(fieldName, indexed.separator(), false));
            continue;
          }

          else if (Number.class.isAssignableFrom(subField.getType()) || (subField.getType() == LocalDateTime.class)
              || (subField.getType() == LocalDate.class) || (subField.getType() == Date.class)) {

            FieldName fieldName = FieldName.of(fieldPrefix + tempPrefix + subField.getName());
            fieldName = fieldName.as(QueryUtils.searchIndexFieldAliasFor(subField, prefix));
            logger.info(String.format("Creating nested relationships: %s -> %s", field.getName(), subField.getName()));
            fieldList.add(new Field(fieldName, FieldType.Numeric));
          }
        }

        getNestedField(fieldPrefix + tempPrefix, subField, prefix, fieldList);
}

I added the else if with Number.class checks to line 493.
In the attach there is also the example for the meta subfield.
redis-om-spring.zip

@fr4ncesco this is great. Why don't you send a formal PR, would love to have you as a contributor!

Thanks @fr4ncesco merged and implemented the required repository queries


Add bulk-permissions API

The create-issue-meta API just returns a partial response if you don't
have permission to create issues in that project. It's possible there
are other reasons for that, but we can't really tell without the
GetBulkPermissions API.

@paprikati yeah sorry. Proof is in the running of it: https://github.com/incident-io/core/pull/3423/commits/38fe8299ba9631ab270b8e0c08618893298df979


"Internalizing" external reasoning about monadic actions (SatisfiesM)

I have read the docs on SatisfiesM and appreciate the humility about ergonomics. But my question is not about how annoying something is, but whether it's possible at all.
It's great to be able to reason about Monodic programs externally, so the original program is not given the impossible tax of anticipating all proofs that might be desired in the future and providing them internally. At the same time, if it is only possible to reason externally, then batteries doesn't help us write dependent monadic programs, and just helps us reason post-hoc about "simple" mondic programs. I hope this isn't true.
I was trying to figure out how to "internalize" a SatisfiesM. I was having trouble at first figuring out what exactly that entailed, and in https://leanprover.zulipchat.com/#narrow/channel/113489-new-members/topic/.E2.9C.94.20Proofs.20inside.20monads/near/466762282 I ended up with
def internalizePostCondition
  {m : Type u -> Type u_2}
  [Monad m]
  [LawfulMonad m]
  (action : {action: m t // SatisfiesM p action})
  : m {value: t // p value}
  := sorry

But I am not sure how to prove this; it would seem to require an EvenMoreLawfulMonad. Can anyone point me in the right direction?

#1029 is very relevant to this issue and may close it

Yes I think it closes it!


"One or more of your mining binaries are showing rapid failures (immediately stop after starting)" What to do about this??

Ensure your GPU is supported.


Error loading shm.dll, The specified module could not be found.

(cuda) C:\Users\palam\OneDrive\Desktop\IC light\IC-Light>python gradio_demo.py
Traceback (most recent call last):
File "C:\Users\palam\OneDrive\Desktop\IC light\IC-Light\gradio_demo.py", line 5, in
import torch
File "C:\Users\palam\AppData\Roaming\Python\Python310\site-packages\torch_init_.py", line 141, in
raise err
OSError: [WinError 126] The specified module could not be found. Error loading "C:\Users\palam\AppData\Roaming\Python\Python310\site-packages\torch\lib\shm.dll" or one of its dependencies

+1


Create profile-single-tenant-cluster.md

Signed-off-by: Tasha Drew<EMAIL_ADDRESS>

/lgtm
/approve


Document prisma format

Source for content: https://github.com/prisma/specs/tree/master/cli#format

https://prisma-company.slack.com/archives/CEYCG2MCN/p1599725646184500?thread_ts=1599690957.182600&cid=CEYCG2MCN


Suppress display of pinned tweets

Describe the problem
When browsing user feed, pinned tweets show up every 20 tweets. Some pinned tweets are quite long. Even the short ones become exceedingly tiresome after a short time.
Merci!
Describe the solution
Pinned tweets should, at most, appear as the first tweet on a user feed.
Better yet, an option to disable them entirely would be preferred, perhaps on a per user basis or, if it's easier, globally. I only need to see them once.

bump


Fixissue8126v4branch

Summary
fix #8126
Details and comments
Fix wrong time value in Trotterized unitary #8126.
When Computing a suzuki decomposition of a Hamiltonian for a given time t, if t is a float, everything works fine.
If t is a Parameter object the value gets squared when it is bound.
This is tested with function test_suzuki_trotterization_time_parameter(self).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: BramDo:x: Lennard MalthaLennard Maltha seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Http request header disappeared when I click other item

Describe the bug
I have a header in the http request, and I want to change it. But after I change it, click another form and then click back, the header disappeared

Version

Browser

[x] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
Screenshots

Additional context

addressed via https://github.com/microsoft/BotFramework-Composer/pull/2592


[feature] Consider using native-package-installer if users opt into system libraries

If users choose to use system libraries, it might be good to use https://rubygems.org/gems/native-package-installer/ to help users get up and running without having to find and read the installation docs.
Example usage: https://github.com/rcairo/rcairo/blob/master/ext/cairo/extconf.rb
Please do not conflate this topic with the topic of whether to default to system libraries or packaged libraries.

An example of where this might be useful: xz is required for the new libxml2/libxslt tarballs (https://github.com/sparklemotion/nokogiri/issues/2466).
One thought is that maybe we should push some of this upstream into MiniPortile (for things like git, patch,  tar, etc.) and then the extension can focus on extension-specific things (libmagick, etc.)

Closing this because

it feels less relevant now that the precompiled gems are widely used
there haven't been any user requests for functionality like this in the past few years

If someone wants to pick this up, I'd be happy to consult/support/help in any way I can.


Create game and author

Hello @yusufyusie and @ishimwepati
-I implemented the game and author class and their properties
-Added unit tests
-Preserve data into json file
-Read data from the json file

Hello @MayPyone  your project is complete!
You can move on the next project!


STM32 Dual core support?

Hi @MaJerle ,
I would like to port a project to vcode from a STM32H745 (dual core M7 and M4). I am kinda of vscode fan
I have been looking now for some time, I read that it should be possible to debug both cores with the https://marketplace.visualstudio.com/items?itemName=marus25.cortex-debug extension. But so far no example on-line.
Do you believe  with you method would be possible to make it work for a dual core system?
Did you came further with the python script for dual cores ?
My Project works fine under STM32CubeIDE for both cores (can flash and debug without much hassle).

HI @MaJerle ,
thanks for your fast reply. I will give it a go. will keep you posted once I got something .


If one addon fails to compile this stops working

If an addon fails to compile, this mod loader throws a file not found error for the dll and ceases to function. It should be able to handle such problems more gracefully.

Sorry for the late response, but this is already fixed for the 0.4 version.
https://github.com/Erdroy/Stationeers.Addons/blob/plugin-compilation-diagnostics/Source/Stationeers.Addons/Modules/Plugins/PluginCompilerModule.cs#L185
But yeah, thanks!


[Bug]: GSheet | Query page options take a lot of time to load

Is there an existing issue for this?

[X] I have searched the existing issues

Description
https://www.loom.com/share/1d051742c9d94960a634955a1cd260b6
When we try to create a new API for a Gsheet, the drop-downs take a lot of time to load and sometime we get the below error:

Note:

This is prevalent only on Release and not on Prod.
Tried the same in an incognito window but no success there as well.
Using a Mac machine.
Prevalent on Chrome & Firefox

Steps To Reproduce

Go to any application in Release.
Add a GSheet as a datasource.
Click on New API.

Public Sample App
No response
Version
Cloud

Unable to use exsisting app using gsheet https://www.loom.com/share/aa5b9bdd71894287a208504c2922354d https://release-ee-https.appsmith.com/applications/62ac1622d03dbf1d461f6ca1/pages/62ac1622d03dbf1d461f6cad/edit/saas/google-sheets-plugin/api/62ac1622d03dbf1d461f6cb6

It is supposed to be closed via https://github.com/appsmithorg/appsmith/pull/16565


Include licenses in the final bosh tarball.

Because there is no proper attribution of the vendored dependencies,
use a wildcard to keep all licenses in place.

Part of HPE and so I should be part of the corporate CLA. Adjusted my organization privacy settings so hopefully the next PR's will automatically be verified.


Delay killing sidecars until artifacts are saved

Supports service meshes such as Istio where all traffic is routed
through the sidecar.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


rust: update to 1.54 (7)

Motivation

Codebase wide cleanup, to match idiomatic rust construct
Removed following rules from clippy allow list of x.toml, instead of blanket allow, only used code level allows.

"clippy::self-named-constructors",
"clippy::unnecessary-to-owned",
"clippy::large-enum-variant"

Removed unnecessary address-of operator
Converted eager executions into lazy (ex. ok_or to ok_or_else)
Reduced unnecessary conversions
Simplified If stmts.

Testplan

CI test execution will cover updated code changes.

/canary

:sunny: Canary successful

/land


Remediation Tasks naming

Prerequisites

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed

Context
I have a question about timestamp in name for remeditation tasks.
In what cases they would not be created? I can't understand it.
Now on every apply all remeditation tasks are always recreated.

Hi @gettek
Thanks for explanation. I think it should help in my pipeline.
I checked that the variable skip_remediation is only defined in module set_assignment but not used there. Maybe you missed it in this module?

Hi @pmalczuk,
Yes you're correct, I noticed it was missing also a few days ago and was wrongly removed in version 2.2.0 but will create a fix for the upcoming release in a few days.

I just ran into this as well (skip_remediation not implemented).  Will try the 2.6.0 version....

so it seems to work, although when NOT skipping remediation tasks, I think it's creating them for policies that don't have DINE/modify effects.  For example, in my initiative I have a policy with a deny effect, and a remediation task is being created for it.

thanks @timwebster9 have added that fix to 2.6.0 now

@gettek I updated set_assignment/variables.tf with your latest changes, and it still creates remediation tasks for 'deny' policies...

Apologies, I will devote some time to this over the coming days, planning to also implement a parameter to change remediation_scope


Remove forgot password link

django-allauth now provides its own Forgot Password link as a form help text.

This partly addresses #79.


mpmath structure

The mpmath library can be a good tool to improve the precision. This issue is to check this.

Now we use numpy.ndarray with 64float or 128float. This idea is change to list with mpf type (that we can change the precision), as it is not possible to represent mpf in a numpy it loses efficiency.

Testing different frameworks using richardson's method and testing with the basel problem


Cron backup

Context

Adds supercronic for scheduled backups
Will make it easier to implement #187 & #37
Sets a backup for everyday at 12:00am (Based on TZ set)
Continuing the work of @GuillaumeBarreau from #101
Addressing #39

Choices

Set as default to prevent issues like #183, Although I think it should be ran hourly but I will wait until #188 as to not eat up storage.
Using supercronic instead of cron since cron is not able to use environmental variables and it outputs to terminal
palworld-server-test  | time="2024-01-28T17:33:00-05:00" level=info msg=starting iteration=0 job.command="bash /usr/local/bin/backup" job.position=0 job.schedule="* * * * *"

Test instructions

Set BACKUP_CRON_EXPRESSION to * * * * * to backup every minute to reduce waiting while testing
Verify backups are being made every minute
Verify supercronic starts as steam: docker exec -it palworld-server bash -c "top -n 1 | grep supercronic | grep --color steam"

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I've added documentation about this change to the README.
[x] I've not introduced breaking changes.

Nice work! Will test tonight, after https://github.com/thijsvanloef/palworld-server-docker/pull/188 is merged


feat: add browser deployment logic

feat: add browser deployment logic
Fix: https://github.com/bestchains/installer/issues/54

@0xff-dev please update the README.md


Ray casts against parallel segments return intersection

Ray casts against segments with ray direction parallel to the segment return an intersection with toi = 0.0 instead of None.
This was reported in #178 and allegedly fixed in #196 but still exists.
use nalgebra::{Isometry2, Point2, Vector2};
use ncollide2d::{
    query::{Ray, RayCast},
    shape::Segment,
};

#[test]
fn test_ray_parallel_to_segment() {
    let segment = Segment::new(Point2::new(1.0, 2.0), Point2::new(1.0, -2.0));
    let ray = Ray::new(Point2::new(0.0, 0.0), Vector2::new(0.0, -1.0));
    let toi = segment.toi_with_ray(&Isometry2::identity(), &ray, true);
    assert!(toi.is_none());
}

Thank you for reporting this. This is a regression due to the addition of a specialized ray-cast on 2D segment. This will be fixed today.

It appears that ncollide's test are not run at all by the CI. This explains why we did not see this regression coming. I will fix the CI at the same time as this issue.


Cherry pick Update parquet module documentation to reflect correct SerializedFileReader location to active_release

Automatic cherry-pick of 67af0d0

Originally appeared in https://github.com/apache/arrow-rs/pull/909: Update parquet module documentation to reflect correct SerializedFileReader location

Codecov Report

Merging #919 (fc37fdb) into active_release (03d95e6) will decrease coverage by 0.14%.
The diff coverage is n/a.

:exclamation: Current head fc37fdb differs from pull request most recent head ea0d904. Consider uploading reports for the commit ea0d904 to get more accurate results

@@                Coverage Diff                 @@
##           active_release     #919      +/-   ##
==================================================
- Coverage           82.45%   82.31%   -0.15%
==================================================
  Files                 168      168
  Lines               48175    48091      -84
==================================================
- Hits                39725    39588     -137
- Misses               8450     8503      +53

Impacted Files
Coverage Δ

arrow/src/array/transform/fixed_binary.rs
75.00% <0.00%> (-3.95%)
:arrow_down:

parquet/src/schema/visitor.rs
67.10% <0.00%> (-2.64%)
:arrow_down:

arrow/src/compute/kernels/cast_utils.rs
87.50% <0.00%> (-2.50%)
:arrow_down:

parquet/src/encodings/decoding.rs
90.45% <0.00%> (-2.02%)
:arrow_down:

arrow/src/datatypes/ffi.rs
70.85% <0.00%> (-2.02%)
:arrow_down:

parquet/src/arrow/arrow_reader.rs
89.32% <0.00%> (-1.95%)
:arrow_down:

arrow/src/ffi.rs
84.69% <0.00%> (-1.89%)
:arrow_down:

arrow/src/csv/reader.rs
90.00% <0.00%> (-1.78%)
:arrow_down:

arrow/src/util/data_gen.rs
75.44% <0.00%> (-1.66%)
:arrow_down:

parquet/src/schema/parser.rs
85.32% <0.00%> (-1.05%)
:arrow_down:

... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d95e6...ea0d904. Read the comment docs.


User authentication of collectors with respective tools

How does Hygieia collectors connect with their respective tools?
What kind of authentication mechanism is used?
For example - While setting a collector for Bitbucket/Jenkins, we put user name and password. How BitBucket/Jenkins rest api authenticate those credentials?

@prasadyash Check the collectors readme markdown files for examples of property settings.


[SUGGESTION] working on a better english documentation

I have recently found hyperf and have been working with the framework for some time..
this is a great tool that can have richer documentation and ecosystem. I will be glad to co-operate as developer / document maintainer in this project. with more technical documentation and more example within it, more newcomers can join and use this great tool.
in comparison to laravel, hyperf has great performance..
but it's been hard for me to configure most of its advanced features likes gRPC server.
and believe me when I say there is no English article out there about this stuff.
I declare my readiness, to work along.

The development team is currently all Chinese, so the English documentation is a bit behind, feel free to submit PRs.

I am finding a way that to translate Chinese doc to any other languages' doc automatically by Google translator. But it can not recognize the markdown and may confuse code with text.
I believe that continuously optimizing documents based on the results of machine translation is an easier way for us.
Just to set the ball rolling here.

I am finding a way that to translate Chinese doc to any other languages' doc automatically by Google translator. But it can not recognize the markdown and may confuse code with text. I believe that continuously optimizing documents based on the results of machine translation is an easier way for us. Just to set the ball rolling here.

I'm willing to write English articles and co-operate wherever it's needed.
if people have a way to connect and understand, hyperf will be more known and appreciated.

The development team is currently all Chinese, so the English documentation is a bit behind, feel free to submit PRs.

that is the issue.. as a developer, I need a little bit of co-operation for understanding some sections.

I did the Kafka doc using Google's Translate from the Chinese doc, exactly how @twose suggested: https://github.com/hyperf/hyperf/blob/master/docs/en/kafka.md
You can start from that then refine the parts that the automatic translation didn't work well.
Unfortunately I haven't PR more translations because of the lack of time, but I thing is a good way to go.

I am finding a way that to translate Chinese doc to any other languages' doc automatically by Google translator. But it can not recognize the markdown and may confuse code with text. I believe that continuously optimizing documents based on the results of machine translation is an easier way for us. Just to set the ball rolling here.

机翻的效果应该不咋地吧(不过比某度肯定好不少),这位国外大神愿意加入人工翻译大军,可以让他多PR一点,哈哈

Hi, I have also started using this great framework and I can contribute to translate it using google translate. I don't understand chinese but the english text seems to make sense, at least for me, not english native speaker  :-). I will send a PR soon with the docs translated. Now I'm working with metrics doc.

I have translated most of the missing english docs using Google Translate. This is the PR: https://github.com/hyperf/hyperf/pull/4472. I think that the result looks good.

If only we could apply the same methods to the issue tracker! 😂


Less not compatible with V2.3

After packing, run and find that style is not compressed

did you try npm install -D less less-loader ?

@andylei18 did you've tried that? The less loader does not come by default installed.
Also you need to add
<style lang="less"> in your code

@valentinvieriu I did it long ago, but it's the same

@john-ko That's what I did, but it turned out that way


Support for CH347 based host

What kind of new feature are you looking for?

Hardware: Support for CH347 based hosts such as https://www.waveshare.com/wiki/USB_TO_UART/I2C/SPI/JTAG
Software: Windows mostly but could check on other OS

Do you plan to:

Contribute an initial driver: Maybe
Write unit tests: No

To clarify, it's a request for support for https://www.wch-ic.com/products/CH347.html


Architecture Error running on Raspberry Pi 4

Error:
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
standard_init_linux.go:228: exec user process caused: exec format error

Command:
docker run -it --env-file ./BingRewards.env --restart unless-stopped --name bing-rewards nelsondane/bing-rewards:latest

Hello, thanks for your interest in the bot! Unfortunately Raspberry Pi's don't support Google Chrome, which is what the bot uses at the moment. Perhaps in the future we'll add some variations for other architectures

Hello, thanks for your interest in the bot! Unfortunately Raspberry Pi's don't support Google Chrome, which is what the bot uses at the moment. Perhaps in the future we'll add some variations for other architectures

Ah I see. I've had issues in the past with Google Chrome on Raspberry Pis. Is there a reason this couldn't run on Chromium though? From my experience, the only time I needed Google Chrome over Chromium was for the mp4 codecs which Chromium doesn't have. If the bot doesn't rely on that I'd like to give Chromium a swing!

Hello, thanks for your interest in the bot! Unfortunately Raspberry Pi's don't support Google Chrome, which is what the bot uses at the moment. Perhaps in the future we'll add some variations for other architectures

Ah I see. I've had issues in the past with Google Chrome on Raspberry Pis. Is there a reason this couldn't run on Chromium though? From my experience, the only time I needed Google Chrome over Chromium was for the mp4 codecs which Chromium doesn't have. If the bot doesn't rely on that I'd like to give Chromium a swing!

You're right that the bot doesn't require Google Chrome over Chromium, so I've pushed an update to nelsondane/bing-rewards:beta that (hopefully) uses Chromium if the architecture arm64 is detected. I don't have a device to test it with currently, but if you could give it a try that would be much appreciated!

Hello, thanks for your interest in the bot! Unfortunately Raspberry Pi's don't support Google Chrome, which is what the bot uses at the moment. Perhaps in the future we'll add some variations for other architectures

Ah I see. I've had issues in the past with Google Chrome on Raspberry Pis. Is there a reason this couldn't run on Chromium though? From my experience, the only time I needed Google Chrome over Chromium was for the mp4 codecs which Chromium doesn't have. If the bot doesn't rely on that I'd like to give Chromium a swing!

You're right that the bot doesn't require Google Chrome over Chromium, so I've pushed an update to nelsondane/bing-rewards:beta that (hopefully) uses Chromium if the architecture arm64 is detected. I don't have a device to test it with currently, but if you could give it a try that would be much appreciated!

Cool, Thanks! I'll try it and get back to you

Hello, thanks for your interest in the bot! Unfortunately Raspberry Pi's don't support Google Chrome, which is what the bot uses at the moment. Perhaps in the future we'll add some variations for other architectures

Ah I see. I've had issues in the past with Google Chrome on Raspberry Pis. Is there a reason this couldn't run on Chromium though? From my experience, the only time I needed Google Chrome over Chromium was for the mp4 codecs which Chromium doesn't have. If the bot doesn't rely on that I'd like to give Chromium a swing!

You're right that the bot doesn't require Google Chrome over Chromium, so I've pushed an update to nelsondane/bing-rewards:beta that (hopefully) uses Chromium if the architecture arm64 is detected. I don't have a device to test it with currently, but if you could give it a try that would be much appreciated!

I see that you just pushed to DockerHub which initially got it up and running. Still, it looks like after it downloads chromedriver it crashes because chromedriver is the wrong architecture?
rm: cannot remove '/tmp/.X99-lock': No such file or directory
Starting X virtual framebuffer (Xvfb) in background...
Starting Bing Rewards Bot...
Current IPv4 Address: [Redacted]
Unable to get IPv6 address

Starting Bing Rewards Automation:       2022-10-16 14:25:00.488836-04:00

[WDM] - Downloading: 100%|██████████████████████████████████████████████████████████████████████████████████████████| 6.35M/6.35M [00:00<00:00, 14.1MB/s]

Traceback (most recent call last):
  File "/app/main.py", line 635, in getDriver
    driver = webdriver.Chrome(
  File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/chrome/webdriver.py", line 69, in __init__
    super().__init__(DesiredCapabilities.CHROME['browserName'], "goog",
  File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/chromium/webdriver.py", line 89, in __init__
    self.service.start()
  File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/common/service.py", line 71, in start
    self.process = subprocess.Popen(cmd, env=self.env,
  File "/usr/lib/python3.10/subprocess.py", line 969, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.10/subprocess.py", line 1845, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
OSError: [Errno 8] Exec format error: '/root/.wdm/drivers/chromedriver/linux64/106.0.5249/chromedriver'

Similar thing...
Starting Bing Rewards Automation:       2022-10-16 21:28:02.279277+02:00

Traceback (most recent call last):
  File "/app/main.py", line 638, in getDriver
    driver = webdriver.Chrome(
  File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/chrome/webdriver.py", line 69, in __init__
    super().__init__(DesiredCapabilities.CHROME['browserName'], "goog",
  File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/chromium/webdriver.py", line 89, in __init__
    self.service.start()
  File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/common/service.py", line 98, in start
    self.assert_process_still_running()
  File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/common/service.py", line 110, in assert_process_still_running
    raise WebDriverException(
selenium.common.exceptions.WebDriverException: Message: Service /root/.wdm/drivers/chromedriver/linux64/106.0.5249/chromedriver unexpectedly exited. Status code was: 255

Hello there!
We've just added support for Edge and Firefox. Please try running the bot with HANDLE_DRIVER set as True and BROWSER set to edge or firefox.

Unfortunately, we are unable to confidently implement a solution for this issue as the none of the active collaborators of this repository possess or have access to a Raspberry Pi to test with. Should that change sometime into the future, we will consider adding that support.

I understand. I'll do a little digging and let you know if I find anything :)

@Prem-ium I have ARM device, could test the images if you want!?

 File "main.py", line 339, in get_driver     driver = webdriver.Firefox(   File "/root/br/BingRewards/venv/lib/python3.8/site-packages/selenium/webdriver/firefox/webdriver.py", line 68, in __init__     super().__init__(command_executor=executor, options=self.options)   File "/root/br/BingRewards/venv/lib/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 206, in __init__     self.start_session(capabilities)   File "/root/br/BingRewards/venv/lib/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 291, in start_session     response = self.execute(Command.NEW_SESSION, caps)["value"]   File "/root/br/BingRewards/venv/lib/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 346, in execute     self.error_handler.check_response(response)   File "/root/br/BingRewards/venv/lib/python3.8/site-packages/selenium/webdriver/remote/errorhandler.py", line 245, in check_response     raise exception_class(message, screen, stacktrace) selenium.common.exceptions.SessionNotCreatedException: Message: Expected browser binary location, but unable to find binary in default location, no 'moz:firefoxOptions.binary' capability provided, and no binary flag set on the command line


Allow line specific word wrap toggling

VSCode is becoming the de facto markdown editor for most devs, but it's wildly jarring to have some of the wider markdown elements be wrapped, including lists (see #164267) and tables (this issue).
If the editor is too thin, the following table's markdown wraps across lines, and the raw md is awful.

Folder Name
Location
Description

My Space
~\My Space
The root of my folder

Games
~\My Space\Games
All the games and symlinks to game installations

The raw text of this table when in an editor pane of width 75 looks like the following:
1   | Folder Name | Location         |
    Description                                      |
2   | ----------- | ---------------- |
    ------------------------------------------------ |
3   | My Space    | ~\My Space       | The root of **my**
    folder                        |
4   | Games       | ~\My Space\Games | All the games and symlinks to game
    installations |

Similar to how VSCode has the ability to highlight rows and fold them, it would be nice if I could highlight rows and tell VSCode to not wrap the text. When I scroll left/right all the wrapped lines should remain in place, with all the non-wrapped lines scrolling appropriately.
Similar to language aware word wrapping.

A different approach to the problem you're describing would be to detect which lines are for lists and tables and do this automatically instead of making users do it themselves. Less work for the user, and less bookkeeping insanity work for VS Code that way I'd imagine.
Related on Stack Overflow: How can I switch off word wrap for parts of a markdown file in VS Code / VSCodium?

The exact same issue exists for restructured text  (.rst) files.


Fix all typos in one go

Describe the feature request
We don't want to accept hundreds of small typo PRs, instead we'd like to fix everything in one go, and then continue to prevent typos with our CICD.
We have a CICD job in typos.yml which does this. However, in order to integrate the job quickly, we decided to ignore a bunch of files, which you can see here in _typos.toml.
This issue is super easy! What you have to do is this:

Install typos
Start removing all things from the _typos.toml, except keep the ones where we won't care about typos. These are: CHANGELOG.md, automata-attestation, and third-party. Everything else we should remove!
After removing those (I would recommend removing one at a time), use the typos cli tool you installed, to find the typos, review them carefully, and then apply the fixes. The tool should apply them automatically, by the way!

Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

hello @momodaka as you said you are interested in contributing, i will assign you to this issue. if you have any questions please feel free to leave them here, otherwise we'll review the PR once it's ready. thanks a bunch! 🍻

hello @momodaka as you said you are interested in contributing, i will assign you to this issue. if you have any questions please feel free to leave them here, otherwise we'll review the PR once it's ready. thanks a bunch! 🍻

I can take this issue.

hello @momodaka as you said you are interested in contributing, i will assign you to this issue. if you have any questions please feel free to leave them here, otherwise we'll review the PR once it's ready. thanks a bunch! 🍻

Let me do it 🍻

thank you @ariesjia for your commitment. @momodaka asked first however on another PR.
if there is a particular field / area of work you are interested in, I can try to come up with another issue. thanks

I can correct capitalization, punctuation, and grammar throughout the documentation. Also, I can clarify wording for better understanding and standardize formatting for consistency if desired. Fixing typos is nice but there are also other issues with the docs I've noticed. I have experience with writing technical documentation in my private GitHub environment.

Nice proposal

This is overall a solid copy

Wagmi!

wen token launch ?/

wen token launch ?/

https://twitter.com/wenwencoin

Hi @d1onys1us, If there is more to be done as a "good first issue" I'm available to help

what kind of stuff do you like to work on or want to do? that will help narrow things down. thankx


PP-2688 Merchant details CSS changes

WHAT
Use display: block to display the merchant details name and address on two lines when address line 2 is not provided.
with @jonheslop

Closing this one, because Jenkins and GitHub integration is having problems


Fix type mutation upon compound assignment

Fixes #53700
MPR in https://github.com/godotengine/godot/issues/53700#issuecomment-954263842:
var v_int : int = 3
var v_float : float = 5.5
v_int += v_float
prints("value:", v_int, "type:", typeof(v_int)) # value: 8.5 type: 3

Old output:
value: 8.5 type: 3

New output:
value: 8 type: 2

Note: For subscript compound assignments, while these changes make the situation better by preventing this bug from happening in the future, it's currently still not possible to do my_int_array[0] += my_float due to the error Attempted to set a variable of type 'float' into a TypedArray of type 'int'. There doesn't seem to be any conversion logic implemented for that case.
Also, I think it would be better for the analyzer to set AssignmentNode::use_conversion_assign even for builtins, so that most of the conversion-related code in write_assign and write_assign_with_conversion can be deduplicated (to remain in write_assign_with_conversion only).

Thanks!


Project has no license in the META file

See https://design.perl6.org/S22.html#license for details on this field. Thanks :)

LICENSE has been added


Assets can't roundtrip properly with v2.3.2 (works in 2.3.1) java.io.FileNotFoundException: This file can not be opened as a file descriptor; it is probably compressed

Information

Apktool Version (apktool -version) - 2.3.2
Operating System (Mac, Linux, Windows) - Mac
APK From? (Playstore, ROM, Other) - Other, a sample on Github: https://github.com/minsko/netsi

Stacktrace/Logcat
04-26 11:06:45.960 14206 14206 W System.err: java.io.FileNotFoundException: This file can not be opened as a file descriptor; it is probably compressed
04-26 11:06:45.960 14206 14206 W System.err: 	at android.content.res.AssetManager.openAssetFd(Native Method)
04-26 11:06:45.960 14206 14206 W System.err: 	at android.content.res.AssetManager.openFd(AssetManager.java:352)
04-26 11:06:45.960 14206 14206 W System.err: 	at com.mattinsko.netsi.MainActivity.onCreate(MainActivity.java:27)

Steps to Reproduce

apktool decode
apktool build

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
no
APK
If this APK can be freely shared, please upload/attach a link to it.
The sample can be built from https://github.com/minsko/netsi.
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? yes
If you are trying to install a modified apk, did you resign it? Not modifed, but yes signed.
Are you using the latest apktool version? Yes.  It works in the previous 2.3.1 version.

Duplicate of regression - https://github.com/iBotPeaches/Apktool/issues/1769, will have binaries up later today. Hotfix (2.3.3)

Sorry for the duplication.  I should have searched more diligently through the issues.


Set up Google and Facebook Log Ins

Set up log-in functionality for Facebook and Google.

[ ] Done When a user can log in using their Google Account.
[ ] Done When a user can log in using their Facebook Account.

Note: Updates for this will be made in the transcript_editor_deploy script. Also, the code from NYPL for logging in with Facebook does not work (verified here: http://transcribe.oralhistory.nypl.org/). Will limit to to just Google log-in for now.


Adding typedocs to gitignore

and removing docs, as a follow up on https://github.com/playcanvas/engine/pull/6132

This is not needed after https://github.com/playcanvas/engine/pull/6132

The build doesn't generate a typedocs folder any more. It just generates a docs folder (the default for TypeDoc).


NetBeans ignores module path in VM Options

I followed the instructions on how to set up a JavaFX project in NetBeans (Non-modular from IDE) https://openjfx.io/openjfx-docs/#IDE-NetBeans, but running the program did not work.
I added a global library, and added the JavaFX jar files as described in the guide. I then created a new project and added the global library to the compile classpath, and set the VM Options to the module path on my system --module-path /usr/share/openjfx/lib/ --add-modules javafx.controls.
When running the program I got the error message java.lang.module.FindException: Module javafx.controls not found. It seems that NetBeans ignores the option --module-path in Project Settings / Run / VM Options. Instead, I added the JavaFX global library under Project Options / Libraries / Run / Modulepath, and only the option --add-modules javafx.controls to VM Options. Doing so makes the program compile and run just fine.
I tried it both on Linux and Windows, and got the same error message and same solution. NetBeans 11.2, JDK 13, several different versions of openjfx.
When compiling and running the hello world JavaFX project from the command line with javac and java directly, --module-path works just fine, so it does not seem to be a problem with my installation.
Maybe you want to update the instructions in the guide.

This worked for me, thank you!

Take a look on [solution]https://github.com/openjfx/openjfx-docs/issues/115]. It works.


Feature request: Axis label spaning only a subset of subplots

This is a feature request as I have been unable to find a working solution right now. In short, I would like to see the option of label spaning for only some rows/columns.
For example, I have a plot with three rows and I would like the y label to span the first two rows (as they have the same y axis) but keep a different/unique y label for the last row.
And the same would go for x labels as well of course.

Makes sense, esp. in the context of #200. We should be able to both restrict spanning labels and shared labels to specific row/column groups with a few subplots() keyword arguments.


Add builder transaction status API

Closes https://github.com/EspressoSystems/marketplace-builder-core/issues/175

This PR:

Added an enum TransactionStatus to track status of each transactions.
Added API to claim transaction status.

This PR does not:

Added offset for status Sequenced as it's not a priority for now.

Key places to review:

Closes EspressoSystems/marketplace-builder-core#175

We probably don't want to use closes here since we'll need other followup PRs to complete this issue. Maybe replace "Closes" with another word indicating the relationship without the auto closing setting.


Team update - Jun 15, 2022

This is a @Quansight-Labs/czi-a11y-grant team sync 🎉🎉🎉! This is a way for the Team Members to provide status reports on what they've been up to this week and request help and attention for things they are working on. This issue will be closed at the end of the day.
Copy and paste the template below, and answer questions as you wish!

Response Template
**Thanks I'd like to give 🙌**
- So-and-so helped me out a lot with foo...

**Updates from last week :heavy_check_mark:**
- I worked towards deliverable: <link-to-deliverable>

**Challenges I faced and things I'd like assistance with 🙏**
- I had a hard time figuring out ...

**My availability for next week**
- I'll be off on foo day...

**Important items for discussion 💬**
- I have a question about goal <link-to-goal>
- Can @foo give a comment on issue #NN ?
- I opened #NN for discussion, please chime in
- I need to discuss foo

:mag: Needs Triage
The Needs Triage issues require an initial assessment and labeling.
No issues need triage! 🎉
:dart: Project boards
Please make sure the boards reflect the current status of the project.
Jupyter a11y grant project

I'm taking a break from grant work from this check-in to next check-in to work on the new Quansight website, specifically setting up GitHub workflows in the website repo to automate some of the quality assurance tasks (including some accessibility checks).
Updates from last week :heavy_check_mark:

Since the last check-in, I've spent most of my time updating Tony's PR

My availability for next week

Available all next week.

Important items for discussion 💬

Tony's "PRFD" pull request for discussion about using JupyterLab cookie cutter to bundle Python and Node in a more jovyan way

Thanks I'd like to give 🙌
Updates from last week :heavy_check_mark:

Rendered notebook (like nbviewer) user testing script. Work in progress script focused on navigation and interaction feedback needs, as well as a collection of possible notebooks for testing.
Got feedback on some of the open PRs and the JupyterLab accessibility meeting. I need to make some changes based on the feedback.

(Isabela needs to make issues for this)
Challenges I faced and things I'd like assistance with 🙏

I think I'm okay at the moment. Just scrambling through tasks.

My availability for next week

I'll be out of office June 16 to 24.

Important items for discussion 💬


Bring DSL to JVM version

We added a world creation DSL to the KMP version (next branch). I think it makes sense to also align that with the JVM version.
@jobe-m : I was thinking of also introducing a world DSL function instead of using the World constructor meaning that we write something like:
world {
  systems {
    add<Sys1>()
    add<Sys2>()
  }

  injectables {
    add("42")
    add(eventMgr)
  }
}

It is a minor detail but I see two benefits:

since everything is lower case in the current DSL it makes sense to also have the world in lowercase
when using Box2D we have a nameclash since Box2D also calls its "core object" World. You have to be careful when importing to choose the correct World. When we have a unique world DSL function and a private constructor then this nameclash is avoided and importing the wrong World, at least in that scenario, cannot happen anymore

What do you think? I can add this small adjustment to the next branch as well of course!

I fully agree. In Korge there is also Box2D integrated.


/watch has been deprecated, use ?watch=true

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @hzxuzhonghu. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @zackbutcher

/ok-to-test

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kindly ping @zackbutcher

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu, ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [ZackButcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ZackButcher can you re-tag lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gyliu513, ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [ZackButcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simple

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simple

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
2b5f9faf1e46fb62845d5f040389d87ef015292e
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Improve expired authentication handling

The current logic for handling expired authentication is quite simple and should be improved to possibly support ether an authentication url and/or authentication callback supplied by the client.

Addressed in Pr #9


Upgrade Kotlin code for null safety

Looks like the Kotlin code is not null safe in all places

Thanks for your attention. I will improve this work in the near future.

Thanks for your attention. I will improve this work in the near future.

I know it's an open source project, and I understand if you are busy, I wish I had more time to contribute.

Thank you very much for your understanding, I would be very grateful if I could receive your pr. Because that would be the first pr I received.
In addition, I have reinstalled the development environment to try to improve the whole plugin, such as using English comments and providing better examples.

I won't have time to craft a PR in the near future unfortunately. I also had trouble with the IDE, that's the partial reason I opened the other issue errornously.


AVD Add-On: ensure app groups from different locations are added to the same workspace

The app groups and workspaces need to be in the same region.


Added max-fetch note to InfluxDB Enterprise config doc, updated formatting

I commented out the max-fetch AE setting with the expectation that it will return in a future version of InfluxDB enterprise.


Broken build!

testBasicTrajectoryGenerationException has failed, resulting in a broken build!
Gradle build scan
Travis CI build
Unfortunately, since this failure occurred in a Travis build, there doesn't seem to be a way to recover the log files for TestHelper to replicate the failure... Perhaps add something in TestLogger that prints to stdout?

Commit a641f08 addresses the issue of the lost test logs by printing out all logs to stdout when building on Travis CI only.

Fortunately, the failing test was able to be reproduced:
test-logs.zip

Fixed in c34c5f5.


Feat: A CLI command to print the name of the physical table for a model

Adding a new CLI command to help figure out the name of the physical table given a model name. The local model snapshot is used for this purpose.

can you add notebook?

@tobymao what's the use case for it? Can't notebook call the context method directly?

we try to mimic all cli commands as magics, do we want to change that?

@tobymao added the magic

@izeigerman Can you also add tests for both CLI and magics?
https://github.com/TobikoData/sqlmesh/blob/2fd6721594dc3f7dc2cfafe57384d23943d8817b/tests/cli/test_cli.py
https://github.com/TobikoData/sqlmesh/blob/2fd6721594dc3f7dc2cfafe57384d23943d8817b/tests/integrations/jupyter/test_magics.py

@eakmanrq added tests, thanks


bad behaviour with double quotes and ! character on option

python --version
Python 3.5.2
click (6.6) and 6.7
Without quotes functions cleanly
python double_quote_spike.py --note hi!
hi!

Single quotes functions cleanly
python double_quote_spike.py --note 'hi!'
hi!

Double quotes generates error
python double_quote_spike.py --note "hi!"
-bash: !": event not found

double_quote_spike.py gist

That error is from bash, it has nothing to do with Click.


fix: update toolchain to nightly to fix failing bench builds

running benches:
cargo test --release -- --nocapture bench_msm

is currently failing to build:
error: package `clap_builder v4.5.0` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.73.0-nightly
Either upgrade to rustc 1.74 or newer, or use
cargo update -p<EMAIL_ADDRESS>--precise ver
where `ver` is the latest version of `clap_builder` supporting rustc 1.73.0-nightly

PR simply updates to nightly in rust-toolchain

Thanks - not pinning a nightly version likely leads to problems down the line. Do you know what dependency is importing clap? It seems to be a consistent source of problems, so it'd be preferable to remove it if possible.
Otherwise, we can re-pin the rust toolchain to a newer nightly.

Do you know what dependency is importing clap?

Its coming in from [Criterion v0.5.1](https://crates.io/crates/criterion) which is the latest version:
[dev-dependencies]
├── criterion v0.5.1
│   ├── anes v0.1.6
│   ├── cast v0.3.0
│   ├── ciborium v0.2.2
│   │   ├── ciborium-io v0.2.2
│   │   ├── ciborium-ll v0.2.2
│   │   │   ├── ciborium-io v0.2.2
│   │   │   └── half v2.3.1
│   │   │       └── cfg-if v1.0.0
│   │   └── serde v1.0.196 (*)
│   ├── clap v4.5.0
│   │   └── clap_builder v4.5.0
│   │       ├── anstyle v1.0.6
│   │       └── clap_lex v0.7.0

These features are identified as requiring nightly FYI:
#![feature(slice_group_by)]
#![feature(trait_alias)]
#![feature(slice_group_by)]

Ah got it, can you change the rust-toolchain to specify a date so we can pin it, and then also pin the criterion version with =0.5.1 so hopefully future updates don't break things again? Thanks!

Ah got it, can you change the rust-toolchain to specify a date so we can pin it, and then also pin the criterion version with =0.5.1 so hopefully future updates don't break things again? Thanks!

Criterion version appears pinned already. PR pins nightly as of today.

@drcapybara maybe we can just add clap as a dev dependency and pin the version to something before 4.5.0


What is the minimal required config?

Before I start guessing, is it fine to have config like
var HardSourceWebpackPlugin = require('hard-source-webpack-plugin');

module.exports = {
  context: // ...
  entry: // ...
  output: // ...
  plugins: [
    new HardSourceWebpackPlugin({
      cacheDirectory: 'path/to/cache/[confighash]',
      recordsPath: 'path/to/cache/[confighash]/records.json',
    }),
  ],
};

? Or are the hashing parts also required?

You'd need to also define the confighash.
This is the minimal configuration I use:
    new HardSourcePlugin({
      cacheDirectory: path.join(__dirname, 'node_modules/.cache/hardsource/[confighash]'),
      recordsPath: path.join(__dirname, 'node_modules/.cache/hardsource/[confighash]/records.json'),
      configHash: function(webpackConfig) {
        return require('node-object-hash')().hash(webpackConfig);
      }
    })

Note that this requires the node-object-hashdependency

Worth noting that you could just remove [confighash] from the paths of your suggested config and it would work. I like using confighash though because most of the time my projects end up with multiple webpack configs for different environments (dev, prod, ci, etc).

Oh, okay, I do intend to use this for only one build environment. So the following would work?
    new HardSourcePlugin({
      cacheDirectory: path.join(__dirname, 'node_modules/.cache/hardsource'),
      recordsPath: path.join(__dirname, 'node_modules/.cache/hardsource/records.json'),
    })

The assumption for my case is I have a single production build env (for now), where webpack is ran inside a system that detects file changes and invokes webpack to make incremental builds.

Yes it should. The only thing to note is that webpack-dev-server makes non-obvious internal modifications to your webpack config, for example including the hot module replacement plugin. So if you're using dev server with your project you might want to consider keeping configHash in use.

Thanks for the note. I'm not using dev server because there's already apache serving files for this project. What configHash and --watch mode?

To my knowledge watch doesn't alter the config the way dev-server does so you should be fine.

The minimum config in v0.4.0 is no config! The old minimum config or the highlighted config options are also covered in the config now. https://github.com/mzgoddard/hard-source-webpack-plugin/pull/129

--watch mode like what webpack-dev-server is handled by configHash. The first recommendation was to do your own configuration for separate uses. But that's a little difficult with non-obvious changes dev-server makes. --watch and other webpack command line options modify the config to the compiler instead of call methods to activate those modes. Since they modify the config configHash is able to record that.


proto: Support map fields

There is a TODO in the codebase, so I assume the support is desired.
https://github.com/google/starlark-go/blob/master/lib/proto/proto.go#L84
There are two primary questions in regard of the possible implementation:

Ensuring deterministic ordering is tricky, the only feasible way is to sort all keys before the iteration (meaning lexicographical order as in opposite to the insertion one in regular dicts).
Are there any tests for the package? Where should they be put?

I'm very interested in sorting this out at the moment, at least for struct initialisation. @adonovan, would you accept a PR for this? (CLA is on file, and I'm a Xoogler).

Turned out to be fairly easy, map construction is here: https://github.com/google/starlark-go/pull/491
It seems like there isn't great test coverage of the lib/proto functionality at the moment. Didn't touch that too much. This code exists in a private fork, too, and has been tested against some fairly complex protos with map fields there.


CMake Debug No active kit

Issue Type: Bug
at wsl terminal ,cmake work ok.
but in the vs code windows,cmake build will report:
mpossible: CMake driver died immediately after successful configure
Unable to determine what CMake generator to use. Please install or configure a preferred generator, or update settings.json or your Kit configuration.
source: cmake tools(extension)
Extension version: 0.0.17
VS Code version: Code - Insiders 1.36.0-insider (68a7e5bc437b38d0281df0756997a25da2a2900c, 2019-06-18T18:40:22.519Z)
OS version: Windows_NT x64 10.0.18917

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3 CPU       M 330  @ 2.13GHz (4 x 2128)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: unavailable_offprotected_video_decode: unavailable_offrasterization: unavailable_offskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.86GB (3.58GB free)

Process Argv
C:\Users\lyl\helloworld\src

Screen Reader
no

VM
0%

Hi,
I think this issue is for the vscode-cmake-tools (https://github.com/vector-of-bool/vscode-cmake-tools) plugin

now i download the camke msi file and install,it works ok.

Hi,
I think this issue is for the vscode-cmake-tools (https://github.com/vector-of-bool/vscode-cmake-tools) plugin

thanks.

Hi,
I think this issue is for the vscode-cmake-tools (https://github.com/vector-of-bool/vscode-cmake-tools) plugin

now i download the camke msi file and install,it works ok.
Originally posted by @kinglionsz in #51 (comment)
but there's issues.while cmake configure,cmake reports:
[cmake] The C compiler identification is unknown
[cmake] The CXX compiler identification is unknown
[cmake] Check for working C compiler: C:/Users/lyl/AppData/Local/Packages/CanonicalGroupLimited.Ubuntu18.04onWindows_79rhkp1fndgsc/LocalState/rootfs/usr/bin/cc
[cmake] CMake Error: Generator: execution of make failed. Make command was: "C:/Users/lyl/AppData/Local/Packages/CanonicalGroupLimited.Ubuntu18.04onWindows_79rhkp1fndgsc/LocalState/rootfs/usr/bin/make" "cmTC_b6cba/fast"
[cmake] Check for working C compiler: C:/Users/lyl/AppData/Local/Packages/CanonicalGroupLimited.Ubuntu18.04onWindows_79rhkp1fndgsc/LocalState/rootfs/usr/bin/cc -- broken
[cmake] CMake Error at C:/Program Files (x86)/CMake/share/cmake-3.11/Modules/CMakeTestCCompiler.cmake:52 (message):
[cmake] The C compiler
[cmake]
[cmake] "C:/Users/lyl/AppData/Local/Packages/CanonicalGroupLimited.Ubuntu18.04onWindows_79rhkp1fndgsc/LocalState/rootfs/usr/bin/cc"
[cmake]
[cmake] is not able to compile a simple test program.
[cmake]
[cmake] It fails with the following output:
[cmake]
[cmake] Change Dir: c:/Users/lyl/helloworld/src/build/CMakeFiles/CMakeTmp
[cmake]
[cmake] Run Build Command:"C:/Users/lyl/AppData/Local/Packages/CanonicalGroupLimited.Ubuntu18.04onWindows_79rhkp1fndgsc/LocalState/rootfs/usr/bin/make" "cmTC_b6cba/fast"
[cmake] %1 不是有效的 Win32 应用程序。
[cmake] Generator: execution of make failed. Make command was: "C:/Users/lyl/AppData/Local/Packages/CanonicalGroupLimited.Ubuntu18.04onWindows_79rhkp1fndgsc/LocalState/rootfs/usr/bin/make" "cmTC_b6cba/fast"
[cmake]
[cmake]
[cmake]
[cmake]
[cmake] CMake will not be able to correctly generate this project.
[cmake] Call Stack (most recent call first):
[cmake] CMakeLists.txt:2 (project)
[cmake]
[cmake]
[cmake] Configuring incomplete, errors occurred!
the same CMakeLists.txt,at WSL terminal camke will be ok,build and debug no problem.

Hi,
I think this issue is for the vscode-cmake-tools (https://github.com/vector-of-bool/vscode-cmake-tools) plugin

Hi, Nicolas twxs:

Hi,
I think this issue is for the vscode-cmake-tools (https://github.com/vector-of-bool/vscode-cmake-tools) plugin

Hi,

Hi,
I think this issue is for the vscode-cmake-tools (https://github.com/vector-of-bool/vscode-cmake-tools) plugin

Hi,Nicolas 👍I have  installed the Remote Development extension pack(vs code version 1.36.0),and use Remote-WSL,then CMake tools works very good.
build & debug, no any problems.
tks. very much.