Questions about FCOS3D and PGD model 3D box

Dear author：
Hello，Thank you very much for the framework and model you published！
I trained the FCOS3D algorithm using KITTI data set as described in issue #865. The profile is the same as issue #865, training 72 epochs. After the training, I tested the trained weight model and PGD weight model respectively, and encountered two problems:
1、I ran into this on both models: too many 3D boxes：
FCOS3D：

PGD：

As you can see. They all detect too many 3D boxes. PGD even has a bunch of 3D boxes that shouldn't be there. What causes this problem? How to solve it?
2、I wrote test instructions to test according to the official documents and git instructions. Unfortunately, it can only be viewed and saved one by one. Batch tests cannot be completed, saved, and then viewed. Is there any solution to this problem? Maybe I'm not doing it right? I enclose mine here：
python tools/test.py configs/fcos3d/fcos3d_r101_caffe_fpn_gn-head_dcn_2x8_1x_kitti-mono3d.py /media/lee/DATA/project/FCOS3D/latest.pth --show --show-dir /media/lee/DATA/project/dataset/FCOS
python tools/test.py configs/pgd/pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py checkpoints/pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d_20211022_102608-8a97533b.pth --show --show-dir /media/lee/DATA/project/dataset/PGD
I look forward to your early reply! Thank you very much.

What nms_thr and score_thr do you set? This threshold can be tuned a little lower to suppress those low-quality predictions.
The result of PGD is really strange. Maybe you can first try to tune that threshold, and we can further have a closer look at what happens (maybe you can also print the predicted boxes). From the visualization result, I guess it is due to terrible detection performance for cyclists and pedestrians. We can try to only visualize the result for cars.
You can remove the option --show and the results will be saved automatically. After finishing the inference, you can then observe those results from your saving path.

Thank you very much for your busy response. I'll retest as you say. I will give you timely feedback on the results.

Hello author：
I have modified the nms_thr and score_thr parameters as you suggested. Effective results have been achieved in FCOS3D and PGD. However, PGD still has additional 3D boxes. I'll show it below:
FCOS3D:
Origin nms_thr is 0.8 and score_thr is 0.05:

After the adjustment nms_thr is 0.7 and score_thr is 0.3:

PGD：
Origin nms_thr is 0.8 and score_thr is 0.01:

After the adjustment nms_thr is 0.8 and score_thr is 0.2:

Even more extreme adjustments nms_thr is 5 and score_thr is 0.2:

As you can see, no matter how PGD is tuned, there are always extra 3D boxes. Is there any solution to this situation?
The second problem is that I removed the --show option as you suggested. The test worked fine but the folder I specified with --show-dir didn't store any data. See the following figure for details:

Is there any solution to this situation?
I look forward to your early reply! Thank you very much.

Could please check which classes these false predictions are from? I guess they are cyclists/pedestrians predictions. If yes, just filter them because the training for these two classes is really unstable for mono3D on KITTI, and also I do not pay much attention to it.
You can try with python tools/test.py ${CONFIG_FILE} ${CKPT_PATH} --eval 'mAP' --eval-options 'show=True' 'out_dir=${SHOW_DIR}' according to the documentation for visualization. It seems your command only supports LiDAR-based methods. If it can not work, I will have my colleagues further check the details carefully.

I see. I'll try again. Thank you very much! I will timely feedback the results.

Hello author：
I acted as you suggested. For the first question, I filtered the Pedestrian and Cyclist tags in PGD, leaving only the Car tags. But the extra boxes still exist, and adjusting nms_thr and score_thr has no effect. The result is shown below:

----------- AP11 Results ------------

Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP11:3.7567, 13.6954, 13.6954
bev  AP11:2.0669, 3.5100, 3.5100
3d   AP11:2.0459, 2.2684, 2.2684
aos  AP11:3.76, 13.69, 13.69
Car<EMAIL_ADDRESS>0.50, 0.50:
bbox AP11:3.7567, 13.6954, 13.6954
bev  AP11:3.7567, 13.6954, 13.6954
3d   AP11:3.7567, 13.6954, 13.6954
aos  AP11:3.76, 13.69, 13.69

----------- AP40 Results ------------

Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP40:2.7031, 5.6306, 5.6306
bev  AP40:1.2588, 2.4493, 2.4493
3d   AP40:1.2414, 1.9583, 1.9583
aos  AP40:2.70, 5.63, 5.63
Car<EMAIL_ADDRESS>0.50, 0.50:
bbox AP40:2.7031, 5.6306, 5.6306
bev  AP40:2.5015, 5.3571, 5.3571
3d   AP40:2.5015, 5.3571, 5.3571
aos  AP40:2.70, 5.63, 5.63

Results of img_bbox2d:

----------- AP11 Results ------------

Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP11:3.7567, 13.6954, 13.6954
Car<EMAIL_ADDRESS>0.50, 0.50:
bbox AP11:3.7567, 13.6954, 13.6954

----------- AP40 Results ------------

Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP40:2.7031, 5.6306, 5.6306
Car<EMAIL_ADDRESS>0.50, 0.50:
bbox AP40:2.7031, 5.6306, 5.6306

And as you can see, the detection accuracy is also very low. What are the reasons for these two situations? What's the solution?
For the second question, I conducted the test according to the format you provided. Unfortunately, there is still no way to save the result file. Here's an example:

And the test program runs to the end, will appear the following error:

Below is the error report and error source code：
Traceback (most recent call last):
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/tools/test.py", line 230, in <module>
    main()
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/tools/test.py", line 217, in main
    print(dataset.evaluate(outputs, **eval_kwargs))
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/kitti_mono_dataset.py", line 260, in evaluate
    self.show(results, out_dir)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/nuscenes_mono_dataset.py", line 630, in show
    img = img.numpy().transpose(1, 2, 0)
AttributeError: 'numpy.ndarray' object has no attribute 'numpy'

Error source code:
    def show(self, results, out_dir, show=True, pipeline=None):
        """Results visualization.

        Args:
            results (list[dict]): List of bounding boxes results.
            out_dir (str): Output directory of visualization result.
            show (bool): Visualize the results online.
            pipeline (list[dict], optional): raw data loading for showing.
                Default: None.
        """
        assert out_dir is not None, 'Expect out_dir, got none.'
        pipeline = self._get_pipeline(pipeline)
        for i, result in enumerate(results):
            if 'img_bbox' in result.keys():
                result = result['img_bbox']
            data_info = self.data_infos[i]
            img_path = data_info['file_name']
            file_name = osp.split(img_path)[-1].split('.')[0]
            img, img_metas = self._extract_data(i, pipeline,
                                                ['img', 'img_metas'])
            # need to transpose channel to first dim
            img = img.numpy().transpose(1, 2, 0)
            gt_bboxes = self.get_ann_info(i)['gt_bboxes_3d']
            pred_bboxes = result['boxes_3d']
            show_multi_modality_result(
                img,
                gt_bboxes,
                pred_bboxes,
                img_metas['cam2img'],
                out_dir,
                file_name,
                box_mode='camera',
                show=show)

The source code is in themmdet3d/datasets/nuscenes_mono_dataset.py path.
Because variable img is in numpy. ndarray format. So I tried to change  img = img.numpy().transpose(1, 2, 0) to  img = img.transpose(1, 2, 0), but reported a new error:
Traceback (most recent call last):
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/tools/test.py", line 230, in <module>
    main()
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/tools/test.py", line 217, in main
    print(dataset.evaluate(outputs, **eval_kwargs))
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/kitti_mono_dataset.py", line 260, in evaluate
    self.show(results, out_dir)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/nuscenes_mono_dataset.py", line 637, in show
    img_metas['cam2img'],
TypeError: 'NoneType' object is not subscriptable

The same data key as variable  img_metas was not found in the KITTI dataset. So does variable   img_metas represent the predicted data of the model? Or does variable  img_metas represent data that is not in KITTI format (possibly Nuscenes data)?
Attached here is the data shown by variable img_metas:

For comparison, I have attached the same contents of the 000001 image from the Calib and Label_2 files in the KITTI dataset.
Calib:

Label_2:

I tried a lot of things. I hope I can try my best to solve the problem myself before bothering you. But my capacity is limited. I'm really hope you can help me solve the above problems.
I look forward to your early reply! Thank you very much.

Follow the comments below. Similarly, when I tested the SMOKE model, I also had an error similar to problem 2. This seems to be a common bug. The following is an error message:
loading annotations into memory...
Done (t=0.00s)
creating index...
index created!
 Please check your prepared data and training log for the reason of the much lower performance than expected. You can take our provided logs for reference.

I didn't do training. It was tested directly using the weighting model you provided. I prepared the dataset by strictly following the tutorial in the documentation, downloaded the full KITTI dataset, organized the format as required, and generated the training and test files. As for the low accuracy of the test I think it is caused by the fact that I only left 20 images in the validation set. I will rerun the test with the full validation set and submit test feedback. Until then, could you please arrange a colleague to see how to fix the bugs I've reported. Thank you very much!

This is the result of a test using the full validation set. I annotated '--eval-options', 'show=Ture' in the test command to get this result.
loading annotations into memory...
Done (t=0.39s)
creating index...
index created!
 We will check it ASAP.

Thanks for your hard work! Looking forward to hearing from you guys!

Hi! @Gewaihir , In PGD model, the score for each object is combined with object's uncertainty. If you print the scores:
tensor([1303.7736,  488.0242,  367.1842,   93.2382,   42.8337,   41.1439,
          26.1720,   21.4874,   15.8451,   14.6057,   13.8399,   12.4595,
           9.6357,    8.7701,    8.5532,    6.6126,    6.5322,    6.3516,
           5.9160,    5.8083], device='cuda:0')

So you will find that they are not typically in range [0,1].  I recommend you to set a higher score threshold while visualization.
May be you can set it as 10.

@Gewaihir Another supplemental note is that a lower score threshold can yield a little better (very little that can be ignored). So when I did the ablation I did not set it to a higher one. As for the compatibility of visualization API, we will fix it ASAP.

Thank you both so much for your work! I will follow the suggestions and give it a try. Looking forward to the perfect code!

Hello Author! I set the corresponding nms_thr and score_thr values as suggested by @ZCMax and found that the test came out with no change in the results. Here are the tests with different settings.
nms_thr=10,  score_thr=0.01

nms_thr=500,  score_thr=0.01

nms_thr=1000,  score_thr=0.01

This is very strange. It looks like there are still problems with the model. Looking forward to your solutions.

@Gewaihir You need to set the param score_thr to be higher instead of the nms_thr. nms_thr is the threshold for judging whether two overlapped boxes should be filtered with nms.

@Tai-Wang I tried your suggestion and set different and even extreme score_thr parameters. But this still didn't change the test. Here is an example showing.
nms_thr=0.8,  score_thr=10

nms_thr=0.8,  score_thr=500

nms_thr=0.8,  score_thr=1000

At the extreme some，nms_thr=1000,  score_thr=1000

You can see that no change has occurred. Looking forward to your solutions.

@Gewaihir  Did you change score threshold in pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py config?

@Gewaihir  We suggest you to change the code like #1066 for a quick solution, or wait until the code is merged into our codebase. After code changing, the command for saving results should be like this:
python tools/test.py configs/pgd/pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py checkpoints/pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d_20211022_102608-8a97533b.pth --eval 'mAP' --eval-options 'show=False' 'out_dir=./pgd_results'

Actually, the problem is caused by inference model on multi-gpu testing scheme, Saving results while inference is only applicable to single GPU testing and mainly used for debugging and simple visualization.

@ZCMax I changed the parameter of score_thr in pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py as you suggested. And set a few more different sets of parameters for comparison. It seems to work well. The following examples are all set with the parameters nms_thr=0.8 and score_thr=0.01 within pgd.py.
pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py  nms_thr=0.05 and score_thr=5

pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py  nms_thr=0.8 and score_thr=5

pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py  nms_thr=0.2 and score_thr=5

pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py  nms_thr=0.2 and score_thr=10

pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py  nms_thr=0.5 and score_thr=10

It seems that modifying the parameters in pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py  works. What is puzzling is that shouldn't the parameters in pgd.py be able to override the parameters in pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py ?
Secondly I updated the code with the new changes you submitted. The updated code runs with an error that does not affect the runtime. The error is reported as follows.
Traceback (most recent call last):
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/tools/test.py", line 244, in <module>
    main()
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/tools/test.py", line 219, in main
    print(dataset.evaluate(outputs, **eval_kwargs))
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/kitti_mono_dataset.py", line 266, in evaluate
    self.show(results, out_dir, show=show, pipeline=pipeline)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/nuscenes_mono_dataset.py", line 620, in show
    pipeline = self._get_pipeline(pipeline)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/nuscenes_mono_dataset.py", line 593, in _get_pipeline
    loading_pipeline = get_loading_pipeline(self.pipeline.transforms)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/utils.py", line 103, in get_loading_pipeline
    is_loading = is_loading_function(transform)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/utils.py", line 51, in is_loading_function
    if isinstance(transform, MultiScaleFlipAug3D, MultiScaleFlipAug):
TypeError: isinstance expected 2 arguments, got 3

The entire terminal output is as follows.
loading annotations into memory...
Done (t=0.27s)
creating index...
index created!
Use load_from_local loader
2021-11-22 18:18:57,314 - root - INFO - ModulatedDeformConvPack bbox_head.cls_convs.1.conv is upgraded to version 2.
2021-11-22 18:18:57,315 - root - INFO - ModulatedDeformConvPack bbox_head.reg_convs.1.conv is upgraded to version 2.
[>>>>>>>>>>>>>>>>>>>>>>>>>>>] 3769/3769, 5.3 task/s, elapsed: 713s, ETA:     0s
Converting prediction to KITTI format
[>>>>>>>>>>>>>>>>>>>>>>>>>>] 3769/3769, 1017.5 task/s, elapsed: 4s, ETA:     0s
Result is saved to /tmp/tmprxop69se/resultsimg_bbox.pkl

Converting prediction to KITTI format
[>>>>>>>>>>>>>>>>>>>>>>>>>>] 3769/3769, 8005.3 task/s, elapsed: 0s, ETA:     0s
Result is saved to /tmp/tmprxop69se/resultsimg_bbox2d.pkl
Results of img_bbox:

----------- AP11 Results ------------

Pedestrian<EMAIL_ADDRESS>0.50, 0.50:
bbox AP11:60.5382, 50.8523, 43.8061
bev  AP11:5.9303, 5.0150, 4.7442
3d   AP11:4.9901, 4.7131, 4.2165
aos  AP11:50.66, 41.87, 36.03
Pedestrian<EMAIL_ADDRESS>0.25, 0.25:
bbox AP11:60.5382, 50.8523, 43.8061
bev  AP11:29.3821, 25.1919, 22.3654
3d   AP11:28.4081, 24.4285, 21.6380
aos  AP11:50.66, 41.87, 36.03
Cyclist<EMAIL_ADDRESS>0.50, 0.50:
bbox AP11:33.1469, 21.3790, 21.2673
bev  AP11:11.2900, 9.6947, 9.5859
3d   AP11:10.4609, 9.3370, 9.3414
aos  AP11:26.58, 17.80, 17.68
Cyclist<EMAIL_ADDRESS>0.25, 0.25:
bbox AP11:33.1469, 21.3790, 21.2673
bev  AP11:19.8410, 13.4393, 13.0573
3d   AP11:19.7245, 13.3082, 12.9519
aos  AP11:26.58, 17.80, 17.68
Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP11:90.2953, 80.2002, 71.0076
bev  AP11:30.1130, 23.4541, 19.3242
3d   AP11:24.7254, 18.3290, 16.8798
aos  AP11:89.40, 78.78, 69.41
Car<EMAIL_ADDRESS>0.50, 0.50:
bbox AP11:90.2953, 80.2002, 71.0076
bev  AP11:61.6286, 45.5171, 38.2089
3d   AP11:56.7955, 42.6317, 36.2314
aos  AP11:89.40, 78.78, 69.41

Overall AP11@easy, moderate, hard:
bbox AP11:61.3268, 50.8105, 45.3603
bev  AP11:15.7778, 12.7213, 11.2181
3d   AP11:13.3921, 10.7930, 10.1459
aos  AP11:55.54, 46.15, 41.04

----------- AP40 Results ------------

Pedestrian<EMAIL_ADDRESS>0.50, 0.50:
bbox AP40:60.5920, 48.5055, 41.5453
bev  AP40:4.4606, 3.5650, 2.9825
3d   AP40:3.4750, 2.8608, 2.2876
aos  AP40:49.32, 38.69, 32.81
Pedestrian<EMAIL_ADDRESS>0.25, 0.25:
bbox AP40:60.5920, 48.5055, 41.5453
bev  AP40:25.3144, 20.8319, 17.5321
3d   AP40:24.4363, 20.0587, 16.2912
aos  AP40:49.32, 38.69, 32.81
Cyclist<EMAIL_ADDRESS>0.50, 0.50:
bbox AP40:29.5595, 16.0317, 15.8611
bev  AP40:4.6236, 1.9053, 1.8235
3d   AP40:3.6031, 1.1803, 1.1889
aos  AP40:22.07, 11.96, 11.81
Cyclist<EMAIL_ADDRESS>0.25, 0.25:
bbox AP40:29.5595, 16.0317, 15.8611
bev  AP40:14.5821, 7.4671, 6.9711
3d   AP40:14.3430, 7.3643, 6.8760
aos  AP40:22.07, 11.96, 11.81
Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP40:95.8790, 84.9067, 72.8449
bev  AP40:26.9398, 18.5883, 15.3906
3d   AP40:19.4497, 13.5134, 10.9605
aos  AP40:94.83, 83.25, 71.01
Car<EMAIL_ADDRESS>0.50, 0.50:
bbox AP40:95.8790, 84.9067, 72.8449
bev  AP40:61.5092, 44.1024, 37.7061
3d   AP40:55.1299, 39.9826, 33.9913
aos  AP40:94.83, 83.25, 71.01

Overall AP40@easy, moderate, hard:
bbox AP40:62.0102, 49.8146, 43.4171
bev  AP40:12.0080, 8.0195, 6.7322
3d   AP40:8.8426, 5.8515, 4.8124
aos  AP40:55.41, 44.63, 38.54

Traceback (most recent call last):
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/tools/test.py", line 244, in <module>
    main()
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/tools/test.py", line 219, in main
    print(dataset.evaluate(outputs, **eval_kwargs))
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/kitti_mono_dataset.py", line 266, in evaluate
    self.show(results, out_dir, show=show, pipeline=pipeline)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/nuscenes_mono_dataset.py", line 620, in show
    pipeline = self._get_pipeline(pipeline)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/nuscenes_mono_dataset.py", line 593, in _get_pipeline
    loading_pipeline = get_loading_pipeline(self.pipeline.transforms)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/utils.py", line 103, in get_loading_pipeline
    is_loading = is_loading_function(transform)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/utils.py", line 51, in is_loading_function
    if isinstance(transform, MultiScaleFlipAug3D, MultiScaleFlipAug):
TypeError: isinstance expected 2 arguments, got 3
Results of img_bbox2d:

----------- AP11 Results ------------

Pedestrian<EMAIL_ADDRESS>0.50, 0.50:
bbox AP11:60.5774, 50.7689, 43.9143
Pedestrian<EMAIL_ADDRESS>0.25, 0.25:
bbox AP11:60.5774, 50.7689, 43.9143
Cyclist<EMAIL_ADDRESS>0.50, 0.50:
bbox AP11:35.3694, 22.4179, 22.3332
Cyclist<EMAIL_ADDRESS>0.25, 0.25:
bbox AP11:35.3694, 22.4179, 22.3332
Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP11:97.1444, 80.8651, 71.6386
Car<EMAIL_ADDRESS>0.50, 0.50:
bbox AP11:97.1444, 80.8651, 71.6386

Overall AP11@easy, moderate, hard:
bbox AP11:64.3637, 51.3506, 45.9621

----------- AP40 Results ------------

Pedestrian<EMAIL_ADDRESS>0.50, 0.50:
bbox AP40:60.7576, 48.4249, 41.5158
Pedestrian<EMAIL_ADDRESS>0.25, 0.25:
bbox AP40:60.7576, 48.4249, 41.5158
Cyclist<EMAIL_ADDRESS>0.50, 0.50:
bbox AP40:32.6655, 17.7604, 17.7796
Cyclist<EMAIL_ADDRESS>0.25, 0.25:
bbox AP40:32.6655, 17.7604, 17.7796
Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP40:98.5597, 85.8037, 75.6706
Car<EMAIL_ADDRESS>0.50, 0.50:
bbox AP40:98.5597, 85.8037, 75.6706

Overall AP40@easy, moderate, hard:
bbox AP40:63.9943, 50.6630, 44.9887

There are no saved files in the specified folder except for the error report.

Anyway, thank you very much for solving the problem. Looking forward to your new version! Thanks for your hard work!

the parameters in pgd_r101_caffe_fpn_gn-head_3x4_4x_kitti-mono3d.py  will override the parameters in pgd.py, It's quitely natural for the config design,  the user should change the parameters in the final model config.
Please check your code carefully for modification:
It's:
if isinstance(transform, (MultiScaleFlipAug3D, MultiScaleFlipAug)):
not
if isinstance(transform, MultiScaleFlipAug3D, MultiScaleFlipAug):

@Gewaihir the PR has been merged into our v1.0.0.dev0 branch, you can update your code via git pull.

@ZCMax  To avoid the problem in 2 again. I double checked and modified the code. It still didn't save any files after re-running. The new error reported is as follows.
Traceback (most recent call last):
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/tools/test.py", line 244, in <module>
    main()
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/tools/test.py", line 219, in main
    print(dataset.evaluate(outputs, **eval_kwargs))
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/kitti_mono_dataset.py", line 266, in evaluate
    self.show(results, out_dir, show=show, pipeline=pipeline)
  File "/home/lee/Project/mmdetection3d-1.0.0.dev0/mmdet3d/datasets/nuscenes_mono_dataset.py", line 630, in show
    img = img.np.transpose(1, 2, 0)
AttributeError: 'Tensor' object has no attribute 'np'

I added the following code at the beginning of the file that reports the error where the module is imported.
import tensorflow as tf
tf.enable_eager_execution()

Re-run test.py. The terminal displays the following message.
Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)

Although no error was reported, it did not solve the problem.

@Gewaihir I have no idea about where is the img.np.transpose(1, 2, 0) code from, check here. I suggest you just update your code via git pull since the modification has been merged into our codebase.

Hello @ZCMax  I git pull the latest branch. Re-running the test resulted in the following error.
Traceback (most recent call last):
  File "/home/lee/Project/gitproject/mmdetection3d/tools/test.py", line 13, in <module>
    from mmdet3d.apis import single_gpu_test
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/apis/__init__.py", line 2, in <module>
    from .inference import (convert_SyncBN, inference_detector,
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/apis/inference.py", line 11, in <module>
    from mmdet3d.core import (Box3DMode, CameraInstance3DBoxes, Coord3DMode,
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/core/__init__.py", line 3, in <module>
    from .bbox import *  # noqa: F401, F403
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/core/bbox/__init__.py", line 3, in <module>
    from .coders import DeltaXYZWLHRBBoxCoder
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/core/bbox/coders/__init__.py", line 6, in <module>
    from .fcos3d_bbox_coder import FCOS3DBBoxCoder
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/core/bbox/coders/fcos3d_bbox_coder.py", line 6, in <module>
    from ..structures import limit_period
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/core/bbox/structures/__init__.py", line 2, in <module>
    from .base_box3d import BaseInstance3DBoxes
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/core/bbox/structures/base_box3d.py", line 7, in <module>
    from mmdet3d.ops import points_in_boxes_all, points_in_boxes_part
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/ops/__init__.py", line 6, in <module>
    from .ball_query import ball_query
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/ops/ball_query/__init__.py", line 1, in <module>
    from .ball_query import ball_query
  File "/home/lee/Project/gitproject/mmdetection3d/mmdet3d/ops/ball_query/ball_query.py", line 4, in <module>
    from . import ball_query_ext
ImportError: cannot import name 'ball_query_ext' from 'mmdet3d.ops.ball_query' (/home/lee/Project/gitproject/mmdetection3d/mmdet3d/ops/ball_query/__init__.py)

The code file for this error is located in the mmdetection3d/mmdet3d/ops/ball_query/ path. I did a search within the file and didn't find the module ball_query_ext that I needed to import. Where is the module ball_query_ext located?

@Gewaihir  It seems you git clone a new repo, change from /home/lee/Project/mmdetection3d-1.0.0.dev0 to /home/lee/Project/gitproject/mmdetection3d, you can just use git pull in your original repo, or you can create a new conda environment, and reinstall mmdetection3d in your new repo.

@Tai-Wang @ZCMax The problem has been solved. Fantastic, thank you for all your hard work!

Results Show.
Original image

Prediction Chart

Three files are generated by inference. The file names are 000008_img.png, 000008_pred.png and 000008_gt.png. Where 000008_img.png is the original image. 000008_pred.png is the prediction graph. What is 000008_gt.png the graph? 000008_gt.png is the image that shows the orange box.

Results Show. Original image
Prediction Chart
Three files are generated by inference. The file names are 000008_img.png, 000008_pred.png and 000008_gt.png. Where 000008_img.png is the original image. 000008_pred.png is the prediction graph. What is 000008_gt.png the graph? 000008_gt.png is the image that shows the orange box.

gt.png represents the image with ground truth label.

@ZCMax Understood. Thank you！


After update, preferences are not fully transfered to new configuration

I've noticed for a few versions now, every time I update, I get this pop-up to transfert old preferences for the new version.
I don't know for the other files, but I know for a fact that the file "stored_directories.json" is not transfered, and an empty one is used instead:
{
    "workingDirectory": "/local/home/mylogin",
    "recentFiles": [
    ],
    "favoriteDirectories": [
    ]
}

What it means in practice is that I loose all my preferences at every update, including default folder, history of opened files (which is really the only preferences I use in AsciidocFX, hence why I don't know if the rest is transfered or not)
And I have to copy paste manually what's inside $HOME/.AsciidocFX-1.8.8/stored_directories.json into $HOME/.AsciidocFX-1.8.9/stored_directories.json
One possible explanation is that my home directory is in /local/home/mylogin instead of /home/mylogin as one would usually expect. I've had issues with AppImage because of that, whicih is why I mention this.  The bash variable $HOME correctly points to it though.
Another possible explanation is that it simply doesn't work for anyone.

I still experienced this for 1.8.10.
This time "stored_directories.json" had this:
{}

(2 octets, instead of the one from 1.8.9 that was 5.3ko)

Sorry, there was one bug and fixed. I expect it to be fixed by downloading and reinstalling it

Thanks for your answer. Do you mean that I install the next version when it's updated, or I need to deinstall my version, before installing 1.8.10 again?

possibly related: in a 1.8.10 version downloaded prior to this issue I experience that some settings vanish from one run to another.  Observed under Linux, Windows ver. not tested.
Are changes made to the downloadable installer? Or do I have to wait for next update to test?


test/RuntimePrivilegedUnitTests: Log timestamps

RuntimePrivilegedUnitTests times out from time to time (cf. https://github.com/cilium/cilium/issues/18958), sometimes at the very end, while computing coverage. By dumping the timestamp for each test output line, this commit will help us determine where time is spent.
Note we already have timestamps in Jenkins, but since we dump all the unit test logs at once at the end, the timestamp is the same for the entire test.

/test-runtime


two way binding doesn't have animation

while i try two way binding is there any way to make animation work on value change ?

I'm wondering the same thing - did you ever find a solution for this?

nope.


Partition Problem

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
The Partition Problem: Given a nonempty set A of positive integers, we have to find two nonempty
disjoint subsets A1 and A2 such that (a) A1∪A2 = A and (b) sum of elements of A1 = sum of elements
of A2.
Checklist

[Y] I've read the contribution guidelines.
[Y] I've checked the issue list before deciding what to submit.
[Y] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Issue Number #1560

@Bharati2612 there are some Unwanted addition, only add Partition problem and Update the README.md accordingly.

@Bharati2612 there are some Unwanted addition, only add Partition problem and Update the README.md accordingly.

Some of the conversations is yet not resolved. Please resolve them as soon as possible, so that I can re-review it.

Some of the conversations is yet not resolved. Please resolve them as soon as possible, so that I can re-review it.

That Matrix_Chain_Multiplication is already merged into Masters. I did the required changes in the Partition problem which is not yet merged and this PR is for partition problem.

Some of the conversations is yet not resolved. Please resolve them as soon as possible, so that I can re-review it.

That Matrix_Chain_Multiplication is already merged into Masters. I did the required changes in the Partition problem which is not yet merged and this PR is for partition problem.

Closing this because of no updates.

Closing this because of no updates.


Color filter on Camera view

Hello sir,
How can we set custom filter on camera screen?

can you please reply fast its urgent...

@Azharaliimark have you make it ?

@giskook no, I am still finding the solution.

@Azharaliimark according to I made a customer filter on cameraview.


DM/Admin view for front-end

Create a way for the Dungeon Master or an Admin to create, track, and view monsters that the party is currently facing or may face in the future.

This was an issue for an earlier version of the project. I will revisit this issue in the future.


Where is my shop?

World and coordinates where the shop is located would be nice

Will be perhaps done with c9ced7b184da1f5171823f2a92006d72e201c20c

👍


Add mysqlrouter_exporter

Thanks for sharing. Your exporter it taking a password on the command line, which is not secure. Can you fix that?
Some other tips to improve your exporter:
Several label names should be separate metrics as they are numeric, including process_id, time_started, time_refresh_in_ms, group_replication_id, time_last_refresh_succeeded, refresh_failed. router_status should be router_info.
Metrics should be gathered at scrape time and use MustNewConstMetric, not on a 60s cycle independent of scrapes.

OK I'll change reading credentials from command line to an environment variable.

Several label names should be separate metrics as they are numeric, including process_id, time_started, time_refresh_in_ms, group_replication_id, time_last_refresh_succeeded, refresh_failed. router_status should be router_info.

It's means change label like below?
router_info{process_id=x, time_started=x, time_refresh_in_ms=x, group_replication_id=x, time_last_refresh_succeeded=x, refresh_failed=x}

It's means change label like below?

Yes, and remove the numeric labels. Instead have them as separate gauge metrics. You can't do math on label values.

Thanks quick reply!
I know labels can't math. but for example process_id there is no problem even if wen can't math currently.
I updated code of getting credentials.
please check again :-)
https://github.com/rluisr/mysqlrouter_exporter

R sorts before S

Ah sorry. fixed.

y is after S :)

oh my god.... sorry

Thanks!


How to change the default favicon folder

Hey guys, i'd like to know how i can change the default folder of the favicon:
<link rel="shortcut icon" href="/favicon.ico"> is injected in the <head> everytime even though i have a favicon.ico in src/assets/ so I have the preact default favicon visible.
How can i change the favicon folder to another one ?
Thanks!

Do you want to change the favion folder because you don't see the favicon itself ? Maybe it's an ServiceWorker issue as it is caching it ?
I think in general if you want to change the folder you should check this line https://github.com/developit/preact-cli/blob/ae50aaddd18797db4cc9e7d3e281b8b812dac0ad/src/lib/webpack/render-html-plugin.js#L22
and you would need to change this line with a preact.config.js querying the webpack.config and changing this value see: https://github.com/developit/preact-cli#webpack

Preact CLI aims for a perfect lighthouse score, and IIRC forgoing an icon impacts that. Maybe supply a blank one?  FWIW, if you have no favicon declared at all, your server will get a bunch of 404's for /favicon.ico as browsers still attempt to look for it.  It's usually best to have one, even if its an empty file.

@developit The point is not to remove the favicon, just to change his location
@fokusferit I don't thinks it's a serviceWorker issue, i tried to change the path in the preact-config.js and when i log it, the path is indeed changed, but even though i don't have any reference in my html template about the root ico, i still have a <link rel="shortcut icon" href="/favicon.ico"> injected at build time, which override the one i included manually.

Is it by any chance a problem related to this closed issue #167 ?
I am facing a strange issue on the favicon.ico myself: I just put my own favicon.ico into the /assets folder like in the default template, and still I get preact's default one.
I tried to clear the cache, manually unregister the service worker from the browser, force hard reload, close/reopen Chrome and open my app using incognito window... I still get the default preact icon.
When I monitor the network tab under Chrome, I don't see the favicon.ico being called, but I see this line in the <head></head> portion:
<link rel="shortcut icon" href="/favicon.ico">

and navigating to http://localhost:8080/favicon.ico reaches correct asset.
Now I tried to force call of favicon.ico using preact-helmet module and put this line:
<Helmet
 link={[
{rel:"shortcut icon", href:"/assets/favicon.ico"}
]}
/>

the problem is still the same, but through Chrome's network tab I now see a GET/ favicon.ico.
That being said, npm run build correctly creates /favicon.ico alongside the index.html and npm run serve also seems to take correct asset. So I guess this only a development mode issue.

@Jonarod you'll need to replace the default template with your own by passing --template foo.html

@developit
Actually, even if i use the custom template, it still creates preact favicon automatically replacing my custom favicon. Can you give me more specific example?
Custom template is recognized, but it overrides favicon. Do we have ways to prevent this?


create daemon containers with deployments instead of pods

Summary
daemon containers should be able to be deployed using a k8s deployment rather than a pod
Use Cases

CICD unit testing pipelines - when testing features that rely on external services, I want the other services (that may be daemon containers) to be consistent
"Rare resource" dependent workflows - for workflows that depend on "rare resources" (such as GPUs), they might have preemptive scheduling (like spot instances), so I'd like my workflow to wait for the resource to be available again

Message from the maintainers:
Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.

I'd also like to contribute to solve this issue

after looking at the code, i think a better fix would be to amend retry policy because of the createWorkflowPod function, which is kinda huge.
the something like retryPolicy: always

This seems to duplicate https://github.com/argoproj/argo-workflows/issues/5833.
This also would have to handle the difference between the Controller intentionally killing it at the end vs it dying on its own


Update radix to v4

Radix v4 supports passing a context.Context to all blocking operations.
We require this feature to limit potential request timeouts.
Please update t38c so that the Execute method and other command methods can take advantage of this feature.

Implemented in v0.11.0 release.
Note that this is a breaking change.
Thanks for pointing it out!


description of projects and scenes that could be viewed on the inspector bar

hi
the end user would eventually make many projects and many many many scenes
(in my case "chapters", "scenes" and "sub-scenes")
it would be helpful and faster for the end user to have a place where they could add a description for the scenes(chapters), and to an extent to the projects

Hi @whwptb
This is implemented in v1.5.0 using entry nodes' notes property.
Each scene, macro or project requires an entry node. The notes on each entry node will be shown as description of the parent scene/macro/project in the respective lists.


Using docker for test

Configured application to use Azure Sql fri database
Created new migrations
Fixed connection errors
Fixed default value for page number
Fixed Environment Variable for production
Added comment to code
Using user secret for connectionstring locally
Added package refrence to test project
Made end2end test comments. Need to set up docker for testing
Modified test to use sql server

Closes #145

Making a new pull request based on main to not run into conflicts


.then alias for alternative cases

Updating nexus-prisma examples today, found this change to be awkward:

-        return ctx.photon.blogs.findOne({
-          where: {
-            id: args.id,
-          },
-        })
+        return ctx.photon.blogs
+          .findOne({
+            where: {
+              id: args.id,
+            },
+          })
+          .then()
       },

IIUC then is optimized for users who await it, right?
I think we should support non-await users / non-await cases / non-then-chains with an alias to then that feels ergonomic.
To get the discussion going, here are some example possibilities run execute start launch send exec go ....
I personally think run is pretty good. Example:
    //
    // Examples showing custom resolvers
    //

    t.field('blog', {
      type: 'Blog',
      args: {
        id: intArg({ required: true }),
      },
      resolve(_root, args, ctx) {
        return ctx.photon.blogs
          .findOne({
            where: {
              id: args.id,
            },
          })
          .run()
      },
    })

The motiving use-case for this issue was invalid. Delegates conform to the thenable contract.


Upgrade to puppeteer 9.1.1

Context

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[ ] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[ ] I have added documentation where necessary
[ ] I have added a matching Type: XYZ label to the PR

Fixes #

I believe the issue is @axe-core/puppeteer see.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/puppeteer
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@wordpress/e2e-test-utils
npm ERR<EMAIL_ADDRESS>from e2e-test-utils@undefined
npm ERR!     packages/e2e-test-utils
npm ERR!     dev<EMAIL_ADDRESS>from e2e-tests@undefined
npm ERR!     packages/e2e-tests
npm ERR!   2 more (@wordpress/jest-puppeteer-axe, @percy/puppeteer)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>< 6" from<EMAIL_ADDRESS>npm ERR! node_modules/@axe-core/puppeteer
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@wordpress/jest-puppeteer-axe
npm ERR!     dev<EMAIL_ADDRESS>from e2e-tests@undefined
npm ERR!     packages/e2e-tests
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/jonny/.npm/eresolve-report.txt for a full report.

@axe-core/puppeteer only added support for puppeteer 9.0.0 19 hours ago in https://github.com/dequelabs/axe-core-npm/pull/242.
@swissspidy ^

Installing @axe-core/puppeteer@next (currently pointing at 4.1.2-alpha.118) should resolve that, it was published 3 ours ago.

This PR is blocked by https://github.com/google/web-stories-wp/pull/7289.

Publishing flow tests seem to be still flakey, even after #7289 being merged

@swissspidy It is now passing. I ran it twice and it works.


CUDA Graph issues when using "reduce-overhead"

It seems I am experiencing CUDA-Graph related issues when using "reduce-overhead" method for compilation. Am I right to assume that the reason for this is because CUDA graphs very much expect the same kind of input every time and prompts/descriptions of varying length that don't match the initial warmup phases throw these errors?

Yes exactly ! @eustlb  can elaborate a bit more if necessary


Support more special keys

Keys F1-F12 (and more on some keyboards) are not currently properly handled.
The Shift/Ctrl variants may be tougher to get right.

Home, End, PageUp, PageDown, Ins, Del are also not supported.

Backspace is also not supported.

@tnias It is supported.

@Ticki Oops, not sure wether I replied to the correct issue. But I meant read_passwd returns something like this "letmeh\u{7f}in", when I try to use backspace.
Is this behaviour expected?

Oh, no. It certainly isn't! Could you open another issue?

@tnias I have fixed the issue you described.

@Ticki Nice. Thanks.

shift or ctrl-modified arrows (left/right/up/down) are also not supported.

Currently, the only modifiers supported are Alt and Ctrl with a single char.
I suggest making those more general to accept other keys (arrows, F1-12 keys, home/end/ins/del, PageUp/Down).
Adding a Shift modifier would also be useful, but handling characters may become tricky (should shift-A output Shift(A) or Char('A')?).
Other input engines (SFML, SDL, ...) often detach key detection from text detection. I think it'd be easier to have a simple key input system, with methods to convert it to a Option<char> for when the text is needed.

For comparison, Rustbox does this with a Key enum where the chars are uppercase when shift is pressed. Which is fair for most usages, but isn't really a solution to multiple modifier presses: detecting good old Escape-Meta-Alt-Control-Shift might be hard but it's fine as it is for a lot of usages.
pub enum Key {
    Tab,
    Enter,
    Esc,
    Backspace,
    Right,
    Left,
    Up,
    Down,
    Delete,
    Insert,
    Home,
    End,
    PageUp,
    PageDown,
    Char(char),
    Ctrl(char),
    F(u32),
    Unknown(u16),
}

Note that it might also be nice to return a value through Unknown(u16) instead of the current Invalid if the user wants to deal with special escape codes or something.

As another example, in cursive there is a slightly more complete event model. It doesn't unify char and Key representations as far as modifiers go, but as you remarked "shift" doesn't properly apply to chars anyway.
Though maybe it's too high-level for termion, and should rather be implemented on top (once unhandled codes are actually returned)?

The event model would need to change anyways if mouse events are to be implemented (unless window resize and mouse clicks are still "keys"), but having CtrlShift and AltShift but somehow no CtrlAltShift? Not very elegant.
Maybe if that info is really to be parsed, Keys just need to be structs and have properties reflecting the current pressed modifiers? std::fs::OpenOptions comes to mind.

For some reason ctrl-alt-shift only sends the lower-case characters to the application here :S

@IGI-111, that looks very interesting. I left a few comments. When they're fixed, I'll merge it.

The "escape" key is also not properly supported. It is currently always expected to be part of an escape sequence, even when no more input is present (it will just block until the next key is pressed).

@gyscos see #45

@gyscos see #45

Maybe I'm missing something, but I don't see Key::Enter in version 1.5.1?

@olivernn isn't that just \n?

It is, and Keys::Char('\n') works for what I want, thanks.


Items by Partition Key

I’m sure this is obvious but how do I get all items by partiton key? do i still use MaxItems = -1 and does the concurrently option come into play?
thanks!

        IDocumentQuery<T> query =
            DocumentClient.CreateDocumentQuery<T>(
                UriFactory.CreateDocumentCollectionUri( dbName, collectionName),
                options )
                .AsDocumentQuery();

        List<T> results = new List<T>();
        while ( query.HasMoreResults )
        {
            // Accumulate results
        }

Where options if an instance of FeedOptions that has the PartitionKey set.
You can set MaxItems or not.  Setting it to -1 allows the DocumentClient to optimize the number of results that come back in each result set.

thank you however i am looking how to do the equivalent with the new API SDK 3.

There are currently 2 overloads for the query. The first overload only queries a single partition. The second overload does cross partitions queries.  I haven't verified the following code, but this should return all the items for the selected partition key.
List<Family> results = new List<Family>();
var resultSetIterator = container.Items.CreateItemQuery<Family>("SELECT * FROM Families f", partitionKey: "Anderson");
while (resultSetIterator.HasMoreResults)
{
     results.AddRange((await resultSetIterator.FetchNextSetAsync()));
}

thank you that works great!
one more question, does the maxConcurrency only come into play when performing a cross-partition query?

Yes, the max concurrency overload method is only needed when performing cross-partition queries.


Question: Find largest containers that fits inside volume

Hi,
Would be possible to find the largest container that fit into the shape.
We are looking for some nice centre point inside 3D geometry. So I thought we could get the largest volume container and its middle of diagonal using your workflow. Not sure if this would work...or maybe you have some idea?
Does it work if we have volume like doughnut shape?
What are the limitation yo my volumes?

Hmm, I'm not sure this project would help with that. This packing algorithm treats everything as solid cuboids, so it wouldn't know what to do with differently shaped volumes.

ok thanks for the reply...yes in my case I need more flexibility...


Fix unit tests that fail when Myria is recompiled with TupleBatch.BATCH_SIZE = 1

Myria should work with any value of BATCH_SIZE, but many unit tests fail when we set TupleBatch.BATCH_SIZE = 1. Most of these are buffer overflows, but the most concerning are assertion failures on values, e.g. on DupElimTest.

@parmitam has observed this on her Python UDF branch

fixed with blob and python udf support.


Support using static

I'm not sure which version of C# you're currently tracking, but using static would be really useful for creating bindings for JS that has global functions (for example, Jasmine). Currently if you try to use this, you get a compile error.
This code works fine:
using DanTup.Bridge.Jasmine;

namespace SampleTests.Tests
{
	public class SimpleTests
	{
		[Ready]
		public static void Test1()
		{
			Jasmine.Describe("A suite", () =>
			{
				Jasmine.It("contains spec with an expectation", () =>
				{
					Jasmine.Expect(true).ToBe(true);
				});
			});
		}
	}
}

However if you try importing the Jasmine class statically:
using static DanTup.Bridge.Jasmine.Jasmine;

namespace SampleTests.Tests
{
	public class SimpleTests
	{
		[Ready]
		public static void Test1()
		{
			Describe("A suite", () =>
			{
				It("contains spec with an expectation", () =>
				{
					Expect(true).ToBe(true);
				});
			});
		}
	}
}

You get the following build error:
The "GenerateScript" task failed unexpectedly.
System.NullReferenceException: Object reference not set to an instance of an object.
   at Bridge.Contract.EmitterException.get_FileName()
   at Bridge.Build.GenerateScript.Execute()
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__1.MoveNext()	SampleTests

All packages are already installed and there is nothing to restore.
1>------ Build started: Project: SampleTests, Configuration: Debug Any CPU ------
1>  SampleTests -> C:\Work\Source\DMS\DanTup.Bridge.Jasmine\SampleTests\bin\SampleTests.dll
1>C:\Work\Source\DMS\DanTup.Bridge.Jasmine\packages\Bridge.1.7.0\build\Bridge.targets(12,5): error MSB4018: The "GenerateScript" task failed unexpectedly.
1>C:\Work\Source\DMS\DanTup.Bridge.Jasmine\packages\Bridge.1.7.0\build\Bridge.targets(12,5): error MSB4018: System.NullReferenceException: Object reference not set to an instance of an object.
1>C:\Work\Source\DMS\DanTup.Bridge.Jasmine\packages\Bridge.1.7.0\build\Bridge.targets(12,5): error MSB4018:    at Bridge.Contract.EmitterException.get_FileName()
1>C:\Work\Source\DMS\DanTup.Bridge.Jasmine\packages\Bridge.1.7.0\build\Bridge.targets(12,5): error MSB4018:    at Bridge.Build.GenerateScript.Execute()
1>C:\Work\Source\DMS\DanTup.Bridge.Jasmine\packages\Bridge.1.7.0\build\Bridge.targets(12,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
1>C:\Work\Source\DMS\DanTup.Bridge.Jasmine\packages\Bridge.1.7.0\build\Bridge.targets(12,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__1.MoveNext()
========== Build: 0 succeeded, 1 failed, 1 up-to-date, 0 skipped ==========

The using static syntax functionality is part of the C# 6 language spec and will be included in Bridge 2.0.

Related #1435


fix: small optimization to add extra gaurd to updatePropDefaults

Description
Small optimization to withThemeStyles to make sure updatePropDefaults does not run if the styleManager does not have any props
Testing
Everything should work ask previously expected. The entire _updatePropDefaults method in withThemeStyles should not run each time a component is created unless props are defined in the theme.
Automation
NA
Checklist

[x] all commented code has been removed
[x] any new console issues have been resolved
[x] code linter and formatter has been run
[x] test coverage meets repo requirements
[x] PR name matches the expected semantic-commit syntax

Test Execution Failed.

Test Execution Failed.

:tada: This PR is included in version @lightningjs/ui-components-v2.20.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Performance improvement for io::inputbuffer

Do not add chars to string one by one.
In most cases, buffer size >= max line length.
Let's do it in one function call.

Can one of the admins verify this patch?

For input like:
"aaa\rbbb\r\n"
The old code will output: "aaabbb"
This new code will output: "aaa\rbbb"
I think this behavior change is acceptable. Do you?

Have you measured the performance improvement?
It certainly looks more efficient to me, but I'd like to weigh this against the cost of making a (probably irrelevant, but you never know...) backwards incompatible change.

Working. I'll post the result later.

input data: A text file in libsvm format,<PHONE_NUMBER>2 bytes, 164540416 lines, with CRLF line terminators
test code 1:
#include <mutex>
#include <Windows.h>
#include <stdio.h>

#include "tensorflow/core/platform/env.h"
#include "tensorflow/core/lib/core/errors.h"
#include "tensorflow/core/lib/io/inputbuffer.h"
using namespace tensorflow;

int test1(const char* filename) {
	LARGE_INTEGER li;
	QueryPerformanceFrequency(&li);
	Env* env = Env::Default();
	std::unique_ptr<RandomAccessFile> file_;
	const ::tensorflow::Status status = env->NewRandomAccessFile(filename, &file_);
	if (!status.ok()) {
		return -1;
	}
	LARGE_INTEGER startTime, endTime;
	int kBufferSize = 2 * 1024 * 1024;
	io::InputBuffer* input_buffer = new io::InputBuffer(file_.get(), kBufferSize);
	QueryPerformanceCounter(&startTime);
	string line_contents;
	while (true) {
		Status status = input_buffer->ReadLine(&line_contents);
		if (errors::IsOutOfRange(status)) {
			break;
		}
		if (!status.ok()) {
			return -1;
		}
	}
	QueryPerformanceCounter(&endTime);
	const double seconds = ((endTime.QuadPart - startTime.QuadPart) / (double)li.QuadPart);
	printf("dur = %g\n", seconds);
	return 0;
}

test code 2:
Almost the same as test code 1, with only one line change:
while (true) {
    string line_contents;  // this line is moved from the line before "while(true)"
    Status status = input_buffer->ReadLine(&line_contents);
}

Result:

Before
After
Changes

test1
67 seconds
26 seconds
 - 61%

test2(cache line_contents)
34 seconds
19 seconds
 - 44%

Great, thanks for confirming that. I'm satisfied with the change, so let's run the tests and merge if they pass.
@tensorflow-jenkins test this please.

@tensorflow-jenkins test this please.


Azure slots fix patch

This PR is necessary to add correct support for Azure WebApp Slots. It changes the URL so the request are in line with the Azure API.

@DanCech @daniellee  Could you merge this please.

@sylr on vacation this week and next but will review/merge this before the next release (the next release will be a large one that includes support for Log Analytics for Azure Monitor and for App Insights)

@daniellee could you merge this now ?

@daniellee could you please merge that

Thanks for the PR but I found a more general solution to solve this problem: https://github.com/grafana/azure-monitor-datasource/commit/1698a5bdc7505f8c8ae7838de85864f0b216763f
The fix is released in v0.1.2.


feat: drop axios requirement

Which problem is this PR solving?
Some users were unable to install this package due to issues with our transitive dependency on axios.
It turns out, though, that we don't really need axios for much. This PR removes it.
Short description of the changes
Drop axios, switch to standard fetch API
How to verify that this has the expected result

[x] unit tests pass
[x] Install into test repo, confirm ConsoleTraceLinkExporter still does what we think it does

@pkanal I added some smoke tests, let me know if you want me to change anything else.


Kubernetes cluster not scaling down once it gone to alert state

ISSUE TYPE

Bug Report

COMPONENT NAME

Kubernetes UI
CLOUDSTACK VERSION

4.18
CONFIGURATION

Advance Networking
OS / ENVIRONMENT

All runnig on Ubuntu 22.04
SUMMARY

My kubernetes cluster was configured for autoscale and when I deployed some 40 pods on the cluster it when to Alert state due to some resources. So I removed all pods from the cluster and restarted the cluster. Now cluster state is in Running status but all new nodes it spinned up is still running and scale down is not triggered.
STEPS TO REPRODUCE

Expected scale down has to be triggered and cluster should move to old state

@Noelantogerorge
I think this is same as #7920 , right ? cc @shwstppr

@weizhouapache
Yes it is same... I will close this and followup on #7920

@weizhouapache Yes it is same... I will close this and followup on #7920

cool.
btw thanks for the details in description


Chat history feature

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Expected/desired behavior
Currently chat history is not persisted. In an enterprise environment its critical to provide the ability to review/audit chat history.
Chat with your data repo has this feature: https://github.com/microsoft/sample-app-aoai-chatGPT

It looks like there was a PR 259 related to this, but several months back. I haven't tried it myself but I wonder if the approach is sound or if there's a reason it hasn't been included.

This would be really helpful. Any update ?

We now have a chat history feature that stores it in IndexedDB:
https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/docs/deploy_features.md#enabling-chat-history
I'll close this issue, but if you want Cosmos DB persistence, please subscribe/star/comment on this issue:
https://github.com/Azure-Samples/azure-search-openai-demo/issues/977


Change the text in the node settings if the address and port fields are empty

For example, in the case of a task https://github.com/BeamMW/beam/issues/1570 when our fields are empty, you should show the prompt "Please enter the address", " Please enter the port" rather than display the error that the address is invalid.

Checked.


docker-compose command fails when running mxnet predict

I am trying to run the local training mode for the mxnet_gluon_cifar10 example folder. I am able to run the training and all but when I try to deploy the predictor it does this.
predictor = m.deploy(initial_instance_count=1, instance_type='local_gpu')

Exception in thread Thread-4:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/sagemaker/local/image.py", line 542, in run
    _stream_output(self.process)
  File "/usr/local/lib/python3.6/dist-packages/sagemaker/local/image.py", line 604, in _stream_output
    raise RuntimeError("Process exited with code: %s" % exit_code)
RuntimeError: Process exited with code: 1

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/usr/local/lib/python3.6/dist-packages/sagemaker/local/image.py", line 547, in run
    raise RuntimeError(msg)
RuntimeError: Failed to run: ['docker-compose', '-f', '/tmp/tmpxkw6jkfy/docker-compose.yaml', 'up', '--build', '--abort-on-container-exit'], Process exited with code: 1

-----------------------------------------------------
RuntimeError        Traceback (most recent call last)
<ipython-input-22-09117cc2243b> in <module>
----> 1 predictor = m.deploy(initial_instance_count=1, instance_type='local_gpu')

/usr/local/lib/python3.6/dist-packages/sagemaker/estimator.py in deploy(self, initial_instance_count, instance_type, accelerator_type, endpoint_name, use_compiled_model, update_endpoint, wait, model_name, **kwargs)
    453             update_endpoint=update_endpoint,
    454             tags=self.tags,
--> 455             wait=wait,
    456         )
    457

/usr/local/lib/python3.6/dist-packages/sagemaker/model.py in deploy(self, initial_instance_count, instance_type, accelerator_type, endpoint_name, update_endpoint, tags, kms_key, wait)
    386         else:
    387             self.sagemaker_session.endpoint_from_production_variants(
--> 388                 self.endpoint_name, [production_variant], tags, kms_key, wait
    389             )
    390

/usr/local/lib/python3.6/dist-packages/sagemaker/session.py in endpoint_from_production_variants(self, name, production_variants, tags, kms_key, wait)
   1216
   1217             self.sagemaker_client.create_endpoint_config(**config_options)
-> 1218         return self.create_endpoint(endpoint_name=name, config_name=name, tags=tags, wait=wait)
   1219
   1220     def expand_role(self, role):

/usr/local/lib/python3.6/dist-packages/sagemaker/session.py in create_endpoint(self, endpoint_name, config_name, tags, wait)
    877
    878         self.sagemaker_client.create_endpoint(
--> 879             EndpointName=endpoint_name, EndpointConfigName=config_name, Tags=tags
    880         )
    881         if wait:

/usr/local/lib/python3.6/dist-packages/sagemaker/local/local_session.py in create_endpoint(self, EndpointName, EndpointConfigName, Tags)
    185         endpoint = _LocalEndpoint(EndpointName, EndpointConfigName, Tags, self.sagemaker_session)
    186         LocalSagemakerClient._endpoints[EndpointName] = endpoint
--> 187         endpoint.serve()
    188
    189     def update_endpoint(self, EndpointName, EndpointConfigName):  # pylint: disable=unused-argument

/usr/local/lib/python3.6/dist-packages/sagemaker/local/entities.py in serve(self)
    397
    398         serving_port = get_config_value("local.serving_port", self.local_session.config) or 8080
--> 399         _wait_for_serving_container(serving_port)
    400         # the container is running and it passed the healthcheck status is now InService
    401         self.state = _LocalEndpoint._IN_SERVICE

/usr/local/lib/python3.6/dist-packages/sagemaker/local/entities.py in _wait_for_serving_container(serving_port)
    426         i += 5
    427         if i >= HEALTH_CHECK_TIMEOUT_LIMIT:
--> 428             raise RuntimeError("Giving up, endpoint didn't launch correctly")
    429
    430         logger.info("Checking if serving container is up, attempt: %s", i)

RuntimeError: Giving up, endpoint didn't launch correctly

When I try to run the command that's failing in the terminal I get...
docker-compose -f /tmp/tmpxkw6jkfy/docker-compose.yaml up --build
Starting tmpxkw6jkfy_algo-1-t97fn_1 ... error

ERROR: for tmpxkw6jkfy_algo-1-t97fn_1  Cannot start service algo-1-t97fn: driver failed programming external connectivity on endpoint tmpxkw6jkfy_algo-1-t97fn_1 (6f76b65eb55ea66367751d02512449f518d9575f1b73449c5ee145c8c9ce8728): Bind for <IP_ADDRESS>:8080 failed: port is already allocated

ERROR: for algo-1-t97fn  Cannot start service algo-1-t97fn: driver failed programming external connectivity on endpoint tmpxkw6jkfy_algo-1-t97fn_1 (6f76b65eb55ea66367751d02512449f518d9575f1b73449c5ee145c8c9ce8728): Bind for <IP_ADDRESS>:8080 failed: port is already allocated
ERROR: Encountered errors while bringing up the project.

I am able to get it to work if I edit the yaml file manually but im guessing it needs to run with the predictor code. I cannot change the port number for the generated yaml file. It just creates a new one with port 8080 each time. Is there a way to configure it to use a different default port/

Ok so this is working now but now I'm getting a different but related issue.


Using Azure CDN with SAS and Rules Engine v4.0

The tutorial of using Azure CDN together with Verizon Premium seems to be outdated for the Rules Engine v4.0.

If I strictly follow the tutorial (Option 2), I get the this error:

I found (https://stackoverflow.com/questions/58697519/azure-cdn-verizon-custom-rewrite-rule-invalid-origin) that you have to set the origin and destination URL manually, and it can be extracted from this Rule

If I do so, the policy gets accepted and can be deployed

Unfortunately, the regex is ignored, presumably since the "/" should have been escaped in Source and Destianation fields, cf. https://docs.vdms.com/cdn/Content/HRE/F/URL-Rewrite.htm
If I try to escape the slash, I get the same error as shown above.

What would be the correct procedure, of using Azure CDN with SAS in the Rules Engine v4.0? Is there a way to do it with the azure-cli (https://stackoverflow.com/questions/62093666/what-is-the-correct-azure-cli-command-for-creating-http-rules-on-cdn-endpoints), or can you achieve the same goal using the Standard Rules Engine in Azure CDN with Microsoft Standard?
Thank you very much in advance for your help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: be0f8fa5-b31c-17fc-64ee-e1b77f4f1389
Version Independent ID: 24461bb6-a8ac-65e8-db24-fd359cab4130
Content: Using Azure CDN with SAS
Content Source: articles/cdn/cdn-sas-storage-support.md
Service: azure-cdn
GitHub Login: @asudbring
Microsoft Alias: allensu

@vpohl  Thank you for your feedback . We will investigate and update the thread.

Update: The procedure described in post above works. It takes several hours for the rules to take effect. But still, the documentation is outdated and it is not clear to me which characters do and which do not need to be escaped in the regex.
Furthermore, is it possible to interact with RulesEngine via the azure-cli or an API?

@vpohl We are reaching out to the author for more details on this.
@asudbring Could you please help review the ask on this issue and see how best the documentation can be improved.

I am also having a ton of issues with this and can't get the URL Rewrite to work at all.  The documentation is all over the place, but that looks like that is on the path to resolution.
@vpohl What worked finally?  I thought I had done it like you suggested but it is still not working after waiting about 18 hours.  Here is what I did since escaping the slashes caused the issue you mentioned:

It worked as described above except that I had to additionally match the query parameters in the source URL and insert those in the Destination after the SAS token using &.

It worked as described above except that I had to additionally match the query parameters in the source URL and insert those in the Destination after the SAS token using &.

This totally worked, thanks for the extra tip, documentation really does need updating.  Really appreciate the assistance.

Sending to PM for review
#reassign:@mdgattuso

I am also having a ton of issues with this and can't get the URL Rewrite to work at all. The documentation is all over the place, but that looks like that is on the path to resolution.
@vpohl What worked finally? I thought I had done it like you suggested but it is still not working after waiting about 18 hours. Here is what I did since escaping the slashes caused the issue you mentioned:

Hi Guys, I'm trying this but it's not working for me. :S does it need the "&" to concatenate the sas token?

Ah yeah, it's still messy ha.  You need to put your source information at the end of our destination.  Let me see if I can write out the whole solution:
Source: ///(.*)
Destination: ///$1?&
Like, literally just slap the whole text of the Source after your SAS token with an ampersand between.

Source: ///(.*)
Destination: ///$1&

So you mean  : Destination: ///$1?sv=123123xxx123&///(.*)
SHould I include (.*) as well?

Yup, include the (.*).  After the & it should be exactly what is in your Source field.

@kainzuu Hero!, you were right, it started to work (after some hours) :D i don't know what kind of dark magic was this but the rwrite is working.
The new challenge appears, as the rewrite is returning an insecure file i got "insecure file" to "myazuredge.net". I found this https://www.itinsights.org/Static-Websites-with-Azure-Part-1/ so I'm on it... if there is a better way, i'm open to anything at this point. Thanks!

Try to create a Rule with Origin
you can find your Origin
then delete the Rule

Any update on this?

Any update on this?

I am also having a ton of issues with this and can't get the URL Rewrite to work at all. The documentation is all over the place, but that looks like that is on the path to resolution.
@vpohl What worked finally? I thought I had done it like you suggested but it is still not working after waiting about 18 hours. Here is what I did since escaping the slashes caused the issue you mentioned:

Hi Guys, I'm trying this but it's not working for me. :S does it need the "&" to concatenate the sas token?

Hello guys - I am using the url rewrite in combination with cdn token. Url rewrite works fine but when I enable token auth and try to pass token it does not work. any idea how I can get this work?
Here is the rule I am trying

Hey! I got my cdn working with one regex suggested from Verizon team when i requested help on this.
They told me to use (.*.\w+) which helps with some especial chars.

(.*.\w+)

It didn't work for me. I keep getting same error -

AuthenticationFailed
Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. RequestId:3075e1f2-b01e-0094-7027-ff8fec000000 Time:2021-02-09T21:03:42.8087282Z
sr is mandatory. Cannot be empty

Did you copy the one from picture? (. * \ . \ w + )

Hi guys,
I've tried to append the CDN auth token after storage SAS in rewrite rule but it doesn't work for me.
Source: /CDNBase/CustomerOrigin/(container/.)?(.)
Destination: /CDNBase/CustomerOrigin/$1?SAS&$2
I can see in %{query_string} that SAS and CDN tokens concatenated, but still getting 403 from CDN.
Any ideas?
TA

I don't know much about using the Auth token but here https://docs.microsoft.com/en-us/azure/cdn/cdn-token-auth looks like they are adding a second rw rule for that. Anyways, why do you want to use it, if you're already using a SAS token? to improve security, i'm not sure but, maybe, you can limit the access to storage account only fron Verizon CDN's IP range or disable "public access" in storage account, accesing just with an registered Identity.

Did you copy the one from picture? (. * \ . \ w + ) (without spaces)

Yes. This is my configuration -
<feature.url.url-rewrite source="/0000000F/s-cdn-dev/(.*.\w+)" destination="/0000000F/s-cdn-dev/$1?sv=2019-12-12&ss=b&srt=sco&sp=rlx&se=2050-02-09T05:06:08Z&st=2021-02-07T21:06:08Z&spr=https&sig=ssSSS8SS5sSssS7SS7SssssKGlo%2B6Dya3%2SdImSuhSz4%3S"/>

I don't know much about using the Auth token but here https://docs.microsoft.com/en-us/azure/cdn/cdn-token-auth looks like they are adding a second rw rule for that. Anyways, why do you want to use it, if you're already using a SAS token? to improve security, i'm not sure but, maybe, you can limit the access to storage account only fron Verizon CDN's IP range or disable "public access" in storage account, accesing just with an registered Identity.

We have requirement to secure some content only for logged in users. We are planning to serve them only to urls with dynamically generated short living tokens.

Assigning to PM for review
#reassign:@amitsriva

GitHub user mdgattuso has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

Any update on CLI commands to enable rewrite URL rules on Verizon Premium SKU?

I was able to fix the issue. As Url rewrite is used in combination with the token authentication, the regex for url rewrite should be written in this way -
<feature.url.url-rewrite source="/0000000F/s-cdn-dev/(.*.\w+)" destination="/0000000F/s-cdn-dev/$1**&**sv=2019-12-12&ss=b&srt=sco&sp=rlx&se=2050-02-09T05:06:08Z&st=2021-02-07T21:06:08Z&spr=https&sig=ssSSS8SS5sSssS7SS7SssssKGlo%2B6Dya3%2SdImSuhSz4%3S"/>
Note the & instead of ? here - destination="/0000000F/s-cdn-dev/$1**&**sv=2019-12. As token is passed in query parameter by client, url rewrite should append the sas token with &

Try to create a Rule with Origin
you can find your Origin see the Value inspect the browser html to copy the text from the dropdown
then delete the Rule

What if the origin isn't available at all for some mysterious reason?

#reassign: gunjanj

Any update on CLI commands to enable rewrite URL rules on Verizon Premium SKU?
Or ARM/Biceps templates?
Any API to apply the Rules Engine v4.0 rewrite URL rules from CD pipelines?

Any update for this?
Unfortunately after two years the documentation remains outdated.
I applied the approaches mentioned above and I'm awaiting several hours, but rules remains not working.

It's been almost one whole year and this documentation is still out of date

I was able to fix the issue. As Url rewrite is used in combination with the token authentication, the regex for url rewrite should be written in this way - <feature.url.url-rewrite source="/0000000F/s-cdn-dev/(.*.\w+)" destination="/0000000F/s-cdn-dev/$1&sv=2019-12-12&ss=b&srt=sco&sp=rlx&se=2050-02-09T05:06:08Z&st=2021-02-07T21:06:08Z&spr=https&sig=ssSSS8SS5sSssS7SS7SssssKGlo%2B6Dya3%2SdImSuhSz4%3S"/>
Note the & instead of ? here - destination="/0000000F/s-cdn-dev/$1&sv=2019-12. As token is passed in query parameter by client, url rewrite should append the sas token with &

Thank you! I've been fighting with this since yesterday, and it was all because of that ? instead of the &. It actually didn't make sense to me why I should be using a ? if I was appending the token, and now everything makes sense. Thank you!

Thank you for you dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We will create an internal tracking work item to address this issue. For now, we are closing this issue. If you have any additional information you would like to provide, please respond to this issue with any additional details.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


Can we start using nix 2.4?

I can't repro the issue locally so I'm hoping a bump can make CI pass.

@zupo I think may have just been flaky.

All but the unstable passes now

@zupo I think may have just been flaky.

Maybe the fix got pushed in the recent cachix action or niv updates. We just got lucky, someone else fixed it for us? :)
That said, we need unstable to work too before we can merge it, otherwise, we don't get any new unstable images, and we need them.

We're not going to do this until nixpkgs stable channel upgrades to nix 2.4.


SW-5477 Updated useEffect deps to eliminate scroll bounce on Support Forms

#2693  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite


implements? is a macro - can't use with partial

implements? can't be partially applied - so wrap it in a function instead
this PR isn't against the develop branch because #108 isn't merged there yet

Hey thanks for catching this, I really appreciate it. I've fixed this on the dynamic-subscriptions branch directly (I just rescued the previous commit I had which took this approach).
Thanks!


Windowing again

Pull request
Description
Clean up the windowing code
Related

Related docs PR

Checklist

[x] The RFC, if required, has been submitted and approved
[x] Any user-facing impact of the changes is reflected in docs.tremor.rs
[x] The code is tested
[x] Use of unsafe code is reasoned about in a comment
[x] Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
[x] The performance impact of the change is measured (see below)

Performance
Within run to run variance of main

Coverage increased (+0.3%) to 84.826% when pulling 77e96dffe08be78155af2153243aca821c278a7c on windowing-again into 5fae67d137303dc48f95315446ec261f763e1997 on main.


micro-events : SystemData should include the correlation id

SystemData captures metrics for active jobs. The correlation id past into ActiveEvents is not stored on SystemData, so any subscribers to the jobs Guava EventBus can't correlate back the exact event triggered.
Correlation id should be included in SystemData.

released in 0.78


Verify CouchDB Installation fails with create view

Description
I'm trying to verify the installation but I get a server error

Expected Behaviour
the verification process is expected to run successfully

CouchDB version used: v. 3.3.3
Browser name and version: [Chrome 125 on Windows 11]
Operating system and version: windows 11

Hi,
on Windows you need to bind the chttp interface to <IP_ADDRESS> or to your real ip.
[chttpd]
bind_address = <IP_ADDRESS>

i still get the same issue,

Can you show your config from Fauxton or via command line like (maybe you need to install curl for Windows):
curl.exe -s --user user:password http://<IP_ADDRESS>:5984/_node/_local/_config

Could you append your log file too?

I figured out that Avira is blocking couchspawnkillable.exe, i restored the file and now create view is working just fine


App can crash if relaunched manually during update installation

It's unclear the exact set of circumstances that can cause this, but relaunching the parent application too quickly (i.e., when update installation has begun but not completed) can result in crashes from trying to load incorrect nibs, and probably other resources too.
We could maybe fix this by having Squirrel automatically abort installation if it notices that the application has started again.

@jspahrsummers

there's already a tiny window where it can go missing

Does it depend on the size of the App? Our App is around 300 MB and it takes around 16-30 seconds when I am using SSD for the updated App to start launching. I am guessing this number would be much higher for hard disk drives.
Did you find any workaround to avoid this?

@harryi3t This thread is more than five years old. I'm afraid I don't have the context here anymore.

I'm facing the exact same problem described here, and I believe the bundle size and bundle file counts matters

Facing this issue in 2023 when using electron. To reproduce the issue:

Launch the app, wait for update download complete
Quit the app to proceed update
Launch the app again immediate, before the update complete. This will bring up the non-updated version
Close the app window (not quit)
When the update complete, open the app (as the app was not quit, the app process is still the old version, but the old app's Resources are already gone) , the OS will say "The app is damaged and can't be opened. You should move it to the Bin"
Once you move it to the bin, you will get the same error whenever reinstalling the app from dmg, until you reboot the machine.


Swiftmailer 6 compatibility

Hi, Any plan to support swiftmailer 6 ?
getting Composer conflicts when trying to install
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: don't install mailjet/mailjet-bundle 1.0.5
    - Conclusion: don't install mailjet/mailjet-bundle 1.0.4
    - Conclusion: don't install mailjet/mailjet-bundle 1.0.3
    - Conclusion: don't install mailjet/mailjet-bundle 1.0.2
    - Conclusion: don't install mailjet/mailjet-bundle 1.0.1
    - Conclusion: remove swiftmailer/swiftmailer v6.1.3
    - Installation request for mailjet/mailjet-bundle ^1.0 -> satisfiable by mailjet/mailjet-bundle[1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5].
    - Conclusion: don't install swiftmailer/swiftmailer v6.1.3
    - mailjet/mailjet-bundle 1.0.0 requires mailjet/mailjet-swiftmailer ^1.0 -> satisfiable by mailjet/mailjet-swiftmailer[1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6].
    - mailjet/mailjet-swiftmailer 1.0.0 requires swiftmailer/swiftmailer ~5.4 -> satisfiable by swiftmailer/swiftmailer[v5.4.0, v5.4.1, v5.4.10, v5.4.11, v5.4.12, v5.4.2, v5.4.3, v5.4.4, v5.4.5, v5.4.6, v5.4.7, v5.4.8, v5.4.9].
    - mailjet/mailjet-swiftmailer 1.0.1 requires swiftmailer/swiftmailer ~5.4 -> satisfiable by swiftmailer/swiftmailer[v5.4.0, v5.4.1, v5.4.10, v5.4.11, v5.4.12, v5.4.2, v5.4.3, v5.4.4, v5.4.5, v5.4.6, v5.4.7, v5.4.8, v5.4.9].
    - mailjet/mailjet-swiftmailer 1.0.2 requires swiftmailer/swiftmailer ~5.4 -> satisfiable by swiftmailer/swiftmailer[v5.4.0, v5.4.1, v5.4.10, v5.4.11, v5.4.12, v5.4.2, v5.4.3, v5.4.4, v5.4.5, v5.4.6, v5.4.7, v5.4.8, v5.4.9].
    - mailjet/mailjet-swiftmailer 1.0.3 requires swiftmailer/swiftmailer ~5.4 -> satisfiable by swiftmailer/swiftmailer[v5.4.0, v5.4.1, v5.4.10, v5.4.11, v5.4.12, v5.4.2, v5.4.3, v5.4.4, v5.4.5, v5.4.6, v5.4.7, v5.4.8, v5.4.9].
    - mailjet/mailjet-swiftmailer 1.0.4 requires swiftmailer/swiftmailer ~5.4 -> satisfiable by swiftmailer/swiftmailer[v5.4.0, v5.4.1, v5.4.10, v5.4.11, v5.4.12, v5.4.2, v5.4.3, v5.4.4, v5.4.5, v5.4.6, v5.4.7, v5.4.8, v5.4.9].
    - mailjet/mailjet-swiftmailer 1.0.5 requires swiftmailer/swiftmailer ~5.4 -> satisfiable by swiftmailer/swiftmailer[v5.4.0, v5.4.1, v5.4.10, v5.4.11, v5.4.12, v5.4.2, v5.4.3, v5.4.4, v5.4.5, v5.4.6, v5.4.7, v5.4.8, v5.4.9].
    - mailjet/mailjet-swiftmailer 1.0.6 requires swiftmailer/swiftmailer ~5.4 -> satisfiable by swiftmailer/swiftmailer[v5.4.0, v5.4.1, v5.4.10, v5.4.11, v5.4.12, v5.4.2, v5.4.3, v5.4.4, v5.4.5, v5.4.6, v5.4.7, v5.4.8, v5.4.9].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.0, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.1, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.10, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.11, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.12, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.2, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.3, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.4, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.5, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.6, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.7, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.8, v6.1.3].
    - Can only install one of: swiftmailer/swiftmailer[v5.4.9, v6.1.3].
    - Installation request for swiftmailer/swiftmailer (locked at v6.1.3) -> satisfiable by swiftmailer/swiftmailer[v6.1.3]

Thanks

There is a branch on mailjet/mailjet-swiftmailer for Swiftmailer 6.0 https://github.com/mailjet/MailjetSwiftMailer/tree/upgradeToSwiftmailer6 but not in this bundle

ping @mailjet/api-community

working fork here btw: https://github.com/saloonio/mailjetBundle

@Nightbr thank you for this fork but impossible to install your fork, I tried this tutorial without success.
Here my composer.json
 ...
  },
        ...
        {
            "type": "vcs",
            "url": "https://github.com/saloonio/mailjetBundle"
        }
    ],
    "require": {
        "php": "^7.1",
        ...
        "mailjet/mailjet-bundle": "dev-master",
        ...

How did you achieve this?

In your composer.json
In require:
"mailjet/mailjet-bundle": "dev-master",
"mailjet/mailjet-swiftmailer": "dev-upgradeToSwiftmailer6",

And in repositories:
 "repositories": [
        {
            "type": "git",
            "url": "https://github.com/saloonio/mailjetBundle.git"
        },
        {
            "type": "vcs",
            "url": "https://github.com/mailjet/MailjetSwiftMailer"
        }

    ],

I did it but I have this
Package operations: 0 installs, 1 update, 0 removals
  - Updating mailjet/mailjet-bundle dev-master (d79bb7a => b733f4c):  Checking out b733f4c28c

remove your vendor folder, it seems to be a cache problem.

Thank you it worked when I require "mailjet/mailjet-swiftmailer": "dev-upgradeToSwiftmailer6", also maybe a stupid question (and not related to this issue) but do you know why?

When you require, it refresh your composer.lock and it will override the old mailjet/mailjet-swiftmailer#master in your vendor folder :ok_hand:

The current version of the wrapper is compatible with Swiftmailer 6, so I'm closing this issue.


Disconnect event never callback

Because clear() is called before the callback, the disconnect event will not be called back.

I think you're right. This is a problem.


Facebook login

How i can login with facebook ? My setup is angular 5 in firebase hosting as www.xxxxx.com and my meteor backend in AWS elastic beanstalk as api.xxxxx.com

You can see Meteor's documentation about Facebook login.
https://guide.meteor.com/accounts.html#oauth-logging-in

@ardatan  this dont work for me example.
@Urigo can u help me please?
Thanks

@katusiky can you please create a reproduction on Github and share it here?


Fix unit tests

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
✔

Fixed issues
Fix tests

👍


Incorrectly parsing ''(Note text)'' in paths

From PCGamingWiki:Editing guide/Game data:

If it is felt to be needed to add notes on specific game versions, this can be done after the filepath with {{note|Note text}} or ''(Note text)''.

Ludusavi's manifest should be ignoring the '' notes, but it is instead interpreting them as part of the path. This is used on the Minecraft: Bedrock Edition page to indicate paths for Minecraft Preview.

Thanks for the report! I just fixed this.


Build tweaks

Getting the site running locally can be kind of difficult.  Also, debugging install issues is harder because they are hidden behind npm install scripts.
This PR:

strips back the required gems
separates out the build steps so that the site can be served without the optimisation dependencies

Still fails trying to install charlock_holmes (0.7.3) with
***************************************************************************************
*********** icu required (brew install icu4c or apt-get install libicu-dev) ***********
***************************************************************************************

Weird - charlock_holmes is no longer in the Gemfile.lock..  hmm

Would you be able to pop the entire bundler output somewhere? (here's mine)

Here you go @benfoxall

Ugh!  Was on the wrong branch!
I do still get an error fetching gems Gem::RemoteFetcher::FetchError: SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed (https://rubygems.org/gems/coffee-script-source-<IP_ADDRESS>.gem) but changing the first line of the Gemfile to source 'http://rubygems.org' fixes works around this for me.


Empty string becoming null when modifying YAML

I use dasel in a helm filter to modify template for k8s.
Unfortunately modifying YAML ends in empty string becoming null.
How to reproduce
foo.yaml:
kind: ConfigMap
data:
  foo: hello
  script:
  namespace: myworld
---
kind: xvdcscd
data:
  foo: bar

Now modify:
cat foo.yaml |  dasel put -t string -v "bar" -r yaml -h  'all().filter(equal(kind,ConfigMap)).data.foo'

Now watch the value for key script
kind: ConfigMap
data:
  foo: bar
  script: null
---
kind: xvdcscd
data:
  foo: bar

Version
Tested on Linux AMD64, dasel version v2.7.0
I just downloaded that release after I encountered the bug with an older release (some weeks old).
What else?
If this is standard behavior it would be nyce to add a command-line flag to change this. Dasel is far easier to use then kustomize. Also tools like jq/yq/oq don't help since they cannot parse manifests divided by '---'.

Workaround
For the moment I added an additonal pipe with:
dasel put -t string -v "" -r yaml -w yaml  'all().filter(equal(kind,ConfigMap)).data.all().filter(equal(.,null))'

But workarounds are not a solution since they don't solve the original problem but cure the effect ;)

Hey @blurayne, my guess this is how the yaml parser is interpreting the value.
Does it help if you change the original file to be value: ""?

Nope. In the original I had
key: |

with just a newline. Reading via dasel -r yaml -w plain gave BOM plus newline. So I guess it happens somewhere between.

Thanks for the info. I'll do some digging when I get a chance


:sparkles: Adds markdown language support

I added markdown language support using the https://github.com/remarkjs/remark-lint
markdown linter.

anything we can do to get this merged?

@rickstaa Thank you! ✌

Hi, @rickstaa! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨
We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.
Thanks again!


Re-calculate historical risk score

Description
Related to https://github.com/DependencyTrack/dependency-track/issues/2824 , this issue is to allow the custom weights of risk scores to be re-calculated.
Addressed Issue
Related to https://github.com/DependencyTrack/dependency-track/issues/2824
Front end issue to go along with this is https://github.com/DependencyTrack/hyades-frontend/pull/94
Additional Details
Adds a new endpoint to tell the database to recalculate with /riskscore/refresh. If there's a better approach for this, I'm all ears!
This PR is draft, I have a few questions / open ended items:

I'm not super experienced with SQL so I'm confused about how to write the new SQL. i'm not sure how to define the columns to make sure the risk scores are recalculated throughout the DEPENDENCYMETRICS table. I have pgadmin set up and connected to the hyades database, but i'm unable to run a query of the sql as it is, or even just the "update" part.
I need to only run this recalculation if weight.history.enabled is True, don't run this when false. Where would this logic be done?
Tests haven't been added yet

Checklist

[x] I have read and understand the contributing guidelines
[ ] This PR fixes a defect, and I have provided tests to verify that the fix is effective
[ ] This PR implements an enhancement, and I have provided tests to verify that it works as intended
[ ] This PR introduces changes to the database model, and I have updated the migration changelog accordingly
[ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

I have pgadmin set up and connected to the hyades database, but i'm unable to run a query of the sql as it is, or even just the "update" part.

Can you share some more details on the issues you're encountering? What are you trying, and is pgadmin showing any errors?

i'm not sure how to define the columns to make sure the risk scores are recalculated throughout the DEPENDENCYMETRICS table.

I'll try to provide some guidance below.

In general I think the whole thing becomes easier if you don't use a stored procedure for this. The SQL you already have:
UPDATE "DEPENDENCYMETRICS" SET "v_risk_score" = "CALC_RISK_SCORE"("v_critical", "v_high", "v_medium", "v_low", "v_unassigned");

can be rewritten to the following:
UPDATE "DEPENDENCYMETRICS"
   SET "RISK_SCORE" = "CALC_RISK_SCORE"("CRITICAL", "HIGH", "MEDIUM", "LOW", "UNASSIGNED_SEVERITY")

There is no need to declare any input or output variables, the RDBMS will execute the above as-is, and update the risk score of all records in the DEPENDENCYMETRICS table accordingly.
As for how to execute the query, the main way we interact with the database now is via JDBI. It should also "just work" in pgadmin, provided you have data in your DEPENDENCYMETRICS table.
There are multiple ways to use JDBI, but the fluent API is probably the easiest. You can find an example here:
https://github.com/DependencyTrack/hyades-apiserver/blob/f36392b16e5b7eca0ac42c52d377036b4878dc57/src/test/java/org/dependencytrack/resources/v1/AnalysisResourceTest.java#L808-L820
(Ignore the query in the example above, just want to showcase how to use createUpdate with JDBI)

I personally find that working on something like this is easiest in a test-driven way:

Create a test that sets up your input data. In your case, you need a project, a component in that project, and an existing DependencyMetrics record for the component.
Execute your new code on the dataset above.
Assert that the dataset has changed according to your expectation. In your case, you will want to ensure that the riskScore values were updated correctly.

You can take inspiration from the existing metrics update tests.

I need to only run this recalculation if weight.history.enabled is True, don't run this when false. Where would this logic be done?

Add this as a check to the new HistoricalRiskScoreUpdateTask. Consider logging a warning when the task is executed, but the feature itself is disabled.

Tests haven't been added yet

See above. Getting tests set up will help you in developing the feature. Let me know if you need more help with that.


[BugFix] Reset current database after using catalog

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #18862
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[x] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[ ] 2.4
[ ] 2.3

run starrocks_be_unittest

run starrocks_admit_test

run starrocks_admit_test

run starrocks_be_unittest

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_admit_test

run starrocks_fe_unittest

run starrocks_admit_test

run starrocks_admit_test

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 8 / 10 (80.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
8
10
80.00%
[3237, 3250]

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test


Multiple dex files define

Hiya! So you think it's broken or missing a feature eh?
Welllllll, it just might be.  Do me a favor and check the following.

[ ] Issue does not already exist
Identify exactly what aspect your issue is about

[ ] ignite base application
[ ] ignite the cli
[ ] ignite generated code

:app:dexDebug
Unknown source file : UNEXPECTED TOP-LEVEL EXCEPTION:
Unknown source file : com.android.dex.DexException: Multiple dex files define La
ndroid/support/v7/appcompat/R$anim;
Unknown source file :   at com.android.dx.merge.DexMerger.readSortableTypes(DexM
erger.java:596)
Unknown source file :   at com.android.dx.merge.DexMerger.getSortedTypes(DexMerg
er.java:554)
Unknown source file :   at com.android.dx.merge.DexMerger.mergeClassDefs(DexMerg
er.java:535)
Unknown source file :   at com.android.dx.merge.DexMerger.mergeDexes(DexMerger.j
ava:171)
Unknown source file :   at com.android.dx.merge.DexMerger.merge(DexMerger.java:1
89)
Unknown source file :   at com.android.dx.command.dexer.Main.mergeLibraryDexBuff
ers(Main.java:502)
Unknown source file :   at com.android.dx.command.dexer.Main.runMonoDex(Main.jav
a:334)
Unknown source file :   at com.android.dx.command.dexer.Main.run(Main.java:277)
Unknown source file :   at com.android.dx.command.dexer.Main.main(Main.java:245)
Unknown source file :   at com.android.dx.command.Main.main(Main.java:106)
:app:dexDebug FAILED
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:dexDebug'.

com.android.ide.common.process.ProcessException: org.gradle.process.internal.E
xecException: Process 'command 'C:\Program Files\Java\jdk1.8.0_60\bin\java.exe''
finished with non-zero exit value 2

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

BUILD FAILED
Total time: 44.965 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/android-setup.html

what version of ignite?  Probably a duplicate of #362

1.7.1

Works like a charm! Thanks!

   But this seems to be a new issue with latest Android.  I might have to create a script that helps clean things up and include it in the scripts, but glad it is fixed!
Cheers!

Blog article on the clean process:
https://patternsandpractices.wordpress.com/2016/10/19/easy-way-to-make-react-native-run-android-work/

Hit this on the latest as of 2016-10-21...
Followed the blog article above.   Perfect except is linux or osx.  Clean is "./gradlew clean"

I'm adding this code to 1.9.2 in the hopes of killing this issue.

AND

looks to me that you haven't setup ANDROID_HOME just yet
https://facebook.github.io/react-native/docs/getting-started.html#3-set-up-paths


fix cogvlm vl template

Motivation
fix cogvlm vl template brought by https://github.com/InternLM/lmdeploy/pull/1741
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

fixed！

PR #1652 addresses this issue

fixed in #1652