injector changes for health check, pilot agent take over app readiness check.

Injector part for https://github.com/istio/istio/issues/9150

Figure out the application probing path and port and fill that in the sidecar tmpl.
Rewrite the app liveness and readiness probe.

The part to figure out the statusPort is ugly, but considering the sidecartmpl can come from configmap, I don't think there's a better way. Feel free to comment.
Won't merge util https://github.com/istio/istio/pull/9204 is merged. Will add a E2E test before merging as well.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold
Add hold just to address e2e test.

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a38602d11bbbae22763acf500f47078158a64348
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
200b602c04ba44fdade8932710df854380c64cea
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
200b602c04ba44fdade8932710df854380c64cea
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
200b602c04ba44fdade8932710df854380c64cea
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
200b602c04ba44fdade8932710df854380c64cea
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
200b602c04ba44fdade8932710df854380c64cea
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth-mcp.sh
200b602c04ba44fdade8932710df854380c64cea
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Any update?

@wattli I got the basic example working, readiness health check work under mTLS enabled for a pod. But still need some polishing for some corner cases handling.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: ayj, greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @ayj @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
istioctl/OWNERS
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
200b602c04ba44fdade8932710df854380c64cea
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth-mcp.sh
200b602c04ba44fdade8932710df854380c64cea
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
bf01af9c13ef0368ccbed0c67a144bfc1e5fcaa6
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
200b602c04ba44fdade8932710df854380c64cea
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth-mcp.sh
200b602c04ba44fdade8932710df854380c64cea
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
bf01af9c13ef0368ccbed0c67a144bfc1e5fcaa6
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
bf01af9c13ef0368ccbed0c67a144bfc1e5fcaa6
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
49ec933dbc653d1f5042a800642042661ea6c98e
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/hold cancel
While the tests needs to be fixed, I think this PR is ready for review. PTAL @mandarjog @ayj thanks!

@incfly I have a doubt: when have multi-containers, and each has a readiness probe.
Seems appReadyUrl only support one url redirect.

Another thought:

remove --appReadyUrl and --appLiveUrl and only rewrite the probe port with 10250.

in pilot-agent, status server uses a wilcard prefix "/" match. And acquire req.RequestURI in handler. Use it as the probe path

The only issue left is how we can get the probe port, we can try each port in --applicationPorts.

I think this way is easy for users.

Another thought:

remove --appReadyUrl and --appLiveUrl and only rewrite the probe port with 10250.
in pilot-agent, status server uses a wilcard prefix "/" match. And acquire req.RequestURI in handler. Use it as the probe path
The only issue left is how we can get the probe port, we can try each port in --applicationPorts.

I think this way is easy for users.

Great point. I like the idea of rewriting probe port with 10502 directly, instead of doing encoding of multi containers url paths into --appReadyUrl.
However, I feel we don't want to enumerate all ports for the same path from applicationPorts, because that subjects to ambiguity, for example, if port 8000 fails and 8001 succeeds, what should pilot agent think? We have two options to avoid that

Put a http header in httpHeader sections indicate this, using reserved header name, saying "appProbePort: 8000"
Rewrite url path to encode appProbe port as well. Could be :15020/8000/original_probe_path

Comments? @mandarjog @hzxuzhonghu

Rewrite url path to encode appProbe port as well. Could be :15020/8000/original_probe_path

I like this, more clear.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
49ec933dbc653d1f5042a800642042661ea6c98e
link
/test e2e-simpleTests

prow/istio-unit-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
49ec933dbc653d1f5042a800642042661ea6c98e
link
/test e2e-simpleTests

prow/istio-unit-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
49ec933dbc653d1f5042a800642042661ea6c98e
link
/test e2e-simpleTests

prow/istio-unit-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-simpleTests-cni

prow/build-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test build-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-simpleTests-cni

prow/build-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test build-tests

prow/istio-integ-k8s-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-simpleTests-cni

prow/build-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test build-tests

prow/istio-integ-k8s-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-simpleTests-cni

prow/build-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test build-tests

prow/istio-integ-k8s-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-simpleTests-cni

prow/build-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test build-tests

prow/istio-integ-k8s-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/build-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test build-tests

prow/istio-integ-k8s-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-mixer-no_auth-mcp

prow/e2e-simpleTests-cni.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-mixer-no_auth-mcp

prow/e2e-simpleTests-cni.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test e2e-simpleTests-cni

prow/build-tests.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test build-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test e2e-mixer-no_auth-mcp

prow/e2e-simpleTests-cni.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test e2e-simpleTests-cni

prow/build-tests.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test build-tests

prow/e2e-dashboard.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
027c4e3668f7109668a574d994a53850c246fcc8
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests-cni.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test e2e-simpleTests-cni

prow/build-tests.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test build-tests

prow/e2e-dashboard.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/build-tests.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test build-tests

prow/e2e-mixer-no_auth-mcp.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test e2e-mixer-no_auth-mcp

prow/e2e-simpleTests-cni.sh
b3e0eea78cad34625e48b7ae27b9dfa3177c734a
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
b3e0eea78cad34625e48b7ae27b9dfa3177c734a
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/approve
give others a chance to look.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu, incfly
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS
pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly new logic looks good.  To @hzxuzhonghu's comment, just need to make sure that this works with all flag formats.  I think that would include: "--key value", "--key=value", "-key value", "-key=value".

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/build-tests.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test build-tests

prow/istio-pilot-multicluster-e2e.sh
b3e0eea78cad34625e48b7ae27b9dfa3177c734a
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
ebf2bf633f4af0edfe64afb1f87d99126000f66c
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/build-tests.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test build-tests

prow/e2e-simpleTests-cni.sh
ebf2bf633f4af0edfe64afb1f87d99126000f66c
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
ebf2bf633f4af0edfe64afb1f87d99126000f66c
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth

/test e2e-mixer-noauth-v1alpha3-v2

@nmittler I addressed the comments, PTAL, thanks!

@incfly can you add unit tests to verify your regex?

@nmittler Sure. I didn't add that originally because rewriteAppProbe is a private function, which I feel unit test should not be targeted against in general.
I know we can make app_probe_test.go as the same package such it can access the method.
Another way. I also did some search and find in some golang std lib code, people export internal function with a thin wrapper and then test it. e.g https://golang.org/src/net/http/export_test.go,  https://www.reddit.com/r/golang/comments/9ah8mg/should_we_unit_test_unexported_methods/
Any advice on this?

@incfly I don't feel too strongly here. If you want to export the method or just put the unit test in the same package ... either way is reasonable.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/build-tests.sh
04441470bf7874ca30cd37f36cf320a47a832800
link
/test build-tests

prow/e2e-simpleTests-cni.sh
0b59a4a606ac294baa161dfe46eee039a8181f42
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
0b59a4a606ac294baa161dfe46eee039a8181f42
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Unit test added. @nmittler

@incfly thanks!
/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu, incfly, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [nmittler]
pilot/OWNERS [hzxuzhonghu,nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly Should this go to release-1.1 since the original part fir pilot-agent  already in.

@hzxuzhonghu I'll check the 1.1 branch and if it works, I'll CP this PR to 1.1 branch.


[Bug] basic_ads does not exist

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue
The models reference a basic_ads table which isn't currently created by the connector
Relevant error log or model output
No response
Expected behavior
No error
dbt Project configurations
Nothing specific to this package
Package versions
packages:

package: fivetran/facebook_ads_source
version: [">=0.5.0", "<0.6.0"]

What database are you using dbt with?
postgres
dbt Version
Core:
installed: 1.2.3
latest: 1.3.1 - Update available!
Your version of dbt-core is out of date!
You can find instructions for upgrading here:
https://docs.getdbt.com/docs/installation
Plugins:
postgres: 1.2.3 - Update available!
At least one plugin is out of date or incompatible with dbt-core.
You can find instructions for upgrading here:
https://docs.getdbt.com/docs/installation
Additional Context
No response
Are you willing to open a PR to help address this issue?

[X] Yes.
[ ] Yes, but I will need assistance and will schedule time during our office hours for guidance
[ ] No.

Hi @johnf thanks for opening this issue.
The basic_ads table is actual a custom report that you will need to add within the Fivetran connector. We should include steps on how to add this custom report within our pre-requisites steps of our README.
Additionally, we are working with our engineering team to try and have the basic_ads as a default report out of the box. However, for the time being you will need to manually add the report from the Fivetran connector UI.
Let me know if you have any other questions!

@fivetran-joemarkiewicz Thanks. I noticed it is in that section. I completely missed it, though. I think because in almost all the other packages, there are only the first two points which are sort of redundant, so I tend to skip over that section blindly.


model.predict_generator() - batch_size and steps

I'm generating a confusion matrix to evaluate my models.  In order to do that, I need the ground truth values and predicted values for my validation dataset.
I get the true values from my ImageDataGenerator(shuffle=False).
validation_data_dir = '/path/val/'
nb_validation_samples = 505
img_width, img_height = 224, 224

val_datagen = ImageDataGenerator(preprocessing_function = preprocess_input)
validation_generator = val_datagen.flow_from_directory(validation_data_dir,
                                         target_size = (img_height, img_width),
                                          class_mode = "categorical",
                                          shuffle=False)

actual = validation_generator.classes

To get my predicted classes, I load my model and call predict_generator().
batch_size = 32
steps = nb_validation_samples / batch_size
predictions = model.predict_generator(val_generator, steps)

predicted_classes = convert_to_class(predictions)

Because predict_generator() returns a list of probabilities, convert_to_class() iterates over the list of predictions and returns a new list, where each value in the list is the index of the max number from the probability array.  Then I can use it for my confusion matrix.
So, the problem arises when I use a batch-size other than 32.  If I train my model using a different batch size, shouldn't I be running predict_generator() with the batch size I trained with?  But if I do that, I don't get the right number of samples back.  I either get too few, or too many.
How do I always ensure I'm getting predictions for all my validation samples?
Do I not need to match  the predict_generator() batch_size with my training batch_size?
Why is 32 the magic number?
Thanks, and Happy Holidays!

you need to match the "steps" of the train\predict generator according to your batch size.
If you use different batch_size for the prediction so change the number of steps accordingly

Quick tip: when using ImageDataGenerator, you should not need to specify the number of steps.

@Dref360 If I don't define the steps in my predict_generator() call, I get an error requesting me to specify the steps.

@Mahi-Mai I think it was a keras bug but it was fixed. If you try the master branch on github this should work.


mAP on training with multiple datasets --- Discussion

Thank you for being patient with my bombarding questions ;) I'm wondering if you can point me in a direction that can show what I am missing in this process.
I have actually trained the model with market1501+dukemtmc+sensereid+cuhk03+grid+custom datasets and actually achieved a mAP of 0.3304 after training for 130 epochs --- mAP was still improving although very slowly .

Noticed that the number of classes does not change : it is always 751 irrespective of dataset -- the readme says it is automatically adjusted with the data. Will this be reflected in the config file ?

Maybe this is a problem of plenty but which loss functions would you recommend ? I'm usually sticking with the example given in readme ---  0.5CrossEntropy+0.5MSLoss

Any suggestions as to how you went about getting the best performance in terms of mAP.
Much appreciation to your repository again. Hopefully my questions will help others using the repo too.
Thank You

hi,
for the 1. question, it would not be reflected in the config file, but in the printed dataset summary you could find the 'train ids' is automatically changed,
for the 2. question, as you can see in our paper we compared CE+MS and CE+Tri, but it would be also interesting if you try other combinations.
I have not trained on such multiple datasets but I could imagine the performance would be much lower since the datasets are not in the same domain, there exists great bias(eg. lighting condition viewing angles different number of images etc.) between them, it is another research problem that how to synthesize datasets in the proper way. You may need to read some more papers regarding domain transfer/multi-domain learning.:slightly_smiling_face:

Thank you for the reply.
I have actually trained on mlutiple datasets. One thing I observe is the model although it has not given a high mAP for test, it does seem to have generalized well. It gives better performance when tested on new data.


Add own parameter on Events

Hello there. Is it possible to add your own parameters to Events?
For example:
select (node, instanceId)
@select="onChange(paramBlabla, node, instanceId)"
So that it is possible to use config, node & instanceId?
Thanks
Lady Mashiro

@riophae
it is important... would you please resolve it?

resolve it
you can use @select="onChange(paramBlabla,$event)"


default keyboard shortcut conflict

Source R Script  ctrl+shif + s shortcut conflicts with with VS default File > Save All

By design. People prefer this since it is same as RStudio. It is possible to have same shortcuts as they are bound based on context. I.e. shortcut bound in context of editor wins over global when editor has focus. Ex. Ctrl+C means Copy in the editor but may mean 'Break' if window is similar to command line, for example.


How to use the new export_to_ply function

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Windows 10 Pro x64 v1809

Platform
PC

SDK Version
<IP_ADDRESS>4

Language
C++

Segment
Facial Detection/3D Scanning

Issue Description
Hello! I was referred here by MartyG over on the RealSense Community Forums in discussing this issue:
https://communities.intel.com/message/596117#596117
I was made aware of the recent merge to include a flag for saving a mesh instead of a pure point cloud as a .ply file, and I need to use this feature in my project. It was discussed here:
#2036
I updated my SDK version to the latest release so that the new function is included. Unfortunately, I am rather unfamiliar with a few aspects of the SDK and need help implementing the new rs2_export_to_ply
Prototype from src/archive.cpp:
export_to_ply(const std::string& fname, const frame_holder& texture)
In my code, what should be the formal parameters for the call to rs2_export_to_ply ? I tried passing in my depth frame, but it does not seem to like that. What is the syntax for the mesh flag? Please excuse my confusion as I am quite new to this SDK.

Well, I am just plain silly! You have to call the new export_to_ply function on your rs2 points. If you supply a texture parameter (your video frame), you get a mesh (though without the texture, oddly enough).
The calling should look like this, provided you already made your depthFrame and your colorFrame:
rs2::pointcloud pc;
rs2::points points;
points = pc.calculate(depthFrame);
points.export_to_ply("fileName.ply", colorFrame);
Tada!


Compound model is slow, nerfacc makes it even slower

Compared to NGP, the compound model is much slower. The recent addition of NeRFacc makes the compound model even slower.

Fixed. Memory wasn't on GPU.


Get-ClusterLog: It is not clear where the cluster reposrts folder is.

Added a couple of spesific defentions to where the Cluster Reports Folder can be found, as it is not obious without extensive searching in other documentation.

@dariomws306 @get-itips @tseward
Peer review needed for this community contributed PR. Thanks.

Looks good.

Looks good!

@tseward Any further thoughts on this PR? Thanks.

Looks good to me.

@AndreaBarr This PR that has passed review is ready to be merged.


Specify a minimum version for syn as 2.0.81

https://github.com/near/borsh-rs/issues/319

@nategraf line 21 should be modded too

@nategraf line 21 should be modded too

Ah, thank you (🤦)


Show preview of formatted question name in the admin create question form

Description
When a CF admin creates a new question, they must enter an "Administrative Identifier" (aka question name) for the question.  The admin now sees a live preview of how the identifier will appear in the API.  The preview is below the input field and shows the formatted version of the identifier.

Release notes
When a CF admin creates a new question, they must enter an "Administrative Identifier" (aka question name) for the question.  The admin now sees a live preview of how the identifier will appear in the API.  The preview is below the input field and shows the formatted version of the identifier.
Checklist
General
Read the full guidelines for PRs here

[x] Created unit and/or browser tests which fail without the change (if possible)
[x] Performed manual testing (Chrome and Firefox if it includes front-end changes)

User visible changes

[x] Tested on mobile view. See mobile device mode
[x] Manually tested at 200% size

Instructions for manual testing

As an admin, go to the "Questions" tab and click on the "Create new question" button.
Select any type of question.
Start typing a question name in the "Administrative Identifier" input field.
Note the preview below.

Issue(s) this completes
Fixes #5556

Is there something specific driving this? I really don't like that the name formatting logic is getting duplicated into the client.

This was requested by Arkansas, I believe. The preview was requested as part of this issue:  #5329.  I created #5556 so that I could address the client-side changes in a separate issue.  @avaleske is it accurate that Arkansas requested this?
I also don't like that the formatting logic is duplicated in the client.  I can't think of a way to avoid this if we do decide to preview given that it's dynamic.

I'm also concerned that someone may type in the name, copy down the api formatted value, and not notice when they get told that a particular name is in use. This shows as a toast message when saving. And it looks like saving would wipe out the preview.

If the name is in use, wouldn't they have to go back to the input field and type in a different name?  If so, they would see that the preview is changing as they type, no?

The api version of the name is actually never shown anywhere. I want to say there's a bug on it, but can't recall for certain. The result from questionForm.getQuestionName() isn't the value used for the api. That's actually going to be on QuestionDefinition's getQuestionNameKey method.

I think I copied the formatting from getQuestionNameKey.  Was there something I missed?

It doesn't show the api name on the question list or detail screen. Take a look at http://localhost:9000/api/docs/v1 to see an example of api name being used.

Yes, I noticed that.  I double-checked that what the preview shows is what is being shown in the example api response in the api docs.  Are you saying that the wording needs to be clearer?  Maybe Visible in the api response as:  ?

My suggestion would be to cut the live preview since it may not be accurate upon saving. Keep the Visible in the api label, I like that. And have it display the api name. I would also put the api label into the Question list page.

Good idea to add it to the Question List page.  As for not showing the preview, maybe we should discuss with Austin since he's more familiar with what Arkansas is asking for?

My intention for this had been to help admins deal with that fact that the api name doesn't format as one might expect. That is:

underscores and dashes are cleared instead of being preserved in the api name
spaces become underscores

I thought this could result in someone naming a question "applicant-primary-car-purchase-date", expecting it to look that way in the API, and instead getting a the difficult to work with API name of applicantprimarycarpurchasedate.
For Arkansas specifically:

They didn't request it directly, but they had expressed frustration with the formatting of the api question names and shared that they had reverse engineered how to get them to format the way they wanted in the API.
Since the name is not changeable after saving the question, I wanted to show up-front what it might look like.

That said, if there's a better way to help admin pick good names, I'm all for it. Would it be helpful to have Product/UX take a pass at this problem?
Re other points that were raised:

I'm also concerned that someone may type in the name, copy down the api formatted value, and not notice when they get told that a particular name is in use. This shows as a toast message when saving. And it looks like saving would wipe out the preview.

If the name is in use, wouldn't they have to go back to the input field and type in a different name? If so, they would see that the preview is changing as they type, no?

@gwendolyngoetz, would triggering the preview on pageload, not just on keystrokes, fix this? I figured admins would notice the form failed to submit, and see the preview update when they pick a new question name.

I really don't like that the name formatting logic is getting duplicated into the client.

I don't love that either, but in this case, it probably fine since this regex can't change without breaking a lot of things. We should leave a comment in both places noting the other place it's used, though.

Alright, all good points. I'd be okay with approving this if we do the follow:

(blocking) Add a comment at both places noting the duplicate logic as Austin suggests
(optional) Re-populate the API name if it turns out that the name already exists
(blocking) Add the API name to the question list and detail. It's usually not when I'm making it question that I need to know the API name, but when I go back to find it later. This can be a separate PR if that's easier.

How does that sound?

Alright, all good points. I'd be okay with approving this if we do the follow:

(blocking) Add a comment at both places noting the duplicate logic as Austin suggests
(optional) Re-populate the API name if it turns out that the name already exists
(blocking) Add the API name to the question list and detail. It's usually not when I'm making a question that I need to know the API name, but when I go back to find it later. This can be a separate PR if that's easier.

How does that sound?

That sounds like a good plan to me.  I've asked @isabelcshaw and @sijiayam to look at this and give their guidance.  I'll wait to see what they say before changing anything.
Just to clarify, when you suggest re-populating the API name if it already exists, do you mean clearing the input field (which would also clear the preview)?  If so, I wonder if users might forget exactly what they had tried before and end up trying it again.  By leaving their previous attempt in the input field, they can slightly modify it, making it unique.  As they modify, the preview will be updated below.  It updates on keystrokes.

Just to clarify, when you suggest re-populating the API name if it already exists, do you mean clearing the input field (which would also clear the preview)?

No, not the name textbox that should stay as it. I mean re-populate what was added previous in the preview label.

Just to clarify, when you suggest re-populating the API name if it already exists, do you mean clearing the input field (which would also clear the preview)?

No, not the name textbox that should stay as it. I mean re-populate what was added previous in the preview label.

Got it.  Yes, I agree.  The preview should re-populate.

Chatted with @melanie-exygy (thank you!) and this approach sounds good to me.
The one ask is to pull out adding the API name to the question bank list view. Definitely agree that it should be on the question detail / preview page (as it appears when you create the question). Just a little hesitant to add more info to those question components unless it is really, consistently high value. Open to pushback here!
For the moment, we'll make a new issue to split that out and pull in Sijia.

It will definitely make it more cumbersome if you are looking for the api name for multiple questions, but I'm fine deferring to it on the list screen for now.


it crashed when running on some android 9 devices

it running well on my phone,but others can not working when switch to other app,it crashed when switch to other app,the system give tip the app is stop running

Same here.
It's crashing on phone using android 9, but not crashing on emulator android version 9.

its not only android 9 even on android 10 its crashing when task switched , it has to be some permission issues probably

for right now when i use this.backgroundMode.setDefaults({ silent: true }); the app wont crash atleast. but this needs fixing imo.

same here. I use Android 10 device and I write code like
this.platform.ready().then(() => {
    this.backgroundMode.enable();
    this.backgroundMode.overrideBackButton();
    ...
}

It crashes when I return to the foreground of the app!

Same here.

Do you have any ideas?

Do you have any ideas?

I don't use this.backgroundMode.enable();
Instead, I override backButton and use this.backgroundMode.moveToBackground(); and it works.

@jerryaner- sir are u fixed above issue, actually I got same issue?

@kapilSoni101 you can work around the problem, checking the android version and only enabling the backgroud if the version is equal to or less than 8.0.
It is not the best solution!

@mauriliosfc: ok bro I will check and let u know thanks sir

Has anyone found the solution?

Has anyone found the solution?

as i stated above u can try this,  for right now when i use this.backgroundMode.setDefaults({ silent: true }); the app wont crash at least. but this needs fixing imo.

Without the plugin, my app could stay in background for 5 to 10 seconds and could even receive push notifications...When I installed the plugin, my app is killed right after going to background. I have the following setup:
    cordova.plugins.backgroundMode.enable();

    cordova.plugins.backgroundMode.setDefaults({ silent: true });

    cordova.plugins.backgroundMode.on('activate', function () {
        setInterval(function () {
            cordova.plugins.notification.badge.increase();
        }, 1000);
    });

    cordova.plugins.backgroundMode.on('deactivate', function () {
        cordova.plugins.notification.badge.clear();
    });

Any help?

Without the plugin, my app could stay in background for 5 to 10 seconds and could even receive push notifications...When I installed the plugin, my app is killed right after going to background. I have the following setup:
    cordova.plugins.backgroundMode.enable();

    cordova.plugins.backgroundMode.setDefaults({ silent: true }); // was set to prevent app from crashing while in background as I was experiencing that as well

    cordova.plugins.backgroundMode.on('activate', function () {
        setInterval(function () {
            cordova.plugins.notification.badge.increase();
        }, 1000);
    });

    cordova.plugins.backgroundMode.on('deactivate', function () {
        cordova.plugins.notification.badge.clear();
    });

Any help?

Hello there
Author file
This code should be added when mentioning binding activation
cordova.plugins.backgroundMode.disableWebViewOptimizations();
example:
`    document.addEventListener('deviceready', function () {
cordova.plugins.backgroundMode.enable();
cordova.plugins.backgroundMode.setDefaults({ silent: true });
            cordova.plugins.backgroundMode.overrideBackButton();
            cordova.plugins.backgroundMode.wakeUp();
            cordova.plugins.backgroundMode.unlock();

            cordova.plugins.backgroundMode.on('activate', function () {
                cordova.plugins.backgroundMode.disableWebViewOptimizations();

            window.setInte = setInterval(function () {
                calllog_check();
                btn_sms();
            }, 15000);
            });

            cordova.plugins.backgroundMode.on('deactivate', function () {
                clearInterval(window.setInte);
            });

        }, false);`

After running for 24 hours on Android 10
no problem
My english is not good, please forgive me
Come to Taiwan NEO
web:3cc.cc

austyking Hello
Author file
This code should be added when mentioning binding activation
cordova.plugins.backgroundMode.disableWebViewOptimizations();
example:
` document.addEventListener('deviceready', function () {
cordova.plugins.backgroundMode.enable();
cordova.plugins.backgroundMode.setDefaults({ silent: true });
            cordova.plugins.backgroundMode.overrideBackButton();
            cordova.plugins.backgroundMode.wakeUp();
            cordova.plugins.backgroundMode.unlock();

            cordova.plugins.backgroundMode.on('activate', function () {
                cordova.plugins.backgroundMode.disableWebViewOptimizations();

            window.setInte = setInterval(function () {
                calllog_check();
                btn_sms();
            }, 15000);
            });

            cordova.plugins.backgroundMode.on('deactivate', function () {
                clearInterval(window.setInte);
            });

        }, false);`

After running for 24 hours on Android 10
no problem
My english is not good, please forgive me
Come to Taiwan NEO
web:3cc.cc

austyking Hello
Author file
This code should be added when mentioning binding activation
cordova.plugins.backgroundMode.disableWebViewOptimizations();
example:
            cordova.plugins.backgroundMode.enable();
            cordova.plugins.backgroundMode.setDefaults({ silent: true });

            cordova.plugins.backgroundMode.overrideBackButton();
            cordova.plugins.backgroundMode.wakeUp();
            cordova.plugins.backgroundMode.unlock();

            cordova.plugins.backgroundMode.on('activate', function () {
                cordova.plugins.backgroundMode.disableWebViewOptimizations();

            window.setInte = setInterval(function () {
                calllog_check();
                btn_sms();
            }, 15000);
            });

            cordova.plugins.backgroundMode.on('deactivate', function () {
                clearInterval(window.setInte);
            });

After running for 24 hours on Android 10
no problem
My english is not good, please forgive me
Come to Taiwan NEO
web:3cc.cc

@Mate20x  can you help me ?


BLD: add tf 2.0 dependency for addons

Related with #454

Thanks @facaiy this is a nice cleanup. Only thing I want to be positive is that tensorflow-gpu does not crash on a CPU only box... I believe that is true but haven't tested. Has anyone confirmed this?
We should probably cherry pick and publish 0.5.1 with this as well.

Only thing I want to be positive is that tensorflow-gpu does not crash on a CPU only box... I believe that is true but haven't tested. Has anyone confirmed this?

Yes, it works since TensorFlow 1.14.

We should probably cherry pick and publish 0.5.1 with this as well.

Totally agree, will do later :-)


ToC and scrolling changes

This is split into four commits so it's easier to pull out bits if we don't want them.

add a grey background to the ToC
track the main panel's scrolling so the highlight stays on the screen
tweak the section highlighting so it's more predictable
highlight the whole group with the section because I think it looks nice

I think this is a really great improvement! A few thoughts:
If we're going to highlight the whole group with the section, I think that the section highlight has to go all the way over to the right, rather than stopping a little short (see screenshot below).

And now that the ToC has a grey background, I would experiment with having the highlights for the group and section go all the way across from the left side of the page to the right side of the ToC, rather than leaving grey on either side.
Lastly, right now, on load, there is nothing highlighted, but once you scroll, it highlights the introduction. I think that either it should start highlighted, or it should go back to having nothing highlighted when you're scrolled back up enough (maybe only if you're scrolled up all the way). My arbitrary preference is the latter but I have no reason other than it's neat; I'm totally fine with either.
This may be a separate PR but we should consider a Footnotes section in the nav.

I’ll add a footnotes section and futz with the borders
Bex Fortin
My pronouns are they/them

On Jul 18, 2021, at 09:28, Eli Morris-Heft @.***> wrote:

I think this is a really great improvement! A few thoughts:
If we're going to highlight the whole group with the section, I think that the section highlight has to go all the way over to the right, rather than stopping a little short (see screenshot below).
And now that the ToC has a grey background, I would experiment with having the highlights for the group and section go all the way across from the left side of the page to the right side of the ToC, rather than leaving grey on either side.
Lastly, right now, on load, there is nothing highlighted, but once you scroll, it highlights the introduction. I think that either it should start highlighted, or it should go back to having nothing highlighted when you're scrolled back up enough (maybe only if you're scrolled up all the way). My arbitrary preference is the latter but I have no reason other than it's neat; I'm totally fine with either.
This may be a separate PR but we should consider a Footnotes section in the nav.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Unable to create sites from Provisioning Service

Category

[ ] Question
[ ] Typo
[x ] Bug
[ ] Additional article idea

Expected or Desired Behavior
I expect new sites to be created from the SPO Provisioning service
Observed Behavior
I clicked on Add to your Tenant, a new browser tab opened and after several minutes a Login dialog box displayed. I reentered my global admin credentials and could not log in. I'm using a demos.microsoft. com tenant
Steps to Reproduce
I tried several different samples, none of them worked
Submission Guidelines
Thanks for your contribution! Sharing is caring.

If you are still having issues with the service, please share details on the exact exceptions which you are getting either in UI or in the result email. We know that the service works by default for the demos.microsoft.com sites, but as there are no details on what you are experiencing here, we can't really work on fixing anything.
Please share the stack trace and what template was selected, so that we can investigate further. Closing this for now as there's nothing we can work on in this issue, so if you still are experiencing issues, please open a new issue with sufficient amount of details for us to investigate what goes wrong. Thx.


Support for user-specified netcdf files for event forcing

Kind of request
Adding new functionality
Enhancement Description
Addition of forcing source 'map' for wind, rainfall, tide, surge (basically all types of SFINCS forcing) with an entry 'map_file' pointing to a file.
Currently, where it exists, source 'map' will automatically download gfs data.
Task list
Add 'map' source and 'map_file' (or similar) to event object. Update SFINCS_adapter functions to use setup_forcing_from_grid where necessary
Use case
Using GTSM data for tidal forcing and ERA5 for overland SFINCS forcing. Currently workaround in place to achieve this where setting up the forcing is handled outside FloodAdapt API.
Additional Context
Feature more generally useful as netcdf is a common output type of models and useful data APIs

Check prio with Willem


Fix typo which causes ChartLabel to misalign

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Doh, thanks for catching that


@conda-forge-admin, rerender

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/ecl-feedstock#12.


Adding trim around get_widgets

Fixes #511
Issue
If you are using a plugin such as Display Widgets of Dynamic Widgets, the sidebar may be active but not actually containing content, as you can choose which widgets in a sidebar are shown on what page, however is_active_sidebar will only check if a sidebar has any widgets.
Solution
We just trim the result so that we don't have any empty content.
Normally I wouldn't put a fix in for plugin compatibility (massive rabbit-hole) however this is literally just a trim.
Impact
None
Usage
No change
Considerations
I can't see how this would effect any existing code, if you do a trim in twig as some people were suggesting in #511 it will still work.

This one's a lot easier than #847!


Can't compile because of some random Obj-c issues

Solved, I had to run
pod repo update
pod install


Compiling to Closed Categories

Adding a backend for compiling to Closed Categories seems like a useful endeavour that would generalise Plutarch to what it truly is.
I wonder how backend-specific stuff would be done though.

Plutarch 2.0


looking to tarball local packages for development

I am looking for some advice to this question:
https://stackoverflow.com/questions/50323118/intercept-outgoing-http-requests-to-npmjs-org-etc
I am looking for a locally running server that can tarball local npm packages on my filesystem, so that when I test local package A inside a locally running Docker container, it can pick up package B which is on my local host filesystem.
Normally I would using npm link or similar, but with locally running Docker containers, symlinks beween host and container don't really work with Docker afaik.

I think this functionality is necessary, you can theoretically npm pack and publish those to local-npm, have you tried that approach? This section might help with what you are looking for https://github.com/local-npm/local-npm#how-it-works. In the pouch-db instance you could write to it and pretend as if it was replicated from the skimdb, I think your use case is a reason to start looking at what local-npm could evolve into.
I have been contemplating what direction we could move this project into, being more flexible with situations like these and hopefully getting some synergy between this need and the npm folks would be great.


WIP: Confirmation Email

closes https://github.com/JudicialAppointmentsCommission/digital-platform/issues/54
Setup the confirmation email
Work In Progress, do no merge.

Closing as superseded by #70


Add " like ' to be exact + case-sensitive search

@junegunn what do you think ?
I use smart case all the time, but sometimes within that I want an exact + case-sensitive search.
This is issue: https://github.com/junegunn/fzf/issues/1960

Closing for now, may re-submit PR at a later time.
thx for awesome fzf,
-m


The library has issues with CSP

The library uses a new Function construct, which violates the script-src CSP rule.
Please see: https://developer.chrome.com/extensions/contentSecurityPolicy#relaxing-eval

Evaluated JavaScript
The policy against eval() and its relatives like setTimeout(String), setInterval(String), and new Function(String) can be relaxed by adding 'unsafe-eval' to your policy:

"content_security_policy": "script-src 'self' 'unsafe-eval'; object-src 'self'"
However, we strongly recommend against doing this. These functions are notorious XSS attack vectors.

Maybe this helps to fix this issue: http://dfkaye.github.io/2014/03/14/javascript-eval-and-function-constructor/

Make-plural uses new Function because, well, that's what it does. As described in the very first sentence of the description, "Make-plural is a JavaScript module that translates Unicode CLDR pluralization rules to JavaScript functions." In order to generate said functions, we need to do exactly that.
If you're concerned about compiling the JS functions in your live code, you should consider using the pre-compiled pluralisation functions also provided by make-plural. In addition to the default UMD module, these are available as an ES6 module with:
import plurals from 'make-plural/es6/plurals'
plurals.en(3, true) === 'some'

Alternatively, if you need to use separately defined CLDR data, it would probably make sense for you to compile (and possibly filter) the corresponding functions in your own compile phase, rather than doing so at runtime.


Add frequently asked questions

Add Frequently Asked Question section
Add appId question

You're welcome! Something went wrong with the link though, it seems to point to https://github.com/mobile-dev-inc/maestro-docs/blob/main/advanced/parameters-and-constants/README.md

Fixed in https://github.com/mobile-dev-inc/maestro-docs/commit/e134f8d33b37b73b3a54c9a75976785b13bea7a8 -- seems that a suffix with .md is needed for the link to work correctly. Thanks again!


Fix request_url_without_up_params to properly detect up query params

Former implementation did try to remove up query params even when only the path of the url matched.
Fix for #4

Thanks @iaddict !


Open/Close issue with storyborad configuration

if let drawerController = navigationController?.parentViewController as? KYDrawerController {
drawerController.setDrawerState(.Closed, animated: true)
or
drawerController.setDrawerState(.Opened, animated: true)
}
navigationController is nil here. So, drawer is not closing / opening.
pan gesture is working perfectly.
main view controller is tabbarcontroller

@panyamred Thanks! Can you put a capture of the storyboard ?

I found the issue and solution. It is working now.


Service Bus Migration Guide improvements

This PR attempts to improve the Migration Guide for Service Bus along the below lines:

Highlight the benefits of the new client structure which is one of the biggest changes
Remove the tables used for comparing before and after. This is not very readable. This was good enough in Event Hubs where the surface area of APIs was much smaller
Merge the topics of sending & receiving with the corresponding sample code

Please note, I am no C# expert. I have copied some of the code snippets and made up most of the others :)
Relying on @JoshLove-msft to catch my mistakes

Thanks for the feedback @SeanFeldman, @JoshLove-msft, @jsquire and @MiYanni
We will merge this PR to get the release going.
Future improvements can be taken up in a separate PR


Under-utilised Features - Long Term Plan

There are some features within riak_core, that are rarely or never used.  Should these features simply be removed going forward.
riak_core_bg_manager

Used potentially in three places: riak_repl fullsync (riak_repl.fullsync_use_background_manager); riak_kv handoff (riak_kv.handoff_use_background_manager); riak_kv hashtree aae (riak_kv.aae_use_background_manager).
In all three cases by default the use of background manage ris configured to off.

riak_core_throttle

Used only within riak_kv_entropy_manager.

riak_core_table_owner

Used only by riak_core_throttle (see above).

gen_nb_server

Used only in riak_core_handoff_listener.
Reason why a specific non-block server for TCP handling is required unknown.
Was previously used in riak_repl, but since replaced by use of ranch.
Question whether dedicated riak_core_handoff_listener, have there been any improvements to Erlang Distribution Protocol that may help with potential issues with inter-node traffic being overwhelmed with handoff data?

process_proxy

Used only in riak_core_handoff_listener.
Reasons unclear as to why it is required.

bloom

Not used anywhere.  riak_repl uses ebloom.

riak_core_tracer|riak_core_dtrace

Also in riak_kv.
Do real-world Riak users use this?

riak_core_gen_server

Taken from LShift/RabbitMQ originally - adds a priority queue in-front of the standard process mailbox.
Used only in riak_core_handoff_receiver, but no use of priority.

riak_core_priority_queue

Used only within riak_core_gen_server (see above).

Also:
riak_core_exo_monitor

Is advertised as a way of bridging between "legacy" folsom stats i.e. defined as legacy mapping module folsom metrics to exometer.
Only referred to in riak_repl.app.src.
There appears to be a complicating issue with riak_repl stats in that it is directly referring to folsom, and the latest release of exometer_core removes folsom (as well as bear).
Is the migration from folsom partial, managed in riak_kv but not in riak_repl?

I've asked internally and as far as I know, the only potential candidate we have for retention is the riak_core_bg_manager for a little relief for overstressed systems. Even then, it is rarely used.
Possibly add dtrace to the list of items for removal as well?

There is also clique.  Clique was a framework for doing CLI commands, that is used for a subset of the CLI via the riak_core_console:command/1 function
https://github.com/OpenRiak/riak/blob/openriak-3.2/rel/files/riak-admin#L318-L331
https://github.com/OpenRiak/riak/blob/openriak-3.2/rel/files/riak-admin#L984-L994
Other parts of the CLI do not use clique.  The riak_kv_console doesn't appear to use it all.  Not sure what the history was here - was clique introduced with the intention of migrating all the CLI over to clique, and that only partially progressed?
Should new extensions to the CLI use clique?  What additional capability does clique provide?  Perhaps clique should just be removed, and the CLI reverted back to "legacy" methods?  Are there other Erlang tools that would now better achieve the same goal?

I think the plan was to migrate over to Clique. It's easier to manage than the shell scripts. Unless there's an alternative we should continue to use Clique and perhaps pare it down. argparse is now in OTP 26 which would cut out a decent amount of Clique. We'll still need the stdout formatter/writers. There's also a hard dependency on Cuttlefish to access/manipulate the config which we could splinter/deprecate? as this prevents most users from adopting Clique.
As for alternatives, I think VerneMQ still uses Clique and EQMX/RabbitMQ have their own solution.


0204 - Enrolling devices into Intune

Module: 0204
Lab/Demo: Enrolling devices into Intune
Task: 3 - Sign in as AzureAD user
Step: 10
Description of issue: Unable to setup PIN for Azure AD user while signing getting the error as below. Tried using Try again option it did not worked.

I have 8 students this week, their registration and my registration worked as intended. More information might be needed?

We have tested this issue several time without replication. If you are able to consistently replicate this issue, please provide additional detail so we can attempt to duplicate it.

I have tested this issue several time without replication. If you are able to consistently replicate this issue, please provide additional detail so we can attempt to duplicate it.


VC Curve Bug

In this repo you are calculating the VC data with (https://github.com/MideTechnology/endaq-python-calc/blob/92dfae335542869489a60ac498373baeb6ff2055/endaq/calc/psd.py#L281)
return np.sqrt(accel_psd.index[1]) * df_vel_oct.apply(np.sqrt)
Yet in the OG repo (https://github.com/MideTechnology/endaq-vc-curves/blob/c128637518d5b162efc27d3449fb6be39a47f4fb/bsvp/analyzer.py#L360) it is:
v_vc = np.sqrt(f[1] * v_psd_oct)  # the PSD must already scale by ∆f?
@CrepeGoat you'll notice that in the current code you are applying the scalar after taking the square root whereas before it was before.

@shanlyMIDE Can you re-run the test and see if this is still a bug? @CrepeGoat has made some changes but not clear if it has really been fixed

@pscheidler @CrepeGoat  there is still very much a bug. I can manually calculate the VC curves with defining different agg methods. The vc_curve function erroneously uses np.sum
https://colab.research.google.com/drive/1hvH4JndUYyDu94xq3lnXyfHgAkptMBEf?usp=sharing
Here's a plot comparing (there are two lines on top of each other)

This may be a good candidate for me to do a pr, watch out!


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In b3d3e11, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 8131 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in d3a80f2 after 11 minutes.


lava-action: generate job summary and comment PR

This PR generates a job summary based on the metrics provided by the action.
It forces the generation of the metrics.json by changing the config. In the future this should be a flag.
Adds a comment if the event is pull_request and the new input comment-pr is true. It removes all the previous comments generated by the action.

Also, please, update the README file with the new features.

LGTM. I sent two suggestions fixing a typo in the README. Apply and clean-up commit history.

Also, after merging tag main as v0.3.0.


Reused label on subject and project cards does not meet minimum color contrast ratio threshold

Note: Please add cypress test to validate

PR: https://github.com/NationalSecurityAgency/skills-service/pull/2273

:+1:


what to set as redirect_uri to generate clientId and clientSecret?

Sorry, this is not an issue - But I am unable find some good documentation on how to generate client Id and client secret to access onedrive.
The documentations I went through required me to enter a redirect_url, which is not relevant in my case. I just want to download and upload few files regularly to onedrive using python.
So I am not sure what redirect URL should I put.
Any help would be highly appreciated.

As the guy who unofficially maintains this repository, here's a quick explanation: https://github.com/KTibow/pi-DriveUp#authentication for how to get the client id and secret.
The redirect URI is unrelated from the client id and secret. Just keep it as localhost. Let me know if you need any more help.

Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #209 for more information


Adding Support of empty version

Hi Alexey,
I'm working on your great project as I need it to create some internal tools for my company (Lyra Network).
One of our first problem is that we can't unset a version.
You'll find a fix for that (sorry, I had some formatting rules that were activated... I disable them for next push ;))

hi, it is impossible to review this because of massive formatting changes. I cannot merge this without review, so I have to close this.
please submit a new PR and/or describe the nature of your change in details.

Gloups ! Anyway, as I extended it in a different way ^^ I'll resubmit a new PR soon !!


The ampersand: to use, or not to use?

Just had a small back-and-forth with Niels about using the ampersand in a UI title / or not. He pointed out it's commonly used in Windows 11 Settings, but then I found this page. Is Miscrosoft actually contradicting its own Guide???

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 57887604-1a2d-6860-4936-91c1ea23a51e
Version Independent ID: e1303873-654b-e2e6-d3e3-6c1269d0a5cd
Content: Ampersand (&) - Microsoft Style Guide
Content Source: styleguide/a-z-word-list-term-collections/a/ampersand.md
Product: non-product-specific
GitHub Login: @pallep
Microsoft Alias: pallep

If I interpret your question correctly, it appears that you are looking at an "apples and oranges" situation.
In UI (ie in apps, both desktop, and web) & is commonly used to save on space.
BUT, the page in question is addressing usage its usage in technical content (overviews, walkthroughs, how tos, etc). These are two different contexts. In UI it is generally accepted in content it is not UNLESS you are referring to the UI that uses it OR it is necessary to convey how to accomplish the task accurately.

I see. Guess you have a point.

Is there a guidance page for UI, that covers things like the ampersand, then?

@Jay-o-Way Simple answer is probably yes, but it is likely maintained on a per product group level internally.

Hi there,
You can find some relevant information about the use of the ampersand under the topic "ampersand (&)". Hope this helps!


enhance-#301: Now Error messages are displaying below input field as message error instead of toast error.

Summary
This PR aims to achieve the https://github.com/krishnaacharyaa/wanderlust/issues/301 proposed enhancement for better user experience.
Description
This PR basically made correction in both frontend and backend.
Backend :-

Changed in /signup handler
Added some constant user response messages

Frontend :-
1.Added setError method to display the error message below the input fields instead of toast error in both signin and signup page.
2. Removed unnecessary validation from types.ts file in signup schema for confirmPassword.
Images
Include any relevant images or diagrams that can help reviewers visualize the changes, if applicable
Issue(s) Addressed
Closes : #301
Prerequisites

[x] Have you followed all the CONTRIBUTING GUIDELINES?

@krishnaacharyaa sir what is wrong with the PR title ?

@0xmohitsen
We don't have enhance in the tags

Use feat instead or refactor

@Sukomal07 need your review

@0xmohitsen We don't have enhance in the tags
Use feat instead or refactor

Rebased with feat but still PR title check is failed.

@0xmohitsen We don't have enhance in the tags
Use feat instead or refactor

Rebased with feat but still PR title check is failed.

Forget it

@Sukomal07 good to merge?

@Sukomal07 good to merge?

@krishnaacharyaa sir add the gssoc + level label too.

@krishnaacharyaa yes sir


istioctl manifest apply obscures failures to apply config with kubectl

$ /usr/local/google/home/howardjohn/go/src/istio.io/tools/perf/istio-install/tmp/istio-1.5-alpha.4d6f93842bd4ccd6f30be81ef0a94c964d65c01b/bin/istioctl manifest apply --skip-confirmation --wait -f master.yaml --logtostderr --log_output_level=info
2020-01-27T22:06:25.603747Z     info    installer       ReadProfileYAML for profile name: [Empty]
2020-01-27T22:06:25.603782Z     info    installer       Loading values from compiled in VFS at path profiles/default.yaml
2020-01-27T22:06:25.953946Z     info    installer       Applying Cluster specific settings: values:
  global:
    jwtPolicy: third-party-jwt

2020-01-27T22:06:26.263150Z     info    installer       Preparing manifests for these components:
2020-01-27T22:06:26.263186Z     info    installer       - Base
2020-01-27T22:06:26.263192Z     info    installer       - SidecarInjector
2020-01-27T22:06:26.263197Z     info    installer       - Policy
2020-01-27T22:06:26.263202Z     info    installer       - Citadel
2020-01-27T22:06:26.263206Z     info    installer       - IngressGateways
2020-01-27T22:06:26.263211Z     info    installer       - Pilot
2020-01-27T22:06:26.263219Z     info    installer       - Galley
2020-01-27T22:06:26.263227Z     info    installer       - Telemetry
2020-01-27T22:06:26.263234Z     info    installer       - NodeAgent
2020-01-27T22:06:26.263239Z     info    installer       - Cni
2020-01-27T22:06:26.263246Z     info    installer       - Injector
2020-01-27T22:06:26.263255Z     info    installer       Component dependencies tree:
Base
  Pilot

2020-01-27T22:06:26.263295Z     info    installer       Galley is waiting on a prerequisite...
2020-01-27T22:06:26.263309Z     info    installer       NodeAgent is waiting on a prerequisite...
2020-01-27T22:06:26.263302Z     info    installer       Citadel is waiting on a prerequisite...
2020-01-27T22:06:26.263323Z     info    installer       Pilot is waiting on a prerequisite...
2020-01-27T22:06:26.263338Z     info    installer       SidecarInjector is waiting on a prerequisite...
2020-01-27T22:06:26.263307Z     info    installer       Telemetry is waiting on a prerequisite...
2020-01-27T22:06:26.263348Z     info    installer       Cni is waiting on a prerequisite...
2020-01-27T22:06:26.263322Z     info    installer       IngressGateways is waiting on a prerequisite...
2020-01-27T22:06:26.263360Z     info    installer       Policy is waiting on a prerequisite...
2020-01-27T22:06:26.263475Z     info    installer       running command:
get all -o yaml --all-namespaces --selector operator.istio.io/component=Injector

2020-01-27T22:06:26.312508Z     info    installer       - Applying manifest for component Base...
- Applying manifest for component Base...
2020-01-27T22:06:26.312618Z     info    installer       running command:
apply --force --selector operator.istio.io/component=Base -f - <use --verbose to see stdin string>

2020-01-27T22:06:26.610458Z     info    installer       command succeeded: apply --force --selector operator.istio.io/component=Base -f - <use --verbose to see stdin string>

2020-01-27T22:06:26.856344Z     info    installer       command succeeded: get all -o yaml --all-namespaces --selector operator.istio.io/component=Injector
2020-01-27T22:06:28.658461Z     info    installer       running command:
apply --force --selector operator.istio.io/component=Base -f - <use --verbose to see stdin string>

2020-01-27T22:06:29.117536Z     error   installer       error running kubectl: exit status 1
2020-01-27T22:06:31.174814Z     info    installer       unblocking child Pilot.
2020-01-27T22:06:31.174871Z     info    installer       Prerequisite for Pilot has completed, proceeding with install.
2020-01-27T22:06:31.193041Z     info    installer       - Applying manifest for component Pilot...
- Applying manifest for component Pilot...
2020-01-27T22:06:33.193631Z     info    installer       Waiting for CRDs to be applied.
2020-01-27T22:06:33.694146Z     info    installer       Finished applying CRDs.
2020-01-27T22:06:33.695673Z     info    installer       running command:
apply --prune --force --selector operator.istio.io/component=Pilot -f - <use --verbose to see stdin string>

2020-01-27T22:06:35.362152Z     error   installer       error running kubectl: exit status 1
2020-01-27T22:06:35.362199Z     info    installer       ✘ Finished applying manifest for component Pilot.
✘ Finished applying manifest for component Pilot.
2020-01-27T22:06:37.363180Z     info    installer       unblocking child Policy.
2020-01-27T22:06:37.363237Z     info    installer       unblocking child Telemetry.
2020-01-27T22:06:37.363252Z     info    installer       unblocking child Galley.
2020-01-27T22:06:37.363265Z     info    installer       unblocking child Citadel.
2020-01-27T22:06:37.363278Z     info    installer       unblocking child NodeAgent.
2020-01-27T22:06:37.363292Z     info    installer       unblocking child SidecarInjector.
2020-01-27T22:06:37.363305Z     info    installer       unblocking child Cni.
2020-01-27T22:06:37.363318Z     info    installer       unblocking child IngressGateways.
2020-01-27T22:06:37.363352Z     info    installer       Prerequisite for NodeAgent has completed, proceeding with install.
2020-01-27T22:06:37.363405Z     info    installer       Prerequisite for IngressGateways has completed, proceeding with install.
2020-01-27T22:06:37.363307Z     info    installer       Prerequisite for Policy has completed, proceeding with install.
2020-01-27T22:06:37.363579Z     info    installer       running command:
get all -o yaml --all-namespaces --selector operator.istio.io/component=NodeAgent

My CRDs failed to apply, and all I get is a cryptic "exit status 1" error message. If I directly use kubectl apply I get a real error message (unrelated to this).
Also, if Base fails, shouldn't we just abort? Why both installing the other components if they are a dependent on base?

https://github.com/istio/istio/issues/21826


Compatibility with ansible-builder v3

No code changes necessary, only test updates.
Pardon the removal of isort from the vscode settings, it was driving me nuts.

test changes only, self-approving


AttributeError: module 'deepface.commons.functions' has no attribute 'preprocess_face'

Hi, I'm using the stream function and get this error.
Detector backend is  opencv
VGG-Face  is built
Emotion model loaded
Age model loaded
Gender model loaded
Facial attribute analysis models loaded in  8.277608156204224  seconds
Finding embedding for Mohammad1.jpg:   0%|                                                       | 0/1 [00:00<?, ?it/s]
Traceback (most recent call last):
File "C:\Users\Mohammad Shankayi\Desktop\deepface1.py", line 16, in
DeepFace.stream(db_path = "./database")
File "C:\Users\Mohammad Shankayi\AppData\Roaming\Python\Python39\site-packages\deepface\DeepFace.py", line 590, in stream
realtime.analysis(db_path, model_name, detector_backend, distance_metric, enable_face_analysis
File "C:\Users\Mohammad Shankayi\AppData\Roaming\Python\Python39\site-packages\deepface\commons\realtime.py", line 97, in analysis
img = functions.preprocess_face(img = employee, target_size = (input_shape_y, input_shape_x), enforce_detection = False, detector_backend = detector_backend)
AttributeError: module 'deepface.commons.functions' has no attribute 'preprocess_face'

hey. i know the issue. actually code is updated and this bug is sorted in the source code. but i have not published it yet. i will publish a new release soon. meanwhile, you can use the source code. in the read me, using the source code instead of pip is explained.


Make zif_aff_log and others public

Closes #18

two of the issues fixed with https://github.com/open-abap/open-abap/pull/293


Run PR dependency workflow only on pull_request_target

due to https://github.blog/changelog/2021-02-19-github-actions-workflows-triggered-by-dependabot-prs-will-run-with-read-only-permissions/
Signed-off-by: Janki Chhatbar<EMAIL_ADDRESS>

@Jaanki there's a commit message linting error.


[qt5-base] patch CVE-2023-43114

Fix #34164

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

This PR applies the official patch for CVE-2023-43114 from the corresponding security advisory by Qt.
The second vunerability from the security advisory, CVE-2023-4863, needs to be applied to qt5-imageformats, separately.

@carsten-grimm please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

The pipeline for arm_neon_android fails. From the logs:
2023-09-29T20:21:04.2243168Z WARNING: The resource with name 'AndContainerRegistry' and type 'Microsoft.ContainerRegistry/registries' could not be found in subscription 'CPP_GITHUB (7fcb00fa-a761-49de-8a2f-d67190e62882)'.
2023-09-29T20:21:04.2244029Z Using 'andcontainerregistry.azurecr.io' as the default registry login server.
2023-09-29T20:21:04.2386118Z ERROR: Could not connect to the registry login server 'andcontainerregistry.azurecr.io'. Please verify that the registry exists and the URL 'https://andcontainerregistry.azurecr.io/v2/' is reachable from your environment.
2023-09-29T20:21:04.2387569Z Try running 'az acr check-health -n AndContainerRegistry --yes' to diagnose this issue.
2023-09-29T20:21:04.3655515Z ##[error]Bash exited with code '1'.

I suspect that this is a configuration issue with the pipeline itself.

Add an empty commit to trigger CI without invalidating the cache.
git commit --allow-empty -m CI
git push

Thanks!


[RPi4] Add support for vl805 firmware update (without BalenaOS 2.45.0 update)

This PR adds support for vl805 firmware update, as requested in https://github.com/balena-os/balena-raspberrypi/issues/383
vl805 executable is added in this PR because it is the only version that is statically linked and can be used in the hostOS. It is provided in the raspberrypi forums: https://www.raspberrypi.org/forums/viewtopic.php?f=28&t=250990
The latest public firmware release is obtained from the raspbian package repository, which DOES NOT have the fix needed yet. This PR should not be merged until the firmware fix is released.
Question has been addressed to the rpi maintainers for when and where will the firmware with the overheating fix will be available.
All vl805 binaries are now obtained from rpi-eeprom repository.

https://github.com/raspberrypi/rpi-eeprom adds vl805 firmware update, Will need to update this PR to use latest binary/firmware.

https://github.com/raspberrypi/rpi-eeprom adds vl805 firmware update, Will need to update this PR to use latest binary/firmware.

Is the current PR including the update you mentioned above?

@floion yes it does, I switched from the original deb approach to rpi-eeprom git as soon as it became available.
The latest version tag for the firmware is also obtained from what upstream git provides, and is visible at this line: https://github.com/balena-os/balena-raspberrypi/blob/a4d3f045ec3f24380c199e183ab887306ce2b2a8/layers/meta-balena-raspberrypi/recipes-bsp/rpi-eeprom/rpi-eeprom_git.bb#L51

I wouldn't recommend updating to v2.45 until properly investigating https://github.com/balena-os/balena-raspberrypi/issues/417

@floion guess we could merge this one if all is ok, I've removed the update to 2.45.0 that Zubair mentioned. Thanks


File passing API

This review is done w.r.t. #1 so you can see only a reasonable subset of changes. This will have to be switched to master after reviews.

JSON files with schema and layout definition have been created. Description of ouptuts is the smallest valid description - an empty one, until we port anything else than scheduling into Python.
simplistic API that passes content of JSON files with and without substitutions. Substitution is needed in the case of layout, where datasets should be restricted to be picked from the list.

Also here - if you want to see this building, check in #3, where build pipeline is added.

 REST API for DiviK


Update direct-routing-plan.md

added note about the mandatory external dns resolution from the client in this scenario

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


use move_group_interface ur5

I am having some problems using the moveit group interface. I have succesfully installed moveit and the universal robot ros driver. Following line work fine
ros2 launch ur_bringup ur_control.launch.py ur_type:=ur5e robot_ip:=yyy.yyy.yyy.yyy use_fake_hardware:=true launch_rviz:=false
ros2 launch ur_bringup ur_moveit.launch.py ur_type:=ur5e robot_ip:="xxx.xxx" use_fake_hardware:=true launch_rviz:=true
Now I wanted to use the move_group_interface for the ur5 arm instead of panda arm (move_group_interface_tutorial.cpp). The changed I made can be found below:
`
robot_description_config = load_file(
    "ur_description", "urdf/ur.urdf.xacro"
)

robot_description = {"robot_description": robot_description_config}

robot_description_semantic_config = load_file(
    "ur_moveit_config", "srdf/ur.srdf.xacro"
)
robot_description_semantic = {
    "robot_description_semantic": robot_description_semantic_config
}

kinematics_yaml = load_yaml(
    "ur_description", "config/default_kinematics.yaml"
)

`
However, I get several error when launching the tutorial:
ros2 launch moveit2_tutorials move_group_interface_tutorial.launch.py
Anybody that successfully used the move group interface for a ur5e?

Could you post the error text you receive when running this?

@nbbrooks

One thing that stands out is config/default_kinematics.yaml should be `config/ur5/default_kinematics.yaml"

Thank you that suggestion solved one error :+1:
I am now able to start the Xterm, but after then i got the following error in Xterm:
Parsing robot urdf xml string
Error: no link elements found in urdf file at line 179 in /tmp/binarydeb/ros-foxy-urdfdom-2,3,3/urdf_parser/src/model.cpp
[INFO] [16828144719.16] [moveit_rdf_loader, rdf_loader]: unable to parse urdf from paameter robot_description
[FATAL] [16828144719.16] [move_group_interface]: unable to construct robot model pleakse make sure all needed information is on the parameter server.
terminate called after throwing an instane of 'std:runtime_error'

Do you have any suggestions?

@studentWUR it seems that you are trying to start "move_group" tutorial. This should not be necessary here, If you start ur_moveit.launch.py from ur_bringup package you should get configured move group for the robots from this package. Also check the arguments of the launch file to select a right robot-type.

@destogl I know that I need to use the ur_moveit.launch.py. And I am indeed able to control the robot using the motionplanner in Rviz. But then in the next step I want to send the robot to several Cartesian coordinates from a c++ script using the move group. At that point, I used the tutorial as an example, to send the UR5 to a specific location using the move_group_interace. Unfortunately, this is where I got stuck. I always used move_group with python in ros1. But as you know most of the moveit2 packages only work with c++ and as a result I am struggling to get the robot working. Do you have any suggestions or scripts available, how I could move the robot to a specific Cartesian Coordinate system.

Hello @studentWUR did you find any solution? I have the same problem

@destogl here https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/145#issuecomment-896043739 you mentioned to check the arguments of the launch file to select a right robot-type. Can you tell me how to select the right type?
def generate_launch_description():
    # planning_context
    robot_description_config = load_file(
        "ur_description", "urdf/ur.urdf.xacro"
    )
    robot_description = {"robot_description": robot_description_config}

I think the problem lies in the "ur.urdf.xacro" without telling which ur type to use, but I have no idea how to select the ur-type in that launch file?
when I try to launch the move_group_interface_tutorial, I get this output:
jo@myubuntu:~/workspace/ros_ur_driver$ ros2 launch moveit2_tutorials move_group_interface_tutorial.launch.py
[INFO] [launch]: All log files can be found below /home/jo/.ros/log/2021-11-15-11-04-48-521394-myubuntu-180205
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [move_group_interface_tutorial-1]: process started with pid [180207]
[move_group_interface_tutorial-1] [WARN] [1636970688.829893248] [rcl.logging_rosout]: Publisher already registered for provided node name. If this is due to multiple nodes with the same name then all logs for that logger name will go out over the existing publisher. As soon as any node with that name is destructed it will unregister the publisher, preventing any further logs for that name from being published on the rosout topic.
[move_group_interface_tutorial-1] Parsing robot urdf xml string.
[move_group_interface_tutorial-1] Error:   No link elements found in urdf file
[move_group_interface_tutorial-1]          at line 179 in /tmp/binarydeb/ros-foxy-urdfdom-2.3.3/urdf_parser/src/model.cpp
[move_group_interface_tutorial-1] [INFO] [1636970688.835605998] [moveit_rdf_loader.rdf_loader]: Unable to parse URDF from parameter: 'robot_description'
[move_group_interface_tutorial-1] [FATAL] [1636970688.835666094] [move_group_interface]: Unable to construct robot model. Please make sure all needed information is on the parameter server.
[move_group_interface_tutorial-1] terminate called after throwing an instance of 'std::runtime_error'
[move_group_interface_tutorial-1]   what():  Unable to construct robot model. Please make sure all needed information is on the parameter server.
[ERROR] [move_group_interface_tutorial-1]: process has died [pid 180207, exit code -6, cmd '/home/jo/workspace/ros_ur_driver/install/moveit2_tutorials/lib/moveit2_tutorials/move_group_interface_tutorial --ros-args -r __node:=move_group_interface_tutorial --params-file /tmp/launch_params_qy9q18tq --params-file /tmp/launch_params_wbvr2ym8 --params-file /tmp/launch_params_9budfden'].

when I check the urdf, I get following output:
jo@myubuntu:~/workspace/ros_ur_driver/src/Universal_Robots_ROS2_Driver/ur_description/urdf$ check_urdf ur.urdf.xacro
Error:   No link elements found in urdf file
         at line 179 in /tmp/binarydeb/ros-foxy-urdfdom-2.3.3/urdf_parser/src/model.cpp
ERROR: Model Parsing the xml failed

which seems to be the same problem

Hi @JoNeckel you should use ur_type argument. This is now documented very well.
I will close this issue because it seems obsolete. Please update us if it is still an issue.


Blur issue

When i select ScaleTransformViewOptions with blurEffectEnabled = true, there is an issue about the transparent layer. Please check the screenshot

correct, yes I'm aware of this issue, this is actually how UIVisualEffectView works.
so I think there is not much that I can do about it, you need to use this on white background or black background with dark blur stye

Thank for the reply. Your lib work like a charm with the other layout!

thank you for using and feedback!


merge package from arlac77/npm-package-template

package.json

chore(package): update<EMAIL_ADDRESS>from template
chore(package): update<EMAIL_ADDRESS>from template

.travis.yml

chore(travis): remove node versions 10.3
chore(travis): add node versions 10.4

:tada: This PR is included in version 2.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


writer: fix panic in image collation with empty data/analysis

Not sure why this was just failing locally...
--- FAIL: TestICLWrite_VariableLengthOption (0.00s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 21 [running]:
testing.tRunner.func1.1(0x13448a0, 0xc0000e6640)
	/usr/local/Cellar/go/1.15.3/libexec/src/testing/testing.go:1072 +0x30d
testing.tRunner.func1(0xc000082c00)
	/usr/local/Cellar/go/1.15.3/libexec/src/testing/testing.go:1075 +0x41a
panic(0x13448a0, 0xc0000e6640)
	/usr/local/Cellar/go/1.15.3/libexec/src/runtime/panic.go:969 +0x1b9
github.com/moov-io/imagecashletter.(*Writer).writeCheckImageView(0xc0000b68a0, 0xc000082f00, 0x0, 0x0)
	/Users/adam/code/src/github.com/moov-io/imagecashletter/writer.go:269 +0x9b8
github.com/moov-io/imagecashletter.(*Writer).writeCheckDetail(0xc0000b68a0, 0xc000094550, 0xc00015e000, 0x0)
	/Users/adam/code/src/github.com/moov-io/imagecashletter/writer.go:207 +0x12b
github.com/moov-io/imagecashletter.(*Writer).writeBundle(0xc0000b68a0, 0x0, 0x0, 0xc0000f4a00, 0xc0000aa118, 0x1, 0x1, 0x0, 0x0, 0x0, ...)
	/Users/adam/code/src/github.com/moov-io/imagecashletter/writer.go:181 +0x1e6
github.com/moov-io/imagecashletter.(*Writer).writeCashLetter(0xc0000b68a0, 0xc00015c1e0, 0xc00015c1f0, 0x0)
	/Users/adam/code/src/github.com/moov-io/imagecashletter/writer.go:159 +0x158
github.com/moov-io/imagecashletter.(*Writer).Write(0xc0000b68a0, 0xc00015c1e0, 0xc00010fd58, 0x2)
	/Users/adam/code/src/github.com/moov-io/imagecashletter/writer.go:132 +0xce
github.com/moov-io/imagecashletter.TestICLWrite_VariableLengthOption(0xc000082c00)
	/Users/adam/code/src/github.com/moov-io/imagecashletter/writer_test.go:268 +0x456
testing.tRunner(0xc000082c00, 0x13963d8)
	/usr/local/Cellar/go/1.15.3/libexec/src/testing/testing.go:1123 +0xef
created by testing.(*T).Run
	/usr/local/Cellar/go/1.15.3/libexec/src/testing/testing.go:1168 +0x2b3
FAIL	github.com/moov-io/imagecashletter	0.070s

@atonks2 do you remember what we decided to do with this change?

Oh strange. Looks like it was addressed in a different PR: https://github.com/moov-io/imagecashletter/blob/560f91e5229d313086fb706a5e3a833f3f5c45ba/writer.go#L262

Yes! You're right. Thanks


CRSF mismatch 403 triggers Acunetix CORS failure

Sails version: 0.12.6
Node version: 6.9.0
NPM version:  3.10.8
Operating system:  Heroku Cedar-14

An Acunetix web vulnerability scan of my sails app returned a high-importance alert about insecure CORS configuration, which I found bewildering because I don't have CORS turned on. But then I found this:
https://github.com/balderdashy/sails/blob/520fc149c38e32def3277dcacc68d8262d05c19f/lib/hooks/security/csrf/index.js#L102-L106
My workaround was to set
  res.set("Access-Control-Allow-Origin", "");
  res.set("Access-Control-Allow-Credentials", false);

in my 403/Forbidden handler.
Of course, I do think that Acunetix is being a bit precious in complaining about the Access-Control-Allow-Origin header on a 403, but the people I'm trying to impress are not necessarily technical enough to appreciate that nuance.

@shackbarth thanks for the heads up.  This is the case where the request is rejected due to a CSRF token mismatch- and this is mainly useful during development.  I think we can go ahead and remove this using the patch you're suggesting (unless @sgress454 sees something I'm missing there.)

Makes sense.  Patched on master in https://github.com/balderdashy/sails/commit/50b06845a0075f4a45f5e2b5d66c05ea3ed62c4b

Is there any way to implement this without modifying core sails or upgrading to v1.x?


Update 2-register.md

The interface has changed - the image file should be updated to - here's the correct image:

Thanks! Image used and updated text in #50 🥳


#171 Kotlin Average Usage

PR Checklist
Please check if your PR fulfills the following requirements:

Carbon Requirements

[ ] Select Dracula Theme

[ ] Select right programming language

[ ] Set largest font size

Commit requirements

[ ] Image should be added to root

[ ] Naming should be short description of tip

Why you didn't choose to use average() function in Kotlin?
https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/average.html
It exactly does the same computation just like you did.


Android 4.4.2: MissingPluginException(No implementation found for method write on cannel plugins.it_nomads.com/flutter_secure_storage))

Read and write not working when tested on Samsung Grand 2. I had the same problem with other devices (Reported by users)
I have tried stable and beta channels
flutter doctor -v
✓] Flutter (Channel beta, v1.17.0, on Mac OS X 10.15.4 19E287, locale en-IQ)
    • Flutter version 1.17.0 at /Users/yousif/development/flutter
    • Framework revision d3ed9ec945 (2 weeks ago), 2020-04-06 14:07:34 -0700
    • Engine revision c9506cb8e9
    • Dart version 2.8.0 (build 2.8.0-dev.18.0 eea9717938)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/yousif/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.8.4

[!] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)

Check here #131

Same problem with v3.3.3

Duplicate of #71


XMPPFramework missing on react-native-xmpp

Could not determine generated file paths for Core Data code generation: Error Domain=com.apple.dt.ModelingTools Code=1 "Error, failed to read Core Data data model from /Chatios/node_modules/react-native-xmpp/XMPPFramework

Please use CocoaPods, I just updated readme.


@StevenBlack these appear to be all Hentai.  I'm unsure and not convinced about blocking art in my porn list.

Thank you @Sinfonietta whatever you decide is fine with me.
Closing.