Architect changes

Currently I like how it starts

git clone
git push to your project

But then I thought about to move marked and jquery as deps using npm
So I get

git clone
npm install
move files from node_model to lib
git push

Also I thought about steps

npm install -g cms.js
cms.js init
git push

I thought about it because

break project to sep files
use babel
min sources
write test
use dependancy manager
new features for project how to update own project

what do you think ?

Yes, I agree there needs a bit of an architecture change. I'm in the process of restructuring the code for easier editing/PRs/setup. We are also probably going to be moving away from jQuery and will probably use bower for marked deps.
I'm leaning towards having the "demo" content in it's own directory because cms.js is basically the only file which changes frequently enough. This way when there are changes to the engine, users can just pull that file instead of demo content, etc. Will most likely also be including grunt in the round of commits.

Please take a look on #48
I did this structure

npm install -g cms.js
cms.js init
git push

So it will resolve all those issues
What do you think ?

I'm definitely on board with this type of structure. Working with you PR to finalize a solution.

We pulled out the starter template from the source code to make maintaining easier in v2. I definitely think it would be great to have a CLI utility. I retitled and created a new issue here to avoid confusion.


⚠ Jenkins Plugins Artifactory has degraded performance

In c91fbce, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1286 ms

Resolved: Jenkins Plugins Artifactory performance has improved in b06c9de after 17 minutes.


Container border color is always brighter than expected

Hi,
I need to set the border color of a container to a speceifc color:
var container = Container(
      child: largeRow,
      padding: EdgeInsets.all(10),
      decoration: BoxDecoration(
        border: Border.all(color: cardBorderColor, width: 0.2),
        color: cardColor,
        ),
      height: 70,
    );

But the color is always too bright. For example if I set
cardBorderColor = Colors.balck
the border gets gray.
Is this intented or a bug?

With black:

With grey:

With blue:

Seems to be expected to me.

Compare in your first screenshot the "blackness" of the border with the black color of your IDE Background.
Or another example. Write some blue text in your container. With the same blue as the border. You will see that the blues will differ.

This is a part of your first screenshot. The border is defenetly not black.

Ah.  So the color is spread and get brighter...


How to get currently playing?

hi how do get currently playing?
my code is this:
import flask
import spotipy
from spotipy.oauth2 import SpotifyClientCredentials

my_user = '31raqyw475t4bxd2mqybdm7ksoie'

spotify = spotipy.Spotify(client_credentials_manager=SpotifyClientCredentials())

me = spotify.user(my_user)
url = me['uri']

print(me.currently_playing(market=None, additional_types=None))

nvm


⚠ Bofrost.com has degraded performance

In f320075, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 1593 ms

Resolved: Bofrost.com performance has improved in 9dcd93f after 10 minutes.


Added create map type

Codecov Report

Merging #304 into master will increase coverage by <.01%.
The diff coverage is 93.02%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   91.86%   91.87%   +<.01%
==========================================
  Files           9        9
  Lines        2176     2215      +39
==========================================
+ Hits         1999     2035      +36
- Misses        115      117       +2
- Partials       62       63       +1

Impacted Files
Coverage Δ

vm/vmExpr.go
96.32% <93.02%> (-0.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324fd7c...a2f3f28. Read the comment docs.

@mattn Good to merge

Should we add to the modification of README.md to clarify that anko treat map[string]interface{} and map[interface{}]interface {} separately?

@mattn How are they treated differently? If they are, I am not aware how they are treated differently.
a = map[interface]interface {"b":"b"}; a.b // b
a = map[string]interface {"b":"b"}; a.b // b

Is this related on https://github.com/mattn/anko/issues/264, isn't ?

A little. Mostly it is for people to have basically the same syntax as Go. The only difference is that interface{} type is interface, which is not ideal but what works.

Thanks for your explaining.


Refactoring database tests

Current coverage is 71.45% (diff: 100%)

Merging #112 into master will not change coverage

@@             master       #112   diff @@
==========================================
  Files            10         10
  Lines           508        508
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            363        363
  Misses          113        113
  Partials         32         32

Powered by Codecov. Last update b47c7de...bc9e01d


New Package: Added vencord 1.9.3

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Resolves: https://github.com/microsoft/winget-pkgs/issues/160788
Microsoft Reviewers: Open in CodeFlow

@Trenly, is there a way to force Discord to be closed?

Automatic Validation ended with:
(Automated response - build 886.)

I don't believe I have found a way to skip the completed screen.

@Vendicated, is there a way to skip the success patched screen?

Automatic Validation ended with:
(Automated response - build 886.)


typescript error

const channelID = channel.match(/\d{17,19}/)?.[0];
?. and ;
in setanischedch

Update node version to at least lts

Update node version to at least lts

well since replit don't have other version of nodes I tried to do this
let channel = message.mentions.channels.first() || client.guilds.cache.get(message.guild.id).channels.cache.get(args[0]) || message.guild.channels.cache.find(c => c.name.toLowerCase() === args.join(' ').toLocaleLowerCase());
it work perfectly and set the channel

well first off, how is this a ts error?

how is this a ts error?

Yeah lol, that's what i thought

Update node version to at least lts

well since replit don't have other version of nodes I tried to do this
let channel = message.mentions.channels.first() || client.guilds.cache.get(message.guild.id).channels.cache.get(args[0]) || message.guild.channels.cache.find(c => c.name.toLowerCase() === args.join(' ').toLocaleLowerCase());
it work perfectly and set the channel

We Highly recommend you using the public docker images that are available

how is this a ts error?

it just showed there, I was using replit nodev v12.3.1

well ok, upgrade the node version, or use the docker image that bear made 👍

I believe the issue is fixed and can be closed now

@maisans-maid Yeah, I believe we can close this.


Make checking done customizable

 (1) [6] Groups - Managing Members - HTML fragment for Managing Groups [Cycle 95] [Cycle 96]


Network setting issue

All my LiDARs and PCs are under <IP_ADDRESS>/24 subnet, the default lucid camera IP is under <IP_ADDRESS>/16 if i am not wrong. If i only got one PC to run both perception and Autoware.universe, how can I reroute the lucid camera IP under the <IP_ADDRESS> subnet?

Made this PR to address the issue. Would appreciate a review if it may help resolve this issue. Thanks.
https://github.com/autowarefoundation/lucid_vision_driver/pull/12


Using Codecov

It's good if we use Codecov.

travis is already configured. It is necessary to create coverage report from test execution script.

Done!


defining contributionTypes

Summary of contributorType vs contributionType:

contributorType (DataCite)
contributionType
comments

ContactPerson
correspondence

DataCollector
collecting data

DataCurator
curating data
would we expect local curators here, or the responsible EBRAINS curator ?

DataManager
managing data

Distributor
distributing
not sure if this is needed in our case

Editor
editing
not sure if would need to be more specific here... or maybe I don't get when to use it

HostingInstitution
hosting
is captured separately (cf. hostedBy in fileRepository schema)

Producer
producing
not sure if that is used in our context

ProjectLeader
project coordination
I would get probably rid of the "project" because we use this as a schema

ProjectManager
project management
I would get probably rid of the "project" because we use this as a schema

ProjectMember
project participation
I would get probably rid of the "project" because we use this as a schema

RegistrationAgency
registration
do we need this in our context?

RegistrationAuthority
registration
do we need this in our context?

RelatedPerson
collaboration
not sure if I interpreted that correctly

Researcher
research

ResearchGroup
research

RightsHolder
holding rights
captured elsewhere (cf. copyright schema)

Sponsor
funding
captured elsewhere (cf. funding schema)

Supervisor
supervision

WorkPackageLeader
lead of work package

I have the feeling that this does not capture all of what we need...
Authors for the dataset/model/software publication, will be explicitly stated, because they need to be ordered.
Developers for the dataset/model/software publication, will be explicitly stated, because they need to be ordered.
Custodians for the dataset/model/software publication, will be explicitly stated, because they need to be ordered.
I kind of miss contributions like (only some examples):

analyzing data
experiment development
concept development
information technology support
laboratory assistance
etc.

Feedback from @jcolomb: CRO/CREDIT list roles, so something closer to contribution types. It seems to have what you feel is missing. (best navigate the ontology here https://www.ebi.ac.uk/ols/ontologies/cro/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FCRO_0000000&viewMode=All&siblings=false)
@apdavison : what do you think?

Maybe the author contribution list from PLOS ONE could be useful in relation to this (https://journals.plos.org/plosone/s/authorship#loc-author-contributions)?

Contributor Role
Role Definition

Conceptualization
Ideas; formulation or evolution of overarching research goals and aims.

Data Curation
Management activities to annotate (produce metadata), scrub data and maintain research data (including software code, where it is necessary for interpreting the data itself) for initial use and later reuse.

Formal Analysis
Application of statistical, mathematical, computational, or other formal techniques to analyze or synthesize study data.

Funding Acquisition
Acquisition of the financial support for the project leading to this publication.

Investigation
Conducting a research and investigation process, specifically performing the experiments, or data/evidence collection.

Methodology
Development or design of methodology; creation of models

Project Administration
Management and coordination responsibility for the research activity planning and execution.

Resources
Provision of study materials, reagents, materials, patients, laboratory samples, animals, instrumentation, computing resources, or other analysis tools.

Software
Programming, software development; designing computer programs; implementation of the computer code and supporting algorithms; testing of existing code components.

Supervision
Oversight and leadership responsibility for the research activity planning and execution, including mentorship external to the core team.

Validation
Verification, whether as a part of the activity or separate, of the overall replication/reproducibility of results/experiments and other research outputs.

Visualization
Preparation, creation and/or presentation of the published work, specifically visualization/data presentation.

Writing – Original Draft Preparation
Creation and/or presentation of the published work, specifically writing the initial draft (including substantive translation).

Writing – Review & Editing
Preparation, creation and/or presentation of the published work by those from the original research group, specifically critical review, commentary or revision – including pre- or post-publication stages.

Otherwise, is there anything that should be done in relation to this issue or should it be closed/postponed?

@UlrikeS91 thanks. I'll see that we add some from this list

The plosone list is identical to CREDIT (http://credit.niso.org/), which is included in CRO (CRO is supposed to be an extension of CREDIT).
Note that CREDIT was developed for papers (life science papers to be more specific), datacite schema is meant for dataset, while software may have a different kind of nomenclature (see https://allcontributors.org/).
My take would be to try to use CRO, adding contribution types to CRO if they are missing. (that is outsource the problem, make the solution more reusable and interoperable).

The plosone list is identical to CREDIT (http://credit.niso.org/), which is included in CRO (CRO is supposed to be an extension of CREDIT).
Note that CREDIT was developed for papers (life science papers to be more specific), datacite schema is meant for dataset, while software may have a different kind of nomenclature (see https://allcontributors.org/).
My take would be to try to use CRO, adding contribution types to CRO if they are missing. (that is: outsource the problem, make the solution more reusable and interoperable).

Thank you! This is very useful and we will use CRO. We may use other names here and there, but since our controlledTerms instances can have synonyms and links to ontologies, the CRO ID will always be attached to it and the CRO name added as synonym in case we want to use another one.


Lack of HTTP method on actions causing an error when trying to view Swagger

As shown below, to be able to view a swagger document, all actions need to be decorated with an explicit HttpMethod

@GeekInTheNorth many thanks for merging this in so quickly, very much appreciated 👍

@adayinthelifeofapro  No worries mate, I've credited you on the release notes withing the discussions section too :)


please ignore. This is for testing

Commit IDs
98d5d5,https://github.com/iancha1992/bazel/commit/79a0dc276cc81717ac2951d575e19f6a54d71e43, a2b775
Category
team-Bazel, team-Rules-API, team-Rules-CPP
Reviewers
@iancha1992

The following commits were cherry-picked in https://github.com/bazelbuild/bazel/pull/19654: https://github.com/iancha1992/bazel/commit/79a0dc276cc81717ac2951d575e19f6a54d71e43, https://github.com/iancha1992/bazel/commit/a2b775,
Failed commits (likely due to merge conflicts): https://github.com/iancha1992/bazel/commit/98d5d5,
The failed commits are NOT included in the PR. Please resolve manually.
cc: @bazelbuild/triage

Cherry-pick was attempted, but failed to push. Please check if the branch, cp_ondemand_362-6.3.0, already exists
cc: @bazelbuild/triage


Multiple date / time format options

Allow users to select which date/time format to display (Note: \n is not only a linebreak - the lower line will be in a smaller TextView (like currently):

default (counting right to left): YYYY-MM-DD\nhh:mm:ss
flipped (date below time): hh:mm:ss\nYYYY-MM-DD
german (it is weird): DD.MM.YYYY\nhh:mm:ss (I don't like it despite being german...)
flipped german (date below time): hh:mm:ss\nDD.MM.YYYY
feel free to suggest other options ^^

Adding an option to disable / enable seconds from being shown would be nice too (Using a toggle / switch).
The multiple date / time format options should be displayed in a dropdown.

I just implemented a spinner with all the date-formats listed below (except for flipped german). I called the flipped option inverse, as I felt that sounded better.

Inverse actually looks like this:

The selected format is stored as sharedPreferences, accessible through the launcherPreferences global object of the Launcher.
Possible compatibilty issues may arise, as they are stored as integers not as strings.May be fixed later using some glue code ^^


Make Response object return optional if such config selected

Closes #290
Address issue with Response data field doesn't return data wrapped with optional.
Take a look at https://github.com/apollographql/apollo-android/pull/331/files#diff-bd1f7dd25c2f308ad46f434f16893f11 and https://github.com/apollographql/apollo-android/pull/331/files#diff-1d4349ba6464dd54d277f125b3253316 as example how it will be used.

Do we have any tests that test what happens when optional is disabled?

@BenSchwab There aren't any for the plugin extension but there are for the compiler generation

Yes, that correct. We can have 2 Optional implementations: guava or our own shadowed version. So boolean field is not enough. Plus our Runtime lib knows nothing about guava. So only if user uses Guava we will wrap data (via method wrapData) to guava Optional, otherwise we will wrap it into our shadowed Optional

@digitalbuddha @marwanad any comments?

Not from first glance need to look tonight
On Mar 17, 2017 1:38 PM, "Ivan Savytskyi"<EMAIL_ADDRESS>wrote:

@digitalbuddha https://github.com/digitalbuddha @marwanad
https://github.com/marwanad any comments?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apollographql/apollo-android/pull/331#issuecomment-287422471,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEUX3LeLWtkyxaSgbPDiXeZM5Z7bxMxIks5rmsUsgaJpZM4Mf5Tp
.


GUACAMOLE-1905: Update client dependencies to latest compatible versions

Updated the client-side dependencies to the latest compatible versions, or, at least, I think that's what I've done. There were a handful of Java dependencies in the pom.xml files, one angular-translate update, and then version bumps for the JDBC drivers included with the Docker images.

Sadly it looks like 3 NPM packages are now deprecated:

angular-translate
angular-translate-interpolation-messageformat
angular-translate-loader-static-files

Nothing we can really do about that short of upgrading to angular-not-js.

Oops, I was a bit hasty in merging this - logback 1.5.2 requires Java 11.
The latest Java 8 compatible version is 1.3.14.


[New Feature]: Hover effects on the starting page

🎮 feature Request
Hover effects on the initial buttons on the starting page would look good as currently there are no hover effects.
@Durgesh4993 Please assign this issue to me under GSSoC'24, I will add good hover effects to make it look more appealing.
Point down the features
feature points
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

please assign me

I would like to work on this issue, please assign this issue to me under GSSoC'23.

@AtharvKasar04 Could you please explain more what you want to do, if possible you can also add screenshot.

@Muskansahuincredible @Anup2601 Please raise any other issue, i'll assign you
If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)

Please assign me this project and fix the issues of hover effects on the starting page and give me more details about the hover effects..

@AtharvKasar04 Could you please explain more what you want to do, if possible you can also add screenshot.

These buttons on the starting page arent having any hover effects and looks like a one single thing.
So i will add hover effects and more UI improvements so that these buttons looks more defined and separated from each other with a small margin.
Can i work on this?
Thank You!
@Durgesh4993


StompSessionProvider doesn't apply headers

I am configuring my StompSessionPRovider like so:
      <StompSessionProvider
        url="wss://bla/ws"
        heartbeatIncoming={3000}
        heartbeatOutgoing={0}
        stompVersions={
          new Versions(["1.2"])
        }
        connectHeaders={{
          Authorization: token,
        }}
        debug={(str) => {
          console.log(str);
        }}
      >

The connection fails and when I inspect the request, I can see no heartbeat, no authorization, and no versions. The dev tools also says that "Provisional headers shown." which seems to indicate a problem with the headers. It tries to connect to the correct URL tho, which is passed along with the headers.
Any idea what I am doing wrong?

Hello!
"Provisional headers shown" usually means that the request you are inspecting wasn't actually sent for some reason. My gut feeling is that your issue is probably caused by CORS. Please provide a Screenshot of the Inspect view of the request, as well as of any console output that may have occurred when connecting.


How to use spine with Pixi v3+  ????

How to use spine with Pixi v3+  ????

PIXI.spine is now a plugin :
https://github.com/pixijs/pixi-spine

Examples of Spine aren't working, like here: Gobling Example
I am trying to use the plugin with Dragon from Spine Trial, but I gets
Uncaught TypeError: Cannot read property 'skeleton' of undefined @ Slot.js:35

I have the same problem！！

Ok so the problem is:
var bone = this.bones[skeletonData.bones.indexOf(slotData.boneData)]; @ `Skeleton.js:23'
because this.bones is an integer indexed array, but slotData.boneData is type of string (for dictionary), so undefined is passed to Slot and bg happens

Pixi examples with spine weren't working because the plugin wasn't present:
https://github.com/pixijs/examples/pull/5
Now it is there we are trying to work through some issues with how plugins integrate:
https://github.com/pixijs/examples/issues/4
https://github.com/GoodBoyDigital/pixi.js/issues/1713
etc. Please be patient while we work through the issues. If you have problems using pixi-spine, please post issues on their repo. Pixi.js no longer ships with spine support, it is all in that plugin now.


Improve parsing for git URLs

Resolves #2631
Signed-off-by: Helder Correia

@dolanor Here's a starting point. Started with the tests but didn't finish.

I'm skipping over this since it's a draft. Will check again next week.

To be clear, this was for sharing initial work I had for @dolanor since he was interested in picking up #2631, but it can be for anyone else who wants to pick it up.


Investigate the ways to represent complex events

Current variant specification with rsID/CHROM_POS_REF_ALT does not work for all classes, for example structural variants, CNVs, translocations etc.

VRS is probably the best way to go here, but other alternatives can be discussed.

ClinVar documentation
Submission guidelines can be found here, in particular note the requirement:

a valid description of the variant, one of:

an HGVS expression
chromosome coordinates and change
cytogenetic description

Notes from 4 August meeting
Tentatively define "complex events" as variants without full chr_pos_ref_alt coordinates, as these are variants that aren't handled by the core VEP-based functional consequence pipeline.  Some of these are handled by the specialised repeat expansion pipeline, so we can focus on the rest.
To really deal with complex events, besides identifiers we also need to get functional consequences, otherwise they get dropped by the pipeline.
Next steps:

Collect more representative examples of complex events in ClinVar
Look at distribution of records with no functional consequences

How many have HGVS-esque identifiers, sequence location with start/stop position, cytogenetic location?
Of those with no full coordinates, how many can we parse? How many can the official HGVS parser parse?
How are unparseable HGVS identifiers failing?  Is there some systematic way people are using HGVS-esque identifiers that aren't technically HGVS-compliant but we can still parse reliably?

What does VEP require to get consequences? Biologically we should only need start/stop coordinates.
Can we report variant/phenotype associations without functional consequences, similar to ontology mappings?  Is this still valuable to OT?

Can we report functional consequences with some uncertainty?  For example some HGVS identifiers encode uncertain location, e.g. here.

(1) and (2) I've started doing and will post in a subsequent comment before the next meeting.

Some basic stats on variants without consequences or complete coordinates (total is 17,649, note this is using June consequence prediction output but on a newer version of ClinVar).  If there is anything else you'd be interested in seeing let me know, I'll see if I can get it before the next meeting.

 'Deletion': 9937,
 'Insertion': 552,
 'single nucleotide variant': 864,
 'Variation': 311,
 'Duplication': 3875,
 'Indel': 213,
 'Inversion': 73,
 'Translocation': 230,
 'fusion': 10,
 'copy number gain': 596,
 'copy number loss': 813,
 'Complex': 63,
 'protein only': 99,
 'Microsatellite': 12,
 'Tandem duplication': 1

 'Canonical SPDI': 183,
 'Any HGVS': 13619,
 'Top level refseq HGVS': 6730,
 'Cytogenetic location': 16317,
 'chr, start, stop': 1344,
 'official hgvs parser': 2402,
 'our hgvs parser': 3165

And finally, for @M-casado and @tcezard, some hand-picked examples of complex variants from ClinVar.  For each type I tried to choose at least one that seemed "typical" and one that was relatively high quality to get an idea of the variability, but no guarantees for how representative these are.

Duplication

https://www.ncbi.nlm.nih.gov/clinvar/variation/1062574/
https://www.ncbi.nlm.nih.gov/clinvar/variation/89496/

Deletion

https://www.ncbi.nlm.nih.gov/clinvar/variation/1011851/

Inversion

https://www.ncbi.nlm.nih.gov/clinvar/variation/268016/
https://www.ncbi.nlm.nih.gov/clinvar/variation/90611/

Translocation

https://www.ncbi.nlm.nih.gov/clinvar/variation/267959/
https://www.ncbi.nlm.nih.gov/clinvar/variation/267873/
https://www.ncbi.nlm.nih.gov/clinvar/variation/1012364/

copy number gain

https://www.ncbi.nlm.nih.gov/clinvar/variation/523250/
https://www.ncbi.nlm.nih.gov/clinvar/variation/870516/

copy number loss

https://www.ncbi.nlm.nih.gov/clinvar/variation/1047901/
https://www.ncbi.nlm.nih.gov/clinvar/variation/625801/

Complex

https://www.ncbi.nlm.nih.gov/clinvar/variation/267835/
https://www.ncbi.nlm.nih.gov/clinvar/variation/585332/

Answers to some questions by @M-casado:

What do the HGVS parser numbers mean?

This is the number of records which had at least one HGVS descriptor for which the specified parser was able to extract some information.  For the official parser this means not throwing an exception; for our parser this means returning some non-None properties (though note our parser was originally written for the repeat expansion pipeline).

What's the total number of HGVS we can parse with either parser?

3226, a grand total of 61 more than our parser can do alone...

From the variants with cytogenetic location, how many did not have any of the other descriptors, if any?

I made a new chart for this, for the main descriptor types.

'Only HGVS': 1277
'Only cytogenetic': 3821
'Only chr/start/stop': 0

Summary for Open Targets
Out of 1.27M variants in ClinVar processed by our pipeline, there are about 17K discarded because we cannot retrieve chr_pos_ref_alt coordinates and thus find no functional consequences.  Many of these are complex events like copy number variants and translocations.  We need a concise and descriptive way to identify these variants, as well as an accurate way of getting functional consequences for them.
This is a summary of our investigations for this issue; please see the previous comments for some more detail and charts.
Findings
There are currently 17,649 records in ClinVar with variants that have incomplete chr_pos_ref_alt coordinates and for which we were unable to get functional consequences. (This is using consequence prediction output from June but on a more recent version of ClinVar, which yields some discrepency from previously reported metrics). We first note that ClinVar requires from submitters one of three types of variant descriptor:

HGVS expression (any of these types)
chromosome coordinates and change
cytogenetic description.

Of the 17,649 records in question, 13,619 have some kind of HGVS descriptor. (Note that this only includes the actual HGVS attribute in the XML, for example it doesn't include HGVS or HGVS-like identifiers which we know are sometimes stored in the name attribute.) Cytogenetic location is more common with 16,317 records -- and 3,821 that have only cytogenetic location as a variant descriptor -- but this is not enough information to reliably get functional consequences or construct a unique variant identifier, so we propose focusing on HGVS descriptors.
One issue that will be important to address is that of uncertainty.  It is likely that these variants are lacking coordinates specifically because there is some uncertainty in placing them, and there is specific guidance for encoding uncertainty in HGVS descriptors. For example, HGVS expressions like the following are very common in the data we examined:
NC_000006.10:g.(165249445_165297427)_(170688258_170899992)del
NC_000001.10:g.(?_245017732)_(245020178_?)dup
NC_000006.12:g.(?_129049908)_(129192863_?)del

The first descriptor indicates a deletion beginning anywhere in the first range 165249445_165297427 and ending anywhere in the second range 170688258_170899992.  The others are similar but indicate that while the minimal extent of the variant is known, the maximal extent is unknown.  There are also quite a few expressions of a similar nature but with locations given relative to coding DNA reference sequences:
NM_000019.3:c.(72+1_73-1)_(344+1_345-1)del
NM_000019.3:c.(730+1_731-1)_(940+1_941-1)dup
NM_002354.2:c.(903+1_904-1)_(*1_?)del

For such variants there's the possibility of reporting some "minimal" set of functional consequences, with the caveat that some consequences like frameshifts can't necessarily be accurately reported without knowing the precise coordinates of the variant.
Questions

Is HGVS an acceptable way of identifying variants in evidence strings?
How can we report functional consequences with some uncertainty, or variants with a range of possible consequences?
Is it worth reporting variant/phenotype associations without functional consequences at all (analogous to what we're doing now regarding ontology mappings)?

@tskir, let us know your thoughts and whether you'd like to schedule a discussion on this.


DO NOT MERGE: testbuild: lockdebug

First build failed during runtime tests due to:
17:58:39 ==> cilium-master-build-PR-1697-1: docker: Error response from daemon: IpamDriver.RequestAddress: Could not allocate IP address: Post http:///var/run/cilium/cilium.sock/v1beta/ipam?family=ipv4: dial unix /var/run/cilium/cilium.sock: connect: connection refused


Issues on subscribe page

Current Behavior

On https://meshery.io/subscribe page the color of buttons does not match with other buttons on different pages.

There is a grey color border which ig is not needed

There is no hover effect on the cards.

Contributor Guides and Resources

🎨 Wireframes and designs for Meshery Site in Figma
🖥 Contributing to Meshery Website
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hey @leecalcote @Nikhil-Ladha
I would like to work on this if such a change may be required.

The button color can be updated to be consistent with the whole site, and the border could be removed.
We don't need a hover effect on the card, because the card is not clickable, only the buttons are.

@Nikhil-Ladha I have raised the PR. Could you please review it </>


docs: update branding

https://unjs-nitro-c2qzjzpca-nuxt-js.vercel.app/
https://github.com/unjs/nitro/tree/docs/branding

I love it 😻 Let’s discuss tomorrow before updating branding in website.
Is it possible to include svg source for logo? 🙏

Pushed for svg sources!

Logo is not final for me but lets iterate...


operator images support multi platforms

fix https://github.com/SumoLogic/tailing-sidecar/issues/400

https://github.com/SumoLogic/sumologic-kubernetes-setup/blob/main/Makefile

ok, I will update soon.

LGTM. Can you also rebase on main? That should fix the failing check.

done

@swiatekm-sumo I forgat update multi-build in dev_builds stages.  I will open another PR to fix it. :-P


Readability of the figures

Many figures in the Conway spec still have some typesetting problems. Here are some typical ones, all of them appear multiple times:

[ ] Too much whitespace when using vertical vectors (e.g. Fig. 22). Solve using AgdaSuppressSpace environments?
[ ] Some spacing issues with vertical vectors, e.g. Fig 24 at the bottom constMap wdrlCreds 0 ....
[ ] We shouldn't use qualified names, e.g. GovVote.voter and some others in Fig 14.
[ ] It might make sense to replace some record construction with vertical vectors, e.g. in Fig 37.

Another one is the fact that some lines extend outside the figure box.  I'll add that to the list.


Sponge Support

This is nearing completion. Mainly commands left.

Moving Sponge support to 1.1.

I don't think this will be happening


View not refreshing (No change detection)

Dart VM version: 2.0.0 (Fri Aug 3 10:53:23 2018 +0200) on "macos_x64"
MacOS X 10.13.6
Chrome

I want to notify a parent component from a child component to update a view in the parent component, after saving an entry. I'm using the @Output annotation to parse back an event.
In the parent component the function "loadPosts()" is actually invoked, but the view is not updated. Not even with ChangeDetectorRef.
What happens:
place_component contains a "list-post" directive, which displays all posts.
place_component contains a modal, to add a new post with a directive "new-post"
When a new post is saved, a message is parsed back over @output to the "new-post" directive in the modal: (doneIt)="loadPosts()"
The loadPosts() function is executed, but the "list-post" directive does not reload.
See following Stackoverflow for details:
https://stackoverflow.com/questions/52295624/how-to-notify-parent-component-of-change-and-refresh-view

This should be reported to AngularDart not the SDK.

Apologies


applet.program.ecp5_sram: Initial ecp5 SRAM applet

I've started working on an applet for the ecp5.
Right now it supports the bare minimum: reading IDCODE, STATUS register and can download a bitstream.
The ECP5 expects the bit stream data to be sent MSB first, which is how the SPI flash is operating, but reverse to JTAG. So we need to reverse every byte before we send it out, I have a very crude implementation of this right now.

I see that you import bitarray, but don't see that it is used at all. Probably copied from somewhere else?
bitarray has some problems so the plan is to deprecate it. So I would prefer if there were no new users of bitarray added to Glasgow.
I didn't do a thorough review of the rest as I don't have enough experience with the ECP5 and JTAG.

Yep, bitarray is not needed. I was poking around with it to try to handle the bit reversal. I'll remove the import
Thanks for the comments! I'll work through them now.
Speed on the bit reversal isn't a huge impact. A bigger factor seems to be only calling shift_tdi with 8 bits at a time.
Here is a quick benchmark (552K bitstream, 6MHz TCK) for 2 bit-reversal methods.

Control ( _reverse() ): 14.2s
_lookup_table():        13.7s

Calling shift_tdi with 64bytes. 512 bits
_reverse():      4.7s
_lookup_table(): 4.0s

This PR has been sitting on my local branch for awhile now, would be useful to get it merged.
Because it's been so long, I've rebased the changes, and squashed my working commits.

Sorry for the delay, I had my hands full. I'll take a look soon!

Anything I can do to help this along?

@gregdavill Apologies for the huge delay--I'm currently working on updating this applet to the latest coding standards and working on merging it. I do have a few questions about the way you wrote it.

An issue I found while testing this applet is that it does not (as written) assert PROGRAMN at the beginning of configuration, so if e.g. there was already a bitstream, or if a bitstream load finished with an error, this is never reflected.

@gregdavill I've updated the applet to follow all of our standards and guidelines; it is almost ready to be merged! There are only a few items left.
Functionality:

The applet does not assert PROGRAMN at the beginning of configuration. This is probably done through some register, but without documentation (per items below) it's hard to figure out which.

Documentation:

Where did you obtain the encodings for IR_* instructions in glasgow.arch.lattice.ecp5?
Where did you obtain the programming algorithm for bitstream burst load?
Are the 10 cycles in Run-Test/Idle specified by some document (which?) or is this just a guess?

@gregdavill Friendly ping--I'd like to merge this! I've been explicitly allocating resources for Glasgow maintenance recently so things should go faster.

@gregdavill Hi! Pinging you again on these changes.
For documentation I'd like it to be added to our archive and the header to be updated to list it, the same way it's done in other files.
For the functional difference of 24/10 clocks I'd like that to be added to the applet.


Port for React Native

Please provide support for react native as well

hey, @rvuyyuru1
react-native is not yet in our roadmap.
but we will surely love if someone picks up and port it to react-native. 🙂
thanks.

I'm on it https://github.com/efoken/neopop-react-native
Already ported the most stuff to React Native, also with Web support and everything tested in Storybook 😄

@efoken great to hear


Allow skipping gerrit validation step

Some repos can have several non-gerrit commits between gerrit commits (automated commits, merges, etc) so checking only the previous 2 commits for validity can break stuff. We could increase the window... but if we know that all the repos are gerrit repos, we should be able to just skip this validation step.

Ahh that makes sense. While I do agree that "just upping the window" is not a perfect fix either since at any point the window can still be too small, I think adding another setting for something that (I think, given that nobody has mentioned it before) does not happen super frequently is also not the best.
The danger with that is that it increases complexity in configuration for users and also easily leads to issues for people who don't know how to properly set up workspace-specific settings and suddenly have every project of theirs recognized as a gerrit project due to them using global settings instead.
How would you feel about upping the window to (let's say) 50? That may sound like a lot but a simple regex operation that's only performed on initial start probably has a relatively low impact.

I guess my thought was that "if we just default it to false, only people who actually care about it will use it" same as the option that forces the versions. Do you anticipate people setting this option if they don't need it? Can we just make the comment clearer?

I think there's three things I'm afraid of:

There are people that won't know how/where to find this setting. Since VSCode settings are not super discoverable, people still have issues finding them and either post here asking me (which is the best case) or just give up on the extension altogether.
There are people that will use it wrong and will enable it for repos that it shouldn't be enabled for, for example by setting it in their global settings because they're don't know how the VSCode settings work.
This is also a bit of a "per-repo" setting and not a "per-user" setting. That means that it will have to be set in the .vscode/settings.json. That can be a bit of an issue for shared repos that use git and that have the settings.json file checked into the repository. Either everybody now has to use that setting (even if they don't have the extension or want to) or nobody can. With a team of 2 people it's generally fine but (from personal experience) in a bigger company it's not super easy to say "hey please add this thing to the repo for some extension only I want to use".

So for those reasons I tend to prefer "magically" fixing things. I wonder what you think though

I think it could be a per-workspace setting rather than per user, with the assumption "hey if you're using git in this workspace you're probably not using multiple different review systems" or they can multi-root. Could also do something like a map to specific workspaces to force enable it.
That said though... 50 is probably enough for any realistic use case, including mine, and I don't know if it's worth over-engineering this. I'm happy to close this if you just want to up it to a larger value.

Alright let's just go for that then, indeed sounds easier to just bump the value than to over-engineer. I'll make the change :)


Fixes #198

Allow EventBus.fire() to be called from another thread
Fixes #198

Wow nice! I thought this fix was going to be more complicated, but this is perfect!
Good work on the test too :grin:


port blake3 hash to this crate as an example of performance.

https://en.wikipedia.org/wiki/BLAKE_(hash_function)

https://github.com/BLAKE3-team/BLAKE3

Working examples count as docs, in a sense, so we'll add that label.


Add more languages and voices

tts config node allows to choose any language and voice available in Amazon Polly service (https://docs.aws.amazon.com/polly/latest/dg/voicelist.html)

Besides the comments I made, I think it may be more user-friendly if we pre-fill the dropdown with the first item in associated arrays.
For defaults, I may suggest en-US for the language and its first voice for the relevant field.
cc: @s-schumann


issue with missing reference

im not sure whats going on by the code is some how missing a component, which is part of the microsoft csharp code. this is the message im getting. im using the new Unity 6 engine. im going to try importing it using an older version of unity (such as 2023)
Assets\Depiction Engine\Runtime\Helper\Utility\FastMember\CallSiteCache.cs(4,24): error CS0234: The type or namespace name 'RuntimeBinder' does not exist in the namespace 'Microsoft.CSh\arp' (are you missing an assembly reference?)

nope. error still happens with unity 2022.3.21f1


Requests tx in order.

There is a problem with the way the TxSubmission protocol tracks which txs has been accepted. The only mechanics provided is a simple window size update. This means that if the server decides to fetch txs in an arbitrary order it is very hard for the client to keep track of which txid's it has sent to the client.
By requesting Tx in the order they where presented (if the server is interested in them) the client can easily keep track of a limited number of TXs (rather than all TXs sent since the start of the connection), and the server can verify that the client does indeed send newish txs.
Requesting tx in order also means that they get added to the mempool faster and thus propagate through the network quicker.

Fixes #2680 in a controversial way.

This doesn't fix #2680 it just makes it harder to trigger.


Server kills connection while sending a file

Server kills connection even when data is written in it. So this leads to error:
ERROR|Mon, 14  Jun 2021 13:28:18 GMT:Failed to send packet: {error,{closed,<<...>>}} @ io_proxy:tcp_send/2

The problem is connected with that the Send-File rules does not notify io_proxy about that connection is still in use and as a result io_proxy just kills it after KeepAlive time.


 This is likely to expose some amount of private data.
We should either

Add an option to ensure that those endpoints are unexposed
Require authentication to access those endpoints

I just stumbled upon this. I wanted to report it and found this issue already open.
I can confirm, except for debug, which returns a 404 error.

I was just looking through the issues before reporting this as well.
It makes it even "hard" to test out the beta, considering how InfluxDB kinda has to be exposed for Telegraf to reach it, at the same time InfluxDB should be able to scrape itself.
How about adding some sort of ACL for /metrics?
The /ready and /health routes are useful for k8s, obviously, and do not seem to be leaking sensitive information.
Having /metrics locked down to access from <IP_ADDRESS> would be a good sane default setting.

connect https://github.com/influxdata/influxdb/issues/20764

Closing this since we've split the work into multiple issues:

#20764 for pprof
#20755 for metrics


Feature Request: Rich Text Format (RTF) Copy

Description of the new feature/enhancement
Copy RTF data from selection. Useful for pasting text over to MS Word (or something similar).
Split off from #1146 for clarity.
Resources:
Copy and Paste Docs
DataPackage Docs (how to actually save the stuff. This is probably the more important doc)
Proposed technical implementation details (optional)
So, looking at Clipboard.cpp under ConHost's InteractivityWin32 project, should cover most of what is done. We're just slightly different in that we're using the UWP Clipboard API but that should actually make a lot of it much easier.
The data should already be saved in data in Terminal::RetrieveSelectedTextFromBuffer(bool). We just need to actually save it properly.

HTML copy was accomplished with #1224 . The logic should be pretty similar and will point you in the right direction.
Also adding the Help-Wanted tag in case anybody wants to implement this feature.

@carlos-zamora Attempted a PR (#3535) for this. Please have a look.


Try to fix these errors in branch 2body.

Try to fix at least some if not all.
Ignore the unused variable ones. They are not so important as of now.

The errors have been fixed except for there is some inheritance problem of the header file

@munishkr, changes are not in main() and the changes have not yet been pushed.
Issue reopened.

Modified the 2body branch. Fixes #5


ChefSpec unusably slow in ChefDK > 0.3.2

ChefSpec 4.2 is taking ~3 seconds per test
https://gist.github.com/someara/678301194a8c9b89e105

Is there an upstream bug report we can refer to?

Not yet. Was going to see if I could dig up more info before filing it with Seth.
—
Sent from Mailbox
On Sun, Jan 4, 2015 at 5:32 PM, Dan DeLeo<EMAIL_ADDRESS>wrote:

Is there an upstream bug report we can refer to?
Reply to this email directly or view it on GitHub:
https://github.com/opscode/chef-dk/issues/280#issuecomment-68659263

What version of ChefDK did you have before this problem appeared? Has ChefSpec been upgraded since then? Does the problem go away if you downgrade ChefSpec with a newer ChefDK?

The solution here is to use the new cached spec runners.
https://github.com/sethvargo/chefspec/issues/551
-s


istiod: upgrade path testing

Istiod has a considerable number of update paths we need to verify. The table below attempts to capture all of them and our progress on testing these. If you are working on this please add yourself as an owner.

Start
End
Priority
Results

Default 1.4
Default 1.5
P0
2/20 - no issues

Default 1.4
Non-istiod 1.5
P1
https://github.com/istio/istio/issues/20582, remote pilot broken chart (TODO PR), need to backport split profile, need to add mountMtlsCerts, prometheus broken, injection references wrong service

Minimal 1.4
Default 1.5
P1

Demo 1.4
Demo 1.5
P0
2/20 - no issues

Ingress SDS 1.4
Default 1.5
P0

Default 1.4
Default 1.5, no trustworthy JWT
P0

Default 1.4
Default 1.5, with Mixer
P0

Default 1.4
Default 1.5, with Galley
P1
Requires citadel, some other issues: https://github.com/istio/istio/pull/20517

Default 1.4
Default 1.5, with Citadel
P1

Helm 1.4
Helm 1.5
P0

Explicitly not supported:

Upgrades from (nodeagent) SDS
Nodeagent SDS as an end state

Might work, but not tested/supported:

Helm to istioctl migration

@howardjohn - Not all of the cases are P0's. John can you please update the test scenarios with required and must have so we know that not all scenarios are not release blockers. Thanks

found https://github.com/istio/istio/issues/21233 and https://github.com/istio/istio/issues/21232 which impact this

I have done some more testing today. Default -> Default and demo -> demo are good. Default -> Non-Istiod has ~5 different bugs I will send PRs for. I haven't tested the rest yet

1.4 -> Default 1.5, with Mixer seems to work, but I think its actually broken, because we mount certs and those will expire without citadel running. Also, after upgrade, the old proxies cannot talk to pilot (not sure how mixer comes into play here?)


feat(options): Disable foldtext for nightly

Considering https://github.com/neovim/neovim/pull/20750 was merged there is no need to utilize foldtext() helper for nightly

Thanks!


[Launcher]: Tune Framework Exit Spec

Coverage decreased (-0.02%) to 52.939% when pulling 6c727f2bd1b7867271bab83a6b2b1b31af351a68 on yqwang/launcher-dev into d001b9cac64364e5fa39f64790405ba47cf24108 on errorspec.


Print commands required to explicitly build module dependencies.

This PR resurrects #47 and builds on top of it.
Adds new flag -driver-print-module-dependencies-jobs to instruct the driver to scan for dependencies and generate build jobs for each dependent Swift or C module.
At present, this WIP does the following:

Invoke the Swift frontend Fast Dependency Scanner to prescan for dependencies.
Construct a ModuleDependencyGraph from the dependency scanner's JSON output.
Generate and print build jobs for each dependent module.

Next Steps:

Actually have the driver schedule and execute the dependent module build jobs ahead of time, eliminating the need to re-build those modules when it tries to import them.

I am new to writing Swift so I encourage reviewers to nit-pick with extreme prejudice.

Do we have a swift style guide akin to: https://llvm.org/docs/CodingStandards.html ?

As far as API design and naming questions: https://swift.org/documentation/api-design-guidelines/
For other stylistic decisions, this style guide is pretty close to standard library style, and should be preferred for this project as well IMO: https://google.github.io/swift

@swift-ci test

@owenv, thanks for catching this.

@swift-ci please test

@swift-ci please test

@swift-ci please test


Bugfixes

This PR addresses some bugs

Codecov Report

Merging #1 into master will decrease coverage by 42.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #1       +/-   ##
==========================================
- Coverage   42.40%   0.00%   -42.41%
==========================================
  Files           6       7        +1
  Lines        2224     662     -1562
==========================================
- Hits          943       0      -943
+ Misses       1097     662      -435
+ Partials      184       0      -184

Impacted Files
Coverage Δ

auth.go
0.00% <0.00%> (ø)

...-runner-launcher/github_actions_runner_launcher.go
0.00% <0.00%> (ø)

config.go
0.00% <0.00%> (ø)

setup.go
0.00% <0.00%> (ø)

token.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56e44a...9163468. Read the comment docs.


How to know if a json is compressed?

I have some old jsons that have not been compressed and I would like to program a logic that check if the json is compressed then decompress it else just return the original json.
Thanks!

You can try to uncompress it in a try-catch block. If it fails to uncompress, you can return the original data.

@Hedronmx does that work in your case?

This works perfectly!! Thank you!


Updated portal ID and made doc changes to reflect new API version

@nCastle1 please review

updated Portal ID to match the Android app (the one I was using was a test one)
updated doc to reflect the changes in API and toolkit versions

Sorry for the delay, this one fell off my radar.


Removing unnecessary safe operators

Hi Eugene!
If the constant or expression is null, the instanceof will not pass. So you don't need to use safe operator before every call.

Thanks, was coding in deep night time :)


Enable xplat tests

Whittling down #799.

Interesting, the failure is
MESSAGE:
Assert.Null() Failure\r\nExpected: (null)\r\nActual: ProjectRootElement { AllChildren = [], AllParents = [], Children = [], ChildrenReversed = [], ChooseElements = [], ... }
+++++++++++++++++++
STACK TRACE:
at Microsoft.Build.UnitTests.OM.Evaluation.ProjectRootElementCache_Tests.AddEntryStrongReference() in D:\j\workspace\_Windows_NT_D---eb124103\src\XMakeBuildEngine\UnitTests\Evaluation\ProjectRootElementCache_Tests.cs:line 115

That is a test I just enabled, but it just passed several times on my machine. This test is conceivably at the mercy of .NET GC behavior, but eyeballing it, it looks ok . . .
@dotnet-bot test Windows_NT Build for Desktop please

Ok, twice in a row isn't a coincidence even if it works on my machine. I'll leave that one off for now.

Curse you, CancelledBuildWithDelay40!
@dotnet-bot test OSX Build for CoreCLR please

@dotnet-bot test OSX Build for CoreCLR please

@dotnet-bot test OSX Build for CoreCLR please

@dotnet-bot test OSX Build for CoreCLR please


libunwind upstream doesn't exist

The repository rule points to a place (https://chromium.googlesource.com/chromium/llvm-project/libunwind) which doesn't exist.

Ah, yes. I discovered this today (not using the Arm targets at all yet... and Chromium changed to only require this for Fuchsia. Will fix.


Expiration Module Epic

Summary
This epic adds the concept of asset expiration to Provenance. When assets are added to the chain, expiration metadata is added so that the assets may be removed at a future date, allowing the head state of the chain to be minimized. The expiration process is designed to recover gas costs of the expiration operations and not require any per-block processing overhead in handling asset expiration.
Problem Definition
When storing assets on-chain, there is an expense in terms of node memory and processing that is associated with each added asset that is maintained in the head state. Without some method of expiration, the head state of the system would continue growing until it eventually becomes too large to be efficiently managed and system performance would degrade.
In many cases, asset lifespan may be estimated at creation so that the asset may be expired and potentially removed from active state. The expiration process uses node processing resources to prune the state, so the solution should offset gas costs if possible. Also, since a large number of assets may be monitored for expiration over a long lifespan, care must be taken to prevent expiration processing from adding too much overhead to the default processing loop for nodes.
Proposal

[ ] #961

[Child issues to be added here to support implementation]
Supporting Documentation
Draft ADR

For Admin Use

[x] Not duplicate issue
[x] Appropriate labels applied
[x] Appropriate contributors tagged
[x] Contributor assigned/self-assigned

@derekadams We have a duplicate epic created by @iramiller #689 with subtasks that we need to fold into one epic.


Changing confirmation text only works once

Hello!
I'm trying to dynamically change confirmation text. But dialog actually changes only the first time I change data-confirm value. Is there anything else I'm doing wrong or some event I need to trigger for this to work correctly?
I'm using v.1.3.0.
UPD. Updating to 1.6.1 made no effect.

Hi, sorry for the late reply.
When using data- attributes, the modal is built once by buildModal and then cached into the confirm-modal data attribute by getConfirmModal.
If you want to keep using data- attributes, you can use the newly exposed .getConfirmModal() to get the modal object, and then:
$(..).getConfirmModal().find('.modal-body p').text('new text')

Otherwise, you can use the window.dataConfirmModal() API, that creates new modals every time it is called.

Hi, it looks like $(..).getConfirmModal() is not in the latest release (v1.6.2). Could you please release it when you get a chance?

Hi @JamesPlayer,
1.6.3 has been pushed to rubygems. Thanks for the heads up.

@vjt - please could you push the latest version to npmjs? It doesn't look like it has been updated there. Thanks! :+1:

same here...


Have FakeAdapter.close() ensure that the adapter isn't closed multiple times

This would allow checking that sessions and by extension adapters are closed, e.g. when using a context manager's __exit__ method.

On closer examination, calling close multiple times in real life doesn't result in any error thrown so an alternative to ensuring that close cannot be called more than once (which it obviously can) is to keep track of whether it has been called or not.


sushid not syncing with connecting node when behind apache

When I start a sushid and give it a connecting node behind apache - it's not syncing from the connecting node:

It's connected to the node in the above view - but fetching wallet amount from testnet and from local node give different results:

If I start sushid directly against the port on the testnet - it does sync correctly:

So I think the problem is with the apache forwarding on the testnet AWS - I'm going to change this and put a LB in front of the sushid server and remove apache proxy and instead get the LB to forward the ports.

LB added in front of instance


jumpToIndex animation / inverted animations

Thanks for the great lib.
I've forked it to add support to animations when using jumpToIndex.
However I'm not making a PR because I've inverted the swiping directions. I think it makes more sense to swipe left to load the next cards and the opposite. It feels more natural to me, for example it's the same when using iBooks to change pages. (related article: https://ux.stackexchange.com/questions/71910/swipe-in-which-direction-to-get-to-the-next-newest-article)
Maybe it'd be useful to add a property to inverse the animations.
Also FWI I had to run additional commands to get the examples to run:
npm i # root folder
# in examples
npm i buffer
npm i react-native-vector-icons

Thanks, @cwagner22 The topic is really debatable. What might be good is to add prop that can be used to toggle the direction.

Also FWI I had to run additional commands to get the examples to run

Thanks again, I'll update the readme


Text API 2

Big thanks to @Minecrell for his work here. I just wanted to get a PR to resolve this ASAP and get it merged.
Some new features:

Name of Message/Text has finally been decided on. It will be Text, with Message.Text being Text.Literal
The generic getContent method has been removed
A lot of the factory methods have been moved to GameRegistry
Some more Translatable interfaces
Javadocs

This fixes #287, #263 and #435.

:+1:

Can't merge this.

@Zidane This is not yet ready for merge.

I added a Txt class that makes constructing text easier and adds some shorthand. There's a bit of debate on whether it belongs as a separate class or inside Texts, here's the arguments for both sides:
For:

Txt consists of utilities and shorthands(and has a shorter name) while Texts is a proxy to the factory, so they do different things and belong separately

Against:

Both contain methods related to constructing text, so they do the same thing and belong in the same class

@gratimax I think the Txt class belongs to the api.text package.

Is this almost ready to merge?

@me4502 #435 still needs to be done (and decided)

This PR is looking quite nice

Is this PR merge able yet?

Is this ready for merging?

@gabizou No.

@gratimax @Minecrell
How close are we on this? I would like to see this in master by Friday morning for preparation of SoS.

@Zidane While progress on this is going quite well, I'm pretty sure it won't be ready until Friday morning. This is a huge redesign of the Text API and time is quite short for me and @gratimax (afaik) right now, so finding a time to discuss things within the week is quite difficult - especially due to completely different timezones.
The PR for the API is not far away from completion, but once merged the implementation will break at a lot of places and the Text API implementation will have to be completely rewritten as nearly everything was changed. I've started this already but this is still in the beginnings. Only updating the implementation to have the current amount of implemented features would probably already take at least 1-2 hours if we would merge the API on Friday.
That's why I don't think we should merge this too early because I don't want to make any bigger (breaking) changes to the Text API after this. We should make sure the API as well as the implementation is stable and efficiently designed, as this will be a frequently used part of the API.

Is it possible to create new lines (\n) within a Text object?
I think that would be a really useful feature.

@boformer It works fine already: player.sendMessage(Texts.of("Hello!\nHow are you?")); prints 2 separate lines

Is this PR mergable?

@me4502 No, I'm still working on the implementation of the selector API changes. I've been a bit busy the last days.

Is it possible to get this completed and merged by next friday?

@Minecrell
Is this ready for merge?

@Zidane Everything is ready (both API and implementation) except the Selector API. There is no big point to keep the rest waiting any longer so I guess I can finish the selector API (mostly just implementation) separately from the rest.

@Minecrell I've rebased and squashed the entire PR. Everything should be in working order, i.e. everything should look exactly the same as it was before.

Looks good to me although I didn't went through the complete PR to check if everything is still there. :P


Create new virtual column AR extension for UI display text

New virtual column to be available to any and all classes. Created mostly for UI display to make text more consistent for all actions: add/edit/delete. In most cases, currently, we call common methods to process all records to be deleted, and in many cases we then display .description (when exists and available), rather than title/name. Title/name are used to populate tree nodes' text and application then displays same title/name text in confirmation messages for add/edit actions. This creates a dichotomy with add/edit actions using one set of text for messages and delete/destroy a different set (description) in some cases. Code now can selectively use new virtual column to set same common text for messages, and particular classes can choose to override that and use chosen one, name for example, on a per case basis.

@h-kataria @jrafanie @dclarizio @Fryguy @mzazrivec FYI, and comments.

@GregP Is there a BZ for this?

You would also have to actually make this a virtual column as all this does is just create a method, unless you don't need that.
How does this differ from the work @mzazrivec did in https://github.com/ManageIQ/manageiq/issues/16596 ?
In general I'm ok with the idea.  I don't love the name...would prefer display_name, but that was already taken in https://github.com/ManageIQ/manageiq/issues/16596, but perhaps we can just overload that?

@Fryguy No particular BZ, but this one has started the conversation: https://bugzilla.redhat.com/show_bug.cgi?id=1539118

@Fryguy display_name was already taken, as you mentioned, and I also figured we may as well have "virtual" in there so that its easier to id in code. Not married to any particular name at this point.

Sounds like https://bugzilla.redhat.com/show_bug.cgi?id=1501052 is the root BZ (and so should be in your commit messages), and it also looks like that BZ should be moved back to ON_DEV.  cc @dclarizio

Also needs tests...at least for candidate objects from different domains (by domain I mean, cloud, virtual, policy, automate, etc).  I'd argue you should make a test for every object. but that might be overkilll.

@GregP we had agreed the name of this column would be ui_display_name.  The use of virtual_ here is confusing.

Perhaps using "_name" is too specific since derived value can be a number of things: description, title, name, ems, even record id in some cases.

I personally quite dislike the fact that in UI, to address a particular object, we sometimes choose name and some other times we choose description (or something else).
My understanding is that this all started because for some users, the name column was too short and wanted to use longer strings. If that was the true problem, then we should have simply extended the length of name column(s) and use name everywhere.
Though if we want to go down this road, I don't understand why we're doing it in models. Seeing this is purely a matter of UI presentation, this should live in the UI repo (presenters perhaps?).

@Fryguy https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller.rb#L2083 has been there from long time, long before ui repo split, is there a way to find out when that was added commit/comment info, trying to figure out the case when we would want to display EMS name of record instead of record name in the flash message.

I still contend that display_name from a model perspective is better...we could pass this value over the API in the future or in reports, so it should not be ui-specifically named.

@h-kataria git blame leads to

ManageIQ/manageiq-ui-classic@8ff3020e5e  (transferred from https://github.com/ManageIQ/manageiq/commit/cf33fd477371c5dfd23dfdb2c05601cc3edbde29)

ManageIQ/manageiq@23c22b853c2eee362e1a55966824fda7bb423a2

commit 23c22b853c2eee362e1a55966824fda7bb423a27
Author: Greg Piatigorski<EMAIL_ADDRESS>Date:   Wed Nov 20 14:42:43 2013 -0800

    Refactored code to display Service name instead of description when deleting

    Refactored application_controller, ci_controller and service_controller to to display Service Name in flash messages when deleting Services.
    Created spec for Service Controller

    BZ 990775

ManageIQ/manageiq@c4a0f0969970bbd3d34a37b7c6a99021547d24c2

commit c4a0f0969970bbd3d34a37b7c6a99021547d24c2
Author: Harpreet Kataria<EMAIL_ADDRESS>Date:   Fri Nov 8 16:33:46 2013 -0500

    Updated flash message for Refresh button on ISO datastore & PXE server

    Update flash message when Refresh button is pressed for ISO datastores and PXE servers to show display name instead of a raw task name string. Changed process_elements to accept display_name as a parameter with default value n

    bug 1025853

@h-kataria That being said, get_record_display_name is only used in
app/controllers/application_controller/ci_processing.rb  (in process_elements and process_elements_destroy)
app/controllers/miq_ae_class_controller.rb
app/controllers/ops_controller/settings/analysis_profiles.rb
app/controllers/pxe_controller/pxe_customization_templates.rb
app/controllers/report_controller/dashboards.rb
app/controllers/service_controller.rb
I do realize that ci_processing.rb is all CIs, but if I literally pass an EmsCluster object through get_record_display_name it will return the EMS name, so clearly it's being used extensively or we'd be getting issues all over the place.

@Fryguy in most cases i think it returns description of a record and doesn't even get to return ext_management_system.name if respond_to?("ems_id") this line of code.

@mzazrivec

I personally quite dislike the fact that in UI, to address a particular object, we sometimes choose name and some other times we choose description (or something else).

My understanding is that this all started because for some users, the name column was too short and wanted to use longer strings. If that was the true problem, then we should have simply extended the length of name column(s) and use name everywhere.

Though if we want to go down this road, I don't understand why we're doing it in models. Seeing this is purely a matter of UI presentation, this should live in the UI repo (presenters perhaps?).

I'm not so sure a presenter can figure this out, especially since it's not like we have a name field text string and just need to figure out how to present/format it.  I'm open to ideas though to do it this way, it's just that the presenter has to figure out then which field to use to show names and if some model comes along that decides to use a my_name field (for whatever reason, perhaps an outside vendor plugin), we have to alter our presenter.  Can you maybe give an example how it might work in this case?
The other issue is regarding @Fryguy's comments:

I still contend that display_name from a model perspective is better...we could pass this value over the API in the future or in reports, so it should not be ui-specifically named.

I do like display_name so it is not UI dependent and would be helpful in the API and reporting (should someone writing a report want to match what is seen in the UI/API).  This also supports having the logic at the model level.  Have to verify that display_name is not in use in any of the models currently.

While I agree mostly, unfortunately name sometimes means "unique identifier" on the backend, and in other cases it's used closer to a "short description". Changing that from a backend perspective may be too complicated at this point.

Exactly . . . and at times we've tried to make the name field work both ways and ended up adding a description later due to restrictions (length, no spaces, etc) put on the name field.

I do like display_name so it is not UI dependent and would be helpful in the API and reporting (should someone writing a report want to match what is seen in the UI/API). This also supports having the logic at the model level. Have to verify that display_name is not in use in any of the models currently.

Already did :smile:   ☝ https://github.com/ManageIQ/manageiq/pull/17577#issuecomment-397056096

@Fryguy Looked at the list of all objects that currently have display_name defined, its rather extensive. Almost every model, for example. Not sure how to proceed.


Force quit after the grace period while closing the Logs Agent.

What does this PR do?
This PR adds a small timer to give some last seconds to the stoppers and then finally force close the Logs Agent.
Motivation
We use different stoppers (serial/parallel) to stop everything in the Logs Agent in order to not lose any line of log.
However, in some circumstances (reproduced only on Windows) with an Agent monitoring its own log file, when no network is available while closing the Agent, the stoppers never successfully complete.
The Agent is stopping and there is no network: we won't be able to send the logs in anyway.
This PR adds a small timer to give some last seconds to the stoppers and then finally force close the Log Agent.
Additional Notes
To be more precise, the input/file/scanner.go stop method never completes because the decoder of the tailer never flushes properly. The routine is stuck listening on the tailer done channel: https://github.com/DataDog/datadog-agent/blob/master/pkg/logs/input/file/tailer.go#L199
There may be a better solution as the tailer is also selecting on a forwardContext signal, but don't know what can trigger it. https://github.com/DataDog/datadog-agent/blob/master/pkg/logs/input/file/tailer.go#L251

@ajacquemot I've slightly modified the implementation to log a stack trace if we enter in the "force close" branch of code, in order to have more information to retrieve if it's happening in the wild.
Could you give it a quick glance again? Thank you.

Just reviewed the PR, looks good, I feel like the go routines dump could be move somewhere else so that it can be reused by any package of the project


[Drilldown Menu] Wrong JS events listed in Documentation

The Javascript events in the documentation for the Drilldown Menu appear to be wrong. I tried the open event, which is listed in the docs as 'open.zf.drilldownMenu', but nothing was happening when I set up a listener for it. Using 'open.zf.drilldown' however, worked as intended. This was with version 6.2.3.

This is still an issue in version 6.4.

How come this has not been fixed in a release?
Googled for 1h before finding this, and solving my problems.
The event name is still open.zf.drilldownMenu in docs, and needs to be open.zf.drilldown

Looks like it was fixed in f7e63fd by changing the docs title, but then the title was changed back 72844c8 for consistency. That probably reintroduced the issue.

Appologies folks... Have to accept my mistake... I just updated it for the sake of docs search but that was a mistake...
Fixed it now ... Added a PR!


Heatmap slicer broken

Bug report
The _gen_idxs function has a residual mpl_gr_33 which was removed at some point in the past when this stopped supporting mpl 3.2.
https://github.com/ianhi/mpl-interactions/blob/e559c0aefe6f14eedffacd0af2007b0d81116149/mpl_interactions/generic.py#L189
Code for reproduction
Try using heatmap_slicer

oops lol. that may have been broken for awhile.

oops lol. that may have been broken for awhile.

gotta use the actual matplotlib widget tests to catch stuff like this. like mocking events

gotta use the actual matplotlib widget tests to catch stuff like this. like mocking events


42812 crush when deleting db during push replication

(The FB ticket is 42884, with 42812 as the parent case.)

I think that bar the line changing 2k for 10k test docs and the few notes you might want to add, this PR's basically good to be merged.


Dispersion refinements

@shabihsherjeel This is mainly refactored into classes (I thought all these nested functions are not too nice). I added, however, requests and requests-cache to the dependencies (requests was there as a sub-dependency before).
The most crucial change to review is probably the changes in convert.py I did.
I think with this the parser should also be final for now.

It looks all good to me. :+1:


Anthropic prompt caching

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution! We are working on more generalized support for different cost tracking scenarios on the server side. Closing this PR in favor of that approach.

Is there an open Issue for this? Would also love to have accurate cost tracking for Anthropic Claude PDF Support. Which combines cost for image-based and text-based calculations.


web-mari0

i need some help with mari0, i want to make an html/js port of it and i need help!

Hey, I've already ported mari0 to web. You can see it here: http://tannerrogalsky.com/mari0/
If you're having other problems with this project, please be more specific in any issues that you open.

i know its there but i cant make it with the github clone, can you give me the files that u use for the port?

I follow exactly the instructions but it always freezes

Sure, my site is open source and hosted on github. You'll find the relevant folder here:
https://github.com/TannerRogalsky/tannerrogalsky.github.com/tree/master/mari0

cool thanks.... but why does my port crash? what i am doing wrong?

I need a lot more information from you. Where does it crash? What error messages are you getting? What's your browser and OS? Are you using the debug release of this lib?

i am using the master branch from github, i clone all files like it should and follow the instructions, in the debug it says my main.lua is not in the root, here a screenshot!
http://imgur.com/2tTY14f

the love.js is freezing, but your version is working

i am uploading my dbg folder

You're not packaging the game correctly.
Double check that you're following these steps exactly.

python ../emscripten/tools/file_packager.py game.data --preload [path-to-game]@/ --js-output=game.js
This should output two files: game.data and game.js into the debug folder.
Make you include the '@/' after the path to your game source. This will tell the file packager to place your game at the root of Emscripten's file system.
Make sure your [path-to-game] does not contain any non ascii characters

i did,  (here my debug folder https://drive.google.com/open?id=0B-MZzriUapsTQkRlNnNvR2JXMGM
python2 ../emscripten/tools/file_packager.py game.data --preload /home/lugarius/Downloads/future-mari0-master/game.love@/ --js-output=game.js
python2 because python is python3

shit... have to learn markdown

Try packaging the top-level game folder rather than the .love file.

like this?
python2 ../emscripten/tools/file_packager.py game.data --preload /home/lugarius/Downloads/future-mari0-master/@/ --js-output=game.js

(ps : there is a new offical version of mari0 for love2d 0.10.1 https://github.com/Stabyourself/mari0)

python2 ../emscripten/tools/file_packager.py game.data --preload /home/lugarius/Downloads/future-mari0-master@/ --js-output=game.js
It's worth noting that I made some changes to mari0 to get it to work with the port (removed networking, updated some shaders to be OpenGL ES2 compliant) so your download of future-mari0 will not work out of the box with love.js.

Error: [string "boot.lua"]:432: No code to run
Your game might be packaged incorrectly
Make sure main.lua is at the top level of the zip
stack traceback:
(tail call): ?
[C]: in function 'error'
[string "boot.lua"]:432: in function <[string "boot.lua"]:274>
[C]: in function 'xpcall'

your game.data is not an zip archive....
http://imgur.com/KuXIbqC

can we work together on an mari0 made for the web? i could help with mappacks and you can help making the js and the game data?

I'm not interested in that. Sorry.

ok
can you give me the files that you used for the webversion, you said you have modded them?

i want to make that alone then, but i need the source pack, and the instructions how you made it,

@TannerRogalsky can you give me the game.love file and the instructions to make an working game.data file?
i want to mod it with more stuff so that is better in the web.  If you are not interested to work together, give me the last things that i need to do that alone please.

Sure, the changes I made for the web port are on my fork. https://github.com/TannerRogalsky/future-mari0/tree/remove_threads


Determine if image has transparency

Description
I need to be able to determine if an image has a transparent background. In the event that it does I would then need to replace the transparency with a color. Is there a way to do this in the existing API? Basically something like this...
var imageFactory = new ImageFactory.Load(inStream);
if(imageFactory.HasTransparentBackground)
{
    imageFactory.ReplaceTransparency(Color.Black);
}

There's no way to tell whether an image has transparency without checking it pixels since all images are loaded with 32bit format.
I would use the FastBitmap class to check the ImageFactory.Image to avoid having to use pointers for decent performance..
bool hasTransparent = false;
Image image  = imageFactory.Image;
using (var fast = new FastBitmap(image))
{
    for (int y = 0; y < image.Height; y++)
    {
        for (int x = 0; x < image.Width; x++)
        {
            if(fast.GetPixel(x, y).A < 255)
            {
                hasTransparent = true;
                break;
            }
        }
    }
}


=tck,api #333 Add license headers to TCK and API

Follow up to #333 in which we added license headers to examples already but forgot to do so for API an TCK.
The entire project is CC0, so this makes not change to licensing or actual artifacts.
Please review/chime in.

Thanks @ktoso ! :+1:

Ping @reactive-streams/contributors

@reactive-streams/contributors Merging.


 Maybe it's more useful to display the RoutedToJobId and RoutedFromJobId fields?

I do want to know about both routed and unrouted. If you want routed to/routed from, I could do
    FROM      JOB ID TO          OWNER     SUBMITTED   STATUS  SINCE       [OSG] PROJECT NAME              BATCH PROJECT
               259.0 -> 260.0    osg       8/17 04:12  R       8/17 04:14  TG-DDM160003                    -
   259.0 ->    260.0             osg       8/17 04:12  R       8/17 04:14  TG-DDM160003                    TG-DDM160003
               261.0 -> 262.0    osg       8/17 04:15  R       8/17 04:16  TG-DDM160003                    -
   261.0 ->    262.0             osg       8/17 04:15  R       8/17 04:16  TG-DDM160003                    TG-DDM160003
               279.0 -> 280.0    osg       8/18 03:51  R       8/18 03:55  GravSearches,UTAustin_Zimmerman -
   279.0 ->    280.0             osg       8/18 03:51  R       8/18 03:55  UTAustin_Zimmerman              GravSearches

or separate tables (some tweaking required):
-- Schedd: tacc-stampede2-ce2.svc.opensciencegrid.org : <<IP_ADDRESS>:35797?... @ 08/18/21 03:58:11
  JOB ID        TO     OWNER     SUBMITTED   STATUS  SINCE       [OSG] PROJECT NAME              BATCH PROJECT
   259.0   -> 260.0    osg       8/17 04:12  R       8/17 04:14  TG-DDM160003                    -
   261.0   -> 262.0    osg       8/17 04:15  R       8/17 04:16  TG-DDM160003                    -
   279.0   -> 280.0    osg       8/18 03:51  R       8/18 03:55  GravSearches,UTAustin_Zimmerman -

-- Schedd: tacc-stampede2-ce2.svc.opensciencegrid.org : <<IP_ADDRESS>:35797?... @ 08/18/21 03:58:12
  JOB ID          FROM OWNER     SUBMITTED   STATUS  SINCE       [OSG] PROJECT NAME BATCH PROJECT
   260.0   <-    259.0 osg       8/17 04:12  R       8/17 04:14  TG-DDM160003       TG-DDM160003
   262.0   <-    261.0 osg       8/17 04:15  R       8/17 04:16  TG-DDM160003       TG-DDM160003
   280.0   <-    279.0 osg       8/18 03:51  R       8/18 03:55  UTAustin_Zimmerman GravSearches

The reason I want to see both routed and unrouted is to make sure the transforms worked as expected so having them right next to each other would make seeing that easier.

I like the first one but could you slightly adjust the spacings of the headings so that the TO is right above the RoutedToJobId field?
    FROM      JOB ID    TO       OWNER     SUBMITTED   STATUS  SINCE       [OSG] PROJECT NAME              BATCH PROJECT
               259.0 -> 260.0    osg       8/17 04:12  R       8/17 04:14  TG-DDM160003                    -

Done.

On second thought, can I get rid of the RoutedFrom/RoutedToJobId fields? They are making the output pretty wide. I guess I don't need the "R" column either -- pretty easy to tell which one's routed (the one with the even-numbered ClusterID).

pretty easy to tell which one's routed (the one with the even-numbered ClusterID)

I don't think this is necessarily true for busy CEs but maybe you don't care. Maybe you can get away with two columns:
GridJob  RoutedJob ...
259.0    260.0 # populate the rest of the fields with grid job info
261.0    -  # unrouted job


Check TPI stream is valid before creating it

The examples erroneously create a TPI stream before checking that it is valid to do so. This is likely a copy-paste error, as on a first look it seems that we are doing the same for DBI. However, for DBI there are two checks, which has probably created this confusion:

Great, thank you for finding and fixing this!


Implemented awaiting lazy iterator, fixed duplicated global ratelimit warning.

Codecov Report

Merging #19 into master will decrease coverage by 0.13%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   79.74%   79.61%   -0.14%
==========================================
  Files          78       78
  Lines        9560     9584      +24
  Branches     1225     1229       +4
==========================================
+ Hits         7624     7630       +6
- Misses       1881     1899      +18
  Partials       55       55

Impacted Files
Coverage Δ

hikari/impl/rest.py
88.69% <ø> (-0.02%)
:arrow_down:

hikari/utilities/iterators.py
36.39% <33.33%> (-0.82%)
:arrow_down:

hikari/impl/rate_limits.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5debac...1f381ac. Read the comment docs.


Refactor/save bench to file

@yumetodo そもそもrender時benchmarkをOFFに方がいい。更新が早すぎてcrashの可能性もある— 全くCloudFlareは最高だぜ (@MaverickTse) 2016年10月30日
ということでファイルに書き出すpatch

@MaverickTse changed to stop io when process video.

I said you need a NEW checkbox, not removing the title bar display!!!
That means set CHECK_N to 6 and add a new label for it.
I have already added a function to disable the benchmark checkbox when saving, so don't wipe it out.

not removing the title bar display!!!

!?
...I was missed

Also, your log file implementation need to associate with a new checkbox on the UI.

this. I'm trying to fix this.

take your time, no rush, don't work overnight

なんでWM_COMMANDが来てかつwparamが50344749のときにfunc_WndProc_conがコケるんだ・・・？なんか影響のある変更したっけか

なんでWM_COMMANDが来てかつwparamが50344749のときにfunc_WndProc_conがコケるんだ・・・？なんか影響のある変更したっけか

I'm also experiencing strange error. Previously, I tried adding an extra value to
int		check_default[] = { 1, 0, 0, 0 };
then AviUtl crash immediately on startup :-\
Maybe FILTER_DLL**  GetFilterTableList(void) has bug, I'm not sure.
Anyway, try keeping check_defaut to 4 items and see if the error goes away.

I think use config file to enable benchmark is best way. How do you think?

Just submitted a new patch. Try again.

fixed!

お疲れ様でした　👍


Upgrade VSSDK

Description
Upgrading the version of VSSDK Build tools nuget, because the older one is incompatible with the latest VSSDK.
Related issue
https://github.com/Microsoft/vstest/issues/1760

@dotnet-bot test this please

@dotnet-bot test Ubuntu14.04 / Debug Build please

@dotnet-bot test Ubuntu14.04 / Release Build please


feat(runtime): add support for async code transformation

Summary
Fixes #9504

Test plan
e2e test added

Codecov Report

Merging #11191 (507c635) into master (858c50b) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #11191      +/-   ##
==========================================
- Coverage   64.31%   64.27%   -0.05%
==========================================
  Files         307      307
  Lines       13444    13458      +14
  Branches     3281     3285       +4
==========================================
+ Hits         8647     8650       +3
- Misses       4090     4101      +11
  Partials      707      707

Impacted Files
Coverage Δ

packages/jest-runtime/src/index.ts
54.85% <50.00%> (-0.74%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858c50b...507c635. Read the comment docs.

@thymikee this is ESM already as we cannot support async transformation for CJS, although via type: 'module' in package.json rather than mjs.
Or am I misunderstanding your question? 😅

I meant the file to be my-transform.mjs and checking if a transform can be written in ESM instead of CJS. But I'm not really up to the speed with all the ESM changes, so pardon if I ask some dummy questions 🙈

Ah! I added a test for that together with the feature in #11163.

Perfect, thanks! I see these are separate responsibilities, could have checked it before asking :)

No problem 👍

Hmm, I observed something odd. After adopting next-5, transformers lost this value in getCacheKey and process when running with Node ESM. That doesn't occur with Node CommonJS. Is this behavior expected or is it a bug?

Please open up a separate issue.
Note that we've never really supported using classes, so I don't think we've ever officially supported any form of this. However, I'm surprised this changed between next.4 and next.5

oh nvm, i think something funky with my node_modules :)


Self-defense against pump issues

We've had reports of partitions wedging and making no forward progress.
This only seems to happen to people who have topic claim mode active,
but partition mode health checking may just be masking it.
This patch does two things:

Watch the last time we saw a message. The health check loop will now
release partition claims if the consumer velocity hits 0 and we are not
caught up. This is true even in topic claim mode.

This also fixes a (potential) issue where updateOffsets is failing
on calling PartitionOffsets (a Kafka call). In that mode, we'd never
updateCurrentOffsets and the heartbeat loop would continue happily. If
this was happening I'd have expected log entries, but let's make this
more failure-proof anyway by checking errors.

cc @robot-dreams


Add configuration back

revert https://github.com/Fullscreen/yt/pull/318

Coverage increased (+0.06%) to 93.227% when pulling b4d95762c5670ec3224b4bbe10dddd1fbadc899f on add-yt-support-back into 65489d64196edd283a0e3315a0c8647c62b6c135 on master.

🎉


Add missing Nuxt 3's generated dirs

Update

[x] Template - Update existing .gitignore template

Description
I updated the Nuxt section to include the new Nuxt 3 generated folders.
References

Official .gitignore file.
Nuxt Team's recommended .gitignore entries.

Thank you for such a quick response!
I made a PR to the upstream repo, but it looks they haven't approved anything in a while. So I moved the changes to a separate NuxtJS file, as you suggested.

Thank you for contributing @luvejo !


Crash on startup

Describe the bug
Chatterino crashes on startup
[FFZEmotes] Reload FFZ Channel Emotes for channel "148973258"
chatterino: ../src/providers/ffz/FfzEmotes.cpp:22: chatterino::Url chatterino::{anonymous}::getEmoteLink(const QJsonObject&, const QString&): Assertion `emote.isString()' failed.
[1]    42191 abort (core dumped)  chatterino

After removing that channel, next channel crashes
[FFZEmotes] Reload FFZ Channel Emotes for channel "22484632"
chatterino: ../src/providers/ffz/FfzEmotes.cpp:22: chatterino::Url chatterino::{anonymous}::getEmoteLink(const QJsonObject&, const QString&): Assertion `emote.isString()' failed.
[1]    42618 abort (core dumped)  chatterino

To reproduce
Unsure. Something related to FFZ Emotes.
Screenshots

Chatterino version
7d2b640874d1975492bb6c814acd2bba944e72be
Operating system
Manjaro
Aditional Information
Maybe related to FFZ doing maintenance today?

My chatterino is crashing instantly the moment I try to open it. I reinstalled multiple times - then finally i am able to open it but the moment I type a channel name and press enter it crashes again.
"Application Specific Information:
Assertion failed: (emote.isString()), function getEmoteLink, file ../src/providers/ffz/FfzEmotes.cpp, line 22."
is part of the report, not sure how to fix.

You can fix it temporarily by commenting out the Assert in FfzEmotes.cpp line 22 and recompiling

After doing some investigating, the FFZ API is returning nulls in their emote URL responses.
GET https://api.frankerfacez.com/v1/emote/381434

{
	"emote": {
		"id": 381434,
		"name": "4House",
		"height": 32,
		"width": 32,
		"public": true,
		"hidden": false,
		"modifier": false,
		"offset": null,
		"margins": null,
		"css": null,
		"owner": {
			"_id": 512619,
			"name": "auqra",
			"display_name": "auqra"
		},
		"urls": {
			"1": "//cdn.frankerfacez.com/emoticon/381434/1",
			"2": null,
			"4": null
		},
		"status": 1,
		"usage_count": 13,
		"created_at": "2019-08-19T18:41:46.408Z",
		"last_updated": "2019-08-22T09:20:09.237Z"
	}
}

However, Chatterino only checks for undefined values, not null values:
https://github.com/Chatterino/chatterino2/blob/7d2b640874d1975492bb6c814acd2bba944e72be/src/providers/ffz/FfzEmotes.cpp#L16-L20

So what's the solution?

@thelobbylegend see #2192

@swills I see it but what am I supposed to do lol. I see a bunch of words.

Download and test the build artifacts from https://github.com/Chatterino/chatterino2/pull/2192/checks?check_run_id=1408346531

https://github.com/Chatterino/chatterino2/pull/2192/checks?check_run_id=1408346531 - Download the correct build in artifiacts 3. Then merge the fix in #2192; it fixes the issue~

@swills @jonnyboy123321 Ok, it worked. A message is prompted (see attached). I installed the update and chatterino would start crashing again. I uninstalled chatterino and downloaded from artifacts again without updating it and it works fine. I assume I just shouldn't install the update for chatterino?
Message: https://gyazo.com/4ea592ad6175f60e44ee0f1f45643982

The update is not meant for nightlies. Ignore them on such builds.

Ah got it. Thank you all.

Just wanted to chime in and say sorry for the trouble. I 100% did not expect anyone to have any issues since the fields are null, but here we are.
(This happened because I've started serving the v1 API from a newer codebase that does output sanitization based off a schema, and it will insert null values where data is missing. Plus side, the new API is considerably faster and has a new caching scheme that means emotes update pretty much instantly. We also have new generated docs at https://api.frankerfacez.com/docs/)


Styles support?

Hi, thanks for an awesome tool! 😄
Most styles do not seem to work for me, so before I dig a bit deeper, I thought I'd quickly ask if its expected to work.
For example, if I have:
      element "Database" {
        shape Cylinder
        color #ff0000
        background #dddd00
        stroke green
        opacity 50
      }

The shape (ie Cylinder) will take effect, but none of the other properties. And actually the shape only seems to take effect with some values, but not all of the official DSL shapes.  Is this just not supported (yet), or shall I dig deeper?
Thanks!

Hi. you are welcome :)
Did you set
"c4plantuml.tags" "true"

in your views properties?
That switch can make a difference. See also https://github.com/avisi-cloud/structurizr-site-generatr#customizing-the-generated-website and  https://github.com/structurizr/export/tree/main/src/main/java/com/structurizr/export/plantuml#c4plantumlexporter

Ah, that was it! I hadn't realised that needed. My styles are all working now 😄
Thanks again!


gnunet: 0.17.2 -> 0.17.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gnunet/versions.
meta.description for gnunet is: "GNU's decentralized anonymous and censorship-resistant P2P framework"
meta.homepage for gnunet is: "https://gnunet.org/"
meta.changelog for gnunet is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.17.6 with grep in /nix/store/9p5p99l06bwy68jfm19a1x6vpa0xy971-gnunet-0.17.6
found 0.17.6 in filename of file in /nix/store/9p5p99l06bwy68jfm19a1x6vpa0xy971-gnunet-0.17.6

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
gnunet
gnunet-gtk
taler-exchange
taler-merchant

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9p5p99l06bwy68jfm19a1x6vpa0xy971-gnunet-0.17.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gnunet https://github.com/r-ryantm/nixpkgs/archive/dc43e4bd82ecb7bfe90fce97a39b0140c571d3cf.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9p5p99l06bwy68jfm19a1x6vpa0xy971-gnunet-0.17.6
ls -la /nix/store/9p5p99l06bwy68jfm19a1x6vpa0xy971-gnunet-0.17.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

gnunet
gnunet-gtk
taler-exchange
taler-merchant

Maintainer pings
cc @pstn @vrthra for testing.

@dvn care to check this?

Looks good to me. Compiles and runs.


Check constraint is not displayed in table DDL

System information:

Operating system (distribution) and version Win10
DBeaver version 21.0.0

Connection specification:

Database name and version SQL Server

Steps to reproduce, if exist:
Open DDL tab for a  table with check constraint, e.g.  CREATE TABLE Persons (     ID int NOT NULL,     LastName varchar(255) NOT NULL,     FirstName varchar(255),     Age int CHECK (Age>=18) );
Expected: Check constraint is displayed in DDL
Actual result: Check constraint is not mentioned in table DDL

Fixed in 21.0.2

Definition and constraint names fixed.

verified


Title alignment

How can I align the Title to the right just like the default flutter stepper? Why is it at the bottom by default for vertical stepper?

Same question here


Linux - Scan doesn't rescan but list networks

Expected Behavior
In some case, wifi list doesn't update automatically and we need to rescan networks manually using linux cmd nmcli wifi rescan.
Current Behavior
Actually with node-wifi, usage of wifi.scan() do a nmcli wifi list which doesn't perform rescan but listing networks we got at the beginning.
If we add a new network by tethering for exemple, it doesn't appear in our list.
Affected features

[X] node API
[ ] cli

Possible Solution
Change list argument to rescan at this line:
https://github.com/friedrith/node-wifi/blob/master/src/linux-scan.js#L14
Context
Changing this line will do a rescan instead of a list, cover more use case and fit with the name 'scan'

The official nmcli documentation says (https://developer.gnome.org/NetworkManager/stable/nmcli.html):
By default, nmcli ensures that the access point list is no older than 30 seconds and triggers a network scan if necessary. The --rescan can be used to either force or disable the scan regardless of how fresh the access point list is.