Navigate to first/last element of surrounded parents

Is blocked by: #167
Is your feature request related to a problem? Please describe
Right now, you can navigate in the tree view from an element of a parent to the first (or last) element of the previous (or next) parent only when you expand the other parent.
Desired solution
In addition to #167 new Buttons should be added, that can jump to the first element of the same type from the previous parent and the last element of the same type from the next parent. The buttons should encase the 'previous/next' buttons. An idea for their icons could be '<<' and '>>' or the related media control symbols.

This is no longer required due to the changes to #167.


Google side settings?

I see an option for Bot URL* that requires an https endpoint... is that what I should be using? how do I get bot studio/ laravel to serve as https?

I found the ACTUAL problem, config/botman/hangouts.php has ENV() which references entries in the .env file where the hangouts token was not defined. So don't make changes to the HangoutsDriver.php file directly (if you do that's fine, but it needs to be 'token' => 'YOUR-WEBHOOK-TOKEN', not 'token' => ENV('YOUR-WEBHOOK-TOKEN')), instead put the token in the .env file with HANGOUTS_TOKEN=YOUR-WEBHOOK-TOKEN


Differences with skia-canvas?

Hello,
What are the main differences with skia-canvas as below? Thanks.
https://github.com/samizdatco/skia-canvas

@xeoshow this library is aim to provide zero system dependency experience and targets more platform.

This is extremely needed, since gyp c++ is really very very hard to use ...


Allow domain removal

Users with the role "System admin" should be allowed to remove domains instead of just disabling them.

@llopat ,
The main reason for requesting this feature was to remove domains that might never be used again. In the case of the virtual lab scenario, I expect that there will be many such domains over time (e.g., students that have graduated). In many cases universities even disable the accounts of such students, so even if they wanted to, they wouldn't be able to login into NMaaS if an IdP integration is in place. Taking this into account, the preference for the mentioned features is as follows:

domain is no longer visible in the Portal (including the system administrator users)
Strongly preferred that the domain is no longer visible in the Portal. If you think that soft-delete is the way to go and simply mark the domain as deleted, without removing the entry itself from the database, this is fine. This might prevent new domains to be created with the same name, but in the context of the virtual lab use-case this might not be a problem. We might think whether a recreation of a new domain with a previously used name would be desired for other use-cases though. If yes, maybe we can just alter the domain name and add a suffix -DELETED$TIMESTAMP  `if there is a constraint on the domain name in the database.

all users with roles assigned in a domain have those roles removed
Yes, this sounds acceptable.

domain is entirely removed from the database (including application instances, no history, risky(?)) - new domains with the same codename can be created in the future
Tackled above, soft-delete is an option that might be worth exploring. The important thing is that in the case of the virtual lab scenario, yes, any active instances should be deleted as well. There should be a clear warning for this when an admin tries to remove a domain.

k8s namespace removal script is triggered
Yes, this would be great.

removal possible only if no application instances are running within the domain
Well actually as mentioned above it should be preferred if domains with active instances are deleted. There might be some stale instances no longer used by the domain owner, and it shouldn't be up to the administrator to find these manually and manually delete them before removing the domain.

maybe removal only possible for domains created from bulk deployment ?
I think this would complicate things too much, and it might not be clear to other potential administrators why the feature is available in some cases and not in other.

Even with the soft-delete approach, it is not expected that a deleted domain will ever need to be reactivated. That's the function of the "disable" feature. So deletion is final in this case. The soft-delete approach in the database might be more suitable for debugging and accounting purposes.

@pgiertych
We need to add a Flyway migration that would add the boolean deleted column to the Domain table

@llopat
I will handle application instance removal from deleted domain

Still such constraint needs to be handled: External service domain is not unique (provided value: testd2.nmaas.qalab.geant.net)


As a bridge user, I should be able to see an estimate of the amount received

We'll need:

SDK method to get the router fees + the AMM slippage fees.
UI to display this.

Oracles could increase scope
File contract integration for fully onchain way to restimate relayer fee

Note: Going to meet with @sanchaymittal @just-a-node on this request and how to best break out these needs:

Slippage
Gas fee estimate
Relayer fee estimate
Estimate of amount received
Workflow to 'bump' gas where actual fees > estimated fees
UI best practices and plan to display this in-app

@alexwhte  break this up per convo

ex/ Hop


[docs] translate portuguese adjustment and contribution

Contribution translate
I adjustmented terms in portuguese and translate the initial page overview about the Material UI :hearts:

We don't accept PRs for translations. They are done through Crowdin (translate.mui.com) instead.
Besides, we're going to drop the translations in the docs in the near future


Make shared state name case insensitive

What's the motivation for this change?

we do this in v5, so need to make it backward compatible.


Add jamadar

Signed-off-by: Faizan Ahmad
username: faizanahmad055
email<EMAIL_ADDRESS>What this PR does / why we need it:

Jamadar is an opensource tool maintained by Stakater
Jamadar is a Kubernetes controller that can poll at configured time intervals and watch for dangling resources that are an 'X' time period old and don't have a specific annotation and will delete them and take corresponding actions.

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Hi @foxish, @unguiculus,
Can you guys, please take a look


📌 fixed a bug where RAG would not reply after not reading the file correctly

Pull Request Checklist
Description
fix #1869
📌 fixed a bug where RAG would not reply after not reading the file correctly

Changelog Entry
Fixed
optimize open-webui/backend/apps/rag/utils.py
resolved the error in
  File "/app/backend/apps/rag/utils.py", line 325, in rag_messages
    context_string += "\n\n".join(items)
                      ^^^^^^^^^^^^^^^^^^
TypeError: sequence item 0: expected str instance, NoneType found

Changed

fixed a bug where RAG would not reply after not reading the file correctly

Additional Information
At present, it can self-test and run normal operation and reply !!!

LGTM, Thanks!


Support for jest.config.js

[x] I'm sure this issue is not a duplicate.

[x] I'm submitting an icon request:

Type: filename
Icon Name: Jest Config
Sample original Icon: https://github.com/vscode-icons/vscode-icons/blob/master/icons/file_type_jest.svg
Filenames: jest.config.js

More info:

https://jestjs.io/docs/en/configuration

Already supported


Fix parsing of use_file

Because the use_file parser definition is recursive, we were applying
the operator swapping mappers more than once in the cases where the rule
recursed.
Instead, we should only apply the mapper to the final result of parsing
the use_file rule.
Fixes https://github.com/facebook/reason/issues/1965
Fixes https://github.com/facebook/reason/issues/1980
Fixes https://github.com/facebook/reason/issues/1970

Thank you as always!


Fix autodoc build warnings for Fabric API reference

📚 Documentation
In our DeepSpeed strategy, we have conditional imports like this:
if TYPE_CHECKING:
    import deepspeed

def some_method(x: `deepspeed.something"):
    ...

Sphinx autodoc does not like that. There are warnings when we generate the api docs:
WARNING: Cannot resolve forward reference in type annotations of "lightning_fabric.plugins.precision.DeepSpeedPrecision.backward": name 'deepspeed' is not defined
[960](https://github.com/Lightning-AI/lightning/actions/runs/3878948627/jobs/6615629448#step:8:961)
WARNING: Cannot resolve forward reference in type annotations of "lightning_fabric.strategies.DeepSpeedStrategy.setup_module": name 'deepspeed' is not defined
[961](https://github.com/Lightning-AI/lightning/actions/runs/3878948627/jobs/6615629448#step:8:962)
WARNING: Cannot resolve forward reference in type annotations of "lightning_fabric.strategies.DeepSpeedStrategy.setup_module_and_optimizers": name 'deepspeed' is not defined
[962](https://github.com/Lightning-AI/lightning/actions/runs/3878948627/jobs/6615629448#step:8:963)
WARNING: Cannot resolve forward reference in type annotations of "lightning_fabric.strategies.XLAStrategy.process_dataloader": name 'MpDeviceLoader' is not defined
[963](https://github.com/Lightning-AI/lightning/actions/runs/3878948627/jobs/6615629448#step:8:964)
/home/runner/work/lightning/lightning/docs/source-pytorch/fabric/api/api_reference.rst:78:<autosummary>:1: ERROR:

In #16291 we had to exclude these classes from the API reference to make the build pass. We need to figure out a way to either fix the reference errors or ignore them.
cc @borda @carmocca @justusschock @awaelchli

Disabling the -W flag in the sphinx-build command should make the build pass. The problem of this approach is that by doing so, potential other warnings could be missed by the CI, which is probably why this setting is turned on right now.
A solution for this could be setting the lowercase -w flag which writes all warnings to a file, and then in a separate GH workflow check if there are unexpected warnings in this file.
Ideally a setting like this could be used to filter warnings out using just Sphinx and without custom logic, but I could not get something like this to work. Also other settings in the Sphinx config file didn't help.
@awaelchli any thoughts on this?

Thanks for looking into it. I think that unless absolutely necessary, we would prefer to raise all warnings without ignoring them. This is because more often than not, they reveal real issues that should be fixed. Nonetheless, I'll check out your PR to see what could be done. Thanks for exploring these solutions.


No Beans MinioService found

When i am trying to run your example
@RestController
@RequestMapping("/files")
public class TestController {

    @Autowired
    private MinioService minioService;

    @GetMapping
    public List<Item> testMinio() throws MinioException {
        return minioService.list();
    }

    @GetMapping("/{object}")
    public void getObject(@PathVariable("object") String object, HttpServletResponse response) throws MinioException, IOException {
        InputStream inputStream = minioService.get(Path.of(object));
        InputStreamResource inputStreamResource = new InputStreamResource(inputStream);

        // Set the content type and attachment header.
        response.addHeader("Content-disposition", "attachment;filename=" + object);
        response.setContentType(URLConnection.guessContentTypeFromName(object));

        // Copy the stream to the response's output stream.
        IOUtils.copy(inputStream, response.getOutputStream());
        response.flushBuffer();
    }

    @PostMapping
    public void addAttachement(@RequestParam("file") MultipartFile file) {
        Path path = Path.of(file.getOriginalFilename());
        try {
            minioService.upload(path, file.getInputStream(), file.getContentType());
        } catch (MinioException e) {
            throw new IllegalStateException("The file cannot be upload on the internal storage. Please retry later", e);
        } catch (IOException e) {
            throw new IllegalStateException("The file cannot be read", e);
        }
    }
}

Spring does not start cause it cant find the Bean MinioService.
***************************
APPLICATION FAILED TO START
***************************

Description:

Field minioService in de.jbcbezerra.craftylab.test.TestController required a bean of type 'com.jlefebure.spring.boot.minio.MinioService' that could not be found.

The injection point has the following annotations:
	- @org.springframework.beans.factory.annotation.Autowired(required=true)

Action:

Consider defining a bean of type 'com.jlefebure.spring.boot.minio.MinioService' in your configuration.

Same thing :(

Hi all ,
@sployad @jbcbezerra
I don't know how you re using the service, but consider put an annotation like @Component. This way the application notices that this service exists.
Regards!

Same thing :(

ComponentScan actually did the job for me
@SpringBootApplication
@ComponentScan({"com.jlefebure.*"})
public class TestApplication {

  public static void main(String[] args) {
    SpringApplication.run(TestApplication.class, args);
  }
}


Allow JS Fallback for Import Sources to be VDOM.

I don't think we need to allow elements here since the fallback should only be there for a little while, but allowing VDOM seems appropriate in cases where you want a spinner instead of static text.

Done!

Done!


performance drop with GO111MODULE="on"

export GO111MODULE="on" and then run any of the code generators (so far defaulter-gen, deepcopy-gen, conversion-gen) for a pretty drastic increase in time to run vs export GO111MODULE="off" first.
I've been converting https://sigs.k8s.io/kind over to modules fully, and observed this performance issue, I've not yet had a chance to dig into why this occurs, but ensuring that module mode is set to off while calling the code generators seems to dramatically improve peformance.

This might be because go mod will download all the dependencies of the project, rather than looking at the vendor directory (if it hasn't pulled them down already?). May want to try with -mod=vendor enabled?
Just a thought.

I don't think that's it but I'm not 100% certain. The performance difference can be observed with a populated vendor and module cache just between running GO111MODULE="on" <code-generator> and GO111MODULE="off" <code-generator>. The code generator code performance seems to be tied to this.
So far a viable work around to embrace modules is:

build the code generators while module mode is enabled (so you can install the version your module tracks)
go mod vendor to populate vendor locally from your module cache
disable module mode export GO111MODULE="off"
fake a GOPATH with a tempdir and a symlink to the repo
run the generators
cleanup the fake gopath

This is a bit hacky, but allows everything to use modules and doesn't have the big performance penalty.
Implementation here:
https://github.com/kubernetes-sigs/kind/blob/10642f530782963ed23b3d4a14587950bbacaa63/hack/update-generated.sh

@BenTheElder Can you try with GO111MODULE="on" GOFLAGS="-mod=vendor" <code-generator> as well? We're about to hit this in cluster-api soon :)

@vincepri feel free to give it a shot in the kind repo, we're still using the workaround detailed above for now. I might not get to this for a bit myself :sweat_smile:
The fake gopath part is pretty trivial and either way we need the rest of the wrapper to populate vendor etc.

Oops, sorry I missed the other comment above yours which suggested the same. I wonder how this will perform with the latest build of code-generator, which should be using tools/packages to retrieve the modules.
I'll update when I can test in CAPI or kind.

latest build of code-generator, which should be using tools/packages to retrieve the modules.

@vincepri do you have a link to an issue/PR about this? Afaik gengo, the main generation tool behind code-generator, would need to move to using tools/packages first and I don't think that's going to happen soon-ish because that would result in breaking lots of existing interfaces.
cc @sttts

@nikhita I think I might have talked too soon :smile:. We should definitely get this on the roadmap, maybe with a feature flag and documentation to opt in?

/remove-lifecycle stale

/remove-lifecycle stale

/lifecycle frozen
this issue is not going away on it's own and it will probably bite us in the future, FYI @liggitt @dims (be aware of this when touching k/k build scripts...)

FWIW i'm no longer using the vendor / GOPATH workaround in kind, but I've also changed a lot of things:

less code
less dependencies
less use of generators
go1.15rc1
...

/kind bug
/priority important-soon
/sig api-machinery

Could this change landing in Go 1.18 help here? 🤔
https://github.com/golang/go/issues/44435

I don't think so. That issue seems to relate to populating dependencies in the module cache more quickly. Module mode slows the generators significantly independently of that step.

/close

any context around how/why this is closed ? Seems like there was no activity for three years and it was closed - is that it or it was "fixed" somehow ?

An answer in parts.

Yes, module mode is slower because Go's libs internally call exec("go", "list", "-json") and then parse the results.
It's not as much slower now as it was when this was filed.
Continuing to support non-modules mode in k/k was a burden, which we have decided not to carry.  We stopped running codegen on every make and we adopted go workspaces.

IOW, Go's packages and related libs could get faster, but we no longer consider it "a problem".

thank you for clarification!


check-exercises: Fix warning with ghc >= 7.10.

This fixes the warning "The import of Control.Applicative is redundant" when compiling check-exercises cause by Prelude re-exporting Control.Applicative.<$> in base >= 4.8.
Removing the offending line is undesirable because it would break compiling if ghc <= 7.10.
Closes #122

Seems good as I no longer see warning, so :+1:


android: no update and no install possible since today

As the title says.
Hangs on update and hangs on install.
Xiaomi Poco 3 Pro.

Try to reinstall the plugin.

Before your suggestion: Uninstalling does not work or takes too long time. I deleted the folder from the file system.
(Side effect while the plugin was installed: I could not make a new note.)

Obsidian was very slowly in doing something (add a note, delete a note, install a plugin). Now the problems are gone. You can delete this issue or mark is as solved.
Nonetheless: Thanks for your fast response!


Speed up benchmarkScore script

The slowness came from product description lookup. Created a Map of ID to description for quick lookups, now the whole script runs in a few seconds.

Nice!


fix: broken URL when you are using Range filter

Description
This PR fixes the odd links in the app, by checking if the router is ready to push range based on that.
What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

fix https://github.com/open-sauced/app/issues/2185
Mobile & Desktop Screenshots/Recordings
Before
https://github.com/open-sauced/app/assets/18273833/d39040d9-efa0-414e-821f-c59ff22b1542
After
Note: you could jump to 50th second to see the rendering.
https://github.com/open-sauced/app/assets/18273833/6fea6677-541d-4758-a3fd-9910d735ed18
Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[x] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

@nickytonline thanks for the review, I have added a video of the before and after in the PR description, is there anything I need to highlight in the video?

@a0m0rajab does this handle https://github.com/open-sauced/app/issues/2211 also?

@brandonroberts nope, that's happening due to the inconsistency in the naming. Just changing the range keyword to limit would solve the other issue I think. I mentioned it in the issue comment itself: https://github.com/open-sauced/app/issues/2185#issuecomment-1826008397 but did not open an issue for that yet.


finalize method and data type names

Solved #287

I'd reiterate objections wrt seqAll, sequence is a far more well-known name and I don't see a reason to differ.

@ratoshniuk Thank you for your work on this. The original ticket has changed quite considerably based on lots more feedback. Do you want to revise this PR or should I close it down and someone can pick it up?

@jdegoes I missed out to answer. Yes, after the discussions above I will sum up all words and revise this ticket


After editing the settings.json file it adds it to my git project as 'Changes'

VSCode Version: Code 1.12.2 (19222cdc84ce72202478ba1cec5cb557b71163de, 2017-05-10T13:16:25.899Z)
OS Version: Linux x64 4.4.0-78-generic
Extensions:

Extension
Author
Version

material-icon-theme
PKief
2.0.8

html-snippets
abusaidm
0.1.0

Maybe I misunderstood your problem but why is this a bug? Assuming you are talking about workspace settings - you just changed one of your project's files (just like any other per-project configuration file, e.g. .jshintrc, .npmrc, .editorconfig etc), so of course it shows as change in Git too.

Sorry, I thought VSCode automatically added the vscode's preferences file (settings.json) to my project.

It does but only if you change the workspace settings because they are saved in a file inside your project.
If you change the global settings, they will not be added to your project.

Yeah i was editing the global settings.


Spectral Mismatch Calculation Integration Range

As it is currently written, the calc_spectral_mismatch_field() function takes only the module spectral response (sr), the measured spectral solar irradiance (e_sun), and the reference spectrum (e_ref) as inputs. It then truncates the reference spectrum to the wavelength range of the measured spectrum to perform the SMM calculation, like so:
\frac{\int^{\lambda_2}_{\lambda_1} E_{sun}(\lambda) SR(\lambda)}{\int^{\lambda_2}_{\lambda_1} E_{ref}(\lambda) SR(\lambda)} \times
\frac{\int^{\lambda_2}_{\lambda_1} E_{ref}(\lambda) }{\int^{\lambda_2}_{\lambda_1} E_{sun}(\lambda)}

where $\lambda_1$ and $\lambda_2$ are the wavelength range of the spectral irradiance measurement
I see that there was a discussion here concerning the addition of two more optional inputs, the total irradiance of the measured spectrum (e_sun_tot) and the reference spectrum (e_ref_tot), which would change this calculation to:
\frac{\int^{\lambda_2}_{\lambda_1} E_{sun}(\lambda) SR(\lambda)}{\int^{\lambda_2}_{\lambda_1} E_{ref}(\lambda) SR(\lambda)} \times
\frac{ E_{ref,total} }{E_{sun,total}}

I'm curious, why wasn't this option included in the end?
As a follow-up question, in a case where we have co-located pyranometer GHI measurements with global spectral irradiance measurements, could the GHI measured by the pyranometer be used to replace $E_{sun,total}$? Is there a strong reason why not to do this if the sensors are time-synchronized and very near each other?
I'm interested because I've found that the long-wavelength absorption of clouds is actually significant for SMM values, and truncating the spectrum in the way that calc_spectral_mismatch_field() currently does would underestimate the SMM for silicon modules under cloudy conditions. I was hoping to use measured pyranometer data to capture this effect instead.
@adriesse, @RDaxini, do you have any comments?

Hey Mandy, an astute observation and a good question!

I'm curious, why wasn't this option included in the end?

I'm sure @adriesse will be able to provide a better answer as I was not part of the original implementation, but I had a scan through the discussion in #1524 and it seems to me that for the sake of simplicity it was implemented in this way with the appropriate caveat added to the docstring. I guess in (most?) situations people would be relying on spectral irradiance data alone, which typically not extend to 4000nm, in which case the truncation executed in this function would be required anyway.

could the GHI measured by the pyranometer be used to replace esun_total?

Wait for a second opinion, but I can't think of a reason why not.

I'm interested because I've found that the long-wavelength absorption of clouds is actually significant for SMM values, and truncating the spectrum in the way that calc_spectral_mismatch_field() currently does would underestimate the SMM for silicon modules under cloudy conditions. I was hoping to use measured pyranometer data to capture this effect instead.

Further developments are always welcome. If you think you could help improve the calc_spectral_mismatch_field() then I'd be happy to help you through the contribution process! Let's see what some others think about this.

@mandylewis The primary reference cell calibration case that I was considering in my PR review used a direct-FOV cavity radiometer for the broadband sun measurement. This thermopile is typically “more ideal” with a higher cutoff wavelength than a wide-FOV pyranometer, due to the missing glass dome in the cavity device. In any case, working from first principles is the surest guide to knowing which integration limits should be what in the formula. I’d be happy to help sketch that out in further detail.
In terms of your concurrent broadband pyranometer and spectral irradiance measurements I have secondhand knowledge that says to be aware of the time-constant difference that may exist between their response times (thermopiles can be on the order of seconds as compared to comparatively much faster solid state detectors, although some spectroradiometers scan instead of snapshotting). Spectral correction errors may be higher during highly variable conditions due to instrument lag.

I recommend using the equation twice to calculate two spectral mismatch value, one for the PV device and another for the pyrometer. This rewrites heading the spectral responses of both devices.

This is from: Preliminary Investigation of
Methods for Correcting for
Variations in Solar Spectrum
under Clear Skies

To clarify my comment w.r.t. @mikofski‘s refinement of @mandylewis’s initial mismatch formula, when I spoke of a thermopile being “ideal”, this refers to both (1) its spectral response being perfectly constant (usually taken as one without loss of generality in spectral corrections where any scalar multiple typically (!) factors out in both numerator and denominator and thus cancels) AND (2) the wavelength limits of the response going from 0 to infinity. So, to the extent that one’s pyranometer is not ideal (it’s not!), then using @mikofski’s approach is indeed indicated.
Also, I cannot help but remind about the key assumption of Isc linearity w.r.t. total irradiance for any fixed spectrum.

I'm curious, why wasn't this option included in the end?

It was just a question of staying focused on the use case at hand.

As a follow-up question, in a case where we have co-located pyranometer GHI measurements with global spectral irradiance measurements, could the GHI measured by the pyranometer be used to replace E s u n , t o t a l ? Is there a strong reason why not to do this if the sensors are time-synchronized and very near each other?

If you have the synchronized parallel measurements, I would encourage you to just try it and see what comes out!

I'm interested because I've found that the long-wavelength absorption of clouds is actually significant for SMM values, and truncating the spectrum in the way that calc_spectral_mismatch_field() currently does would underestimate the SMM for silicon modules under cloudy conditions. I was hoping to use measured pyranometer data to capture this effect instead.

Don't you have Spectrafy instruments?  There would be no truncation using those.
Your findings sound interesting.  Would you be able to propose a better assumption about the unmeasured portion of the spectrum?

Here is a spectral measurement extension technique based on how the NREL primary reference cell calibration lab extends their measured direct spectrum with a standard spectrum so that it integrates to the total irradiance measured by the direct cavity radiometer:
https://github.com/markcampanelli/pvfit/blob/main/pvfit/measurement/spectral_correction/computation.py#L201
It should also work reasonably for global measurements as done in the technique I presented at the recent PVPMC (note overcast days here also have a notably different spectral effect): https://github.com/markcampanelli/pvpmc2024/blob/main/poster/poster-final-mark-campanelli.pdf


update take transport type and tasks celery

merge messages about save trip, and update tasks celery to sync


CMake: move tricky code from CMake to Python

Removing an abstraction boundary also allowed me to fix a bug where we could not run long tests in optimized mode, which prevented us from being able to mark executable tests as long.
I tested this refactoring by running each check-swift-*-macosx-* target with --no-execute --show-unsupported arguments for lit, and inspected the output to make sure that we execute the right tests in each mode.

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci Please test

@swift-ci Please smoke test

I feel I'm a little puzzled about test feature flags.
I'm pretty sure that I'm still not understanding completely,
but why not just add UNSUPPORTED: executable_test to existing long_test test cases?

but why not just add UNSUPPORTED: executable_test to existing long_test test cases?

I think doing so would disable them in, for example, check-swift-only_long-* configuration, which should run long executable tests in -Onone and long non-executable tests.

but why not just add UNSUPPORTED: executable_test to existing long_test test cases?

I think doing so would disable them in, for example, check-swift-only_long-* configuration, which should run long executable tests in -Onone and long non-executable tests.

I see, thank you!

Thank you for the review!
@swift-ci Please smoke test and merge


Language support

Spanish Latin America

Hello @argenisB,
Sure, I'll look into adding support for Spanish.  Since you request Spanish Latin America, I assume the language is somewhat uniform in that region.  But, to avoid confusion, can you be more specific as to the language?  Spanish (Argentina)?  Spanish (Mexico)?


Adding qsim Accelerator backend

Implement xacc::Accelerator inteface for https://github.com/quantumlib/qsim

For tracking purposes, I'll work on it in the near future :)


Investigate controlling Alexa-connected smart home devices

Investigate if it's possible to control and monitor Alexa-connected smart home devices from the alexa-remote2 package. If so, this plug-in could be significantly more useful.

Even if it's possible to send commands via alexa-remote2 to control smart home devices, it doesn't look like the existing event stream allows monitoring them, which would be another requirement.
I'm not married to using alexa-remote2 as the underlying service integration for this plug-in. The Alexa app is able to monitor changes to smart home devices in real-time, so there is a mechanism, it just needs to be reverse-engineered.


set webView as content of ScrollView?

I need to have a webView, but when I try, it doesn't appear

@borjaruiz webView not support


Atomic swap the request drained handler when shutting down.

For https://github.com/aspnet/AspNetCore-Internal/issues/1964 and https://github.com/aspnet/AspNetCore-Internal/issues/1958

There was a failure with an ANCM test that this fix was originally dealing with. I realized now that if app_offline is dropped too early, the IIS site will never shut down because it creates a polling application.
I'm going to make it so the test only runs with IIS Express and rewrite a test that works with IIS.


⚠ Hartman Foundation has degraded performance

In 75594cd, Hartman Foundation (https://gordonhartman.com/) experienced degraded performance:

HTTP code: 200
Response time: 2604 ms

Resolved: Hartman Foundation performance has improved in 331a447.


Sending Messages takes 3x the time than prior to updating to v5.5.2

Hello together,
after we did the Update to the v5.5.2 of the Communicator, sending a message takes about 3x of what it used to be before the update.
Prior to v5.5.2

After the update to v5.5.2

There you can see that the SendMessage Function now takes around 4,3 seconds per message. It used to be around 1.5 before the update.
This a big issue for our customer as there company-wide messages now take up to 12 hours to be send.
I hope you can help us resolve the issue.
I'm happy to share what ever you need.
Thanks and best regards
Bennet

Please note: a large number of people are in focus for this instance of the company communicator, so the time it takes to send the messages does actually have significant impact

Hi @peddivyshnavi
Thanks for confirming. That also surprised me that there was no change there but we still see the change after the Deployment. Is there anything I can provide to further investigate the issue? As of my knowledge there is nothing else that changed during the update.

Hi @bbruenings
As mentioned earlier we didnt added any logic to send functionality .we will analyze further and will update you

Hi @peddivyshnavi
I double checked which version we were coming from on production.
The update not only included the newest version 5.5.2 but also 5.5.1 and 5.5. as we were coming from 5.4.1.
Sorry for the confusion 5.5 included changes to the send feature as it included the scheduled message feature correct?
Thanks and best regards
Bennet

Hi @bbruenings
we were checking on this we will update you as early as possible

HI @bbruenings
Schedule send is separate component in send functionality we didnt added or merged schedule send with send functionality

@bbruenings
Could you please update us on the status of the issue?

Sure we will check accordingly

we were closing ADO ticket for avoiding duplicate and we will continue discussing this issue over here.
thanks


Theme improvements

Bootstrap offers a built-in "dark mode" which is worth looking into:
https://getbootstrap.com/docs/5.3/customize/color-modes/#dark-mode
Might simplify (and improve) the user interface between light mode and dark mode.
Also is it worth considering removing "custom themes"?

Not sure how much css/styles would need to be rewritten but cool feature.

Also is it worth considering removing "custom themes"?

I am not sure about taking away functionality. Maybe we can push it into a really simple mix-in? When the plugin is enabled the provided file is loaded if not then not? Would remove all the selection logic.
I would be interested in @eeintech's take on this

I like the idea of shipping themes via plugins.

I like the idea of shipping themes via plugins.

Me too, this is a good idea

The current "Dark Reader" mode CSS comes from the same name browser extension: https://chrome.google.com/webstore/detail/dark-reader/eimadpbcbfnmbkopoojfekhnkhdbieeh
In the past, I had chosen it over others as it did a really good job at converting bright websites into dark mode.
Bootstrap built-in dark mode would have definitely been simpler option but not available at the time...
Theme management via plugin is fine, but having core light/dark modes would still make the InvenTree setup much faster and lean for those who don't want to bring in plugins.

I'm going to shelve this until the new bootstrap (5.3) is out - the current alpha dark mode support is pretty limited

Closing this, we'll get this for "free" with the React/mantine updates.


Delete wsub.txt

Private Page.
DOMAIN NAME: wsub.waw.pl
subscriber type: natural person

@aaapl Yes, and the website looks spammish. Thank you for the update! Pull request merged.


Cleanup docs examples

PR Checklist

[x] Have you followed the guidelines in CONTRIBUTING.md?
[x] Have you got 100% test coverage on new code?
[x] Have you updated the prose documentation?
[ ] Have you updated the reference documentation?

Opening this for review now, since I don't want it to get too big. I'm gonna follow up with a few more PRs, so this is going to be a sequential process.


bug(datepicker): Duplicate marker on calendar pop up when inputting date that is outwith min/max dates

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
I have set the min and max dates using their respective properties. When I type in a date that is after the max date, and then open the calendar, a marker appears on both the date I typed in and the max date. This behaviour could arguably be slightly confusing to the user but it is particularly misleading in the instance that the highlighted max date is actually disabled due to custom validation. The same issue can be seen for the minimum date.

Reproduction
StackBlitz link: https://stackblitz.com/run?file=package.json (an example from the docs)
Steps to reproduce:

In datepicker-min-max-example.ts, adjust the max date so that it is not the last day of the month (so that the issue can be seen) e.g. change it to the 15th
In the input, type in a date which is after the max date - e.g. the 18th
Open the calendar and you will see that two dates are highlighted - the date that was typed in and the maximum date.
Provide a custom validator that would render the maximum date disabled e.g. if the max date was a Sunday but weekends are not allowed. Repeat steps 2 & 3 and you will see that this date is highlighted even though it is invalid.
Same steps for minimum date.

Expected Behavior
I am expecting to see only one date highlighted on the calendar - just the (invalid one) that was typed in. If this is not desired, then it should still take into account other invalid/disabled dates through customer validator, so it should highlight the maximum valid date rather than the general maximum date regardless of its validity. Likewise for the minimum date.
Actual Behavior
I saw two dates highlighted on the calendar - the date I typed in and the maximum date. The maximum date is also highlighted even when it has been rendered invalid by a custom validator, which could be misleading to users - this is the main issue. Likewise for the minimum date.
Environment

Angular: 16.1.6
CDK/Material: 16.1.6
Browser(s): Google Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

I think that these are two different states of the calendar. The one on the 31st is the current selection while the one on the 29th is the date that has focus.

Why does the max date (aka the 29th in this case) have focus from typing in a date beyond the max date?

The calendar sets focus either on the selected date, or the closest non-disabled date next to it. In this case since the minimum is the 30th and the selected date is the 31st, focus is set on the 29th.

This makes sense, but it also highlights the maximum date even when it is disabled by a custom validator.

The custom validator only determines which dates are disabled, but since the user typed in the value, it's still considered selected.

I mean that it still focuses the maximum date even when it is been disabled by a custom validator.


security: move away from SSH keys stored in cleartext

Currently, the terraform deployment step results in the hpcadmin SSH key being stored in cleartext in the volume of the deployer, which allows for lateral movement in the network.
It would be preferable to use a local key management solution, such as password-protected (encrypted) SSH keys with an SSH agent and a timeout for ssh-add (e.g. 24h).

Edit: this should have been a feature request rather than a bug

can you please elaborate more on this ? moving to bicep would remove that I guess.

This was flagged by an automatic security scanner of a customer.
I think the basic premise is simply that storing SSH keys in cleartext (time-unlimited token) on a web server allows an attacker who gains access to the machine to move laterally through the network and should be avoided.
Thinking a bit more about this, I guess in the case of a compromise of the deployer VM, the main worry is actually the (permanent) system managed identity rather than the SSH key for the cluster.
Perhaps one could suggest users to shut down the deployer when it's not used to reduce the attack surface.


[Translation] - Getting Started

It shows 2 commits, I hope I have done it correctly.

also need to resolve merge conflicts!

@saranshkataria  how do I resolve merge conflicts properly?

@saranshkataria  how do I resolve merge conflicts properly?

@yashguptaz add a comment once you are done with all the changes

Done enough of translation, now you can review.
I will continue afterwards only 8 paragraphs remain, 12 are done I guess.

@yashguptaz we want to go section wise for translation and reviews.
It will be easy to keep track of review comments.
Let's hold on for some time for next sections translation, let's close on the review of what ever is translated till now.
Once everything is approved you can continue with translation of next paragraphs.
Does that makes sense?

I think it is better to do section wise.
Also I'm committing section wise.
I have translated 2 more section which you can review now if you want.

I have translated all the sections :)
Please review,
Tell me any additional procedures for closing this Pull Request (Adding my name in translators etc..) so that I can close this Pull Request.
👍

Tell me any additional procedures for closing this Pull Request (Adding my name in translators etc..) so that I can close this Pull Request.

We will review and get it merged once every thing is reviewed.

@arshadkazmi42 Please review asap.

@arshadkazmi42 Also, I'm done with translation. Waiting Review.

@arshadkazmi42 Also, I'm done with translation. Waiting Review.

Working on the review. Review takes time, there is alot of things and we do not want wrong things to get merged. :raised_hands:

@arshadkazmi42 Changes requested on the Learn React section corrected :)

@arshadkazmi42 [Correction] Everything till line 98 was corrected and committed.
Waiting for the next set. Only 6 sections left.

I have done it until line 90 again. Give me the next set :)

[Correction] - [28 Commit] - Whole documented corrected successfuly.
With One Suggestion

[Correction] - [28 Commit] - Whole documented corrected successfuly.
With One Suggestion

I have resolved everything, just your suggestion is pending, can you make changes for that and we will be done with the 1st phase of the review

@arshadkazmi42 I am done with it, kindly mark everything on the PR Description and begin with review phase.

@arshadkazmi42 Looks like I missed a # at staying informed.
It is not scrolling when clicked in deploy preview.
I am updating that.

@arshadkazmi42 Looks like I missed a # at staying informed.
It is not scrolling when clicked in deploy preview.
I am updating that.

Good catch.
I was about to build your changes locally to verify the build

@yashguptaz added some more review comments. Hope you can get them done too. I will proceed with the section {#react-for-beginners} after you have resolved these ones. Thanks for putting in the efforts!

@saranshkataria All the corrections have been completed till now.
You may wanna give the next set.
I am curious, will there be more phases after this?

Also, I am not resolving any conversation in case you want to recheck stuff I'm just giving your comments 👍 (Thumbs Up(s))

@yashguptaz this is the last review. And us marking it resolved helps since we can confirm that the changes are in there. Thanks 😄

Done till {#recommended-courses}. Almost there! 👍

@saranshkataria Done.

@yashguptaz you have missed a couple

Fine now?

@saranshkataria Changed the missed ones too.

Added more comments

@saranshkataria  Made more changes.
Please be quick! 👍 :D

@yashguptaz you missed some but I fixed those too. Great job translating everything! Thanks! :+1:

Great. got another page done :tada:


Add experimental withoutGaussianBlur API

Applying a Gaussian blur for large reductions of transparent images can cause dark ‘fringing’ around bright parts of the image.
This API helps us work around the issue, but I’d love to hear more about the cause of this issue and if there is a way to apply the Gaussian blur safely. We originally assumed this was caused by a missing alpha channel premultiplication before the affine transform but this turned out not to be the case.
See  https://github.com/gasi/sharp/pull/3 for details.
/cc @julianwa

Coverage increased (+0.04%) to 95.87% when pulling eba84afbb881e86fd41cf3809bff2abddbb62ed2 on gasi:alpha-reduction-gaussian-blur into acc6059801602fbbd49ddb34c1d16332c3885ebd on lovell:knife.

I wonder if using floating point arithmetic will help here.
vips_gaussmat and vips_convsep have a precision parameter you can set to VIPS_PRECISION_FLOAT instead of the default VIPS_PRECISION_INTEGER.
(I notice the existing code sets a non-existent integer parameter of vips_gaussmat - not sure where that came from - can probably be removed.)

Thanks for the tip, @lovell, but I just tried that and got even worse (compared visually). Luckily, I can work around the reduction fringes by disabling the Gaussian blur, but to my dismay, I realized that even upscaling transparent images with straight VIPS CLI causes dark fringes when using non-nearest interpolation. See: https://github.com/jcupitt/libvips/issues/291
It’s after 3am here, so I will catch some sleep and come back to this tomorrow with a fresh mind :smile: Happy to discuss best long-term solution to this. For now, we’ll use withoutGaussianBlur as a workaround for image reductions. We’ll still have to find a solution for upscaling though.

Coverage increased (+0.04%) to 95.87% when pulling 6f2715b872de96d6e0ff9dc1f6a47be0f0629e25 on gasi:alpha-reduction-gaussian-blur into acc6059801602fbbd49ddb34c1d16332c3885ebd on lovell:knife.

@gasi  There’s actually good reasons why they are applying the gaussian blur before downsampling; you can filter the high-frequency noise and therefore avoid moiré patterns. Does this mean that they were doing that blur before your were converting to pre-multiplied alpha? If we convert to pre-multiplied as early as possible (before the blur), it just might fix things, possibly in both upsampling and downsampling cases.
The issue is that you can’t interpolate two semi-transparent colors non-pre-multiplied colors. You’ll get the wrong result. For example: lerp(color(255, 0, 0, 255), color(0, 0, 0, 0), 0.5) = color(128, 0, 0, 128), which is a 50% transparent gray pixel, not a 50% transparent white pixel. On the other hand, lerp(color(255 * 1, 0 * 1, 0 * 1, 255),  color(0 * 0, 0 * 0, 0 * 0, 0), 0.5) = pre-mulitiplied-color(128, 0, 0, 128) = color(128 / 0.5, 0 / 0.5, 0 / 0.5, 128) = color(255, 0, 0, 128), which is what you’d expect.
So anything that does interpolation of colors, including gaussian blur or resampling, needs to be done in pre-multiplied space. Being a scientific image processing library, not a general purpose one, vips may not be taking this into account because it has to do with color perception and the treatment of alpha, rather than the raw math.

@gasi Thanks for testing the use of floats to remove rounding/truncate errors as a possible source.
@julianwa Yes, the blur is to reduce aliasing on diagonal edges, a similar method to *magick's Lanczos filter.
In case you missed it, the related improvement to libvips is being discussed over at https://github.com/jcupitt/libvips/issues/291

Thanks for your feedback, @lovell, and apologies for this misguided attempt at solving the problem (although it did visually make an improvement). This is superceded by https://github.com/lovell/sharp/pull/211 and I will hence close this.


Update Bank OVERVIEW & Purchase Confirmation Service Modal

Bank OVERVIEW Update:

[ ] Rename 'Confirmation Services' UI block to 'Active Confirmation Services'.
[ ] Move Bank NID & Account# block under Tx Fee
[ ] Move Active Confirmation Service block to the right of Tx Fee
[ ] Move Crawl Status to right of Active Confirmation Services
[ ] For Active Confirmation Services, when CVs are purchased, display the purchased active CVs on the block along with the Network ID, and Time Remaining. Time remaining will display the single biggest time left. For example, if 8 days are left, just display 8 days. If 11 hours of lets, just display 11 hours. No need to display minutes & seconds when displaying the days or hours left.
[ ] Max height of Active Confirmation Service UI block is 508px and if there are many CVs purchased, the scroll bar will start from the first CV purchased itself.
[ ] For Active Confirmation Services, we will display the first 4 digits and last 4 digits of the network ID. This will be a link to the CV.

Purchase Confirmation Service Modal Update:

[ ] Include Time Remaining
[ ] If user is purchasing a CV for the first time, Time Remaining will be blank until they fill out an amount.
[ ] If user is purchasing the same CV again, in Time Remaining, we will display the existing time remaining and if user adds amount, the calculated time will add onto the existing time remaining they have.

Willing to work on this when it is ready

@tomijaga sure, but I don't think this will be ready for awhile. I think there are BE updates needed


including aws headers in #pragma push()/pop() blocks throws C4251 on MSVC

We've wrapped some headers in pragma push()/pop() to temporarily disable warnings due to invalid characters in some of the aws headers.  We found this by compiling on a machine using simplified Chinese as the default code page.  We used the push()/pop() method to limit the scope of when these warnings were disabled to prevent masking issues in our own code.  We have found that this can cause C4251 to be thrown on MSVC if we try to include aws headers in 2 different locations.  An example below:
.h file:
pragma warning(push)
pragma warning(disable:4819)  // Invalid character not in default code page
include <aws/core/Aws.h>
...
pragma warning(pop)
.cpp file:
include <aws/core/utils/threading/Executor.h>
Diving deeper on this, we found that Core_EXPORTS.h uses #pragma warning(disable:4251) in a file that also has #pragma once.  This prevents the warning from being disabled when a second file that subsequently includes Core_EXPORTS.h a second time.

When did you last sync the SDK?  The invalid characters issue was fixed (as far as we know) a month or so ago.

That being said, we can move the disable to a /w4251 definition inside cmakelists.txt

@bretambrose @JonathanHenson @zippererer
I think this is more of a logical problem when using this SDK. It's not a bug. Your use case is to preserve settings first by pragma push, then import settings from SDK, then restore your original settings by pragma pop, so settings from SDK are ineffective. Now you include the AWS's header the second time, but pragma warning(disable 4251) is not taking into effect because of #pragma once. The solution I think is either we extract this warning from pragma once or you can add it in your own code

Please reopen if you have any other questions


Fix image flavor variable naming

This PR fixes the image flavor variable name mismatch

I don't see any fix here. 'image_flavor' -> 'flavor', why is the change needed?

I don't see any fix here. 'image_flavor' -> 'flavor', why is the change needed?

That is because you are not looking into the whole file probably, the default value is here,
https://github.com/Nordix/airship-dev-tools/blob/master/ci/images/image_builder_template.json#L14

I don't see any fix here. 'image_flavor' -> 'flavor', why is the change needed?

That is because you are not looking into the whole file probably, the default value is here,
https://github.com/Nordix/airship-dev-tools/blob/master/ci/images/image_builder_template.json#L14

That clarifies it, thanks.


Fix tesla daemon to replace data instead of update

Update to tesla-history docker container to address issue noted by @youzer-name in #286
@jasonacox - Please push to Docker Hub when you have a chance, thanks!
Changes as follows:

Script will now remove previously written data before writing new data, instead of updating the data points in InfluxDB. This should address the issue where previously returned timestamps are not returned in subsequent calls for history data, which would result in zero values being seen in production graphs
Updated the docker container to use Python 3.11 which is now released in alpine 3.18 (stable) - noting "Python 3.11 is between 10-60% faster than Python 3.10"

Merged and uploaded jasonacox/tesla-history:0.1.2
Thanks @mcbirse ! 🙏


Meteor start slows down as collectionfs grows

I'm using collectionFS with cfs-filesystem where I have 120k images stored and the server is taking almost 10 minutes to start.
If I reduce my collection to 60k images it takes only 3 minutes to start.
I don't get why the size of this collection is making the start slower.
Tks

This is because of fileWorker adds observer added which is well known for calling itself for each object on startup.
So more images we have, more time it will need to startup.

+1
we are experiencing the same issue. We only have around 4K documents on S3 and it takes more that 15mins to start up :(

I've moved on to meteor uploads. This package has too many bugs and doesn't look to be actively maintained.

@tdhz77 You mean this https://github.com/tomitrescak/meteor-uploads ?

I would recommend https://github.com/VeliovGroup/Meteor-Files
Really solid.
But to be frank, I would recommend not to deal with files and images inside meteor. Use cloud server like cloudinary.com, or build your own, for example https://github.com/pierrre/imageserver written on Go lang.

@aldeed I love autoforms and have good success in terms of features and functionality (not knowing speed issues)
@iSuslov - I understand the CDN way here but for ~10K records with average size of 54KB of image I am not sure if 8CPU (with 8 Cores per CPU) is sufficient enough.
Unfortunately, meteorhacks cluster package doesn't go well and ends up producing id not found error and eventually crashing the server.
I am not sure if there is a solution in place for this.
~10K images in the cfs.files.filrecord and it just makes the server sluggish and moreover the server startup is dramatically slow.
We are heavily coupled with adleed forms and our admin panel of the application uses the fileupload package (over autoform).
Optimistically, a solution would be highly appreciated inline to the caveat that we already are with Autoform and still want the speed in place.
Cheers,
--
Tamjeed

I switched to meteor-slingshot and wrote my own custom image service which is easy to develop and lot faster to handle large file uploads and image processing.
https://github.com/CulturalMe/meteor-slingshot

@digz6666  great to know that. I am just going by the caveat of having it worked with autoform.
It would be greater to know if you can have the code provided on GitHub.
For everyones' information; I could dodge the performance issue to a greater extent by commenting out the Delete observer being added to all of the file collections (And we will be running a delete daemon job for this purpose).
Now we are stuck with the sticky error arising with Meteor cluster + Autoform File, wherein the the observers get notified of the file upload and resulting in crashing the server as the id is received by only one of the nodes in the cluster and the lag or delay could be the root cause that the other nodes not getting the error.
Moreover the error crashing the server is definitely a strange scenario and would want to get it routed through the proper Meteor error handling mechanism (need to come up with workaround here).
Any experiences and successes are greatly appreciated, as it is a burning issue, we are dwelling with.
Cheers,
--
Tamjeed

@mdtamjeed I can share the image service code on Github which is developed with Spring Framework. I'm currently running this on tomcat on different port with the same server, also it can run on different server.

// Initiate observe for finding files that have been stored so we can delete
// any temp files
var initFSstart = fsCollection.files.find(getDoneQuery(fsCollection.options.stores)).observe({
added: function(fsFile) {
if(!initFSstart) return ;
FS.debug && console.log("FileWorker ADDED - calling deleteChunks for", fsFile._id);
FS.TempStore.removeFile(fsFile);
}
});

@aboire Please explain to others that this little hack should be applied inside  fileWorker and to make it work without push request, users should copy fileWorker with this fix into their project

@iSuslov you must copy the cfs:worker package locally in the local package directory and edit the file fileworker.js
var initFSstart = fsCollection.files.find(getDoneQuery(fsCollection.options.stores)).observe({ added: function(fsFile) { if(!initFSstart) return ; FS.debug && console.log("FileWorker ADDED - calling deleteChunks for", fsFile._id); FS.TempStore.removeFile(fsFile); } });

@aboire better to just copy one file and init it on Meteor.startup so it will override the behavior of this file.

@iSuslov yes it is better since there is only one file in the pakage


Chi2 plot fixes

Chi2 plot:

Fixed labels (log / non-log and subscript formatting).
Fixed colorbar overlap with x-axis if only two parameters are varied.
Added colorbar label $(\chi^2-\chi^2_\mathrm{min})/\sqrt{2n_\mathrm{obs}}$
Note: $2n_\mathrm{obs}$ is calculated via config.get_2n_obs() which returns the sum of $(2n_\mathrm{obs})$ for all kinematic sets, depending on their type:
for GaussHermite, n_obs = number_GH * number_spatial_bins;
for BayesLOSVD, n_obs = n_LOSVD_bins * number_spatial_bins.

Closes #312
Tested so far with

Tutorial notebook 3
test_nnls.py with varying fixed: False parameters in its config file user_test_config_ml.yaml

I did the tests that Thomas wrote in #380. I honestly do not know if you want to have the plot like this
 because I would do several things differently (but plotting is very subjective). For example, if you show data in log(quantity) i would make the scale linear and not log? Also I would always show $10^12$ instead of 1e12. I would also make the limits the same for the same quantities, when they are shown in y-axis and x-axis, so it is easier to compare. Lastly, there are no tick labels for the black-hole mass (x-axis).

Hi @boeckera, many thanks for testing and your comments! Of course it is wrong to show log quantities on a log scale - excellent point (and embarrassing missing it, it's been like that forever...). In the last commit this should be fixed and the axis limits should be consistent. As the plotted quantities should be smaller than about 200 in most instances, I did not touch the $10^\mathrm{X}$ vs. 1eX issue, though...
If you have time, a re-test is highly appreciated, as are any comments :-)
Cheers, Thomas

Hello @maindlt,
I guess it is fine for now?

Except that we show logarithmic things in log10 not log ;) I changed it haha
I do not see how any of these values should ever accede 200, unless you for whatever reason decide to sample things like black hole mass or dark matter fraction in linear space (would you ever want to do that though? I guess that is a different question).
I guess the question is also, at least for me, if you want this plot as a quick dirty check of what is going on, or if you want to polish it until it becomes "publishable". I guess that applies to all other plots, too.

Hello @boeckera,
outch, thanks for the log10-fixes!
Well, these graphs are mainly to get a quick overview of the results rather than to produce publishable plots. The ticks are a good example for this: sometimes they are close or even overlapping with neighboring axes and need some tweaking; people may prefer to plot log quantities as such and not on a linear scale, etc. Nevertheless our plots need to be mathematically correct.
A universal solution will need much development time and it is questionable whether we want and have the capacity to go into providing publication-grade plots for every need ;-) In the past the strategy was to provide a minimal set and let users extend/add as they wish. Shall we pick that up in one of our upcoming development meetings...?

Hi @maindlt,
maybe if I do not have anything else to do jajaja.
Sounds great!
Cheers,
Alina


documents: add open_access field

documents can be restricted by open_access field (implicit permissions)
_access (explicit permissions), if and when defined`, takes always precedence
refactor records item/list permissions to filter out closed access
documents for non-admins/librarians
changed records restrictions to use _access only when configured. In
this way, the field is not evaluated on each search query when
disabled.
partially addresses #687

Quick explanation: for e-items, when open_access: False then only logged in users can get the  file.
Here for documents, when open_access: False, it means that only librarians/admins can see the record.
IMHO, even if the meaning is different, it is not an issue: this implicit permissions means that, given the value of the filed, some restriction is applied, depending on some conditions.
If you believe we should change the field, I can do that.

@kprzerwa I have added the form field and the facet.
To be added in your PR (after you rebase):

search result, display open/closed on each as for e-items
document detail: clearly show if open/close access


Hatching is not mapped to pattern

Hello,
I have a matplotlib code that plots a bar plot with bars that are colored and given some pattern, like this one:
import pandas as pd
from matplotlib2tikz import get_tikz_code

speed = [0.1, 17.5, 40, 48, 52, 69, 88]
lifespan = [2, 8, 70, 1.5, 25, 12, 28]
index = ['snail', 'pig', 'elephant', 'rabbit', 'giraffe', 'coyote', 'horse']
df = pd.DataFrame({'speed': speed,\
                    'lifespan': lifespan}, index=index)
ax = df.plot.bar(rot=0)

bars = ax.patches
patterns =('o', '', '//', '\\\\', 'O', '-', '+', 'x','/','\\')
hatches = [p for p in patterns for i in range(len(df))]
for bar, hatch in zip(bars, hatches):
    bar.set_hatch(hatch)

ax.legend()

print(get_tikz_code("example.tex"))

Unfortunately, in the tikz output the pattern is lost. I wonder whether it is possible to do what I'd like at all with tikz, but I see online examples that seem to do exactly that.
Is it a feature not implemented yet, or a bug?

Fixed by #357.


⚠ Bofrost.be has degraded performance

In 863e287, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1323 ms

Resolved: Bofrost.be performance has improved in 91c9f49.


Dealing with Byproducts

The traditional solver can't have the user add byproduct recipes, to consume byproducts explicitly. This shouldn't really be too complicated to handle, it would need to pull from the pool of byproducts instead of products to set its demand, but yeah we'll see.
This will require the UI to be updated for this. Most byproduct shenanigans are already in place for the matrix solver, so it should be a simplification of that, ideally. This is quite close to the calculating by ingredients idea, so we'll see how those interoperate.
Make sure to check out how line satisfaction will deal with all of that.

Hello there.
This is an option I was looking for in FactoryPlanner...
For context: I am using FP now in my Nullius Momenti playthrough.
So - if I may make a suggestion from my "user" perspective how I'd like to deal with byproducts - I'd do it like this:

I have the red buttons with byproduct on top
I click the desired byproduct button
Recipe select dialog shows up showing recipes that take this byproduct as an input
I select recipe and it shows up on the list, which recalculates byproducts and so on accordingly (sum).
What also would be helpful in this regard:
ability to add product eaters such as turbines that eat steam, outfalls that eat wastewater etc - they all have their throughput capabilities and if FP was able to calculate the amount of buildings needed to void stuff - that would be great :)
ability to add any recipe and having ingredients/products/byproducts recalculated, adding results from that recipe to global count - maybe it is somehow possible already?
I wonder how do I add two recipes for the same product when I want to make some percentage of this product using one recipe, and the rest using the other one. Right now I can only add one recipe per product and I can only add the product once. So maybe add the ability to add same product more than once? And then first would be done with recipe A, and the second using recipe B?
Right now I deal with these issues by starting factory plan with a recipe for the last byproduct and build from there. But this is bit annoying, as I have to keep the whole chain up in my head first.
Hope these suggestions be helpful.
:)


Ed Lavender on CPUE

CPUE/weight records. Can you clarify how you have defined CPUE/weights where unrecorded in the initial data? My understanding from your manuscript (L204–211) is that if weight was not recorded then it has been estimated (from a length-weight relationship). I am not sure if there are any surveys that do not provide counts of the number of individuals? But, if so, my understanding is that you have not calculated CPUE and it is thus defined as NA. Is that correct? While the onus is on researchers using these data to make sure they are using them properly, it might help to have a summary table that defines which surveys record individual counts and/or weights, and/or an additional field in the processed dataset that defines which ‘observations’ are real or calculated (as the uncertainty may differ). There are other data fields where this kind of additional information could be valuable too (e.g., I think swept areas in your compiled dataset variously represent the areas swept by the trawl doors or wings, depending on the survey, and are variously observed quantities, fixed/assumed values or estimated values?). Reporting these differences in the compiled dataset would greatly help researchers propagate uncertainty.

For DATRAS surveys, we always recalculated weights based on abundance at length data, and compared it to the reported taxa-haul abundance/weight when available. However, DATRAS holds reported weights that are not in the right unit, and this is not clearly indicated in the data, making it difficult to know what's "right". So cpue recalculated from the abundance at length are all estimations, not measurements, for ICES surveys. We're working on the QAQC this month on this specific aspect. I'll try to make that more clear in the MS. For DATRAS, swept areas are never measured, but always recalculated (some directly, some via model predictions). I like the idea of making that explicit in the dataset, I'll think how

This is now summarized in Supplementary Table 1, but not indicated in the actual dataset because time is lacking to implement this for every haul


Fix entry point specification

Noticed because in the docs build, we had  a lot of errors in the log:
ModuleNotFoundError: No module named 'ctapipe.reco.sklearn.ParticleClassifier'; 'ctapipe.reco.sklearn' is not a package
Error loading ctapipe_reco plugin: 'ctapipe.reco.sklearn.DispReconstructor'
The last . should be a :

I am going to merge as it is not a code change and blocks all other PRs.


Execution Context Refactoring

[ ] How do we complete the data result?
[ ] Should we introduce something like a ILeafValue?
[ ] Integrate new coerce variables middleware

[ ]  Extension Methods
[ ]  Default Pipeline
[ ] Tests

[ ] Rename Custom -> ContextData
[ ] Check that the error handler gets all errors
[ ] CustomContext -> ContextData

How do we complete the data result?

For now we will leave that how it is. I opened an issue and will describe there what we are going to do with query results and how those come to be. #439


Remove double the

Hey all, noticed this morning while reading the docs. Cheers!

Somehow missed this fix — thanks for catching it!


support Extensions on the end of a Strand

This would give a nice way to specify toeholds and extensions common in DNA strand displacement and structural designs.
See also https://github.com/UC-Davis-molecular-computing/scadnano-python-package/issues/2.
Display
One thing that is not straightforward is how to display such extensions. One idea is to make it a straight line at an angle, with length proportional to the number of DNA bases. Some complications:

What angle?

Should the angle be customizable?

If so, independently for each extension, or just one option in the View menu to apply to all of them?

If it is customizable individually for each extension, then the natural place to store it is in the Design json, rather than as an AppUIState field. But this is a bit ugly; there's very little other UI specifications in the Design object.

Should the length be equivalent to a Domain of the same length? Or should it be shorter, with the DNA bases rendered closer together, to reduce the potential for visual clutter?

Workarounds
If you want to put a single-stranded extension/overhang on a strand before this feature is implemented, there are two solutions. The first is recommended:

5' or 3' modification: Add a 5' or 3' modification to the strand, and specify its idt_text to be the sequence you want. Normally the idt_text is a code for a DNA modification, e.g., /5Biosg/ for 5' biotin. However, it is simply placed inline with the DNA sequence when creating an IDT formatted file. So you can simply give a DNA sequence. For example, here is a screenshot showing how to add a tail of 6 T's to the 3' end of a strand:

add crossover to a "fake" helix: This is less elegant, but you can also create a "fake" helix where the single-stranded part is represented as a Domain instead of a Loopout:

I removed the "High Priority" label, since the workaround with 5'/3' modifications is fairly simple and actually not that hacky.

Note: after some consideration, it makes sense to have this be a third type of Substrand called Extension. Also, the position of the end of it (the one not connected to the adjacent Domain) should be customizable by the user, by dragging in the web interface, or using units of nanometers for the Python interface.

This is a reminder to implement the following behavior. Each extension stores a relative_offset field, which is a pair (z,y) of coordinates in units of nanometers, indicating where the free end of the extension should be placed relative to the end it shares with the next domain; as usual, z is horizontal in the main view, increasing to the right, and y is vertical, increasing down.
The default offset should be

up and to the left for 5' end adjacent to a forward domain
down and to the left for 5' end adjacent to a reverse domain
up and to the right for 3' end adjacent to a forward domain
down and to the right for 3' end adjacent to a reverse domain

The default could be 1 nm in each z,y direction (and as usual, if equal to the default then this is not written to the JSON); but we'll adjust this based on how it looks.
A feature that would be nice (and toggle-able view the Edit menu whether this happens or not) is that when any of the following happen and affect where an extension is drawn:

a strand is copied
a strand is moved
a domain is moved
a strand is reflected (horizontally or vertically via the strand context menu)

relative_offset should be re-calculated if something changed, e.g., changing the adjacent domain from forward to reverse should negate the y-value of relative_offset.

Release notes
Single-stranded extensions
Single-stranded extensions on the end of a strand can now be specified. See related notes in the Python package.
Like a Loopout, it is single-stranded, so does not occupy a Helix. However, Loopouts always reside between two Domains (which are on a Helix and in generate intended to be double-stranded), whereas an Extension is always at the 5' or 3' end of a strand.
TODO: finish this

closed by #800


Adding change schema model when voyager is used as a library

Hi,
I am trying to build something simimlar to the demo where it is possible, through a modal/button, to change the schema on the fly.
The demo today is tightly coupled with voyager library sources. Do you think it is possible just to call voyager library and extend some react component to enable the button on top? Anybody has done it and can share an example?

I've found the way, easy to be fair:
<Voyager.PanelHeader>
</Voyager.PanelHeader>


Flexible pyarrow

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.51%. Comparing base (67fefb1) to head (16adafd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   94.51%   94.51%
=======================================
  Files          10       10
  Lines         602      602
=======================================
  Hits          569      569
  Misses         33       33

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Uncaught ReferenceError: moment is not defined

您好，请问我使用该组件一直报这个错，我已经引入了moment包还是不行

已经解决了

How did you solve it?

import moment with script tab in HTML.

Sadly that's not an option to go with here :(

import moment with script tag.
npm install moment.

gantt needs it.

I know that gantt needs moment and we have it already included in our project. But importing it via a script tag is not an option. Not moment in general, which I haven't been clearly about in my answer. Sorry for the confusion.

You can submit your case on https://github.com/frappe/gantt/issues/31.
Or

import moment.js in your html file with script tag.
add moment.js in webpack as global.


vite_rails: Improve default deployment and dev enviroment support

Rails 7.2+ ships with features like the ability to generate a devcontainer for development, Github Action to run tests and Rails 8 will ship with Kamal configured by default for deployment.
It would be helpful if vite_rails integrated into these systems automatically or (as a fallback) documented what steps users need to take in order to work with these new defaults.
At a first pass, I ran into trouble with:

Github Action tests where vite wasn't installed (solved by manually adding run: npm install)
Kamal, where npx wasn't installed
Devcontainers - untested.

There are some pointers in the existing docs, like a dependency on npx and some notes about devcontainers port forwarding, but I think it would be helpful to have very clear steps for Rails users as part of the vite_rails setup docs.
For example, I'm not sure if I should actually be running npm install in my Github Action or if there's a bug somewhere in vite:install_dependencies or other hooks which should automatically install the deps.

Hi Brian!
The guide recommends running assets:precompile in the CI, which should install dependencies, although it's more robust to do it explicitly.
I'm not familiar with Kamal or Devcontainers, happy to include setup guides in the docs. Instructions should be concise, following the existing style of the docs. Alternatively, we can link to other resources that go into more detail of how to setup either.

I have not used them personally, but I believe Kamal and Dev Containers are both based on Docker. When you run rails new and specify a Node-based build system, like  --javascript esbuild, Rails will automatically inject the necessary Node steps into the generated Dockerfile, like this:
# Install JavaScript dependencies
ARG NODE_VERSION=20.17.0
ARG YARN_VERSION=1.22.22
ENV PATH=/usr/local/node/bin:$PATH
RUN curl -sL https://github.com/nodenv/node-build/archive/master.tar.gz | tar xz -C /tmp/ && \
    /tmp/node-build-master/bin/node-build "${NODE_VERSION}" /usr/local/node && \
    npm install -g yarn@$YARN_VERSION && \
    rm -rf /tmp/node-build-master

# Install node modules
COPY package.json yarn.lock ./
RUN yarn install --frozen-lockfile

Likewise, it adds a Node "feature" to .devcontainer/devcontainer.json:
"features": {
  "ghcr.io/devcontainers/features/node:1": {}
}

The problem is that Vite is not a supported option for rails new. For starting new Vite Rails apps, I recommend using rails new --javascript esbuild as a workaround to ensure the necessary Node pieces are in place, then proceed with the Vite installer.
The Vite Ruby docs could be updated to explain this, and/or mention specifically how to update the Docker files and GitHub actions workflow after the fact.

Second the documentation website needs a thorough review. Many sections simply state, “You can use this (link to GitHub page),” without explaining what to expect or how to configure the options correctly. This is especially problematic when certain options are incompatible with each other.
Additionally, I can no longer get vite_rails to work on a freshly created Rails 8 app. The significant changes since Rails 7.0, combined with conflicting or outdated documentation, make it difficult to resolve these issues.
If you try creating a new Rails 7.2 or 8 app with: rails new --javascript esbuild, and then install the vite_rails gem along with vite_plugin_rails, you will encounter issues such as misconfigured Procfile, wrong javascript path, and many other strange problems. I hope we can at least have a working app after following the installation steps.

@planetaska I just skip javascript and then run the standard vite ruby install steps


⚠ Bofrost.lu has degraded performance

In 4a98018, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2042 ms

Resolved: Bofrost.lu performance has improved in e66aeee after 6 minutes.


call unbindView of items when recyclerview destoryed

is posible that call unbindView of binded items when recyclerview destoryed ?
i need it for glide and image loading, when activity/recyclerview destoryed

The FastAdapter is using the default behavior.
"Called when a view created by this adapter has been recycled.
A view is recycled when a RecyclerView.LayoutManager decides that it no longer needs to be attached to its parent RecyclerView. This can be because it has fallen out of visibility or a set of cached views represented by views still attached to the parent RecyclerView. If an item view has large or expensive data bound to it such as large bitmaps, this may be a good place to release those resources.
RecyclerView calls this method right before clearing ViewHolder's internal data and sending it to RecycledViewPool. This way, if ViewHolder was holding valid information before being recycled, you can call getAdapterPosition() to get its adapter position."
https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#onViewRecycled(VH)


In observation summary, change the first letters of pathogens to lower case

I turns out  we do not want this.  We need to reverse this change.

Looks good.


Pattern name^: value binds name, while name: value never does

Fixes #1660 by no longer binding name in object pattern properties with literal values: name: "string", name: 42, or name: /regex/. The general rule is now this: if a property has a value, then it doesn't get bound. This seems like a natural extension of how destructuring assignment works.
New feature name^: value binds name. This also works when checking other properties. For example, the pattern {parent^: {type: "BlockStatement", expressions}} binds parent and expression in two destructurings: {parent} = x, {expressions} = parent.
BREAKING CHANGE: Pattern matching with {name: literal} no longer binds name; use {name^: literal} to bind.

Oh, that's a fun idea, like {x^: [y]} := z. (It already works within if.)
I wonder if there's a natural way to do it at the top level too, not just for object properties. Like I want function Comp(props) to bind props but also destructure... Something like function Comp(props^: {name}). This is related to the desire to have as in a pattern, like [a, b] as arr. I'm not sure we want to call it as because it's not a type operation. So maybe something involving ^.


Add trailing slash option to aiohttp routes

For Contrast Python Developers Only:

[ ] I've created a PR to update the vulnpy commit

[x] We do not want to update to this PR's top commit.

Had this left over from recent work, figured it was worth merging

couldn't figure out why the pipeline wouldn't run - it was requesting ubuntu 18.04


Mixin.resetValue should reset to props.value

I think its weird how resetModel clears out the fields.  I think it should reset to the Pristine values.

@sdemjanenko You make an excellent point. I will try to make this part of next release!

This is part of next release now


EAN Guard Bars

Hello,
Thank you for your additions of EAN5 and 2 addons for the EAN13 family.
Do you also have plans to support EAN guard bars. These are standard on a lot of EAN barcodes and also other families.
Thanks

Hi,
No problem with the EAN5 and 2, it used a lot of the standard EAN data so
it was not very hard to implement.
In regards to the guard bars, they are already there. But what you probably
mean is to make them taller as is the standard. Also to split the number in
three parts (first digit, group of 6 and group of 6).
I've had this in mind for a while but not had an plan for how to implement
it without losing the generality of the library as a whole. But I do now
have a solution in mind for it that would solve both the problem of making
the guard bars taller and the problem of adding two barcodes together.
//Johan
On Fri, Apr 1, 2016 at 10:59 AM, Joshua Baldwin<EMAIL_ADDRESS>wrote:

Hello,
Thank you for your additions of EAN5 and 2 addons for the EAN13 family.
Do you also have plans to support EAN guard bars. These are standard on a
lot of EAN barcodes and also other families.
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/lindell/JsBarcode/issues/60

EAN guardbars is now implemented in the new (beta) release. That together with issue-59 can be seen in this codepen example.


raise an exception if allclean_path is not a file

https://github.com/bessagroup/f3dasm_simulate/blob/1ae25bcff81cef6de3c4c71fdcbd744a497130ba/src/f3dasm_simulate/openFoam/openfoam_simulator.py#L154-L156

This piece of code is no longer required as the functionality is implemented in PrepareCase form PyFoam.


[SPARK-11205] [PYSPARK] Delegate to scala DataFrame API rather than p…

…rint in python
No test needed. Verify it manually in pyspark shell

Merged build triggered.

Merged build started.

Test build #43972 has started for PR 9177 at commit e4417c8.

Test build #43972 has finished for PR 9177 at commit e4417c8.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43972/
Test FAILed.

While I agree that it would be nice to have both outputs match, I'm not sure that this is the right way to do it. After your change, the output is being printed by a separate process, breaking the tests and possibly breaking this feature for certain environments where the Py4J Gateway JVM's stdout / stderr isn't captured or display.
If you still want to fix this, can you come up with an approach which prints the header in Python or otherwise harmonizes the output without changing which process performs the printing?

I think this would break a lot of things, including output redirection in Python.

@zjffdu mind closing this pull request?

@rxin  I will make a new commit soon to match the output in python and scala. Should be a trivial change.

Merged build triggered.

Merged build started.

Test build #44044 has started for PR 9177 at commit 39f3fc0.

Test build #44044 has finished for PR 9177 at commit 39f3fc0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44044/
Test PASSed.

Merged build finished. Test PASSed.

Can you show the before and after changes?

@rxin, I believe that the doctest itself reflects the before/after.

Thanks - I've merged this.

Sorry, @rxin forget to change the title.


On Windows, I can't get out with ctrl-d from the input screen opened via prqlc compile

I tried prqlc on PowerShell 7 on Windows Terminal, and I realized that I can't quit from the prqlc compile screen.

Thanks!
Is this just the command that Windows sends with that keybinding? Or is something that prqlc can change?
https://stackoverflow.com/questions/976796/can-i-make-python-2-5-exit-on-ctrl-d-in-windows-instead-of-ctrl-z
(maybe either way we should change the docs...)

Oh, I didn't know ctrl-z would work instead. It certainly seems to work.
I think the documentation needs to be updated.


[doc] added some documentation for the api

Pull Request Test Coverage Report for Build 560

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 558:
0.0%

Covered Lines:
571

Relevant Lines:
571

💛  - Coveralls


werkzeug 2.2.3 breaks serving on unix domain sockets in hidden unix directories

I have a strange problem that I can reproduce on werkzeug 2.2.3 and cannot reproduce on werkzeug 2.2.2.
I'm trying to flask run --host=unix://.path/to/socket in development mode (so that I can front the server with an authenticating reverse proxy). This used to work and no longer does on 2.2.3.
With 2.2.3, when I run flask, I get a crash that looks like this (sorry that it's a screenshot instead of text, I'm working in an odd environment):

With 2.2.2, it just runs fine.
This seems to happen only when the argument to --host is a unix domain socket that starts with a . character, like what happens if your environment lives in the .nox directory. For example, flask run --host=unix://.nox/dev/tmp/flask.sock.
You ought to be able to reproduce this with the minimal flask application:
from flask import Flask
app = Flask(__name__)
@app.route("/")
def hello():
    return "
is it me you're looking for?
"

Then:
python -m venv venv
source venv/bin/activate
pip install flask werkzeug==2.2.3
mkdir -p .nox
socat TCP-LISTEN:6789 UNIX-CONNECT:.nox/test &
flask run --host=unix://.nox/test

This should produce a crash. After that:
pip install werkzeug==2.2.2
socat TCP-LISTEN:6789 UNIX-CONNECT:.nox/test &
flask run --host=unix://.nox/test

This should work.
I have a medium hunch that this has something to do with #2517, just because that's where most of the changes between 2.2.2 and 2.2.3 happened. But I have no idea why they exhibit this behavior change.
Environment:

Python version: 3.10
Werkzeug version: 2.2.3

I should add, I dropped a print just before https://github.com/python/cpython/blob/v3.10.10/Lib/socket.py#L793 and name is the string . in my reproduction of the problem.

This actually looks like an issue with Python, not Werkzeug. http.server is calling socket.getfqdn(), which wants to decode the URL from IDNA to ASCII, but that only makes sense for hosts, not for unix socket paths. http.server doesn't support Unix sockets, that's something we added on top, but we can't get in at the place this is happening to prevent it. You should try to report this to Python, or even ask for/implement Unix support in http.server.
I think we could always convert a Unix socket to an absolute path, that should never start with a ..

Interesting. I should be able to convert everything to absolute paths, thanks. I suppose the fact that it worked before was mostly an accident. I'll think about what to try to do in http.server.


Document how to fetch paginated data from dataplane API

In the implementation guide, document how to fetch paginated data from dataplane API. For example:
curl -L -w "%{http_code} %{url_effective}\n" -k -X GET -H 'Content-Type: application/json' -H 'Authorization: '$MIE_ACCESS_TOKEN "$DATAPLANE_API_ENDPOINT/metadata/ebb8d873-ae75-4b92-b632-1bc4b8f37c28/WebCaptions_en" | jq '.cursor'

Also, document how to overwrite data store for a given asset, eg:
curl -k POST -H 'Authorization: '$MIE_ACCESS_TOKEN -H "Content-Type: application/json" --data '{"OperatorName": "WebCaptions_en", "Results": {"start":"4.98"}, "WorkflowId": "ebb8d873-ae75-4b92-b632-1bc4b8f37c28"}' $DATAPLANE_API_ENDPOINT/metadata/ebb8d873-ae75-4b92-b632-1bc4b8f37c28

Also document how to get the workflow id for an asset:
curl -L -w "%{http_code} %{url_effective}\n" -k -X GET -H 'Content-Type: application/json' -H 'Authorization: '$MIE_ACCESS_TOKEN $WORKFLOW_API_ENDPOINT/workflow/execution/asset/ebb8d873-ae75-4b92-b632-1bc4b8f37c28 | jq

I'm just going to treat this issue like a list of useful curl commands which would be useful in the docs.
Here's how to get a workflow configuration:
curl -L -w "%{http_code} %{url_effective}\n" -k -X GET -H 'Content-Type: application/json' -H 'Authorization: '$MIE_ACCESS_TOKEN $WORKFLOW_API_ENDPOINT/workflow/configuration/MieCompleteWorkflow2 | jq


Implemented convolution aware initialization

Hello,
I implemented convolution aware initialization as described in this paper: https://arxiv.org/abs/1702.06295
Thank you.

Looks good, but is there any reason not to extend to 3D filters as well? Seems easy enough to do...

In the paper I really only focused on 1D and 2D convolution, so there's not empirical evidence that it would work for 3D convolution (although in theory it should). I could implement it using numpy's irfftn and rfftn functions. Would you recommend doing so?

Because it's easy to do and potentially useful, I would recommend it.

I just added support for Conv3D. Let me know what you think.

I added tests that reflected the upper and lower bounds proved in the paper. I had to add a new parameters to the _runner to allow testing against bounds.

LGTM!

Great! When will it be merged?

Very soon! Was hoping to get another review, just sent out requests since it hadn't happened spontaneously.


add Access logs

📑 I have found these related issues/pull requests

🏷 Feature Request Type
Other
🔖 Feature description
Currently there are no access logs when run without a reverse proxy.
✔ Solution
https://github.com/expressjs/morgan
Should be as easy as
var express = require('express')
var morgan = require('morgan')
var app = express()
app.use(morgan('combined'))

❓ Alternatives
No response
📝 Additional Context
No response

What operation are you missing need access logs for?
I don't think that expressjs/morgan is quite what you want as this would spam the log with status page related events but would ommit the actual events via websockets..

To prevent an XY-Problem, why do you want access logs for http-requests?
Is this related to https://github.com/louislam/uptime-kuma/issues/3481 ?

To see who called the backend and the status page. Currently you need to put a reverse proxy in front of it to get access logs. Websockets are usually not part of the access logs

And why do you want to know that specifically? That seems pretty noisy and not actionable for me.

If you put something on the internet, you want to know what is happening. If you are concerned about being too noisy, make it optional.
It’s somehow related but I don’t need audit logs, just normal access logs like every webserver out there

want to know what is happening

We already do log for interesting events, no request logs required.
What are you concerned about specifically? Is there something which we are not logging that we should?

this conversation is leading to nothing if you don’t understand what access logs are and why they are needed. closing this issue and finding an alternative, thanks

I was mostly probing to see if this is a debug or info thing, but if this is not a need for you this is fine by be.
And yes, I don't quite understand why the noise of access logs is usefull for operating the system. (Request logs likely don't fulfill auditing requirements => not usefull for that)


Unable to create gossip_messages directory to save gossip messages. Disabling saving debug data to file.

Description
During startup, Teku tries to create the following folders in the current directory instead of using the configured data-base-path.
./gossip_messages
./gossip_messages/decoding_error
./gossip_messages/rejected
./invalid_blocks

This is probably due to the recent introduction of the DebugDataDumper .
Steps to Reproduce (Bug)

download and unzip teku 24.4.0
navigate to any folder you have read only access (i.e., /home)
launch teku via absolute or relative path
wait a few seconds
stop teku (CTRL+C)
check the log for the error message ERROR | DebugDataDumper | Unable to create gossip_messages directory to save gossip messages. Disabling saving debug data to file.
navigate to a temp folder you have write permissions
launch teku via absolute or relative path
wait a few seconds
stop teku (CTRL+C)
verify debug folders are created inside the current folder

Expected behavior:
Teku complies with the data-base-path in the configuration file.
Actual behavior:
Teku is trying to use the current folder for debugging purposes.
Frequency:
Always
Versions

Software version: teku/v24.4.0/linux-x86_64/-privatebuild-openjdk64bitservervm-java-17
Java version: OpenJDK Runtime Environment (build 17.0.10+7-Ubuntu-122.04.1)
OS Name & Version: Ubuntu 22.04.4 LTS

Hi @Neurone thanks for raising this.  By default dumping p2p debug data is disabled and teku was creating the debug directories in the current directory in this case. This behaviour is fixed in https://github.com/Consensys/teku/pull/8258, so will be part of the next release. For the moment, it is safe to ignore this error message. In case you want to enable p2p debug data, can use --Xp2p-dumps-to-file-enabled=true. In that case, the correct data-base-path is used.


Minor updates and spelling fixes

Summary
Adding spelling corrections for docs and minor changes to install guides to bring them up to date. Removing broken link

Hello @Conor0Callaghan,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla


postgresql-jdbc: 42.2.2 -> 42.2.5

Motivation for this change
Version bump mostly for bug fixing but also one CVE fix :

Security: added server hostname verification for non-default SSL factories in sslmode=verify-full (CVE-2018-10936)

Regarding the licensing :
https://github.com/pgjdbc/pgjdbc/pull/660
https://github.com/pgjdbc/pgjdbc/blob/master/LICENSE
https://jdbc.postgresql.org/about/license.html
And I removed the underscore in the install rule to avoid breaking the package with #26839
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

cc @yorickvP @Mic92 for review maybe? :)


Is it possible to run this on shared web hosting

hello
i have integrated the toolkit in my asp .net website. but when i run it on a shared hosting server, it gives me an error.
is it possible to convert files on shared hosting?
thanks
raxit

It depends on your hosting provider policy, though almost all sharing provider do not allow apps to run arbitrary exe (so there is high chance that you cant run this on a shared hosting).

You wouldn't be able to (or at least you shouldn't be able to due to the risks arising from being able to run an executable, in addition to the stress that this would impose on the shared cpus)


[RFC] Removed VPC resource dependency

Every time we run terraform it tries to create 3 instances of this resource.
I believe we can just drop it and have successful applies from now on.
This is need because when we apply the changes on Circle CI (streethub-infrastructure repo) every build will be marked as failing due to terraform failing to instantiate this resources.

What is your basis for thinking we can drop it and remove it from the stack?

Not much besides trial and error, just created this in a minute to remember discussing it today basically.

So now we've fixed the statefiles/AWS state, this pull request should now be redundant