Runtime error using Effectful + Conduit + Servant + UnliftIO

Hello!
I've been experimenting with using Effectful alongside Servant. I also want to use Conduit for streaming responses. Because Servant's Conduit integration expects a handler to return a ConduitT () a IO (), I decided to use UnliftIO to run the side-effects in Conduit's pipeline in my custom monad. I know, I know, it's confusing.
To make this more clear, I put together an example repo. I've implemented two toy examples -- the first uses newtype App a = App (ReaderT String IO a) as my custom monad and the second uses type App = Eff '[Reader String, Error ServerError, IOE]. Both compile just fine, but when I call the streaming endpoint for the Effectful example, I get the following runtime error:
version (3) /= storageVersion (0)
CallStack (from HasCallStack):
  error, called at src/Effectful/Internal/Env.hs:358:5 in effectful-core-<IP_ADDRESS>-8gRe1gsiGtKADksLppQ43Q:Effectful.Internal.Env

You can try both versions for yourself. Clone the example repo above, and run the following for the MTL example:
$ stack run -- mtl

You should now be able to do the following:
$ curl localhost:3000/stream
{"itemId":1,"itemText":"Drew"}
{"itemId":2,"itemText":"Drew"}
{"itemId":3,"itemText":"Drew"}
{"itemId":4,"itemText":"Drew"}
{"itemId":5,"itemText":"Drew"}
{"itemId":6,"itemText":"Drew"}
{"itemId":7,"itemText":"Drew"}
{"itemId":8,"itemText":"Drew"}
{"itemId":9,"itemText":"Drew"}
{"itemId":10,"itemText":"Drew"}

Now, try running the effectful version:
$ stack run -- effectful

If we perform the same curl request, we see our runtime error:
$ curl localhost:3000/stream
curl: (52) Empty reply from server

and from the server process:
listening on port 3000
version (3) /= storageVersion (0)
CallStack (from HasCallStack):
  error, called at src/Effectful/Internal/Env.hs:358:5 in effectful-core-<IP_ADDRESS>-8gRe1gsiGtKADksLppQ43Q:Effectful.Internal.Env

You can view the code responsible for streaming here.
Apologies for the long-winded explanation, but I figured this would be the easiest way to demonstrate the problem. This feels like it may be a bug.
Let me know if you need any more information.

I decided to use UnliftIO to run the side-effects in Conduit's pipeline in my custom monad. I know, I know, it's confusing.

Not really, seems like a perfectly reasonable use case :slightly_smiling_face:
The problem you're hitting is usage of the unlifting function long after the effects it refers to have gone out of scope. Note that it's called when the conduit is run, not when it's constructed and this happens after you return from the handler, so even outside of the call to runEff.
There are two workarounds:

Don't use the unlifting function in a conduit. In your case it's easy to solve so far by adjusting stream:

stream :: Reader String :> es => Eff es (ConduitT () Item IO ())
stream = do
    name <- ask
    pure $
      C.yieldMany [1 ..]
        .| C.takeC 10
        .| C.mapMC
          ( \i -> pure $ Item i name
          )

Of course this doesn't work if you actually need to run some effectful function inside the conduit. In this case you need to copy the environment.
A utility function is needed:
import Effectful.Dispatch.Static
import Effectful.Dispatch.Static.Primitive
import Effectful

withClonedEnv :: Eff es a -> Eff es a
withClonedEnv action = unsafeEff $ \es -> unEff action =<< cloneEnv es

and then
stream :: (IOE :> es, Reader String :> es) => Eff es (ConduitT () Item IO ())
stream = withClonedEnv $ do
  C.withRunInIO $ \runIO -> do
    pure $
      C.yieldMany [1 ..]
        .| C.takeC 10
        .| C.mapMC
          ( \i -> runIO $ do
              name <- ask

              pure $ Item i name
          )

will work.
Looks like I missed this use case, so there is no unlifting strategy that would give you this option easily :disappointed:

I think I'll add withClonedEnv to effectful-core and adjust the error message you got to refer to this particular case and hinting at its usage.

The problem you're hitting is usage of the unlifting function long after the effects it refers to have gone out of scope. Note that it's called when the conduit is run, not when it's constructed and this happens after you return from the handler, so even outside of the call to runEff.

That's what I suspected was happening, though I was confused as to how it was working with ReaderT.

Of course this doesn't work if you actually need to run some effectful function inside the conduit. In this case you need to copy the environment.
A utility function is needed:

I realize that the example was super artificial, but I was just trying to keep the code small. As you guessed, I would actually like to run these side-effects in my custom monad, but I couldn't come up with a better example :)
Does cloning the env like this have any downsides? For example, if I use this technique with a State effect, will the State be "forked" at the time of clone?

Looks like I missed this use case, so there is no unlifting strategy that would give you this option easily 😞

No problem, thanks for the helpful response! It sounds like adding withClonedEnv to effectful-core will work out nicely!

I just stumbled into the same issue with Scotty and a simple StreamingBody result type.
Incidentally I have used Effectful, Servant and Streaming together without issue because I used Servant's hoistServer along with a single higher level runApp call.  The magic incantation was ...
liftedServer <- withRunInIO $ \toIo -> pure $ hoistServer (Proxy @MyAPI) (Handler . ExceptT . try . toIo) myServer
let
  app :: Application
  app = serve (Proxy @MyAPI) liftedServer

I don't think Scotty has a hoist so I may have to go with withClonedEnv.

Does it work if you use withEffToIO (instead of withRunInIO) with a ConcUnlift strategy, @goertzenator ?

Sorry, disregard my last reply - I was a bit hasty and didn't fully parse your message @goertzenator !

Aha!  I got Scotty working with monadUnliftIO.
withRunInIO $ \toIo -> scottyT 80 toIo myEffServer

I just stumbled into the same issue with Scotty and a simple StreamingBody result type.
Incidentally I have used Effectful, Servant and Streaming together without issue because I used Servant's hoistServer along with a single higher level runApp call. The magic incantation was ...

Thanks for the tip! I tried this out but, and it worked -- with a caveat. I was required to use the ConcUnlift unlifting strategy, otherwise I was greeted with a runtime error. See the relevant line in my gist here. However, this does seem like exactly what UnliftStrategy is intended for. Good to know!
Were you performing side effects in your Streaming response? Is there something I'm doing wrong in my example?
Thanks!

Thanks for pointing out withEffToIO; I should be using that instead.
I am indeed doing side effects in the streaming response.  Looking at my code I ejected the withRunInIO call to a separate function so I can do all my logic in a nice clean Stream (Of a) (Eff es) r (which I assume is similar to ConduitT () a (Eff es) ()).
toIOStream :: (MonadUnliftIO m) => Stream (Of a) m r -> m (Stream (Of a) IO r)
toIOStream str = withRunInIO $ \toio -> pure $ hoist toio str

Making that look more concrete gives:
toIOStream :: (... es) => Stream (Of a) (Eff es) r -> Eff es (Stream (Of a) IO r)
toIOStream str = withRunInIO $ \toio -> pure $ hoist toio str

The part that I'm not seeing in your code is the hoist.  I've never used Conduit before, but I suspect it has something similar to Streaming's hoist.  Maybe that helps, or maybe what you've written is already equivalent to this.  UnliftIO still makes my head spin...

Thanks for the tip! I tried this out but, and it worked -- with a caveat. I was required to use the ConcUnlift unlifting strategy, otherwise I was greeted with a runtime error. See the relevant line in my gist here. However, this does seem like exactly what UnliftStrategy is intended for. Good to know!

Your gist works, but with a caveat. If your attempt to use any any handler-local effect in the conduit, you will be back to square one. E.g. if you modify stream from the gist to:
stream :: (IOE :> es, Reader String :> es) => Eff es (ConduitT () String IO ())
stream = runReader @Int 777 $ do
  C.withRunInIO $ \runIO -> do
    pure $
      C.yieldMany [1 :: Int ..]
        .| C.takeC 10
        .| C.mapMC
          ( \i -> runIO $ do
              _ <- ask @Int -- makes use of the just-created Reader Int
              name <- ask
              pure $ name <> " " <> show i
          )

you'll get the same error as in the beginning because of the same reason - the Reader Int will no longer exist when you try to run the conduit.

I think I'll add another unlift strategy for this instead of providing withClonedEnv as it looks more ergonomic.
Can any of you test if #224 works for you?

I've updated my example repo and this does indeed fix the problem. Thanks!


Now am only able to download "public" Lynda videos despite using Authentication Options

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.10.12. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.10.12

Before submitting an issue make sure you have:

[ ] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl -v https://www.lynda.com/R-tutorials/Up-
Running-R/120612-2.html --username<EMAIL_ADDRESS>--password ******** --playl
ist-start 1 --playlist-end 10
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'https://www.lynda.com/R-tutorials/Up-Running-
R/120612-2.html', '--username', 'PRIVATE', '--password', 'PRIVATE', '--playlist-
start', '1', '--playlist-end', '10']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2016.10.12
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[lynda:course] Downloading signin page
[lynda:course] Submitting email
[lynda:course] Submitting password
[lynda:course] 120612: Downloading course JSON
WARNING: 20 videos are only available for members (or paid members) and will not
 be downloaded. Use --username and --password options to provide lynda.com accou
nt credentials.
[download] Downloading playlist: Up and Running with R
[lynda:course] playlist Up and Running with R: Collected 6 video ids (downloadin
g 6 of them)
[download] Downloading video 1 of 6
[lynda] Downloading signin page
[lynda] Submitting email
[lynda] Submitting password
[lynda] 129815: Downloading video JSON
[lynda] 129815: Checking 0-720 video format URL
[lynda] 129815: Checking 0-360 video format URL
[lynda] 129815: Checking 0-540 video format URL
[lynda] 129815: Checking 2-720 video format URL
[lynda] 129815: Checking 2-360 video format URL
[lynda] 129815: Checking 2-540 video format URL
[lynda] 129815: Checking 1-720 video format URL
[lynda] 129815: Checking 1-360 video format URL
[lynda] 129815: Checking 1-540 video format URL
[debug] Invoking downloader on 'https://lynda_files2-a.akamaihd.net/secure/cours
es/120612/VBR_MP4h264_main_HD720/120612_00_01_WX30_welcome.mp4?c3.ri=37707795023
84859668&hashval=1476416124_8b9d1922d0b28942a65fd441ed7c7674'
[download] Welcome-129815.mp4 has already been downloaded
[download] 100% of 6.21MiB
[download] Downloading video 2 of 6
[lynda] 129816: Downloading video JSON
[lynda] 129816: Checking 0-720 video format URL
[lynda] 129816: Checking 0-360 video format URL
[lynda] 129816: Checking 0-540 video format URL
[lynda] 129816: Checking 2-720 video format URL
[lynda] 129816: Checking 2-360 video format URL
[lynda] 129816: Checking 2-540 video format URL
[lynda] 129816: Checking 1-720 video format URL
[lynda] 129816: Checking 1-360 video format URL
[lynda] 129816: Checking 1-540 video format URL
[debug] Invoking downloader on 'https://lynda_files2-a.akamaihd.net/secure/cours
es/120612/VBR_MP4h264_main_HD720/120612_00_02_XR15_exfiles.mp4?c3.ri=37704980304
27990084&hashval=1476416126_863c499fbda57ec18e4820ce3e4cd484'
[download] Using the exercise files-129816.mp4 has already been downloaded
[download] 100% of 1.27MiB
[download] Downloading video 3 of 6
[lynda] 129818: Downloading video JSON
[lynda] 129818: Checking 0-720 video format URL
[lynda] 129818: Checking 0-360 video format URL
[lynda] 129818: Checking 0-540 video format URL
[lynda] 129818: Checking 2-720 video format URL
[lynda] 129818: Checking 2-360 video format URL
[lynda] 129818: Checking 2-540 video format URL
[lynda] 129818: Checking 1-720 video format URL
[lynda] 129818: Checking 1-360 video format URL
[lynda] 129818: Checking 1-540 video format URL
[debug] Invoking downloader on 'https://lynda_files2-a.akamaihd.net/secure/cours
es/120612/VBR_MP4h264_main_HD720/120612_01_01_XR15_context.mp4?c3.ri=37733127761
35048197&hashval=1476416127_f1926ccba7a880deb431dfa1ef8669e6'
[download] R in context-129818.mp4 has already been downloaded
[download] 100% of 5.18MiB
[download] Downloading video 4 of 6
[lynda] 129827: Downloading video JSON
[lynda] 129827: Checking 0-720 video format URL
[lynda] 129827: Checking 0-360 video format URL
[lynda] 129827: Checking 0-540 video format URL
[lynda] 129827: Checking 2-720 video format URL
[lynda] 129827: Checking 2-360 video format URL
[lynda] 129827: Checking 2-540 video format URL
[lynda] 129827: Checking 1-720 video format URL
[lynda] 129827: Checking 1-360 video format URL
[lynda] 129827: Checking 1-540 video format URL
[debug] Invoking downloader on 'https://lynda_files2-a.akamaihd.net/secure/cours
es/120612/VBR_MP4h264_main_HD720/120612_03_01_XR15_bar.mp4?c3.ri=377077950238485
9818&hashval=1476416129_3ee9d5566cb64808ca8aae6c4391a3e9'
[download] Creating bar charts for categorical variables-129827.mp4 has already
been downloaded
[download] 100% of 30.91MiB
[download] Downloading video 5 of 6
[lynda] 129836: Downloading video JSON
[lynda] 129836: Checking 0-720 video format URL
[lynda] 129836: Checking 0-360 video format URL
[lynda] 129836: Checking 0-540 video format URL
[lynda] 129836: Checking 2-720 video format URL
[lynda] 129836: Checking 2-360 video format URL
[lynda] 129836: Checking 2-540 video format URL
[lynda] 129836: Checking 1-720 video format URL
[lynda] 129836: Checking 1-360 video format URL
[lynda] 129836: Checking 1-540 video format URL
[debug] Invoking downloader on 'https://lynda_files2-a.akamaihd.net/secure/cours
es/120612/VBR_MP4h264_main_HD720/120612_05_01_XR15_chgrp.mp4?c3.ri=3770498030427
990197&hashval=1476416131_d649f6b70b9526aa7c21afc2736718ad'
[download] Creating simple bar charts of group means-129836.mp4 has already been
 downloaded
[download] 100% of 15.81MiB
[download] Downloading video 6 of 6
[lynda] 129843: Downloading video JSON
[lynda] 129843: Checking 0-720 video format URL
[lynda] 129843: Checking 0-360 video format URL
[lynda] 129843: Checking 0-540 video format URL
[lynda] 129843: Checking 2-720 video format URL
[lynda] 129843: Checking 2-360 video format URL
[lynda] 129843: Checking 2-540 video format URL
[lynda] 129843: Checking 1-720 video format URL
[lynda] 129843: Checking 1-360 video format URL
[lynda] 129843: Checking 1-540 video format URL
[debug] Invoking downloader on 'https://lynda_files2-a.akamaihd.net/secure/cours
es/120612/VBR_MP4h264_main_HD720/120612_06_03_XR15_crosstab.mp4?c3.ri=3770779502
384859912&hashval=1476416132_22525a344f1cdcbee1ace8ce661a84c5'
[download] Creating crosstabs for categorical variables-129843.mp4 has already b
een downloaded
[download] 100% of 16.48MiB
[download] Finished downloading playlist: Up and Running with R

...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Description of your issue, suggested solution and other information
Earlier today I was able to download lynda videos with no problem. However, now it is only downloads the "public" videos (those available to anyone) even though I included (as I always do) my user name and password on the command line (I've hidden them in the above log, if you need them let me know).
Note: in the above log files the files were already download from previous attempt but it downloaded all 6 public videos despite there being over 25 of them.
When I try to log into lynda.com with the user name and password I am successful and am able to view all videos not just the public ones.
I tried to see if I could figure out anything but have been unable to get it to work so I believe there must be some internal change made in their code.
I appreciate you looking into this for me. Thanks.

I am also having the same issue today, after working fine last week. It it seems to take the login and password fine, but then gives the warning message
[lynda:course] Downloading signin page
[lynda:course] Submitting email
[lynda:course] Submitting password
[lynda:course] 513596: Downloading course JSON
WARNING: 24 videos are only available for members (or paid members) and will not
 be downloaded. Use --username and --password options to provide lynda.com accou
nt credentials.

You must provide account credentials for any further investigations.

Just emailed you my account details. Thanks

i am facing the same issue on
youtube-dl.exe --version
2016.10.12
is there any fix ?


Add a Django system check...

...that CONFIG_FIELDSETS accounts for all of CONFIG
In other words, adds a check that addresses the issue mentioned in https://github.com/jazzband/django-constance/issues/293

Great work. Thank you!


Investigate use of Keras core

Keras Core is now in beta https://keras.io/keras_core/, and will replace the current tf.kerasAPI in v3. This would allow us to make pytorch, JAX and TF models with the same API, and may lead to performance improvements. Probably this will also break lots of backwards-compat of model loading (see #155...) and might need a few more code changes for custom loss functions etc. I will try to find time to investigate this before MODNet v1.0.

This is now officially released and I think I'd like to try implementing it. Looks like it could cover lots of cases for us (e.g., model parallelism)


No data returned when using start/end parameters (rather than 'period') for history and download methods

Describe bug
The start and end parameters of download and history methods are no longer returning data, e.g.
start_date = '2024-06-25'
end_date = '2024-06-30'
d = yf.download(tickers="MSFT", start=start_date, end=end_date)

1 Failed download:
- MSFT: No data found for this date range, symbol may be delisted

Passing in the period parameter returns data as expected, e.g.
d = yf.download(tickers="MSFT", period='1wk')

gives:
                                  Open        High         Low       Close   Adj Close    Volume
Date
2024-06-24 00:00:00-04:00  449.799988  452.750000  446.410004  447.670013  447.670013  15913700
2024-06-25 00:00:00-04:00  448.250000  451.420013  446.750000  450.950012  450.950012  16747500
2024-06-26 00:00:00-04:00  449.000000  453.600006  448.190002  452.160004  452.160004  16507000
2024-06-27 00:00:00-04:00  452.179993  456.170013  451.769989  452.850006  452.850006  14806300
2024-06-28 00:00:00-04:00  453.070007  455.380005  446.410004  446.950012  446.950012  28333300

As far as I can tell, the start and end parameters are still valid: https://github.com/ranaroussi/yfinance/blob/main/yfinance/scrapers/history.py.
Simple code that reproduces your problem
import yfinance as yf
d = yf.download(tickers="MSFT", start=start_date, end=end_date)
print("\nData returned with start/end parameters:\n", d, "\n##################")
d = yf.download(tickers="MSFT", period='1wk')
print("\nData returned with 'period' parameters:\n", d, "\n##################")

msft = yf.Ticker("MSFT")

hist = msft.history(period="1wk")
print(f"\nMSFT with '1wk' period is:\n", hist, "\n##################")

hist = msft.history(start=start_date, end=end_date, interval="1d")
print(f"\nMSFT with start/end dates is:\n", hist, "\n##################")
quit()

Debug log
yf.enable_debug_mode()  throws an error, since enable_debug_mode is not available on yf.
Bad data proof
[*********************100%***********************]  1 of 1 completed

1 Failed download:
- MSFT: No data found for this date range, symbol may be delisted

Data returned with start/end parameters:
 Empty DataFrame
Columns: [Open, High, Low, Close, Adj Close, Volume]
Index: []
##################
[*********************100%***********************]  1 of 1 completed

Data returned with 'period' parameters:
                                  Open        High         Low       Close   Adj Close    Volume
Date
2024-06-24 00:00:00-04:00  449.799988  452.750000  446.410004  447.670013  447.670013  15913700
2024-06-25 00:00:00-04:00  448.250000  451.420013  446.750000  450.950012  450.950012  16747500
2024-06-26 00:00:00-04:00  449.000000  453.600006  448.190002  452.160004  452.160004  16507000
2024-06-27 00:00:00-04:00  452.179993  456.170013  451.769989  452.850006  452.850006  14806300
2024-06-28 00:00:00-04:00  453.070007  455.380005  446.410004  446.950012  446.950012  28333300
##################

MSFT with '1wk' period is:
                                  Open        High         Low       Close    Volume  Dividends  Stock Splits
Date
2024-06-24 00:00:00-04:00  449.799988  452.750000  446.410004  447.670013  15913700        0.0           0.0
2024-06-25 00:00:00-04:00  448.250000  451.420013  446.750000  450.950012  16747500        0.0           0.0
2024-06-26 00:00:00-04:00  449.000000  453.600006  448.190002  452.160004  16507000        0.0           0.0
2024-06-27 00:00:00-04:00  452.179993  456.170013  451.769989  452.850006  14806300        0.0           0.0
2024-06-28 00:00:00-04:00  453.070007  455.380005  446.410004  446.950012  28333300        0.0           0.0
##################
MSFT: No data found for this date range, symbol may be delisted

MSFT with start/end dates is:
 Empty DataFrame
Columns: [Open, High, Low, Close, Adj Close, Volume]
Index: []
##################

yfinance version
0.2.4
Python version
3.11.4
Operating system
Windows 10

I am having the same problem. It was working last night, but not today.

Update yfinance

Update yfinance

Thank you!
Now running yfinance-0.2.40, and everything is working as expected.
(And not previous latest of v0.2.4)

Update yfinance

Thank you!
Now running yfinance-0.2.40, and everything is working as expected.
(And not previous latest of v0.2.4)


clarify the vsys situation

the tested vsys...versus the actual systemic velocity of the system...

addressed by #75! honestly kind of neatly, too :)


samples: mcp9808: Fix CONFIG_MCP9808_TRIGGER_GLOBAL_THREAD assignment

CONFIG_MCP9808_TRIGGER_GLOBAL never existed. Looks like a typo.
Signed-off-by: Ulf Magnusson<EMAIL_ADDRESS>

Codecov Report

Merging #7855 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7855   +/-   ##
=======================================
  Coverage   55.02%   55.02%
=======================================
  Files         483      483
  Lines       53968    53968
  Branches    10501    10501
=======================================
  Hits        29694    29694
  Misses      19986    19986
  Partials     4288     4288

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9174c6...7351d22. Read the comment docs.


ng-pattern doesn't understand RegExp literal

<div ng-pattern="/^[0-9]+(\.[0-9]{1,2})?$/"/>

Gives this error:
Lexer Error: {Unexpected next character } at columns 1-1 [^] in expression [/^[0-9]+(.[0-9]{1,2})?$/]`

Fixed in commit 41a925b7d69f16f1f49cebd43d4da2b530f838d3.


help(cdk-virtual-scroll-viewport): How to use autosize and event scrolledIndexChange

How to use autosize and event scrolledIndexChange?
The height of each element is different, so autosize must be used. When using autosize, the scrolledIndexChange event stops working and an error appears
Error: cdk-virtual-scroll: scrolledIndexChange is currently not supported for the autosize scroll strategy

That error is reflecting that the autosize and virtual scroll is still experimental and not yet considered stable

That error is reflecting that the autosize and virtual scroll is still experimental and not yet considered stable

what should I do? how to solve a problem?


AL - Fix Storybook Deployment Scripts

This PR fixes the storybook deployment scripts to enter the correct working directory (javascript instead of frontend) and to deploy from the correct build directory (docs-build instead of storybook-static).
Tested with STARTER-team02-docs and STARTER-team02-docs-qa

Merging with verbal permission by Conrad.


[HELP WANTED] Can't upgrade Jetty without breaking WebSocket implementation

Upgrading breaks the tests, but that can be fixed as seen in #698.
This only fixes the tests though. When actually trying to run a project which uses WebSockets, I get:
Exception in thread "Thread-0" java.lang.NoClassDefFoundError: org/eclipse/jetty/http/pathmap/PathSpec
	at spark.embeddedserver.jetty.EmbeddedJettyServer.ignite(EmbeddedJettyServer.java:108)
	at spark.Service.lambda$init$2(Service.java:504)

We need to update the implementation, and write some better tests.

@joakime I don't suppose you have more time on your hands, and could look at this one too? I saw your name a lot while digging through the jetty source code.

Yeah, sure, no problem.
I wrote the websocket code afterall.
I'll have to help you get over the 9.4.5 hurdle in the future too.
(Support for javax.websocket 1.1 changes were massive)

@joakime Do you know when you'll get time to look at this? We want to release 2.6 soon, and we're wondering if this could make it into the release.

@tipsy see PR #838

Thanks!


Add support for create custom build rule

To make xcake generate project compatible with j2objc, I need to add custom build rule.
My experience about ruby is almost zero, please point out any problem in this pr, thanks!
Intend to fix #180

Coverage decreased (-0.5%) to 96.5% when pulling 91180aa73722e8f19181b27bbefdd1874a3419e3 on Piasy:master into 5753581f0e420d21b32d20dfe6664153872d18e3 on jcampbell05:master.

Coverage decreased (-0.5%) to 96.5% when pulling 91180aa73722e8f19181b27bbefdd1874a3419e3 on Piasy:master into 5753581f0e420d21b32d20dfe6664153872d18e3 on jcampbell05:master.


pulumi complains about changes to unmodified resources

Pulumi tries to recreate some resources without modifications, like the RoutingProtocol resource due to changes in the "name" field even though there are no changes. Although it could be temporarily suppressed with ignore_changes=["name"] we must investigate and identify if we are missing something in the configuration or if there is a problem in the pulumi terraform bridge plugin
routing_protocol_bgp_gcp = equinix.fabric.RoutingProtocol("rp-bgp",
    opts=pulumi.ResourceOptions(
        depends_on=[routing_protocol_direct_gcp],
        ignore_changes=["name"]
    ),
    type="BGP",
    connection_uuid=fabric_connection_gcp.id,
    name="FabricToGCPRoutingProtocolBGP",
    customer_asn=gcp_peer_config.gcp_asn,
    bgp_ipv4=equinix.fabric.RoutingProtocolBgpIpv4Args(
        customer_peer_ip=gcp_peer_config.gcp_router_ip
    ),
)

While the issue with field name mentioned above will be fixed in https://github.com/equinix/pulumi-equinix/pull/91 (it was an issue in terraform provider), there are some other resources and fields with that issue that I think it could be a problem with the bridge plugin https://github.com/pulumi/pulumi-terraform-bridge/issues/1951

fixed in #104


[Feature]: Support USAGE ON DATASET grants in snowflake_grant_privileges_to_account_role

Use Cases or Problem Statement
I attempted to use the latest provider to grant usage on a dataset like so:
resource "snowflake_grant_privileges_to_account_role" "model" {
  privileges        = ["USAGE"]
  account_role_name = local.account_role
  on_schema_object {
    object_type = "DATASET"
    object_name = "MY_DB.MY_SCHEMA.MY_DATASET"
  }
}

But got this error:
│ Error: expected [{{} on_schema_object} {{} {{{{} 78}} 0xc000d2a3c0}} {{} object_type}] to be one of ["AGGREGATION POLICY" "ALERT" "AUTHENTICATION POLICY" "DATA METRIC FUNCTION" "DYNAMIC TABLE" "EVENT
TABLE" "EXTERNAL TABLE" "FILE FORMAT" "FUNCTION" "GIT REPOSITORY" "HYBRID TABLE" "IMAGE REPOSITORY" "ICEBERG TABLE" "MASKING POLICY" "MATERIALIZED VIEW" "MODEL" "NETWORK RULE" "PACKAGES POLICY" "PASSWOR
D POLICY" "PIPE" "PROCEDURE" "PROJECTION POLICY" "ROW ACCESS POLICY" "SECRET" "SERVICE" "SESSION POLICY" "SEQUENCE" "STAGE" "STREAM" "TABLE" "TAG" "TASK" "VIEW" "STREAMLIT"], got DATASET

Category
category:grants
Object type(s)
resource:grant_privileges_to_account_role
Proposal
Add DATASET as an option for object_type within resource snowflake_grant_privileges_to_account_role
How much impact is this issue causing?
Low
Additional Information
No response
Would you like to implement a fix?

[ ] Yeah, I'll take it 😎

Duplicates #2807.

Closing as duplicate.


[New Version Available]: K-Lite Codec Pack Standard

Package Requested

[X] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[ ] I have performed a search and couldn't find this package.
[ ] I have checked that the installer for this package is not a standalone or portable executable or a .zip file
[X] I think there is a new version available and I have provided the URL.

Please provide the following information
Publisher:
Publisher Url: https://www.codecguide.com
Package Name:
Description:
Package Version: 17.0.0
Installer URL: https://files3.codecguide.com/K-Lite_Codec_Pack_1700_Standard.exe
Current Package Identifier (for new versions):

Resolved in #61123

Duplicate of #61123


Model API QA: Errors met when testing model training and replacing loaded model

Problem description:

Testing /model/train endpoint with the example in the docs leads to a YAML validation error (400 Bad Request error:

"The request body does not contain valid YAML. Error: Failed to validate YAML. Please make sure the file is correct and all mandatory parameters are specified. Here are the errors found during validation:\n  in Line 1:\n      Value 'b'- intent: greet\\\\n examples: |\\\\n - hey\\\\n - hello\\\\n - hi'' is not a list. Value path: '/nlu'"

Testing PUT /model endpoint with this request body (existing file on disk) leads to 400 Bad Request:

{
"model_file": "/models/20211110-091805-impulsive-birth.tar.gz"
}

It seems not to be able to identify the path given, this is the response error message:
"Agent with name '/models/20211110-091805-impulsive-birth.tar.gz' could not be loaded."
The debug log shows this user warning:
UserWarning: No valid configuration given to load agent. Agent loaded with no model!

Found the same - @tayfun I see you're assigned so maybe you already saw this, but it expects literal yaml, so a documentation issue - this request works:
curl --request POST \
  --url http://localhost:5005/model/train \
  --header 'Content-Type: text/yaml' \
  --data 'version: '\''3.0'\''
config:
  store_entities_as_slots: true
session_config:
  session_expiration_time: 60
  carry_over_slots_to_new_session: true
intents:
- greet:
    use_entities: true
- goodbye:
    use_entities: true
- affirm:
    use_entities: true
- deny:
    use_entities: true
- mood_great:
    use_entities: true
- mood_unhappy:
    use_entities: true
- bot_challenge:
    use_entities: true
entities:
- name
slots:
  name:
    type: rasa.shared.core.slots.AnySlot
    initial_value: null
    influence_conversation: false
    mappings:
    - type: from_entity
      entity: name
  yes:
    type: rasa.shared.core.slots.AnySlot
    initial_value: null
    influence_conversation: false
    mappings:
    - type: from_intent
      intent: affirm
      value: yes
    - type: from_intent
      not_intent: affirm
      value: no
responses:
  utter_greet:
  - text: Hey {name}! How are you?
  utter_cheer_up:
  - text: '\''Here is something to cheer you up:'\''
    image: https://i.imgur.com/nGF1K8f.jpg
  utter_did_that_help:
  - text: Did that help you?
  utter_happy:
  - text: Great, carry on!
  utter_goodbye:
  - text: Bye
  utter_iamabot:
  - text: I am a bot, powered by Rasa.
actions: []
forms: {}
e2e_actions: []
nlu:
- intent: greet
  examples: |
    - hey [Molly](name)
    - hello [Bob](name)
    - hi [Chris](name)
    - hello there [Jim](name)
    - good morning [Fred](name)
    - good evening [Sally](name)
    - moin
    - hey there
    - let'\''s go
    - hey dude
    - goodmorning
    - goodevening
    - good afternoon
    - hi
- intent: goodbye
  examples: |
    - cu
    - good by
    - cee you later
    - good night
    - bye
    - goodbye
    - have a nice day
    - see you around
    - bye bye
    - see you later
stories:
- story: happy path
  steps:
  - intent: greet
  - action: utter_greet
  - intent: mood_great
  - action: utter_happy
rules:
- rule: Say goodbye anytime the user says goodbye
  steps:
  - intent: goodbye
  - action: utter_goodbye
- rule: Say '\''I am a bot'\'' anytime the user challenges
  steps:
  - intent: bot_challenge
  - action: utter_iamabot
'

@ancalita I think the model replacement 400s because of the absolute path - was the model really at the root of the machine?
If I follow the doc and use the full path to an existing model, instead of a 400 I get a 204, but the loaded model's name doesn't change:
 $ curl --request PUT \
  --url http://localhost:5005/model \
  --header 'Content-Type: application/json' \
  --data '{
  "model_file": "/Users/melinda/rasa_bots/3.0rc2_QA/models/20211115-213850-covering-bosun.tar.gz"
}' -vv
*   Trying ::1...
* TCP_NODELAY set
* Connection failed
* connect to ::1 port 5005 failed: Connection refused
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 5005 (#0)
> PUT /model HTTP/1.1
> Host: localhost:5005
> User-Agent: curl/7.64.1
> Accept: */*
> Content-Type: application/json
> Content-Length: 101
>
* upload completely sent off: 101 out of 101 bytes
< HTTP/1.1 204 No Content
< Access-Control-Expose-Headers: filename
< Access-Control-Allow-Credentials: true
< connection: keep-alive
<
* Connection #0 to host localhost left intact
* Closing connection 0

status remains the same as before:
$ curl --request GET \
  --url 'http://localhost:5005/status'

{
  "model_file": "20211115-220201-witty-agent.tar.gz",
  "model_id": "b0d7f6d363ff47cba922c33dbe38fb1b",
  "num_active_training_jobs": 0
}

there's only a log about UnexpectTED in the logs to show it read the model at all
2021-11-15 22:12:23 WARNING  rasa.shared.utils.common  - The UnexpecTED Intent Policy is currently experimental and might change or be removed in the future 🔬 Please share your feedback on it in the forum (https://forum.rasa.com) to help us make this feature ready for production.

Also: After unloading the model with a DELETE, doing the PUT just reactivates the previously loaded model.

@ancalita I think the model replacement 400s because of the absolute path - was the model really at the root of the machine?

@melindaloubser1 Oh that could have been the problem, not using absolute path, because indeed the models were not really at the root directory. But probably this could be made clearer in the docs (to use absolute paths) for those naive folks like myself copy-pasting examples 😅

Yes, yes you are both right @melindaloubser1 @ancalita . I need to update the documentation (and remove obsolete code which was handling JSON since only YAML is supported now). I'm struggling with redocly, specifically only using yaml in documentation has not been easy.

^^ I've had a fight with the API spec and YAML example snippets too, really cannot figure out what the magic is there besides that specifying the ref to the snippet separately for both schema & example sort-of works

@melindaloubser1 You're right. I had too much confidence in OpenAPI and redocly I think. It seems XML and YAML are not supported directly, see https://github.com/Redocly/redoc/issues/492#issuecomment-390919837

@tayfun Could you get the model replacement to work? Since the docs change the path instructions only, seems the endpoint itself may not be behaving as it ought?


QIIME2 environment not activating during pipeline, works in isolation and other environments work

Dear Hi-Fi Team,
My group first used your pipeline about a year ago for some skin samples, and we got it to work after a bit of effort as an LSF submission on our HPC. We have new skin samples now though, and can no longer get it to work. The issue seems to be with activating the QIIME2 environment. Whenever we get to the cutadapt step, we get the following:
[1e/0e7670] process > pb16S:write_log                [100%] 1 of 1 ✔
[d5/72a256] process > pb16S:QC_fastq (3)             [100%] 24 of 24 ✔
[48/20f6ce] process > pb16S:cutadapt (24)            [100%] 8 of 8, failed: 8
[-        ] process > pb16S:QC_fastq_post_trim       -
[-        ] process > pb16S:collect_QC               -
[-        ] process > pb16S:prepare_qiime2_manifest  -
[-        ] process > pb16S:merge_sample_manifest    -
[-        ] process > pb16S:import_qiime2            -
[-        ] process > pb16S:demux_summarize          -
[-        ] process > pb16S:dada2_denoise            -
[-        ] process > pb16S:mergeASV                 -
[-        ] process > pb16S:filter_dada2             -
[-        ] process > pb16S:dada2_qc                 -
[-        ] process > pb16S:qiime2_phylogeny_dive... -
[-        ] process > pb16S:dada2_rarefaction        -
[-        ] process > pb16S:class_tax                -
[-        ] process > pb16S:dada2_assignTax          -
[-        ] process > pb16S:export_biom              -
[-        ] process > pb16S:barplot_nb               -
[-        ] process > pb16S:barplot                  -
[-        ] process > pb16S:html_rep                 -
[-        ] process > pb16S:krona_plot               -
Error executing process > 'pb16S:cutadapt (2)'

Caused by:
  Process `pb16S:cutadapt (2)` terminated with an error exit status (1)

With the error:
Traceback (most recent call last):
    File "/sc/arion/projects/clemej05a/alba/conda/env/nf_conda/qiime2-2022.2-py38-linux-conda-0f9d5d3ab8a678e45d02e511ce6c0160/bin/qiime", line 7, in <module>
      from q2cli.__main__ import qiime
  ModuleNotFoundError: No module named 'q2cli'

Things that are weird to me/that I have tried:

The conda env works fine on its own. I can activate it and run the same commands that are in the cutadapt process manually, as well as use the q2cli that it can't find.
It's definitely not the content of the process. I tried replacing everything in the cutadapt process with echo "test" and got the same ModuleNotFoundError
When I go to the failed cutadapt work files, I can activate the environment and run them directly on command line with no issue.
Updated to the latest version of the pipeline, with the 2023 qiime env, no change.
Skipping the cutadapt step, which causes the same error to appear at the next process that uses the Q2 env.
Sanity check stuff like making sure conda_enabled is on, and the conda paths are accurate.
I tried checking with my HPC to see if there was an explanation on their side for this, but they couldn't help.
Once for seemingly no reason it gave me a JRE error and core dump instead of this module error, but never again. This was that error:

# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00002ba4f4022938, pid=86946, tid=86946
#
# JRE version: OpenJDK Runtime Environment JBR-<IP_ADDRESS>-1751.21-jcef (11.0.13+7) (build 11.0.13+7-b1751.21)
# Java VM: OpenJDK 64-Bit Server VM JBR-<IP_ADDRESS>-1751.21-jcef (11.0.13+7-b1751.21, mixed mode, tiered, compressed oops, g1 gc, linux-amd64)
# Problematic frame:
# V  [libjvm.so+0xbbb938]  SR_handler(int, siginfo_t*, ucontext*)+0x38
#
# Core dump will be written. Default location: /sc/arion/projects/clemej05a/alba/pb-16S-nf/core.86946

Thanks in advance for your help, let me know if I can provide more info
Adam

@adamcantor22 The latest pipeline should be using QIIME 2 2023.2, I would try updating the pipeline and let it download the new QIIME 2 environment to see if that solves the problem.
When you say you "I can activate the environment and run them directly on command line with no issue", did you activate via /sc/arion/projects/clemej05a/alba/conda/env/nf_conda/qiime2-2022.2-py38-linux-conda-0f9d5d3ab8a678e45d02e511ce6c0160? Can you show me the full command of what you did?
Thank you.

@proteinosome thanks for your reply.
Yes, I've upgraded to the 2023.2 version which has the same issue.
To activate the environment, I first load the anaconda3 module on my HPC, then do 'source activate /sc/arion/projects/clemej05a/alba/conda/env/nf_conda/qiime2-2023.2-py38...'. The environment is then active, and I can do any environment commands e.g. 'qiime feature-table' with no problems.

@proteinosome let me know if there's anything else I can try


Pagination template

Are there any options to pass in a custom template for pagination?

Not yet, It was ment to work with bootstrap pagination.
But if you have an idea, your PR is welcome 👍

Bootstrap 3 or 4? Will it work with either?

@sosensible At the moment, only works with Bootstrap 3.
I think it would be a good diea to add the custom template feature.

Feature in progress :)

The feature is available in the theme-feature branch, you can review it @kferran @sosensible. I'm thinking of adding two props where they can add their custom templates based to the theme files.

Has anyone tried this feature? @coderdiaz  when will you merge the theme-feature branch?

Nope :v

Closed for inactivity


How-to, Managing Users + other sections (WIP)

This is just a push for the rewritten-structure (no content yet) - separate merges incoming

Really great stuff! Kudos Filp!
This requires more fine tuning- and I'd like to review once more - once the preview deployment would be available


Display 1000 population figures to 1dp

This relates to the pop ups on the charts.

With whole numbers, for smaller practices population changes are mostly not distinguishable. E.g. in the image above, any change between 1,500-2,499 patients would not be apparent but could potentially affect the measures substantially. Also, for <500 patients it looks like there are zero patients.

I'd like it to say "patients", and give the number for that instead.  Any chance we can do that?

This is great! I just noticed that it doesn't apply to the low-priority compound measure though, is it possible to change that too @inglesp ?


Add the rest of the file operations in the LSP Specification

This builds on top of #25 by adding support for the rest of the file operations in the LSP specification. Honestly, I'm not sure if/any language servers actually implement all of these but they can be supported nonetheless 😅
This does include a refactor of the main setup just to simplify adding more modules and the events that trigger them rather than duplicating a bunch of code. This does include the changes in #25 so this could be merged later or just supersede it if you like where this is going.
I am about to go on travel for several weeks and will be unavailable so I'm going to mark this PR as a draft just because it will need to be reviewed, might want to involve refactoring of how the callbacks are built just to decrease more duplicate code, and the README hasn't been updated with all the new features.
Let me know if you think this is worthwhile and I can continue! If not, I understand :)

I've been testing this for a few weeks and it's working great. I think it's ready to go and I'm going to go ahead and close my other PR unless discussion wants me to reopen it and close this one.

Hey @mehalter!
Thank you for shouing interest in this plugin and for your contribution 🚀
I'll switch to this branch to test it out and will merge right after

updates on this? also is there a guide to implementing the plugin? with packer do you just put it in as shown in readme with no other config?

@jaivinwylde this PR is ready to go and I do not believe there are any bugs currently. Hopefully it gets merged any day now once the dev gets a chance to finish testing it!
Also the only thing you have to do along with adding the plugin to your plugin manager is to make sure to run the setup call as described in the docs:
require("lsp-file-operations").setup()

You would put this wherever would be standard for your plugin manager

@antosha417 just a heads up, I just did a bit of cleanup on the README to add a complete list of all of the file operations now supported (it's just all of the ones in the spec). I also added the missing config functions to the packer install instructions.

@jaivinwylde If you don't want to wait for the merge you can just install this plugin from a fork and use it right away

Thanks for the review @antosha417 ! I added a simple method for controlling the operations. Let me know if you want the interface to look differently. I opted for a map from { [string]: boolean } mainly because it allows the user to specify just a single one to disable rather than specifying an exhaustive list with the ones they want to disable missing. Let me know if you would prefer it to just be a list of strings!
I made sure to keep the performance the same as well 😄

Looks good!

Thanks so much! Glad to collaborate with you and love what this plugin provides!


Make Our E2E Tests Choose the Right Region

Right now we're hard-coding our tests to use the eu-west region. However, with the introduction of shipperctl admin clusters apply, people could define their own clusters very easily and run tests against those. We should retrieve that cluster and use its region instead of hard-coding the region when creating cluster requirements.

#50 addresses this

Fixed because #50 was merged!


Sections with repeating digits.

Hey, big fan of the blog. I use this class for my homeworks and the section numbering just displayed a 0 if the section was two repeating digits (11, 22, 66, etc.) Here's a document that reproduces the issue for me. Using TexLive 2015 on OSX.
Anyone else having this issue? \writtensection 10 and 12 work fine, but 11 renders as
0 Question 1
Instead of
Question 11.1
as I'd expect.
\begin{document}

\maketitle

\renewcommand{\writtensection}{11}

\setcounter{questionCounter}{0}

\hypertarget{section}{%
\section{}\label{section}}

Question content here

\end{document}

Found a fix, submitted PR.

Closed via #2.


Rename the master branch to main

Is your feature request related to a problem? Please describe.
The name of the master branch is offensive
Describe the solution you'd like
We should rename the master branch to main.

A quick guide on how to do this: https://www.hanselman.com/blog/EasilyRenameYourGitDefaultBranchFromMasterToMain.aspx
I'm not sure how to turn this into a pull request though.

This issue has been completed and the default branch is now main. The old master branch has been removed.


No times available for selected participants

Regarding Meeting assistant
If i click FIND TIMES button
I got toast like this  "No times available for selected participants"

Closing due to inactivity.


feat: made Context a part of the factory object

Closes #1001

Reviewing

Reviewing

Thanks. I did run a few commands, and they seem to be working :-D

problem is that I want to see if all occurences of context were replaced etc. looks good


feat(gen): added client err middleware option

Unfortunately I don't have the time to invest in getting this PR "to code", if anyone wants to pick it up, please do.


Missing configobj dependecy

Traceback (most recent call last):
  File "/usr/local/bin/mopidy", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/mopidy/__main__.py", line 69, in main
    extensions_data = ext.load_extensions()
  File "/usr/local/lib/python2.7/dist-packages/mopidy/ext.py", line 194, in load_extensions
    extension_class = entry_point.load(require=False)
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2355, in load
    return self.resolve()
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2361, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/local/lib/python2.7/dist-packages/mopidy_material_webclient/__init__.py", line 11, in <module>
    from configobj import ConfigObj, ConfigObjError
ImportError: No module named configobj

Same for me

pip install configobj

Thanks @jake-g this fixed it for me.
@matgallacher can you add this information to the installation instructions? Thanks.
Cool webclient by the way :)

Added to the instructions for the meantime - apologies for not being around much at the moment, work is somewhat getting the better of me.
Glad to hear people are using it!


FR: Allow for export of the User's table as CSV from the Users page

Please setup an icon/button to all an export of the Users page to CSV (same table as displayed on the Users page)

It would be useful when going through to remove old accounts, get a list of disabled accounts, audit stuffs, etc. TIA!

🦉 🦉 🦉 🦉 🦉 🦉 🦉 🦉

Will be part of 5.0


Small improvements to use Java 8 API

preferably mandated by Checkstyle or Eclipse Formatter or something like that

https://github.com/eclipse-ee4j/ee4j/tree/master/codestyle
This code style can be used automatically in a maven build, see e.g.
https://github.com/eclipse-ee4j/servlet-api/blob/master/api/pom.xml#L123

I have also just noticed https://github.com/eclipse-ee4j/cdi/tree/master/api/src/ide/eclipse and I wonder what should CDI use then :-)

I wonder what should CDI use then :-)

My guess would be the EE4J one ;) The jboss community one seems to have transferred from its previous location at Red Hat / Jboss.


fix: context handling for persistence and ack

context handling to ensure that all the read messages are successfully written and acked.

Thsi is the relevant log line that suggests that the window was closed.
2022-11-16T00:49:18.222Z	DEBUG	numaflow.ReduceUDF-processor	readloop/readloop.go:186	Closing Window	{"vertex": "even-odd-sum-compute-sum", "windowStart": "1970-01-01T01:42:00.000Z", "windowEnd": "1970-01-01T01:43:00.000Z"}


Improve debugging capabilities (Redux and React)

Suggestion: electron-devtools-installer + redux-devtools-extension instead of electron-debug.
In main process:
        const {
            default: installExtension,
            REACT_DEVELOPER_TOOLS,
            REDUX_DEVTOOLS,
        } = require("electron-devtools-installer");

        [REACT_DEVELOPER_TOOLS, REDUX_DEVTOOLS].forEach((extension) => {
            installExtension(extension)
                .then((name) => console.log("Added Extension: ", name))
                .catch((err) => console.log("An error occurred: ", err));
        });

In main and renderer processes:
import { composeWithDevTools } from "redux-devtools-extension";

    const store = createStore(
        myReducer,
        composeWithDevTools(
            applyMiddleware(myMiddleware),
        ),
    );

WebPack config for main process (so that source map paths can be found by VisualStudioCode etc.):
config.output.devtoolModuleFilenameTemplate = "[absolute-resource-path]";

Fixed via https://github.com/daisy/ace-gui/pull/83


A2DP sink output left/right channel swapped (IDFGH-1078)

Environment

Development Kit: Widora AIR v6.0
Module or chip used: ESP32 Rev.1
IDF version: v3.2
Build System: CMake
Compiler version: 1.22.0-80-g6c4433a
Operating System: Linux
Power Supply: USB

Problem Description
When ESP32 is used for A2DP streaming, the A2DP output left/right channels are swapped. I have tested the i2s example and the I2S driver works as expected, this problem seems to be related to A2DP data output.
When playing left channel only audio, the LA output is:

When playing right channel only audio, the LA output is:

The expected left/right channel behavior according to TRM:

Steps to repropduce

Get the a2dp_sink example from esp-idf v3.2.
Build the example and flash it to esp32.
Connect to esp32 with your phone and play the test files.
test_files.zip

Code to reproduce this issue
The a2dp_sink example from esp-idf v3.2

Well, the a2d_data_cb() is just a wrapper for i2s_write(), so the problem might be SBC decoding output:
void bt_app_a2d_data_cb(const uint8_t *data, uint32_t len)
{
    size_t bytes_written;
    i2s_write(0, data, len, &bytes_written, portMAX_DELAY);
    if (++s_pkt_cnt % 100 == 0) {
        ESP_LOGI(BT_AV_TAG, "Audio packet count %u", s_pkt_cnt);
    }
}

Hi @redchenjs,  We have do some test, and the PCM decoded by the SBC actually has the correct left and right channel order.
And the problem appear on the I2S side, our Drvier code defaults to the left channel in the high position, only need to set I2S_CONF_REG (0x0008) when I2S configuration the I2S_TX_MSB_RIGHT bit of the register, L/R, can be flipped over.


Unknown TimeZone ID : Asia/Yangon

The app crashes on setting the timezone to Asia/Yangon. Here's the log
FATAL EXCEPTION: main Process: <my_app_id>, PID: 1462 org.threeten.bp.zone.ZoneRulesException: Unknown time-zone ID: Asia/Yangon at org.threeten.bp.zone.ZoneRulesProvider.b(ZoneRulesProvider.java:1178) at org.threeten.bp.ZoneRegion.a(ZoneRegion.java:143) at org.threeten.bp.ZoneId.a(ZoneId.java:1357)

+1
It's a huge issue crashing on big apps like Reddit Mobile.

Using v1.3.6 of threetenbp on a standard JDK has no problem with this time-zone. I assume you are using Android, and probably not using the standard threetenbp-1.3.6.jar file, so I can't really help further.


Why asset_host isn't used for private assets?

This would have been more appropriate as a comment on #90, or at least have a some additional context. Truthfully I don't remember why it isn't used for private assets, it was modeled after the way fog handled urls. Is this causing trouble for you?

I using CloudFront origin access identity for restrict bucket access.
And, Object upload from ec2 instance was granted IAM Roles.
Then, I want to uploaded S3 object ACL is private.

I don't have a use case for private asset host, so I can't easily verify any changes. If you would like to make the change and test it out I will gladly accept a pull request.


Support for no_std

Specific Demand
Add no_std support so that web apps can be bundle size-optimized by not needing to include the standard lib in their wasm binaries.
Implement Suggestion
No specific suggestions, I more wanted to get a sense of the Dioxus developers' feeling on this - whether this was possible or not and whether this is a desired direction for Dioxus.
Edit: I should say I'm assuming dioxus would still require alloc.

Dioxus uses the standard library extensively in it's virtual dom implementation so I'm not sure this would be feasible. For binary size, there are probably other ways we can reduce binary size without omitting the standard library that would make a larger difference like removing dependencies and moving optional code behind feature flags.
One thing that could be interesting to look at for reducing the binary size is statically linking the standard library: https://github.com/johnthagen/min-sized-rust#optimize-libstd-with-build-std which should allow dead code elimination for parts of the standard library that Dioxus does not use


Stop invalid components being added to model

Currently, if one adds an invalid parameter, rule etc. that generates
an exception in __init__, (e.g. a validation error), the component
is still added to the model. In interactive mode, this is annoying, as
the model has to be re-instantiated. Example:
Model()
Parameter('a', 'invalid_value')  # raises ValueError
assert len(model.parameters) == 0  # fixed in this PR
Parameter('a', 1.0)  # should succeed, fixed in this PR

This PR fixes this situation by adding the Component to the Model
(by calling Component.__init__()) last instead of first in each
affected __init__ method.

Coverage increased (+0.1%) to 78.948% when pulling e88e1d3073dd469d3caba56bbf617c9b9dc8f3a9 on alubbock:fix_invalid_components into b6ba27d45eb17b8fbb239f9b592d529e107e4815 on pysb:master.


[VMware Fusion] Port Forwarding does not work when using Big Sur

Operating System Version: Big Sur Beta 10
Deploying via (VirtualBox/VMWare/AWS/Azure/ESXi): VMware Fusion
Vagrant Version (if applicable): 2.2.10

Port forwarding has not yet been implemented on Big Sur: https://discuss.hashicorp.com/t/vagrant-up-stuck-on-network-setup-with-vmware-provider-on-macos-11/14992/4

This may be fixed as of 1.0.14: https://github.com/hashicorp/vagrant-plugin-changelog/blob/master/vagrant-vmware-utility-changelog.md#1014
Will test in the next few days

I was able to get some clarification here from folks working on Vagrant:
 It's a little complicated but this is the current state:

* Fusion 12 on macOS Catalina - Everything works as expected
* Fusion 12 on macOS Big Sur - Port forwarding and network management is currently broken

The reason for the difference between the two versions is due to Fusion 12 being rewritten to simply be a wrapper around the virtualization and vmnet frameworks provided by macOS. The result of this is that where things don't work in the framework (like port forwarding to the loopback) the wait is now a combination of waiting for the framework to provide the functionality, and then for a Fusion update to include support. So using the provider modification discussed in the thread you linked will allow Vagrant to connect to the guest, and port forwards won't cause a failure, they just won't be functional.

With the updates to using the vmnet framework API, the only way to interact with the networks (in a CRUD context) is via the vmrest utility, which currently is not working as advertised. I'm not sure yet if this is due to a deficiency in the vmnet framework, or if it's the vmrest utility itself. New networks can be created, but they cannot be modified (or deleted), and the subnet/mask cannot be set. When on a non-Big Sur host, we can bypass using the vmrest utility since we can just affect network modifications directly via other vmware processes + configuration files.  Since those are not used anymore on Big Sur, it leaves us a bit stuck.

For the port forwarding side, we did a bunch of experimentation and digging to see if we could utilize pf, or really anything, to get things working until proper support gets released but were unsuccessful. I'm currently messing around with spinning out ssh processes to provide the forwarding. It's not ideal and makes it easy for things to end up in an inconsistent state, but we are attempting to get something in a usable state that we could utilize for now.

Although not perfect it is possible to switch from localhost ssh to public with adding/creating the following at ~/.vagrant.d/Vagrantfile (first image below). Although this only fixes part of the problem and will let you get the logger box up.

The next issue is NAT, which can be manually fixed ish.. With commenting out the nat entries in /Library/Preferences/VMware Fusion/vmnet8/nat.conf

However, it has to be done after each box is brought up... Although not pretty, what I did was vagrant up logger -> comment out nat entries -> vagrant up dc -> comment out nat entries and repeat process for the rest of the boxes.

Thanks for the workaround @Hops-AF !

For anyone trying the workaround, here's the text from https://github.com/clong/DetectionLab/issues/539#issuecomment-739084743:
Vagrant.configure("2") do |config|
  config.vm.provider :vmware_desktop do |v|
    v.ssh_info_public = true
  end
end

As an update here I was successful in building building DetectionLab without any additional modifications for networking. I used the latest version of macOS, VMware Fusion, the Vagrant plugin, and DetectionLab as of today. Per the changelog for the plugin, as of v1.0.18, it appears to support port forwarding in Big Sur (https://github.com/hashicorp/vagrant-plugin-changelog/blob/main/vagrant-vmware-utility-changelog.md)

Oooh that's exciting, I missed that! I'll try building tonight and if all is good I'll go ahead and close this. Thanks for the heads up @edepree !

Hi,
I tried building the Lab after a fresh reinstall of MacOS Big Sur 11.5.1 and I still get stuck. I cannot confirm building works without any network modifications.


@Pattern works incorrect if regex has options

Informations

Type
Version

Bug
4.32.0

Description
Schema
export class Client {

  @JsonProperty()
  @Required()
  @Pattern(/[a-z0-9]{10}/i)
  public client_id!: string;

  @JsonProperty()
  public client_secret!: string;

}

Response
Bad request on parameter "request.body".
<br />At Client.client_id, value '01020304aa' should match pattern "[a-z0-9]{10}/"

Acceptance criterias

[ ] Example (log, usecase, etc...)
[ ] Ts.ED version (bug/question)

Hello @microshine
I found the problem.
Ajv doesn't support RegExp with flag
pattern
The value of the keyword should be a string. The data to be valid should match the regular expression defined by the keyword value.
Ajv uses new RegExp(value) to create the regular expression that will be used to test data.
Example

schema: { "pattern": "[abc]+" }
valid: "a", "abcd", "cde", any non-string (1, [], {}, null, true)
invalid: "def", ""

Solution: Remove the i flag and the validator will work.


Add Algolia search once approved for open-source use

Splitting this out in its own issue from https://github.com/protocol/nft-website/issues/22 for post-MVP work.
Looks unlikely that Algolia will approve this site for an open-source license until MVP is launched and the URL has more public content. @zebateira — can you please re-submit to Algolia once the site is soft-launched with DNS correctly pointed? Thank you!

@jessicaschilling sent the request using your email 🚀


Update test-service/ratelimit-service to allow for use of TLS

Description
Updates the test-services/ratelimit-service to allow for the use of TLS if the USE_TLS env variable is set to true. Right now nothing uses this but https://github.com/datawire/ambassador/pull/1832 will use this once the new docker containers are built by @kflynn.
Related Issues
https://github.com/datawire/ambassador/pull/1832
Testing
Tested locally that existing tests do not fail using the new container.

Closing this in favor of https://github.com/datawire/ambassador/pull/1861, which includes some additional test service build work by @kflynn.


UI Enhancement

Improving current UI to modern UI design

Hi, i want to work on this.

Hi @Archana550,
Sure, thank you for your interest in this issue! I appreciate your enthusiasm and willingness to contribute. I will assign the issue to you – looking forward to your insights and solutions. If you have any questions or need assistance, feel free to reach out. Happy coding! 🚀 Also, don’t forget to leave a ⭐ if you like the project! and join Slack
Kind Regards,
Shashi Kumar Kasturi


UX-1# rest-api module... wip

Most model classes, still wip
BlueOceanUI.doResT() handles /rest and tries to delegates rest of the path to
ApiHead. It does not work though, needs more investigations
@Operation annotation intercepts incoming HTTP requests and does the following:
enforces handling of specific HTTP method, captures exceptions to return JSON error
message
WebException class to abstract HTTP specific exception.
ProfileService defined and Standalone implementation as example. More work needed.

@michaelmccaskill  please take a look.

@vivek  I think you meant someone else named Michael. I'm not familiar with this project.

@vivek thanks. hahha, yes wrong michael, taking a look.

LGTM - however, perhaps this is broader than just #UX-1.
The Pipelines/run stuff maybe should be its own module, and User/Org another. Perhaps put this against another ticket as this is infrastructural for REST/Json style interfaces.


can't build with rustc 1.24

The readme says

Most development happens on the master branch, however, this only supports nightly toolchains.

but also claims

You can use rustfmt on Rust 1.24 and above.

How does that work, since the dependencies use features that were stabilized after 1.24 (dyn Trait, i128) and even require unstable features? Travis also isn't testing against rust 1.24.

That is false, sorry. You need a recent nightly


Q: Create table leads to create index?

Question regarding the console
http://alasql.org/console/
When I enter
CREATE TABLE t9(  e9 INTEGER,  x9 VARCHAR(30))
the console writes
CREATE INDEX undefined ON t9(e9 INTEGER,x9 VARCHAR(30))
does alasql as default create an index behind the lines? I have not been able to find any information about it in the slides.

Sorry, this is a bug in toString() function.

Found and fixed. Thank you!


Check exit code from calling hostfxr_main

Currently we don't check this inside of the inprocess application.

@jkotalik will do this after preview2.


Stylebot won't undock from browser

Stylebot should be able to undock from the browser or have the ability to be repositioned and/or resized

Duplicate of #378 Closing this


FIX #5254 : dropdown height fixed and made scrollable

Description

Made filter scrollable

Fixes #5254
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
No changes to code coverage between the base branch and the head branch

@vibhandikyash Verified this fix now the table filter has scroll option in the dropdown working as expected

/ok-to-test sha=ee7f2fd

@vibhandikyash need the latest release merged here, Failing test fixes are available


[CELEBORN-142] Should add into committed partitions regardless whethe…

…r StorageInfo exists when commit files

What changes were proposed in this pull request?
bugfix for handle commitfiles response
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?

ping @FMX , seems the issue is introduced by https://github.com/apache/incubator-celeborn/pull/466 , plz have a check

This is used for deleted partitions in which storage info will be null on HDFS.

If this patch should be applied, worker should change its logic first.

Plz submit a pr including changing worker logic and this one. I'm closing this.


Homebrew bottle fails to build on Mojave

When trying to update the homebrew version of Macvim to snapshot 159, the bottle fails to build on Mojave, see Homebrew/homebrew-core#45455. There seems to be a Ruby mismatch.
The problem becomes apparent when running brew test macvim. The output shows that macvim --version has no Ruby support (-ruby) although Mac OS X Mojave ships with Ruby 2.3: see https://jenkins.brew.sh/job/Homebrew Core Pull Requests/50000/version=mojave/testReport/brew-test-bot/mojave/test_macvim/
Most likely, there is a problem with the way Homebrew tries to build the bottle. So probably a Homebrew problem and no Macvim problem. However, I hope that some Macvim developers care about this problem as many users use Macvim through Homebrew. Hopefully, we could shed some light on the build failure.
It seems that there are two possible solutions to this problem.
Either we could ignore the problem and remove Ruby support from the Mojave bottle. I don't know how many users actually rely on Ruby support... On the other hand, I think that Apple plans to stop shipping Ruby with OS X so we might need to do this in the future anyway.
The other option would be to solve the Homebrew problem, which seems to be the superior solution at this point. However, I have no clue how to do this since the problem does not seem to occur on a local computer.
I am not a very experienced user but I love the work you guys have done with Macvim. Therefore, I would very much like to help to solve this problem. I might be interpreting this problem completely wrong, so don't hesitate to tell me and point me in the right direction. Basically, any help would very much be appreciated.

@mvcouwen Thank you for an issue,
Reading the log and formula, configure script of ViM (MacVim is only GUI) haven't found library or it was incompatible for some reason. Formula explicitly checks that ruby was included into the build.
You could try to build it manually by yourself and provide full build logs to discover what really happened.

Returning to #952, it looks only for Ruby 2.6 shipped with Catalina. Alternatively, you could build with ruby/dyn (or download an official GitHub build), install Ruby 2.6 and try to use it.

@eirnym Thanks for the help! Are you suggesting to make the Macvim formula dependent on ruby? And then use homebrew ruby to build Macvim?
On the other hand, I have read somewhere that deleting SDKROOT (as done in the formula for Sierra and Yosemite) might solve the mismatch. Is this worth trying?

Could you try the build from GitHub if it works for you?
please, try to build MacVim manually explicitly providing ruby paths for configure script, such as --with-ruby-command as per documentation for configure script.

BTW, I don't know why the formula for MacVim is different with formula for vim

Solved by PR Homebrew/homebrew-core#45624.


Simplify storage migration function

@monstermunchkin maybe that'll make your life easier with the storage rework

@brauner good to go


Prelude in C♯ minor: The Hard Fork Combinator

Much like Rachmaninoff's famous prelude, the work on the hard fork combinator consists of three phases:

Various months of working through all the grim consequences of having transition points in the chain.
A period of highly agitated hacking and writing the actual hard fork combinator (this PR)
A quiet ending where we introduce the hard fork combinator on mainnet and everything Just Works (TM)

The new hard fork combinator is n-ary rather than binary. Not only does this mean we will be able to smoothly handle the transition from Shelley to post-Shelley (Shelley+MSIG, Goguen, and beyond), it also means that the code is very uniform and consistent; this also has various advantages for testing. For example, we can instantiate the combinator with a single block, and then test that "hard forking between just one block" (degenerate case) is equivalent to just running with that single block without the hard fork combinator meditating.
Supported interfaces
The consensus layer is a large piece of code that offers a lot of interfaces, and the hard fork combinator must deal with virtually all of those interfaces.
This PR is still WIP, but the vast majority of the interfaces have been completed:
Consensus protocol integration

[x] ConsensusProtocol instance
This includes chain selection, the leader check, consensus-specific header validation and consensus-specific rollback.

[x] BlockSupportsProtocol instance

Block integration

[x] BlockHasCodecConfig instance
[x] GetHeader instance
[x] StandardHash instance
[x] HasHeader instances (block and header)
[x] HasAnnTip instance (depends on #2059)
[x] ValidateEnvelope instance (#2071)
The trickiest part here is to verify that hashes line up across the transition point.

Ledger integration

[x] IsLedger instance
[x] ApplyBlock instance
[x] UpdateLedger instance
[x] HasHardForkHistory instance
[x] LedgerSupportsProtocol instance

Mempool integration

[x] ApplyTx instance
[x] HasTxId instance

LocalStateQuery integration

[x] ShowQuery instance
[x] QueryLedger instance

Integration with Byron / Shelley

[ ] CanHardFork instance (#2072)
Although the hard fork combinator takes care of most of the details, some ledger specific info must be required; in particular, the translation from the final Byron ledger state to the initial Shelley ledger state.

[ ] Serialisation. We must decide on a serialization format for the hard fork block, and make sure that it is backwards compatible with the existing Byron mainnet.  (#2073)

[ ] RunNode instance (#2074)

Testing

[x] RunNode instance for DegenFork
In order to test that the hard fork combinator implements all the interfaces required for RunNode, there is a DegenFork type that is a witness to the degenerate case where we are hard forking "between" exactly one era, which has a RunNode instance derived from the underlying block.

[ ] We should run the standard consensus tests with DegenFork as a sanity check (#2075)

[ ] We should run use the DualBlock infrastructure to compare ByronBlock to HardForkBlock '[ByronBlock]: the two should be isomorphic. (#2077)

[ ] Indeed, we should run a full node and have it try sync to mainnet or staging with HardForkBlock '[ByronBlock] (#2076)

[ ] We should run DualBlock with HardForkBlock '[ByronBlock, ByronBlock] and some arbitrary transition point. This will allow us to make check that stuff goes okay at transition points without having to think about translations between Byron and Shelley. (#2078)

[ ] We should run the consensus tests with HardForkBlock '[MockA, MockB] for two very simple block ledgers. (#2079)

[ ] We should run the consensus tests with HardForkBlock '[ByronBlock, ShelleyBlock] where we set the epoch size and slot length for both to the same value. This allows us to check everything except timing concerns (#2078)

[ ] Finally, we should test with the full Cardano chain, going from Byron to Shelley, including timing changes. This will depend on improvements to the testing infrastructure (most importantly #2029 and #2027) as well as improvements to the Shelley integration (at least #2030). (#2078)

Miscellaneous other TODOs/improvements

[ ] We need to finish the documentation of the hard fork combinator and update it with latest insights (draft PR at #1741) as well as reconsider timing constraints (https://github.com/input-output-hk/ouroboros-network/blob/nfrisby/doc-stability-window/doc/stability-window-design.md , PR #2056, I have some local markdown files that describe some of the timing subtleties that I need to polish and add to the repo, possibly others). (#2081)

[ ] HasHardForkHistory should have hardForkSummary as primitive instead of hardForkTransitions (and possibly also replacing hardForkShape. The state of the hard fork combinator allows us to read the Summary off almost straight away without having to recompute anything at all.  (#2080)

[ ] HasHardForkHistory should be given a default in terms of SingleEraBlock. (#2080)

HardForkBlock '[ByronBlock, ByronBlock] is interesting because we can use a different slot duration in the two eras. I'm guessing it's simpler to write a module for testing that protocol, and that would suffice for me to prove out the new oracular aspects of the test infrastructure.

HardForkBlock '[ByronBlock, ByronBlock] is interesting because we can use a different slot duration in the two eras. I'm guessing it's simpler to write a module for testing that protocol, and that would suffice for me to prove out the new oracular aspects of the test infrastructure. cc: @edsko @mrBliss

Yes, agreed. We'd just have to make sure that the second ByronBlock will be EBB free, as we don't currently support transitioning to eras with EBBs.

Included #2100 and #2101.

First commit is #2102.

Rebased on #2102 and #2103.

bors merge


Adding Wavefront to the users list

Wavefront internally uses argo for release automation

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Akshaya Chitneni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Hardknott Support

Applicable for hardknott branch

Please create a hardknott branch

Sorry it has taken me so long to respond to this. I finally have some time this week and next. Would you be able to separate the changes that add quoting around all the shell variables into a new pull request? Then this one can just be adding hardknott to compatible layers and fixing the override syntax?


[7.x.x] Clean unused tests

Remove entitlement and workflow tests
Bump framework

Merge after https://github.com/wso2/product-is/pull/15873


Update Webhook

As the operator no longer creates default
SriovOperatorConfig and SriovNetworkNodePolicy
the webhook is updated in the following Manner:
Validating:

Allow deletion of default config/policy.
Block create/update of non default config CR

Mutating:

keep skipping default but add a comment to mark as deprecated.

Related to #592

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-3 of 7 (57.14%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 25.854%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/webhook/validate.go
4
5
80.0%

pkg/webhook/mutate.go
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/webhook/validate.go
1
60.19%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
2907

Relevant Lines:
11244

💛  - Coveralls

@zeeke @SchSeba could you take a quick look at this one ?  the last of the series :)


Issue with local proxy with external images

I'm noticing some external images in e-mails aren't showing up, the dev console shows a 404 error and a grey pixel appears in place of the image.

Duplicate/related to https://github.com/RainLoop/rainloop-webmail/issues/1253 and https://github.com/RainLoop/rainloop-webmail/issues/1252.


javadoc truncated on converting from Props -> Builder

:bug: Bug Report
Affected Languages

[ ] TypeScript or Javascript
[ ] Python
[X] Java
[ ] .NET (C#, F#, ...)

What is the problem?

Compare FunctionProps.handler in typescript vs java

This is because the second paragraph and further gets into a "remarks" section and is not in the "summary" section. Code generation appears to ignore remarks.


[Request] Sort seasons of series in ascending order

As usual, I was showcasing elementum to a friend of mine and this time he noticed that seasons of series are sorted in descending order, as shown here.

So, I was wondering if it is possible to somehow sort them in an ascending one, i.e season 1 on the top, then season 2 and so on,
Expected Behavior
Elementum should sort seasons like so: season 1, season 2, season 3 etc.
Current Behavior
Elementum sorts seasons like so: season 5, season 4, season 3, season 2, season 1 and then the specials/extras.
Possible Solution
No idea.
Steps to Reproduce (for bugs)

Launch elementum and go to tv shows
Select one from the lists, e.g. breaking bad from the "most popular" list.
Notice what I mention above

Context
I think that ordering the seasons in ascending order offers a more straigh forward way to search through the episodes.
Your Environment

Version used: 0.1.37
Environment name and version: Kodi 18.4 on amd64 linux
Operating System and version: Debian testing x64
Link to Kodi debug log: not needed

Setting to sort seasons was added to v0.1.38.
Also "All seasons" was added, to look like Kodi library.
Please, try.

Works for me.
The only thing is that if you want to change ordering you need to do it for every TV series separately (not sure if it is Kodi or elementum thing)
Thank you

It works for every tv show for me. Screenshots for the first 4 from the "most popular" section.

@antonsoroko there is no caching for list of episodes/seasons. Maybe your skin is doing caching, or some other addon.


[cgal][openmvs] CGAL: Upgrade to 5.0

Upgrade the CGAL port to version 5.0-beta1

This pull-request is for the moment a draft. Do not merge it until it is updated to 5.0 final version.

@maxGimeno
Could you add a usage file, like in the data port:
https://github.com/microsoft/vcpkg/blob/2aaf7fd8b3d7dce245c5ce2d41aa3fdb6f0f7438/ports/date/usage#L1-L4
https://github.com/microsoft/vcpkg/blob/2aaf7fd8b3d7dce245c5ce2d41aa3fdb6f0f7438/ports/date/portfile.cmake#L44-L45
That would avoid the false message displayed automatically by vcpkg:
The package cgal:x64-linux provides CMake targets:

    find_package(CGAL CONFIG REQUIRED)

    # Note: 1 target(s) were omitted.

    target_link_libraries(main PRIVATE ${cgal_lib} CGAL::${cgal_lib} CGAL_Qt5_moc_and_resources CGAL::Qt5_moc_and_resources)

I have pushed an upgrade to CGAL-5.0-beta2. That is still a wip PR.

I have upgraded to 5.0. This PR should now be ready for integration.

This is a really important library for my project. I have tests for MacOS, Linux, and Windows if you want real-world examples to check: https://github.com/acgetchell/CDT-plusplus

I don't understand the CI failures. It says it is probably caused by the missing log files for comparison baseline, but I don't know how to fix this :/

@maxGimeno See #8949.

/azp run

@maxGimeno Please modify VCPKG_PATH/ports/openmvs/CONTROL:
Version: 1.0-2
->
Version: 1.0-3

@ras0219-msft I thinks this PR is ready to merge now.

Thanks for the PR!

Thank you, that was a smooth upgrade and the first simultaneous one for me on Windows, Linux, and macOS.
https://ci.appveyor.com/project/acgetchell/cdt-plusplus#L518
https://travis-ci.org/acgetchell/CDT-plusplus/jobs/615752586#L540


Trying to create a repo that already exists returns a weird error when auth is enabled

could not create ACL for new repo "mine": rpc error: code = Unknown desc = not authorized to perform this operation on the repo mine, must have at least OWNER access

This is fixed by https://github.com/pachyderm/pachyderm/pull/2310


Clarify text a bit

Thanks @ramonakira. I can't help but feel this wording is a little repetitive. Can you think of a better way to write it?
It might be nice to update the WAGTAILMENUS_FLAT_MENUS_EDITABLE_IN_WAGTAILADMIN docs accordingly too.

Text was updated in 6395822. Thanks for the spot @ramonakira!


namespaced vs. namespace

Hi there
Thanks for providing this library. It helps a lot in the migration process from Vue2 class-based to Vue3.
I've noticed there's a settle difference in your library compared to vuex-class:
Vuex-class:
@Getter('activeSet', { namespace: customizationSetNamespace })

vuex-facing-decorator:
@Getter('activeSet', { namespaced: customizationSetNamespace })

Was this intentional? It would be great if the API is 100% equivalent to vuex-class for people who migrate to it.

Thank you for feedback. I have corrected namespaced to namespace in version 1.1.0. You can try this version<EMAIL_ADDRESS>


Add files via upload

add the Email domain of University of Chinese Academy of Sciences

@zhaodeming file/lib/domains/cn/ac/ioa/mail.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@zhaodeming Pull request corrected and merged.
Please notice that free educational subscription for JetBrains tools is for students and teachers only, and is valid for using the tools for educational purpose only. If employees of this Institute who are not students, nor teachers, also need a license for JetBrains tools, they are eligible for an academic discount for the tools. They can get the discount by email to<EMAIL_ADDRESS>Thank you!


Handle a deleted namespace

When viewing a namespace and it is deleted, Octant should inform the
user of the next step.

We have a NotFound page in Octant that we maybe able to repurpose when the active namespace you're looking at is deleted.

Right now, we send an alert warning and keep the user on the same page.
We could extend our error capability to include a NamespaceNotFound which rendered a similar error page but a better error message and with links to some other namespaces a user could switch to.

Current behavior is an app level alert:


Issue with Find (CTRL-F) in the Deployment Pipelines section?

Is there an issue with the latest update and CTRL-F not working (find) to filter datasets and reports in the Deployment Pipelines section? this image is what it used to look like for me:

Pressing CTRL-F does nothing, and Find/Replace are grayed out in the Edit menu. I have restarted VS Code and even rebooted the PC. Still doesn't work.
The Find/Replace keyboard shortcuts and features work fine when editing a document, just no longer with this addin.

Hey @edhans,
that is nothing related to the extension itself but a change recently introduced in VSCode which has an impact on all treeviews like the ones I am using. It is described here with a potential workaround
https://code.visualstudio.com/updates/v1_89#_find-in-trees-keybinding
regards,
-gerhard


⚠ Secret Website 3 has degraded performance

In 5f44ecb, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 21250 ms

Resolved: Secret Website 3 performance has improved in 819a97c.


kctrl package release validation issue

What steps did you take:
git clone https://github.com/matteo-magni/carvel-lab.git
cd carvel-lab/kctrl/authoring-sample
kctrl package release --repo-output ./repository --tag 0.0.1 --version 0.0.1 --yes

What happened:
If some package values are required to be provided (i.e. via schema validation) the package won't build, and the error returned is
kctrl: Error: Reconciling: ytt:
  Error:
    Validating final data values:
  name
    from: schema.yml:4
    - must be: length >= 1 (by: schema.yml:3)
      found: length = 0

What did you expect:
I expect some variables to be required at install time but not at build time.
For example, if I provide a package to deploy infrastructure on AWS I want to force the user to choose the destination region, so no default can be set.
Anything else you would like to add:
The same problem was raised by me and @joostvdg in another GH issue two months ago (#927).
Environment:

kctrl version: v0.44.1

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

Thanks, @matteo-magni for reporting the issue. We will discuss and update the issue with the next steps.

I believe the case here is that there are no defaults for the value in question and it must me supplied.
Am I correct?

Correct. The value must be supplied at install time and not at build time, otherwise it would be included in the actual package, which is something I don't really want (that would be the same thing as setting a default).

I see, I agree with this. When running validations initially the intention is to let kbld have YAML it can look for images in. I think the build step should use --dangerous-data-values-disable-validation when templating. Thanks a lot for the callout!


Set password on MySql user for GKE

[ ] Forseti: Update Forseti docker entrypoint script
[ ] Terraform: Pass the username/password to the on_gke module
[ ] Heml: Update templates to utilize username/password variables

Story
This is a clone of #3217 to add the same feature for Forseti on GKE.
Proposed Solution
See tasks above.
Acceptance Criteria

[ ] GIVEN: a new project
WHEN: Forseti GKE is installed
THEN: the MySQL root user has a password
[ ] GIVEN: an existing Forseti installation on GKE
WHEN: Forseti is upgraded via Terraform
THEN: the MySQL root user has a password

Forseti + Terraform changes are done, we just need to support Helm. Move this ticket to helm repo.

Helm chart updated w/ sql user and password:
https://github.com/forseti-security/helm-charts/pull/52


Read dataset

Adds the initial command to read our dataset to parse before applying learning techniques.

Ensure to try out 3-4 different techniques to find the most efficient approach


How to refresh an adsense unit when route changes ?

Hi,
I use your package to display adsense units on my react app.
This works very well the first time the page load but I don't find the way to force units to be refreshed when route changes.
Using componentDidMount is ok to load the (adsbygoogle = window.adsbygoogle || []).push({})  part of adsense snippet. But as componentDidMount is only called once, units are never refreshed unless the whole page is reloaded by a cmd(or CTRL)-R.
I guess componentDidUpdate should be used here, but calling another (adsbygoogle = window.adsbygoogle || []).push({})   leads to Adsense error :
 adsbygoogle.push() error: All ins elements in the … with class=adsbygoogle already have ads in them...
Any idea how to handle that ?

Maybe we should remove the dom element of adsense, and then, call (adsbygoogle = window.adsbygoogle || []).push({}).

Hi, the solution I found was putting an unique key depending on page url to each ad component, that way ads are destroyed and recreated on every page changes.

excellent!

@jtexier hi,the solution you found,can you give a example,thanks.

@jtexier can you give me an example.
Thanks in Advance.

Hi @Pocamus51270, @cllgeek , @pratik-aileensoul  sorry for the late answer during this holyday time.
The problem is that components have to be removed from the DOM each time the url changes on the browser.
The solution is to give an unique key to each ads component, something linked to the url (could be a slug) and the format of the unit or an index if you display many units on a list
Example with a post page :
http://example.com/post/
<AdSense.Google
key={'300x250-'+post.slug}
client='ca-pub-7292810486004926'
slot='7806394673'
/>
Hope it helps.

The issue still persists for, adding key does not solve the problem. the library doesn't seem to support any key-related params. @hustcc Can you confirm?

<AdSense.Google
              key={Math.random()}
              client="ca-pub-8xxxxx"
              slot="7xxxxxxx"
              style={{ display: 'block' }}
              format="rectangle"
              responsive="true"
   />


How to add disable attribute to radio button

Hi,
It is a question not a issue, I just want to know how can I set the disabled property to the radio, I don't want to do something like:
document.getElementById("blablabla").disabled = true;
Best regards,
Daniel.

You can add disabled=true to the component helper.
{{radio-button value='green' checked=flavour disabled=true}}

See #6.

Hi @ynnoj
Thanks for your quick answer, I tried but I didn't work, I think it is because I was using an older version. Now I install de last one, but I am getting an error following the instructions in the README. #7
I restart the server and reinstall the npm modules but it still not working.
I created the component using ember generate component and add the code to expose de helper, but I get 'ENOENT, no such file or directory'


Allow use of Ansible files without a workspace

Fixes https://github.com/ansible/ansible-language-server/issues/117

If an individual file is opened in client without workspace (in
case of VSCode) the workspace param in undefined
To allow completion to work explicity set the workspace to
the folder containing the file opened within client.

Nice workaround. But it could be improved a bit - if there is any open workspace for which the file's path is a subpath, that could be used instead. In any other case, the first open workspace could be used, since this is most likely going to be the intention of the user. Incidentally, this would also cover the case of new, unsaved files, for which the path does not exist on the disk yet.

@tomaciazek Thanks for the comment.

But it could be improved a bit - the first open workspace could be used, since this is most likely going to be the intention of the user

If the user opens the client with a single file (say from command-line code <name-of-file>) in that case there won't be any open workspace. I am not sure if I understood your comment clearly.

@tomaciazek Thanks for the comment.

But it could be improved a bit - the first open workspace could be used, since this is most likely going to be the intention of the user

If the user opens the client with a single file (say from command-line code <name-of-file>) in that case there won't be any open workspace. I am not sure if I understood your comment clearly.

Alright, so I misunderstood the case that is being solved here. This solution will indeed be the best-effort implementation for that case. Mind that workspace created in this way will (likely) not provide any ansible.cfg, nor VS Code settings.
But, there are two other interesting cases, when there actually are some workspace folders to work with:

newly opened file does not match any of them
the user works on an unsaved tab
In both cases a better solution would be to take the first workspace from the list instead of generating a new one.

@tomaciazek could you explain those in more detail within separate issues so that this doesn't get lost?


Create Login and Sign Up

Use Figma for design - https://www.figma.com/file/AFtZDlQZT0HcC0KOR7EW8u/PRJ4020-Rental-Book-System?type=design&node-id=0%3A1&mode=design&t=5MyWGaOw3WOZr3wE-1

Login in form and sign-up form is functional and has been push to main.


Add SpanId, TraceId, AppName into MDC

Ref. https://github.com/ratpack/ratpack/issues/913#issuecomment-211289925

@hyleung while I remember, we also need to look at adding values into MDC. SpanId, TraceId, ?AppName. See ratpack.logging.MDCInterceptor.

Done. I think.


android: Update targetSdkVersion to 33 (Android 13)

This change will be required in order to upload new releases to the Play Store, effective 2023-08-31 (or 2023-11-01 if we request an extension).
Tested on an emulated Pixel running Android 13, but testing on a real device would be good too. (The office device I use only runs Android 9, though, so I can't do that myself.)
Fixes: #5453

Tested on my Pixel 5 running Android 13, and it seems to work fine. In particular I tested both "attach photo from library" and "use camera" — since that was one area where the docs indicated things were changing, which we looked at in the office on Friday — and both worked fine.
I suppose the other thing we need to do is to read through the list of potentially-breaking changes and confirm we don't see anything else that seems like it might affect us. I saw you'd looked through at least some of those docs on Friday. Do you have any notes on things you spotted?

The short answer is that I read through the whole doc, and I don't think anything in there is likely to be disruptive.
In a section "Battery Resource Utilization", it mentions the system broadcasts BOOT_COMPLETED and LOCKED_BOOT_COMPLETED, which IIUC announce to interested apps that the device has booted and been unlocked (or just booted, for the latter). Our app doesn't listen for those broadcasts.
There is a section "App color theme applied automatically to WebView content" about a setForceDark method being deprecated, but we don't use that; and a behavior change with the css media query prefers-color-scheme, which we don't use (but have thought about using: #5533).
For the "Updated non-SDK restrictions" section, a linked doc says any issues of that kind would show up in the Play Console, and I checked and didn't see any.

Cool, thanks. And I just read through it as well: https://github.com/zulip/zulip-mobile/issues/5453#issuecomment-1687272719 and don't see anything else of interest.
I did just test this in dark theme as well as light theme, and all still worked as desired.
LGTM; merging!