Question

Hello, i'm using your adblib and i'm trying using local command (push, pull or install for example) but I've only found examples that use "adbConnection.open("shell:")"
It's possible using this library to use local command ?
I am looking forward to your response.

Have you tried?

I´ve tried with "host:" and "adb:" but in both return ConnectionException, because i don´t know if it´s the correct syntax
I found this repo in issues from

What's wrong with "shell:"?

Nothing, but I need work with "push", "pull" and "install" but I don´t have any idea for how to work it, but with previous repo i´m trying that

Hello, sorry for not answered before, I´m working push and install and it works!
salmpalmer, I see the url that you shared and is too interesting, thanks for share!
Now, i´m working with pull

@ManoloLopera The link shows C++ code I am not familiar with. Could you share a hint or some code from the adblib how you use it to push and pull, please? Thanks a lot.

@konir https://github.com/wuxudong/flashbotin

Hello @tananaev
Following the Adb Pull protocol in https://github.com/cstyan/adbDocumentation , in step 20 device send me a message with the next structure:

DATA + data length + the file data
How can I access to "the file data" ???

I supose that with stream.read(), but I don´t known how -.-
I am looking forward to your response.

https://github.com/tananaev/adblib/issues/6#issuecomment-731631962
I think this resolve my problem

I´ve tried with "host:" and "adb:" but in both return ConnectionException, because i don´t know if it´s the correct syntax I found this repo https://github.com/wuxudong/flashbotin issues from https://github.com/cgutman/AdbLib

in case anyone who need, the correct url is
https://github.com/wuxudong/flashbot


Pass environment to identity providers on link or login

Required so the correct redirect url can be selected; otherwise the ID
provider will return an error because the url doesn't match the url
provided when getting the authcode.

Soooooo is that a pass...?

All this is to make the AppDev login less janky? I'm never taking a Java dev job

It's nothing to do with java, it's just that login & linking are by far the most complex parts of the system, and these changes go pretty deep into the guts of said system and touch a lot of pieces.
Almost done now, 1 more real PR to go probably.


Xcode alone is not sufficient on Sierra

I have a fresh client computer running Sierra 10.12.6, when I run the script:
$ sh mac 2>&1 | tee ~/laptop.log

Changing your shell to zsh ...
Password:
Changing shell for dashboard.
chsh: no changes made

Updating Homebrew formulae ...
Already up-to-date.
==> Tapping homebrew/bundle
Cloning into '/usr/local/Homebrew/Library/Taps/homebrew/homebrew-bundle'...
Tapped 0 formulae (130 files, 173.4KB)
Tapping thoughtbot/formulae
Tapping homebrew/services
Tapping universal-ctags/universal-ctags
Tapping caskroom/cask

Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing universal-ctags has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing git has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing openssl has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing rcm has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing reattach-to-user-namespace has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing the_silver_searcher has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing tmux has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing vim has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing watchman has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing zsh has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing heroku has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing parity has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing hub has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing imagemagick has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing<EMAIL_ADDRESS>has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing libyaml has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing coreutils has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing yarn has failed!
Installing gpg-suite
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing postgres has failed!
Error: Xcode alone is not sufficient on Sierra.
Install the Command Line Tools:
  xcode-select --install

Installing redis has failed!
Homebrew Bundle failed! 20 Brewfile dependencies failed to install.
failed

Do you think it's a good idea to install XCode command line tools at the beginning of Mac script?
xcode-select --install

xcode-select --install is currently an implicit dependency with the Homebrew installation:
https://github.com/thoughtbot/laptop/blob/8ad6fd7096c58c61cf59e1f5987ec996af46d6a1/mac#L92-L103
The ~/laptop.log output pasted here does not contain the text "Installing Homebrew ..." so it looks like brew may have already been installed before this script ran? Perhaps xcode-select --install was not accepted at that time?
Having said that, making xcode-select --install explicit might be a good idea.

This is where the Homebrew install runs xcode-select --install:
https://github.com/Homebrew/install/blob/afa0e0eeac175776e89500a8dffd54e0fe04b232/install#L271-L278

The ~/laptop.log output pasted here does not contain the text "Installing Homebrew ..." so it looks like brew may have already been installed before this script ran? Perhaps xcode-select --install was not accepted at that time?

You're right. I installed homebrew first before running laptop/mac script. It didn't prompt me to install xcode though 🤔

Having said that, making xcode-select --install explicit might be a good idea.

👍


move files to asdf install path

It appears that the GOBIN variable is not being used as a location to output the binaries, as I expected it woud be when reading the code. Simply moving the built binaries into place works.
Fixes #1

Hey! I'm sorry, I never got a notification for this PR. LGTM, thank you!


Missing column selection verbs rename and transmute

select and mutate are present, but there are two others that are variations on these:

rename is like select, but leaves other columns as they are: diamonds >> rename(Price = price) will just rename the one column.

transmute is like select, but allows mutation in column definitions, e.g. diamonds >> transmute(carat, new_price = price / 1000) will have only two columns, with new_price manipulated

These are added with #43 and #42


Conditions for "unanswered" questions should not be generated

Describe the bug
Currently, if questions about the presence of a condition (e.g. chronic lung diseases) are not answered at all, it is still exported without any verification status. Since those conditions are typically interpreted as being present, this leads to false information being exported.
To Reproduce
Export empty for unaswered questions about preexisting Conditions.
Expected behavior
For unanswered questions, no Conditions should be exported.
@makampf

Thank you for your report. I will have a closer look and come back to you.

Thank you for your report. I will have a closer look and come back to you.

@noemide Actually, I had a quite similar question this very morning which I posted on Zulip (https://chat.fhir.org/#narrow/stream/179183-german-(d-a-ch)/topic/GECCO-Datensatz/near/224294828) but have not received an answer yet...

@noemide Actually, I had a quite similar question this very morning which I posted on Zulip (https://chat.fhir.org/#narrow/stream/179183-german-(d-a-ch)/topic/GECCO-Datensatz/near/224294828) but have not received an answer yet...

I do not get the differentiation between unknown and not answered.
Why not assuming any unanswered field as unknown, and why not exclusively exporting only known answers like yes/no?

I do not get the differentiation between unknown and not answered.
Why not assuming any unanswered field as unknown, and why not exclusively exporting only known answers like yes/no?

@makampf Well, technically, if you do not answer a question at all then you do not provide any information but if you answer that you do not know then you provide at least that information... 🙂 How relevant this is in the end and how this should be "modeled" in FHIR is another question. 🤷♂

@makampf Well, technically, if you do not answer a question at all then you do not provide any information but if you answer that you do not know then you provide at least that information... 🙂 How relevant this is in the end and how this should be "modeled" in FHIR is another question. 🤷♂

The CodeSystem DataAbsentReason describes the differences. (and also possible different codings)

The CodeSystem DataAbsentReason describes the differences. (and also possible different codings)

I wondered about the relevance in cohort identification an thats actually another level of questionable relevance :D

I wondered about the relevance in cohort identification an thats actually another level of questionable relevance :D


failed run prisma cli in docker container of python 3.10

Bug description
failed run prisma cli in docker container of python 3.10
Downloading Prisma engines for debian-openssl-1.1.x ... Socket connection timeout
How to reproduce

run in docker container of python3

docker run --name test -it python:3.10.11-slim-buster bash

install prisma succcussful

pip install prisma succcussful
3. run prisma init error:
root@5238a031512d:/opt# prisma init
Installing Prisma CLI
 * Install prebuilt node (20.2.0) ..... done.
> Downloading Prisma engines for debian-openssl-1.1.x [                    ] 0%Error: request to https://binaries.prisma.sh/all_commits/8fde8fef4033376662cad983758335009d522acb/debian-openssl-1.1.x/query-engine.gz.sha256 failed, reason: Socket connection timeout

Expected behavior
wanted build a image of server with prisma and fastapi base image of python
Prisma information

Environment & setup

OS:  docker run --name test -it python:3.10.11-slim-buster bash
Database: PostgreSQL
Python version:
Prisma version: 0.8.2

Can you share your Dockerfile?
This is the Dockerfile we use for testing: https://github.com/RobertCraigie/prisma-client-py/blob/main/tests/Dockerfile
Here's how we're running it: https://github.com/RobertCraigie/prisma-client-py/blob/2a5b9045a85478807d54a076574daac41e480bbb/.github/workflows/test.yml#L334


Home react plugin

Adds the no-top-level-material-ui-4-import ESLint rule to the git-release-manager plugin to aid with the migration to Material UI v5.
Issue: #23467

@awanlin @freben @Rugvip  Please take a Look ! commenting for as there are no reviewers assigned

@AmbrishRamachandiran, the Home plugin is maintained by the discoverability-maintainers and they were added to this PR. I'll take a look as well though 👍

Hi @binishma-ss, just wanted to warn you to rotate your GitHub secrets ASAP as they are still in the commit history of this PR.

Waiting for PR to get merged, commenting for avoiding  Stale


fix(percy): adding waitForTimeout for false positive stories in Safari

Related Ticket(s)
No related issue
Description
Noticing that the card group with images and leaving ibm stories were showing false positives consistently in Safari. This is an attempt to have these stories skipped in Safari only (but still run in Chrome).
Changelog
Changed

add percy skip to card group with images and leaving ibm for Safari

Closing this, will do further investigation offline as this approach doesn't appear to be working.


bug: overlapping elements in settings menu on 1.19.2

Hi, forwarding this issue from our Modpacks Repo. (https://github.com/FTBTeam/FTB-Modpack-Issues/issues/2902)
The Bug
https://user-images.githubusercontent.com/66274985/229901015-6875df17-1fe3-446a-9235-66bfc08152a6.png
As you can see, in the top right, the two elements would appear to overlap.
Many thanks.

Sorry, just saw it now. It looks like something isn't working and I'm trying to fix it now.

fixed in mc1.19.x-v1.0.5
I will upload on curseforge & modrinth

uploaded


Block edge 4.5.17

4.5.17 needs to be disabled:
2 clusters currently failing (12%),  3 gone (18%),and 12 successful (71%), out of 17 who attempted the update over 7d
Currently failing classification:
* Untriaged: 2

4.5.17 can be enabled again:
2 clusters currently failing (10%),  3 gone (15%),and 14 successful (70%), out of 20 who attempted the update over 7d
Currently failing classification:
* Untriaged: 2


repeater dataSource to support array

It doesn't make sense to support just an array instead of a function, since the function / callback pattern is a common convention across several fuelux controls with a dataSource. Instead, I've made the repeater function even without a dataSource and be a lot more lenient with what's passed back in the callback. @swilliamset thoughts on this decision?

  // determine length page etc
  // call callback
}```

We will be addressing this in an upcoming release. Thank you!

This would be a great idea, however we're not going to add this unless its an explicit ask from a scrum team.


Webpack: The worst tech I've ever tried! HMR is not working at all.

Bug report

What is the current behavior?
 One of dozens is as below:
Enabled hot: true and added
 {
             loader: MiniCssExtractPlugin.loader,
             options: {
                 hot: true,
              },
}

to my css and scss rules. Serving caused errors, so I had to remove the block above and just keep the hot:true in devServer. HMR is still not working. In console, it just says:
 [HMR] Update failed: Loading hot update chunk application failed. missing: http://localhost:9000/application.6da021c816b0d34d754f.hot-update.js) The URL contains the updated file but the browser can't get it.
Tried every single reccommendation from StackOverflow (though there's only few solutions in there), none worked.  It's one of dozens issues I've encountered with this trash aka webpack.
 Have no idea why some devs use it and are so proud of it.
I can't be sorry more than that for you Webpack developers. I've attached my config.js and I'm damn sure no one can fix it.
const MiniCssExtractPlugin = require("mini-css-extract-plugin");
const webpack = require("webpack");
const OptimizeCSSAssetsPlugin = require('optimize-css-assets-webpack-plugin');
const TerserJSPlugin = require('terser-webpack-plugin');
const { CleanWebpackPlugin } = require('clean-webpack-plugin');
const { WebpackManifestPlugin } = require('webpack-manifest-plugin');
const HtmlWebpackPlugin = require('html-webpack-plugin');

const mode = "development";

module.exports = {
    watch: true,
    mode: mode,
    devtool: false,
    entry: {
        application: "./src/javascripts/index.js",
        admin: "./src/javascripts/admin.js"
    },
    output: {
        publicPath: '',
        filename: mode === 'production' ? "[name]-[contenthash].js" : '[name].js',
        path: path.resolve(__dirname, 'build')
    },
    plugins: [
        new MiniCssExtractPlugin({
            filename: mode === 'production' ? "[name]-[contenthash].css" : '[name].css'
        }),
        new webpack.SourceMapDevToolPlugin({}),
        new WebpackManifestPlugin(),
        new CleanWebpackPlugin(),
        new HtmlWebpackPlugin({
            template: './src/template.html'
        }),
        // new webpack.HotModuleReplacementPlugin({
        // })
    ],
    module: {
        rules: [
            {
                test: /\.m?js$/,
                exclude: /(node_modules|bower_components)/,
                use: {
                    loader: 'babel-loader',
                    options: {
                        presets: ['@babel/preset-env']
                    }
                }
            },
            {
                test: /\.css$/i,
                use: [
                    MiniCssExtractPlugin.loader,
                    { loader: 'css-loader', options: { importLoaders: 1 } },
                    'postcss-loader'
                    // {
                    //     loader: MiniCssExtractPlugin.loader,
                    //     options: {
                    //         hot: true,
                    //     },
                    // }
                ],

            },
            {
                test: /\.scss$/i,
                use: [
                    MiniCssExtractPlugin.loader,
                    { loader: 'css-loader', options: { importLoaders: 1 } },
                    'postcss-loader', 'sass-loader'
                    // {
                    //     loader: MiniCssExtractPlugin.loader,
                    //     options: {
                    //         hot: true,
                    //     },
                    // }
                ],
            },
            {
                test: /\.(png|jpg|gif|svg)$/i,
                use: [
                    {
                        loader: 'url-loader',
                        options: {
                            limit: 8192,
                            name: mode === "production" ? "[name]-[hash:7].[ext]" : "[name].[ext]"
                        },
                    },
                    { loader: 'image-webpack-loader' }
                ],
            }
        ]
    },
    resolve: {
        alias: {
            CssFolder: path.resolve(__dirname, 'src/stylesheets/')
        },
        modules: [path.resolve(__dirname, 'src/downloaded_libs'), 'node_modules']
    },
    optimization: {
        minimizer: [
            new TerserJSPlugin({}),
            new OptimizeCSSAssetsPlugin({})
        ],
    },
    devServer: {
        port: 9000,
        // contentBase: path.resolve(__dirname, 'build'),
        // inline: true,
        //  publicPath: '/',
        hot: true
    },
};

My package.json:
{
  "name": "webpack-tutorial",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "build": "webpack",
    "start": "webpack-cli serve"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "@babel/core": "^7.12.9",
    "@babel/preset-env": "^7.12.7",
    "autoprefixer": "^10.0.4",
    "babel-loader": "^8.2.2",
    "clean-webpack-plugin": "^3.0.0",
    "css-loader": "^5.0.1",
    "file-loader": "^6.2.0",
    "html-webpack-plugin": "^4.5.0",
    "image-webpack-loader": "^7.0.1",
    "imagemin-gifsicle": "^7.0.0",
    "mini-css-extract-plugin": "^1.3.1",
    "node-sass": "^5.0.0",
    "optimize-css-assets-webpack-plugin": "^5.0.4",
    "path": "^0.12.7",
    "postcss-loader": "^4.1.0",
    "sass-loader": "^10.1.0",
    "style-loader": "^2.0.0",
    "url-loader": "^4.1.1",
    "webpack": "^5.6.0",
    "webpack-cli": "^4.2.0",
    "webpack-dev-server": "^3.11.0",
    "webpack-manifest-plugin": "^3.0.0"
  },
  "dependencies": {}
}

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?

Other relevant information:
webpack version:
Node.js version:
Operating System:
Additional tools:

You are so toxic, no answer, sorry

Need help?
Your so-called "simple" solution didn't work too! Got it dumbass?
 Flooding my issue and closing it so quick so that
no one could see what I issued. Yeah?
 Kill yourself.
On Fri, Dec 4, 2020, 16:42 Alexander Akait<EMAIL_ADDRESS>wrote:

But solution is simple target: 'web'
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/webpack/webpack/issues/12120#issuecomment-738776392,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQGAO3MUD5WQJMU5QEPDJWTSTDN2NANCNFSM4UNNMN7A
.

No, you are toxic, I don't want to help such people


Reduce size of compiled / uploaded app

Current Implementation
In Google PlayStore the Corona-Warn-App is displayed with a size of 31 MB.
In Apple App Store the Corona-Warn-App is displayed with a size of 18,9 MB.
Suggested Enhancement
I think many people will not understand why a simple app which will not track any personal data or something else from them is so big. Also not so powerful devices should be supported, because not all people have latest power devices. I think many users will not install an app with such a huge size.

[ ] Reduce size of production required assets like images, icons, logos
[ ] Remove non-production required assets from app source
[ ] Remove all develop / test related stuff from production app
[ ] Reduce usage of not really required libs or use smaller ones
[ ] Check used install package type Android App Bundles or APK
[ ] Maybe optimize CI jobs / pipelines

Expected Benefits
More people will install a clean and smaller app.

The app simply needs the space right now. If you have concrete steps for improvements, contributions are welcome. But for now, we close this issue as too abstract.
Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team

Some of the recommendations were quite explicit: Reduce size of assets?
And yes, 30MB is big. Once it's running smoothly, try to get it down in a week or two.

@SebastianWolf-SAP please stop closing issues that aren't resolved, thanks.

@SebastianWolf-SAP Please don't add wontfix prematurely. Surely you will work on this app for the next few months while the pandemic is ongoing and continue to improve it.
You did a good job getting it out quickly. Now the optimisation begins.

@SebastianWolf-SAP please remember the first few weeks after the cwa-repositories were published step by step: Lots of issues  were closed with "we'll do that later, please wait". Soon after, lots of duplicates were created for the closed issues - most likely because the original problem still persisted and there were no open issues that tracked it. For one thing, this causes unnecessary work for the repository maintainers. But worse: it may lead to frustration on the side of contributors.
In this sense, I would suggest to close #527 as duplicate of #482 and reopen #482 since

the issue actually lists "concrete steps for improvements" and
"contributions are welcome".

@IT-Cru could you add in the benefit mentioned in #527 ("support for budget phones with small internal space") in https://github.com/corona-warn-app/cwa-app-android/issues/482#issue-639403794? Perhaps you could also use a task list instead of a bullet list.
https://github.com/corona-warn-app/cwa-app-android/issues/527#issuecomment-644682489 also asks if the app currently uses Android App Bundle as deployment method instead of APK. Perhaps this could also be added to the suggested enhancements.

Switched from bullet to task list and little re-ordering.
Added check for used package type.
@SebastianWolf-SAP: Are there any shared assets / components between Android and Apple repo?
Maybe I've a little more time on Friday or upcoming weekend with bad weather to dive deeper into code and repo structure.

I've taken a deeper look on why the app is too big for what it does, and found out that's because of the native libs that are getting shipped for every architecture in a single apk, that means an arm device would get an x86 lib binary even though it is not needed at all.

To remedy this we have two options AFAIK:

App Bundles  Obviously not possible with the current code structure as it requires some modularization steps to be taken for the project which I'm not sure if the maintainers have time for that or not.

Using APK splits which I tried it out as an experiment and resulted in three different apks:

Corona-Warn-App-device-arm64-v8a-release-unsigned.apk size 16.3 MB
Corona-Warn-App-device-armeabi-v7a-release-unsigned.apk size 14.4 MB
Corona-Warn-App-device-x86_64-release-unsigned.apk size 17.2 MB

That means if a user has a phone with one of these architectures, he'd just download the corresponding apk to his architecture hence saving almost 50% of the current download size.
I could try to open a PR for option 2, but not sure if it would get accepted by the maintainers or not.

@R4md4c Could you elaborate a little bit on what steps would be necessary for option 1? I understood that app bundles would enable Google Play to generate apks for the different native variants but maybe this was too naive.  Mainly for my curiosity; however it may be interesting for someone that would like to pick up the bundle variant.

@ironjan Thanks to your question, it made me read more in depth regarding the app bundle, and turned out that changing the code structure is only necessary if you're going to support Dynamic Features (which are features that are deferred until the user explicitly request them), which I don't think it applies to the use case of the corona app. I'll edit my comment to reflect on my findings.

The app simply needs the space right now. If you have concrete steps for improvements, contributions are welcome. But for now, we close this issue as too abstract.
Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team

@SebastianWolf-SAP 's reasons for closing the issue are no longer valid.
There are now very concrete proposals on how to reduce size to a third without much ado.
@R4md4c 's post shows clearly why it's a bad idea to close issues quickly even if there are no concrete solutions presented. They may appear later once someone sees there is an issue and starts looking. Point in case. So please, maintainers, stop closing issues as quickly as you're doing right now. You can add labels to them as much as you like, but don't silence the community when it thinks there's an issue.


build: Use node16 module resolution in azure packages, fluid-framework, and fluid-static

Won't be merged until https://github.com/microsoft/FluidFramework/pull/18125 is merged, and this can be updated to use the new tsconfigs.

Superseded by other PRs.


Add pipelineruns in vse-catalog

add pipelineRuns templates to tekton catalog
add readme on tekton catalog

Needs to squash commits before merge.


Move and rename IHostingStartup topic

Fixes #6228

rename the file/folder

How do you mean? ... the UID?

If you rename the title, you don't need to rename the folder. Now you have redirection and the PR has a bunch of renames. None of that is necessary - just rename the title.

And never change the UID, that's a convention.

Let's discuss offline. I'll send an email.

@guardrex  Is this ready to merge?

It is ... just didn't know if you wanted to revert the physical location/UID updates. You got my "BOOK" 📖 on the subject. lol ... but yeah ... It's all good. This keeps things nice and neat.


Update grails-quartz for Grails 7

4.0.x branch has been created for Grails 7: https://github.com/grails/grails-quartz

Internally, we use the quartz spring starter and it works perfectly as-is.  What are people's thoughts about publishing a guide for this way instead?

FYI: https://github.com/quartz-scheduler/quartz/issues/1134 - quartz was released so it should work with the jakarta packages now

@jamesfredley I made some updates for this plugin for Java 17 (this was mostly done already), Spring 6.2.0,  and Grails 7.0.0-snapshot in my  branch.  Before I do the MR where do we stand on the following.

Keep or  remove buildSrc dir?
Cleaning up the .toml and .gradle files in https://github.com/grails/grails-quartz/tree/4.0.x/gradle and moving the versions to gradle.properties?

@amondel2
Grails projects are currently split with and without buildSrc.  I personally like without because it is simpler and version management is not independent, but it is up to you.  For start.grails.org generated projects on 6.2.2 and 7.0.0 default to without buildSrc.
Most Grails projects do not use .toml.  For the ones that do, it is possible to use versions from grails-bom and remove most of the versions from .toml files.  It would also be OK to convert away from .toml, if you want to go this direction.  Toml is cool, but it takes more time to see what it is doing, IMO.
A good example of removing most versions from .toml:  https://github.com/grails/grails-spring-security-core/pull/1034/files
Anything with a version in https://repo.grails.org/ui/repos/tree/PomView/libs-snapshots-local/org/grails/grails-bom/7.0.0-SNAPSHOT/grails-bom-7.0.0-20241213.003552-182.pom can have the version removed.


Abstract the construction of view/viewermodel

Description
This ensures that we properly clean up QtViewers.
Some views were not being cleaned up properly, and thus exposed a bug where qtconsoles shared a kernel.  see the change on napari/_qt/qt_console.py
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)

How has this been tested?

[x] all tests pass with my change

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

🙌 thanks!  will look soon

looks like everything is passing now.  Will wait a day to see if any other @napari/core-devs have thoughts, and then merge

I'm going to merge this... I'd like to see if it fixes some of the other test issues we're having at the moment.  thanks @ttung


take_until_either! returns error when bytes aren't found

named!(xxx, take_until_either!("!."));

#[test]
fn test_take_until_either() {
    assert_eq!(
        xxx(&b"123"[..]),
        nom::IResult::Incomplete(nom::Needed::Unknown)
    );
}
//
//thread 'test_take_until_either' panicked at 'assertion failed: `(left == right)` (left: `Error(Position(14, [49, 50, 51]))`, right: `Incomplete(Unknown)`)'

I'd expect the result of the above to be Incomplete(Unknown) because it's unknown how much more must be read until any of the bytes are found. Is the error result correct?
Also compare this to take_until...
named!(xxx2, take_until!("end"));

#[test]
fn test_take_until() {
    assert_eq!(
        xxx2(&b"123"[..]),
        nom::IResult::Incomplete(nom::Needed::Unknown)
    );
}
//
//thread 'test_take_until' panicked at 'assertion failed: `(left == right)` (left: `Incomplete(Size(4))`, right: `Incomplete(Unknown)`)'

In that case, I think take_untilhas a bug, since it has enough characters to decide if there is its terminating byte array. The rationale here would be that you expect to encounter the terminators, otherwise the parser would be successful with partial data.
I have to admit, the whole take_until* functions do not really please me. They are confusing, and would be better replaced by explicit code using many0, terminated and other combinators.


Create lorenzo

Travis tests has failed
Hey RicciLorenzo,
Please read the following log in order to understand why the tests failed.
It'll be awesome if you fix what's wrong and commit the changes.
npm test
><EMAIL_ADDRESS>test /home/travis/build/bluzi/name-db
> mocha

  name files
    1) should contain valid JSON
    2) should contain a lowercase name, same as the filename
    3) should not have duplicate names
    4) should have ISO-639-3 language codes
    5) should have correct structure

  Translations
    6) should be lowercase

  Sex
    7) should be "m", "f" or "u"
    8) should be lowercase

  0 passing (139ms)
  8 failing

  1) name files
       should contain valid JSON:
     Error: Error in name file "lorenzo":
SyntaxError: Unexpected string in JSON at position 117
      at Context.it (test/test.js:16:23)

  2) name files
       should contain a lowercase name, same as the filename:
     SyntaxError: Unexpected string in JSON at position 117
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:24:31)

  3) name files
       should not have duplicate names:
     SyntaxError: Unexpected string in JSON at position 117
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:35:31)

  4) name files
       should have ISO-639-3 language codes:
     SyntaxError: Unexpected string in JSON at position 117
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:46:31)

  5) name files
       should have correct structure:
     Error: Error in name file "lorenzo":
SyntaxError: Unexpected string in JSON at position 117
      at Context.it (test/test.js:105:23)

  6) Translations
       should be lowercase:
     SyntaxError: Unexpected string in JSON at position 117
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:115:31)

  7) Sex
       should be "m", "f" or "u":
     SyntaxError: Unexpected string in JSON at position 117
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:134:31)

  8) Sex
       should be lowercase:
     SyntaxError: Unexpected string in JSON at position 117
      at JSON.parse (<anonymous>)
      at Context.it (test/test.js:147:31)

npm ERR! Test failed.  See above for more details.

Travis tests has failed
Hey RicciLorenzo,
Please read the following log in order to understand why the tests failed.
It'll be awesome if you fix what's wrong and commit the changes.
npm test


FileEntry - getFile error code 5 for files with : in filename on android

When calling getFile() we are getting an error if we want to open a file with a double point : in the name.
We tried:
var path = "sync/data/Wichtige Dokumente/Test:mehrseitiges PDF SO.pdf"
directoryEntry.getFile(path, {create: false}, ..);

or
var path = "sync%2Fdata%2FWichtige%20Dokumente%2FTest%3Amehrseitiges%20PDF%20SO.pdf";
directoryEntry.getFile getFile(path, {create: false}, ..);

but we always get the error code 5.
Any ideas?

Apparently you can't have : in filenames, see https://github.com/apache/cordova-plugin-file/issues/289#issuecomment-477954331
So it's probably the easiest to replace them with something else.
Why it is restricted like that, I don't know.


programmatically create apollo-compiler HIR

I guess this is actually the exact same as #593 but that one is all tagged up in the sprint planning etc. so will close this in favour of #593


🗺  Create Wardley map for Data Platform to provide clarity

User Story
As a Data Platform team member
I want to have a clear visual representation of the components that make up our Platform
So that we as a team have a common understanding of where are and where we are going
Value / Purpose
Clarity and Visualisation: Wardley maps provide a clear visual representation of the components of a system or business, making it easier for stakeholders to understand and communicate complex ideas. This visualization can help teams align on a common understanding of their environment.
Alignment: They can facilitate alignment within an organisation. When teams and individuals have a shared visual representation of the business landscape, it becomes easier to align their efforts towards common goals and objectives.
Continuous Improvement: Wardley maps encourage continuous improvement. As your business environment evolves, you can regularly update and refine your maps to reflect changes and adapt your strategy accordingly.
If we... [do a thing]
Then... [this will happen]
Proposal
We can draft the maps using Excalidraw and then decide to either commit or transfer to e.g. https://onlinewardleymaps.com/ and use the VScode extension to keep our maps updated.
Additional Information

Excalidraw template
Excalidraw board with canvas
Definition of Done

[ ] Wardley map created for AP --> DP
[ ] Wardley map for Data Protection @alex-vonfeldmann // TODO: create issue?

we are up to step 5

Wardley Map session 1 completed with miro here

Will add Pr to add to docs

On Friday went through Wardley with @tom-webber and @julialawrence
Moving these to the TechDocs


Basic support for Record & Tuple proposal

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (95f93d3) 80.64% compared to head (cc2b342) 80.81%.

Files
Patch %
Lines

src/Escalier.Data/Library.fs
66.66%
4 Missing :warning:

src/Escalier.TypeChecker/Infer.fs
87.50%
4 Missing :warning:

src/Escalier.Interop/Infer.fs
81.81%
2 Missing :warning:

src/Escalier.Codegen/Codegen.fs
66.66%
1 Missing :warning:

src/Escalier.TypeChecker/Unify.fs
97.67%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   80.64%   80.81%   +0.16%
==========================================
  Files          18       18
  Lines        5621     5702      +81
  Branches      706      718      +12
==========================================
+ Hits         4533     4608      +75
- Misses       1088     1094       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


IG DM NOT WORKING

the ig dm download is no longer working i have uninstalled it and installed it 3 times and it still doesnt work when i try to log in it says please try again in a couple of minutes i restarted my laptop and it still wouldnt let me log on for the past hour

@itszainebxo
Same, I'm getting this error message:


feat(typeorm): update driver to work with latest typeorm version

PR Checklist

[x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[ ] All existing tests are passing
[ ] Tests for the changes are included

What is the current behavior?

The plugin does not support the latest typeorm version and requires the user to install @nativescript-community/typeorm instead.
What is the new behavior?

Upstream typeorm is supported.

@mukaschultze looks awesome. Love it!
Thanks a lot for this !


Issue running automatic database schema migrations.

Running FROM flyio/litefs:0.2.0 AS litefs
Hi, so I'm trying to run automatic schema migrations with litefs in a fly.io project. The project has three regions/instances. I have a bash script that checks if the instance is the primary, and if it is, it runs the migration command:
#!/usr/bin/env bash

PRIMARY=$LITEFS_DIR/.primary
if [[ -f "$PRIMARY" ]]; then
    PRIMARYFILE=$(cat "$PRIMARY")

    if [[ $PRIMARYFILE == $HOSTNAME* ]]; then
    echo "This is the primary. Migrating."
    (npx prisma migrate deploy)
    else
    echo "Not Primary. Not Migrating."
    fi

else
    echo "No .primary file found. Migrating."
    (npx prisma migrate deploy)
fi

The problem is that when I deploy an update, the first two instances to get the update all report that they are not the primary (since that last one is), but then when the last instance gets the update it is no longer the primary and thus the migration never gets executed. What can I do to ensure the migration is ran?

@JulianBuse Good question. Currently, you'd need to run the migration out-of-band from the deployment to ensure it's on the primary. We do have write forwarding (https://github.com/superfly/litefs/issues/56) planned for v0.3.1 to make this easier so you can run a write transaction from any node—even if they're not the primary. You'll want to run most writes near the primary for performance reasons but it'd be fine to run infrequent migrations from any node.


Proposal: Javadoc-like documentation support for schema language

What
When developing a schema for SpiceDB, it would be helpful to have documentation strings attached to resources, permissions, and relations. In addition, parser tooling to parse the documentation strings and output them in a human-readable format, e.g. markdown that can be uploaded to GitHub. Another application of a parser would be to extend support for the schema language in VSCode by adding documentation popups when hovering over a symbol. Here's a similar example using a Go project:

An example of such documentation (using a pseudo-code derivative of javadoc) might look like:
/**
 * An authenticated user.
 */
definition user {}

/**
 * A document resource.
 */
definition document {
  /**
   * Reader relationship for a document.
   *
   * @types user
   */
  relation reader: user
}

Why
This is clearly a trivial example which doesn't benefit from documentation of this nature, but as schemas become more complex, having something to auto-generate documentation becomes increasingly useful. This is especially so when schemas begin introduce resource definitions/relations that don't have a one-to-one mapping to domain models and relationships.
How
Many languages have some sort of structured documentation string that can be parsed and generate formal documentation, but there are no language agnostic tools to do such a task. Two possible solutions are proposed here, though other solutions do exist!
ReStructuredText
The ReStructuredText format defines markdown style of documentation string which has some parsers in a variety of languages (though no active Go projects):

Rust - https://github.com/flying-sheep/rust-rst
Python - https://pypi.org/project/docutils/
PHP - https://github.com/doctrine/rst-parser

Custom format
In the absence of standard, general-purpose tooling to parse documentation strings, it becomes viable (even necessary) to define a custom format and parser. See the above section for an example custom format.

The SpiceDB schema parser already consumes and stores comment information as part of the parsing processing: https://github.com/authzed/spicedb/blob/main/pkg/schemadsl/dslshape/dslshape.go#L13.
It is placed into the parsed namespace protocol buffers as metadata: https://github.com/authzed/spicedb/blob/main/proto/internal/impl/v1/impl.proto#L25
The comment format is exactly as displayed above: // for single line and /* for multiline. We also, already, recommend using /** for doc comments, as shown in examples:
    /**
     * writer indicates that the user is a writer on the document.
     */
    relation writer: user

Therefore, it should be (fairly) straightforward to add a new command to, say, zed to generate documentation off of an input schema file; could likely be done with no code changes to SpiceDB.

Awesome, so this should be fairly straightforward then! I think there's a variety of ways the parsed document could be rendered.
Probably the most powerful (and complex) way would be to render HTML. This would allow people to host docs as static sites and customize the appearance of the documentation via CSS. Some examples of documentation generation frameworks that output HTML (among other formats) are

Doxygen (example)
Sphinx (example)
Javadoc (example)

However, an easier approach would be to export the docs as markdown. This means the files could be uploaded to GitHub and rendered as part of a repository's documentation. Consider the following schema
/**
 * A user resource.
 */
definition user {}

/**
 * A team resource.
 */
definition team {
    /**
     * A child relationship. Indicates this team has child teams.
     */
    relation child: team

    /**
     * A member relationship.
     */
    relation member: user

    /**
     * A membership permission. True if a user is directly a member to this team
     * or a member of child teams.
     */
    permission membership = member + child->membership
}

This could be rendered in markdown as such

Definitions
user
A user resource.
Relations
None
Permissions
None
team
A team resource.
Relations
child
relation child: team

A child relationship. Indicates this team has child teams.
member
relation member: user

A member relationship.
Permissions
membership
permission membership = member + child->membership

A membership permission. True if a user is directly a member to this team or a member of child teams.

This is only a suggested markdown rendering. Perhaps there could be a more useful structure that includes a table of contents, links between definitions that reference each other, inline example usages, etc.


Problem statement review

My problem statement document is located in docs/ProblemStatement/ProblemStatement.pdf (or tex). Please let me know if I should be raising this issue on the cas741 gitlab webpage instead. Instructions state to chose the group's repository. I wasn't quite sure if that was the course repo or not (no one else seems to have made an issue there for their problem statements).
Thanks,
Jen

This is the right place for your issue.  I'll have a look at your problem statement soon.

@PeaWagon you commented out %\input{../Comments} from your Proposal.tex file.  Can you please uncomment it and add the Comments.tex file under version control.  That way I can add comments directly to your tex file.

Some comments on your proposal:

what is a smiles string?
rather than say evolutionary algorithm, it would be better to be more abstract.  You are doing an optimization, so you should say that.  You can still list the example of an evolutionary algorithm, but you don't want to lock yourself into that too early
will people outside of your research group be able to run your software?  I'm specifically wondering about me and, to some extent, your classmates.  Specific concerns follow:

Can there be a serial version, or will running it require parallel computation?
What if Vetee isn't working in time for this course?
Who has access to Gaussian?
Will your software be difficult to install, compile?

Okay so I should have covered most of these questions in the problem statement. More specifically:
SMILES = Simplified molecular-input line-entry system
Parallelization would be a nice feature to add, but it is not a priority. I expect to write serial code first.
Vetee and Gaussian will not be necessary for the project to work, I just need to leave places where they can be easily connected for later. I will need a way to evaluate molecular energies - there should be a few open-source packages for this purpose. Gaussian can compute the energies; it is accessible to anyone who has a Compute Canada/Sharcnet account, but purchasing a personal license is very expensive. I will leave the choice of energy computation up to the user.
I will try to make the project into an anaconda package - it can also be fairly easily installed using pip (development option -e).

Thank you for the clarification @PeaWagon.  I can see that you added SMILES in e5e856f16e6b200574ae0d1c8baad1a657970f82.  In the future, it helps if you link to the commit that closes the issue.
I approve your problem statement, and by extension ,  your project.


Images in Word don't convert to PDF

E.g. figure 1 here: https://www.dropbox.com/s/xwcy8i5mrpskyzm/anno-rep-testing_paper.docx?dl=1

I replace the old converter with OpenOffice. This has to be installed separately, but once installed the JODC library I found will invoke it automatically to do the conversion. This change appears to fix this issue and the others related to docx to pdf conversion.

This doesn't appear to work in the test doc I sent you today (Figure 1, p. 35) -- it's no big deal if we can't get it to work, but if there's a toggle we can switch, it'd be nice.

OK, I tested again and this works, including caption. It doesn't work for charts embeded in Word docs, but I think we can skip those


Support weird characters in secret

'binary' is not the right encoding for such characters in the secret. Using the default 'utf8' encoding solves the issue.

@eeror could you please review this PR? Also, feel free to create issues / PRs for anything else you would like to see added to this library.

@RaisinTen Sure. I went and checked what the original library does and tested with a solid set of inputs.
The only difference I found right now is that if you have a lone surrogate in a string, CryptoJS crashes whereas your function replaces it with U+FFFD.
I would say that this is fine for a replacement library as long as you document this. I hope nobody actually depends on CryptoJS crashing instead of providing a result. :)


Both cookies and javascript enabled to login?

Hi there,
I have problems logging into website which requires cookies and javascript enabled.
Check the screenshot below
http://i.imgur.com/dl5wFzl.jpg
Here's my code
import time
import dryscrape

username = '123456'
password = 'mypassword'

# setup a web scraping session
sess = dryscrape.Session(base_url = 'https://www.somewebsitedomain.com/Pages/Login/Login.aspx

# we don't need images
sess.set_attribute('auto_load_images', False)

# visit homepage and log in
print "Logging in..."
sess.visit('/')

username_field = sess.at_css("#txtCustomer")
password_field = sess.at_css("#passwd")
btnlogin_field = sess.at_css("#btnLogin")

username_field.set(username)
password_field.set(password)

# username_field.form().submit() is not working here
# btnlogin_field.form().submit() can't work either

btnlogin_field.click() # this works, but see the issue which requires cookies and javascript enabled

print "Taking snapshot"
sess.render('website.png')

Is there any way to make this worked? I have tested on python selenium firefox and it worked. BUt again I need to run this on server basis. Thus python selenium phantomjs will see the same issue here. I was thinking whether your solution could help.
I need to run this script from an ubuntu 14.04 LTS server (not desktop).
Any help? Thanks.

Hi,
from your code alone it's not apparent what the problem is. dryscrape
supports both Javascript and Cookies. Maybe the website uses an unusal
authentication mechanism such as locale storage which dryscrape does not
support?
Also, you should probably wait for some UI change after logging in,
otherwise you will just get a screenshot of the login form.
Best, Niklas
On Wed, May 20, 2015 at 11:19 AM, ericmachine88<EMAIL_ADDRESS>wrote:

Hi there,
I have problems logging into website which requires cookies and javascript
enabled.
Check the screenshot below
http://i.imgur.com/dl5wFzl.jpg
Here's my code
import time
import dryscrape
username = '123456'
password = 'mypassword'
setup a web scraping session
sess = dryscrape.Session(base_url = 'https://www.somewebsitedomain.com/Pages/Login/Login.aspx
we don't need images
sess.set_attribute('auto_load_images', False)
visit homepage and log in
print "Logging in..."
sess.visit('/')
username_field = sess.at_css("#txtCustomer")
password_field = sess.at_css("#passwd")
btnlogin_field = sess.at_css("#btnLogin")
username_field.set(username)
password_field.set(password)
username_field.form().submit() is not working here
btnlogin_field.form().submit() can't work either
btnlogin_field.click() # this works, but see the issue which requires cookies and javascript enabled
print "Taking snapshot"
sess.render('website.png')
Is there any way to make this worked? I have tested on python selenium
firefox and it worked. BUt again I need to run this on server basis. Thus
python selenium phantomjs will see the same issue here. I was thinking
whether your solution could help.
I need to run this script from an ubuntu 14.04 LTS server (not desktop).
Any help? Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/niklasb/dryscrape/issues/30.

--
Viele Grüße,
Niklas

Hi Niklas,
Thanks for coming back.
What can I do to code the "waiting" part? Any tips?
For database, I believe they are using SQL Server since it's on asp.net platform.
Any help? Thanks.

I'm not talking about server-side database technology. I was referring to what client-side mechanisms the web page uses for authentication. Maybe it's not just cookies, maybe it's local storage or something else entirely.
As for waiting, you can use the methods defined in WaitMixin to wait for DOM elements.

Anyway I have figured out a way to make this work via selenium firefox.
http://scraping.pro/use-headless-firefox-scraping-linux/
Thanks anyway :)


Default producer buffer_size and support configuring it

Updates the producer to default to an infinite buffer size to prevent discarding messages under load.
This can be configured via the pool config and set to any positive integer like so.
{FaktoryWorker, pool: [buffer_size: 20_000], workers: [..]}

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #45   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          23     23
  Lines         289    291    +2
=====================================
+ Hits          289    291    +2

Impacted Files
Coverage Δ

lib/faktory_worker/push_pipeline.ex
100% <ø> (ø)
:arrow_up:

lib/faktory_worker/push_pipeline/producer.ex
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73df82e...4dafabe. Read the comment docs.


Can I pass props like onClick to styled components?

I tried to create a Wrapper component like so:
const Wrapper = styled("div")`
  border-radius: 20px;
  padding: 30px;
  display: flex;
  flex-direction: column;
  align-items: flex-start;
  box-shadow: inset 0px 0px 0px 2px var(--color-grey);
  &:hover {
    box-shadow: inset 0px 0px 0px 2px black;
  }
  &:focus {
    box-shadow: inset 0px 0px 0px 2px black;
  }
  p {
    color: gray;
  }

Doesn't really matter what's inside the style. Then I tried to use Wrapper but also pass in custom onClick.
  setSelectedOption,
}: Props) {
  return (
    <Wrapper onClick={() => setSelectedOption(title)}>

This doesn't actually work.setSelectedOption never gets run. If I instead of Wrapper have normal div there, it does work.

Actually it started working for me, not sure what I was doing wrong but no longer an issue for me. 🎊

I had the same problem. In my particular case, the styled component was being created in the end of the file (using const). When I moved it to before where it was used, it worked correctly.


Add a datacenter view to access information about the Sensu servers

Description
We add a new datacenter view, accessible from the datacenters view, in order to access new information about the Sensu servers available since Sensu 0.28.
The Datacenter structure exposed in the /datacenters endpoint has been modified; the Stats attribute is now called Metrics.
We also add additional debug information when Sensu API does not respond properly.
Related Issue
Fixes https://github.com/sensu/uchiwa/issues/652
Depends on https://github.com/sensu/uchiwa-web/pull/145
Motivation and Context
Display Sensu servers information
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #660 into master will decrease coverage by 0.39%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #660     +/-   ##
=========================================
- Coverage   22.48%   22.08%   -0.4%
=========================================
  Files          26       27      +1
  Lines        2135     2173     +38
=========================================
  Hits          480      480
- Misses       1598     1636     +38
  Partials       57       57

Impacted Files
Coverage Δ

uchiwa/daemon/daemon.go
13.22% <0%> (-0.82%)
:arrow_down:

uchiwa/datacenter.go
0% <0%> (ø)

uchiwa/server.go
0% <0%> (ø)
:arrow_up:

uchiwa/daemon/datacenters.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 240a184...0ed1264. Read the comment docs.


bug: fix object rendering in helm doc

See https://github.com/Mellanox/network-operator/pull/1064

Before:

After:


Fix SMPTE 291 exactframerate field

Unit tests + basically same fix for #344 as proposed by @cmaberto in #345.

New unit tests found another simple bug so I've fixed that too 🤦♂

@jonathan-r-thorpe I believe this is now failing just because #351 isn't merged yet... so I guess the proper procedure is to merge #351 into master, then merge master into this PR branch, check the CI results and then merge this to master. Sigh.

Verified with the updated SDPoker. LGTM


ATS 9 NetHandler lock abort

#0  0x00002ad64a0e7207 in raise () from /lib64/libc.so.6
#0  0x00002ad64a0e7207 in raise () from /lib64/libc.so.6
#1  0x00002ad64a0e88f8 in abort () from /lib64/libc.so.6
#2  0x00002ad64765162b in ink_abort (message_format=message_format@entry=0x2ad6476bae47 "%s:%d: failed assertion `%s`") at ink_error.cc:99
#3  0x00002ad64764ede5 in _ink_assert (expression=expression@entry=0x795e88 "!\"BUG: It must have acquired the NetHandler's lock before doing anything on active_queue.\"", file=file@entry=0x795be0 "UnixNetVConnection.cc", line=line@entry=1471) at ink_assert.cc:37
#4  0x00000000006f4c49 in UnixNetVConnection::add_to_active_queue() () at UnixNetVConnection.cc:1471
#5  0x00000000005bda7c in Http2ConnectionState::create_stream (this=this@entry=0x2ada648ba148, new_id=new_id@entry=497, error=...) at Http2ClientSession.h:191
#6  0x00000000005bea41 in rcv_headers_frame(Http2ConnectionState&, Http2Frame const&) () at Http2ConnectionState.cc:235
#7  0x00000000005c0cd9 in Http2ConnectionState::main_event_handler(int, void*) () at Http2ClientSession.h:95
#8  0x00000000005b5e81 in handleEvent (data=0x2ad651efd3e0, event=2253, this=0x2ada648ba148) at //build_release_posix-x86_64_gcc_8/trafficserver9/iocore/eventsystem/I_Continuation.h:190
#9  handleEvent (data=0x2ad651efd3e0, event=2253, this=0x2ada648ba148) at //build_release_posix-x86_64_gcc_8/trafficserver9/iocore/eventsystem/I_Continuation.h:186
#10 send_connection_event(Continuation*, int, void*) () at Http2ClientSession.cc:65
#11 0x00000000005b6a75 in Http2ClientSession::do_complete_frame_read() () at Http2ClientSession.cc:556
#12 0x00000000005b6edd in Http2ClientSession::state_process_frame_read(int, VIO*, bool) () at Http2ClientSession.cc:610
#13 0x00000000005b7671 in Http2ClientSession::state_start_frame_read (this=0x2ada648b9e00, event=100, edata=0x2ad8d8e0ddd0) at Http2ClientSession.cc:477
#14 0x00000000005b5fe7 in Http2ClientSession::main_event_handler (this=0x2ada648b9e00, event=2257, edata=0x2ad7bd591240) at Http2ClientSession.cc:363
#15 0x0000000000736bfb in handleEvent (data=0x2ad7bd591240, event=2257, this=0x2ada648b9e00) at I_Continuation.h:190
#16 handleEvent (data=0x2ad7bd591240, event=2257, this=0x2ada648b9e00) at I_Continuation.h:186
#17 EThread::process_event(Event*, int) () at UnixEThread.cc:136
#18 0x0000000000737abc in EThread::execute_regular (this=this@entry=0x2ad64d7ddbc0) at UnixEThread.cc:249
#19 0x0000000000737eaa in execute (this=0x2ad64d7ddbc0) at UnixEThread.cc:338
#20 EThread::execute (this=0x2ad64d7ddbc0) at UnixEThread.cc:316
#21 0x0000000000736309 in spawn_thread_internal (a=0x2ad64c193e00) at Thread.cc:92
#22 0x00002ad649479dd5 in start_thread () from /lib64/libpthread.so.0
#23 0x00002ad64a1aeead in clone () from /lib64/libc.so.6

The problem why I am seeing this crash is because of global session pool thread migration.  Here is the coredump after making the ProxyMutex have a thread affinity and core if some other thread tries to grab the lock:
#0  0x00002b95fd320207 in raise () from /lib64/libc.so.6
#0  0x00002b95fd320207 in raise () from /lib64/libc.so.6
#1  0x00002b95fd3218f8 in abort () from /lib64/libc.so.6
#2  0x00002b95fa88a62b in ink_abort (message_format=message_format@entry=0x2b95fa8f3e47 "%s:%d: failed assertion `%s`") at ink_error.cc:99
#3  0x00002b95fa887de5 in _ink_assert (expression=expression@entry=0x73d780 "t == m->getThreadAffinity()", file=file@entry=0x73d8e0 "/sd/workspace/src/git.ouroath.com/Edge/build/_build/build_release_posix-x86_64_gcc_8/trafficserver9/iocore/eventsystem/I_Lock.h", line=line@entry=252) at ink_assert.cc:37
#4  0x00000000006fb279 in Mutex_trylock (t=0x2b9600800f00, m=...) at /sd/workspace/src/git.ouroath.com/Edge/build/_build/build_release_posix-x86_64_gcc_8/trafficserver9/iocore/eventsystem/I_ThreadAffinity.h:43
#5  MutexTryLock (t=0x2b9600800f00, am=..., this=0x2b9603202010) at /sd/workspace/src/git.ouroath.com/Edge/build/_build/build_release_posix-x86_64_gcc_8/trafficserver9/iocore/eventsystem/I_Lock.h:399
#6  UnixNetVConnection::migrateToCurrentThread(Continuation*, EThread*) () at UnixNetVConnection.cc:1378
#7  0x0000000000553798 in HttpSessionManager::acquire_session(Continuation*, sockaddr const*, char const*, ProxyTransaction*, HttpSM*) () at HttpSessionManager.cc:342
#8  0x000000000054787d in HttpSM::do_http_server_open(bool) () at HttpSM.cc:4814
#9  0x000000000054a228 in HttpSM::set_next_state (this=0x2b978bd40000) at HttpSM.cc:7318
#10 0x000000000053400f in HttpSM::call_transact_and_set_next_state (this=this@entry=0x2b978bd40000, f=f@entry=0x0) at HttpSM.cc:7116
#11 0x00000000005364d4 in HttpSM::state_cache_open_write (this=0x2b978bd40000, event=1109, data=0xffffffffffffb04f) at HttpSM.cc:2455
#12 0x0000000000541e63 in main_handler (data=0xffffffffffffb04f, event=1109, this=0x2b978bd40000) at HttpSM.cc:2568
#13 HttpSM::main_handler (this=0x2b978bd40000, event=1109, data=0xffffffffffffb04f) at HttpSM.cc:2538
#14 0x000000000058f425 in handleEvent (data=0xffffffffffffb04f, event=1109, this=0x2b978bd40000) at /sd/workspace/src/git.ouroath.com/Edge/build/_build/build_release_posix-x86_64_gcc_8/trafficserver9/iocore/eventsystem/I_Continuation.h:167
#15 handleEvent (data=0xffffffffffffb04f, event=1109, this=0x2b978bd40000) at /sd/workspace/src/git.ouroath.com/Edge/build/_build/build_release_posix-x86_64_gcc_8/trafficserver9/iocore/eventsystem/I_Continuation.h:163
#16 HttpCacheSM::open_write (this=this@entry=0x2b978bd41d60, key=key@entry=0x2b978bd41e20, url=<optimized out>, request=<optimized out>, old_info=<optimized out>, pin_in_cache=<optimized out>, retry=true, allow_multiple=false) at HttpCacheSM.cc:322
#17 0x000000000058f5e3 in HttpCacheSM::state_cache_open_write (this=0x2b978bd41d60, event=2, data=0x2b977d1a1440) at HttpCacheSM.cc:199
#18 0x0000000000737963 in handleEvent (data=0x2b977d1a1440, event=2, this=0x2b978bd41d60) at I_Continuation.h:167
#19 handleEvent (data=0x2b977d1a1440, event=2, this=0x2b978bd41d60) at I_Continuation.h:163
#20 EThread::process_event(Event*, int) () at UnixEThread.cc:136
#21 0x000000000073886c in EThread::execute_regular (this=this@entry=0x2b9600800f00) at UnixEThread.cc:249
#22 0x0000000000738ca6 in execute (this=0x2b9600800f00) at UnixEThread.cc:338
#23 EThread::execute (this=0x2b9600800f00) at UnixEThread.cc:316
#24 0x0000000000736f19 in spawn_thread_internal (a=0x2b95ff393c80) at Thread.cc:92
#25 0x00002b95fc6b2dd5 in start_thread () from /lib64/libpthread.so.0
#26 0x00002b95fd3e7ead in clone () from /lib64/libc.so.6

The grabbing of the net handler thread was logic added by @oknet to try to preserve the existing netvc object and simply move it to another thread.  At this point the logic is holding (briefly) the mutex for the nethandlers of two threads.
The original logic always created new netvc objects on the target thread and moved the key information over (fd and ssl object).

I've been running with logic that reverts the logic that tries to preserve the existing netvc object, and that has been running without incident.  In that logic, the migration thread does not need to grab the other thread's net handler lock.  The epoll call to remove the file descriptor from the original thread's epoll descriptor is thread save.  Then do_io_close only sets the close flag on the netvc if the netvc is not associated with the current thread.  The next time through the inactivity cop on the original thread will free the netvc objects with the close flag set.

1377   // Try to get the mutex lock for NetHandler of this NetVC
1378   MUTEX_TRY_LOCK(lock_src, this->nh->mutex, t);

The this->nh is running at another EThread, the the nh->mutex has thread affinity for another EThread.
The line 1378 of UnixNetVConnection.cc just do one thing: try lock a ProxyMutex across EThread, it is a common operation.

Resolved.


List extensions in docs, and add some helpful exports

Description
Export ALL_GENERIC_EXTENSIONS, ALL_MARK_EXTENSIONS, ALL_NODE_EXTENSIONS, and ALL_EXTENSIONS from @remirror/core-extensions. Tests the lengths of these arrays. Adds documentation for links.
Checklist

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project and yarn fix runs successfully.
[x] I have updated the documentation where necessary.
[x] New code is unit tested and all current tests pass when running yarn test .

Screenshot
Docs page:

@charlex I'm liking how you've structured this PR. It has tests, docs, and the code is nice and clean. I could learn a thing or two, especially, regarding writing docs for new functionality.
Some thoughts
After thinking a bit more into the benefits of this new code I'm not sure it's enough to justify the addition to remirror.
There are currently two ways of creating a RemirrorEditor.
Method 1 - Use React
My preferred, but by no means required way, is to use a react tree for configuration.
const EditorLayout: FunctionComponent = () => {
  return (
    <RemirrorManager>
      <RemirrorExtension Constructor={Bold} priority={1} />
      <RemirrorExtension Constructor={Italic} />
      <RemirrorExtension Constructor={Underline} />
      <ManagedRemirrorProvider
        attributes={{ 'data-testid': 'editor-instance' }}
        onChange={onChange}
        placeholder='Start typing for magic...'
        autoFocus={true}
        initialContent={EMPTY_PARAGRAPH_NODE}
      >
        <InnerEditor />
      </ManagedRemirrorProvider>
    </RemirrorManager>
  );
};

As you can imagine the lists of extensions doesn't really help much when configuring with this method.
Method 2 - Create your manager
Another way of configuring is via creating our own manager.
const manager = ExtensionManager.create([
  ...baseExtensions,
  new CodeBlockExtension(),
  { extension: new PlaceholderExtension(), priority: 2 },
]);

const EditorLayout: FunctionComponent = () => {
  const onChange = () => console.log('I am magical 🧚🏾♀');

  return (
    <RemirrorProvider
      manager={manager}
      attributes={{ 'data-testid': 'editor-instance' }}
      onChange={onChange}
      placeholder='Start typing for magic...'
      autoFocus={true}
      initialContent={EMPTY_PARAGRAPH_NODE}
    >
      <InnerEditor />
    </RemirrorProvider>
  );
};

In this case, yes, a list of extensions can be used quite easily but it does come with caveats. The order of extension is important and affects which functionality takes priority, this is why there is a priority prop when creating the manager. The lower the number the more important the extension 😋
It would be really difficult to create a list (as a part of the library) that captures order in a meaningful way for all possible users.
Possible changes
A list could be useful for classifying extensions. However, right now each extension has a property with its type and we in the ExtensionManager this is frequently used to identify Node, Mark and Plain extensions.
I'd be open to adding a new property on ExtensionManager.data which keeps a record of the extension types. Something with the following shape
import { NodeExtension, Extension, MarkExtension } from '@remirror/core';

type ExtensionNameMap<GExtension extends AnyExtension> = {
  [name: string]: GExtension;
};

interface ExtensionRecord {
  node: ExtensionNameMap<NodeExtension>;
  mark: ExtensionNameMap<MarkExtension>;
  plain: ExtensionNameMap<Extension>;
}

I'd love to hear your thoughts 👍

@ifiokjr Thanks so much for the thoughtful feedback! Tell you the truth, I didn't have a ton of value myself in consuming these new arrays, so I removed it from the PR to reflect my intent, and your feedback.
I'm not totally sure what you mean when you refer to putting a property on ExtensionManager.data.  Would this map just the extensions loaded? Or would it map all extensions?

@charlex I'm happy to merge the new code once the lint issue is fixed.
If you take a look at the failing pipeline it's failing when checking the formatting of the edited file docs/guides/terms/extension.mdx.
A quick fix would be to run yarn fix from the root of the repository. It will auto fix all prettier issues.

Once you've done that I'll merge 👍
Regarding the proposed property on ExtensionManager.data I didn't really explain myself well. I was referring to the data that is initialized in the extension manager and wondering if it would be worthwhile adding a new property which held information on the extensions currently being used.
https://github.com/ifiokjr/remirror/blob/98cdbbd306195852ba0cf689d88668b9a4106e7c/%40remirror/core/src/extension-manager.ts#L148-L181
We can ignore this for now though 😄


Inconsistency between blockchain values displayed inside the Peers and Blockchain tabs

I see that under peers we are displaying the slot no  but under blockchain we are displaying epoch/slot and block no
I think it would be useful (and consistent) to display values that could be easily comparable (in order to easily spot discrepancies), what do you think? One option could be to add the slot no also into the blockchain tab

Unfortunately, the number in Peers tab is taken from another metric than numbers in Blockchain tab. And that metric (which is used for Peers tab) contains only slot number. This is the limitation in the structure in ouroboros-network, so I only can display this number as it is.


introducing rank

Introducing rank - we will start peeling of pieces to get it into the general stack arrangement.

It's quite fresh and we have it over in https://github.com/wellcomecollection/rank

@jamesgorrie can you archive (with a deprecation message pointing here) or delete  https://github.com/wellcomecollection/rank?

Yup, was on the list ♻


Gosmee pod reports such error "No help topic for ..."

Issue
When we deploy gosemee-client as a pod
k get -n pipelines-as-code deployment/gosmee-client -o yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: gosmee-client
  namespace: pipelines-as-code
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app: gosmee-client
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: gosmee-client
    spec:
      containers:
      - args:
        - https://smee.io/upi-0.apps.mystone.lab.upshift.rdu2.redhat.com
        - $(SVC)
        env:
        - name: SVC
          value: https://pipelines-as-code-controller-pipelines-as-code.apps.mystone.lab.upshift.rdu2.redhat.com/
        image: ghcr.io/chmouel/gosmee:main
        imagePullPolicy: IfNotPresent
        name: gosmee-client
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 30

then the log reports
No help topic for 'https://smee.io/upi-0.apps.mystone.lab.upshift.rdu2.redhat.com'

you are missing the client as first argument,
you can use the template from here as example https://github.com/chmouel/gosmee/blob/main/misc/kubernetes-deployment.yaml


Feature request: Support for Optional[List[Link]] relation

Feature request
Thank you for all of the great work on Beanie @roman-right! I would like to make a feature request. It would be helpful to extend the supported relationship patterns to include:
Optional[List[Link[...]]

Per the docs the currently supported patterns are:

Link[...]
Optional[Link[...]]
List[Link[...]]

Related issues

#220

+1
This feature would be helpful for situations where the parent object is created separately from the process to add/remove items to it.  For example, a "group" model that links to a list of "users".  It is valid for a group to exist and be empty.

Hi!
Thank you for the suggestion.
I'll add this soon.

@roman-right When will this feature be added?
I'm using it like this right now, would that be a problem? perm:List[Link[Permission]]  = []

@roman-right When will this feature be added?
I'm using it like this right now, would that be a problem? perm:List[Link[Permission]] = []

I think you will want to use the Field class like this:
from pydantic import Field

perm:List[Link[Permission]] = Field(default_factory=list)


update en and zh-CN translation

minor edit on en
major edit on zh_CN translation
match en & zh_CN strings order

todos (no plan this week):

standardized phrase like seed phrase and private seed phrase
other checks

local build passed on official metamask/metamask-extension main branch
local build failed on fork branch from mg/metamask-extension main branch......


Segmentation fault on linux

Segmentation fault

🤷🏽♂ Current Behaviour

Stopped working.
🎯 Expected Behaviour

It was working before but not now.
👟 Steps to Reproduce (S2R)

Install
Doesn't run.

🏡 Environmental Context

App Version
4.0.4
Installation Type
Arch Linux AUR
Operating System
Linux - Arch Linux x64

Terminal output:
desktop-dimmer
Gtk-Message: 06:45:22.580: Failed to load module "appmenu-gtk-module"
[1]    4027 segmentation fault (core dumped)  desktop-dimmer

I have the same problem, but it has not worked since the time I installed
desktop-dimmer-4.0.4-amd64.deb
OS: Zorin OS 17.1 x86_64
DE: GNOME 43.9


[Feat] ADD TRANSLATOR FEATURE

Description
ADD A TRANSLATOR IN THE WEBSITE TO MAKE THE USER EXPERIENCE GOOD IT WILL BE HELPFUL FOR THE PEOPLE WHO ARE MORE COMFORTABLE TO THEIR NATIVE LANGUAGES

I can work on this
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@HS202022 You have raised a duplicate issue; it was already raised by someone else.

Look at all the issues, see which ones are available and which ones are not, and create issues accordingly.

This is not the way to work on open source :)

Actually, I need to reach a total of 128 stars to get the Starstruck x2 badge achievement on my GitHub. Can you please help by Star our repository? ⭐


Helm chart linting - pick target branch

Should fix #4176
On master to take effect.

What is the idea now with this change? Will it ignore changes made in other branches? I think in general it made sense that the linting complained about the versions as we bumped the defect dojo version.

Read the code again, is it now only raising an error if the chart was actually changed in a pr?

Read the code again, is it now only raising an error if the chart was actually changed in a pr?

Right.
An actual pull request made from a release branch to master for example triggers a push event hence the else part.

By default, target_branch was always there, but implicitly always against master.


[CS] Better handle null in BuilderClosureRewriter

There were a couple of places where we weren't handling a nullptr return from one of the visitor methods. Change the methods to return NullablePtr and add the missing null checks.
rdar://81228221

@swift-ci please test


Chevy Tahoe 2018, pi 0 works

Read an article on beebom showing how to make a wireless android auto dongle with a pi. I had a spare pi 0 laying around, downloaded your image and followed the directions. Had a connection issue at first but got it working. This saved me from having to buy a wireless dongle from amazon. Donated to the project.
Seems to work fine on chevy tahoe 2018 head unit with a pi 0. Still need to test more but so far so good.
(not an issue, just saying it works)

Glad that this project helped! And thanks a lot for the sponsorship, it helps!


Small changes to handle battery heating

added is_battery_heating to OtaChrgMangDataResp
set ptcHeatReq to 2 to turn off battery heating (tested on MG4 2022)

Thank you @magior for your contribution. I am still hesitating a bit with the merging since I am not sure about values for disabling and enabling of the battery heating.
The current implementation is:

0: deactivate battery heating
1: activate battery heating

I have to admit that I didn't test it on my ZS yet.
On your MG4 2022 it should be

1: activate battery heating
2: deactivate battery heating

@nanomad do you have experience with the values for activating battery heating?

I double-checked my value for MG4 with the native app (since it's difficult to understand if the battery is heating for real).
@tosate, on your ZS, when inactive, which value you read on bmsPTCHeatResp? If you read different values, we need to change behavior on a per-vehicle basis.
On MG4, to test it, the battery has to be under 7/8 degrees.

This is how my charge state response looks like:
{
  "applicationData": {
    "bmsReserCtrlDspCmd": 2,
    "bmsReserStHourDspCmd": 10,
    "bmsReserStMintueDspCmd": 0,
    "bmsReserSpHourDspCmd": 15,
    "bmsReserSpMintueDspCmd": 0,
    "bmsOnBdChrgTrgtSOCDspCmd": 7,
    "bmsEstdElecRng": 249,
    "bmsAltngChrgCrntDspCmd": 0,
    "bmsChrgCtrlDspCmd": 2,
    "chrgngRmnngTime": 1023,
    "chrgngRmnngTimeV": 1,
    "bmsChrgOtptCrntReq": 1023,
    "bmsPackCrnt": 20000,
    "bmsPackVol": 1599,
    "bmsPackSOCDsp": 610,
    "bmsChrgSts": 5,
    "bmsChrgSpRsn": 0,
    "clstrElecRngToEPT": 149,
    "bmsPTCHeatReqDspCmd": 0,
    "chargeStatus": {
      "realtimePower": 442,
      "chargingGunState": true,
      "fuelRangeElec": 1490,
      "chargingType": 1,
      "mileage": xxxxx,
      "startTime":<PHONE_NUMBER>,
      "endTime":<PHONE_NUMBER>,
      "workingCurrent": 20000,
      "workingVoltage": 1599,
      "mileageSinceLastCharge": 0,
      "powerUsageSinceLastCharge": 299,
      "mileageOfDay": 0,
      "powerUsageOfDay": 898,
      "chargingDuration": 0,
      "lastChargeEndingPower": 742,
      "totalBatteryCapacity": 725
    },
    "bmsAdpPubChrgSttnDspCmd": 1,
    "bmsPTCHeatSpRsn": 0
  },
  "body": {
    "applicationID": "516",
    "eventCreationTime":<PHONE_NUMBER>,
    "messageID": 6,
    "applicationDataLength": 71,
    "applicationDataProtocolVersion": 768,
    "uid": "00000000000000000000000000000000000010000000057133",
    "token": "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXXXXXX",
    "vin": "LSJXXXXXXXXXXXXXX",
    "eventID": 537282789,
    "ackRequired": false,
    "applicationDataEncoding": "perUnaligned",
    "testFlag": 2,
    "result": 0,
    "ulMessageCounter": 0,
    "dlMessageCounter": 1,
    "ackMessageCounter": 0
  },
  "header": {
    "protocolVersion": 48,
    "dispatcherMessageLength": 123,
    "dispatcherBodyEncoding": 0
  }
}

I don't even get the optional field bmsPTCHeatResp. In the native app I cannot simply switch on battery heating. I can only schedule the heating for a certain time.

Sorry, my mistake. You have bmsPTCHeatReqDspCmd with 0 as the value.
On MG4, I receive 2 as a value when the battery heating is off and 1 when it is on, and I need to use the same values to turn the heater on and off.
It seems that we have to handle the vehicle type. Could you do some tests on your ZS to verify if it can control the instant turn-on of the battery heater and check the value of the response?


Checking if the linked list is palindrome or not using stacks in C++

💥 Proposal
I would like to add the code for checking if the linked list is palindrome or not using stacks in C++. I am a GSSOC participant. Please /assign this issue to me.
Have you read the Contributing Guidelines on Pull Requests?
Yes

Fixed


Duplicate modules via different ways of import causing instanceof confusion.

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
webpack2 causes this bug in redux-form. I think the reason is two copies of SubmissionError classes are created and can be referenced separately, causing instanceof confusions.
If the current behavior is a bug, please provide the steps to reproduce.
Please see the error demonstration here:
https://github.com/aq1018/webpack2-redux-form-submission-error-weirdness

What is the expected behavior?
instanceof should return true from instance of classes imported from either import methods.
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.

redux-form/es/SubmissionError and redux-form/lib/SubmissionError are different modules.

@sokra Thanks for looking into this. Just realized that webpack loads from es as indicated by the module main field. I changed the demo code mentioned above to import from es, and the error is no longer there.
But I think there is a different bug in my code that is not captured in my demo code above. Somehow, in my code, I used import { SubmissionError } from 'redux-form' and throw new SubmissionError(...), but somehow in side redux code, submitError instanceof SubmissionError always returns false. I was able to confirm this by adding a console.log line in my node_modules/redux-form/lib/handleSubmit. Note, I instrumented lib modules. Instrumenting es modules yielded no effect. This leads me to think that webpack is loading from lib instead of es in my code.
I added a gist extracted the following from my project:

webpack.config.bable.js
.babelrc
package.json
yarn.lock

Thank you very much for your help!

@sokra I think I sort of figured out the reason. I was importing redux-form/immutable throughout my code, but I did import { SubmissionError } from 'redux-form' instead of import { SubmissionError } from 'redux-form/immutable'.
Soon as I updated all the reference from redux-form to redux-form/immutable, everything just worked. What confused me was that webpack version 1 worked without those changes though. ( Maybe the dedupe plugin was doing its magic? No idea... )

The module field was added in webpack 2.


Repo abandoned/dead?

It's been about 8 months since the last commit.
It's currently in an unusable state for me.
I'd be happy to help on pull requests, but someone needs to review and merge the ones already here.

Why is it unusable? I forked dts-gen-lite without typescript binding. Maybe that's something for you?


Show liquidity provision network parameters on liquidity dashboard

Story
As a potential liquidity provider
I want to understand what would be required of me
So I can make an informed decision about providing liquidity on Vega
Acceptance Criteria

[ ] I can see all network parameters relevant to liquidity provision on Vega
[ ] Where relevant these are pulled onto the LP tiles on the homepage

Tasks

[ ] Explore and sketch
[ ] Team and stakeholder review
[ ] Visual Design
[ ] Team review
[ ] Etc.

Sketch
Additional details / background info

Barney on Slack: "You would probably want to show the SLA and other related parameters so that potential LPs know what they have to sign up to to be an LP on that market"

Dupe of #4552


MultipartFormDataParser using UploadedFile does not work

What steps will reproduce the problem?

use yii\web\MultipartFormDataParser as a request parser
upload file using PATCH method
use UploadedFile to instanciate the file

What is the expected result?
When using UploadedFile::saveAs() file is saved into specified directory.
What do you get instead?
Since it uses php-s move_uploaded_file() or is_uploaded_file() which check if php itself dealt with uploaded file (which it didn't), file is not saved.
Additional info
yii\web\MultipartFormDataParser deals with $_FILES itself not php.

Q
A

Yii version
<IP_ADDRESS>

Relates to #6996 but is not the same.

We attempted an upgrade from 2.0.14. For us this seems to be happening with latest #2.0.18 version using POST also. Any advice? File do not get saved, type not identified and files shows error 3 and validation trigger the file type missing. All works fine when we downgrade to <IP_ADDRESS>.

@Nuffic this mentioned in the documentation https://www.yiiframework.com/doc/api/2.0/yii-web-multipartformdataparser
Note: although this parser fully emulates regular structure of the $_FILES, related temporary files, which are available via tmp_name key, will not be recognized by PHP as uploaded ones. Thus functions like is_uploaded_file() and move_uploaded_file() will fail on them. This also means yii\web\UploadedFile::saveAs() will fail as well.


nixos.ova build fails on Hydra

Issue description
The ova job has been failing during past week, blocking the nixos-unstable channel.  I don't know what's the exact problem.
Steps to reproduce
I'm unable to reproduce the failure locally.

Differences between succeeding and failing job:
+copying closure closure to /build/root...
-copying closure closure to /tmp/nix-build-nixos-ova-17.09pre107278.42bf19cc04-x86_64-linux.drv-0/root...
+error: changing ownership of path ‘/build/root/nix/store’: Invalid argument

Here's the line from nix giving the error:
https://github.com/NixOS/nix/blob/62d476c7ee5dbb79fb435895e0cda3fac8f53ba3/src/libstore/local-store.cc#L89
It's definitely related to NixOS/nix@eba840c8a13b465ace90172ff76a0db2899ab11b.

Probably the same reason as explained in 6cfb3b636418526d1c49d14316a127133cf09c9d.
No idea on how to fix, though.

This issue seems to have no owner (just stating facts, no offense intended). Is there a process to identify the offending commit and roll it back?

It wasn't triggered by a nixpkgs commit but by a nix change.  That's why most people won't reproduce it.  I don't think a process really exists (for this).
/cc @edolstra for the option to roll that change back on the build farm for now, as there's no idea how to fix it properly and the channel is on a ~11 days old commit already.

Seems it's now timing out building ibus package?

ibus was updated on master (since the last ova failure) and it seems to build fine on Hydra now, though the ova job doesn't really show that (yet).

Now the job built successfully, though I can't see why.  AFAIK it's possible some build slaves still use an older version of nix, or something...

Right, probably only the packet machine can succeed.
I managed to make Hydra build the tested job successfully now, after two weeks, but this issue remains a channel blocker IMO.

I guess the packet machine was updated so now the job will never succeed...

The problem seems to be we're running insstall commands for the ova inside the sandbox, which prevents setuid/gid, however, we do use setsid/setgid in some places:
ex in nixos-prepare-root:
mkdir -m 1775 -p $mountPoint/nix/store

Here are some additional places:
grahamc@Morbo> rg  -g '!*.xml' nix/store | grep -E "[0-7]{4}"
nixos/modules/virtualisation/qemu-vm.nix:          mkdir -p 0755 $targetRoot/nix/.rw-store/store $targetRoot/nix/.rw-store/work $targetRoot/nix/store
nixos/modules/system/boot/stage-2-init.sh:chmod -f 1775 /nix/store
nixos/modules/installer/tools/nixos-prepare-root.sh:mkdir -m 1775 -p $mountPoint/nix/store
pkgs/tools/package-management/nix/nix/nix.spec.in:chmod 1775 /nix/store

Right, /nix/store seems to use 1775 root nixbld on standard NixOS, but that's only the sticky bit, not set(u/g)id.  If I read the seccomp code right, it only attempts to disallow those two bits.

Please bear in mind I don't know anything about the low-level details involved. I was able to reproduce the failure in a VM and trying to debug and connect some breadcrumbs I ended up with the below, although again my reasoning here may well be flawed. Hopefully it is of some help and doesn't add to the confusion.

Applying the following:
$ git status --short
 M pkgs/tools/system/fakeroot/default.nix
?? pkgs/tools/system/fakeroot/einval.patch
$ git diff
diff --git a/pkgs/tools/system/fakeroot/default.nix b/pkgs/tools/system/fakeroot/default.nix
index 5286b6b2cb..a3b858db2d 100644
--- a/pkgs/tools/system/fakeroot/default.nix
+++ b/pkgs/tools/system/fakeroot/default.nix
@@ -10,7 +10,7 @@ stdenv.mkDerivation rec {
   };

   # patchset from brew
-  patches = stdenv.lib.optionals stdenv.isDarwin [
+  patches = [ ./einval.patch ] ++ (stdenv.lib.optionals stdenv.isDarwin [
     (fetchpatch {
       name = "0001-Implement-openat-2-wrapper-which-handles-optional-ar.patch";
       url = "https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=0001-Implement-openat-2-wrapper-which-handles-optional-ar.patch;att=1;bug=766649";
@@ -26,7 +26,7 @@ stdenv.mkDerivation rec {
       url = "https://bugs.debian.org/cgi-bin/bugreport.cgi?att=2;bug=766649;filename=fakeroot-always-pass-mode.patch;msg=20";
       sha256 = "0i3zaca1v449dm9m1cq6wq4dy6hc2y04l05m9gg8d4y4swld637p";
     })
-    ];
+    ]);

   buildInputs = [ getopt ]
     ++ stdenv.lib.optional (!stdenv.isDarwin) libcap
$ cat pkgs/tools/system/fakeroot/einval.patch
diff --git a/libfakeroot.c b/libfakeroot.c
index 68a95fb..70da8bc 100644
--- a/libfakeroot.c
+++ b/libfakeroot.c
@@ -792,7 +792,7 @@ int chown(const char *path, uid_t owner, gid_t group){
     r=next_lchown(path,owner,group);
   else
     r=0;
-  if(r&&(errno==EPERM))
+  if(r&&(errno==EPERM||errno==EINVAL))
     r=0;

   return r;
@@ -819,7 +819,7 @@ int lchown(const char *path, uid_t owner, gid_t group){
     r=next_lchown(path,owner,group);
   else
     r=0;
-  if(r&&(errno==EPERM))
+  if(r&&(errno==EPERM||errno==EINVAL))
     r=0;

   return r;
@@ -843,7 +843,7 @@ int fchown(int fd, uid_t owner, gid_t group){
   else
     r=0;

-  if(r&&(errno==EPERM))
+  if(r&&(errno==EPERM||errno==EINVAL))
     r=0;

   return r;
@@ -870,7 +870,7 @@ int fchownat(int dir_fd, const char *path, uid_t owner, gid_t group, int flags)
   else
     r=0;

-  if(r&&(errno==EPERM))
+  if(r&&(errno==EPERM||errno==EINVAL))
     r=0;

   return r;

on top of:

System: 17.09pre108553.0011f9065a (Hummingbird)
Nix version: nix-env (Nix) 1.12pre5350_7689181e
Nixpkgs version: 17.09pre108553.0011f9065a
Sandboxing enabled: build-use-sandbox = true

makes the test pass for me.
Patch stolen from https://github.com/NixOS/nixpkgs/issues/10496#issuecomment-149893498

@pbogdan I'm in no position to evaluate if your patch is the best solution (I have no idea what I'm doing here,) however I can definitely appreciate your great digging and patch. Thank you!

@grahamc you can safely drop the sticky bit in, when creating the image. It will be fixed by stage-2 automatically: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/system/boot/stage-2-init.sh#L62

Oh, I didn't realize this isn't reproducible with the latest stable nix.  It still builds in /tmp and not /build, according to log from ova, and it just succeeds as it is.

This solution seems OK.  I think I now understand.  @pbogdan: thank you a lot for finding a solution; I designated you as the author of the modified commit :-)

Not only did it work okay, it passed: https://hydra.nixos.org/build/54649680#tabs-summary
I think we'll get a channel update: https://hydra.nixos.org/job/nixos/trunk-combined/tested#tabs-constituents
https://channels.nix.gsc.io/graph.html

Yes, I do believe we'll get a channel bump within several hours.  There are just some heavy packages left, e.g. webkitgtk...

nixos-unstable bumped!

Maybe we should just get rid of that fakeroot stuff? I mean, the goal was to git rid of the QEMU VM, but that's still being used, so fakeroot just seems an unnecessary complication...


Please support Chinese

I am using it, but I found that it does not support Chinese.

Hi!  Could you please be more specific?  What isn't working?

I have heard that Markdown documents with Chinese names are not created successfully

Thanks, I'll investigate further.