Enable UnitTest

PR is added to the queue for testing as 2. task. (717c95f)

Test (Success) 50650278 build is completed (717c95f)
See https://github.com/ThaliTester/TestResults/tree/50650278717c95f_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (3545139)

Test (Fail) 50650278 build is completed (3545139)
See https://github.com/ThaliTester/TestResults/tree/506502783545139_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (95390fa)

Test (Fail) 50650278 build is completed (95390fa)
See https://github.com/ThaliTester/TestResults/tree/5065027895390fa_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (b5b3a17)

Test (Fail) 50650278 build is completed (b5b3a17)
See https://github.com/ThaliTester/TestResults/tree/50650278b5b3a17_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (2f56074)

Test (Fail) 50650278 build is completed (2f56074)
See https://github.com/ThaliTester/TestResults/tree/506502782f56074_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (b63d1af)

Test (Success) 50650278 build is completed (b63d1af)
See https://github.com/ThaliTester/TestResults/tree/50650278b63d1af_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (81baad9)

Test (Success) 50650278 build is completed (81baad9)
See https://github.com/ThaliTester/TestResults/tree/5065027881baad9_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>baad9(81baad9) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027881baad9_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (5fb00e5)

Test (Success) 50650278 build is completed (5fb00e5)
See https://github.com/ThaliTester/TestResults/tree/506502785fb00e5_Enable_UnitTest_tobybrad/ for the logs

Test 506502785fb00e5(5fb00e5) has failed
See https://github.com/ThaliTester/TestResults/tree/506502785fb00e5_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (c5a416b)

Test (Success) 50650278 build is completed (c5a416b)
See https://github.com/ThaliTester/TestResults/tree/50650278c5a416b_Enable_UnitTest_tobybrad/ for the logs

Test 50650278c5a416b(c5a416b) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278c5a416b_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (4f771df)

Test (Fail) 50650278 build is completed (4f771df)
See https://github.com/ThaliTester/TestResults/tree/506502784f771df_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (ca89752)

Test (Fail) 50650278 build is completed (ca89752)
See https://github.com/ThaliTester/TestResults/tree/50650278ca89752_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (d8b316d)

PR is added to the queue for testing as 1. task. (6e377ec)

Test (Fail) 50650278 build is completed (d8b316d)
See https://github.com/ThaliTester/TestResults/tree/50650278d8b316d_Enable_UnitTest_tobybrad/ for the logs

Test (Fail) 50650278 build is completed (6e377ec)
See https://github.com/ThaliTester/TestResults/tree/506502786e377ec_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (c526ecb)

Test (Fail) 50650278 build is completed (c526ecb)
See https://github.com/ThaliTester/TestResults/tree/50650278c526ecb_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (76743b1)

Test (Fail) 50650278 build is completed (76743b1)
See https://github.com/ThaliTester/TestResults/tree/5065027876743b1_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (60a4eba)

Test (Success) 50650278 build is completed (60a4eba)
See https://github.com/ThaliTester/TestResults/tree/5065027860a4eba_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>a4eba(60a4eba) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027860a4eba_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (48f855f)

Test (Success) 50650278 build is completed (48f855f)
See https://github.com/ThaliTester/TestResults/tree/5065027848f855f_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>f855f(48f855f) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027848f855f_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (7a45a3c)

Test (Success) 50650278 build is completed (7a45a3c)
See https://github.com/ThaliTester/TestResults/tree/506502787a45a3c_Enable_UnitTest_tobybrad/ for the logs

Test 506502787a45a3c(7a45a3c) has failed
See https://github.com/ThaliTester/TestResults/tree/506502787a45a3c_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (fa25325)

Test (Success) 50650278 build is completed (fa25325)
See https://github.com/ThaliTester/TestResults/tree/50650278fa25325_Enable_UnitTest_tobybrad/ for the logs

Test 50650278fa25325(fa25325) has successfully finished without an error
See https://github.com/ThaliTester/TestResults/tree/50650278fa25325_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (265fe5c)

Test (Success) 50650278 build is completed (265fe5c)
See https://github.com/ThaliTester/TestResults/tree/50650278265fe5c_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>5fe5c(265fe5c) has successfully finished without an error
See https://github.com/ThaliTester/TestResults/tree/50650278265fe5c_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (208a743)

PR is added to the queue for testing as 2. task. (9318894)

Test (Fail) 50650278 build is completed (208a743)
See https://github.com/ThaliTester/TestResults/tree/50650278208a743_Enable_UnitTest_tobybrad/ for the logs

Test (Success) 50650278 build is completed (9318894)
See https://github.com/ThaliTester/TestResults/tree/506502789318894_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 3. task. (f3f3060)

Test (Success) 50650278 build is completed (f3f3060)
See https://github.com/ThaliTester/TestResults/tree/50650278f3f3060_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>18894(9318894) has failed
See https://github.com/ThaliTester/TestResults/tree/506502789318894_Enable_UnitTest_tobybrad/ for the fail logs

Test 50650278f3f3060(f3f3060) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278f3f3060_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 4. task. (59ed96a)

Test (Success) 50650278 build is completed (59ed96a)
See https://github.com/ThaliTester/TestResults/tree/5065027859ed96a_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>ed96a(59ed96a) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027859ed96a_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (2cf4552)

Test (Success) 50650278 build is completed (2cf4552)
See https://github.com/ThaliTester/TestResults/tree/506502782cf4552_Enable_UnitTest_tobybrad/ for the logs

Test 506502782cf4552(2cf4552) has failed
See https://github.com/ThaliTester/TestResults/tree/506502782cf4552_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (2b2305a)

Test (Success) 50650278 build is completed (2b2305a)
See https://github.com/ThaliTester/TestResults/tree/506502782b2305a_Enable_UnitTest_tobybrad/ for the logs

Test 506502782b2305a(2b2305a) has failed
See https://github.com/ThaliTester/TestResults/tree/506502782b2305a_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (35b6ad9)

Test (Success) 50650278 build is completed (35b6ad9)
See https://github.com/ThaliTester/TestResults/tree/5065027835b6ad9_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>b6ad9(35b6ad9) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027835b6ad9_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 2. task. (8f08dc7)

Test (Success) 50650278 build is completed (8f08dc7)
See https://github.com/ThaliTester/TestResults/tree/506502788f08dc7_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (c902ea2)

Test (Success) 50650278 build is completed (c902ea2)
See https://github.com/ThaliTester/TestResults/tree/50650278c902ea2_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 3. task. (3160246)

Test (Fail) 50650278 build is completed (3160246)
See https://github.com/ThaliTester/TestResults/tree/506502783160246_Enable_UnitTest_tobybrad/ for the logs

Test 506502788f08dc7(8f08dc7) has failed
See https://github.com/ThaliTester/TestResults/tree/506502788f08dc7_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 2. task. (b04e3e5)

Test (Success) 50650278 build is completed (b04e3e5)
See https://github.com/ThaliTester/TestResults/tree/50650278b04e3e5_Enable_UnitTest_tobybrad/ for the logs

Test 50650278c902ea2(c902ea2) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278c902ea2_Enable_UnitTest_tobybrad/ for the fail logs

Test 50650278b04e3e5(b04e3e5) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278b04e3e5_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (8a86afe)

Test (Success) 50650278 build is completed (8a86afe)
See https://github.com/ThaliTester/TestResults/tree/506502788a86afe_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (c5de1fe)

Test (Success) 50650278 build is completed (c5de1fe)
See https://github.com/ThaliTester/TestResults/tree/50650278c5de1fe_Enable_UnitTest_tobybrad/ for the logs

Test 506502788a86afe(8a86afe) has failed
See https://github.com/ThaliTester/TestResults/tree/506502788a86afe_Enable_UnitTest_tobybrad/ for the fail logs

Test 50650278c5de1fe(c5de1fe) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278c5de1fe_Enable_UnitTest_tobybrad/ for the fail logs

Reviewed 40 of 40 files at r1.
Review status: all files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

mobile_test.json, line 7 [r1] (raw file):
Before merging, I think we could change this back to all.

test/TestServer/Config_PerfTest.json, line 2 [r1] (raw file):
The updated syntax could be updated to the README.md under test/TestServer.

test/TestServer/Config_PerfTest.json, line 5 [r1] (raw file):
In local long-running runs, I have sometimes leveraged the tests list so that I can run multiple data sending tests in a row. It looks like the current configuration syntax doesn't allow this anymore.
I am fine dropping that feature now and adding it back later. It could perhaps be a number in the root of the object.
Wanted to also point out that this number would mean how many times to run a test and that is different to what the round in the test configuration is.

test/TestServer/index.js, line 32 [r1] (raw file):
Is the functionality that the honorCount is for temporarily disabled and intended to be brought back?

test/TestServer/PerfTestFramework.js, line 128 [r1] (raw file):
Good that you added quitting the server once tests are done!
 Is it possible that this process might still be sending the data that is emitted to the devices when the process.exit is hit?

test/TestServer/UnitTestFramework.js, line 118 [r1] (raw file):
Is the idea in the reporting so that if run on many devices (like 20+ Android devices in CI), a unit test is reported as passed if it passes on all devices? I think that is a reasonable way to report it, but just wanted to double-check.
Furthermore, if a test fails on 10 devices, but passes on others, do we just see that the test failed, but not the count about on how many it passed?

test/www/jxcore/bv_tests/testTests.js, line 12 [r1] (raw file):
Could these tests for tests be in the meta_tests folder?

test/www/jxcore/lib/thali-tape.js, line 28 [r1] (raw file):
If an uncaughtException or unhandledRejection is encountered, is the test framework trying to proceed with other tests or does it "tear down" the whole test run?
If the intent is that other tests are continued in case of errors, I think we should not print the PROCESS_ON_EXIT_FAILED inside this callback, because that tells CI to basically kill everything related to this device.

test/www/jxcore/lib/thali-tape.js, line 68 [r1] (raw file):
When looking at CI results, there is sometimes value in being able to easily correlate device names to physical devices. Could the unit tests use the assigned device names? See also https://github.com/thaliproject/Thali_CordovaPlugin/issues/290.

test/www/jxcore/package.json, line 37 [r1] (raw file):
I believe typically, adding a fixed version of thali does not have an effect, because tests are most often wanted to be run against a version of thali from the git repository (rather than npm).
I think this doesn't break anything so if there is a case where this has value, I think it is okay to have it.

test/www/jxcore/perf_tests/PerfTestFrameworkClient.js, line 153 [r1] (raw file):
This should be fixed since the server address is now a proper node module. Also, it might be better to avoid inline-requires.

test/www/jxcore/perf_tests/PerfTestFrameworkClient.js, line 191 [r1] (raw file):
The report printing was refactored onto a separate file so it should not be needed anymore in this file.

test/www/jxcore/perf_tests/SendDataConnector.js, line 256 [r1] (raw file):
Perhaps a left-over?

test/www/jxcore/PerfTest_app.js, line 73 [r1] (raw file):
Based on looking at the code, in case of Android, the bluetoothAddress is set in a callback to an async function, which probably means it is not set yet when this line is executed.

Comments from the review on Reviewable.io

PR is added to the queue for testing as 1. task. (60d2bae)

Test (Success) 50650278 build is completed (60d2bae)
See https://github.com/ThaliTester/TestResults/tree/5065027860d2bae_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>d2bae(60d2bae) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027860d2bae_Enable_UnitTest_tobybrad/ for the fail logs

Review status: 25 of 36 files reviewed at latest revision, 17 unresolved discussions, some commit checks failed.

test/TestServer/PerfTestFramework.js, line 60 [r1] (raw file):
Why is this Bt in particular? I would think the same logic would apply for iOS. That is, we would give the peerID from iOS. That way devices will only look for and accept connections from peerIDs that are supposed to be part of the test.

test/www/jxcore/lib/CoordinatorConnector.js, line 92 [r1] (raw file):
Same issue as before, shouldn't this be generic and not just bluetoothAddress? In other words, shouldn't we have the coodination manager restriction what peerIDs will be used in a test so we make sure we don't get any outside noise? No stray devices that haven't properly reset themselves. Etc.?

test/www/jxcore/lib/testUtils.js, line 10 [r1] (raw file):
Do we want to consider at least putting in an error into the logs if toggleRadios gets called while we are in iOS? It means that somebody is confused.

Comments from the review on Reviewable.io

PR is added to the queue for testing as 1. task. (1c561a7)

Test (Fail) 50650278 build is completed (1c561a7)
See https://github.com/ThaliTester/TestResults/tree/506502781c561a7_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (5032ad1)

Test<PHONE_NUMBER>32ad1(5032ad1) has failed
See https://github.com/ThaliTester/TestResults/tree/506502785032ad1_Enable_UnitTest_tobybrad/ for the fail logs

Review status: 20 of 36 files reviewed at latest revision, 12 unresolved discussions.

test/TestServer/Config_PerfTest.json, line 5 [r1] (raw file):
Fair point.
I'm thinking we should remove rounds as they are currently implemented and just run the test multiple times as though it had appeared multiply in the config somehow. Current implementation seems over complex. Just run the whole test again.

test/TestServer/index.js, line 32 [r1] (raw file):
Bought back. I think it's a hack to cover issues in the CI or test frameworks though and should eventually be removed.

test/TestServer/PerfTestFramework.js, line 60 [r1] (raw file):
BtAddressList - I think this is an awful hack that shouldn't be here. My addition's here are just clearing up the handling of the address list. I'm completely unconvinced of the requirement for this feature. It seems to me if you can't communicate with a device without first knowing it's BT MAC address then you've either mis-implemented the stack or this is basically not terribly useful as a p2p system. I think this is currently a crutch for android code that I'm hoping we can prove is unnecessary. Hence I'm not keen to replicate this for ios.

test/TestServer/PerfTestFramework.js, line 128 [r1] (raw file):
It's possible but unlikely and not really that important anyway since we have our test results at this point. Only way to guarantee we've correctly emitted the end event is wait for an acknowledgement of it's receipt. Timeouts don't guarantee anything. I'll get to this in the morning.

test/TestServer/UnitTestFramework.js, line 118 [r1] (raw file):
If a test fails on a single device that's a failure. At least for unit tests.

test/www/jxcore/bv_tests/testTests.js, line 12 [r1] (raw file):
I want them to run every time unit tests run.

test/www/jxcore/lib/CoordinatorConnector.js, line 92 [r1] (raw file):
See previous comment regarding btAddressList. tldr; I think it's hack. tests should imho pass with noise in the system.

test/www/jxcore/lib/thali-tape.js, line 28 [r1] (raw file):
I really don't know tbh. This is how things have been up to now. Don't feel strongly either way on this. Let's discuss.

test/www/jxcore/package.json, line 37 [r1] (raw file):
?? I thought this was asking for any version > 2.0.1, not a specific version.

test/www/jxcore/perf_tests/PerfTestFrameworkClient.js, line 153 [r1] (raw file):
Not clear what you're referring to here.

test/www/jxcore/perf_tests/PerfTestFrameworkClient.js, line 191 [r1] (raw file):
This all appears to be duplicated here just to print out the result on the device console. Commented out whilst I double-check we don't lose anything useful by removing.

test/www/jxcore/PerfTest_app.js, line 73 [r1] (raw file):
The nature of jxcore (all calls are actually sync) says it is. But I agree.

Comments from the review on Reviewable.io

Review status: 15 of 37 files reviewed at latest revision, 9 unresolved discussions.

test/TestServer/Config_PerfTest.json, line 5 [r1] (raw file):
Agreed.
Could we do so that we would leave this code as is in the PR and open up an issue about making the round behave so that it can be used to run the specified test multiple times?

test/TestServer/index.js, line 32 [r1] (raw file):
It is true that it is to work around issues. Mainly, the issue we still see is that when deploying to 20+ Android devices, sometimes something might go wrong (typically, we tend to say adb has issues). If an alternative solution is found for the root cause, the code here could be gotten rid of.

test/TestServer/PerfTestFramework.js, line 128 [r1] (raw file):
In the CI, what often happens is that not all devices manage to run the entire test in the time given for the CI run. In that case, the test server signals devices that the time is up and devices send the report from the results they have gathered so far.
I think this step is important, because otherwise, we wouldn't see the results from devices that don't fully complete even though they might have useful data.

test/www/jxcore/package.json, line 37 [r1] (raw file):
The ^ does not mean same as >, but my point wasn't really about the version.
It was more about in which scenarios we want to run these tests against the thali package coming from npm (instead of a git clone). If that scenario is wanted to be supported, this change is justified.

test/www/jxcore/perf_tests/PerfTestFrameworkClient.js, line 153 [r1] (raw file):
Was referring to the change serveraddress.json -> server-address.js, but you had fixed this already so all good :)
With the inline-require, I meant that typically, the requires are at the top of the file, but now that I look at the latest code, I think you have it inline for better mock-up capabilities so I think that is okay.

test/www/jxcore/perf_tests/PerfTestFrameworkClient.js, line 191 [r1] (raw file):
That is good point that I forgot / overlooked. The idea was that if there is a connection failure to the test server, the device still prints the results so that they are accessible "somewhere" after the run.
An idea was that we could reuse the same result printing code in both sides, but this was just never done. I think it is okay to leave this in any way you want within this PR.

test/www/jxcore/PerfTest_app.js, line 73 [r1] (raw file):
We have a work item to ensure they are really async https://github.com/thaliproject/Thali_CordovaPlugin/issues/365 so it might be good "future-proofing" that this code works after that issue is fixed.

Comments from the review on Reviewable.io

Review status: 15 of 37 files reviewed at latest revision, 6 unresolved discussions.

test/TestServer/Config_PerfTest.json, line 5 [r1] (raw file):
Sounds like good plan.

test/www/jxcore/package.json, line 37 [r1] (raw file):
Soo.. I'm confused. What do you think this should be ? No thali dependency in this file ?

test/www/jxcore/perf_tests/PerfTestFrameworkClient.js, line 153 [r1] (raw file):
We should look to try and capture these style issues in jshint or similar. I tend to prefer principal of locality in cases like this (put active code close to where it's used) but I don't have a very strong opinion on this kind of thing.

test/www/jxcore/perf_tests/PerfTestFrameworkClient.js, line 191 [r1] (raw file):
I'll have a look to see if we can easily re-use your refactored results processor here.

Comments from the review on Reviewable.io

Review status: 15 of 37 files reviewed at latest revision, 3 unresolved discussions.

test/www/jxcore/package.json, line 37 [r1] (raw file):
Sorry for not being clear on this one :)
It is okay to have it if there is a need for it. Why was the dependency added?

Comments from the review on Reviewable.io

PR is added to the queue for testing as 1. task. (cc6513d)

Test (Success) 50650278 build is completed (cc6513d)
See https://github.com/ThaliTester/TestResults/tree/50650278cc6513d_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (352fc1f)

Test (Success) 50650278 build is completed (352fc1f)
See https://github.com/ThaliTester/TestResults/tree/50650278352fc1f_Enable_UnitTest_tobybrad/ for the logs

Test 50650278cc6513d(cc6513d) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278cc6513d_Enable_UnitTest_tobybrad/ for the fail logs

Test<PHONE_NUMBER>2fc1f(352fc1f) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278352fc1f_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 2. task. (b1aec71)

Test (Success) 50650278 build is completed (b1aec71)
See https://github.com/ThaliTester/TestResults/tree/50650278b1aec71_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (65f659b)

Test 50650278b1aec71(b1aec71) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278b1aec71_Enable_UnitTest_tobybrad/ for the fail logs

Test (Success) 50650278 build is completed (65f659b)
See https://github.com/ThaliTester/TestResults/tree/5065027865f659b_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>f659b(65f659b) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027865f659b_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (73d6a28)

Test (Success) 50650278 build is completed (73d6a28)
See https://github.com/ThaliTester/TestResults/tree/5065027873d6a28_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>d6a28(73d6a28) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027873d6a28_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (eab32a5)

Test (Success) 50650278 build is completed (eab32a5)
See https://github.com/ThaliTester/TestResults/tree/50650278eab32a5_Enable_UnitTest_tobybrad/ for the logs

Reviewed 1 of 1 files at r8, 1 of 3 files at r9.
Review status: 17 of 37 files reviewed at latest revision, 4 unresolved discussions.

test/www/jxcore/UnitTest_app.js, line 17 [r13] (raw file):
I believe the failure in the CI currently comes, because this line is missing ending parenthesis.

Comments from the review on Reviewable.io

PR is added to the queue for testing as 2. task. (b28a87a)

Test 50650278eab32a5(eab32a5) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278eab32a5_Enable_UnitTest_tobybrad/ for the fail logs

Test (Success) 50650278 build is completed (b28a87a)
See https://github.com/ThaliTester/TestResults/tree/50650278b28a87a_Enable_UnitTest_tobybrad/ for the logs

Test 50650278b28a87a(b28a87a) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278b28a87a_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (7907953)

Test (Success) 50650278 build is completed (7907953)
See https://github.com/ThaliTester/TestResults/tree/506502787907953_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (d0426ce)

Test (Success) 50650278 build is completed (d0426ce)
See https://github.com/ThaliTester/TestResults/tree/50650278d0426ce_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (9252e15)

Test (Success) 50650278 build is completed (9252e15)
See https://github.com/ThaliTester/TestResults/tree/506502789252e15_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>52e15(9252e15) has failed
See https://github.com/ThaliTester/TestResults/tree/506502789252e15_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (c17c777)

Test (Success) 50650278 build is completed (c17c777)
See https://github.com/ThaliTester/TestResults/tree/50650278c17c777_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (c0f6ec2)

PR is added to the queue for testing as 3. task. (4dae475)

PR is added to the queue for testing as 4. task. (81383b1)

Test (Success) 50650278 build is completed (c0f6ec2)
See https://github.com/ThaliTester/TestResults/tree/50650278c0f6ec2_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 5. task. (d6c551a)

Test (Success) 50650278 build is completed (4dae475)
See https://github.com/ThaliTester/TestResults/tree/506502784dae475_Enable_UnitTest_tobybrad/ for the logs

Test (Success) 50650278 build is completed (81383b1)
See https://github.com/ThaliTester/TestResults/tree/5065027881383b1_Enable_UnitTest_tobybrad/ for the logs

Test 50650278c17c777(c17c777) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278c17c777_Enable_UnitTest_tobybrad/ for the fail logs

Test (Success) 50650278 build is completed (d6c551a)
See https://github.com/ThaliTester/TestResults/tree/50650278d6c551a_Enable_UnitTest_tobybrad/ for the logs

Reviewed 7 of 11 files at r2, 5 of 6 files at r4, 2 of 6 files at r5, 1 of 1 files at r10, 1 of 2 files at r12, 1 of 1 files at r15, 2 of 3 files at r17, 1 of 2 files at r21, 3 of 3 files at r24.
Review status: all files reviewed at latest revision, 7 unresolved discussions.

test/TestServer/PerfTestFramework.js, line 124 [r24] (raw file):
I wonder could the following happen. When run in CI, one device manages to complete tests and sends results after which the whole server timeout is cleared. Then, some other devices that happen to run tests slower would not be aware of the timeout to trigger and might hit the "CI timeout" in which case they don't have time to flush logs to the test server.

test/TestServer/README.md, line 20 [r24] (raw file):
I believe the filename was changed so this comment could be fixed.

test/www/jxcore/perf_tests/SendDataConnector.js, line 13 [r24] (raw file):
Was this meant to be left or a development-time log? :)

Comments from the review on Reviewable.io

Test 50650278c0f6ec2(c0f6ec2) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278c0f6ec2_Enable_UnitTest_tobybrad/ for the fail logs

Test 506502784dae475(4dae475) has failed
See https://github.com/ThaliTester/TestResults/tree/506502784dae475_Enable_UnitTest_tobybrad/ for the fail logs

Test<PHONE_NUMBER>383b1(81383b1) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027881383b1_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 2. task. (b86327b)

Test (Success) 50650278 build is completed (b86327b)
See https://github.com/ThaliTester/TestResults/tree/50650278b86327b_Enable_UnitTest_tobybrad/ for the logs

Test 50650278d6c551a(d6c551a) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278d6c551a_Enable_UnitTest_tobybrad/ for the fail logs

Test 50650278b86327b(b86327b) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278b86327b_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (57de7f1)

Test (Success) 50650278 build is completed (57de7f1)
See https://github.com/ThaliTester/TestResults/tree/5065027857de7f1_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>de7f1(57de7f1) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027857de7f1_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (f6345ef)

Test (Success) 50650278 build is completed (f6345ef)
See https://github.com/ThaliTester/TestResults/tree/50650278f6345ef_Enable_UnitTest_tobybrad/ for the logs

Test 50650278f6345ef(f6345ef) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278f6345ef_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (e3ff7c2)

Test (Success) 50650278 build is completed (e3ff7c2)
See https://github.com/ThaliTester/TestResults/tree/50650278e3ff7c2_Enable_UnitTest_tobybrad/ for the logs

Test 50650278e3ff7c2(e3ff7c2) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278e3ff7c2_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (b2f31ec)

Test (Success) 50650278 build is completed (b2f31ec)
See https://github.com/ThaliTester/TestResults/tree/50650278b2f31ec_Enable_UnitTest_tobybrad/ for the logs

Test 50650278b2f31ec(b2f31ec) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278b2f31ec_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (ec2c976)

Test (Success) 50650278 build is completed (ec2c976)
See https://github.com/ThaliTester/TestResults/tree/50650278ec2c976_Enable_UnitTest_tobybrad/ for the logs

Test 50650278ec2c976(ec2c976) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278ec2c976_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (3a40166)

Test (Success) 50650278 build is completed (3a40166)
See https://github.com/ThaliTester/TestResults/tree/506502783a40166_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (1cef9bd)

Test (Fail) 50650278 build is completed (1cef9bd)
See https://github.com/ThaliTester/TestResults/tree/506502781cef9bd_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (8f5bfb2)

Test (Success) 50650278 build is completed (8f5bfb2)
See https://github.com/ThaliTester/TestResults/tree/506502788f5bfb2_Enable_UnitTest_tobybrad/ for the logs

Test 506502788f5bfb2(8f5bfb2) has failed
See https://github.com/ThaliTester/TestResults/tree/506502788f5bfb2_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (70036d7)

Test (Success) 50650278 build is completed (70036d7)
See https://github.com/ThaliTester/TestResults/tree/5065027870036d7_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>036d7(70036d7) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027870036d7_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (cb112b9)

PR is added to the queue for testing as 2. task. (ee43ca0)

Test (Success) 50650278 build is completed (cb112b9)
See https://github.com/ThaliTester/TestResults/tree/50650278cb112b9_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 3. task. (2ddd83f)

Test (Success) 50650278 build is completed (ee43ca0)
See https://github.com/ThaliTester/TestResults/tree/50650278ee43ca0_Enable_UnitTest_tobybrad/ for the logs

Test (Success) 50650278 build is completed (2ddd83f)
See https://github.com/ThaliTester/TestResults/tree/506502782ddd83f_Enable_UnitTest_tobybrad/ for the logs

Test 50650278cb112b9(cb112b9) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278cb112b9_Enable_UnitTest_tobybrad/ for the fail logs

Test 50650278ee43ca0(ee43ca0) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278ee43ca0_Enable_UnitTest_tobybrad/ for the fail logs

Test 506502782ddd83f(2ddd83f) has failed
See https://github.com/ThaliTester/TestResults/tree/506502782ddd83f_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task

Test 50650278 has failed
See https://gist.github.com/c040ec9b5aa10cd75a5b for the fail logs

Test 50650278 build process is completed
See https://gist.github.com/8db8a2cbf094356c08fa for the logs

PR is added to the queue for testing as 1. task

Test 50650278 has failed
See https://gist.github.com/5f1c8bb3c303e1507e3d for the fail logs

Test 50650278 build process is completed
See https://gist.github.com/640dea36f2fadfce6e36 for the logs

PR is added to the queue for testing as 2. task. (088ea35)

Test (Success) 50650278 build is completed (088ea35)
See https://github.com/ThaliTester/TestResults/tree/50650278088ea35_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>8ea35(088ea35) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278088ea35_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (654db8c)

Test (Success) 50650278 build is completed (654db8c)
See https://github.com/ThaliTester/TestResults/tree/50650278654db8c_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>4db8c(654db8c) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278654db8c_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (dbf8a2a)

Test (Success) 50650278 build is completed (dbf8a2a)
See https://github.com/ThaliTester/TestResults/tree/50650278dbf8a2a_Enable_UnitTest_tobybrad/ for the logs

Test 50650278dbf8a2a(dbf8a2a) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278dbf8a2a_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (9b39735)

Test (Success) 50650278 build is completed (9b39735)
See https://github.com/ThaliTester/TestResults/tree/506502789b39735_Enable_UnitTest_tobybrad/ for the logs

Test 506502789b39735(9b39735) has failed
See https://github.com/ThaliTester/TestResults/tree/506502789b39735_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (e989a4f)

Test (Success) 50650278 build is completed (e989a4f)
See https://github.com/ThaliTester/TestResults/tree/50650278e989a4f_Enable_UnitTest_tobybrad/ for the logs

Test 50650278e989a4f(e989a4f) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278e989a4f_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (3fcf234)

Test (Success) 50650278 build is completed (3fcf234)
See https://github.com/ThaliTester/TestResults/tree/506502783fcf234_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (cd699a4)

Test (Success) 50650278 build is completed (cd699a4)
See https://github.com/ThaliTester/TestResults/tree/50650278cd699a4_Enable_UnitTest_tobybrad/ for the logs

Test 506502783fcf234(3fcf234) has failed
See https://github.com/ThaliTester/TestResults/tree/506502783fcf234_Enable_UnitTest_tobybrad/ for the fail logs

Test 50650278cd699a4(cd699a4) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278cd699a4_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (923ff9f)

Test (Success) 50650278 build is completed (923ff9f)
See https://github.com/ThaliTester/TestResults/tree/50650278923ff9f_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>3ff9f(923ff9f) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278923ff9f_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (b44f053)

Test (Success) 50650278 build is completed (b44f053)
See https://github.com/ThaliTester/TestResults/tree/50650278b44f053_Enable_UnitTest_tobybrad/ for the logs

Test 50650278b44f053(b44f053) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278b44f053_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (dcf3b38)

Test (Success) 50650278 build is completed (dcf3b38)
See https://github.com/ThaliTester/TestResults/tree/50650278dcf3b38_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (5223c58)

Test (Success) 50650278 build is completed (5223c58)
See https://github.com/ThaliTester/TestResults/tree/506502785223c58_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>23c58(5223c58) has failed
See https://github.com/ThaliTester/TestResults/tree/506502785223c58_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (1a07ac8)

Test (Success) 50650278 build is completed (1a07ac8)
See https://github.com/ThaliTester/TestResults/tree/506502781a07ac8_Enable_UnitTest_tobybrad/ for the logs

Test 506502781a07ac8(1a07ac8) has failed
See https://github.com/ThaliTester/TestResults/tree/506502781a07ac8_Enable_UnitTest_tobybrad/ for the fail logs

Review status: 25 of 40 files reviewed at latest revision, 7 unresolved discussions.

test/TestServer/index.js, line 4 [r26] (raw file):
Seems that this sample command has always been a bit "wrong" since the numbers have been strings rather than numbers. However, before this PR, this sample line used to work, but not anymore.
Thus, I'd propose changing this to:
jx index.js "{\"devices\": {\"android\": 3, \"ios\": 2}, \"honorCount\": true}"

Comments from the review on Reviewable.io

PR is added to the queue for testing as 1. task. (bcecc5c)

Test (Success) 50650278 build is completed (bcecc5c)
See https://github.com/ThaliTester/TestResults/tree/50650278bcecc5c_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (d76d9c3)

Test (Success) 50650278 build is completed (d76d9c3)
See https://github.com/ThaliTester/TestResults/tree/50650278d76d9c3_Enable_UnitTest_tobybrad/ for the logs

Test 50650278bcecc5c(bcecc5c) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278bcecc5c_Enable_UnitTest_tobybrad/ for the fail logs

Test 50650278d76d9c3(d76d9c3) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278d76d9c3_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (69d93ea)

Test (Success) 50650278 build is completed (69d93ea)
See https://github.com/ThaliTester/TestResults/tree/5065027869d93ea_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>d93ea(69d93ea) has failed
See https://github.com/ThaliTester/TestResults/tree/5065027869d93ea_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (161ce7f)

Test (Success) 50650278 build is completed (161ce7f)
See https://github.com/ThaliTester/TestResults/tree/50650278161ce7f_Enable_UnitTest_tobybrad/ for the logs

Test<PHONE_NUMBER>1ce7f(161ce7f) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278161ce7f_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (5b2d2b2)

Test (Success) 50650278 build is completed (5b2d2b2)
See https://github.com/ThaliTester/TestResults/tree/506502785b2d2b2_Enable_UnitTest_tobybrad/ for the logs

Test 506502785b2d2b2(5b2d2b2) has failed
See https://github.com/ThaliTester/TestResults/tree/506502785b2d2b2_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (bb431e6)

PR is added to the queue for testing as 2. task. (d1b06e8)

Test (Success) 50650278 build is completed (bb431e6)
See https://github.com/ThaliTester/TestResults/tree/50650278bb431e6_Enable_UnitTest_tobybrad/ for the logs

Test (Success) 50650278 build is completed (d1b06e8)
See https://github.com/ThaliTester/TestResults/tree/50650278d1b06e8_Enable_UnitTest_tobybrad/ for the logs

PR is added to the queue for testing as 3. task. (1c2754f)

Test (Success) 50650278 build is completed (1c2754f)
See https://github.com/ThaliTester/TestResults/tree/506502781c2754f_Enable_UnitTest_tobybrad/ for the logs

Test 50650278bb431e6(bb431e6) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278bb431e6_Enable_UnitTest_tobybrad/ for the fail logs

Test 50650278d1b06e8(d1b06e8) has failed
See https://github.com/ThaliTester/TestResults/tree/50650278d1b06e8_Enable_UnitTest_tobybrad/ for the fail logs

Test 506502781c2754f(1c2754f) has failed
See https://github.com/ThaliTester/TestResults/tree/506502781c2754f_Enable_UnitTest_tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (2e2cb10)

Test (Success) 50650278 build is completed (2e2cb10)
See https://github.com/ThaliTester/TestResults/tree/506502782e2cb10_Enable_UnitTest_tobybrad/ for the logs

Review status: 24 of 42 files reviewed at latest revision, 3 unresolved discussions.

test/TestServer/PerfTestFramework.js, line 124 [r24] (raw file):
Server timeout is per device.

Comments from the review on Reviewable.io

Test 506502782e2cb10(2e2cb10) has failed
See https://github.com/ThaliTester/TestResults/tree/506502782e2cb10_Enable_UnitTest_tobybrad/ for the fail logs


impl Display, FromStr, and add fuzzer

Sorry, had a late lunch

(Also, the FromStr impl is pretty shitty, error is just a string)

bors r+


Cmdparse choices options tuple

Let's try this feature again.

Coverage increased (+0.0%) to 99.77% when pulling 6d69f46dd8d4c143688c8fbd730ca72ab77fe455 on schwager-hsph:cmdparse_choices_options_tuple into 947b6b31006622ebdca26ad34818a26f883eb2f9 on pydoit:master.

merged. thanks.
I did a few changes:

choices are always displayed on help, no need to include a %(choices)s in your help string
added a new choices attribute for option dictionary, type must be a callable to convert a string to the "real" value
more strict on choices specification. must be 2-tuple.

please check and let me know if you have any concerns.


⚠ AZ-Launcher has degraded performance

In 1ce30cb, AZ-Launcher (https://az-launcher.nz/) experienced degraded performance:

HTTP code: 200
Response time: 1856 ms

Resolved: AZ-Launcher performance has improved in 299965d after 4 hours, 7 minutes.


Airzone central console

Hi there @max13fr !
first of all, thanks for relaunching this integration. It is lovely to see it back. Could we possibly grab you a coffee?? :)
Now with version 1.1.2 I see all the satellites in my setup but I don't see the central console/module. Is this expected? am I missing something? With older versions it was possible to see the central console, but I now don't know how to find it. Could you provide some guidance maybe? or is that no longer possible?
thanks!!

Thanks a lot for the great job! I have same problem, cannot see the central unit so I am not able to switch on-off the system.

Hello,
I just add it in the last version (v1.2.1).
Max

Hello,
I just add it in the last version (v1.2.1).
Max

Hello Max ,
thanks a lot for your effort.
I can see the central entity now but the heat mode cannot be acrivates.
Just off, dry and ventilation mode can be activated.
I Wish you a nice evening
Il sab 1 gen 2022, 15:58 max13fr @.***> ha scritto:

Hello,
I just add it in the last version (v1.2.1).
Max
—
Reply to this email directly, view it on GitHub
https://github.com/max13fr/Airzonecloud-HomeAssistant/issues/22#issuecomment-1003569655,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO2UB7YL5A2TED5BWM5AJCDUT4JCVANCNFSM5KTQ6JQA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Hello Max ,
thanks a lot for your effort.
I can see the central entity now but the heat mode cannot be acrivates.
Just off, dry and ventilation mode can be activated.
I Wish you a nice evening
Il sab 1 gen 2022, 15:58 max13fr @.***> ha scritto:

Hello,
I just add it in the last version (v1.2.1).
Max
—
Reply to this email directly, view it on GitHub
https://github.com/max13fr/Airzonecloud-HomeAssistant/issues/22#issuecomment-1003569655,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO2UB7YL5A2TED5BWM5AJCDUT4JCVANCNFSM5KTQ6JQA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Hello Max , thanks a lot for your effort. I can see the central entity now but the heat mode cannot be acrivates. Just off, dry and ventilation mode can be activated. I Wish you a nice evening Il sab 1 gen 2022, 15:58 max13fr @.***> ha scritto:
…

I confirm this is the case. With this new version (many thanks @max13fr !!) I can see the main unit and I can even switch modes, but I can't activate the system. Would you be interested in me creating a temporary account for you? is there anything I can do to provide you with the data needed otherwise?

Hello,
Sorry I'm running out of free time right now, but yes I can't reproduce the issue with my hardware so a temporary account would be perfect.
Thanks in advance, Max

Hello,
Sorry I'm running out of free time right now, but yes I can't reproduce the issue with my hardware so a temporary account would be perfect.
Thanks in advance, Max

Hi! I just invited you (I hope). Let me know if you can access my system.
Many many thanks @max13fr

Hello,
Yes it's good for the access.
Ah it's not what I was expecting. What do you expect when you're clicking heating mode on central console ? Turn on all zones ?
Max

@max13fr thanks for your answer. This new component is central to my environment and it can manage all the satellites at once, in terms of target temperature, in terms of mode (heating, cooling or fan) or in terms of global activation/deactivation (global on/off).
So yes, it would be very coherent with what I see in the real world, if this logical component mimiced the physical one in terms of functionality.
Thank you!!! any chance I we could buy you a coffee?

Hi @max13fr did you have the chance to check my message above? is the access that I provided sufficient?
thanks


Error chanel

I have this error that I don't understand

did you find a solution?

@ahmedradwan18 @NathanFlorins  Please provide steps to reproduce error.
Try again with this upgrade or higher


Corey/data split

This PR covers task Create a new train/val from train (possibly need stratification).
Use the pickle_maker.ipynb notebook for creating pickles in your GDrive
Use the --pickle argument with train.py in colab_train.ipynb to specify which pickle you want to train on.
Features

df_pickler module with functions for creating pickle files from dataframes and reading data frames from pickle files

Creates training, validation, and testing datasets (training and validation come from COCO's training, testing comes from COCO's testing)

Notebook file pickle_maker.ipynb for creating pickle files in your google drive
new arg --pickle specifies which pickle you want to consume

If pickle flag not used train.py uses hourglass.load_and_filter_annotations() to generate training and validation dataframes
If the pickle doesn't exist, an error is output and train.py uses hourglass.load_and_filter_annotations() to generate training and validation dataframes

new script anno_dl.sh for downloading only annotation zips.

Potential issues

naming scheme for model folders won't reflect which pickle this came from
stratification is not currently implemented, could result in training and validation sets having unequal representation of different parameters.

I think you accidentally deleted submodules/HeatMap

Overall it looks like a great addition for some much needed data splitting options for us. I haven't fully reviewed it (I'm working on the assignment) but I've left a few comments on things I noticed. Thanks for knocking this off our backlog.


Remove need for independent package restore

Description

Remove need for independent package restore

Motivation and Context

nuget client should now be able to handle it.
speeds up build time.

Types of changes

[ ] Improvement (correction, content improvement, typo fix, formatting)
[ ] New Article (new document for docs website)
[x] Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

[ ] My doc follows the code style of this project.
[ ] I have read the CONTRIBUTING document.

Nuget packages are restored at SLN file level, so there is no way we can have a "global" package folder for all the repos.
I can't see how you can just eliminate the restore step for each repo.......

Noted.


[BUG] Decode endpoint requires the key "data" instead of "invoice"

Describe the bug
The endpoint "/api/v1/payments/decode" requires the key of the body to be "data". The docs reads "invoice". I was trying it with "invoice" and was wondering why I'm receiving an error.
Expected behavior
The docs should be updated to "data" instead of "invoice" at this point.
Screenshots

hi! you should look into the Swagger API, https://legend.lnbits.com/docs#/default/api_payments_decode_api_v1_payments_decode_post
those API docs are just manually managed by the extension developer and tbh. i think it is a pain and we should probably remove it from there and just rely on swagger


ENHANCEMENT: Restart NGINX after renewal of certs

Hey, just a quick one.
I  have just renewed my certs with the script. Works perfectly however I had to manualy restart nginx after the renewals for them to be picked up by the browser.. So it might be worth creating a separate script which can be executed by CRON instead of the suggested CRON line..

Just add another cron line with /etc/init.d/nginx reload at your desired time (i.e. 5 minutes later after executing the script). To me the every 12 hours cron for the script is excessive while one every week it should be enough.

That could be done but it seems a bit of a shortcut, you would be restarting NGinx even if the renewal failed. If this was contained in a shell script, it could renew and then if renewals were successful, then reload/restart nginx.


Update sorting for lighthouse

fixes lighthouse issues for Accessibility

1. Why is this change necessary?
2. What does this change do, exactly?
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-25464
Please use this issue to track the state of your pull request.

Thanks for your Contribution! :blue_heart:


Update the README

We should flesh out our README to add legitimacy, encourage contributors, and explain the nature of the project to newcomers.
At some point, we will also want to add thorough usage documentation, whether in the README or elsewhere, like hexdocs. This can happen over time.
Some resources

Awesome README - Pretty comprehensive set of README resources
A README checklist
Badges by shields.io (for CI build status or other metadata)

Added a badge for CircleCI.


framework not found GT3Captcha

ld: framework not found GT3Captcha
clang: error: linker command failed with exit code 1 (use -v to see invocation)

add $(PROJECT_DIR)/../node_modules/@yyyyu/react-native-geetest-sensebot/ios/SDK to Framework Search Paths in Build Settings tab, just like this

I abble to build my project now. But when i insert this line
import * as RNGeetestSensebot from '@yyyyu/react-native-geetest-sensebot'
Native module cannot be null. Error occured
Error page from my device

Console error message

it looks like link failed.
have you ever been run react-native link @yyyyu/react-native-geetest-sensebot to link library?
you can unlink firstly react-native unlink @yyyyu/react-native-geetest-sensebot, then relink by run  react-native link @yyyyu/react-native-geetest-sensebot or manual link

I done the manual link by adding libRCTGeeTestSensebot.a into Link Binary With Libraries section.
But everytime i run/build the project, it's failed without any error.

try add it to Linked Frameworks and Libraries section in General tab, like this

My project is using RN v0.57.1. I tried fresh install again but it still showing me same error as below image.

the reason for this problem is this library depend on react-native library, if you set up project by react-native init XXX, React and other relative libraries were added to your project. when project compile, React will copy its header files(just like declaration file in typescript) to your project include directory, so the library can be compiled right. i don't know why you project didn't do this, sry i have no macbook currently. you can check project include directory if react directory in it, btw, <React/RCTConvert.h> correspond to XXX/include/React/RCTConvert.h file

I managed to show the Geetest modal but it always auto close after Analysing.... I followed exactly the code from your tutorial.
Following is the message i get from console (onEvent) :-
Validate failed, reason: _21, {     NSErrorFailingURLStringKey = "https://<IP_ADDRESS>/get.php?gt=4faf9dd37eb683586977947ce87a866a&challenge=db6591069310c69cf5727ccc06849892&lang=en-ph&client_type=ios&w=z33h(orseIRe5Vw7053BwIUot3Tpm4XD7HQT(6hPQPA.c126d5bdccd783820910cb219a990fadadff3e2b823d5c07e5744883d1b39f4e7bd41744a17f6a7ac957be96a5e6c0b19b6fa3366d7d6ceeea6baf791d6982c661489718dd87846c1c4b2ab19be65c048aa5ad1ef7f4a179b9edad44754cc8a719b27e6df83e71ddeae20790cc02b2786d57f5eba176f8bd1717dbd7f07f90ec";     NSLocalizedDescription = "not proof";     "error_code" = "error_21";     geetest = "apiService:didFailWithError:";     metadata = "{\"user_error\": \"Error\", \"status\": \"error\", \"error\": \"not proof\", \"error_code\": \"error_21\"}";     "user_error" = Error; }

you have to keep api1 response struct like this
// https://www.geetest.com/demo/gt/register-test
let api1Result = {
  "success": 1,
  "challenge": "f53e91f1df8b5bcab012caea32b1d3de",
  "gt": "4faf9dd37eb683586977947ce87a866a",
  "new_captcha": true
}

from your log, it seems like some error on your server


[] [] Ignore pyenv files

Purpose
Adds .python-version to the gitignore file to allow people to use their own pyenv virtual environments without committing those changes.

Coverage remained the same at 90.108% when pulling bcc46f0d33d4fccb0b223547ca4a019de5f10bcd on birdbrained:ft/ignore-pyenv into 5a660f888d50e38aea338baaadbff5742f96dfff on CenterForOpenScience:develop.

Coverage remained the same at 90.108% when pulling bcc46f0d33d4fccb0b223547ca4a019de5f10bcd on birdbrained:ft/ignore-pyenv into 5a660f888d50e38aea338baaadbff5742f96dfff on CenterForOpenScience:develop.


Add media control

Hi,
I forked your app and modified it to include media controls (play, stop, next, previous, mute, volume up and down).
The problem I encountered is that java (or at least the Robot class) by default can't emulate key presses for special keys like the media keys. I therefore used the jnativehook  library, which I found working just fine (tested on Windows only).
For the moment you need to import the library yourself (I think the GPL license of jnativehook isn't compatible with your MIT license).
Feel free to check my implementation and include it in your build or modify it as you like.
Kind regards

Thanks franzmueller,
I'll have a look into it.


Publish the extension to open-vsx.org too

Feature request summary
It would be great to also have it on open-vsx.org, as it is an open platform.
Rationale
It would make it available to people using VSCodium, Gitpod, etc. It would make for a better experience for more developers, and it would also support open platforms.

Bump. Really need this as there aren't any liquid extensions for Gitpod. I'm considering just making a port...

@charlespwd Yeah I can understand that. If we open a PR or an issue in the open-vsx repo for them to add it, would that work with you?
Also just hijacking this thread to ask if my issue in Shopify/quilt was seen, as well as this issue with submissions that affects multiple people but hasn't been acknowledged (as far as I know) by any Shopify staff...

If we open a PR or an issue in the open-vsx repo for them to add it, would that work with you?

I can't adequately judge if that would incur overhead on our part.
But, if it's not done in Shopify's name, this project is under the MIT license, so you are free to do so :upside_down_smile: (with proper attributions, of course)

As far as I know, it wouldn't cause overhead as open-vsx builds the extension themselves when we open that PR. I'll open a PR on their repo some time this week :) I'll keep the issue open until I've done so, then I'll close it to move the tracking to the PR.


Update installer.js

Will consider this. The only issue with it is it sort of conflicts with the possible web dashboard in v6

This is useless now since we are on Repl


Fix for using library as a transative dep

See https://github.com/shouldly/shouldly/issues/717
I've tested this locally by hacking about with my .nuget/packages folder, it seems to do the trick but could use another pair of eyes.
I've also removed buildMultiTargeting here, as I don't think we need to do an "outer build" import, we only want to operate at a per-tfm basis.

Thanks for this. i will deploy and smoke test


Refactor remote write queue tracking/restarts

Track remote write queues via a map so we don't have to track the index in the remote write array. The queue names in metrics now contain the hash as a string instead of the index in the config array, so they look like this:
prometheus_remote_storage_dropped_samples_total{queue="4d50f478186c47dfcffff29ffbc4b5d4:http://localhost:1235/receive"} 0
prometheus_remote_storage_dropped_samples_total{queue="97f072436c72649a7547e91184322b58:http://localhost:1234/receive"} 0

@csmarchbanks @YaoZengzeng
cc @tomwilkie

closing in favour of #6043


Editor context menu is hard to close

On the latest Insiders on Windows 10:

Open an editor
Right-click on it. A context menu should appear
Click on part of the editor that's not the context menu
:bug: The context menu is still there
Press the escape key while the mouse is not over the context menu
:bug: The context menu is still there
Press the escape key while the mouse is over the context menu
The context menu finally closes

/duplicate of #137785 and fixed ready for tomorrow.


update to v8.1

Hi Guys,
I make quite simple changes to make that working on v8.1.
Best,
Arkadiusz

Thanks, @cleversolutions also had a PR with more or less the same changes :)


2nd page - UI

The results should be more clear:
Label in front of data
Name as the first
If more that 50 responses per search  probably start to page results with a recommendation to specify the query more
Some remarks in attachment

I modified it locally but couldn't take all your suggestions.
I'm using a tabular style now. Please see the version for multiple hits:

and the version with a single hit but multiple entities:

Does that look okay?

I dont see the same layout as in your screenshots above where the Country is on the line above the Entity.
For me the Entity is still bunched against the country, and I the the screenshots aboe with separate lines is a clearer way to display.

This version is not yet live - I wanted to get basic feedback first :)

Ok, I think the (still to be published) view above looks good

Musch nicer still some ocmments.
You still count that ID is more important than name though most probably in Directory most of the searches will be commited by name. I would have the name first and then ID an d all the rest
Then this scrap before the id (iso6523-actorid-upis::), could we possibly remove that?

@allikah1 Please see #14 for how the stuff with the removed iso6523-actorid-upis could look like.

@allikah1 & @clancger  New version is online

@allikah1 has a very good point regarding the name.
I think that the value shuould be at the top, but then the Name should be second.

Ok, I think we're now getting close to where we need to be..
I wolud insert the PEPPOL ENDPOINT, or perhaps just Endpoint in the csae we oneday have non-PEPPOL IDs here. Thats at the top of Business Information and Document Types pages
Full PEPPOL ENDPOINT ID: iso6523-actorid-upis::9932:856922195

Also, on the Document Types page, other than the search term still being visible in the search window at the very top, the Participant name is not shown, so I'd pull that in too, just for clarity

@clancger The text is now: Full PEPPOL participant ID: iso6523-actorid-upis::9915:test
@clancger The name of the entity on top of the document types: this is tricky if many entities are available for a single participant. How shall the names be represented? Or shall we not use tabs at all, and show the document types below???

that's fine
I'd say just the top level name thats shown on the  "Business Information" page.
I think it's cleaner in the tabbed format as we have it now

Ad 2. You mean that if a participant has multiple entities, only the first one is shown (maybe with some "..." afterwards)?

If a participant has multiple entries inside a single Business Card, I'd still be showing no more than the business Card entity name. The reason for showing then headline name on the Capabilities page is just so that a viewer doesnt get confused

This is how it looks now with 3 entities in a single Business Card:

Any changes?
Otherwise I put it on the server like this.

I like it

It will be on the server like this in the next hour.
If you need more, please open a new issue - thx.

HI
Can you once again review the look and feel of search results and Details. Search results is nice but I owuld try t omake details page look like a bit same: Font size, table with…
Ahti
From: Philip Helger<EMAIL_ADDRESS>Sent: Tuesday, May 2, 2017 3:58 PM
To: phax/peppol-directory<EMAIL_ADDRESS>Cc: Allikas Ahti<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [phax/peppol-directory] 2nd page - UI (#9)
It will be on the server like this in the next hour.
If you need more, please open a new issue - thx.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/phax/peppol-directory/issues/9#issuecomment-298627810, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZnvz6ij2n-rIB0zF-6x3QjlXUYwoTeTks5r1yhPgaJpZM4M_8lw.

Okay Ahti - lets work on the details by Skype, and I will create a new issue with the tasks


3dstool does not compile without tweaks

I'm using MSYS2/mingw64, cloned repo, and was trying to use my own libraries, renamed dep to dep1 to make sure it didn't use it, and then ran
mkdir build && cd build
cmake -G "MSYS Makefiles" -DUSE_DEP=OFF ..
make

like suggested, but I had to change <capstone.h> in both code.h and code.cpp to <capstone/capstone.h>, and add capstone to the target_link_libraries() in src/CMakeLists.txt to get it to link right, thought I'd bring it up

It's don't support capstone version 4.0 or master now.
The include folder layout is different between v3 and v4.
USE_DEP means don't use the prebuilt files.
3dstool use capstone as source files, not a library.


[ROCKETMQ-331] Make DLQ queue nums configurable

What is the purpose of the change
As DLQ queue nums is configured to static as
protected final static int DLQ_NUMS_PER_GROUP = 1;

in some cases, we need to get messages from DLQ to recover,but queue nums of DLQ is limited and can't expand load.So I want to change the default DLQ queue nums default value.
Brief changelog
add dlqNumsPerGroup to BrokerConfig
Verifying this change
This is a trivial change.
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.04%) to 39.904% when pulling 956a2ac50aef5bd2fdd791a9c90dac447547dcfa on lindzh:dlq_config into a79c66ae2c4c9431129bd779e42a25afe6e76686 on apache:develop.

Good catch

@lindzh Could you help to resolve the conflicts, thanks.

@vongosling conflicts has been resolved.

@lindzh I will close the pr, if you happened to the same question, please let me know :-)


Migrate resource ec_deployment_traffic_filter to terraform-provider-framework

Migrate resource ec_deployment_traffic_filter to terraform-provider-framework
The behavior of the default_value plan_modifier changes, so it also applies default values when the value has been explicitly specified before.
Unit test timeout increased.
Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Refactoring (improves code quality but has no user-facing effect)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Readiness Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] All new and existing tests passed

@pascal-hofmann , I'm sorry if I missed something, but does it make sense to add migration tests as you did in the previous PR?

@pascal-hofmann , I'm sorry if I missed something, but does it make sense to add migration tests as you did in the previous PR?

I just added the missing migration test.


Revert 58 to fix spotbugs/spotbugs!819

This PR solves a reported problem at the core project.
To avoid potential issues, it also bumps up supported Gradle version from 4.0 to 5.0.

@spotbugs/everyone could you review these changes? thank you!

Updated, please review this PR again @ThrawnCA

Why revert using the worker API? Looks like a bad idea to me, because now you depend on internal APIs again. Shouldn't instead the usage of static state be removed?

I agree with @oehme; using Gradle internal APIs is a step backwards.
If the spotbugs tool can not be quickly remedied to avoid preservation of static state, I suggest that we preserve the public API of SpotBugsTask while avoiding the Worker API or internal APIs. Instead, the @TaskAction method will invoke Project#javaexec(Action); that spawned JVM will then die at the conclusion of the task execution. While this isn't ideal from a performance POV, it should prevent the static state issues identified by @Vampire.

I also believe that it's mandatory to remove dependency on Gradle internal API. This is why I made #104 recently.
At the same time, we need to make this product working. The reverted code in this PR introduced a trouble. To make it stable, I merged this PR after the user test.
Let's find the way to realize stable feature in both of feature and compatibility :)
I believe it's possible even though SpotBugs itself is thread unsafe.

JavaExec seems nice. It will be nice option to solve this issue.

Maybe even a combination of worker api and javaExec could make sense.
Because by using the worker api, tasks are done in parallel up to max-workers amount.
The worker implementation could then spawn a separate process.
This way you have the parallelity and still the isolation.
With the current solution I think the tasks would again be done sequentially only, as would be by only doing a javaExec.

I must admit I haven't looked closely at the holistic issue, but what's problematic about dealing with the printout or dual registration at the point it happens? I don't see a dysfunction in the checkers where they themselves keep static state during analysis.

The problem is the same why in 80% of the cases when you do an invokeLater in Swing to fix a bug you even make it worse.
It is symptom treatment, not bug fixing and you just shift the problem to a less obvious and harder to solve place.
I don't know of whether there are other static things that are already broken in more subtle ways, but speaking of the plugins, imagine two projects A and B that both run with the same Gradle version and thus on the same daemon and the Spotbugs task will run on the same worker (e. g. wih --max-workers 1).
Project A uses the find-sec-bugs plugin, Project B does not.
Now you analyze project B and you get no bugs found.
Next you analyze project A, not warnings, no bugs found.
Now you analyze project B again without any change and (even without warning as there is no double registration) suddenly you get issues found.
Or you analyze A and B with different version of the same plugin, and so on.

@Vampire I totally agree with that assessment. What I'm meaning is that instead of printing a warning for every time a factory is re-registered, why not be pragmatic and warn only once? That doesn't hide the symptom, and it doesn't spam the logs, and you'll get the speedup associated with the worker API.
For sure, there could be cases where your isolation is broken. Is that an issue that people are currently struggling with, or is it more of a theoretical problem at this point?

What do you gain with speedup if you get wrong results? o_O
Besides that, if he follows my suggestion to combine worker-api and javaExec, you are just a bit slower as you need to start a VM each time, but it will still be done in parallel.

@Vampire If people actually do get wrong results, it's not a gain, agreed. In our projects we run the same extensions for SpotBugs for all (hundreds of) modules, so the execution time problem is much more important to solve. The speedup with the worker API and in daemon processing was substantial, reducing the execution time with more than 75%. That being said, we can perform tests with your proposed solution and see if it performs well enough. If it is at least 50% faster than the baseline I'd consider it a success from our point of view, otherwise not.

It was not in-daemon with the worker API.
The isolation level was set to PROCESS, so the tasks are done in separate worker processes, not in the daemon process.
Those were reused though.
I'd guess the most speed gain was because of the parallel execution, so it might speed up enough for you with my proposal, but I might be wrong of course.

You're right, I was under the wrong impression with how the worker API was used.
I'd be happy to test the proposal, so we can know for sure.

I'd like to add to what @davidburstromspotify said that the slowdown is a big deal for larger projects.  We had to roll back to a prior version (1.6.9) of the plugin because it made such a huge difference in our in CI builds.

Feel free to share your idea to solve this problem via PR! :)

note: It is possible to launch SpotBugs by project.javaexec, however it cannot create SpotBugsResult instance because we cannot touch IFindBugsEngine instance after execution.
      ExecResult result = project.javaexec(new Action<JavaExecSpec>() {
		@Override
		public void execute(JavaExecSpec javaSpec) {
			javaSpec.args(spec.getArguments());
			javaSpec.setMain("edu.umd.cs.findbugs.LaunchAppropriateUI");
		}
      });

To keep current feature, we need to avoid using JavaExec, then probably need to hack a classloader?


it is seem too slowly of training speed?

gpu？

Sorry, it may be my version problem, not used gpu processing. Thanks for your replay.


Enable IPv6 zone ID support for HttpRepository

Accomplished by switching to http::Uri rather than url::Url. This
is somewhat unfortunate, as the ergonomics of http::Uri are notably
worse, but the result is that zone IDs work.
For API compatibility purposes, the changes manifest as a new struct
called HttpRepository2 and HttpRepositoryBuilder2. In a subsequent
commit we can delete HttpRepository and rename HttpRepository2.

The CI error looks like an infra configuration problem. How are those normally handled with this repo?

The CI error looks like an infra configuration problem. How are those normally handled with this repo?

Opened https://github.com/heartsucker/rust-tuf/pull/260


Reconciliation of Wikidata URIs fails with "use values as identifiers" operation

Describe the bug
When using the operation "Use values as identifiers" on a column of URIs obtained from Wikidata's SPARQL endpoint, one gets items reconciled to https://www.wikidata.org/wiki/Http://www.wikidata.org/entity/Q160482.
To Reproduce
Steps to reproduce the behavior:

Import in OpenRefine the results of a SPARQL query, such as this one
Use the "Use values as identifiers" operation
Click on a reconciled cell and observe the error

Expected behavior
OpenRefine could magically understand that these cells are URIs and convert them to identifiers properly.
OpenRefine (please complete the following information):

Version 3.1

Potential workarounds
We could take into account the view URL of a service, and match the cell contents to the view URL to extract the URI. However, in the case of Wikidata, that would not work, as the SPARQL URIs and the view URIs used in the interface are different. I could change the view URIs of the reconciliation service to use the RDF URIs but that will require people to remove the service and add it back.
Otherwise, we could also implement a SPARQL importer (#1212) where users could type their SPARQL query, preview it, and create a project from it, directly from OpenRefine. The SPARQL importer would take care of the reconciliation.

Let's clarify what the OpenRefine values are in the column after import in step 1 and what the import method is.
this ?
wd:Q55830412
or this ?
Q55830412
or something else ?
Because when I download from SPARQL query using the "Download as TSV", I already get URLs that look like this:
item
http://www.wikidata.org/entity/Q55830412
http://www.wikidata.org/entity/Q55830494
http://www.wikidata.org/entity/Q55830502
etc...

I like the idea of a SPARQL importer.
But it wouldn't have all the nice features of WDQS online interface, right? (that isn't as powerful)
However, I don't want a lot of overhead in OpenRefine for us to maintain. (that's a worry I have)
I wonder if we could just use the existing WDQS browser interface in OpenRefine somehow...
What if we flipped things around...and WDQS had a "Download ID's" option? or "Download OpenRefine project" option?

When downloading the results of a SPARQL query, the column contains full URIs (http://www.wikidata.org/entity/Q55830494) whereas OpenRefine expects identifiers (Q55830494). One can convert one from the other with an expression such that value.split('/')[-1] but that requires an extra step and confuses newcomers.

Hmm actually we do store the schema space http://www.wikidata.org/entity/ so we can use that too.


memory leak in 2b tests

I found around 3GB memory leak every time I run 2b tests.
And when I run all 2b tests like "go test -run 2B", it will start all 11 tests one by one. Finally memory leak will get to tens of GiB and process will be killed.
Even if I just start the cluster and shut it down immediately, it will result to about 2GB memory leak.

Seems problems happen in badger, not my own code...

Do you use the latest commit? Seems same as https://github.com/tidb-incubator/tinykv/issues/238

Do you use the latest commit? Seems same as #238

I do use the latest commit. I started the talent plan one month ago, but #238 is issued on Jan..

You can follow the way of the issue to check. 2GB memory maybe not a leak, it just due to badger's cache and golang runtime doesn't return the memory back to system in time.


[test] Put shared test projects INPUTS into bundle resources

This avoids depending on the absolute path to the INPUTS and allows looking it up at run time even if the tests have moved.
This required updating to tools version 5.3 to use resource support, and adding several "excludes" to the Package.swift for files that are not recognized by swiftpm.

https://github.com/apple/sourcekit-lsp/pull/322
@swift-ci please smoke test

apple/sourcekit-lsp#322
@swift-ci please smoke test Linux

apple/sourcekit-lsp#322
@swift-ci please smoke test Linux

apple/sourcekit-lsp#322
@swift-ci please smoke test Linux

apple/sourcekit-lsp#322
@swift-ci please smoke test


WIP feat: Improve docker-compose performance

This PR contains some small improvements in the docker-compose performance.
Pull Request type
Feature
Please add the labels corresponding to the type of changes your PR introduces:

Feature
Build-related changes

What is the current behavior?

There are warnings while running the docker-compose when not running it in amd64 architectures (tested in a Mac M1) due to using paritytech/ci-linux as the base container
When you run amd64 containers on Mac, they are runned with some emulator, which leads Cargo to use way more memory (users.rust-lang.org, rust-lang/cargo#10781). In some systems, the cargo build --release will crash while updating the crates.io index

Resolves: #NA
What is the new behavior?

Specified the platform for the container, this way there are no more warnings. Although the performance is not improved by doing this
Use Cargo's new sparse index protocol to reduce the memory footprint of updating the crates.io index (Cargo Sparse Protocol), leading to some performance improvements

The sparse protocol seems to be a nice approach to be used not only for the docker build, but also for the whole project config
An alternative that also reduces the memory footprint (I tested, and it works), is to use the command-line git instead of libgit2. We can do that by appending --config net.git-fetch-with-cli=true to the build command, or add that configurations in the Cargo config file

Does this introduce a breaking change?
No
Other information
This PR was opened as a draft for us to discuss if this is the best approach to go and ignore performance issues on aarch64 (such as Macs Mx and RPi), or if we should support docker on other architectures (replacing paritytech/ci-linux base image).

I'm excited for this one, docker-compose has been crashing on my Mac M1

Do you think we should create a custom base image to support aarch64?

I'll have to test some docker deploys with gh actions in my fork to refactor the docker files. In the meantime, we can merge this one as a temporary fix for running docker in Mac M1
@dbejarano820 after this is merged, please confirm that you can run the docker-compose commands on your Mac


Added sort feature on the basis of views

I have added the sort feature where the profiles will be sorted on the basis of views
closes : #148
https://github.com/user-attachments/assets/7165dde7-a1a5-4fd6-a555-f5655e5e5093

awesome


docstrings/sphinx: Support "Deprecated" sections

Is your feature request related to a problem? Please describe.
The goal is to have a common set of features between all parsers.
Describe the solution you'd like
The Sphinx parser should be able to parse "Deprecated" sections, if it makes any sense.

Closing for cleanup, but if you'd like to work on this, just ask and I'll reopen!


linux_npu_driver for generic linux, not restricted by Ubuntu only

I am not sure if it an issue or a "feature", so will start discussion here.
Can a driver be part of a generic linux core, not tight to Ubuntu only? Some other distros have some compelling features for meteor lake based laptops, so restricting a driver to Ubuntu only will severely restrict NPU based advantages of such laptops.
Thanks

The plan is to have a generic Linux driver as much as possible. Today our testing scope is narrowed to Ubuntu22.04. In future the number of targeted systems will be extended.

I'm using this repo just fine on Fedora 40 Beta.
But to do anything useful you need https://github.com/intel/intel-npu-acceleration-library which is really not supported on non-Ubuntu.

What is the difference between this repo, and the ivpu driver which is already upstreamed?
And, why does the upstream kernel have the ivpu driver, but seemingly no firmware for it is in linux-firmware?

What is the difference between this repo, and the ivpu driver which is already upstreamed?
And, why does the upstream kernel have the ivpu driver, but seemingly no firmware for it is in linux-firmware?

Please, familiarize yourself with README.md and docs/overview.md in linux-npu-driver repository. It explains the software stack. The user-space part is within linux-npu-driver, npu_plugin, level-zero and OpenVINO repositories
The firmware is not in linux-firmware because today the firmware is strictly connected with NPU compiler


Marshalling records & arrays (request)

Can you add Marshalling support for record and arrays too ?
(like in https://github.com/onryldz/x-superobject)
Thank you

Check this project: https://github.com/mauriziodm/DJSON

Does not support multidimensional arrays :(


CAP-1815 support custom sensitive annotations and labels

What does this PR do?
Users can use DD_ORCHESTRATOR_EXPLORER_CUSTOM_SENSITIVE_ANNOTATIONS_LABELS to remove sensitive annotations and labels from Kubernetes resource manifests.
DD_ORCHESTRATOR_EXPLORER_CUSTOM_SENSITIVE_ANNOTATIONS_LABELS is a list that contains keys for sensitive annotations and labels. Datadog agent will scrub any annotations and labels with a matching key.
Example
Set the environment variable:
DD_ORCHESTRATOR_EXPLORER_CUSTOM_SENSITIVE_ANNOTATIONS_LABELS="sensitive-annotations sensitive-labels sensitive-key"

Given the following resource manifest:
{
  "Annotations": {
    "my-annotation": "my-value",
    "sensitive-annotations": "sensitive-annotations-value"
    "sensitive-key":"sensitive-value"
  },
  "Labels": {
    "my-label": "my-value",
    "sensitive-labels": "sensitive-labels-value"
    "sensitive-key":"sensitive-value"
  }
}

The output from the agent will be:
{
  "Annotations": {
    "my-annotation": "my-value",
    "sensitive-annotations": "-"
    "sensitive-key":"-"
  },
  "Labels": {
    "my-label": "my-value",
    "sensitive-labels": "-"
    "sensitive-key":"-"
  }
}

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Feature/winpanda

High-level description
What features does this change enable? What bugs does this change fix?
Corresponding DC/OS tickets (required)

DCOS_OSS-5636 Add Winpanda build scripts. Fix install Python3.6

Related tickets (optional)

DCOS-ID JIRA title / short description.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot changelog-not-required

@mesosphere-mergebot label ready for review

The jenkins failure in this PR is a Jenkins Infrastructure issue and related to the PR.


feat: allow configuring additional linters to run

Extend getChecks to allow an additional list of linters, which is always run. This can be used downstream to e.g. enable the docBlameThm or explicitVarsOfIff linters without modifying batteries.
As part of this, we

update fix the function docstring (which was quite outdated anyway)
remove the useOnly option: the equivalent effect can be achieved by filtering the list of linters afterwards; adding linters cannot, hence must be performed in this function. (That said, I'm happy to add this functionality back if desired.)
rename a variable dflt to the more readable default
adjust the logic of the #lint command accordingly
Note that test/lint_simpNF.lean lies on this (the docBlame linter warns there) - so this changed is already tested.

awaiting-review

I just pushed a commit adding back the useOnly option as runOnly.


Android app crashes on call startPreview method (NullPointerException)

I just faced in my Crashlytics dashboard a report of a fatal error in an Android 10 device with the following log:

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.hardware.Camera.startPreview()' on a null object reference
at com.ahm.capacitor.camera.preview.CameraActivity$4.onPictureTaken(CameraActivity.java:485)
at android.hardware.Camera$EventHandler.handleMessage(Camera.java:1412)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:214)
at android.os.HandlerThread.run(HandlerThread.java:67)

Looking in the CameraActivity.java I found at the end of onPictureTaken method:
} finally {
  canTakePicture = true;
  mCamera.startPreview(); // here is the line 485 that thrown the error
}

How can I fix this? Do I have to add only a verification before like if (mCamera != null) mCamera.startPreview() or it needs to be done in another way?

Hi @IgorSamer sorry to hear you've had a fatal error. Did you find out what you needed to do to fix the problem?

closing since there was no response


Added events and docs

Adds the following:

Added extensions array to constructor to be passed down to the metadata core
"extension" event from the metadata feed to listen on extension messages
extension() method for broadcasting extension messages to peers
.peers getter for getting the current list of peers (useful for stuff like getting the health of an archive)
"peer-add" event from the metadata feed so that actions can be taken when a peer is added (useful for extension stuff)
"peer-remove" event from the metadata feed so that actions can be taken when a peer is removed
"close" event so that actions can be taken when the archive is closed (useful for the SDK)
docs for the "update" event so that people can be aware of it

Ideally these properties and events should be exposed in the RPC API in the daemon down the line, which is why I'd like to surface them at the top level rather than getting people to mess with the metadata feed directly.
TODO:

Tests 😁

Woot! 💜💜


Android studio failed to find your jar

Android studio failed to find the jar file of dependencies.
Error:A problem occurred configuring project ':app'.

Could not resolve all dependencies for configuration ':app:_debugCompile'.
Could not find com.github.rockerhieu:emojicon:v1.0.
Searched in the following locations:
https://jcenter.bintray.com/com/github/rockerhieu/emojicon/v1.0/emojicon-v1.0.pom
https://jcenter.bintray.com/com/github/rockerhieu/emojicon/v1.0/emojicon-v1.0.jar

The latest version is 1.3.3.


Pelican?

If you are going to become a pythonista you could possibly use Pelican http://docs.getpelican.com/en/stable/

I got started with Jekyll off a friend's recommendation, but Pelican looks pretty cool. Thanks for the tip!


Bd2 is not marking as completed when the conditions are fufilled

Bd2 only requires the participation in a sortie (you don't even need to win) to be completed. I have discovered this when I was using 2-3 to farm for fuel with just Ro-500 and happened to be sent to Red in the first node netting me a D-Rank however, this fulfilled the the quest despite not sinking any ships nor getting a win. Furthermore, http://en.kancollewiki.net/wiki/Quests#Bd2 mirrors this idea even though the translation of the quest would suggest that the conditions would be otherwise.

to be sure : 3-2?

3-2 is where you level :p

bleh typo 2-3

Bd2 truly is vague from the start. I discovered that it marks the quest complete in-game so I left it as, as long as you go on a sortie, track it.

However, the current tracker doesn't seem to do that. I could check on the next quest reset to be certain, but I think it looks specifically for the flagship to be sunk.

For now, KC3Kai checks for api_destsf to increase the quest tracking of Bd2. We can remove that to resolve this issue.

oh I didnt know about api_destsf. might need more testing to see what really triggers Bd2

well, what i really wonder is,
after have a talk with @ethrundr yesterday,
about Bd1,2,3,4,5,6 etc.
some of those quests have funny behavior for sure.
maybe he could explain those things (to make it sure again, about its behavior vs description lol)
(don't forget about #422 too lol)

Well just did a test on Bd2, sent 1 DD to 5-5 and it got wrecked thus getting a D-rank. However, this completed the quest which implies that ou just need to sortie to finish it.


Function calls are not supported in decorators in 'NgModule'

Angular Versions
Angular CLI: 1.6.3
Node: 8.3.0
OS: win32 x64
Angular: 5.2.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker
angular/cli: 1.6.3
angular-devkit/build-optimizer: 0.0.38
angular-devkit/core: 0.0.25
angular-devkit/schematics: 0.0.48
ngtools/json-schema: 1.1.0
ngtools/webpack: 1.9.3
schematics/angular: 0.1.13
schematics/schematics: 0.0.13
typescript: 2.4.2
webpack: 3.10.0
The Issue
I am trying to use this package in a large project with lazily loaded modules. I'm not too sure what the cause of the issue is but when I try to import the SSRSReportViewerModule in any module in my app I get the error shown below.

Is there anything I can do to get this to work? Or are some code changes required?

I have the same issue. Did you ever resolve it?

Hi @JonDosmann  @celvin  @beinguam , other obligations have kept me from keeping this up to date.
I have a branch I am working on that will update it to the latest version of Angular that should be out this weekend.  This should fix these issues and introduce improved features and tooling.
Thanks for understanding.


NOISSUE- Fix groups

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
Fixes 404 on groups
Which issue(s) does this PR fix/relate to?
Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)
List any changes that modify/break current functionality
N/A
Have you included tests for your changes?
Not necessary
Did you document any new/modified functionality?
Notes

Why are groups removed from the documentation, and where are they moved now?
Is this removing them just from the index? What about .md file that is the real description?

@rodneyosodo has more context on this.

Why are groups removed from the documentation, and where are they moved now?
Is this removing them just from the index? What about .md file that is the real description?

Initially groups were at https://github.com/rodneyosodo/docs/blob/NOISSUE-format/docs/api.md#groups and https://github.com/rodneyosodo/docs/blob/NOISSUE-format/docs/cli.md#groups-management. With this PR https://github.com/mainflux/docs/pull/146, I updated in the respective places

Is this removing them just from the index?

Yes, it is.


Multithreaded Date Range Based Download

Hello!
I've been modifying the source code to build a multi threaded crawler that downloads tweets in a given date range. I'm using these architecture to download a huge amount of tweets in a cluster. Since it seems to work pretty good I thought about sharing my code. Would you guys find useful this?
PD: I'm using these to download 60M of tweet, that are like 20GB of data. Using a non multithreaded scheme my program would have spent almost a month to download all the data. With the multithreaded scheme I can download it faster.
Cheers,
Victor

I'd be interested. I've also done this, but I could not solve the problem of it not downloading the tweets in chronological order (See #23).
How does your solution work?
Sincerely,
Giulio

Great!
My code splits the given date rage in intervals of days. Let's say you want to download tweets from 2017-09-01 to 2017-10-01. The code will create a partition for each day within the interval.
Once the partitions had been created, I build an array of TwitterCriteria Partitions.
Finally I start a ThreadPoolExecutor that executes each TwitterCriteria in a thread for the given pool of workers.
Each thread will call TweetManager().getTweets() for the given TweetCriteria. Once the download has finished, another job will be assigned to the worker. by the pool executor.
This way, I generate N .csv files ( one csv file per day within the interval ) that contain the tweets published within that day ordered in descending chronological order.
Cheers,
Victor

Also, I'm struggling with the proxies thing. As I'm downloading a 2 years dataset, my IP gets banned every 10-15 days downloaded, so I though about making a proxy pool and rotate proxies for every job using the proxies pool. This also could be easily implemented.

Hi!
During last week, I worked in a multi-threaded tweet extractor. I hadn't looked at the Pull Requests (I'm still not used to the GitHub flow) so I did my own library which uses GetOldTweets3.
I did a workaround which consists in creating a Queue of jobs (user, date) and then each worker creates a tweetCriteria for that specific job and calls the getTweets method. However, when I started testing it with larger time intervals, "429: Too many requests" appeared and I realized that splitting the date range into days might not be the best approach.
So, at this point, I did what I should have done since the beginning, I looked at the PR section and I found that @giulionf was already working on it. Moreover, I have also thught in the proxies pool approach that @Victorpc98 proposes to avoid banning.
Are you still working on it? Why hasn't it been merged yet?
Thanks!

Hey @gegallego !
I can't share my code with you bcs I'm using it for my dissertation but I can explain you what I did.
I'm using a pool of workers where each one of them receives a TweetCreiteria. Each TweetCriteria is a day from the time interval.
About the "429: Too many requests", it's just twitter saying that you should stop asking that much data. The easy thing to avoid this is to simulate human behaviours and use multiple proxies. You could even use a tool to change your ip every x hours.
If you're trying to download a huge dataset and you're not using proxies or dynamic its eventually you'll get blocked by twitter and won't be able to download more.
I downloaded a 2 years dataset of more than 60 million tweets using the worker pool and a proxies pool using between 5 and 10 workers in about 1 month.
Feel free to ask me anything
Victor

Hi @Victorpc98 ,
Thanks for your time! What you describe about giving each worker a TweetCriteria (which is a day in the interval) is exactly the approach I implemented during last week.
I'll try to implement also the periodical change of proxy to avoid the Twitter block, as you propose.
Gerard

@Victorpc98 have you run into the problem where you receive 429 error with just a 1 day interval?

Hey @vonadz !  Personally, when this happened to me I’d wait for a few hours or even a hole day to start the crawler again. This is why I encourage you to use a rotative list of proxies and even tor to dynamically change your ip.
I have to say that even using proxies you can get blank listed too if you’re requesting a lot. If you’re not using multiple proxies I suggest you slow down your requests frequency and even modify the code so that it follows a human behavior. If you keep on requesting a lot there will be a moment when twitter blocks you permanently and you’ll get a 429 forever.
We could easily reproduce human behavior by adding some random wait timers and so on.

@Victorpc98 okay thanks.


Timestamp normalization

Summary
Previously, malformed timestamps in MSH-7 prevented some messages from processing.  Now, processing is more lenient - if additional precision is added to different parts of an otherwise valid HL7 timestamp format, the value is modified to conform to stricter format validation and allowed to process.

This is quite simply an excellent pull request...

Thank you @bamader! I'm blushing. I appreciate all your feedback.