SSE: Unnoticed close when used with HMR

Environment
h3 1.11.1
bun 1.1.3
Reproduction
https://stackblitz.com/edit/github-b7ffrj?file=server%2Fapi%2Fevents.ts
All output is in your browsers devtools.
The reproduction provides an SSE endpoint (/api/events) simply sending events once a second.
The clients app.vue connects to that endpoint, printing out received messages, and additionally a connection status once a second.
To trigger the issue: Add an empty line at the end of the server handler, save the file (to trigger the HMR actions) and observe no more events coming in while the connection is still reported as OPEN.
Describe the bug
An HMR event (such as a change to a server eventHandler handling a SSE connection) kills any open SSE connection without further notice.
I can't tell if this is an issue by h3, nuxt or vueuse (providing the client composable).
Additional context
No response
Logs
No response

What would you expect to be different / how to handle that case? The server is "reset" based on HMR - I'm not sure if we can keep the connection open "reliably" 🤔

Simple workaround for now:
export default eventHandler((event) => {
  const eventStream = createEventStream(event);

  // Send a message every second
  const interval = setInterval(async () => {
    await eventStream.push(`Hello world, it's ${Date.now()}`);
  }, 1000);

  // cleanup the interval and close the stream when the connection is terminated
  // ok
  eventStream.onClosed(async () => {
    clearInterval(interval);
    await eventStream.close();
  });

  if(import.meta.dev) {
    useNitroApp().hooks.hookOnce('close', () => {
      clearInterval(interval);
      eventStream.close();
    })
  }

  return eventStream.send();
});

I'll take that simple workaround! Thanks for that!
It'll take some days for feedback, sorry for that.

Feedback: Works great!
I'd love to see this integrated in h3, but that's up to you 🙇🏼

@max06 The problem is that the workaround involves nitro. Maybe a different nitro integration (e.g. tracking SSEs in dev mode in a weakmap or so) would be helpful.
Moving this to nitro


Added Using DTR Trust Data with a Remote UCP

Proposed changes
This PR will finally add documentation for using DTR Trust Data with remote UCP's, this came in with DTR 2.5. So once this page is finished I can back port to the DTR 2.5 docs too.
The graphic at the beginning is a placeholder, until one with the correct icons is made.
Unreleased project version (optional)

Related issues (optional)

@bermudezmt PTAL :)

Deploy preview for docsdocker ready!
Built with commit 3ae9602269ec01719358c308f4afdb27102139c9
https://deploy-preview-8195--docsdocker.netlify.com

@ollypom when you and @bermudezmt are happy and it's no longer a WIP, go ahead and add me as a reviewer, OK?

Good go to; sorry about the delay.


Improved Testing

More testing coverage!

Coverage increased (+25.6%) to 86.432% when pulling 2f6ed7553620aaf9bf57e1e6e6be9bfe230dba2f on feat/improve-testing into 46998d048d9b3f9676c95672617a1f4a1de69ede on master.

Coverage increased (+25.6%) to 86.432% when pulling 2f6ed7553620aaf9bf57e1e6e6be9bfe230dba2f on feat/improve-testing into 46998d048d9b3f9676c95672617a1f4a1de69ede on master.


Feature request: Path output from run-all

In this issue and the follow up pull request the paths for different states are called output for errors. It would be nice if they were called out in normal operation. This is achievable with --terragrunt-log-level debug, but I wouldn't want to turn it on all the time, and I don't want to have to remember to add it just for run-all. A cleaner version of output like this would be awesome. Then a user could tell which state is which in the output at a glance.
``--terragrunt-log-level debug` output:
DEBU[0023] Module /home/user/git/terraform/aws/development/us-east-2 has finished successfully!  prefix=[/home/user/git/terraform/aws/development/us-east-2]

Thanks for creating this issue, @edgan . We've recently done some working thinking through logging improvements, and this will be addressed with those updates. An RFC will be forthcoming shortly. Leaving this issue open to ensure we meet this need when the RFC is implemented.


Complete to_dict method in image_layer class

Currently the to_dict method in the image_layer class only includes 'packages', 'tar_file' and 'created_by'. Also include 'diff_id' and 'import_str' to the dict. See classes/image_layer.py for details.
This is work towards #70

I'll take this one. :)

@psyonara go for it!

@psyonara someone has already submitted a PR for this. If you still want to work on it, let me know.

@nishakm Cool, no worries. No point in duplicating work. :)

https://github.com/vmware/tern/pull/97 addresses this issue. The commit message referenced the wrong issue number. Closing this.


Create REQUIRED_INSTALLED_APPS for Django projects integrating CloudL…

…aunch
Fix for issue #143
The way this would work for cloudman is in its settings.py you would do
import cloudlaunchserver
INSTALLED_APPS = [
...
] + cloudlaunchserver.settings.REQUIRED_INSTALLED_APPS

Maybe there is a better way though. I still want to see how other Django apps handle this.

@nuwang came up with a different solution, doing an import * from cloudlaunch's settings


Couldn't find a config-punt.json file

I have just set up homebridge on my pi and created a config.json file in  ~/.homebrige . I have placed my config code after the out put of when I attempt to run homebridge. Any assistance is greatly appreciated!
*** WARNING *** The program 'node' uses the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see <http://0pointer.de/avahi-compat?s=libdns_sd&e=node>
*** WARNING *** The program 'node' called 'DNSServiceRegister()' which is not supported (or only supported partially) in the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see <http://0pointer.de/avahi-compat?s=libdns_sd&e=node&f=DNSServiceRegister>
[Wed Sep 21 2016 03:50:10 GMT+0000 (UTC)] Loaded plugin: homebridge-homeassistant
homebridge API version: 2
[Wed Sep 21 2016 03:50:10 GMT+0000 (UTC)] Registering platform 'homebridge-homeassistant.HomeAssistant'
[Wed Sep 21 2016 03:50:10 GMT+0000 (UTC)] ---
[Wed Sep 21 2016 03:50:17 GMT+0000 (UTC)] Loaded plugin: homebridge-punt
homebridge API version: 2
[Wed Sep 21 2016 03:50:17 GMT+0000 (UTC)] Registering platform 'homebridge-punt.punt'
[Wed Sep 21 2016 03:50:17 GMT+0000 (UTC)] ---
[Wed Sep 21 2016 03:50:17 GMT+0000 (UTC)] Loaded config.json with 0 accessories and 1 platforms.
[Wed Sep 21 2016 03:50:17 GMT+0000 (UTC)] ---
[Wed Sep 21 2016 03:50:17 GMT+0000 (UTC)] Loading 1 platforms...
[Wed Sep 21 2016 03:50:17 GMT+0000 (UTC)] [HomeAssistant] Initializing HomeAssistant platform...
Booting Platform
[Wed Sep 21 2016 03:50:17 GMT+0000 (UTC)] [HomeAssistant] Fetching HomeAssistant devices.
Load homebridge-punt.punt
Couldn't find a config-punt.json file at /root/.homebridge/plugins/homebridge-punt.

my config.json file looks like this
{
    "bridge": {
        "name": "Homebridge",
        "username": "CC:22:3D:E3:CE:30",
        "port": 51826,
        "pin": "031-45-154"
    },

    "platforms": [
        {
            "platform": "HomeAssistant",
            "name": "HomeAssistant",
            "host": "http://<IP_ADDRESS>:8123",
            "password": "yourapipassword",
            "supported_types": ["light", "switch", "media_player", "scene", "rollershutter"]
        }
    ]
}

I feel as if I am very close to getting this to work...

hi. i suspect you should re-submit this issue at https://github.com/cflurin/homebridge-punt/issues ... it looks to me that the issue is in the homebridge-punt repo, not this repo.  (if i'm wrong, sorry for the redirect!)

Thanks. I put my issue there.


Wording Error in Ruleset Documentation at phpmd.org/rules/index.html

"Design Rules: The Code Size Ruleset contains a collection of rules that find software design related problems."
Should be:
Design Rules: The Design Ruleset contains a collection of rules that find software design related problems.

Resolved in https://github.com/phpmd/phpmd/commit/c51ea72761fdaf38c1787658f07e2d20b1141ae0
Thanks for reporting!


Update Collaborators.md to Include Deema's Fave Resturaunt

Full Name: Deema Saddik
Fave Resturaunt: Red Lobster

This assignment was really confusing. Will this be explained in class?


fix: the sign up CTA should only be shown if not signed in

Screenshots

Closing this in favor of #68


Grant write permission to auto-issue-assigner

Summary

Auto-issue-assigner GH action pipeline is not working for now since it doesn't have write permissions: https://github.com/openvinotoolkit/datumaro/actions/runs/4933109608/jobs/8816769441#step:2:11.

How to test

Checklist

[ ] I have added unit tests to cover my changes.
[ ] I have added integration tests to cover my changes.
[ ] I have added the description of my changes into CHANGELOG.
[ ] I have updated the documentation accordingly

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below).

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Codecov Report
Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (38bbf0c) 78.75% compared to head (492769e) 78.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #995      +/-   ##
===========================================
- Coverage    78.75%   78.72%   -0.03%
===========================================
  Files          233      233
  Lines        26626    26626
  Branches      5283     5283
===========================================
- Hits         20969    20962       -7
- Misses        4424     4428       +4
- Partials      1233     1236       +3

Flag
Coverage Δ

macos-11_Python-3.8
?

ubuntu-20.04_Python-3.8
78.72% <ø> (ø)

windows-2019_Python-3.8
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Two minor typos

Two typos I noticed trying to run the examples.
Actually, shouldn't it be 0.4.0rc0 though?

Btw, I still get errors here:
docker run --rm kaczmarj/neurodocker:0.4.0rc0 generate singularity --base ubuntu:18.04 --pkg-manager apt --ants version=2.2.0

Traceback (most recent call last):
  File "/usr/bin/neurodocker", line 11, in <module>
    load_entry_point('neurodocker', 'console_scripts', 'neurodocker')()
  File "/opt/neurodocker/neurodocker/neurodocker.py", line 349, in main
    subparser_functions[namespace.subsubparser_name](namespace)
  File "/opt/neurodocker/neurodocker/neurodocker.py", line 302, in generate
    print(recipe_obj.render())
  File "/opt/neurodocker/neurodocker/generators/singularity.py", line 108, in render
    self._fill_parts()
  File "/opt/neurodocker/neurodocker/generators/singularity.py", line 165, in _fill_parts
    impl(params)
  File "/opt/neurodocker/neurodocker/generators/singularity.py", line 32, in base
    "singularity base must be in the form `docker://...` or"
ValueError: singularity base must be in the form `docker://...` or `shub://...`

This:
docker run --rm kaczmarj/neurodocker:0.4.0rc0 generate  docker   --base ubuntu:18.04 --pkg-manager apt --ants version=2.2.0 | docker build - works, by the way.

hi @jona-sassenhagen - thank you for the pull request. you are right that the docker image tag should not be 0.4.0 — that was me being hasty. and thank you for finding the typos!
the --run-bash option will be added in #160. can you please add --run-bash back into this pull request?
then i can merge this PR and I will update the docker image tags in the readme to 0.4.0rc1 and release 0.4.0 release candidate 1. does that sound good?
by the way, you can always use kaczmarj/neurodocker:master. i purposely do not include a latest tag because i want users to use a versioned image.

Done.
--no-check-urls was also giving me errors, is it also gonna come in some PR?

@jona-sassenhagen - yes, i am updating those examples in #160. i'll merge that and release 0.4.0rc1 shortly after.

Great.


trigger build

I'm closing everything here now.
Current up-to-date builds can be found in the integration ticket over at https://github.com/reduxjs/redux-toolkit/pull/1016


Give better description of IE9 transparent click bug & workaround

CC: @mdo for review

Have you checked if clean-css changes that to transparent?

Apparently<EMAIL_ADDRESS>does rewrite it to transparent... :scream:
Wanna file a bug? :sweat_smile:

https://github.com/jakubpawlowicz/clean-css/issues/699

On a side note, does that other comment we have in Gruntfile still apply?
        // TODO: disable `zeroUnits` optimization once clean-css 3.2 is released
        //    and then simplify the fix for https://github.com/twbs/bootstrap/issues/14837 accordingly

Yes, it does: https://github.com/twbs/bootstrap/blob/f564c683f776173c1dc828cc6095358c0fd4d74c/scss/_tables.scss#L118

But it's commented out there :S
If we still need it, we should check clean-css' advanced properties toggling and set this off that way.

But it's commented out there :S

Not anymore :smile: 7d766e4a94299f811e8eab522bfb128a350cca4a

Filed #18144 to track the zeroUnits TODO.

@XhmikosR Anyway, does this PR LGTY? It just updates the comment. We can open another issue for the clean-css problem.

Yeah it's fine. Already tracking #18144; I'll see when I'll have some time to look into it.

Filed #18145 to track the clean-css problem.


ARROW-10947: [Rust][DataFusion] Optimize UTF8 to Date32 Conversion

After adding benchmarking capability to the UTF8 to Date32/Date64 CAST functions there was opportunity to improve the performance.
This PR uses inbuilt chrono functionality to calculate the number of days since CE then uses a constant to calculate the offset days relative to 1970-01-01. This improves performance around 10% for this operation relative to the since function presumably as chrono does not have to ensure the from_ymd is a valid date.
Before:
cast utf8 to date32 512 time:   [41.966 us 42.508 us 43.087 us]
cast utf8 to date32 512 time:   [40.591 us 40.661 us 40.740 us]
cast utf8 to date32 512 time:   [40.825 us 40.878 us 40.916 us]

After:
cast utf8 to date32 512 time:   [36.557 us 36.839 us 37.200 us]
cast utf8 to date32 512 time:   [35.997 us 36.442 us 36.919 us]
cast utf8 to date32 512 time:   [35.750 us 35.969 us 36.160 us]

Codecov Report

Merging #8943 (639fb71) into master (71e37e2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #8943   +/-   ##
=======================================
  Coverage   83.26%   83.27%
=======================================
  Files         195      195
  Lines       48066    48062    -4
=======================================
- Hits        40024    40022    -2
+ Misses       8042     8040    -2

Impacted Files
Coverage Δ

rust/arrow/src/compute/kernels/cast.rs
96.77% <100.00%> (-0.01%)
:arrow_down:

rust/arrow/src/csv/reader.rs
94.33% <100.00%> (+0.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cedab0...639fb71. Read the comment docs.


Update to 1.19.0

This is being worked on. Our Discord will have more information when it's coming.


Fix mail filters

With the previous configuration, I was unable to have more than one mail filter, no matter what I tried to put in my configurations to override the default.
After this change, the following syntaxes all work to override the filter:

application.properties
<EMAIL_ADDRESS>
Result: one filter<EMAIL_ADDRESS>
application.properties
blossom.mail.filters=test<EMAIL_ADDRESS>
Result: two filters<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
application.properties
<EMAIL_ADDRESS><EMAIL_ADDRESS>
Result: two filters<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
application.yml
blossom.mail.filters<EMAIL_ADDRESS>
Result: one filter<EMAIL_ADDRESS>
application.yml
blossom.mail.filters:
  -<EMAIL_ADDRESS>  -<EMAIL_ADDRESS>
Result: two filters<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Coverage remained the same at 57.441% when pulling d180447b86eb21a58fbfa48cbfb33e7c303a30a6 on RLejolivet:fix-mail-filters into 6ad60dd70c39987bfb6195c0003c7b220c07cf36 on blossom-project:master.


Read additional configs from $XDG_CONFIG_HOME/kanshi/config.d/

This is so wdisplays can write its config file without having to mess with any user-supplied files. It could also make use of #50 to be able to write a "Do not edit" comment at the top of the generated config.

I'm a little worried about implicitly loading configs under the hood. I probably just worry too much though. The alternative would be to add support for a directive like include whatever/*.

After some testing I think this is not the right approach either. Closing, will make another PR that supports an include directive.


Bump intl to 0.18.0, implement new overrides

@12people I was already thinking about it but, in my own experience, intl 18 support is still very low and I couldn't move any of my current apps, anyway. :-) Do you think it will bring benefits now?

@12people What's more problematic, I don't think we can, actually. If I change it, I get the following error:
Because l10n_esperanto depends on flutter_localizations from sdk which depends on intl 0.17.0, intl 0.17.0 is required.
So, because l10n_esperanto depends on intl ^0.18.0, version solving failed.

I had the impression that we needed to wait for the new SDK arriving with Dart 3 to do that, isn't this so?

@deakjahn I made this PR specifically because the latest version of flutter_localizations (the officially recommended i18n package) depends on intl 0.18.0. And since I upgraded to the latest version of Flutter (released yesterday), I can't build my app due to l10n_esperanto being incompatible.
So I would say definitely. :)
If an app relies on an older version of Flutter, they could simply choose to use an older version of  l10n_esperanto.

I had the impression that we needed to wait for the new SDK arriving with Dart 3 to do that, isn't this so?

Yup, but it was released yesterday. :)
Just run flutter upgrade on your machine and you should get the latest SDK.

@12people Oh, dear me, dandy, I was looking forward to the new patterns and records for some time now. :-)
I haven't built anything yet today, I didn't see the upgrade warning but I didn't get anything yesterday. Maybe later in the day?

Yes, of course, in that case. I'm looking up what else we need to change, whether the sdk in the environment needs to be bumped up as well. I check out the news now.

@12people Oh, dear me, dandy, I was looking forward to the new patterns and records for some time now. :-)
I haven't built anything yet today, I didn't see the upgrade warning but I didn't get anything yesterday, either. Maybe it was later in the day?

@deakjahn I use VSCodium rather than Android Studio, so I'm used to upgrading manually via flutter upgrade rather than getting upgrade notifications.
I'm pretty sure you can just run flutter upgrade in your Terminal and get the update that way.

I use VSCode for most anything now (from PHP to TS), but I'm so well established with Flutter in AS where I originally started that I'm hesitant to move over... :-) I, too consider VSC to be probably the best of the currently available IDEs, just that caution...

At any rate, did you find anyting yet about whether we need to change the SDK setting in pubspec.yaml? I read the notification and the changelog and a few other things now but nothing about that yet.

@deakjahn Nothing official, but I have noticed that Flutter's community packages (the "plus_plugins") have had updates yesterday that brought up the SDK and Flutter versions to:
environment:
  sdk: ">=2.18.0 <4.0.0"
  flutter: ">=3.3.0"

(See device_info_plus or share_plus, for example.)

Let's hope for the best. I'll check out my apps where I've been really waiting for the new language constructs and some of the UI changes are welcome, too.

Yep, in my app depending on this:
Because flutter_cupertino_localizations 1.0.1 doesn't support null safety and no versions of flutter_cupertino_localizations
match >1.0.1 <2.0.0, flutter_cupertino_localizations ^1.0.1 is forbidden.

And https://pub.dev/packages/flutter_cupertino_localizations/versions confirms that it isn't compatible. What do you do about that in your app?

Now that I visited the project page, it doesn't seem important, something abandoned, I wonder where I did pick it up and why I had it as a dependency in the first place... :-)


Dall-E not working for local editor

Investigation needed. See comments in https://github.com/lastmile-ai/aiconfig/pull/715#issuecomment-1875577409

May be related to https://github.com/lastmile-ai/aiconfig/issues/720

Fixed in https://github.com/lastmile-ai/aiconfig/pull/739


minZoom doesn't work

Smaller images are imported and they are not fit to width or height like v2.0. Tried minZoom but has no effect. Here is what I have for the settings.. please help!
$imageCropper.cropit({
			imageBackground: true,
			exportZoom: 2,
			imageBackgroundBorderWidth: [0, 25, 0, 25],
			rejectSmallImage : false,
			minZoom: 'fill',
			onZoomDisabled: function(){
				$imageZoomBar.addClass('inactive');
			},
			onZoomEnabled: function(){
				$imageZoomBar.removeClass('inactive');
			},
			onImageError : function(err){
				console.log('cropit.onImageError ' + err.message);
			},
		});

minZoom: 'fit'

@guntherkoo Thanks for posting the issue. This is a scenario that I did not consider. I'll make some change to support it now.

Fixed in 9bdefa8bb51d6ccd4486f965dbf447f009193fb3.

@guntherkoo if you upgrade to<EMAIL_ADDRESS>and use { smallImage: 'stretch' } it'll fill/fit the container, depending on minZoom option.


PopScope not checked in BottomSheet

Steps to reproduce

Run the sample app added below.
Open the modal sheet
Close it by using the back button or swiping it down.

Expected results
Bottom sheet should not be closed, and instead the onPopInvoked callback should be executed with didPop set to false.
Actual results
Bottom sheet is closed, and the onPopInvoked callback ise executed with didPop set to true.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Builder(builder: (context) {
        return Scaffold(
          body: Center(
            child: ElevatedButton(
                child: Text('Open bottom sheet'),
                onPressed: () {
                  Navigator.of(context).push(
                    ModalBottomSheetRoute(
                      builder: (context) {
                        return PopScope(
                          canPop: false,
                          onPopInvoked: (didPop) {
                            debugPrint('didPop: $didPop');
                          },
                          child: Container(
                            height: 200,
                            color: Colors.red,
                          ),
                        );
                      },
                      isScrollControlled: false,
                    ),
                  );
                }),
          ),
        );
      }),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.1, on macOS 14.5 23F79 darwin-arm64, locale en-GB)
    • Flutter version 3.22.1 on channel stable at /Users/yvesdelcoigne/fvm/versions/3.22.1
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a14f74ff3a (9 weeks ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/yvesdelcoigne/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/yvesdelcoigne/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode-15.3.0.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.90.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.92.0

[✓] Connected device (5 available)
    • sdk gphone64 arm64 (mobile)     • emulator-5554             • android-arm64  • Android 12 (API 31) (emulator)
    • Yves’s iPhone (mobile)          • 00008120-001219A82687C01E • ios            • iOS 17.5.1 21F90
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 14.5 23F79 darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome 126.0.6478.62

[✓] Network resources
    • All expected network resources are available.

• No issues found!

With how I understand how PopScope works, the root cause is found in the _ModalBottomSheetState build method, specifically in the implementation of the onClosing function:
onClosing: () {
  if (widget.route.isCurrent) {
    Navigator.pop(context);
  }
},

should be
onClosing: () {
  if (widget.route.isCurrent) {
    Navigator.maybePop(context);
  }
},

Other implications might be involved, to reset the animation of the bottom sheet to its original state.

Thanks for the report @DelcoigneYves
Can you check https://docs.flutter.dev/release/breaking-changes/android-predictive-back and see if it helps in your case or not ?
Also check https://github.com/flutter/flutter/issues/144074 and https://github.com/flutter/flutter/issues/138614

Hi @darshankawar
I checked your references, and while the NavigatorPopHandler was new for me, it did not solve my problem (as it is not related to nested Navigators).
The issue above is also not relevant when the user taps the Android back button (then it is handled correctly), the issue is specifically when the user swipes away the bottom sheet.

Thanks for the details. See https://github.com/flutter/flutter/issues/129829 for reference.

Thank you for your response. However, I'm afraid the issue is not related. It was my bad, I added the back button in my steps to reproduce, while it is only when swiping down the bottom sheet that the issue occurs. I've updated the original issue to make it more clear.

Thanks for the details. I do see the reported behavior on latest versions and likely root-cause as mentioned https://github.com/flutter/flutter/issues/152120#issuecomment-2243496684
stable: 3.22.3
master: 3.24.0-1.0.pre.273

@DelcoigneYves Do you expect that the bottom sheet doesn't move at all during the back gesture?
Typically PopScope is used for system back gestures. I guess it makes sense that it would block this too, though. I know it's often used for showing a confirmation dialog when the user tries to navigate back, which might make sense here.

Hi @justinmc
I didn't think about the back gesture yet, but my first thought would be indeed that the bottom sheet remains in place.
Showing the confirmation dialog is exactly the usecase we are trying to implement!

@DelcoigneYves As you pointed out this call to Navigator.pop forces the pop to succeed, even though you are blocking pops with PopScope. If we changed it to Navigator.maybePop then it would not succeed.
https://github.com/flutter/flutter/blob/e66ce1591f17e5e1c2b3310cf0a64c8a28b3fff5/packages/flutter/lib/src/material/bottom_sheet.dart#L749
However, the bottom sheet would still allow you to drag it closed, and would be stuck in that position without further code changes.
Do you want the bottom sheet to not move at all? Have you seen ModalBottomSheetRoute.enableDrag?

Hi @justinmc
I'm indeed aware of the enableDrag property, however I would like to keep the dragging enabled, and, when the user releases the drag, have the bottom sheet revert the drag (basically animating back to the position it had before the drag started).
Indeed more code changes would be necessary for that, but I'm not sure where or what these changes should be, any help there would be appreciated.

any fix for this? I have the same problem with the modal. I can prevent tapping outside the modal, but if I drag it down the end it bypasses the prevention


Lab Manual Changes and initial bot code

Three main things here:

Changed .png to .PNG because the images were broken in the lab manual
Told the users to set location to West US (only one with Cog Service keys right now and Build is in Seattle)
Template code for bot, so you can more easily see my changes in future diffs

@jennifermarsman I'm good with all of these changes, feel free to merge.


TgBot-0: create Sketelon Spring boot project

Create skeleton Spring boot project for TgBot.
Acceptance criteria:
Spring boot project created.

Implemented in https://github.com/maksimprivalov/subscriptions_telegrambot/pull/7


Repl on website not working anymore

I'm not sure since when this feature is broken but the repl on the website isn't working anymore (tested with current Firefox and Chrome). There is no sample that is shown up and no text can be typed into the box.
https://markmap.js.org/repl/
And by the way:
The link "New feature: load markmap from Gist!" is giving me a 404.

It may be a network problem since the data is loaded from Gist now.
Can you confirm if you are able to open https://api.github.com/gists/af76a4c245b302206b16aec503dbe07b?

The link "New feature: load markmap from Gist!" is giving me a 404.

The link you pasted here is incorrect. Here is the correct link and works for me.

Can you confirm if you are able to open https://api.github.com/gists/af76a4c245b302206b16aec503dbe07b?

This is what I see:

The link you pasted here is incorrect. Here is the correct link and works for me.

The link you provided works but I just copied the link from the website which leads to the 404:

For some reason CodeMirror fails to load in your browser and leads to other problems. I've changed a bit and it should work now even without CodeMirror. Could you please confirm it?

Closing as it works now


[IS 5.6.0] Include derived attributes also in the SCIM2 User creation response.

Description

The response does not include derived attributes when create a user using SCIM2 request

Request
curl -v -k --user admin:admin --data '{"userName":"xxxx","password":"kimwso2"}' --header "Content-Type:application/json" https://localhost:9443/scim2/Users
Response:
{"meta":{"created":"2019-04-19T18:22:13Z","location":"https://localhost:9443/scim2/Users/99cc7a79-eb8f-4344-b7ac-62e11e99d3e4","lastModified":"2019-04-19T18:22:13Z","resourceType":"User"},"schemas":["urn:ietf:params:scim:schemas:core:2.0:User","urn:ietf:params:scim:schemas:extension:enterprise:2.0:User"],"id":"99cc7a79-eb8f-4344-b7ac-62e11e99d3e4","userName":"xxxx"}

But in when List Users and List User by ID include derived attributes in the response

List user request:
curl -v -k --user admin:admin 'https://localhost:9443/scim2/Users/'
Response:
{"totalResults":3,"startIndex":1,"itemsPerPage":3,"schemas":["urn:ietf:params:scim:api:messages:2.0:ListResponse"],"Resources":[{"emails":["admin@wso2.com"],"meta":{"created":"2019-04-19T18:16:06Z","lastModified":"2019-04-19T18:16:06Z"},"roles":[{"type":"default","value":"Internal/everyone,admin"}],"name":{"givenName":"admin","familyName":"admin"},"id":"afc03988-3b34-4897-b88c-b83dc788245b","userName":"admin"},{"meta":{"created":"2019-04-19T18:20:16Z","location":"https://localhost:9443/scim2/Users/eb13095d-8138-41ab-9a47-45738a9c1492","lastModified":"2019-04-19T18:20:16Z","resourceType":"User"},"roles":[{"type":"default","value":"Internal/everyone"}],"name":{"familyName":"jackson"},"id":"eb13095d-8138-41ab-9a47-45738a9c1492","userName":"kim"},{"meta":{"created":"2019-04-19T18:22:13Z","location":"https://localhost:9443/scim2/Users/99cc7a79-eb8f-4344-b7ac-62e11e99d3e4","lastModified":"2019-04-19T18:22:13Z","resourceType":"User"},"roles":[{"type":"default","value":"Internal/everyone"}],"name":{"familyName":"xxxx"},"id":"99cc7a79-eb8f-4344-b7ac-62e11e99d3e4","userName":"xxxx"}]}

When we do not include those attributes in the user creation response, It will impact for the scenarios where if we are doing response processing. Therefore we need to improve SCIM2 user creation flow to include derived attributes also in the user creation response.

@nilasini can we close this issue ?


Fs update

fsGroupchangePolicy  is set - https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#configure-volume-permission-and-ownership-change-policy-for-pods . so that it does not change fs group every time volume is mounted when pod is restarted


Issue with chapter link template tags in markdown

https://cs-field-guide-dev.appspot.com/en/chapters/coding-encryption/substitution-ciphers/
In this example, in the pink Tractability – problems that take too long to solve box at the end of the page, there is a link to a different chapter.
In the markdown file, this is tagged as:
[whole chapter about tractability]('chapters:chapter' 'complexity-tractability')
However, instead of generating a link to the chapter, i.e:
https://cs-field-guide-dev.appspot.com/en/chapters/complexity-tractability (Does not exist yet)
it appends information to the link to the current page:
https://cs-field-guide-dev.appspot.com/en/chapters/coding-encryption/substitution-ciphers/'chapters:chapter'%20'complexity-tractability'

This is the case regardless of whether or not the destination has been created

The same behaviour has been found for templates:
[text]('chapters:chapter_section' 'chapter' 'section') and
[text]('interactives:interactive' 'slug'?parameters)

I listed useful information I found about the link syntax in #946

I listed useful information I found about the link syntax in #947

For the specific example talked about in the description, the tag should be complexity-and-tractability, however this doesn't change the result


GPU memory issue Windows 10

I have recently installed SuRVos on two Windows 10 machines and it is constantly crashing, even when only small data sets are being used (smaller than those I tested SuRVos on when at Diamond). I received the following as an error when computing supervoxels on one of the computers:
[GPU] Selected CUDA device: 0
[GPU] Device 0: "GeForce GTX 1060 6GB" with compute capability .1, 1024 threads pb.
[CUDA ERROR] Memcpy back: an illegal memory access was encountered
QObject: :~Timers cannot be stopped from another thread
Both computers have Python 3.6 and Anaconda3 running on them.

Can you please send me a dataset so that i can replicate the error.
On Thu, May 31, 2018 at 9:31 AM, ememuri<EMAIL_ADDRESS>wrote:

I have recently installed SuRVos on two Windows 10 machines and it is
constantly crashing, even when only small data sets are being used (smaller
than those I tested SuRVos on when at Diamond). I received the following as
an error when computing supervoxels on one of the computers:
[GPU] Selected CUDA device: 0
[GPU] Device 0: "GeForce GTX 1060 6GB" with compute capability .1, 1024
threads pb.
[CUDA ERROR] Memcpy back: an illegal memory access was encountered
QObject: :~Timers cannot be stopped from another thread
Both computers have Python 3.6 and Anaconda3 running on them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DiamondLightSource/SuRVoS/issues/46, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAovcW3yyjrLNiXn5w_xklv0knjjTGyZks5t36p6gaJpZM4UUoY7
.

temporary measure is to change the ROI to 64, 128,256,512,1024 cubes.

I have now fixed this bug and uploaded the latest version. Let me know if you encounter anymore bugs.

Hi Sri,
Below is a link to the folder with the data sets and workspace that has
caused the problem. The workspace is the Test_1 folder. However, I have
tried other data sets and have had the same problem so it does not seem to
be data/specific. With the  Test_1 workspace, survos crashes when we try to
calculate the frangi filter or when we try to reduce the size of the
supervoxels. Another error that I have received when computing the frangi
filter is below the link.
Cheers,
Emily Baird
/CT_2/Inga
https://<IP_ADDRESS>:8001/portal/apis/fileExplorer/share_link.cgi?link=hzZXA78xFtmRKZ21Ph1OE0
Computing Feature: frangi
compute_channel

Loading data into memory
Rescaling data
Computing feature frangi
Computing Hessian Matrix
Padding data

Computing gaussian (radius=(3, 3, 3))
[GPU] Selected CUDA device: 0
[GPU] Device 0: "GeForce GTX 970" with compute capability 5.2, 1024 threads
pb.

Computing Hessian Eigenvalues
[GPU] Reusing device (0) with 1024 threads
.[CUDA ERROR] SRC & KERNEL & DST: out of memory
QObject::~QObject: Timers cannot be stopped from another thread

On 31 May 2018 at 10:59, Srikanth Nagella<EMAIL_ADDRESS>wrote:

Can you please send me a dataset so that i can replicate the error.
On Thu, May 31, 2018 at 9:31 AM, ememuri<EMAIL_ADDRESS>wrote:

I have recently installed SuRVos on two Windows 10 machines and it is
constantly crashing, even when only small data sets are being used
(smaller
than those I tested SuRVos on when at Diamond). I received the following
as
an error when computing supervoxels on one of the computers:
[GPU] Selected CUDA device: 0
[GPU] Device 0: "GeForce GTX 1060 6GB" with compute capability .1, 1024
threads pb.
[CUDA ERROR] Memcpy back: an illegal memory access was encountered
QObject: :~Timers cannot be stopped from another thread
Both computers have Python 3.6 and Anaconda3 running on them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DiamondLightSource/SuRVoS/issues/46, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAovcW3yyjrLNiXn5w_
xklv0knjjTGyZks5t36p6gaJpZM4UUoY7>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DiamondLightSource/SuRVoS/issues/46#issuecomment-393463903,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMgqNbcZf_KFiklS3smPqEyheJwwh2flks5t37D6gaJpZM4UUoY7
.

Ahh. got the problem. your datasets are more than 1024pixels in width / height. SuRVoS - 1 only supports 1024pixel images. you can either resize your datasets or you can select a ROI in the tab and select region. remember that total pixels in each dimensions should be less than 1024pixels.


Refactoring run_agent_on so that it functions as expected.

When testing a module one would usually use the apply_manifest_on
method, which applies all the command line options and allows you
to validate the exits codes. When testing in a multi-node scenario
with one master host and one agent host you are unable to do that.
With windows, the multi-node test is a requirement.
The run_agent_on method does not provide the same flexibility in
apply detailed-exit-codes and being able to validate against them.
This change aims to solve that problem by making it function in the
same way as the apply_manifest_on method.

retest this please

:red_circle: Test failed.
Refer to this link for build results: http://jenkins-beaker.delivery.puppetlabs.net/job/Beaker Combined Smoketest/412/

retest this please

:red_circle: Test failed.
Refer to this link for build results: http://jenkins-beaker.delivery.puppetlabs.net/job/Beaker Combined Smoketest/430/

I need to look deeper, but this is currently breaking puppetdb testing with:
Test Case<EMAIL_ADDRESS>reported: #<RuntimeError: PuppetAcceptance::DSL::Helpers.with_puppet_running_on failed (check backtrace for location) because: can't convert Symbol into Integer

retest this please

:red_circle: Test failed.
Refer to this link for build results: http://jenkins-beaker.delivery.puppetlabs.net/job/Beaker Combined Smoketest/432/

retest this please

I need to dig into the test output here so that I can give you a workable log.  Sorry for the delay!

:red_circle: Test failed.
Refer to this link for build results: http://jenkins-beaker.delivery.puppetlabs.net/job/Beaker Combined Smoketest/461/

Okay, the logs are full of -
Test Case tests/environment/use_enc_environment_for_files.rb reported: #<RuntimeError: PuppetAcceptance::DSL::Helpers.with_puppet_running_on failed (check backtrace for location) because: can't convert Symbol into Integer
/var/lib/jenkins/workspace/qe_beaker_intn-sys_vpool-foss-master@2/layout/64mcd-64/platform/centos7/lib/beaker/dsl/helpers.rb:1020:in []' /var/lib/jenkins/workspace/qe_beaker_intn-sys_vpool-foss-master@2/layout/64mcd-64/platform/centos7/lib/beaker/dsl/helpers.rb:1020:in block in run_agent_on'
/var/lib/jenkins/workspace/qe_beaker_intn-sys_vpool-foss-master@2/layout/64mcd-64/platform/centos7/lib/beaker/shared/host_manager.rb:95:in run_block_on' /var/lib/jenkins/workspace/qe_beaker_intn-sys_vpool-foss-master@2/layout/64mcd-64/platform/centos7/lib/beaker/dsl/patterns.rb:32:in block_on'
/var/lib/jenkins/workspace/qe_beaker_intn-sys_vpool-foss-master@2/layout/64mcd-64/platform/centos7/lib/beaker/dsl/helpers.rb:1017:in `run_agent_on'

The line 1020 is:
on_options[:acceptable_exit_codes] = Array(opts[:acceptable_exit_codes])

Which suggests that that the way the opts are being passed into this method is not a hash.
Can you confirm this? Any chance of gist-ing the code where the run_agent or run_agent_on code is being called in your tests.
I can then create a unit test to properly replicate this behaviour.

@liamjbennett this is the step in question:
https://github.com/puppetlabs/puppetdb/blob/master/acceptance/setup/pre_suite/30_generate_ssl_certs.rb

@justinstoller awesome thanks. Will get a test for this.

@liamjbennett  is this ready for a re-test?

Sorry, not yet.

Could you close this out till you are ready for review/test?

Going to close this out for now.  Please re-open when you are ready for test + review.

Here's your associated beaker jira bug:
https://tickets.puppetlabs.com/browse/BKR-22


ChatPane.razor compile error in start solution

ChatPane.razor line 309:
await chatService.ClearCacheAsync();
but the method is called
ChatService.CacheClearAsync,

ChatService.cs line 195 defines the method ClearCacheAsync()

CacheClearAsync is a function in CosmosDbService,  ChatService has ClearCacheAsync. Please elaborate the issue.

It's fixed now, thanks


Variadic and template specializations for serialize and deserialize

Describe the issue (if no issue has been made)
A clear and concise description of what the issue is. Explain the difference between the expected and the current behavior.
A screen shot or copy of the error could be helpful as well.
Serialize and Deserialize were 2 large functions. I thought it might become hard to manage.
PR impact (Make sure to add closing keywords)
List of related issues/PRs this will solve:
I took a different approach than the previous ideas I had in https://github.com/TheCherno/Hazel/issues/496. Instead of changing AllComponents, I altered my function to accept more template arguments. So this way we are serializing TagComponent.
	template<typename... PrefixComponent, typename...Component>
	static void SerializeEntityComponents(ComponentGroup<Component...>, YAML::Emitter& out, Entity entity)
	{
		SerializeEntityComponents<PrefixComponent..., Component...>(out, entity);
	}

	template<typename... PrefixComponent, typename...Component>
	static void DeserializeEntryComponents(ComponentGroup<Component...>, YAML::detail::iterator_value& entity, Entity& deserializedEntity)
	{
		DeserializeEntryComponents<PrefixComponent..., Component...>(entity, deserializedEntity);
	}

	static void SerializeAllEntityComponents(YAML::Emitter& out, Entity entity)
	{
		SerializeEntityComponents<TagComponent>(AllComponents{}, out, entity);
	}

	static void DeserializeAllEntryComponents(YAML::detail::iterator_value& entity, Entity& deserializedEntity)
	{
		DeserializeEntryComponents(AllComponents{}, entity, deserializedEntity);
	}

Impact
Issue/PR

Issues this solves
None

Other PRs this solves
None

Proposed fix (Make sure you've read on how to contribute to Hazel)
A short description of what this fix is and how it fixed the issue you described.
This gives you a separate function for each component, for both serializing and deserializing. I grouped them by Component and placed them at the bottom of SceneSerializer.cpp. The default catch all case is deleted so if you add a new Component to AllComponents then you will get a compile time error. So you know what you forgot and can fix it.
Additional context
Add any other context about the solution here. Did you test the solution on all (relevant) platforms?
If not, create a task list here.
I didn't do anything with NativeScriptComponent because I don't know enough about it. Are we planning to serialize it? I just put a TODO there.
	template<>
	static void SerializeEntityComponent<NativeScriptComponent>(YAML::Emitter& out, Entity entity)
	{
		//TODO: serialize NativeScriptComponent?
	}

	template<>
	static void DeserializeEntryComponent<NativeScriptComponent>(YAML::detail::iterator_value&, Entity&)
	{
		//TODO: deserialize NativeScriptComponent?
	}

I just merged the upstream/master into my branch as it was several months old. I wanted to make sure stuff was still working. 6e309d4
I noticed CircleCollider2DComponent was missing from Deserialize and Serialize code. So I added that. c64ec68
Texture wasn't being saved.  OpenGLTexture does store a path. So I added a virtual GetPath() function. So we had something to serialize. https://github.com/TheCherno/Hazel/issues/561 c64ec68

I need to like cherry pick this pull request I'm really only chaning like 4 files but it's showing all these other files. It's all because I merged in upstream changes. I'm not sure what the best way to do it is....

This pull request was originally on dev and now on it's master. Some of the changes in my pull request are from dev.
entt.hpp Entity.h are included but I haven't touched those files. TheCherno made those commits.
There was one commit I accidentally reverted. So I had a revert revert. 7b19ce5

I cherry picked my commits and reset this branch so I no longer had anything from the dev branch in my pull request.

Cherno added TexturePath and Tiling Factor.
Main thing I did differently is I checked to see if the path exists on saving.
I resolved the merge conflicts from the latest stream.
TODO I need to pull the code down and make sure it still builds. I thought I was done and deleted my files heh.


how do you integrate it to laravel 5.2??

Any instructions on how to integrate it to the AuthController that comes?. thanks

There is no instruction as it is not integrated perfectly yet. But, you can use the 'ldap' keyword in your auth.php config file to reference ldap authentication. I'll try to give you a working exemple soon.
Xavier


Prevent traceback in PM recipient matching code.

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, thanks @showell!


Fixed SSR hydration case

EDIT: I have included a simple fix for this. There may be a better way to do this (I'm still new to the codebase) but tests now pass.
This PR adds a failing test that demonstrates the problem below:
Upon hydrating the following DOM

Hello worldFoo

an uncaught error is thrown: TypeError: Cannot read property 'firstChild' of undefined
The source of the error is this line in hydrateStaticVElement

It appears tests for this PR are currently failing due to a pre-existing TypeScript compilation error that is currently on the dev branch (the browser tests pass in the build log).

LGTM!


Environment XML transformation not applied

I have selected the "XML transformation" checkbox but the step is ignoring transformation for environment unique config files.
I have web.config, web.Release.config and web.Staging.config, the release config is applied but not the staging config, I have tried to remove the web.Release.config and only use web.Staging.config but without success.
The log says: "XML Transformations applied successfully"
17-03-23T09:53:15.8593344Z ==============================================================================

2017-03-23T09:53:15.8593344Z Task         : IIS WebApp Deploy(Preview)

2017-03-23T09:53:15.8593344Z Description  : Deploy a Website or Web Application using WebDeploy

2017-03-23T09:53:15.8593344Z Version      : 0.0.11

2017-03-23T09:53:15.8593344Z Author       : Microsoft Corporation

2017-03-23T09:53:15.8593344Z Help         : [More Information](https://aka.ms/iiswebappdeployreadme)

2017-03-23T09:53:15.8593344Z ==============================================================================

After more investigation i found out the build is deleting web.Release.config and web.Staging.config.
I moved out some configuration to separate files, for example connectionString.Staging.config and not it's included in the artefact drop and the release task makes the transformation.

This issue doesn't belong to this repo, going forward for any issues related IIS WebApp Deploy you can post https://github.com/Microsoft/vsts-tasks/issues


Release Pisco

Codecov Report

Merging #440 into master will increase coverage by 0.06%.
The diff coverage is 97.22%.

@@            Coverage Diff            @@
##           master    #440      +/-   ##
=========================================
+ Coverage   95.83%   95.9%   +0.06%
=========================================
  Files          91      94       +3
  Lines        3049    3074      +25
  Branches      266     272       +6
=========================================
+ Hits         2922    2948      +26
  Misses         86      86
+ Partials       41      40       -1

Impacted Files
Coverage Δ

datahub/omis/market/metadata.py
100% <ø> (ø)
:arrow_up:

datahub/metadata/serializers.py
100% <ø> (ø)
:arrow_up:

datahub/search/management/commands/sync_es.py
85.71% <ø> (ø)
:arrow_up:

datahub/omis/core/exceptions.py
100% <100%> (ø)

datahub/search/views.py
93.54% <100%> (-0.4%)
:arrow_down:

datahub/omis/quote/urls.py
100% <100%> (ø)

datahub/search/company/views.py
100% <100%> (ø)
:arrow_up:

datahub/company/urls.py
100% <100%> (ø)
:arrow_up:

datahub/company/serializers.py
98.94% <100%> (+1.04%)
:arrow_up:

datahub/omis/urls.py
100% <100%> (ø)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91bf2fb...e44d6e6. Read the comment docs.


Added merge command

Dear @peteward44 ,
I added the merge command which supports the --revision option.
I also added a full test that demonstrates the command works as expected and updated the readme.
I am not proficient to svn, so of course feel free to improve my PR.
If everything is ok, please try to merge it asap.
Thanks,
Michele

Thanks, i've released v1.1.0 with this in :+1:

Great! :)


Possible Memory Leak

Describe the bug
We were trying to follow the example in examples/mnist_transferability.py. We used the exact same data set (MNIST) to train the same Keras model. The code file is provided here and the model file is here. Everything works so far.
Then, we repeatedly generate adversarial data by using PGD and CW inside a for loop (31 iterations. After about 5 iterations, the program was killed by the Operating System because memory usage keeps rising (we have 45 GB of RAM available before running the code).
I tried to do garbage collection but that didn't help. I printed out the size of all objects in locals() (line 44 of the code) and observed that none of them increases RAM Usage after each iteration. So I think there may be memory leak in the ART library.
I'm tagging @jinglin80 for follow ups.
To Reproduce
Steps to reproduce the behavior:

Download the model file here
Download the code here
Execute the code in the same directory as the model file python3 cifar_seed.py

Expected behavior
RAM Usage keeps increasing until the Operating System kills the program
System information (please complete the following information):

OS: Ubuntu 18.04.4 LTS
Python version: 3.7.6
ART version or commit number: 1.1.1
TensorFlow 2.0.0

Hi @minhhpham Thank you very much for using ART and raising this issue! We will investigate it as soon as possible.

Hi @minhhpham and @jinlin80,
I have made a few test runs with your script and model. I was able to see a quite dramatic increase in memory usage from the beginning during the iterations with attack_cw (Carlini&Wagner) using TensorFlow 2.0.0 as reported by you above. This increase completely disappears if I upgrade to TensorFlow 2.1.0 as recommended, therefore I think this memory leak is caused by TensorFlow 2.0.0 and not by ART, which is also support by multiple related issues e.g. https://github.com/tensorflow/tensorflow/issues/33030.


Format JSON responses that were unformatted

Use pretty printing for the remanining JSON responses that were on a
single line.

Current coverage is 64.18% (diff: 50.00%)

No coverage report found for master at 3c02db2.

Powered by Codecov. Last update 3c02db2...714b377


Tests for version_deps.go

Coverage increased (+1.07%) to 72.741% when pulling 4762280d5922e7171ca6ba55ee8355413b811ac6 on feature/verdeps-tests into c6db1e08e1f6a8acf476afa10614a43888f7ab24 on master.


Keyboard disable

Summary of the Pull Request
What is this about?
This pull request implements disabling keys/shortcuts.
Thanks @jmahlers for a fair amount of work with it, link to his pull request
PR Checklist

[x] Applies to #2215
[x] CLA signed. If not, go over here and sign the CLA
[x] Tests added/passed
[x] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
An Artificial Disable key was added. The code of the key is 0x100 which does not overlap with windows keys.
The disable key was only included into 'Mapped to' column as it does not make sense to include it to key/shortcut column.
Disable for shortcuts works only for exact matches. For example, if you set Ctrl+A->Disable and then press Ctrl+Shift+A no keys will get disabled.
Validation Steps Performed
Tested all cases.
How does someone test & validate?
One can try it in Keyboard Manager settings or mess with unit tests.

Remapping to disable works because it calls SendInput on (WORD)VK_DISABLE sometimes which is interpreted as 0x01 which doesn't actually do anything. This should be changed so that we do not SendInput on that

I think it should map VK_DISABLE to 0 since it is equal to 0x100, isn't it?
It seems like if we decided to treat shortcut disable as key remap and was not concerned with sending 0 key events It would require adding only new disable key without tweaking any existing logic.

Remapping to disable works because it calls SendInput on (WORD)VK_DISABLE sometimes which is interpreted as 0x01 which doesn't actually do anything. This should be changed so that we do not SendInput on that

I think it should map VK_DISABLE to 0 since it is equal to 0x100, isn't it?
It seems like if we decided to treat shortcut disable as key remap and was not concerned with sending 0 key events It would require adding only new disable key without tweaking any existing logic.

@mykhailopylyp right, my mistake, its 0x0. I still think we should avoid sending key events with 0x0 since that is an undocumented key code which could have side effects. Currently 0xFF is the only undocumented key code we use for dummy keys and we have got an issue of a side effect of that on WSL on Windows Terminal, so using undocumented keys could have issues in the future

@arjunbalgovind

I still think we should avoid sending key events with 0x0 since that is an undocumented key code which could have side effects. Currently 0xFF is the only undocumented key code we use for dummy keys

I agree.

@arjunbalgovind,
I think that a good way to fix the following issue is do not show Disable in the dropdown. Do you agree?

https://github.com/microsoft/PowerToys/blob/39c61b9abd5d401d166f8d8b6a4dead81218502a/src/modules/keyboardmanager/common/Helpers.cpp#L99-L108
Along with that, I noticed that it would be good to have boxList of ComboBoxItems so we can attach key code as value. In that way, we can throw away indexes logic so we do not have to rely on the exact order in the two arrays(key codes and key code names). What do you think?
It will help if we want to keep different amount of keys in different orders for dropdowns.
Should we implement it in this pull request or create separate issue?

@mykhailopylyp

I think that a good way to fix the following issue is do not show Disable in the dropdown. Do you agree?
I think that would be the ideal way to fix it, but I'm guessing that might be more difficult since there could be many cases? (Like someone may delete a drop down by selecting None so another drop down's list may have to be refreshed, which could mess up an existing selection). That's why when this was initially made we went the route of showing warnings when a user selects A & B together for example rather than making the drop down show only modifiers/only action keys. It sounds like it could be a lot of changes.

Along with that, I noticed that it would be good to have boxList of ComboBoxItems so we can attach key code as value. In that way, we can throw away indexes logic so we do not have to rely on the exact order in the two arrays(key codes and key code names). What do you think?
It will help if we want to keep different amount of keys in different orders for dropdowns.
Should we implement it in this pull request or create separate issue?

This sounds good, but I think it's better to create a separate issue for this to keep the scope of this PR smaller. I think while the change to ComboBoxItems is made it could also be possible to do the "not show Disable in the drop down" and similar for modifier/action keys. Like it could be something like if there is only 1 drop down you can choose any key, and if there are more, the non-last dropdowns will have only modifier keys and the last one again allows you to choose any (except Disable since that is a separate case). Since a lot more features have been added in this code space recently (like key to shortcut/shortcut to key, disable being added now, etc) I think there are some places for cleaning up the UI code like this.

One UI case where it is possible to select Modifier+Disable (I've mentioned in a separate comment the missing code)
There is one more place in the ShortcutControl file where GetKeyCodeList has to be replaced with the new version. For the first call it should have renderDisabled as false and for second it should be true

It is two more reasons to implement https://github.com/microsoft/PowerToys/issues/6913

does this implement @jmahlers's PR from https://github.com/microsoft/PowerToys/pull/6236 or the two are related but independent?

It was built on top of it, adding tests and implementing the shortcut disable feature as well, along with some tweaks


More than one Azure Keyvault

As in this page,
Response to this returns access token. Does this mean that for this VM, same "access token" is to be used irrespective of key vault resource, if more than one, where secret is stored?
$response = Invoke-WebRequest -Uri 'http://<IP_ADDRESS>/metadata/identity/oauth2/token?api-version=2018-02-01&resource=https%3A%2F%2Fvault.azure.net' -Method GET -Headers @{Metadata="true"}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 294128ee-aa91-8f63-f2e1-04b1ec5db5bc
Version Independent ID: 681f180d-73a6-0388-a49f-6b3cba481cf9
Content: Tutorial: Use a managed identity to access Azure Key Vault - Windows - Azure AD
Content Source: articles/active-directory/managed-identities-azure-resources/tutorial-windows-vm-access-nonaad.md
Service: active-directory
Sub-service: msi
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@prashantma Thank you for your feedback . We will investigate and update the thread further.

@prashantma, Everytime you run the Invoke-WebRequest command on the VM, it would hit the AAD and try to get a new access token. Now if you are trying to get this access token for a specific Azure Key Vault, then in the access token in the audience section you would find something like https://vault.azure.net this is a common endpoint for fetching a token for the Azure Key Vault resource.
When you actually use this access token, thats when you need to specify the specific Azure KeyVault's name so that the data can be fetched from that specific Key Vault using the access token.
Also, an access token is valid for one hour by default, hence you can make multiple calls to keyvaults using a single access token issued to this VM within one hour timespan. After that again you would need to fetch another token.
But keep one thing in mind, everytime you run the "Invoke-WebRequest -Uri 'http://<IP_ADDRESS>/metadata/identity/oauth2/token?api-version=2018-02-01&resource=https%3A%2F%2Fvault.azure.net' -Method GET -Headers @{Metadata="true"}" It would hit AAD and get you a new Access Token.
Hope this helps.
Do let us know if there are any more queries around this. If no more queries, do let us know so that we can close this thread on our end.

If one of the keyvaults is for production secrets, and other is for dev/uat secrets, and each of them have managed identity to respective vms in production or dev/uat. Is additional setup necessary to prevent unwanted access requests to production keyvault from dev/uat vms?

@prashantma, In each KeyVault, there is a section Access Policies where you add a resource and provide specific set of permissions to that resource and only that resource would have access to keyvault. In your case its the Managed Identity that would be added to a specific KeyVault's access policies section. Hence whenever that managed identity tries to fetch any object from KeyVault with a valid token issued from AAD, it would be able to make a successful attempt, If some other managed identity makes an attempt on that that particular key vault where its not a part of the access policies the attempt would fail.

Closing this thread since no more updates on this.


[Semantic Scholar] Generate Bibtex for a reference

Extension – Semantic Scholar
Author: @blainerothrock
Thanks for this awesome extension @blainerothrock. Would you be open to adding an action for generating and copying a Bibtex reference to the clipboard?
If yes, I'd be happy to make a PR!
Who will benefit with this feature?
Citing a paper using Raycast.
Any Other info.
This could be implemented with the request:
curl --location --request GET 'https://doi.org/10.1007/b97644' \
--header 'Accept: application/x-bibtex'

@book{2004,
	doi = {10.1007/b97644},
	url = {https://doi.org/10.1007%2Fb97644},
	year = 2004,
	publisher = {Springer-Verlag},
	title = {Guide to Elliptic Curve Cryptography}
}

Yes, that is a great addition! I honestly could use this today ha. Looking forward to the PR!

@blainerothrock Do you mind if I use the Raycast template to make a Raycast themed icon as well?

Not at all! I have no ties to the current logo.

I've created a PR for this at #1022.
Unfortunately I realised that Semantic Scholar is missing DOIs for a number of papers that I have tried to cite, so I've also hidden the option if it's unavailable.
Let me know what you think!


How do I load trained models? (20 news groups example)

After running the run_20newsgroups.py I got model.ckpt, .meta, and .index files in logdir_yymmdd_nnnn. So I tried loading the model by:
from lda2vec import utils, model
'import numpy as np
# Path to preprocessed data
data_path  = "data/clean_data"
# Whether or not to load saved embeddings file
load_embeds = True

# Load data from files
(idx_to_word, word_to_idx, freqs, pivot_ids,
 target_ids, doc_ids, embed_matrix) = utils.load_preprocessed_data(data_path, load_embed_matrix=load_embeds)

# Number of unique documents
num_docs = len(np.unique(doc_ids))
print('Num docs: %f'%num_docs)
# Number of unique words in vocabulary (int)
vocab_size = embed_matrix.shape[0]
print('Vocab size: %f'%vocab_size)
# Embed layer dimension size
# If not loading embeds, change 128 to whatever size you want.
embed_size = embed_matrix.shape[1] if load_embeds else 128
print('Embed size: %f'%embed_size)
# Number of topics to cluster into
num_topics = 16
# Epoch that we want to "switch on" LDA loss
switch_loss_epoch = 5
# Pretrained embeddings
pretrained_embeddings = embed_matrix if load_embeds else None
# If True, save logdir, otherwise don't
save_graph = True
num_epochs = 100
batch_size = 8192 #4096

# Initialize the model
m = model(num_docs,
          vocab_size,
          num_topics,
          embedding_size=embed_size,
          pretrained_embeddings=pretrained_embeddings,
          freqs=freqs,
          batch_size = batch_size,
          save_graph_def=save_graph,
          restore=True,
          logdir='logdir_191205_2320')

# Train the model
# m.train(pivot_ids,
#         target_ids,
#         doc_ids,
#         len(pivot_ids),
#         num_epochs,
#         idx_to_word=idx_to_word,
#         switch_loss_epoch=switch_loss_epoch)

# Visualize topics with pyldavis
utils.generate_ldavis_data(data_path, m, idx_to_word, freqs, vocab_size)

and I am getting a following error:
/Lda2vec-Tensorflow/tests/twenty_newsgroups
Using TensorFlow backend.
Num docs: 10722.000000
Vocab size: 5196.000000
Embed size: 300.000000
WARNING:tensorflow:From /home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/lda2vec-0.16.10-py3.6.egg/lda2vec/Lda2vec.py:40: The name tf.ConfigProto is deprecated. Please use tf.compat.v1.ConfigProto instead.

WARNING:tensorflow:From /home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/lda2vec-0.16.10-py3.6.egg/lda2vec/Lda2vec.py:43: The name tf.Session is deprecated. Please use tf.compat.v1.Session instead.

2019-12-09 21:12:17.346986: I tensorflow/core/platform/cpu_feature_guard.cc:145] This TensorFlow binary is optimized with Intel(R) MKL-DNN to use the following CPU instructions in performance critical operations:  AVX512F
To enable them in non-MKL-DNN operations, rebuild TensorFlow with the appropriate compiler flags.
2019-12-09 21:12:17.378228: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-12-09 21:12:17.378444: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x55617ec28b80 executing computations on platform Host. Devices:
2019-12-09 21:12:17.378460: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): <undefined>, <undefined>
2019-12-09 21:12:17.378600: I tensorflow/core/common_runtime/process_util.cc:115] Creating new thread pool with default inter op setting: 2. Tune using inter_op_parallelism_threads for best performance.
WARNING:tensorflow:From /home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/lda2vec-0.16.10-py3.6.egg/lda2vec/Lda2vec.py:105: The name tf.train.import_meta_graph is deprecated. Please use tf.compat.v1.train.import_meta_graph instead.

WARNING:tensorflow:From /home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/tensorflow/python/training/saver.py:1282: checkpoint_exists (from tensorflow.python.training.checkpoint_management) is deprecated and will be removed in a future version.
Instructions for updating:
Use standard file APIs to check for files with this prefix.
2019-12-09 21:12:17.862352: W tensorflow/compiler/jit/mark_for_compilation_pass.cc:1412] (One-time warning): Not using XLA:CPU for cluster because envvar TF_XLA_FLAGS=--tf_xla_cpu_global_jit was not set.  If you want XLA:CPU, either set that envvar, or use experimental_jit_scope to enable XLA:CPU.  To confirm that XLA is active, pass --vmodule=xla_compilation_cache=1 (as a proper command-line flag, not via TF_XLA_FLAGS) or set the envvar XLA_FLAGS=--xla_hlo_profile.
Traceback (most recent call last):
  File "visualize_20newsgroups.py", line 56, in <module>
    utils.generate_ldavis_data(data_path, m, idx_to_word, freqs, vocab_size)
  File "/home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/lda2vec-0.16.10-py3.6.egg/lda2vec/utils.py", line 172, in generate_ldavis_data
  File "/home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/lda2vec-0.16.10-py3.6.egg/lda2vec/utils.py", line 67, in prepare_topics
AssertionError: Vocabulary size did not match size of word vectors

The preprocessing step  generates numpy matrices and pickle files with files for word-to-index, index-to-word, embedding vectors, etc.
$ ls -l data/clean_data
total 205744
-rw-r--r--  1 davidlaxer  staff     85064 Apr  8  2019 doc_lengths.npy
-rw-r--r--  1 davidlaxer  staff   8551328 Apr  8  2019 embedding_matrix.npy
-rw-r--r--  1 davidlaxer  staff     28632 Apr  8  2019 freqs.npy
-rw-r--r--  1 davidlaxer  staff     68335 Apr  8  2019 idx_to_word.pickle
-rw-r--r--  1 davidlaxer  staff  96531372 Apr  8  2019 skipgrams.txt
-rw-r--r--  1 davidlaxer  staff     68335 Apr  8  2019 word_to_idx.pickle

what do you see running ‘wc’ on the following files:

(ai) MacBook-Pro:twenty_newsgroups davidlaxer$ wc data/clean_data/embedding_matrix.npy
8461<PHONE_NUMBER>328 data/clean_data/embedding_matrix.npy
(ai) MacBook-Pro:twenty_newsgroups davidlaxer$ wc data/clean_data/word_to_idx.pickle
732    3312   68335 data/clean_data/word_to_idx.pickle
(ai) MacBook-Pro:twenty_newsgroups davidlaxer$ wc data/clean_data/idx_to_word.pickle
732    3312   68335 data/clean_data/idx_to_word.pickle

what’s the size of ‘word_embed'?
word_embed = m.sesh.run(model.w_embed.embedding)

is it the dimension as wc data/clean_data/embedding_matrix.npy

On Dec 9, 2019, at 1:22 PM, KyungB<EMAIL_ADDRESS>wrote:
After running the run_20newsgroups.py I got model.ckpt, .meta, and .index files in logdir_yymmdd_nnnn. So I tried loading the model by:
from lda2vec import utils, model
'import numpy as np
Path to preprocessed data
data_path  = "data/clean_data"
Whether or not to load saved embeddings file
load_embeds = True
Load data from files
(idx_to_word, word_to_idx, freqs, pivot_ids,
target_ids, doc_ids, embed_matrix) = utils.load_preprocessed_data(data_path, load_embed_matrix=load_embeds)
Number of unique documents
num_docs = len(np.unique(doc_ids))
print('Num docs: %f'%num_docs)
Number of unique words in vocabulary (int)
vocab_size = embed_matrix.shape[0]
print('Vocab size: %f'%vocab_size)
Embed layer dimension size
If not loading embeds, change 128 to whatever size you want.
embed_size = embed_matrix.shape[1] if load_embeds else 128
print('Embed size: %f'%embed_size)
Number of topics to cluster into
num_topics = 16
Epoch that we want to "switch on" LDA loss
switch_loss_epoch = 5
Pretrained embeddings
pretrained_embeddings = embed_matrix if load_embeds else None
If True, save logdir, otherwise don't
save_graph = True
num_epochs = 100
batch_size = 8192 #4096
Initialize the model
m = model(num_docs,
vocab_size,
num_topics,
embedding_size=embed_size,
pretrained_embeddings=pretrained_embeddings,
freqs=freqs,
batch_size = batch_size,
save_graph_def=save_graph,
restore=True,
logdir='logdir_191205_2320')
Train the model
m.train(pivot_ids,
target_ids,
doc_ids,
len(pivot_ids),
num_epochs,
idx_to_word=idx_to_word,
switch_loss_epoch=switch_loss_epoch)
Visualize topics with pyldavis
utils.generate_ldavis_data(data_path, m, idx_to_word, freqs, vocab_size)
and I am getting a following error:
/Lda2vec-Tensorflow/tests/twenty_newsgroups
Using TensorFlow backend.
Num docs: 10722.000000
Vocab size: 5196.000000
Embed size: 300.000000
WARNING:tensorflow:From /home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/lda2vec-0.16.10-py3.6.egg/lda2vec/Lda2vec.py:40: The name tf.ConfigProto is deprecated. Please use tf.compat.v1.ConfigProto instead.
WARNING:tensorflow:From /home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/lda2vec-0.16.10-py3.6.egg/lda2vec/Lda2vec.py:43: The name tf.Session is deprecated. Please use tf.compat.v1.Session instead.
2019-12-09 21:12:17.346986: I tensorflow/core/platform/cpu_feature_guard.cc:145] This TensorFlow binary is optimized with Intel(R) MKL-DNN to use the following CPU instructions in performance critical operations:  AVX512F
To enable them in non-MKL-DNN operations, rebuild TensorFlow with the appropriate compiler flags.
2019-12-09 21:12:17.378228: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-12-09 21:12:17.378444: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x55617ec28b80 executing computations on platform Host. Devices:
2019-12-09 21:12:17.378460: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): ,
2019-12-09 21:12:17.378600: I tensorflow/core/common_runtime/process_util.cc:115] Creating new thread pool with default inter op setting: 2. Tune using inter_op_parallelism_threads for best performance.
WARNING:tensorflow:From /home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/lda2vec-0.16.10-py3.6.egg/lda2vec/Lda2vec.py:105: The name tf.train.import_meta_graph is deprecated. Please use tf.compat.v1.train.import_meta_graph instead.
WARNING:tensorflow:From /home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/tensorflow/python/training/saver.py:1282: checkpoint_exists (from tensorflow.python.training.checkpoint_management) is deprecated and will be removed in a future version.
Instructions for updating:
Use standard file APIs to check for files with this prefix.
2019-12-09 21:12:17.862352: W tensorflow/compiler/jit/mark_for_compilation_pass.cc:1412] (One-time warning): Not using XLA:CPU for cluster because envvar TF_XLA_FLAGS=--tf_xla_cpu_global_jit was not set.  If you want XLA:CPU, either set that envvar, or use experimental_jit_scope to enable XLA:CPU.  To confirm that XLA is active, pass --vmodule=xla_compilation_cache=1 (as a proper command-line flag, not via TF_XLA_FLAGS) or set the envvar XLA_FLAGS=--xla_hlo_profile.
Traceback (most recent call last):
File "visualize_20newsgroups.py", line 56, in
utils.generate_ldavis_data(data_path, m, idx_to_word, freqs, vocab_size)
File "/home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/lda2vec-0.16.10-py3.6.egg/lda2vec/utils.py", line 172, in generate_ldavis_data
File "/home/ec2-user/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/lda2vec-0.16.10-py3.6.egg/lda2vec/utils.py", line 67, in prepare_topics
AssertionError: Vocabulary size did not match size of word vectors
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/nateraw/Lda2vec-Tensorflow/issues/62?email_source=notifications&email_token=AAXWFW75MGGPQNJAAVKHKOLQX2ZKFA5CNFSM4JYSQK72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7IXOZQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXWFW6JTD7LR5TL5XT254TQX2ZKFANCNFSM4JYSQK7Q.

@dbl001 is correct. your error is happening in the pyldavis section. Seems your model loaded fine (unless there are some underlying issues with model load that cause that piece to fail). I'm taking a look now.

@KyungB do you have the version on master branch installed? If not, do that as a first step. Next, I'd make sure you are using the same preprocessed data as was used to train your model. The error you received is a simple assertion I included at the top of that function. If you used different data to train the model you are trying to visualize topics for, you will almost definitely get that error.
Here is a colab notebook where we run the example, restore the model, and then launch PyLDAvis. Closing this as I was able to get it to run there.

Thank you for your quick responses. It was because of the change in data apparently.


Fix error hanndling of JSONata expression editor for extennded functions

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

Current JSONata editor reports extended functions $flowContext and $globalContext as not testable but not reports for $env, $moment, and $clone.
This PR makes all these functions reported as not testable.
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 68.341% when pulling b0d12c41251529f4b7aefad8e2581df920a2e6f7 on node-red-hitachi:fix-extended-function-error-handling-of-jsonata-editor into a5d7f7acceb4c77d1e91feca63a3619164d8b06b on node-red:master.


Linting improvements

Description
Adding some improvements over the ESLint checks:

Enabling validations from Visual Studio Code when opening from root path (for flat config files).

Changing end of line check to auto. To avoid linting errors after pulling the repo due to end of line mismatches. Before and after using the new config:

Should these prettier configs be consistent with minecraft?
    arrowParens: 'avoid',
    bracketSpacing: true,
    endOfLine: 'crlf',
    printWidth: 120,
    singleQuote: true,
    tabWidth: 4,
    useTabs: false

Seems this is ok, at least with the current config


New changes for ReutersBridge

Health feed in the U.S context now using different feed.
Bridge now support using a unique feed ID instead of normal name.

As Reuters stated right here:

We are building a global site and, from January 7, 2021, will be redirecting users from some regional editions – such as br.reuters.com and fr.reuters.com – to www.Reuters.com. This will offer users a more consistent and higher quality experience, as many of our regional sites currently operate as automated news feeds, and we are making a wide range of improvements to Reuters.com. You can continue reading news coverage from your region in the English language on the global site.

So it's not necessary to make a new context for U.K edition so i'm removing the U.K context in the next commit.

As Reuters stated right here:

We are building a global site and, from January 7, 2021, will be redirecting users from some regional editions – such as br.reuters.com and fr.reuters.com – to www.Reuters.com. This will offer users a more consistent and higher quality experience, as many of our regional sites currently operate as automated news feeds, and we are making a wide range of improvements to Reuters.com. You can continue reading news coverage from your region in the English language on the global site.

So it's not necessary to make a new context for U.K edition so i'm removing the U.K context in the next commit.

Close #3 .
Going to open a new PR at hollowleviathan's repo.

Close #3 .
Going to open a new PR at hollowleviathan's repo.


Add utmp/wtmp support

I thought it might be easiest to discuss this now by way of another PR.
For the history, see #38, #890, #1077 and more recently discussion #2744. There are probably others!
The points I took away from the discussion were:-

PAM on at least Linux and FreeBSD is capable of updating wtmp and lastlog, and should be used where possible. This is because these files have a Y2038 problem on glibc systems. See the links in #2744 for info on this.
utmp is a harder problem to solve, and in the short term can still be updated with traditional interfaces.
btmp is not used enough to worry about.

I've taken @moobyfr's wtmp branch, rebased it and added a few extra commits. The rebasing was a little challenging as all the code has now moved to sesexec rather than being in sesman. The commits do the following:-

Fix a name collision between the struct exit_status I added to os_calls and the one in (Linux) utmpx.h
Removed wtmp updating code and moved it to the PAM files.
Added --enable-utmp to configure.ac to allow this feature to be used only where required.
Added support for some Linux-specific utmpx fields.
Fixed a testing problem I found with g_strncpy().

On a Ubuntu 22.04 system with this branch, I now have the following when logging on:-
$ who -a | grep testuser
testuser ? xrdp:11      2023-06-30 11:29   ?        137441 (::ffff:<IP4-addr>)
w testuser
 11:30:35 up  1:56,  3 users,  load average: 0.48, 0.35, 0.17
USER     TTY      FROM             LOGIN@   IDLE   JCPU   PCPU WHAT
testuser xrdp:11  <snipped>        11:29    0.00s  0.00s  0.08s /usr/libexec/gnome-session-binary
$ utmpdump /run/utmp | grep testuser
Utmp dump of /run/utmp
[7] [137441] [:b  ] [testuser] [xrdp:11     ] [<snipped> ] [<IP_ADDRESS>        ] [2023-06-30T10:29:28,096368+00:00]
$ who /var/log/wtmp | tail -1
testuser :11          2023-06-30 11:29 (<snipped>)
$ lastlog -u testuser
Username         Port     From             Latest
testuser         :11      <snipped>        Fri Jun 30 11:29:26 +0100 2023

After logging out normally:-
$ who -a | grep testuser
$ w testuser
 11:37:03 up  2:03,  2 users,  load average: 0.08, 0.32, 0.24
USER     TTY      FROM             LOGIN@   IDLE   JCPU   PCPU WHAT
$ utmpdump /run/utmp | grep testuser
Utmp dump of /run/utmp
$ who -a /var/log/wtmp | tail -2
testuser ? :11          2023-06-30 11:29   ?        137236 (<snipped>)
           :11          2023-06-30 11:34            137236 id=      term=0 exit=0
$ lastlog -u testuser
Username         Port     From             Latest
testuser         :11      <snipped>        Fri Jun 30 11:29:26 +0100 2023

A couple of other points:-

Arch linux doesn't seem to be shipping with either pam_lastlog.so or pam_lastlog2.so at the moment.
Debian/Fedora are still on pam_lastlog.so
OpenSUSE Tumbleweed has moved to pam_lastlog2.so

On another note, I'm going to be unavailable for a lot of July, but I've got a bit of time next Monday to work on this.

LGTM, thx for getting this back and synced

I'm waiting on @Nexarian before I merge this - I don't want to disrupt some of the stuff he's looking at.
In the meantime I'll fix the conflicts.

A lot of time has passed, so I'm rebasing it. I'll retest soon and hopefully we can get this merged.

Yeah, at this point I don't think anything I've worked on will affect this in light of the recent merges!

@metalefty - I've retested this and it still works!
Are you happy for me to merge it?

Let me test.

A couple of testing notes - these will be added to the release notes under the 'packagers and maintainers' section.
Linux

You'll need to compile with --enable-utmp to get utmp support.
wtmp/lastlog support is provided via PAM. I've updated the PAM files in instfiles, so if you're using make install you should be fine. Otherwise you may need to modify /etc/pam.d/xrdp-sesman yourself.

FreeBSD
FreeBSD has its UTX database which replaces all of the above files. It is supported via the FreeBSD pam_lastlog module which I think is called normally anyway. In other words, this should already work on FreeBSD without this PR.

I did a quick test only on Linux. LGTM overall.
BTW, the from entry is not updated after reconnecting another client from a different IP address.  Isn't it implemented yet?
[almalinux@a9xrdp ~]$ lastlog -u almalinux
Username         Port     From                                       Latest
almalinux        :10      ::ffff:<IP_ADDRESS>                       Wed Feb 21 12:20:08 +0000 2024

That's a really good point.
I've had a look at the pam_lastlog source code. The lastlog file is only updated when a session is opened or closed.
The PAM session lifetime is that of the user session - i.e. it starts when the user logs a session in and ends when that session finishes.
For a reconnect we don't start a new session - we only go through the auth and account stages of PAM. So I think this is sort-of expected if we use PAM to implement this functionality.

I've added your observation to the known issues on the NEWS page. I've also deleted the old wtmp branch from the repo.


Entity Matches : 16.90%  Requestable Success : 15.30%

I have cloned the code and downloaded the pre-trained model, but the model only gets Entity Matches : 16.90%  Requestable Success : 15.30%.   But the  bleu (0.235) and entity F1 (0.657) is consistent with the paper, I'm confused with the preoblem.

Hi, the database file was somehow broken, which leads to the problem. I just fix the problem, you can pull and try again. It should be fine by now.

Everything is OK. Thanks a lot.


Deduplication error during sbt assembly

On the latest master, when running sbt assembly, I am getting an error to do with wm_compositional_metadata.yml. I tried deleting both the implicated jar file in .ivy2 and the target/scala-2.12/classes folder but neither of those solved the issue.
[error] 1 error was encountered during merge
[error] java.lang.RuntimeException: deduplicate: different file contents found in the following:
[error] org/clulab/wm/eidos/english/ontologies/wm_compositional_metadata.yml
[error] /Users/ben/.ivy2/cache/com.github.WorldModelers/Ontologies/jars/Ontologies-master-SNAPSHOT.jar:org/clulab/wm/eidos/english/ontologies/wm_compositional_metadata.yml
[error] 	at sbtassembly.Assembly$.applyStrategies(Assembly.scala:143)
[error] 	at sbtassembly.Assembly$.x$1$lzycompute$1(Assembly.scala:25)
[error] 	at sbtassembly.Assembly$.x$1$1(Assembly.scala:23)
[error] 	at sbtassembly.Assembly$.stratMapping$lzycompute$1(Assembly.scala:23)
[error] 	at sbtassembly.Assembly$.stratMapping$1(Assembly.scala:23)
[error] 	at sbtassembly.Assembly$.inputs$lzycompute$1(Assembly.scala:68)
[error] 	at sbtassembly.Assembly$.inputs$1(Assembly.scala:58)
[error] 	at sbtassembly.Assembly$.apply(Assembly.scala:85)
[error] 	at sbtassembly.Assembly$.$anonfun$assemblyTask$1(Assembly.scala:244)
[error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:44)
[error] 	at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:39)
[error] 	at sbt.std.Transform$$anon$4.work(System.scala:66)
[error] 	at sbt.Execute.$anonfun$submit$2(Execute.scala:263)
[error] 	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:16)
[error] 	at sbt.Execute.work(Execute.scala:272)
[error] 	at sbt.Execute.$anonfun$submit$1(Execute.scala:263)
[error] 	at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:174)
[error] 	at sbt.CompletionService$$anon$2.call(CompletionService.scala:37)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error] 	at java.lang.Thread.run(Thread.java:748)
[error] (assembly) deduplicate: different file contents found in the following:
[error] org/clulab/wm/eidos/english/ontologies/wm_compositional_metadata.yml
[error] /Users/ben/.ivy2/cache/com.github.WorldModelers/Ontologies/jars/Ontologies-master-SNAPSHOT.jar:org/clulab/wm/eidos/english/ontologies/wm_compositional_metadata.yml

@kwalcock: can you please take a look?

It looks like I forgot something.  It's being addressed with #795.  We've switched over to the WorldModelers/Ontologies version that is on github and don't need the local files, especially if they differ.  It should be ready momentarily.

@bgyori, can you give it a try?  Also, if you have time can you see #791?  Thanks.

Thanks, #795 solved it!


picocli does not seem to support - as a positional parameter

Hi,
I'm preparing some demo project for picocli and stumbled over some interesting, currently unsupported case.
Some shell commands, like cat accept - as a positional parameter
cat -

which means cat will read it's input from STDIN instead of a file.
But it seems picocli currently doesn't support such a case?
When I call
@Command(name = "mst-cli", mixinStandardHelpOptions = true)
public class Cli implements Runnable {
    @Parameters(index = "0")
    private String json;
    @Parameters(index = "1")
    private String template;
    // more code
}

with the following parameters
- ~/hello.mustache

picocli complains that the second parameter isn't set :/.
But
~/data.json ~/hello.mustache

works.

Picocli 3.9.3 has been released. This includes a fix for this issue.
Enjoy!

Thank you very much. Was very low on time the last few weeks so couldn't test the change :/.


OpenAI-DotNet 6.3.2

Closes #54 Attempt to fix dependency requirement for dotnet/runtime docker base images
Closes #53 Made internal OpenAIClient constructor with HttpClient public

CC @grishin please review and let me know if this resolves your issues


Work Package wp-gl.csv

I would like to work on this please!

Results of Phase 1
wp-gl-results.csv

I completed this package!

I completed this work package.

CSC510 - Submission for Homework-2
wp-gl-results.csv

I've completed this work package.

I would like to work on this please!

Result of Phase 2
wp-gl-results.csv

I've completed this work package.

I would like to work on this please!

Results of Phase 2 (Unfinished
wp-gl-results.csv
)


Fix functions GetHex and SetHex of Scalar

Is it safe to fix the secp256k1 lib?
Poramin Insom

On 18 Jun BE 2562, at 08:33, Panu<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/zcoinofficial/zcoin/pull/463
Commit Summary
Fix scalar GetHex and SetHex
File Changes
M src/secp256k1/include/Scalar.h (2)
M src/secp256k1/src/cpp/Scalar.cpp (19)
Patch Links:
https://github.com/zcoinofficial/zcoin/pull/463.patch
https://github.com/zcoinofficial/zcoin/pull/463.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@nopslide this class just a c++ wrapper of secp256k1_scalar which create by us. And it work incorrectly.


Update the change log for AutolispExt v1.5.0

Objective
Update the change log for AutolispExt v1.5.0
Abstractions
The change log is updated to describe what's new since ver1.4.0.
Also updated i18n/enu/package.i18n.json with package.nls.json.
Tests performed
Screen shot

Happy to see we will release another new version!


Add XRF measurents

We have a couple of use cases of groups that are using XRF either as mapping or as a single measured point. We need a schema and parsers to cope with this. File formats should account for the tornado .spx format and for the files provided by the UIBK colleagues: https://fileshare.uibk.ac.at/d/1a200e720a29450f9add/
@hampusnasstrom, feel free to add info and comment on this. I believe there is already a reader for the .spx files. @RoteKekse, @yaruwangway, is there already a schema for Thomas's lab?

Hey there is a parser which is quite user oriented. it takes the results of the data analysis and the spx files and  reads position thickness and composition information
so proper schema should also include what model was used and other data :)

Hey there is a parser which is quite user oriented. it takes the results of the data analysis and the spx files and reads position thickness and composition information
so proper schema should also include what model was used and other data :)

I think starting with this would be already very good. Do you have a link to the parser @RoteKekse? This would be helpful for @fabianschoeppach to get inspired.

ah fabian sghould now already but i can repost here:
the parsing is done here: https://github.com/nomad-hzb/hzb-combinatorial-libraries-plugin/blob/bae9edd97400b943d1e66994dec40b173938c831/src/hzb_combinatorial_libraries/schema.py#L131
the schema is here: https://github.com/nomad-hzb/nomad-baseclasses/blob/main/baseclasses/characterizations/xrf.py
keep in mind that i modified the schema right now in a way that elasticsearch is not overlimited, since there are only 10000 values able to b eregistered per nomad entry my orginal schema was too much for 625 XRF spot measurements

FYI: I created the branch '88-add-xrf-measurements' last week and did some work similar to the xrd stuff on there.
I got the plugin and schema to run properly, e.g. I can use the create upload from schema.
Still unsure about how to properly save the extracted data in the end.


the big data is not rendered correctly in Hierarchical TreeDataGrid

when the data is loaded, the TreeDataGrid is shown as that

and when I scroll vertically, the data is not rendered well.

I think because there is a lot of Data.

the issue of the render was a custom template (Checkbox), now I fixed it.


Zhaoyu/maximum vcores config

change default vcores maximum number to 32.

Coverage increased (+25.9%) to 77.755% when pulling 2e32cea39c42d13e74181ee7d1f9b4bdb214eaf8 on zhaoyu/maximum-vcores-config into f78edccf8f2c6ca34ecaeee805b788f028b927fb on master.

Coverage increased (+25.9%) to 77.755% when pulling 2e32cea39c42d13e74181ee7d1f9b4bdb214eaf8 on zhaoyu/maximum-vcores-config into f78edccf8f2c6ca34ecaeee805b788f028b927fb on master.


dropForeignKey does not allow removal of constraints containing whitespaces

The code from ./src/Db/Adapter/MysqlAdapter.php:700-707 in MysqlAdapter::dropForeigKey(...) at Lines 700-707, doesn't quote $constraint with MysqlAdapter::quoteColumnName(...).
As a result, dropping a foreign key constraint with whitespaces (which made me notice it), e.g. "i am a silly test", is not possible.
My current workaround is to quote the name with backticks, manually.

Are you able to provide a pull request with your suggested changes?

using whitespace is definitely not typical.
Closing due to lack of activity or out of scope. If there is new interest, please open a PR.

@othercorey could this be re-opened.


pretty-quick validates wrong files

Pretty-quick gets called without additional parameters package.json, so all staged files will be validated, even if they are not supposed to be.
Either there should be the additional pattern parameter or even better since lint-staged is used just use prettier --write as it is done in the script section of package.json

Hi @LOK-Soft,
thank you. We will remove pretty-quick because lint-staged now also solves the issue we had with prettified files wich are not staged.

should be fixed with npx<EMAIL_ADDRESS>


[Jenkins] ...

Extension
https://www.raycast.com/k8scat/jenkins
Description
Can you support http?
Who will benefit from this feature?
No response
Anything else?
No response

+1


Upgrade etcd-viewer to work with etcd v3

It has been 3 months since the relase of etcd v3. Any plans of supporting it?

I also use etcd v3 version, will support for the v3 version?

@raoofm  @qihanglys Thanks for your comments and interest guys! I will try as soon as possible to include support for etcd v3. The issue is that this project is a mainly a hobby and unfortunately I don't have much free time these days.

It seems to work with my v3 cluster, but maybe I'm missing something.


feat: FW-5 Implement artist search

Description
Implement artist repository in order to be able to search artists by name.
Next steps: serve artist search through a REST API.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Plugin does not work with sbt 0.13.0

Besides the documentation, sbteclipse version 4.0.0 does not work with sbt 0.13.0. The error message is:
lefou@x3 /tmp/test $ sbt eclipse
Loading /home/lefou/bin/sbt-0.13.0/bin/sbt-launch-lib.bash
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
[info] Loading global plugins from /home/lefou/.sbt/0.13/plugins
[info] Set current project to test (in build file:/tmp/test/)
[error] Not a valid command: eclipse (similar: help, alias)
[error] Not a valid project ID: eclipse
[error] Expected ':' (if selecting a configuration)
[error] Not a valid key: eclipse (similar: deliver, licenses, clean)
[error] eclipse
[error]        ^

Using a recent sbt version, e.g. 0.13.9 works.

I don't think we're likely to add support for older versions of SBT especially given that it's really easy for folks to upgrade to a newer version of SBT


Clarify where .npmrc should live

The installation docs say:

Edit .npmrc
In order for yarn/npm on your computer to be able to install Remix, you need to add your license key to the npmrc. You'll find it on the dashboard.

It’s no clear what the “the npmrc” is. Perhaps the docs should change to:

Edit .npmrc
In order for yarn/npm on your computer to be able to install Remix, you need to add your license key to your project’s .npmrc file. Create a .npmrc in the root of your project if you don’t have one. You'll find your license key in the dashboard.

BTW have you considered having the docs as a repo we can PR to?

This won't be necessary anymore