Systematic Deviations in Projecting 3D Points

I am following up on the issue posted her:  (#493)
I also observe systematic issues, when projecting 3D points to 2D. I only find them on some of the images. Possibly there is again a tendency of issues to occur on the side cameras? I am reminded of #458
I use the fixed version of the dataset: v1.3.2.
e.g.
context_name: '10289507859301986274_4200_000_4220_000', 'timestamp_micros':<PHONE_NUMBER>072479, 'camera_id': 4
'context_name': '10203656353524179475_7625_000_7645_000', 'timestamp_micros':<PHONE_NUMBER>762835, 'camera_id': 4

I can confirm now: I only find the issues with cameras 4 and 5

Thanks for reporting the issue! I'll investigate and share an update in about a week.


add right padding to notebook toolbar action item

This PR addresses #13607

Pull Request Test Coverage Report for Build 397312512

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 41.155%

Totals

Change from base Build 397262449:
0.01%

Covered Lines:
21856

Relevant Lines:
48649

💛  - Coveralls


Another case of author component with an anonymous author

My friend's blog post (deployed and source) uses the Author component via :Author src=github.  I also think their github configuration is correct (which was the issue in #18).  This is consistent when the output of codedoc check, which says
twilliams@EDMONDS MINGW64 /c/Code/ThirdParty/coding-blog (master)
$ codedoc check

# Checking CODEDOC configuration ...

# Checking Title configuration ...

# Checking GitHub configuration ...

# No issues detected.

I tried updating all dependencies to their latest version (by running codedoc install after deleting node_modules and packages-lock.json).  Still had the same behavior (when hosting locally).
What am I missing?  Why does the Author component on my friend's blog post show an anonymous author?

Will check it later today, thanks for the heads up!

on a quick look: this seems indeed like a bug with the Author component, since the commit data is correctly fetched from GitHub API on that page.

@TysonMN @nathans1309 so this is the issue:
the author of the last commit (and the only commit on that file) is apparently NOT a GitHub user, so basically GitHub doesn't provide author information about them. This is the response from GitHub:
[
  {
    "sha": "29acfcbed64dc4a04506b0259db17e625acad1cb",
    "node_id": "MDY6Q29tbWl0MjkxMTUzMzIwOjI5YWNmY2JlZDY0ZGM0YTA0NTA2YjAyNTlkYjE3ZTYyNWFjYWQxY2I=",
    "commit": {
      "author": {
        "name": "BTAA",
        "email"<EMAIL_ADDRESS>        "date": "2020-09-08T21:18:05Z"
      },
      "committer": {
        "name": "BTAA",
        "email"<EMAIL_ADDRESS>        "date": "2020-09-08T21:18:05Z"
      },
      "message": "first blog post",
      "tree": {
        "sha": "a899318408389622e28164c7e8a10492fce5d3a7",
        "url": "https://api.github.com/repos/nathans1309/coding-blog/git/trees/a899318408389622e28164c7e8a10492fce5d3a7"
      },
      "url": "https://api.github.com/repos/nathans1309/coding-blog/git/commits/29acfcbed64dc4a04506b0259db17e625acad1cb",
      "comment_count": 0,
      "verification": {
        "verified": false,
        "reason": "unsigned",
        "signature": null,
        "payload": null
      }
    },
    "url": "https://api.github.com/repos/nathans1309/coding-blog/commits/29acfcbed64dc4a04506b0259db17e625acad1cb",
    "html_url": "https://github.com/nathans1309/coding-blog/commit/29acfcbed64dc4a04506b0259db17e625acad1cb",
    "comments_url": "https://api.github.com/repos/nathans1309/coding-blog/commits/29acfcbed64dc4a04506b0259db17e625acad1cb/comments",
    "author": null,
    "committer": null,
    "parents": [
      {
        "sha": "9cc9cc78f3785540f6cff1a2de2c297815433e74",
        "url": "https://api.github.com/repos/nathans1309/coding-blog/commits/9cc9cc78f3785540f6cff1a2de2c297815433e74",
        "html_url": "https://github.com/nathans1309/coding-blog/commit/9cc9cc78f3785540f6cff1a2de2c297815433e74"
      }
    ]
  }
]

And as you can see the author object is null, and I also cannot click on the author name in GitHub to see their profile.
This of course is still a bug, since Author component can still deduce the name of the author and use that, but this would mean that the author displayed would not get an avatar and wouldn't be linked to anywhere in particular.
I will fix the issue with the component and roll an update when I get home.

Very good debugging @loreanvictor.
@nathans1309, your commit that added our first blog post uses your work email.  In contrast, the merge commit GitHub created for you when you completed my PR uses your personal/gmail email.  I had this happen to me before.  You can associate your work email with your GitHub account.  That will also fix this problem.
As a funny but related aside, since your only non-merge commit uses your work email (which is not associated with your GitHub account) and GitHub doesn't consider merge commits as a contribution, GitHub does not yet consider you a contributor to your blog's repository.

Fix deployed via<EMAIL_ADDRESS>As discussed before, the effect of this fix in the provided case would be that the name of the author (and publishing date) would be properly displayed, but not the author avatar or the url to their GitHub profile.

You can associate your work email with your GitHub account . That will also fix this problem.

Another way that you can solve this problem @nathans1309 is by recreating that commit with you personal/gmail email and then force pushing.  Normally people recommend against force pushing, but this is your repo that almost no one else will ever use.

...the effect of this fix in the provided case would be that the name of the author (and publishing date) would be properly displayed, but not the author avatar or the url to their GitHub profile.

Why that fix?  I think it is possible to better with only a little extra work.
Given the username MyUsername, the URL to the corresponding GitHub profile is https://github.com/MyUsername, and a URL to an image of the corresponding avatar is https://github.com/MyUsername.png.

@TysonMN which username are you referring to? In the provided case:

the username on the commit is BTAA, however the url https://github.com/BTAA.png leads nowhere.
the username of the repo can be used, but it would lead to two issues:

it is possible that the author of that particular post is indeed someone else without a publicly accessibly GitHub profile. In that case your proposed solution would lead to the incorrect avatar being fetched.
the proposed solution would introduce a coupling between the logic of Author component and a convention (not a specification) of GitHub API, which by nature can be changed without prior notice, leading to errors.

You can associate your work email with your GitHub account . That will also fix this problem.

Another way that you can solve this problem @nathans1309 is by recreating that commit with you personal/gmail email and then force pushing. Normally people recommend against force pushing, but this is your repo that almost no one else will ever use.

Thanks, @TysonMN I made those changes.

@TysonMN which username are you referring to?
...

the username of the repo can be used, but it would lead to two issues:

it is possible that the author of that particular post is indeed someone else without a publicly accessible GitHub profile. In that case your proposed solution would lead to the incorrect avatar being fetched.
the proposed solution would introduce a coupling between the logic of Author component and a convention (not a specification) of GitHub API, which by nature can be changed without prior notice, leading to errors.

I was referring to this case with the two issues that you mentioned.
The second issue is definitely a concern.  Maybe GitHub's API has a way to officially convert from a GitHub username to an avatar.  However, isn't this already a concern?  runs away to check  Oh, it is not an issue now because the Author component becomes a script that fetches this data from GitHub on page load.  I was guessing the data was obtained from GitHub at build time.
I hadn't considered the first issue.  Which commit are you assuming is the author?  The most recent commit that edited the file or first commit that created the file?

Oh, it is not an issue now because the Author component becomes a script that fetches this data from GitHub on page load. I was guessing the data was obtained from GitHub at build time.

Yeah thats precisely why its a client-side script, as it needs to be re-executed when the user navigates.

I hadn't considered the first issue. Which commit are you assuming is the author? The most recent commit that edited the file or first commit that created the file?

Right now, the latest commit, since I suspected the last edit date should be displayed (so people can easily know if the post has been updated since the last time they saw it). This might not be ideal when multiple people start working on a post simultaneously though. My thinking was waiting for that to happen, and then act accordingly (I would personally love for it to display the first author and a limited number of most recent authors, with a link to GitHub so people can see its history for themselves, however depending on the case some other mechanism might be desirable).


find fails with array of ids

The default behaviour of Model#find is to take a single id and returns a single element or take
an array of ids and returns an array of elements (though duplicate ids in the array are not in the result).
Expected behaviour:
using the code below will work with hashid-rails installed
Model.find([1,2])
=> [#<Model id: 1>,  #<Model id: 2>]

Actual Result
Get an error
ActiveRecord::RecordNotFound: Couldn't find Role without an ID
        from /Users/drb/.gem/ruby/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/finder_methods.rb:454:in `find_with_ids'
        from /Users/drb/.gem/ruby/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/finder_methods.rb:66:in `find'
        from /Users/drb/.gem/ruby/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/querying.rb:3:in `find'
        from /Users/drb/.gem/ruby/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/core.rb:151:in `find'
        from /Users/drb/.gem/ruby/2.3.0/gems/hashid-rails-0.5.0/lib/hashid/rails.rb:66:in `find'
        from (irb):1
        from /Users/drb/.gem/ruby/2.3.0/gems/railties-<IP_ADDRESS>/lib/rails/commands/console.rb:65:in `start'
        from /Users/drb/.gem/ruby/2.3.0/gems/railties-<IP_ADDRESS>/lib/rails/commands/console_helper.rb:9:in `start'
        from /Users/drb/.gem/ruby/2.3.0/gems/railties-<IP_ADDRESS>/lib/rails/commands/commands_tasks.rb:78:in `console'
        from /Users/drb/.gem/ruby/2.3.0/gems/railties-<IP_ADDRESS>/lib/rails/commands/commands_tasks.rb:49:in `run_command!'
        from /Users/drb/.gem/ruby/2.3.0/gems/railties-<IP_ADDRESS>/lib/rails/commands.rb:18:in `<top (required)>'
        from /Users/drb/.gem/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:293:in `require'
        from /Users/drb/.gem/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:293:in `block in require'
        from /Users/drb/.gem/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:259:in `load_dependency'
        from /Users/drb/.gem/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:293:in `require'
        from /Users/drb/Code/project/mafia-rails/bin/rails:9:in `<top (required)>'
        from /Users/drb/.gem/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:287:in `load'
        from /Users/drb/.gem/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:287:in `block in load'
        from /Users/drb/.gem/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:259:in `load_dependency'
        from /Users/drb/.gem/ruby/2.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:287:in `load'
        from /Users/drb/.rbenv/versions/2.3.3/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
        from /Users/drb/.rbenv/versions/2.3.3/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
        from -e:1:in `<main>'

Environment
This was found to occur on Ruby on Rails 5.0.1 and ruby 2.3.3 on macOS

Hi @zyphrus. Thanks for pointing this out! I was able to replicate the issue you mentioned, added a test case, and implemented a fix in version 0.6.0 (https://github.com/jcypret/hashid-rails/commit/23caa2228d6c345050040f6287a7dd33d1aadf51).


Add a documentTemplateMaxBytes parameter to limit the max length of document templates

Pull Request
Related issue
Fixes #4885
See public usage

@ManyTheFish
Added analytics, and also we no longer reindex when decreasing the max bytes value.

bors merge

Rebased


[Question] - Is there a way to exclude default metadata when formatting in a JSON format?

Issue description
I was trying to build a JSON file for the Figma Tokens plugin written by six7.
When a name property is declared for a token in the JSON file, I've noticed that the plugin use it for organizing the tokens with the type property. But when no name property is included, the keys of the token is used instead.
Current behaviour
When I use the pre-defined JSON transform I get this verbose data structure
{
  "colour": {
    "utils": {
      "blue": {
        "value": "#0535D2",
        "type": "color",
        "filePath": "tokens/color/base.js",
        "isSource": true,
        "original": {
          "value": "#0535D2",
          "type": "color"
        },
        "name": "gcds-colour-utils-blue",
        "attributes": {},
        "path": [
          "colour",
          "utils",
          "blue"
        ]
      },
      "purple": {
        "value": "#7834BC",
        "type": "color",
        "filePath": "tokens/color/base.js",
        "isSource": true,
        "original": {
          "value": "#7834BC",
          "type": "color"
        },
        "name": "gcds-colour-utils-purple",
        "attributes": {},
        "path": [
          "colour",
          "utils",
          "purple"
        ]
      },
      "white": {
        "value": "#ffffff",
        "type": "color",
        "filePath": "tokens/color/base.js",
        "isSource": true,
        "original": {
          "value": "#ffffff",
          "type": "color"
        },
        "name": "gcds-colour-utils-white",
        "attributes": {},
        "path": [
          "colour",
          "utils",
          "white"
        ]
      }
    },
    "base": {
      "red": {
        "100": {
          "value": "#ecb6b5",
          "type": "color",
          "filePath": "tokens/color/base.js",
          "isSource": true,
          "original": {
            "value": "#ecb6b5",
            "type": "color"
          },
          "name": "gcds-colour-base-red-100",
          "attributes": {},
          "path": [
            "colour",
            "base",
            "red",
            "100"
          ]
        },
        "300": {
          "value": "#c85c5a",
          "type": "color",
          "filePath": "tokens/color/base.js",
          "isSource": true,
          "original": {
            "value": "#c85c5a",
            "type": "color"
          },
          "name": "gcds-colour-base-red-300",
          "attributes": {},
          "path": [
            "colour",
            "base",
            "red",
            "300"
          ]
        },
        "500": {
          "value": "#bf3230",
          "type": "color",
          "filePath": "tokens/color/base.js",
          "isSource": true,
          "original": {
            "value": "#bf3230",
            "type": "color"
          },
          "name": "gcds-colour-base-red-500",
          "attributes": {},
          "path": [
            "colour",
            "base",
            "red",
            "500"
          ]
       },
...
    }
}

This is generated from this config.json file:
{
  "source": [
    "tokens/**/*.js",
    "tokens/**/*.json"
  ],
  "platforms": {
    "figma": {
      "buildPath": "build/figma/",
      "prefix": "gcds",
      "transforms": [ "name/cti/kebab" ],
      "files": [ {
        "destination": "figma.tokens.json",
        "format": "json"
      } ]
    }
  }
}

Expected behaviour
I would prefer Figma Tokens behaviour where the keys organize the tokens instead of the name property. But then I'm trying to not have the default metadata generated by SD and I can't seem to figure out how. I just need to output the JSON file like this:
{
  "colour": {
    "utils": {
      "blue": {
        "value": "#0535D2",
        "type": "color"
      },
      "purple": {
        "value": "#7834BC",
        "type": "color"
      },
      "white": {
        "value": "#ffffff",
        "type": "color"
      }
    },
    "base": {
      "red": {
        "100": {
          "value": "#ecb6b5",
          "type": "color"
        },
        "300": {
          "value": "#c85c5a",
          "type": "color"
        },
  ...
    }
}

Screenshots
Default JSON file uploaded in Figma Tokens

Expected JSON file uploaded in Figma Tokens which might be more informative for designers

All that said, is this something that could be achieved with SD or should we investigate with Figma Tokens a way to prevent their default behaviour?
Linked to #2

@phantasmagoriadigital, let's reconvene the conversation here. How would you prefer to connect? gMeet, Twitter, email?
cc/ @JoshBeveridge

Let's connect here, other folks are already there and good group to be part of if you aren't already!
Join my Slack workspace! https://join.slack.com/t/design-systems/shared_invite/zt-dyukxagw-w5PfwgRReus54M4alVb39w


[New Feature] Create new utilities : Currency Converter #286

Description
New Feature(Create new utilities : Currency Converter) fixes #286
Type of change
Just put an x in the [] which are valid.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.

[x] ./gradlew assembleDebug assembleRelease
[x] ./gradlew checkstyle

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@santoshhiremani Also, instead of pngs, can we have vector drawables?

Yes have to, As we have one more issue #414. Will fix in this.

@santoshhiremani Sure. We can have these fixed in that issue only.


View toolbar actions hide when showing a menu unless menuAsChild: true is provided

Issue Type: Bug
Testing #145232

/assign @bpasero
VS Code version: Code - Insiders 1.66.0-insider (d572d6e9d1282b352227916cb8f95bb2b03ddcaa, 2022-03-18T05:15:32.366Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

Reproduces when custom menus are enabled or on Windows.
@sandy081 @sbatten any idea how to solve this? Looks like the menu takes focus away from the view toolbar and then entries hide.
Interestingly this does not happen with "..." menu, so I might be setting up the dropdown wrong:

dropdowns can opt in to rendering the menu as a child element which prevents focus loss https://github.com/microsoft/vscode/blob/442227c0db5b9d298d896efd4c72f8c762e4e59b/src/vs/base/browser/ui/dropdown/dropdown.ts#L212

@sbatten I do not really create the dropdown menu, someone else seems to do that from the Toolbar of the view, I think the action item is being created from here:
https://github.com/microsoft/vscode/blob/4a130c40ed876644ed8af2943809d08221375408/src/vs/workbench/browser/parts/views/viewPane.ts#L512
But we do not pass the option in, nor do I know how to pass this in from the outside.
To clarify, here is how I create the menu:
https://github.com/microsoft/vscode/blob/714420d4c9ed7a7de213185ec7fa0988dac57778/src/vs/workbench/contrib/timeline/browser/timelinePane.ts#L1210-L1216

I was able to solve this from the TimelinePane by overriding getActionViewItem and passing the related option down:
https://github.com/microsoft/vscode/blob/801ad86ce10939dbca554f764e6b767223be8973/src/vs/workbench/contrib/timeline/browser/timelinePane.ts#L969-L971
It sounds to me though that this should be made the default somewhere in a generic supertype so that not every view has to adopt this when they show a menu.

Moved the change to base class

Thanks!


UDP support

Description
This PR adds UPD support with another approach than #144

I think just adding all ports to a single service will not work - if this PR is applied using helm to a cluster:
Error: Service "traefik" is invalid: spec.ports: Invalid value: []core.ServicePort{core.ServicePort{Name:"udp", Protocol:"UDP", Port:8099, TargetPort:intstr.IntOrString{Type:1, IntVal:0, StrVal:"udp"}, NodePort:0}, core.ServicePort{Name:"web", Protocol:"TCP", Port:80, TargetPort:intstr.IntOrString{Type:1, IntVal:0, StrVal:"web"}, NodePort:0}, core.ServicePort{Name:"websecure", Protocol:"TCP", Port:443, TargetPort:intstr.IntOrString{Type:1, IntVal:0, StrVal:"websecure"}, NodePort:0}}: cannot create an external load balancer with mix protocols

The cluster was running 1.17.2:
❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:58:59Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.2", GitCommit:"59603c6e503c87169aea6106f57b9f242f64df89", GitTreeState:"clean", BuildDate:"2020-01-18T23:22:30Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}

To tests this I just added a UDP port to the values.yaml:
  udp:
    port: 8099
    expose: true
    exposedPort: 8099
    protocol: UDP

Thanks @bergmannf for the input.
So I think the best solution in this case is to create a second LB only for UDP connexions.
I will try to think to the best approach to solve this issue

@mmatur Yes I think having only 2 LoadBalancers is the best way - I couldn't figure out a nice way to get this to work in my PR (but I'm also quite new to the go template language).
I will close my PR, as this one already has all the testing and looks generally nicer.

Hi! Any chance to get this merged?

If memory serves, AWS only supports UDP traffic on network load balancers--not the ELB we spin up by default. So using this would require one to set service.beta.kubernetes.io/aws-load-balancer-type: "nlb" on the Service (which I'm fine with, I much prefer NLBs anyway).
Some docs to this effect would be great, if not configuring the Service outright.

Any news on merging this in? I am anxious for UDP support!

Into this two set protocol: TCP is missing I think :
https://github.com/containous/traefik-helm-chart/pull/145/files#diff-76ff81f79f6efcd76b91e037d8126589R94
https://github.com/containous/traefik-helm-chart/pull/145/files#diff-76ff81f79f6efcd76b91e037d8126589R68
It seems the reason of build fail :)


[Dashboarding] Zero values showing up in df timeseries in prometheus

Putting this here before I forget this issue exists.
Certain dashboarding components utilize division in queries to calculate percentages. If a divisor returns zero, Prometheus returns a 100% value (or that is how Grafana shows division error). The root of the problem, then, is that a time series has a zero value in it in the first place.
I see this when graphing some of the metrics from the df collectd plugin. For example, here is an erratic zero causing the very graphing issue described above, where disk usage drops from 15GB to 0 in a single instant and back up:

On a wider scale, it is easier to see why this is problematic:

This may cause alarms to be triggered and cause confusion for the end user.

So far I only see this for values provided by the df plugin.

Check to see if you are really getting 0's in the source data from prometheus, or whether they are simply being supplied by grafana in response to a null value for that sample.

Thanks for pointing that out. Unfortunately setting it to null all of the options did not make a difference


Improve customizing preset options

It would be useful if we can merge preset options like webpack-merge.

Spending in various projects using Houl, I noticed we need the following features to extend presets better:

Fully overwrite a rule (this is already available in the current version)
Modify a part of a rule
Remove a rule
Modify a task chain (add / remove / replace gulp plugins)

The above are almost the responsibility of the preset side by handling their options for now but to adapt various use cases, the options can be very messy. So it would be better to allow these features in Houl so that the preset auther can keep simple their preset and the end-user can modify their config more flexible with arbitrary presets.
Merge configs with preset instead of replacing
Currently, we can fully overwrite a preset rule by just specifying corresponding rules field:
module.exports = {
  preset: 'foo-preset', // assume `foo-preset` has a task for `.js` files
  taskFile: './task.js',
  rules: {
    // This overwrite a task for `.js` files in the preset.
    js: {
      task: 'scripts'
    }
  }
}

This config replaces the preset .js files rule with the specified scripts task. But in the real world, there are cases we want to modify a part of the preset rule instead of replace it. e.g. adding exclude option with leaving the preset task.
To handle the case, I would prefer merging rules with preset ones instead of replacing.
Allow to mutate raw config object of preset
Similar with modification of rules, there are cases we want to remove rules in a preset. To do this, we need to allow low-level modification for preset config object. Here if we specify a function as a rules field, it will receive a raw config object of preset and the user can mutate it.
module.exports = {
  preset: 'foo-preset',
  rules: config => {
    // remove js config
    delete config.rules.js
  }
}

Customize preset tasks
Customizing tasks is difficult to design its API since all tasks are combined into one stream object and the users cannot modify it.
One idea is to change that a task function returns an array of stream objects.
exports.scripts = () => [
  babel(),
  uglify()
]

But it still a bit hard to customize because the user may not able to find which plugin the array has programattically.

I guess allowing array format tasks is not effective because the plugin author needs to make tasks in such form. If they does not use the format, the users cannot customize tasks in any cases.
Now merging rules and modifying preset objects are implemented. closing.


[Dashboard] Replace Discord icon

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR focuses on replacing the usage of SiDiscord icon from @react-icons/all-files with a custom DiscordIcon component across several files to standardize the icon usage in the application.
Detailed summary

Replaced SiDiscord with DiscordIcon in:

edit-profile.tsx
socialLinks.tsx
PublisherSocials.tsx

Introduced a new DiscordIcon component in DiscordIcon.tsx that renders an SVG.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4816  👈
#4814
#4813
#4812
#4811
#4810
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on  Graphite


Add the Canon PIXMA MP240 to the USB quirk list

Without it the printer gets stuck waiting for some kind of USB response from the computer 3/4 into the page. Right at the end of the job. Sometimes it moves the printing head once every few minutes, if we wait for 20-30 minutes it often finishes correctly. Which is unacceptable.
Using no-reattach unidir instead of only unidir seems to also work fine, but it seemed superfluous in my case, so try that if things are still wonky. Disconnecting the USB cable makes it stop the job instantly, spitting the rest of the page.
The same setup works on Windows just fine. Maybe adding the other MP2XX models into the list should be considered. In my case, until a few months ago printing via CUPS without any kinds of quirks seemed to work fine, so it seems like some kind of regression.
The credit goes to @mounaiban for the original solution:
https://github.com/agalakhov/captdriver/issues/7#issuecomment-602004919
More information here:
https://github.com/agalakhov/captdriver/issues/7#issuecomment-890380405

As all future CUPS development is happening over in OpenPrinting, I'm closing this PR out without merging and have merged the change into OpenPrinting CUPS instead.

Makes sense, thanks for merging.


fix: Update getTransactionByBlockHashOrBlockNumAndIndex to pass timestamp to MAPI calls

Description:

Updates the eth_getTransactionByBlockHashAndIndex and eth_getTransactionByBlockNumberAndIndex to pass a timestamp range of the block to subsequent calls to getContractResults

Related issue(s):
Fixes #3042
Notes for reviewer:

Checklist

[x] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

The "Tests" seem to fail consistently:
    3 failing

    1) HAPI Service
         should be able to reset all counter upon reinitialization of the SDK Client:

        AssertionError: expected 35999 to equal 36000
        + expected - actual

        -35999
        +36000

        at Context.<anonymous> (tests/lib/hapiService.spec.ts:132:48)
        at Generator.next (<anonymous>)
        at /home/runner/_work/hedera-json-rpc-relay/hedera-json-rpc-relay/packages/relay/tests/lib/hapiService.spec.ts:27:71
        at new Promise (<anonymous>)
        at __awaiter (tests/lib/hapiService.spec.ts:23:12)
        at Context.<anonymous> (tests/lib/hapiService.spec.ts:124:20)
        at processImmediate (node:internal/timers:483:21)

    2) Open RPC Specification
         should execute "eth_getTransactionByBlockHashAndIndex":
       Error invoking RPC: Could not find mock for:
  {
    "method": "get",
    "url": "contracts/results?block.hash=0x3c08bbbee74d287b1dcd3f0ca6d1d2cb92c90883c4acf9747de9f3f3162ad25b999fc7e86699f60f2a3fb3ed9a646c6b&timestamp=gte:1651560386.060890949&timestamp=lte:1651560389.060890949&transaction.index=77&limit=100&order=asc"
  }

    3) Open RPC Specification
         should execute "eth_getTransactionByBlockNumberAndIndex":
       Error invoking RPC: Could not find mock for:
  {
    "method": "get",
    "url": "contracts/results?block.number=3&timestamp=gte:1651560386.060890949&timestamp=lte:1651560389.060890949&transaction.index=77&limit=100&order=asc"
  }
    ```

Fixed

After discussing this with xin, it seems like those changes were not needed


Fix various result propagation issues in AdES engine

Description of the changes
The discussion in #228 centres on some files with an LTV configuration that has some interesting properties:

Signature declared as PAdES
No DSS or any DTSes present, the signature covers the entire file.
The signature timestamp uses a TSA with a different root.
The leaf certificate is very short-lived (i.e. expected to have expired by the time the signature needs to be validated).
The file contains an OCSP response for the leaf certificate, but in a RevInfoArchival attribute (i.e. not in a DSS), which has no defined role in PAdES.
Revocation information for the intermediate CA is not included in the file, so needs to be fetched live.

PyHanko's old validation engine can't cope with some of these characteristics. The new AdES validation deals with them mostly correctly, but the status report is confusing because not all of the information that one would expect actually propagates to the status report. This PR fixes some of those issues.
Caveats
Upgrades pyhanko-certvalidator to 0.21.0, which includes a minor but breaking change in the exception hierarchy (see the changelog).
Checklist
Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).

[x] I have read the project's CoC and contribution guidelines.
[x] I understand and agree to the terms in the Developer Certificate of Origin as applied to this contribution.
[ ] All new code in this PR has full test coverage.

For new features (delete if not applicable)

[x] I have discussed the implementation of this feature with the project maintainer(s) on the discussion forum or over email.
[x] I have verified that my changes do not break existing API or CLI functionality, or ensured that all breaking changes are clearly documented in this PR.
[x] All public API functionality in this PR is documented.

For bug fixes (delete if not applicable)

[x] My changes do not affect any public API or CLI semantics.
[x] My PR adds regression tests (i.e. tests that fail if the bug fix is not applied).
[x] All new code in this PR has full test coverage.

While trying to get coverage on the full diff I found a more thorny issue with how the AdES validator handles algorithm policy failures---I'll fix that on this branch as well.


Should it be possible to use "HTTP connect" as the mode for Konnectivity

When adding --mode=http-connect to TenantControlPlane.spec.addons.konnectivity.server.extraArgs this gets overridden to be set to "grpc" here:
https://github.com/clastix/kamaji/blob/7e08b9a7cede820ab4c41f751ac6703d6957e10a/internal/builders/controlplane/konnectivity_server.go#L52
Is "grpc" hard coded for a particular reason? Or is "http-connect" not a good idea to use?
Thanks.

Don't want to play the Uno reverse card here: why are you trying to setup http connect mode? I guess it could be related to network firewalls but any feedback would be really valuable.
The gRPC one is the same used by other providers and we went with that choice, as well as the documentation from Kubernetes suggests using this mode.
If you don't mind, I'll move this as a Discussion since it's not a bug per se.

I might play a Uno draw four ;)
But the additional context for “why” might have been useful…
The reason was we have a reverse proxy solution for our Tenant Control Plane’s that doesn’t handle gRPC well sometimes (which you may argue is the real problem) so I’d hoped HTTP Connect mode might provide a workable solution, however I’ve not tested this outside of Kamajj so it may be a dead end for my own purposes…but I guess it’s more a question of why gRPC is the only option.
If HTTP Connect is terrible for some reason I’m perfectly fine with this decision of forcing gRPC though.

I might play a Uno draw four ;)

I'll leave this here.

I remember we worked with @jwitko on 7ac8e5e5 in allowing overriding Konnectivity, as well as API Server, parameters, taking for granted users knew what they were doing.
My main remark is that these kinds of customisations could potentially create issues with Kamaji, and newbie users would blame Kamaji for its instability, even tho it's their "fault".
I'm open tho in supporting the customisations of the konnectivity server, unless there's a well-known and proven best practice in preferring gRPC over HTTP, besides the fact gRPC is based on a binary format which is more performant and robust.

Touché for the Uno reference.
I’m honestly fine if the position is that gRPC is a superior solution so that’s all Kamaji will support…as being opinionated in this regard is no problem.
I don’t know enough about the internals of Kamaji or Konnectivity to comment on the suitability of HTTP Connect as an option, it was more to (hopefully) work around a deficiency in our environment.
I can put tog PR so that option is not explicitly set if that helps?
Then it can be accepted or rejected either way?

Rather than superior, I'd say easier: I had a quick review of the current code and such a change would require a change in the TenantControlPlane specification, since we need a value parity between the konnectivity server and the EgressSelector file stored as a ConfigMap.
https://github.com/clastix/kamaji/blob/7e08b9a7cede820ab4c41f751ac6703d6957e10a/internal/resources/konnectivity/egress_selector_configuration_resource.go#L98
https://github.com/clastix/kamaji/blob/7e08b9a7cede820ab4c41f751ac6703d6957e10a/internal/builders/controlplane/konnectivity_server.go#L52
Not a big deal, tho, we could provide an enum in the Konnectivity Addon struct we're already using with a default value of GRPC. Contributions are definitely welcome and warmly accepted, thanks for giving a shot to Kamaji!


Retrieving item sets from op.gg doesn't seem to work anymore

It doesn't show the current version nor does it reliably download the item sets. Sometimes it does some, but most of the time I end up with no item sets at all. Also, when finished downloading, the window looks like this:

Might be, because of that.

Just did a full import with op.gg and didn't see a problem. If you see it break again, could you pass me your log before running another import, please? C:/Users/YOURNAME/AppData/Roaming/Championify/championify.log.txt

Funny enough, now it works for me too... I can only imagine that op.gg had some difficulties. Even the blank screen is "fixed". Well, if I experience that again, I'll give you the log. Thanks!


bug: CORS error when using SSE with webflux

I created a sample project making the use of webflux and disabled CORS and it works for the /graphql endpoint but no for the /subscriptions one.
Expected behavior
It should disabled CORS for all endpoints.
Actual behavior
It does not disabled for subscriptions.
Steps to reproduce
Clone: https://github.com/esfomeado/dgs-cors
Do a request with SSE or fetch:
subscription {
  liveCoinsPrice {
    name,
    price,
    time
  }
}

Thanks for reporting!

I don't have this issue with my example: https://github.com/Ancient-Dragon/dgs-sse-subscriptions-backend-example

Could you add more info about this incident please?
I didn't find a way to reproduce it using this repo.
Thanks in advance.

Closing this as this is now handled by Spring GraphQL with the DGS/Spring GraphQL integration.


Too bright default users avatars text.

Which version is this on?

Fixed with https://github.com/catppuccin/telegram/commit/5ce8614aab1a6f9bfc6aa3dcebb6abbcc53b9b51


Add Azure category to VSCode extension

Also azure and azd as keywords

VSCode Extension Installation Instructions

Download the extension at https://azuresdkreleasepreview.blob.core.windows.net/azd/vscode/pr/1785/azure-dev-0.5.0-alpha.1.vsix
Extract the extension from the compressed file
In vscode
a. Open "Extensions" (Ctrl+Shift+X)
b. Click the ...\ menu at top of Extensions sidebar
c. Click "Install from VSIX"
d. Select location of downloaded file


release the code

Hello, YueLiao, could you please release the code? I'm looking forward to it, Thanks!

After a recent significant DDL, may within two weeks~

The source code is now available.


Fix dotmesh on Docker for Mac

Tests are failing: http://gitlab.dotmesh.io:9999/dotmesh/dotmesh-sync/-/jobs/55950
Seems to be caused by a lack of suitable kernel modules, the zfs-builder isn't keeping up with Docker for Mac any more.

Yay, it's working now in CI.


nix-shell shouldn't complain about missing mice-nix-overlay/default.nix

We could consider switching to a NUR-like repository layout.

feb9c8d0 moved all-packages.nix -> default.nix.
At any rate, since this is an overlay, the right way to get a shell is probably nix-shell <nixpkgs> -p <package>.


I am using OAuthSwift lib to call web services. We are using OAuth 1 at server side for authentication. But every time I call services it creates a new session at server side. by using Cookies Jar, my android app able to maintain session and no new session is created at server for same. But this not a case in IOS. The Code I tried is as follows

let oauthswift = OAuth1Swift(
consumerKey:"1xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
consumerSecret:"5xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
)
oauthswift.client.credential.oauthToken = "cxxxxxxxxxxxxxxxxxxxxxxxxx"
oauthswift.client.credential.oauthTokenSecret = "xxxxxxxxxxxxxxxxxxxxxxxx"
oauthswift.client.post(register_URL , parameters:requestDict, headers: ["Accept": "application/json", "Content-Type":"application/json"],success: { response in

    let dataString = response.string

    let data = dataString?.data(using: .utf8)
       do {
        //Parsing data & get the Array

    } catch let error as NSError {
        print("Failed to load: \(error.localizedDescription)")
        DispatchQueue.main.async {
            errorBlock(error.localizedDescription)
        }
    }
},
        failure: { error in
        print(error)
})

I also tried to keep the singleton pattern to keep oauthswift object same form to request but not helped. Also tried to set cookies in oAuthSwift Client as follows.
import Foundation
import OAuthSwift
class ClientHelper{
static var oauthswift:OAuth1Swift?
/* Create cookie and place in cookie storage */
static let cookieStorage = HTTPCookieStorage.shared
static func getInstance()->OAuth1Swift{

if(oauthswift == nil){
oauthswift = OAuth1Swift(
        consumerKey:"1xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
        consumerSecret:"5xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
     )
    oauthswift?.client.credential.oauthToken = "cxxxxxxxxxxxxxxxxxxxxxxxxx"
    oauthswift?.client.credential.oauthTokenSecret = "xxxxxxxxxxxxxxxxxxxxxxxx"
    oauthswift?.client.sessionFactory.configuration.httpCookieStorage = cookieStorage
   oauthswift?.client.sessionFactory.configuration.httpShouldSetCookies = true

}
    return oauthswift!;

}
}

Title too long
Issue template deleted
I close


responds_to? not working properly in Modules

The following code will fail, unless I call self.responds_to? instead of responds_to?:
module SomeLength
  def responds
    responds_to?(:foobar) # fails here
  end
end

class Items
  extend SomeLength

  def self.foobar
    "Any return"
  end
end

puts Items.responds.to_s

Bug: http://carc.in/#/r/d1k
Workaround: http://carc.in/#/r/d1j

I am not sure if this is related, but responds_to? does not accept Symbol in this way. I tried to use Macros::SymbolLiteral as well, but it still fails:
module SomeLength
  def responds(method_name : Symbol)
    self.responds_to?(method_name) # Syntax error: 'responds_to?' argument must be a Symbol literal
  end
end

class Items
  extend SomeLength

  def self.foobar
    "Any return"
  end
end

p Items.responds(:foobar)

@alanwillms It's because responds_to? is a compile-time method, it is not evaluated at runtime. So the compiler must have a literal there to work with. This is a feature™ .

Thank you @lbguilherme :smile:
What about the first issue, is it a bug or a newbieness?

@alanwillms Yes, after some though I classify this as a bug. Right now the parser just checks for is_a? and responds_to? with a receiver (like in obj.is_a?), but never without one. But it should work.


Please update as soon as possible support ES5.5, thank you

Please update as soon as possible support ES5.5, thank you

Is there a specific reason you need 5.5?

The new version of the time series visual builder is enhanced

Nice! So I am trying to re-do this repo over here: https://github.com/malice-plugins/kibana-malice I might just keep it here I can't decide... it IS a plugin, but it is a main compenent of the malice framework... I'll probably keep it here 😖
That is just a skeleton for now, I will pull over the malice styling and hopefully get time to FINALLY finish the Malice Plugin display to look like how VirusTotal displays things.
However, just FYI if you go into the malice config you should be able to tell it to use the new versions (just won't have the malice style yet)
~/.malice/config/config.toml
and change it to:
[database]
  name = "malice-elastic"
  image = "blacktop/elasticsearch:5.5"
...

[ui]
  name = "malice-kibana"
  image = "blacktop/kibana:5.5"
...

I'll probably update this to 5.5.0 and update malice to use it tonight too.

Sorry for the great delay, but I have put in a lot of work to make all future malice-kibana-plugin updates to be much easier to create.
Cheers


implement incremental parsing?

Hi!
How would you add incremental parsing into this awesome project? I looked at the TS source, and doubt it couldn't be that hard?
In your parser code you do an extra 'while' loop to push all tokens into an array. That's different than TS, and would cause performance regression. Why you do it? No need for it

Thanks for your interest in the project! Incremental parsing is an interesting idea, I could look into using a tool such as tree sitter.
You raise a good point about the parser storing the tokens in an extra array. There really isn't any reason to have it, so I've opened another issue about it (#41).
At the moment I'm focused on getting type inference working really well. I'm looking into using constraint solving. These articles have been really useful for that.
I'll look into incremental parsing after the type system is working really well, so for now I'll leave this issue open.

Why use a 3rd party? Your AST nodes seems to have the seem layout as in TypeScript? Should be easy enough to "borrow" some ideas from there and run your own solution. Less overhead and less memory usage, and you are not forcing users to use 3rd party lib.

That's a good point, I'll look into how TypeScript does incremental parsing. It might end up being easier to implement incremental parsing in the future if I'm cautious of how I design the API for each component in the compiler pipeline so I'll keep it in mind.


standard exception handling altered in a lock context

Jenkins and plugins versions report
for my test cases i found/assume that when i am inside a lock
the standard exception handling is replace by the lock call.
thus where i formerly might have seen some error message
and a hint for the exact line of trouble (or even a stack trace)
i am now getting only outputs that do hint for the lock
being returned - and a "FAILED" error is reported at the very end of my pipeline.
also i feel that cases where the lock fails (e.g. empty string passed to the label: parameter; or no such label found...)
there is no good chance to locate and tell about the failure of lock-reservation - no such messages, just an overall failure.
What Operating System are you using (both controller, and any agents involved in the problem)?
Jenkins 2.346.3 on Linux
lock plugin 2.18
Reproduction steps
setup a pipeline
use the lock() { ... } command
raise failures, such as empty label, non-registered label, an exception in the clamped block...
Expected Results
sufficient outputs to know about the error in the enclosed block
sufficient outputs when the lock itself failed for whatever reason
Actual Results
the lock function call just silently fails and terminates the build - also hiding all other failures that lead to the error state.
Anything else?
No response

@AlexanderStohr can you confirm this issue also in the latest released plugin version? 2.18 version is pretty old one.

i don't have a matching runtime handy.

Ok, I will try it.


[tests-only][full-ci]Extend tests coverage for different role capability for spaces

Description
This PR adds tests coverage for different role user to manipulate space
Related Issue

https://github.com/owncloud/ocis/issues/5565

Motivation and Context

How Has This Been Tested?

Locally

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[x] Acceptance tests added
[ ] Documentation ticket raised:

@amrita-shrestha shouldn't we add this to stable first?

@SwikritiT some features related to assigning roles are not implemented in stable so we may have to skip that on stable I create PR in master so we can cover a max number of scenarios and later skip on stable


fix var hides class member, constructors with this->

partial fix luxonis/depthai-core#247

Use camelCase on the refactored parts

done and force-pushed


feat(content-band-list-block): Section content band list block.

Issue
Fixes #MERATIVE-781
Description
This ticket is part of the phase 3 effort, which is to migrate all of the remaining components/patterns in AEM over to Franklin. Sections > Section Content band list
Note: part of this work is to clean up the naming in Franklin to ensure it aligns with our Design Systems.
New

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Figma Link - https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=1459-14993&mode=design&t=WtS8KBTRL2E1rFnO-0

Test URLs
https://section-content-band-list--merative2--nimithshetty17.hlx.page/block-library/sections/section-content-band-list
Testing Instruction
To test the content band list and its responsiveness with respect to the design across all devices.

Checked, its good to go @nimithshetty17
CC: @proeung @keith-kaplan @helms-charity @sharathmrft @Shalini-SB

@proeung @keith-kaplan - I have made changes to the styles accordingly. Please have a look and let me know if there are any concerns.

@nimithshetty17 In an effort to move this ticket along. I'm gonna go ahead and take over this work. I'll assign you as one of the reviewers when it's ready.


hover over profiles in "followed by" section

https://github.com/user-attachments/assets/470ee021-5cc6-41e0-8d74-b607e6eaf255
Task

should only show cursor pointer and not changing the color fo the border

👋


I have installed this package in my win server.

I have installed this package in my win server.
By the way, can not see the admin panel dashboard successfully.
I got cache store does not support tagging and changed AES-256-CBC to AES-128-CBC.
So I change the file to array in cache config file.
So  I could see  the login page.
But I can not see the dashboard with time out 30s issue.
Want your help.

@Jinqianv , Can you try to clear cache by running artisan command php artisan cache:clear. We use cache array config in our projects too and it works fine. If after cleaning cache problem still exists, please attach your log file and we will investigate them.

@Jinqianv Just want to follow up on this, is the problem still relevant, or could the issue be closed? If there are any questions, just let me know.

@Konro1... I'm actually facing the same problem. However, I'm using a Mac. I was able to seed the database successfully... But, I'm not able to access the public folder... I get 'Internal Server Error'.

@Konro1... So, I'm not able to access the interface of the admin application.


chore: update examples so messages reference channel messages

addressing #991
channels and servers were correct anyway as we never had servers and channels under components before, so converter did not handle setting refs to components
this PR:

fixes messages references
solves some naming errors, left overs that I did not fix with my previous PR for adjusting examples

I was fixing examples to make sure they are v3 valid:

by adding # yaml-language-server: $schema=https://raw.githubusercontent.com/asyncapi/spec-json-schemas/next-major-spec/schemas/3.0.0-without-%24id.json to the file and making sure nothing blinks red
changed references, I was making sure they are valid links, VSCode makes them active links

/rtm


Introducing backup variable

This PR is to implement the https://github.com/ministryofjustice/modernisation-platform/issues/4803 ticket.
Allowing to specify what kind of backups should be taken by passing backup input value and amending the backup tag accordingly:

if backup is set to all or is missing, set backup tag to true on both ec2 and ebs tags
if backup is set to ec2, set backup tag to true for ec2 and false for ebs tags
if backup is set to ebs, set backup tag to true for ebs and false for ec2 tags

This is not needed anymore as the functionality exists through the original backup tags.


Refactor database provider for web

From tenfour-archive created by caharding: ushahidi/tenfour-archive#1125
Currently the WebstoreProvider is being used in the PWA but is only a skeleton simply returning empty results. If we want to implement storage in the PWA, we could use something like IndexedDB or WebSQL
Some Angular2+ module options:
https://www.npmjs.com/package/angular2-indexeddb
https://www.npmjs.com/package/ngx-warehouse
https://www.npmjs.com/package/ngforage

Currently the WebstoreProvider is being used in the PWA but is only a skeleton simply returning empty results. If we want to implement storage in the PWA, we could use something like IndexedDB or WebSQL
Some Angular2+ module options:

https://www.npmjs.com/package/angular2-indexeddb
https://www.npmjs.com/package/ngx-warehouse
https://www.npmjs.com/package/ngforage

@dale to add spec and estimate


Update how-to-modify-group-settings.md

Message Batch Threshold and Large Message Size default values were mixed up. Update to switch them back.

Docs Build status updates of commit a315836:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/core/how-to-modify-group-settings.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 8652e2c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/core/how-to-modify-group-settings.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Feature Request] Add an ability to resolve ServiceURL based on a channel ID

This issue is a feature request.
Based on the issue:
#2003 Authorization for Microsoft App ID failed with status code Forbidden
As pointed out in the documentation the ServiceURL is not persistent and bot should use ServiceURL from an activity rather from hard-coded value.

But there are cases when bot need to send a proactive message when there is no activity from a user for a long time.
For that case it will be useful to have an ability to resolve actual ServiceURL based on a channel ID.

Hi @lisitsyn-a, there may not be a single ServiceUrl for a given channel. In some cases, the ServiceUrl may vary based on the conversation ID.
The ServiceUrl typically isn't sufficient to send a new message. In addition to the URL, you must also have a conversation ID and the bot's address within channel (so you can properly populate the Recipient field). In some cases, the bot's address is dynamic.
For now, we recommend you store the conversation ID, Recipient field, a user ID (if you want to contact them directly), an activity ID (if you want to reply to a particular reply chain), and the Service URL if you want to send send a proactive message. Both SDKs have objects for storing these values: Resumption Cookie (C#), and Address (Node.js).
We've heard the request for a resolver endpoint but have found in many cases that bots need to store this other data, so we're recommending you use Resumption Cookie or Address for now.

As @lisitsyn-a said,
there are cases when bot need to send a proactive message when there is no activity from a user for a long time.

How could we know if the ServiceUrl has changed if there's no activity from user?

i am also facing the same issue as @thstarshine


Possible Onboarding Methods missing

On this section for Windows Server 2019 and later, Windows Server 2019 core edition, Windows Server version 1803 and later it does not mention Azure Defender / Security Center as a way to onboard these server version, I would assume that if these are available in Azure, they would be available to onboarded on the Azure Defender / Security Center methods.
Also, it is quite unclear which methods work based on where the VM lives, as there's different methods that'll work if the VM is on-premise vs. in Azure or another cloud.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f43ff24-610d-5bd7-cc54-14a418b7d494
Version Independent ID: 3a677b3a-712c-dd35-e31c-dfcc18808c43
Content: Switch to Microsoft Defender for Endpoint - Onboard
Content Source: microsoft-365/security/defender-endpoint/switch-to-microsoft-defender-onboard.md
Product: m365-security
Technology: mde
GitHub Login: @denisebmsft
Microsoft Alias: deniseb

Hello @digitalzomb and thank you so much for your feedback. I am looking into this and will post an update here soon. Appreciate you raising this to our attention!

Greetings @digitalzomb @yogkumgit
The article has been updated and the changes will be live later today (around 4 p.m. Pacific Time). Thank you again for the helpful feedback!


Demo link in readme file does not work.

The demo link points to https://github.com/curvenote/editor/blob/main/demo/index.tsx for github doc and https://github.com/curvenote/editor/blob/HEAD/demo/index.tsx in npmjs doc. The result is page not found. I think it should be something like: https://github.com/curvenote/editor/tree/main/packages/editor/demo

Thanks! This has been cleaned up, and will get it out to NPM soon. 🚀


⚠ Samsung has degraded performance

In da53951, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2160 ms

Resolved: Samsung performance has improved in eb3130b.


Font files are missing in build.prod

When building a prod package and fonts are included via css they won't get included in the prod package.
Current workaround is to copy all files manually in the app/ directory.
I think this could be done in a gulp task. Am I right?

If the font files are located somewhere inside assets then the task build.assets.prod will copy them.
If you're using fonts from node_modules you need to explicitly specify that the need to be copied in config.ts

I've tried adding the bootstrap glyphicons by adding this
{ src: 'bootstrap/dist/fonts/glyphicons-halflings-regular.eot', inject: true}
to PROD_NPM_DEPENDENCIES.
Nothing is getting copied/injected. Not sure where to look.

@bertvh Can you try { src: 'bootstrap/dist/fonts/**/*', dest: FONTS_DIR }. Fonts should not be injected.

Doesn't seem to do anything. If I don't inject the fonts, I need to get them in a location relative to the aggregated minified css (in this case bootstrap.css refers to ./fonts/glyphicons-...). Maybe I've changed something locally. Will look further. Thanks.

I too have the same problem. Can't copy fonts.

Eventually, I fixed this by writing a small plugin based on gulp-extract-css-urls. What is does is parse the css file and then copy all dependencies to the correct level in your output folder.
This works for me but is not heavily tested!
You can add this in build.html_css.prod.ts:
// ...
import * as through from 'through2';
import {readFileSync} from 'fs';

var url = require('rework-plugin-url');
var rework = require('rework');
var vinylFile = require('vinyl-file');
// ...

/**
   * This is a gulp plugin that takes a css file and outputs the files that the css file refers to via url().
   * Heavily inspired on https://github.com/skyrpex/gulp-extract-css-urls/blob/master/src/index.js
   * @returns {NodeJS.ReadWriteStream}
   */
  var includeCssResources = function () {
    return through.obj(function (file, encoding, callback) {

      var self = this;

      // callback for the rework-url plugin
      var handle = function (url:string) {
        if (url.match(/^data:/) || url.indexOf('#') >= 0) {
          return url;
        }
        self.push(vinylFile.readSync(url, {cwd: dirname(file.path)}));
        return url;
      };

      // Read css file and give it to rework for parsing
      var cssContent:Buffer = readFileSync(file.path);
      rework(cssContent.toString()).use(url(handle));

      // Call this when done
      callback(/*possible error*/);
    });
  };

// Copy and concatenate all external css
    function processExternalCss() {

      // copy all dependencies from the css to the css destination
      gulp.src(getExternalCss().map(r => r.src))
        .pipe(includeCssResources())  // this does the includes
        .pipe(gulp.dest(CSS_DEST));

      return gulp.src(getExternalCss().map(r => r.src))
        //.pipe(plugins.cssnano())
        .pipe(plugins.concat(CSS_PROD_BUNDLE))
        .pipe(gulp.dest(CSS_DEST));
    }

This is my problem as well. Tried to copy with this
{ src: 'material-design-iconic-font/dist/fonts/**/*', inject: false, dest: JS_DEST }
but failed to do so. Isn't any easier solution out there?

@zcsongor This was previously supported by the build.deps tasks which has been removed since then.
An easy way to add it again is to add copy tasks with the appropriate config.
https://github.com/ludohenin/ng2-wp-blog/blob/master/tools/config.ts#L98-L100
https://github.com/ludohenin/ng2-wp-blog/blob/master/tools/tasks/copy.fonts.prod.ts
//cc @mgechev Do you think we should support it ?

Thank you!

We should support copying fonts given the current copy task.

My version of this that works with bootstrap 3 looks something like this:
in the config.ts:
export const FONTS_DEST = ${APP_DEST}/fonts;
export const PROD_NPM_DEPENDENCIES: InjectableDependency[] = normalizeDependencies([
    { src: "bootstrap/dist/fonts/**", inject: false, dest: FONTS_DEST }
]);
and then 'build.fonts.prod' task:
return gulp
    .src(getFonts().map(r => r.src))
    .pipe(gulp.dest(FONTS_DEST));

function getFonts() {
    return PROD_DEPENDENCIES.filter(d => /fonts/.test(d.src));
}

I'm not sure though if it's a best place for the font files to be referenced from the array of 'InjectableDependencies'  :cactus:

@heikoholland the solution by @dimarzionist sounds like the correct one.
I agree that it doesn't sound very semantically correct. I'll rename the interface.

Here's wiki page I added https://github.com/mgechev/angular2-seed/wiki/Add-external-fonts
Let me know if you find something wrong.

@mgechev I don't think it will work. The src is just a string, so no changes to find a font extension in it. I'd rather map src defining a glob in build.assets.prod to copy those files with the rest.
I'll try and send a PR for that.

build.assets.prod isn't the right place ... DEST issue :/

@mgechev I tested your approach but, like @ludohenin expected, it does not work.


[RFC]: improve README examples of number/float32/base namespace

Description
This RFC proposes to improve the README examples of the number/float32/base namespace package. Currently, namespace package READMEs only include minimal examples which are not particularly informative and do not showcase namespace functionality.
Historically, namespace examples were not given much effort due to the rapidly changing nature of the project; however, now that development and organization has settled, it would be good to revisit these packages and add proper examples to better communicate to users how to use namespace contents.
For those wanting to contribute to this issue, you can use the following steps:

Browse through the contents of the number/float32/base namespace and identify interesting functions and packages to showcase.
Update the example code block in the "Examples" section of the README for the number/float32/base namespace and open a PR.
When updating the README, examples should follow existing project conventions (e.g., ES5).
Examples may require functionality from other packages to help make examples more interesting.

Related Issues
None.
Questions
No.
Other
No.
Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

@Planeshifter I would like to work on this issue

@CodeMaverick2 Assigned. Please only work on updating one README at a time.

Yeah sure @Planeshifter  And should I also update the index.js for examples according to the examples I add


more time for devicelab tasks

We currently let the main body of these tests take 30 minutes. If that times out, all subsequent steps fail to run becaue of global shutdown. This means we don't get a chance to upload logs or screenshots.
see https://github.com/flutter/flutter/issues/83939

test-exempt: configuration


Enable distribution of modules again

These re-enables publication of the JBoss Modules, the last blocker for 5.4.0.Beta1
Also includes:

now WildFly tests work on Java9
switch from HornetQ to ActiveMQ

Most of the documentation changes are a revert to previous text which was taken out when we disabled the modules distribution.

https://hibernate.atlassian.net/browse/HSEARCH-1893
https://hibernate.atlassian.net/browse/HSEARCH-1906
https://hibernate.atlassian.net/browse/HSEARCH-1931

Merged it; In case further doc changes are required, just push another commit or that.


⚠ ClamAV has degraded performance

In ebff558, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 4bdf345 after 539 days, 6 hours, 11 minutes.


Changed _unknown.svg flag to fit proportions

@wiredmax The last added _unknown.svg was in a different proportion than the other flags. I found a better fitting flag, which looks fine now.

Thanks, it has been published to NPM as version v0.1.17


CLI could miss UpdateWorkloadState between update and complete state request

If a workload that is in waiting to start state is deleted, it could be that (with the proper timing), the CLI misses the UpdateWorkloadState and declares the workload as removed. This happens because there is a small window between the update and get complete state where the CLI is not listening for the unsolicited messages.
The problem was only reproducible with release builds installed over the install script and started as systemd units.
Current Behavior

Expected Behavior

The CLI exits correctly when the workload is deleted.
Steps to Reproduce

Install Ankaios via the install script
start server and agent via systemd
ank apply a workload with a dependency which is not available
ank delete workload the workload
CLI hangs and waits for the missed message

Context (Environment)
Manjaro Linux
Ankaios v0.3.0-rc2

Logs
We checked the logs and the message is sent by the agent and received by the server

Additional Information

Final result

To be filled by the one closing the issue.

#246 is now merged. @christoph-hamm, we can now close this here right?


Delete /pb/ directory's README.md

No necessary and currently gets copied unnecessarily in the Dockerfiles - that could be avoided by making the copy commands only copy all *.pb but I'm not sure how much explaining is needed for this file. Each service should explain in their own README files what types of requests they can receive and what their responses will look like and any outgoing requests too?

I guess @cartersocha added this intentionally so other markdown files can reference this README.md, @mic-max see if you can get the CI clear.


Refactor CSS - closes #17

This PR finishes the CSS refactor issue.

Refactor...
This refactor rearranges the SCSS file to more closely resemble the HTML structure of the portfolio.  Beyond that, removed many redundant rules, fixed the content card layout to better utilize the open space and extirpated some useless div elements.
Finally, pushed through a stopgap solution to render the Unity logo using DevIcon.


Blender crashes on export of this file

We've found this one lod file that seems to crash blender when you try to export it. Here is the: file
3 different people on the discord have tried this, and all have had the same result of blender just freezing up/stalling.
Even without modifying this file at all, we're unable to export it.

This is strange. It also seems to crash when switching to edit mode.

Fixed with commit 4e4873ef38e2b0299cfb473ded4a48e4b5609e48 . Although we will have to get to the bottom of why some of these meshes are invalid in the first place I'll make a new issue.


Add MONet sampling slots

To accommodate MONet metadata submission via the NMDC submission portal, we need to add the following slots to the schema.  (3 new slots)
infiltration_1:
description: Amount of time it takes to accomplish the first infiltration activity
title: infiltration time 1
examples:
- value: 15 minutes
multivalued: false
infiltration_2
description: Amount of time it takes to accomplish the second infiltration activity
title: infiltration time 2
examples:
- value: 15 minutes
multivalued: false
infiltration_note:
description: Any details, issues, or context needed to understand the infiltration activity
title: infiltration notes
examples:
- value: Raining all day, infiltration unsuccessful
- value: Infiltration too rapid to capture
multivalued: false
bulk_elect_conductivity:
description: Electrical conductivity is a measure of the bulk soil ability to carry electric current, which is mostly dictated by the chemistry of and amount of soil water. Provide the value output of the field instrument.
examples:
- value: 0.003 milli siemens per centimeter
- value: 0.003 mS/cm
multivalued: false
Note, the units will likely remain consistent!

(non-squad activity)

I apologize for forgetting about this.
These slots will require some remodeling. They appear to be in the schema/data hybrid notation and will need to be rewritten. We will also need to determine which class(es) can use them.

is there really no information about an infiltration other than it's duration? and a note? I proposed creating an Infiltration class, with slots for duration, notes and additional future attributes.
directives like "Provide the value output of the field instrument" are OK for a submission schema, but the nmdc-schema emphasizes purely descriptive descriptions, like "The measure of the bulk soil's ability to carry electric current." I would propose moving "mostly dictated by the chemistry of the soil and the amount of soil water" to a comment

Adding to current sprint per Mark. Will be part of Metabolink squad work per Mark.
FYI @anastasiyaprymolenna

Marked as done on the Metabolink board so closing this issue.

These slots don't appear to be in the schema? That said, they were important for the submission portal for MONet submissions... and I think the decision is that's not happening now. So we do not need these MONet specific slots.


customize hueristics for textDocument/switchSourceHeader ?

I'm not sure exactly what heuristic clangd uses to locate header/source file pairs for the purpose of textDocument/switchSourceHeader requests, but it seems like it generally doesn't find the corresponding files when they are separated by one or more subdirectories. For example, if you have a header file in src/component and the implementation in src/component/impl, then clangd doesn't find it.
Is there any way to hint or suggest possible relative search paths when trying to locate corresponding source/header files? In the case of header-->source mapping, there might be a solution that would just search the entire compile database (if using one) for the matching source name, but that only works in one direction.

The heuristic used by clangd (up to v9) is very naive -- we just look for the corresponding .h/.cc file in the same directory, so it doesn't work for your case.
Good news is that recently we have built a smarter header-source-swich based on the index, it is designed for cases like yours. It will be available in next LLVM release v10.

thanks for the clarification - looking forward to v10.


Marker creation - deselect icon

When creating markers, an icon cannot be deselected after it has been selected.
Please insert a field „kein Icon“ in the icon drop-down list to enable a deselection of the icon.

Will be part of next release

Included in v0.8.8 release.
@s-platte please retest


Upgrade to MP Health 4.0 and align with jakarta.* namespace

Fixed in jakarta branch - https://github.com/smallrye/smallrye-health/commit/772e95910c7b9c7f45154d7045269d0616dd37ae.


MODOAIPMH-293: Transfer suppressed records with discovery flag is not honored for instances suppressed from discovery

Jira: https://issues.folio.org/browse/MODOAIPMH-293
PURPOSE
Fix misconfiguration issue caused by the reason that downloading instances is performed in a separate context which wasn't populated with oai-pmh configs data.

Why do we need a separate "downloadContext" (line 140)?

Honestly, I feel like storing the configuration on a vertx context just adds a layer of complexity that isn't necessary. Really, all we need is a static map with tenant as the key and the config as the value. There's no need to store this on any vertx context. Doing so is only going to lead to these sorts of problems.
We already have public static String RepositoryConfigurationUtil.getProperty(tenant, name), why not just store the configs in a static map in RepositoryConfigurationUtil? IMO there's no need to get the vert contexts involved here.

Hi @craigmcnally, I strongly agree with you that it will be much simpler and less problematic, I will refactor this part of the code.

Please add a unit test to verify this fix

Unit test has been added


Cargo.toml: Improve mkroening author

bors r+

bors retry

bors retry

This is https://github.com/hermitcore/libhermit-rs/issues/301 again.

bors cancel

bors retry

bors r+

bors r+


Improve message id cache

Describe the bug
Right now we use WeakMap to cache message id and it takes time to cache messages there

It seems that after we improve the memory, this map keeps growing and we don't control the max size of it
Expected behavior
Find another way to cache that we can control the size of the map

there is similar issue to the UncompressCache, we can just cache the uncompressed message data right inside the message and remove it

there is similar issue to the UncompressCache, we can just cache the uncompressed message data right inside the message and remove it

Sounds good!


Consider emmet-ls

Should be easy since it can be install with npm
https://github.com/aca/emmet-ls

Awesome, I was looking for emmet completions myself :) Will add this soon

@ChristianChiarulli have you tried it? Not sure I want to bundle this, as the emmet-ls lang server doesn't work too well for me.

completion often needs to be triggered manually (eg not automatically on type)
cursor position after completion is

| instead of
|

Will probably add this when the npm release is updated. There are some promising commits in the repo that are not yet published.

If you want this for yourself, just add it to your config somewhere before setup():
require'lspinstall/servers'.emmet = {
  install_script = [[
  ! test -f package.json && npm init -y --scope=lspinstall || true
  npm install emmet-ls
  ]],
  default_config = {
    cmd = { "./node_modules/.bin/emmet-ls", "--stdio" },
    filetypes = { 'html', 'css' },
    root_dir = require'lspconfig'.util.root_pattern(".git", vim.fn.getcwd()),
  }
}

Then you'll be able to :LspInstall emmet

Will probably add this when the npm release is updated. There are some promising commits in the repo that are not yet published.

Hey, just to let you know, the npm package finally got updated a couple of days ago, it's working  better for me, although the integration with nvim-compe is not as good yet, there's some snippets that don't expand correctly with compe :(

@rafamadriz which snippets for example?

@kabouzeid  Okay it seems like it's all working fine now, for the longest time any snippet that had $ or spaces a{Item  $} wouldn't work at all using nvim-compe. Just tried once again and those snippets get properly expanded now.

Thanks for the fast response! Sounds great, I'll give it another try, and bundle the installer in nvim-lspinstall if it's working as expected.


Providing example file for package.

Hi.
I'm going to use vlucas/phpdotenv for one of my packages.
I'd like to create an mypackage.dotenv.example file and have that installed into the root of the user's project (i.e. parallel to vendor rather than embedded within it).
Is this possible?
I suspect this is more of a composer issue, but I was wondering how packages that use vlucas/phpdotenv provide the example file for the users of their package.
It could be possible to say that the example file is tucked away in vendor, but ideally, I'd like to leave vendor alone and provide the example file in another location, allowing the developer who incorporates my package to not have to go hunting for the example file.

I am not sure how to do this, other than providing written steps to do this in your package's installation instructions.

Which is what we are doing. Also, I wasn't aware that only 1 .env file is possible. I suppose it makes sense, but it would be nice to be able to keep .env files for different packages separate.
Unless I've missed something.


trusty & puppet: Warning: Connection refused. Retrying...

$ PUPPET=1 make trusty
$ cd some_other_dir
$ cat Vagrantfile
Vagrant.configure("2") do |config|
  config.vm.box = "trusty64"
  config.vm.provider :lxc do |lxc|
    lxc.customize 'aa_allow_incomplete','1'
  end
end
$ vagrant add box --name trusty64 ~/vagrant-lxc-base-boxes/output/2014-12-30/vagrant-lxc-trusty-amd64.box
$ vagrant up --provider=lxc
Bringing machine 'default' up with 'lxc' provider...
==> default: Importing base box 'trusty64'...
==> default: Setting up mount entries for shared folders...
    default: /vagrant => /home/jake/repos/c4puppet
Warning! The LXC provider doesn't support the :owner parameter for synced
folders. It will be silently ignored.
    default: /tmp/vagrant-puppet-2/manifests => /home/jake/repos/c4puppet/manifests
Warning! The LXC provider doesn't support the :owner parameter for synced
folders. It will be silently ignored.
    default: /tmp/vagrant-puppet-2/modules-0 => /home/jake/repos/c4puppet/modules
==> default: Starting container...
==> default: Waiting for machine to boot. This may take a few minutes...
    default: SSH address: <IP_ADDRESS>:22
    default: SSH username: vagrant
    default: SSH auth method: private key
    default: Warning: Connection refused. Retrying...
    default: Warning: Connection refused. Retrying...
    default: Warning: Connection refused. Retrying...

It appears that openssh-server is not installed.  Installing it seems to resolve the issue:
$ sudo lxc-attach -n $(cat .vagrant/machines/default/lxc/id)
root@vagrant-base-trusty-amd64:/# apt-get install openssh-server
 ... installing ...
root@vagrant-base-trusty-amd64:/# exit
exit
$ vagrant ssh
vagrant@vagrant-base-trusty-amd64:~$

Resolved in this pull request: https://github.com/fgrehm/vagrant-lxc-base-boxes/pull/37

The PR mentioned above has been merged! :rocket:


Release 2.1.1

Questions
Answers

Description?
Release 2.1.1

Type?

BC breaks?

Deprecations?

Fixed ticket?

How to test?

@Hlavtox ,
It seems like it's missing the upgrade file. Could you check ?

@florine2623 I forgot to update the version number, now you can test it. ;-) Sorryyy


Creating Social Media accounts

Icons of facebook, instagram and other icons does not contain the original website links. So if you provide the links , then I can make them functional or else you can share the details, so that I can create accounts .
This will provide users with easy access to our social media profiles and improve engagement.
Could you please assign this issue to me under GSSoC'24?

@khushi-joshi-05  please assign this to me i am GSSOC'24 contributor with 2+ years of experience in development


Support for HT1621 Module Character LCD

it's called 5V LCD Module 6Bit 8-Segment 3-wires SPI HT1621 Module Character LCD for Arduino.
On ebay: http://www.ebay.com/itm/351939450953

@rm-hull also sent one your way

Awesome... 😆

Arrived today, pulling together a driver now, rudimentaries are there:

It will most likely be driven like the max7219 by wrapping the `sevensegment class around the driver, eg.

from luma.lcd.device import ht1621
from luma.core.virtual import sevensegment

device = sevensegment(ht1621())
device.text = "Hello"

[the sevensegment class will need to be pulled into luma.core]

nice! expecting mine any day then.

WIP on branch https://github.com/rm-hull/luma.lcd/tree/ht1621
Its getting there, but the segments are mapped differently to the max7219 segments, so not sure if it is a good idea to push those down into core. At the moment I just created a hack test script that converts the segment bytes on the fly.

looks very crisp. but the battery icon is kinda burnt in there?

Like any LCD, unless you view it directly head on, you see the slight ghosting of the unlit segments.
The viewing angles aren't great.
Also, can't appear to switch the backlight on or off (it's on all the time)

Ok but its first screen i see with pre-defined icons as such.


$ is not a function of ElementHandle.

Running puppeteer 0.12.0v
Getting an error where $ is not a function of ElementHandle.  Are elementHandles even meant to have this? Because it's in the documentation: https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#class-elementhandle
This is what I'm doing:

        await page.goto(url)
        var frame = await page.frames()[0];
        await page.waitFor("iframe")
        var child = frame.childFrames()[0]
        // wait for the image cut block to be visible
        await child.waitFor("section[data-type=imagecut]")
        // open the image cut
        let section = await child.$("section[data-type=imagecut] h1")
        await section.click()
        let elements = await child.$$("section[data-type=imagecut] fieldset div")
        for (let element of elements)
        {
            let a = await element.$("a")
            await a.click()
            await child.waitFor(2000)
        }

What I expected to happen was that it would find an  tag from the reference of the div then I would be able to click it.
Instead, it just gives me that $ is not function of element.

elementHandle.$(selector) is available from the v0.13.0-alpha. You can upgrade with npm install https://github.com/GoogleChrome/puppeteer/.


Fixed annotation on id property for tokens delete command.

Command failed with "missing required parameter" without it.

Whoops, sorry about that! Fairly certain I tested this though, strange 🤔

I was checking, discovered I had like 30+ old api tokens defined, and tried to delete a couple. And it failed.
No big, and I just released 0.4.0 so it's fixed in the file now.


Syncer

Opening for visibility.
Based kayaba's earlier work on https://github.com/farcaster-project/farcaster-node/pull/18 , but now using my own farcaster-core branch: https://github.com/TheCharlatan/farcaster-core/tree/syncer .

The pull requests is based on https://github.com/farcaster-project/farcaster-core/pull/100 . Once this pull request is merged, the farcaster_code dependency in the Cargo file needs to be changed again.

created farcaster-project/farcaster-core#101 putting correct dependency in core, this would allow us to converge into farcaster-core main repo

#9a33509 rebasing


Fix #894, add resource ID type

Describe the contribution
Add a new typedef CFE_ES_ResourceID_t that can replace uint32 for all ID storage and manipulation. Initially this is just an alias to uint32 for backward compatibility.
Convert all APIs that accept an ID to use the new typedef.
This also reserves the value "0" as an undefined ID, and gives a separate base value for each resource type. Therefore even though the type is still fundamentally a uint32, the different resource IDs can still be distinguished.
Fixes #894
Testing performed
Build and run, sanity test CFE, ensure apps and libs are loaded OK
Spot-check various commands that operate on apps/appids by sending using cmdUtil.  Confirmed commands that write to data files (e.g. QUERY_ALL) has the correct appIDs in the file (e.g. 0x02110000 instead of 0x00000000 for CFE_EVS).
Confirmed that commands that operate on app name (start/stop/restart etc) still work fine.
Expected behavior changes
IDs are no longer zero based.
This should not matter so long as the ID is treated as opaque, and only manipulated via the ES APIs.  This matters if an app is using the ID as a table/array index.  All instances of this usage in CFE itself has already been fixed, and initial review of CFS apps didn't show any concerns.
Otherwise, no change to behavior as long as IDs are treated as opaque and only stored/used per API.
System(s) tested on
Ubuntu 20.04
Additional context
An optional add-on can make the ID type into a struct so it triggers a compiler error if/when used as an integer.  This can aid in updating apps that might still use uint32.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Update commit 7132452 just corrects a doxygen warning.

Update commit 96d82c5 fixes a cppcheck warning....

Personally I'd rather see more specific types, CFE_ES_AppID_t, CFE_ES_TaskID_t, etc. Could do that later, after this monumental change set is applied...

CCB 2020-09-23 APPROVED

Personally I'd rather see more specific types, CFE_ES_AppID_t, CFE_ES_TaskID_t, etc. Could do that later, after this monumental change set is applied...

Right - by design this is also entirely possible if we want to do this.  The API has separate category-specific functions so its easy to update these to have a separate ID type per category.  But you get much of the same effect by using different bases, it just happens at runtime rather than compile time.  And it wouldn't be possible to trigger compile time checking as long as we are still using uint32 ... until we transition to a type safe wrapper, there is no benefit to different types.
Still if we wanted to at least define separate types now, it could be a good idea.

Still if we wanted to at least define separate types now, it could be a good idea.

I like separate types, a step further in the right direction.

Still if we wanted to at least define separate types now, it could be a good idea.

I like separate types, a step further in the right direction.

No objection there -- do you want me to submit a separate PR for that or add a new commit on top of this one?  My suggestion is a separate PR, and I can have it ready for next week CCB.

Personally I'd rather see more specific types, CFE_ES_AppID_t, CFE_ES_TaskID_t, etc. Could do that later, after this monumental change set is applied...

Right - by design this is also entirely possible if we want to do this. The API has separate category-specific functions so its easy to update these to have a separate ID type per category. But you get much of the same effect by using different bases, it just happens at runtime rather than compile time. And it wouldn't be possible to trigger compile time checking as long as we are still using uint32 ... until we transition to a type safe wrapper, there is no benefit to different types.
Still if we wanted to at least define separate types now, it could be a good idea.

Actually was thinking:
typedef uint32 CFE_ES_ResourceID_t;
typedef CFE_ES_ResourceID_t CFE_ES_AppID_t;
...
so you could switch all to a struct with one line change...And gives more explicit semantics that the "subtypes" are related.

FYI - submitted issue #913 to make the separate type per category enhancement.  I can have this for next CCB but need to get this into the baseline first, so I don't want to hold this one up.


WIP: enable MeshLine.load

For #175, which in a minimal sense is just because 'line' is missing from the dict in bnd_types in 'Mesh._parse_submeshes`, but I'll check whether anything else is required.

This is enough to suppress the warning and load Physical Curves as MeshLine.subdomains, if present.
Fixes #175.

Shortcoming: see #178; basically MeshLine.p.shape[0] and therefore MeshLine.dim() is whatever was in the file, typically 3.

Fixes #178; the problem was that MeshLine.strip_extra_coordinates wasn't overridden and defaulted to that from Mesh which does nothing.

Shortcoming: doesn't read all boundaries #175.

This has been rewritten so that MeshLine._build_mappings no longer sorts MeshLine.p.  This required fairly extensive changes, e.g. to the

__init__ method, which previously silently ignored t
_uniform_refine, which relied upon a subsequent call to _build_mappings to resort p and regenerate t from scratch

It now all works though, successfully running ex15, ex16, ex23, the various one-dimensional tests, and an in-house example involving multiple Gmsh Physical Points which become entries of MeshLine.boundaries.

Very impressive work. Thanks a lot for these contributions.

It's slightly inconvenient that building facets is now done in two places (refine and init) instead of one (_build_mappings), but we can try to workaround it later. I'm going to merge this.


fix Go SDK codegen for devtestlabs package-2018-09

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-node

Automation for azure-sdk-for-js

Automation for azure-sdk-for-python

Automation for azure-sdk-for-java

Automation for azure-sdk-for-ruby

Fixes https://github.com/Azure/azure-rest-api-specs/pull/4794

Automation for azure-sdk-for-go

Can one of the admins verify this patch?


mount-s3 stopped working without explanation

Mountpoint for Amazon S3 version
mount-s3 1.3.2
AWS Region
us-east-1
Describe the running environment
Running on a EC2 with linux instance with IAM credentials against a bucket in the same region
Mountpoint options
--dir-mode=0777 --file-mode=0777 --allow-other --allow-delete

What happened?
Mounted directory stopped being available while the mount-s3 process was still running with no error being logged anywhere.  The processes that required access to the directory all failed with timeouts when trying to operate with S3 through the mounted directory.
journalctl -e SYSLOG_IDENTIFIER=mount-s3 stopped logging when this happened without reporting any error.
Relevant log output
No response

Hi @sibutorovic, thanks for reporting the issue. Are you able to reproduce this problem?
We will need to see mountpoint logs in order to investigate the problem. It would be great if you can capture debug logs next time this happens. See https://github.com/awslabs/mountpoint-s3/blob/main/doc/LOGGING.md#verbose-logging for logging configuration.

Hello! I am unable to reproduce this problem because it might be related to high stress of our site.  Regarding the logs, mountpoint stopped logging when this happenedes but I will enable verbose logging so I can bring any logs that might appear next time it happens,

Thanks @sibutorovic. While we're waiting for the logs, could you share more details on access pattern that might be causing the issue?

Closing this issue for inactivity. If this is still a problem, feel free to reopen.


Custom callouts and markers not working correctly

Hey all,
After upgrading to RN 0.32.0 and react-native-maps 0.8.0 weird things started happening with maps in my app. At first, I have experienced the callout cut-off issue (#427) which is "workaroundable". What puzzles me now is the issues that came after :

1. In order to trigger the callout I need to click a little bit over the custom marker (which in this case is the red square). Clicking on the red square itself doesn't do anything in this regard apart from triggering onSelect and onPress (callout should show at this point as well!).
2. After clicking a little bit over the marker the callout seems to show but under other markers. How to position it back on the top? It worked correctly in the previous versions.
Supplementary snippet :
 <MapView.Marker
            coordinate={marker.loc}
            onSelect={() => alert("test")}
            onPress={() => alert("test")}
          >
            <View style={{height:20, width:20, backgroundColor:'red'}} />
            <MapView.Callout tooltip={false}>
              <BCClickableCallout title={marker.title} bar={marker.bar} onSelected={() => { alert("go places")  </MapView.Callout>
          </MapView.Marker>

What happened in the new version that broke it all? Is it me doing something wrong or is it a bug?

I'm also having the same problem, here is the code I'm using to test out the events:
import React, { Component } from 'react';
import MapView from 'react-native-maps';
import {
  StyleSheet,
  View,
} from 'react-native';

var styles = StyleSheet.create({
    container: {
    	backgroundColor: '#003D40',
    	flex: 1,
    	marginTop: 65
    },
    map: {
        position: 'absolute',
        top: 0,
        left: 0,
        right: 0,
        bottom: 0,
      },
})
class Main extends React.Component{
	constructor(props) {
		super(props);
		this.state = {
			region: {
		      latitude: 37.78825,
		      longitude: -122.4324,
		      latitudeDelta: 0.0922,
		      longitudeDelta: 0.0421,
		    }
		}
	}
	onRegionChange(region) {
	  this.setState({
	  	region: region
	  });
	}
	render() {
		return (
			<View style={styles.container}>
				<MapView.Animated
				      region={this.state.region}
				      onRegionChange={this.onRegionChange.bind(this)}
				      style={ styles.map }
				 >
				 	<MapView.Marker
				 	      coordinate={this.state.region}
		 	      	 	  draggable
		 	       	      onSelect={() => console.log('onSelect', arguments)}
		 	       	      onDrag={() => console.log('onDrag', arguments)}
		 	       	      onDragStart={() => console.log('onDragStart', arguments)}

				 	  />
				 </MapView.Animated>
        	</View>
        )
	}
}
module.exports = Main;

(Running react-native 0.32)
Any help would be appreciated!

I also have this problem, but it started with 0.28.0, it is exactly as describe above, but something changed between 27 and upwards, but i wasn't able to find the issue.

I'm have the same issues. On react-native 0.33.0 and react-native-maps 0.8.2

I was able to fix this, by editing mapCallout.js within the react-native-maps package
import React, { PropTypes } from 'react';
import {
  View,
  requireNativeComponent,
  StyleSheet,
} from 'react-native';

const propTypes = {
  ...View.propTypes,
  tooltip: PropTypes.bool,
  onPress: PropTypes.func,
};

const defaultProps = {
  tooltip: false,
};

class MapCallout extends React.Component {
  render() {
    console.log(this.props.style)
    return <AIRMapCallout {...this.props} style={[styles.callout, this.props.style]} />;
  }
}

MapCallout.propTypes = propTypes;
MapCallout.defaultProps = defaultProps;

const styles = StyleSheet.create({
  callout: {
    position: 'relative',
  },
});

const AIRMapCallout = requireNativeComponent('AIRMapCallout', MapCallout);

module.exports = MapCallout;

by changing the callout style to position relative.
u could pass is as a prop.style, but i just changed it directly and the behaviour was normal again. "normal as in , as it worked before"
hope this helps someone

@ryanhoer @nazywamsiepawel @nillo
Can you confirm again that this is still working?
@ryanhoer Looks like you have a forked branch with that fix. Mind making a quick pull request?

@christopherdro, i have just upgraded to 0.35.0, and it still works.

@nillo that's great! Would you be able to submit a pull request with that small change and reference this ticket?
Thanks!

@christopherdro @nillo I just try the solution by changing 'absolute' position to 'relative' and doesn't seem to work for me, all the pin move in a wrong position on the map

Fixed for me on iOS.  After update from 0.11 to 0.12.1 callouts no longer display behind markers

that's great, thanks for the report!

The problem still happened for me with the version 0.12.1 with custom markers and callouts.

Still having this issue with RN0.39 and maps 0.12.4
				ref={(MarkRef) => {
					// logger.log("MARKER: " + selectedResult.title);
					if (MarkRef != null) {
						// MarkRef.showCallout();
					}
				}}
				coordinate={{
					latitude: selectedResult.mkrLat,
					longitude: selectedResult.mkrLong
				}}
				title={selectedResult.title}
				description={selectedResult.description}
				identifier={selectedResult.title}
				key={selectedResult.title}
			>
				<MapView.Callout style={{ width: 100 }} >
					<TouchableHighlight underlayColor={'rgba(200,200,200,.1)'} onPress={() => gotoNavigationApp(selectedResult.mkrLat, selectedResult.mkrLong)}>
						<View style={{ flex: 1, alignItems: 'center', flexDirection: 'row', flexWrap: 'wrap' }}>
							<Text style={{ flex: 0.8 }}>{selectedResult.title}</Text>
							<Icon style={{ flex:0.2 }} name={'location-arrow'} size={20} />
						</View>
					</TouchableHighlight>
				</MapView.Callout>
			</MapView.Marker>
			) : (null)}```

Seems like whenever additional markers, besides the initially rendered markers, are added to the mapview. This problem occurs. Which is unfortunate for me because I need to dynamically add markers to my mapview...

#1845 should solve this problem. Please comment if you tested and if there are any bugs detected, as collaborators ask me to have positive replies on my pull request to merge it to master.

Duplicate of #418

position, and set size for callout: {
position: 'relative',
height: 100,
width: 100,
},
and it worked for me.


definition of a new training (trainer: Francais-Pertinant")

Lets get this thing live!!

Look at this my mighty push