Updates to the Filter side bar on Results page (3/6)

Fixes

Related to #845 by @annatuma.
Description

Move the expand/collapse filter icon when toggle side bar and change some texts of license types filter.
If “Use commercially” is checked, NC licenses are disabled.
If “Modify or adapt” is checked, ND licenses are disabled.
Add 'disabled' attribute (binding) in label of checkbox for styles.

Screenshots
Showing side bar

Hidding side bar

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[ ] My pull request targets the master branch of the repository. (K: but default branch is develop ??)
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal this looks good. Thanks so much for working on this.
These is only one change we need you to make, and that is the icon to be used for the Filter. We'd like to use the Funnel filter icon moving forward. (Apologies that this was not communicated in the mockup, we are fixing that).
I am attaching a screenshot:

You can also see it here:
https://cc-vocabulary.netlify.com/?path=/docs/tokens-icons--figma
It is in Symbols -> Hieroglyphs section.

No problem @annatuma! Icon changed. Actually I noticed that moving the icon on the mobile version was pending, I pushed changes to fix that too. :)
Here are new screeshots:
Desktop version
Open side bar

Closed side bar

With filters applied

Mobile version

With filters applied


660 signup avatar upload improvement

@tibetsprague this makes the whole profile Avatar bubble clickable for upload on the Sign-up flow vs just the icon (as it is on in Edit User Profile. I think its a better better UX. Merge if you agree, close if not 👍


Deprecates tracing support for dependencies not released in 1.5-3.5+ years

This deprecates for removal the following, as they have not been updated in a long time. The exception to this rule is log4j context, which is widely used even if not updated recently.

context/rxjava2 - last released Feb 2021

replaced by RxJava3, but unlikely this module will be ported as it wasn't used widely.

instrumentation/dubbo-rpc - (alibaba) last released Dec 2021

replaced by Apache Dubbo instrumentation/dubbo

instrumentation/p6spy - last released July 2020

project dormant

instrumentation/sparkjava - last released July 2022

project dormant

These will be removed in Brave 6 and can be re-introduced if something changes.

opened #1394 about the flakey artemis invoker test

not sure why, but didn't flake this time.


N26: Learn WGPU section

Part of #783

@sotrh Any idea on why there are so many old commits as part of this branch? It might be caused by your source not being up to date with the origin's. We do squash changes though, so it shouldn't be an issue. Might be worth rebasing though.

@sotrh Any idea on why there are so many old commits as part of this branch? It might be caused by your source not being up to date with the origin's. We do squash changes though, so it shouldn't be an issue. Might be worth rebasing though.

Yeah I should probably rebase.


first attempt of fixing job-gms duplicity issue

Context
1st attempt of fixing job-gms duplicity issue. The fix includes

removing out-of-date analysis code
add EBean retry (Attempt 1) on search miss
add Jdbc retry (Attempt 2) on search miss (not enabled yet)

Checklist

[X] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[X] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

Do you plan on removing the ENUM's themselves + config?

Do you plan on removing the ENUM's themselves + config?

I'll do it later, still need it now for testing on small set of traffic.


Feature/hres refactor

We need to set a message/advice first time user enables the hr-layer. After that, I've set a cookie for 60 days to prevent this message appear again. Here you have the styles if you want to check that they are correct.
https://app.zeplin.io/project.html#pid=564c8b73362183187a126880&sid=57221fb360c90bd61e71f509

Ok, small comment on that empty function, but otherwise it works great locally ⭐


Fix a small typo in a comment in base.rb

Summary
Just fixing virutal to virtual in a comment!

@ayushn21 thanks for the PR!


catch ImportError instead of reading version number

Hi again @malexer ...  Thanks for releasing a new version of pytest-spark so quickly!
However I found a problem in the version check code I added in the spark_session fixture. pyspark.__version__ is only defined from v2.1 onwards... 😞
This causes an ugly exception instead of showing an explanation message, and most importantly even prevents the fixture from working on spark 2.0 where it should be available.
the spark version can be read from sparkContext.version  in older versions but that requires an instances of sparkContext to be created which is not the case here.
Instead I went for a simpler check to fix the issue: catch the ImportError in old spark versions and display a more helpful message.
Sorry about that!

Oh, my fault as well - I have not checked it on the older versions of Spark.
Thanks!


$gt selector doesn't work correctly with dates

I'm not sure if I have it set up wrong or what but when the $gt selector doesn't seem to work with dates.
Data:
{
docType: 'log',
logDate:<PHONE_NUMBER>926
}
Query:
var start = (new Date()).getTime();
db.find({
selector: { docType: 'log', startTime: { $gt: start } }
});
The above query doesn't returns no results with correct values for start and logDate. I also tried this without using epoch time and letting the date get serialized to ISO format and this doesn't work either. For some reason, it works if I use $gte
Edit:
I've created a plunker showing the issue here:
http://plnkr.co/edit/FU3SFp3E30ZTOElTbNSU

Can you provide a live test case? Just makes it easier to confirm what's going on. A JSBin or even just a Node script would be fine. :)

Hi Nolan, thanks for the quick response. I created a plunker here, just in case you didn't see the edit:
http://plnkr.co/edit/FU3SFp3E30ZTOElTbNSU

I just noticed that $gte doesn't work either when combined with $lt or $lte. It seems like it completely ignores $gt/$gte

Hi Nolan,
I'm sure you're very busy but have you had a chance to look at my plunk?
Thanks

Sorry, I looked at it just now.
db.post({ docType: 'log', logDate: new Date('2015-05-24')});

You cannot save Dates in PouchDB. IndexedDB will save the dates for you without emitting a warning, but it is a lie because the other adapters (and CouchDB) cannot, and unexpected things will happen when you do so.
You need to do:
db.post({ docType: 'log', logDate: new Date('2015-05-24').toISOString()});

Thanks for taking a look. I changed everything to use only strings and $gt and $gte still don't work correctly. See the updated plunk please. You can see the output in the console. I'm using Firefox, if that matters.
In the console, these two queries show something's wrong:
"-- querying docs logDate > 2015-05-25T00:00:00.000Z"
""
"-- querying docs logDate >= 2015-05-25T00:00:00.000Z and <= 2015-05-26T00:00:00.000Z"
"2015-05-24T00:00:00.000Z, 2015-05-25T00:00:00.000Z, 2015-05-26T00:00:00.000Z, "
The first query should return 2 docs (26th and 27th). The second should only return doc with logDate 26th

Okay, it does indeed look like a bug. I am very busy right now and will probably not be able to get to it for several weeks at the maximum.
If you would like to contribute the fix, you just need to write a test and fix it. :) The tests are described in CONTRIBUTING.md and are pretty easy to set up. Basically just check out the code, connect it to your Cloudant, and then run npm test.

fixed by https://github.com/nolanlawson/pouchdb-find/pull/44

fixed in 0.3.5


Revert "chore(deps): update dep typescript from 4.3.5 to v4.4.3"

Reverts artsy/force#8281

@dzucconi - can you update the PR description with details about why we had to revert? Then we'll know later when it inevitably fails 🔮

https://github.com/artsy/force/pull/8281 was automatically merged despite not passing type-check

oh no, so this is still happening?

in this case it appears it was Renovate that merged not Peril. 🤖 uprising?

😓


English Proofreading

Could you proofread the documentation? Please check README.md in particular carefully. index.md is almost same as README.md.

The README.md looks fine to me.
But, there is a small typo here:
Write documnetation in this file. Include at least the definition of the Hamiltonian and the analytical solutions (eigenvalues and eigenfunctions). Calls a docstring in the source code (src/ModelName.jl) .
I think it should be "documentation" and "Call".

@ajarifi Thank you! I updated README.md.

@lhapp27 Please close this issue after you check README.md.

Just another comment, but not very important.
The Figure labels $r$ and $\psi$ look rather small. It may be better if they are bigger.

Anyway, it is good that you have added the demonstration. I think it is a good example of the application in research.

Just another comment, but not very important. The Figure labels r and ψ look rather small. It may be better if they are bigger.

Anyway, do not worry about this at the moment. It is not crucial.

I checked the README.md file, see related pull request #67 . Proofreading the entire documentation is quite a lot and a rather tedious, since the text is located in two separate files (docstrings in source code and extra markdown file). Maybe we can automate that with some spellchecking software?


Adding initial github actions

An initial commit for github actions to compile embree, coreBlacbird and hdBlackbird. We need to review flags that are passed to embree
Not sure how to pull  aswf/ci-vfxall:2020 container. It does work on my local machine. Currently we are getting an error during the build:
No runner matching the specified labels was found: aswf/ci-vfxall:2020

Hi @dedoardo so we have first successful build. There are few things we can work together on:

create a new docker image containing embree - I can handle that, seems like a simple task
installation of the plugins so they would be properly discovered by usdrecord
run some tests

I created custom docker container called piotrbarejko/blackbird that contains built embree. I also included Dockerfile in the repository.

Hey @dedoardo I think this one would be ready to run some render tests.


missing puppet on centos 7 without

on base centos 7 ncm
[vagrant@localhost alfresco]$ sudo ./install.sh
loading config/ootb_pre.sh
__    __    __    __    __    __    __    __    __    __

_/  _/  _/  _/  _/  _/  _/  _/  _/  _/  _
/  _ ORDER OF THE BEE /  _/  _/  _/  _/  _/  _/  \
_/  _/  _/  _/  \ Alfresco (TM) Honeycomb Edition   _/
_/  _/  _/  _/  _/  _/  _/  _/  _/  __/
Idx	Param                     Value
[1]	domain_name               localhost
[2]	ssl_cert_path
[3]	initial_admin_pass        admin
[4]	mail_from_default         admin@localhost
[5]	mail_host                 localhost
[6]	mail_port                 25
[7]	alfresco_base_dir         /opt/alfresco
[8]	tomcat_home               /opt/alfresco/tomcat
[9]	alfresco_version          5.0.x
[10]	download_path             /opt/downloads
[11]	db_root_password          alfresco
[12]	db_user                   alfresco
[13]	db_pass                   alfresco
[14]	db_name                   alfresco
[15]	db_host                   localhost
[16]	db_port                   3306
[17]	mem_xmx                   3G
[18]	mem_xxmaxpermsize         256m
Please choose an index number to edit, I to install, or Q to quit
(if using Vagrant, choose Q not I and run 'vagrant up')
-> I
0 errors
Installing...
Writing answer file config/ootb_answers.sh
Writing puppet file go.pp
Writing puppet file test.pp
which: no puppet in (/sbin:/bin:/usr/sbin:/usr/bin)
Installing puppet
which: no puppet in (/sbin:/bin:/usr/sbin:/usr/bin)
./install/modules-for-vagrant.sh: line 32: puppet: command not found
Transient failure, retrying
./install/modules-for-vagrant.sh: line 32: puppet: command not found
Transient failure, retrying
./install/modules-for-vagrant.sh: line 32: puppet: command not found
Transient failure, retrying

ah it's due to that /etc/issue thing again, same as #77 -  we need to determine the osfamily (e.g. RedHat, Debian) pretty early for some of the scripts to work;
particularly install/inc-puppet.sh needs to know osfamily before we have facter to help us
so:
<marsbard> I suppose if "-f /etc/debian_version" at least we know it's osfamily==Debian
<marsbard> and if "-f /etc/redhat-release"  we know osfamily==Redhat

[vagrant@localhost alfresco]$ more /etc/redhat-release
CentOS Linux release 7.0.1406 (Core)

true >.<

ok kind of crap, I just changed it to parse the /etc/redhat-release file but it feels really fragile to me. want to leave it open for now and reconsider it later

think this is fixed using facter variables, #84

best wait till its compiled in travis

#84 tested this fixes this issue.


ARM build broken (bool / boolean casts)

Describe the bug
libjxl doesn't build on ARM64 using GCC-11 or GCC-12
It appears there are several implicit casts between bool and boolean through the codebase - unsure why this is only triggered on ARM?

  /io/libjxl/lib/extras/enc/jpg.cc:250:27: error: cannot convert ‘bool’ to ‘boolean’ in assignment
    250 |   cinfo.optimize_coding = optimize_coding;
        |                           ^~~~~~~~~~~~~~~
        |                           |
        |                           bool
  gmake[2]: *** [lib/CMakeFiles/jxl_extras_codec-obj.dir/extras/enc/jpg.cc.o] Error 1
  gmake[2]: *** Waiting for unfinished jobs....
  [ 30%] Building C object third_party/brotli/CMakeFiles/brotlienc.dir/c/enc/bit_cost.c.o
  [ 30%] Building C object third_party/brotli/CMakeFiles/brotlienc.dir/c/enc/block_splitter.c.o
  [ 30%] Building C object third_party/brotli/CMakeFiles/brotlienc.dir/c/enc/brotli_bit_stream.c.o
  /io/libjxl/lib/jpegli/bitstream.cc: In function ‘bool jpegli::EncodeScan(j_compress_ptr, int)’:
  /io/libjxl/lib/jpegli/bitstream.cc:802:32: error: cannot convert ‘bool’ to ‘boolean’ in argument passing
    802 |           by0, max_block_rows, false);
        |                                ^~~~~
        |                                |
        |                                bool
  /io/libjxl/lib/jpegli/bitstream.cc: In function ‘void jpegli::ComputeTokens(j_compress_ptr, std::vector<jpegli::TokenArray>*)’:
  /io/libjxl/lib/jpegli/bitstream.cc:983:27: error: cannot convert ‘bool’ to ‘boolean’ in argument passing
    983 |           max_block_rows, false);
        |                           ^~~~~
        |                           |
        |                           bool

Environment

OS: Ubuntu 22.04
Compiler version: gcc (Ubuntu 12-20220319-1ubuntu1) 12.0.1 20220319 (experimental) [master r12-7719-g8ca61ad148f]
CPU type: arm64

Thanks for reporting the bug.
It's weird that this implicit conversion is causing the build to fail.
Can you attach a more complete error log?
What version (git hash) of libjxl are you trying to compile?


map: add a search bar

@floatplane currently stuck on how to get this to work in Expo Go for us - our API keys are restricted for use only by our "real" app - and this library (the only one ...) chooses not to use the normal SDKs, so whatever magic Expo Go does to make the map work, is not applied here by default. Will need to figure that out, or get a dev token ...

We need to figure out what the UX of this thing is. As is, the library expects to render everything in one view, so doing an overlay of the results outside of the header thing will be impossible, I think.

@floatplane currently stuck on how to get this to work in Expo Go for us - our API keys are restricted for use only by our "real" app - and this library (the only one ...) chooses not to use the normal SDKs, so whatever magic Expo Go does to make the map work, is not applied here by default. Will need to figure that out, or get a dev token ...

that's annoying! I wonder if we could create a separate set keys under our own account that work correctly with Expo Go, by following the instructions in https://docs.expo.dev/versions/latest/sdk/map-view/ and using the Expo Go bundle id instead of our own. I presume that mismatch is what keeps our existing keys from working correctly with this component.
we could also ask for help in Expo support channels?


[WIP] Add connector based TomcatServiceInvocationHandler

Beware: this PR is still in POC state, don't merge this as is.
Motivation:
Introduce a way to setup TomcatService using existing Embedded Tomcat
instance.  possible usage can be found at HERE
Modification:
Split TomcatServiceInvocationHandler into two classes,
introduced class is instantiated using configured hostname and
Connector, and provides ServiceInvocationHandler interface using those
values.
(TBD) I've left TomcatServiceInvocationHandler for
backward-compatibility. But as this class is not public, roles of the
class can be migrated into TomcatServiceBuilder, with little logical
changes.
(TBD) name of introduced class is not yet determined.
Result:
Easier TomcatService integration with other framework like spring

Handled above comments, PTAL

@blmarket Replied to a collapsed comment: https://github.com/line/armeria/pull/110#discussion_r53126922

Ah, I see. Then perhaps we could make TomcatServiceConfig package-local and remove the config() method. Could you take care of this change as well?

Sure, JFYI it is the breaking change.

Sure, JFYI it is the breaking change.

No problem. Not reached at 1.0 just yet.

Handled above comments, PTAL. let me squash commits if it's ready.

@blmarket LGTM. Please squash the commits. :-)

squashed, title updated, commit description updated.

@trustin : ping?

@blmarket Merged. :-)


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>

Coverage remained the same at 66.31% when pulling 55a68828e2d2868a70866b62c6a3b15933d507c6 on template-sync-1 into a12bc3c8a8f66e964a3d1693cb947e4cb50f7d57 on master.

:tada: This PR is included in version 2.20.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


New version: MIRT v0.8.0

Registering package: MIRT
Repository: https://github.com/JeffFessler/MIRT.jl
Created by: @JeffFessler
Version: v0.8.0
Commit: d7e4501b90b7e475bac07f24c4e70be5e4672cd4
Reviewed by: @JeffFessler
Reference: https://github.com/JeffFessler/MIRT.jl/issues/14

[noblock]
If you want us to "the guidelines" then please include url pointing to those guidelines in the message!  I have reviewed the only guidelines I could find here:
https://github.com/JuliaRegistries/General/pull/3567/files
and I think that MIRTio.jl has a conforming compat entry (julia="1.1") which has an implicit upper bound of < 2.0, as far as I can tell.  So why is the bot complaining about no upper bound?

[noblock]
Your compat entry for julia meets the guidelines.
However, you do not have upper-bounded compat entries for your other dependencies, as specified in the automerge comment:

The following dependencies do not have a compat entry that has an upper bound:
BenchmarkTools, Colors, DSP, FFTViews, FFTW, FileIO, ImageFiltering, ImageTransformations,
Interpolations, LaTeXStrings, LinearMaps, LinearMapsAA, MIRTio, MosaicViews, NFFT, Plots,
Reexport, SpecialFunctions, Wavelets

[noblock]
@DilumAluthge thanks for giving this feedback!
But now I am very perplexed.
The Manifest.toml file is generated automatically, and is not supposed to be edited manually:
https://julialang.github.io/Pkg.jl/dev/toml-files/#Manifest.toml-1
In fact the docs say that
"Given a Project.toml + Manifest.toml pair, it is possible to instantiate the exact same package environment, which is very useful for reproducibility."
So adding an upper bound seems contrary to loading the exact same package versions!?
Now, I just found this section of the manual:
https://julialang.github.io/Pkg.jl/dev/compatibility/#Compatibility-1
that offers the option of specifying versions in the Project.toml
So we must manually copy this from the Manifest.toml file then?
Seems to be quite redundant with the Manifest?

[noblock]
So, when you register a package, Registrator.jl and the General registry do not even look at your Manifest.toml file. They only look at your Project.toml file.
Instead of copying compat bounds manually, you may find CompatHelper.jl helpful: https://github.com/bcbi/CompatHelper.jl

Ok, thanks.  I wrote a small script to automate extracting the current version info from the Manifest.
I appreciate the pointer to CompatHelper.jl but I am not ready to have to rerun tests etc. every single time any of the dependencies does a version bump.  I've pushed an updated Project.toml file and now I hope the bot will be happy...

[noblock]
You'll need to re-trigger Registrator in order to update the PR. Also, make sure to edit all of your comments to include the text [noblock].
Also, would you be willing to post the script you wrote as a comment? Other users might find it useful.

[noblock]  Here's the code.  It just prints to the terminal and then I cut and paste.  Thanks!
#=
compat.jl
Extract version info from Manifest.toml for all Dependencies in Project.toml
and print it out in a format suitable for pasting into Project.toml
to appease the JuliaRegistrator bot that now (as of Fall 2019)
apparently insists on having compat entries for all versioned packages.
A related tool is: https://github.com/bcbi/CompatHelper.jl
For related manual page see
https://julialang.github.io/Pkg.jl/dev/compatibility/
2019-11-05 Jeff Fessler, University of Michigan
=#

using TOML # https://github.com/JuliaStdlibs/TOML.jl

pro = TOML.parsefile("Project.toml")
deps = collect(keys(pro["deps"])) # package dependencies
man = TOML.parsefile("Manifest.toml")

# loop over all packages in the Manifest
for (p,d) in sort(collect(man), by = x->x[1])
	if p ∈ deps # only care about the dependencies
		d = d[1] # seems to be an array for some reason
		haskey(d, "version") && println(p, " = \"", d["version"], "\"")
	end
end

[noblock]
Well, I will say that I do like the speed of the new auto-merge process so it is worth the effort to write/use a script to get the [compat] in there.  Thanks!

I'm very happy to hear that you like it!


Sound not being triggered (WinError 10054)

I often get this error with PlaySound node:
Exception in callback _ProactorBasePipeTransport._call_connection_lost(None)
handle: <Handle _ProactorBasePipeTransport._call_connection_lost(None)>
Traceback (most recent call last):
  File "asyncio\events.py", line 80, in _run
  File "asyncio\proactor_events.py", line 165, in _call_connection_lost
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host

This happens to me in console and also in Stability Matrix. Unfortunately, it seems to happen randomly, I haven't observed any patern.

Hmm, they playsound node doesnt have any logic on the backend so I would be suprised if it was this node causing the issue


Maintenance page is bugged on mobile, not mobile responsive

Maintenance page is bugged on mobile, and isn't mobile responsive. Need to fix this with flex.

Fixed in<PHONE_NUMBER>d19788d7b076cf02b785e04a482d2a


Gray line on the edges in the multiply process

Describe the bug
When I try to perform a composite process with multiply, for some reason the overlay image gets a gray border. This is only happening with the multiply process. When checking with Photoshop, this issue does not occur, and the image appears without the border as it should from the beginning.
To Reproduce
def compose_images(art_image_path:, base_image_path:, x:, y:)
  base_image = Vips::Image.new_from_file(base_image_path)
  art_image = Vips::Image.new_from_file(art_image_path)

  base_image.composite(art_image, :multiply, x:, y:)
end

Resulting image:

Expected image:

Additional context
To solve this problem, I applied a white background instead of transparent, but I'm not sure if this is the correct way to do it...
def compose_images(art_image_path:, base_image_path:, x:, y:)
  base_image = Vips::Image.new_from_file(base_image_path)
  art_image = Vips::Image.new_from_file(art_image_path)
  art_image = art_image.flatten(background: [255, 255, 255])

  base_image.composite(art_image, :multiply, x:, y:)
end

Hi @JohnAnon9771, could you upload your overlay and base images too?

Hi @JohnAnon9771, could you upload your overlay and base images too?

Sure!
Positions: X: -448, Y: 395
base_image:

art_image:

I think your art image has been premultiplied -- ie. the alpha has already been blended into the RGB layer. If I run:
$ vips composite2 base_image.jpg art_image.png x.png multiply \
    --x=-448 --y=395 --premultiplied

I get:

Which looks better to me.
You can either save your art image as unpremultiplied (PNG images are supposed to be unpremultiplied), or pass the --premultiplied flag to composite.

Oh, maybe not, I tried unpremultiplying your art image and it looks bad. But I looked at the sources again and I can't see anything wrong with MULTIPLY :( Puzzling!

Looking at:
https://gitlab.freedesktop.org/pixman/pixman/-/blob/865e6ce00bb79a6b925ed4c2c436e1533e4472aa/pixman/pixman-combine-float.c#L372-374
It seems Pixman does (if I understand correctly):
xR = 1/aR · [ (1−aB)·xaA + (1−aA)·xaB + f(xA,xB) ]

instead of:
xR = 1/aR · [ (1−aB)·xaA + (1−aA)·xaB + aA·aB·f(xA,xB) ]

(i.e. the equation documented at https://www.cairographics.org/operators/)
So, there's a missing $aA·aB$ in Pixman's implementation. By applying this patch:

Details
--- a/libvips/conversion/composite.cpp
+++ b/libvips/conversion/composite.cpp
@@ -488,7 +488,6 @@ vips_composite_base_blend(VipsCompositeBase *composite,
 	double aR;
 	double t1;
 	double t2;
-	double t3;
 	double f[MAX_BANDS + 1];

 	/* Load and scale the pixel to 0 - 1.
@@ -701,9 +700,8 @@ vips_composite_base_blend(VipsCompositeBase *composite,

 		t1 = 1 - aB;
 		t2 = 1 - aA;
-		t3 = aA * aB;
 		for (int b = 0; b < bands; b++)
-			B[b] = t1 * A[b] + t2 * B[b] + t3 * f[b];
+			B[b] = t1 * A[b] + t2 * B[b] + f[b];
 		break;
 	}

@@ -732,7 +730,6 @@ vips_composite_base_blend3(VipsCompositeSequence *seq,
 	float aR;
 	float t1;
 	float t2;
-	float t3;
 	v4f f;
 	v4f g;

@@ -934,8 +931,7 @@ vips_composite_base_blend3(VipsCompositeSequence *seq,

 		t1 = 1 - aB;
 		t2 = 1 - aA;
-		t3 = aA * aB;
-		B = t1 * A + t2 * B + t3 * f;
+		B = t1 * A + t2 * B + f;
 		break;
 	}

I see:

When running:
$ vips composite2 base_image.jpg art_image.png x-multiply.png multiply --x=-448 --y=395

Ah great detective work. But how strange! That will change all 11 of the PDF blend modes, won't it? You'd think we'd have noticed this before.

Indeed, that will change all 11 separable PDF blend modes. :(
Perhaps the aA and aB calculations are integrated into other blend modes? For example, I noticed the screen blend mode in Pixman is actually implemented as:
f = A * aA + B * aB - A * B

instead of just:
f = A + B - A * B

See:
https://gitlab.freedesktop.org/pixman/pixman/-/blob/865e6ce00bb79a6b925ed4c2c436e1533e4472aa/pixman/pixman-combine-float.c#L403

Looking at this comment, it seems that this problem has already been seen on the edge.
https://github.com/libvips/libvips/issues/1622#issuecomment-630855734

These two scripts appear to produce visually identical images:
cairo.c:
/* compile with:
 * gcc -g -Wall cairo.c `pkg-config cairo --cflags --libs` -o cairo
 */

#include <cairo.h>

int
main(int argc, char *argv[])
{
	cairo_surface_t *surface;
	cairo_t *cr;

	surface = cairo_image_surface_create(CAIRO_FORMAT_ARGB32, 160, 120);
	cr = cairo_create(surface);

	cairo_rectangle(cr, 0, 0, 120, 90);
	cairo_set_source_rgba(cr, 0.7, 0, 0, 0.8);
	cairo_fill(cr);

	cairo_set_operator(cr, CAIRO_OPERATOR_MULTIPLY);

	cairo_rectangle(cr, 40, 30, 120, 90);
	cairo_set_source_rgba(cr, 0, 0, 0.9, 0.4);
	cairo_fill(cr);

	cairo_destroy(cr);
	cairo_surface_write_to_png(surface, "cairo.png");
	cairo_surface_destroy(surface);

	return 0;
}

vips.py:
import pyvips

base = (pyvips.Image.black(120, 90)
        .copy(interpretation='srgb')
        .new_from_image([179, 0, 0, 204])
        .embed(0, 0, 160, 120))

overlay = (pyvips.Image.black(120, 190)
           .copy(interpretation='srgb')
           .new_from_image([0, 0, 230, 102])
           .embed(40, 30, 160, 120))

im = base.composite2(overlay, 'multiply')
im.write_to_file('vips.png')

Run with:
$ gcc -g -Wall cairo.c `pkg-config cairo --cflags --libs` -o cairo
$ ./cairo
$ python vips.py
$ vips subtract vips.png cairo.png x.v
$ vips abs x.v x2.v
$ vips max x2.v
1.000000

Output:

vips.png
cairo.png

So, it looks there's nothing wrong with VIPS_BLEND_MODE_MULTIPLY.

Hmm, for VIPS_BLEND_MODE_SCREEN you also need to pass premultiplied=True to ensure the images are visually identical to those produced by Cairo.
--- a/cairo.c
+++ b/cairo.c
@@ -17,7 +17,7 @@ main(int argc, char *argv[])
 	cairo_set_source_rgba(cr, 0.7, 0, 0, 0.8);
 	cairo_fill(cr);

-	cairo_set_operator(cr, CAIRO_OPERATOR_MULTIPLY);
+	cairo_set_operator(cr, CAIRO_OPERATOR_SCREEN);

 	cairo_rectangle(cr, 40, 30, 120, 90);
 	cairo_set_source_rgba(cr, 0, 0, 0.9, 0.8);

--- a/vips.py
+++ b/vips.py
@@ -10,5 +10,5 @@ overlay = (pyvips.Image.black(120, 190)
            .new_from_image([0, 0, 230, 204])
            .embed(40, 30, 160, 120))

-im = base.composite2(overlay, 'multiply')
+im = base.composite2(overlay, 'screen', premultiplied=True)
 im.write_to_file('vips.png')

If you don't do this, it will produce:

vips.png
cairo.png

Perhaps the separable PDF blend modes in Cairo always operates on unpremultiplied values?


BugChecker for effectively unused PublisherProbes

Problem
Reactor's PublisherProbe defines a neat API to test reactive code. However, it  is only helpful when it is actually used.
Considering the following code snippet, the PublisherProbe is initialized and asserted, but never actually used. Surely we can assert that it was never subscribed to, because we never included it in code that should be subscribed to. :slightly_smiling_face:
@Test
void probeBugChecker() {
    PublisherProbe<Void> probe = PublisherProbe.empty();
    // some test code that doesn't involve `probe`
    probe.assertWasNotSubscribed();
}

This looks like an unintentional human mistake that wrongfully could increase the author's confidence in their production code.
Description of the proposed new feature

[ ] Support a stylistic preference.
[x] Avoid a common gotcha, or potential problem.
[ ] Improve performance.

I'd like to have a BugChecker that identifies such a construct as a common mistake and expects changes.
Considerations

In essence, this BugChecker should flag in the following scenario:

A PublisherProbe is declared and initialized
Is used exclusively in assertion calls (e.g. PublisherProbe#assertWasNotSubscribed).

The BugChecker should not flag if

The PublisherProbe is used

as a mocked value with PublisherProbe#{mono,flux}
as a parameter to a method, since it could be used for mocking there

Participation

[ ] I am willing to submit a pull request to implement this improvement.

Most likely not within the next couple of weeks.

Something to add: We can also include the following case:

PublisherProbe is declared and initialized
Probe is used in a mock
Probe is not used for any assertions


Chicago parks is not working

when i try to play chicago parks it doesn't work

Can you provide a screenshot, and what tell us what browser you're using?

Oh, I see the problem - when the window size gets too small things go 'boom' in the code that tries to pad a boundary around the smaller parks.
I'm not sure how to fix it just yet, but at least it's easy to reproduce.


Add AAD support for Event Grid functions extensions

Now that the service and the SDK support it, we can add it to the extension as well.

Waiting on design feedback from Functions folks.


Unbelievable error in esp_wifi.c: invalid magic number (IDFGH-2887)

In the C++ code bellow (Base on ESP-IDF/release/v4.1):
esp_err_t HalWifiImpl::init() {
    wifi_init_config_t cfg = WIFI_INIT_CONFIG_DEFAULT();
    printf("feature_caps = %llu", cfg->feature_caps);  // OK // feature_caps = 0
    printf("magic = 0x%08X", cfg->magic);              // OK // magic = 0x1F2F3F4F
    RET_ON_ERROR( esp_wifi_init(&cfg) );        // !!! Unbelievable error here !!!
    RET_ON_ERROR( esp_wifi_set_storage(WIFI_STORAGE_RAM) );
...
}

When the parameter "wifi_init_config_t *cfg" is passed into "components/esp_wifi/wifi_init.c: esp_wifi_init()", it's not the same as passed !
esp_err_t esp_wifi_init(const wifi_init_config_t *config)
{
...
    // config->* // The most fields are correct, except the last two bellow:
    printf("feature_caps = %llu", config->feature_caps);  // Unbelievable ! // feature_caps =<PHONE_NUMBER>616133120
    printf("magic = 0x%08X", config->magic);    // Unbelievable ! //magic = 0x3F403FF8
    esp_err_t result = esp_wifi_init_internal(config);
    if (result == ESP_OK) {
        esp_wifi_set_debug_log();
...

It's unbelievable ! It just happened suddenly, I don't know why ...
I mixed C/C++ program in my project, there are many strange problems ! This is the most unbelievable one !
I think it maybe the difference of struct field initialization between C and C++, or the field alignment    difference ?
The other C/C++ mixed program problems I suffered is: inline function may cause CoreDump !

I solved this problem temporarily by:

Try this:
wifi_init_config_t cfg = {0};
cfg = WIFI_INIT_CONFIG_DEFAULT();

Hi @awander, have you call "git submodule update" when you upgrade your IDF?

@awander Glad that the issue gets resolved. Please help check the note by @liuzfesp , thanks.


Jumping back to homepage after creating a discussion

See title; you will be notified on the home page that the discussion was created; instead of staying at the article (reported by Hannes)
This does not happen if you comment on an already existing discussion

Closed by #117


Add HTTP API method to load configuration nodes

[ ] Bugfix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)

Proposed changes
add GET, PUT configuration nodes in Admin HTTP API Methods

Admin HTTP API Methods cant GET or PUT configuration nodes
Checklist

[ x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[ ] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

As per our contribution guidelines, we don't accept PRs that haven't been discussed first - especially ones that modify external APIs.
It also appears you've raised a PR from our own dev branch into master - so there aren't any changes from you included - has this PR been raised by mistake?

Coverage decreased (-0.9%) to 67.49% when pulling df90e3414dc15780ba054e41f23c3a39cfa34df7 on dev into bccfd21cf46da7dfdde9653466f218fb3459ad7d on master.

Closing this PR as I think it has been raised by mistake.


Series/indicators shown in constant order

Series always shown in front of indicators. Perhaps debatable which way round we want it - we might want the lines (eg moving average line) on top of the main series, but the fill/area of bollinger bands definitely behind. Either way, at least this is consistent.

Resolves #146

Thanks @CBarrett2


Sodg::ids()

@rultor release, tag is 0.0.26

@rultor release, tag is 0.0.26

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.26

@yegor256 Done! FYI, the full log is here (took me 4min)


Next release v3.2.0

CHANGELOG 3.2.0

🚀 Added

Added no-round, small-round, round|medium-round, large-round helpers
Added max helper to tooltip element to do the rich tooltips of MD3 (https://m3.material.io/components/tooltips/overview)
Added inverse-surface, inverse-primary, inverse-on-primary and inverse-link helpers (https://m3.material.io/styles/color/the-color-system/color-roles#22be76ec-3322-4a3b-9db3-574cf49c106b)
Added default color to tooltip and toast elements (https://m3.material.io/components/tooltips/specs and https://m3.material.io/components/snackbar/specs)

🩹 Fixed

Fixed some responsive bugs (https://github.com/beercss/beercss/issues/145)
Fixed label up on input numbers (https://github.com/beercss/beercss/issues/140)

⚠ Breaking changes

Renamed dropdown to <menu> to be more semantic (https://m3.material.io/components/menus/overview)
The default <button> is now rounded (https://github.com/beercss/beercss/issues/142)
Using system fonts instead Roboto Flex (https://github.com/beercss/beercss/discussions/132 and https://github.com/beercss/beercss/issues/86)
Renamed modal to <dialog> to be more semantic (https://github.com/beercss/beercss/issues/54)

🚩 Examples
// before

  Item 1
  Item 2
  Item 3

// after
<menu>
  Item 1
  Item 2
  Item 3
</menu>

// before

Title

Some text here

// after
<dialog>

Title

Some text here

</dialog>

// rich tooltip example, using max helper

Title

Some text here

    <button>Button</button>

// new round helpers example

...

...

...

...

/* if you want to use roboto flex or any other custom font use this css */
@import "https://fonts.googleapis.com/css2?family=Roboto Flex";

:root {
  --font: "Roboto Flex";
}

Tested the new default round buttons, responsive of badge and typography on website and the new rich tooltip everything is working thanks for your effort @leonardorafael.

@laurentpayot @KicKerBNU I added https://github.com/beercss/beercss/issues/54 to next release too, ok?

@laurentpayot @KicKerBNU I added #54 to this release too, ok?

That would be awesome. More than one year after dialog is avaiable for Safari, we can use it almost anywhere now. :+1:


[Feature Request] add class to allow use of css selectors

I want to change the buttons positions. I can use css and flex to achieve what i need but I can't select the confirm dialog appart from my other dialogs.
There could be a few solutions for this, but a simple class at the root of the confirm or an option to add one would be great
Thanks for the great package anyway :smile:

my current solution is to select with
#app > [tabindex="0"] > .v-dialog > .v-card.v-sheet.theme--light.rounded-0 > .v-card__text.body-1.text-body-1.py-3 + .v-card__actions but it is not foolproof or to tediously exclude each of my dialog with a special class (not my prefered approaches)


docs: add beginner-friendly sentence about installing Node.js

Motivation
When I started out with Docusaurus I had no idea about NPM, yarn or even coding. I feel that although this isn't a very big change, it'll still help the beginners with getting started. I could've really used with this information when I started, so I feel that it'll definitely help others.
Have you read the Contributing Guidelines on pull requests?
Yes

Going to merge this into #6187. Thanks!

Thanks @Josh-Cena I wanted to do that but didn't know how :(. Thanks for doing it!

@PatelN123 Please clone the repo locally and make edits. The GitHub interface is incredibly hard to use when make significant changes. Your code is also not formatted exactly because you didn't do committing locally.


Add a prompt that tells users the remaining product count when users add too many items

Currently the users will get an alert saying "not enough in stock for - test" when they click the checkout button while ordering too many items of the same type. However, since they do not know the remaining number, they have to do "minus -> checkout -> minus -> checkout...." until the item count is within limit. It might be nice to let them know the amount in stock.

Closed by https://github.com/CPSC319-2022/JungleCart/pull/260


M3-2446 Region status message

Description
Add a banner to the top of all relevant pages (and to the support
ticket drawer) if any region returns a status of "outage". If multiple
regions have outages, the notices will stack.
This was our first use of the region.status field, so we had to update
typings and test data to respect the new API response.
Notes
We could do this site-wide in App.tsx, but the AC made it clear that it should only be on relevant pages so I took my best guess at what counted (Domains don't, OBJ does). Feedback welcome.
To test, replace line 34 of src/store/regions/regions.reducer.ts with the following:
draft.entities = [
        ...result,
        {
          id: 'us-east',
          status: 'outage',
          capabilities: [],
          country: 'US'
        }
      ];

So I added in a bunch of outages to play around with since we can stack them. It could get a little ugly.
I also played with putting in "junk" data and it was nice to see that we still have a message about a facility outage.


Fix output regarding the watch namespace

@aduffeck we waited long enough, after merging https://github.com/cloudfoundry-incubator/quarks-job/pull/49 there is only $WATCH_NAMESPACE.

Closing this as I cherry picked the commit in #49


[WIP][Release] Release 4.0.0-RC0

Version updates and supplemental patches from RC0

@github-actions crossbow submit --group verify-rc-source --param release=4.0.0 --param rc=0

@andygrove strangely the rust verification fails with some minor error msg quote escaping test assertion. Could it be due to the nightly toolchain used in the verification script?

@github-actions crossbow submit verify-rc-source-*-rust

@andygrove strangely the rust verification fails with some minor error msg quote escaping test assertion. Could it be due to the nightly toolchain used in the verification script?

I don't know for sure but that would be my guess too.

@github-actions crossbow submit verify-rc-source-linux-ruby

Codecov Report

Merging #10065 (23e8758) into release-4.0.0 (d7f90ca) will increase coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-4.0.0   #10065   +/-   ##
==============================================
  Coverage          78.92%   78.92%
==============================================
  Files                286      286
  Lines              64715    64715
==============================================
+ Hits               51074    51076    +2
+ Misses             13641    13639    -2

Impacted Files
Coverage Δ

rust/parquet/src/encodings/encoding.rs
95.05% <0.00%> (+0.19%)
:arrow_up:

rust/arrow/src/array/transform/fixed_binary.rs
84.21% <0.00%> (+5.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f90ca...23e8758. Read the comment docs.

Codecov Report

Merging #10065 (a5f647f) into release-4.0.0 (d7f90ca) will increase coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-4.0.0   #10065   +/-   ##
==============================================
  Coverage          78.92%   78.92%
==============================================
  Files                286      286
  Lines              64715    64715
==============================================
+ Hits               51074    51076    +2
+ Misses             13641    13639    -2

Impacted Files
Coverage Δ

rust/arrow/src/array/equal/utils.rs
76.00% <0.00%> (+1.00%)
:arrow_up:

rust/arrow/src/array/transform/fixed_binary.rs
84.21% <0.00%> (+5.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f90ca...a5f647f. Read the comment docs.

@github-actions crossbow submit --group verify-rc --param release=4.0.0 --param rc=0

@github-actions crossbow submit --param release=4.0.0 --param rc=0 verify-rc-binaries-apt verify-rc-binaries-binary

@github-actions crossbow submit --param release=4.0.0 --param rc=0 verify-rc-binaries-apt verify-rc-wheels-windows


Show order routing protocol in confirm trade modal

Overview
Gm! We want to display which order routing protocol is being used in the trade modal, on the confirm trade screen.
Please see below for a screenshot of the current view.

Below is a mock of the desired look for the routing information, displayed below the rate.

Please direct any questions to me, @decentralizedj on discord.
References and additional details
See above.
Acceptance Criteria
Order router is displayed on trade confirm modal in manner shown above.
Need By Date
No response
Screenshots/Mockups
No response
Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

We are already using the human-readable swapper.name, newly added by @DaoDev44 in https://github.com/shapeshift/lib/pull/867, to display 0x Fee.
There are no ramifications to this, this will just be about a few JSX modifications to display this variable under the rate vs. <swapperName> fee currently

GM @decentralized-j , do you have an estimated hours for this bounty so i can put a value on it in dework? Cheers.

GM @decentralized-j , do you have an estimated hours for this bounty so i can put a value on it in dework? Cheers.

We can estimate is as 1 hour @MBMaria

GM! Would love to take this up if no one else is working on it.


Add data attributes to select component

Adds the ability to pass arbitrary data attributes to the select component, that will be applied to the individual options.

Component guide for this PR:
https://govuk-publishing-compon-pr-650.herokuapp.com/component-guide/select
Trello card: https://trello.com/c/CF6DmPXk/137-add-sorting-to-the-news-and-communications-finder

:shipit:  🎉


Potential issue with cython wrapper

Hello,
I've just used pyJac's pyWrap utility to write C code that I can call from python. I'm getting nans when I evaluate py_dydt and py_eval_jacobian, but not from py_eval_conc, py_eval_rxn_rates, py_get_rxn_pres_mod, or py_eval_spec_rates. See details below.
Build procedure
pyJac call: python3 -m pyjac -i h2-burke.xml -l c
pyWrap call: python3 -m pyjac.pywrap --source_dir out -l c
While pyWrap completes without errors, I get a deprecated numpy warning during compilation and the following warning during linkage. I'm not sure but it seems like it might be important.
ld: warning: ignoring file /Users/mike/Mechanisms/coh2-davis/build/temp.macosx-10.6-intel-3.6/libc_pyjac.a,
file was built for archive which is not the architecture being linked (i386):
/Users/mike/Mechanisms/coh2-davis/build/temp.macosx-10.6-intel-3.6/libc_pyjac.a

Here's the input file (XML generated by cantera): h2-burke.xml.zip
Sample code (requires cantera, numpy, and generated pyjacob)
The snippet below evaluates some pyJac functions and prints the results, demonstrating (on my machine) that everything looks okay except for dYdt and Jflat, which are full of nans.
import pyjacob as pyjacob
import cantera as ct
import numpy as np

T = 300
p = 101325
gas = ct.Solution('h2-burke.xml')
nspec = gas.n_species
Y = 'H2:2, O2:1, N2:3.73'
Y = np.ones(nspec)
gas.TPY = T, p, Y

Y = gas.Y
mw = gas.mean_molecular_weight
rho = gas.density_mass

conc = np.zeros_like(Y)
dYdt = np.zeros(nspec + 1)
molar_sp_rates = np.zeros(nspec)
Jflat = np.zeros((nspec + 1) * (nspec + 1))

fwd_rates = np.zeros(gas.n_reactions)
rev_rates = np.zeros(gas.n_reactions)
pres_mod = np.zeros(gas.n_reactions)

pyjacob.py_eval_conc(T, p, Y, mw, rho, conc)
pyjacob.py_eval_rxn_rates(T, p, conc, fwd_rates, rev_rates)
pyjacob.py_eval_rxn_rates(T, p, conc, fwd_rates, rev_rates)
pyjacob.py_get_rxn_pres_mod(T, p, conc, pres_mod)
pyjacob.py_eval_spec_rates(fwd_rates, rev_rates, pres_mod, molar_sp_rates)

print(T, p, mw, rho)
print(Y)
print(conc)
print(fwd_rates)
print(rev_rates)
print(pres_mod)
print(molar_sp_rates)

pyjacob.py_dydt(T, p, Y, dYdt)
pyjacob.py_eval_jacobian(T, p, Y, Jflat)
print(dYdt)
print(Jflat)

Software state

Mac OS X 10.12.3, XCode 8.2.1
pyJac updated today
python 3.6 with numpy, cython, cantera all updated

@michael-a-hansen ok, the issue here is that the t argument in py_dydt and py_eval_jacobian actually represents time, not temperature.  The state vector (for the C module) should consist of:
[T, Y0, Y1.... YNsp]

Hence you should get the correct results by calling this as:
Y = gas.Y
Y = np.concatenate(([T], Y))
dYdt = np.zeros_like(Y)
Jflat = np.zeros((nspec) * (nspec))
pyjacob.py_dydt(0, p, Y, dYdt)
pyjacob.py_eval_jacobian(0, p, Y, Jflat)

Also note that due to the formulation of our system, the Jacobian is actually Nsp x Nsp, i.e. 1 entry for Temperature and Nspecies - 1 entries for the species mass fractions (using the strict mass conservation formulation)
The reason for all this confusion is that typically in ODE solvers, the RHS / Jacobian function accept time as an argument in case the equations are dependent on it directly.  To conform to CVODE, etc. it is also included here.
@kyleniemeyer didn't we have someone working on documentation for the python wrapper?  It looks like an example would be particularly useful 👍

Terrific! Thank you. It is working as expected now :)
A note: it's very confusing that Y is TY in the higher-level functions (dydt and such) and Y in the lower-level methods (eval_conc and such). Additionally, when looking at the auto-generated code, I saw a line like the following, which I was ready to submit as a massive bug report before I realized Y is TY and so y[1] is actually the first mass fraction (first element of Y, second of TY)! I think simply replacing Y with TY where appropriate would help new developers and users immensely.
cp[0] * y[1] + cp[1] * y[2] + cp[2] * y[3] + cp[3] * y[4] ...


Species SG

@jj-umn @iracooke is the species option completely removed. Or is it just integrated into an other command?

Anyone?

Hi Bjoern
I don't really understand what this is about. Did you make this change to fix an issue? What was the issue?
Sent from my iPhone

On 25 Jun 2016, at 2:35 AM, Björn Grüning<EMAIL_ADDRESS>wrote:
Anyone?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Allow cubic interpolant for 2D data

Description
Currently the scipy interpolate.interp2d function is called if there are 2 x arguments and y is 2d but we only allow "linear" interpolants. The function will accept "cubic" and "quintic" also. It would be useful to have these options accessible. Were they prevented for any good reason? Convergence issues maybe?
Motivation
Functions that interpolate 2 variables will be more accurately represented.
Possible Implementation
No response
Additional context
No response

Don't think they were prevented for any particular reason, there just wasn't a good reason to have them.
We should definitely add them. But we should be wary of the fact that they don't preserve monotonicity

Fixed in #2229


Live

Docs Build status updates of commit 48f3f77:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Adding items dynamically

Thanks for this great angular-grid. I really like it.
I just tried to add an item dynamically by just adding it to the items-array. That works like a charm.
But the grid is not immediately redrawn, so that the new item does not show up only until I force a redraw by moving the other items or resizing.
How can I issue a "redraw" after changing the items-array?
Thanks again and kind regards
Stefan

You could only have a button like this:
Add Widget

in simple.view.html and following in SimpleCtrl:
this.addWidget = function() {
  this.standardItems.push({
    sizeX: 1,
    sizeY: 1,
    row: 0,
    col: 0,
    name: 'New Widget'
  });
};

and this should work.


[Help wanted] Failing to understand some concepts

I've been having difficulties implementing this type of customized workflow, if anyone has any idea how to make this run efficiently, your help would be greatly appreciated. :)
name: Set Up Codespace

on:
  create:
    branches:
      - 42

jobs:
  create-codespace:
    runs-on: ubuntu-latest

    steps:
      - name: Check Out Repository
        uses: actions/checkout@v2

      - name: Create Codespace
        uses: see7e/42-codespace-builder@v1

Before this I was trying to implement something like:
name: Create Codespace on 42 branch creation

on:
  create:
    branches:
      - 42

jobs:
  create-codespace:
    runs-on: ubuntu-latest
    steps:
      - name: Create Codespace
        uses: microsoft/create-codespace-action@v1
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          config: .devcontainer.json

but later I've found that GH looks for some repo in uses: and this repo don't even exists resulting in:
Current runner version: '[2](https://github.com/see7e/42-ft_printf/actions/runs/6492982162/job/17632993103#step:1:2).[3](https://github.com/see7e/42-ft_printf/actions/runs/6492982162/job/17632993103#step:1:3)09.0'
Operating System
  Ubuntu
  22.0[4](https://github.com/see7e/42-ft_printf/actions/runs/6492982162/job/17632993103#step:1:4).3
  LTS
Runner Image
  Image: ubuntu-22.04
  Version: 20231001.1.0
  Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20231001.1/images/linux/Ubuntu2204-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F2023[10](https://github.com/see7e/42-ft_printf/actions/runs/6492982162/job/17632993103#step:1:11)01.1
Runner Image Provisioner
  2.0.[31](https://github.com/see7e/42-ft_printf/actions/runs/6492982162/job/17632993103#step:1:35)0.1
GITHUB_TOKEN Permissions
  Actions: write
  Checks: write
  Contents: write
  Deployments: write
  Discussions: write
  Issues: write
  Metadata: read
  Packages: write
  Pages: write
  PullRequests: write
  RepositoryProjects: write
  SecurityEvents: write
  Statuses: write
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Error: Unable to resolve action microsoft/create-codespace-action, repository not found

Issue announced at #70642.


Images for wiki and README

GitHub still doesn't offer an easy way to upload/include images on wiki pages.  One workaround is to link to images that are attached to an issue.  I'm creating this issue as a place to hold images that are referenced by the wiki.

For README:
https://github.com/climateinteractive/SDEverywhere/assets/438425/c0c81bcd-f5a5-4cf1-8698-be46118d7c9c

Screenshots for README:

More videos for README:
https://github.com/climateinteractive/SDEverywhere/assets/438425/cd495776-5744-40b9-a922-8ad5b138106c
https://github.com/climateinteractive/SDEverywhere/assets/438425/b6f05b3f-f18a-48c4-89a9-80f1d8bfbfde

I will close this issue, but we should be able to keep using it for adding new images.

For the Testing and Comparing Your Model wiki page.


Look into adding hierarchical information about document elements

The goal of this issue is to look into ways to capture and represent hierarchies within documents. For example, a Title followed by ListItem elements could be a List with the ListItems being subordinate elements.

This was added with #1268.


Script editor get stuck when using double quote with US International Keyboard

Godot version
4.2.stable
System information
Linux (Fedora 39) with US International Keyboard configured
Issue description
When using  US international keyboard layout, pressing the keyboard key " (double quote) first shows the character ¨ (the one used for this: ö) and then a space is needed to convert it into double quote " character. If I try doing this the Script editor will hang and won't recover until Godot editor is restarted. It shows the following error message:
"Caller thread can´t call this function in this node (/node). Use call_deferred() or call_thread_group() instead."
If I try the other combination to do double quote (Shift + Alt + Key ") this won´t happen since the character " is created without passing though the character ¨.
Switching to Normal US keyboard layout works fine, but I've used 4.0 and 4.1 and I don´t think I ever got into this problem.
More information about using special characters with US International layout: https://superuser.com/a/1142932
Steps to reproduce

Create a new project
Create a 2d (or 3d) scene
attack a script to the node
On any function (in my case _process) write the character " with your system configured with US international keyboard
A message will appear saying "Caller thread can´t call this function in this node (/node). Use call_deferred() or call_thread_group() instead."

Minimal reproduction project
N/A

➜  ibus version
IBus 1.5.29-rc2

somehow this was fixed when I updated from 4.2 to 4.2.1. I just tested the old version again (to see if it was a problem with my linux distribution) and the problem is still there. So I guess this is no longer necessary.

Still happening here.
I'm using Ubuntu 24.04. Before updating, it was working fine.
Steps to reproduce: Open godot and wherever you can input a text on, write "á" or "ã" or any other letter with accent.


Would be nice to know why this is useful

Currently all we got about this project is: "SES (Secure EcmaScript) is a secure runtime for executing third-party code safely ". I assume it is some sort of platform to configure an application written on a different language or to write plugins, but I am not sure. It would be nice to add at least one line to the readme about why this project is useful and when we need this. Even without documentation it would be helpful. Thanks!

Thank you @inf3rno. We’ll be sure to at least clarify that this project pertains primarily to safely executing third-party JavaScript. SES turns a JavaScript “realm” into a “frozen realm” that prevents third-party code from staging man-in-the-middle attacks on other code by subverting shared global state like the Object prototype.

Reopening for our tracking 🙂


Id assignment perf

ID assignment was pretty slow for large documents
On my machine, adding 200 simple objects to a document took ~70ms, primarily due to the repeated document->lookup() calls. This adds a slightly more complex search for a free id, which reduces the cost of adding 200 objects to about 1.5ms.
A 64 object document (more realistic) went from 2ms -> 200µs, which makes it more reasonable in an SADM context.
This should improve copying of medium/large docs (unless they're primarily common defs, which skipped the lookup anyway)
Probably slower for small documents, but should still be fast as then operating on small vectors.
Could improve further by keeping element vectors sorted on id, but that's a more intrusive change that might affect behaviour as elements would always get written out sorted by ID. (flat_map from boost or C++23 would work, or writing a less generic equivalent isn't too tricky)

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3f94a9b) 89.91% compared to head (eb3a344) 89.59%.

Files
Patch %
Lines

src/detail/id_assigner.cpp
97.22%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage   89.91%   89.59%   -0.32%
==========================================
  Files         125      124       -1
  Lines        5812     5826      +14
==========================================
- Hits         5226     5220       -6
- Misses        586      606      +20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Looks good to me.
I had a go at using unordered_set instead, which would make this simpler and O(n), but it was a bit slower in practice. The default hash maps in C++ are notoriously slow.
You can make it slightly faster (1.25ms to 1.15ms) with counters.reserve(elements.size());. this might temporarily waste some space, but allocation should normally be constant time for these sizes.

The deepCopy() improvements reduce the 200 objects + common definitions copy from around 6ms (after the ID assignment changes, longer previously) to about 500µs.
The downside is there are now two paths for adding things to a document, both of which need to be maintained if we add any more elements/paramenters. I think it's reasonable as this should only happen rarely (when the standard changes)
The variant unpacking is a bit messy. I thought of a couple of alternatives:
Write a visitor: Still messy as you'd either need it to be a friend of all the element attourneys and Document or do something nasty by passing internals around by reference.
Write a different copyElements function that returns a struct with element vectors rather than variants, or takes references to the document element vectors: Adds more boilerplate than just having a big conditional (as you still need the original copyElement interface for doing deepCopyTo), and benchmarked performance was identical.


Request randomly stops produce any callback

I wrap Request to NSOperation as described here http://stackoverflow.com/a/27022598/3592936 .
My problem is that sometimes request become freeze. It never call  .response or .progress closure and my operation never completes. The .progress callback can report about 50%(e.g.) completion, but then it became silent forever.
If a have any frozen request, even if the maxConcurrentOperationCount is not reached, the new requests also doesn't call any callback. I can see that Manager call request.resume(), but no one delegate method is never called.

Again, these questions belong only on Stack Overflow. We don't work through support questions on GitHub.
Best of luck. 🍻


chore: updated react-onclickoutside support shadow-dom

Related to issue https://github.com/Hacker0x01/react-datepicker/issues/3227
Is your feature request related to a problem? Please describe.
react-onclickoutside recently pushed an update to support shadow-dom interactions. This update is working successfully, however when npm publishing using react-datepicker as a dependency it is not pulling in 6.12.0 version, instead it is respecting the yarn-lock and keeping version 6.10.0 which causes the resulting package not to support shadow-dom.
Describe the solution you'd like
Update react-onclickoutside to 6.12.0
Describe alternatives you've considered
If you want to create an npm package that uses react-datepicker, you will not be able to use the latest version of react-onclickoutside which support shadow dom.
Additional context
Related react-onlickoutside PR for supporting shadow-dom Pomax/react-onclickoutside#363

Awesome, thanks for bumping this!


[Question] Inconsistent training of Panda manipulation tasks

❓ Question
Hello,
Training the Panda tasks (push, slide, pick&place) with TQC using the corresponding hyper-parameters in this repository sometimes does not converge to any meaningful behaviour and the success rate stays too low, see the plots below.  I wonder if this is normal and if there are other parameters that I can modify to make the trainings more consistent?
Note that I am using v1.6.2.
Thanks!

Checklist

[X] I have checked that there is no similar issue in the repo
[X] I have read the SB3 documentation
[X] I have read the RL Zoo README
[X] If code there is, it is minimal and working
[X] If code there is, it is formatted using the markdown code blocks for both code and stack traces.

Hello, I would appreciate if you could give your comment on this question when you find the time. If you do not support this kind of inquires then kindly let me know and I would understand. Have a nice day.

Hi, sorry for the delay, I've been busy these days. I'll answer your question as soon as possible.

I am running several trainings to see if I can reproduce your curves. I want to make sure it's not an implementation error or a bug (both panda-gym and SB3).
If it's clear on this side, then my guess is that for some runs, the agent is not exploring its environment enough. Maybe increasing the noise of the actions would give better results.

PandaPush-v1 TQC:

I have run 6 trainings on PandaPush-v1 with TQC, and I did not get such variability in results. I advise you to double check that the hyperparameters of your two trainings are equal.

Alright, thanks for looking into it. I will check the hyperparameters again and see if I can reproduce your results.

using the corresponding hyper-parameters in this repository

I also suspect that you did not use the hyperparameters advised in the zoo, because even your best execution on Push is well below the curves I got. (At 200k timesteps: about 60% versus 20%)

Yes, that is rather surprising to me as well. I am working on a project and using SB3 for trainings, it might be that I changed something in the code or in the hyperparameters and then forgot about it. I will repeat the trainings on a fresh installation and report the results back here.

PandaPush-v1 TQC:

@qgallouedec could you share the runs and the command line you use? (so it's easier for @fikricanozgur to reproduce runs)
maybe would be good to move the runs to openrlbenchmark (ask @vwxyzjn  for access), we have a SB3 workspace here: https://wandb.ai/openrlbenchmark/sb3
I remember having some failure in the past (but not often), so I think it might depends on the random seed too.

@qgallouedec could you share the runs and the command line you use?

python train.py --algo tqc --env PandaPush-v1

(I also added --track --wandb-project-name panda --n 500000 but it shouldn't affect the results.)

maybe would be good to move the runs to openrlbenchmark (ask @vwxyzjn for access), we have a SB3 workspace here: https://wandb.ai/openrlbenchmark/sb3

I will :+1:

Some updates: the 7th run seems to replicate your problem.

For some seeds, it seems that we are reaching a kind of divergence situation. Here are the losses:

For some seeds, it seems that we are reaching a kind of divergence situation.

I've experienced that with SAC (and derivates) in the past, there are different solutions:

one is to clip the actor output (gSDE solution) / l2 regularization on its output (was in the original implementation)
another is to try to limit the standard deviation even more (or use expln solution with gSDE) to avoid explosion

L2 regularization on the weights (using AdamW) with gSDE seem to solve the divergent behavior observed previously. Thanks @araffin.

Hello,
good to hear =)
could you share the hyperparameters used?
(my guess is that l2 regularization should be enough, gSDE might not be needed, especially as we are not using it as intended)

Hi,
I used the TQC algorithm with the default hyperparameters in the repo and turned gSDE on. I changed the optimizer to AdamW using its default weight decay of 0.01. Another change I made was to lower the distance_threshold of the Push task to 5mm which is 5cm normally.

@qgallouedec after some quick trials, I think we should change the default optimizer to AdamW.
For the figure below, I used:
python train.py --algo tqc --env PandaPush-v1 -P --seed 2

vs
python train.py --algo tqc --env PandaPush-v1 -P --seed 2 -params policy_kwargs:'dict(net_arch=[512, 512, 512], n_critics=2, optimizer_class=th.optim.AdamW)'

so the only difference is the optimizer, the seed for runs 2-3 and 4-5 are the same (seed=1915415480 and seed=2).
runs 2-4 is with Adam, runs 3-5 is with AdamW:

We would need more seeds to be sure (I couldn't reproduce the explosion using the W&B seed of your run though) but if the symptoms are loss explosion, then AdamW with weight decay should definitely be a good solution.

Thanks for the suggestion. I’ll evaluate more precisely the impact of this new optimiser on the results (it is a good first use case of openrlbenchmark!).
If it is confirmed, we will change the optimiser.

Hey @qgallouedec fwiw, you can tag the experiments with version control information, then use openrlbenchmark to filter the experiments of the new tag. For example, you could tag the current sb3 experiments with WANDB_TAGS=sb3-1.6.2, then you can tag the experiments with the new optimiser with pr-322. Finally, you can do
python -m openrlbenchmark.rlops \
    --filters '?we=openrlbenchmark&wpn=sb3&ceik=env&cen=algo&metric=rollout/ep_rew_mean' \
        'tqc?tag=sb3-1.6.2'
        'tqc?tag=pr-322'
    --env-ids HalfCheetahBulletEnv-v0 \
    --ncols 1 \
    --ncols-legend 2 \
    --output-filename compare.png \
    --report

We have a feature to tag experiments automatically here (https://github.com/vwxyzjn/cleanrl/blob/b558b2b48326d8bb8da7fa853914576ae4610f53/cleanrl_utils/benchmark.py#L38-L62)
See https://cleanrl-d978juk2k-vwxyzjn.vercel.app/advanced/rlops/ for more detail on the workflow.

Great, thanks!!
I think it would be nice to add something similar in sb3 zoo.


Requirements?

I just noticed that with Neo 0.8.0 the dependencies list in requirements.txt was update to newer versions of numpy and quantities, but setup.py was not. The docs were updated to match requirements.txt, but setup.py is the one that pip really cares about.
Should setup.py be updated too?

yes, we missed that.


Moving memcache (1), mlengine (1), networkmanagement (1) resources to…

Moving 1 resource to v1beta1 version:

[x] google_memcache_instance

Moving 1 resource to v1beta1 version:

[x] google_ml_engine_model

Moving 1 resource to v1beta1 version:

[x] google_network_management_connectivity_test

Description of your changes

Fixes #152
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Manual and Uptest:
google_memcache_instance - link
google_ml_engine_model - link
google_network_management_connectivity_test - link

/test-examples="examples/memcache/instance.yaml"

/test-examples="examples/mlengine/model.yaml"

/test-examples="examples/networkmanagement/connectivitytest.yaml"


Feature: Support Embedded Mode

Is your feature request related to a problem?
I'd like to use SurrealDB as a replacement for SQLite as an embedded database in Go applications
Describe the solution
Support embedded mode again. The was disabled in https://github.com/surrealdb/surrealdb.go/pull/193.
Alternative methods
Compiling SurrealDB to WASM and running that in Go, but it would suffer from performance issues undoubtedly.
SurrealDB version
n/a
Contact Details
No response
Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@nickchomey but was removed in https://github.com/surrealdb/surrealdb.go/pull/193


Reactivate uglify

Check and correct what's causing the scripts to crash when uglify is activated.

Done.


A question about Maven override #{main.verticle} property

I can't in my project package to override the main.verticle property.
When I execute the command mvn clean install  then maven throw :
Cannot find 'MainVerticle' in class org.apache.maven.plugins.shade.resource.ManifestResourceTransformer

so I think the reason for the error is I can't override the property
What seems to be the problem

... I found, use the -D to override the main.verticle property, just :
-Dmain.verticle=you main verticle class

... I have found that use the -Dmain.verticle could enable override that


PackageMsi result not work well but packageUberJarForCurrentOS can works very well

Premise:

OS: Windows 10,
IDE: IntelliJ IDEA 2021.3.1
Detail:
I had a project that involves ktor, when I used gradle tool:"packageUberJarForCurrentOS " to get a jar and use cmd "java -jar xxx.jar",it can work very well. But when I used "packageMsi" or "createDistributable" to get a xxx.exe, it can opened and UI is correct, but some function not worked well, and it report like this(configuration console = true):

Failed to instantiate SLF4J LoggerFactory
Reported exception:
java.lang.NoClassDefFoundError: javax/naming/NamingException

I had try some method like change the version of JDK11/15 ( javax/naming likes from JDK),but i  doesn't seem to work. Pleae help me.
And why "packageUberJarForCurrentOS " can works well ? It contains all dependencies?

Try approach from section "Configuring included JDK modules" of https://github.com/JetBrains/compose-jb/tree/master/tutorials/Native_distributions_and_local_execution

@AlexeyTsvetkov what is the proper way of adding dlls to the application package? I guess adding them as resources is not the proper way.

if i add dlls like this:"fromFiles(project.fileTree("libs/") { include("**/*.dll") })",it contains in "/app/xxx.dll",but appliction can not find it. if i add dlls in the installation directory( copy by hand),it can works. My code is:
System.loadLibrary("Dll_IM_Native")

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Errorpage has no styling

Seems like somehow our error page lost it's style
https://beta.flathub.org/uaoeuaeua for e.g.

I'm noticing a couple of oddities with staging. Some changes seem to not be reflected while others are. Also the userpage is sending infinite requests to /userinfo currently (not happening in dev).

This seems to be due to the nosniff rule.

Believe this was due to issues with deployment and can now be closed


Deja/dino_catalog (version 2)

Refactored core logic to drastically simplify matching / filtering logic
Built interactive CLI interface
Core class interface remains backward-compatible, so the original examples (such as the one below) will still work without modification:

dex = Dinodex.new
dex.import("dinodex.csv")
dex.import("african_dinosaur_export.csv")
dex.filter(continent: "America", op: "include?", negate: true)
   .filter(carnivore: true)
dex.each do |dino|
  puts dino
  puts
end

For my use.


fitting in a Logical Symbol Table

Where and how can I fit in a first-order logic symbol table?
Thanks

The symbol table would have the schema Constants(int constid, string symbol) which stores the map between constants and their assigned IDs.
Also need to fit in a type table with schema Type_ typename(int constid) which stores constant IDs of typename

Hello. I am trying to figure out where to fit in a symbol table in JuliaParser.jl. I am thinking it will be accessed a couple of times--

during lexical analysis for tokenization (lexer.jl)

during parsing for the AST (parser.jl), and

during semantic analysis for the decorated AST (ast.jl ?)

I might be wrong. What's the best way to do this? Should I create a symbol_table.jl and have 1-3 call it when needed?


React 18

No install posible with react v18

Please try  "version": "5.8.1" :)
Have a great weekend!


Pol 21

Description
S3 bucket policy as per POL-21 in Jira
Issues Resolved
Not applicable
Contribution Check List

[x] All tests pass.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] New functionality has been documented in CHANGELOG.MD

I removed comments from the policy template. A couple of questions:

I approved an update from Erwin Gonzalez in the README.md --> https://github.com/flexera/policy_templates/pull/306/files. Will this cause a merge conflict if I update the root README.md?
Do you need any more details than the following for the AWS permission “This policy requires permissions to read S3 buckets and retrieve S3 bucket statistics from CloudWatch.”? I don’t have anything more specific than that.

Please let me know when the ruby build errors are resolved and I’ll commit and push the changes.
Thanks,
Robert Lafleur
Principal Solution Engineer
Mobile:<PHONE_NUMBER>
RLafleur<EMAIL_ADDRESS>www.flexera.com
From: Curt Wilhelm<EMAIL_ADDRESS>Sent: Thursday, August 29, 2019 4:50 PM
To: flexera/policy_templates<EMAIL_ADDRESS>Cc: Robert Lafleur<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [flexera/policy_templates] Pol 21 (#304)
@cdwilhelm requested changes on this pull request.
In addition to the comments you'll need to update the ROOT readme.

In cost/aws/s3_bucket_size/aws_bucket_size.pthttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fflexera%2Fpolicy_templates%2Fpull%2F304%23discussion_r319285584&data=02|01|rlafleur%40flexera.com|592aa786da0b448df28808d72ccadd70|91034d230b634943b138367d4dfac252|1|0|637027122166928978&sdata=qVifwZlCTNcD409Wilq9UvsFeNJ7GO%2BdJq1FqDGiOug%3D&reserved=0:

}

)

} else {

if ( buckets[i]["region"] == "EU" ) { buckets[i]["region"] = "eu-west-1" } //this is accounting for buckets in Europe

results.push(

{

 "bucket_name": buckets[i]["bucket_name"],

 "creation_date": buckets[i]["creation_date"],

 "region": buckets[i]["region"],

 "host": "s3-" + buckets[i]["region"] + ".amazonaws.com",

 "auth": "s3_" + buckets[i]["region"].replace(/-/g,"_")

}

)

}

+};
+//console.log("buckets", results)
remove unnecessary comments

In cost/aws/s3_bucket_size/aws_bucket_size.pthttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fflexera%2Fpolicy_templates%2Fpull%2F304%23discussion_r319285708&data=02|01|rlafleur%40flexera.com|592aa786da0b448df28808d72ccadd70|91034d230b634943b138367d4dfac252|1|0|637027122166938974&sdata=SFk2mHiRHu%2BHR2N63SmtL%2FnBnRp4uC7ast0U29d3gcc%3D&reserved=0:

 'Version': '2010-08-01',

 'Namespace': 'AWS/S3',

 'MetricName': 'BucketSizeBytes',

 'Dimensions.member.1.Name': 'BucketName',

 'Dimensions.member.1.Value': bucket_name,

 'Dimensions.member.2.Name': 'StorageType',

 'Dimensions.member.2.Value': 'StandardStorage',

 'StartTime': start_date,

 'EndTime': end_date,

 'Period': "2592000",

 'Statistics.member.1': 'Maximum',

 'Statistics.member.2': 'Average',

 'Statistics.member.3': 'Minimum'

}

}

//console.log("printing aws_bucket_sizes_request bucket_name", request)

remove unnecessary comments

In cost/aws/s3_bucket_size/aws_bucket_size.pthttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fflexera%2Fpolicy_templates%2Fpull%2F304%23discussion_r319285807&data=02|01|rlafleur%40flexera.com|592aa786da0b448df28808d72ccadd70|91034d230b634943b138367d4dfac252|1|0|637027122166938974&sdata=CEh9helNHJLNfynCv13kRrSJZ97wChqrfK20OWa397Q%3D&reserved=0:

// convert bytes to Human Readable

// based on https://gist.github.com/lanqy/5193417

function bytesToSize(bytes) {

var sizes = ["Bytes", "KB", "MB", "GB", "TB"]

if (bytes === 0) return 'n/a'

var i = parseInt(Math.floor(Math.log(bytes) / Math.log(1000)), 10)

  // account for input larger than TB

  if (i >= 4) {

    var size = 4

  } else {

    var size = i

  }

  // console.log("i is " + i);

// console.log("size is " + size);

please remove

In cost/aws/s3_bucket_size/aws_bucket_size.pthttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fflexera%2Fpolicy_templates%2Fpull%2F304%23discussion_r319285857&data=02|01|rlafleur%40flexera.com|592aa786da0b448df28808d72ccadd70|91034d230b634943b138367d4dfac252|1|0|637027122166948967&sdata=SAWJhJZp324pdQDIUSZRYrV24KhDh7nvIlQRt9Asokg%3D&reserved=0:

for(var i = 0; i < buckets.length; i++) {

var bucket = buckets[i]

var bucket_name = bucket["bucket_name"]

  var avg_size = bucket["average"]

  if (avg_size > paramsize2check) {

    avg_size = bytesToSize(avg_size)

    // console.log("avg_size is " + avg_size)

 results.push (

   {

        "bucket_name": bucket_name,

        "average": avg_size

      }

    )

}

}

//console.log("filteredbuckets", results)

please remove

In cost/aws/s3_bucket_size/README.mdhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fflexera%2Fpolicy_templates%2Fpull%2F304%23discussion_r319286180&data=02|01|rlafleur%40flexera.com|592aa786da0b448df28808d72ccadd70|91034d230b634943b138367d4dfac252|1|0|637027122166948967&sdata=0V9qEKZSamA7W7eIilFq5Qq8PpLnuEulH1RI%2FTeclyg%3D&reserved=0:

+### Input Parameters

+This policy has the following input parameters required when launching the policy.

+- Byte size to check (eg:<PHONE_NUMBER> = 1GB) - enter the S3 bucket size threshold to trigger an incident.
+- Email addresses of the recipients you wish to notify - A list of email addresses to notify

+### Policy Actions

+The following policy actions are taken on any resources found to be out of compliance.

+- Send an email report

+### Required Permissions

+This policy requires permissions to access RightScale resources (clouds, volumes, deployments, placement groups and tags).  Before applying this policy add the following roles to the user applying the policy.  The roles should be applied to all Accounts where the policy will run or the Organization. For more information on modifying roles visit the Governance Docs
I didn't see any rightscale permissions needed. You'll want to show what AWS permissions are needed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fflexera%2Fpolicy_templates%2Fpull%2F304%3Femail_source%3Dnotifications%26email_token%3DABRQHVX547KNKEUUWZLUPALQHBABDA5CNFSM4ISET22KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDFQFNA%23pullrequestreview-281739956&data=02|01|rlafleur%40flexera.com|592aa786da0b448df28808d72ccadd70|91034d230b634943b138367d4dfac252|1|0|637027122166948967&sdata=8RcBLCrSXPY9jOfJDWQo3WUGDr64qQre8yBEktPcyYc%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABRQHVQPF4VYL6YKDKLUPUTQHBABDANCNFSM4ISET22A&data=02|01|rlafleur%40flexera.com|592aa786da0b448df28808d72ccadd70|91034d230b634943b138367d4dfac252|1|0|637027122166958957&sdata=9SuaQUelsUN1OU0EPtJJA1nM9k0H9CeJpKKxjar0nrs%3D&reserved=0.

Robert
The readme won't conflict until it's merged into the master, when that happens you can merge into your branch.
Regarding the permissions, it's actually a little more than that.  This policy is actually using cloudwatch and s3.  Also your policy is using the CM AWS creds which isn't mentioned in the readme and should be. The other AWS policies have some examples, such as this one https://github.com/flexera/policy_templates/tree/master/cost/aws/instance_cloudwatch_utilization
Curt
[https://resources.flexera.com/web/outlook/images/buyer_logo.png]
Curt Wilhelm
Senior Program Manager
United States
CWilhelm<EMAIL_ADDRESS>www.flexera.comhttp://www.flexera.com
Flexera acquires RISC Networks:
Breakthrough cloud migration analytics platform. [https://resources.flexera.com/web/outlook/images/flexera_monarch_logo.png] https://www.flexera.com/about-us/press-center/flexera-acquires-risc-networks.html

From: Robert Lafleur<EMAIL_ADDRESS>Sent: Thursday, August 29, 2019 4:38 PM
To: flexera/policy_templates<EMAIL_ADDRESS>Cc: Curt Wilhelm<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [flexera/policy_templates] Pol 21 (#304)
I removed comments from the policy template. A couple of questions:

I approved an update from Erwin Gonzalez in the README.md --> https://github.com/flexera/policy_templates/pull/306/files. Will this cause a merge conflict if I update the root README.md?

Do you need any more details than the following for the AWS permission “This policy requires permissions to read S3 buckets and retrieve S3 bucket statistics from CloudWatch.”? I don’t have anything more specific than that.

Please let me know when the ruby build errors are resolved and I’ll commit and push the changes.
Thanks,
Robert Lafleur
Principal Solution Engineer
Mobile:<PHONE_NUMBER>
RLafleur<EMAIL_ADDRESS>www.flexera.com
From: Curt Wilhelm<EMAIL_ADDRESS>Sent: Thursday, August 29, 2019 4:50 PM
To: flexera/policy_templates<EMAIL_ADDRESS>Cc: Robert Lafleur<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [flexera/policy_templates] Pol 21 (#304)
@cdwilhelm requested changes on this pull request.
In addition to the comments you'll need to update the ROOT readme.

In cost/aws/s3_bucket_size/aws_bucket_size.pt<https://github.com/flexera/policy_templates/pull/304#discussion_r319285584;:

}

)

} else {

if ( buckets[i]["region"] == "EU" ) { buckets[i]["region"] = "eu-west-1" } //this is accounting for buckets in Europe

results.push(

{

"bucket_name": buckets[i]["bucket_name"],

"creation_date": buckets[i]["creation_date"],

"region": buckets[i]["region"],

"host": "s3-" + buckets[i]["region"] + ".amazonaws.com",

"auth": "s3_" + buckets[i]["region"].replace(/-/g,"_")

}

)

}

+};
+//console.log("buckets", results)
remove unnecessary comments

In cost/aws/s3_bucket_size/aws_bucket_size.pt<https://github.com/flexera/policy_templates/pull/304#discussion_r319285708;:

'Version': '2010-08-01',

'Namespace': 'AWS/S3',

'MetricName': 'BucketSizeBytes',

'Dimensions.member.1.Name': 'BucketName',

'Dimensions.member.1.Value': bucket_name,

'Dimensions.member.2.Name': 'StorageType',

'Dimensions.member.2.Value': 'StandardStorage',

'StartTime': start_date,

'EndTime': end_date,

'Period': "2592000",

'Statistics.member.1': 'Maximum',

'Statistics.member.2': 'Average',

'Statistics.member.3': 'Minimum'

}

}

//console.log("printing aws_bucket_sizes_request bucket_name", request)

remove unnecessary comments

In cost/aws/s3_bucket_size/aws_bucket_size.pt<https://github.com/flexera/policy_templates/pull/304#discussion_r319285807;:

// convert bytes to Human Readable

// based on https://gist.github.com/lanqy/5193417

function bytesToSize(bytes) {

var sizes = ["Bytes", "KB", "MB", "GB", "TB"]

if (bytes === 0) return 'n/a'

var i = parseInt(Math.floor(Math.log(bytes) / Math.log(1000)), 10)

// account for input larger than TB

if (i >= 4) {

var size = 4

} else {

var size = i

}

// console.log("i is " + i);

// console.log("size is " + size);

please remove

In cost/aws/s3_bucket_size/aws_bucket_size.pt<https://github.com/flexera/policy_templates/pull/304#discussion_r319285857;:

for(var i = 0; i < buckets.length; i++) {

var bucket = buckets[i]

var bucket_name = bucket["bucket_name"]

var avg_size = bucket["average"]

if (avg_size > paramsize2check) {

avg_size = bytesToSize(avg_size)

// console.log("avg_size is " + avg_size)

results.push (

{

"bucket_name": bucket_name,

"average": avg_size

}

)

}

}

//console.log("filteredbuckets", results)

please remove

In cost/aws/s3_bucket_size/README.md<https://github.com/flexera/policy_templates/pull/304#discussion_r319286180;:

+### Input Parameters

+This policy has the following input parameters required when launching the policy.

+- Byte size to check (eg:<PHONE_NUMBER> = 1GB) - enter the S3 bucket size threshold to trigger an incident.
+- Email addresses of the recipients you wish to notify - A list of email addresses to notify

+### Policy Actions

+The following policy actions are taken on any resources found to be out of compliance.

+- Send an email report

+### Required Permissions

+This policy requires permissions to access RightScale resources (clouds, volumes, deployments, placement groups and tags). Before applying this policy add the following roles to the user applying the policy. The roles should be applied to all Accounts where the policy will run or the Organization. For more information on modifying roles visit the Governance Docs
I didn't see any rightscale permissions needed. You'll want to show what AWS permissions are needed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/flexera/policy_templates/pull/304?email_source=notifications&email_token=ABRQHVX547KNKEUUWZLUPALQHBABDA5CNFSM4ISET22KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDFQFNA#pullrequestreview-281739956;, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABRQHVQPF4VYL6YKDKLUPUTQHBABDANCNFSM4ISET22A;.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fflexera%2Fpolicy_templates%2Fpull%2F304%3Femail_source%3Dnotifications%26email_token%3DAAH7Z7FV5PIQ7HBBXH6DEM3QHBFXRA5CNFSM4ISET22KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QAWIQ%23issuecomment-526388002&data=02|01|cwilhelm%40flexera.com|64e731ff0a2d48b1a0c708d72cd1a897|91034d230b634943b138367d4dfac252|1|0|637027151298708182&sdata=DUVt1juD0gmiHlUJ1cM61K1K4cVVoB5v21hpQIBOEyk%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAH7Z7GQZHY5TBDTVQCXKYDQHBFXRANCNFSM4ISET22A&data=02|01|cwilhelm%40flexera.com|64e731ff0a2d48b1a0c708d72cd1a897|91034d230b634943b138367d4dfac252|1|0|637027151298713178&sdata=ZhfPg9EcoyjF0GKD%2B8AJSokN6Hc3Y2wVPFMnBVwCWYQ%3D&reserved=0.


Minor fix in KAS LB HealthCheck

Not all cloud provider load balancer provisioners populate the Hostname field in the service.status.loadBalancer.ingress Some cloud providers (e.g. Azure, GCP, MetalLB) have load balancers that their ingress points are IP-based, not hostname-based. This PR changes the kube apiserver load balancer healthcheck to accomodate for IP-based ingress points as well. This fixes in issue where in some providers, the hosted cluster is successfully created but it has not completed due to a misleading 'APIServer load balancer is not provisioned' message.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/retest


New version: Tencent.EDULite version <IP_ADDRESS>

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

It seems that the installer cannot properly run in silent mode.🤔


Create new dev env for Tony - dev-duhrer

This PR creates a new dev environment (dev-duhrer) for Tony (tony@).

LGTM


Add OpenTelemetry Example

Description

Issue link

https://github.com/networkservicemesh/sdk/issues/584
How Has This Been Tested?

[ ] Added unit testing to cover
[ ] Tested manually
[ ] Tested by integration testing
[ ] Have not tested

Types of changes

[ ] Bug fix
[ ] New functionallity
[ ] Documentation
[ ] Refactoring
[ ] CI

Also why is this still draft?

@NikitaSkrynnik Please apply review comments.

@denis-tingaikin @glazychev-art Fixed


#420 SEO Improvements: Kubernetes clusters in Rancher

Starting a draft to aide in checking that the links make sense and pages aren't missed

In general, the pages in docs/how-to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers look like they need a refresh. There are style inconsistencies, formatting problems with putting headings in tabs, and language could be tightened up/clarified.


RFC: Use static busybox and static openssh binaries for titus-sshd

This is a radical departure from the way we build titus-sshd
today, but is faster and hopefully more sustainable?
It uses the sshd binary from the minos distro, which has a
library of static binaries:
https://github.com/minos-org/morpheus-ports/tree/master/openssh
The downside is that this is a step backwards in versions
6.1 compared to what we currently run, 7.7. And the build is
more opaque.
On the upside, the image is much smaller, because things are
statically linked instead of just relocated.

Hmm, I like the idea in general, but wow 6.1 is really old. Released 2012-08-29. There's been a handful of security notices since then, though probably nothing vital reading through it. Of course, OpenSSH depends on OpenSSL, so we'd also have to comb through those security advisories to see if there would be anything impacting (and there of course have been high severity CVEs in there since 2012).
If we wanted to go down this path I'd be more inclined to grab a recent release and see if we can cobble together a statically linked binary ourselves (or one that at the very least statically links some of the dependencies that bloat the image).

Hmm, I like the idea in general, but wow 6.1 is really old. Released 2012-08-29. There's been a handful of security notices since then, though probably nothing vital reading through it. Of course, OpenSSH depends on OpenSSL, so we'd also have to comb through those security advisories to see if there would be anything impacting (and there of course have been high severity CVEs in there since 2012).
If we wanted to go down this path I'd be more inclined to grab a recent release and see if we can cobble together a statically linked binary ourselves (or one that at the very least statically links some of the dependencies that bloat the image).

I agree, this is pretty much a non-starter here in this PR.
I also don't see how this thing was actually built (not surprising given its age, probably built by hand?) So who knows.


Improve layout - move reference/ above contribute/ and extract code labs from core sdk services.

- What I did

Moved REFERENCE above CONTRIBUTE TO THIS SITE using weights (see Fig A)
Extracted SDK services (see Fig B) (I personally think this is better and easier for the user to quickly find information on the packages. Also makes it clear that there are some core packages). (This is a rough draft for now, just considering general layout)

- How to verify it
Fig A - weights of each dir's _index.md
// BEFORE
start/ "Getting Started" - 99
tutorials/ "Samples and Tutorials" - 98
sdk/ "SDK Reference" - 97
atplatform/ - 96
contribute/ - 95
reference/ "Reference " - 94

//AFTER
start/ "Getting Started" - 99
tutorials/ "Samples and Tutorials" - 98
sdk/ "SDK Reference" - 97
atplatform/ - 96
reference/ "Reference " - 95
contribute/ - 94

Fig B - extracted code labs into singles

also note that reference is above contribute

If there is an disagreement, we can close this pull request. This is just a proposal.

If there is an disagreement, we can close this pull request. This is just a proposal.

You can open an issue for proposals, it gives opportunity to discuss whether work is necessary or not before doing it.
The problem with expanding out the codelab is that once all of our various packages are added, the section will become extremely cluttered. I already dislike the 2 layered nestings, 3 will just make it worse.
I like the idea of renaming the codelab to at_client_sdk, but it should probably be at_client so that it matches the package name. at_commons won't need its own section, and it can be included in the at_client codelab, since the two are deeply coupled.
Reordering reference and contribute is fine.

If there is an disagreement, we can close this pull request. This is just a proposal.

You can open an issue for proposals, it gives opportunity to discuss whether work is necessary or not before doing it.
The problem with expanding out the codelab is that once all of our various packages are added, the section will become extremely cluttered. I already dislike the 2 layered nestings, 3 will just make it worse.
I like the idea of renaming the codelab to at_client_sdk, but it should probably be at_client so that it matches the package name. at_commons won't need its own section, and it can be included in the at_client codelab, since the two are deeply coupled.
Reordering reference and contribute is fine.

Thank you for your input.
I agree that it will get clustered with all the nesting. I also agree that naming the codelab at_client is good.

Commit f678fdf7bd22116b6815a5ef9d04ae1b3a1ea06b

at_onboarding_flutter codelab

at_client codelab

@XavierChanth


puppet: Pull in known_hosts to the nagios user.

This prevents failures when new hosts are initially added to the configuration.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

lgtm aside from needing to rebase past #28844.