[Frontend]-config-cli-args

FILL IN THE PR DESCRIPTION HERE
FIX #7350
Alows you to submit args using a config file. Exploited configparse module to accomplish this.
Example:
$ vllm serve --config <path/to/config.yaml>

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Can you add an example to the docs on using a config file?

Thanks for implementing this! Can you add to the docs an example of using a config file?

absolutely. on it.. just finished setting up my ubuntu box for e2e testing..

Hi @DarkLight1337  and @youkaichao  a gentle nudge on this one :)

I'll take another look at this later today.

sorry I don't have bandwidth to review this pr. @DarkLight1337  please go ahead to take the review.
My only ask is to keep the precedence level:
commandline args > config file > default value
e.g.
config.yaml:
tp: 4

commandline:
vllm server -tp 8
and the result should be tp=8 .


adding my name to students.md

Adding my name to the students.md file

Looks good

thanks both! merging this in now
@klterwelp please make sure to add your profile picture when you get a chance :D (it's good practice for your career to have a consistent photo/presence!)


[xla] Improve validation of Broadcast shape

If one misreads the semantics of this instruction, it's easy to cause
an out of bounds access into the dimensions here. Add an extra check
to return a proper error to the user rather than crashing in that
case.
Ref #22130

This should be reviewed by someone on the XLA team. @eliben would you assign someone?

@Keno, can u address the last comment, and I will merge the change afterwards. Thanks.

Yes, I will. Been a bit busy, but I'll push an update shortly.

I had pushed an update to this PR to address the review. Doesn't look like @tensorflowbutler noticed though.


support for variant?

I am testing this library for my use-case, but in some instances it doesn't look right:

What I would want is to never have path going horizontal or going up, it should all flow down. Any idea how I could achieve this?

First of all, looks awesome!
Secondly, is there an actual edge between 'Upload CSV' and 'End IF Step'. If so, would your preference be that 'end if step' would be placed lower than 'Upload CSV'?

First of all, looks awesome!
Thanks!

Secondly, is there an actual edge between 'Upload CSV' and 'End IF Step'. If so, would your preference be that 'end if step' would be placed lower than 'Upload CSV'?
yes exactly. the thing is that if  'Condition', 'Upload CSV', 'End IF Step', and 'EndProcess' are all on a different Rank, I suppose they would be on a vertical line, which would look also broken.
I am thinking i may be able to hack it by checking if a node has a path coming to it from the same rank or below, if so, then push down (position Y) this node and all nodes branching down from it without changing the X position.
This is a hack because the rank would be meaningless, unless adding empty spots in a Rank array...

I think it would be possible to create this in. It is a combination of two optional points that should be added to the graph.

Adding an optional flag to disallow edges within a rank, or edges that go back to a previous rank. If this case is found, the ranks will be adjusted. As said you will push nodes to other ranks (and create new ranks). This will happen recursively until the graph complies with the rules if this flag.
In addition, another optional flag should be added to disallow loops in the graph. (created an issue for this one already #3 )

Hmmm interesting.
The first two steps would still be the ones I described. But, indeed, some additional steps with adding empty ranks should be be added. That part I have to think about how to achieve that.

I was thinking of a completely different approach. By changing the very first thing the algo does:

Use a breadth-first search algorithm to determine the shortest possible route from the start node. The length of the found shortest route for each node is used as the corresponding rank of the node.

to
Use a breadth-first search algorithm to determine the longest possible route from the start node. The length of the found shortest route for each node is used as the corresponding rank of the node.
Maybe this way there would be no upward or horizontal paths... There is still the problem of the empty spots to add, still thinking about it, but I guess it should happen only when a path jumps more than 1 rank, then all intermediate ranks should be added empty spots to make some space...

@crinklesio I copied your lib and made the above adjustments. If you want I can make a PR to your repo so you can take a look...
I haven't fully QA but it is better already for my use case.

@JulienDemarque that would be very interesting. I have yet to find the time to look at it myself.

@crinklesio Ah i don't have permission to push to the repo, if you can add me for permissions (except main), I can push my branch

@crinklesio Ah i don't have permission to push to the repo, if you can add me for permissions (except main), I can push my branch

Should be possible now.

@crinklesio here is the PR: https://github.com/crinklesio/digl/pull/5

@JulienDemarque apologies for the late reply.
I will look at the PR somewhere this or next week. I was thinking though, your proposed approach of starting with the 'longest path from the start' might be a better approach right from the start. That would mean it becomes the default option (and possible the only one).

@crinklesio No worry, I had to switch to a different library. I am using Dagre at the moment, it gives me the position of edges so they can go around nodes. but it still doesn't really fulfill my needs, because I can have multiple edges between 2 nodes, and this is not supported, so I had to do some workaround.
I saw elk (https://www.eclipse.org/elk/reference/algorithms/org-eclipse-elk-layered.html) supports multi-edges but I could never make it work... I wish someone would have extracted their lib into a proper typescript package.

#6 changes the default to 'longest path from source' for the initial ranking of nodes, instead of shortest path from source. I believe it is the better approach, as it will result in better layouts.
Adding empty spots based on your PR (#5 ) is the next step.


Basic Python Implementation of Bindings

A simple Python program that counts the number of tokens in a .cpp file, using the LLVM-Clang Python bindings.

Closed in this pulll request.

Closed in this pull request.


make monitor all check respect individual check box disable

we disable waveform PVs from being monitored via the mui disable property but it would be good if the monitor all also did not check these

https://github.com/ChannelFinder/pvinfo/pull/54


Duplicating Text event: Character setting get's lost

It gives this error:
  The object does not have any 'meta' values with the key 'editor_character_directory'.

This should be resolvrd by the changes in #1207, but I will have to double check

@thebardsrc This has not been fixed. Can still reproduce.


Update Aerial Thumbnail

@glouel I think that the thumbnail is a little blurry you can see below:

I think that's just the 1080p video getting downscaled that artifacts like that, although it does look particularly bad. Is that on a retina screen ?
On 4K videos I noticed the opposite, where the previews are extra sharp and small details tend to blink. I'll have a look tomorrow, I'm not sure if we can pick any resizing method (usually you can) for previews.

No I have a Late 15 MacBook Air

Not the Preview the thing in the bottom left corner

Fixed in 1.4.2 !
https://github.com/JohnCoates/Aerial/releases/download/v1.4.2/Aerial.saver.zip

That is so bloody cool! The best screensaver ever. And that goes beyond the videos themselves as well. Great job guys!

@glouel noticed that the image is actually outside of the border... see screenshot.

and possibly still slightly blurry on a new 5k iMac I'm setting up for a client.. ;)

@glouel noticed that the image is actually outside of the border... see screenshot.

Apparently we had the same issue before, see this screenshot here :

Guess I need to cut the corner of the image !

and possibly still slightly blurry on a new 5k iMac

I'll try to see what images are used by the bundled screensavers, that may have changed and the info I found was outdated 90x58 and 180x116@2x for retina.

I'm setting up for a client.. ;)

What a nice thing to do for your client 👍

FYI found this : https://stackoverflow.com/questions/34030980/os-x-screensaver-retina-thumbnail-image
Regarding corner faking, I can do it, no issue. But the retina thing looks like a bug, I used the same method as the guy did and it's indeed blurry looking closely.
And as the guy said, indeed the effect/corners are baked in default savers ! Very weird :

no worries.. I think the obvious thing was the corner, imo... the retina thing just may be slightly more of an issue at higher(bigger) resolutions?

@dVIAN13 here's the build with the new icon with rounded corners, I tried to align myself to word of the day although the other ones are slightly different.
https://github.com/glouel/Aerial/releases/download/v1.4.4test2/Aerial.saver.zip
Also couple of new featuer, manual sunset/sunrise calculation from latitude/longitude, and brightness reduction !

corners look great! and it doesn't stick out anymore form the other savers... ;) thank you!

Closing this with https://github.com/JohnCoates/Aerial/releases/download/v1.4.4beta1/Aerial.saver.zip

I am still getting a blurry picture on my 2015 MacBook Air:


Allow manually defined models to override PureLive models

I'm looking to create a Starter Kit for Umbraco however my Starter Kit is going to need some SurfaceControllers and in those controllers it will need access to the MB models. Unfortunately, PureLive models are available in a controller context.
This in itself isn't a problem as I'd happily create the models myself manually and allow them to be distributed with the Starter Kit, however, the problem is that there is no way to override PureLive models with your own predefined models. As the Starter Kit will be installed on a solution we won't know the models builder mode of (or, I don't really want to have to change this for them), it would be good if there was a way to use PureLive by default, but for things I want to control in my Starter Kit provide predefined classes that would work in controllers too, but would be used by Models Builder in place of the dynamic PureLive models.

Isn't this already possible if you create custom interfaces, use those in your own controllers and ship partial classes (in ~\App_Data\Models) to make the generated models implement those?

You can also disable generation of the document type using [assembly:IgnoreContentType("alias")], but that would totally break editing the document type, as your shipped model class won't be updated when properties are added, updated or removed...
You also have to account for different namespaces, even when using interfaces and ship partial classes.
Having an assembly attribute to add an interface to a model based on the alias would fix that problem, e.g.: [assembly:ModelsInterface("alias", typeof (IMyOwnInterface))].


Bug fixes in the FontMgr

Fix documentation typos
Fix bug in TypefaceFontProvider which overrides matchFamilyStyle as nullptr (which is sensible due to the typeface font provider name alising).

cc @terrysahaidak @choudlet

Tested it with my fonts and seems to be rendering all the fonts! Great! Thanks @william-candillon for a quick fix!

@terrysahaidak Thanks for the testing, this is fun 🙏


Feature

the lisitdir function list everything inside the directory and the directory itself == if provide path points to directory.
if provide path is "emptystring" then whole content of bucket is provided including directories subdirectories and files

Will ListDir list the contents of the sub directories as well? That should not happen. Or maybe we can provide an option to show the contents in the sub dir as well

In go, package names must be lowercase. Make the package name amazons3

Anything else
On Wed 27 Feb, 2019, 11:46 AM Noorain Panjwani<EMAIL_ADDRESS>wrote:

In go, package names must be lowercase. Make the package name amazons3
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spaceuptech/space-cloud/pull/37#issuecomment-467738312,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXR-HGF0aDsRyZyUbHewXGrxn_lEQgtHks5vRiLJgaJpZM4bTxmO
.

yes it will, list the content of subdirectories

It seems you have got some merge conflicts. After committing your changes, you will have to pull the the upstream repo to resolve the conflicts.
Don't forget to run go mod tidy after resolving the merge conflict

Ok
On Wed 27 Feb, 2019, 8:07 PM Noorain Panjwani<EMAIL_ADDRESS>wrote:

It seems you have got some merge conflicts. After committing your changes,
you will have to pull the the upstream repo to resolve the conflicts.
Don't forget to run go mod tidy after resolving the merge conflict
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spaceuptech/space-cloud/pull/37#issuecomment-467885396,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXR-HGgUFY4VYNXBbufmoUVvpqDLFymUks5vRpgcgaJpZM4bTxmO
.


Single-line comment changes

Change constructHandwrittenBlock in the isComment case to call a new indentAndCommentMarker function, to handle single-line comments such that the comment marker is outside of the socket (and therefore, can't be deleted)
Changed how the ENTER_KEY is handled when inside a socket in a comment: Previously, nothing happened. Now, a new single-line comment is created on the next line with the focus in the new socket so that typing can continue.
Fixed some issues with how handwritten blocks are constructed by properly parenting the TextToken and Socket that belong to the new block.
Fixed an issue where @setCursor would cause comments to be reparsed - and blank comments would fail to parse
NOTE: multi-line comments still have issues and this PR does not address those issues
NOTE: single-line comment support was added for JavaScript and CoffeeScript only

@Bjvanminnen @joshlory

@Bjvanminnen @joshlory

lgtm


Use string functions for left trimming

since we can get the amount of trimmed text by comparing string lengths.
@muhqu please take a look

@nightlyone looks like the acceptance tests failed... see travis.
diff --unified ../testdata/good/example_tokens_everywhere.feature.tokens acceptance/testdata/good/example_tokens_everywhere.feature.tokens
--- ../testdata/good/example_tokens_everywhere.feature.tokens	2015-04-24 14:09:16.572713965 +0000
+++ acceptance/testdata/good/example_tokens_everywhere.feature.tokens	2015-04-24 14:09:19.926556671 +0000
@@ -9,7 +9,7 @@
 (9:7)TableRow://9:<five>
 (10:1)Empty://
 (11:5)ExamplesLine:Examples//
-(12:7)TableRow://9:one,15:two,22:three,30:four,39:five
-(13:7)TableRow://9:un,15:deux,22:trois,30:quatre,39:cinq
-(14:7)TableRow://9:uno,15:dos,22:tres,30:quatro,39:cinco
+(12:7)TableRow://9:one,14:two,20:three,27:four,35:five
+(13:7)TableRow://9:un,14:deux,20:trois,27:quatre,35:cinq
+(14:7)TableRow://9:uno,14:dos,20:tres,27:quatro,35:cinco
 EOF

Fix is on the way. The make file confused me a bit. It only re-compiles all go files after I did git clean -d -ff -x ...

@nightlyone or use make -B to unconditionally build everything...

:+1:


Compute Enclosures and Mounting

For George

waterproof

Compute Box Requirements

Cooling - fans (can do scoop too, but need to have cooling when car is static for long periods)
Mounted to roll hoop
Waterproof
Clear top? / Latching top
Able to add buttons to the side (probably still good if we can do this even with latching top)
Grommets for wires
UV resistance, will be out in the sun a lot

Fits in it:

ROScube-I (core only - no expansion, https://www.adlinktech.com/Products/Download.ashx?type=MDownload&isDatasheet=yes&file=1785\ROScube-I-20201116.pdf)
Jetson AGX Xavier Developer Kit (https://developer.nvidia.com/embedded/jetson-agx-xavier-developer-kit)
EBS Controller (PCB - assume 120mm x 120mm x 40mm)
CAN Tranciever (USR-CANET200 https://www.iot-store.com.au/products/industrial-can-bus-to-ethernet-converter-w-rs485-port-usr-canet200)
Anything else we've forgotten, try and get the biggest box that fits within the rollhoop area so we have flexibility

Connections:

2x Ethernet
Heaps of wires (power, sensors)
Just need clearance on the edges of the box for a lot of ad-hoc grommets

The Two-Box Solution.
Demonstrating that all the non-ROScube components can fit inside a 30x30x10 box:

TheBox 2.zip

Some options for TheBox™es:
Plastic boxes - most are IP66 or thereabouts  which is like the highest grade of protection (or even above that which means we're good on the waterproofing front; 1st digit represents solid protection and 2nd digit represents liquid protection):
Brenclosures: https://www.brenclosures.com.au/plastic-enclosures/
Polynova PC: 270x270x170, IP66
Polynova PM: 270x270x165, IP65
Polynova PN: 360x250x150, IP67
RS PRO Grey Polycarbonate General Purpose Enclosure, IP65, 344 x 289 x 117mm: $121.04; https://au.rs-online.com/web/p/general-purpose-enclosures/1972019
RS PRO Grey Fibreglass Enclosure, IP67, 300 x 300 x 175mm: $231.85; https://au.rs-online.com/web/p/general-purpose-enclosures/0507999
RS PRO Grey PET Enclosure, IP66, 255 x 250 x 120mm: $228.86; https://au.rs-online.com/web/p/general-purpose-enclosures/9188825
GRP IP68 Grey Terminal Enclosure 250H x 255W x 125D:  $71.34; https://www.tro.com.au/GRP-IP68-Grey-Terminal-Enclosure-250H-x-255W-x-125D
Metal boxes - more expensive and with less options found so far:
Aluminium Electrical Enclosure 300H x 300W x 150D IP66 Grey: $269.85; https://www.tro.com.au/Aluminium-Electrical-Enclosure-300H-x-300W-x-150D-IP66
Aluminium Electrical Enclosure 300H x 250W x 150D IP66 Grey:  $260.70; https://www.tro.com.au/Aluminium-Electrical-Enclosure-300H-x-250W-x-150D-IP66
RS PRO Silver Die Cast Aluminium Enclosure, IP66, Shielded, 250 x 250 x 100mm: $90.05; https://au.rs-online.com/web/p/general-purpose-enclosures/5173428
^ wouldn't fit ROScube but very cheap
Note: a 25x25 enclosure would need to stack some components on top of each other in order to fit a fan (eg. CAN to Ethernet on top of Jetson as below), although a deeper box may use the extra depth for the fan instead.

Note note: I presume we can just cut the fan exhaust hole/s into the box ourselves - would be best in terms of flexibility in box choice and component arrangement, but may lead to waterproofing issues (I saw shrouds mounted where the exhaust is and the thing was called weatherproof so that might be enough).

Neat, these look like good options with sufficient mounting options/
Metal boxes might get toasty for the computers in the sun lol.

Initial harness diagram for routing cables in and out of boxes

Was looking into the:
Polynova PM 270x270x165 https://brenclosures-webxopt.netdna-ssl.com/wp-content/uploads/Product-Leaflet-Technical-Polynova-PM.pdf
And:
Polynova PC 270x270x170+42 https://brenclosures-webxopt.netdna-ssl.com/wp-content/uploads/Product-Leaflet-Technical_Polynova-PC-2021.pdf
They look like good options, but cant see prices for them as @GeorgyUshakov noted or at other retailers.
So I found some more options at good prices:
Fibox 300x230x110 - $132.06: https://au.rs-online.com/web/p/general-purpose-enclosures/2189896
Fibox 278x278x130 - $131.34: https://au.rs-online.com/web/p/general-purpose-enclosures/1943134
Fibox 278x278x180 - $119.08 (lol 50mm taller but $12 cheaper): https://au.rs-online.com/web/p/general-purpose-enclosures/1943077

TLA test sizes

Fibox 278x278x180 - $119.08:

Fibox 300x230x110 - $132.06:

Polynova PC 270x270x170 - $165:

Tro 300x230x130 - $42.25:

Contacted Tro Pacific to get datasheets for:
https://www.tro.com.au/Polycarbonate-Enclosure-Clear-Lid-IP66-300H-x-230W-x-130D
Enlec 300x230x130.pdf

https://www.tro.com.au/GRP-IP68-Grey-Terminal-Enclosure-250H-x-255W-x-125D (this one out of stock)
AllBro 250x255x125.pdf

Given sizing constraints and the datasheets from the 4 test TLA options, the ones that can house the roscube are:
Fibox 278x278x180 - $119 (or the 130mm tall variant, its just $12 more)
https://au.rs-online.com/web/p/general-purpose-enclosures/1943077
Polynova 270x270x170 - $165
https://www.tradezone.com.au/product/b-r-270mm-w-x-270mm-h-x-170mm-d-square-adaptable-box-with-clear-lid-22558.html

Option for Enlec 300x230x130 still on the table for secondary components. Cheap and attainable too - $42.25
https://www.tro.com.au/Polycarbonate-Enclosure-Clear-Lid-IP66-300H-x-230W-x-130D

regarding chat today, i also also specced out how this would fit.
Fibox 378x278x180 - $136.07
https://au.rs-online.com/web/p/general-purpose-enclosures/1943132
Would allow for the rear vent fan if we had the snorkel design for the fan on top


Removing Iris, FaceMesh from the Holistic model?

Hello @homuler , How do we remove Iris, FaceMesh from the Holistic model. I am asking this because in some cases the Iris, FaceMesh models gets heavy, and I don't need them in my project.
I tried commenting out the Facemesh graph from the 3 main scripts of the holistic model, namely HolisticGraph, HolisticValue and HolisticAnnotationController . But upon running I get null reference which I was not able to debug it in a standard way.
Here are the logs,

Can you please suggest a better way of doing this?

You can disable iris detections by setting false to detectIris.
https://github.com/homuler/MediaPipeUnityPlugin/blob/8c171d0eb2d16140ea94511d3dd6c94cf3792804/Assets/Mediapipe/Samples/Graphs/Holistic/Scripts/HolisticGraph.cs#L11
Disabling FaceMesh is not so straightforward, because HolisticLandmarkGpu, which HolisticGraph uses internally, does not have such an option.
There are at least 2 options.

You can inline HolisticLandmarkGpu except for unnecessary nodes.
You can define you custom calculators (say PoseLandmarksWithHandsGpu) and use it from HolisticGraph (cf. https://github.com/google/mediapipe/blob/017c1dc7eaf2d45ca95769194d9c83a86a82876d/mediapipe/modules/holistic_landmark/BUILD#L241-L253).

Hi @homuler , what you have described is really interesting way (by making a custom calculator)
But I was able to do my way as well, which I was telling in the first comment, by editing HolisticGraph, HolisticValue and HolisticAnnotationController . The only I did was to comment out all the lines of code where the face mesh was used.

Anyways, Let say If I want to add some other graph (for example lets take face detection instead of face mesh) to add in the holistic model, How do we do it?
Is it by just adding relevant code in all the three scripts I mentioned or something else?
I tried adding faceDetection with this method as shown in the images, Am I going in right way?

Close it because it got staled.


Pagination component isn't responsive for breakpoints above "lg"

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
When using the pagination component, the responsive behaviour is broken when page size is above "lg" breakpoint. All the items are displayed :

Don't know if it's a real bug or if i'm missing a conf option...
Same for versions 5.2.0-beta1 and 5.1.3, using npm.
Reduced test cases
https://stackblitz.com/edit/d41sw5?file=index.html
(app block needs to be widen a bit to see the issue)
What operating system(s) are you seeing the problem on?
Linux
What browser(s) are you seeing the problem on?
Chrome
What version of Boosted are you using?
5.2.0, 5.1.3

Thanks for reporting this issue @Galienna. You're not missing options. At the moment, we only set a max items number until large breakpoint. We could introduce a new rule like that:
@include media-breakpoint-up(lg) {
  @include pagination-max-items(10);
}

FYI we tackled the main issue in https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/1579 that will be released with the v5.2.1. We worked on https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/1370 but there are still some issues of edge cases so we'll try to finish it rather for the v5.2.2 (or v5.3.0 if too complicated to resolve).


feat!: page cache fix, prefer cors for requests, add bigcommerce-cors docs

This PR should update dc-integration-middleware with a version that uses CORS requests by default instead of the middleware API. This should be more reliable, and means that we don't have to officially host a middleware API.
The middleware API and CORS blocked requests are still available via two methods:

INTEGRATION_MIDDLEWARE_SERVER set as 1 when build/run this project to host the API along with the extension.

The extension being hosted will try to use the middleware by default, and the

Passing a custom URL in middleware_api in the extension parameters.

This also fixes a bug with the page cache where some APIs would not properly make product requests.
TODO:

dc-integration-middleware version bump (https://github.com/amplience/dc-integration-middleware/pull/3 after it releases)

You can test current functionality by installing the dc-integration-middleware package from a local copy of the repo (after running npm run build)

Build failure is due to the integration middleware not being updated yet.


Map responseJSON data to User object

Note: I need to use ObjectMapper, and not AlamoFireObjectMapper.
How do you map without going to JSON but from responseJSON data to map to User? The following is trying to go from responseJSON to jsonn and then back again to data(being User). I guess there must be a way?
Or should I use responseData from AlamoFire?

public class User: Mappable {
    var username: String?

    required public init?(map: Map) {

    }

    // Mappable
    public func mapping(map: Map) {
        username    <- map["username"]
    }
}

    Alamofire.request(
        url,
        method: .get,
        headers: headers_employees).responseJSON {
            response in
        // Map via ObjectMapper
        let [User] = Mapper<User>().map(JSONString: JSONString)

   }

The map function also accepts a JSONObject (Any) or a JSON dictionary ([String: Any]). Depending on the type of the response object, you should use the appropriate method.


Validation failed exception

I've tried to use the extension for the repository https://github.com/Microsoft/vscode-npm-scripts/issues, but I'm getting the exception below. Do I need to have a GITHUB access token in my environment?
{"message":"Validation Failed","errors":[{"message":"The listed users cannot be searched either because the users do not exist or you do not have permission to view the users.","resource":"Search","field":"q","code":"invalid"}],"documentation_url":"https://developer.github.com/v3/search/"}
e.doShow @ /C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28

It doesn't need a token/password, the username is picked from 'git credential'. What is the output of git remote -v? And what is the output of echo "url=https://github.com/Microsoft/vscode-npm-scripts.git\n\n" | git credential fill | grep username?

I'm doing this on Windows.
git remote -v
origin  https://github.com/Microsoft/vscode-npm-scripts.git (fetch)
origin  https://github.com/Microsoft/vscode-npm-scripts.git (push)

git credential fill
url=https://github.com/Microsoft/vscode-npm-scripts.git
warning: invalid credential line:

@egamma A variation that works on Windows, could you check what the output is: echo url=https://github.com/Microsoft/vscode-npm-scripts.git | git credential fill

voila
echo url=https://github.com/Microsoft/vscode-npm-scripts.git | git credential fill
protocol=https
host=github.com
path=
username=Personal Access Token
password=xxxx

Fixed and added a setting github.username for when the username in the Git credentials manager cannot be used.


[BUG] The pane doesn't return downwards

Describe the bug
I have a textarea in the pane, and when I click the textarea, the pane moves upwards as a result of the keyboard. When I dismiss the keyboard, the pane still remains hanging upwards.

Hello @Evanzsnr
Please specify platform and provide some video if possible.

I am using ionic framework
Ionic:

   Ionic CLI                     : 6.12.1 (C:\Users\Evans\AppData\Roaming\npm\node_modules\@ionic\cli)
   Ionic Framework               : @ionic/angular 5.3.2
   @angular-devkit/build-angular : 0.1000.8
   @angular-devkit/schematics    : 10.0.8
   @angular/cli                  : 10.0.8
   @ionic/angular-toolkit        : 2.3.3

Capacitor:

   Capacitor CLI   : 2.4.1
   @capacitor/core : 2.4.1

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : android 8.1.0
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.2.1, (and 16 other plugins)

Utility:

   cordova-res (update available: 0.15.1) : 0.9.0
   native-run (update available: 1.0.0)   : 0.2.8

System:

   NodeJS : v12.14.1 (C:\Program Files\nodejs\node.exe)
   npm    : 6.13.4
   OS     : Windows 10

I have a video but I am unable to attach it here.

Hey @Evanzsnr
Please check master branch version with your app
"cupertino-pane": "git+https://github.com/roman-rr/cupertino-pane.git"

@Evanzsnr should be fixed in master and will be fixed in next release.


Create emissary-ingress.dev/v4 CRDs

We have to bump the CRD version anyway, because removing header casing and error response rewriting is a breaking change, and we'd like to be able to get away from apiext for green-field installations of Emissary 4, but we'd also like to not force forklift upgrades from Emissary 3. The way to make all of these things work is to have a new API group.
emissary-ingress.dev/v4 CRDs should mostly look like getambassador.io/v3alpha1, but:

rip out stuff lingering from v2
rip out header casing and error response rewriting
use camelCase instead of snake_case

and yes, we'll all but certainly start with v4alpha1 but let's not stop there.

Note that we run into the shortname collision problem here, too: does kubectl get Mapping mean mapping.getambassador.io or mapping.emissary-ingress.dev? We should think about that, and how to alleviate it.


Requires 2 Charges Per Use

Couldn't find REQUIRES MULTIPLE CHARGES in HD.  It appears it may be a custom modifier, which I'm not prepared to handle.


Update free-trial.md

Fixed styling issue with bullet points inside note

Hi @miparnisari, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


Unpredictable empty response during FIA refreshing data

Due to truncation and rewriting feeds_aggregated table.

Hmmm... Partitioning based approach can boost performance.


ci: replace mergify with prow bot

See: https://github.com/Xunzhuo/layotto/pull/5

cc @kebe7jun

Codecov Report

Merging #275 (4f68390) into main (c91d896) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   40.33%   40.33%
=======================================
  Files           7        7
  Lines         419      419
=======================================
  Hits          169      169
  Misses        236      236
  Partials       14       14

Flag
Coverage Δ

unittests
40.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Some questions.
Can this perform merge automatically (when lgtm and approved tags are present).
Does it respect to the CODEOWNERS file? (I don't seem to see it, I need to define it manually)?

Can this perform merge automatically (when lgtm and approved tags are present).

Currently we can use /merge to merge it, and it requires PR has already got /lgtm and /approve and without /hold. But you are right, we should also support auto merge when we has /lgtm and /approve.

Does it respect to the CODEOWNERS file? (I don't seem to see it, I need to define it manually)?

We will repect k8s OWNERS format to define our maintainers/approvers/reviewers:  https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
They are both in the plan.

Hold

Some configs need to be updated.
/hold

Side comment, since merbridge is a sandbox project, can CNCF provide a server to deploy Prow itself, which is more powerful than the bot written by me?

Maybe can ask for it in Service Desk?

Good idea, can you help to create a request?

Looks like our onboarding process is still WIP, we can only access to service desk, after being invited.

Service Desk permissions have been added, you can check the email address you left last time~


Created mobile middle section (projects and about-me)

In this PR:
created projects section HTML code
styled projects section
created about-me section
added style to the about-me section
added images to img folder
Thank you for reviewing my PR

Thank you @Kossi-stack


Module "@circlon/angular-tree-component" has no  exported  member 'IDTypeDictionary'

In our project there is old import from old version, in @circular I got following error

My fault: It should be


Eventually move onto returning promise consistently

Let me prefix this by stating there isn't an emergency for this change, but I consider it a good direction in the long run (ie. v3), since we are using yieldb on a new project, might as well plan for it.
My question: for those APIs returning thunk, are they chosen based on semantic reason or performance reason? Since yieldb assumes node v0.11, I guess it's not due to compatibility?
There are many debates around whether co should continue to support thunk, given it's moving towards ES7 async/await, which support promise only. But perhaps the larger gain here is not needing to specify if an API is returning thunk or promise.
And I prefer to use then/catch instead of node style callback when not using co, but that's my personal preference.

Not sure about the easier to implement part, since most of the queries are already promise-based. Maybe some find it easier to explain what thunks do than promises.

supports apis like .aggregate().stream() which would not be possible using an approach which immediately executes the query (like promises)

Understand this is a general problem as one needs to choose between Promise and Stream, but perhaps we can provide a method/options to enable optional piping.

cannot use a chaining api for streams because query is immediately executed

mquery seems to does chaining just fine by creating a thenable function?
For common actions like insert I don't see many advantages of thunk over promise, maybe I missed something?

i agree with the goal of making the return objects all thenables for maximum interop. haven't thought a lot about it yet but one possibility is just adding a then() method to the thunks.

try out 2.3.0 and let me know if this works for you. every method now returns something which has a then() method and is therefore a Promise.

amazing, i will try it out.


Propagate changes of md-rendered checkboxes to the server

Markdown rendered checkboxes are now enabled/clickable in comment blocks, markdown is changed accordingly and the raw comment is updated on the server.
Attaches change handlers to the markdown rendered checkboxes.
When a checkbox value changes, the corresponding [ ] or [x] in the markdown string is set accordingly and sent to the server.
On success it updates the raw-content on error it resets the checkbox to its original value.
While a request is in-flight, all checkboxes within the same markdown block are disabled.
#7097

Codecov Report

Merging #14258 (6e824dc) into master (126c933) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14258      +/-   ##
==========================================
- Coverage   41.97%   41.87%   -0.10%
==========================================
  Files         735      742       +7
  Lines       78933    79324     +391
==========================================
+ Hits        33132    33218      +86
- Misses      40346    40645     +299
- Partials     5455     5461       +6

Impacted Files
Coverage Δ

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

routers/init.go
45.79% <0.00%> (-4.61%)
:arrow_down:

models/unit.go
46.57% <0.00%> (-2.74%)
:arrow_down:

modules/auth/auth.go
61.53% <0.00%> (-2.51%)
:arrow_down:

modules/auth/sso/sso.go
32.14% <0.00%> (-0.59%)
:arrow_down:

models/gpg_key.go
53.33% <0.00%> (-0.58%)
:arrow_down:

routers/admin/users.go
27.77% <0.00%> (-0.08%)
:arrow_down:

modules/auth/admin.go
0.00% <0.00%> (ø)

modules/auth/sso/basic.go
51.06% <0.00%> (ø)

modules/auth/sso/oauth2.go
46.77% <0.00%> (ø)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126c933...6e824dc. Read the comment docs.

Codecov Report

Merging #14258 (6e824dc) into master (126c933) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14258      +/-   ##
==========================================
- Coverage   41.97%   41.87%   -0.10%
==========================================
  Files         735      742       +7
  Lines       78933    79324     +391
==========================================
+ Hits        33132    33218      +86
- Misses      40346    40645     +299
- Partials     5455     5461       +6

Impacted Files
Coverage Δ

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

routers/init.go
45.79% <0.00%> (-4.61%)
:arrow_down:

models/unit.go
46.57% <0.00%> (-2.74%)
:arrow_down:

modules/auth/auth.go
61.53% <0.00%> (-2.51%)
:arrow_down:

modules/auth/sso/sso.go
32.14% <0.00%> (-0.59%)
:arrow_down:

models/gpg_key.go
53.33% <0.00%> (-0.58%)
:arrow_down:

routers/admin/users.go
27.77% <0.00%> (-0.08%)
:arrow_down:

modules/auth/admin.go
0.00% <0.00%> (ø)

modules/auth/sso/basic.go
51.06% <0.00%> (ø)

modules/auth/sso/oauth2.go
46.77% <0.00%> (ø)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126c933...6e824dc. Read the comment docs.

Thank you!
Two edge cases to consider:

Your markdown <-> checkbox matching fails for pathologic markdown like the following:
[x]
- [ ] foobar

This should be fixable with a stricter regex like ^- \[[ x]\]

as I showed in https://github.com/go-gitea/gitea/pull/14258#discussion_r552191512 the regexp route cannot work - we need to store the index in the raw markdown of the checkbox as described here: https://github.com/go-gitea/gitea/pull/14258#discussion_r556063439 (and some  kind of hash of the raw markdown too to ensure it hasn't changed in the intervening period) then switch the checkbox that way.

The checkboxes are still interactive when user can't edit a comment. For accessibility I'd prefer if these checkboxes remain disabled. You could check if a sibling matching .comment-container .comment-header-right .menu .item.edit-content exists, or (cleaner) add a data-attr to the comment indicating if it is editable. For the cleaner solution, edit templates/repo/issue/view_content/comments.tmpl with a similar check to https://github.com/go-gitea/gitea/blob/f76c30094f086162d09926a95e9a75c91177a674/templates/repo/issue/view_content/context_menu.tmpl#L13

Agreed - these should be disabled if the user does not have permission to edit.
We can pass in the permission check as part of render config to goldmark to get it to render actual forms for the checkboxes - although getting that past the sanitizer as currently constituted could be difficult - or just get javascript to enable them - by passing in the permission flag as part of the render.

Thank you!
Two edge cases to consider:

Your markdown <-> checkbox matching fails for pathologic markdown like the following:
[x]
- [ ] foobar

This should be fixable with a stricter regex like ^- \[[ x]\]

as I showed in https://github.com/go-gitea/gitea/pull/14258#discussion_r552191512 the regexp route cannot work - we need to store the index in the raw markdown of the checkbox as described here: https://github.com/go-gitea/gitea/pull/14258#discussion_r556063439 (and some  kind of hash of the raw markdown too to ensure it hasn't changed in the intervening period) then switch the checkbox that way.

The checkboxes are still interactive when user can't edit a comment. For accessibility I'd prefer if these checkboxes remain disabled. You could check if a sibling matching .comment-container .comment-header-right .menu .item.edit-content exists, or (cleaner) add a data-attr to the comment indicating if it is editable. For the cleaner solution, edit templates/repo/issue/view_content/comments.tmpl with a similar check to https://github.com/go-gitea/gitea/blob/f76c30094f086162d09926a95e9a75c91177a674/templates/repo/issue/view_content/context_menu.tmpl#L13

Agreed - these should be disabled if the user does not have permission to edit.
We can pass in the permission check as part of render config to goldmark to get it to render actual forms for the checkboxes - although getting that past the sanitizer as currently constituted could be difficult - or just get javascript to enable them - by passing in the permission flag as part of the render.

The markdown or orgmode renderer should give the line number of the checkbox on original document.
All checkboxes should accept an event to request backend to update the markdown/orgmode and then update the frontend document via ajax .

The markdown or orgmode renderer should give the line number of the checkbox on original document.
All checkboxes should accept an event to request backend to update the markdown/orgmode and then update the frontend document via ajax .

I'm still up for this, but having a lot on my plate right now. I'll get it done when I find the time to read up on go a little, so I don't just blindly apply zeripath's diff (thanks for that) but know how it works. Shouldn't be that long.
If anyone's willing to do it right away, go ahead. Will report back here once I start working on it again

I'm still up for this, but having a lot on my plate right now. I'll get it done when I find the time to read up on go a little, so I don't just blindly apply zeripath's diff (thanks for that) but know how it works. Shouldn't be that long.
If anyone's willing to do it right away, go ahead. Will report back here once I start working on it again


Add link to save original PDF in Firefox extension

It's well and good that I can view PDFs seamlessly in my browser, but sometimes I want to retain them for future use. The window URL points to an unhelpful resource://, and there's no convenient way to save the original PDF to disk.

There's a button labeled 'Download' that should allow you to save the original pdf locally.  I think that was added awhile ago so it should be in the current extension.

I see a Print button, but no download one.

Interesting, it's there in the Live View. Looks like the extension requires updating.

Turns out I didn't have the most recent extension.


Add mDNS configuration

Enums serialized quite nicely, let me know what you think

Enums serialized quite nicely, let me know what you think

Looking good! I'm glad we tried.


Project settings for the cluster deployment

From the readme I understand that the dm-setup folder's code ensures Google Deployment Manager running in one project deploys GCP resources in another project.
Something that I could not catch hold of is

How do you set the target project details where the cluster would need to get deployed  ?

Hi -- this lab is intended to be run in a single GCP project. When we use this repository it's typically deployed into a project in the Qwiklabs environment, but there's no reason why it shouldn't work in any project. Note that by default you may hit quota issues when deploying.


clang-tidy: performance-noexcept-move-constructor

Description: performance-noexcept-move-constructor checks for move constructors that aren't declared noexcept, the reason being that STL containers will use the copy constructor for operations like emplace_back if the move constructor is not declared noexcept due to exception safety guarantees.
http://www.hlsl.co.uk/blog/2017/12/1/c-noexcept-and-move-constructors-effect-on-performance-in-stl-containers
https://stackoverflow.com/a/32225460
Risk Level: low
Testing: existing
Docs Changes: N/A
Release Notes: N/A
Relates to #4863
Signed-off-by: Derek Argueta<EMAIL_ADDRESS>

/retest

This is subtle. TIL

hmm coverage keeps core-dumping, seemingly on IpVersions/ProxyFilterIntegrationTest.RemoveHostViaTTL/IPv4
external/bazel_tools/tools/test/test-setup.sh: line 310:  2368 Aborted                 (core dumped) "${TEST_PATH}" "$@" 2>&1
Not seeing anything on master relating to a "fix" for this, gonna give it one more retest, and if that fails will merge master. BTW is there a way to access the error log file from Circle CI? I haven't figured that out yet for looking at the exact error log.

/retest

@derekargueta that test flake is fixed in https://github.com/envoyproxy/envoy/pull/7361


Configure.CheckLib() error with -Wstrict-prototypes

This is a continuation of #3095. As noted in this comment, there was one more instance that was missed in PR #3096:
https://github.com/SCons/scons/blob/810ca6c8895b01cbd636d83079f6a848dc36adf6/SCons/Conftest.py#L677-L684

Thanks for spotting, you're quite right.  I'll take this; might also normalize the formatting a little on some of the other C snippets too.  Line breaking seems to be... well, breaking... various things these days: e.g. Python code formatters may break a function signature into multiline, and then it doesn't look right in tracebacks, debugger, etc.

FYI I already submitted PR #4374. I mentioned it in the commit but not the PR, so it wasn't linked.

ah, ok.


Re-use common results

Now that we keep more state on the server, we can also re-use some of the results. For example, there is no need to recalculate the "sum of all frames" image for each analysis of a dataset that uses it - for these, we could implement some basic caching, until the dataset is closed. An Analysis would need to specify if the result is cacheable, for example SUM_FRAMES and similar should only be cached if there is no ROI set.
This is a low-priority enhancement, and care should be taken to get the caching right. If implemented on the server side, care needs to be taken to not cancel jobs that are shared etc.

Related to #1094?


Redirect nested routes

I have routes:
<Route path="/" component={Root}>
  <Route path="project/:name" component={Project}>
    <IndexRoute component={ProjectIndex} />
    <Route path="settings" component={ProjectSettings} />
    <Redirect from="about" to="settings" />
  </Route>
</Route>

But this case is not work!

I need redirect from /project/:name/about to /project/:name/settings
How i can do it in new v1 version?
In old version i do:
<Route name="root" path="/" handler={Root}>
  <Route name="project" path="project/:name/?" handler={Project}>
    <DefaultRoute name="projectIndex" handler={ProjectIndex} />
    <Route name="projectSettings" path="settings/?" handler={ProjectSettings} />
    <Redirect from="about/?" to="projectSettings" />
  </Route>
</Route>

I very like old version with many cool features: active class in Link, route names

https://github.com/rackt/react-router/blob/master/UPGRADE_GUIDE.md#redirect-route


pnr/openroad disable mpl2

disable mpl2 until we get or-tools packaged

Fixes #258

@maliberty @donn is mpl2 currently used in OpenLane?

@proppy Not that I know of

openlane mostly uses manual macro placement today afaik

Not sure who is responsible for this, but can this be merged please? Not having the openroad latest conda package is delaying OpenFASOC's tests with the latest version of openroad.
@PiotrZierhoffer can you help here in someway?
cc: @msaligane

@proppy

@saicharan0112 the build need to be fixed first https://github.com/hdl/conda-eda/actions/runs/3499093346/jobs/5860258677

@proppy So this PR is not the complete solution for the openroad build?

@saicharan0112 the goal of that PR is to find out what need to be changed to fix the build ;)

@ajelinski the build seem to pass now: https://github.com/hdl/conda-eda/actions/runs/3540069944/jobs/5942702180 can  you review?

@QuantamHD does it look reasonable to you to disable mpl2 for now?

Hi everyone, not sure what's stopping from merging the PR to publish the latest openroad package but just for info, but the package out there is almost 20 days old and projects like OpenFASoC relies on this package to get the latest openroad binary in the CI. I am sure others who you were encouraged to use the package are also have no access to the latest version of the binary.
It would be really helpful if we have access to the latest version of the binary in the package form in the near future.
Thanks

Yeah you can disable it. Nothing will break, but it's not a desirable state to be in.

@proppy Are the failing CI results related to the patch file?

@QuantamHD nop, the OpenROAD job itself is failing:
https://github.com/hdl/conda-eda/actions/runs/3540186266/jobs/5942944935

Nothing will break, but it's not a desirable state to be in.

Is it surfaced in the openroad cli/ui yet? It doesn't seem that OpenLane is using yet per https://github.com/hdl/conda-eda/pull/259#issuecomment-1319494561.

You can call it, but most people aren't using it. It's an automatic macro placer

Filed https://github.com/hdl/conda-eda/issues/261 to track re-enabling it.

@proppy the openroad is still failing. Did you see that? https://github.com/hdl/conda-eda/actions/runs/3629708117/jobs/6122235621#step:3:1209

That's confusing because it passed in the presubmit:
https://github.com/hdl/conda-eda/actions/runs/3540186266/jobs/5942944935
@ajelinski @PiotrZierhoffer do you have a clue?

Error: Failed to render jinja template in /home/runner/work/conda-eda/conda-eda/workdir/recipe/meta.yaml:
'GIT_DESCRIBE_TAG' is undefined

Such an error is almost always about problems during patches and then the details are reported below: https://github.com/hdl/conda-eda/actions/runs/3629708117/jobs/6122235621#step:3:1256

Command '['/home/runner/work/conda-eda/conda-eda/workdir/conda-env/bin/patch', '--no-backup-if-mismatch', '--batch', '-Np1', '-i', '/tmp/tmp9nw5r5pn/disable-mpl2.patch.native', '--binary', '--dry-run']' returned non-zero exit status 1.

So this is definitely about disable-mpl2.patch as MPL2 was disabled for macOS in the meantime: https://github.com/The-OpenROAD-Project/OpenROAD/commit/ac6fcd93f4fc88dd1bc11731b43621d2ad898d20


Ask

how to install this bot in termux ? and how to run it

Hi cleprist, please open the issue on this repo:
https://github.com/soruly/whatanime.ga-telegram-bot/issues

im still not understand, how to install to be LINE BOT,

@cleprist I didn't develop any LINE bot for whatanime.ga
To do so, you'd have to develop your own bot with the whatanime.ga API
See more on https://soruly.github.io/whatanime.ga/


move excess native token transfer to before post-execution checks

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (8c54f89) compared to base (e8ead7e).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##               1.3      #983   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           47        47
  Lines         2669      2671    +2
  Branches       394       394
=========================================
+ Hits          2669      2671    +2

Flag
Coverage Δ

foundry
77.71% <83.33%> (+<0.01%)
:arrow_up:

production
100.00% <100.00%> (ø)

reference
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contracts/lib/OrderCombiner.sol
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Codesign and upload new ios-usb-dependencies binary

Codesign the binaries in flutter_infra_release/ios-usb-dependencies/unsigned/ from https://ci.chromium.org/p/flutter/builders/prod/ios-usb-dependencies/5 and upload to the signed bucket.
https://docs.google.com/document/d/1ukmoITOt7rixsp8dw7Da95-3WFkKzPMnwzcvd-0UqqU (internal link) says:
./codesign.py --ios-deploy $IOS_DEPLOY_REVISION

I'm not sure if this still works after the recipe change https://flutter-review.googlesource.com/c/recipes/+/32660/
See also https://docs.google.com/document/d/1LZ4k65Xf5wcMD7ProYL6zXRcoBlCkWB67Mu_Uzs-gjU/ (internal link)
Blocking https://github.com/flutter/flutter/issues/111988
@XilaiZhang

TLDR: I left a comment in https://flutter-review.googlesource.com/c/recipes/+/32660/ which I believe could be the potential cause.
umm I clicked through each of the ios_deploy_revision in the designated signed buckets at https://pantheon.corp.google.com/storage/browser/flutter_infra_release/ios-usb-dependencies/ios-deploy?authuser=0&pageState=("StorageObjectListTable":("f":"%255B%255D"))&prefix=&forceOnObjectsSortingFiltering=false, and looks like all of them were created in 2020 or 2021. My understanding is that the binaries Jenn code signed weren't uploaded back to the correct bucket.
From the upload step of ios-deploy in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8802457278010945569/+/u/gsutil_upload_of_ios-deploy.zip/execution_details, looks like the codesigned ios-deploy was uploaded back to the bucket flutter_infra_release/ios-usb-dependencies/unsigned/ios-deploy/90bac5343961b10379a41d814820c5aac8145df2 , and i verified that this bucket has a create timestamp of Sep 20 2022. But I am confused as of why a signed binary would be uploaded back to this bucket.
tracing through the code sign script, looks like cloud buckets are set correctly. If using the codesign script, the signed binary would be uploaded back to the flutter_infra_release/ios-usb-dependencies/ios-deploy/revision bucket, as opposed to the flutter_infra_release/ios-usb-dependencies/unsigned/ios-deploy/90bac5343961b10379a41d814820c5aac8145df2 bucket.
I traced through https://flutter-review.googlesource.com/c/recipes/+/32660/ and my understanding is that the codesigned binary is uploaded through the GetCloudPath function, which uses the unsigned binary cloud bucket path, and I left a comment at the line which I believe could potentially be the culprit.
I am kind of confused of how the upload/download to/from google cloud storage is handled by the recipe and not handled by the codesigning script. And it doesn't look like the codesign script was triggered as one of the steps in the recipe. Maybe @christopherfujino would have more idea on how code sign script fits in this recipe?

The artifacts produced by the recipe at https://flutter-review.googlesource.com/c/recipes/+/32660/ are unsigned, and upload to the unsigned bucket.

My understanding is that the binaries Jenn code signed weren't uploaded back to the correct bucket.

I haven't codesigned anything, they need to be codesigned on the codesigning bot, which is what this issue is tracking.  If the recipe could handle codesigning and upload to the signed bucket that would be even better, but it doesn't now.  Then I will validate ios-deploy works, and then we can bump the version that the tool downloads.

Ohhh i see. sorry I misunderstood. So this would be a tracking issue, and not a bug that requires inspection or fix?

Exactly, the unsigned ios-deploy binary is built, and now it needs to be codesigned with the distribution cert, and uploaded to the signed bucket.

Perfect prefect, thanks for explaining!

Now that https://flutter-review.googlesource.com/c/recipes/+/34240 has merged it would be great to have all the binaries codesigned, not just ios-deploy.  I'll update the title and description.

Will do, yeah I will experiment with repo modules a few more times. If it doesn’t work I will just remove the else block to unblock myself.

this issue is added to release blockers to track the progress per @CaseyHillers request

https://github.com/flutter/cocoon/pull/2179 and https://flutter-review.googlesource.com/c/recipes/+/34300 are both ready. would be great if i can get more reviews on them. I have tested by signing the ios usb artifacts under the led directory and they are signed correctly (tested by running the app locally).

https://flutter-review.googlesource.com/c/recipes/+/34300 has merged

Update from triage: @XilaiZhang updated the standalone codesign tool to work for this use case, but there's some more recipe work.

Moving out of blockers as there's no PRs/CLs left for review.

@XilaiZhang codesigned these manually.  I'm testing now.

@XilaiZhang is this finished testing?

we have removed standalone codesigning tool, and codesigning is now used as a recipe module (e.g. as used in engine v2 recipe), and artifacts are signed when they are built. my understanding is that we could invoke code signing from the recipe that builds ios-usb-dependencies, as long as there are entitlement files embedded in those artifacts.
The embedding of the entitlement files would look something similar to https://github.com/flutter/engine/blob/main/sky/tools/create_macos_framework.py#L174

updated doc at code-signing-artifacts-other-than-flutter-engine-binaries. we can potentially invoke the recipe module of code signing, once ios usb artifacts are built.


Injection zone component for Content Manager edit view

Injection zone dedicated for Content Manager Edit View

visible only in case of existing reactions
counting reaction by type
nice visualization

Released as part of v1.0.0-beta.2


sync/async subscription behavior differs after slidingWindow()

I get a different behavior depending on if I subscribe synchronously or asynchronously to a stream that is using slidingWindow(): https://jsfiddle.net/j2mLpuqw/
Not sure if am missing something but I expected that the behavior of the async subscriber is independent of subscriptions to other streams. The subscription outside setTimeout() works as expected. With .changes().filter(...) I get the expected behavior but this solution would not work for a stream with more states than true/false.
Another example with combined streams: https://jsfiddle.net/zwn05cxu/
Is that a bug or is it possible to get the async subscription to work the same way as the sync subscription?

Looks like the combo Bacon.fromArray().bufferingThrottle is somehow broken.
Replacing Bacon.fromArray([]) with Bacon.sequentially(0, []) seems to fix both examples.
I rarely use Bacon.fromArray in real code - just for doodling in the REPL.
If I recall correctly Bacon.fromArray also is something of an alien in baconjs because it kind of synchronously emits events which causes all kinds of trouble. That behaviour was already changed in the past when the major version of baconjs bumped, I guess.
Do you really need to fire your data items using Bacon.fromArray?

The stream I use is created with Bacon.fromBinder. Seems to happen there too: https://jsfiddle.net/7es20dtw/. I mean there are ways to circumvent this exact case, just wondering if I was missing some idea here.

Some ideas regarding the example with Bacon.fromBinder(producerFn) :

Bacon streams are lazy. That means until there is a subscriber for the stream, the producer function is not called. This is part of the explanation why the async subscription of  derived works if boolStream itself has not yet produced any values in case the boolStream subscription is commented out.
slidingWindow produces a Bacon.Property. That is a stream which has a concept of a current value to help when combining with other Bacon.Properties using binary functions. (It prevents misleading updates in diamond shaped data paths, There is a helpful section called "Why is my property not updated somewhere in the baconjs FAQ.)

So when you comment in the synchronous subscription of derived (your Property), derived maintains a current value, which is later, when the async subscription kicks in, reproduced.
As explained in my first point the sync subscription of the base boolStream ( a Bacon.EventStream) causes the producerFn to produce values - but without any subscription to the derived Bacon.Property that pipeline is completely dead (or lazy) and those early produced values  are nowhere buffered or stored.
Does that make sense?
P.S. It's always beneficial to ponder a little if my data stream is an event stream or a property stream.

Thank you now it's clear! The moment when a subscription is reaching through first to boolStream  matters. So when boolStream is a property like here https://jsfiddle.net/4b6j0Lvo/1/ then at the time of the async subscription to derived boolStream has a latest value and produces the result I expected.


How to hidden the error: WARN: A->p (column pointers) not strictly increasing, column X empty?

Problem Background
I'm currently working on some problems with quantum computing, and I need to solve SDP involving complex matrices. I also browsed related issues before(https://github.com/cvxpy/cvxpy/issues/481), but found that his issue is not quite the same as mine.
My program does not fail, and the results are as expected. But the annoying WARN always pops up when the program is running.
Below is my code.
My Code
import numpy as np
import cvxpy as cp
import asm
import math

def solve_SDP(assemblages):

    # Generate variables
    variables = []
    for i in range(2):
        temp = []
        for j in range(2):
            temp.append(cp.Variable((2, 2), hermitian=True))
        variables.append(temp)

    # Create the objective function
    obj_func = assemblages[0][0] @ variables[0][0] + assemblages[0][
        1] @ variables[0][1] + assemblages[1][0] @ variables[1][
            0] + assemblages[1][1] @ variables[1][1]
    obj_func = cp.real(cp.trace(obj_func))

    # Create constraints
    constraints = [
        cp.real(
            cp.trace(variables[0][0] + variables[0][1] + variables[1][0] +
                     variables[1][1])) == 0.5
    ]
    constraints += [
        variables[0][0] + variables[1][0] >> 0,
        variables[0][0] + variables[1][1] >> 0,
        variables[0][1] + variables[1][0] >> 0,
        variables[0][1] + variables[1][1] >> 0,
    ]

    # Problem solving
    prob = cp.Problem(cp.Minimize(obj_func), constraints)
    prob.solve()

    return prob.value

if __name__ == '__main__':
    w = 0.5
    N = 1
    flag = False
    psi = np.array([math.sqrt(2) / 2, 0, 0, math.sqrt(2) / 2])
    rho = np.multiply(w, np.outer(psi, psi)) + np.multiply((1 - w) / 4, np.eye(4))

    for tries in range(N):
        observables = []
        for k in range(2):
            observables.append(asm.get_observable())

        projectors = asm.get_projectors(observables)
        assemblages = asm.get_assemblages(projectors, rho)
        if solve_SDP(assemblages) < 0:
            flag = True
            break

    if flag:
        print('Steerable')
    else:
        print('Unsteerable')

Output
WARN: A->p (column pointers) not strictly increasing, column 3 empty
WARN: A->p (column pointers) not strictly increasing, column 6 empty
WARN: A->p (column pointers) not strictly increasing, column 10 empty
WARN: A->p (column pointers) not strictly increasing, column 13 empty
WARN: A->p (column pointers) not strictly increasing, column 17 empty
WARN: A->p (column pointers) not strictly increasing, column 20 empty
WARN: A->p (column pointers) not strictly increasing, column 24 empty
WARN: A->p (column pointers) not strictly increasing, column 27 empty
Unsteerable

These WARNs always pop up every time I run the program, and every time the WARN pops up is exactly the same.
So, how can I hide these errors? Because they affect the aesthetics and prevent me from seeing the results.
Version

OS: Windows 11
CVXPY Version: 1.1.18
Python Version: 3.9.7

Also, my IDE is Visual Studio Code and using anaconda environment.

The warnings are coming from the solver SCS (https://github.com/cvxgrp/scs). You might want to raise an issue on their repo. You could also try using another SDP solver like Mosek.

After I install Mosek using command conda install -c mosek mosek, I always get an error when I run my program on VS Code:

After I install Mosek using command conda install -c mosek mosek, I always get an error when I run my program on VS Code:
(CVXPY) Jan 10 09:24:47 AM: Encountered unexpected exception importing solver MOSEK:
ImportError('DLL load failed while importing _msk: 找不到指定的模块。')

How to deal with it?


Clicking a link at the patient archives leads to inexistent page and requires a full reload

Lead to reproduce this with qcl

This issue is not reproduceable


FlareReplacer netkan

Could these have more differentiated abstracts, so users have some basis for choosing one of them?

I mean, not really. They are sun flares and describing them will be even more confusing as some have the same characteristics as others. They can’t be categorized by color either because they are all white or greyscale, and the color is changed by a cfg in the download. There is an image of each flare inside each zip. If the user doesn’t like it, I don’t think it’s that big of an inconvenience to download another flare at that’s less than 2mb in dl size. Do you have any suggestions? I figured doing it by name would suffice. What would be really cool is if CKAN could add a small thumbnail in a tab next to “Versions”. That’s a long shot, I’m sure, but could be helpful.

Can you add a link to the forum thread via:
    "resources": { "homepage": "url here" },

Then maybe folks could browse the images.

I can do that. I think what I will do also is compile all the flares into a single zip. This will give them all of the flares, and from there, they can swap them out without having do download them again, instead they will be cached for them., maybe thats not the best way to do it though.
There is now a grand total of 15 flares for people to choose from... I think individual zips will get out of hand...

Thinking about it, I don't think there is a way to to get these on CKAN without spamming the UI with all these entries. With 15 now, its ridiculous. I don't think I'll add these after all, unless you guys dont have an issue with a ton of flares on CKAN?

Personally it doesn't bother me as long as there's some way for people to tell them apart. :)
But if you want to limit it, maybe take a vote on your forum thread and list the top three?


unable to run test.py file

Even After properly doing make unable to run test.py file:
getting this stacktrace
Traceback (most recent call last):
File "/home/rajeev/pb/ds3/libs/warp-transducer/pytorch_binding/test/test.py", line 17, in
from warprnnt_pytorch import RNNTLoss
ModuleNotFoundError: No module named 'warprnnt_pytorch
Any help on this??

getting this stacktrace when doing python setup.py install:
running install
running bdist_egg
running egg_info
creating warprnnt_pytorch.egg-info
writing warprnnt_pytorch.egg-info/PKG-INFO
writing dependency_links to warprnnt_pytorch.egg-info/dependency_links.txt
writing top-level names to warprnnt_pytorch.egg-info/top_level.txt
writing manifest file 'warprnnt_pytorch.egg-info/SOURCES.txt'
reading manifest file 'warprnnt_pytorch.egg-info/SOURCES.txt'
writing manifest file 'warprnnt_pytorch.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
creating build
creating build/lib.linux-x86_64-3.6
creating build/lib.linux-x86_64-3.6/warprnnt_pytorch
copying warprnnt_pytorch/init.py -> build/lib.linux-x86_64-3.6/warprnnt_pytorch
running build_ext
building 'warprnnt_pytorch.warp_rnnt' extension
creating build/temp.linux-x86_64-3.6
creating build/temp.linux-x86_64-3.6/src
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/home/rajeev/pb/ds3/libs/warp-transducer/include -I/home/rajeev/environments/ds3/lib/python3.6/site-packages/torch/lib/include -I/home/rajeev/environments/ds3/lib/python3.6/site-packages/torch/lib/include/torch/csrc/api/include -I/home/rajeev/environments/ds3/lib/python3.6/site-packages/torch/lib/include/TH -I/home/rajeev/environments/ds3/lib/python3.6/site-packages/torch/lib/include/THC -I/home/rajeev/environments/ds3/include -I/usr/include/python3.6m -c src/binding.cpp -o build/temp.linux-x86_64-3.6/src/binding.o -std=c++11 -fPIC -DWARPRNNT_ENABLE_GPU -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=warp_rnnt -D_GLIBCXX_USE_CXX11_ABI=0
In file included from /home/rajeev/environments/ds3/lib/python3.6/site-packages/torch/lib/include/THC/THCGeneral.h:12:0,
from /home/rajeev/environments/ds3/lib/python3.6/site-packages/torch/lib/include/THC/THC.h:4,
from src/binding.cpp:8:
/home/rajeev/environments/ds3/lib/python3.6/site-packages/torch/lib/include/ATen/cuda/CUDAStream.h:6:30: fatal error: cuda_runtime_api.h: No such file or directory
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

I have the same problem with you. fatal error: cuda_runtime_api.h: No such file or directory.

Please refer to this issue: fatal error: cuda_runtime_api.h: No such file or directory

It's working! Thank you so much.


python3.pkgs.scipy: use pytestCheckHook && python3.pkgs.numpy: small cleanup

Related to: #255262 .
Haven't tested this change yet., will undraft this when it is tested.
Description of changes
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I built scipy locally, and tests seem to take long, but I'm not sure. Having another eye on this would be nice. pytest-xdist is used, and -m not\\ slow is also used, like in Numpy.

I'm closing, as this seems fixed scipy's 1.12.0rc2 . I'll open a new PR with other updates as well when the time comes.


[debian system builder] Compile with gcc7

The build script that is generated by debian_system_builder currently
compiles OpenR and the dependencies with gcc5. It seems that at least
some of the dependencies require at least gcc7. Update the
debian_system_builder to use gcc7 by default.

I've totally redesigned this and you should be able to build with the way #61 (docker) and our GitHub actions build using getdeps.py.


flowhub runtime discovery down?

NoFlo runtime listening at ws://<IP_ADDRESS>:3569
Using /home/ensonic/projects/noflo-nodejs-test for component loading
...
but nothing shows up in the UI (http://app.flowhub.io/#). Tried local or public up addresses. This happens for at least two days now. If everything looks good on the flowhub site, any ideas how to debug this?

Probably was a glitch.


Support for unconditional training

This PR is for discussing how best to re-enable support for training models without a text prompt.
Currently, training a model using this repo is coupled with requiring an embedder. When training unconditional models, the embedder is not necessary.
In the initial version of this PR, the code which causes the coupling has been commented out. Hopefully this opens a discussion on how best to add support for unconditional training back into the repo.
I've used the lsun churches dataset as an application for this PR. The relevant config file is: configs/latent-diffusion/lsun_churches-ldm-kl-8.yaml
The key changes to note:

main.py requires a personalization_config in a .yaml file. The personalization_config seems to be where we pass language specific parameters (lines 713-725 in dev // 720-732 in my PR)
Multiple lines in ddpm.py have been commented out. The lines which have been commented out is the conditional language coupling mentioned above.

To re-support unconditional training, 2 things need to happen:

main.py needs to do its assignments to config.model.params.personalization_config only if personalization_config is present in the config yaml file
The commented out code in ddpm.py should only run if conditional language coupling has been specified by the user of the system

My proposal is to check for the existence of personalization_config in the .yaml file. If it exists, the code can run as is (in main or dev). If the key doesn't exist, then we can use that to infer that we're not in the conditional language setting and set a flag in ddpm.py to not run the language-specific code.
One thing to mention... I eventually want to add support for using an image as a prompt instead of language. If you would like this feature in this branch, then these changes will likely need to be revisited if/when I start working on that

By the way - the model is currently training. But I have no idea if it'll produce useful results or not for a little while longer (15k steps in and I'm still just seeing noise)

If someone could provide an example of a train/loss they've trained from this repo that'd be valuable. So far the changed code seems to be giving this which seems undesirable (I'll post an update here after a couple thousand iterations have completed):

I really appreciate your taking this on. Model training is an important feature that has been largely neglected in this repo. Since this PR is primarily for discussion, I'm going to mark it draft until it reaches a more mature point.

Thanks. I'm looking forward to contribute more :).

I just trained another model, this time with more frequent logs.
The model seems to be learning properly until around step 3650. After this step, it goes back to generating pure noise:
Step 3250:

Step 3750:

Loss curve:

Any progress on tracking down the scheduler issue?

Apologies - I only have 1 GPU I can train this on so experiment speed is a bit limited.
But no - I haven't been able to debug why this is happening.
I've taken a look at how the scheduler changes the LR and everything there seems to be fine/make sense. I've trained some models without a scheduler but also using the LR that causes this instability. These models seem to train fine.
None of the other config files actually use a scheduler (even the lsun bedrooms file). I wonder if this was left there by mistake..
I'm going to remove the scheduler from this config file and implement the changes to I suggested in the OP

I've continued to play around around with the scheduler. If you change warmup steps in the config to any non-zero number you'll be able to see this issue quicker. For example, changing warmup steps to 10 will show the instable loss after 10 steps. I've also tried using an l2 loss instead of l1 but this makes no difference.
I'm baffled by this. But removing the scheduler from the config seems to lead the model to train.
Anyway. This PR is ready for review now. I can also add to the README instructions on how to train the model for this dataset

Is this PR still a draft, or is it ready for testing and review?

@nihirv There hasn't been any activity on this PR in 9 days and it is still marked as draft. I'm going to close it now and will happily reopen it if you let me know.

Hi @lstein. Apologies - I seem to have missed the notification that you sent me last week.
PR is ready to review and can update it as needed


Vocoder Fine-Tuning produces an error during the evaluation

To begin, very good work I found the software very easy to use and the documentation is perfect.
For the problem, when I am in the "Vocoder Fine-Tuning" phase the program displays two errors in popup just after the "Evaluating". I tested on two different datasets but each time I get the error

I don't always get the error message but it was a pystoi issue :

I just saw that the main branch is much more advanced and the bug is surely fixed (when will it be released?)


User component config does not override default component config

I believe it’s because of the missing line I have placed in this commit

:tada: This PR is included in version 0.7.18 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add secret-operator

Depends on https://github.com/stackabletech/secret-operator/pull/64

R4R now that https://github.com/stackabletech/secret-operator/issues/64 is merged.

bors r+

This will also require adding it to the menu, right? I believe it's not there at the moment.

That's correct, since the menu is controlled by the UI bundle… :/


All Add-ons from a collection are marked added to a chosen collection in the "Add to collection" list even if just one Add-on was added

Steps to reproduce:

Load AMO-stage page https://addons.allizom.org/en-US/firefox
Go to any collection details page (i.e. https://addons.allizom.org/en-US/firefox/collections/ValentinaStage/012354/ )
Choose any addon and click “Add to collection” icon
Add the add-on to any collection (i.e. Summer)
Check another add-on “Add to collection” affiliation list (i.e. Menu Wizard)

Expected results:
The other add-on is not added to the collection that first add-on was.
Actual results:
All add-ons from that collection are added to the collection that first addon (from step 4) was added.
Notes/Issues:
In AMO production an add-on from a collection can belong just to one collection. (don't know if this behavior is intended)
Verified on Ff43(Win 7). Issue is reproducing on AMO-stage, AMO-dev and AMO-prod.
Screencast for this issue: http://screencast.com/t/UsvPQIm7m7Nc

This issue can be expanded to: adding an add-on to a collection (bu clicking the "add to collection" link from add-on details page) makes all add-ons accessed afterwards appear to be added to that collection, even if, when accessing the collection, only the first add-on appears. (http://screencast.com/t/JUMRtRGvV1L)


Carthage will not checkout Realm 2.8.x

Goals
I use Carthage for packet management and wanted to upgrade from Realm 2.7.0 to 2.8.3. So I changed the version in cart file.
Expected Results
When I do carthage update --platform iOS it should download Realm 2.8.3
Actual Results
When I set the cart file to use github "realm/realm-cocoa" == 2.8.3, carthage will log *** Checking out realm-cocoa at "v1.1.0-3". Also the update will never complete.
When I  change that to github "realm/realm-cocoa", carthage will download Realm 2.7.0
I looks like the 2.8.x versions are not correctly linked to be pulled by carthage.
I did of course try to clean the Carthage output folder. But it did not have any effect.
Steps to Reproduce
Load Realm 2.8.x using Carthage.
Version of Realm and Tooling
Realm framework version: 2.8.3
Xcode version: 8.3.3
iOS/OSX version: 10.12.5
Dependency manager + version: Carthage 0.24.0

I can't reproduce this:
$ carthage version
0.24.0
$ echo "github \"realm/realm-cocoa\"" > Cartfile
$ carthage update --platform iOS
*** Fetching realm-cocoa
*** Downloading realm-cocoa.framework binary at "v2.8.3"
*** xcodebuild output can be found in /var/folders/tv/cc131sv94cv_xk5bzg81559r0000gn/T/carthage-xcodebuild.nQZ701.log

Thanks for checking @jpsim. You are right. This is not a general problem but actually specific to my setup. I did a lot of testing and finally found out the this issue appears because I have another dependency in Carthage that depends on Realm 2.7.0. Obviously Carthage will not pull newer versions than the lowest version of any dependency.
Anyway, this is not a Realm issue but a Carthage issue.


Error when adding more than three ViewControllers in "TinderStoryboard" example project

Hi !
I have successfully run the project example in my iPhone but the problem appears when I try to add another UIViewController to the "TinderStoryboard" example project.
I have put  sl_3  into the storyboardSegue in the fourth UIViewController.

Anyone know the cause of this problem ? Thanks.

Hi @LuiggiMS
I fixed the bug ecb84f80dcbc145cb35211c2c29ba06c717ab3aa.
Actually the method which add all views didn't sort views by index, thus it crashed but only using Auto Layout because it try to make a constraint with some views that weren't existing yet.

Thanks a lot :smiley:


Fuel Control menu bug - Won't go back to Fuel Control menu upon exit

Reproduce:
Attempting to exit out of a fuel control menu option such as display or modify should go back to the main fuel control menu, but instead it goes back to the controls menu.
Root cause:
Error in UI code most likely something to do with the continues in the while loop for the menu display.
Location:
Autopilot.cs

Solution: Incorrect variable name was used for the menu option if condition which caused it to always go to that option instead of checking for others. Replaced that variable with the correct one and tested the menu - everything works as it should now.
Version: 1.0


Geth node disconnects after 15 seconds with snappy: corrupt input

Describe the bug
When testing a long-lived connection with a geth node, we always disconnect after 15 seconds. Some context: we pass the handshake and the eth/67 protocol is registered, and the geth node starts sending transactions. We also respond to the checkpoint challenge (geth link), but unless that message somehow doesn't go through that also can't be the problem. In the node logs section below you can see the 2 log traces, the important error seems to be snappy: corrupt input.
Steps to reproduce
Start the network with an up-to-date status message and an eth message handler in place to respond to checkpoint challenges
Node logs
Geth
Dec 21 09:13:18 beast geth[46660]: DEBUG[12-21|09:13:18.911] Adding p2p peer                          peercount=4 id=9a3c8299e4f49e20 conn=inbound         addr=<IP_ADDRESS>:58256    name=reth/v0.1.0
Dec 21 09:13:18 beast geth[46660]: TRACE[12-21|09:13:18.911] Starting protocol eth/67                 id=9a3c8299e4f49e20 conn=inbound
Dec 21 09:13:18 beast geth[46660]: DEBUG[12-21|09:13:18.913] Ethereum peer connected                  id=9a3c8299e4f49e20 conn=inbound         name=reth/v0.1.0
Dec 21 09:13:18 beast geth[46660]: TRACE[12-21|09:13:18.913] Registering sync peer                    peer=9a3c8299
Dec 21 09:13:18 beast geth[46660]: DEBUG[12-21|09:13:18.914] Fetching batch of headers                id=9a3c8299e4f49e20 conn=inbound         count=1   fromnum=14,811,135 skip=0 reverse=false
Dec 21 09:13:18 beast geth[46660]: TRACE[12-21|09:13:18.914] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=391
Dec 21 09:13:19 beast geth[46660]: TRACE[12-21|09:13:19.160] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=2
Dec 21 09:13:20 beast geth[46660]: TRACE[12-21|09:13:20.538] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=82
Dec 21 09:13:20 beast geth[46660]: TRACE[12-21|09:13:20.538] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=31
Dec 21 09:13:20 beast geth[46660]: TRACE[12-21|09:13:20.809] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=3
Dec 21 09:13:20 beast geth[46660]: TRACE[12-21|09:13:20.809] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=5
Dec 21 09:13:21 beast geth[46660]: TRACE[12-21|09:13:21.378] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=5
Dec 21 09:13:21 beast geth[46660]: TRACE[12-21|09:13:21.378] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=2
Dec 21 09:13:22 beast geth[46660]: TRACE[12-21|09:13:22.374] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=3
Dec 21 09:13:22 beast geth[46660]: TRACE[12-21|09:13:22.374] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=2
Dec 21 09:13:23 beast geth[46660]: TRACE[12-21|09:13:23.387] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=8
Dec 21 09:13:23 beast geth[46660]: TRACE[12-21|09:13:23.387] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=4
Dec 21 09:13:24 beast geth[46660]: TRACE[12-21|09:13:24.386] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=5
Dec 21 09:13:24 beast geth[46660]: TRACE[12-21|09:13:24.386] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=2
Dec 21 09:13:25 beast geth[46660]: TRACE[12-21|09:13:25.407] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=7
Dec 21 09:13:25 beast geth[46660]: TRACE[12-21|09:13:25.407] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=17
Dec 21 09:13:26 beast geth[46660]: TRACE[12-21|09:13:26.480] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=49
Dec 21 09:13:26 beast geth[46660]: TRACE[12-21|09:13:26.480] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=18
Dec 21 09:13:27 beast geth[46660]: TRACE[12-21|09:13:27.424] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=14
Dec 21 09:13:27 beast geth[46660]: TRACE[12-21|09:13:27.424] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=4
Dec 21 09:13:28 beast geth[46660]: TRACE[12-21|09:13:28.425] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=15
Dec 21 09:13:28 beast geth[46660]: TRACE[12-21|09:13:28.425] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=1
Dec 21 09:13:29 beast geth[46660]: TRACE[12-21|09:13:29.422] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=2
Dec 21 09:13:29 beast geth[46660]: TRACE[12-21|09:13:29.422] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=2
Dec 21 09:13:30 beast geth[46660]: TRACE[12-21|09:13:30.428] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=8
Dec 21 09:13:30 beast geth[46660]: TRACE[12-21|09:13:30.428] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=3
Dec 21 09:13:31 beast geth[46660]: TRACE[12-21|09:13:31.479] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=1
Dec 21 09:13:31 beast geth[46660]: TRACE[12-21|09:13:31.479] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=4
Dec 21 09:13:32 beast geth[46660]: TRACE[12-21|09:13:32.967] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=1
Dec 21 09:13:32 beast geth[46660]: TRACE[12-21|09:13:32.967] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=8
Dec 21 09:13:33 beast geth[46660]: TRACE[12-21|09:13:33.735] Sent transactions                        id=9a3c8299e4f49e20 conn=inbound         count=2
Dec 21 09:13:33 beast geth[46660]: TRACE[12-21|09:13:33.735] Sent transaction announcements           id=9a3c8299e4f49e20 conn=inbound         count=13
Dec 21 09:13:33 beast geth[46660]: DEBUG[12-21|09:13:33.919] Message handling failed in `eth`         id=9a3c8299e4f49e20 conn=inbound         err=EOF
Dec 21 09:13:33 beast geth[46660]: DEBUG[12-21|09:13:33.919] Removing Ethereum peer                   peer=9a3c8299 snap=false
Dec 21 09:13:33 beast geth[46660]: TRACE[12-21|09:13:33.919] Unregistering sync peer                  peer=9a3c8299
Dec 21 09:13:33 beast geth[46660]: DEBUG[12-21|09:13:33.919] Removing p2p peer                        peercount=3 id=9a3c8299e4f49e20 duration=15.008s      req=false err="snappy: corrupt input"

Reth
2022-12-21T09:13:33.877377Z DEBUG net::session: eth stream completed remote_peer_id=0xabcd
2022-12-21T09:13:33.877461Z TRACE net::session: gracefully disconnected active session. peer_id=0xabcd
2022-12-21T09:13:33.877479Z TRACE net: Session disconnected remote_addr=<IP_ADDRESS>:30303 peer_id=0xabcd total_active=0 error=None

Platform(s)
MacOS (Silicon)
Code of Conduct

[X] I agree to follow the Code of Conduct

thanks for raising this, this should help us track down the issue


Run an audit fix

AFAIK this doesn't affect anything in the actual sb-edit library; it just fixes some vulnerabilities in out of date, relatively deep dependencies of jest.
added 494 packages from 451 contributors and audited 876444 packages in 18.386s
found 3 high severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details

^ I wrote fixes #3 but that was the wrong number :P Meant to write #6...


Fix for macOS build action

Updating python version to fix build

This fixed previously failing step of installing python, but now ffmpeg install from FedericoCarboni/setup-ffmpeg fails on ARM macs. There is an active issue in the action repository. If resolved, this action should be re-run.

@chidiwilliams at some spare moment, please take a look at the failing check.
security import $CERTIFICATE_PATH -P "$P12_PASSWORD" -A -t cert -f pkcs12 -k $KEYCHAIN_PATH

This line in macOS bundle creation fails with error security: SecKeychainItemImport: One or more parameters passed to a function were not valid. Feels like one of the security parameters might be wrong.


elasticsearch-jdbc-<IP_ADDRESS> No lib folder?

elasticsearch-jdbc-<IP_ADDRESS>.tar.gz don't have lib folder!
Why?
so how can I import MySql data use my.sh which will use lib folder in linux OS.
anyone could help me out ?
thanks very much.

There is no tar.gz
Can you please use elasticsearch-jdbc-<IP_ADDRESS>-dist.zip in folder http://xbib.org/repository/org/xbib/elasticsearch/importer/elasticsearch-jdbc/<IP_ADDRESS>/ ?

thanks @jprante . I found the lib folder. But when I use run sh my.sh. I got the following error:
Exception in thread "main" java.lang.UnsupportedClassVersionError: org/xbib/tools/Runner : Unsupported major.minor version 52.0
could you help me out, please?

@jprante Thanks a lot.

Accidentally, this release is compiled only for Java 8 Runtime. Please use JDK 8.

@jprante yeah, I found it. Thanks for your help.


[feature]:  Toast notifications

The toast notifications feature is required on the website.
The toast notification can be generated on following events.

From frontend actions (eg. send toast notification if user clicks on reset button)
From API response (eg. A form is submitted successfully/ failed)

The toast notification should have a different icon for success, failed, working and info.

Close button is required on toast notifications


Do the tasks continue to run if the application enters background?

And if they do, for how long?
It seems to me that the queue is subject to the limited time given by iOS to tasks created by application.beginBackgroundTaskWithExpirationHandler, since there is no additional setup required to use it.

yes, all code in your app is subject to the time that the OS gives to your app. If the OS deactivates your app there's no way to do more work


feat(iroh, iroh-gossip): introduce log-self feature

Description
Aff a feature flag to turn on logging our own peer_id in short form and plug this in in sync, gossip and the downloader. This is enabled by default (not sure if we want this for releases thought. Having it as a feature flag at least gives us the option to chose.
This is what I did to debug #1531 and it was really useful
Notes & open questions
Log sample:
Sync
2023-09-28T20:51:18.908126Z DEBUG sync{me=oywqb57ovmdry243}: iroh::sync_engine::live: sync[dial]: start namespace=NamespaceId(q47zmyim5r6isz22…) peer=PublicKey(2jnygwapdm26wwa2) reason=DirectJoin last_state=None

Gossip
2023-09-28T20:58:42.854730Z DEBUG gossip{me=zooj7iazcl7rsoal}: iroh_gossip::net: handle out_event EmitEvent(TopicId(wno5nwxtkhhtnqsm…), Received(GossipEvent { content: <33b>, delivered_from: PublicKey(7a7kkzndvbt6eulu), scope: Neighbors }))

Downloader
2023-09-28T21:00:11.107411Z DEBUG downloader{me=4vabufwku3wselbl}: iroh::downloader: download completed peer=2jnygwapdm26wwa26tvcprm3m5vqajmhwz7lx5xizwx637ad5sea kind=Blob { hash: Hash(224746ea89d286220e0770f89cda2ab138143b00e384dd795d5a13b77b094822) }

Change checklist

[x] Self-review.
[ ] Documentation updates if relevant.
[ ] Tests if relevant.

This might / will be PII eventually, so having the option to scrub it is nice.

This might / will be PII eventually

unlikely, peerids are sent over the network and shared as identifiers.
if we really need to scrub PII we should do so on themlog storage side, as there is already much more in the logs, like ip addresses

Yeah, let's add this. Test logs with multiple nodes are basically unusable without. I did parts of this in #1530 but let's get this in!
@flub has more experience with tracing then I do so don't have much to add on the implementation front.

can people comment on deciding to make this a compile time flag? @Frando @dignifiedquire @flub (heck we are four here let's just bring @ramfox  and @b5 ) my thinking is that logs are already very hard to read.  Your own peer id is useful only when you are dealing with multiple nodes in the single run.
This is not the case of users in general, and I would not include this in release builds by default for example. Basically I think it's very nice to be able to have cleaner logs by just removing a feature because this adds "a lot" to already noisy logs

agreed feature is not necessary

agreed feature is not necessary

for completeness: everyone agreed the logging added here is super useful and we should totally have it.  but we prefer it always-on, so without the crate-level feature to control it.
i don't mind if you want to re-open this and remove the crate-feature or re-create the PR.  though I think it's a reasonable refactor to do to this PR so re-opening might be easier.


Hyundai Longitudinal: Display personality in instrument cluster

Displays Longitudinal Personality with 2nd, 3rd, and 4th bar.
Requires

https://github.com/commaai/openpilot/pull/31760

untested YOLO

untested YOLO

I've been using it for months! #trust :heart: