Build an iOS app - gltf viewer that can load from an opensea based contractid where a gltf object is used

These are the features needed

[ ] a gltf viewer
[ ] forced to use landscape mode
[ ] doesn't go into screenlock or low power
[ ] user can move the object in the viewer
[ ] user can double tap on the screen to open an input field where the user can type in / paste in an NFT contract address from opensea and load the item
[ ] load errors are handled with a dialog message explaining the issue
[ ] uses the opensea api

My recommendation is to use: https://github.com/google/filament/tree/main/ios/samples/gltf-viewer
which can be built according to mac/ios instructions here: https://github.com/google/filament

You can get started simply by building the gltf viewer application.  Once you have that figured out and have it running (it's just the sample code posted above), figure out how to isolate the library code build for filament, and checkin the viewer code into this software repository.

I will provide more specs on the software integration with opensea in another issue.

Going to use the boilerplate instructions, just to get the filament app set up https://google.github.io/filament/posts/cocoapods/
I believe we can just use the existing sample for the filament code.

Code is now checked in.  I'll add an issue to add a URL loader (it seems to have one partially implemented but not implemented).  Then I'll add the opensea loader from a contract.  And then NFC based contract assets addresses.

Need to experiment with the landscape mode.


feat: Add example helm chart for non-secure and secure modes

Signed-off-by: Leonard Goodell<EMAIL_ADDRESS>

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] I have added unit tests for the new feature or bug fix (if not, why?) N/A for deployment example
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions
See README

Caveat: These helm charts assume a single worker node.  There should probably be some node placement constraints to enforce this, at least initially, so that support for distribution can be added on a service-by-service basis.

Do we have enough approvals to merge?

@bnevis-i,  Waiting on feedback from Matts from Intel.

Do we have enough approvals to merge?

@bnevis-i, Waiting on feedback from Matts from Intel.

Sorry for the delay, reviewing now.


DEV 8543.3 Add logic in dashboardCtrl to generate uuid, which will be sent to the API while POSTing /api/systemNodes.

https://github.com/Shippable/pm/issues/8543

this is not required, closing


[Enhancement]: 3D box game not available

Do you want to have the enhancement of existing game ? 😀 Describe yourself..
Game enhancement: The 3D box game should not appear at the dashboard, if it is not available.
Uploading GameZone - Google Chrome 2024-06-03 22-33-39.mp4…
Describe the solution you'd like
finding out the game, check if available..
If not available, comment out the part making 3d box appear to dashboard
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @anisharma07 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @anisharma07 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Why cannot webstore detect ungoogled-chromium exactly?

So someone mentioned that UC cannot install extensions from webstore and I tried with vanilla UC on Windows and Arch and both of them can be recognized by webstore.
I searched through the issues here and all I can find is issues about drag&drop of crx files, like #1009, #988 and #923, but there is no explanation why exactly webstore cannot detect the browser. I have seen in this issue that it may have something to do with safe browsing, does this mean it is unfixable without enabling safe brwosing?
To put it simple, is it:

unsolvable? or
no one looked into this before? or
against the goal of the project so it is not fixed?

AFAIK it cannot download extensions from webstore as the URLs are obfuscated in source code. It can however install extensions as .crx files. This is also possible to accomplish with a custom search, which downloads extension.

I think it is not about downloading? Because on the webstore page usually you will see the button Add to Chrome but in UC you will get Available on Chrome which means it is not recognized as chromium at all.

hmm. I have just tried opening webstore in ungoogled-chromium aaaand… guess what?

Surprise! Not only it is detected as Chromium, but it does try to install an extension and succeeds!
Is something changed or my build gone bad? Is it a bug instead?
@jstkdng , please try this in Arch.
@braewoods , please try this in Debian.

I'd be commiting heresy, but works on my machine™

Strange, it doesn't work here. 83.0.4103.61-1 built from AUR.

@wchen342 are you testing on a clean profile?

No, but I tested a clean installation of @braewoods' binary 81.0.4044.138-1 on bionic and it still doesn't work.

okay, just tried on a clean profile and I can confirm it isn't working, not even a button appears for me

Interesting, now I wonder how your old profile actually made it work.

It's been a while, but I believe this is because of patches/core/ungoogled-chromium/disable-webstore-urls.patch.
IIRC, the "Add to Chromium" button is provided by NeverDecaf's chromium-webstore extension. In regular Chromium, it would be "Add to Chrome".
Ideally we would re-enable detection in the Webstore, and use #285 to fix installations. I'd like to use #285 to re-enable extension installation because it allows us to not hardcode webstore URLs, and would enable users to install from non-Webstore sources (which is what NeverDecaf's extension does when it self-updates).

Might I add, had to reinstall Arch because of new hardware so had to configure a new profile, and for sure, the same thing happened as my previous comment, the thing is, after installing chromium-webstore, the 'Add to Chromium' button appears as expected and I'm able to install extensions normally. So yeah, works on my machine™ still stands

@jstkdng Well I was asking i the case you didn't add anything, just the plain browser. The extra extension has two problems for me to include in my Android version:

It needs to be bundled with browser and I am not sure it works the same on Android
It will make the function dependent on a third party to update their code

So I wonder if there is a native way to solve this that only involves changes in C++ codes.

Isnt chromium webstore feature complete? only change could be is that google changes something on their part.

@jstkdng What do you mean?
In the case you don't install that extension you won't get the button right?

@wchen342
yeah, the store recognizes ungoogled chromium as if I was running android. Maybe a user-agent issue?
Also, does the extension-mime-request-handling flag not work under android? Then someone could install chromium-webstore using file:/// on the search bar.

Maybe a user-agent issue?

No. I tried desktop UA, it didn't work.

Also, does the extension-mime-request-handling flag not work under android? Then someone could install chromium-webstore using file:/// on the search bar.

I just made that work in last version so theoretically, yes. But I think a more elegant way is I either bundle chromium-webstore or somehow make this works natively, which is way I'm asking here.

Hmm, if I remember correctly, chromium used to inject some extensions related to crypto I think. We could inject chromium-webstore that way, but that should be done here, and not only under ungoogled-chromium-android. Android should first get extension support.

Android should first get extension support.

I've already adapted that from Kiwi: https://github.com/ungoogled-software/ungoogled-chromium-android/tree/extensions#extensions. Someone was using the extension-support version which is why the question was raised.

if I remember correctly, chromium used to inject some extensions related to crypto I think.

Yeah that's what I am thinking how it can be done. I just don't know how hard it is to keep chromium-webstore maintained between versions.

And there comes my comment, chromium-webstore is feature complete, at least according to NeverDecaf, can't you inject the latest working version and if something breaks, the user could disable the built in extension and install a the new one from NeverDecaf's releases until it is updated on this side.

Ok I tried to install chromium-webstore directly from github release but it doesn't work. I think it is because there is no metadata for the crx file (no extension id, etc.), which means whoever want to use it needs to load the source code manually which is a huge hassle especially on Android 10.
Is the author @enolgor? Do you have any idea whether this can be solved?

@NeverDecaf is the developer of chromium-webstore.
I also tried to install it but no use, could be an issue on android as chromium-webstore installs without any problem.

@NeverDecaf is the developer of chromium-webstore.
I also tried to install it but no use, could be an issue on android as chromium-webstore installs without any problem on pc.

I suppose on pc you drag-and-drop it according to Readme. That is not possible on Android so installing from url or load using developer mode are the only two possible ways.

So I tried install chromium-webstore with extension-mime-request-handling and obviously it doesn't work even on desktop. I think the crx file lacks some critical things so that chromium does not consider it as a complete extension file at all.

So I tried install chromium-webstore with extension-mime-request-handling and obviously it doesn't work even on desktop.

If you mean you're trying to use a HTTP/HTTPS link in the Omnibar to install Chromium Web Store, then this also fails for me on desktop. Otherwise, could you clarify what you mean?

It works for me by dragging and dropping the crx into chrome://extensions or the file:/// protocol on desktop, how did you try to install @wchen342 ?

If you mean you're trying to use a HTTP/HTTPS link in the Omnibar

Yes, that's what I meant.

It works for me by dragging and dropping the crx into chrome://extensions

As I said above, this is not possible on Android so I need the omnibar way to work.

well, I told you what worked for me on desktop.
BTW, I found this: https://stackoverflow.com/questions/50125821/standard-way-to-build-a-chrome-extension-into-chromium
We could use that to bundle chromium-webstore. Might need a few changes as it is a bit outdated.

Interesting, I will try that out. Though I think if it is not too hard to get an id for chromium-webstore that will be an easier solution.

I'm not sure how extension signing works on chromium so can't really say anything.
If we want to bundle the crx we might need to modify the scripts in here to copy files to chromium source dir and not just patching. What do you think @Eloston ?

One minor correction: chromium-webstore does have an id assigned, but there are some other stuff missing. Probably hash?

Another solution is to embed the extension source code in place of chrome/browser/resources/webstore_app/
Or maybe add another extension like the numerous others in chrome/browser/resources, including but not limited to:

cryptotoken
cloud_print_app
help_app
settings
network_speech_synthesis
pdf
media/mei_preload
chrome_app
feedback

Not sure what C++ code is required to make this work though; it's possible using the default_extensions mechanism described above is simpler/more robust.

If we want to bundle the crx we might need to modify the scripts in here to copy files to chromium source dir and not just patching. What do you think @Eloston ?

No need to do that. I imagine this is an Android-specific change, so all you'd need to do in Android is copy the files (either the CRX or the extension source code) after you apply patches (and not before, because you probably don't want to accidentally apply patches to files you just copied in).

It is a little more complicated than that. The way @jstkdng mentioned only works on windows (I check the gn files). I know pdf and cloud_print is considered "plugins" and is separate from extensions. I haven't found where cryptotoken is included though but that's the best bet because I remember it is in the extension page for vanilla chromium.

I didnt see any windows only stuff on that link appart from the gn check but cant that be removed altogether?

The default_extensions target is included in chrome/installer/mini_installer/BUILD.gn which is used in template of mini_installer that is windwos specific (it generates a bunch of dll files).

Strange, I cannot find cryptotoken. All I can find is the api itself which are C++ codes.

I haven't found where cryptotoken is included though but that's the best bet because I remember it is in the extension page for vanilla chromium.

A quick grep in chrome/browser (not likely to be in other directories due to Chromium architecture) shows that cryptotoken/manifest.json is referenced in chrome/browser/browser_resources.grd, which makes sense as all embedded resources must be referenced via .grd files (i.e. GRIT files). The GRIT name for this manifest.json is IDR_CRYPTOTOKEN_MANIFEST
Doing a grep for IDR_CRYPTOTOKEN_MANIFEST in chrome/browser hits two locations:

chrome/browser/extensions/component_loader.cc in ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages(). This seems like where all the actual component extension loading is being done (at least one of them; there's another for kiosk mode).
chrome/browser/extensions/component_extensions_whitelist/whitelist.cc in function IsComponentExtensionWhitelisted. This function is referenced in ComponentLoader::Add(), so it might be a security check to prevent unauthorized components.

Hopefully my thought process here helps.

Ok I figured that out and has successfully added chromium-webstore to Android version (not tested on desktop though). Now the button occurs if I switch to desktop site. There are still some minor problems but those are related to UI I think.

Do you have a binary for testing @wchen342 ?

You mean the Android version?

yes

I am still fixing the UI problem. Currently it will crash after hitting the Add to Chromium button.

@jstkdng You want a binary that can run on your phone or in emulator? They need to be compiled to different architectures (arm vs x86).

@wchen342 I currently don't have an emulator installed, so for a phone I guess. My phone isn't arm64 btw.

Ok, then I will compile an arm one. It will take some time though.

Thanks! Are you using your own resources or do you have some pipeline in your gitea server?

I am using my own machine. My server is a very small instance with only 1 core.
Here you go: https://www.droidware.info/fdroid/repo/ChromePublic.apk.

huh, this one is double the size of the apk in your gitea releases, weird. Did you include debug symbols?

Yeah I made a debug build in case you find any other problem then you can report back the backtrace.

If I find anything I'll report back on uc-android. At least I managed to install ubo from the chrome web store, performance is really bad though.

The bad performance is because of the debug build (optimizations are all disabled). BTW uBlock is not working correctly yet, I think it is related to API difference.

chromium-webstore is now bundled with the Android Extension-support version, so I will close this for now.


kubeConfig should have "format": "byte" along with "type": "string"

If "format": "byte" is specified then the generated code will be able to serialize and deserialize this property kubeconfig correctly.
As per swagger specification, this is the recommended way of describing base64 encoded characters.
@mboersma - Please make sure to fix this.
/cc @milismsft

/cc @lmazuel - FYI.

@mboersma I was looking at CLI, and it seems this will just change this:
        encoded_kubeconfig = access_profile.kube_config
        kubeconfig = base64.b64decode(encoded_kubeconfig).decode(encoding='UTF-8')

to this:
        kubeconfig = access_profile.kube_config.decode(encoding='UTF-8')

while at the same time providing free base64 decoding for SDK customers

FYI I would prefer if this change is done as part of a new API version rather than using the same version as it was done not to far in the past for other "non-breaking" changes (see access profiles)... Especially since it's not blocking and can be easily worked around in the SDKs for now.

This does seem like an obvious improvement.
@milismsft I've encountered a lot of resistance when proposing we rev the AKS API version before, and in this case we're not even changing server-side code. If it's possible to inline such a change into v20170831, that may be the only way to accomplish this in a reasonable time frame.

@mboersma - I have already made this change in the node sdk over here and published the sdk. This was easier than adding a layer on top that would do the right thing.


Bug report

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

No


Default to opaque white color in more CanvasItem::draw_* methods

Makes the color parameter default to opaque white (Color(1, 1, 1, 1)) for these methods:

CanvasItem::draw_dashed_line,
CanvasItem::draw_line,
CanvasItem::draw_polyline,
CanvasItem::draw_arc,
CanvasItem::draw_multiline,
CanvasItem::draw_rect,
CanvasItem::draw_circle,
CanvasItem::draw_colored_polygon,
RenderingServer::canvas_item_add_line,
RenderingServer::canvas_item_add_rect,
RenderingServer::canvas_item_add_circle.

Resolves https://github.com/godotengine/godot-proposals/issues/7310.

Notes:

In the code there were used Color(1, 1, 1, 1), Color(1, 1, 1), Color(1.0, 1.0, 1.0). They are equivalent, I've changed all of them to Color(1, 1, 1, 1) which seemed to be used the most. Could be changed to some other variant if preferred. Edit: it was done in canvas_item.h/cpp. But e.g. in RenderingServer.h/cpp Color(1, 1, 1) seems to be used instead, haven't touched these.

I haven't added defaults for the RenderingServer::canvas_item_add_* methods.

I think we should do that as well for consistency.

Looks like this will require compatibility methods for GDExtension and C#. Take a look at the "files changed" tab for more info

I haven't added defaults for the RenderingServer::canvas_item_add_* methods.

I think we should do that as well for consistency.

Changed some.

Looks like this will require compatibility methods for GDExtension and C#. Take a look at the "files changed" tab for more info

Added compat methods, based on #76577. Kinda no idea what I'm doing though. :upside_down_face:

We currently don't generate compat methods for C#, so they have to be added manually:
diff --git a/modules/mono/glue/GodotSharp/GodotSharp/Compat.cs b/modules/mono/glue/GodotSharp/GodotSharp/Compat.cs
index 41cea031ab..b8f8ff7927 100644
--- a/modules/mono/glue/GodotSharp/GodotSharp/Compat.cs
+++ b/modules/mono/glue/GodotSharp/GodotSharp/Compat.cs
@@ -24,6 +24,65 @@ partial class AnimationNode
     }
 }

+partial class CanvasItem
+{
+    /// <inheritdoc cref="DrawArc(Vector2, float, float, float, int, Nullable{Color}, float, bool)"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public void DrawArc(Vector2 center, float radius, float startAngle, float endAngle, int pointCount, Color color, float width, bool antialiased)
+    {
+        DrawArc(center, radius, startAngle, endAngle, pointCount, new Nullable<Color>(color), width, antialiased);
+    }
+
+    /// <inheritdoc cref="DrawCircle(Vector2, float, Nullable{Color})"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public void DrawCircle(Vector2 position, float radius, Color color)
+    {
+        DrawCircle(position, radius, new Nullable<Color>(color));
+    }
+
+    /// <inheritdoc cref="DrawColoredPolygon(Vector2[], Nullable{Color}, Vector2[], Texture2D)"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public void DrawColoredPolygon(Vector2[] points, Color color, Vector2[] uvs, Texture2D texture)
+    {
+        DrawColoredPolygon(points, new Nullable<Color>(color), uvs, texture);
+    }
+
+    /// <inheritdoc cref="DrawDashedLine(Vector2, Vector2, Nullable{Color}, float, float, bool)"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public void DrawDashedLine(Vector2 from, Vector2 to, Color color, float width, float dash, bool aligned)
+    {
+        DrawDashedLine(from, to, new Nullable<Color>(color), width, dash, aligned);
+    }
+
+    /// <inheritdoc cref="DrawLine(Vector2, Vector2, Nullable{Color}, float, bool)"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public void DrawLine(Vector2 from, Vector2 to, Color color, float width, bool antialiased)
+    {
+        DrawLine(from, to, new Nullable<Color>(color), width, antialiased);
+    }
+
+    /// <inheritdoc cref="DrawMultiline(Vector2[], Nullable{Color}, float)"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public void DrawMultiline(Vector2[] points, Color color, float width)
+    {
+        DrawMultiline(points, new Nullable<Color>(color), width);
+    }
+
+    /// <inheritdoc cref="DrawPolyline(Vector2[], Nullable{Color}, float, bool)"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public void DrawPolyline(Vector2[] points, Color color, float width, bool antialiased)
+    {
+        DrawPolyline(points, new Nullable<Color>(color), width, antialiased);
+    }
+
+    /// <inheritdoc cref="DrawRect(Rect2, Nullable{Color}, bool, float)"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public void DrawRect(Rect2 rect, Color color, bool filled, float width)
+    {
+        DrawRect(rect, new Nullable<Color>(color), filled, width);
+    }
+}
+
 partial class CodeEdit
 {
     /// <inheritdoc cref="AddCodeCompletionOption(CodeCompletionKind, string, string, Nullable{Color}, Resource, Nullable{Variant})"/>
@@ -81,6 +140,30 @@ partial class RenderingDevice
     }
 }

+partial class RenderingServer
+{
+    /// <inheritdoc cref="CanvasItemAddCircle(Rid, Vector2, float, Nullable{Color})"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public static void CanvasItemAddCircle(Rid item, Vector2 pos, float radius, Color color)
+    {
+        CanvasItemAddCircle(item, pos, radius, new Nullable<Color>(color));
+    }
+
+    /// <inheritdoc cref="CanvasItemAddLine(Rid, Vector2, Vector2, Nullable{Color}, float, bool)"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public static void CanvasItemAddLine(Rid item, Vector2 from, Vector2 to, Color color, float width, bool antialiased)
+    {
+        CanvasItemAddLine(item, from, to, new Nullable<Color>(color), width, antialiased);
+    }
+
+    /// <inheritdoc cref="CanvasItemAddRect(Rid, Rect2, Nullable{Color})"/>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    public static void CanvasItemAddRect(Rid item, Rect2 rect, Color color)
+    {
+        CanvasItemAddRect(item, rect, new Nullable<Color>(color));
+    }
+}
+
 partial class RichTextLabel
 {
     /// <inheritdoc cref="PushList(int, ListType, bool, string)"/>

Added compat methods, based on #76577. Kinda no idea what I'm doing though.

Thanks! I've skimmed them and they look good to me. :-)
Unfortunately, they won't actually work until after PR https://github.com/godotengine/godot/pull/79702 is merged. I think it'd be good for that to be merged first, so that CI can double check that you've gotten them all correct.

Unfortunately, they won't actually work until after PR #79702 is merged. I think it'd be good for that to be merged first, so that CI can double check that you've gotten them all correct.

Rebased, seeing #79702 was merged. Hopefully they are correct, will see.
Anyway, thanks all of you for the help with this! :slightly_smiling_face:

Unfortunately, they won't actually work until after PR #79702 is merged. I think it'd be good for that to be merged first, so that CI can double check that you've gotten them all correct.

Rebased, seeing #79702 was merged. Hopefully they are correct, will see.

Unfortunately, CI is still not happy:
Validate extension JSON: Error: Hash changed for 'classes/CanvasItem/methods/draw_arc', from CFD4FBAB to 6031513E. This means that the function has changed and no compatibility function was provided.
Validate extension JSON: Error: Hash changed for 'classes/CanvasItem/methods/draw_colored_polygon', from 62E3D9E1 to B5F97BEA. This means that the function has changed and no compatibility function was provided.
Validate extension JSON: Error: Hash changed for 'classes/CanvasItem/methods/draw_dashed_line', from 81A7290C to EEC0FBE7. This means that the function has changed and no compatibility function was provided.
Validate extension JSON: Error: Hash changed for 'classes/CanvasItem/methods/draw_line', from 96057C42 to 89E57661. This means that the function has changed and no compatibility function was provided.
Validate extension JSON: Error: Hash changed for 'classes/CanvasItem/methods/draw_multiline', from FC2AB533 to 3BFB36E2. This means that the function has changed and no compatibility function was provided.
Validate extension JSON: Error: Hash changed for 'classes/CanvasItem/methods/draw_polyline', from F8E6DB22 to C0C2AA6D. This means that the function has changed and no compatibility function was provided.
Validate extension JSON: Error: Hash changed for 'classes/CanvasItem/methods/draw_rect', from 0507B53D to B5FC4F88. This means that the function has changed and no compatibility function was provided.

Looking at the code, perhaps it's because all the orignal DEFVAL()'s aren't provided when registering the compatibility methods?
For example, for draw_arc() I think it maybe should be:
ClassDB::bind_compatibility_method(D_METHOD("draw_arc", "center", "radius", "start_angle", "end_angle", "point_count", "color", "width", "antialiased"), &CanvasItem::draw_arc_compat_79666, DEFVAL(-1.0), DEFVAL(false));

Looking at the code, perhaps it's because all the orignal DEFVAL()'s aren't provided when registering the compatibility methods?

I was looking at this for some time and everything looked the same to me. Now that you've pointed it out it's so obvious, definitely needed another pair of eyes. Thanks again!
I wonder why it wasn't complaining about RenderingServer::canvas_item_add_line though, I've missed default values in compat binding for it too. :thinking:


Enhance the aggregated blueprint tutorial

How to categorize this issue?

/area documentation
/kind enhancement
/priority 2
What would you like to be added:
The aggregated blueprint tutorial should contain a more complex (and probably more real use-case) scenario.
This should also show hot to use templating with import data mapping etc.
Show how the use case can be implented via the aggregated blueprint feature or via single installations using the "block reconcile annotation".
Why is this needed:
Give the user a guideline how to use the landscaper in more complex deployments that is inspired by real use-case scenarios.
The tutorial ressources can be used in integration testing and verify that the landscaper is working as expected with complex deployment scenarios.

moved to other backlog project

Closing, since this is moved to the new backlog.


Show the notification from streams (non-mentions) with changed title on android

Currently they are showing if someone has mentioned

https://chat.zulip.org/#narrow/stream/test.20here/subject/notification.20test/near/284792
@zulipbot claim

This is the JSON received by the GCM on the phone (content modified for privacy)
{
 sender_full_name=Somenamehere,
 google.sent_time=1505996244425,
 sender_avatar_url=https://secure.gravatar.com/avatar/e2869d37ea2b195112909e13b2b6zxxc8f?d=identicon&version=1,
 stream=test here,
 content_truncated=false,
 zulip_message_id=285113,
 recipient_type=stream,
 time=1505996243,
<EMAIL_ADDRESS> alert=New stream message from Somenamehere in test here,
 event=message,
 topic=(no topic),
 google.message_id=0:1505912312396244443204%46869b2df9fd7ecd,
 content=sometexthere,
<EMAIL_ADDRESS>}

@timabbott In both cases (stream message/Mention) GCM receives recipient_type as stream so should we have it as stream-mention from the server or I can also use the alert which says New stream message/New mention from to different b/w these two messages?

recipient_type is just whether it's a stream or private message in general.  I think we should probably include a "trigger" attribute in these, that tells you what caused the notice.  I wouldn't want to be checking the text of the alert, since with i18n that might vary depending on what language the user has selected.

@timabbott Yeah, adding a new attribute seems better, but what about compatibility with old servers or the old app?

Well, old versions of the app will display whatever they're displaying ignoring that field, so that's fine.  And for older servers, they don't support push notifications to streams aside from in the case of mentions, so the existing logic of just checking recipient_type should work as a fallback if the trigger field isn't there.

True, will be working on it very soon (server side as well) 👍

Sent PR for server https://github.com/zulip/zulip/pull/6659

This was fixed last year in 0f3383649 , after a new report of the issue in #2666 .


[release-1.18] service entry: fix leak in workload addesses

Manual cherrypick required.
#47893 failed to apply on top of branch "release-1.18":
Applying: service entry: fix leak in workload addesses
Using index info to reconstruct a base tree...
M	pilot/pkg/serviceregistry/serviceentry/controller_test.go
M	pilot/pkg/serviceregistry/serviceentry/store.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/serviceregistry/serviceentry/store.go
Auto-merging pilot/pkg/serviceregistry/serviceentry/controller_test.go
Applying: Fix another leak
Using index info to reconstruct a base tree...
M	pilot/pkg/serviceregistry/kube/controller/endpointcontroller.go
M	pilot/pkg/serviceregistry/kube/controller/pod.go
M	pilot/pkg/serviceregistry/kube/controller/pod_test.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/serviceregistry/kube/controller/pod_test.go
CONFLICT (content): Merge conflict in pilot/pkg/serviceregistry/kube/controller/pod_test.go
Auto-merging pilot/pkg/serviceregistry/kube/controller/pod.go
Auto-merging pilot/pkg/serviceregistry/kube/controller/endpointcontroller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Fix another leak
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Fixed by https://github.com/istio/istio/pull/48002


NBKTestKit

I want to deduplicate some testing stuff. I can do this by adding more things to NBKCoreKit, but that's messy. Instead, I think a separate module for this purpose is preferred. I thought of this a while ago but dismissed it because I could not add the utilities I wanted without adding every other module as a dependency. Then I discovered, while working on (#81), that I can extend non-dependencies using #if canImport(...). I believe this lets me do what I want.

I have checked and adding NBKTestKit breaks testing through CocoaPods unless I add it as a dependency. Well, that's lame. I would rather disable testing through CocoaPods.

Also, the alternative to #if canImport(...) is one [Module]TestKit per module, and that does not make things simpler.

Hm. It seems like this makes a symbol discoverable, but unusable?

Perhaps adding testing utilities in NBKDoubleWidthKit, etc, but under a special flag that is passed to testing and benchmarking targets is an alternative?


Installing on windows

Are there any precompiled binaries for windows. I'm finding it very difficult to build the library on windows with the given instructions. Is there a simpler way to compile it.

Are there any precompiled binaries for windows.

No, unfortunately not.

I'm finding it very difficult to build the library on windows with the given instructions. Is there a simpler way to compile it.

Sorry, there is not. There is a VS project here: https://github.com/wjwwood/serial/tree/main/visual_studio but I don't know if it is still working.


New release

Do you mind a new release ? That's necessary to be in the stackage lts-11

1.3.17 is out.

Thanks. Do you understand the build error for ghc-8.4.1 on travis: https://travis-ci.org/bartavelle/language-puppet/jobs/359896772 ?
I don't see where cabal is constrained as such.

Makes no sense to me either ...


Glitch when teleported

Information

Server version: 1.16.4

Full output of /mv version -p:

Server log:

Help request
Problem

i got teleported into a different world, came back to the survival and all my stuff was gone
What I have tried

tried rebooting the game, nothing happened
Screenshots

Issue template is present for a reason. Help yourself get help,  if you choose to ignore me and the issue template, providing little to no information for anyone to work on... then I'm sorry, I cant help you with the issue.

Issue template is present for a reason. Help yourself get help,  if you choose to ignore me and the issue template, providing little to no information for anyone to work on... then I'm sorry, I cant help you with the issue.


chore: Upgrade e2e local image

Currently we support k8s versions: v1.27, v1.28, v1.29, so our e2e test image should be upgraded to v1.29.1

/lgtm
/approve
Thanks!


SMF 2.1 support

Hello, readme says that "The master branch contains the Optimus 2.x version for SMF 2.1 RC3+".
I can't see any master branch here. I get "smf20.zip", but as the filename suggests, it doesn't support SMF version 2.1.
Where can I get it?

Thanks, fixed.

So, no support for 2.1?

Wait for the 2.1 Final. Unfortunately, at the current moment, I have no time, no funds, nor desire to continue this development.


Allows the abbreviated/short form to be used as spoken phrase

"brief application => app
"brief app" => app

Didn't test this yet as afk, but off the top of my head I'd be curious how it handles some existing entries like for instance "brief configuration" returns "config" but "brief config" returns "cfg". Seems like that could break things it as will create duplicate entries?
Could always check and not add the additional entries if one already exists.


chore(litmus-portal): code-refactor of Linear Progress and Ananlytics Progress Bar

Signed-off-by: Surya Bansal<EMAIL_ADDRESS>Proposed changes
Isuue #2100  : Change RC-Progress component to Material UI Compenent and decrease the bundle size.
Types of changes
-Using Material UI Component, conditional colouring of bar with change in values.
-Added proper bar-colour and background-colour to the progress bars.
-Custom styling of the bar.
-All Unit tests(Specs) passed.
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[x] New feature (non-breaking change which adds functionality)
[x] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the commit for DCO to be passed.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

No extra dependancy, used @material-ui/core, which was already present.

Special notes for your reviewer:
Thank you for reviewing my code! It was great to work on it and be a part of litmus community!

Hi @bansalsurya , I am making this PR as a draft. Please let us know if you want to continue working in this PR?

Thanks, @bansalsurya  for this PR. But this PR is pending for the last 6 months. Let us know if you want to work on this PR. Otherwise, we need to close this PR.

Thanks, @bansalsurya for this PR. But this PR is pending for the last 6 months. Let us know if you want to work on this PR. Otherwise, we need to close this PR.

Hey @rajdas98 I'll be pushing the code within 2-3 days.

Thanks, @bansalsurya for this PR. But this PR is pending for the last 6 months. Let us know if you want to work on this PR. Otherwise, we need to close this PR.

Hey, I wish to push from a new branch, is there a way I can do that? I have made changes to the code.

@bansalsurya the branch is outdated

@bansalsurya the branch is outdated

Let me know if I need to rebase (https://stackoverflow.com/questions/8965781/update-an-outdated-branch-against-master-in-a-git-repo/8965803)

@bansalsurya the branch is outdated

Let me know if I need to rebase (https://stackoverflow.com/questions/8965781/update-an-outdated-branch-against-master-in-a-git-repo/8965803)

Hi @bansalsurya, I think this PR has been not rebased properly. Can you close this PR and raise a new one?

I have opened a new PR on @rajdas98's request.
PR: #2579
I request @arkajyotiMukherjee  to review the few changes that were suggested at the end.
Other changes remain the same and approved by @ishangupta-ds
Thanks!


SvgUri On Error

Feature Request
We need to have an on Error when we use svgUri as the app crashes if there is an error in the SVG format. A best practice guide on the format of the svg from uri is also required as it is based on trial and error and standard svg's do not load and app crashes
Why it is needed
In case the svg's are coming from a third party source and if the svg is not confirming to the specs required by react-native-svg, the app crashes. This can be handled and a default svg can be shown.
Possible implementation
It really helps if you could describe from a technical POV how this new feature would work, which code it rely on, etc
Code sample
Please show how the new code could work, if doable

Would you be available to work on this? Could you make a pr?

SvgUri loads svg from a url. We could have a onError prop which could be used to show a default svg image from local images. We noticed that in case of any missing svg's or not well formattted svg's from third party the whole application crashes. To avoid this, it would be helpful. Also the svg loads on component did mount of the view where we use svgURI and we could not trap the error as it happens inside the SvgUri library

@prashantchothani  as a workaround you can implement something like this https://gist.github.com/YuriiStetsula/ccac4e5920db289bcbbd3c029096e3e6

I've made the e2e app work again, might make sense to move it here yeah, mind making a pr for it?

@msand,
This week I'm really busy, but if I can't find some time to do that in the next days, I'll in the next week.

Any news about this topic ?

I couldn't find any time to do that yet. But I'm planning to do during this week.

Any news about this topic ?

@JacobBarr1986, it was merged in the #1266

@uqmessias Thanks for this effort and I tried to use the onError Prop to pass a SVG Component to load that in case of error of the SVG URI. But still it crashes. Any help on how can i use this prop and gracefully show a default image ?

Any news please ?

Hey @prashantchothani, how are you doing? I hope you're well 😄
You can use the onError callback to show another view instead of the SVG with error, to do that, we may need to use something to hold the state of this SVG, in the following example, I'll use useState hook, but you can solve the same problem with other solutions:
const MySVG = () => {
  const [hasError, setError] = useState(false);
  const handleError = useCallback(() => {
    setError(true);
  }, []);

  if (hasError){
    return (
      <Text>There's an error in the SVG file</Text>
    );
  }

  return (
    <SvgXml
        xml='<svg width="400" height="180">\n<rectwitherror x="50" y="20" width="150" height="150" style="fill:blue;stroke:pink;stroke-width:5;opacity:0.5" /></svg>'
        onError={handleError}
    />
  );
}

hi @uqmessias i have used above solution for SvgUri but onError app is crashing
this is my code
export default React.memo(function Segment(props) {     const [hasError, setError] = useState(false);     const handleError =()=>{         setError(true)     }   return(          <View>                {hasError ?                     <Text>error</Text>                     :                     <SvgUri                         width={22}                         height={22}                         uri={Urls.svgAirlineImageUrl + data.vc + ".svg"}                         onError={handleError}                     >                     </SvgUri>                 }             </View> )})
i get this error when i pass wrong svg

can you please help where i am doing wrong

@uqmessias I am fine and hope all's well with you and your family :)
Even i got the same issue.

Hey @prashantchothani and  @vinitgundeti, does it work if you change your example to the following?
diff --git a/your-example.jsx b/your-example.jsx
index 392360b31..ece36f1bc 100644
--- a/your-example.jsx
+++ b/your-example.jsx
@@ -13,8 +13,7 @@ export default React.memo(function Segment(props) {
                         height={22}
                         uri={Urls.svgAirlineImageUrl + data.vc + ".svg"}
                         onError={handleError}
-                    >
-                    </SvgUri>
+                    />
                 }
             </View>
 )})

Hi @uqmessias it's not working even i change it like above

@vinitgundeti, are you getting any new error or something? Because the previous error was regarding to the missing children value (default to null)

@uqmessias i am getting the same error

Hey @vinitgundeti, sorry for taking so long to answer!
Can you upload a sample code to Github and send the link so I can test it and try to help you with that?
I'm not actively working with React Native currently (working with other technologies and other projects) and if you could send me this sample it would be a lot easier to spot the error and I probably could you faster.

Hey @uqmessias, sorry for late reply
this is my git repo link
https://github.com/vinitgundeti/reactnativesvg.git
i have made component svgcomponent.js added it in App.js
in code i have added wrong svg link the right link i have mentioned in readme

@vinitgundeti, this is an issue on the initial implementation of onError, I just opened a PR to fix that:
https://github.com/react-native-svg/react-native-svg/pull/1476
@msand, can you take a look at it, pls?

@uqmessias is this merged in release ?

@uqmessias Thank you very much for fixing this, this was must required feature, i have tested it and it is working fine. when will this be in the main branch ?

Just wanted to throw my hat in the ring and say this would be great to be fixed,

As a workaround, it possible to prevent app from crashing using error boundaries.
<ErrorBoundary> <SvgXml         xml='...'     /> </ErrorBoundary>

Hi all, I don't know how many of you are using the onError props, but I think we have to update ts definitions in order to make is available in typescript.
in src/index.d.ts, this code
export interface SvgProps extends GProps, ReactNative.ViewProperties {   width?: NumberProp;   height?: NumberProp;   viewBox?: string;   preserveAspectRatio?: string;   color?: Color;   title?: string; }
probably should become
`export type AdditionalProps = {
onError?: (error: Error) => void;
override?: Object;
};
export interface SvgProps extends AdditionalProps, GProps, ReactNative.ViewProperties {
width?: NumberProp;
height?: NumberProp;
viewBox?: string;
preserveAspectRatio?: string;
color?: Color;
title?: string;
}
`

:))) Same issue brought me here, took me several hours to find out which uri is dead in hundreds of them

I think it still crash the app when remote url is failed

Dealing with same issue. A bad SVG will crash the entire server, and this library doesn't seem to play nice with error boundaries.

Hey, since https://github.com/react-native-svg/react-native-svg/pull/1503 and https://github.com/react-native-svg/react-native-svg/pull/1718 have been merged, do you think we can close it? It would be nice if you could test it and see if there are some scenarios that are not yet handled though.

@gabimoncha are you sure you updated the library version? And if so, could you post a small reproduction of the problem with a short description of what is the issue exactly?

My project has the current version (12.3.0) and onError still not working properly, even using this example.
It throws me this error:

I have the same problem as @lorran-xo

I'm having this issue, app crash when the url of svg file return error 404.
I hope it can just render null instead of crashing. It is not ideal for production.

I could not reproduce the problem in newest versions. I will close this issue then. Feel free to comment here with a repo with reproduction and we can always reopen it then.

onError still doesnot catch error if the svg cannot be parsed.
react-native-svg : 13.6.0
react-native: 0.70.6

export function SvgUri(props: UriProps) {   const { onError = err, uri, onLoad } = props;   const [xml, setXml] = useState<string | null>(null);   useEffect(() => {     uri       ? fetchText(uri)           .then((data) => {             setXml(data);             onLoad?.();           })           .catch(onError)       : setXml(null);   }, [onError, uri, onLoad]);   return <SvgXml xml={xml} override={props} />; }
if the svg is invalid  it wonot go to onError function as the uri is a valid url and the data will be undefined and it will set xml as undefined ,
`export function SvgXml(props: XmlProps) {
const { onError = err, xml, override } = props;
const ast = useMemo<JsxAST | null>(
() => (xml !== null? parse(xml) : null),
[xml],
);
try {
return <SvgAst ast={ast} override={override || props} />;
} catch (error) {
onError(error);
return null;
}
}`
and in this usememo it will go the parse function and it will cause the error as the source will be undefined too.
I suggest we replace usememo with this code to handle undefined data (invalid svg) too
const ast = useMemo<JsxAST | null>(
() => (![null , undefined].includes(xml) ? parse(xml) : null),
[xml],
);

I simply added a patch:
diff --git a/node_modules/react-native-svg/src/xml.tsx b/node_modules/react-native-svg/src/xml.tsx
index ff9b02e..613010b 100644
--- a/node_modules/react-native-svg/src/xml.tsx
+++ b/node_modules/react-native-svg/src/xml.tsx
@@ -108,7 +108,13 @@ export const err = console.error.bind(console);
 export function SvgXml(props: XmlProps) {
   const { onError = err, xml, override } = props;
   const ast = useMemo<JsxAST | null>(
-    () => (xml !== null ? parse(xml) : null),
+    () => {
+      try {
+        return (xml !== null ? parse(xml) : null)
+      } catch (err) {
+        return null
+      }
+    },
     [xml],
   );


Add onTap function to StringField

I think it would be nice to have onTap property added to StringField

onTap only works when readOnly is true or enabled is false

@Alvarocda try to use ModelField.


Feature: Separate changelog/description for additional files.

I've seen from trial and from poking around in the code that the changelog for additional files are taken from the parent file. Would appreciate a way to set a different changelog to said additional files.
Thank you!
EDIT: I suppose this could also potentially be extended to file display names as well

Hmm good point.
I'm thinking for this, maybe I can change the additional file method, to either take in just a file, or an Object, which would allow overriding the file display name and changelog.
If those properties are not defined, it will just fall back to the globally defined ones

Implemented with 2.0.3
// Additional files to upload with a custom display name and changelog.
// Currently only supported on Curseforge
addAdditionalFile {
    // File, Task or String
    artifact jar
    displayName "Some Name"
    changelog "Hello Changelog"
}

Kotlin DSL
// Additional files to upload with a custom display name and changelog.
// Currently supports CurseForge only
addAdditionalFile {
    // File, Task or String
    artifact(tasks.jar)
    displayName("Test Name")
    changelog("Some Changelog")
}


File upload improvements

[ ] Iterate through tree more efficient (e.g. along a path instead of the current brute force approach) for functions addFileToTree and removeFileFromTree
[ ] Save all expanded nodes such that after adding/removing files (and therefore, after collapsing) they are expanded again all at once
[ ] Find a way to allow filenames with white spaces (instead of replacing them with underscores)
[ ] Allow upload of files with sizes >100MB
[ ] Use different icons for different file extensions

[ ] Adjust margins between folders and files (they are different)
[ ] Set minimum width of upload files windows, so that it doesn't get wider when open
[ ] Mark directories without children as not expandable


merging commits to v1 release branch into master

@zongzw FYI
What issues does this address?
N/A
What's this change do?
Keeps master branch in sync with release branch (v1).
Where should the reviewer start?
Any background context?

Cherry-picking commits instead so we don't end up with all of the merge commits from v1 in the master branch.
Going forward, all changes should be merged into master first, then into v1 to publish.

@zongzw I added a wiki with some helpful information about branch and release management: https://github.com/F5Networks/f5-openstack-docs/wiki

@jputrino helpful!


How to set VSS_NUGET_EXTERNAL_FEED_ENDPOINTS in Azure pipeline?

Hello
I'm not sure if this belongs to this repository.
I set up an Azure DevOps Pipeline and tried to get nugets from telerik feed with auth, but this doesn't work with credential provider (as described here https://docs.microsoft.com/en-us/azure/devops/artifacts/nuget/dotnet-exe)
My Pipeline:
steps:
- task: NuGetToolInstaller@0
  displayName: 'Use NuGet 4.8.1'
  inputs:
    versionSpec: 4.8.1
    checkLatest: true

- task: NuGetCommand@2
  displayName: 'NuGet restore'
  inputs:
    restoreSolution: '$(Parameters.solution)'
    feedsToUse: config
    nugetConfigPath: src/SomeObscureWeb/NuGet.Config

I tried specifying json in VSS_NUGET_EXTERNAL_FEED_ENDPOINTS as Pipeline Variable but it doesn't seem that credential provider in pipline is using this value.
My VSS_NUGET_EXTERNAL_FEED_ENDPOINTS looks like this
{"endpointCredentials": [{
"endpoint":"https://nuget.telerik.com/nuget",
<EMAIL_ADDRESS>
"password":"xxx"}]}

How should I setup VSS_NUGET_EXTERNAL_FEED_ENDPOINTS for Azure Pipline to add new feed with credentials?
Thank you
Peter

We are currently investigating an intermittent issue with the Artifacts Credential Provider in the NuGet build tasks. Therefore, we default to the old way of authenticating which doesn't recognize this environment variable VSS_NUGET_EXTERNAL_FEED_ENDPOINTS. To force your build task to use the Artifacts Credential Provider in NuGet build tasks you need to set two more build variables: NuGet_ForceEnableCredentialProviderV2=true and NuGet.ForceEnableCredentialProvider=false.

Thank you, I tried it but got
2018-11-28T14:36:55.3167976Z [command]C:\hostedtoolcache\windows\NuGet\4.8.1\x64\nuget.exe restore D:\a\1\s\ForecastWeb.sln -Verbosity Detailed -NonInteractive -ConfigFile D:\a\1\s\src\SomeWeb\NuGet.Config
2018-11-28T14:37:13.9054685Z NuGet Version: <IP_ADDRESS>35
2018-11-28T14:37:13.9055281Z MSBuild auto-detection: using msbuild version '<IP_ADDRESS>996' from 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\bin'. Use option -MSBuildVersion to force nuget to use a specific version of MSBuild.
2018-11-28T14:37:13.9055472Z MSBuild P2P timeout [ms]: 120000
2018-11-28T14:37:13.9055746Z C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\bin\msbuild.exe "C:\Users\VssAdministrator\AppData\Local\Temp\NuGetScratch\tbvb5kt1.lv4.nugetinputs.targets" /t:GenerateRestoreGraphFile /nologo /nr:false /v:q /p:NuGetRestoreTargets="C:\Users\VssAdministrator\AppData\Local\Temp\NuGetScratch\tp03cbxu.0rc.nugetrestore.targets" /p:RestoreUseCustomAfterTargets="True" /p:RestoreTaskAssemblyFile="C:\hostedtoolcache\windows\NuGet\4.8.1\x64\nuget.exe" /p:RestoreSolutionDirectory="D:\a\1\s\\" /p:RestoreConfigFile="D:\a\1\s\src\ForecastWeb\NuGet.Config" /p:SolutionDir="D:\a\1\s\\" /p:SolutionName="ForecastWeb"
...
...
2018-11-28T14:37:13.9063495Z Using D:\a\_tasks\NuGetCommand_333b11bd-d341-40d9-afcf-b32d5ce6f23b\2.0.48\node_modules\nuget-task-common\NuGet\CredentialProviderV2\plugins\netfx\CredentialProvider.Microsoft\CredentialProvider.Microsoft.exe as a credential provider plugin.
2018-11-28T14:37:13.9063697Z Terminating plugin 'CredentialProvider.Microsoft' due to an unrecoverable fault:  NuGet.Protocol.Plugins.ProtocolException: A plugin protocol exception occurred. ---> NuGet.Protocol.Plugins.ProtocolException: The message type 'Cancel' is invalid at this time.
2018-11-28T14:37:13.9064016Z    at NuGet.Protocol.Plugins.OutboundRequestContext`1.HandleCancelResponse()
2018-11-28T14:37:13.9064271Z    at NuGet.Protocol.Plugins.MessageDispatcher.OnMessageReceived(Object sender, MessageEventArgs e)
2018-11-28T14:37:13.9064499Z    at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
2018-11-28T14:37:13.9064663Z    at NuGet.Protocol.Plugins.StandardOutputReceiver.OnLineRead(Object sender, LineReadEventArgs e)
2018-11-28T14:37:13.9064826Z    --- End of inner exception stack trace ---
2018-11-28T14:37:13.9064975Z Retrying 'FindPackagesByIdAsyncCore' for source 'https://nuget.telerik.com/nuget/FindPackagesById()?id='Microsoft.AspNetCore.CookiePolicy'&semVerLevel=2.0.0'.
2018-11-28T14:37:13.9065219Z A task was canceled.

I'm using following NuGet.Config
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="Nuget" value="https://api.nuget.org/v3/index.json" />
    <add key="Telerik" value="https://nuget.telerik.com/nuget/" />
  </packageSources>
</configuration>

and VSS_NUGET_EXTERNAL_FEED_ENDPOINTS with json

Hi @PeterJakubik, unfortunately that is the exact intermittent issue that I was referring to in my earlier message. To understand your scenario better, could you turn the variable system.debug to true and try again? This will hopefully provide us some more logs. Also would you mind attaching a screen shot of your build definition?
Are you filling your credentials in the restore task's "Credentials for feeds outside this account/collection" section correctly? I should have mentioned this in my first message but the NuGet build task will automatically populate the VSS_NUGET_EXTERNAL_FEED_ENDPOINTS variable if the Azure Artifacts credential provider (V2) is being used and the "Credentials for feeds outside this account/collection" section is filled. With the old way of authenticating (currently, when not setting the build env vars to force-enable "V2", or using NuGet version lesser than 4.8.1), the task will not use VSS_NUGET_EXTERNAL_FEED_ENDPOINTS env var but will create a temp nuget.config with the credentials provided and call NuGet restore with the nuget.config with credentials. Did this not work for you? If you didn't try yet or if you have a reason not to, please try and remove the build variables that force-enable V2 cred provider and fill out the "Credentials for feeds outside this account/collection" section with the credentials you want to use.
We are still investigating the issue but please let me know if using the old credential provider worked for you.

Hi @satbai
Thank you. When I set the "Credentials for feeds outside this account/collection" it works!
So my NuGet.config looks like this
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="Nuget" value="https://api.nuget.org/v3/index.json" />
    <add key="Telerik" value="https://nuget.telerik.com/nuget/" />
  </packageSources>
</configuration>

I set Build variables NuGet.ForceEnableCredentialProvider, NuGet_ForceEnableCredentialProviderV2, VSS_NUGET_EXTERNAL_FEED_ENDPOINTS
Variable VSS_NUGET_EXTERNAL_FEED_ENDPOINTS
{
"endpointCredentials": [
{
"endpoint":"https://nuget.telerik.com/nuget/",
<EMAIL_ADDRESS>
"password":"secret password"}
]}

The same credentials must be set in build task in credentials provider

Hi @satbai
Although it works, i'm still getting occasional Problems authentication from Azure
2018-11-29T10:41:16.3477604Z   GET https://nuget.telerik.com/nuget/FindPackagesById()?id='Telerik.Reporting.Services.AspNetCore'&semVerLevel=2.0.0
2018-11-29T10:41:16.3477733Z   GET https://nuget.telerik.com/nuget/FindPackagesById()?id='Telerik.UI.for.AspNet.Core'&semVerLevel=2.0.0
2018-11-29T10:41:16.3477894Z Using D:\a\_tasks\NuGetCommand_333b11bd-d341-40d9-afcf-b32d5ce6f23b\2.0.48\node_modules\nuget-task-common\NuGet\CredentialProviderV2\plugins\netfx\CredentialProvider.Microsoft\CredentialProvider.Microsoft.exe as a credential provider plugin.
2018-11-29T10:41:16.3478210Z Terminating plugin 'CredentialProvider.Microsoft' due to an unrecoverable fault:  NuGet.Protocol.Plugins.ProtocolException: A plugin protocol exception occurred. ---> NuGet.Protocol.Plugins.ProtocolException: The message type 'Cancel' is invalid at this time.
2018-11-29T10:41:16.3478368Z    at NuGet.Protocol.Plugins.OutboundRequestContext`1.HandleCancelResponse()
2018-11-29T10:41:16.3478493Z    at NuGet.Protocol.Plugins.MessageDispatcher.OnMessageReceived(Object sender, MessageEventArgs e)
2018-11-29T10:41:16.3478588Z    at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
2018-11-29T10:41:16.3478839Z    at NuGet.Protocol.Plugins.StandardOutputReceiver.OnLineRead(Object sender, LineReadEventArgs e)
2018-11-29T10:41:16.3478929Z    --- End of inner exception stack trace ---
2018-11-29T10:41:16.3479058Z Retrying 'FindPackagesByIdAsyncCore' for source 'https://nuget.telerik.com/nuget/FindPackagesById()?id='Telerik.Reporting.Services.AspNetCore'&semVerLevel=2.0.0'.
2018-11-29T10:41:16.3479168Z A task was canceled.

Any update on this intermittent issue?

When you use the "Credentials for feeds outside this account/collection" you shouldn't need to set the variable VSS_NUGET_EXTERNAL_FEED_ENDPOINTS at all. If the task uses the Artifacts Cred Provider, which in your case it does because of the build variables that force it, the task will populate the VSS_NUGET_EXTERNAL_FEED_ENDPOINTS variable under the covers based on the credentials that you've set in the task.
We'll update this issue once we know more about the intermittent exception in the NuGet build tasks when using the Artifacts Credential Provider.

I tried removing VSS_NUGET_EXTERNAL_FEED_ENDPOINTS.
Started Build 5x and 5x got an error.
2018-11-30T09:15:14.2877565Z   GET https://nuget.telerik.com/nuget/FindPackagesById()?id='Telerik.UI.for.AspNet.Core'&semVerLevel=2.0.0
2018-11-30T09:15:14.2877710Z Using D:\a\_tasks\NuGetCommand_333b11bd-d341-40d9-afcf-b32d5ce6f23b\2.0.48\node_modules\nuget-task-common\NuGet\CredentialProviderV2\plugins\netfx\CredentialProvider.Microsoft\CredentialProvider.Microsoft.exe as a credential provider plugin.
2018-11-30T09:15:14.2878100Z Terminating plugin 'CredentialProvider.Microsoft' due to an unrecoverable fault:  NuGet.Protocol.Plugins.ProtocolException: A plugin protocol exception occurred. ---> NuGet.Protocol.Plugins.ProtocolException: The message type 'Cancel' is invalid at this time.
2018-11-30T09:15:14.2878255Z    at NuGet.Protocol.Plugins.OutboundRequestContext`1.HandleCancelResponse()
2018-11-30T09:15:14.2878369Z    at NuGet.Protocol.Plugins.MessageDispatcher.OnMessageReceived(Object sender, MessageEventArgs e)
2018-11-30T09:15:14.2878464Z    at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
2018-11-30T09:15:14.2878574Z    at NuGet.Protocol.Plugins.StandardOutputReceiver.OnLineRead(Object sender, LineReadEventArgs e)
2018-11-30T09:15:14.2878665Z    --- End of inner exception stack trace ---

I will test again when the exception in the NuGet build tasks is fixed.

I still need to set VSS_NUGET_EXTERNAL_FEED_ENDPOINTS explicitly in order for this to work on Mac agents even after installing the latest credentials provider. Adding all the endpoints as nuget service connections didn't work. The same tokens specified in the envvar do work, however.

@kzu if you're using the NuGetCommandV2 task with nuget version 4.8 or greater, it should automatically use the version of the cred provider that gets installed with the task, so you shouldn't have to install it separately. In the task, if you're using feeds in your nuget.config, the task will use the PATs that you set in the task as service connections and behind the scenes will populate VSS_NUGET_EXTERNAL_FEED_ENDPOINTS for you without you having to set it manually.
Please make sure that the service connections that you set in the task are PATs and the you're using the External Azure DevOps Server type of service connection:

If you're still having issues after verifying the service connection and removing the VSS_NUGET_EXTERNAL_FEED_ENDPOINTS variable, please set the system.debug build variable to true and share the failing logs and I can take a look.

we're using msbuild /t:restore, not the nuget task. Would that apply in that case too?

For cases that are not NuGetCommandV2 you have to set things up manually.


[flame_tiled] Null check on tileData fails for infinite maps

Current bug behavior
A null check operator exception is thrown when trying to load (cache) infinite tiled maps

Expected behavior
The map is loaded in chunks or the chunks are consoladated

Steps to reproduce
Simply use an infinite map.
Flutter doctor output

[√] Flutter (Channel stable, 3.13.9, on Microsoft Windows [Version 10.0.22621.2428], locale de-DE)
    • Flutter version 3.13.9 on channel stable at C:\Users\xxxxx\Coding\_sdks\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d211f42860 (3 weeks ago), 2023-10-25 13:42:25 -0700
    • Engine revision 0545f8705d
    • Dart version 3.1.5
    • DevTools version 2.25.0

[√] Windows Version (Installed version of Windows is version 10 or higher)

[X] Android toolchain - develop for Android devices
    X Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.7.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.7.34202.233
    • Windows 10 SDK version 10.0.22621.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[√] IntelliJ IDEA Ultimate Edition (version 2023.2)
    • IntelliJ at C:\Users\xxxxx\AppData\Local\Programs\IntelliJ IDEA Ultimate
    • Flutter plugin version 76.2.4
    • Dart plugin version 232.10072.19

[√] VS Code (version 1.84.0)
    • VS Code at C:\Users\xxxx\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
       https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.2428]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 119.0.6045.124
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 119.0.2151.58

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

More environment information

Flame version: 1.2.0
flame_tiled version: 1.14.1
Platform affected: all

Log information

ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Null check operator used on a null value
#0      OrthogonalTileLayer.cacheTiles (package:flame_tiled/src/renderable_layers/tile_layers/orthogonal_tile_layer.dart:25:36)
#1      FlameTileLayer.refreshCache (package:flame_tiled/src/renderable_layers/tile_layers/tile_layer.dart:181:5)
#2      RenderableTiledMap._refreshCache (package:flame_tiled/src/renderable_tile_map.dart:365:13)
#3      new RenderableTiledMap (package:flame_tiled/src/renderable_tile_map.dart:64:5)
#4      RenderableTiledMap.fromTiledMap (package:flame_tiled/src/renderable_tile_map.dart:300:12)

More information
This bug is caused because (as far as I can see all) FlameTileLayer's force-unwrap layer.tileData however with the current tiled implementation this can be null if the map is infinite and therefore split into chunks.
I see two possible solutions:

Aggregate all chunks into a single matrix (this would be sufficient for my use case) however with very large maps this can lead to performance issues
Implement some mechanism to only render visible chunks and scope the cache/rendering appropriately. This seems like it would require quite a lot of work.

Since finite maps are fine for my use case I probably won't be able to contribute a PR to this!
For the time being I think a warning in the docs that infinite maps are not support would be appropriate!
(I didn't find one so far, I hope I didn't miss it 😅)

Yeah, probably the quickest way to avoid confusion on user side will be to add an assert for infinite maps.


Need additional instructions on setting up to perform development

Using current instructions pytest fails with missing imports. Additional steps are needed for pytest to work smoothly ( assumes conda is used to allow pre-compiled GDAL) :

pip install -e .
pip install -e .[test]
conda install gdal
export GDAL_DATA = "where GDAL_DATA went"
pip install eodatasets3[ancillary]
pip install h5py

As of 16/12/2019 running pytest here has the following result:
=== 2 failed, 91 passed, 25 warnings in 7.57s ===

against origin/HEAD

Thanks Tisham!
Those other optional dependencies are installable in one step with pip install -e .[all]
But it's a mistake that they're not included with the [test] group, since there's tests on the optional parts too.

In that PR, the travis build now does the same thing we say in our docs: just a pip install -e .[test]

You also mentioned test failures, do you still get them? Which tests?
They're passing on Travis and locally for me.

When running on gdal 3 exactly two tests failed -- my guess is that that was the problem you saw. Gdal 3 is now the default in some environments.
I've added a fix for gdal 3 to my PR. Feel free to reopen this if your failures still occur.


Update find_inactive_members.rb

Add error handling for the null set response which GitHub's API treats as an entity not existing error and responds with a 404 instead of an empty set.
/cc @MikeNwin @harsh

Chodya Mury khaaa
On Thu, Apr 4, 2019, 1:27 AM Aziz Shamim<EMAIL_ADDRESS>wrote:

Add error handling for the null set response which GitHub's API treats as
an entity not existing error and responds with a 404 instead of an empty
set.
/cc @MikeNwin https://github.com/MikeNwin @harsh
https://github.com/harsh
You can view, comment on, or merge this pull request online at:
https://github.com/github/platform-samples/pull/237
Commit Summary

Update find_inactive_members.rb

File Changes

M api/ruby/find-inactive-members/find_inactive_members.rb
https://github.com/github/platform-samples/pull/237/files#diff-0 (5)

Patch Links:

https://github.com/github/platform-samples/pull/237.patch
https://github.com/github/platform-samples/pull/237.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/platform-samples/pull/237, or mute the thread
https://github.com/notifications/unsubscribe-auth/AuQLi_OoLr8i7n4zOHLvvJIGG9Fi97r1ks5vdQCHgaJpZM4cbRCU
.


Is there a way to enable logging to file?

I'm currently working on integrating Haul into a project, and it's working great so far. However, one issue I'm running into is that I need to be able to measure performance data, such as live reload times, in order to track and process them elsewhere. This is something that I see came up in #343 , but as far as I can tell the changes discussed have not yet been made. I'd settle for manually parsing the CLI output, but I can't seem to get anything from stdout, and node_modules/.haul-artifacts/stdout.log is completely empty at all times. I'd really like to avoid just piping all output to file, because this needs to be captured concurrently with CLI use, and for some reason tee seems to suppress CLI updates.
Am I missing something obvious, or is this scenario currently not possible?

Cc @zamotany

I'd love to extend haul's logging abilities. Currently it all goes through the https://github.com/callstack/haul/blob/next/src/server/ui.js file, which subscribes to an EventEmitter.
It would be pretty straightforward to write another logger that subscribes to the EventEmitter as well.
My interests lie in that I'd love to have a more CI friendly (or foreman start friendly) logging available within the context of haul start. It all happens in a very ncurses manner right now, which is sub-optimal in some applications.
Curious to hear what contributors think about this – I may be able to put together a pull request. I've been looking at this code a lot lately!

PRs welcome :)

If anyone is interested:
Yes, there's a option to enable logging to file with --output-file <filename> and --json, which will write logs in JSON format. #628 will also improve the logging to file.
The recommended way to log to file on CI:

haul bundle --output-file ./bundle.log --json <...rest>
haul start --output-file ./start.log --json --no-interactive <...rest>


Good Luck

Prevent the dumbness of breaking a block without "Fortune III"-enchantment. https://minecraft.wiki/w/Fortune
Please dont prevent this Issue.
Best Regards

Please rephrase your issue, as it is not exactly clear what you mean.

I hope this message reaches you in good health. I am writing to you with an urgent request, one that I believe could save countless Minecraft players from unnecessary heartbreak 💔.
In Minecraft, there is an enchantment called "Fortune," which allows players to receive more items when mining certain types of blocks. For example, if you mine a diamond ore block with the "Fortune III" enchantment on your pickaxe, you have a higher chance of getting multiple diamonds 💎 instead of just one.
I wanted to suggest a potential feature for your very nice preventing "preventer" mod 🚫. In Minecraft, using a pickaxe without the "Fortune III" enchantment on valuable blocks (like diamond ore) can lead to a significant loss of resources. It can be really frustrating to realize later that you could have gotten many more resources if you had used a Fortune-enchanted tool.
To address this, could you consider adding a feature that prevents players from breaking certain blocks (like diamond, emerald, or lapis ore) unless they are using a tool with the "Fortune III" enchantment? This would help ensure that players always get the maximum yield from their mining efforts and avoid accidentally missing out on valuable drops.
By preventing this, happiness becomes a person, and Fortune 🍀 herself smiles upon us.
Best Regards


add support for rabbitmq shovels

Hey there! thank you for making terraformer opensource. This afternoon I tried to add shovel support for rabbitmq provider however I'm missing something. This pull request is almost completed except for that part.
+ ../terraformer import rabbitmq -v -p '{output}/{provider}/' --resources=shovels
2020-12-27T21:56:04.769+0100 [INFO]  plugin: configuring client automatic mTLS
2020-12-27T21:56:04.798+0100 [DEBUG] plugin: starting plugin: path=.terraform/plugins/registry.terraform.io/cyrilgdn/rabbitmq/1.5.1/linux_amd64/terraform-provider-rabbitmq_v1.5.1 args=[.terraform/plugins/registry.terraform.io/cyrilgdn/rabbitmq/1.5.1/linux_amd64/terraform-provider-rabbitmq_v1.5.1]
2020-12-27T21:56:04.798+0100 [DEBUG] plugin: plugin started: path=.terraform/plugins/registry.terraform.io/cyrilgdn/rabbitmq/1.5.1/linux_amd64/terraform-provider-rabbitmq_v1.5.1 pid=10977
2020-12-27T21:56:04.798+0100 [DEBUG] plugin: waiting for RPC address: path=.terraform/plugins/registry.terraform.io/cyrilgdn/rabbitmq/1.5.1/linux_amd64/terraform-provider-rabbitmq_v1.5.1
2020-12-27T21:56:04.810+0100 [INFO]  plugin.terraform-provider-rabbitmq_v1.5.1: configuring server automatic mTLS: timestamp=2020-12-27T21:56:04.810+0100
2020-12-27T21:56:04.837+0100 [DEBUG] plugin: using plugin: version=5
2020-12-27T21:56:04.837+0100 [DEBUG] plugin.terraform-provider-rabbitmq_v1.5.1: plugin address: address=/tmp/plugin928573766 network=unix timestamp=2020-12-27T21:56:04.837+0100
2020-12-27T21:56:04.887+0100 [TRACE] plugin.stdio: waiting for stdio data
2020-12-27T21:56:04.888+0100 [DEBUG] plugin.stdio: received EOF, stopping recv loop: err="rpc error: code = Unimplemented desc = unknown service plugin.GRPCStdio"
2020/12/27 21:56:04 rabbitmq importing... shovels
2020/12/27 21:56:04 [{0xc0012f4960 ID = someshovel@someVhost
name = someshovel
vhost = someVhost
Tainted = false
2020/12/27 21:56:04 Refreshing state... rabbitmq_shovel.tfer--someshovel
2020-12-27T21:56:04.896+0100 [DEBUG] plugin.terraform-provider-rabbitmq_v1.5.1: 2020/12/27 21:56:04 [DEBUG] RabbitMQ: Shovel retrieved: Vhost: "someVhost", Name: "someshovel"
2020/12/27 21:56:04 rabbitmq Connecting....
2020/12/27 21:56:04 rabbitmq save
2020/12/27 21:56:04 rabbitmq save tfstate
2020-12-27T21:56:04.900+0100 [DEBUG] plugin: plugin process exited: path=.terraform/plugins/registry.terraform.io/cyrilgdn/rabbitmq/1.5.1/linux_amd64/terraform-provider-rabbitmq_v1.5.1 pid=10977
2020-12-27T21:56:04.900+0100 [DEBUG] plugin: plugin exited
+ cat generated/rabbitmq/shovel.tf
resource "rabbitmq_shovel" "tfer--someshovel" {
  name  = "someshovel"
  vhost = "someVhost"
}

Clearly its missing info definition for shovel but I cannot seem to find where it should be done :(

I found out why it wasn't working as it expected. It's a problem in terraform rabbitmq provider. After updating to use v2.6.0 (rabbit-hole) and changing data types for shovelInfo.Definition.SourceURI - shovelInfo.Definition.DestinationURI it worked as expected. I'll submit a pr to the tf provider/rabbit-hole
It seems destination_uri/source_uri


BulkRead does not work for views

Hi, when I try to use BulkRead to read entities from a SQL Server view, the method throws an exception 'Entity does not contain a table name'. When I look into the code, I think the IEntityType.GetTableName() form Entity Framework Core is used. This method indeed will return null for entities mapped to SQL views. IEntityType.GetViewName() should probably be used instead.
Is it possible to add support to BulkExtensions.BulkRead to read entities from a view? That would be great!
Versions being used by me at the moment:

Microsoft.EntityFrameworkCore version 7.0.11
EFCore.BulkExtensions version 7.1.6

entity definition:
public class MyViewItem
{
    public long Id { get; set; }

    public int TenantId { get; set; }

    [Required]
    [MaxLength(100)]
    public string Description { get; set; }
}

DbContext:
public class MyContext : DbContext
{
    public DbSet<MyViewItem> MyViewItems { get; set; }

    public MyContext(DbContextOptions<MyContext> options) : base(options)
    {
    }

    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        modelBuilder.Entity<MyViewItem>(entity =>
        {
            entity.HasKey(item => new { item.TenantId, item.Id });
            entity.ToView("MyView");
        });
    }
}

Code to read (which throws the exception):
public async Task<IEnumerable<MyViewItem>> ReadViewItems(List<long> ids)
{
    var tenantId = 1;
    var entities = ids
        .Select(id => new MyViewItem { Id = id, TenantId = tenantId })
        .ToList();

    using (var context = _contextFactory.Create())
    {
        await context.BulkReadAsync(entities, config =>
        {
            config.UpdateByProperties = new List<string> { nameof(MyViewItem.TenantId), nameof(MyViewItem.Id) };
        }).ConfigureAwait(false);

        return entities;
    }
}

SQL Server view
CREATE OR ALTER VIEW [MyView] AS
SELECT [TenantId]
     , [Id]
     , [Description]
FROM   [MyTable]

Will look into it.

Hi @borisdj, do you have an update on this?
The support for bulk reading from a sql view should be fairly easy I think. The when the IEntityType.GetTableName() from Entity Framework Core returns null, IEntityType.GetViewName() can be used as a second check?


warning on scope mismatch

Creating a function-level .NET rule but using - match: compiled to the .NET platform does not raise an error or give any other failure information, however, matching fails.

we should be able to catch this in the linter and reject this when actually running capa


Using same port for HMI and Vision System

Using same port no for both HMI and Vision System

Seems that this is not what was happening


Updated IOCTypes.

Description
Updated IOCTypes.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The cypress tests are known to be flaky when executed in a windows environment.
The ubuntu environment cypress tests workflow was canceled when the windows workflow failed; but the tests passed up until then. Will rerun the workflows separately.
https://github.com/opensearch-project/security-analytics-dashboards-plugin/actions/runs/9883120082/job/27297265089?pr=1076#step:20:238


F2 Score and mAP metric for object detection model.

I didn't find a metric regarding the object detection task in keras.
How to implement the above two metrics in keras and use them? In this competition, https://www.kaggle.com/c/tensorflow-great-barrier-reef/overview/evaluation uses the F2 score for its object detection task but I don't know how to evaluate my model locally with this score?

The metric sweeps over IoU thresholds in the range of 0.3 to 0.8 with a step size of 0.05, calculating an F2 score at each threshold. For example, at a threshold of 0.5, a predicted object is considered a "hit" if its IoU with a ground truth object is at least 0.5.

@Suzan009
Please post this issue on keras-team/keras repo.
To know more see;
https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999
Thanks!

I did. But I also want to achieve this in pure tensorflow.

@Suzan009
Please follow the TFOD API code and tensorflow garden, as this repo is for bugs and feature request, we request you to move this issue to closed status and for any further queries open a new issue at discussion forum which has larger community to help.
Thanks!

@Saduf2019 I am not following the messy repo of the tensorflow-model garden. In fact, this so-called model garden repo should be closed.
I'm simply looking to get the implementation of these two metrics in pure tensorflow. Asking or suggesting to look into TFOD API, you're making someone's life harder.

@Suzan009
You may take the following command as a reference to get the mAP values.
python models/research/object_detection/model_main_tf2.py
--model_dir = <YOUR_MODEL_PATH>
--pipeline_config_path = <YOUR_PIPELINE.CONFIG_PATH>
--checkpoint_dir = <YOUR_CHECKPOINT_DIR_PATH>
Alternatively, you can visualize these metrics on Tensorboard by initiating Tensorboard in the eval directory.
As informed earlier this repo is for bugs you have to open this issue in tf discussion forum.


Add eslint and prettier

Hey people,
I created this issue just to represent the PR already submitted before but I created it without an issue opened related. #71.
Basically, we should think about organization and standardization, so I submitted a simple configuration of eslint and prettier. And obviously, we can improve other things over time, but for the moment I saw reason to just go here. These configurations already support the project well the development experience and we are already unlocked to analyze indentation, for example, future reviews. So from that moment its just saves the file and everything is automatically adjusted. Also, I added .idea and .vscode in gitignore.

prettier configuration is added in the package.json file.

prettier configuration is present in the package.json file.

@mosmk2 you right, I'm gonna review it.

Done!


Added formal charge to components, chemicalstate

Adds formal_charge property to ChemicalState, all defined Component classes so far.

Hello @dotsdl! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file gufe/chemicalstate.py:

Line 106:80: E501 line too long (88 > 79 characters)

This only hitch with this method is I'm not sure what the solvent component charge is. It's technically anything, and won't know its charge until it sees the State, (and I don't want a gross reference to the State in SolventComponent).

Return the solvent charge if the solvent is properly defined (i.e. you passed in a solvated system), otherwise return NaN / None / other undefined value? Technically it's undefined at this stage and that's ok. Internally unless pre-defined we assume neutrality until ion addition happens.

@dotsdl I merged main into this and added the proposed SolventComponent formal charge implementation


Allow pressing Enter on a Delete Confirmation Dialog to proceed with the deletion.

Is your feature request related to a problem?
When I press SHIFT+DEL to delete some files, I'm used to Windows asking if I'm sure with a Yes/No prompt, with Yes auto-focused. This allowed me to simply press SHIFT+DEL+Enter to proceed.
Describe the solution
Like Windows File Explorer's own Dialog, it would be ideal to autofocus on the "Delete" button so I can simply press enter.
Describe alternatives you've considered
N/A
Scope

Capability
Priority

Press Enter on a Delete Confirmation Dialog to proceed with Deletion
Must

Mouse should not need to be used
Should

System Information

OS Version: Windows 11 22000.100
App version: v<IP_ADDRESS>

Additional comment
N/A

@rlaphoenix this should already be implemented in v1.9.15, can you check if it ever works?

@rlaphoenix this should already be implemented in v1.9.15, can you check if it ever works?

I've tried already. It seems to focus on the first file in the list of items to be deleted, so pressing enter tries to click on the file rather than the button.

Ok strangely I've retried again, and it now works fine. That's quite odd. I was definitely testing this on v1.19.15 too.

I've found out why! The bug in question only occurs if the "Permanently delete" is disabled (cannot be unticked). E.g. while deleting from the Recycle Bin.

This has been resolved with #7882


Maximize popup window size for using screen estate

JENKINS-44470

Thank you for submitting this!  It looks very appealing, but please can you include a screenshot of the result?
Will need to do some manual testing at a variety of resolutions and browsers to verify if this works correctly in all the cases, so may be a while before I can get back with a clear mergeable/changes needed result.

I am still working on polishing this as I found some problems during testing. I will be back with updates and screenshots! Everyone loves them :)

@ssbarnea Did you ever get this to where you're happy with it?  I'm doing a sweep through PRs this week to try to get everything tested/merged, and this would be a good candidate for the next release.

@svanoort Thanks for pinging me on this as I didn't do anything on it due to other priorities. But your sale point convinced me to spend an extra hour or two and fix it.

@ssbarnea Any word on this change?  Still looking to include it into a release


Write example cases like many other crates have

Many crates have example cases in an examples folder which can be compiled and run right out of the gate to give users something to work with. The examples in the README.md file should be translatable.

I was thinking about that. What do you think good examples would be? A possible issue is the fact that we need something running on the ROS side for this to work. Should I fork roscore and rospy_tutorial/add_two_ints_service as part of a Client example, or should I just leave it to the user to launch them, and just explain it in the README, combined with error messages within the example?
I'm leaning towards the latter one, since it feels like it makes more sense

I would only distribute the required rust code in the examples, and leave notes in the README about how to download and launch the appropriate ros service to make the examples work.
I would possibly consider a script for downloading and building the proper programs for the install and the appropriate ros_launch commands. That is just my opinion though.

Doing roslaunch stuff would be something for after actual integration into the ROS ecosystem (doing that right now)
I'll use rospy tutorial examples to communicate with - they come bundled in the full desktop installation of ROS

I got approval for my Rust message generation package to be pulled into ROS's respository - ros/rosdistro#13528. I'll have to wait a few days before requesting integration into message generation and ROS core, but in any case - I'll probably make these examples once I have message generation integrated into ROS core.

Examples can't work in the same repo - at least for now. Using the library at all requires message generation. There is an example by @OTL that works at OTL/rosrust_tutorial
It's a string message sending/receiving with a publisher and subscriber, and uses the master branch. I'll soon push out a release that contains all the major changes made since the last release!


confluence-server-url

I want to migrate confluence to my personal url, how can we do that. What configuration I need to do ?
Do I need to change only confluence _server_url ?
Request to guide in this.

The two key configurations would be confluence_server_url and confluence_space_key. The values will depend on if the content is being posted to a personal Wiki of a Confluence Cloud instance or Confluence Data Center. If hosted on the same Confluence instance in your original configuration, you only need to update confluence_space_key. For confluence_space_key, set is to the name of the personal Wiki. This may be a value such as ~123456789 on Cloud, or may include the target username ~myusername on other variants.

We already migrated to data center, I am facing authentication error.

For authentication, are you using a PAT which you configure into a confluence_publish_token option? Also ensure confluence_server_user is not set.
When configuring confluence_space_key for a personal Wiki, ensure it includes the ~ prefix.
If you have connection issues, maybe try the troubleshooting mode?

Ok sure I will work on this

still it is showing me error.

@avkulkarni1620, the provided image did not appear to work. Can you re-attach and/or provide some output when trying to troubleshoot?

This has been open for a couple a releases and more so looks to be a support case. If the issued case repeats itself with a recent release, feel free to re-open or create a new issue. For now, marking as closed.


Shift-return doesn't always launch Spotter

From a freshly opened GT window, type Shift-Return to open Spotter and type a search term.
Type Esc to close the Spotter popup, without having selected/inspected anything in it.
The Spotter icon remains in "selected" state (see screenshot below), and Shift-Return will not launch Spotter.

To get Shift-Return back, I either have to press Esc again, or click on the Spotter icon.

thanks for the bug report!
solved via https://github.com/feenkcom/Brick/commit/8cdc561712d94766418b2050321cd491babf9a87

thanks for the bug report!
solved via https://github.com/feenkcom/Brick/commit/8cdc561712d94766418b2050321cd491babf9a87