Running multiple build variant license tasks crashes build

In a project with a few different build variants, running a full gradle build results in a crash.
The crash seems to be caused by each variant's license task conflicting with one another. When the first license task runs, it creates a configuration called 'poms'. Then when the second variant's license task runs, it attempts to create the same configuration, which crashes since it already exists.
Here's a small example app that demos this issue: https://github.com/egargan/license-plugin-issue-demo.
The error output can be viewed in the  /gradle-build-error-output file. The /app/build.gradle file sets up the calls to each task.

I get this error:
$ gradlew build

> Task :app:licenseDebugReport
Wrote HTML report to file:///Users/noname/repo/license-plugin-issue-demo/app/build/reports/licenses/licenseDebugReport.html.
Wrote JSON report to file:///Users/noname/repo/license-plugin-issue-demo/app/build/reports/licenses/licenseDebugReport.json.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:licenseReleaseReport'.
> Cannot add a configuration with name 'poms' as a configuration with that name already exists.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 12s
30 actionable tasks: 30 executed

Yep that's the issue we're getting too, is this expected behaviour? We're currently just deleting the 'poms' configuration after each task which seems to work fine - we get good output from the license task for each build variant. I'm thinking maybe this is something that should be done by the task itself?

Maybe we should create a separate configuration per variant?

Thanks for addressing this!


Does not seem to work with Immutable.js

Hi,
I have Immutable.js map in the store that I am trying to listen to changes on:
as in:
let w = watch(appStore.getState, 'notify.currentAction', isEqual);

and yet I don't get an event for when Map currentAction gets modified (if I removed currentAction all works per reducer only)
is that not supported?
regards
Sean

found problem, so closing...

@born2net how did u solve it? i am stuck at the same place

I ended up creating my own version of the lib (with some added helper methods)
see here:
https://github.com/born2net/angular2-redux-util

For those who still want to use the library, there's a fix. When you create your watchers:

Pass a function that returns the .toJS() version on your store
Pass a compare function using _.isEqual() (or any other function to compare but this one is pretty good)

Example:
import store from 'store';
import watch from 'redux-watch';
import _ from 'underscore';

const compare = (a, b) => {
    return _.isEqual(a, b);
};

// create watchers
const pathExample = 'app.isLoaded';
const callback = (appLoaded, prevAppLoaded) => {
   console.log('app loaded!', appLoaded);
};

const watcher = watch(() => { return store.getState().toJS(); }, pathExample, compare);
const subscription = store.subscribe(watcher(callback));

Actually, forget about my last comment. It works, but it's really, really slow and use immutable.js in a bad way.
Inspired by the work on the library, we created redux-watch-immutable that just works for immutable object (and it's crazy fast!)


Local date time cell renderer

This PR adds the ability to render local datetime using client side scripting.
Linz will now allow customisation for:

date format
datetime format
localise date by default

This configuration can change when initialising the application. See linz default.js for the default values.
This PR also includes 3 other date renderers, they are:

dateTimeRenderer
localDateRenderer
localDateTimeRenderer

@sandytrinh, how is the localDateRenderer and localDateTimeRenderer used on the client-side? Because ISO 8601 isn't really a localised date format?
Have you seen http://momentjs.com/docs/#/i18n/instance-locale/? Would it be better to use something like that? I'm not really sure how it's being used...


Feature request: Add ability to change location of the keystrokes display

At the moment the location defaults to bottom left corner of the screen - would it be possible, to ideally, set location freely?

As demonstrated in the README, you can drag it to your preferred position


Vertical NavBar

Hi,
Is there sample for vertical NavBar? The one in the current demo shows only a horizontal layout. Option to switch it vertical or Horizontal would be great.

+1 needing it right now ;)

You're right - currently we only have the horizontal one. We're looking into the vertical one! Switching between the layouts is an interesting idea...

Do we have a design for this that's ready to be implemented, or is it a future request?

We don't have any designs for this or plans to build it in the near future, so I've added it to our roadmap.


Optional, hidden, and alias support

Which issue does this fix?

Closes #5
Describe the solution

This change adds support for subcommand alias, hidden subcommands, and optional arguments.
Subcommand aliases can be specified by separating the command name with "//".
So # command (arg) becomes # command//c (arg).
Commands can be hidden from the help screen by simply prefixing the command name with "_".
To make an argument optional, simply add a question mark. (optional?)

Note that I did not make changes to the documentation. Prettier is opinionated and making changes there would make review more difficult. Ultimately doing that though would make contributions easier.
Also note this is my first day writing Rust.

Sure thing. I'll address those requests and split this up when I find the cycles.

Closing in favor of split.


[BUG] :ui popup causes bug with racket--send-to-definition

Using :ui popup together with racket-mode causes buggy behavior when updating a definition via racket-send-definition.
Instead of updating the definition, I get an error message and the function now does not work in the Racket REPL anymore.
The issue disappears when I disable :ui (popup +all +defaults) in my init.el and run doom re.
There's also an issue open at the racket-mode github. Link.

Debugger entered--Lisp error: (args-out-of-range # 20 68)
  process-send-region(# 20 68)
  comint-send-region(# 20 68)
  racket--send-region-to-repl(20 68)
  racket-send-definition(nil)
  funcall-interactively(racket-send-definition nil)
  call-interactively(racket-send-definition nil nil)
  command-execute(racket-send-definition)

Steps to reproduce

Open a file
For example:

#lang racket

(define (hello-world)
    (print "hello, world"))

Run racket-run
This opens the REPL and executing (hello-world) prints "hello, world".

Change the definition of (hello-world) to

(define (hello-world)
    (print "hello, world!"))

Execute (racket-send-definition) with the point inside the parenthesis of define.

Receive `Args out of range: #<buffer *Racket REPL#>, 20, 68.

Trying (hello-world) in the REPL now does nothing.
In *Messages* the following error shows up: comint-send-region: Args out of range: #<buffer *Racket REPL*>, 20, 68.
System information

emacs   version    26.3
        features   JPEG RSVG IMAGEMAGICK GLIB NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS LCMS2
        build      Nov 20, 2019
        buildopts  (--disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/Users/herwig/.brew/share/emacs/site-lisp --infodir=/Users/herwig/.brew/Cellar/emacs-plus/26.3/share/info/emacs --prefix=/Users/herwig/.brew/Cellar/emacs-plus/26.3 --with-xml2 --without-dbus --with-gnutls --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained)
        windowsys  ns
        daemonp    server-running
doom    version    2.0.9
        build      HEAD -> develop 83090894d 2019-11-21 00:50:25 -0500
system  type       darwin
        config     x86_64-apple-darwin18.7.0
        shell
        uname      Darwin 18.7.0 Darwin Kernel Version 18.7.0: Tue Aug 20 16:57:14 PDT 2019; root:xnu-4903.271.2~2/RELEASE_X86_64 x86_64
        path       (~/.brew/bin/ ~/.local/bin/ ~/.brew/sbin/ ~/.emacs.d/bin/ ~/.cargo/bin/ /usr/local/bin/ /usr/bin/ /bin/ /usr/sbin/ /sbin/ /usr/local/share/dotnet/ ~/.dotnet/tools/ /usr/local/MacGPG2/bin/ ~/.emacs.d/bin/ ~/.emacs.d/cask/bin/ ~/.local/share/cargo/bin/ ~/.local/share/pyenv/shims/ ~/.local/share/pyenv/bin/ /usr/local/sbin/ ~/.dotfiles/bin/ ~/.local/share/dotfiles/base.macos.topic/bin/ ~/.local/share/dotfiles/shell.git.topic/bin/ ~/.brew/Cellar/emacs-plus/26.3/libexec/emacs/26.3/x86_64-apple-darwin18.7.0/)
config  envfile    envvar-file
        elc-files  0
        modules    (:completion (company +childframe) (ivy +childframe +fuzzy) :ui doom doom-dashboard doom-quit fill-column hl-todo hydra modeline nav-flash ophints (popup +all +defaults) (pretty-code +fira) treemacs unicode vc-gutter vi-tilde-fringe window-select workspaces :editor (evil +everywhere) file-templates (format +onsave) lispy multiple-cursors rotate-text snippets :emacs (dired +icons) electric vc :term eshell :tools debugger editorconfig eval flycheck flyspell (lookup +docsets) lsp macos magit :lang (cc +lsp) common-lisp data emacs-lisp (haskell +lsp) latex (org +dragndrop +ipython) python racket (rust +lsp) (sh +fish) :config (default +bindings +evil-commands))
        packages   (n/a)
        elpa       (n/a)

Can you reproduce this in vanilla Emacs? (see https://github.com/hlissner/doom-emacs/blob/develop/docs/getting_started.org#testing-in-dooms-sandbox for how)

How do I enable just :ui popup in Vanilla Emacs?
Running doom/sandbox, then (require 'racket-mode) and finally the steps outlined above do not reproduce the issue for me.

Hi, Racket Mode author here.
I'm only skimming the popup README but I noticed mention of display-buffer-alist as well as the second example "popup rule" ("^\\*" :select t). Does that mean that anytime display-buffer is called, not only will the buffer be displayed in a window, but it will also change the currently selected window to that?
If so, that might explain the problem? Racket Mode uses comint-send-region which calls process-send-region to copy some text from the selected .rkt buffer to the *Racket REPL* comint buffer. process-send-region takes the target process/buffer as an argument. The source is not specified; it is the selected window's buffer.
Something else Racket Mode does, is display the REPL and move to the end of the buffer, before the send-region.
So if Doom Emacs is causing the "display" to mean "display and also select", that might explain this?
@Herbsi what if you try adding a set-popup-rule! to exclude "*.rkt" buffers? I'm not sure the exact syntax but maybe @hlissner could help with that?

[I suppose I could also look at changing Racket Mode to do the display-buffer after the comint-send-region. That would probably avoid this problem. OTOH this is the first such issue in many years, and, I don't know if that might cause some other, new problem(s).]

@Herbsi Alternatively I just commented with a potential little patch you could try if you're comfortable.

Does that mean that anytime display-buffer is called, not only will the buffer be displayed in a window, but it will also change the currently selected window to that?

@greghendershott Only if the buffer's name starts with an asterix.

what if you try adding a set-popup-rule! to exclude "*.rkt" buffers? I'm not sure the exact syntax but maybe @hlissner could help with that?

That should work. @Herbsi give this a try:
(after! racket-mode
  (set-popup-rule! "^\\*Racket REPL\\*" :select #'ignore))

While the (after! racket-mode ...) isn't strictly necessary at this time, I may add this (or another popup rule) to the :lang racket module. If/when I do so, the after! will ensure your rule has precedence over mine (principle of least surprise).

(after! racket-mode
 ;; Passing `#'ignore` to `:select` tells the popup manager to not do any focus
;; management. `nil` would focus the origin window while `t` would focus the
 ;; new popup window.
 (set-popup-rule! "^\\*Racket REPL\\*" :select #'ignore))

@hlissner The popup rule did not fix my issue, but @greghendershott 's "patch" did.

@hlissner It looks like I'll be able to fix this in Racket Mode itself, e.g. this commit. It seems reasonable to fix it on my end -- I just didn't realize that display-buffer could possibly also change the selected window and current buffer; now I know. So unless @Herbsi disagrees you could probably close this issue here.

The commit fixes the issue for me, so I have no problem with closing this issue.


Clarify Providers Setup in Documentation

The documentation for setting up provider secrets needs clarification regarding which files are for Android and which are for iOS. We shouldn't assume developers are familiar with Android or iOS, as many may come from desktop and web backgrounds.
Proposed Changes:
Update the setup steps to include these notes:
# In apps/sample-app/android
# Note: The local.properties file is for the Android setup.
cp local.properties.sample local.properties

# In apps/sample-app
# Note: The .env file is for the iOS setup.
cp .env.sample .env

CC - @artus9033 in case it similarly applies to Maps. Thanks!

Hey @dzuluaga, thanks for bringing this to our attention! This has been addressed and should be fixed in https://github.com/openmobilehub/react-native-omh-auth/pull/70/commits/b08882e32025c132ed5b6f91a84917ed60d86861.

Thanks. LGTM


Remove the configuration of helm-releaser that we no longer need

Signed-off-by: aisuko<EMAIL_ADDRESS>Description
We can remove this config due to the current Helm CI(https://github.com/meshery/meshery/blob/26b27c46101c3b9ae53337c06b985605a4fc0255/.github/workflows/helm-chart-releaser.yml#L70) no longer need an independent configuration that needs to hold on in the root folder.
For more detail please check at the homepage of the repo  https://github.com/stefanprodan/helm-gh-pages
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #3364 (6ac5da3) into master (05cda78) will decrease coverage by 0.75%.
The diff coverage is 0.31%.

@@            Coverage Diff            @@
##           master   #3364      +/-   ##
=========================================
- Coverage    7.02%   6.27%   -0.76%
=========================================
  Files          23      35      +12
  Lines        1409    2743    +1334
=========================================
+ Hits           99     172      +73
- Misses       1303    2549    +1246
- Partials        7      22      +15

Flag
Coverage Δ

integrationtests
?

unittests
6.27% <0.31%> (-0.76%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/config/config.go
1.11% <0.00%> (-1.12%)
:arrow_down:

mesheryctl/internal/cli/root/perf/perf.go
50.00% <ø> (ø)

mesheryctl/internal/cli/root/system/check.go
1.94% <0.00%> (ø)

mesheryctl/internal/cli/root/system/start.go
1.53% <0.00%> (-0.01%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (ø)

mesheryctl/internal/cli/root/system/stop.go
1.08% <0.00%> (-0.07%)
:arrow_down:

mesheryctl/pkg/utils/auth.go
0.00% <0.00%> (ø)

mesheryctl/pkg/utils/error.go
0.00% <0.00%> (ø)

mesheryctl/pkg/utils/formatter.go
0.00% <0.00%> (ø)

mesheryctl/pkg/utils/healthcheck.go
18.75% <0.00%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b27c4...6ac5da3. Read the comment docs.


Webbsite brandkit

Summary of changes
Finish the Brand Kit page
Proposed area of change
Put an x in the boxes that apply.

[ ] apps/bridge-dapp
[ ] apps/stats-dapp
[x] apps/webbsite
[ ] apps/faucet
[ ] apps/tangle-website
[ ] libs/webb-ui-components

Reference issue to close (if applicable)
#1129
Screen Recording
If possible provide a screen recording of proposed change.

Code Checklist
Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

@vutuanlinh2k2 Users should be able to download assets only when they click the Download button.
https://user-images.githubusercontent.com/53374218/236592051-2f6f8f4c-8285-49fe-b4c9-25fdd2382eec.mp4


Jenkins HTML report is not showing Gauge.writeMessage logs.

Hi,
While running test with Intellij Gauge HTML report showing correct logging for Gauge.writeMessage("test");
But if run the same with Jenkins [local Jenkins setup on same my machine only], HTML report doesn't show Gauge.writeMessage logs.
Earlier it used to work. Not sure which update caused this issue.
Expected:  Gauge.writeMessage logs should display in html report even we run test with Jenkins.
Actual:  Gauge.writeMessage logs is NOT displaying in html report ifwe run test with Jenkins.
Refer the attached both snapshot.

Gauge version: 1.0.5
Commit Hash: 562f036
Plugins
html-report (4.0.8)
java (0.6.9)
screenshot (0.0.1)

@vinodbhardwaj1 This should not be the case. Are you sure the same html-report and Gauge versions are used on your local and Jenkins machines?
Can you try printing the gauge version from your Jenkins machine and paste its output here?

@vinodbhardwaj1 any updates ? where you able to check the versions in jenkins ?

Closing this due to inactivity. Feel free to reopen if you are still facing this.


Use StringArrayVarP for --include and --exclude flags

Replace StringSliceVarP with StringArrayVarP for the --include and --exclude flags so regex strings can contain colons.
With the current StringSliceVarP implementation, it is impossible to accurately search for (or eliminate) a specific key/value pair if your service emits log lines in json:
$ stern -e '"pod.iam.role":""' r1-kiam-agent
Error: invalid argument "\"pod.iam.role\":\"\"" for "-e, --exclude" flag: parse error on line 1, column 14: extraneous or missing " in quoted-field
Usage:
  stern pod-query [flags]

With these flags defined as StringArrayVarP this works correctly:
$ dist/stern -e '"pod.iam.role":""' r1-kiam-agent
+ r1-kiam-agent-kg85t › kiam-agent

@rkmathi I've updated README.md. PTAL.


make VOLUME declaration in docker absolute

Otherwise some docker versions complain about:
docker: Error response from daemon: failed to create shim: OCI runtime create failed: invalid mount {Destination:data Type:bind Source:/var/lib/docker/volumes/8c57860badfdf66bd32f64fe4b22970bcbb1f0f13a5d134ec451458a823dec6f/_data Options:[rbind]}: mount destination data not absolute: unknown.

Also see docs for VOLUME which suggest this path should be absolute: https://docs.docker.com/engine/reference/builder/#volume
Fixes #465.

Codecov Report

Merging #466 (4a3ae15) into master (c8ab5a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   75.30%   75.30%
=======================================
  Files         152      152
  Lines       25275    25275
=======================================
  Hits        19033    19033
  Misses       6242     6242

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ab5a4...4a3ae15. Read the comment docs.


Make git tag version prefix configurable

In function set_versions(), when outputting the new version as a git tag, a prefix "v" is hard-coded before the version. I've seen the convention many places, but I haven't adopted it because any alphabetic character is a suffix. It appears the v prefix is not used for any other output formats, which also seems inconsistent.
So my question/discussion becomes: can the hard coded v prefix become configurable or defeatable?
I could hack a simple PR fix for an environment variable to define the prefix if desired.
My ideal use case may not be the same for others, but I'd prefer the option! Interested in seeing if there are any other thoughts or what the origin/justification/convention is for the v prefix.
Thank you!

It's an easy enough feature, but it makes me regret not having based setver on bashew (it predates it a bit), because then it would have been super trivial to e.g. put the prefix you always use in the .env file (in your case prefix="").
I'll keep the rewrite to bashew for a v2.0, but I will already add your feature!

Actually, it's a bit more complex. When you bump/set a version (e.g. "1.3.4") through npm, npm actually creates the git tag and automatically adds the "v" prefix (so "v1.3.4") . That was why I hardcoded it in setver, I assumed it was the standard procedure everywhere.
It should still work like you proposed for repos without package.json file.

Added to 1.15.0

Thank you for the rapid response, really! You also answered my question about bashew. :)
I'll open a new issue since I've still not been able to get an unprefixed version into git tags yet with the latest release; I'll show how I tried to adopt (and failed).

Try the version 2.0.x! It also supports the .env files, so you can add a prefix="" line to your .env file

Thank you!


Adding a rain effect project

I would like to add a Realistic Rain effect Project using Three.js in JavaScript. I will create cloud, lights and all the external things manually using CSS and JS manipulation.
The clouds will look like this:

The black color background of lighting will look like this:

I will merge it all up and create animation for the realistic rain effect.
Please assign me this issue under GSSOC'21 participation @ridsuteri @991rajat @harshgupta20
[gssoc21]

@anushree71199 any updates ?

@Ankita297 Can I work on this issue under LGM-SOC 21. Please assign it to me.

@Deep06-11 go for it .


Bug: Cannot insert image to new inserted table row in playground

Lexical version: 0.12.5
Steps To Reproduce

Insert a table
Insert a new row
Insert a image on new row

Link to code example:

The current behavior

Console show error

https://github.com/facebook/lexical/assets/72237443/4d8d89c5-8882-4bda-81f0-9f3e13ecec8a
The expected behavior

Should be able to insert image into table

By now, I temporarily fixed this by getting new inserted table row then loop through its cell and add the empty paragraph
`
const insertTableRowAtSelection = useCallback(
(shouldInsertAfter: boolean) => {
editor.update(() => {
$insertTableRow__EXPERIMENTAL(shouldInsertAfter);
    // get inserted table row node
    const tableNode = $getTableNodeFromLexicalNodeOrThrow(tableCellNode);
    const tableRows = tableNode.getChildren();
    const tableRowIndex = shouldInsertAfter ? tableRows.length - 1 : 0;
    const tableRow = tableRows[tableRowIndex];

    // Loop through table row and insert empty paragraph nodes
    const tableCells = tableRow.getChildren();
    for (let i = 0; i < tableCells.length; i++) {
      const tableCell = tableCells[i];

      if (!$isTableCellNode(tableCell)) {
        throw new Error('Expected table cell');
      }

      tableCell.append($createParagraphNode());
    }

    clearTableSelection();
    onClose();
  });
},
[clearTableSelection, editor, onClose, tableCellNode]

);
`

Duplicate of https://github.com/facebook/lexical/issues/5286

The fix for this issue seems to be in #5912

This works now. Closing.


Style in CSS

Description
In this document I'll be explaining the different styles in CSS.
Domain
Frontend Dev HTML/CSS/JS
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign

/assign

/assign

/assign

/assign

/assign


Added missing doc comment characters

The documentation comments are missing the ":" character is missing, so it's not highlighted correctly.
Hopefully this will be fixed at some point.

@cla-bot check


Add send sticker service to telegram bot

Description:
Allows sending webp stickers. The size of the sticker must be less than 512x512 px. I used https://www.gstatic.com/webp/gallery3/2_webp_a.webp for testing.
Pull request in home-assistant.github.io with documentation (if applicable): TBD.

It would help if you provide samples to test new features. Copy-and-paste make the reviewer's life easier.

@fabaff Why do we merged without docs?

Because I'm adding them myself to speed things up.

👍 Awesome!


Node16 Deprecation

Ansible v10 doesn't work well with Amazon Linux 2, so I needed something like this. I can make my own, this is a very simple action, but you already made one and published it, so I thought I'd start there. ;)
But ... I'm getting warnings about Node16 being deprecated, which looks like it's related to setup-python@v4; I can make a PR to upgrade if that helps. ;)

thanks, that would be nice!

See PR #3.


chore(main): release 0.37.3

:robot: I have created a release beep boop
0.37.3 (2023-05-26)
Bug Fixes

deps: update dependency intl to ^0.18.0 (#336) (8105668)

Code Refactoring

dart fix (21a5c0d)
resolve deprecated warnings (3e24bc2)

Miscellaneous Chores

ignore: avoid_positional_boolean_parameters (dae8f71)
rerun build_runner (ed75d04)
save IDEA config (499fdef)
update gitignore (8a3cf37)

Build System

flutter pub upgrade (3cfd1a0)
update build.gradle (2367ad9)
update ios configs (520a685)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/CCXXXI/ecg_monitor/releases/tag/v0.37.3 :sunflower:


Rename packages

Changed spark version to 2.1.3 and renamed packages

Can you also remove Java 7 from the travis configuration?


Incorrect linebreaks

I'm using Android Studio 3.2 (Windows) with gradle 4.6 and stringcare 0.7, everytime I build my app String care removes all linebrakes from strings.xml making it a single line file.

Hi @abraaocaldas, could you solve the issue?

I'm sorry about that, thanks for testing! 🙂
How did you resign the APK? It isn't a common task, only (afaik) in APK publishing if you use an upload key as the local fingerprint.


Added color plotting for labelled data

Added:

Data points on projected graphs now have colors instead of label names
A legend describes the mappings of colors to label
Dimensions can now be given names which will be displayed as heading of the projections
Modified:
Filenames are now saved with dimension name if possible

Looks good, thanks for the contribution.


AssertPFSIOU task keeps retrying until 5min timeout even if it's succeeding

Description
It eventually succeeds, but takes 5min timeout, even though the request condition is fulfilled in the first request.
I didn't notice this behavior on other tasks, only on AssertPFSIOU
Task:
AssertPFSIOU 0:04:04.681630: {'source': 3, 'amount':<PHONE_NUMBER>00000000}

Logs filled with:
{"url": "https://pfs.transport01.raiden.network/api/v1/_debug/ious/0xA0661172D1aD4eDf76fDF3fAd2bE5F49ac9f4425", "method": "get", "json": {}, "event": "Requesting", "logger": "scenario_player.tasks.api_base", "level": "debug", "greenlet_name": "orchestration", "timestamp": "2020-10-08 13:45:40.442408"}
{"json": {"sender": "0xA0661172D1aD4eDf76fDF3fAd2bE5F49ac9f4425", "amount":<PHONE_NUMBER>00000000, "expiration_block": 3739450}, "event": "Received response", "logger": "scenario_player.tasks.api_base", "level": "debug", "greenlet_name": "orchestration", "timestamp": "2020-10-08 13:45:40.607931"}
{"ex": "None", "event": "Assertion failed, retrying...", "logger": "scenario_player.tasks.base", "level": "debug", "greenlet_name": "orchestration", "timestamp": "2020-10-08 13:45:40.609282"}

Return of that _debug URL request:
{
    "amount":<PHONE_NUMBER>00000000,
    "expiration_block": 3739450,
    "sender": "0xA0661172D1aD4eDf76fDF3fAd2bE5F49ac9f4425"
}

Expected Behavior
The task succeeds the first time the URL returns the expected value.

Same is the case with assert_events task
## Wait for channel to be closed
      - wait_blocks: 10
      - assert: {from: 0, to: 1, total_deposit: 1_000_000_000_000_000_000, balance: 500_000_000_000_000_000, state: "closed"}
      - assert_events:
          contract_name: "TokenNetwork"
          event_name: "ChannelClosed"
          num_events: 1
          event_args: {closing_participant: 0}

{"task": "<AssertBlockchainEventsTask: {'contract_name': 'TokenNetwork', 'event_name': 'ChannelClosed', 'num_events': 1, 'event_args': {'closing_participant': 0}}>", "id": "10", "event": "Starting task", "logger": "scenario_player.tasks.base", "level": "info", "greenlet_name": "orchestration", "timestamp": "2020-10-08 09:43:16.430773"}
{"timeout": 300, "event": "Running task with timeout", "logger": "scenario_player.tasks.base", "level": "debug", "greenlet_name": "orchestration", "timestamp": "2020-10-08 09:43:16.433063"}
{"ex": "None", "event": "Assertion failed, retrying...", "logger": "scenario_player.tasks.base", "level": "debug", "greenlet_name": "orchestration", "timestamp": "2020-10-08 09:43:16.837555"}
.
.
.
{"ex": "None", "event": "Timeout reached", "logger": "scenario_player.tasks.base", "level": "debug", "greenlet_name": "orchestration", "timestamp": "2020-10-08 09:48:16.450198"}
{"id": "10", "task": "<AssertBlockchainEventsTask: {'contract_name': 'TokenNetwork', 'event_name': 'ChannelClosed', 'num_events': 1, 'event_args': {'closing_participant': 0}}>", "runtime":<PHONE_NUMBER>220036, "event": "Task successful", "logger": "scenario_player.tasks.base", "level": "info", "greenlet_name": "orchestration", "timestamp": "2020-10-08 09:48:16.451324"}


new url for css

https://bootswatch.com/4/flatly/bootstrap.min.css

@benoitwimart Just use this link for CSS: https://bootswatch.com/3/flatly/bootstrap.min.css instead of new one.


Gc aligner

Based on PR #1710 by @kyrasolaris01
Creating another PR to keep the two versions separate and comparable.

Much of the heavy scheduling of the alignment of rows onto base rows was extracted into a BaseFeatureListAligner.
The different scoring for GC and Join is split into FeatureRowAlignScorer implementations.
FeatureCloner defines how features are cloned - either just cloned or reextracted in the case of GC if feature has a different mz than the row.
The module and class of Gc and JoinAligner are now precisely the same, ignoring minor naming differences.

@ansgarkorf I fixed the GC score. It seems the similarity was inverted.
Can you check the results on your side

whats different than before?

Speed is good, was something else! Looks all good!


Invoke-AzOps fails when Core.AutoGeneratedTemplateFolderPath is changed from default

When changing the auto generated folder path for AzOps deployments no longer work.

Update settings.json key "Core.AutoGeneratedTemplateFolderPath"  to anything other than the default , i.e. "/.state"
Create new branch, add template to deploy (or modify value of existing), issue PR

[12:09:32][New-AzOpsScope] Starting creation of new scope object
[12:09:32][New-AzOpsScope] Execution Confirmed: Creating a new scope from a path
[12:09:32][AzOpsScope] Calling Constructor with value /home/runner/work/ecorp/ecorp/root/tenant root group (***)/ecorp (ecorp)/ecorp-platform (ecorp-platform)/ecorp-connectivity (ecorp-connectivity)/sub-prod-global-connectivity ()/rg-prod-eus-transitnetwork
[12:09:32][AzOpsScope] Calling InitializeMemberVariablesFromDirectory with value /home/runner/work/ecorp/ecorp/root/tenant root group (***)/ecorp (ecorp)/ecorp-platform (ecorp-platform)/ecorp-connectivity (ecorp-connectivity)/sub-prod-global-connectivity ()/rg-prod-eus-transitnetwork
[12:09:32][InitializeMemberVariablesFromDirectory] Appended AutoGeneratedTemplateFolderPath /home/runner/work/ecorp/ecorp/root/tenant root group (***)/ecorp (ecorp)/ecorp-platform (ecorp-platform)/ecorp-connectivity (ecorp-connectivity)/sub-prod-global-connectivity ()/rg-prod-eus-transitnetwork/.state
[12:09:32][InitializeMemberVariablesFromDirectory] Determining parent subscription of resourece group /home/runner/work/ecorp/ecorp/root/tenant root group (***)/ecorp (ecorp)/ecorp-platform (ecorp-platform)/ecorp-connectivity (ecorp-connectivity)/sub-prod-global-connectivity ()/rg-prod-eus-transitnetwork
[12:09:32][New-AzOpsScope] Starting creation of new scope object
[12:09:32][New-AzOpsScope] Execution Confirmed: Creating a new scope from a path
[12:09:32][AzOpsScope] Calling Constructor with value /home/runner/work/ecorp/ecorp/root/tenant root group (***)/ecorp (ecorp)/ecorp-platform (ecorp-platform)/ecorp-connectivity (ecorp-connectivity)/sub-prod-global-connectivity ()/rg-prod-eus-transitnetwork
[12:09:32][AzOpsScope] Calling InitializeMemberVariablesFromDirectory with value /home/runner/work/ecorp/ecorp/root/tenant root group (***)/ecorp (ecorp)/ecorp-platform (ecorp-platform)/ecorp-connectivity (ecorp-connectivity)/sub-prod-global-connectivity ()/rg-prod-eus-transitnetwork
[12:09:47][Invoke-AzOpsPush] Failed to read root/tenant root group (***)/ecorp (ecorp)/ecorp-platform (ecorp-platform)/ecorp-connectivity (ecorp-connectivity)/sub-prod-global-connectivity ()/rg-prod-eus-transitnetwork/fwp-prod-global-corp.json as part of /home/runner/work/ecorp/ecorp/root | A positional parameter cannot be found that accepts argument '$null'.

Yes, I manually run the pull when changing the setting. The structure is then represented correctly, but subsequent attempts to add or modify always fail with the error above.


[Discussion] FromServicesAttribute is no longer applicable on controller or model properties

FromServicesAttribute used to be applicable on properties and parameters. The former allowed services to be bound on controller and model properties. However there was a lot of confusion as to where and how this worked.
This change, limits FromServicesAttribute to only work with action arguments. FromServices on controller properties can be replaced by a DI framework that support property injection.
See https://github.com/aspnet/Mvc/issues/3507 for discussion for past discussions for this change.

:+1:

Ugh... :-1: :zap:

Controllers: constructor injection can become tedious/hideous and we shouldn't have to write little 'service grouping' classes just to make our constructors more concise.
Models: it is so convenient to tack on a [FromServices] property onto a model and then use it for validation (a-la IValidatableObject.) I don't want to have to write a custom validation attribute or model binder thing just to use a certain service within my model's validation logic. Examples:

Checking if a username already exists
Checking against a value stored in the user's session
Checking if the current user is authenticated to determine if a specific field should be required or not

@tuespetre : use a full-blown IoC container like Ninject and you can do whatever you want.

I don't want to use a 'full-blown IoC container like Ninject'. That defeats the whole purpose of having dependency injection built in to ASP.NET 5.

@tuespetre the default DI system provided in ASP.NET is not meant to be a feature-rich system.
The decision to remove property support from [FromServices] was made specifically because of customer feedback. We saw that very few people were using it for properties, and that of the few who tried to use were using it incorrectly and it didn't work. This ended up causing many headaches for many people.
We've been working with the community to provide additional features via community-owned DI systems. The DependencyInjection repo has a readme that links to other DI systems that offer additional features and enhancements.

@tuespetre As an FYI: I wasn't one of the ones that complained, but I always felt as though the built-in DI should be just enough to complete the story for ASP.NET internals rather than act as a 'replacement' for the many tried-and-true DI systems out there. They've done just that, which gives us the freedom to use whatever DI system we want -- always a good thing, especially in OSS.

Switching to use another DI container would be awesome if I wanted to do all sorts of Mickey Mouse shit like scan unknown assemblies and manipulate a newly-activated instance of a service, but as far as I can tell, switching to another DI container does exactly nothing in relation to binding a service to a model property. All it does is return a different implementation of IServiceContainer from ConfigureServices. With the change that has been made here, whether they use another DI container or not, developers who want to bind services to controller and model properties are going to have to plumb it out themselves using the constructs provided by the MVC framework. Feel free to prove me wrong!
It will be mildly annoying to have to put this snippet of plumbing into the root of all or most of my projects...
using System;

[AttributeUsage(AttributeTargets.Property | AttributeTargets.Parameter, AllowMultiple = false, Inherited = true)]
public class FromServicesAttribute : Microsoft.AspNet.Mvc.FromServicesAttribute
{
}

...when the team could have just put a better, more descriptive summary on FromServicesAttribute:
/// <summary>
/// Specifies that a controller action parameter, controller property, or model property should be bound using the request services during model binding.
/// </summary>

I just don't feel like the team considered the very real-world scenarios that I outlined in my previous comments when making this decision. I have commented on the commit that removed the property attribute target to point out where I think a red flag should have gone up.

I partly agree  @tuespetre we write code because like others to use them. If the built-in DI could not meet the common use then it comes waste. However, I don't think current DI need more functionality, because it covers most of needs already.

:+1: I knew it will happen. All can see strong reaction against [FromService] here:
https://github.com/aspnet/Announcements/issues/28
and here:
https://github.com/aspnet/Mvc/issues/2151

I've been reading over these discussions and frankly, I am baffled. We have a few mentions of how [FromServices] has caused a lot of confusion, a lot of headaches, and a lot of posted issues:

@pranavkm: "there was a lot of confusion as to where and how this worked."

@Eilon: "This ended up causing many headaches for many people."

@rynowak: "we've had a number of issues posted by users with confusion around how this feature should be used. There's really been a fairly large amount of feedback"

I can't seem to find any such posted issues regarding confusion about where to use [FromServices], at least not in this repository. Is there some other public place that is officially used to track this kind of feedback? I did find a total of three on StackOverflow:

http://stackoverflow.com/questions/33535824/asp-net-5-dependency-injection-is-the-fromservices-attribute-only-works-in-a
http://stackoverflow.com/questions/30759403/dependency-injection-asp-net-5-custom-classes-what-is-correct-way
http://stackoverflow.com/questions/31324406/how-to-inject-dependency-of-applicationdbcontext-in-repository-mvc6

We also have this notion that there has been an outpouring of feedback from developers about [FromServices]:

@NeelBhatt: "All can see strong reaction against [FromService] here"

@rynowak: "We've heard feedback [...] that [FromServices] is a bit awkward and oddball."

Having looked over the discussion that contains the ten-or-so criticisms about it, there was no mention of its usability or functionality; rather the general sentiment that was expressed was "the naming of it doesn't seem right".

@justinvp: "Personally, I prefer [Inject] over [Activate] and [FromServices]"

@eamodio: "IMO, using "inject" aligns well with Dependency Injection while also expressing more with less confusion than [FromServices]"

@ctolkien: ":+1: on [Inject]"

@bangoker: ":+1: on [Inject] as well"

@atrauzzi: "I agree, [Inject] sounds a lot better than [FromServices]"

@davidroth: ":+1: on [Inject] as it is clear from the name whats happening.
[FromServices] sounds very ambiguous"

@nil4: ":+1: for [Inject] rather than [FromServices]"

@evil-shrike, I must single you out for this comment:

@evil-shrike: "I'm afraid that emphasizing "services" contradicts the idea of DI a bit. It'd be ok for "Service Locator" but not for Dependency Injection - as "dependency" isn't always a service."

Throughout the ASP.NET 5 framework, every reference to the dependency injection subsystem refers to "Services": IServiceCollection, ConfigureServices, RequestServices, ApplicationServices, etc. This is not just a matter of the [FromServices] attribute.
And @glen-84, I am sorry but I do feel the need to single you out for this comment:

@glen-84: "Finally, it seems to me that [FromService] is inconsistent with the other [From*] attributes, in that all the others bind data from the request, whereas [FromService] simply resolves the object via DI."

If model binding was strictly an abstraction for binding values from an HTTP request, you would be correct, but as far as I can tell, it is not. It is an abstracting for binding values from a binding source, which may happen to be an HTTP request in most cases, but not always.
Every single one of those comments I quoted from #2151 seemed to miss that point entirely, and even though @dougbu and @danroth27 attempted to clarify that this is not a matter of the dependency injection framework but rather of the model binding framework, their comments seem to have gone unnoticed:

@dougbu: "FYI [FromServices] is named for how that attribute is used elsewhere in MVC model binding"

@danroth27: "[FromService] is a model-binding concept, and allows arbitrary plugging of services on parameters, models, properties"

I don't mean to be angry or rude or anything. I just really feel the need to express my disappointment and concern that it only took roughly ten or so comments on a GitHub discussion -- none of which entailed anything other than purely aesthetic concerns -- and a truthfully small number of posts online was all it took for the team to justify the crippling of a very useful feature which would probably be used a lot more than you would think or even be able to reliably measure (looking at you @Eilon):

@Eilon: "We saw that very few people were using it for properties, and that of the few who tried to use were using it incorrectly and it didn't work."

My plea to the MVC team
You have already written the code for the feature and I have demonstrated common, real-world use case scenarios for it. Please revert your decision, add the AttributeTargets.Property back onto the attribute definition, and edit the documentation/summary of the attribute to give it all the clarity it needs to help prevent any confusion surrounding its usage. You could also ensure that all of the official documentation avoids the word "inject" and instead uses the word "bind" when using the attribute, because it is not primarily a dependency injection construct, but a model binding construct.

I use [FromServices] to bind model properties and it's very useful. And I don't want to use 'full-blown IoC container' for just this feature :-1:

:broken_heart:

I agree with @tuespetre - IMO using this attribute for dependency injection in controllers looks much more better than constructor injection. Code with this feature looks more expressive and readable, because I can omit unnecessary constructor which in most cases needed ONLY for DI.

I'm actually totally confused now.  You know what would really be helpful is if a blog post or a topic on announcements was made to describe the feature, what it's intended to do and how it stands currently.
My views on dependency injection might be oriented a little strange to what I think I'm reading from everyone here...
Really, DI should only be used for infrastructure.  The fact that I'm hearing about injection happening in models or with models being injected raises huge red flags for me.
Strictly in speaking as a developer using ASP.NET MVC, the first place DI should be triggered - Startup.cs not with standing - is in the controller's constructor and/or the controller's action methods.
I think it's easy to see that if DI is allowed everywhere, it just gets out of control and we could run afoul of other competing lifecycles like EF.
Use DI for infrastructure at request time, heck, get rid of all these annotations entirely.  Just automatically do DI on controller classes and action methods.  You will cover 99% of every scenario and come up with that "bare minimum for a built in DI system".
And like I always do, please see Laravel's DI system which is just so straightforward.

@Igmat : a constructor exists as a concept specifically for the purpose of initializing an object with the necessary dependencies... thats its purpose. Properties as a concept are used to mutate an object after it has been initialized. Using property injection with attributes might seem more readable, but it doesn't fit the lifecycle of object-oriented design. For dumb objects like models, using property initialization is fine, since there are so many possible mutations -- but for something like a controller, where the dependencies are always the same, constructor injection is the right place to do it.
@atrauzzi I'm in agreement with you; adapting behavior via dependency injection is purely about infrastructure (in my world view) ... its core purpose is not to dynamically adapt behavior to solve business problems.

@dmccaffery I can't agree with you. We are working in OO-language, so all things here is objects by design, but controller is abstraction that has some specific use case. You actually will never use it as object. You won't write things like var ctrl = new MyController(); or ctrl.SomeMethod();. You will never create this object, get it via DI, call its methods or set its properties.
Controller have to not contain any business logic. Controller is just a mediator between client code and server code. Its only purpose is to correctly handle requests by calling right services methods, and choose what to send for a client. So controller can be and should be as declarative as possible. We already have some declarative things there like [Route], [Authorize], [HttpGet] etc. Even using MyCoolModel but not ActionResult while describing actions in controllers is a way to more declarative style. And adding additional will just simplify our work.
When we write public IMyService MyService { get; set; } or private IMyService _myService; we have already described our intention - to add a dependency. Everything else is redundant for this task in controller.
P.S.
But I agree that constructor is right place for injection in services. I have never used property injection there.
P.P.S.
But if we could use property injection for private properties - it would be much more better than constructor injection in most cases.

When we write public IMyService MyService { get; set; } or private IMyService _myService; we have already described our intention - to add a dependency

In the case of the property, no you haven't described it as a dependency. That's the issue.
Will add my voice to ctor only injection.

@ctolkien Agreed, properties are ambiguous in meaning as they can be set at any point during an object's lifetime.  It is not safe to assume that because something is declared as a property that it is a "dependency".
I wonder -- is it possible that some of the confusion around how people use these things is as a result of the overuse of annotations?  Like, what are we really annotating for here?

It seems that some folks on are still missing a crucial detail: the [FromServices] is not, and never has been, a means of dependency injection. It has nothing to do with the ASP.NET dependency injection system, at all. Using the [FromServices] attribute does not cause the dependency injection system to inject anything onto anything else's properties. It instead tells the model binding system to a bind a property or argument by getting its value from the dependency injection system.
Unless I am mistaken, there is no support right now for parameterized constructors on model classes. If there is, I will stop complaining right now. Otherwise, we need [FromServices] to work on model properties in order to make use of services for validation purposes.

I completely understand that. The effect is; however, the same. Whether the service provider injects the implementation itself, or a 'middleman' uses the service locator anti-pattern to acquire a value and assign it to a property on its behalf, you're still using dependency injection.
Short answer is; using the dependency injection system in .NET for any purpose other than injecting dependencies is promoting it's use beyond its original intent. It wasn't meant to be a fully featured IoC container. It was meant to provide the bare minimum requirements for the framework itself to support composition and separation of concerns through loosely coupled abstractions.
If you want to use IoC to effect behavior rather than infrastructure, then use a fully featured IoC container that allows for this. .NET is fully extensible, including its IoC implementation.
I'm not arguing for or against these different patterns; I'm only arguing against trying to make the built-in dependency injection system attempt to go beyond its means. If MS were to bring this attribute back, they would also need to negate its misuse, which would require the DI to be much more involved -- something that 3rd parties have already done.

@dmccaffery:

If you want to use IoC to effect behavior rather than infrastructure, then use a fully featured IoC container that allows for this. .NET is fully extensible, including its IoC implementation.

If you want to promote 'using a fully featured IOC container' to fill the gap created by disabling the use of [FromServices] on model properties, then please explain exactly how another IOC container could be used to do so. Post a code sample. Publish a Gist.

But if we could use property injection for private properties - it would be much more better than constructor injection in most cases.

So I must admit, I don't like [FromServices] now or before. The above quote was the original reason. Take the following example:
public abstract class RavenController : Microsoft.AspNet.Mvc.Controller
{
	[FromServices]
	public IDocumentStore DocumentStore { get; set; }
	public IDocumentSession Session { get; set; }

	public override void OnActionExecuting(ActionExecutingContext context)
	{
		Session = DocumentStore.OpenSession();
		base.OnActionExecuting(context);
	}

	public override void OnActionExecuted(ActionExecutedContext context)
	{
		using (Session) {
			if (Session != null && context.Exception == null) {
				Session.SaveChanges();
			}
		}
		base.OnActionExecuted(context);
	}
}

public class PageController : RavenController
{
	public IActionResult Index()
	{
		Employee employee = Session.Load<Employee>(employeeId);
		...
	}
}

The proerty, DocumentStore, really should be private, not public, but that is how [FromServices] worked. The alternative was/now is more hideous:
public abstract class RavenController : Microsoft.AspNet.Mvc.Controller
{
	private IDocumentStore _documentStore { get; set; }
	public IDocumentSession Session { get; set; }

	public Controller([FromServices] IDocumentStore documentStore)
	{
		_documentStore = documentStore;
	}

	public override void OnActionExecuting(ActionExecutingContext context)
	{
		Session = _documentStore.OpenSession();
		base.OnActionExecuting(context);
	}

	public override void OnActionExecuted(ActionExecutedContext context)
	{
		using (Session) {
			if (Session != null && context.Exception == null) {
				Session.SaveChanges();
			}
		}
		base.OnActionExecuted(context);
	}
}

public class PageController : RavenController
{
	public PageController(IDocumentStore documentStore) : base(documentStore) { }

	public IActionResult Index()
	{
		Employee employee = Session.Load<Employee>(employeeId);
		...
	}
}

Now the constructor has to be redefine for every child controller. And, I still have access to documentStore in the constructor when it really should be private.
Now, I'm new to MVC as I've always used Web Forms, and throughout the development of vNext I've been keeping a learning project update date with changes and fixing breaking changes as they occur, so that when MVC 6 releases I might move my Web Forms project to MVC. Thus, I might not have a proper idea of DI, but it seems that what I'm trying to do with RavenDB is acceptable logic under DI. It would be much cleaner to have [FromServices] work for private properties.
Additionally, I thought I read somewhere that [FromServices] was only acceptable for one parameter of constructors, and as a consequence [FromServices] properties should be consider in cases where multiple DI object are needed. If this is still true, [FromServices] feature is hardly usable.

Make your IDocumentStore a private read only field; it doesn't need to be public, but you would need to register the IDocumentStore or factory to the services collection for DI to work. You would also need include IDocumentStore as a constructor argument.
The argument against using an attribute to set a private field is related to performance; it's expensive to reflect a type to find all fields, property methods, and constructors looking for things to inject.
Constructor injection follows object-oriented design principles; and is the minimal amount of extra work required to enable injection.

Okay. I understand why private fields isn't implemented for [FromService]. But, I still don't understand how to extend a class without making an empty copy of the parents constructor as the second example shows above. Is this expected? This was what I was trying to avoid by using [FromService] on a property.

Constructor injection follows object-oriented design principles; and is the minimal amount of extra work required to enable injection.

Which is fine for controllers, but if you want to keep all of your model validation logic together and be able to take advantage of automatic validation during model binding, we need one of two things:

Support for parameterized constructors in model classes
The [FromServices] attribute

It's been three weeks now; I know it's probably been busy for everybody but would an MVC team member have any updates to share with us? I feel that the "using services from the service container to implement model validation logic" story is very important and I would just like to know whether, at the very least, some unspecified solution to this story is in the plans for MVC 6.

In your suggestion, what would you be using the parameterized constructors in the model for?

@atrauzzi:
https://github.com/aspnet/Mvc/issues/3578#issuecomment-162257937

in order to make use of services for validation purposes.

https://github.com/aspnet/Mvc/issues/3578#issuecomment-163257863

if you want to keep all of your model validation logic together and be able to take advantage of automatic validation during model binding

https://github.com/aspnet/Mvc/issues/3578#issuecomment-157825813

Examples:

Checking if a username already exists
Checking against a value stored in the user's session
Checking if the current user is authenticated to determine if a specific field should be required or not

Pseudo-code example of what I am doing now with rc1:
public class SignupFormViewModel : IValidatableObject
{
    [FromServices]
    public UserSession Session { get; set; }

    [FromServices]
    public IHttpContextAccessor HttpContextAccessor { get; set; }

    // Lots of properties I'm omitting for brevity

    public IEnumerable<ValidationResult> Validate(ValidationContext validationContext)
    {
        // Lots of simple validation rules I'm omitting for brevity

        if (!HttpContextAccessor.HttpContext.User.Identity.IsAuthenticated)
        {
            if (SomeConditionFails())
            {
                yield return new ValidationResult(SomeMessage, new [] { nameof(SomeProperty) });
            }
            else if (AnotherConditionFails())
            {
                yield return new ValidationResult(AnotherMessage, new [] { nameof(AnotherProperty) });
            }
        }

        if (Session.SomeConditionIsPresent() && DifferentConditionFails())
        {
            yield return new ValidationResult(DifferentMessage, new [] { nameof(DifferentProperty) });
        }
    }
}

The beauty of [FromServices] (or possible support for injecting dependencies into parameterized constructors in models) is that you have all of the validation rules for an object in one place and you don't have to use the service locator anti-pattern to get what you need. I'm not even sure how to use that anti-pattern in MVC6 since the service container is not made available as a static reference, as far as I can tell.
Nobody in any of the discussions surrounding [FromServices] who has stated "Just use another DI container" has bothered to explain how that would help or how it applies to this situation, and it seems that you are the first person willing to consider the concerns that I am voicing, so thank you for that. I look forward to seeing what you have to say.

@tuespetre
Firstly, I did leave a comment of how it could be done; you could write your own model binder, or validate (like you did) and resolve types using the anti-pattern you mentioned. You can even do it without a separate DI container by saving off the service provider during Startup to a static field to enable the anti-pattern. You can also use filters to effect behavior based on the current state of the system, which is probably how this would have been done in the past.
Secondly, It's still a bad idea. While your specific use case seems reasonable (and it is -- it's the use case MS was trying to support, I believe), enabling dependency injection on the model during model binding is dangerous (out of the box) for several reasons:

I can see use cases where people are going to use [FromServices] in model binding to extend the model -- like reading some additional info from session, or a cache, like this example which already cropped up a year ago:

http://shazwazza.com/post/model-binding-with-fromservices-in-aspnet-5/
This is a horrible idea, and I'm sure that everyone will agree with me on this, at least.

If the injection fails, or any code within the injected types fail, an exception is thrown that cannot be caught by user code, which means difficult, hard to find debugging scenarios.

Fat model, skinny controller was not embraced by Microsoft in ASP.NET MVC, for better or worse. Aside from validators, the design of the system reinforces the idea that models are more like DTOs for a view -- not fully-baked, self-aware, self-managing objects.

@tuespetre: Oh crap: I stand corrected. I wrote a comment on how it could be done; of that, I am sure. For whatever reason, I don't think it persisted for whatever reason. It was yesterday, at some point. Oops. My sincere apologies.

@dmccaffery

you could [..] resolve types using the anti-pattern you mentioned. You can even do it without a separate DI container by saving off the service provider during Startup to a static field to enable the anti-pattern.

Except then you lose the concept of request-scoped services, let alone the ability to access the HttpContext itself.

I can see use cases where people are going to use [FromServices] in model binding to extend the model -- like reading some additional info from session, or a cache, like this example which already cropped up a year ago:

http://shazwazza.com/post/model-binding-with-fromservices-in-aspnet-5/

This is a horrible idea, and I'm sure that everyone will agree with me on this, at least.

Yes, I can agree with that, but you can do a whole bunch of horrible things with a lot of other things in a lot of other ways. I could write an application that uses Entity Framework to build a 'meta', proprietary, crappy data storage system within a relational database. I could write controller actions that have no logic within them and then write filters that return all the results. I could pass everything around via HttpContext.Items and implement my own vomit-inducing validation system inside of it.
That's no excuse for taking something away that has perfectly valid and sensible use cases.

If the injection fails, or any code within the injected types fail, an exception is thrown that cannot be caught by user code, which means difficult, hard to find debugging scenarios.

That's going to be the case when injecting services into controllers as well, or using the [FromServices] attribute on an action method parameter. That's what testing is for; it's just the nature of the beast!

Fat model, skinny controller was not embraced by Microsoft in ASP.NET MVC, for better or worse. Aside from validators, the design of the system reinforces the idea that models are more like DTOs for a view -- not fully-baked, self-aware, self-managing objects.

I fully acknowledge that; I am speaking only of the binding and validation aspects of the framework.

@tuespetre What @dmccaffery said is more or less where I was heading with my question.
What happens when you're running CLI outside of a request and you try to use an object that depends on requests?

Late to the party, I see this has already been changed for RC2.  I was happy when I found this and then disappointed when I found this thread today seeing it's going away.
In my case, I had services being injected via a constructor in a base controller.  Having to pass the same constructor around repeatedly was cumbersome and a little annoying to refactor when a change needed to be made to the base class causing all inheriting constructors to need to be changed.  I used the FromServices to slim the constructor but provide those services via properties that wouldn't break when I added a new one (maybe that's a poor use but it was easy to provide those services without busting everything down the line).
I assume I can group those services into a class like a service manager where they're injected and then use that in the constructor for the same result but it seems like a needless step after having used this.  That's just my two cents.

@blakepell
I feel your pain, and can only offer this as a solution:
Use a full-blown IoC container, such as Autofac; it can do what you need it to do. The built in dependency resolver is designed solely for the purpose of injecting types necessary for supporting the framework; it wasn't meant to be a replacement for the other, quite good, and fully-featured IoC containers that are available; primarily because there are different schools of thought as to how a container should register types, etc, and Microsoft seemingly wants to continue to enable developers to make our own choices when it comes to pervasive design patterns.

@dmccaffery That's fair, I'll take a look at Autofac and also Ninject, thanks for the suggestions, it is appreciated.  The more this evening I think about a service manager injected through the constructor the more I'm warming up to it, it does fulfill the need of being able to update without breaking inheritance.  Thanks for the response also.

Ninject isn't supportive of DNX, I don't believe -- it's somewhat a dead project; but StructureMap is there, as is AutoFac. I realized I mentioned Ninject at the head of this thread, but that was me just throwing out an example, not a recommendation. All IoC (and things in general) are left to personal preference.

I am with  atrauzzi, dmccaffery (and so on). Whoever liked (and needed) the FromService attribute should read Mark Seemann's "Dependency Injection in .NET". IMHO is should be 90% constructor injection, 9% method injection and 1% property injection. Why? Anti patterns. Decay of architecture. Etc. Not going to explain in 1 comment. See reference to suggested book.

I'm mostly okay with the removal (I think).  But I don't like the suggestion that people can plug their own DI in becoming the standard response. It's getting a bit stale and ASP.NET core isn't even out yet.
The MVC/routing dispatcher should support method injection on controller actions. This would ensure peoples' controller constructors don't get too fat.
Otherwise, constructor injection is really what people should be using.  Again, as always, I direct people to look at how laravel's injection is made available.  It's quite effective.

@atrauzzi IMHO the objections against constructor injection are because of breaking SRP (as said before decay of architecture). Around 3 injections via constructor as a rule of thumb is fine. If it is starting to get more and more it is time to check the cohesion.

@DannyvanderKraan That definitely makes sense and I agree with that philosophy in the absence of method injection.  It's 100% common sense.
There's sadly a lot of dissonance that arises out of the terminology.  Specifically controller and action.  In the absence of method injection, a controller is a cohesive group of actions - as you said.
When method injection is available, the notion of a controller almost completely boils off.  It's just a language construct and serves more for organization of code.  It becomes more about the actions which can specify different dependencies without stepping on each other's toes.

I found this thread way too late as I have just found that [FromServices] is missing in RC2 and I'm a little disappointed.
Like @tuespetre we do validation in Models using IValidatableObject when we need to validate using dependencies outside of the model itself.  (Duplicate checking would be a good example).
We like to keep this sort of validation outside of the Controller, because the pattern of if (!ModelState.IsValid) return View(vm) provides a nice separation of concerns & thinner controllers.
The DataAnnotations attributes also provide a nice separation of concerns, in that for each model, we know exactly where the validation logic, or validation orchestration logic if you are using more of a DDD pattern is.  EG, [Required] is validation logic so is the iValidableObject.IsValid.
I think it comes down the fact that you have to have the orchestration logic for validation somewhere, and you either have fatter controllers or fatter models.  It's up to us as developers to choose our poison based on our circumstances. No one way is outright good and evil, right or wrong.
Also like @tuespetre, I don't really care how the framework injects dependencies into Models/Attributes (constructor or attribute or even service location via validationContext.ServiceContainer.GetService()) but the point is that they should provide that capability.
Saying "just use a full blown IoC container" as the answer does not really help as you still need custom model binders & attribute factories, and that code is tricky to get right.  Probably trickier than using [FromServices]
dave

@davidames you can now use the ValidationContext that comes into the Validate method of IValidatableObject to obtain services for use during validation.

On May 22, 2016, at 7:53 PM, davidames<EMAIL_ADDRESS>wrote:
I found this thread way too late as I have just found that [FromServices] is missing in RC2 and I'm a little disappointed.
Like @tuespetre we do validation in Models using IValidatableObject when we need to validate using dependencies outside of the model itself. (Duplicate checking would be a good example).
We like to keep this sort of validation outside of the Controller, because the pattern of if (!ModelState.IsValid) return View(vm) provides a nice separation of concerns & thinner controllers.
The DataAnnotations attributes also provide a nice separation of concerns, in that for each model, we know exactly where the validation logic, or validation orchestration logic if you are using more of a DDD pattern is. EG, [Required] is validation logic so is the iValidableObject.IsValid.
I think it comes down the fact that you have to have the orchestration logic for validation somewhere, and you either have fatter controllers or fatter models. It's up to us as developers to choose our poison based on our circumstances. No one way is outright good and evil, right or wrong.
Also like @tuespetre, I don't really care how the framework injects dependencies into Models/Attributes (constructor or attribute or even service location via validationContext.ServiceContainer.GetService()) but the point is that they should provide that capability.
Saying "just use a full blown IoC container" as the answer does not really help as you still need custom model binders & attribute factories, and that code is tricky to get right. Probably trickier than using [FromServices]
dave
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Also sad to see this go. We were using the [FromServices] attribute for the exact same reason as @blakepell. Having to plug a custom DI framework only to accommodate this scenario is a waste of time imho, and we would revert back to ctor injection. But again, having to add 10 constructors in our controllers that extend our basecontroller just for the sake of injecting a service is way more ugly than injecting something through a property.

ah... so if enough people come up here and complain about DI framework confusing them, are we going to remove DI from .net then ? Believe me, I know a lot of old style programmers hating DI, I can tell them this "good news". When someone say something confuse him, I think we should figure out why instead of removing it. And honestly, if this confuses them, why do they need to use this way ? It is an optional solution not a mandatory one. It is like you can either walk on ice or slide on it. And someone think sliding is confusing, or don't know how to slide, so we forbid people to slide. Anyway, just feeling frustrating about how many code I need to change for this breaking change.

@maxisam DI is good pattern to save a lot of time and prevent "old style programmers" to write unmaintainable code. Writing code is not just for features and function working. It is also for read by others and maintainability.

@davidames @razzemans I extracted this class and it appears to allow FromServices to work in RC2 from initial testing (although I should verify I was using all RC2 bits and didn't re-reference an old piece for this).  I'm guessing probably not the best thing to do but, thought I'd share what I found).
[AttributeUsage(AttributeTargets.Property | AttributeTargets.Parameter, AllowMultiple = false, Inherited = true)]
public class PropertyFromServicesAttribute : Microsoft.AspNet.Mvc.FromServicesAttribute
{

}

`

@singlewind  I think you totally miss my point.

@blakepell Yes thanks, we ended up using that as well, as described by @tuespetre in this thread. In my opinion, it's a good solution and I think it's exactly what the [FromServices] used to be in RC1.

An [Inject]-like attribute (~[FromServices]~) is nice for things like abstract base classes when you don't want to clutter up inheriting classes with constructor injection parameters. Removing it only because some people don't understand how to use it seems like the wrong action to take on something that is highly useful in some situations.
This reminds me of the whole project.json subject too... lets move forward and stop ripping good stuff out to support people that don't want to learn new things.

I am also disappointed and baffled that this change was made. 👎

Now if I am implementing a CustomAttribute that needs services in it.
How to inject services inside the Attribute?

@tariqalardah injecting arbitrary services into an arbitrary attribute was never supported and I don't think it ever can be - construction of attributes is done by .NET itself, which isn't aware of DI or services.
Is this an arbitrary attribute or is it an MVC filter attribute?

@tariqalardah to add on what @Eilon said, if you are making a custom filter attribute, you probably want your attribute to implement IFilterFactory, which can then return your custom instance of IFilterMetadata from the service container (or use the service container to obtain the dependencies needed by your filter.)

I am trying to implement my ExceptionFilterAttribute to be used on some API Controllers.
public class MyExceptionHandlerAttribute : ExceptionFilterAttribute
And planning to use IHostingEnvironment and my IRepositry service in the implementation!
Then will use it on Controller, like,
[MyExceptionHandler]
public class MySampleController: Controller
{ }

Any chance this will work?

@tariqalardah you could get the services you want out of the ExceptionContext that gets passed into public override void OnException(ExceptionContext context) like this: context.HttpContext.RequestServices.GetService<IHostingEnvironment>(...).

@tuespetre, Thanks, now I have two options to try
IFilterFactory and context.HttpContext.RequestServices.GetService<>()

@tariqalardah why not use ServiceFilters - https://docs.asp.net/en/latest/mvc/controllers/filters.html?#configuring-filters?

@pranavkm, I was going to use them after a time being trying and searching how to get the needed service in the custom attribute, as a last chance, I posted my question here.
And fortunately, got the needed answer by using (IHostingEnvironment)context.HttpContext.RequestServices.GetService(typeof(IHostingEnvironment)); suggested by @tuespetre :+1:

Hi,
Can somebody please give me a hand?
I am Autofac as DI in my .NET Core webApi following the docs here is my code in startup class:
       public IServiceProvider ConfigureServices(IServiceCollection services)
    {
        services.AddMvc();
        var builder = new ContainerBuilder();
        builder.RegisterModule<DefaultModule>();
       builder.Populate(services);
        this.ApplicationContainer = builder.Build();
        return this.ApplicationContainer.Resolve<IServiceProvider>();

}
DefaultModule.cs code
public class DefaultModule : Module
{
    protected override void Load(ContainerBuilder builder)
    {
        builder.RegisterType<BlogServices>().As<IBlogServices>();
    }
}

Controller Code:
private readonly IBlogServices _blogServices;
    public BlogsController(IBlogServices blogServices) {
        IBlogServices _blogServices = blogServices;
    }

But the resolved dependency passed to controller is null!!!!
Any Idea what am I missing please ?

We are closing this issue because no further action is planned for this issue. If you still have any issues or questions, please log a new issue with any additional details that you have.


Problem with run sota/lm1b.sh.

python data_utils.py receive --dataset=enwik8 but dataset name - lm1b
https://github.com/kimiyoung/transformer-xl/blob/master/tf/sota/lm1b.sh#L30
2 If I change dataset parameter to lm1b and run sh sota/lm1b.sh I have this error:

Assign requires shapes of both tensors to match. lhs shape= [153470,20] rhs shape= [153472,20]
	 [[node save/Assign_5 (defined at /Users/path/transformer-xl/tf/train_gpu.py:419) ]]

Hi, thanks for spotting the typo. However, after fixing the type, I just did a quick run and didn't notice any problem. Can you confirm other conditions fit the instruction, i.e., python 2.7 + tensorflow r1.12?


Bump nix from 0.26.2 to 0.26.4

This PR bumps nix from 0.26.2 to <IP_ADDRESS>.4 and thus removes the static_assertions dependency.

Closing this PR in favor of https://github.com/uutils/coreutils/pull/5258


Alerts are need if remote runner job fails on nightly cron job ( or doesn't run )

We need an alert either on a failed job or missing the daily points in a graph using Grafana ( not sure if Grafana has this feature)

We should be able to write alerts in Grafana.  One rule could be points in last 24 hours per test
http://docs.grafana.org/alerting/rules/

Not going to be able to implement.


Rename README.txt to README.md

Nothing big, but makes the README easier to look at on Github.

I think that this was done.  Can this issue be closed?


[dev.icinga.com #12794] add db port to ido schema load

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12794
Created by vkhatri on 2016-09-25 23:34:36 +00:00
Assignee: (none)
Status: New
Target Version: (none)
Last Update: 2016-09-25 23:34:36 +00:00 (in Redmine)

Change applied, closing.


use print for INFO and lower levels summarize()

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
[x] Did you read the contributor guideline?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
Fixes #518  (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

I was thinking that prepending a newline seems to be a good idead (suggested by @awaelchli ) @jeffling what do you think about this?
I moved the config to init @Borda . Thx!


Please invite me to the community

Name
Sulaman shah
Additional Context
learn collaborate and network

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is an open source solution for serverless platforms, it is designed for developing solutions and enhancing creators to create their infrastructure 💻 Great to have you in our community ✨ Looking forward to your valuable contributions! 🤓 You can also check our community ✨ Github ✨ LinkedIn 💜 You can also share our community with other folks who want to learn about development, DevOps, tech, and contribute together and with us 👉💜👈


Https Support

I wonder if seaweedFS support https or other API, such as grpc?

Pull Requests are welcome.


Car Maintenance Materials disappear when equipped

Hello.
I hope this is right place to post a bug.
I noticed when I equip the "Car Maintenance Materials" into hand, it will eventually empty the entire box and change it into plastic box. So then empty container and causing loosing all of it even when is on max condition.
Also tested on original version of Def's mod and it does it there too.

Sorry for the delay in my reply, I wasn't getting notifications for this repo.
I've honestly never used the car stuff from the mod so I'll test it in-game to see what you're referring to.

It seems that the default behavior for drainable items is to start draining once you equip them. Why? I haven't the foggiest. But it was fixed by adding the property UseWhileEquipped=FALSE. It also turned out that a lot of other items in this mod didn't have that set either, particularly stack items. It was probably never noticed because no one equipped them before. Anyways, good find, thanks for that!

Hello.
Thank you for fixing this issue. So I'll download and subscribe again an
updated version on steam as I'm steam user.
On Wed., Dec. 13, 2023, 8:13 p.m. faeldray, @.***>
wrote:

It seems that the default behavior for drainable items is to start
draining once you equip them. Why? I haven't the foggiest. But it was fixed
by adding the property UseWhileEquipped=FALSE. It also turned out that a
lot of other items in this mod didn't have that set either, particularly
stack items. It was probably never noticed because no one equipped them
before. Anyways, good find, thanks for that!
—
Reply to this email directly, view it on GitHub
https://github.com/faeldray/DefsLTS/issues/7#issuecomment-1854945613,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3FYM3C5TNVNJZIK66GYY43YJJHDHAVCNFSM6AAAAAA7G4NWDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJUHE2DKNRRGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


⚠ Jenkins Plugins Artifactory has degraded performance

In 67f9490, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2419 ms

Resolved: Jenkins Plugins Artifactory performance has improved in fd0e985 after 13 minutes.


Doing purchase on internal test getting error.

Bug Description
Summary:
The app functions normally for testers who have been granted permissions, but for other users, a popup error appears stating: "Error: This item you were attempting to purchase could not be found."
Steps to Reproduce:

Setup the app according to the provided instructions.
Upload the app to internal testing.
Test the app with users who do not have granted permissions.
I'm review on production but the app name always mark as unreviewed.
Expected Result:
The app should function normally for all users.

Actual Result:
The app shows a popup error for users without permissions: "Error: This item you were attempting to purchase could not be found.". Billing Response code = 4  ITEM_UNAVAILABLE
Additional Information:
The issue does not occur for testers who have been granted permissions.
The problem persists only for other users.
Possible Solution:
To fix this issue, ensure that the item or feature in question is available to all users or check the configuration for the internal testing setup. Verify that the necessary permissions and access rights are properly set for all users.
Feel free to let me know if you need any additional information or assistance!.
Please help me in this case. I'm a newbie and really excited in with your source code.

Sounds like the Google's Billing APIs simply doesn't return products for users without granted permissions in internal testing, if app is not available publicly?

Im trying to publish my app to production. But policy team tell that my app is violate policy because when i run purchase flow the purchase bottom sheet show that error. Do you have any idea. Please help me!


About Us Design

Added and customized scrollbar, removed ability to scroll horizontally as well as accompanying scrollbar, and styled the about us page. This involved adding more food items and a preview image, as well as some stylistic svgs.

Note! Scrollbar changes are not applied to Firefox. This issue will need to be addressed later.


Dapr sidecar should only check the health of components used by the service it is injected into when starting.

/area runtime
Kubernetes env.
/area operator
/area placement
/area docs
/area test-and-release

What version of Dapr?
Dapr 1.0 ,Dapr 0.11
Expected Behavior
Dapr sidecar  should run based on respective/assigned  component.
Actual Behavior
Scenario :  Deployed an Dapr Microservice with State-management using Redis . Able to store the data no issues here.
Deployed another Microservice with pub-sub using Kafka able to  publish and subscribe the messages .
After some time VM got down where Kafka installed ,By that time User restarted the service which is using  Stage-management  then it is observed that dapr side car is not coming up.
When user check the logs found that due to Kafka component problem .
So The service which is not using Kafka component should be up and running without depending on independent component Health status.
Steps to Reproduce the Problem
Deploy any service which uses State management with Redis..
Deploy another service which uses Pub-sub with Kafka.
Make Kafka down.
Restart the State management service . Then issue occurred.
Release Note

RELEASE NOTE:

I see this as a feature request for App to announce to sidecar which components are required. Right now, Dapr does not know which components the app will actually use or not.
In the meantime, you might use the ignoreErrors flag in the component that can be ignored but that is a global setting: https://docs.dapr.io/operations/components/component-schema/#fields

My thoughts on this issue are as follows:

Each Microservice application use it's own module config. In your case, the daprd of state-manager application will not load the pub/sub module at all. @kamesh1677
Provides a mechanism for sending messages from applications to daprd to decide which modules to start.

In the suggestion 2, we can  enhance the “runtime.loadAppConfiguration()” method, to let daprd got which component the app want to use.

As my suggestion 2, i submit a PR https://github.com/dapr/dapr/pull/3688

This can be solved by using scopes on the PubSub and State-Management components, so that they are only loaded by the Apps that care about them.
In OPs example, if scopes were assigned accordingly, Kafka being down wouldn't affect Apps that haven't loaded the Kafka component.
@artursouza this can probably be closed, right?


SharedNumberSequence Class isn't documented but linked from the docs

https://fluidframework.com/apis/sequence/sharednumbersequence/

Triage: We'd like to have a class description and some basic usage information in the TSDocs. Some of this info may already be in the package readme.

@anthony-murphy are you working on this?


socket enricher: Use single instance for multiple gadgets

Check the details in https://github.com/inspektor-gadget/inspektor-gadget/issues/1695.
Fixes https://github.com/inspektor-gadget/inspektor-gadget/issues/1695

There's something going on with the tests on this PR. Holding until I have the chance to investigate more.

There's something going on with the tests on this PR. Holding until I have the chance to investigate more.

At least for TestProfileCpu the KubeInventoryCache crashed the gadget. After rebase + https://github.com/inspektor-gadget/inspektor-gadget/pull/2354 at least one test should pass again.
That crash seems to be a very rare race condition

@burak-ok does it have any relation with https://github.com/inspektor-gadget/inspektor-gadget/pull/2347? Because that PR is not included in this branch yet.

@burak-ok does it have any relation with #2347? Because that PR is not included in this branch yet.

No, that rare race condition appears to have existed until that branch. With #2347 I think it got worse


After cancel on the add IP dialog the server is forever in loading mode

Azure Data Studio Version:

Steps to Reproduce:

Connect to Azure Account
Double click a Sql Server in a Subscription which opens the add IP dialog
Hit Cancel on the dialog
The SqlServer remains in loading mode for the whole session (even refreshing the tree doesn't remove loading icon)

Not happening anymore


Balena-dash does not render Czech characters correctly

Probably some fonts are missing. You can look at this dashboard https://tanix.damidev.com/enviro-tv and focus on measurement names in charts - the word "Světlo" in the last chart for example. I am experiencing the problem with timezone, thumb up given to the related issue.
Thanks for your work and help with this issue.

That's not only so at Czech characters also many Unicode characters like arrow symbols or Chinese characters are not shown correctly. There's only a border of a rectangle.


DataGrid grouping not working correctly with ServerData

Bug type
Component
Component name
MudDataGrid
What happened?
It seems like grouping is not working with ServerData.  This was actually reported here previously and marked as fixed.  Did it break again? https://github.com/MudBlazor/MudBlazor/issues/5554
Expected behavior
Grouping should work
Reproduction link
https://try.mudblazor.com/snippet/QucRFlwNiniCEQmD
Reproduction steps

Add a data grid with server data
Add grouping by column
...

Relevant log output
No response
Version (bug)
6.0.9
Version (working)
No response
What browsers are you seeing the problem on?
Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I also tried with this example, using the GroupBy attribute, and it is still not working:
https://try.mudblazor.com/snippet/cEmdPbcNCousECmU

It appears to works:
https://try.mudblazor.com/snippet/mamHPQccennfZQxE
Needed to change your columns to property columns.

Ah, oversight on my part.  Thank you @ZipOnRunnerAndNet!

Hi all, there still seems to be a bug when there is grouping (like here https://try.mudblazor.com/snippet/mamHPQccennfZQxE) plus the GridPager (which is common use case to paginate and use serverdata)


Okta Migration Changes

This PR encapsulates all of the changes needed for the Okta migration from various tickets.

@jeremy-page @snesm branch now only consists of the URL/ClientID changes for migration

Need to figure out the conflicts first, should be done today.

operations\app\terraform\modules\function_app\main.tf has been updated to read the cors settings from locals file, please update the CORS settings in below file
operations\app\terraform\modules\function_app\locals.tf

Please do not merge this until we have a plan how to apply...once it's in the pipeline we're going through with it!


.eh_frame contains more CIEs than needed

readelf -W --debug-dump=frames wild/tests/build/rust-integration.rs-llvm-dynamic.wild | grep CIE | wc -l
23
readelf -W --debug-dump=frames wild/tests/build/rust-integration.rs-llvm-dynamic.ld | grep CIE | wc -l
2

Wild GCs FDEs for sections that aren't used, but doesn't currently GC CIEs that aren't referenced by any FDEs.

Just providing statistics for the current main branch and other linkers (for Clang binary):
Mold:
.eh_frame_hdr                                                    1.2 MiB
.eh_frame                                                        9.7 MiB

LLD:
.eh_frame_hdr                                                    1.2 MiB
.eh_frame                                                        9.7 MiB

Wild:
.eh_frame_hdr                                                    1.1 MiB
.eh_frame                                                        9.0 MiB

That's interesting that the total size of those sections is smaller. I wonder what's causing that. Especially given that Wild is emitting more CIEs. Perhaps Wild is emitting less FDEs for some reason.
If I use the commands from the first comment of this issue to look at the clang binary, I get 1 CIE for lld and 2746 for Wild. Worse, if I look at the rustc-driver shared object, I get 2 for all the linkers except for Wild, which ends up with 15025.


FEAT: have an all ctf's page

ctf's will keep piling up on the first page. I was thinking that we could have an "all cts" page (paginated with links to all ctf's that we've been part of

ctf's will keep piling up on the first page. I was thinking that we could have an "all cts" page (paginated with links to all ctf's that we've been part of

I am not sure I understand, also referring to ctf links may be dangerous if their websites are down ?

@Stefan-Radu up ?

@Mathis-Dory sorry, I forgot to respond to this.
I was suggesting to have a separate page listing all ctf's we've taken part in, because the first page will get very full. And this separate page can be paginated so it's easy to navigate and doesn't just show a huge list
Regarding links I wasn't referring to links to the ctf's website, but to our website's page for that ctf, where all the writeups are listed

@Mathis-Dory sorry, I forgot to respond to this. I was suggesting to have a separate page listing all ctf's we've taken part in, because the first page will get very full. And this separate page can be paginated so it's easy to navigate and doesn't just show a huge list
Regarding links I wasn't referring to links to the ctf's website, but to our website's page for that ctf, where all the writeups are listed

Make sense, again I will claim it if I have some time in the next few days


show expressivity and penetrance in term detail view

did we used to? I'm sure that we did
http://pombase2.aska.gen.nz/term/FYPO%3A0000099

Term detail view does show expressivity and penetrance ... when any are annotated.
FYPO:0000099 will never have any penetrance extensions because it's a population term, and happens not to have any annotations with expressivity extensions.

Ah OK, I thought that was odd as there are double mutants  with no expressivity, presumably much sicker than the contributing, single mutants which are also listed.... but no worries...

I wouldn't assume that - the comparison is always to wild type

Its good to add the expressivity  to the doubles, to indicate whether the expressivity is the same or different from the single. If the phenotype if  its the same as the single,  it isn't additive (so not net effect).  It's unusual for  people show sensitivity for doubles and exclude single mutant? The same expressivity of phenotype might indicate same pathway, but it could also be that one allele might be making no contribution to the phenotype....
I guess this indicates why double mutants aren't so useful in lists as single mutants when you  always know that there is an effect...

It's good to add the expressivity to the doubles, to indicate whether the expressivity is the same or different from the single.

I agree, but it's not always practical because we don't have any absolute quantitative measure for expressivity. If an experiment just shows that yfg1 and the yfg1 yfg2 double mutant are equally sensitive to X, there's no straightforward way to say whether that expressivity is low, medium, or high.
I have made some annotations where I've included a "same as yfg1 alone" sort of comment.


Syntactic error when building

When I build IdrisWeb by
idris --build idris_web.ipkg

I get a syntactic error
./IdrisWeb/DB/SQLite/SQLiteNew.idr:321:17: error: not
    a terminator, expected: (....)
reset = if_left then ResetFromEnd else Reset

I also saw a lot of if_valid scattered through the same file. My idris version: <IP_ADDRESS>-git:f50a883

@david-christiansen & @SimonJF, this will be a bit longish, so! I'll preface by saying I'm very happy to make any PRs necessary to help get this project up & running with Idris 0.9.20 (I'm running <IP_ADDRESS>).
The project now fails to build due to the recent FFI changes:
λ idris --install idris_web.ipkg
Entering directory `./src'
make: Nothing to be done for `all'.
Type checking ./IdrisWeb/Common/Random/RandC.idr
./IdrisWeb/Common/Random/RandC.idr:8:11:
When checking right hand side of getRandom with expected type
        IO Int

No such variable mkForeign

I think that this line (IdrisWeb/Common/Random/RandC.idr:8:11):
getRandom min max = mkForeign (FFun "random_number" [FInt, FInt] FInt) min max

should now be:
getRandom min max = foreign FFI_C "random_number" (Int -> Int -> IO Int) min max

Next, it looks like we need to update the package syntax:
λ idris --install idris_web.ipkg
Entering directory `./src'
make: Nothing to be done for `all'.
Type checking ./IdrisWeb/Common/Random/RandC.idr
Can't find import Effects

I think this change to idris_web.ipkg will do it:
package idrisweb

opts = "--typecase"
pkgs = effects, simpleparser

At this point, we start getting the above-noted if_valid errors (IdrisWeb/DB/SQLite/SQLiteNew.idr:321:17):
reset = if_left then ResetFromEnd else Reset

I'm happy to make the FFI and package changes (in separate PRs) if the incremental improvement seems worthwhile; if you have the time to provide some guidance, I'm also happy to work on porting to the new Effects library or doing whatever needs doing.
Thanks so much for your work on this project! I've only just started working with Idris, but love it so far.

I'd be happy to answer what questions I can if you want to work on de-bitrotting this lib. I haven't done the real work on this library, but I think you've identified what needs doing.
I don't think it's realistic to do these in separate PRs, because you can't test it until all of them are done. So I'd just update it to work with the newest Idris, and send a commit.
Thanks!

@david-christiansen Makes sense; I'll get cracking and submit a PR (though it may be large) when ready.
Are there preferred replacements for if_left and if_valid?

On December 6, 2015 9:19:32 PM GMT+01:00, Eric Weinstein<EMAIL_ADDRESS>wrote:

@david-christiansen Makes sense; I'll get cracking and submit a PR
(though it may be large) when ready.
Are there preferred replacements for if_left and if_valid?

Reply to this email directly or view it on GitHub:
https://github.com/idris-hackers/IdrisWeb/issues/10#issuecomment-162344431

Pattern matching on the result of the call does the same thing now!

:+1:

@david-christiansen Making good headway! Are these SQLite bindings relatively current (would they be useful in updating src/IdrisWeb/DB/SQLite/SQLiteNew.idr)?

Done so far:

[x] FFI updates (s/mkForeign/foreign/)
[x] Updated package syntax
[x] Replaced deprecated if_* with pattern matching

Working on:

[ ] Updated SQLite bindings (it looks like the Effects library has moved ahead of this library)
[ ] Any other Effects-related updates that need doing

@ericqweinstein Hey there, I was playing around with making IdrisWeb compile when I stumbled upon this issue and I see you already made some progress in solving it :+1:
Any idea on when you might have time to complete the update? Or maybe share a "work-in-progress" branch on what you have updated so far?

Hi, sorry I seem to have missed this.
I'd say that this is in need of a rewrite now -- the Effects library that was current back when this library was written is deprecated now.
IdrisWeb provided:

Effectful bindings for CGI, SQLite, and web sessions
A web form DSL

What were you looking for from the library?
Reflecting on the web form DSL, I now think there are better ways of doing this (Formlets, in particular) and this implementation, while an interesting experiment, rather overcomplicates things.

@SimonJF oh I see, I wanted to setup a simple webpage using Idris. I want to learn the language and I thought working with already existing, simple code, would be a very good learning experience.

@neduard Thanks for reminding me about this! I sort of fell down a rabbit hole and agree with @SimonJF that this probably needs to be rewritten, given the changes in Idris and the Effects library since this repo was started. I'm happy to collaborate on that—things are a bit hectic on my end this week, but I'm free to help out starting next. 👍


mct advanced: switched back to cu1 instead of crz

Summary
The crz gate does not work if the control qubits are in superposition. The cu1 gate is the correct way to go.
Details and comments
I think this should be covered somehow in test cases, maybe just putting an Hadamard gate in front of the control qubits.

@tigerjack thx for checking on this! do you also want to open an issue, say, suggesting that the corresponding test(s) cover the superpositioned-controls case?