[LLVMGPU] Use forall workgroup distribution in TileAndFuse pipeline

This switches the TileAndFuse pipeline to use scf.forall distribution. Using scf.forall distribution also requires some changes to the pass ordering in the TileAndFuse pipeline, which is also handled by this PR:

The main difference is that PackToIntrinsics happens before workgroup distribution. Otherwise, collapse_shape ops can end up at the end of the workgroup forall, and an extra buffer is created.
Pack decomposition is now staged, with packs/unpacks at the function boundaries being decomposed early before workgroup decomposition, and the rest being decomposed after reduction tiling as before. This prevents unpacks being fused into the workgroup forall and causing the same problem as in (1).
createConcretizeMmaShapes now runs before workgroup tiling as well, so the resulting collapse_shape on the multi_mma op result can be propagated to the function boundary before any tiling. This is also to avoid the same problem as in (1).

The lowering configs on the MMA path have also changed, since they now need to account for inner tile sizes of packing.
depends on https://github.com/iree-org/iree/pull/18469

The main difference is that PackToIntrinsics happens before workgroup distribution. Otherwise, collapse_shape ops can end up at the end of the workgroup forall, and an extra buffer is created.

Can you share an example of this? If the collapse shape is at the end of workgroup for all, i'd expect we can fold it away with flow.dispatch.tensor.store ops.

The main difference is that PackToIntrinsics happens before workgroup distribution. Otherwise, collapse_shape ops can end up at the end of the workgroup forall, and an extra buffer is created.

Can you share an example of this? If the collapse shape is at the end of workgroup for all, i'd expect we can fold it away with flow.dispatch.tensor.store ops.

You can end up with IR like this:
    %collapsed = tensor.collapse_shape %transposed [[0, 1], [2, 3]] : tensor<4x16x4x16xf32> into tensor<64x64xf32>
    scf.forall.in_parallel {
      tensor.parallel_insert_slice %collapsed into %arg2[%arg0, %arg1] [64, 64] [1, 1] : tensor<64x64xf32> into tensor<2048x10240xf32>
    }

And it would not be correct in general to fold the collapse_shape into the parallel_insert_slice/forall dest. This collapse_shape comes from the tensor.unpack after PackToIntrinsics. Moving PackToIntrinsics and DecomposePackUnPack before workgroup distributions means the collapse_shape will be outside of the scf.forall already, and then the transpose from the unpack can be fused into the forall loop. Then, the collapse_shape can be folded into the flow.dispatch.tensor.store consumer outside of the forall, since it is a full slice.


Remove legacy qt references

I know this requires changing the ZcashFoundation/zec-qt-wallet repo name and other changes but I think it's important to avoid future confusion.

Hey @rex4539,
Thanks for the pull request. Unfortunately, all these can't be easily renamed yet, because of various issues.
Renaming the package name in the installers causes problems upgrading. I haven't figured out how to do that safely yet. The repro / project file renaming is also causing trouble with the build/signing for the installers. I have to figure out how to do this properly.

ok, withdrawing for now.


Change destination folder for Resize.

Hi !
I'd like to change the destination directory for the Resize filter.
So I went to the Resize.php file, and made the changes directly in it, to test. But now i'd like to override the function run() of that file. Is it possible to do it in the functions.php of my theme ?
`<public function run( $load_filename, $save_filename ) {
-> $save_filename = (str_replace('uploads', 'resized', $save_filename));
    // Attempt to check if SVG.
	if ( ImageHelper::is_svg($load_filename) ) {
		return false;
	}

....
`
Thank you for your help !

is this what you are looking for
https://timber.github.io/docs/v2/hooks/filters/#timber/sideload_image/subdir

Closing as stale


Kubeflow dashboard: Cannot load dashboard menu link

/kind bug
What steps did you take and what happened:

On a fresh Ubuntu 20.04.02 LTS virtual machine
Installed kubeflow using microk8s by following these instructions:

sudo snap install microk8s --channel 1.20/stable --classic
sudo microk8s status --wait-ready
sudo usermod -a -G microk8s $USER
sudo chown -f -R $USER ~/.kube
microk8s.enable dns dashboard storage
microk8s.enable kubeflow

and it reported that the kubeflow is ready
3. Logged into the dashboard successfully (not from the first attempt though, there were several 404s but it fixed itself)
4. The dashboard was missing essential links to Jupyter Notebooks and Pipelines, sample pipelines were also missing and the error "Cannot load dashboard menu link" was displayed, as shown on the screenshots below:

What did you expect to happen:

Jupyter Notebook and Pipelines links are present on the dashboard.
No errors shown.

Suspects:
The configmaps/centraldashboard-config config map is missing in the deployment.
Investigation:

As seen in the browser console, the /api/dashboard-links URI returns 500 error.
I have the following virtual services in the kubeflow namespace:

$ microk8s.kubectl -n kubeflow get vs
NAME                 GATEWAYS                        HOSTS   AGE
argo-ui              ["kubeflow/kubeflow-gateway"]   ["*"]   26h
dex-auth             ["kubeflow/kubeflow-gateway"]   ["*"]   26h
jupyter-web          ["kubeflow/kubeflow-gateway"]   ["*"]   26h
kubeflow-dashboard   ["kubeflow/kubeflow-gateway"]   ["*"]   26h
pipelines-api        ["kubeflow/kubeflow-gateway"]   ["*"]   26h
pipelines-viewer     ["kubeflow/kubeflow-gateway"]   ["*"]   26h
katib-ui             ["kubeflow/kubeflow-gateway"]   ["*"]   26h
metadata-ui          ["kubeflow/kubeflow-gateway"]   ["*"]   26h
oidc-gatekeeper      ["kubeflow/kubeflow-gateway"]   ["*"]   26h
pipelines-ui         ["kubeflow/kubeflow-gateway"]   ["*"]   26h

The route /api/dashboard-links is supposed to be matched to the kubeflow-dashboard virtualservice and sent to the kubeflow-dashboard ClusterIP service:

spec:
  gateways:
  - kubeflow/kubeflow-gateway
  hosts:
  - '*'
  http:
  - match:
    - uri:
        prefix: /
    rewrite:
      uri: /
    route:
    - destination:
        host: kubeflow-dashboard.kubeflow.svc.cluster.local
        port:
          number: 8082

The kubeflow-dashboard service says it was not able to get a ConfigMap:

$ microk8s.kubectl -n kubeflow logs -f -l juju-app=kubeflow-dashboard -c kubeflow-dashboard
Unable to fetch ConfigMap: {
  kind: 'Status',
  apiVersion: 'v1',
  metadata: {},
  status: 'Failure',
  message: 'configmaps "centraldashboard-config" not found',
  reason: 'NotFound',
  details: { name: 'centraldashboard-config', kind: 'configmaps' },
  code: 404
}

The centraldashboard-config is indeed missing in the deployment:

$ microk8s.kubectl -n kubeflow get configmaps centraldashboard-config
Error from server (NotFound): configmaps "centraldashboard-config" not found

$ microk8s.kubectl get configmaps --all-namespaces | grep centraldashboard-config
$ # Nothing here!

Another 500 error in the browser console comes from the /pipeline/apis/v1betra1/pipelines URL managed by the pipelines-api virtualservice:

spec:
  gateways:
  - kubeflow/kubeflow-gateway
  hosts:
  - '*'
  http:
  - match:
    - uri:
        prefix: /apis/v1beta1/pipelines
    rewrite:
      uri: /apis/v1beta1/pipelines
    route:
    - destination:
        host: pipelines-api.kubeflow.svc.cluster.local
        port:
          number: 8888

And there it fails with en error I cannot interpret:

$ microk8s.kubectl -n kubeflow logs -l juju-app=pipelines-api -c pipelines-api
github.com/kubeflow/pipelines/backend/api/go_client._PipelineService_ListPipelines_Handler
	bazel-out/k8-opt/bin/backend/api/linux_amd64_stripped/go_client_go_proto%/github.com/kubeflow/pipelines/backend/api/go_client/pipeline.pb.go:1040
google.golang.org/grpc.(*Server).processUnaryRPC
	external/org_golang_google_grpc/server.go:966
google.golang.org/grpc.(*Server).handleStream
	external/org_golang_google_grpc/server.go:1245
google.golang.org/grpc.(*Server).serveStreams.func1.1
	external/org_golang_google_grpc/server.go:685
runtime.goexit
	GOROOT/src/runtime/asm_amd64.s:1333

Hi. I am also facing the same error. Took the same steps to install kubeflow on an Ubuntu 18.04.5 LTS virtual machine. Below is how the dashboard looks now.

Console logs:

Only /api/dashboard-links is returning 500 error. Ran the same commands mentioned above and verified that centraldashboard-config is missing.
$ microk8s.kubectl -n kubeflow logs -f -l juju-app=kubeflow-dashboard -c kubeflow-dashboard
Unable to fetch ConfigMap: {
  kind: 'Status',
  apiVersion: 'v1',
  metadata: {},
  status: 'Failure',
  message: 'configmaps "centraldashboard-config" not found',
  reason: 'NotFound',
  details: { name: 'centraldashboard-config', kind: 'configmaps' },
  code: 404
}

$ microk8s.kubectl -n kubeflow get configmaps centraldashboard-config
Error from server (NotFound): configmaps "centraldashboard-config" not found

Any help is appreciated. Thanks

@olokshyn: Can you run microk8s inspect and post the generated tarball here? microk8s.enable kubeflow should not yet be enabling the most recent kubeflow dashboard (updating microk8s to include that version is over here: https://github.com/ubuntu/microk8s/pull/2213).
At any rate, you can manually create the configmap as a workaround with this command:
microk8s kubectl apply -n kubeflow -f https://raw.githubusercontent.com/kubeflow/manifests/master/apps/centraldashboard/upstream/base/configmap.yaml

@knkski thanks for your workaround! I can confirm it fixes the problem!
The inspection report is attached: inspection-report-20210428_035406.tar.gz.

@olokshyn: Can you run microk8s inspect and post the generated tarball here? microk8s.enable kubeflow should not yet be enabling the most recent kubeflow dashboard (updating microk8s to include that version is over here: ubuntu/microk8s#2213).
At any rate, you can manually create the configmap as a workaround with this command:
microk8s kubectl apply -n kubeflow -f https://raw.githubusercontent.com/kubeflow/manifests/master/apps/centraldashboard/upstream/base/configmap.yaml

I followed the same steps with the OP. But, while this command makes the menu visible, when I click one of the items it does not work as expected:

This should be fixed now


bufferline not updating when using vim-bbye or BClose

Issue:
Since I don't want to delete splits when deleting a buffer, I am running :Bclose offered by vim-bbye. This sometimes leads to not updating the bufferline or even removing the whole bufferline itself.
With scripts like BClose I have similar behaviour.
How to reproduce:

Install lightline-bufferline
install vim-bbye
open two buffers

Delete first buffer

As you can see, .vimrc is still in the bufferline although deleted. :e will refresh the bufferline.

Delete second buffer

Aaaand its gone....
Procedure might differ slightly. But essentially lightline-bufferline seems to have trouble with various kind of Bclose implementations.

Sorry for the late response. I somehow missed this issue. I will have a look at it and will try to reproduce it on my machine.

I could not reproduce it with neovim 0.4.3 and vim 8.1 together with vim-bbye and the Bclose script. The bufferline is correctly updated for me. Can you share a minimal vimrc config that reproduces the issue for you?

I am closing this due to the lack of feedback and because I cannot reproduce the issue. Feel free to reopen this issue if you are still experiencing this and can provide a minimal vimrc config that reproduces it.


add ipvs case

add ipvs case
fix  https://github.com/kubean-io/kubean/issues/699
fix kubean deploy.sh to match new kubean helm chart structure
update some paramater name
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
https://github.com/kubean-io/kubean/issues/699
Special notes for your reviewer:

self repo offline result: https://github.com/wenting-guo/kubean/actions/runs/4943126903/jobs/8837930416

/lgtm


PROD-XXX - Use server porvided training code

See related PR on server side: https://github.com/nimble-technology/nimble-distributed-evaluators/pull/43

The server will provide the code to execute. The miner will compute the md5 hash of the code sent by server, and submit it to server after task is done for validation purposes.
The trainer and job completion code is now managed by server.

How to ensure server security? If the server is hacked, the entire network is completely compromised, and the risk spreads to every miner's computer?


How predict a single image?

Hello, firstly thank your for your god job.
How can I predict a single image? Can you give an example?

Sorry but the current model is based on a polarized camera, it cannot support direct inference by a single image.
If you want to use one single image for inference, please train another pipeline with unpolarized image pairs.


Added support to PurgeCSS

Tackled #1329 with PurgeCSS.
Being talking with @varuniyer about using jekyll-uncss to reduce css file sizes by ditching unused classes. This approach have 3 main problems:
1 - have some limitations as pointed here
2 - last update to jekyll-uncss was about 3 years ago, so it might have a few issues
3 - uncss haven't seem a new release in a while, currently lacking maintenance, and using some deprecated libraries as seem here:
npm install -g uncss
npm WARN deprecated<EMAIL_ADDRESS>request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142

I thought about giving PurgeCSS a go, since it has been more actively maintaned, but jekyll-purgecss haven't.
For this, I needed to change to use some local libraries instead of getting them via CDN. The good news is that it is quite effective in reducing css file sizes. Comparing dir sizes with du -hs _site/assets/css/:

current
minify
PurgeCSS
PurgeCSS + minify

1,1M
988K
456K
420K

It would be a lot better if we could see the online version of the site after the pull request without building it locally. Is it possible for Jekyll? @rohandebsarkar

For this specific case I can use these commits in my demo site and we can check if everything is ok there. What do you think?
Another solution is to create an install script to install everything needed to run locally outside of docker, so you could test it. But I agree, see an online version after each PR (or at least select the PRs to which generate a temporary demo from) would be better.

Just tried out the changes in my personal site and run a few times.
Before:

Desktop
Mobile

Before

After

Tried to add bootstrap-table to use local files, but for some reason it messes with it and I can't avoid it, even after adding it to ignore files in purgecss. Best keep it loading from web.
Before purge:

After purge:


[RFC] State Separation

Here is the RFC to replace amethyst/amethyst#1199
Related to amethyst/amethyst#1152 (About the simplicity issue)
This started it's life as a working prototype implementation of what is being proposed.
Rendered

Something I wanted to bring up for a long time is that state is actually not something that should be limited to "one global state" if that makes sense.
Let me elaborate:
There are of course high-level states of the game; these mostly represent different parts of the game (loading, main menu, in game, etc). However, there are actually multiple independent graphs for states in practice. Imagine things like animation, AI behaviour, player controls (on foot, driving, etc). Wouldn't it be nice if our states could achieve all that?
I've experimented with a generic state machine a while ago (machinae). However, there was some issue that made it impossible to use in certain situations. I can't recall what that was exactly. Just wanted to bring that up.
This also relates a little bit to the states vs systems issue and the thread on Discourse.
I think I'll actually create a new thread about this. Link-

AI behaviour, player controls (on foot, driving, etc). Wouldn't it be nice if our states could achieve all that?

It seems like you have one in mind, so if you could outline a concrete example that would help.
It's worth noting that there are two potential solutions that allow you to emulate the old architecture:

Use a custom state that has effectively non-finite values and build and destroy as many as you want/need dynamically (e.g. u64).
Maintain your own stack of "data" inside a single state callback instance, i.e. push to it on on_start, pop on on_stop.

I do find it now compelling to have a single instance because that is the use case I see being overrepresented in both the examples and games currently being built. So in the spirit of making the default thing easy, that is what I propose.

I had some inspiration and realized this could support "complex states" quite easily through the derive:
#[derive(State, Debug, Clone, PartialEq, Eq, Hash, Default)]
struct Complex {
    name: String,
}

#[derive(State, Debug, Clone, PartialEq, Eq)]
enum State {
    A,
    Named(&'static str),
    Complex(Complex),
    StopIt,
}

The State trait had to be modified a bit with the type parameter T specifying what is stored in the state:
/// The trait associated with a state.
///
/// # Type Parameters
///
/// - `E`: The event associated with the state.
/// - `T`: The value stored in state storage.
///        This can be used to implement forward storage for other types, like when nesting states.
pub trait State<E, T = Box<dyn StateCallback<Self, E>>>: Clone + Default + fmt::Debug
where
    Self: Sized,
{
    /// The storage used for storing callbacks for the given state.
    type Storage: StateStorage<Self, T>;
}

Deriving State on a struct builds the following implementation:
impl<E, T> amethyst::State<E, T> for Complex {
    type Storage = amethyst::MapStateStorage<Self, T>;
}

I've added an example for it here:
https://github.com/udoprog/amethyst/blob/enum-state-machine/examples/states/main.rs

GameData was there to allow having shared dispatchers between states. How can we do this under this architecture?

GameData was there to allow having shared dispatchers between states. How can we do this under this architecture?

My long term goal is to strive to provide the necessary architecture to only need one dispatcher.
That being said, we have global callbacks that can drive additional dispatchers depending on which value the state resource has. Something like this:
#[derive(State, Debug, Clone, Copy, PartialEq, Eq)]
pub enum State {
    First,
    Second,
}

struct DispatcherDriver<S>(S, Dispatcher<'static, 'static>);

impl<S, E> GlobalCallback<S, E> for DispatcherDriver<S>
where
    S: 'static + Send + Sync + PartialEq + Eq,
{
    fn update(&mut self, world: &mut World) -> Trans<S> {
        if self.0 == *world.read_resource::<S>() {
            self.1.dispatch(&world.res);
        }

        Trans::None
    }
}

Note have the above is:

Modular, you can drive as many dispatchers as you want with this single type.
Generic over the the specific State it's running for.
Only responsible for doing "one thing" in isolation which is generally easier to document and teach.

Finally got here, and your design is excellent; thanks for going through that cray cray amethyst_test crate as well.

There are of course high-level states of the game; these mostly represent different parts of the game (loading, main menu, in game, etc). However, there are actually multiple independent graphs for states in practice. Imagine things like animation, AI behaviour, player controls (on foot, driving, etc). Wouldn't it be nice if our states could achieve all that?

I have a feeling that some of the methods on the StateCallback aren't always applicable to the lower level state machine, some example cases:

entity being limited to only one state at a time, without stacking (on_resume, on_pause not applicable)
state does an update based on the data in the world (pulled events) rather than pushed events (handle_event not applicable). sounds like I'm talking about a System rather than a State
not sure if both update and fixed_update are always applicable

That said, does leaving a trait method empty for all implementations get optimized out? If so, it wouldn't hurt at runtime, perhaps there's a little confusion at development time if people look at docs and ask "what about these trait methods".

I haven't understood the global state callback use case + complex states yet, shall take another look later.
Removing GameData makes sense given we can use a resource to determine if a System should run.
And, I think it's possible with the SystemExt trait, as well as the previous comment, but I'd like the ability to specify the logic for "this group of systems should run in this State" in the same place, which is separate from the system's own logic.

Hello,
I'm back, and I've rebased the refactored the prototype on top of the latest master (thanks @torkleyy for changing every state implementation :D).
It would help if people could outline any concerns that they still have, and I can try and address them to get this RFC rolling again.
Thank you!

Here's my proposal for a more data-driven pushdown FSM

Should I open a separate rfc or should this be discussed here?
Short explanation: Instead of deciding at runtime which event triggers which state transition, they are all determined in advanced as data.
For example, the MyEvent::Play user event triggers a transition from StateA to StateB using Push.
In the State, you can just return Option<MyEvent> instead of the complex Trans type.
This only works if states aren't depending on runtime data (same as this PR).
It would fit well within this PR I think. Systems could trigger the state transitions by emitting the events into the TransCallback (which would now accept the MyEvent user type, and not Trans). Events would only have an effect if you are in the starting state of the transition (A -> B, you need to be in A to go to B). This means that Systems wouldn't need to be aware of which state you are currently in, while still being able to trigger state transitions.
This solves my concern with this pr, and should answer what @Xaeroxe asked.
Also we have way less Box like this :D

@jojolepro @azriel91 That's an interesting idea, however I'm concerned it adds too much complexity to the implementation for the benefit it gives.
If we're to make a distinction between "code" and "data" then I would argue States and their transitions are very firmly in the camp of "code".  I don't feel a data oriented approach for states gives us many benefits, and it mostly seems to add complexity and increase maintenance costs for both engine and game developers.
It could possibly give us a tiny squeak of performance boost from not having to use Box but I'm not convinced at this time that such a boost is worth the maintenance overhead that introduces.

That's an interesting idea, however I'm concerned it adds too much complexity to the implementation for the benefit it gives.

Gotcha, am already super happy with the current proposed mechanism (and sometimes hope that we one day reach stability 📆). Also, I probably get too caught up in things that we could do, and don't stop enough to think if it's something we should 😅.

@jojolepro @azriel91

Should I open a separate rfc or should this be discussed here?

If I'm reading this correctly, your goals are to only allow a certain set of "legal" state transitions driven by events?
In that case this does seem like something we should punt until a later RFC, since it adds another step of indirection to, and fundamentally changes (limits?) how state transitions work. If anything I'd like proposals how to simplify this without sacrificing the separation it tries to accomplish.

If I'm reading this correctly, your goals are to only allow a certain set of "legal" state transitions driven by events?

yeap that was one of the goals I had. The other one was to be able to separate "what state am I transitioning to" out of the state handler, into "I'm done!" or "The user cancelled", and let something outside decide what state it should transition to (data vs code like Xaeroxe said).

So I've discovered another way to motivate why this change has a positive impact in how Amethyst applications are modeled.
Many problems can be phrased as "I want to do x when the application is in a given state" - if you've been around for a while this seems to be a very common request in #help. Whether that is drive a dispatcher or have some custom logic that runs for a specific state.
In order to do something for a specific state today, we are required to add that something to a single large State implementation. This leads to the state implementation being rather complex, and to push back against this complexity we've done things like SimpleState.
Forcing us to name states, and allowing us to associate specific pieces of logic with this name makes this cleaner.

Systems can read the resource that tells it which state it is currently in.
State handlers can be more modular and do one thing well, since it doesn't have to be able to do all the things we need a state handler to do today*.

*: Ultimately this might even be an argument for allowing associating multiple handlers to any one state, but I'm not gonna push for that right now.

Systems can read the resource that tells it which state it is currently in.

That would, however, make systems dependent on the State. The big problem with that is that it doesn't compose well; systems should be stateless.
I think however, there is a need for state specific functionality that doesn't just get thrown into the state impl.

One thing I'd also like to bring up is that I don't really like our current Application because while it has a bunch of useful features, it means you have to give up control of how your game is ran.

Systems can read the resource that tells it which state it is currently in.

That would, however, make systems dependent on the State. The big problem with that is that it doesn't compose well; systems should be stateless.

Consider systems which are generic over the state. For example:
struct Example(S);

impl<'a, S> System<'a> for Example<S> where S: State + PartialEq {
  type SystemData = Read<'a, S>;

  /* ... */
}

This can do things with any state S, without dictating exactly which state it is. In that sense it composes rather well.

One thing I'd also like to bring up is that I don't really like our current Application because while it has a bunch of useful features, it means you have to give up control of how your game is ran.

I think many of the things in Application could in principle be refactored into distinct GlobalHandler implementations. But I'm gonna suggest punting on this for now as out of scope for this RFC.


code centralization: publish content navigation component

The content-navigation component is currently used in both headless cannabis and drought sites. The code required to render it should be published to npm with a readme describing the module and the required package files. The code for the component should be checked into the design-system repository and deleted from the cannabis and drought repositories. The feature should be used in both sites via npm install. All sass variables not defined inside this component should be replaced with css variables. These variables should be defined in the site code that installs this component
This is a first step towards making this component a member of the design system. We are publishing it in a central location now to prevent code drift.

Pull requests:
https://github.com/cagov/design-system/pull/38
https://github.com/cagov/cannabis.ca.gov/pull/294


[RFC][OpenCLML] OpenCLML integration as BYOC

I'll merge this week unless there is a further comment cc @FrozenGene

LGTM. I don't have any other comments.


Multiple expectedOrigin and expectedRPID

Hello,
Thanks for your great work.
I have a use case that seems not working with the current implementation of the lib.
When using SimpleWebAuthn on a browser extension I have different expectedOrigin and expectedRPID for Firefox / Chrome / ...
Maybe I'm wrong but the only way I see to have the lib working with this use case is to change both expectedOrigin and expectedRPID from string to tables so that I can check if the origin and rpId in the attestation/assertion are in the list.
Is my interpretation correct and is it worth to support this use case in the lib?

It's hard to comment on this without knowing more about your use case but can't that lookup information and logic not reside in the extension, prior to calling verifyAttestationResponse or verifyAssertionResponse? Typically a server implementing this library is only going to have a single expected RP ID and origin.

It's hard to comment on this without knowing more about your use case but can't that lookup information and logic not reside in the extension, prior to calling verifyAttestationResponse or verifyAssertionResponse? Typically a server implementing this library is only going to have a single expected RP ID and origin.

From the test we made the origin is different between browsers (and dev/prod environement) as the extension register with a built-in origin, for instance on Firefox it is moz-extension://dbac9369-xxxx-xxxx-xxxx.
So in our case the browser extension ask the server on api.domain.com for the challenge, do its webauthn.create/get and send it back to the server for validation.
We could somehow detect that it's a chrome or firefox browser extension that is calling us and then choose the right expectedOrigin/RPID but that would be way easier with the proposal I made in my previous message.
Let me know what you think :)

From the test we made the origin is different between browsers (and dev/prod environement) as the extension register with a built-in origin, for instance on Firefox it is moz-extension://dbac9369-xxxx-xxxx-xxxx.
So in our case the browser extension ask the server on api.domain.com for the challenge, do its webauthn.create/get and send it back to the server for validation.
We could somehow detect that it's a chrome or firefox browser extension that is calling us and then choose the right expectedOrigin/RPID but that would be way easier with the proposal I made in my previous message.
Let me know what you think :)

Oh, are you using WebAuthn to protect access to some aspect of your browser extension? What a fascinating use case! I see now, with UUID-like origins like that, how it would be difficult to ensure a consistent RP ID across environments.
So then, to clarify, the request is to change expectedOrigin and expectedRPID to accept string | string[] instead of just string so that multiple possible values for either can be passed into the verify methods?

Oh, are you using WebAuthn to protect access to some aspect of your browser extension? What a fascinating use case! I see now, with UUID-like origins like that, how it would be difficult to ensure a consistent RP ID across environments.
So then, to clarify, the request is to change expectedOrigin and expectedRPID to accept string | string[] instead of just string so that multiple possible values for either can be passed into the verify methods?

Yes, exactly, two use cases: 2FA and access validation (I can give you concrete examples of this in private as I don't want to leak too much information publicly).

So then, to clarify, the request is to change expectedOrigin and expectedRPID to accept string | string[] instead of just string so that multiple possible values for either can be passed into the verify methods?

Correct, then it would be something like if (!expectedOrigin.includes(data.origin)) return new Error('wrong origin');.
If you agree with this, I can work on a pull request.

Yes, exactly, two use cases: 2FA and access validation (I can give you concrete examples of this in private as I don't want to leak too much information publicly).

So then, to clarify, the request is to change expectedOrigin and expectedRPID to accept string | string[] instead of just string so that multiple possible values for either can be passed into the verify methods?

Correct, then it would be something like if (!expectedOrigin.includes(data.origin)) return new Error('wrong origin');.
If you agree with this, I can work on a pull request.

@Mikescops Take a look at PR #91 and let me know if anything looks off, otherwise I'll merge it in later today and cut a release.

@Mikescops Take a look at PR #91 and let me know if anything looks off, otherwise I'll merge it in later today and cut a release.

@MasterKale wow that's fast, thanks! 👍

@MasterKale wow that's fast, thanks! 👍


No test file for sthv1,v2 and anet

For these datasets, there are only run.sh files. For test files, can they be copied from run.sh with TRAIN.ENABLE False? So, the test file in sthv2 may look like this:
NUM_SHARDS=$SLURM_NNODES
NUM_GPUS=$WORLD_SIZE
BATCH_SIZE=128
BASE_LR=4e-5
work_path=./exp/sthv2/ssv2_b16_f16x224/
PYTHONPATH=$PYTHONPATH:./slowfast
python tools/run_net_multi_node.py
--init_method tcp://localhost:10125
--cfg $work_path/config.yaml
--num_shards $NUM_SHARDS
DATA.PATH_TO_DATA_DIR /data/gpfs/projects/punim0512/data/sth-sthv2/kc_label
DATA.PATH_PREFIX /data/gpfs/projects/punim0512/data/sth-sthv2/20bn-something-something-v2
DATA.PATH_LABEL_SEPARATOR ","
TRAIN.EVAL_PERIOD 1
TRAIN.CHECKPOINT_PERIOD 50
TRAIN.BATCH_SIZE $BATCH_SIZE
TRAIN.SAVE_LATEST False
NUM_GPUS $NUM_GPUS
NUM_SHARDS $NUM_SHARDS
SOLVER.MAX_EPOCH 22
SOLVER.BASE_LR $BASE_LR
SOLVER.BASE_LR_SCALE_NUM_SHARDS False
SOLVER.WARMUP_EPOCHS 5.
TRAIN.ENABLE False
DATA.TEST_CROP_SIZE 224
TEST.NUM_ENSEMBLE_VIEWS 1
TEST.NUM_SPATIAL_CROPS 3
TEST.TEST_BEST True
DATA.MC True
RNG_SEED 6666
OUTPUT_DIR $work_path

I can see that run.sh will test the model performance automatically after the model train in sthv2 case. But the test results is like "logging.py:  99: json_stats: {"split": "test_final", "top1_acc": "0.60", "top5_acc": "2.91"}". Does it mean the top1_acc is 60% ? but how to interpret top5_acc?

The top1_acc and top5_acc is actually 0.60% and 2.91%. It seems that you do not load the pretrained model, thus you get the random prediction (1/174≈0.60%). To load the pretrained model, you have to set TEST.CHECKPOINT_FILE_PATH.

I can see that run.sh will test the model performance automatically after the model train in sthv2 case. But the test results is like "logging.py: 99: json_stats: {"split": "test_final", "top1_acc": "0.60", "top5_acc": "2.91"}". Does it mean the top1_acc is 60% ? but how to interpret top5_acc?

Hi, how do I load the pre-training model correctly, I set CHECKPOINT_FILE_PATH in the run.sh file, but it didn't work!

Can you provide your full run.sh?

Thank you for your reply, here's the run.sh file I used for training.
 \   DATA.TEST_CROP_SIZE 224 \   TEST.NUM_ENSEMBLE_VIEWS 1 \   TEST.NUM_SPATIAL_CROPS 3 \   TEST.TEST_BEST True \   TEST.CHECKPOINT_FILE_PATH "./model/vit_b16.pth" \   DATA.MC True \   RNG_SEED 6666 \   OUTPUT_DIR $work_path

It seems that the model you loaded is CLIP pretraining. Please download the model from MODEL_ZOO to reload it.


Improvements to WMS GetFeatureInfo

Break out the handling of feature information in various formats to GetFeatureInfoFormat.js.
Add support for WMS servers, such as Google Maps Engine, that can only return feature information in HTML format.
WebMapServiceImageryProvider now accepts an array of GetFeatureInfoFormat instances that it will use to obtain information about the features at a given position on the globe.  This enables an arbitrary info_format to be passed to the WMS server, and an arbitrary JavaScript function to be used to interpret the response.

This looks good, thanks.


FluxEngine-GUI: where is the customized configfile stored?

Hi,
I tried to modify the custom config-file...
I made a mistake - now alltime the GUI starts with my damaged config and I can't use the GUI.
There are no function to reset the config.
So I looked in the registry, but not found anything; there also no .cfg files or something like that in the app-folder.
Where else?

What platform are you on?
On Windows it's in the registry, somewhere in HKEY_LOCAL_MACHINE. On Linux it'll be in .config somewhere. On OSX... not sure. Some plist file somewhere. It's all abstracted behind a WxWidgets utility class (https://docs.wxwidgets.org/3.0/classwx_config_base.html), so I don't know the details.

Okay, I found the data; looked in wrong registry key.
Is stored here: HKCU\Software\FluxEngine\ExtraConfig
If there is an error, the GUI doesn't load any other config.
I would like to change the built-in configs, but seems no way to do it?

I am, in fact, working on a complete rewrite of the GUI because the one you're using is terrible.
Regarding changing the built-in configs: you can't, other than rebuilding the program. However, you can put textproto configs into a file and then reference them from ExtraConfig. Of course, they'll get loaded on top of the default config for whatever format you're using.

Ah, GUI looks fine for me, but would like to click checkboxes for the mass of options there in the CLI...
I working on brother 240k-Disks from LW-30 (FAT-ID: "BDOSV250") and maybe 720k-Disk from LW-350 (FAT-ID: "BDOSV720").
The GUI's config starts not at Track 0, so the directory of the diskette missed; this is an error in the config.. that I would try fix..

Ah, that problem's due to the variable track alignment on the Brother 240kB disks. Different drives put track 0 in different places. Rather than using the rolandd20 config. try using the Brother 240kB config but set drive.head_bios=0 (or some other number; the default is 3).


Token Validation with modulus and exponent

needed to validate Azure AD B2C Tokens
fixes #145

Merged! Thanks for the PR!


[Question]: tsql alter column to not null or null

Contact Details
No response
What's the question?
When I run following statement
ALTER TABLE  customer ALTER COLUMN  phone  NVARCHAR(20) NOT NULL;

I get the following error
Msg 33557097, Level 16, State 1, Line 1
'NOT NULL in ALTER TABLE ALTER COLUMN' is not currently supported in Babelfish

Which I believe is related to the documented difference of ALTER TABLE Supports adding or dropping a single column or constraint only.
I found the following information below here

Generally, performing DDL in PG and expecting this to be reflected on the T-SQL Babelfish layer, is not supported. Babelfish works the other direction: what you can access through the TDS port with T-SQL, can identically be accessed through the PG port when using the same PG user to connect as used when connecting to the TDS port. The reverse is however not necessarily true. While performing DDL through PG may in some cases be reflected in T-SQL, this will not always work. But more importantly, this is not recommended and may not be compatible with future releases of Babelfish.

Based on this information I am not sure if it is wise to alter the table via PSQL.
So my question is what would be the best strategy to update this table?
Relevant log output or information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

It's simpler: as the error message says, NOT NULL is not currently supported with ALTER TABLE..ALTER COLUMN in Babelfish. NULL isn't either. If you specify ALTER TABLE ALTER COLUMN without NULL or NOT NULL, it should work.
If you want to change the nullability of the column, currently there is no way to do that from T-SQL, and you'd have to use the workaround by going through PG. In this case, this should work and no adverse effects are expected.
The restriction which you reference is about adding/dropping/altering multiple columns in a single statement, and that does not apply here.

Thanks Rob for your quick answer!
If you want to change the nullability yes, that is what I wanted to do. I will make the update through PG.

Can this be added to the list of unsupported features:
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/babelfish-compatibility.html#babelfish-compatibility.tsql.limitations-unsupported-list7

I'll submit a doc update

I suggest keeping this open until the doc update has been done


Special handling for "Latin Capital Letter I with Dot Above":

Java follow Unicode standard which says lowercasing should produce "i" plus "Combining Dot Above".  Our C++ code doesn't agree that this makes sense, and note that this is the only character which produces two characters as output from lowercasing.
Ideally we should do "Case Folding" instead of lowercasing.
@bratseth please review
@hmusum FYI

@geirst or. @toregge take a look at the C++ unit test changes.  It turns out it also tested Java-only lowercasing comparing to reference values, and I found that it only compared the first character for fastlib/vespalib variants.


Add support for i18n content retrieval

While trying to create a multi language site using the php client, I found there is was no way to set the language a story should be retrieved in.
This PR adds support for the language and fallback_lang query string parameters.

Thanks for your contribution, @lucadegasperi!


Move javax.json and javax.inject to their Jakarta EE counterparts

https://issues.jboss.org/browse/WFCORE-4648
https://issues.jboss.org/browse/WFCORE-4630
These PR's were combined into one so there would not be conflicts. This likely needs to be merged after https://github.com/wildfly/wildfly/pull/12603.

Closing this as I meant to open it as a draft.

Core - Full Integration Build 9055 outcome was FAILURE using a merge of 56a77d7845a651062754adac29d820b95dd18ca2
Summary: Exit code 1 (Step: Build & test full (Maven)) (new) Build time: 00:04:10

Dependency Tree Analyzer Output:
New Dependencies:

jakarta.json:jakarta.json-api:jar:1.1.6:compile
org.glassfish:jakarta.json:jar:1.1.6:compile

Removed Dependencies:

javax.json:javax.json-api:jar:1.1.2:compile
org.glassfish:javax.json:jar:1.1.2:compile

CC @wildfly/prod


Dealing with line endings

Hi Austin,
wow, you squeezed some extra perfomance out of the stuff...
This is about the line endings. I'm always puzzeled by the diffs which shows a lot of lines removed and added again with no visible change. So I followed the Dealing with line endings article from the github-help and added an .gitattributes file to the repository.
Best Regards,
Martin

Excellent!


Vue 3 does not handle events with specific names (capture, once, passive) from custom element

Vue version
3
Link to minimal reproduction
https://codesandbox.io/p/sandbox/autumn-dust-4f3rb4
Steps to reproduce

Create a SFC component
Define in that component event with name "capture"
Define custom element in window
Use this custom element in Vue 3 App
Subscribe to event and trigger some method on it

What is expected?
Method is triggered on event "capture" from custom element
What is actually happening?
Method is NOT triggered
System Info
No response
Any additional comments?
That custom element works fine with Vue 2

There's seems to be issue with binding @once event. Your reproduction doesn't show any errors, If you look at SFC Playground there's an error thrown by vue:
Cannot read properties of undefined (reading 'toLowerCase')
and it happens because @once event. Others work properly.

@sqal to reproduce you need to define component as Custom Element:

Rename Comp.vue to Comp.ce.vue
Define it as custom element import { defineCustomElement } from "vue"; import Comp from './Comp.ce.vue'; window.customElements.define("my-comp", defineCustomElement(Comp));
Use it in App.vue like custom element <my-comp @capture="capture"></my-comp>

https://vuejs.org/guide/extras/web-components.html#building-custom-elements-with-vue

@yyx990803 normal component also has the same issues.

@yyx990803 normal component also has the same issues.

I find once problematic in regular components, are there other use cases? I created a new issue（https://github.com/vuejs/core/pull/8341） and submitted a PR（https://github.com/vuejs/core/issues/8342）,the test example in this issue（#8334 ） works fine in the PR


Incomplete tutorial

Steps to "Establish a private link connection to an existing key vault" only cover first tab of operation and the section abruptly cuts off leaving the reader at a loss/guessing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 191d0067-67ee-212d-77f6-ffb1db64582f
Version Independent ID: 71d5a250-17e6-8500-b6a3-3c46401a255c
Content: Integrate Key Vault with Azure Private Link
Content Source: articles/key-vault/general/private-link-service.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@BRGLLCIT
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Hi, @BRGLLCIT. I updated the Establish a private link connection to an existing key vault section to include all the steps, up to an including the creation of the Private Link.  Thanks for your feedback!  #please-close


[FEATURE] Allow ArgoCD application auto-sync to be disabled

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?
It would be nice to have the ability to disable the auto-sync policy when creating an ArgoCD application.
This would allow for deployment processes which still require a human-in-the-loop.
In our case, we need to be able to prepare everything for deployment (build and tag images, update manifests), then perform the actual deployment at a later time. Unfortunately this process is outside of my control.
Describe the solution you would like
When defining an ArgoCD application, I would like to be able to set an 'auto_sync' variable to false.
argocd_applications = {
  my-project = {
    path               = "chart"
    repo_url           = "https://github.com/aws-samples/eks-blueprints-add-ons.git"
    auto_sync          = false
  }
}

When this variable is false, the resulting Application.spec.syncPolicy should not have an 'automated' property.
Describe alternatives you have considered
Being able to override all values of Application.spec.syncPolicy would be a more robust solution, but may be overkill.

this is controlled here https://github.com/aws-samples/eks-blueprints-add-ons


adds a variation of the get_spot_price fn to include fees

Resolved Issues
The get_spot_price rust fn does not include fees, I need one that does for the targeted long fn.
Description
Simple change that uses calculate_open_long instead of calculate_bonds_out_given_shares_in_down to get the delta bonds.
Review Checklists
Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can
be removed.
[[Reviewer Name]]
Solidity

[ ] Tokens

[ ] Do all approve calls use forceApprove?
[ ] Do all transfer calls use safeTransfer?
[ ] Do all transferFrom calls use msg.sender as the from address?

[ ] If not, is the function access restricted to prevent unauthorized
token spend?

[ ] Low-level calls (call, delegatecall, staticcall, transfer, send)

[ ] Is the returned success boolean checked to handle failed calls?
[ ] If using delegatecall, are there strict access controls on the
addresses that can be called? It shouldn't be possible to delegatecall
arbitrary addresses, so the list of possible targets should either be
immutable or tightly controlled by an admin.

[ ] Reentrancy

[ ] Are functions that make external calls or transfer ether marked as nonReentrant?

[ ] If not, is there documentation that explains why reentrancy is
not a concern or how it's mitigated?

[ ] Gas Optimizations

[ ] Is the logic as simple as possible?
[ ] Are the storage values that are used repeatedly cached in stack or
memory variables?
[ ] If loops are used, are there guards in place to avoid out-of-gas
issues?

[ ] Visibility

[ ] Are all payable functions restricted to avoid stuck ether?

[ ] Math

[ ] Is all of the arithmetic checked or guarded by if-statements that will
catch underflows?
[ ] If Safe functions are altered, are potential underflows and
overflows caught so that a failure flag can be thrown?
[ ] Are all of the rounding directions clearly documented?

[ ] Testing

[ ] Are there new or updated unit or integration tests?
[ ] Do the tests cover the happy paths?
[ ] Do the tests cover the unhappy paths?
[ ] Are there an adequate number of fuzz tests to ensure that we are
covering the full input space?

Rust

[ ] Testing

[ ] Are there new or updated unit or integration tests?
[ ] Do the tests cover the happy paths?
[ ] Do the tests cover the unhappy paths?
[ ] Are there an adequate number of fuzz tests to ensure that we are
covering the full input space?
[ ] If matching Solidity behavior, are there differential fuzz tests that
ensure that Rust matches Solidity?

closed in favor of https://github.com/delvtech/hyperdrive/pull/833


Password::broker() with existing email cause SQLSTATE[42000]: Syntax error or access violation

Laravel Version: 7.3.0
PHP Version: 7.4.2
Database Driver & Version: mysql (v5.7.29)

Description:
I have upgraded an application from Laravel 6 to 7.3, but now seems that something goes wrong with the Password Reset process: when I call Password::broker()->sendResetLink(...) with an existing email address, I get the following error:
Illuminate/Database/QueryException with message 'SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'as nullwhereemail= ?' at line 1 (SQL: delete frompassword_resetsasnullwhereemail = admin@laravel.test)'
I have another application that uses a fresh Laravel 7 installation, and it works: the bug seems to be caused by the upgrade. What could be?
Steps To Reproduce:
\Illuminate\Support\Facades\Password::broker()->sendResetLink(['email' =><EMAIL_ADDRESS>]);

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!


[NFR]: Create static methods for ini/camelize/uncamelize

Create static methods for
Camelize
Lower
Uncamelize
Upper
Ini

Resolved in https://github.com/phalcon/traits/pull/43


How to set Startup Parameter?

When run a workflow by webUI, user can set Startup Parameter, but how to set Startup Parameter by python sdk?
I try to use param but it does't work
with Workflow(name="api_python_test5", param={"data": "hello"}) as workflow:
   workflow.start()

Hi @kevinkelin
I think locally and it works for me. could you share which version of dolphinscheduler and pydolphinscheduler do you use?

Hi @kevinkelin
I think locally and it works for me. could you share which version of dolphinscheduler and pydolphinscheduler do you use?

Thanks, but I mean when user already set Start Parms by webUI, for example set KEY1 value1, then user use sdk to start a worlflow, then user want to make KEY1 to value2.
with Workflow(name="api_python_test5", param={"KEY1": "value2"}) as workflow:
   workflow.start()

only call  workflow.start() , doesn't call workflow.commit(), the value of KEY1 is still value1 in flow instance.
Is this the feature of sdk?  or I must call commit method?

hi @kevinkelin I have test base on your case, but I can update the workflow parameter already fine in web ui. BTW, when you can method workflow.start() it will call workflow.submit() implicitly

please make sure your parameter set in web UI and SDK with same name. You need to carefully compare whether there are spaces in parameter

could you share what version do you use for dolphinschduler and sdk?


APT whitelist request for libmozjs-dev

For Apache CouchDB.

Ran tests and found setuid bits. See https://travis-ci.org/travis-ci/apt-whitelist-checker/builds/72229233.

I can't easily determine if any of that ends up in libmozjs-dev, unfortunately. :/

Ran tests and found setuid bits. See https://travis-ci.org/travis-ci/apt-whitelist-checker/builds/72284804.


Question: json map(string, object)

Please can someone confirm if this is possible and steer me in the right direction? I've tried a number of ways but I'm not getting there
Sample that errors:
  const MyobjJson = {
    "addresses": {
      "roger": {
        "address": "some street"
      },
      "peter": {
        "address": "other street"
      }
    }
  };

  const schemaAddress=z.object({
    address: z.string()
  });

  const schemaAddresses=z.map(z.string(), schemaAddress)

  const schemaMyobj = z.object({
    addresses: schemaAddresses
  });

  var r = schemaMyobj.parse(MyobjJson)
  console.log(r)

Error...
    ZodError: [
    {
      "code": "invalid_type",
      "expected": "map",
      "received": "object",
      "path": [
        "addresses"
      ],
      "message": "Expected map, received object"
    }
  ]

The below seems to work, any observations very welcome.
Coming from a Go background I guess I'm struggling with Go map = Typescript Map/Record
  //const schemaAddresses=z.map(z.string(), schemaAddress)
  const schemaAddresses=z.record(schemaAddress)

  var v = r.addresses
  for (let k in v) {
    console.log(v[k as keyof typeof v].address)
  }

Hi @adeturner,
In fact, the z.map() is based on the Map type of JS (ref) which is a bit different from the original JavaScript object. Your MyobjJson is a JS object and can be parsed with Zod with something like:
const schema = z.object({
  addresses: z.record(
    z.object({
      address: z.string(),
    })
  ),
});

Live example here.
The use of z.record() it's based on the Typescript behavior of Record utility type which allows us to type correctly objects with dynamic properties.

Thanks for confirming Lucas, much appreciated.  Really liking zod tbh, it makes mapping typescript to Go's struct/validate much easier.


 Trying to attach a crafting terminal to an ME conduit results in it facing away from the player, making it impossible to turn the right way.
Also tested with the other terminal types, same result.

This is beacause you cannot place those AE parts on ME conduits. You need a cable from AE in between.

Not a bug, the terminal is not connecting because conduits are not multiparts. This is intended.


Inconsistent behaviour of printf %#0(insert number)x with different types

What did you do?
I wanted print a padded (zeros)  and prepended (0x) string character as a hex number.
Link to example on play.golang.org
What did you expect to see?
The same result for a string character and an integer.
The string printed as an hexadecimal number should be prepended with '0x'.
What did you see instead?
> A hex Number (a int) with padding:    0x0000000030
> A hex Number (a string) with padding: 0000000x30
>
> Program exited.

System details
go version go1.11.2 linux/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/sebi/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/sebi/go/"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
GOROOT/bin/go version: go version go1.11.2 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.11.2
uname -sr: Linux 4.15.0-38-generic
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.5 LTS
Release:	16.04
Codename:	xenial
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Ubuntu GLIBC 2.23-0ubuntu10) stable release version 2.23, by Roland McGrath et al.
gdb --version: GNU gdb (Ubuntu 7.11.1-0ubuntu1~16.5) 7.11.1

This seems to be working as documented:

int: # for 0x for hex (%#x) and 0 for pad with leading zeros rather than spaces
string: %x base 16, lower-case, two characters per byte then # for 0x for hex (%#x)  for each byte and pad the string with leading zeros rather than spaces.

The difference is that the verb %x applies to each byte in strings but the rest of the modifiers are not.

But it does not add an '0x' for each byte:
(Example)[https://play.golang.org/p/kTuXoeOZ5mo]
> 00000x3031

As far as I understood you it should print something like:
> 0x00000x300x31

you are right it i was confusing this with ' ' where it applies per byte and is mentioned explicitly "% x" in documentation.
Referring back to the original issue of 0 padding I think its still in line with documentation that padding of 0 applies to the whole string after it has been formatted?

Referring back to the original issue of 0 padding I think its still in line with documentation that padding of 0 > applies to the whole string after it has been formatted? Could maybe made explicit.

I cannot find this in the documentation for printf.
This is what I've found:

 ' '	(space) leave a space for elided sign in numbers (% d);
	put spaces between bytes printing strings or slices in hex (% x, % X)
0	pad with leading zeros rather than spaces;
	for numbers, this moves the padding after the sign

It does only say what happens if you pad it with spaces, so I agree it should be more explicitly stated what happens if you use zeros instead of spaces.

CC @robpike

Padding applies to the whole result.


Wrong Table spaceing when using d-inline-block on table element

There may be two issues:

When using d-inline-block on a table, the table scales up to viewport width, regardless of the content
When using d-inline-block on a table, the table content (thead, tbody) does use up all space provided by the table

Tested on OS: Windows 10
Tested on Browser:

Firefox 56.0
Brave 0.18.36
Edge 40.15063.0.0

Reduced test case:
https://output.jsbin.com/jilulod/

You're going to run into a number of issues when changing the display of a <table>. That's nothing on our end that we can change—that's just HTML and CSS.


Performs some minor cleanup of TabletLocator

This commit has no changes in functionality, it only contains some minor code cleanup of the TabletLocator code.
The following changes were made.

Encapsulated fields in TabletLocation class
Replaced a Callable interface with a Supplier interface to avoid the uneeded exception thrown by Callable
Removed an uneeded compareTo method from TabletLocation class

Created this PR to pull some of refactoring done in #3143 into its own PR.


nfs4-acl-tools: init at 0.3.7

Description of changes
Adds NFSv4 ACL tools and a corresponding NixOS test.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@kwohlfahrt any change for this PR to get merged?


Add checks to prevent the same Conditional from being used multiple times

Motivation
If someone uses the same Conditional object multiple times in the same _Always or in different _Always blocks, it can cause unexpected behavior and simulation/synthesis mismatches.
Desired solution
There should be an explicit check that Conditionals are not reused.  Perhaps a build-time check where each Conditional is assigned a parent _Always, and the _Always confirms there are no duplicates within itself?

@mkorbel1 I can pick this up as well.

Check at the construction time.

Conditional Object creation:
final condOne = If(a, then: [q < d]);


Feature: Add Github Workflow

Feature: Add Github Workflow

Discord Username: @sudo-adduser-jordan
What type of PR is this? (select all that apply)

[ x ] 🍕 Feature
[ x ] 🧑💻 Code Refactor

Description
-add Lint check
-add Type check
-add Build check
-add Cypress check
-add scripts migrate, test
-remove existing cypress tests
-add empty cypress tests
Added/updated tests?

[ x ] 👍 yes

Additional Comments
These tests will work as they are supposed to. The build step is going to fail. Someone merged a bad commit before I opened this pull request. It could have been caught before it was merged with these tests. The "Test" job should be cached. I could not figure out how to cache the cypress binary correctly. This will save about 30s of time. The other jobs are cached. I will look into it. I will also open a issue so someone else can as well.

Please merge. See Additional Comment above.


backport patch for CVE-2022-30634 to EKS Go 1.16

Issue #, if available:
https://github.com/aws/eks-distro-build-tooling/issues/571
Description of changes:
Backport fix for CVE-2022-30634 to EKS Go 1.16.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


chore: release main

:robot: I have created a release beep boop
bundlesize: 2.0.0
2.0.0 (2024-01-17)
⚠ BREAKING CHANGES

bundlesize: output results with artifactPaths as keys

Features

bundlesize: output results with artifactPaths as keys (09b4a5c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/aversini/node-cli/releases/tag/bundlesize-v2.0.0 :sunflower:


Host page example cannot be used programmatically without extra user action

We're trying to use the example hostpage from http://wopi.readthedocs.io/en/latest/hostpage.html, but since it suggests to use a form that is submitted programmatically, most browsers require the form submit to be triggered by an user event (a click, or in our case a mouseenter event).
Our application is displaying the form/iframe inside a pop-up dialog, and the form submit cannot be tied to the initial click to display the dialog. Therefore we end up needing an extra button(or mouseenter listener) to trigger the submission of the form. We tried to use a basic post request initially which would've worked better for us, but the request to urls such as https://word-view.officeapps-df.live.com gave us a CORS error.
It's worth noting our app is using Angular 2.1.1.

That shouldn't be happening - browsers should not require user action for this form submit.  The sample code you cite is what we recommend to partners and is very similar to the code we use across multiple different Microsoft services.  And programmatic form posts are very common across the internet; they definitely work in general.
Browsers can change behavior significantly based on tiny differences in pages, however.  If you can create a reduced repro we'd like to look over it to help you.

You're right, it turned out we needed to wait for Angular to update the DOM before trying to submit the form (used a setTimeout(fn, 0);).

I'm going to reopen this to use as a doc update, to mention this pattern & solution in the "Building a Host Page" documentation.


How to train

Dear Sir:
Thanks for your sharing your elegant work.  I am still confused about how to train this model on ShapeNet, even after reading your paper. Could you provide your training code for my better understanding

Codes are uploaded. Datasets and pretrained models are on the way.


Encrypt ec2 user data

@npalm  I can do this. assign me this task pls

@hendrixroa Would you still like to implement this feature?

@npalm Really doesn't necessary, feel free to close this, you already merged some important encryption things that matter


Feature: Add ability for "power points" to be displayed as “switches"

Currently I can set my ikea sockets to be displayed as power points, fans, or lights. It would be nice to have them be able to work as switches too. I dont know if this is a HomeKit limitation.

Unfortunately yes, it's an Homekit limitation. I don't have a way to modify how the app shows accessories I map

Is there an option to change how it maps? e.g. map to switch rather than socket?

Te only way is to create a switch accessory from Homebridge


Serial port with on_data / readline events

Tested on hardware (trident1) and in virtualbox. @fwsGonzo @AndreasAakesson Let me know if this causes any trouble for you, otherwise I'll merge.


Vector needs a nerf

Shooting revolver bullets is okay but these things are mapped so they should be shooting pistol like the other smgs are.

Wasn't the purpose of .45 magnum to separate the ammo of the vector and the revolver so they didn't share the same round?

Wasn't the purpose of .45 magnum to separate the ammo of the vector and the revolver so they didn't share the same round?

We don't need 2 types of magnum rounds.

Thats fair but I think its a little bland if every gun in the armory uses the same bullet. Personally i think it just losses the variety of using different guns with different ammo types. It just ends up being "what gun fires the fastest" if every single gun shared the same bullet. But thats how I see it and its not going to affect the game too badly if sec only uses .35 auto and buckshot.

Removed.


chore: edit styling for range input

What does this PR do?

[x] Add color on the left side when only one handle is present.

Hey @tuanddd, I accidentally made the same change while working on other styling tweaks.


Using dep: syntax in Cargo.toml makes it impossible to enable features for dependencies unless you also have a feature by that name

Any crate with this Cargo.toml, or any one like it:
[package]
name = 'whatever'
version = '0.1.0'
edition = '2021'

[features]
default = ['font', 'allsorts/flate2_rust']
font = ['dep:allsorts']

[dependencies]
allsorts = { version = '~0.10.0', optional = true, default-features = false }

fails to compile because of the allsorts/flate2_rust, even though it shouldn't (allsorts is a dependency, not a feature name).
Adding an allsorts feature, even a completely empty one, fixes the error:
[package]
name = 'whatever'
version = '0.1.0'
edition = '2021'

[features]
default = ['font', 'allsorts/flate2_rust']
font = ['dep:allsorts']
allsorts = []

[dependencies]
allsorts = { version = '~0.10.0', optional = true, default-features = false }

so this is probably a misbehaving lint. I don't want an extra allsorts feature (in my real crate, font is more than just allsorts, and enabling allsorts on its own makes 0 sense).
If this lint exists for encapsulation purposes, I would like to be able to do dep:allsorts/flate2_rust at least, if there is no outer-facing allsorts feature (although I'd add one in that case so that downstream crates can configure which flate2 backend they want).
Active toolchain:
nightly-x86_64-unknown-linux-gnu (default)
rustc 1.63.0-nightly (dc80ca78b 2022-06-21)

I have made a minimum effort to search for duplicate issues, but "dep cargo feature" is such a generic search term that it gives thousands of results.

Thanks for the report!  I'm not sure how we missed that.

Interesting, I was confused because I thought I was using this setup in a crate of mine just fine; but it looks like if you use allsorts?/flate2_rust it works fine, and I happened to be using weak-features for all my namespaced crates.

it looks like if you use allsorts?/flate2_rust it works fine

Thanks for the workaround :)

As this doesn't seem to be very active, I'll try it and see what happens :)
@rustbot claim


Multi-scaled structural similarity (MS-SSIM)

Add MS-SSIM to the library

Done in 48c9b9d9303a623f2901c04acf03aa515288e73f


[tool_crash] _CastError: (#0      BatchedExpressionEvaluator._evaluateBatch (package:dwds/src/services/batched_expression_evaluator.dart:125:39))

Command
flutter --no-color run --machine --track-widget-creation --device-id=chrome --start-paused --dart-define=flutter.inspector.structuredErrors=true lib\main.dart

Steps to Reproduce

...
...
...

Logs
_CastError: (#0      BatchedExpressionEvaluator._evaluateBatch (package:dwds/src/services/batched_expression_evaluator.dart:125:39))
#0      BatchedExpressionEvaluator._evaluateBatch (package:dwds/src/services/batched_expression_evaluator.dart:125:39)
<asynchronous suspension>

[!] Flutter (Channel stable, 3.7.1, on Microsoft Windows [Version 10.0.22621.1105], locale ko-KR)
    • Flutter version 3.7.1 on channel stable at C:\tools\flutter
    ! The flutter binary is not on your path. Consider adding C:\tools\flutter\bin to your path.
    ! The dart binary is not on your path. Consider adding C:\tools\flutter\bin to your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7048ed95a5 (33 hours ago), 2023-02-01 09:07:31 -0800
    • Engine revision 800594f1f4
    • Dart version 2.19.1
    • DevTools version 2.20.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✗] Windows Version (Unable to confirm if installed Windows version is 10 or greater)

[✗] Android toolchain - develop for Android devices
    • Android SDK at C:\Users\ket36\AppData\Local\Android\sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✗] Visual Studio - develop for Windows
    ✗ Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[!] Android Studio (version 2022.1)
    • Android Studio at C:\Users\ket36\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\221.6008.13.2211.9514443
    • Flutter plugin version 72.0.2
    • Dart plugin version 221.6096
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] IntelliJ IDEA Ultimate Edition (version 2022.3)
    • IntelliJ at C:\Users\ket36\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\223.8617.56
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 109.0.5414.120
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 109.0.1518.70

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 5 categories.

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: 135454af32477f815a7525073027a3ff9eff1bfd
Plugins
path_provider_linux-2.1.7
path_provider_windows-2.1.3
shared_preferences-2.0.15
shared_preferences_android-2.0.14
shared_preferences_ios-2.1.1
shared_preferences_linux-2.1.2
shared_preferences_macos-2.0.4
shared_preferences_web-2.0.4
shared_preferences_windows-2.1.2

한글 입력시 오류 재기동후 정상확인

Closing this as a duplicate of https://github.com/flutter/flutter/issues/119084.


add byandell to README.md

Pull Request Description Here
Adresses Issue (start typing # to see a list of issues)
Before you submit, remember to:

[ ] Pull in all changes from main to reduce conflicts
[ ] Request reviews from @earthlab-education/ea-students

Test


Storage inspection

Closes #151
Description
This PR adds storage inspection capability to the emulator and expose an API to interact with this feature.
A new endpoint on the emulator API allows you to inspect the storage "on-demand" by calling /emulator/storages/{address} an example response would be:
{
  "Address": "f8d6e0586b0a20c7",
  "Private": {
    "lockedTokenAdmin": {
      "target": "/storage/lockedTokenAdminCollection",
      "type": "&A.f8d6e0586b0a20c7.LockedTokens.TokenAdminCollection"
    }
  },
  "Public": {
    "flowTokenBalance": {
      "target": "/storage/flowTokenVault",
      "type": "&A.0ae53cb6e3f42a79.FlowToken.Vault{A.ee82856bf20e2aa6.FungibleToken.Balance}"
    },
    "flowTokenReceiver": {
      "target": "/storage/flowTokenVault",
      "type": "&A.0ae53cb6e3f42a79.FlowToken.Vault{A.ee82856bf20e2aa6.FungibleToken.Receiver}"
    }
  },
  "Storage": {
    "flowContractAuditVouchersAdmin": "A.f8d6e0586b0a20c7.FlowContractAudits.Administrator(uuid: 0)",
    "flowEpochAdmin": "A.f8d6e0586b0a20c7.FlowEpoch.Admin(uuid: 20)",
    "flowEpochHeartbeat": "A.f8d6e0586b0a20c7.FlowEpoch.Heartbeat(uuid: 21)",
    "flowEpochMetadata": "{0: A.f8d6e0586b0a20c7.FlowEpoch.EpochMetadata(dkgKeys: [], endView: 99, collectorClusters: [], stakingEndView: 9, totalRewards: 0.00000000, startView: 0, clusterQCs: [], rewardsPaid: false, seed: \"\", counter: 0, rewardAmounts: [])}",
    "flowEpochsDKGAdmin": "A.f8d6e0586b0a20c7.FlowDKG.Admin(uuid: 17)",
    "flowEpochsQCAdmin": "A.f8d6e0586b0a20c7.FlowClusterQC.Admin(uuid: 18)",
    "flowFeesAdmin": "A.e5a8b7f23e8b548f.FlowFees.Administrator(uuid: 4)",
    "flowServiceAdmin": "A.f8d6e0586b0a20c7.FlowServiceAccount.Administrator(uuid: 8)",
    "flowStakingAdmin": "A.f8d6e0586b0a20c7.FlowIDTableStaking.Admin(uuid: 19)",
    "flowTokenAdmin": "A.0ae53cb6e3f42a79.FlowToken.Administrator(uuid: 2)",
    "flowTokenMinter": "A.0ae53cb6e3f42a79.FlowToken.Minter(uuid: 16, allowedAmount:<PHONE_NUMBER>.00000000)",
    "flowTokenVault": "A.0ae53cb6e3f42a79.FlowToken.Vault(balance: 999999999.99700000, uuid: 1)",
    "idTableApproveList": "[]",
    "idTableCurrentList": "[]",
    "idTableNonOperationalNodesList": "{}",
    "isAccountCreationRestricted": "false",
    "lockedTokenAdminCollection": "A.f8d6e0586b0a20c7.LockedTokens.TokenAdminCollection(uuid: 22, accounts: {})",
    "networkingAddressesClaimed": "{}",
    "networkingKeysClaimed": "{}",
    "stakingEnabled": "true",
    "stakingKeysClaimed": "{}",
    "storageFeesAdmin": "A.f8d6e0586b0a20c7.FlowStorageFees.Administrator(uuid: 5)"
  }
}

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the GitHub PR explorer
[ ] Added appropriate labels

@turbolent could you let me know if this additional required env API implementation for resolve location is correct:
https://github.com/onflow/flow-emulator/blob/feature/storage-inspection/blockchain.go#L1295
The now produced output looks much better with cadence values:
{
    "Address": "01cf0e2f2f715450",
    "Private": null,
    "Public": {
        "flowTokenBalance": {
            "TargetPath": {
                "Domain": "storage",
                "Identifier": "flowTokenVault"
            },
            "BorrowType": "&A.0ae53cb6e3f42a79.FlowToken.Vault{A.ee82856bf20e2aa6.FungibleToken.Balance}"
        },
        "flowTokenReceiver": {
            "TargetPath": {
                "Domain": "storage",
                "Identifier": "flowTokenVault"
            },
            "BorrowType": "&A.0ae53cb6e3f42a79.FlowToken.Vault{A.ee82856bf20e2aa6.FungibleToken.Receiver}"
        }
    },
    "Storage": {
        "flowTokenVault": {
            "ResourceType": {
                "Location": {
                    "Type": "AddressLocation",
                    "Address": "0x0ae53cb6e3f42a79",
                    "Name": "FlowToken"
                },
                "QualifiedIdentifier": "FlowToken.Vault",
                "Fields": [
                    {
                        "Identifier": "uuid",
                        "Type": {}
                    },
                    {
                        "Identifier": "balance",
                        "Type": {}
                    }
                ],
                "Initializers": null
            },
            "Fields": [
                25,
                100000
            ]
        }
    },
    "Account": {
        "Address": "01cf0e2f2f715450",
        "Balance": 0,
        "Keys": [
            {
                "PublicKey": "oq9SRhH3Idi0Cl7yYpuzLY/DDd0A9ZQg4L9FjX9wDsVBUsP3RdYAyF5+Y2Ed6TlSgjAvi0Wf2wDPnP950HrCYQ==",
                "SignAlgo": 2,
                "HashAlgo": 3,
                "SeqNumber": 0,
                "Weight": 1000
            }
        ],
        "Contracts": {}
    }
}

@sideninja Yes, this should be sufficient I think

The blocking PR got merged https://github.com/onflow/cadence/pull/1679 but the problem now is that the Cadence used in flow-go and latest emulator master is different than master, meaning we can't access this merged features.


Give correct error messages on wrong email config

Describe the bug
I have set up the mailserver according documentation. When I then try to send an email to an newly created user within openslided I get the message "No emails were send. The user has no email, so the invitation email could not be send." altrough the user definitely have a email.
How to Reproduce
Steps to reproduce the behavior:

Go to Accounts.
Add an Account with an email.
On the profile page of the account on the tree dots klick "send invitation email"

Expected behavior
The email should be sended. No error should be thrown.
System information

OpenSlides-Version: 4.0.1-main-20230424-19b6cce
Device: MacBook Pro 16" 2021.
OS: macOS, current Version
Browser: Safari & Firefox
Browser-Version: current versions

Additional context
(Excerpt from docker-compose.yml)

   environment:
      << : *default-environment
      OPENSLIDES_BACKEND_COMPONENT: action
      EMAIL_HOST: "smtp-relay.sendinblue.com"
      EMAIL_PORT: "587"
      EMAIL_HOST_USER: "*************"
      EMAIL_HOST_PASSWORD: "***********"
      EMAIL_CONNECTION_SECURITY: "SSL/TLS"  # This can also be "NONE" or "STARTTLS".
      EMAIL_TIMEOUT: "5"  # Timeout in seconds for blocking operations like the connection attempt.
      EMAIL_ACCEPT_SELF_SIGNED_CERTIFICATE: "false"  # Or "true" of course.

Screenshots

The snackbar message is a client-generated information text. The actual error message can usually be found in the development console (Press F12 in the browser) or its network tab. This was a design decision to ensure that users aren't bombarded with endlessly long snackbar messages full of technobabble that sometimes may only be understandable to the admin or other more tech-savvy people.
However it is quite clear that the current text is rather inadequate for this purpose.
I would recommend to change the text as follows:

Change the second sentence to something like Perhaps the user has no email or there may be a problem communicating with the mail server, in case of the latter please contact your admin. This new message only really needs to appear if really not a single email was sent, otherwise the communication with the mail server evidently does work.
Also: Instead of send use the correct past form, which is sent (see here)

By the way, the message is generated in the UserControllerService's sendInvitationEmails method.


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-redhatopenShift-openshiftcluster
Module Details
AVM Resource Module for Azure Red Hat OpenShift
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
ljtill
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Hi @ljtill
i updated module name to align with specification
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @ljtill ,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

@prjelesi please can we update the owner of this module to @mosabami?

@mosabami
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:
Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support
Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR


CI - added option to run tests workflow on dispatch

Solution
Necessary so we can check \ debug of the workflow itself
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[X] Infrastructure change (CI configs, etc)
[ ] Non-code change (docs, etc)
[ ] None of the above: (explain here)

Closing for now.
This workflow requires deeper changes anyway.


average page loading time in firefox is more than 7 seconds

Btw at the moment we don't use any of Angular's feature, but still load this huge dependency.

We use angular for codemirror, posting stuff to the backend and hiding the different view panes. Is angular really such a big dependeny? Sources are quite small but make the frontend code much more readable.


Delete unused adapter and interface #61

@andrei-picus-hs @flavius-tirnacop-hs @valentin-radulescu-hs Can you review?

LGTM

@andrei-picus-hs Can I merge this?

Merge after addressing that comment.


chore(deps): upgrade to app v1.7.0-rc0

Draft PR to verify that CI passes. Once it passes, I'll cut an official app release. I couldn't retain the Go version 1.21.1 because go mod tidy auto updated the go directive.
$ go1.21.1 mod tidy
go<EMAIL_ADDRESS>requires go >= 1.22.0; switching to go1.22.0

This behavior is unexpected because I thought applications could use libraries with different Go versions. 🤔

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.88%. Comparing base (c1ab9c5) to head (d1c8b40).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3228      +/-   ##
==========================================
- Coverage   52.08%   44.88%   -7.21%
==========================================
  Files         183      265      +82
  Lines       11594    14635    +3041
==========================================
+ Hits         6039     6569     +530
- Misses       5043     7305    +2262
- Partials      512      761     +249

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CI passed so I created https://github.com/celestiaorg/celestia-app/releases/tag/v1.7.0


adding tests for Get-DbaMemoryCondition. Issue #4558

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[X] Adding code coverage to existing functionality
[X] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Adding coverage for 1.0! Issue #4558 add coverage for get*
Approach

standard unit tests
integration tests check results are returned and expected properties, hard to simulate a memory condition to test the SQL works.

Screenshots

fantastic, thank you 🙇 !


fix: Replace reference error with sync field error

Description
We added logic to replace async function undefined error with "{{actionName}} cannot be used in this field".
Fixes #12179
Fixes #13273
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Cypress test
Checklist:

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=386b0b8

/ok-to-test sha=1282a4a

/ok-to-test sha=edf7556

/ok-to-test sha=dfde092

/ok-to-test sha=19a3708

/ok-to-test sha=641c837

/ok-to-test sha=162b2b6

/ok-to-test sha=162b2b6

/ok-to-test sha=162b2b6

/ok-to-test sha=4806229

/ok-to-test sha=946cfdc

Will be changing the implementation for fixing the above issue to the older one after merging https://github.com/appsmithorg/appsmith/pull/18471.

/ok-to-test sha=18fd69a


🐛 Weird circular dependency between firebase_ui_auth and firebase_ui_oauth

Is there an existing issue for this?

[X] I have searched the existing issues and found no duplicates.

What plugin is this bug for?
Firebase UI Auth, Firebase UI OAuth
What platform(s) does this bug affect?
Android, iOS, Web, macOS, Linux, Windows
List of dependencies used.

flutter pub deps -s list

Steps to reproduce
I was trying to make a change to the firebase_ui_auth package to change some colors (that are not configurable and look hideous on dark mode btw, please view #18) , but when I made the change, I noticed that it kept failing on me with
Because firebase_ui_oauth 1.4.17 depends on firebase_ui_auth ^1.12.1 and no versions of firebase_ui_oauth match >1.4.17 <2.0.0, firebase_ui_oauth ^1.4.17 requires firebase_ui_auth from hosted.
So, because award_ace depends on firebase_ui_auth from git which depends on firebase_ui_oauth ^1.4.17, version solving failed.
exit code 1

Upon closer inspection, I noticed that firebase_ui_auth depends on firebase_ui_oauth: ^1.4.17 and firebase_ui_oauth depends on firebase_ui_auth: ^1.12.1. This seems like a weird circular dependency and anti-pattern. To me, having a package depend on one but it depend on the other doesn't seem like a great approach, and causes issue when trying to do what I am trying to do.
Could someone please explain why this is?? Which definitely seems like a bug
Expected Behavior
No circular dependency here. Both should potentially depend on firebase_ui_shared which they already do.
Actual Behavior
Circular dependency
Additional Information
No response

Hi @tapizquent, can you provide the steps to reproduce the issue? Pub usually is able to resolve the dependencies by itself. When I added both plugins into a new project it worked without any issue

Hey @danagbemava-nc
It is good to know that I am not publishing the package through Pub because I am accessing just my fork from my git url.
Steps are:

Fork repository
Clone the repo from the fork into your machine
Make changes to firebase_ui_auth or don't, doesn't really matter.
Push changes to forked repo
In any Flutter app, import the package from the forked repo with

firebase_ui_auth:
    git:
      url: https://github.com/<YOUR_USERNAME>/FirebaseUI-Flutter.git
      path: packages/firebase_ui_auth
      ref: main

Save

You will see the error complaining that the package depends on firebase_ui_oauth and thus must be imported from hosted
Anyway, my concern still applies. Why are these packages depending on each other? Doesn't seem very intuitive

I can't say for sure why they depend on each other but I can reproduce the issue.
Labeling for further investigation
cc @lesnitsky


Fix gitsign binary name on OSX/ARM64

The binary used for ARM64 was amd64. 🚨

Glad to contribute.


Osiset\ShopifyApp\Exceptions\MissingAuthUrlException

can't resolved anyone can help regrading this?

Make Sure api key and public key is correct.
clear cache and delete app form store and database entry and reinstall

can't resolved anyone can help regrading this?

Closing as the solution has been provided.

@usman735 ,thank you for replying, I resolved this issue by using laragon , the issue is with ngork.


Custom escape character

User should be able to set custom escape character. Currently "quote character" and "escape character" are the same.
Due to RFC 4180 paragraph 2.7:

If double-quotes are used to enclose fields, then a double-quote
appearing inside a field must be escaped by preceding it with
another double quote.  For example:
"aaa","b""bb","ccc"

If user change escape character to "[" below should be valid:
"aaa","b["bb","ccc"

Update "testCustomEscape" test in ReadingFeaturesTest and WritingFeaturesTest classes.

Should close this as a dupe of #14


Get called when main tree flushLayout is finished

why: https://github.com/fzyzcjy/flutter_smooth/issues/23#issuecomment-1261691891

looks like it is called.

/Volumes/MyExternal/ExternalRefCode/flutter/bin/flutter --no-color test --machine --start-paused --plain-name "when one extra smooth frame" --local-engine-src-path=/Volumes/MyExternal/ExternalRefCode/engine/src --local-engine=host_debug_unopt test/src/builder_test.dart
Testing started at 11:50 ...

TODO _handleAfterFlushLayout now=2022-09-29 11:51:00.034637
pumpWidget
▄▄▄▄▄▄▄▄ Frame 2                        0ms ▄▄▄▄▄▄▄▄
SimpleAnimatedBuilder.builder animationValue=0.0
first slow builder elapseBlocking for 0:00:00.000000 (p.s. currentFrameTimeStamp=0:00:00.000000)
AuxiliaryTreePack runPipeline start timeStamp=0:00:00.000000 debugReason=RenderAdapterInMainTree.performLayout
SimpleAnimatedBuilder.builder animationValue=0.0
RenderLayoutPreemptPoint.performLayout
Actor.maybePreemptRender shouldAct=false
_RenderAlwaysLayoutBuilder.performLayout
_RenderAlwaysLayoutBuilder.performLayout
second slow layout elapseBlocking for 0:00:00.000000 (p.s. currentFrameTimeStamp=0:00:00.000000)
TODO _handleAfterFlushLayout now=2022-09-29 11:51:00.034637
RenderAdapterInMainTree.paint detach the auxiliaryTreeRootLayer
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
action: pump now=2022-09-29 11:51:00.034637
▄▄▄▄▄▄▄▄ Frame 3                   16.666ms ▄▄▄▄▄▄▄▄
first slow builder elapseBlocking for 0:00:00.015500 (p.s. currentFrameTimeStamp=0:00:00.016666)
RenderLayoutPreemptPoint.performLayout
shouldAct=true now=SimpleDateTime(1664423460066803) nowTimeStamp=0:00:00.015500 shouldActTimeStamp=0:00:00.014666 currentSmoothFrameTimeStamp=0:00:00.016666 currentFrameAdjustedVsyncTargetTimeStamp=0:00:00.016666 currentPreemptRenderVsyncTargetTimeStamp=-2:46:40.000000
Actor.maybePreemptRender shouldAct=true
AuxiliaryTreePack runPipeline start timeStamp=0:00:00.016666 debugReason=preemptModifyLayerTree
SimpleAnimatedBuilder.builder animationValue=0.1
shouldAct=true now=SimpleDateTime(1664423460066803) nowTimeStamp=0:00:00.015500 shouldActTimeStamp=0:00:00.014666 currentSmoothFrameTimeStamp=0:00:00.016666 currentFrameAdjustedVsyncTargetTimeStamp=0:00:00.016666 currentPreemptRenderVsyncTargetTimeStamp=-2:46:40.000000
_RenderAlwaysLayoutBuilder.performLayout
_RenderAlwaysLayoutBuilder.performLayout
second slow layout elapseBlocking for 0:00:00.015500 (p.s. currentFrameTimeStamp=0:00:00.016666)
TODO _handleAfterFlushLayout now=2022-09-29 11:51:00.082303
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
WindowRenderCapturer.expect save failed images to disk
Save image to failure_0_actual.png
Save image to failure_1_actual.png
Save image to failure_0_expect.png
Save image to failure_1_expect.png
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: rasterized image matches that of a [100×50] reference image
  Actual: Image:<[100×50]>
   Which: does not match on 2500 pixels

When the exception was thrown, this was the stack:
#0      fail (package:test_api/src/expect/expect.dart:134:31)
#1      _expect.<anonymous closure> (package:test_api/src/expect/expect.dart:109:9)
<asynchronous suspension>
<asynchronous suspension>
(elided 6 frames from dart:async and package:stack_trace)

The test description was:
  when one extra smooth frame
════════════════════════════════════════════════════════════════════════════════════════════════════

Test failed. See exception logs above.
The test description was: when one extra smooth frame


OntoFox import terms required by assays from PennTURBO team

I am getting ready to add lots of terms to the OBI OntoFox sheets.
There's roughly

700 ChEBI terms
40 PR terms

Plus the following, whose roles in assays may require some more scrutiny.

IRI
label

http://purl.obolibrary.org/obo/DRON_00018971
adalimumab

http://purl.obolibrary.org/obo/GO_0033130
acetylcholine receptor binding

http://purl.obolibrary.org/obo/GO_0071735
IgG immunoglobulin complex

http://purl.obolibrary.org/obo/NCBITaxon_1
root

http://purl.obolibrary.org/obo/NCBITaxon_131567
cellular organisms

http://purl.obolibrary.org/obo/NCBITaxon_33317
Protostomia

http://purl.obolibrary.org/obo/NCBITaxon_33340
Neoptera

http://purl.obolibrary.org/obo/NCBITaxon_6656
Arthropoda

http://purl.obolibrary.org/obo/NCBITaxon_7434
Aculeata <wasps, ants, and bees>

http://purl.obolibrary.org/obo/NCBITaxon_7438
Vespidae

http://purl.obolibrary.org/obo/NCBITaxon_7439
Vespinae

http://purl.obolibrary.org/obo/NCBITaxon_7440
Dolichovespula

http://purl.obolibrary.org/obo/NCBITaxon_7441
Dolichovespula maculata

http://purl.obolibrary.org/obo/NCBITaxon_7442
Dolichovespula arenaria

http://purl.obolibrary.org/obo/NCBITaxon_7456
Polistes

http://purl.obolibrary.org/obo/PATO_0002027
osmolality

http://purl.obolibrary.org/obo/UO_0000061
unit of molarity

http://purl.obolibrary.org/obo/UO_0000180

http://purl.obolibrary.org/obo/UO_0000202
catalytic (activity) concentration unit

http://www.ebi.ac.uk/efo/EFO_0000001
experimental factor

The required terms were determined with the following SPARQL. The !strstarts(str(?s), "turbo:") shouldn't be necessary after switching to OBI IDs. I can clarify more if desired.
The SPARQL query does require one to populate the two named graphs into a RDF triplestore.
PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
select
*
where {
    graph <https://raw.githubusercontent.com/PennTURBO/turbo-assay-templating/master/pipeline/build/turbo_assays.ttl> {
        ?s a owl:Class .
    }
    filter(isiri(?s))
    filter(!strstarts(str(?s), "turbo:"))
    minus {
        graph <http://purl.obolibrary.org/obo/obi.owl> {
            ?s a owl:Class .
        }
    }
    optional {
        ?s rdfs:label ?l .
    }
}

I'll start by just adding these terms to the [Low level source term URIs] section.
I have commented them like this

http://purl.obolibrary.org/obo/PR_000000017 # interferon gamma for TURBO assays

I have entered the UO terms into both

UO_input_instance.txt
UO_input.txt

make all completed on my laptop. I think reasoning took a little longer... around 15 minutes? (I had a stopwatch running but was on a different screen when the reasoning ended.)
But I don't see my new imports (like http://purl.obolibrary.org/obo/CHEBI_18323 'anserine') in either the OntoFox output or build/obi_merged.owl
I'll push and submit a pull request fo others can see what I did

Discussed on 2020-10-05. Needs discussion with LOINC.

Have taken a different approach to generating assays for TURBO needs.


Update ELIXIR Cloud Registry deployment at https://elixir-cloud.dcc.sib.swiss/ga4gh/registry/v1/ui

Deployment at  at https://elixir-cloud.dcc.sib.swiss/ga4gh/registry/v1/ui. Update to latest push on Docker Hub.

Deployment at  at https://elixir-cloud.dcc.sib.swiss/ga4gh/registry/v1/ui. Update to latest commit.

Done.