Getting more then one retained message

Environment

OS: Ubuntu 14.04
Erlang/OTP: Erlang/OTP 19 [erts-8.3.5] [source] [64-bit] [smp:2:2] [async-threads:10] [hipe] -
[kernel-poll:false]
EMQ: 2.3.0

Description
There are many cases where client gets more then one retained message (for one topic)
if let's say client A writes more then one retained message,
within a small time frame (lets say 1 second)
The receiving client (B) will get multiple retained messages instead
of only one.
if client B is subscribed with cleanSession = false and is not connected,
when it does connect, it will get multiple retained messages.

@chriswue As far as i understood the QoS 1 / 0 /2
are all contracts between broker and a client,
thus it ensures broker and client agree that
messages have been arrived on the application level (not only the TCP level)
there should be no stacking up of messages
and there should be only one retained message period.
what happens is that we get 10 retained messages
after the other because client published them with Qos2
so instead of getting the last 'state' we get 10 states
which ruins the whole idea of one retained message.
I think we should stick to
simple and easy use cases without side effects.
There is no reason that QoS > 0 should stack up messages,
if subscribers are not connected, they are going to miss these
messages unless a message is retained.
let's keep it simple stupid?  :)

I've made a few tests with EMQ 2.3.1, here is what i found:

Client B Subscribes to topic "AAAA" with clean: false (Qos 0)

Client B disconnects.

Client A publishes 3 messages with Qos (0 or 1 or 2) to topic "AAAA"

Client B re-Connects, and receives 3 messages.

If client A publishes all the 3 messages as retained, all of them will be received
with a retain flag: true.
So there are 2 discrepancies:

messages should not be kept for Client B (except retained)
There should be always only one retained messages, not multiple

It's very easy to reproduce.

@syberkitten
Regarding:

There is no reason that QoS > 0 should stack up messages,
if subscribers are not connected, they are going to miss these
messages unless a message is retained.

This is obviously incorrect - that's precisely what persistent subscriptions (Clean Session = False) are for.
If you create a persistent subscription then QoS > 0 means the broker must queue up the messages (unless it runs into practical limitation such as running out of storage). For QoS = 0 such a guarantee doesn't exist but it doesn't mean "the broker MUST discard those messages". MQTT doesn't specify what has to happen in that case and as such it's implementation defined. QoS level 0 doesn't "guarantee" message dropping, it just means for the broker it doesn't need to go the extra mile - but obviously it can if it wants to.
emqtt has a queue_qos0 setting (https://github.com/emqtt/emqttd/wiki/Configuration) which seems to default to true so the behaviour you're seeing is completely expected.
If your requirement is that when you newly connect to the broker and subscribe to a topic with a retained message you only ever want the retained message delivered then you need to make that connection with Clean Session = True, this makes the server discard any existing state (including any queued messages in case that client was previously subscribed to the same topic with a Clean Session = False connection) and you only get the retained message delivered.
That's the only "portable" way between MQTT brokers. You may have to keep two client connections around in case you need Clean Session = False for other topics (where you want queuing in case the client disconnects temporarily)
Now with emqtt you could probably set queue_qos0 = False and retry your experiment and it might get you what you want (I'm just not sure if that setting relates to the publisher or the subscriber QoS level)

Hello @chriswue
Thanks for clarifying some of the forest up.
It sounds like you made a turn to make MQTT into a more classic message Queue
which somehow sounds to be a bit of an anti-pattern for MQTT Broker.
I've tried using queue_qos0 = False, it results in the fact that no message is retained
not even Qos1 / Qos 1 / Qos 3
test with store_qos0 = False:

restart broker (after changing to store_qos0 = false)
client A subscribe to topic with clean: false
client A disconnect
client B connect send retained message to topic
client A - reconnects , no retained arrived.

And I really don't want to connect two mqtt clients.
what we do need is simply get the last retained message
with no other messages arriving.

Hm, not entirely sure how you arrive at this conclusion:

It sounds like you made a turn to make MQTT into a more classic message Queue
which somehow sounds to be a bit of an anti-pattern for MQTT Broker.

As per MQTT Spec section <IP_ADDRESS>

If CleanSession is set to 0, the Server MUST resume communications with the Client based on state from the current Session (as identified by the Client identifier). If there is no Session associated with the Client identifier the Server MUST create a new Session. The Client and Server MUST store the Session after the Client and Server are disconnected [MQTT-3.1.2-4]. After the disconnection of a Session that had CleanSession set to 0, the Server MUST store further QoS 1 and QoS 2 messages that match any subscriptions that the client had at the time of disconnection as part of the Session state [MQTT-3.1.2-5]. It MAY also store QoS 0 messages that meet the same criteria.

If CleanSession is set to 1, the Client and Server MUST discard any previous Session and start a new one. This Session lasts as long as the Network Connection. State data associated with this Session MUST NOT be reused in any subsequent Session [MQTT-3.1.2-6].

The Session state in the Client consists of:
·         QoS 1 and QoS 2 messages which have been sent to the Server, but have not been completely acknowledged.
·         QoS 2 messages which have been received from the Server, but have not been completely acknowledged.

The Session state in the Server consists of:
·         The existence of a Session, even if the rest of the Session state is empty.
·         The Client’s subscriptions.
·         QoS 1 and QoS 2 messages which have been sent to the Client, but have not been completely acknowledged.
·         QoS 1 and QoS 2 messages pending transmission to the Client.
·         QoS 2 messages which have been received from the Client, but have not been completely acknowledged.
·         Optionally, QoS 0 messages pending transmission to the Client.

So queuing up messages (or persisting them in some form) for at least QoS > 0 is what's required to conform to the MQTT spec. In how far is this an MQTT broker antipattern?
Regarding the retained behaviour, sound like a bug, but I've tried reproduce this with a 2.3.3 instance (queue_qos0 = false) and it's working fine for me (using the mosquitto command line tools):
First create persistent subscription and using mosquitto_pub -h localhost -q 1 -m "hello" -t "/test" on a different console to publish the "hello" message after client is subscribed:
mosquitto_sub -h localhost -q 1 -C 1 -t "/test" -d -v -c -i "myclient"
Client myclient sending CONNECT
Client myclient received CONNACK
Client myclient sending SUBSCRIBE (Mid: 1, Topic: /test, QoS: 1)
Client myclient received SUBACK
Subscribed (mid: 1): 1
Client myclient received PUBLISH (d0, q1, r0, m1, '/test', ... (5 bytes))
Client myclient sending PUBACK (Mid: 1)
/test hello
Client myclient sending DISCONNECT

Then publish a retained message:
mosquitto_pub -h localhost -q 1 -m "hello retained" -t "/test" -r

Then reconnect:
mosquitto_sub -h localhost -q 1 -C 1 -t "/test" -d -v -c -i "myclient"
Client myclient sending CONNECT
Client myclient received CONNACK
Client myclient sending SUBSCRIBE (Mid: 1, Topic: /test, QoS: 1)
Client myclient received SUBACK
Subscribed (mid: 1): 1
Client myclient received PUBLISH (d0, q1, r0, m2, '/test', ... (14 bytes))
Client myclient sending PUBACK (Mid: 2)
/test hello retained
Client myclient sending DISCONNECT

This is both pub/sub with qos 1. Retain keeps working with QoS 0 as well:
mosquitto_pub -h localhost -q 0 -m "hello retained q0" -t "/test0" -r

mosquitto_sub -h localhost -q 0 -C 1 -t "/test0" -d -v -c -i "myclient"
Client myclient sending CONNECT
Client myclient received CONNACK
Client myclient sending SUBSCRIBE (Mid: 1, Topic: /test0, QoS: 0)
Client myclient received SUBACK
Subscribed (mid: 1): 0
Client myclient received PUBLISH (d0, q0, r0, m0, '/test0', ... (17 bytes))
/test0 hello retained q0
Client myclient sending DISCONNECT

For normal messages (no retain flag) the messages get queued up only if both pub/sub are QoS > 0 (with store_qos0 = false)

@chriswue I guess we have been using MQTT broker in way which is pertaining to somewhat a different pattern, mostly all other brokers never saved QoS 0 messages out of the box.
on my Mac OSX running: 2.3.4
I'm unable to get retained messages when setting, store_qos0
will test on version 2.4.1 - which is the one we'll use in production anyway.

When I'm testing broker nothing of the above seems stable,
sometimes i get only one retained message, sometimes i get none.
@chriswue  Are you running tests to cover all the different scenarios?


Store filter in URL or state (like it was done before)

@0xbase12
Can you link the commit that removed this feature before?


Update replication ack level if response has no task

What changed?
Update replication ack level if response has no task

Why?
if the workflow passed the retention day and got delete, the replication task ack level should be updated.

How did you test it?
Unit test and local tests

Potential risks
N/A

Coverage decreased (-0.5%) to 67.16% when pulling c64877750ab2329588e7e6ab8b35bc1d575fca88 on fix_replication_no_task into 33e4a75ed9b0bce84efa19c670f3c0e3d8fdb4b2 on master.


Vite compatible Jest preset

Is your feature request related to a problem? Please describe.
I'm migrating a large codebase to Vue 3 + Vite. The project contains tests I'd like to reuse. But due to the limited ESM support Jest throws an error every time import.meta.env is used in components, vuex actions, api helpers. Apart from that experience is pretty smooth.
For example (in tests):
timeout: import.meta.env.VITE_API_CONFIG_TIMEOUT
                      ^^^^
SyntaxError: Cannot use 'import.meta' outside a module

Describe the solution you'd like
I'd like to use process.env until ESM support in Jest is complete. Allowing environment variables with VITE_ prefix. As far as I can see in config.ts, the choice is made in favour of import.meta. Would you consider adding a config flag that will allow env customization?
Describe alternatives you've considered
Snowpack, because similar issue has already been addressed
https://github.com/snowpackjs/create-snowpack-app/issues/120
jest.config.js
module.exports = {
  coverageDirectory: 'coverage',
  moduleFileExtensions: ['vue', 'js', 'json'],
  moduleNameMapper: {
    '^/@/(.*)$': '<rootDir>/src/$1',
  },
  transform: {
    '^.+\\.vue$': 'vue-jest',
    '^.+\\js$': 'babel-jest',
  },
}

babel.config.js
module.exports = {
  env: {
    test: {
      presets: [
        [
          '@babel/preset-env',
          {
            targets: {
              node: 'current',
            },
          },
        ],
      ],
    },
  },
}

P.S. I'm happy to provide a reproduction if needed

This is not really a Vite issue - since then running your Jest tests, Jest directly loads your source code without Vite getting involved at all.
What you need is adding a babel plugin like this one (you may need to tweak it a bit) to your babel config.

This is not really a Vite issue - since then running your Jest tests, Jest directly loads your source code without Vite getting involved at all.
What you need is adding a babel plugin like this one (you may need to tweak it a bit) to your babel config.

On another thought, there could probably be an official Jest preset to make Jest vite-compatible.

On another thought, there could probably be an official Jest preset to make Jest vite-compatible.

Honestly, the only thing stopping me from widely adopting Vite as the build tool is the lack of templates with unit tests and end to end tests. I've been trying to get something done myself but apparently I don't know the area good enough to accomplish that. I suppose I am not alone in it.
Having the option to scaffold a project with unit tests using either mocha+chai or jest and e2e tests with cypress or some selenium-based library would make it far easier to make Vite the choice for a new project.

Honestly, the only thing stopping me from widely adopting Vite as the build tool is the lack of templates with unit tests and end to end tests. I've been trying to get something done myself but apparently I don't know the area good enough to accomplish that. I suppose I am not alone in it.
Having the option to scaffold a project with unit tests using either mocha+chai or jest and e2e tests with cypress or some selenium-based library would make it far easier to make Vite the choice for a new project.

It'd be even cooler if those could be plugins that one would need to install and those plugins would then add functionality. I've been dying to get that kind of modularity for ages and nowadays it is only possible with vue-cli managed projects - hence I'm sticking to that.

It'd be even cooler if those could be plugins that one would need to install and those plugins would then add functionality. I've been dying to get that kind of modularity for ages and nowadays it is only possible with vue-cli managed projects - hence I'm sticking to that.

It seems I've found at last the plugin which is able to implement import.meta, it's babel-plugin-transform-import-meta.
So all is needed in my case is:

npm install --save-dev babel-plugin-transform-import-meta
babel.config.js modification

module.exports = {
  plugins: [
    'babel-plugin-transform-import-meta',
  ],
  // or to:
  // env: { test: plugins: [...] }
}

Previously I had:
ERROR: unknown: import.meta may appear only with 'sourceType: "module"' (110:20)
> 110 |   createWebHistory)(import.meta.env.BASE_URL),

Now all is ok.

Keeping an eye on this, feel like it's one of the last big pieces for vite to embrace. Happy to contribute too. I'll have a go at making a jest preset soon, including their fancy hoisting plugin.

I could make it work with the following inline plugin in babel.config.js:
// Only used by Jest
module.exports = {
  presets: [
    [
      '@babel/preset-env',
      { useBuiltIns: 'entry', corejs: '2', targets: { node: 'current' } },
    ],
    '@babel/preset-typescript',
  ],
  plugins: [
    function () {
      return {
        visitor: {
          MetaProperty(path) {
            path.replaceWithSourceString('process')
          },
        },
      }
    },
  ],
}

It basically replaces import.meta.env with process.env. Note it doesn't populate process.env.MODE.
Also, make sure to tell vue-jest to use Babel:
// jest.config.js
globals: {
  'vue-jest': {
    babelConfig: true,
  },
},

And, in case you are testing different configurations, run Jest with --no-cache parameter to avoid wasting hours 🤦

Honestly, the only thing stopping me from widely adopting Vite as the build tool is the lack of templates with unit tests and end to end tests. I've been trying to get something done myself but apparently I don't know the area good enough to accomplish that. I suppose I am not alone in it.
Having the option to scaffold a project with unit tests using either mocha+chai or jest and e2e tests with cypress or some selenium-based library would make it far easier to make Vite the choice for a new project.

@padcom i created a vite-plugin that can test your component with mocha+chai+puppeter you can check this
https://github.com/aelbore/vite-plugin-test
hope you can give any feedback :)

@aelbore Thanks! I've checked it and seems to be working! Thank you!
However, I am mostly using Jest for my tests. Would you be able to create a similar plugin just for use with Jest?

I got it to work by just following the Jest docs.
I just had to install and configure Babel:
https://jestjs.io/docs/en/getting-started
For ESM module support, run with
NODE_OPTIONS=--experimental-vm-modules npx jest

as described here: https://jestjs.io/docs/en/ecmascript-modules

Closing this one to keep discussions in a single issue https://github.com/vitejs/vite/issues/1955

Unrelated to jest, I get the same error in vscode when editing .vue files:

test

import.meta may appear only with 'sourceType: "module"'
and vite shows this error in console
[vite] Internal server error: avoid using JavaScript keyword as property name: "import"
  Raw expression: v-if="import.meta.env.VITE_APP_USER_MODE != 'single'"

I know the workaround is to declare a new variable in data() which has the value of VITE_APP_... . Would there be another way to use VITE_APP_ in templates directly?

@mariusa Do a computed property that exposes the env variable:
computed: {
  mode() {
    return import.meta.env.VITE_APP_USER_MODE
  }
}

Thanks @padcom . That works, setting it in data also works (less typing than computed).
Would have preferred to use directly the env var in template, as vue-cli used to work via process.env.VUE_APP_

@mariusa The difference is that a computed property behaves the same as the meta import - it's read-only. A data item is reactive and read/write, which would have a different semantic that the meta import

I'm using jest with react typescript. Making ts-jest compatible with meta.import seemed like a huge effort currently.
I choose to make Vite act 'backward compatible' by bringing process.env back to Vite. You can achieve this by making use of "define" in vite.config.ts. for example:
import { defineConfig, loadEnv } from 'vite'

export default defineConfig(({ mode }) => {
  const env = loadEnv(mode, process.cwd())

  // expose .env as process.env instead of import.meta since jest does not import meta yet
  const envWithProcessPrefix = Object.entries(env).reduce(
    (prev, [key, val]) => {
      return {
        ...prev,
        ['process.env.' + key]: `"${val}"`,
      }
    },
    {},
  )

  return {
    define: envWithProcessPrefix,
  }
})

Then you can replace any import.meta.env.VITE_SERVER_API_URL to process.env.VITE_SERVER_API_URL


refactor: use createPlateOptions

Calls createPlateOptions() on our own plugin options as mentioned on Plate's configuration docs: https://plate.udecode.io/docs/configuration/#factory

This is probably a bad idea after all and it doesn't seem to help with any of the current issues anyhow (although it solves TS issues for Paragraph)

createPlateOptions() creates plugin options for all plugins they support, not just the ones we're using.
If there are default options that we do not overwrite, e.g. for hotkeys, then I imagine we'll end up with undesired hotkeys etc.


Assets commited to repo

As the purpose of this repository is to be used as a neovim plugin the assets for the readme should not be commited into the repo. Plugins for neovim are just git clones of repositories. There is no need for a user to download assets every time (waste of download time and space). Since they are also committed into git a copy of them is zlib compressed into the objects folder and will live for the existence of the project.
Instead of adding them to the repo you can either create an issue that you lock and use it to upload images that you link, or use the wiki to host the files instead.
As an example of the first method I use this method to host my screenshots for my colorscheme nightfox (issue). I also close it so no one really sees it and I can just upload images there.
As the plugin is still very new you can rewrite your git history to remove the references to the assets. This can be done with the git command filter-repo. This will rewrite your git history to remove references to the images.
The command would be
git filter-repo --invert-paths --path .github/assets/

Here is the results before and after
Before
nvim-compleet ➜ dua
   4.10 KB .cargo
   4.10 KB .gitignore
   4.10 KB Cargo.toml
   4.10 KB LICENSE
   4.10 KB build.rs
   4.10 KB rustfmt.toml
   8.19 KB Cargo.lock
   8.19 KB README.md
  77.82 KB neovim
 249.86 KB src
   1.90 MB .github
   4.51 MB .git
   6.78 MB total

After
nvim-compleet  ➜ dua
   4.10 KB .cargo
   4.10 KB .github
   4.10 KB .gitignore
   4.10 KB Cargo.toml
   4.10 KB LICENSE
   4.10 KB build.rs
   4.10 KB rustfmt.toml
   8.19 KB Cargo.lock
   8.19 KB README.md
  77.82 KB neovim
 249.86 KB src
 438.27 KB .git
 811.01 KB total

Removing the references change the repo size from 6.78 MB to 811.01 KB !

Yep, this all makes sense. I need to update the links in the README but this should be fixed now.


Pre-Market data

Hi,
is there any way to get pre-market data in Ticker.info?
i have seen it in the old version. (#390)

Hi,
is there any way to get pre-market data in Ticker.info?
i have seen it in the old version. (#390)

Hi,
I have the same question, any progress?

Duplicate #1393


Update existing scrapers to use logging

[] Existing scrapers should use logging, and most do not
[] Existing scrapers should have scrape functionality deprecated
[] ca_orange_county_sheriff scraper is missing an apostrophe in Sheriff's Department and it just drives me nuts


Unable to find the nodes in cytoscape3.

I have manually installed the cytoscape plugin for cytoscape 3. I am able to see the app in the list of apps.
The next step I did was to configure and add the default URL. Further I started to search the kam model and found all the 5 kam models I built. I selected one of those and gene abundance but got 0 nodes. Later on I searched with ALL as the function and still got the same result(0 nodes).
Is there any work around for this issue?

The requirements listed for the current release has now been updated to specify the 3.0.0 (experimental) version of the BEL Framework. Was the BEL Framework version responsible for this issue?

I am  not sure whether the Bel framework version was responsible or not. I guess not because of the following reason.
I have tried compiling Bel script in both the versions (2.0 and 3.0 ) and with both of the results I tried on cytoscape 3.0. Here I am able to see the kam's but not able to search for nodes or find them. It shows 0 results when I search. This happened for the kams created from both version of Bel framework.


Mux encoder on dev board

If we do decide on a serialized select method, perhaps we can implement an encoder into the development board?
(I still prefer a combinatorial selection. We just reduce user input size to io_in(10:0) )

If caravel works, then we can use that to select designs and have a default / selection method.
If not then we'll have a co-processor that sits on the board and does the selection.


Prompt gets mis-aligned when PS1 includes emoji 😥

We all know how important it is to have emoji in our bash prompt.
Adding emoji moves the prompt down and it gets cut off when at the bottom of the window.

😢

#154 🙂


Home page "nutriscore v2" link goes to "page error"

What

Just opened the app, with its "learn more about nutriscore v2" button, and landed on an error page.

Steps to reproduce the behavior

Open the app
In the home page, below the barcode scanner, there's a "Hey, nutriscore v2 is there!" card.
In this card, there's a "learn more..." button
When you click in the link, you land in the web on an error page

Expected behavior
Landing on a correct page was expected.
Screenshot/Mockup/Before-After

app
web

Smartphone model

Device: android emulator
App Version: dev

Additional context
We land on https://world.openfoodfacts.org/guide/nutriscore-v2
I also tried https://fr.openfoodfacts.org/guide/nutriscore-v2 and I still land on an error page - but in French ;)

I removed the guide/ it's at the domain root

@teolemon Does not work either:

https://world.openfoodfacts.org/nutriscore-v2
https://fr.openfoodfacts.org/nutriscore-v2

Does work in TEST though:

https://world.openfoodfacts.net/nutriscore-v2
https://fr.openfoodfacts.net/nutriscore-v2

yes, we haven't deployed it to prod yet.

yes, we haven't deployed it to prod yet.

Would be about time.

https://github.com/openfoodfacts/openfoodfacts-server/pull/10470

You can hotlink to GitHub @monsieurtanuki

The issue was fixed for 4.15.0


Unable to Reproduce Build Process; Missing Dependencies

The build process, as described, fails due to a missing libelf.h file.
This issue was encountered when testing within Docker using Ubuntu 24.04 in combination with the RISC-V GNU Compiler Toolchain as well as with Dockcross, instead of compiling the toolchain manually.
Building natively on the PolarFire SoC FPGA Icicle Kit and in QEMU (both running Ubuntu 24.04)
succeeds after installing libelf-dev and adding -lzstd to LIBS= in the Makefile.
However, the resulting binary fails at runtime with the error: "Unhandled auxv entry type: 27."
Could you provide further information on the recommended build process?
Beste Grüße!

Hi, so I tried to build MAMBO-V natively running a RISC-V Debian image, but it didn't work out (I get strange linker errors from elfutils).
Originally, we fully cross-compiled MAMBO-V and all its dependencies, as there was no Debian or Ubuntu image back then :sweat_smile:. For libelf we used the elfutils implementation at version 0.183. The GNU RISC-V Toolchain was something like version 2022.02.11.
I'm very busy right now, but I'll try to revive and perhaps modernize the old build process.


Cython - defining functions with dictionaries, other dataframes and dates series as arguments

I am a python user with moderate experience in writing codes and recently I noticed that I can use cython for sequential models like backtesting codes to make it faster. The problem is that imagine I have a function called backtesting with arguments given below:
def backtest(daterange,price_dict,tickers_dict,):
return result
where daterange is a dataframe of dates.
price_dict is a dictionary of daily prices based on company ticker and date given (so it is a dictionary with 2 levels of keys --> price_dict[ticker][date] -> price
tickers_dict is a dictionary of picked tickers based on dates so it is like tickers_dict[date] --> gives a list of tickers
result is a dataframe with daily equity values of the portfolio calculated inside the function.
How can I define all of these in cython using cdef or cpdef? what is the syntax for it? It has driven me crazy t o find the right syntax!
thanks

The bug tracker is really only for bugs and feature requests. The recommended support channel is the cython-users mailing list.


Exposing port other than 80.

Description:
I’m trying to run Docker Flow Proxy and expose some port other than 80, but not having any luck.  I’ve created a simple test compose file below:
Steps to reproduce
On a swarm cluster, deploy the following stack:
version: "3.2"

networks:
  backend:
    driver: overlay

services:
  proxy:
    image: vfarcic/docker-flow-proxy
    ports:
      - "5601:5601"
    networks:
      - backend
    environment:
      - LISTENER_ADDRESS=swarm-listener
      - MODE=swarm
      #- BIND_PORTS=5601
      - DEFAULT_PORTS=5601
      - DEBUG=true

  swarm-listener:
    image: vfarcic/docker-flow-swarm-listener
    networks:
      - backend
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    environment:
      - DF_NOTIFY_CREATE_SERVICE_URL=http://proxy:8080/v1/docker-flow-proxy/reconfigure
      - DF_NOTIFY_REMOVE_SERVICE_URL=http://proxy:8080/v1/docker-flow-proxy/remove
    deploy:
      placement:
        constraints: [node.role == manager]

  kibana:
    image: kibana
    networks:
      - backend
    deploy:
      labels:
        - com.df.notify=true
        - com.df.distribute=true
        - com.df.serviceDomain=somedomain.com
        - com.df.port=5601

Add a host or DNS entry to point helloworld.local.com to your swarm.
Everything seems to start up fine, but I cannot access the service on port 90 (e.g. http://somedomain.com:5601).

Reproduced it... I'll fix it later today.

There was an error in documentation. You'll need to add:
- BIND_PORTS=90

... environment variable to the proxy.
That assumes that you will have services that should be accessible on the port 80. If not, the change is even simpler. You can change:
      - 90:90

to
      - 90:80

If your services have unique identifiers (e.g. serviceDomain and/or servicePath), with the BIND_PORTS env. var. there's no need to specify srcPort.
Can you please let me know if this answered your questions and whether one of the suggestions worked?

@vfarcic thanks for looking into this - Unfortunately, I'm still having no luck.  The haproxy.cfg looks correct, but I'm still getting 503 response.  I also turned on debug mode and see that it's not finding a service for the request
test_proxy.1.x7jiebktjmko@moby    | 2017/11/01 19:37:02 HAPRoxy: <IP_ADDRESS>:45098 [01/Nov/2017:19:37:02.156] services services/<NOSRV> -1/-1/-1/-1/0 503 1271 - - SC-- 2/2/0/0/0 0/0 "GET / HTTP/1.1"
test_proxy.1.x7jiebktjmko@moby    | 2017/11/01 19:37:02 HAPRoxy: <IP_ADDRESS>:45100 [01/Nov/2017:19:37:02.481] services services/<NOSRV> -1/-1/-1/-1/0 503 1271 - - SC-- 1/1/0/0/0 0/0 "GET /favicon.ico HTTP/1.1"

Can you post your updated stack YML file?

I updated the yml in the description above.   Note that I've also tried changing the port mapping to 5601:80 and removing the DEFAULT_PORTS and BIND_PORTS but results are the same.  Here is the  frontend and backend sections of the generated haproxy.cfg:
frontend services
    bind *:5601
    mode http

    option httplog
    log global
    acl url_test_kibana5601_0 path_beg /
    acl domain_test_kibana5601_0 hdr(host) -i somedomain.com
    use_backend test_kibana-be5601_0 if url_test_kibana5601_0 domain_test_kibana5601_0

backend test_kibana-be5601_0
    mode http
    http-request add-header X-Forwarded-Proto https if { ssl_fc }
    log global
    server test_kibana test_kibana:5601

Sorry... I didn't explain myself well. Can you send me the YML files with the definition of your services (proxy, listener, ...)? I'd like to replicate the same as what you have so that I can see where is the error.

test.yml.zip
I put the contents of the yml in the description above, but here is the actual file I'm using.

I just rerun the same stack and, once all the services were running, executed curl -i -H "Host: somedomain.com" "http://localhost:5601". The output is:
HTTP/1.1 200 OK
kbn-name: kibana
kbn-version: 5.6.3
cache-control: no-cache
content-type: text/html; charset=utf-8
content-length: 217
accept-ranges: bytes
Date: Wed, 01 Nov 2017 20:21:27 GMT

<script>var hashRoute = '/app/kibana';
var defaultRoute = '/app/kibana';

var hash = window.location.hash;
if (hash.length) {
  window.location = hashRoute + hash;
} else {
  window.location = defaultRoute;
}</script>%

The config from my instance of the proxy is exactly the same as in your case so the problem is not that, in my case, DFP did something different.
Is it possible that something is blocking the port 5601?

Hum, it's not something blocking the port - if I remove the proxy and add the port mapping to the Kibana service, it works.  But given that it works for you, it must be something with my environment.  I'll try on another VM when I get home in about an hour.  Thanks again for looking at it.

Maybe we can have a screen-sharing session and go through it together? How about tomorrow around this same time? Would that suit you?

@vfarcic - I think I found the problem.  It does work with curl command where you specify the Host value (I don't know why it wasn't working for me yesterday, but it does work now).  It fails when you try with the browser because the Host includes the port (see below).  If I manually change the haproxy acl to include the port acl domain_test hdr(host) -i somedomain.com:5601 it works from the browser as well.
We can't have DFP add the port to the acl because that will the the published port and is not anything DFP knows (without adding a new variable, which would not be ideal).  Instead, if we change the generated ACL to use hdr_beg instead of hdr, it will work.  For example, acl domain_test hdr_beg(host) -i somedomain.com.  If that sounds like the right approach, I can submit a PR.

Now that I've looked at the code, I can see that a PR isn't needed.  You already externalized the ACL rule via as SERVICE_DOMAIN_ALGO.  Thanks!.  Just adding SERVICE_DOMAIN_ALGO=hdr_beg(host) works.  Let me know if you think it makes sense to change the default to hdr_beg, or maybe just call it out in the documentation if using a published ports other than 80 or 443.

I think that the right approach would be to use hdr_beg if serviceDomainAlgo is NOT specified and srcPort is set to value other than 80 or 443. What do you think? Would you like to make a PR?

I agree on the first part, using hdr_beg if serviceDomainAlgo not specified, but not sure on the second.  Because I'm using serviceDomain, I'm not specifying srcPort at all.  If I did use srcPort, would that be the published port?  For example, if my compose file had:
    ports:
       - 90:5601

Would I set srcPort to 5601 or 90?  Either way, I'll be glad to submit a PR later today.

You're right. Let's go with hdr_beg(host) as default value instead of hdr(host). I think that it would be enough to change SERVICE_DOMAIN_ALGO in Dockerfile. It's a very simple change but it would require a bit of testing to make sure that nothing is broken. I'll wait for a PR unless you tell me otherwise.

I think this issue can be closed with that merge. Can you please confirm that now it works as expected?

Hi @vfarcic -
I found this issue, is it possible to map a portrange?
Currently i'm using one instance of haproxy-service and maximum 10 of the logstash-service:
frontend fe_logstash
bind *:10000-10100
default_backend be_logstash_service
backend be_logstash_service
balance roundrobin
server-template logstash- 10 logstash-service check port 10000 resolvers docker init-addr libc,none
The idea is too connect 100 different datasources from outside world to the internal service.

@b2az Unfortunately, all the development of this project stopped. Almost everyone moved from Swarm to Kubernetes so it didn't make sense to continue working on this project. I strongly suggest you switch to Kubernetes as well. Even Docker company is not working on Swarm for a long time now.


Text track kind is misspelled

What version of Shaka Player are you using?
2.1.1

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Chrome, FF, Edge, IE; MacOS

What did you do?
Calling getTextTracksin the trackschanged event

What content did you load?
http://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd

If standard demo asset, which one?

If custom asset, what manifest and license server URIs?

How did you interact with the content, if at all?

What did you expect to happen?
Tracks have a kind of subtitles or captions

What actually happened?
Kind is subtitle or caption

I believe these enums are wrong: https://github.com/google/shaka-player/blob/01d64584224d4a9546cb0982b7047a6079f08c28/lib/util/manifest_parser_utils.js#L90-L93
According to the spec, valid kinds are subtitles or captions here.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/track

After careful review, we have determined that the typo is in the documentation for shakaExtern.Stream and shakaExtern.Track.  Those refer to "captions" and "subtitles", even though the constants used are "caption" and "subtitle".
I understand that it is a little confusing to have constants named very similarly to the <track> element attribute names, but the constants in shakaExtern.Track and shakaExtern.Stream are never applied to the kind attribute in <track>.
To summarize:

The Shaka Player API uses subtitle and caption.
DASH manifests use subtitle and caption.
HLS manifests use subtitles.
HTMLTrackElement uses subtitles and captions.

We will take this as a docs bug and correct the typos in the externs.  Thank you for the report!

This fix was just released in v2.1.2.


add docs for LineString geometries

Here's the doc I put together on Wednesday. Could someone please review for merge?

Thanks Martial.


Lighthouse/performance improvements

Lazy load more stuff (e.g. algosdk, firebase)
Fixes for useLocale and useLanguage
Priority loading of some images
get-claims no longer throwing errors just for checking claims
ky-hook extracted to DRY up code
Cookie consent banner is lazy "loaded" (assumes initially accepted to prevent flash)
a11y name for menu toggle
Various lint warning fixes for react hooks
Revalidate homepage immediately if no page was fetched
Configure optional bundle analyzer to help review bundle size (most changes due to the updated package-lock.json)

Before
Page                                                Size     First Load JS
┌ ● /                                               9.43 kB         225 kB
├   └ css/b5c4cdf4c11eec10.css                      1.83 kB
├   /_app                                           0 B             169 kB
...
+ First Load JS shared by all                       169 kB
  ├ chunks/framework-e6a8cc401d03a815.js            42.1 kB
  ├ chunks/main-3a56263fe8525743.js                 29.2 kB
  ├ chunks/pages/_app-b399bdcd98fa6197.js           94.9 kB
  ├ chunks/webpack-3dc0958160ffd7c5.js              2.86 kB
  └ css/3604010d817af5cb.css                        6.84 kB

After
Page                                                Size     First Load JS
┌ ● /                                               9.44 kB         187 kB
├   └ css/b5c4cdf4c11eec10.css                      1.83 kB
├   /_app                                           0 B             129 kB
...
+ First Load JS shared by all                       129 kB
  ├ chunks/framework-e6a8cc401d03a815.js            42.1 kB
  ├ chunks/main-3a56263fe8525743.js                 29.2 kB
  ├ chunks/pages/_app-14c45b38a55bd68a.js           54.6 kB
  ├ chunks/webpack-519aa53fed2161b5.js              2.97 kB
  └ css/3604010d817af5cb.css                        6.84 kB

I was running into an issue related to firebase when doing a hard refresh on the releases page so I ran npm i and then restarted and now I'm getting crbug/1173575, non-JS module files deprecated in the console and the app won't load at all. Not sure what's up. Gotta grab lunch now and then have another call so unfortunately I can't probe in any more right now

I was running into an issue related to firebase when doing a hard refresh on the releases page so I ran npm i and then restarted and now I'm getting crbug/1173575, non-JS module files deprecated in the console and the app won't load at all. Not sure what's up. Gotta grab lunch now and then have another call so unfortunately I can't probe in any more right now

I just tried again and now the application is starting, but I'm running in the following error with Firebase:
FirebaseError: Firebase: No Firebase App '[DEFAULT]' has been created - call Firebase App.initializeApp() (app/no-app).

🔥


Relocate Hit Highlighting Feature from finesse-frontend to finesse-backend

The goal is to centralize the hit highlighting process for non-Azure sources in finesse-backend, aligning with the existing Azure source handling. This shift aims to unify the logic, ensuring consistency across different sources.
Tasks:

Develop hit highlighting logic in the backend for non-Azure sources.
Adjust the frontend to fetch highlighted content from the backend.
Conduct tests to verify that the backend's highlighting aligns with current standards.
Update relevant documentation to reflect the backend-centric approach.

Acceptance Criteria:

[ ] Backend handles hit highlighting for all sources uniformly.
[ ] Frontend correctly displays highlighted content from the backend.
[ ] Consistent highlighting results across Azure and non-Azure sources.
[ ] All tests confirm the new implementation's reliability.
[ ] Documentation accurately describes the unified highlighting approach.

I'm having a hard time visualising this.
Could you provide screenshots, diagrams, deeplinks to the existing source to explain this? Contrasting current vs previous situation.

@ibrahim-kabir ok, but in which issue/PR was the feature implemented ? And have all the tasks listed here been completed or do they need their own issue?

@ibrahim-kabir ok, but in which issue/PR was the feature implemented ? And have all the tasks listed here been completed or do they need their own issue?

If I may, here https://github.com/ai-cfia/finesse-backend/pull/10. I asked him to close this in our board review meeting.
Note however that hit highlighting is currently implemented as a backend feature only for the azure index.


Remove mounted state

https://github.com/akiran/react-slick/blob/master/src/inner-slider.js#L36
Using mounted state is code smell
https://reactjs.org/blog/2015/12/16/ismounted-antipattern.html
We should remove this state and clear all the timers in componentWillUnmount

Removed the state and we are already clearing timeouts and timers in componentWillUnmount.
bbb65e5275c1bd9ea0d99cbd656533cffc1c0208


Quantification rotation && pivot

Guys am not very good in math , if a good guys in math can help me .
How can you compute rotation base on pivot in pixi ?
Example i move pivot to XY.
And i move rotation to ( randian || degree )
After i move again pivot with mouse compute... all became weird..
How i can compute rotation but base on the position from pivot ?
for now here it my try code.
thank guys, i have difficult with deep math.
Also, I would like to compute skew :)
    // update QuickEdit proprety mode
    function update_quickEditMode(objSprite){
        const D = 45; // distance marge for active a mode
        const difX = mX-memX;
        const difY = mY-memY;
        let angle = Math.atan2(difY, difX);
        const kX = objSprite.skew._x*difX; // skew for help compute pivot ?
        const kY = objSprite.skew._y*difY; // skew for help compute pivot ?
        // angle = Math.radians(angle *180);
        if(!QuickEditMode){// wait move mouse in a direction for identify wich mode
            QuickEditMode = difX>D&&'rot'||difX<-D&&'sc'||difY>D&&'ske'||difY<-D&&'piv'||false;
        }else{
            switch (QuickEditMode) {
                case 'rot':
                objSprite.rotation=(angle);
                break;
                case 'sc':
                objSprite.scale.set(-((difX-D)/100),(D-difY)/100)
                break;
                case 'ske':
                objSprite.skew.set((D-difX)/100,(difY-D)/100)
                break;
                case 'piv':
                objSprite.pivot.set((difX*-1)/objSprite.scale._x+kY,(difY*-1)/objSprite.scale._y+kX)
                const color = objSprite.linePivot.graphicsData[0].lineColor
                objSprite.linePivot.clear();
                objSprite.linePivot.lineStyle(2, color, 0.6);
                objSprite.linePivot.moveTo(0,0).lineTo(objSprite.pivot.x||0.1, objSprite.pivot.y).endFill();
                objSprite.lineH.position.set(objSprite.pivot.x,objSprite.pivot.y);
                break;
            };
        };
    };

I have succeeded in allowing the mouse factor to allow all other proprety to work intuitively, but I block when the rotation or skew is engaging.
All the mouse come very weird psychedelic !?
If you need video i can give.

 Can you make a fiddle? I just dont understand what you want to do.

@ivanpopelyshev
here
https://jsfiddle.net/jonforum/ow9w7rfz/1/
as you can see , i don't know the math formula for compute the position with rotation.

@ivanpopelyshev
a friend help me a little bit but we are stock here.
Are you able to make the saure follow mouse correctly in you side ?
https://jsfiddle.net/jonforum/ow9w7rfz/8/
I am convinced that need use .cos and .sin , but not sure...


Add EWS example

OPS Build status updates of commit 2385a1e:
:clock10: Preparing: average preparing time is 41 sec(s)

OPS Build status updates of commit 2385a1e:
:clock10: Incremental building: average incremental building time is 17 sec(s)

OPS Build status updates of commit 2385a1e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/metadata-for-an-outlook-add-in.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 6db63f3:
:clock10: Preparing: average preparing time is 41 sec(s)

OPS Build status updates of commit 6db63f3:
:clock10: Incremental building: average incremental building time is 17 sec(s)

OPS Build status updates of commit 6db63f3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/metadata-for-an-outlook-add-in.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


robot_pose_publisher: 0.2.4-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository robot_pose_publisher to 0.2.4-0:

upstream repository: https://github.com/WPI-RAIL/robot_pose_publisher.git
release repository: https://github.com/gt-rail-release/robot_pose_publisher-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.20
previous version for package: 0.2.3-0

robot_pose_publisher
* Update README.md
* Update package.xml
* fixed dox file
* fixed readme
* travis edit
* Contributors: David Kent, Russell Toris

Your python-rosdistro version is out of date - you need 0.4.4 or higher. Please upgrade and rerun bloom-release with --pull-request-only or -p or edit the commit to fix the REP version.


Spotlight-Projector projection broken/mismatched

Godot version
v4.0.alpha2.official [79077e6c1]
System information
Windows 10, RTX 2070
Issue description
The light projection of the spot light does only show a small spot of the given texture as projection

Steps to reproduce
create SpotLight3D
assign projector texture
shine on receiving object
Minimal reproduction project
spotlight_projector.zip

Duplicate of https://github.com/godotengine/godot/issues/50445 (already fixed in the latest master branch).


Traverse hestia graph of cycles

to find for a specific cycle all related hestia cycles ("activities")
in order to reach just dependencies with emissions ("elementary flows")

#39 was the first try. but using https://api-staging.hestia.earth/swagger/#/default/get_cycles__id__deep_relations will be an easier way to implement this.

[ ] understand and document how https://api-staging.hestia.earth/swagger/#/default/get_cycles__id__deep_relations works
[ ] make a working example to get a flat list of connected cycles to a cycle
[ ] implement it nicely within the existing api calls

The following is derived from a lot of trying around. I am not 100% sure, if these conclusions account for the whole Hestia database.
It seems, that cycles are not directly connected within the Hestia Database.
However the cycles can be connected via impactassessments as can be seen in the section "2. Cycle Navigator", e.g. here:
https://www-staging.hestia.earth/cycle/znex7uqxsfqn
To find the indirectly connected cycles down- and upstream, a different API call can be used. For example:
requests.get("https://api-staging.hestia.earth/cycles/znex7uqxsfqn/deep-relations?connections=ImpactAssessmentcycle,CycleinputsimpactAssessment&includeAggregated=true&offset=0&limit=1000").json()
yields a list of cycles and impactassessments, each with the information on "parentIds" and "childIds". Parents and childs of cycles consist purely of impactassessments and vice versa. With the contained information it is possible to construct the potential connected graph which can be opened by clicking manually on the nodes in the section "2. Cycle Navigator" on:
https://www-staging.hestia.earth/cycle/znex7uqxsfqn
I propose to use the API entry point at /cycles/CYCLE_ID/deep-relations in the form above to get the desired flat list of connected cycles. The impactassessments in the result list can be discarded for now. The limit parameter should be set big enough to account for the whole connected graph. Since the Hestia Database is not fully linked, it should not yield to many results. While trying with different cycle_ids the returned list did never consist of more than 100 elements.
Probably a good list being returned could look something like this (in a brightway exchange thinking):
[
{from: {@type="cycle", @id: PARENT_CYCLE_ID}, to: {@type: "cycle", @id: CHILD_CYCLE_ID}, product: {@type: "term", @id: PRODUCT_TERM_ID}},
...
]

Caution: The parent and cycle ids in this case refer only to cycles. To derive them, a hop via an impactassessment has to be made.
In that form with the proposed "@type" and "@id" fields, this dictionary could be used directly with the already implemented API functionality to get more neccessary information on the desired node.

Deep relations returns
[{'@id': '_pgqzpzubd_3',
  '@type': 'Cycle',
  'name': 'Soybean, seed (whole) - Brazil - 2013 - Soybeans production',
  'aggregated': False,
  'childIds': ['bv2ktx0jjkub'],
  'parentIds': []},
 {'@id': '1wcs_sfkyghn',
  '@type': 'ImpactAssessment',
  'name': 'Meat, beef cattle (cold carcass weight) - Brazil - 2013',
  'aggregated': False,
  'childIds': [],
  'parentIds': ['_mlxmewvtlzx']},
...
]

For "ImpactAssessment" objects returned by deep-relations, the "parentIds" list is always of size 1 and corresponds to the "parent" cycle of that impact assessment, i.e. the impact assessment characterizes an output of that parent cycle.
The parent cycle is also what is stored in the "cycle" entry of the impact assessment Hestia json.

So in order to find a cycle C_B producing an input for cycle C_A
C_A["parentId"] would lead to an Impact Assessment I and I["parentId"] would lead to the desired cycle C_B.

Is implemented with #44


koordlet: improve metric GC

Ⅰ. Describe what this PR does

Refactor the expiring metrics. Instead of running a GC goroutine for each metric vector, use a single goroutine to garbage collect expired metrics.
Ⅱ. Does this pull request fix one issue?

Improve the metric GC introduced in #1118.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
Benchmark

10 gauge vectors and N metrics for each gauge.
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz

func BenchmarkMetricGC(b *testing.B) {
	// ...
	var wg sync.WaitGroup
	metrics := generatePodMetrics(b.N, time.Now().Unix())
	for i := 0; i < b.N; i++ {
		m := metrics[i]
		wg.Add(1)
		go func() {
			for j := 0; j < vecCount; j++ {
				gcVecs[j].WithSet(m.labels, m.value)
			}
			wg.Done()
		}()
	}
	wg.Wait()
}

$ # 1. (default) expireTime = 5 mins, interval = 1 min. Old
BenchmarkMetricGC-12           63543             22914 ns/op           12005 B/op        279 allocs/op
$ # 1.(default) expireTime = 5 mins, interval = 1 min. New
BenchmarkMetricGC-12            70045             20295 ns/op            9653 B/op        190 allocs/op
$ # 2. expireTime = 5 s, interval = 1 s. Old
BenchmarkMetricGC-12           57393             21820 ns/op           12316 B/op        279 allocs/op
$ # 2. expireTime = 5 s, interval = 1 s. New
BenchmarkMetricGC-12            64078             19662 ns/op            9938 B/op        191 allocs/op
$ # 3. expireTime = 5 ms, interval = 1 ms. Old
BenchmarkMetricGC-12           68731             22142 ns/op           11220 B/op        279 allocs/op
$ # 3. expireTime = 5 ms, interval = 1 ms. New
BenchmarkMetricGC-12            70024             24272 ns/op            9359 B/op        224 allocs/op
$ # 4. expireTime = 500 ns, interval = 100 ns. Old
BenchmarkMetricGC-12           43885             34366 ns/op           10684 B/op        279 allocs/op
$ # 4. expireTime = 500 ns, interval = 100 ns. New
BenchmarkMetricGC-12           68745             30414 ns/op           10154 B/op        235 allocs/op

V. Checklist

[X] I have written necessary docs and comments
[X] I have added necessary unit tests and integration tests
[X] All checks passed in make test

/cc @chzhj

/lgtm

/lgtm
/approve


adding navbar

Issue Template
Description
Objective: I propose enhancing the navbar like this
https://github.com/user-attachments/assets/b77b0b3c-563d-4515-b404-261c52a043de
Please assign this issue to me, as I would love to work on it. I am also a contributor in GGSOCExt 24 , hacktoberfest.
Looking forward to your feedback

go ahead, if we like it, we'll merge it


initialValues only works for first rendered form of name

Sort of a tough problem to explain, so feel free to modify the title.
The issue I'm experiencing is that I have a very complex, multi-page form, so I'd like to take the very redux approach of splitting certain fields and sections into their own components and then having them connect to the store/redux-form themselves. In general, the approach works, however the initialValues feature only seems to work on the first-rendered component for that given form name. They need to share the same form name because the top-level form handles submitting of the entire form.
Here's a minimial viable reproduction: http://jsbin.com/xicileg/edit?js,output
const NameField = reduxForm({
  form: 'example-form',
  fields: ['name'],
  initialValues: {
    name: 'Bilbo Baggins'
  }
})(
  ({ fields: { name } }) =>

      Name: {name.value || 'THIS IS NOT SET WITH DEFAULT'}

);

const Form = reduxForm({
  form: 'example-form',
  fields: ['message'],
  initialValues: {
    message: 'works'
  }
})(
  ({ fields: { message } }) =>

Top level value: {message.value}

     <NameField />

);

If I provide every field to the top-level component, it works, however this is now makes the top-level form need to know the schema up-front which in my case it cannot because the inner components vary depending on dynamic conditions only known by the children. i.e. I really would rather not have to define the entire schema w/ initialValues for every field in the form in one place as it appears that will make maintenance a nightmare for me.
Perhaps this isn't a bug and is expected behavior? If so, any insight on decoupling is appreciated.

I had the similar issue, just make sure you pass unique formKey prop to the form, together with initialValues, and it should work (same way the Redux asks for key property). Something like this should work for you:
const Form = reduxForm({
  form: 'example-form',
  fields: ['message'],
  initialValues: {
    message: 'works'
  }
})(
  ({ fields: { message } }) =>

Top level value: {message.value}

     <NameField formKey="uniqueKey"/>

);

This is a known bug that dates back to #621, however, #843 should have just fixed it.
I will expedite the next release to publish that bug fix.

Fix published as v5.2.5.

@erikras well that was fast. Glad to hear a fix was already in the works. I had seen #621 and also experienced the "not until second render" bug, didn't realize it was the same issue. 👍
Thanks!

That's pretty awesome. If you go to your JSBin and flip the 4 to a 5 in the redux-form import, the problem vanishes. I ❤ JSBin!


Modules Not Loaded Under Windows

Hello there. I found that fortls might be unable to find and load external modules under Windows. After doing some simple debugging, I discovered the problem is in the langserver.path_from_uri function. While in Unix-like systems the last slash in “file:///“ denotes file system root, in Windows it will make the system fail to recognize the correct diver letter “invalid driver letter: /C:”. A simple fix would be adding a system detection (if os.name==“nt”) and do uri.split(“file:///“, 1) if it comes out to be Windows.

Sorry for the late reply. There were a few things going on on Windows along with the path issue you pointed out. I didn't have a Windows test box setup till the last few days. I believe I have fixed all the Windows specific issues in the latest release. Let me know if you continue to run into issues. Thanks for the report and tracking down the cause!


Support .NET Standard 2.0

Could you create a .NET Standard 2.0 tool so this addin can be used by the Cake global tools, which uses .NET Core?
There is a NuGet package that can be references in lieu of the reference assembly System.ServiceProcess. https://www.nuget.org/packages/System.ServiceProcess.ServiceController/

.net core support was added in v.1.0.0


Not receiving POST request

Hello
After creating invoice and passing callback_url, when user do successfully payment we don't receive any POST request from you on our callback_url and we are not behind cloudflare

Hello,
Please provide more details to out support


Helper functions

Codecov Report

Merging #25 (6e6f8d9) into main (6c96d2f) will increase coverage by 2.67%.
The diff coverage is 98.48%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   88.14%   90.82%   +2.67%
==========================================
  Files          23       24       +1
  Lines        1004     1046      +42
==========================================
+ Hits          885      950      +65
+ Misses        119       96      -23

Impacted Files
Coverage Δ

OktaPosh/public/ConvertTo-OktaYaml.ps1
90.32% <ø> (+19.73%)
:arrow_up:

OktaPosh/public/Get-OktaLog.ps1
80.00% <ø> (ø)

OktaPosh/public/Policy.ps1
98.31% <ø> (ø)

OktaPosh/public/Zone.ps1
96.00% <ø> (ø)

OktaPosh/public/Links.ps1
96.96% <96.96%> (ø)

OktaPosh/public/Application.ps1
97.50% <100.00%> (+0.88%)
:arrow_up:

OktaPosh/public/AuthorizationClaim.ps1
93.93% <100.00%> (+0.18%)
:arrow_up:

OktaPosh/public/AuthorizationPolicy.ps1
92.30% <100.00%> (+0.30%)
:arrow_up:

OktaPosh/public/AuthorizationRule.ps1
92.68% <100.00%> (+0.18%)
:arrow_up:

OktaPosh/public/AuthorizationScope.ps1
95.45% <100.00%> (+0.21%)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c96d2f...6e6f8d9. Read the comment docs.


Add support for LISY35

WPC/Bally machines with AS-2518-17 or AS-2518-35 CPU boards

part of 0.54


How to simply use functions from module "tstab"?

I have already executed "./configure.sh && make -C build/release".
What can I do next?
Thanks a lot!

Like "mask2poly()" etc.

hello, how do you solve the problem?


Missing LICENSE.txt

I suggest MIT

As of #17, the project now has a LICENSE file, and it's indeed MIT. Suggest closing this issue.

True! Thanks!


WIP: Replace React-Boostrap elements with vscode-webview-ui-toolkit ones.

:warning: DO NOT MERGE YET: work in progress

References

Description

Install @vscode/webview-ui-toolkit as a dependency.
Replace UI elements with the ones in [@vscode/webview-ui-toolkit]
(https://github.com/microsoft/vscode-webview-ui-toolkit/).
Address direct concerns raised in Issue #8 . The proposed slider implementation in the Issue will be addressed separately.

Validation performed

@Henry8192 Kindly take over if you have time.
Please help setting CSS variables (prefixed with --) in the ThemeContextProvider in the format that @vscode/webview-ui-toolkit elements can recognize.

Current look

Closing this PR as the changes were made to a deprecated version of the log viewer. The functionality / improvements introduced here has already been implemented in the new version of the log viewer, which replaced the codebase in PR #101.


Marp for VS Code v0.7.0 cannot export to any types

An updated Marp for VS Code v0.7.0 will show this notification when exporting, and cannot export to any types.

For extension user: Please rollback extension if you are using v0.7.0 and you wanna export Marp Markdown. We apologize for the inconvenience :pray:

Or you can use Marp CLI in terminal.


[Visual Requirements - Upload Card Structure]: Luminosity ratio of "Cancel" button border with respect to background color is 1.605:1 which is less than 3:1.

https://microsoft.visualstudio.com/OS/_workitems/edit/30642435

This issue is not repro at our end, hence closing this issue.
Snippet:


Observe loading changes

Observe loading

Pull Request Test Coverage Report for Build 628004480

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 622921642:
0.0%

Covered Lines:
21

Relevant Lines:
21

💛  - Coveralls


Add statistics for idr0072

To be released in prod96

Merging so that @dominikl can add the stats for idr0063 as a follow-up


Handle async loading of google maps API

It is actually not necessary to directly initialize in the linking function the google maps API services, therefore we could only do it when we actually use them.
This fixes #69

This returns a console error:
angular.js?v=0123456789&m=6:11706 Error: [$injector:undef] Provider 'googlePlacesApi' must return a value from $get factory method. http://errors.angularjs.org/1.3.20/$injector/undef?p0=googlePlacesApi     at angular.js?v=0123456789&m=6:63     at Object.enforcedReturnValue [as $get] (angular.js?v=0123456789&m=6:4074)     at Object.invoke (angular.js?v=0123456789&m=6:4219)     at angular.js?v=0123456789&m=6:4037     at getService (angular.js?v=0123456789&m=6:4178)     at Object.invoke (angular.js?v=0123456789&m=6:4210)     at angular.js?v=0123456789&m=6:6547     at forEach (angular.js?v=0123456789&m=6:326)     at Object.<anonymous> (angular.js?v=0123456789&m=6:6545)     at Object.invoke (angular.js?v=0123456789&m=6:4219)

It would mean that you are calling the directive before having loaded the google places api from google. I guess I am not, which is why I didn't see this error.
This doesn't happen when you still load synchronously right? only when async?


Scope of cursor at end of line

Description
The scope of the cursor is taken to be of the character to the right of it. This works most of the time, but can have unexpected behaviour when the cursor is at the end of a line and scopes do not extend to the newline character.
E.g., in this issue the TS parser does not count the newline as part of the comment, so autocomplete suggestions were not suppressed when typing at the end of the line. I raised this issue to suggest a fix, but decided this is more general than comments.
I think Atom should in general use the left character if the next is a newline. This behaviour matches the TextMate grammars, but I'm not sure if that's because they apply the scope to the newline character or because they already do this.
It potentially makes the following confusing, but it also makes sense in a way (and matches TextMate behaviour, so not really confusing at all). Here, | is the cursor (not a character), and the scopes are how TextMate handles it
// End of line: 'source string'
"foo"|

// Not end of line: 'source'
"foo"| bar

/cc @maxbrunsfeld This falls under Tree-sitter, and I've made my argument.

I think Atom should in general use the left character if the next is a newline.

It potentially makes the following confusing, but it also makes sense in a way (and matches TextMate behaviour, so not really confusing at all).

Yeah, I guess I'm cool with that.


Keep checking for box-status API call in front end

So, when boxId is not yet activated on start up, the boxId should keep checking and refresh itself once the status becomes activated

Done

awesome !


Enhance InMemDiskArrayBuilder with a to simplify population of lists in_mem_node_builder/in_mem_rel_builder

Currently InMemNodeBuilder uses InMemUnstructuredLists unstrPropertyLists, which uses its own structures to populate the actual lists of lists, such as InMemFile. This is not true for ListMetadata and Lists, which uses InMemDiskArray. If we switch to using DiskArray and InMemDiskArrrayBuilder for the actual lists too some of the loading code can simplify. In particular, parts of code that are populating InMemFile work at a low-level abstraction, where they figure out where the actual page locations they need to update. Instead, if we worked at the abstraction of an array or vector, which can be supported by DiskArray, and had utility functions, such as copy(uint64_t beginOffset, uint8_t* from, uint64 numBytes) or push_back(element), where T is the type of DiskArray etc, and the DiskArrayBuilder figured out exactly which pages to update could be much simpler.
As a concrete example, at a high level, the InMemNodeBuilder::putUnstrPropsOfALineToLists code, reads a line of csv, parses each unstructured property and copies to a particular offset in an array. But the code looks lower level and the following function calls happen
1. InMemNodeBuilder::putUnstrPropsOfALineToLists: unstrPropertyLists->setUnstructuredElement(...)
2. InMemUnstructuredLists::setUnstructuredElement:  InMemUnstructuredLists::setComponentOfUnstrProperty(...)
3. Inside InMemUnstructuredLists::setComponentOfUnstrProperty, we find the in-mem page or pages that need to be updated etc.

All this complexity can be hidden if we make lists to use DiskArrays enhance InMemDiskArrayBuilder to have several utility functions that automatically writes the given data to the correct in-memory locations and are saved to disk correctly as well.

No longer relevant.


Light_switch example, can't set-target esp32s3 (CON-386)

esp32s3 can't build, esp32c3 can.
jonsmirl@ares:~/aosp/esp-matter/examples/light_switch$ idf.py set-target esp32s3
Adding "set-target"'s dependency "fullclean" to list of commands with default set of options.
Executing action: fullclean
Build directory '/home/jonsmirl/aosp/esp-matter/examples/light_switch/build' not found. Nothing to clean.
Executing action: set-target
Set Target to: esp32s3, new sdkconfig will be created.
Running cmake in directory /home/jonsmirl/aosp/esp-matter/examples/light_switch/build
Executing "cmake -G Ninja -DPYTHON_DEPS_CHECKED=1 -DPYTHON=/home/jonsmirl/.espressif/python_env/idf5.1_py3.10_env/bin/python -DESP_PLATFORM=1 -DIDF_TARGET=esp32s3 -DCCACHE_ENABLE=1 /home/jonsmirl/aosp/esp-matter/examples/light_switch"...
CMake Error at CMakeLists.txt:21 (message):
  Unsupported IDF_TARGET

-- Configuring incomplete, errors occurred!
cmake failed with exit code 1, output of the command is in the /home/jonsmirl/aosp/esp-matter/examples/light_switch/build/log/idf_py_stderr_output_1145686 and /home/jonsmirl/aosp/esp-matter/examples/light_switch/build/log/idf_py_stdout_output_1145686
jonsmirl@ares:~/aosp/esp-matter/examples/light_switch$

Even this is expected as its not listed into the light_switch/CMakeLists.txt. Will test and add other SoCs here and other examples as well.


Supplement documents, optimize the website

The current project website is not perfect and lacks documentation. We hope to complete the following tasks:

Beautify the website
Supplementary design and use documents

the website resource is here
https://github.com/apache/incubator-eventmesh-site

First draft of the website: https://github.com/apache/incubator-eventmesh-site/pull/6


chore: add more sophisticated datetime handling

Closes #3

Codecov Report

Merging #15 (bba4ea2) into master (68ed63e) will increase coverage by 5.53%.
The diff coverage is 61.11%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   66.11%   71.64%   +5.53%
==========================================
  Files           6        6
  Lines         242      261      +19
==========================================
+ Hits          160      187      +27
+ Misses         82       74       -8

Impacted Files
Coverage Δ

src/request.rs
68.57% <50.00%> (-6.06%)
:arrow_down:

src/request/next_item.rs
69.56% <62.85%> (+69.56%)
:arrow_up:

src/config.rs
86.91% <71.42%> (-1.98%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ed63e...bba4ea2. Read the comment docs.


Various improvements/bugfixes to search_suggestions.

~1. Got rid of is:private being suggested for all sender and pm-with searches.~ Merged
2. Removed the ugly "unknown operand" message from is: searches.
3. Added support for autocompleting operator names, so str completes to stream:.
~4. Negated -has previously broke autocomplete, but this was fixed.~ Merged
5. Changed "Messages sent by..." to "Sent by..."

Automated message from Dropbox CLA bot
@cory2067, it looks like you've already signed the Dropbox CLA. Thanks!

@cory2067 thanks for working on this!  I merged a couple commits, and have a few thoughts on the rest:

I think for the operators typeahead, we want to be a bit smarter; if you've typed fro, we should offer as the first option from:, and hitting enter should just make it from: and leave you in the search interface to type an operand, rather than searching for things from the empty email.
I think if you actually type from:, we don't need from: in the typeahead options -- we should instead be autocompleting things that come after the from: part.  I.e. "messages sent by" in this should go away:

Also, maybe we want "Sent by me" and "messages sent by Iago" to agree in format; probably removing the "messages" part is correct since it's shorter?
I think the new is: behavior isn't quite right; since there are only 4 possible values for what goes after is:, I think we should only offer those values on the RHS; so the top entry that's "foo messages" just shouldn't be offered at all (it basically makes enter useless with is:).  It maybe makes sense to provide some sort of "unknown operator" text if you type something that's not a prefix of a value operator.
You have a linter error.

Will change the "Sent by me" thing.
All the other points above are a result of the default suggestion.
Currently, and with the old search system, the first suggestion result isn't really a suggestion-- it just repeats exactly what you just typed (put into words by Filter.describe). So if you push enter on the first suggestion, autocomplete never modifies your query.
I guess this is useful in that it never autocompletes unless you explicitly want it to, by pushing the down arrow. Like if we're talking about strings, and so I want to search "str". I type 'str' in the top bar and push enter, but (if default suggestion is gone) it autocompletes to "stream:", even though I don't want that.
But we could change this if it's worth dealing with those rare cases. We can make the typeahead quite aggressive, which resolves your above points:
Only show default suggestion if we have nothing else to suggest. I actually implemented this at one point, but then reconsidered and removed it because there's a nice trick you can do with the current system.
If you want to autocomplete without submitting/searching, then you just push the down arrow. This fills the autocomplete, but lets you keep typing afterward. (Basically your above first point). This makes typing multiple-token queries super fast.
If we get rid of the default suggestion, then we lose this as far as I can tell.

What's the status of this PR, @cory2067!  Looks like it has some Travis errors.

I think the Travis errors will be fixed by a rebase, we'll see.
I've been holding off on making more changes to these commits, until I figure out with @timabbott what approach we should take (see the above discussion).

Codecov Report

Merging #5401 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5401      +/-   ##
==========================================
+ Coverage   86.64%   86.65%   +<.01%
==========================================
  Files         432      432
  Lines       53567    53602      +35
  Branches     2092     2094       +2
==========================================
+ Hits        46413    46448      +35
  Misses       7154     7154

Impacted Files
Coverage Δ

frontend_tests/node_tests/filter.js
100% <100%> (ø)
:arrow_up:

static/js/search_suggestion.js
100% <100%> (ø)
:arrow_up:

frontend_tests/node_tests/search_suggestion.js
97.33% <100%> (+0.14%)
:arrow_up:

static/js/filter.js
99.65% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f74dc8...4d471d9. Read the comment docs.

Sorry for the delay reviewing this.  These changes looks great, merged, thanks @cory2067!
I think we should have a further discussion about improving our search suggestions system, but I imagine that the next really big improvement might be more along the axis of visual design changes to make it easy to build a set of operators with the mouse.


CIV-3562 N245 Form screen

Before creating a pull request make sure that:

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-3562
Change description
Create Application to Vary Judgement
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

I think file name needs to end with GASpec.. Isn't it?

Done


Version 3

Fluid Player version 3.0.0
This version is a major rewrite of Fluid Player. All major features are now split from the main player
logic.
Following has changed

NPM package with with ready to use module, ready to be used with dynamic pages and SPAs.
Webpack used for CDN distribution.
All external dependencies have been removed from repository, NPM versions are used instead.
External dependencies are loaded on first time use.
Countless number of small bug fixes and improvements.
Only documented public API is now exposed to end users.
Player instance can be initialized using either player element id or HTMLVideoElement node reference.
Controls are hidden by default and becomes visible if so configured in settings or defaults (no button flash).

Breaking changes

Fluid Player no longer exposes private APIs and player internals not documented to be used from outside the player object itself. Users who rely on these APIs should open an issue requesting a public API to such currently internalized features and APIs.
CDN no longer publishes CSS as a separate file. CSS is now bundled with JavaScript distribution of the player.

Closes #251
Closes #277
Closes #373
Closes #424
Closes #436
Closes #431
Closes #225
Closes #411
Closes #416
Closes #271
Closes #423
Closes #314
Closes #351

Fluid Player version 3.0.0
This version is a major rewrite of Fluid Player. All major features are now split from the main player
logic.
Following has changed

NPM package with with ready to use module, ready to be used with dynamic pages and SPAs.
Webpack used for CDN distribution.
All external dependencies have been removed from repository, NPM versions are used instead.
External dependencies are loaded on first time use.
Countless number of small bug fixes and improvements.
Only documented public API is now exposed to end users.
Player instance can be initialized using either player element id or HTMLVideoElement node reference.
Controls are hidden by default and becomes visible if so configured in settings or defaults (no button flash).

Breaking changes

Fluid Player no longer exposes private APIs and player internals not documented to be used from outside the player object itself. Users who rely on these APIs should open an issue requesting a public API to such currently internalized features and APIs.
CDN no longer publishes CSS as a separate file. CSS is now bundled with JavaScript distribution of the player.

Closes #251
Closes #277
Closes #373
Closes #424
Closes #436
Closes #431
Closes #225
Closes #411
Closes #416
Closes #271
Closes #423
Closes #314
Closes #351

Hello
Is it possible to get code of the latest version for playing m3u8 link on blogs?
thank you in advance!
like this code:

Good

](url)

Amazing


Can't use on mobile devices

Can't use one mobile devices. The image gets stuck on touch.

The plugin was created before the smartphone boom so it was not designed to work with touch screens. I will investigate when i have free time to see if it can be added.


Themes configuration

This is not an issue, rather a question I've not be able to find an answer:  how can I edit and configure the themes? Even browsing the source code here on github but I did not manage to find the location of the themes...

The themes are bundled with the binary, and the sources are on github in the runtime directory here. You can create your own by creating .micro files in ~/.config/micro/colorschemes.

Thank you very much


feat: Add additional permission for karpenter IAM policy added in v0.14.0 release

Description

Add additional permission for karpenter IAM policy added in v0.14.0 release, which allows the use of custom AMIs without the need for an entire launch template

Motivation and Context

Support additional permission required in v0.14.0 https://karpenter.sh/v0.14.0/upgrade-guide/#upgrading-to-v0140

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 5.3.0 :tada:


style(Confirm): update typings

Updates typings of Confirm component for #1169

Codecov Report

Merging #1425 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1425   +/-   ##
=======================================
  Coverage   99.74%   99.74%
=======================================
  Files         141      141
  Lines        2354     2354
=======================================
  Hits         2348     2348
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8e536...6ea4cfa. Read the comment docs.

Released in<EMAIL_ADDRESS>


Workaround for fetchDependencies exit trap shell causing issues for callers

fetchDependencies has a trap on EXIT which makes it hardly usable in a Makefile.
Here is a typical use case:
runme.sh:
#!/bin/sh
trap "kill 0" EXIT

Makefile:
all:
	./runme.sh

% make
./runme.sh
zsh: terminated  make
% echo $?
143

Workaround: ./fetchDependencies --no-parallel-build

Thanks for providing the workaround.

Is this about killing stray child processes? Maybe it could use something like kill $(jobs -p) for that, or make itself a group leader and target the group.

Is this about killing stray child processes?

No, I don't think so.
fetchDependencies has a parallelization option (on by default) to build the dependency libraries for multiple platforms in parallel by spawning multiple xcodebuild processes and then waiting for them to finish.
The --no-parallel-build builds each platform in series and does not spawn and wait for any other processes.
I'm happy to hear ideas for how to run the parallelization spawning without trapping.
Also...the multi-build parallelization effort doesn't actually save that much time (maybe 10%-ish?), because Xcode already does a pretty good job of parallelizing each individual platform to maximize CPU usage efficiency. So...if this parallel spawning design within fetchDependencies is causing problems, we can just remove it altogether.

My point was, is the point of this trap to kill the script's children if it exits prematurely?  Or else, set up it's own process group and then kill 0 would not kill the calling process that does not isolate children in their own group (like make, apparently).
Otherwise, what is the point of it?

PR #1066 makes --no-parallel-build the default option.
Building in parallel does not significantly improve performance, and as shown here, makes it
more difficult to integrate calling fetchDependencies from a larger build script,
because of the need to trap and kill child processes on an error.


RSA key generation fails when date detects an invalid date string in the original cert valid from line

hi   error-failed to generate RSA key???

@jm537 That doesn't look good at all. Can you share the APK file and your run.log file?

run.txt

ccleaner.zip

@jm537 @henefesto I have a fix that will be on the develop branch later today.

ok

@jm537 @henefesto The fix is no on the develop branch. Test it out and report back if you can.

Okay, I'll try

Yeah!!

@henefesto Awesome! Thanks for testing the fix. It will be included in the next release.

1.apk.zip
run.txt

test another system problem RSA KEY

@jm537 It looks like you are still running the script from the master branch. The fix for this issue is only on the develop branch at the moment.

@jm537 @henefesto The fix is now in v0.1.9 on the master branch. Thanks for the bug report and testing help.


Example updates and additions

See commits for details

Will resolve https://github.com/nexmo-community/nexmo-node-quickstart/issues/9


Proposal: time-based releases

I'd like to start doing time-based releases, similar to how web browsers do it.
Not worrying about what changes go into which release will allow us to ship features faster and improve the general state of the network faster. We can do this while not causing problems for admins because of semver.
Here's the full proposal:

Releases will be cut every two months (we can bikeshed about this time frame)
Each release will go through a beta phase of one month (ditto for bikeshedding) before it's released, similar to browser "channels". This means that each release will spend a month being changed in git master, and a month being in beta.
Stabilization fixes go on a separate "beta" branch, which then gets (re)published to npm and merged back into master
Semver-major changes sit unmerged in branches until we're ready to do a semver-major release (i.e. the scheduled nature has no impact on how often we release breaking changes)

There's some precedent for this in server projects, but not a whole lot. The only one I know of is GitLab, which is a little different since they're backed by a company, etc. But I think this is a worthy experiment, and we can always change our minds later.

This has been project policy for months and is working out quite well so far.


Search results remain highlighted after closing unfinished search

Issue Type: Bug

Open DefinitelyTyped. (This is hard to reproduce in a small project because it relies on search taking some time.)
Open types/abs/index.d.ts.
Press ctrl-shift-f to open find-all
Type ex and search, and quickly press ctrl-b to close the find window before it finishes searching.
ex remains highlighted.

0.238Z)
VS Code version: Code - Insiders 1.23.0-insider (ab56a0952b9c2ff7add6404f80ebf9398cf8ae51, 2018-04-17T05:12:5
OS version: Linux x64 4.13.0-37-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2600)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 2

Memory (System)
7.63GB (1.90GB free)

Process Argv
/usr/share/code-insiders/code-insiders .

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

typescript-javascript-grammar
ms-
0.0.39

Reproduced this again with vscode-insiders that I updated this morning.
Version: 1.28.0-insider
Commit: 8330a695712c43f861ce5c47533d82637d3cb374
Date: 2018-09-13T11:25:01.441Z

I can't think of much to elaborate on from my initial description. Note that this needs to be done fast!  After typing ex in the find-all bar, immediately hit enter then ctrl-b. It looks like the highlight on ex actually goes away for a second before coming back.

Today I can repro...


fix: small error in example

Noticed a small error as I was reading the docs.

@betodealmeida My first PR!!! Thank you :)


Does this support the connect attribute?

I've tried setting connect="lower" but the classes don't get added.

I got this working by adding "connect" to the scope object and then adding it to the slider.object on line 64.
line 14:
connect:'@'
line 64:
slider.noUiSlider({  connect:scope.connect, });


Callback/hook for after everything has loaded?

Hi,
Just curious if there is a hook for after all AdminLTE JavaScript has finished loading?
I would like to experiment with an overlay with a "loading" graphic (mainly to avoid seeing jumps in UI components).
Has anyone played with this? Any code or tips?
Thanks!

Hello,
AdminLTE doesn't provide a hook for complete loading but I would suggest trying window.onLoad
https://stackoverflow.com/questions/15564029/adding-to-window-onload-event
Thanks!

Thanks!


Change library name from liblexeme to something else

Java libraries aren't usually prefixed with "lib". I think just "lexeme" would be a better name for the library.

Another good name would be "inflection", because it better represents what this template engine is for.

"Inflexible" would be a good name as well, because I love silly puns. But there is already a php library borisguery/inflexible with that same name.

Inflectible?

Inflectible it is!


LazyDom

Rather than materializing the complete tree eagerly, allow users to create a LazyValue that only parses the input buffer as much as is necessary to satisfy the method call at hand.

@zslayton thanks for the quick response. In terms of the interim solution are you referring to using a Reader?
I’m sure that would work. Just not ideal from my optic as it would make the client code brittle should a change to the underlying data structure occur from our service. Also, it would mean our client code would need to have a deep understanding of the data structures.


Add unit tests for library code

@triblondon The existing tests are closer to integration tests than unit tests. There is definitely some cross-over between test/unit and test/node. With test/unit I'm looking to have fully isolated unit tests with which to run coverage reports against where we have purposefully hit a specific code path. Coverage reports will enable us to find out what parts of the code-base are not covered in test cases.
I'm hoping we can split our tests up into unit and integration tests.

@JakeChampion let me know when you want a fresh review of this


Add support for @slonik/typegen

Closes #11
Note: the captures have been adjusted in (4945117), to match the original tokenization.

Submitted the same changes to vscode-sql-lit, as it seems to be more active (https://github.com/thebearingedge/vscode-sql-lit/pull/3)

The definition of 'identifier' was stolen from the official TypeScript grammar


Removed hover-animation from project card

Hover animation is removed from Project cards to enhance user-experience.

@dheerajmw  Could you please consider adding the issue number to your request? It would greatly assist in the merging process. Thank you.


update typescript usage docs

Update docs fixing how to use standard in a typescript project. This fix was suggested by @mehmetnyarar so if he provides me an email I will add him as co-author.
Fix #1255

I have updated the commit adding @mehmetnyarar as co-author

Thanks!

@Tommytrg @LinusU Note that it won't be enough since due to rules clashing it will result in false-positive 'SomeType' is defined but never used  errors for any imported type.
See for details https://github.com/eslint/typescript-eslint-parser/issues/457


starknet: only send pending data if user requested

Current dependencies on/for this PR:

main

PR #90   👈

This comment was auto-generated by Graphite.


Auto truncate status bar titles

As you can see, sometimes the status bar text is too long when displaying web pages with long titles. Take powerline/powerline for example. An option to truncate the title automatically would be nice. 👍

should the title truncate only if it overlaps with left or right parts of the bar?

Perhaps a setting such that when x% of the bar's horizontal width is taken up the title is truncated with ellipses .... Will need some constant width set for the ellipses since they will technically add length also.

Fixed on master, but couldn't be bothered with the additional complexity to add an ellipsis at the end.


Depend on ansi-terminal in Shake

I am considering adding an ansi-terminal dependency in Shake so I can have prettier console messages. Given Hadrian already has such a dependency I guess that's not going to cause you problems - but I thought I'd check.

@ndmitchell Yes, we already depend on ansi-terminal, so I don't see any issues with this.
However, if ansi-terminal is problematic on a certain platform, Hadrian can easily live without it. But we can't live without Shake! :-)

If ansi-terminal ever becomes problematic I'll just remove it - not a big deal and won't be integrated tightly.


Replace List/Sequence with immutable Tuple in dataclass

For the immutable dataclass (frozen=True), we should use immutable types in the fields. This also makes the dataclass automatically hashable (https://docs.python.org/3/library/dataclasses.html#module-contents)
Right now we use mutable List in many places. For example:
https://github.com/iree-org/iree/blob/5c5feb413acb8f82a351dc2fb648b1446998ec70/build_tools/python/e2e_test_framework/definitions/common_definitions.py#L133
These should be replaced with the immutable Tuple.

https://github.com/iree-org/iree/pull/11587#discussion_r1053904179 shows some good ways to initialize a dataclass with tuple fields.


Support for other PHYs than KSZ8081 missing in mcux_eth / nxp kinetis ethernet driver

The Zephyr shim driver eth_mcux.c is currently hard-coded with support for only one particular PHY (KSZ8081, found on many NXP evks).
Quote by @danieldegrasse in discussion about this issue at Discord:

The PHY management needs to be moved out of the ethernet driver, and into a proper PHY driver. There is a PHY driver interface present in Zephyr, but NXP's driver does not currently use it for the PHY

This issue is a show-stopper for any NXP SoC (K6x, RT10xx, RT11xx) using the Kinetis Ethernet driver (eth_mcux) on a board with a PHY different than KSZ8081.
For example, we use the Texas Instruments TLK111 PHY. Only a few modifications of eth_mcux.c (change hard-coded KSZ8081 registers to TLK111) are necessary to get it to work, but there is no obvious and trivial way to generalize this without refactoring the eth_mcux driver like @danieldegrasse suggests in the quote.

Bump that we are in the same situation in supporting TJA1103 on FMURT6, FMURT7 and MR-CANHUBK344

Bump that we are in the same situation in supporting TJA1103 on FMURT6, FMURT7 and MR-CANHUBK344

I am redoing the driver downstream and it is a large effort that is taking a long time, but it will be able to support the Zephyr PHY API once it is working and therefore should be much more flexible to work with any PHY

closed with merge of new nxp_enet driver, eth_mcux will not support this


Autocomplete without automatic filtering

I want to disable the automatic filtering of the autocomplete. I tried doing so with inheritance but themr messes up the classes so it's impossible to override the .matches() function.
My search is performed on the server side, and I wanna use the autocomplete just for displaying the list and selections.
Is there a way to do that currently?
If not, a possible modification to the AC component could be allowing passing a function to the suggetionMatch prop.

@Tudmotu Right now it is not possible I think and that's why #1169 exists. The implementation that is coming will allow you to fully customize the autocomplete possibilities, children, and filtering function. If you want to PR the change meanwhile, I'll be happy to merge it!
Nonetheless I'm closing in favor of #1169 :)


Fix Lock tests

Fix Lock tests

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (468eeee) 61.92% compared to head (098687b) 61.78%.

Files
Patch %
Lines

lib/core/stores/remote.ts
0.00%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   61.92%   61.78%   -0.15%
==========================================
  Files          18       18
  Lines         851      853       +2
  Branches      222      223       +1
==========================================
  Hits          527      527
- Misses        296      297       +1
- Partials       28       29       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Monorepo follow-on housekeeping

Possible follow-on work to consider from #1.
Must have once we're ready to do the full switchover:

[ ] Migrate existing issues from their individual repos
[ ] Archive those repos
[x] Updated release automation and procedures. The current release processes are currently copied from their respective packages into .github/workflows/ci.yml, and commented out as stubs.
[x] Update other packaging/deployment considerations (i.e. Dockerfile)
[x] Additional revisions to package-level READMEs and documentation revisions

To consider:

[ ] Reduce redundancies in CI config. There's quite a lot of stuff repeated almost-or-totally-verbatim in ci.yml. In theory some of it can be broken out into separate actions which might be triggered explicitly by the main config. This sounds nice, but a word of caution: in past experience, I've found attempts to apply more than the minimal necessary abstraction in these sorts of configs (and in YAML broadly) can and even tend to do more harm than good.
[ ] Migrate any VSCode launch.json/tasks.json as we see fit. (I suspect I was the only one using these, and I haven't used them much for quite a while. I'm inclined to reconsider the approach if/when we find a need.)
[ ] Consolidate top level tsconfig.json and jsconfig.json if/where possible. Some cases must remain broken out in separate configs (generally test-specifics, and cases like those in enketo-transformer with conditional access to DOM APIs). I would like to have spent some time addressing this in the initial setup PR, but there's some inherent complexity (i.e. composite projects) that should probably be addressed, and a bunch of incidental complexity related to our intended gradual adoption.
[ ] Improve consistency of scripts and task management (i.e. package.json scripts entries, remaining usage of grunt). I'd like to have done more on this here too, but it felt increasingly like a separate scope as the rest progressed.
[ ] We should eventually address issues with enketo-transformer's release-related portions of package.json found by Are the types wrong?.
[ ] TODOs extracted from .gitignore:

[ ] Allow *.code-workspace if we ever want that
[ ] Naming and path consistency of build artifacts, don't mix build output in source paths
[ ] Naming and path consistency of fixtures
[ ] Consolidate configs
[ ] Revisit Docker/etc related ignores

Is something keeping you from archiving the old repos? For people unfamiliar with the project it is intuitive to go to the specific repos to create issues since currently there is no indication that these repos are not updated anymore.

Sorry about that, just time. I'm hoping it can be wrapped up by next week.

For moving issues:
gh issue list -s all -L 100 --json number -R enketo/enketo-core | \
    jq -r '.[] | .number' | \
    xargs -I% gh issue transfer % enketo/enketo -R enketo/enketo-core

Moving closed issues as well so all history can be searched from one place. Will have to do in batches because of rate limiting.


The meaning of parameters in transformer.log as output

Hello! I have made 2D affine transform and got the transformer.log file and target.csv, target.pts, source.png file etc as output. In transformer.log I found the ‘TransformParameters’, the ‘Spacing’ and the ‘CenterOfRotationPoint’. I apply T(x) = A(x-c)+c to the original target.csv, but I cannot get the result in output target.csv. I have checked the documentation but cannot find the reasons. Can you give me some help? Thank you very much!
Lin

See this to check you are reading the parameters in a proper way:
https://github.com/SuperElastix/elastix/issues/237
and the way you are doing with "center of rotation" seems OK.
Bartolomejka

See this to check you are reading the parameters in a proper way:
https://github.com/SuperElastix/elastix/issues/237
and the way you are doing with "center of rotation" seems OK.
Bartolomejka

Thank you , my problem has been solved