== and ===

Looks like another step towards more Ruby-like and expressive syntax would be:
`==`  -> `a.equals(b)`
String.new("a") == String.new("a")
Integer.new(1) == Integer.new(1)

This is helpful when comparing values, which we are in most common cases
`===` -> `a == b`
String.new("a") !== String.new("a")
Integer.new(1) !==Integer.new(1)

Thiw would map Java's standard behaviour it to Mirah's, without changing how it works.

The == to equals bit is covered by #127


ExpenseItem Currency being set to CAD on item open for generated data

When an expense item is opened the currency is being set to CAD before the item is opened.
This only seems to happen for the data that is generated, not for any data that is created by the user. If a user modifys a generated claim, the changes will be persistant and will not be changed when entering expense item info. This seems to be happening before the ExpenseItemInfo activity is loaded.
REPRO:

open expense item list for in progress claim
click on expense item
item currency is changed to CAD
expense item is opened

REPRO

open expense item list for in progress claim
click on expense item
item currency is changed to CAD
expense item is opened
change currency to USD
Return to expense item list.
see that currency remains USD
click on expense item again
expense item is opened
currency remains USD.

I remember mentioning this at least once, and I can see it hasn't been acted on yet, bet our currency in item is of type Currency, not our own ItemCurrency. I will go ahead and change this.


chore(FieldTheory/PolynomialGaloisGroup): move lemmas, reduce imports

#dependencies:
Mathlib.FieldTheory.PolynomialGaloisGroup: 1826->1323
Mathlib.Analysis.Complex.Polynomial: 1811->1826
This needed one small change to a moved proof because conj is not allowed as an identifier when the ComplexConjugate locale is open.

I'm not sure if we should add a new file.

!bench

This makes sense to me.
maintainer merge


Quickpick items search reveals octicons used in the items

VSCode Version: 1.10.0-insider 256d76fed7947e7289f921df10658d7a69233b65
OS Version: macOS Sierra 10.12.3 (16D32)

Steps to Reproduce:

Open a quick pick menu that uses the built in octicons in the items

Type a character that is in the octicon name

Octicons get revealed as text

It also looks like the octicon text also shows up in the hover tooltips (title attr)

Any chance to get this on the list for the June (or soon) iteration? This does seem to cause confusion for users as they have no idea what that text that all of a sudden appears is.

Maybe a code position where we could dig in?

The picker is opened from here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/quickopen/quickOpenController.ts#L219

Thanks, I'll take a look, but I was never that deep in the code. :/

@eamodio maybe you check the fix out on master with GitLens since you are a heavy customer.

Will do - thanks!

@bpasero I just checked out master and I don't see any tooltips on quickpick items now.
I did notice another issue (not new though), the tooltip over the input (for the placeholder), shows the wrong content (previous content) if the quickpick is replaced with a new one.
For example, in GitLens if you open file or branch history in a quickpick and see the tooltip over the input (it should be correct), but then pick one of the commits (which will open a new quickpick), and see that the tooltip over the input it still showing the previous tooltip content, not the updated content. (FYI, this is not new, I can reproduce it in 1.19 too)

@eamodio can you file separate issues for that? To be clear: this issue is resolved for you right?

@bpasero No -- now I don't see any tooltips at all -- I was expecting that the octicons would be stripped, but now there is no tooltip at all.
Will do, re: other issue.

Opened: https://github.com/Microsoft/vscode/issues/43114 for the other issue

Sorry, I was getting mixed up on this. The search part works great now -- octicons don't show up

adding verified label based on @eamodio comment


Split functions within the step folder into .hpp and .cpp files

This commit should improve compile times for incremental builds quite significantly, depending on where you're making your changes.  Note that it seems to slow down building from scratch by a little bit (about 20-50%).
The functions in this folder mark the transition from a high level "pass around the structs" workflow to actually calling the kernels that do the work, so they are a reasonable place to provide the split to get the most "bang for our buck" with incremental compile time improvements.

I've added the top-level openturbine.hpp for users to include rather than being fine-grained with their includes.  I'm open to adding more to this, but I figured this was a good first set of files and the bare minimum for using OpenTurbine.
Let me know if this looks good or if you'd still prefer to include in the lower level headers.

The functions in this folder mark the transition from a high level "pass around the structs" workflow to actually calling the kernels that do the work, so they are a reasonable place to provide the split to get the most "bang for our buck" with incremental compile time improvements.

Just wondering if any other parts of openturbine might benefit from such a split -- what are your thoughts? Is maintaining a mix of header-only files + splitting them out as appropriate the optimal path?

The functions in this folder mark the transition from a high level "pass around the structs" workflow to actually calling the kernels that do the work, so they are a reasonable place to provide the split to get the most "bang for our buck" with incremental compile time improvements.

Just wondering if any other parts of openturbine might benefit from such a split -- what are your thoughts? Is maintaining a mix of header-only files + splitting them out as appropriate the optimal path?

Maybe, but I don't think so.  This split already slows down our compile times from scratch significantly.  Truth be told, I'm not even sure if this change is a good idea (I put it together hoping it would be a massive, unqualified win).  If we ever decide to do any templating on these functions, we'll have to pull them back into header files, for example.
This break location was also chosen because it has the best chance of insulating our users from long compile times (they will mostly use the functions in the step folder).  Given our discussions in recent weeks about how we want our users to interact with OpenTurbine, it may make sense to compile to objects at that higher level interface and make most things below it be headers.


cut release 0.5.0-rc1

write changelog, bump necessary versions.

/LGTM

there should be a new folder created here https://github.com/bpfman/bpfman/tree/main/examples/config for v0.5.0 ?

there should be a new folder created here https://github.com/bpfman/bpfman/tree/main/examples/config for v0.5.0 ? or that will be created post merge ?

I think @astoycos said to do that as part of the actual release (non-rc) pr.


Hiding tab bar is a bad API that is not supported on iOS, broken on iOS 11

While it is clear why this API exists, it has never been supported on iOS. Setting a tab bar controller's tab bar to hidden is broken in many cases, and in the case of iOS 11 and safe area, it is a show stopper.
this.props.navigator.toggleTabs({
  to: 'hidden', // required, 'hidden' = hide tab bar, 'shown' = show tab bar
  animated: true // does the toggle have transition animation or does it happen immediately (optional)
});

When a tab bar is hidden in an unsupported way, the safe area does not update. @artald Saw that in an example of his. One App uses this broken API.
In iOS, there is only one sanctioned way that works as expected: Using a controller's hidesBottomBarWhenPushed and pushing that controller in a navigation controller that is enclosed in the tab bar controller. Here is how it looks:

All other ways break iOS handling of safe area insets and margins.

@DanielZlotin @yogevbd @guyca

This is blocking for Xcode 9 upgrade.

Wrong place


Feature/bootstrap upgrade

This is a continuation from the React/Redux upgrade. I'm submitting a PR now to give you the option of reviewing both together (and to save UI testing time). Included here:

all of the React upgrades
Bootstrap 4 migration
some cosmetic adjustments/enhancements which are understandably subjective and can be reverted as need. Some of these changes were designed to move the UI toward future features like letting the user save/load shapes that each have their own distinct configuration.

@jeffeb3 This PR has the previous PR inside of it, but Github is not updating the visual diff. I think this is okay, but it makes reviewing the specific changes difficult. This link seems to propose a way to fix it, but it looks like more trouble than it's worth. You may want to do a manual merge locally when you're ready just to be sure the merge goes without a hitch (vs doing it from Github). Anyway, LMK if you run into trouble when the time comes.
https://makandracards.com/makandra/13043-force-github-pull-requests-to-update-the-diff-against-its-target-branch

I have created a new, cleaner PR that doesn't have these issues.


#1246 fix

@vadmeste hello. I made changes what did you say about.

@vadmeste @harshavardhana @nitisht made new PR because recreate fork for fresh minio version.


Multibyte utf-8 characters are urldecoded incorrectly

Multibyte utf-8 characters are urldecoded incorrectly.  I'll submit a pr to fix this shortly

Here's an example for testing this:  %F0%9F%98%83 should decode to '😃'

Added the fix to my fork, seems to work great!
Now my home network's mini-chatroom has emoji support. 😎 Thanks!


Remove extra feature flags in merkle proof example

After #148 is merged, we now have a fix that enables removing this hack from the example.

Revisit to check if it is still relevant @alexfertel

@alexfertel I just checked and I think we can close this one, unless we want to remove the std feature flag on the example


Uncaught TypeError: Cannot read property 'remove' of undefined

[Enter steps to reproduce:]
Running on OSX Mojave

cmd+i
esc

Atom: 1.41.0 x64
Electron: 4.2.7
OS: Mac OS X 10.14.6
Thrown From: script package 3.25.0
Stack Trace
Uncaught TypeError: Cannot read property 'remove' of undefined
At /Users/johnsonmerrell/.atom/packages/script/node_modules/atom-message-panel/lib/MessagePanelView.js:189

TypeError: Cannot read property 'remove' of undefined
    at ScriptView.MessagePanelView.remove (/packages/script/node_modules/atom-message-panel/lib/MessagePanelView.js:189:30)
    at ScriptView.detach (/packages/script/node_modules/jquery/dist/jquery.js:5357:15)
    at ScriptView.removePanel (/packages/script/lib/script-view.js:89:10)
    at Object.closeScriptViewAndStopRunner (/packages/script/lib/script.js:161:21)
    at HTMLElement.coreCancel (/packages/script/lib/script.js:92:33)
    at CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:349392)
    at KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:1252536)
    at KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:1248670)
    at WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:284598)

Commands
     -0:11.3.0 editor:consolidate-selections (input.hidden-input)
     -0:11.3.0 core:cancel (input.hidden-input)
     -0:11.1.0 editor:consolidate-selections (input.hidden-input)
     -0:11.1.0 core:cancel (input.hidden-input)
     -0:10.9.0 editor:consolidate-selections (input.hidden-input)
     -0:10.9.0 core:cancel (input.hidden-input)
     -0:10.7.0 editor:consolidate-selections (input.hidden-input)
     -0:10.7.0 core:cancel (input.hidden-input)
     -0:10.6.0 editor:consolidate-selections (input.hidden-input)
     -0:10.6.0 core:cancel (input.hidden-input)
     -0:10.4.0 editor:consolidate-selections (input.hidden-input)
     -0:10.4.0 core:cancel (input.hidden-input)
     -0:09.8.0 editor:consolidate-selections (input.hidden-input)
     -0:09.8.0 core:cancel (input.hidden-input)
     -0:03.2.0 editor:consolidate-selections (input.hidden-input)
     -0:03.2.0 core:cancel (input.hidden-input)

Non-Core Packages
anodyne-dark-syntax 0.2.1
atom-material-syntax 1.0.8
atom-material-ui 2.1.3
autocomplete-python 1.16.0
Hydrogen 2.13.1
jackhammer-syntax 1.1.0
minimap 4.29.9
monokai 0.24.0
platformio-ide-terminal 2.10.0
railscast-theme 0.4.0
script 3.25.0
spacetravel-syntax 0.0.0

I got the same error.

Got the same error on attempts to close Script window.

Open a .py file
ctrl+shift+B to run the Python script
Try to close Script window. This and any subsequent attempt to close Script produces the error.

Atom: 1.41.0 x64
Electron: 4.2.7
OS: Debian GNU/Linux
Thrown From: script package 3.25.0
Stack Trace
Uncaught TypeError: Cannot read property 'remove' of undefined
At ~/.atom/packages/script/node_modules/atom-message-panel/lib/MessagePanelView.js:189

TypeError: Cannot read property 'remove' of undefined
    at ScriptView.MessagePanelView.remove (/packages/script/node_modules/atom-message-panel/lib/MessagePanelView.js:189:30)
    at ScriptView.detach (/packages/atom-toolbar/node_modules/jquery/dist/jquery.js:5357:15)
    at ScriptView.removePanel (/packages/script/lib/script-view.js:89:10)
    at Object.closeScriptViewAndStopRunner (/packages/script/lib/script.js:161:21)
    at HTMLElement.scriptCloseView (/packages/script/lib/script.js:94:39)
    at CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app/static/<embedded>:11:349392)
    at CommandRegistry.dispatch (/usr/share/atom/resources/app/static/<embedded>:11:347867)
    at ScriptView.close (/packages/script/lib/script-view.js:99:19)
    at /packages/atom-toolbar/node_modules/space-pen/lib/space-pen.js:220:36)
    at HTMLDivElement.dispatch (/packages/atom-toolbar/node_modules/jquery/dist/jquery.js:4435:9)
    at HTMLDivElement.elemData.handle (/packages/atom-toolbar/node_modules/jquery/dist/jquery.js:4121:28)

Commands
     -0:22.8.0 editor:move-to-end-of-screen-line (input.hidden-input)
     -0:22.6.0 editor:newline (input.hidden-input)
     -0:16.4.0 intentions:highlight (input.hidden-input)
     -0:16 script:run (input.hidden-input)
     -0:11.2.0 script:close-view (atom-workspace.workspace.scrollbars-visible-always.theme-atom-material-syntax.theme-atom-dark-ui)

Non-Core Packages
atom-beautify 0.33.4
atom-history 1.0.8
atom-keyboard-macros 0.12.1
atom-material-syntax 1.0.8
atom-toolbar 0.1.6
busy-signal 2.0.1
git-history 3.3.0
intentions 1.1.5
linter 2.3.1
linter-shellcheck 1.6.0
linter-ui-default 1.8.0
markdown-preview-enhanced 0.17.0
script 3.25.0
sequential-number 0.5.0
split-diff 1.6.1

Updated Script, in 10 seconds faced this bug.
 You have a right to feel frustrated but there's no need for this kind of talk here. #1550

@jmiskinis  this could be easily fixed by just reverting changes to previous working version

I found the same error in #1222
The error occurred due to the atom-message-panel package version update.
The remove method of the MessagePanelView class in the atom-message-panel package appears to have been added.
The temporary way to avoid the problem is the same as before.
Open the package.json file, modify the atom-message-panel version to 1.2.7, and then npm update.
"atom-message-panel": "1.2.7"

@neur0hak This fixes the error on the first run. But Script fails to run afterwards.

Got the same problem! :(

How to fix? :(

I found the same error in #1222
The error occurred due to the atom-message-panel package version update.
The remove method of the MessagePanelView class in the atom-message-panel package appears to have been added.
The temporary way to avoid the problem is the same as before.
Open the package.json file, modify the atom-message-panel version to 1.2.7, and then npm update.
"atom-message-panel": "1.2.7"

the solution indeed worked, but I have to run "apm clean" "apm install" instead of npm update...
(I'm on mac)

@jmiskinis this could be easily fixed by just reverting changes to previous working version

To do that: apm install<EMAIL_ADDRESS>Worked for me!

Same problem on Windows 10

The following steps worked for me:

download version 3.5.0 of jquery.js from this link https://code.jquery.com/jquery-3.5.0.js

replace the jquery.js file in the following folder:
~/.atom/packages/script/node_modules/jquery/dist/jquery.js

restart atom

@ongbuntu Thank you! That worked for me too!

@ongbuntu Thank you! That worked for me too! (Windows 10)

You are welcomed. Glad it helps.


2.1 incompatibility

I'm getting the error
TypeError: handler.run is not a function

when running the latest beta release 0.6.0-beta.4 with Ember 2.1. The error seems to be caused by this line - not sure whether it's actually related to 2.1 but it seems to work with 2.0.

closed by https://github.com/Vestorly/torii/pull/232 + https://github.com/Vestorly/torii/commit/1fec0d2472a7933a888785c7138fa647b5c2ec92. Published as 0.6.0-beta.5. Thanks Marco! Let me know if the issues persists.

I'm seeing a different error now:
TypeError: application.has is not a function

That seems to be caused by this line. I guess the correct method in 2.1 is hasRegistration?
Do you want me to create a new ticket  or will you reopen this one?

@mixonic Made a pull request that should fix this #234


add API workflow to derive WMO RA from geometry

User story
As the wis2box UI admin, I would like to have access to API workflow to be able to derive a WMO RA from a station location (geometry).
RA geometries: https://github.com/OGCMetOceanDWG/wmo-ra/blob/master/wmo-ra.geojson
Acceptance criteria

[ ] API provides endpoint
[ ] API Swagger update
[ ] UI admin integration

Definition of done

[ ] unit/functional tests added/updated
[ ] documentation updated
[ ] live demonstration provided

Implemented in https://github.com/wmo-im/wis2box-api/pull/26


Allow quick create with no name

Create a new field slip
Ensure that no name is specified
Click 'Quick Create'
On main it should take you to the Create Observation page with a flash error
On this branch it should just create the observation with the name "Fungi"

coverage: 93.414%. remained the same
when pulling cf91243f057d814ae9574e96b20f292da8d6a589 on njw-quick-fungi-obs
into d0f07889999ecb76afb67673da5b58aeb353b199 on main.

Also moved the save edit/create button up on the observation form.

@JoeCohen I'm a bit nervous about moving the edit/create button for observations just because I'm moving user's cheese, but I like it a lot better on the. mobile app.  Thoughts?


Fix mansonry articles change to weird widths

Edit: same error occures with chrome 83

Fixed with v2.8.2


⚠ Account has degraded performance

In 564f0ed, Account (https://account.wrk.com/health) experienced degraded performance:

HTTP code: 200
Response time: 192 ms

Resolved: Account performance has improved in 90f80dd.


[document] create a detailed article on playlatam

here's a useful article
https://gist.github.com/1637464#file_tutorial.rst

http://playlatam.wordpress.com/2012/02/09/play-framework-on-the-cloud-made-easy-openshift-module/


No url found for google or bing

No matter what keywords are used, it always says == 0 out of 0 crawled images urls will be used for Google and Bing engine. Only Baidu works. Any clue?

@qilinli It may be that you not allowed the phantomjs.exe to access the internet.


Fix bugs reported by sonarq in validate_data

Addresses the bugs reported in validate_data by sonarq, see here

OK, forget about it - started the branch not from main but from another unmerged branch.


Fix e2e status checks

Tollerate nil status fields without panicing
Add kind and yaml in parent predicates
Remove unused monorepo sync predicates

/hold

/lgtm
/approve

/unhold
Saw some minor issues after i pushed. Fixed now.

/lgtm


Vitis AI Compiler for Caffe model error #5

Hi everyone,
I'm a student at Scuola Superiore Sant'Anna in Pisa.
I'm trying to accelerate a network model on a ZCU102 ultrascale+ using Vitis-AI tools v1.2.
The network model has multiple input tensors with shape (1, 64, 1, 80). I can successfully quantize the model, but when launching the vai_c_caffe command, it reports:
[VAI_C][Error] The data type of [SCNN_D_1_sum]'s inputs are not equal, input 0 has type QInt8, while input 1 has type Float32
[VAI_C][Error] Infer shape for current layer [SCNN_D_1_sum] failed.
This layer just execute a Sum Eltwise operation between blobs.
Could anyone explain me the error and how to fix it, if it is possible?

Hi, @JerrySciangula
Could you enable the '--dump' option with value 'all' during the compilation and share the quant.info file? Thanks very much.

Hi, @Mookel. Here you have the quant.info file. It is in zip file because of the file sharing tool of Github.
quant.zip

Hi, @JerrySciangula
I checked the quant.info and found all the inputs has not been quantized, actually I don't know why:-). But this is why the compiler complained about that.

Thank you very much, @Mookel


d_a_obj_table OK

project setup seems to have broke for some reason, not your fault. will have to look into it

I think I've addressed all current feedback with the exception of the possible fake match for the event::reset() call and the return value for the static create. Open to suggestions for either of those two.


itsm climc

这个 PR 实现什么功能/修复什么问题:
itsm climc
是否需要 backport 到之前的 release 分支:
NONE
/cc @zexi
/area climc

Codecov Report

Merging #7034 into master will decrease coverage by 2.15%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #7034      +/-   ##
=========================================
- Coverage    6.27%   4.12%   -2.16%
=========================================
  Files         482     278     -204
  Lines       92972   64702   -28270
=========================================
- Hits         5835    2667    -3168
+ Misses      86738   61873   -24865
+ Partials      399     162     -237

Flag
Coverage Δ

#aFlag
4.12% <ø> (-2.16%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/appsrv/response.go
66.17% <0.00%> (-2.95%)
:arrow_down:

pkg/cloudcommon/db/infraresource.go

pkg/cloudprovider/objectstore.go

pkg/util/printutils/printgetter.go

pkg/apigateway/clientman/clientman.go

pkg/baremetal/manager.go

.../monitor/alerting/conditions/suggestrulereducer.go

pkg/cloudcommon/db/lockman/etcd.go

pkg/monitor/alerting/scheduler.go

pkg/keystone/driver/cas/class.go

... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af2ff5...36408ab. Read the comment docs.


Dockerize this app

I'm a big fan of Docker, because it provides a universal development environment and thus prevents the infamous "but it works on my machine" problem.

See #5


forceHeight: false breaks skrollr in webkit browsers

Has anyone experienced this problems? Skrollr is working fine in Firefox, but not in Safari and Chrome, when forceHeight: false is set. It might be a css problem, just can find it.
Skrollr itself does not give any errors in Safari or Chrome, it just doesnt work.
Anyone know any good ways of debugging this?

Anyone know any good ways of debugging this?

usually mobile issues can be debugged with emulation in Chrome https://github.com/Prinzhorn/skrollr/wiki/Tips#debugging-mobile

Found the problem. Somewhere on body and html, overflow-x: hidden was set.


[HOTFIX] Added and fixed specifications in class PermissionsHandler

Added @ NonNull and @ Nullable
Added specifications for Context parameters
Changed specifications in method checkPermissions.
Added check if permissions[] is null

I think I improved the code now...
I also realized that the method isGranted was supposed to be called isNotGranted, instead...
So I've been editing something in there, as well...


build(IntelliJ): turn on checkstyle.scan-before-checkin

Small tweaks to how CheckStyle is setup in gradle and IntelliJ.
The most impactful one is that scan-before-checkin.
I was tempted to see if we could get rid of the samedir property, but that princess is in another castle.

* What went wrong:
Execution failed for task ':engine:checkstyleJmh'.
> Unable to store input properties for task ':engine:checkstyleJmh'. Property 'configProperties' with value '{samedir=extension 'checkstyle' property 'configDirectory'}' cannot be serialized.

fixed. There was some groovy/gradle typing hijinks going on that threw a wrench in the first attempt.


[bindings] Add bindings for rpy_utils

As requested in https://github.com/jrl-umi3218/SpaceVecAlg/issues/42 (cc. @mmurooka )

@gergondet Thank you!


Add folder for stack usage calculations

There should be a distinct difference between stack memory when using result values and exceptions. Exceptions utilize no additional stack memory because no information about the air type is stored in any frame. With result types each frame, that ops into using result types or use a function that uses result types ,will need to have at least some memory allocated to storing the air type or discriminant.

Note that there is going to be a crossing point because exceptions do utilize stack memory to run the unwinding algorithms. This could vary depending on the complexity of the object from, but my guess is that it's fixed in size.


Add a redirect method to HTTP::Server::Context

I write web services in Crystal mostly using the standard library and with the exception of routing, I'm content with the tools it provides. However, one simple thing I find missing is a redirect method for handling HTTP redirects. Another standard library I like working with is Go, and they provide this function on their http/server package.
As a solution I end up opening the HTTP::Server::Context class and adding this method myself. Here are some other common implementations of this method from the ecosystem:

Athena
Kemal
Grip

We already have a respond_with_status method in the response type, so adding a redirect method which allows setting a URL and a HTTP status would be great.
I should also point out that aside from being a Crystal user, I'm interested in writing tutorials for new users, and not having to define the redirect method explicitly in a "Simple Web Application with Crystal Stdlib" tutorial would be much better.

An implementation is already proposed in #10412.

Looking at #10412 again, I think the documentation may need some polishing.
Perhaps we should also look at the API/supported features and compare it with prior art.

The Go implementation implicitly expands relative paths. I'm not sure that's really necessary. You can easily achieve that by explicitly calling URI#resolve at the call site.
It also writes a short response body for GET requests. This might be useful. However I would wish for some customization options.
A related question is whether there should be a way to prevent closing the response or injecting a custom body (for example via a yielding overload)?
The status parameter could perhaps support numerical values as well.

And it's potentially harmful because this implementation forbids using this redirect mechanism with 201 Created

My thinking there was you're explicitly saying it be a redirect, e.g. by using RedirectResponse type, or #redirect method. Because of this using a non redirect status would be invalid. If you want to use location header as part of a 201 Created you are no longer doing a redirect and thus should just set it manually versus using this type/method.

I mean, if you need it to be that customizable why not write to the response by hand in that case? After all this is a convenience method for the most common scenario. And I think the most common scenario is... (whatever other languages are doing here)

I suppose the question is whether this method should be expected to validate its arguments or not. I think it's not necessary and just avoidable overhead. Of course, it's nice to produce a nice error message to alert the user about a problem. But this still isn't very useful.

I see that this has already been added to 1.6.0 milestone in #10412. Thank you Crystal team :heart:!

https://github.com/crystal-lang/crystal/pull/10412 was reverted in #12517


Custom annotations for folders, subfolders, trash, starring

We’re working on folder support for Epona.
We’ve been thinking about making threads for folders, and have links to other threads for sub folders, with threads for the pages we have in the folders.
We’ve also considered having special folders for starred items (with a link to the pages and folders that have been starred), and a trash (for links to items that have been added to the trash).
The problem is that when we have multiple attributes (item is in this folder, and starred, and trashed), it doesn’t make sense to have this kind of hierarchy.
Would there be a way to make annotations that would be compatible with how you see the path forward for Textile?

I think you're on the right path with the idea of having threads for a user's starred items. These are for the user, rather than something like a star annotation in a shared thread. In that sense, it is less like an annotation and more like a categorization.
I don't quite understand the trash bin. You could visualize the "ignored" content in a thread.


Make valid JSON example

Bad comma, no cookie.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-2" git@github.com:mrwacky42/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Current coverage is 51.22%

Merging #1632 into master will decrease coverage by -6.75% as of 64700cc

@@            master   #1632   diff @@
======================================
  Files          122     122
  Stmts        10683   10683
  Branches       838     747    -91
  Methods          0       0
======================================
- Hit           6193    5472   -721
+ Partial        838     747    -91
- Missed        3652    4464   +812

Review entire Coverage Diff as of 64700cc

Uncovered Suggestions

+0.30% via .../driver/s3-aws/s3.go#732...763
+0.28% via .../driver/s3-aws/s3.go#268...297
+0.21% via .../driver/s3-aws/s3.go#884...906
See 7 more...

Powered by Codecov. Updated on successful CI builds.

Looks good, thanks. Could you please amend your commit to include a Signed-off-by line?

I really can't be bothered right now. If you don't want help from people who are reading docs and notice problems and fire off a quick fix in the GitHub online editor, you should probably disable that feature.

This comma deletion sponsored by WTFPL.


Make namespace unique check works with multisites

This is already applied to older versions of the cms.
#5458

Coverage remained the same at 82.392% when pulling 1eba556a726a41ed22438a12c30733bd7ca27efd on razisayyed:develop into 4e2ac3e73845fa0a2970247996ddd6fe16408fc0 on divio:develop.

Could you add a test?

@czpython @razisayyed yeah, my bad: I did not forward ported this
I can eventually prepare a forwardport + test


there is no preview

you providing commands available in preview...but how to get this preview? no link on the page, it's not on github, and checking find-module MicrosoftTeams -AllowPrerelease do not find it either...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 26362d70-cfce-2eea-077b-4aaa50f92e8b
Version Independent ID: f52dcd4d-4f58-05c4-11b0-f1e3c95f4d89
Content: Teams PowerShell Overview
Content Source: Teams/teams-powershell-overview.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@Lelivienne  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@Lelivienne hello, the table has a pretty straightforward note "Prior to 1.0 release only". The latest version that is before 1.0 is 0.9.6 and you should run the following command in order to install it Install-Module -Name MicrosoftTeams -RequiredVersion 0.9.6

@Lelivienne Please let us know if the information given by @dplotnikov  worked for you and if you need further assistance

@Lelivienne We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


imu = MPU6050('X'), what is 'X'

Hello,
Could anyone explain how to define the I2C pin and id when call the MPU6050 function? I am trying to use MPU6050 on ESP32 in MicroPython. my i2c pin are 4 and 5 and the i2c address is 0x68.
thx

Please see the docs. It represents the X or Y side of a Pyboard 1.x, but for other platforms (I quote):

an initialised I2C object may be passed.

Thank you @peterhinch for the information


METAMODEL-244

I wanted to give a shot at fixing METAMODEL-244 so here goes.
I made available a strategy interface for column naming, which I implemented in a few different ways, and created a default delegating strategy as well. It's implemented in the 'fixedwidth' and 'csv' module for now.
I also managed to fix something which I've encountered a few times before, but newer got around to report as an issue: The fact that it is annoying that you sometimes get duplicated column names for CSV files and such. That should rarely be allowed, so I implemented a strategy for renaming those duplicated column names automatically.
I'd like a review if anyone is willing. If you agree that the approach taken is good I will happily also apply it in the excel module. It would be quite easy I think actually.

Also implemented this for CSV module now. And added a 'session' abstraction to encapsulate the state that is needed while applying column names for a table.

@kaspersorensen Do we need all the ColumnNamingStrategy interfaces and implementations stuff to just get the names of the columns. It seems like kinda over-engineering to me.

Code mostly looks good. But it is quite a bit more complicated than I expected.

Changed as per review remarks. What do you think now?

Looks good! Maybe I'd let the test be DelegatingIntrinsicSwitchColumnNamingStrategyTest. That it is the default is maybe less relevant for the test than what it really is testing. But that's up to you, not a deal breaker for me.

Renamed it. Will merge it now then.

Yep. A bit "dangerous" to still get it with ColumnNamingStrategies.defaultStrategy(), but nevermind.  :)


TN-3157 potential fix; enhance trigger states logging

TN-3157 happened due to a failure to persist the correct visit month in a trigger_states transition.
This PR includes a one line code change (shifting the db.session.commit() out of a first month only clause in initiate_trigger(), so we always persist new or changed trigger_states rows from that function), as they should always be saved, and may potentially be the source bug behind the issue.
All other changes are to better capture trigger_states transitions and persistence in a manner that should be easier to locate in the logs, should the problem persist.

Hello @pbugni! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/test_trigger_states.py:

Line 84:80: E501 line too long (82 > 79 characters)


Authentication using github

As discussed I will be working on the frontend of this task and @shaksham08 will be working on the backend of the same.

ok @rushi-173 What's the status ?

@rushi-173 Since you have not finished this task so I am reassigning to somebody else .

@ganshul34
ETA given : Thursday(10/02)


Make AddSignalR fully idempotent

There are still a couple things that aren't TryAdded:
https://github.com/aspnet/SignalR/blob/db99baac354d08196a9e64790fa552eb14e932d5/src/Microsoft.AspNetCore.SignalR/SignalRDependencyInjectionExtensions.cs#L38-L39
We'll need to use TryAddEnumerable for the second one since we want to add it if HubOptionsSetup hasn't been registered yet, even if another IConfigureOptions<HubOptions> has been registered.

https://github.com/aspnet/SignalR/commit/8be051ce34319c9aac7cd55340c28642c25d0fbd


Make creator serializable

Creator is instantiated with lambdas. We have been using hollow in pipeline environments and so being serializable by either the Java Serializer or others (like Kryo) need lambdas to be serializable as well. I am not sure if this change has any effect in hollow itself so feel free to reject it, but this would help my experience with Hollow right now

@Sunjeet @stevenewald i was wondering if either of you could take a look at this?


Improve query generation when querying against Dictionary

When a Linq query is comparing against Dictionary<K,V>.Contains(KeyValuePair<K,V>) or dictionary[key] == value, we should be able to optimize the comparison by generating the dictionary for the comparison and then converting that the json.
Example:
Session.Query<Doc>().Where(d => d.Guys.Contains(new KeyValuePair<string,string>("foo", "bar")))
should result in a comparison json of { "Guys" : { "foo" : "bar" } }.
Right now we give {"Guys": [{"Key":"foo", "Value":"bar"}]} instead
Per Jeremy's pointer this can probably be done using http://jasperfx.github.io/marten/documentation/documents/advanced/customizing_linq/

So I'm working on this and I think there's a small problem in the WhereFragment code with regards to the operator I want to use. Specifically, I want to use the ? operator to check if a top-level text element exists in a jsonb object, but the escaping in the WhereFragment is obliterating my first ? symbol.
Specifically I want to write the sql query {fieldLocator} ? ?, where fieldLocator is the found field and the second ? is my key parsed from the expression.
I think we should change the token used to signal a variable in the query DSL, especially given that more of the json operators contain special symbols like |, ?, @ and &.

Going to close this now. Feel free to open a new issue if you think the other issues you ran into that were "hairy" need to be discussed further.


python3Packages.devolo-plc-api: init at 0.6.3

Motivation for this change
Python module to interact with Devolo PLC devices
https://github.com/2Fake/devolo_plc_api
This seems to be the replacement module of Home Assistant's devolo_home_control integration.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 146690 run on x86_64-linux 1

2 packages built:

python38Packages.devolo-plc-api
python39Packages.devolo-plc-api


Safe to delete Intermediate folder?

CARLA version: 0.9.15
Platform/OS: Ubuntu 22.04
Hey, I was running make package to get a new distribution with a new map I created in RoadRunner. Unfortunately, I ran out of memory. Is it safe to delete the content from the "Intermediate" folder in Carla under carla/Unreal/CarlaUE4/Intermediate?

Yes, but you could interfere with the package build process. How much memory do you have available?


Bump tendermint-rs crates to v0.26

This release removes the need to pin to specific versions, allowing the requirements to shift to ^.
It includes some changes related to the elimination of tendermint::abci, namely Gas is now aliased to u64, Data is aliased to Vec<u8>, and Hash uses tendermint::Hash.
cc @tomtau

plus MSRV bump is needed https://github.com/cosmos/cosmos-rust/pull/299/commits/ed14ea02e7711cb0a277428f4ae535552ac45d55


The loading doesn't show on material dashboard

The loader failed to be displayed on material dashboard. Not sure why, I added all code in all parts of the application, I even get a loading output console on each request but the component never shows up, no errors or warnings or any other.

I am having the same issue as reported by hackerunet. I can see console log for startloading() and stoploading() but loadingStatus seems to be not changing, any idea why

I also experienced this in a project, and it appears to be related on event handling because the loading variable holds the right value in the ts code but in the template it is not updated.
The best solution I found is to control the loading screen display using the ngAfterViewInit:
  constructor(private loadingScreenService: LoadingScreenService,
              private _elmRef: ElementRef,
              private _changeDetectorRef: ChangeDetectorRef) {
  }

  ngAfterViewInit(): void {
    this._elmRef.nativeElement.style.display = 'none';
    this.loadingSubscription = this.loadingScreenService.loadingStatus.pipe(debounceTime(this.debounceTime)).subscribe(
      (status: boolean) => {
        this._elmRef.nativeElement.style.display = status ? 'block' : 'none';
        this._changeDetectorRef.detectChanges();
      }
    );
  }

You can see all changes in this commit: https://github.com/nezhar/snypy-frontend/commit/7e17a8dad216e556c084593a569f9debb1b66a61


Support for Vite.js

Describe the bug
When using the next generation esm bundler vite, I'm getting this error:
 > node_modules/y-prosemirror/src/lib.js:1:26: error: No matching export for import "ProsemirrorMapping"
    1 │ import { updateYFragment, ProsemirrorMapping } from './plugins/sync-plugin.js' // eslint-disable-line
      ╵                           ~~~~~~~~~~~~~~~~~~

I think this is because ProsemirrorMapping is a type generated in the build process. Since vite is very strict and uses the source files, it can't find this export. Here is a comment from evan you about that.
Do you have any idea how to fix that on your side?
To Reproduce

import y-prosemirror in a vite project
start dev server
See error

Expected behavior
It should not throw an error

I experienced the same problem. A fix would be great, thanks.

I provided a PR that fixes the issue.

Fixed this in<EMAIL_ADDRESS>

Thanks @dmonad Your patch works.


Logging Validator not working

I'm trying to implement LoggingConfiguration. I noticed the validators aren't being called.
Below is my example code:
    @GET
    @Produces(MediaType.APPLICATION_JSON)
    public String configLog()
    {
        final Logger log;
        final LoggingConfiguration lc;

        log = Logger.get(ServiceModule.class);

        lc = new LoggingConfiguration();
        lc.setCompression(null);

        log.info("%s", lc.getCompression());

        return "ok";
    }

Validator usage for getCompression():
https://github.com/airlift/airlift/blob/fd85d8282658e758cd79cbcc6a1890bd7c947d73/log-manager/src/main/java/io/airlift/log/LoggingConfiguration.java#L96
This should cause an error right? Since compression is set to null.

These annotations are not part of JLS and are not enforced by Java runtime directly.
They are used by "bean validation".


Enable running C# tests on mac in run_tests.py

official mono installation is 32-bit so this required switching default C# build on mac to 32-bit.
based on #4777.

Tests seem reasonably green. With interop tests we have some unrelated problem.


separate typing requirements

What does this PR do?
separate testing requirements for typing

Before submitting

[ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?
Make sure you had fun coding 🙃

removed all particular ignores as they were not validations as almost whole package have been ignored :(


BlobService.put_blob needs timeout parameter

It seems like sometime my socket connections from a Linux Azure VM to Azure Storage are stalling.  Can we add a timeout parameter to pub_blob like some of the other functions?
Traceback below:
Unexpected upload error: <class 'socket.error'>
Traceback (most recent call last):
  File "GetHistory.py", line 81, in getAndUploadHist
    _bs.put_blob('thistory',filename,sz ,x_ms_blob_type='BlockBlob')
  File "/usr/local/lib/python2.7/dist-packages/azure/storage/blobservice.py", line 693, in put_blob
    self._perform_request(request)
  File "/usr/local/lib/python2.7/dist-packages/azure/storage/storageclient.py", line 143, in _perform_request
    resp = self._filter(request)
  File "/usr/local/lib/python2.7/dist-packages/azure/storage/storageclient.py", line 132, in _perform_request_worker
    return self._httpclient.perform_request(request)
  File "/usr/local/lib/python2.7/dist-packages/azure/http/httpclient.py", line 190, in perform_request
    self.send_request_body(connection, request.body)
  File "/usr/local/lib/python2.7/dist-packages/azure/http/httpclient.py", line 173, in send_request_body
    connection.send(request_body)
  File "/usr/lib/python2.7/httplib.py", line 805, in send
    self.sock.sendall(data)
  File "/usr/lib/python2.7/socket.py", line 224, in meth
    return getattr(self._sock,name)(*args)
error: [Errno 104] Connection reset by peer

Issue Migrated to https://github.com/Azure/azure-storage-python/issues/17


Slice: find v2

If slice len is zero then return false
Convert find to generic form.
If return T is nil then no items matched the predicate func

Note: I haven't found out jet how to construct a default value of T.

@duke-git please review

@duke-git please review

@donutloop。OK， have merged.


[Question] Do you see an overlap with SwiftyJSON?

Hey,
I know GH issues is not the preferred place for questions, so feel free to reply and close right after.
Currently in my project I have both SwiftyJSON/ObjectMapper + Alamofire.
I like having SwiftyJSON because I can play with the JSON response much more easily (like the meta data for exemple).
I still use ObjectMapper to map any entity my API returns (using a custom Alamofire response handler similar to https://github.com/SwiftyJSON/Alamofire-SwiftyJSON), i.e. :
        Alamofire.request(Router.ReadSchedule(from: from.stringFromFormat("YYYY-MM-dd"), to: to.stringFromFormat("YYYY-MM-dd"))).validate().responseAppJSON { (request, response, json, error) in
            if error != nil {
                ProgressHUDManager.serverError()
            } else {
                self.schedule = Mapper<Schedule>().map(json["schedule"].rawValue)!e
                self.tableView.reloadData()
            }
        }

Do you think it's fine to use both ObjectMapper and SwiftyJSON? Is there an overlap here?
Thanks!

I've been using both in a project without any problems, I have a custom Alamofire serializer for ObjectMapper similar to yours for my API calls.
SwiftyJSON comes in handy for me when a response doesn't really deserve its own class/struct, usually when you're not planning to pass the data around, or you just need look a value up quickly.
I actually created another Alamofire serializer just for SwiftyJSON usage as well, it looks something like this:
    func responseSwiftyJSON(completionHandler: (NSURLRequest?, NSHTTPURLResponse?, SwiftyJSON.JSON?, NSError?) -> Void) -> Self {
        return response(responseSerializer: Request.JSONResponseSerializer(options: .AllowFragments)) {
            JSONResponse in

            dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0)) {
                var JSONResult: SwiftyJSON.JSON? = nil
                if let obj = JSONResponse.result.value {
                    JSONResult = SwiftyJSON.JSON(obj)
                }

                dispatch_async(dispatch_get_main_queue()) {
                    completionHandler(JSONResponse.request, JSONResponse.response, JSONResult, JSONResponse.result.error)
                }
            }
        }
    }

    func responseSwiftyJSON(completionHandler: (SwiftyJSON.JSON?, NSError?) -> Void) -> Self {
        return responseSwiftyJSON({ (_, _, json, error) -> Void in
            completionHandler(json, error)
        })
    }

@kaandedeoglu Cool, we have a similar way of doing things then, thanks for taking the time to write this down!

I also don't really see a problem to using both SwiftyJSON and ObjectMapper in a project.
I also have created an Alamofire extension... shameless plug:
https://github.com/tristanhimmelman/AlamofireObjectMapper
I'd be interested to see the extensions you guys have created.

@tristanhimmelman Actually I checked AlamofireObjectMapper a while back to see we almost have identical implementations (I don't have a queue parameter)
One interesting thing I use is a serializer just for pretty printing the JSON response, it looks something like this:
extension Alamofire.Request {
    func responseDebugPrint() -> Self {
        return responseJSON() {
            response in
            if let  JSON: AnyObject = response.result.value,
                    JSONData = try? NSJSONSerialization.dataWithJSONObject(JSON, options: .PrettyPrinted),
                    prettyString = NSString(data: JSONData, encoding: NSUTF8StringEncoding) {
             print(prettyString)
            } else if let error = response.result.error {
                print("Error Debug Print: \(error.localizedDescription)")
            }
        }
    }
}

With this I can go
Alamofire.request(...).responseObject {

//Code here

}.responseDebugPrint()

and have it print without touching my main response block

@kaandedeoglu, interesting... I might add that. Thanks for sharing :+1:


Support Bundler 2.x

We'll need to update the version of bundler-audit being used:
https://github.com/rubysec/bundler-audit/issues/202
Hopefully a release is imminent. This is currently breaking most of our travis builds.

@joshpencheon was this resolved by 62d99a8df1244b46709b109a86e3edca17325def?


Exception when using a no-op look with LegacyViewPipeline

If a LegacyViewPipeline is set up to use a look and the look works out to be a no-op, LookTransform::GetLooksResultColorSpace returns "" but LegacyViewingPipelineImpl::getProcessor still tries to create a look transform and append it to the group:
if (!looks.empty())
{
    const char * inCS = dtInputColorSpace->getName();
    const char * outCS = skipColorSpaceConversions ? inCS :
                         LookTransform::GetLooksResultColorSpace(configIn, context,
                                                                 looks.c_str());
    auto lt = LookTransform::Create();
    lt->setSrc(inCS);
    lt->setDst(outCS);
    lt->setLooks(looks.c_str());
    lt->setSkipColorSpaceConversion(skipColorSpaceConversions);

    group->appendTransform(lt);

    // Adjust display transform input color space.
    dt->setSrc(outCS);
}

This causes LookTransform::validate to throw an exception "LookTransform: empty destination color space name." later.
I think it can be fixed by adding a check (at least, it works for me):
if (!looks.empty())
{
    const char * inCS = dtInputColorSpace->getName();
    const char * outCS = skipColorSpaceConversions ? inCS :
                         LookTransform::GetLooksResultColorSpace(configIn, context,
                                                                 looks.c_str());
    if (outCS && *outCS)
    {
        auto lt = LookTransform::Create();
        lt->setSrc(inCS);
        lt->setDst(outCS);
        lt->setLooks(looks.c_str());
        lt->setSkipColorSpaceConversion(skipColorSpaceConversions);

        group->appendTransform(lt);

        // Adjust display transform input color space.
        dt->setSrc(outCS);
    }
}

This is reproducible with a look like this:
  - !<Look>
    name: a
    process_space: "b"
    transform: !<GroupTransform>
        children:
            - !<CDLTransform> {slope: [1, 1, 1], offset: [0, 0, 0], power: [1.0,1.0,1.0]}

Thanks @karlhendrikse for the thorough report, I can look into it if nobody have currently started it.

That would be great @remia !  No one is working on this AFAIK.

Merged in master, and soon in v2.0.x


Implement feedback page design

I implemented the feedback page design which aids user interaction with our documentation, and made it responsive for both desktop and mobile devices


Error in response: Missing or invalid csrf_token parameter when accessing OpenRefine through API

Hi OpenRefine community,
I would like to run OpenRefine in the background and communicate with it from my app through the OpenRefine API. So far, I followed instructions outlined here: OpenRefine API
I'm running Open Refine version 3.3, and attempted to upload my files through the API both from Postman and my Python App and got the response error 'Missing or invalid csrf_token parameter'. I also found another issue raised regarding the same problem, but it was already closed.
My postman request looks like this:

Expected Behavior

I would expect the request to upload my file(s) and create a new project, as described in the documentation.
Versions

Operating System: Mac OS X cataline
Browser Version: Safari 13
JRE or JDK Version: 13
OpenRefine: 3.3

Hi @asyrul21, you will need to retrieve a CSRF token before making the request with GET command/core/get-csrf-token.
See https://github.com/OpenRefine/OpenRefine/wiki/Changes-for-3.3#csrf-protection-changes for more details about this.
Because this is not a bug and working as intended, I will close this, but feel free to comment back if you need more info. In general, questions like this should go to the user or developer mailing lists.

I've updated the wiki with a link to the CSRF docs and a warning that the API is internal-only and subject to change at any time (as you've just discovered).

Dear @tfmorris and @wetneb,
Thank you for your prompt response and action. I have managed to complete the POST request successfully.
Thanks!

Hi @asyrul21
Will you please tell me how you have passed the csrf_token in python code
Thanks in advance


worker: Log table name when NewResultMerger failed.

Usually, NewResultMerger fails when the primary key has textual columns. By logging the table name the user can more easily debug and for example reconsider the table schema or exclude it.
@alainjobart

LGTM


Add FormSection styling via className

very similar to #2271. perhaps a more "hands-off-make-everybody-happy" is a props arg that does a {...props} on the <div ... />, so you can use { id: ..., className: ..., style: ...}.
one-off'ing property support probably isn't a super scalable concise approach?  just thinkin out loud :)

It seems like what really needs to happen here is that it should pass along all props that are not part of the API.

Fix published in v6.4.0.


React Ratings component missing unique key for loop

It looks like the React version of the Ratings component is throwing an issue regarding a missing unique keys.
Best I can tell, there is a key set, but perhaps it's not unique?

https://github.com/skeletonlabs/skeleton/blob/next/packages/skeleton-react/src/lib/components/Rating/Rating.tsx#L83

If someone picks this up before me - please let me know if you have any issue replicating this issue in the dev environment.

I'll try to reproduce it in my local setup. Will investigate it further if the issue happens for me, else I will write here if I don't get it going.

Thanks Long! If you have any trouble I can circle back to this one tomorrow.

Thanks Long! If you have any trouble I can circle back to this one tomorrow.

I'm certainly no expert in React (never built anything with it, in fact) but I think the PR has some potential to solving the issue. I'm having the same key issue when testing in my local setup, but for Popover so that might be worth checking out as well.

@phamduylong saw the PR first, but that makes total sense. I'm new-ish to React as well and didn't think about the empty element being taken into account here.
As per Popovers, feel free to sent a follow up for that as well if you wish to take a look. Otherwise we can log that and get that asap. Thanks for the heads up!


[$500] Status with custom time doesn't work

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.16-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dylanexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1703354936560399?thread_ts=1703016500.538419&cid=C049HHMV9SM
Action Performed:

Access Profile > Status
Add any custom status
Click on Clear After > Custom > Date
Click Save

Expected Result:
It should keep the date you select and save.
Actual Result:
Didn't keep my selected date, and I was unable to save the status
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/a38ce14e-1168-4925-b5c9-350827b7afdf

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019c1da8c2e9f0e2ec
Upwork Job ID:<PHONE_NUMBER>687736320
Last Price Increase: 2023-12-24

Contributor details
My account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0169127a83f9114c17
Proposal
Problem Statement:
When attempting to set a custom date under "Clear After" within "Access Profile > Status" and saving, the selected date is not retained, leading to an inability to save the status with the expected date.
Root Cause Analysis:
Upon analysis, the issue appears to stem from the failure to persist the selected date in the "Clear After" field when saving the status. This indicates a breakdown in the data persistence mechanism associated with custom dates in this particular section of the application.
Proposed Solution:
To rectify this issue, I propose inspecting the data storage and retrieval mechanism linked with the "Clear After" functionality under the "Access Profile > Status." This would involve:

Reviewing the code logic governing the handling of custom dates during the save operation.
Identifying any errors or omissions in the data persistence flow related to storing and retrieving selected dates.
Implementing necessary adjustments to ensure the proper storage and retrieval of custom dates when saving the status.

Alternative Solutions Explored:
Exploring alternative data storage approaches or utilizing client-side storage mechanisms was considered. However, the primary solution centers around rectifying the data persistence issue within the existing storage infrastructure to ensure the accurate saving of selected dates.
I'm prepared to delve into the codebase and address this data persistence issue promptly to ensure the accurate retention and saving of custom dates within the "Clear After" functionality of "Access Profile > Status."
Please note that any proposed changes will be thoroughly tested across supported platforms (MacOS: Chrome / Safari) to guarantee the resolution's effectiveness.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0169127a83f9114c17

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0169127a83f9114c17

Proposal
Please re-state the problem that we are trying to solve in this issue.
Setting a custom clear status date clears the default/selected date and time.
What is the root cause of that problem?
Because the date picker is not wrapped with InputWrapper in the SetDatePage component, the clear after date value can't be accessed inside the submit function.
What changes do you think we should make in order to solve the problem?
Wrap the date picker in an InputWrapper.
<InputWrapper
    InputComponent={DatePicker}
    inputID="dateTime"
    label={translate('statusPage.date')}
    defaultValue={DateUtils.extractDate(customClearAfter)}
    minDate={new Date()}
/>

What alternative solutions did you explore? (Optional)
N/A

Please re-state the problem that we are trying to solve in this issue.
When attempting to set a custom date under "Clear After", the selected date is not saved or not worked
What is the root cause of that problem?
In the SetDatePage component, there seems to be an issue related to the date picker not being encapsulated within an InputWrapper. This omission is causing difficulty in accessing the cleared date value within the submit function. To elaborate, when a date is cleared, the absence of an InputWrapper around the date picker prevents the submit function from effectively retrieving the cleared date value.
What changes do you think we should make in order to solve the problem?
To resolve this issue, you can either utilize <InputWrapperWithRef/> in place of <DatePicker/>, or you can substitute <DatePicker/> with the following code on here:
<InputWrapperWithRef>
  <DatePicker />
</InputWrapperWithRef>

Video:
https://drive.google.com/file/d/1UScOd8VJi1v-e6XqnywjCjEqL0E4PyXb/view?usp=sharing

@eVoloshchak can you please review the proposals and comment (or pick)

@anmurali, this one can be closed I think.
The bug was resolved by https://github.com/Expensify/App/pull/33525 and @rayane-djouah's proposal will be/is discussed on Slack


Remove Wordlist::Runners

Remove the Wordlist::Runners CLI classes and bin script. The wordlist library should be a pure-library. Other CLI functionality could be moved into ronin-wordliss.

Removed in 8ee7f168986ead4f48501d44e3db892a515ba6be.


SScript is not available, thanks to everyone for their support error

Describe your problem here.

how to fix this error?
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

please help

I’m here to lend a hand!
This issue is popping up quite a bit, but no need to worry because it’s a simple fix!
All you need to do is download the previous version of SScript. If you’re using PE0.7.3, you’ll want to grab SScript 7,7,0 You can find the older versions right here!

Once you downloaded what version you wanted, move the file to the source code (don't extract) and leave it there then open CMD or Windows PowerShell and type:

haxelib install SScript 7,7,0.zip

or what version you downloaded
and there you have it!
if you have any problems feel free to reply back :D

mmmmm. how

oh nvm I had to manage to fix the problem without windows powershell thank you

not working

Hi again!
It looks like you may need to reinstall hxdiscord_rpc.
And it's a fast process

haxelib git hxdiscord_rpc https://github.com/MAJigsaw77/hxdiscord_rpc.git

Just enter this in CMD or Windows PowerShell
and that's all you need to do to install it!

oh nvm I had to manage to fix the problem without windows powershell thank you

how

I’m here to lend a hand!
This issue is popping up quite a bit, but no need to worry because it’s a simple fix!
All you need to do is download the previous version of SScript. If you’re using PE0.7.3, you’ll want to grab SScript 7,7,0 You can find the older versions right here too!
https://github.com/CobaltBar/SScript-Archive/tree/main/archives
Once you downloaded what version you wanted, move the file to the source code (don't extract) and leave it there then click on File on the top left of file explorer and open Windows PowerShell and type:

haxelib install SScript 7,7,0.zip

or what version you downloaded and there you have it!
if you have any problems feel free to reply back :D

still not working

source/psychlua/CallbackHandler.hx:55: characters 18-33 : Class<llua.Lua_helper> has no field sendErrorsToLua
export/debug/windows/haxe/ApplicationMain.hx:153: characters 5-36 : ... Called from macro here
source/psychlua/CallbackHandler.hx:55: characters 41-46 : Class<llua.LuaL> has no field error
export/debug/windows/haxe/ApplicationMain.hx:153: characters 5-36 : ... Called from macro here
E:/Downloads in E/HaxeFlixel/haxe/lib/flxanimate/3,0,4/flxanimate/frames/FlxAnimateFrames.hx:142: characters 21-27 : Field concat should be declared with 'override' since it is inherited from superclass flixel.graphics.frames.FlxAtlasFrames
E:/Downloads in E/HaxeFlixel/haxe/lib/flxanimate/3,0,4/flxanimate/frames/FlxAnimateFrames.hx:142: characters 21-27 : Field concat overrides parent class with different or incomplete type
E:/Downloads in E/HaxeFlixel/haxe/lib/flixel/5,8,0/flixel/graphics/frames/FlxAtlasFrames.hx:472: characters 18-24 : ... Base field is defined here
E:/Downloads in E/HaxeFlixel/haxe/lib/flxanimate/3,0,4/flxanimate/frames/FlxAnimateFrames.hx:142: characters 21-27 : ... Different number of function arguments
source/backend/Paths.hx:605: characters 7-18 : flxanimate.FlxAnimate has no field loadAtlasEx (Suggestion: loadAtlas)
source/objects/Character.hx:304: characters 87-101 : flxanimate.animate.FlxAnim has no field lastPlayedAnim
source/objects/Character.hx:335: characters 20-26 : flxanimate.animate.FlxAnim has no field resume
source/psychlua/FunkinLua.hx:280: lines 280-283 : Int should be Bool
source/psychlua/FunkinLua.hx:280: lines 280-283 : ... For function argument 'f'

error please help

source/psychlua/CallbackHandler.hx:55: characters 18-33 : Class<llua.Lua_helper> has no field sendErrorsToLua export/debug/windows/haxe/ApplicationMain.hx:153: characters 5-36 : ...


Docker hub availability

Is the rancher agent for arm, v1.2.6 available on docker hub ?

Unfortunately not, we only have v1.2.1 available on dockerhub - for aarch64 only.

Are you planning to provide a newer version?

Not at the moment, Rancher moves at a very fast pace - we were working with rancher v1.5.8 at the time and the latest version of rancher is already 1.6.10.
Proper tooling around Rancher ecosystem need to be implemented in order to automate this. The variant we have require some manual work - building and adding aarch64 binaries to images, etc - which makes hard to keep up with Rancher release cycle.

What tooling is needed in detail?


Fix typo in example

what

Fixes typo in example module syntax

why

Consistent spelling is good

references

n/a

@dotCipher @RothAndrew -- any thoughts on this one?

/test all

derp. guess I'm not a codeowner. Summoning @cloudposse/engineering or @cloudposse/approvers

Just getting back to this one since I see it still open... @RothAndrew I'm not sure your tag worked, unfortunately.

/tests all

@jamengual any idea what has that last test taking so long? I wonder if it's reasonable to skip certain tests if only Markdown files are updated...

could you run precommit/terraform and commit all changes?
then I believe we will need Code owners review from someone in CloudPosse @max-lobur

/terratest

/terratest


How i automatize replacing of a file/document with a new version ?

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

azd version?

run azd version and copy paste here.

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

The prepdocs script can be used with modifiers to remove a file and add a new file, per the documentation here:
https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/docs/data_ingestion.md#indexing-additional-documents
Can you specify what you mean by automate?

You might also look into integrated vectorization if you're looking for scheduled ingestion. That's also detailed in the same guide.

may be a dumb or obvious question are there any additional costs that come along with scheduling ingestion for say every 2 hours?

Hi,
I read the following part from the guide.
To add additional documents to the index, first upload them to your data source (Blob storage, by default). Then navigate to the Azure portal, find the index, and run it. The Azure AI Search indexer will identify the new documents and ingest them into the index.
But I still couldn't do it. :(
I uploaded my own data into the blob. Then I opened it to the Search service via the portal.
How can I run the current index from the index page?
Isn't an indexer needed to update the existing index? When I want to create an indexer for the current index, what skillset should I create before this? (I added the relevant blob in the Data sources tab in the Search service.)


Implement nullability annotations to improve interoperability with Swift

https://developer.apple.com/swift/blog/?id=25

This is done in the v2 branch


print --auto

@rultor release, tag is 0.0.10

@rultor release, tag is 0.0.10

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.10

@yegor256 Done! FYI, the full log is here (took me 7min)


DOCS: conflict when using input field function

Using phoenix 1.7.14 I see an error when declaring an input in a form as follows:
<.form for={@form} phx-submit="save">
  <div class="w-4/5 mb-6">
    <.input field={@form[:name]} />
    <.button>Save</.button>
   </div>
</.form>

The error:
function input/1 imported from both PetalComponents.Input and MyAppWeb.CoreComponents, call is ambiguous

The latest Petal documentation doesn't mention the need to comment it out or remove:

To fix, go to the generated core_components.ex file and rename or remove the following functions: modal, button and table.

Petal version: {:petal_components, "~> 2.0.3"},,
Used phoenix version: {:phoenix, "~> 1.7.14"},
Elixir: elixir 1.17.1-otp-27

Good point. There is some documentation under the title "Phoenix 1.7 and above", but it doesn't mention the .input component. I'll update the documentation

The documentation has been updated 🙂


Adds base test fixture for WebMVC based tests

This will allow us to backfill tests that are in sleuth which require
different types of configuration classes.

fixed by https://github.com/openzipkin/brave/pull/643


Error Publishing to Government Cloud

I get 2002 and 1001 error messages when attempting to publish a bot to Azure Government cloud. Sometimes I get a 2002 error and sometimes I get a 1001 error:

This happens whether I am attempting to publish to new or existing Azure resources.  My login is authenticating successfully, as an attempt with an incorrect password yields a different error message.  The CLI also recognizes that I am already logged in.
My guess is that it is trying to find my subscriptions, but is looking in the wrong cloud environment.  I can build the project in VS and publish it using the CLI, but have to call "az cloud set --name AzureUSGovernment" prior to login.  Does there need to be a comparable switch/setting in Composer?

Hi @tconnellredmane. You are correct, and we are looking to prioritize this in a release in the near future. Please continue to use VS/CLI for the time being, and thank you for your patience.

@benbrown Is this already fixed in R14 with your tenant/auth improvements?

I'm not sure @GeoffCoxMSFT


[POC] Multiple Background Examples support

Add support for multiple background examples in a feature.
For eg.
Feature: Users sync

  Background:
    Given these users have been created with default attributes and without skeleton files:
    | username |
    | user0    |
    | user1    |

    Examples:
      | ocs-api-version | ocs-status-code |
      | 1               | 100             |

    @OCSv2
    Examples:
      | ocs-api-version | ocs-status-code |
      | 2               | 200             |

  Scenario Outline: Trying to sync a user when there is no external user backend
    Given using OCS API version "<ocs-api-version>"
    When the administrator tries to sync user "user0" using the OCS API
    Then the HTTP status code should be "200"
    And the OCS status code should be "<ocs-status-code>"
    And the OCS status message should be ""

  @TestAlsoOnExternalUserBackend
  Scenario Outline: Trying to sync a user as another user which does not exist
    Given using OCS API version "<ocs-api-version>"
    When user "user20" tries to sync user "user1" using the OCS API
    Then the HTTP status code should be "401"
    And the OCS status code should be "997"
    And the OCS status message should be "Unauthorised"

In this above example, running without any tags will just run both outlines with both tables from the background.
But if we run with tag @OCSv2 then both outlines will run with only the second table from the background.

LGTM :+1:


preprocess_weights_for_loading [bug]

When converting weights (InceptionV3 for instance), if the backend is switched, loading crashes with an error pointing to h5py. It looks like since the conv2d layers are usually included last in any h5 file they are the only ones who have their indexes checked but h5py expects the index to be > 0 as it is not the first layer in the file.
How to reproduce:

Change your backend to 'theano' in the keras.json config file
Run this script:

from keras.applications.inception_v3 import *
from keras.preprocessing import image
from keras.applications.imagenet_utils import decode_predictions
from keras import backend as K
import numpy as np

model = InceptionV3(weights='imagenet')

img_path = 'elephant.jpg'
img = image.load_img(img_path, target_size=(299, 299))
x = image.img_to_array(img)
x = np.expand_dims(x, axis=0)
x = preprocess_input(x)

preds = model.predict(x)
print('Predicted:', decode_predictions(preds))

With the Tensorflow backend this works fine and outputs the following:
[[(u'n02504458', u'African_elephant', 0.90738213)]]

However, if the backend is switched to Theano you get the following error (full traceback):
Using Theano backend.
Traceback (most recent call last):
  File "test.py", line 7, in <module>
    model = InceptionV3(weights='imagenet')
  File "/home/kent/.virtualenvs/keras2/local/lib/python2.7/site-packages/keras/applications/inception_v3.py", line 383, in InceptionV3
    model.load_weights(weights_path)
  File "/home/kent/.virtualenvs/keras2/local/lib/python2.7/site-packages/keras/engine/topology.py", line 2491, in load_weights
    load_weights_from_hdf5_group(f, self.layers)
  File "/home/kent/.virtualenvs/keras2/local/lib/python2.7/site-packages/keras/engine/topology.py", line 2893, in load_weights_from_hdf5_group
    original_backend)
  File "/home/kent/.virtualenvs/keras2/local/lib/python2.7/site-packages/keras/engine/topology.py", line 2833, in preprocess_weights_for_loading
    weights[0] = conv_utils.convert_kernel(weights[0])
  File "/home/kent/.virtualenvs/keras2/local/lib/python2.7/site-packages/keras/utils/conv_utils.py", line 86, in convert_kernel
    return np.copy(kernel[slices])
  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper (/tmp/pip-nCYoKW-build/h5py/_objects.c:2840)
  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper (/tmp/pip-nCYoKW-build/h5py/_objects.c:2798)
  File "/home/kent/.virtualenvs/keras2/local/lib/python2.7/site-packages/h5py/_hl/dataset.py", line 474, in __getitem__
    selection = sel.select(self.shape, args, dsid=self.id)
  File "/home/kent/.virtualenvs/keras2/local/lib/python2.7/site-packages/h5py/_hl/selections.py", line 90, in select
    sel[args]
  File "/home/kent/.virtualenvs/keras2/local/lib/python2.7/site-packages/h5py/_hl/selections.py", line 363, in __getitem__
    raise TypeError("Indexing elements must be in increasing order")
TypeError: Indexing elements must be in increasing order

This is definitely unexpected behavior, however, I'm unable to see an obvious issue anywhere in the Keras-2 changes which is why I'm posting it here.

[x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[x] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[x] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[x] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

Looks like the issue is that for whatever reason, the kernel to convert_kernel(kernel): gets passed as an hd5 dataset and NOT a numpy array as expected. Adding the line weights = np.array(weights) to the function preprocess_weights_for_loading in /keras/engine/topology.py fixes this issue, however, it is not very elegant.

After fixing the issue above, there are still issues with classification.
Given this image of an apple, the test script here outputs the following:
Tensorflow backend:
('Predicted:', [[(u'n07742313', u'Granny_Smith', 0.83470553), (u'n07753113', u'fig', 0.015361091), (u'n07747607', u'orange', 0.0053814445), (u'n07768694', u'pomegranate', 0.0048999568), (u'n12267677', u'acorn', 0.0044363858)]])

Theano backend:
('Predicted:', [[(u'n07753113', u'fig', 0.62229174), (u'n12267677', u'acorn', 0.1156325), (u'n07716906', u'spaghetti_squash', 0.048293442), (u'n07716358', u'zucchini', 0.016509119), (u'n07742313', u'Granny_Smith', 0.011241601)]])

Setup (separate virtual environment):
Keras 2.0.1
Tensorflow 1.0.1
Theano 0.9.0rc4

I'm getting an error in this script:
inc_model=InceptionV3(include_top=False,
                      weights='imagenet',
                      input_shape=(3, 150, 150))

Updates Keras/Theano did not help.
Edit topology.py сauses a lot of problems in the fit network

Am getting the same problem :
base_model = InceptionV3(weights='imagenet', include_top=False, input_shape=(299, 299, 3))
Error:
raise TypeError("Indexing elements must be in increasing order")
TypeError: Indexing elements must be in increasing order
Did you get any solution ?

I am also getting the exact same error with this line of code:
base_model = InceptionV3(weights='imagenet', include_top=False)
I am using theano backend (never installed tensorflow).  I have update to latest master branch code on both keras and theano from github.
Please help.


How to Load a Close-set Fine-tuned Grounding Dino into Grounded SAM

Hello. Following issue #241, I fine-tuned a grounding Dino via mmdetection for a close-set. However, when I try to load these fine-tuned weights into Grounded SAM, it says the model layers are different, and thus, loading fails. I'm curious if there's a way to successfully load a close-set fine-tuned Grounding Dino model into Grounded SAM. It seems it would be highly effective to be able to load the close-set model for downstream tasks. Thanks in advance for your response.

Same issue, look at the network defination is slightly different.

Hello, how to solve this problem?

Same issue, look at the network defination is slightly different.

Hey @rcao-hk and @shz0519, thanks for your attention, and sorry for the late reply. I’ve resolved the issue by creating new code to perform transfer learning on both models using MMDetection's Grounding DINO and the SAM model. I referenced the Grounded SAM code and modified the bounding box extraction with MMDetection's DINO model.

Hey @rcao-hk and @shz0519, thanks for your attention, and sorry for the late reply. I’ve resolved the issue by creating new code to perform transfer learning on both models using MMDetection's Grounding DINO and the SAM model. I referenced the Grounded SAM code and modified the bounding box extraction with MMDetection's DINO model.

Thank you for the information. If possible, could you share the method? I am facing the same issue and am struggling with it


Automatic casting of symbols to enums broken within blocks

There is a bug with automatic casting of symbols to enum values when using with self yield in a block.
Reproducible example:
enum BorderSide
  Top
  Bottom
end

class Table

  def config
    with self yield
  end

  def row(border : BorderSide)
    "bar"
  end
end

Table.new.config do
  row(border: :top)
end

with this error
undefined method 'row' for Table (with ... yield) and top-level (current scope)
its works fine when BorderSide::Top is used
Table.new.config do
  row(border: BorderSide::Top)
end

This is most likely related to with ... yield, not blocks in general.


Update plugin.py

Hi, I added temperature sensor for Shelly 1 PM

I'm reviewing the code but have conflicts
could you please merge it withe the latest version and send me a new pull request?


Item.create vs Item.create(Content)

Both called create, but one create content and the other an item.
Should we rename one? (createContent)

Makes sense to me


Missing a step

Your instructions may be missing a step, like the component configuration

Thanks for highlighting this. I will update the instructions before the next release.

Updated Readme.


flexible bit value reading with template in csv column

some registers are holding sub-byte sized values. ie, 1bit, 2 bits, 4 bits in size.
so on the todo to add support for reading theese values.
i'm thinking maybe this as the format. in the csv. its a bit of a hack
{#bits:variable_name},{#bits:variable_name},... to be put into either the data_type column or documented name column.
or alternatively, could do it via register numbers and data type, with b4 being the starting bit, and data type defining the size.
ie,
data type: 4bits, register 70
data type: 2bits, register 70.b4
data type: 4bits, register 70.b6
leaning towards data_type and register, as its more clean.

done, but untested. also added bit flag reading.
did test it with 16bit val, which is a no duh. so it should work....


Multi-player

Switch from everyone using :hanoi to a game per player
Remove games that haven't had any activity for an hour.
Recover front end from deleted games.
Show number of players online (either through number of games or presence)

Added in 0.8.0

Added in 0.8.0


It's only work on Chrome, firefox not work, could you fix that?

By the way, another question:
I'm using Vagrant, VM ip: <IP_ADDRESS>, it always says:
WebSocket connection to 'ws://<IP_ADDRESS>:2000/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED
So how to fix that too?

I'm using Vagrant box using puphpet, the environment is PHP 5.5 + ubuntu 12.04 + apache + mysql. My Vagrant VM ip: <IP_ADDRESS>, local machine hosts points to <IP_ADDRESS> reactphp.dev, and it works.
And, I'm using this code: https://github.com/muuknl/phprealtimechat to test websocket.
Then I visit reactphp.dev in my Chrome browser, and I start server script using: php bin/server.php, and after I type in the username I just got the error:
WebSocket connection to 'ws://<IP_ADDRESS>:2000/' failed: Error in connection establishment: net::ERR_CONNECTION_TIMED_OUT
It works well when I changed the websocket ip to `ws://<IP_ADDRESS>:2000/', but why it does not work if I change to my VM's ip address?

That happens because the 192.... address is an internal network address, therefor it cannot be found on the internet.

But I'm all under the local environment

try starting your socket server before visiting the webpage

I'm sure I started socket server.

I got the same problem. It doesn't work on me the 'ws://<IP_ADDRESS>:2000'. How to start the socket server?

make sure the port is open. There are a lot of resources online for port-forwarding


update staking docs to refer to PoP and slot selection

Closes: https://github.com/onflow/developer-portal/issues/476
Description
Updates the staking documentation to be more accurate to what has been added:

mentions staking key PoP
Mentions random slot selection
Removes some old information that isn't true or important anymore
Adds some clarifications

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

@a5chanda  @bthaile I got a bunch of link errors here that I'm confused about. Many of them were already there before and I didn't change them at all. This is my first time updating these docs since we migrated to the new docs site, so maybe that is part of the issue?


Doesn't run when navigating

GitHub edits the html dynamically instead of refreshing the page, so the userscript doesn't run in many cases

Visit https://github.com/SavageCore/github-comment-view-source/issues
Click on any issue

No view source button is added:

Thanks, can't believe I missed this!


Unable to install when using Python version 3.9.12

I'm trying to do a deep scan using piicatcher but cannot install piicatcher_spacy.
`
(venv) user$ pip3 install piicatcher_spacy
ERROR: Ignored the following versions that require a different python version: 0.1.0.dev3 Requires-Python >=3.6.2,<3.9; 0.1.1 Requires-Python >=3.6.2,<3.9
ERROR: Could not find a version that satisfies the requirement piicatcher_spacy (from versions: none)
ERROR: No matching distribution found for piicatcher_spacy
(venv) user$ python3 -V
Python 3.9.12
`
Is there an alternative approach for this?

@yjagdale - Can you take a look? This must be solved as piicatcher now supports 3.9 and 3.10 as well.
@ian-lewis-d which type of machine did you try the command on?


Getting error when i run this on cpu

It could be an issue related to the version of Pandas library you are currently using. Please try installing Pandas version 2.0.3.
pip install pandas==2.0.3

Yes i was able to fix this by downgrading pandas to version 1.5.3.
Thank you


Language support

After checking the code, I found that it is very troublesome to add translations. Could you please gather all the language entries into one file so that can add translations in a easy way?

no.


(docs) Do not store docs folder on master branch, generate gh-pages in CI

As a router developer, I do not want changes to docs folder to appear in PRs.
It would be nice to have a shell script for auto generating gh-pages branch to serve the docs, see this example from the older version of Polymer tools repo for some inspiration.

The long-term vision for the Vaadin Router documentation is to include it into the main Vaadin docs site: vaadin.com/docs.

The long-term vision for the Vaadin Router documentation is to include it into the main Vaadin docs site: vaadin.com/docs.


TypeScript issue

Hi, I'm getting this TypeScript error when importing the server part:

Linter doesn't complain when imported from next-client-cookies/dist/server, but that'll break the runtime.
Bit weird, since you are using TypeScript here and have things properly typed. Probably some sort of a misconfiguration here or on my end..
Here's my tsconfig.json:
{
  "compilerOptions": {
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "noEmit": true,
    "incremental": true,
    "esModuleInterop": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "jsx": "preserve",
    "baseUrl": ".",
    "paths": {
      "@/*": ["./*"]
    },
    "plugins": [
      {
        "name": "next"
      }
    ],
    "strictNullChecks": true
  },
  "include": ["next-env.d.ts", "**/*.ts", "**/*.tsx", ".next/types/**/*.ts", "constants.mjs"],
  "exclude": ["node_modules"]
}

I think it's related to old TypeScript version that can't read properly the package exports section.
I've released a fix under 1.0.1, please check if it works for you.


Maps SDK 8.2.0

This pr is to track the eventual upgrade of the plugins' dependency on the Maps SDK for Android to 8.2.0.

[x] 8.2.0-alpha.1
[x] 8.2.0-alpha.2
[x] 8.2.0-alpha.3
[ ] 8.2.0-beta.1
[ ] 8.2.0

cc @mapbox/maps-android

I didn't find any noteworthy issues with 8.2.0-alpha.1.  I assume that this is expected behavior from View-based annotations and another reason to stick with SymbolLayers:

I assume that this is expected behavior from View-based annotations

yes

No noteworthy issues with 8.2.0-alpha.2. There's a weird transition from the 2nd Style.MAPBOX_STREETS style to Style.LIGHT in some test app examples:

@pozdnyakov can ^^^ be caused by https://github.com/mapbox/mapbox-gl-native/pull/15016?

For 8.2.0-alpha.3 QA:

Style change flickering mentioned above, is still visible.

Source in use W-level log message

When style is changed in LineChangeActivity
2019-07-19 09:21:51.192 19245-19245/com.mapbox.mapboxsdk.plugins.testapp W/Mbgl: {plugins.testapp}[General]: Source 'mapbox-android-line-source-1' is in use, cannot remove

When style is changed in TrafficActivity
2019-07-19 09:28:57.650 19245-19245/com.mapbox.mapboxsdk.plugins.testapp W/Mbgl: {plugins.testapp}[General]: Source 'traffic' is in use, cannot remove

When style is changed in CircleActivity
2019-07-19 09:30:17.052 19245-19245/com.mapbox.mapboxsdk.plugins.testapp W/Mbgl: {plugins.testapp}[General]: Source 'mapbox-android-circle-source-2' is in use, cannot remove

and so on...

Could be good to enable buildings when BuildingActivity starts, rather than them not appearing and the user having to press the FAB.

Style change flickering mentioned above, is still visible.

Probably resolved with https://github.com/mapbox/mapbox-gl-native/pull/15127. Targetting 8.3.0 as of now.

Source in use W-level log message

Fixed in https://github.com/mapbox/mapbox-gl-native/pull/15191.

I did QA for alpha.3 but forgot to actually push my bump to this pr. QA was not done for beta.1.
I just bumped this pr to stable 8.2.0.


Huge performance difference in "Transformer-like" usage and "llama.cpp-like" usage

Llama.cpp-like usage by running scripts is really fast but when I try to use from ITREX library (which makes use of Transformer-like usage) the performance difference is huge. Here is the time take by each approach:

Transformer-like usage: >10 mins
Llama.cpp-like usage: ~2 mins

Here's how I am using them:
Transformer Usage:
model = AutoModelForCausalLM.from_pretrained(model_name, load_in_4bit=True)
outputs = model.generate(inputs, streamer=streamer, max_new_tokens=300)

Llama.cpp usage:
python neural-speed/scripts/inference.py --model_name mistral -m runtime_outs/ne_mistral_q_nf4_bestla_cfp32_g32.bin -c 512 -b 1024 -n 256 --color -p "She opened the door and see"

Is there something that I am missing?

@Ankur-singh Hi, please add the numactl if you use transformer-like APIs. It helps you get the expected performance.
For example:
nnumactl -m 0 -C 0-55 python_api_example_for_gguf.py
Actually you can set the numactl for both usages.
numactl -m 0 -C 0-55 python neural-speed/scripts/inference.py --model_name mistral -m runtime_outs/ne_mistral_q_nf4_bestla_cfp32_g32.bin -c 512 -b 1024 -n 256 --color -p "She opened the door and see"

Thanks @Zhenzhong1 worked like a charm.


enhancement(API): Env var based token for authentication

Tasks / Issue :construction: 🔧

[x] Checking the environment variables in the Azure folder
[x] Checking the environment variables in the civo  folder
[x] #78
[ ] #6

Solution :heavy_check_mark:

Note to reviewers :notebook:

Sorry for the delay in solving the issue as I'm having my college exams I'm not finding time to solve issue i will soon resolve the issues
Thank you

@Manda-supraja26 please sign your commits 😄

also squash and rebase with latest main branch

@Manda-supraja26 please sign your commits 😄

I was trying to push the code changes but couldn't do that

Not sure what problem are you facing

@AvineshTripathi if you get time could you review this pr

@Manda-supraja26 please sign your commits smile

I was trying to push the code changes but couldn't do that

can i get some help pls

You can ask in discord channel🙏

@Manda-supraja26 can you add information in the empty solution section in pr description

LGTM

@Manda-supraja26  this branch is not under the rules of auto-merge so here we need to merge when its ready
@AvineshTripathi do take a 📓

Thanks for creating this pr🙏

Thanks for creating this pr🙏

Thank you so much for merging my changes. I learned a lot.🙏🏽


Checkpoint 2

Peer Grade and Review (Required), Reviews will be done in Pairs-Trios

Task
Grade
Reviewer (Aadit)

Queue Hacks
0.95/1
0.95/1 - showed thorough understanding of how to use queues and implemented all the hacks and created a new queue manager to help complete the hacks

Stack T
0.9/1
0.9/1 - completed with a created hack

Github Commits
1/1
1/1 - shows participation in group and individual settings

Perform Queue Hacks in Data Structures lesson with your own Data

Hacks & Code Challenges Completed

PBL Work

Frontend - FRQ Test Site Page Set-up

Build Stack T and create your own stack hack

Created Stack T

[GitHub Commits for Last Month]

Personal
Team - Frontend
Team - Backend

2.85/3

Good Work
I like the work and initiative you have done on the frontend repo
Great Job on the hacks


Docker image for run

I'm trying to implement in a docker installing from docker Ctranslate2 image, however, I get a cuBLAS error to initialized.
Maybe someone have a list of requirements to run in ubuntu 20.04, I installed cuda toolkit, cuDNN 8, but the error continue.

Can you post your Dockerfile and how you run it?

I'm getting it to run ok with this Dockerfile:

FROM nvidia/cuda:11.7.1-cudnn8-runtime-ubuntu20.04
Install necessary dependencies
RUN apt-get update && apt-get install -y python3-pip
Set the working directory
WORKDIR /app
Copy the app code and requirements filed
COPY . /app
Install the app dependencies
RUN pip3 install --no-cache-dir -r requirements.txt

Build with:
docker build -t asr .
Run in interactive mode with:
docker run -it --rm --gpus '"device=0,1"' -v $(pwd):/app asr

Solved Thank you!


Generated Columns are updated

DictORM attempts to update a generated column.
CREATE TABLE foo (
   id SERIAL PRIMARY KEY,
   text_row TEXT,
   id_times_2 INT GENERATED AS (id * 2) STORED
);

>>> Foo = db['foo']
>>> row = Foo().flush()
>>> row['text_row'] = 'foobar'
>>> row.flush()
psycopg2.errors.SyntaxError: column "id_times_2" can only be updated to DEFAULT
DETAIL:  Column "id_times_2" is a generated column.

Fixed in #68


[Search] Behavior_RetryDelay failing in nightly runs

Search nightly test runs are failing with:

Error message
Expected a delay between 2000ms and 10000ms, not 219733
Expected: True
But was:  False
Stack trace
at Azure.Search.Documents.Tests.BatchingTests.Behavior_RetryDelay() in /Users/runner/work/1/s/sdk/search/Azure.Search.Documents/tests/Batching/BatchingTests.cs:line 1314
at Azure.Search.Documents.Tests.BatchingTests.Behavior_RetryDelay() in /Users/runner/work/1/s/sdk/search/Azure.Search.Documents/tests/Batching/BatchingTests.cs:line 1321
at Azure.Search.Documents.Tests.BatchingTests.Behavior_RetryDelay() in /Users/runner/work/1/s/sdk/search/Azure.Search.Documents/tests/Batching/BatchingTests.cs:line 1321
at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter1.BlockUntilCompleted()    at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)    at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func1 invoke)
at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.b__0()
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1659589&view=results

@jsquire for notification.

Nightly tests are running without any errors in the past 2-3 weeks, so closing this issue.
For more details see here: https://dev.azure.com/azure-sdk/internal/_build?definitionId=1594&_a=summary
Please create a new issue, if the tests are started to fail again.


The UI should display times in "Cambridge time"

Feel free to close if this is irrelevant but:
The UI should probably display events in the calendar in "Cambridge time".
If I change my timezone to France and manually change the time one hour back, the calendar is incorrect.
momentjs has a tz utility for this

Thanks for filing this, we hadn't gotten around to it yet but is a must have.

Reassigning to @Coenego for review.

The unit tests are currently failing. Back to @bp323 for fixing.

There seems to be a problem with the event popover as well. The event is displayed correctly on the calendar, but the start and end time for the event is not correct in the popover window. (Should be 9:00am - 12:00am).

The fix seems to be working. Changing the timezone on my machine doesn't trigger any odd behaviour on the calendar and dates are still displayed in Cambridge time.
The unit tests are currently failing though. Back to @bp323 for fixing.

Over to @Coenego for review.

Coverage remained the same at 100.0% when pulling 239f57c8c8002bbddf477dc44865f1255abe3175 on bp323:issue-417 into 140d3b28b915daf2506184b32f9a2b372cb29ce7 on CUL-DigitalServices:master.